- wine-devel - winehq.org

[PATCH] gdi32: Use the default fallback list before trying Fontconfig.
by Akihiro Sagawa 18 Dec '18

18 Dec '18

This fixes a regression introduced by 11ab9ff7b3c43bb41c0325fe9417b1d7f44ad516. It overrides default fallback font fix for Latin scripts as seen in 3b9669017bc8425f04860f331d8a1f689c8d63e0. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46285 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46244 Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/gdi32/freetype.c | 44 +++++++++++++++++++++++++++++--------------- 1 file changed, 29 insertions(+), 15 deletions(-)

2 2

[PATCH 1/3] shell32/shfldr_desktop: Use friendly name instead of GUID when SHGDN_FORADDRESSBAR is set
by Gabriel Ivăncescu 18 Dec '18

18 Dec '18

On Windows, SHGDN_FORPARSING returns the GUID name of a special folder, but only when SHGDN_FORADDRESSBAR is not set. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- This is actually needed for proper enumeration implementation of, for example, the ACList_ISF class (not implemented yet but it requires this patch). dlls/shell32/shfldr_desktop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/shell32/shfldr_desktop.c b/dlls/shell32/shfldr_desktop.c index d0b97c6..938871e 100644 --- a/dlls/shell32/shfldr_desktop.c +++ b/dlls/shell32/shfldr_desktop.c @@ -611,7 +611,7 @@ static HRESULT WINAPI ISF_Desktop_fnGetDisplayNameOf (IShellFolder2 * iface, if ((clsid = _ILGetGUIDPointer (pidl))) { - if (GET_SHGDN_FOR (dwFlags) & SHGDN_FORPARSING) + if ((GET_SHGDN_FOR (dwFlags) & (SHGDN_FORPARSING | SHGDN_FORADDRESSBAR)) == SHGDN_FORPARSING) { BOOL bWantsForParsing; -- 2.19.1

1 2

[PATCH] gdi32: Fix compile error with Fontconfig <= 2.10.91.
by Akihiro Sagawa 18 Dec '18

18 Dec '18

FC_PRGNAME is available since 2.10.92 and FC_NAMELANG is available since 2.9.91. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46296 Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/gdi32/freetype.c | 4 ++++ 1 file changed, 4 insertions(+)

3 2

[PATCH] po: Update Catalan translation
by Alex Henrie 18 Dec '18

18 Dec '18

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> --- po/ca.po | 632 +++++++++++++++++++++++-------------------------------- 1 file changed, 264 insertions(+), 368 deletions(-) diff --git a/po/ca.po b/po/ca.po index 302e4ad32b..5411e0d3c4 100644 --- a/po/ca.po +++ b/po/ca.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2017-12-31 19:18-0700\n" +"PO-Revision-Date: 2018-12-17 21:33-0700\n" "Last-Translator: Alex Henrie <alexhenrie24(a)gmail.com>\n" "Language-Team: Catalan\n" "Language: ca\n" @@ -13,7 +13,7 @@ msgstr "" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" "Plural-Forms: nplurals=2; plural=(n != 1);\n" -"X-Generator: Poedit 2.0.5\n" +"X-Generator: Poedit 2.2\n" #: appwiz.rc:58 msgid "Install/Uninstall" @@ -313,25 +313,23 @@ msgstr "S'està cancel·lant..." #: browseui.rc:29 msgid "%1!u! %2 remaining" -msgstr "" +msgstr "resten %1!u! %2" #: browseui.rc:30 msgid "%1!u! %2 and %3!u! %4 remaining" -msgstr "" +msgstr "resten %1!u! %2 i %3!u! %4" #: browseui.rc:31 -#, fuzzy -#| msgid "&Seconds" msgid "seconds" -msgstr "&Segons" +msgstr "segons" #: browseui.rc:32 msgid "minutes" -msgstr "" +msgstr "minuts" #: browseui.rc:33 msgid "hours" -msgstr "" +msgstr "hores" #: comctl32.rc:68 winefile.rc:157 msgid "Properties for %s" @@ -430,16 +428,12 @@ msgid "&Retry" msgstr "&Reintenta" #: comctl32.rc:62 -#, fuzzy -#| msgid "Hide &Tabs" msgid "Hide details" -msgstr "Amaga &pestanyes" +msgstr "Amaga els detalls" #: comctl32.rc:63 -#, fuzzy -#| msgid "Details" msgid "See details" -msgstr "Detalls" +msgstr "Mostra els detalls" #: comctl32.rc:31 cryptui.rc:235 regedit.rc:286 taskmgr.rc:434 winedbg.rc:61 #: winedbg.rc:76 wordpad.rc:180 @@ -1038,7 +1032,7 @@ msgstr "" #: comdlg32.rc:67 msgid "A printer error occurred." -msgstr "S'ha produït un error d'impressora." +msgstr "Ha ocorregut un error d'impressora." #: comdlg32.rc:68 msgid "No default printer defined." @@ -2212,7 +2206,7 @@ msgstr "" #: cryptui.rc:273 cryptui.rc:69 msgid "Select Certificate Store" -msgstr "Seleccionar el magatzem de certificats" +msgstr "Seleccioneu un magatzem de certificats" #: cryptui.rc:276 msgid "Select the certificate store you want to use:" @@ -2463,16 +2457,12 @@ msgid "You have successfully completed the Certificate Export Wizard." msgstr "Heu acabat amb èxit l'Assistent d'Exportació de Certificats." #: cryptui.rc:456 cryptui.rc:179 -#, fuzzy -#| msgid "Select Certificate Store" msgid "Select Certificate" -msgstr "Seleccionar el magatzem de certificats" +msgstr "Seleccionar el certificat" #: cryptui.rc:459 -#, fuzzy -#| msgid "Select the certificate store you want to use:" msgid "Select a certificate you want to use" -msgstr "Seleccioneu el magatzem de certificats que voleu utilitzar:" +msgstr "Seleccioneu el magatzem de certificats que voleu utilitzar" #: cryptui.rc:30 cryptui.rc:93 msgid "Certificate" @@ -3007,20 +2997,16 @@ msgid "Note: The private key for this certificate is not exportable." msgstr "Nota: La clau privada d'aquest certificat no és exportable." #: cryptui.rc:177 -#, fuzzy -#| msgid "I&ntended purpose:" msgid "Intended Use" -msgstr "&Finalitat prevista:" +msgstr "Finalitat prevista" #: cryptui.rc:178 shell32.rc:152 msgid "Location" msgstr "Ubicació" #: cryptui.rc:180 -#, fuzzy -#| msgid "Select Certificate Store" msgid "Select a certificate" -msgstr "Seleccionar el magatzem de certificats" +msgstr "Seleccioneu un certificat" #: cryptui.rc:181 winefile.rc:102 winhlp32.rc:110 winhlp32.rc:85 msgid "Not yet implemented" @@ -3514,46 +3500,36 @@ msgid "Publishers..." msgstr "Publicadors..." #: inetcpl.rc:123 -#, fuzzy -#| msgid "LAN Connection" msgid "Connections" -msgstr "Connexió LAN" +msgstr "Connexions" #: inetcpl.rc:125 -#, fuzzy -#| msgid "Wine configuration" msgid "Automatic configuration" -msgstr "Configuració del Wine" +msgstr "Configuració automàtica" #: inetcpl.rc:126 msgid "Use Web Proxy Auto-Discovery (WPAD)" -msgstr "" +msgstr "Utilitza autodescobriment de servidor intermediari web (WPAD)" #: inetcpl.rc:127 msgid "Use Proxy Auto-Config (PAC) script" -msgstr "" +msgstr "Utilitza script de autoconfiguració de servidor intermediari (PAC)" #: inetcpl.rc:128 inetcpl.rc:132 -#, fuzzy -#| msgid "Address" msgid "Address:" -msgstr "Adreça" +msgstr "Adreça:" #: inetcpl.rc:130 -#, fuzzy -#| msgid "&Local server" msgid "Proxy server" -msgstr "Servidor &local" +msgstr "Servidor intermediari" #: inetcpl.rc:131 msgid "Use a proxy server" -msgstr "" +msgstr "Utilitza un servidor intermediari" #: inetcpl.rc:134 -#, fuzzy -#| msgid "No Ports" msgid "Port:" -msgstr "Cap port" +msgstr "Port:" #: inetcpl.rc:31 msgid "Internet Settings" @@ -3816,18 +3792,20 @@ msgid "" "'writable' attribute on the property descriptor cannot be set to 'true' on " "this object" msgstr "" +"no es pot establir l'atribut 'writable' en el descriptor de propietat com a " +"'true' en aquest objecte" #: jscript.rc:70 msgid "Cannot redefine non-configurable property '|'" -msgstr "" +msgstr "No es pot redefinir la propietat no configurable '|'" #: jscript.rc:71 msgid "Cannot modify non-writable property '|'" -msgstr "" +msgstr "No es pot modificar la propietat no escrivible '|'" #: jscript.rc:72 msgid "Property cannot have both accessors and a value" -msgstr "" +msgstr "La propietat no pot tenir ambdós mètodes d'accés i un valor" #: ../../include/wine/wine_common_ver.rc:129 msgid "Wine kernel DLL" @@ -6800,10 +6778,8 @@ msgid "Connection reset by peer.\n" msgstr "Un igual ha restablert la connexió.\n" #: winerror.mc:3760 -#, fuzzy -#| msgid "Message 0x%1 not found in file %2.\n" msgid "No Signature found in file.\n" -msgstr "No s'ha trobat el missatge 0x%1 en el fitxer %2.\n" +msgstr "No s'ha trobat cap signatura en el fitxer.\n" #: localspl.rc:31 localui.rc:31 winspool.rc:30 msgid "Local Port" @@ -8651,10 +8627,8 @@ msgid "&Browse..." msgstr "&Navega..." #: shell32.rc:355 shell32.rc:384 -#, fuzzy -#| msgid "File type" msgid "File type:" -msgstr "Tipus de fitxer" +msgstr "Tipus de fitxer:" #: shell32.rc:359 shell32.rc:392 urlmon.rc:37 explorer.rc:32 msgid "Location:" @@ -8665,16 +8639,12 @@ msgid "Size:" msgstr "Mida:" #: shell32.rc:365 shell32.rc:398 -#, fuzzy -#| msgid "Creation date" msgid "Creation date:" -msgstr "Data de creació" +msgstr "Data de creació:" #: shell32.rc:369 shell32.rc:406 -#, fuzzy -#| msgid "&Attributes:" msgid "Attributes:" -msgstr "&Atributs:" +msgstr "Atributs:" #: shell32.rc:371 shell32.rc:408 winefile.rc:174 msgid "H&idden" @@ -8685,28 +8655,20 @@ msgid "&Archive" msgstr "&Arxiu" #: shell32.rc:386 -#, fuzzy -#| msgid "Open:" msgid "Open with:" -msgstr "Obre:" +msgstr "Obre amb:" #: shell32.rc:389 -#, fuzzy -#| msgid "Change &Icon..." msgid "&Change..." -msgstr "&Canvia d'icona..." +msgstr "&Canvia..." #: shell32.rc:400 -#, fuzzy -#| msgid "Modified" msgid "Last modified:" -msgstr "Modificat" +msgstr "Última modificació:" #: shell32.rc:402 -#, fuzzy -#| msgid "Last Change:" msgid "Last accessed:" -msgstr "Últim canvi:" +msgstr "Últim accés:" #: shell32.rc:138 shell32.rc:142 winefile.rc:108 msgid "Size" @@ -9131,811 +9093,791 @@ msgstr "Seleccionar font" #: tzres.rc:82 msgid "China Standard Time" -msgstr "" +msgstr "Hora estàndard de la Xina" #: tzres.rc:83 msgid "China Daylight Time" -msgstr "" +msgstr "Hora d'estiu de la Xina" #: tzres.rc:160 msgid "North Asia Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àsia del Nord" #: tzres.rc:161 msgid "North Asia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àsia del Nord" #: tzres.rc:104 msgid "Georgian Standard Time" -msgstr "" +msgstr "Hora estàndard de Geòrgia" #: tzres.rc:105 msgid "Georgian Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Geòrgia" #: tzres.rc:152 msgid "Nepal Standard Time" -msgstr "" +msgstr "Hora estàndard del Nepal" #: tzres.rc:153 msgid "Nepal Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Nepal" #: tzres.rc:60 msgid "Cape Verde Standard Time" -msgstr "" +msgstr "Hora estàndard de Cap Verd" #: tzres.rc:61 msgid "Cape Verde Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Cap Verd" #: tzres.rc:74 -#, fuzzy -#| msgid "Central European" msgid "Central European Standard Time" -msgstr "Europeu central" +msgstr "Hora estàndard de l'Europa Central" #: tzres.rc:75 -#, fuzzy -#| msgid "Central European" msgid "Central European Daylight Time" -msgstr "Europeu central" +msgstr "Hora d'estiu de l'Europa Central" #: tzres.rc:140 msgid "Morocco Standard Time" -msgstr "" +msgstr "Hora estàndard del Marroc" #: tzres.rc:141 msgid "Morocco Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Marroc" #: tzres.rc:72 -#, fuzzy -#| msgid "Central European" msgid "Central Europe Standard Time" -msgstr "Europeu central" +msgstr "Hora estàndard de l'Europa Central" #: tzres.rc:73 -#, fuzzy -#| msgid "Central European" msgid "Central Europe Daylight Time" -msgstr "Europeu central" +msgstr "Hora d'estiu de l'Europa Central" #: tzres.rc:118 msgid "Iran Standard Time" -msgstr "" +msgstr "Hora estàndard d'Iran" #: tzres.rc:119 msgid "Iran Daylight Time" -msgstr "" +msgstr "Hora d'estiu d'Iran" #: tzres.rc:150 msgid "Namibia Standard Time" -msgstr "" +msgstr "Hora estàndard de Namíbia" #: tzres.rc:151 msgid "Namibia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Namíbia" #: tzres.rc:200 msgid "Tonga Standard Time" -msgstr "" +msgstr "Hora estàndard de Tonga" #: tzres.rc:201 msgid "Tonga Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Tonga" #: tzres.rc:144 msgid "Mountain Standard Time (Mexico)" -msgstr "" +msgstr "Hora estàndard de les muntanyes (Mèxic)" #: tzres.rc:145 msgid "Mountain Daylight Time (Mexico)" -msgstr "" +msgstr "Hora d'estiu de les muntanyes (Mèxic)" #: tzres.rc:106 -#, fuzzy -#| msgid "&Standard bar" msgid "GMT Standard Time" -msgstr "Barra &estàndard" +msgstr "Hora estàndard GMT" #: tzres.rc:107 msgid "GMT Daylight Time" -msgstr "" +msgstr "Hora d'estiu GMT" #: tzres.rc:68 msgid "Central Asia Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àsia Central" #: tzres.rc:69 msgid "Central Asia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àsia Central" #: tzres.rc:38 msgid "Arabic Standard Time" -msgstr "" +msgstr "Hora estàndard àrab" #: tzres.rc:39 msgid "Arabic Daylight Time" -msgstr "" +msgstr "Hora d'estiu àrab" #: tzres.rc:132 msgid "Magadan Standard Time" -msgstr "" +msgstr "Hora estàndard de Magadan" #: tzres.rc:133 msgid "Magadan Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Magadan" #: tzres.rc:156 msgid "Newfoundland Standard Time" -msgstr "" +msgstr "Hora estàndard de Terranova" #: tzres.rc:157 msgid "Newfoundland Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Terranova" #: tzres.rc:224 msgid "West Pacific Standard Time" -msgstr "" +msgstr "Hora estàndard del Pacífic Occidental" #: tzres.rc:225 msgid "West Pacific Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Pacífic Occidental" #: tzres.rc:164 msgid "Pacific Standard Time" -msgstr "" +msgstr "Hora estàndard del Pacífic" #: tzres.rc:165 msgid "Pacific Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Pacífic" #: tzres.rc:48 msgid "Azerbaijan Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Azerbaidjan" #: tzres.rc:49 msgid "Azerbaijan Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Azerbaidjan" #: tzres.rc:182 msgid "Samoa Standard Time" -msgstr "" +msgstr "Hora estàndard de Samoa" #: tzres.rc:183 msgid "Samoa Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Samoa" #: tzres.rc:124 msgid "Kaliningrad Standard Time" -msgstr "" +msgstr "Hora estàndard de Kaliningrad" #: tzres.rc:125 msgid "Kaliningrad Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Kaliningrad" #: tzres.rc:166 msgid "Pacific Standard Time (Mexico)" -msgstr "" +msgstr "Hora estàndard del Pacífic (Mèxic)" #: tzres.rc:167 msgid "Pacific Daylight Time (Mexico)" -msgstr "" +msgstr "Hora d'estiu del Pacífic (Mèxic)" #: tzres.rc:136 msgid "Middle East Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Orient Mitjà" #: tzres.rc:137 msgid "Middle East Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Orient Mitjà" #: tzres.rc:198 msgid "Tokyo Standard Time" -msgstr "" +msgstr "Hora estàndard de Tokyo" #: tzres.rc:199 msgid "Tokyo Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Tokyo" #: tzres.rc:130 msgid "Line Islands Standard Time" -msgstr "" +msgstr "Hora estàndard de les Illes de la Línia" #: tzres.rc:131 msgid "Line Islands Daylight Time" -msgstr "" +msgstr "Hora d'estiu de les Illes de la Línia" #: tzres.rc:122 msgid "Jordan Standard Time" -msgstr "" +msgstr "Hora estàndard de Jordània" #: tzres.rc:123 msgid "Jordan Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Jordània" #: tzres.rc:78 msgid "Central Standard Time" -msgstr "" +msgstr "Hora estàndard central" #: tzres.rc:79 msgid "Central Daylight Time" -msgstr "" +msgstr "Hora d'estiu central" #: tzres.rc:50 msgid "Azores Standard Time" -msgstr "" +msgstr "Hora estàndard dels Açores" #: tzres.rc:51 msgid "Azores Daylight Time" -msgstr "" +msgstr "Hora d'estiu dels Açores" #: tzres.rc:158 msgid "North Asia East Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àsia del Norest" #: tzres.rc:159 msgid "North Asia East Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àsia del Norest" #: tzres.rc:40 msgid "Argentina Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Argentina" #: tzres.rc:41 msgid "Argentina Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Argentina" #: tzres.rc:146 msgid "Myanmar Standard Time" -msgstr "" +msgstr "Hora estàndard de Birmània" #: tzres.rc:147 msgid "Myanmar Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Birmània" #: tzres.rc:210 tzres.rc:211 msgid "Coordinated Universal Time" -msgstr "" +msgstr "Temps universal coordinat" #: tzres.rc:116 msgid "India Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Índia" #: tzres.rc:117 msgid "India Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Índia" #: tzres.rc:112 -#, fuzzy -#| msgid "&Standard bar" msgid "GTB Standard Time" -msgstr "Barra &estàndard" +msgstr "Hora estàndard GTB" #: tzres.rc:113 msgid "GTB Daylight Time" -msgstr "" +msgstr "Hora d'estiu GTB" #: tzres.rc:202 msgid "Turkey Standard Time" -msgstr "" +msgstr "Hora estàndard de Turquia" #: tzres.rc:203 msgid "Turkey Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Turquia" #: tzres.rc:100 msgid "Fiji Standard Time" -msgstr "" +msgstr "Hora estàndard de Fiji" #: tzres.rc:101 msgid "Fiji Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Fiji" #: tzres.rc:58 msgid "Canada Central Standard Time" -msgstr "" +msgstr "Hora estàndard del Canadà Central" #: tzres.rc:59 msgid "Canada Central Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Canadà Central" #: tzres.rc:194 msgid "Taipei Standard Time" -msgstr "" +msgstr "Hora estàndard de Taipei" #: tzres.rc:195 msgid "Taipei Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Taipei" #: tzres.rc:220 msgid "W. Europe Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Europa Occidental" #: tzres.rc:221 msgid "W. Europe Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Europa Occidental" #: tzres.rc:138 msgid "Montevideo Standard Time" -msgstr "" +msgstr "Hora estàndard de Montevideo" #: tzres.rc:139 msgid "Montevideo Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Montevideo" #: tzres.rc:168 msgid "Pakistan Standard Time" -msgstr "" +msgstr "Hora estàndard del Pakistan" #: tzres.rc:169 msgid "Pakistan Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Pakistan" #: tzres.rc:62 msgid "Caucasus Standard Time" -msgstr "" +msgstr "Hora estàndard del Caucas" #: tzres.rc:63 msgid "Caucasus Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Caucas" #: tzres.rc:46 msgid "AUS Eastern Standard Time" -msgstr "" +msgstr "Hora estàndard oriental AUS" #: tzres.rc:47 msgid "AUS Eastern Daylight Time" -msgstr "" +msgstr "Hora d'estiu oriental AUS" #: tzres.rc:148 msgid "N. Central Asia Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àsia del Centre-Nord" #: tzres.rc:149 msgid "N. Central Asia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àsia del Centre-Nord" #: tzres.rc:94 msgid "Eastern Standard Time" -msgstr "" +msgstr "Hora estàndard oriental" #: tzres.rc:95 msgid "Eastern Daylight Time" -msgstr "" +msgstr "Hora d'estiu oriental" #: tzres.rc:80 msgid "Central Standard Time (Mexico)" -msgstr "" +msgstr "Hora estàndard central (Mèxic)" #: tzres.rc:81 msgid "Central Daylight Time (Mexico)" -msgstr "" +msgstr "Hora d'estiu central (Mèxic)" #: tzres.rc:42 msgid "Atlantic Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Atlàntic" #: tzres.rc:43 msgid "Atlantic Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Atlàntic" #: tzres.rc:142 msgid "Mountain Standard Time" -msgstr "" +msgstr "Hora estàndard de les muntanyes" #: tzres.rc:143 msgid "Mountain Daylight Time" -msgstr "" +msgstr "Hora d'estiu de les muntanyes" #: tzres.rc:206 msgid "US Eastern Standard Time" -msgstr "" +msgstr "Hora estàndard oriental EEUU" #: tzres.rc:207 msgid "US Eastern Daylight Time" -msgstr "" +msgstr "Hora d'estiu oriental EEUU" #: tzres.rc:196 msgid "Tasmania Standard Time" -msgstr "" +msgstr "Hora estàndard de Tasmània" #: tzres.rc:197 msgid "Tasmania Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Tasmània" #: tzres.rc:66 msgid "Central America Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àmerica Central" #: tzres.rc:67 msgid "Central America Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àmerica Central" #: tzres.rc:208 msgid "US Mountain Standard Time" -msgstr "" +msgstr "Hora estàndard de les muntanyes EEUU" #: tzres.rc:209 msgid "US Mountain Daylight Time" -msgstr "" +msgstr "Hora d'estiu de les muntanyes EEUU" #: tzres.rc:188 msgid "South Africa Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àfrica del Sud" #: tzres.rc:189 msgid "South Africa Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àfrica del Sud" #: tzres.rc:64 msgid "Cen. Australia Standard Time" -msgstr "" +msgstr "Hora estàndard d'Austràlia Central" #: tzres.rc:65 msgid "Cen. Australia Daylight Time" -msgstr "" +msgstr "Hora d'estiu d'Austràlia Central" #: tzres.rc:190 msgid "Sri Lanka Standard Time" -msgstr "" +msgstr "Hora estàndard de Sri Lanka" #: tzres.rc:191 msgid "Sri Lanka Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Sri Lanka" #: tzres.rc:30 msgid "Afghanistan Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Afganistan" #: tzres.rc:31 msgid "Afghanistan Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Afganistan" #: tzres.rc:226 msgid "Yakutsk Standard Time" -msgstr "" +msgstr "Hora estàndard de Iakutsk" #: tzres.rc:227 msgid "Yakutsk Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Iakutsk" #: tzres.rc:176 msgid "SA Eastern Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àmerica del Sud-Est" #: tzres.rc:177 msgid "SA Eastern Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àmerica del Sud-Est" #: tzres.rc:34 msgid "Arab Standard Time" -msgstr "" +msgstr "Hora estàndard àrab" #: tzres.rc:35 msgid "Arab Daylight Time" -msgstr "" +msgstr "Hora d'estiu àrab" #: tzres.rc:36 msgid "Arabian Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àrabia" #: tzres.rc:37 msgid "Arabian Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àrabia" #: tzres.rc:174 msgid "Russian Standard Time" -msgstr "" +msgstr "Hora estàndard de Rússia" #: tzres.rc:175 msgid "Russian Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Rússia" #: tzres.rc:172 msgid "Romance Standard Time" -msgstr "" +msgstr "Hora estàndard romànic" #: tzres.rc:173 msgid "Romance Daylight Time" -msgstr "" +msgstr "Hora d'estiu romànic" #: tzres.rc:98 msgid "Ekaterinburg Standard Time" -msgstr "" +msgstr "Hora estàndard d'Iekaterinburg" #: tzres.rc:99 msgid "Ekaterinburg Daylight Time" -msgstr "" +msgstr "Hora d'estiu d'Iekaterinburg" #: tzres.rc:192 msgid "Syria Standard Time" -msgstr "" +msgstr "Hora estàndard de Síria" #: tzres.rc:193 msgid "Syria Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Síria" #: tzres.rc:44 msgid "AUS Central Standard Time" -msgstr "" +msgstr "Hora estàndard central AUS" #: tzres.rc:45 msgid "AUS Central Daylight Time" -msgstr "" +msgstr "Hora d'estiu central AUS" #: tzres.rc:110 msgid "Greenwich Standard Time" -msgstr "" +msgstr "Hora estàndard de Greenwich" #: tzres.rc:111 msgid "Greenwich Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Greenwich" #: tzres.rc:204 msgid "Ulaanbaatar Standard Time" -msgstr "" +msgstr "Hora estàndard d'Ulan Bator" #: tzres.rc:205 msgid "Ulaanbaatar Daylight Time" -msgstr "" +msgstr "Hora d'estiu d'Ulan Bator" #: tzres.rc:120 msgid "Israel Standard Time" -msgstr "" +msgstr "Hora estàndard d'Israel" #: tzres.rc:121 msgid "Israel Daylight Time" -msgstr "" +msgstr "Hora d'estiu d'Israel" #: tzres.rc:54 msgid "Bangladesh Standard Time" -msgstr "" +msgstr "Hora estàndard de Bangla Desh" #: tzres.rc:55 msgid "Bangladesh Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Bangla Desh" #: tzres.rc:178 msgid "SA Pacific Standard Time" -msgstr "" +msgstr "Hora estàndard del Pacífic de l'Amèrica del Sud" #: tzres.rc:179 msgid "SA Pacific Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Pacífic de l'Amèrica del Sud" #: tzres.rc:222 msgid "West Asia Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àsia Occidental" #: tzres.rc:223 msgid "West Asia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àsia Occidental" #: tzres.rc:32 msgid "Alaskan Standard Time" -msgstr "" +msgstr "Hora estàndard d'Alaska" #: tzres.rc:33 msgid "Alaskan Daylight Time" -msgstr "" +msgstr "Hora d'estiu d'Alaska" #: tzres.rc:170 msgid "Paraguay Standard Time" -msgstr "" +msgstr "Hora estàndard del Paraguai" #: tzres.rc:171 msgid "Paraguay Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Paraguai" #: tzres.rc:84 -#, fuzzy -#| msgid "Date and time" msgid "Dateline Standard Time" -msgstr "Data i hora" +msgstr "Hora estàndard de la línia de canvi de data" #: tzres.rc:85 msgid "Dateline Daylight Time" -msgstr "" +msgstr "Hora d'estiu de la línia de canvi de data" #: tzres.rc:128 msgid "Libya Standard Time" -msgstr "" +msgstr "Hora estàndard de Líbia" #: tzres.rc:129 msgid "Libya Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Líbia" #: tzres.rc:52 msgid "Bahia Standard Time" -msgstr "" +msgstr "Hora estàndard de Bahia" #: tzres.rc:53 msgid "Bahia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Bahia" #: tzres.rc:212 msgid "Venezuela Standard Time" -msgstr "" +msgstr "Hora estàndard de Veneçuela" #: tzres.rc:213 msgid "Venezuela Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Veneçuela" #: tzres.rc:114 msgid "Hawaiian Standard Time" -msgstr "" +msgstr "Hora estàndard de Hawaii" #: tzres.rc:115 msgid "Hawaiian Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Hawaii" #: tzres.rc:184 msgid "SE Asia Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àsia del Sud-Est" #: tzres.rc:185 msgid "SE Asia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àsia del Sud-Est" #: tzres.rc:154 msgid "New Zealand Standard Time" -msgstr "" +msgstr "Hora estàndard de Nova Zelanda" #: tzres.rc:155 msgid "New Zealand Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Nova Zelanda" #: tzres.rc:70 msgid "Central Brazilian Standard Time" -msgstr "" +msgstr "Hora estàndard del Brasil Central" #: tzres.rc:71 msgid "Central Brazilian Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Brasil Central" #: tzres.rc:56 msgid "Belarus Standard Time" -msgstr "" +msgstr "Hora estàndard de Bielorússia" #: tzres.rc:57 msgid "Belarus Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Bielorússia" #: tzres.rc:180 msgid "SA Western Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àmerica del Sud-Oest" #: tzres.rc:181 msgid "SA Western Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àmerica del Sud-Oest" #: tzres.rc:108 msgid "Greenland Standard Time" -msgstr "" +msgstr "Hora estàndard de Groenlàndia" #: tzres.rc:109 msgid "Greenland Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Groenlàndia" #: tzres.rc:92 -#, fuzzy -#| msgid "Date and time" msgid "Easter Island Standard Time" -msgstr "Data i hora" +msgstr "Hora estàndard de l'Illa de Pasqua" #: tzres.rc:93 -#, fuzzy -#| msgid "Date and time" msgid "Easter Island Daylight Time" -msgstr "Data i hora" +msgstr "Hora d'estiu de l'Illa de Pasqua" #: tzres.rc:96 msgid "Egypt Standard Time" -msgstr "" +msgstr "Hora estàndard d'Egipte" #: tzres.rc:97 msgid "Egypt Daylight Time" -msgstr "" +msgstr "Hora d'estiu d'Egipte" #: tzres.rc:134 msgid "Mauritius Standard Time" -msgstr "" +msgstr "Hora estàndard de Maurici" #: tzres.rc:135 msgid "Mauritius Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Maurici" #: tzres.rc:214 msgid "Vladivostok Standard Time" -msgstr "" +msgstr "Hora estàndard de Vladivostok" #: tzres.rc:215 msgid "Vladivostok Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Vladivostok" #: tzres.rc:186 msgid "Singapore Standard Time" -msgstr "" +msgstr "Hora estàndard de Singapur" #: tzres.rc:187 msgid "Singapore Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Singapur" #: tzres.rc:126 msgid "Korea Standard Time" -msgstr "" +msgstr "Hora estàndard de Corea" #: tzres.rc:127 msgid "Korea Daylight Time" -msgstr "" +msgstr "Hora d'estiu de Corea" #: tzres.rc:86 msgid "E. Africa Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àfrica Oriental" #: tzres.rc:87 msgid "E. Africa Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àfrica Oriental" #: tzres.rc:102 -#, fuzzy -#| msgid "&Standard bar" msgid "FLE Standard Time" -msgstr "Barra &estàndard" +msgstr "Hora estàndard FLE" #: tzres.rc:103 msgid "FLE Daylight Time" -msgstr "" +msgstr "Hora d'estiu FLE" #: tzres.rc:90 msgid "E. South America Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àmerica del Sudest" #: tzres.rc:91 msgid "E. South America Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àmerica del Sudest" #: tzres.rc:76 msgid "Central Pacific Standard Time" -msgstr "" +msgstr "Hora estàndard del Pacífic Central" #: tzres.rc:77 msgid "Central Pacific Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Pacífic Central" #: tzres.rc:218 msgid "W. Central Africa Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Àfrica del Centre-Oest" #: tzres.rc:219 msgid "W. Central Africa Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Àfrica del Centre-Oest" #: tzres.rc:162 msgid "Pacific SA Standard Time" -msgstr "" +msgstr "Hora estàndard del Pacífic de l'Amèrica del Sud" #: tzres.rc:163 msgid "Pacific SA Daylight Time" -msgstr "" +msgstr "Hora d'estiu del Pacífic de l'Amèrica del Sud" #: tzres.rc:88 msgid "E. Australia Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Austràlia Oriental" #: tzres.rc:89 msgid "E. Australia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Austràlia Oriental" #: tzres.rc:216 msgid "W. Australia Standard Time" -msgstr "" +msgstr "Hora estàndard de l'Austràlia Occidental" #: tzres.rc:217 msgid "W. Australia Daylight Time" -msgstr "" +msgstr "Hora d'estiu de l'Austràlia Occidental" #: urlmon.rc:32 wininet.rc:77 msgid "Security Warning" @@ -10126,70 +10068,61 @@ msgstr "" "Hi ha almenys un problema de seguretat no especificat amb aquest certificat." #: winineterror.mc:26 -#, fuzzy -#| msgid "Service request timeout.\n" msgid "The request has timed out.\n" -msgstr "S'ha superat el temps d'espera de sol·licitud de servei.\n" +msgstr "S'ha superat el temps d'espera de la sol·licitud.\n" #: winineterror.mc:31 -#, fuzzy -#| msgid "A printer error occurred." msgid "An internal error has occurred.\n" -msgstr "S'ha produït un error d'impressora." +msgstr "Ha ocorregut un error intern.\n" #: winineterror.mc:36 -#, fuzzy -#| msgid "Path is invalid.\n" msgid "The URL is invalid.\n" -msgstr "El camí no és vàlid.\n" +msgstr "L'URL no és vàlid.\n" #: winineterror.mc:41 msgid "The URL scheme could not be recognized or is not supported.\n" -msgstr "" +msgstr "No s'ha pogut reconèixer l'esquema URL o no és compatible.\n" #: winineterror.mc:46 -#, fuzzy -#| msgid "The username could not be found.\n" msgid "The server name could not be resolved.\n" -msgstr "No s'ha pogut trobar el nom d'usuari.\n" +msgstr "No s'ha pogut resoldre el nom de servidor.\n" #: winineterror.mc:51 -#, fuzzy -#| msgid "The user profile is invalid.\n" msgid "The requested operation is invalid.\n" -msgstr "El perfil d'usuari no és vàlid.\n" +msgstr "L'operació demanada no és vàlida.\n" #: winineterror.mc:56 msgid "" "The operation was canceled, usually because the handle on which the request " "was operating was closed before the operation completed.\n" msgstr "" +"S'ha cancel·lat l'operació, usualment perquè s'ha tancat l'identificador en " +"el qual la sol·licitud s'estava operant abans que es completés l'operació.\n" #: winineterror.mc:61 -#, fuzzy -#| msgid "The profile could not be added.\n" msgid "The requested item could not be located.\n" -msgstr "No s'ha pogut afegir el perfil.\n" +msgstr "No s'ha pogut ubicar l'element demanat.\n" #: winineterror.mc:66 -#, fuzzy -#| msgid "Can't connect to the LDAP server" msgid "The attempt to connect to the server failed.\n" -msgstr "No es pot connectar al servidor LDAP" +msgstr "L'intent de connectar al servidor ha fallat.\n" #: winineterror.mc:71 msgid "The connection with the server has been terminated.\n" -msgstr "" +msgstr "S'ha terminat la connexió amb el servidor.\n" #: winineterror.mc:76 msgid "" "SSL certificate date that was received from the server is bad. The " "certificate is expired.\n" msgstr "" +"La data del certificat SSL que s'ha rebut del servidor està malmesa. El " +"certificat està caducat.\n" #: winineterror.mc:81 msgid "SSL certificate common name (host name field) is incorrect.\n" msgstr "" +"El nom comú del certificat SSL (camp de nom de màquina) és incorrecte.\n" #: winmm.rc:32 msgid "The specified command was carried out." @@ -10430,7 +10363,7 @@ msgstr "El controlador de dispositiu no està llest." #: winmm.rc:78 msgid "A problem occurred in initializing MCI. Try restarting Windows." msgstr "" -"Hi ha hagut un problema en inicialitzar l'MCI. Proveu reiniciar el Windows." +"Ha ocorregut un problema en inicialitzar l'MCI. Proveu reiniciar el Windows." #: winmm.rc:79 msgid "" @@ -10450,7 +10383,7 @@ msgid "" "Errors occurred in more than one device. Specify each command and device " "separately to determine which devices caused the error." msgstr "" -"S'han produït errors en més d'un dispositiu. Especifiqueu cada ordre i " +"Han ocorregut errors en més d'un dispositiu. Especifiqueu cada ordre i " "dispositiu separadament per a determinar quins dispositius han causat " "l'error." @@ -10764,7 +10697,7 @@ msgstr "" #: winmm.rc:130 msgid "An error occurred with the specified port." -msgstr "S'ha ocorregut un error amb el port especificat." +msgstr "Ha ocorregut un error amb el port especificat." #: winmm.rc:133 msgid "" @@ -12041,10 +11974,8 @@ msgid "Error: Invalid option '%c'.\n" msgstr "Error: L'opció '%c' no és vàlida.\n" #: hostname.rc:32 -#, fuzzy -#| msgid "Error: Could not find process \"%1\".\n" msgid "Error: Could not get hostname: %u.\n" -msgstr "Error: No s'ha pogut trobar el procés \"%1\".\n" +msgstr "Error: No s'ha pogut obtenir el nom de màquina: %u.\n" #: hostname.rc:33 msgid "" @@ -12245,7 +12176,7 @@ msgstr "Desconnectat" #: net.rc:50 msgid "A network error occurred" -msgstr "Hi ha hagut un error de xarxa" +msgstr "Ha ocorregut un error de xarxa" #: net.rc:51 msgid "Connection is being made" @@ -13266,16 +13197,16 @@ msgid "" "reg: Unable to delete all registry values in '%1'. An unexpected error " "occurred.\n" msgstr "" -"reg: No s'ha pogut suprimir tots els valors de registre en '%1'. Un error " -"inesperat ha ocorregut.\n" +"reg: No s'ha pogut suprimir tots els valors de registre en '%1'. Ha " +"ocorregut un error inesperat.\n" #: reg.rc:59 msgid "" "reg: Unable to complete the specified operation. An unexpected error " "occurred.\n" msgstr "" -"reg: No s'ha pogut completar l'operació especificada. Un error inesperat ha " -"ocorregut.\n" +"reg: No s'ha pogut completar l'operació especificada. Ha ocorregut un error " +"inesperat.\n" #: reg.rc:60 msgid "Search complete. Number of matches found: %1!d!\n" @@ -13852,10 +13783,8 @@ msgid "Confirm Value Delete" msgstr "Confirmar eliminació de valor" #: regedit.rc:210 -#, fuzzy -#| msgid "Are you sure you want to delete the registry value '%1'?" msgid "Are you sure you want to delete the selected registry value?" -msgstr "Esteu segur que voleu suprimir el valor de registre '%1'?" +msgstr "Esteu segur que voleu suprimir el valor de registre seleccionat?" #: regedit.rc:216 msgid "Search complete. The string '%1' was not found." @@ -15236,11 +15165,11 @@ msgstr "Co&lor:" #: winecfg.rc:304 msgid "MIME types" -msgstr "" +msgstr "Tipus MIME" #: winecfg.rc:305 msgid "Manage file &associations" -msgstr "" +msgstr "Gestiona &associacions de fitxer" #: winecfg.rc:308 msgid "Folders" @@ -15857,6 +15786,8 @@ msgid "" "A program on your system has crashed, but WineDbg was unable to attach to " "the process to obtain a backtrace." msgstr "" +"Un program en el vostre sistema ha tingut una pana, però el WineDbg no ha " +"pogut enganxar-se al procès per a obtenir una traça inversa." #: winedbg.rc:41 msgid "(unidentified)" @@ -16716,41 +16647,6 @@ msgid "D" msgstr "D" #: xcopy.rc:81 -#, fuzzy -#| msgid "" -#| "XCOPY - Copies source files or directory trees to a destination.\n" -#| "\n" -#| "Syntax:\n" -#| "XCOPY source [destination] [/I] [/S] [/Q] [/F] [/L] [/W] [/T] [/N] [/U]\n" -#| "\t [/R] [/H] [/C] [/P] [/A] [/M] [/E] [/D] [/Y] [/-Y]\n" -#| "\n" -#| "Where:\n" -#| "\n" -#| "[/I] Assume directory if destination does not exist and copying two or\n" -#| "\tmore files.\n" -#| "[/S] Copy directories and subdirectories.\n" -#| "[/E] Copy directories and subdirectories, including any empty ones.\n" -#| "[/Q] Do not list names during copy, that is be quiet.\n" -#| "[/F] Show full source and destination names during copy.\n" -#| "[/L] Simulate operation, showing names which would be copied.\n" -#| "[/W] Prompts before beginning the copy operation.\n" -#| "[/T] Creates empty directory structure but does not copy files.\n" -#| "[/Y] Suppress prompting when overwriting files.\n" -#| "[/-Y] Enable prompting when overwriting files.\n" -#| "[/P] Prompts on each source file before copying.\n" -#| "[/N] Copy using short names.\n" -#| "[/U] Copy only files which already exist in destination.\n" -#| "[/R] Overwrite any read only files.\n" -#| "[/H] Include hidden and system files in the copy.\n" -#| "[/C] Continue even if an error occurs during the copy.\n" -#| "[/A] Only copy files with archive attribute set.\n" -#| "[/M] Only copy files with archive attribute set, removes the\n" -#| "\tarchive attribute.\n" -#| "[/D | /D:m-d-y] Copy new files or those modified after the supplied " -#| "date.\n" -#| "\t\tIf no date is supplied, only copy if destination is older\n" -#| "\t\tthan source.\n" -#| "\n" msgid "" "XCOPY - Copies source files or directory trees to a destination.\n" "\n" @@ -16789,8 +16685,8 @@ msgstr "" "XCOPY - Copia fitxers o arbres de directori a una destinació.\n" "\n" "Sintaxi:\n" -"XCOPY origen [destinació] [/I] [/S] [/Q] [/F] [/L] [/W] [/T] [/N] [/U] [/R]\n" -"\t [/H] [/C] [/P] [/A] [/M] [/E] [/D] [/Y] [/-Y]\n" +"XCOPY origen [destinació] [/I] [/S] [/Q] [/F] [/L] [/W] [/T] [/N] [/U]\n" +"\t [/R] [/H] [/C] [/P] [/A] [/M] [/E] [/D] [/Y] [/-Y]\n" "\n" "On:\n" "\n" @@ -16810,7 +16706,7 @@ msgstr "" "[/U] Copia només els fitxers que ja existeixin a la destinació.\n" "[/R] Sobreescriu qualsevol fitxer de només lectura.\n" "[/H] Inclou els fitxers amagats i els fitxers de sistema en la còpia.\n" -"[/C] Continuar inclús si es produeix un error durant la còpia.\n" +"[/C] Continuar inclús si ocorr un error durant la còpia.\n" "[/A] Només copiar els fitxers amb l'atribut d'arxiu establert.\n" "[/M] Només copiar els fitxers amb l'atribut d'arxiu establert, elimina\n" "\tl'atribut d'arxiu.\n" -- 2.20.1

1 0

[PATCH v2] setupapi/tests: Fix return value checking.
by Zhiyi Zhang 18 Dec '18

18 Dec '18

SetupDiCreateDeviceInfoList returns INVALID_HANDLE_VALUE(~0) on error instead of NULL. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- v2: No need to check for null as well. Thanks to Zeb. dlls/setupapi/tests/devinst.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/setupapi/tests/devinst.c b/dlls/setupapi/tests/devinst.c index bfffcb9c32..4abc188ea4 100644 --- a/dlls/setupapi/tests/devinst.c +++ b/dlls/setupapi/tests/devinst.c @@ -125,13 +125,13 @@ static void test_create_device_list_ex(void) "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoListExW(NULL, NULL, NULL, NULL); - ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.", GetLastError()); ret = SetupDiDestroyDeviceInfoList(set); ok(ret, "Failed to destroy device list, error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoListExW(NULL, NULL, empty, NULL); - ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.", GetLastError()); ret = SetupDiDestroyDeviceInfoList(set); ok(ret, "Failed to destroy device list, error %#x.\n", GetLastError()); @@ -286,7 +286,7 @@ static void test_device_info(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device info, error %#x.\n", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device info, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiCreateDeviceInfoA(set, "Root\\LEGACY_BOGUS\\0000", NULL, NULL, NULL, 0, NULL); @@ -366,7 +366,7 @@ static void test_device_info(void) SetupDiDestroyDeviceInfoList(set); set = SetupDiCreateDeviceInfoList(NULL, NULL); - ok(set != NULL, "Failed to create device info, error %#x.\n", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device info, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiCreateDeviceInfoA(set, "Root\\LEGACY_BOGUS\\0000", NULL, NULL, NULL, 0, NULL); @@ -427,7 +427,7 @@ static void test_get_device_instance_id(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiGetDeviceInstanceIdA(set, NULL, NULL, 0, NULL); @@ -485,7 +485,7 @@ static void test_register_device_info(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiRegisterDeviceInfo(set, NULL, 0, NULL, NULL, NULL); @@ -528,7 +528,7 @@ static void test_register_device_info(void) SetupDiDestroyDeviceInfoList(set); set = SetupDiGetClassDevsA(&guid, NULL, NULL, 0); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); check_device_info(set, 0, &guid, "Root\\LEGACY_BOGUS\\0000"); check_device_info(set, 1, &guid, "Root\\LEGACY_BOGUS\\0002"); @@ -596,7 +596,7 @@ static void test_device_iface(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiCreateDeviceInterfaceA(set, NULL, NULL, NULL, 0, NULL); @@ -697,7 +697,7 @@ static void test_device_iface_detail(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiGetDeviceInterfaceDetailA(set, NULL, NULL, 0, NULL, NULL); @@ -787,7 +787,7 @@ static void test_device_key(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); res = RegOpenKeyW(HKEY_LOCAL_MACHINE, bogus, &key); ok(res != ERROR_SUCCESS, "Key should not exist.\n"); -- 2.19.2

2 1

[PATCH 1/5] d3d9: Support drawing from D3DPOOL_SYSTEMMEM vertex buffers.
by Matteo Bruni 17 Dec '18

17 Dec '18

From: Henri Verbeet <hverbeet(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45486 Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> --- dlls/d3d9/buffer.c | 24 ++++++++++++++-- dlls/d3d9/d3d9_private.h | 4 +++ dlls/d3d9/device.c | 60 ++++++++++++++++++++++++++++++++++++---- dlls/d3d9/stateblock.c | 17 ++++++++++++ 4 files changed, 96 insertions(+), 9 deletions(-) diff --git a/dlls/d3d9/buffer.c b/dlls/d3d9/buffer.c index 02b3570402f..15b7e2bdbce 100644 --- a/dlls/d3d9/buffer.c +++ b/dlls/d3d9/buffer.c @@ -59,6 +59,8 @@ static ULONG WINAPI d3d9_vertexbuffer_AddRef(IDirect3DVertexBuffer9 *iface) IDirect3DDevice9Ex_AddRef(buffer->parent_device); wined3d_mutex_lock(); wined3d_buffer_incref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_incref(buffer->draw_buffer); wined3d_mutex_unlock(); } @@ -78,6 +80,8 @@ static ULONG WINAPI d3d9_vertexbuffer_Release(IDirect3DVertexBuffer9 *iface) wined3d_mutex_lock(); wined3d_buffer_decref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_decref(buffer->draw_buffer); wined3d_mutex_unlock(); /* Release the device last, as it may cause the device to be destroyed. */ @@ -274,6 +278,7 @@ static const struct wined3d_parent_ops d3d9_vertexbuffer_wined3d_parent_ops = HRESULT vertexbuffer_init(struct d3d9_vertexbuffer *buffer, struct d3d9_device *device, UINT size, UINT usage, DWORD fvf, D3DPOOL pool) { + const struct wined3d_parent_ops *parent_ops = &d3d9_null_wined3d_parent_ops; struct wined3d_buffer_desc desc; HRESULT hr; @@ -299,15 +304,28 @@ HRESULT vertexbuffer_init(struct d3d9_vertexbuffer *buffer, struct d3d9_device * desc.byte_width = size; desc.usage = usage & WINED3DUSAGE_MASK; - desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + desc.bind_flags = 0; desc.access = wined3daccess_from_d3dpool(pool, usage) | WINED3D_RESOURCE_ACCESS_MAP_R | WINED3D_RESOURCE_ACCESS_MAP_W; desc.misc_flags = 0; desc.structure_byte_stride = 0; + if (desc.access & WINED3D_RESOURCE_ACCESS_GPU) + { + desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + parent_ops = &d3d9_vertexbuffer_wined3d_parent_ops; + } + wined3d_mutex_lock(); - hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, - &d3d9_vertexbuffer_wined3d_parent_ops, &buffer->wined3d_buffer); + hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, parent_ops, &buffer->wined3d_buffer); + if (SUCCEEDED(hr) && !(desc.access & WINED3D_RESOURCE_ACCESS_GPU)) + { + desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + desc.access = WINED3D_RESOURCE_ACCESS_GPU; + if (FAILED(hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, + &d3d9_vertexbuffer_wined3d_parent_ops, &buffer->draw_buffer))) + wined3d_buffer_decref(buffer->wined3d_buffer); + } wined3d_mutex_unlock(); if (FAILED(hr)) { diff --git a/dlls/d3d9/d3d9_private.h b/dlls/d3d9/d3d9_private.h index d6155eba60b..8647aac4af1 100644 --- a/dlls/d3d9/d3d9_private.h +++ b/dlls/d3d9/d3d9_private.h @@ -42,6 +42,7 @@ #define D3D9_MAX_VERTEX_SHADER_CONSTANTF 256 #define D3D9_MAX_TEXTURE_UNITS 20 +#define D3D9_MAX_STREAMS 16 #define D3DPRESENTFLAGS_MASK 0x00000fffu @@ -105,6 +106,8 @@ struct d3d9_device BOOL in_destruction; BOOL in_scene; BOOL has_vertex_declaration; + BOOL recording; + unsigned int upload_map; unsigned int max_user_clip_planes; @@ -181,6 +184,7 @@ struct d3d9_vertexbuffer struct d3d9_resource resource; struct wined3d_buffer *wined3d_buffer; IDirect3DDevice9Ex *parent_device; + struct wined3d_buffer *draw_buffer; DWORD fvf; }; diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index f19e2ae6f65..7c488bfd601 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -974,6 +974,7 @@ static HRESULT d3d9_device_reset(struct d3d9_device *device, if (!extended) { + device->recording = FALSE; wined3d_device_set_render_state(device->wined3d_device, WINED3D_RS_ZENABLE, !!swapchain_desc.enable_auto_depth_stencil); } @@ -2317,7 +2318,8 @@ static HRESULT WINAPI d3d9_device_BeginStateBlock(IDirect3DDevice9Ex *iface) TRACE("iface %p.\n", iface); wined3d_mutex_lock(); - hr = wined3d_device_begin_stateblock(device->wined3d_device); + if (SUCCEEDED(hr = wined3d_device_begin_stateblock(device->wined3d_device))) + device->recording = TRUE; wined3d_mutex_unlock(); return hr; @@ -2340,6 +2342,7 @@ static HRESULT WINAPI d3d9_device_EndStateBlock(IDirect3DDevice9Ex *iface, IDire WARN("Failed to end the state block, hr %#x.\n", hr); return hr; } + device->recording = FALSE; if (!(object = heap_alloc_zero(sizeof(*object)))) { @@ -2688,10 +2691,38 @@ static void d3d9_generate_auto_mipmaps(struct d3d9_device *device) } } +static void d3d9_device_upload_sysmem_buffers(struct d3d9_device *device, + unsigned int start_vertex, unsigned int vertex_count) +{ + struct wined3d_box box = {0, 0, 0, 1, 0, 1}; + struct d3d9_vertexbuffer *d3d9_buffer; + unsigned int i, offset, stride, map; + struct wined3d_buffer *dst_buffer; + HRESULT hr; + + map = device->upload_map; + while (map) + { + i = ffs(map) - 1; + map ^= 1u << i; + + if (FAILED(hr = wined3d_device_get_stream_source(device->wined3d_device, i, &dst_buffer, &offset, &stride))) + ERR("Failed to get stream source.\n"); + d3d9_buffer = wined3d_buffer_get_parent(dst_buffer); + box.left = offset + start_vertex * stride; + box.right = box.left + vertex_count * stride; + if (FAILED(hr = wined3d_device_copy_sub_resource_region(device->wined3d_device, + wined3d_buffer_get_resource(dst_buffer), 0, box.left, 0, 0, + wined3d_buffer_get_resource(d3d9_buffer->wined3d_buffer), 0, &box, 0))) + ERR("Failed to update buffer.\n"); + } +} + static HRESULT WINAPI d3d9_device_DrawPrimitive(IDirect3DDevice9Ex *iface, D3DPRIMITIVETYPE primitive_type, UINT start_vertex, UINT primitive_count) { struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); + unsigned int vertex_count; HRESULT hr; TRACE("iface %p, primitive_type %#x, start_vertex %u, primitive_count %u.\n", @@ -2704,10 +2735,11 @@ static HRESULT WINAPI d3d9_device_DrawPrimitive(IDirect3DDevice9Ex *iface, WARN("Called without a valid vertex declaration set.\n"); return D3DERR_INVALIDCALL; } + vertex_count = vertex_count_from_primitive_count(primitive_type, primitive_count); + d3d9_device_upload_sysmem_buffers(device, start_vertex, vertex_count); d3d9_generate_auto_mipmaps(device); wined3d_device_set_primitive_type(device->wined3d_device, primitive_type, 0); - hr = wined3d_device_draw_primitive(device->wined3d_device, start_vertex, - vertex_count_from_primitive_count(primitive_type, primitive_count)); + hr = wined3d_device_draw_primitive(device->wined3d_device, start_vertex, vertex_count); if (SUCCEEDED(hr)) d3d9_rts_flag_auto_gen_mipmap(device); wined3d_mutex_unlock(); @@ -2734,6 +2766,7 @@ static HRESULT WINAPI d3d9_device_DrawIndexedPrimitive(IDirect3DDevice9Ex *iface WARN("Called without a valid vertex declaration set.\n"); return D3DERR_INVALIDCALL; } + d3d9_device_upload_sysmem_buffers(device, min_vertex_idx, vertex_count); d3d9_generate_auto_mipmaps(device); wined3d_device_set_base_vertex_index(device->wined3d_device, base_vertex_idx); wined3d_device_set_primitive_type(device->wined3d_device, primitive_type, 0); @@ -3378,6 +3411,7 @@ static HRESULT WINAPI d3d9_device_SetStreamSource(IDirect3DDevice9Ex *iface, { struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); struct d3d9_vertexbuffer *buffer_impl = unsafe_impl_from_IDirect3DVertexBuffer9(buffer); + struct wined3d_buffer *wined3d_buffer; HRESULT hr; TRACE("iface %p, stream_idx %u, buffer %p, offset %u, stride %u.\n", @@ -3386,14 +3420,28 @@ static HRESULT WINAPI d3d9_device_SetStreamSource(IDirect3DDevice9Ex *iface, wined3d_mutex_lock(); if (!stride) { - struct wined3d_buffer *wined3d_buffer; unsigned int cur_offset; hr = wined3d_device_get_stream_source(device->wined3d_device, stream_idx, &wined3d_buffer, &cur_offset, &stride); } - hr = wined3d_device_set_stream_source(device->wined3d_device, stream_idx, - buffer_impl ? buffer_impl->wined3d_buffer : NULL, offset, stride); + + if (!buffer_impl) + wined3d_buffer = NULL; + else if (buffer_impl->draw_buffer) + wined3d_buffer = buffer_impl->draw_buffer; + else + wined3d_buffer = buffer_impl->wined3d_buffer; + + hr = wined3d_device_set_stream_source(device->wined3d_device, stream_idx, wined3d_buffer, offset, stride); + if (SUCCEEDED(hr) && !device->recording) + { + if (buffer_impl && buffer_impl->draw_buffer) + device->upload_map |= (1u << stream_idx); + else + device->upload_map &= ~(1u << stream_idx); + } + wined3d_mutex_unlock(); return hr; diff --git a/dlls/d3d9/stateblock.c b/dlls/d3d9/stateblock.c index 62b3bacb28d..c5306fd80b3 100644 --- a/dlls/d3d9/stateblock.c +++ b/dlls/d3d9/stateblock.c @@ -108,11 +108,28 @@ static HRESULT WINAPI d3d9_stateblock_Capture(IDirect3DStateBlock9 *iface) static HRESULT WINAPI d3d9_stateblock_Apply(IDirect3DStateBlock9 *iface) { struct d3d9_stateblock *stateblock = impl_from_IDirect3DStateBlock9(iface); + struct wined3d_buffer *wined3d_buffer; + struct d3d9_vertexbuffer *buffer; + unsigned int i, offset, stride; + struct d3d9_device *device; + HRESULT hr; TRACE("iface %p.\n", iface); wined3d_mutex_lock(); wined3d_stateblock_apply(stateblock->wined3d_stateblock); + device = impl_from_IDirect3DDevice9Ex(stateblock->parent_device); + device->upload_map = 0; + for (i = 0; i < D3D9_MAX_STREAMS; ++i) + { + if (FAILED(hr = wined3d_device_get_stream_source(device->wined3d_device, + i, &wined3d_buffer, &offset, &stride))) + continue; + if (!wined3d_buffer || !(buffer = wined3d_buffer_get_parent(wined3d_buffer))) + continue; + if (buffer->draw_buffer) + device->upload_map |= 1u << i; + } wined3d_mutex_unlock(); return D3D_OK; -- 2.18.1

6 17

[PATCH] devenum/tests: Fix some more memory leaks (Valgrind).
by Zebediah Figura 17 Dec '18

17 Dec '18

Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/devenum/tests/devenum.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/devenum/tests/devenum.c b/dlls/devenum/tests/devenum.c index 10ca27a614..e31f65c653 100644 --- a/dlls/devenum/tests/devenum.c +++ b/dlls/devenum/tests/devenum.c @@ -95,6 +95,7 @@ static void test_devenum(IBindCtx *bind_ctx) if (winetest_debug > 1) trace("%s %s:\n", wine_dbgstr_guid(&cat_guid), wine_dbgstr_w(V_BSTR(&var))); + VariantClear(&var); IPropertyBag_Release(prop_bag); IMoniker_Release(moniker); @@ -688,6 +689,7 @@ static BOOL CALLBACK test_dsound(GUID *guid, const WCHAR *desc, const WCHAR *mod ok(!lstrcmpW(buffer, V_BSTR(&var)), "expected %s, got %s\n", wine_dbgstr_w(buffer), wine_dbgstr_w(V_BSTR(&var))); + VariantClear(&var); IPropertyBag_Release(prop_bag); IMoniker_Release(mon); IParseDisplayName_Release(parser); -- 2.19.2

1 0

[PATCH vkd3d 2/2] vkd3d-shader: Implement DXBC checksum for root signatures.
by Józef Kucia 17 Dec '18

17 Dec '18

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- MD5 code assumes that sizeof(unsigned int) == 4. --- libs/vkd3d-shader/checksum.c | 73 ++++++++++++++++-------- libs/vkd3d-shader/dxbc.c | 6 +- libs/vkd3d-shader/vkd3d_shader_private.h | 6 +- tests/d3d12.c | 7 +-- 4 files changed, 56 insertions(+), 36 deletions(-) diff --git a/libs/vkd3d-shader/checksum.c b/libs/vkd3d-shader/checksum.c index d2929da92635..b9a7140221e0 100644 --- a/libs/vkd3d-shader/checksum.c +++ b/libs/vkd3d-shader/checksum.c @@ -35,11 +35,15 @@ #include "vkd3d_shader_private.h" +#define DXBC_CHECKSUM_BLOCK_SIZE 64 + +STATIC_ASSERT(sizeof(unsigned int) == 4); + struct md5_ctx { unsigned int i[2]; unsigned int buf[4]; - unsigned char in[64]; + unsigned char in[DXBC_CHECKSUM_BLOCK_SIZE]; unsigned char digest[16]; }; @@ -163,7 +167,7 @@ static void byte_reverse(unsigned char *buf, unsigned longs) * Start MD5 accumulation. Set bit count to 0 and buffer to mysterious * initialization constants. */ -void md5_init(struct md5_ctx *ctx) +static void md5_init(struct md5_ctx *ctx) { ctx->buf[0] = 0x67452301; ctx->buf[1] = 0xefcdab89; @@ -177,7 +181,7 @@ void md5_init(struct md5_ctx *ctx) * Update context to reflect the concatenation of another buffer full * of bytes. */ -void md5_update(struct md5_ctx *ctx, const unsigned char *buf, unsigned int len) +static void md5_update(struct md5_ctx *ctx, const unsigned char *buf, unsigned int len) { unsigned int t; @@ -194,7 +198,7 @@ void md5_update(struct md5_ctx *ctx, const unsigned char *buf, unsigned int len) if (t) { unsigned char *p = (unsigned char *)ctx->in + t; - t = 64 - t; + t = DXBC_CHECKSUM_BLOCK_SIZE - t; if (len < t) { @@ -212,27 +216,25 @@ void md5_update(struct md5_ctx *ctx, const unsigned char *buf, unsigned int len) } /* Process data in 64-byte chunks */ - while (len >= 64) + while (len >= DXBC_CHECKSUM_BLOCK_SIZE) { - memcpy(ctx->in, buf, 64); + memcpy(ctx->in, buf, DXBC_CHECKSUM_BLOCK_SIZE); byte_reverse(ctx->in, 16); md5_transform(ctx->buf, (unsigned int *)ctx->in); - buf += 64; - len -= 64; + buf += DXBC_CHECKSUM_BLOCK_SIZE; + len -= DXBC_CHECKSUM_BLOCK_SIZE; } /* Handle any remaining bytes of data. */ memcpy(ctx->in, buf, len); } -/* - * Final wrapup - pad to 64-byte boundary with the bit pattern - * 1 0* (64-bit count of bits processed, MSB-first) - */ -void md5_final(struct md5_ctx *ctx) +static void dxbc_checksum_final(struct md5_ctx *ctx) { + unsigned int padding; + unsigned int length; unsigned int count; unsigned char *p; @@ -243,34 +245,57 @@ void md5_final(struct md5_ctx *ctx) always at least one byte free */ p = ctx->in + count; *p++ = 0x80; + ++count; /* Bytes of padding needed to make 64 bytes */ - count = 64 - 1 - count; + padding = DXBC_CHECKSUM_BLOCK_SIZE - count; /* Pad out to 56 mod 64 */ - if (count < 8) + if (padding < 8) { /* Two lots of padding: Pad the first block to 64 bytes */ - memset(p, 0, count); + memset(p, 0, padding); byte_reverse(ctx->in, 16); md5_transform(ctx->buf, (unsigned int *)ctx->in); - /* Now fill the next block with 56 bytes */ - memset(ctx->in, 0, 56); + /* Now fill the next block */ + memset(ctx->in, 0, DXBC_CHECKSUM_BLOCK_SIZE); } else { - /* Pad block to 56 bytes */ - memset(p, 0, count - 8); - } + /* Make place for bitcount at the beginning of the block */ + memmove(&ctx->in[4], ctx->in, count); - byte_reverse(ctx->in, 14); + /* Pad block to 60 bytes */ + memset(p + 4, 0, padding - 4); + } /* Append length in bits and transform */ - ((unsigned int *)ctx->in)[14] = ctx->i[0]; - ((unsigned int *)ctx->in)[15] = ctx->i[1]; + length = ctx->i[0]; + memcpy(&ctx->in[0], &length, sizeof(length)); + byte_reverse(&ctx->in[4], 14); + length = ctx->i[0] >> 2 | 0x1; + memcpy(&ctx->in[DXBC_CHECKSUM_BLOCK_SIZE - 4], &length, sizeof(length)); md5_transform(ctx->buf, (unsigned int *)ctx->in); byte_reverse((unsigned char *)ctx->buf, 4); memcpy(ctx->digest, ctx->buf, 16); } + +#define DXBC_CHECKSUM_SKIP_BYTE_COUNT 20 + +void vkd3d_compute_dxbc_checksum(const void *dxbc, size_t size, uint32_t checksum[4]) +{ + const uint8_t *ptr = dxbc; + struct md5_ctx ctx; + + assert(size > DXBC_CHECKSUM_SKIP_BYTE_COUNT); + ptr += DXBC_CHECKSUM_SKIP_BYTE_COUNT; + size -= DXBC_CHECKSUM_SKIP_BYTE_COUNT; + + md5_init(&ctx); + md5_update(&ctx, ptr, size); + dxbc_checksum_final(&ctx); + + memcpy(checksum, ctx.digest, sizeof(ctx.digest)); +} diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index b199749064f5..4b36ea644b84 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -2389,7 +2389,7 @@ static int shader_write_root_signature_header(struct root_signature_writer_conte if (!write_dword(context, TAG_DXBC)) return VKD3D_ERROR_OUT_OF_MEMORY; - WARN("DXBC checksum is not implemented.\n"); + /* The checksum is computed when all data is generated. */ if (!write_dwords(context, 4, 0x00000000)) return VKD3D_ERROR_OUT_OF_MEMORY; @@ -2596,6 +2596,7 @@ int vkd3d_shader_serialize_root_signature(const struct vkd3d_root_signature_desc { struct root_signature_writer_context context; size_t total_size, chunk_size; + uint32_t checksum[4]; int ret; TRACE("root_signature %p, version %#x, dxbc %p.\n", root_signature, version, dxbc); @@ -2628,5 +2629,8 @@ int vkd3d_shader_serialize_root_signature(const struct vkd3d_root_signature_desc dxbc->code = context.data; dxbc->size = total_size; + vkd3d_compute_dxbc_checksum(dxbc->code, dxbc->size, checksum); + memcpy((uint32_t *)dxbc->code + 1, checksum, sizeof(checksum)); + return VKD3D_OK; } diff --git a/libs/vkd3d-shader/vkd3d_shader_private.h b/libs/vkd3d-shader/vkd3d_shader_private.h index e0fad6852e53..bf2f45571375 100644 --- a/libs/vkd3d-shader/vkd3d_shader_private.h +++ b/libs/vkd3d-shader/vkd3d_shader_private.h @@ -815,11 +815,7 @@ int vkd3d_dxbc_compiler_generate_spirv(struct vkd3d_dxbc_compiler *compiler, struct vkd3d_shader_code *spirv) DECLSPEC_HIDDEN; void vkd3d_dxbc_compiler_destroy(struct vkd3d_dxbc_compiler *compiler) DECLSPEC_HIDDEN; -struct md5_ctx; - -void md5_init(struct md5_ctx *ctx) DECLSPEC_HIDDEN; -void md5_update(struct md5_ctx *ctx, const unsigned char *buf, unsigned int len) DECLSPEC_HIDDEN; -void md5_final(struct md5_ctx *ctx) DECLSPEC_HIDDEN; +void vkd3d_compute_dxbc_checksum(const void *dxbc, size_t size, uint32_t checksum[4]) DECLSPEC_HIDDEN; static inline enum vkd3d_component_type vkd3d_component_type_from_data_type( enum vkd3d_data_type data_type) diff --git a/tests/d3d12.c b/tests/d3d12.c index 7d67de2966dd..3ba2ce9fbb8f 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -9109,12 +9109,7 @@ static void test_root_signature_serialization_(unsigned int line, const DWORD *c ok_(line)(blob_buffer[0] == code[0], "Got magic %#x, expected %#x.\n", (unsigned int)blob_buffer[0], (unsigned int)code[0]); - for (i = 1; i < 5; ++i) - { - todo ok_(line)(blob_buffer[i] == code[i], "Got checksum %#x, expected %#x at %u.\n", - (unsigned int)blob_buffer[i], (unsigned int)code[i], i - 1); - } - for (; i < code_size / sizeof(DWORD); ++i) + for (i = 0; i < code_size / sizeof(DWORD); ++i) { ok_(line)(blob_buffer[i] == code[i], "Got dword %#x, expected %#x at %u.\n", (unsigned int)blob_buffer[i], (unsigned int)code[i], i); -- 2.19.2

2 1

[PATCH 5/5] ddraw: Support drawing from D3DVBCAPS_SYSTEMMEMORY vertex buffers.
by Henri Verbeet 17 Dec '18

17 Dec '18

From: Matteo Bruni <mbruni(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45279 Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- dlls/ddraw/device.c | 44 +++++++++++++++++++- dlls/ddraw/tests/ddraw4.c | 100 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw7.c | 93 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 236 insertions(+), 1 deletion(-) diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index 0d48c7d704e..48803f8f937 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -4275,8 +4275,11 @@ static HRESULT d3d_device7_DrawPrimitiveVB(IDirect3DDevice7 *iface, D3DPRIMITIVE { struct d3d_device *device = impl_from_IDirect3DDevice7(iface); struct d3d_vertex_buffer *vb_impl = unsafe_impl_from_IDirect3DVertexBuffer7(vb); - HRESULT hr; + struct wined3d_resource *wined3d_resource; + struct wined3d_map_desc wined3d_map_desc; + struct wined3d_box wined3d_box = {0}; DWORD stride; + HRESULT hr; TRACE("iface %p, primitive_type %#x, vb %p, start_vertex %u, vertex_count %u, flags %#x.\n", iface, primitive_type, vb, start_vertex, vertex_count, flags); @@ -4289,6 +4292,26 @@ static HRESULT d3d_device7_DrawPrimitiveVB(IDirect3DDevice7 *iface, D3DPRIMITIVE stride = get_flexible_vertex_size(vb_impl->fvf); + if (vb_impl->Caps & D3DVBCAPS_SYSTEMMEMORY) + { + TRACE("Drawing from D3DVBCAPS_SYSTEMMEMORY vertex buffer, forwarding to DrawPrimitive().\n"); + wined3d_mutex_lock(); + wined3d_resource = wined3d_buffer_get_resource(vb_impl->wined3d_buffer); + wined3d_box.left = start_vertex * stride; + wined3d_box.right = wined3d_box.left + vertex_count * stride; + if (FAILED(hr = wined3d_resource_map(wined3d_resource, 0, &wined3d_map_desc, + &wined3d_box, WINED3D_MAP_READ))) + { + wined3d_mutex_unlock(); + return D3DERR_VERTEXBUFFERLOCKED; + } + hr = d3d_device7_DrawPrimitive(iface, primitive_type, vb_impl->fvf, wined3d_map_desc.data, + vertex_count, flags); + wined3d_resource_unmap(wined3d_resource, 0); + wined3d_mutex_unlock(); + return hr; + } + wined3d_mutex_lock(); wined3d_device_set_vertex_declaration(device->wined3d_device, vb_impl->wined3d_declaration); if (FAILED(hr = wined3d_device_set_stream_source(device->wined3d_device, @@ -4366,6 +4389,7 @@ static HRESULT d3d_device7_DrawIndexedPrimitiveVB(IDirect3DDevice7 *iface, struct d3d_device *device = impl_from_IDirect3DDevice7(iface); struct d3d_vertex_buffer *vb_impl = unsafe_impl_from_IDirect3DVertexBuffer7(vb); DWORD stride = get_flexible_vertex_size(vb_impl->fvf); + struct wined3d_resource *wined3d_resource; struct wined3d_map_desc wined3d_map_desc; struct wined3d_box wined3d_box = {0}; struct wined3d_resource *ib; @@ -4382,6 +4406,24 @@ static HRESULT d3d_device7_DrawIndexedPrimitiveVB(IDirect3DDevice7 *iface, return D3D_OK; } + if (vb_impl->Caps & D3DVBCAPS_SYSTEMMEMORY) + { + TRACE("Drawing from D3DVBCAPS_SYSTEMMEMORY vertex buffer, forwarding to DrawIndexedPrimitive().\n"); + wined3d_mutex_lock(); + wined3d_resource = wined3d_buffer_get_resource(vb_impl->wined3d_buffer); + if (FAILED(hr = wined3d_resource_map(wined3d_resource, 0, &wined3d_map_desc, + &wined3d_box, WINED3D_MAP_READ))) + { + wined3d_mutex_unlock(); + return D3DERR_VERTEXBUFFERLOCKED; + } + hr = d3d_device7_DrawIndexedPrimitive(iface, primitive_type, vb_impl->fvf, wined3d_map_desc.data, + start_vertex + vertex_count, indices, index_count, flags); + wined3d_resource_unmap(wined3d_resource, 0); + wined3d_mutex_unlock(); + return hr; + } + /* Steps: * 1) Upload the indices to the index buffer * 2) Set the index source diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 443c78b6439..1c4841891e4 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -15373,6 +15373,105 @@ static void test_killfocus(void) UnregisterClassA("ddraw_killfocus_wndproc_wc", GetModuleHandleA(NULL)); } +static void test_sysmem_draw(void) +{ + D3DRECT rect_full = {{0}, {0}, {640}, {480}}; + IDirect3DViewport3 *viewport; + D3DVERTEXBUFFERDESC vb_desc; + IDirect3DVertexBuffer *vb; + IDirect3DDevice3 *device; + IDirectDrawSurface4 *rt; + IDirect3D3 *d3d; + D3DCOLOR color; + ULONG refcount; + HWND window; + HRESULT hr; + BYTE *data; + + static const struct + { + struct vec3 position; + DWORD diffuse; + } + quad[] = + { + {{-1.0f, -1.0f, 0.0f}, 0xffff0000}, + {{-1.0f, 1.0f, 0.0f}, 0xff00ff00}, + {{ 1.0f, -1.0f, 0.0f}, 0xff0000ff}, + {{ 1.0f, 1.0f, 0.0f}, 0xffffffff}, + }; + static WORD indices[] = {0, 1, 2, 3}; + + window = create_window(); + ok(!!window, "Failed to create a window.\n"); + + if (!(device = create_device(window, DDSCL_NORMAL))) + { + skip("Failed to create a 3D device, skipping test.\n"); + DestroyWindow(window); + return; + } + + hr = IDirect3DDevice3_GetDirect3D(device, &d3d); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice3_GetRenderTarget(device, &rt); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + viewport = create_viewport(device, 0, 0, 640, 480); + hr = IDirect3DDevice3_SetCurrentViewport(device, viewport); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice3_SetRenderState(device, D3DRENDERSTATE_LIGHTING, FALSE); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + vb_desc.dwSize = sizeof(vb_desc); + vb_desc.dwCaps = D3DVBCAPS_SYSTEMMEMORY; + vb_desc.dwFVF = D3DFVF_XYZ | D3DFVF_DIFFUSE; + vb_desc.dwNumVertices = 4; + hr = IDirect3D3_CreateVertexBuffer(d3d, &vb_desc, &vb, 0, NULL); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DVertexBuffer_Lock(vb, 0, (void **)&data, NULL); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, quad, sizeof(quad)); + hr = IDirect3DVertexBuffer_Unlock(vb); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DViewport3_Clear2(viewport, 1, &rect_full, D3DCLEAR_TARGET, 0xffffffff, 0.0f, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice3_BeginScene(device); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice3_DrawPrimitiveVB(device, D3DPT_TRIANGLESTRIP, vb, 0, 4, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice3_EndScene(device); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + color = get_surface_color(rt, 320, 240); + ok(compare_color(color, 0x00007f7f, 1), "Got unexpected color 0x%08x.\n", color); + + hr = IDirect3DViewport3_Clear2(viewport, 1, &rect_full, D3DCLEAR_TARGET, 0xffffffff, 0.0f, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice3_BeginScene(device); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice3_DrawIndexedPrimitiveVB(device, D3DPT_TRIANGLESTRIP, vb, indices, 4, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice3_EndScene(device); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + color = get_surface_color(rt, 320, 240); + ok(compare_color(color, 0x00007f7f, 1), "Got unexpected color 0x%08x.\n", color); + + IDirect3DVertexBuffer_Release(vb); + IDirect3DViewport3_Release(viewport); + IDirectDrawSurface4_Release(rt); + IDirect3D3_Release(d3d); + refcount = IDirect3DDevice3_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); + DestroyWindow(window); +} + START_TEST(ddraw4) { DDDEVICEIDENTIFIER identifier; @@ -15501,4 +15600,5 @@ START_TEST(ddraw4) test_viewport(); test_find_device(); test_killfocus(); + test_sysmem_draw(); } diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 05151b06510..9ab8644191f 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -15088,6 +15088,98 @@ static void test_killfocus(void) UnregisterClassA("ddraw_killfocus_wndproc_wc", GetModuleHandleA(NULL)); } +static void test_sysmem_draw(void) +{ + D3DVERTEXBUFFERDESC vb_desc; + IDirect3DVertexBuffer7 *vb; + IDirect3DDevice7 *device; + IDirectDrawSurface7 *rt; + IDirect3D7 *d3d; + D3DCOLOR colour; + ULONG refcount; + HWND window; + HRESULT hr; + BYTE *data; + + static const struct + { + struct vec3 position; + DWORD diffuse; + } + quad[] = + { + {{-1.0f, -1.0f, 0.0f}, 0xffff0000}, + {{-1.0f, 1.0f, 0.0f}, 0xff00ff00}, + {{ 1.0f, -1.0f, 0.0f}, 0xff0000ff}, + {{ 1.0f, 1.0f, 0.0f}, 0xffffffff}, + }; + static WORD indices[] = {0, 1, 2, 3}; + + window = create_window(); + ok(!!window, "Failed to create a window.\n"); + + if (!(device = create_device(window, DDSCL_NORMAL))) + { + skip("Failed to create a 3D device, skipping test.\n"); + DestroyWindow(window); + return; + } + + hr = IDirect3DDevice7_GetDirect3D(device, &d3d); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice7_GetRenderTarget(device, &rt); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice7_SetRenderState(device, D3DRENDERSTATE_LIGHTING, FALSE); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + vb_desc.dwSize = sizeof(vb_desc); + vb_desc.dwCaps = D3DVBCAPS_SYSTEMMEMORY; + vb_desc.dwFVF = D3DFVF_XYZ | D3DFVF_DIFFUSE; + vb_desc.dwNumVertices = 4; + hr = IDirect3D7_CreateVertexBuffer(d3d, &vb_desc, &vb, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DVertexBuffer7_Lock(vb, 0, (void **)&data, NULL); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, quad, sizeof(quad)); + hr = IDirect3DVertexBuffer7_Unlock(vb); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice7_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x77777777, 0.0f, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice7_BeginScene(device); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice7_DrawPrimitiveVB(device, D3DPT_TRIANGLESTRIP, vb, 0, 4, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice7_EndScene(device); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + colour = get_surface_color(rt, 320, 240); + ok(compare_color(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + + hr = IDirect3DDevice7_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x77777777, 0.0f, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice7_BeginScene(device); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice7_DrawIndexedPrimitiveVB(device, D3DPT_TRIANGLESTRIP, vb, 0, 4, indices, 4, 0); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice7_EndScene(device); + ok(hr == DD_OK, "Got unexpected hr %#x.\n", hr); + + colour = get_surface_color(rt, 320, 240); + ok(compare_color(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + + IDirect3DVertexBuffer7_Release(vb); + IDirectDrawSurface7_Release(rt); + IDirect3D7_Release(d3d); + refcount = IDirect3DDevice7_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); + DestroyWindow(window); +} + START_TEST(ddraw7) { DDDEVICEIDENTIFIER2 identifier; @@ -15227,4 +15319,5 @@ START_TEST(ddraw7) test_device_load(); test_color_vertex(); test_killfocus(); + test_sysmem_draw(); } -- 2.11.0

2 1

[PATCH 4/5] d3d8: Support drawing from D3DPOOL_SYSTEMMEM index buffers.
by Henri Verbeet 17 Dec '18

17 Dec '18

From: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- dlls/d3d8/buffer.c | 24 +++++++++++-- dlls/d3d8/d3d8_private.h | 4 ++- dlls/d3d8/device.c | 47 +++++++++++++++++++++--- dlls/d3d8/tests/visual.c | 94 +++++++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 160 insertions(+), 9 deletions(-) diff --git a/dlls/d3d8/buffer.c b/dlls/d3d8/buffer.c index 20efe6bd18a..58aaff275b1 100644 --- a/dlls/d3d8/buffer.c +++ b/dlls/d3d8/buffer.c @@ -377,6 +377,8 @@ static ULONG WINAPI d3d8_indexbuffer_AddRef(IDirect3DIndexBuffer8 *iface) IDirect3DDevice8_AddRef(buffer->parent_device); wined3d_mutex_lock(); wined3d_buffer_incref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_incref(buffer->draw_buffer); wined3d_mutex_unlock(); } @@ -396,6 +398,8 @@ static ULONG WINAPI d3d8_indexbuffer_Release(IDirect3DIndexBuffer8 *iface) wined3d_mutex_lock(); wined3d_buffer_decref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_decref(buffer->draw_buffer); wined3d_mutex_unlock(); /* Release the device last, as it may cause the device to be destroyed. */ @@ -592,6 +596,7 @@ static const struct wined3d_parent_ops d3d8_indexbuffer_wined3d_parent_ops = HRESULT indexbuffer_init(struct d3d8_indexbuffer *buffer, struct d3d8_device *device, UINT size, DWORD usage, D3DFORMAT format, D3DPOOL pool) { + const struct wined3d_parent_ops *parent_ops = &d3d8_null_wined3d_parent_ops; struct wined3d_buffer_desc desc; HRESULT hr; @@ -604,19 +609,32 @@ HRESULT indexbuffer_init(struct d3d8_indexbuffer *buffer, struct d3d8_device *de desc.byte_width = size; desc.usage = (usage & WINED3DUSAGE_MASK) | WINED3DUSAGE_STATICDECL; - desc.bind_flags = WINED3D_BIND_INDEX_BUFFER; + desc.bind_flags = 0; desc.access = wined3daccess_from_d3dpool(pool, usage) | WINED3D_RESOURCE_ACCESS_MAP_R | WINED3D_RESOURCE_ACCESS_MAP_W; desc.misc_flags = 0; desc.structure_byte_stride = 0; + if (desc.access & WINED3D_RESOURCE_ACCESS_GPU) + { + desc.bind_flags = WINED3D_BIND_INDEX_BUFFER; + parent_ops = &d3d8_indexbuffer_wined3d_parent_ops; + } + buffer->IDirect3DIndexBuffer8_iface.lpVtbl = &d3d8_indexbuffer_vtbl; d3d8_resource_init(&buffer->resource); buffer->format = wined3dformat_from_d3dformat(format); wined3d_mutex_lock(); - hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, - &d3d8_indexbuffer_wined3d_parent_ops, &buffer->wined3d_buffer); + hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, parent_ops, &buffer->wined3d_buffer); + if (SUCCEEDED(hr) && !(desc.access & WINED3D_RESOURCE_ACCESS_GPU)) + { + desc.bind_flags = WINED3D_BIND_INDEX_BUFFER; + desc.access = WINED3D_RESOURCE_ACCESS_GPU; + if (FAILED(hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, + &d3d8_indexbuffer_wined3d_parent_ops, &buffer->draw_buffer))) + wined3d_buffer_decref(buffer->wined3d_buffer); + } wined3d_mutex_unlock(); if (FAILED(hr)) { diff --git a/dlls/d3d8/d3d8_private.h b/dlls/d3d8/d3d8_private.h index 4a62dbe40c0..81f4e2009fd 100644 --- a/dlls/d3d8/d3d8_private.h +++ b/dlls/d3d8/d3d8_private.h @@ -124,9 +124,10 @@ struct d3d8_device LONG device_state; DWORD sysmem_vb : 16; /* D3D8_MAX_STREAMS */ + DWORD sysmem_ib : 1; DWORD in_destruction : 1; DWORD recording : 1; - DWORD padding : 14; + DWORD padding : 13; /* The d3d8 API supports only one implicit swapchain (no D3DCREATE_ADAPTERGROUP_DEVICE, * no GetSwapchain, GetBackBuffer doesn't accept a swapchain number). */ @@ -220,6 +221,7 @@ struct d3d8_indexbuffer struct d3d8_resource resource; struct wined3d_buffer *wined3d_buffer; IDirect3DDevice8 *parent_device; + struct wined3d_buffer *draw_buffer; enum wined3d_format_id format; }; diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index 8ae1502b566..1f61514b0b7 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -1899,6 +1899,7 @@ static HRESULT WINAPI d3d8_device_ApplyStateBlock(IDirect3DDevice8 *iface, DWORD struct wined3d_buffer *wined3d_buffer; struct d3d8_vertexbuffer *buffer; unsigned int i, offset, stride; + enum wined3d_format_id format; HRESULT hr; TRACE("iface %p, token %#x.\n", iface, token); @@ -1926,6 +1927,8 @@ static HRESULT WINAPI d3d8_device_ApplyStateBlock(IDirect3DDevice8 *iface, DWORD if (buffer->draw_buffer) device->sysmem_vb |= 1u << i; } + device->sysmem_ib = (wined3d_buffer = wined3d_device_get_index_buffer(device->wined3d_device, &format, &offset)) + && (buffer = wined3d_buffer_get_parent(wined3d_buffer)) && buffer->draw_buffer; wined3d_mutex_unlock(); return D3D_OK; @@ -2274,6 +2277,31 @@ static void d3d8_device_upload_sysmem_vertex_buffers(struct d3d8_device *device, } } +static void d3d8_device_upload_sysmem_index_buffer(struct d3d8_device *device, + unsigned int start_idx, unsigned int idx_count) +{ + struct wined3d_box box = {0, 0, 0, 1, 0, 1}; + struct d3d8_vertexbuffer *d3d8_buffer; + struct wined3d_buffer *dst_buffer; + enum wined3d_format_id format; + unsigned int offset, idx_size; + HRESULT hr; + + if (!device->sysmem_ib) + return; + + if (!(dst_buffer = wined3d_device_get_index_buffer(device->wined3d_device, &format, &offset))) + ERR("Failed to get index buffer.\n"); + d3d8_buffer = wined3d_buffer_get_parent(dst_buffer); + idx_size = format == WINED3DFMT_R16_UINT ? 2 : 4; + box.left = offset + start_idx * idx_size; + box.right = box.left + idx_count * idx_size; + if (FAILED(hr = wined3d_device_copy_sub_resource_region(device->wined3d_device, + wined3d_buffer_get_resource(dst_buffer), 0, box.left, 0, 0, + wined3d_buffer_get_resource(d3d8_buffer->wined3d_buffer), 0, &box, 0))) + ERR("Failed to update buffer.\n"); +} + static HRESULT WINAPI d3d8_device_DrawPrimitive(IDirect3DDevice8 *iface, D3DPRIMITIVETYPE primitive_type, UINT start_vertex, UINT primitive_count) { @@ -2299,16 +2327,18 @@ static HRESULT WINAPI d3d8_device_DrawIndexedPrimitive(IDirect3DDevice8 *iface, UINT start_idx, UINT primitive_count) { struct d3d8_device *device = impl_from_IDirect3DDevice8(iface); + unsigned int index_count; HRESULT hr; TRACE("iface %p, primitive_type %#x, min_vertex_idx %u, vertex_count %u, start_idx %u, primitive_count %u.\n", iface, primitive_type, min_vertex_idx, vertex_count, start_idx, primitive_count); + index_count = vertex_count_from_primitive_count(primitive_type, primitive_count); wined3d_mutex_lock(); d3d8_device_upload_sysmem_vertex_buffers(device, min_vertex_idx, vertex_count); + d3d8_device_upload_sysmem_index_buffer(device, start_idx, index_count); wined3d_device_set_primitive_type(device->wined3d_device, primitive_type, 0); - hr = wined3d_device_draw_indexed_primitive(device->wined3d_device, start_idx, - vertex_count_from_primitive_count(primitive_type, primitive_count)); + hr = wined3d_device_draw_indexed_primitive(device->wined3d_device, start_idx, index_count); wined3d_mutex_unlock(); return hr; @@ -2882,9 +2912,17 @@ static HRESULT WINAPI d3d8_device_SetIndices(IDirect3DDevice8 *iface, { struct d3d8_device *device = impl_from_IDirect3DDevice8(iface); struct d3d8_indexbuffer *ib = unsafe_impl_from_IDirect3DIndexBuffer8(buffer); + struct wined3d_buffer *wined3d_buffer; TRACE("iface %p, buffer %p, base_vertex_idx %u.\n", iface, buffer, base_vertex_idx); + if (!ib) + wined3d_buffer = NULL; + else if (ib->draw_buffer) + wined3d_buffer = ib->draw_buffer; + else + wined3d_buffer = ib->wined3d_buffer; + /* WineD3D takes an INT(due to d3d9), but d3d8 uses UINTs. Do I have to add a check here that * the UINT doesn't cause an overflow in the INT? It seems rather unlikely because such large * vertex buffers can't be created to address them with an index that requires the 32nd bit @@ -2893,8 +2931,9 @@ static HRESULT WINAPI d3d8_device_SetIndices(IDirect3DDevice8 *iface, */ wined3d_mutex_lock(); wined3d_device_set_base_vertex_index(device->wined3d_device, base_vertex_idx); - wined3d_device_set_index_buffer(device->wined3d_device, - ib ? ib->wined3d_buffer : NULL, ib ? ib->format : WINED3DFMT_UNKNOWN, 0); + wined3d_device_set_index_buffer(device->wined3d_device, wined3d_buffer, ib ? ib->format : WINED3DFMT_UNKNOWN, 0); + if (!device->recording) + device->sysmem_ib = ib && ib->draw_buffer; wined3d_mutex_unlock(); return D3D_OK; diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c index 7576008b384..25f96fd3dd5 100644 --- a/dlls/d3d8/tests/visual.c +++ b/dlls/d3d8/tests/visual.c @@ -10448,7 +10448,8 @@ static void test_color_vertex(void) static void test_sysmem_draw(void) { - IDirect3DVertexBuffer8 *vb; + IDirect3DVertexBuffer8 *vb, *vb_s0, *vb_s1; + IDirect3DIndexBuffer8 *ib; IDirect3DDevice8 *device; IDirect3D8 *d3d; D3DCOLOR colour; @@ -10456,7 +10457,16 @@ static void test_sysmem_draw(void) HWND window; HRESULT hr; BYTE *data; + DWORD vs; + static const DWORD decl[] = + { + D3DVSD_STREAM(0), + D3DVSD_REG(D3DVSDE_POSITION, D3DVSDT_FLOAT3), + D3DVSD_STREAM(1), + D3DVSD_REG(D3DVSDE_DIFFUSE, D3DVSDT_D3DCOLOR), + D3DVSD_END() + }; static const struct { struct vec3 position; @@ -10469,6 +10479,21 @@ static void test_sysmem_draw(void) {{ 1.0f, -1.0f, 0.0f}, 0xff0000ff}, {{ 1.0f, 1.0f, 0.0f}, 0xffffffff}, }; + static const struct vec3 quad_s0[] = + { + {-1.0f, -1.0f, 0.0f}, + {-1.0f, 1.0f, 0.0f}, + { 1.0f, -1.0f, 0.0f}, + { 1.0f, 1.0f, 0.0f}, + }; + static const DWORD quad_s1[] = + { + 0xffff0000, + 0xff00ff00, + 0xff0000ff, + 0xffffffff, + }; + static const short indices[] = {0, 1, 2, 3}; window = create_window(); ok(!!window, "Failed to create a window.\n"); @@ -10512,9 +10537,76 @@ static void test_sysmem_draw(void) colour = getPixelColor(device, 320, 240); ok(color_match(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + hr = IDirect3DDevice8_CreateIndexBuffer(device, sizeof(indices), 0, + D3DFMT_INDEX16, D3DPOOL_SYSTEMMEM, &ib); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DIndexBuffer8_Lock(ib, 0, sizeof(indices), (BYTE **)&data, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, indices, sizeof(indices)); + hr = IDirect3DIndexBuffer8_Unlock(ib); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x77777777, 0.0f, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_SetIndices(device, ib, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_BeginScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_DrawIndexedPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 4, 0, 2); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_EndScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + colour = getPixelColor(device, 320, 240); + ok(color_match(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + + hr = IDirect3DDevice8_CreateVertexShader(device, decl, NULL, &vs, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_SetVertexShader(device, vs); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_CreateVertexBuffer(device, sizeof(quad_s0), 0, 0, D3DPOOL_SYSTEMMEM, &vb_s0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DVertexBuffer8_Lock(vb_s0, 0, sizeof(quad_s0), (BYTE **)&data, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, quad_s0, sizeof(quad_s0)); + hr = IDirect3DVertexBuffer8_Unlock(vb_s0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_CreateVertexBuffer(device, sizeof(quad_s1), 0, 0, D3DPOOL_SYSTEMMEM, &vb_s1); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DVertexBuffer8_Lock(vb_s1, 0, sizeof(quad_s1), (BYTE **)&data, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, quad_s1, sizeof(quad_s1)); + hr = IDirect3DVertexBuffer8_Unlock(vb_s1); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_SetStreamSource(device, 0, vb_s0, sizeof(*quad_s0)); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_SetStreamSource(device, 1, vb_s1, sizeof(*quad_s1)); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x77777777, 0.0f, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_BeginScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_DrawIndexedPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 4, 0, 2); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_EndScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + colour = getPixelColor(device, 320, 240); + ok(color_match(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + hr = IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL); ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + IDirect3DVertexBuffer8_Release(vb_s1); + IDirect3DVertexBuffer8_Release(vb_s0); + IDirect3DDevice8_DeleteVertexShader(device, vs); + IDirect3DIndexBuffer8_Release(ib); IDirect3DVertexBuffer8_Release(vb); refcount = IDirect3DDevice8_Release(device); ok(!refcount, "Device has %u references left.\n", refcount); -- 2.11.0

2 1

[PATCH 3/5] d3d8: Support drawing from D3DPOOL_SYSTEMMEM vertex buffers.
by Henri Verbeet 17 Dec '18

17 Dec '18

From: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- dlls/d3d8/buffer.c | 24 ++++++++++++-- dlls/d3d8/d3d8_private.h | 14 ++++++--- dlls/d3d8/device.c | 81 ++++++++++++++++++++++++++++++++++++++++++------ dlls/d3d8/tests/visual.c | 77 +++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 180 insertions(+), 16 deletions(-) diff --git a/dlls/d3d8/buffer.c b/dlls/d3d8/buffer.c index 626d74e964c..20efe6bd18a 100644 --- a/dlls/d3d8/buffer.c +++ b/dlls/d3d8/buffer.c @@ -57,6 +57,8 @@ static ULONG WINAPI d3d8_vertexbuffer_AddRef(IDirect3DVertexBuffer8 *iface) IDirect3DDevice8_AddRef(buffer->parent_device); wined3d_mutex_lock(); wined3d_buffer_incref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_incref(buffer->draw_buffer); wined3d_mutex_unlock(); } @@ -76,6 +78,8 @@ static ULONG WINAPI d3d8_vertexbuffer_Release(IDirect3DVertexBuffer8 *iface) wined3d_mutex_lock(); wined3d_buffer_decref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_decref(buffer->draw_buffer); wined3d_mutex_unlock(); /* Release the device last, as it may cause the device to be destroyed. */ @@ -273,6 +277,7 @@ static const struct wined3d_parent_ops d3d8_vertexbuffer_wined3d_parent_ops = HRESULT vertexbuffer_init(struct d3d8_vertexbuffer *buffer, struct d3d8_device *device, UINT size, DWORD usage, DWORD fvf, D3DPOOL pool) { + const struct wined3d_parent_ops *parent_ops = &d3d8_null_wined3d_parent_ops; struct wined3d_buffer_desc desc; HRESULT hr; @@ -292,15 +297,28 @@ HRESULT vertexbuffer_init(struct d3d8_vertexbuffer *buffer, struct d3d8_device * desc.byte_width = size; desc.usage = usage & WINED3DUSAGE_MASK; - desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + desc.bind_flags = 0; desc.access = wined3daccess_from_d3dpool(pool, usage) | WINED3D_RESOURCE_ACCESS_MAP_R | WINED3D_RESOURCE_ACCESS_MAP_W; desc.misc_flags = 0; desc.structure_byte_stride = 0; + if (desc.access & WINED3D_RESOURCE_ACCESS_GPU) + { + desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + parent_ops = &d3d8_vertexbuffer_wined3d_parent_ops; + } + wined3d_mutex_lock(); - hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, - &d3d8_vertexbuffer_wined3d_parent_ops, &buffer->wined3d_buffer); + hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, parent_ops, &buffer->wined3d_buffer); + if (SUCCEEDED(hr) && !(desc.access & WINED3D_RESOURCE_ACCESS_GPU)) + { + desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + desc.access = WINED3D_RESOURCE_ACCESS_GPU; + if (FAILED(hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, + &d3d8_vertexbuffer_wined3d_parent_ops, &buffer->draw_buffer))) + wined3d_buffer_decref(buffer->wined3d_buffer); + } wined3d_mutex_unlock(); if (FAILED(hr)) { diff --git a/dlls/d3d8/d3d8_private.h b/dlls/d3d8/d3d8_private.h index 7f6049df574..4a62dbe40c0 100644 --- a/dlls/d3d8/d3d8_private.h +++ b/dlls/d3d8/d3d8_private.h @@ -39,9 +39,14 @@ #define D3DPRESENTFLAGS_MASK 0x00000fffu +#define D3D8_MAX_VERTEX_SHADER_CONSTANTF 256 +#define D3D8_MAX_STREAMS 16 + /* CreateVertexShader can return > 0xFFFF */ #define VS_HIGHESTFIXEDFXF 0xF0000000 +extern const struct wined3d_parent_ops d3d8_null_wined3d_parent_ops DECLSPEC_HIDDEN; + void d3dcaps_from_wined3dcaps(D3DCAPS8 *caps, const struct wined3d_caps *wined3d_caps) DECLSPEC_HIDDEN; struct d3d8 @@ -118,8 +123,10 @@ struct d3d8_device UINT index_buffer_pos; LONG device_state; - /* Avoids recursion with nested ReleaseRef to 0 */ - BOOL inDestruction; + DWORD sysmem_vb : 16; /* D3D8_MAX_STREAMS */ + DWORD in_destruction : 1; + DWORD recording : 1; + DWORD padding : 14; /* The d3d8 API supports only one implicit swapchain (no D3DCREATE_ADAPTERGROUP_DEVICE, * no GetSwapchain, GetBackBuffer doesn't accept a swapchain number). */ @@ -199,6 +206,7 @@ struct d3d8_vertexbuffer struct d3d8_resource resource; struct wined3d_buffer *wined3d_buffer; IDirect3DDevice8 *parent_device; + struct wined3d_buffer *draw_buffer; DWORD fvf; }; @@ -260,8 +268,6 @@ void d3d8_vertex_shader_destroy(struct d3d8_vertex_shader *shader) DECLSPEC_HIDD HRESULT d3d8_vertex_shader_init(struct d3d8_vertex_shader *shader, struct d3d8_device *device, const DWORD *declaration, const DWORD *byte_code, DWORD shader_handle, DWORD usage) DECLSPEC_HIDDEN; -#define D3D8_MAX_VERTEX_SHADER_CONSTANTF 256 - struct d3d8_pixel_shader { DWORD handle; diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index 3c83811103f..8ae1502b566 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -36,7 +36,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3d8); static void STDMETHODCALLTYPE d3d8_null_wined3d_object_destroyed(void *parent) {} -static const struct wined3d_parent_ops d3d8_null_wined3d_parent_ops = +const struct wined3d_parent_ops d3d8_null_wined3d_parent_ops = { d3d8_null_wined3d_object_destroyed, }; @@ -564,7 +564,7 @@ static ULONG WINAPI d3d8_device_Release(IDirect3DDevice8 *iface) struct d3d8_device *device = impl_from_IDirect3DDevice8(iface); ULONG ref; - if (device->inDestruction) + if (device->in_destruction) return 0; ref = InterlockedDecrement(&device->ref); @@ -580,7 +580,7 @@ static ULONG WINAPI d3d8_device_Release(IDirect3DDevice8 *iface) wined3d_mutex_lock(); - device->inDestruction = TRUE; + device->in_destruction = TRUE; for (i = 0; i < device->numConvertedDecls; ++i) { @@ -891,6 +891,7 @@ static HRESULT WINAPI d3d8_device_Reset(IDirect3DDevice8 *iface, if (SUCCEEDED(hr = wined3d_device_reset(device->wined3d_device, &swapchain_desc, NULL, reset_enum_callback, TRUE))) { + device->recording = FALSE; present_parameters->BackBufferCount = swapchain_desc.backbuffer_count; device->implicit_swapchain->swap_interval = wined3dswapinterval_from_d3d(present_parameters->FullScreen_PresentationInterval); @@ -1845,7 +1846,8 @@ static HRESULT WINAPI d3d8_device_BeginStateBlock(IDirect3DDevice8 *iface) TRACE("iface %p.\n", iface); wined3d_mutex_lock(); - hr = wined3d_device_begin_stateblock(device->wined3d_device); + if (SUCCEEDED(hr = wined3d_device_begin_stateblock(device->wined3d_device))) + device->recording = TRUE; wined3d_mutex_unlock(); return hr; @@ -1870,6 +1872,7 @@ static HRESULT WINAPI d3d8_device_EndStateBlock(IDirect3DDevice8 *iface, DWORD * wined3d_mutex_unlock(); return hr; } + device->recording = FALSE; *token = d3d8_allocate_handle(&device->handle_table, stateblock, D3D8_HANDLE_SB); wined3d_mutex_unlock(); @@ -1893,6 +1896,10 @@ static HRESULT WINAPI d3d8_device_ApplyStateBlock(IDirect3DDevice8 *iface, DWORD { struct d3d8_device *device = impl_from_IDirect3DDevice8(iface); struct wined3d_stateblock *stateblock; + struct wined3d_buffer *wined3d_buffer; + struct d3d8_vertexbuffer *buffer; + unsigned int i, offset, stride; + HRESULT hr; TRACE("iface %p, token %#x.\n", iface, token); @@ -1908,6 +1915,17 @@ static HRESULT WINAPI d3d8_device_ApplyStateBlock(IDirect3DDevice8 *iface, DWORD return D3DERR_INVALIDCALL; } wined3d_stateblock_apply(stateblock); + device->sysmem_vb = 0; + for (i = 0; i < D3D8_MAX_STREAMS; ++i) + { + if (FAILED(hr = wined3d_device_get_stream_source(device->wined3d_device, + i, &wined3d_buffer, &offset, &stride))) + continue; + if (!wined3d_buffer || !(buffer = wined3d_buffer_get_parent(wined3d_buffer))) + continue; + if (buffer->draw_buffer) + device->sysmem_vb |= 1u << i; + } wined3d_mutex_unlock(); return D3D_OK; @@ -2229,19 +2247,48 @@ static HRESULT WINAPI d3d8_device_GetCurrentTexturePalette(IDirect3DDevice8 *ifa return D3DERR_INVALIDCALL; } +static void d3d8_device_upload_sysmem_vertex_buffers(struct d3d8_device *device, + unsigned int start_vertex, unsigned int vertex_count) +{ + struct wined3d_box box = {0, 0, 0, 1, 0, 1}; + struct d3d8_vertexbuffer *d3d8_buffer; + unsigned int i, offset, stride, map; + struct wined3d_buffer *dst_buffer; + HRESULT hr; + + map = device->sysmem_vb; + while (map) + { + i = ffs(map) - 1; + map ^= 1u << i; + + if (FAILED(hr = wined3d_device_get_stream_source(device->wined3d_device, i, &dst_buffer, &offset, &stride))) + ERR("Failed to get stream source.\n"); + d3d8_buffer = wined3d_buffer_get_parent(dst_buffer); + box.left = offset + start_vertex * stride; + box.right = box.left + vertex_count * stride; + if (FAILED(hr = wined3d_device_copy_sub_resource_region(device->wined3d_device, + wined3d_buffer_get_resource(dst_buffer), 0, box.left, 0, 0, + wined3d_buffer_get_resource(d3d8_buffer->wined3d_buffer), 0, &box, 0))) + ERR("Failed to update buffer.\n"); + } +} + static HRESULT WINAPI d3d8_device_DrawPrimitive(IDirect3DDevice8 *iface, D3DPRIMITIVETYPE primitive_type, UINT start_vertex, UINT primitive_count) { struct d3d8_device *device = impl_from_IDirect3DDevice8(iface); + unsigned int vertex_count; HRESULT hr; TRACE("iface %p, primitive_type %#x, start_vertex %u, primitive_count %u.\n", iface, primitive_type, start_vertex, primitive_count); + vertex_count = vertex_count_from_primitive_count(primitive_type, primitive_count); wined3d_mutex_lock(); + d3d8_device_upload_sysmem_vertex_buffers(device, start_vertex, vertex_count); wined3d_device_set_primitive_type(device->wined3d_device, primitive_type, 0); - hr = wined3d_device_draw_primitive(device->wined3d_device, start_vertex, - vertex_count_from_primitive_count(primitive_type, primitive_count)); + hr = wined3d_device_draw_primitive(device->wined3d_device, start_vertex, vertex_count); wined3d_mutex_unlock(); return hr; @@ -2258,6 +2305,7 @@ static HRESULT WINAPI d3d8_device_DrawIndexedPrimitive(IDirect3DDevice8 *iface, iface, primitive_type, min_vertex_idx, vertex_count, start_idx, primitive_count); wined3d_mutex_lock(); + d3d8_device_upload_sysmem_vertex_buffers(device, min_vertex_idx, vertex_count); wined3d_device_set_primitive_type(device->wined3d_device, primitive_type, 0); hr = wined3d_device_draw_indexed_primitive(device->wined3d_device, start_idx, vertex_count_from_primitive_count(primitive_type, primitive_count)); @@ -3098,6 +3146,7 @@ static HRESULT WINAPI d3d8_device_SetStreamSource(IDirect3DDevice8 *iface, { struct d3d8_device *device = impl_from_IDirect3DDevice8(iface); struct d3d8_vertexbuffer *buffer_impl = unsafe_impl_from_IDirect3DVertexBuffer8(buffer); + struct wined3d_buffer *wined3d_buffer; HRESULT hr; TRACE("iface %p, stream_idx %u, buffer %p, stride %u.\n", @@ -3106,14 +3155,28 @@ static HRESULT WINAPI d3d8_device_SetStreamSource(IDirect3DDevice8 *iface, wined3d_mutex_lock(); if (!stride) { - struct wined3d_buffer *wined3d_buffer; unsigned int cur_offset; hr = wined3d_device_get_stream_source(device->wined3d_device, stream_idx, &wined3d_buffer, &cur_offset, &stride); } - hr = wined3d_device_set_stream_source(device->wined3d_device, stream_idx, - buffer_impl ? buffer_impl->wined3d_buffer : NULL, 0, stride); + + if (!buffer_impl) + wined3d_buffer = NULL; + else if (buffer_impl->draw_buffer) + wined3d_buffer = buffer_impl->draw_buffer; + else + wined3d_buffer = buffer_impl->wined3d_buffer; + + hr = wined3d_device_set_stream_source(device->wined3d_device, stream_idx, wined3d_buffer, 0, stride); + if (SUCCEEDED(hr) && !device->recording) + { + if (buffer_impl && buffer_impl->draw_buffer) + device->sysmem_vb |= (1u << stream_idx); + else + device->sysmem_vb &= ~(1u << stream_idx); + } + wined3d_mutex_unlock(); return hr; diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c index e8e6bf870e2..7576008b384 100644 --- a/dlls/d3d8/tests/visual.c +++ b/dlls/d3d8/tests/visual.c @@ -10446,6 +10446,82 @@ static void test_color_vertex(void) DestroyWindow(window); } +static void test_sysmem_draw(void) +{ + IDirect3DVertexBuffer8 *vb; + IDirect3DDevice8 *device; + IDirect3D8 *d3d; + D3DCOLOR colour; + ULONG refcount; + HWND window; + HRESULT hr; + BYTE *data; + + static const struct + { + struct vec3 position; + DWORD diffuse; + } + quad[] = + { + {{-1.0f, -1.0f, 0.0f}, 0xffff0000}, + {{-1.0f, 1.0f, 0.0f}, 0xff00ff00}, + {{ 1.0f, -1.0f, 0.0f}, 0xff0000ff}, + {{ 1.0f, 1.0f, 0.0f}, 0xffffffff}, + }; + + window = create_window(); + ok(!!window, "Failed to create a window.\n"); + + d3d = Direct3DCreate8(D3D_SDK_VERSION); + ok(!!d3d, "Failed to create a D3D object.\n"); + if (!(device = create_device(d3d, window, window, TRUE))) + { + skip("Failed to create a D3D device, skipping tests.\n"); + IDirect3D8_Release(d3d); + DestroyWindow(window); + return; + } + + hr = IDirect3DDevice8_SetRenderState(device, D3DRS_LIGHTING, FALSE); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_CreateVertexBuffer(device, sizeof(quad), 0, 0, D3DPOOL_SYSTEMMEM, &vb); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DVertexBuffer8_Lock(vb, 0, sizeof(quad), (BYTE **)&data, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, quad, sizeof(quad)); + hr = IDirect3DVertexBuffer8_Unlock(vb); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x77777777, 0.0f, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_SetVertexShader(device, D3DFVF_XYZ | D3DFVF_DIFFUSE); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_SetStreamSource(device, 0, vb, sizeof(*quad)); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice8_BeginScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_DrawPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 2); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice8_EndScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + colour = getPixelColor(device, 320, 240); + ok(color_match(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + + hr = IDirect3DDevice8_Present(device, NULL, NULL, NULL, NULL); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + IDirect3DVertexBuffer8_Release(vb); + refcount = IDirect3DDevice8_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); + IDirect3D8_Release(d3d); + DestroyWindow(window); +} + START_TEST(visual) { D3DADAPTER_IDENTIFIER8 identifier; @@ -10520,4 +10596,5 @@ START_TEST(visual) test_map_synchronisation(); test_viewport(); test_color_vertex(); + test_sysmem_draw(); } -- 2.11.0

2 1

[PATCH 2/5] d3d9: Support drawing from D3DPOOL_SYSTEMMEM index buffers.
by Henri Verbeet 17 Dec '18

17 Dec '18

From: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- dlls/d3d9/buffer.c | 24 ++++++- dlls/d3d9/d3d9_private.h | 4 +- dlls/d3d9/device.c | 44 +++++++++++-- dlls/d3d9/stateblock.c | 3 + dlls/d3d9/tests/visual.c | 167 +++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 234 insertions(+), 8 deletions(-) diff --git a/dlls/d3d9/buffer.c b/dlls/d3d9/buffer.c index 15b7e2bdbce..1533a8496d2 100644 --- a/dlls/d3d9/buffer.c +++ b/dlls/d3d9/buffer.c @@ -384,6 +384,8 @@ static ULONG WINAPI d3d9_indexbuffer_AddRef(IDirect3DIndexBuffer9 *iface) IDirect3DDevice9Ex_AddRef(buffer->parent_device); wined3d_mutex_lock(); wined3d_buffer_incref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_incref(buffer->draw_buffer); wined3d_mutex_unlock(); } @@ -403,6 +405,8 @@ static ULONG WINAPI d3d9_indexbuffer_Release(IDirect3DIndexBuffer9 *iface) wined3d_mutex_lock(); wined3d_buffer_decref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_decref(buffer->draw_buffer); wined3d_mutex_unlock(); /* Release the device last, as it may cause the device to be destroyed. */ @@ -597,6 +601,7 @@ static const struct wined3d_parent_ops d3d9_indexbuffer_wined3d_parent_ops = HRESULT indexbuffer_init(struct d3d9_indexbuffer *buffer, struct d3d9_device *device, UINT size, DWORD usage, D3DFORMAT format, D3DPOOL pool) { + const struct wined3d_parent_ops *parent_ops = &d3d9_null_wined3d_parent_ops; struct wined3d_buffer_desc desc; HRESULT hr; @@ -615,19 +620,32 @@ HRESULT indexbuffer_init(struct d3d9_indexbuffer *buffer, struct d3d9_device *de desc.byte_width = size; desc.usage = (usage & WINED3DUSAGE_MASK) | WINED3DUSAGE_STATICDECL; - desc.bind_flags = WINED3D_BIND_INDEX_BUFFER; + desc.bind_flags = 0; desc.access = wined3daccess_from_d3dpool(pool, usage) | WINED3D_RESOURCE_ACCESS_MAP_R | WINED3D_RESOURCE_ACCESS_MAP_W; desc.misc_flags = 0; desc.structure_byte_stride = 0; + if (desc.access & WINED3D_RESOURCE_ACCESS_GPU) + { + desc.bind_flags = WINED3D_BIND_INDEX_BUFFER; + parent_ops = &d3d9_indexbuffer_wined3d_parent_ops; + } + buffer->IDirect3DIndexBuffer9_iface.lpVtbl = &d3d9_indexbuffer_vtbl; buffer->format = wined3dformat_from_d3dformat(format); d3d9_resource_init(&buffer->resource); wined3d_mutex_lock(); - hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, - &d3d9_indexbuffer_wined3d_parent_ops, &buffer->wined3d_buffer); + hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, parent_ops, &buffer->wined3d_buffer); + if (SUCCEEDED(hr) && !(desc.access & WINED3D_RESOURCE_ACCESS_GPU)) + { + desc.bind_flags = WINED3D_BIND_INDEX_BUFFER; + desc.access = WINED3D_RESOURCE_ACCESS_GPU; + if (FAILED(hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, + &d3d9_indexbuffer_wined3d_parent_ops, &buffer->draw_buffer))) + wined3d_buffer_decref(buffer->wined3d_buffer); + } wined3d_mutex_unlock(); if (FAILED(hr)) { diff --git a/dlls/d3d9/d3d9_private.h b/dlls/d3d9/d3d9_private.h index bd6409ffaf5..a4dc3abb7a6 100644 --- a/dlls/d3d9/d3d9_private.h +++ b/dlls/d3d9/d3d9_private.h @@ -104,11 +104,12 @@ struct d3d9_device LONG device_state; DWORD sysmem_vb : 16; /* D3D9_MAX_STREAMS */ + DWORD sysmem_ib : 1; DWORD in_destruction : 1; DWORD in_scene : 1; DWORD has_vertex_declaration : 1; DWORD recording : 1; - DWORD padding : 12; + DWORD padding : 11; unsigned int max_user_clip_planes; @@ -199,6 +200,7 @@ struct d3d9_indexbuffer struct d3d9_resource resource; struct wined3d_buffer *wined3d_buffer; IDirect3DDevice9Ex *parent_device; + struct wined3d_buffer *draw_buffer; enum wined3d_format_id format; }; diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index ba84db9338f..6844ad62e9f 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -2718,6 +2718,31 @@ static void d3d9_device_upload_sysmem_vertex_buffers(struct d3d9_device *device, } } +static void d3d9_device_upload_sysmem_index_buffer(struct d3d9_device *device, + unsigned int start_idx, unsigned int idx_count) +{ + struct wined3d_box box = {0, 0, 0, 1, 0, 1}; + struct d3d9_vertexbuffer *d3d9_buffer; + struct wined3d_buffer *dst_buffer; + enum wined3d_format_id format; + unsigned int offset, idx_size; + HRESULT hr; + + if (!device->sysmem_ib) + return; + + if (!(dst_buffer = wined3d_device_get_index_buffer(device->wined3d_device, &format, &offset))) + ERR("Failed to get index buffer.\n"); + d3d9_buffer = wined3d_buffer_get_parent(dst_buffer); + idx_size = format == WINED3DFMT_R16_UINT ? 2 : 4; + box.left = offset + start_idx * idx_size; + box.right = box.left + idx_count * idx_size; + if (FAILED(hr = wined3d_device_copy_sub_resource_region(device->wined3d_device, + wined3d_buffer_get_resource(dst_buffer), 0, box.left, 0, 0, + wined3d_buffer_get_resource(d3d9_buffer->wined3d_buffer), 0, &box, 0))) + ERR("Failed to update buffer.\n"); +} + static HRESULT WINAPI d3d9_device_DrawPrimitive(IDirect3DDevice9Ex *iface, D3DPRIMITIVETYPE primitive_type, UINT start_vertex, UINT primitive_count) { @@ -2752,6 +2777,7 @@ static HRESULT WINAPI d3d9_device_DrawIndexedPrimitive(IDirect3DDevice9Ex *iface UINT vertex_count, UINT start_idx, UINT primitive_count) { struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); + unsigned int index_count; HRESULT hr; TRACE("iface %p, primitive_type %#x, base_vertex_idx %u, min_vertex_idx %u, " @@ -2766,12 +2792,13 @@ static HRESULT WINAPI d3d9_device_DrawIndexedPrimitive(IDirect3DDevice9Ex *iface WARN("Called without a valid vertex declaration set.\n"); return D3DERR_INVALIDCALL; } + index_count = vertex_count_from_primitive_count(primitive_type, primitive_count); d3d9_device_upload_sysmem_vertex_buffers(device, min_vertex_idx, vertex_count); + d3d9_device_upload_sysmem_index_buffer(device, start_idx, index_count); d3d9_generate_auto_mipmaps(device); wined3d_device_set_base_vertex_index(device->wined3d_device, base_vertex_idx); wined3d_device_set_primitive_type(device->wined3d_device, primitive_type, 0); - hr = wined3d_device_draw_indexed_primitive(device->wined3d_device, start_idx, - vertex_count_from_primitive_count(primitive_type, primitive_count)); + hr = wined3d_device_draw_indexed_primitive(device->wined3d_device, start_idx, index_count); if (SUCCEEDED(hr)) d3d9_rts_flag_auto_gen_mipmap(device); wined3d_mutex_unlock(); @@ -3512,12 +3539,21 @@ static HRESULT WINAPI d3d9_device_SetIndices(IDirect3DDevice9Ex *iface, IDirect3 { struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); struct d3d9_indexbuffer *ib = unsafe_impl_from_IDirect3DIndexBuffer9(buffer); + struct wined3d_buffer *wined3d_buffer; TRACE("iface %p, buffer %p.\n", iface, buffer); + if (!ib) + wined3d_buffer = NULL; + else if (ib->draw_buffer) + wined3d_buffer = ib->draw_buffer; + else + wined3d_buffer = ib->wined3d_buffer; + wined3d_mutex_lock(); - wined3d_device_set_index_buffer(device->wined3d_device, - ib ? ib->wined3d_buffer : NULL, ib ? ib->format : WINED3DFMT_UNKNOWN, 0); + wined3d_device_set_index_buffer(device->wined3d_device, wined3d_buffer, ib ? ib->format : WINED3DFMT_UNKNOWN, 0); + if (!device->recording) + device->sysmem_ib = ib && ib->draw_buffer; wined3d_mutex_unlock(); return D3D_OK; diff --git a/dlls/d3d9/stateblock.c b/dlls/d3d9/stateblock.c index 440df0c1e1a..6f39488fc11 100644 --- a/dlls/d3d9/stateblock.c +++ b/dlls/d3d9/stateblock.c @@ -111,6 +111,7 @@ static HRESULT WINAPI d3d9_stateblock_Apply(IDirect3DStateBlock9 *iface) struct wined3d_buffer *wined3d_buffer; struct d3d9_vertexbuffer *buffer; unsigned int i, offset, stride; + enum wined3d_format_id format; struct d3d9_device *device; HRESULT hr; @@ -130,6 +131,8 @@ static HRESULT WINAPI d3d9_stateblock_Apply(IDirect3DStateBlock9 *iface) if (buffer->draw_buffer) device->sysmem_vb |= 1u << i; } + device->sysmem_ib = (wined3d_buffer = wined3d_device_get_index_buffer(device->wined3d_device, &format, &offset)) + && (buffer = wined3d_buffer_get_parent(wined3d_buffer)) && buffer->draw_buffer; wined3d_mutex_unlock(); return D3D_OK; diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index 4f26b0d23f9..392369a3f79 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -24197,6 +24197,172 @@ static void test_color_vertex(void) DestroyWindow(window); } +static void test_sysmem_draw(void) +{ + IDirect3DVertexDeclaration9 *vertex_declaration; + IDirect3DVertexBuffer9 *vb, *vb_s0, *vb_s1; + IDirect3DIndexBuffer9 *ib; + IDirect3DDevice9 *device; + IDirect3D9 *d3d; + D3DCOLOR colour; + ULONG refcount; + HWND window; + HRESULT hr; + BYTE *data; + + static const D3DVERTEXELEMENT9 decl_elements[] = + { + {0, 0, D3DDECLTYPE_FLOAT3, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_POSITION, 0}, + {1, 0, D3DDECLTYPE_D3DCOLOR, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_COLOR, 0}, + D3DDECL_END() + }; + static const struct + { + struct vec3 position; + DWORD diffuse; + } + quad[] = + { + {{-1.0f, -1.0f, 0.0f}, 0xffff0000}, + {{-1.0f, 1.0f, 0.0f}, 0xff00ff00}, + {{ 1.0f, -1.0f, 0.0f}, 0xff0000ff}, + {{ 1.0f, 1.0f, 0.0f}, 0xffffffff}, + }; + static const struct vec3 quad_s0[] = + { + {-1.0f, -1.0f, 0.0f}, + {-1.0f, 1.0f, 0.0f}, + { 1.0f, -1.0f, 0.0f}, + { 1.0f, 1.0f, 0.0f}, + }; + static const DWORD quad_s1[] = + { + 0xffff0000, + 0xff00ff00, + 0xff0000ff, + 0xffffffff, + }; + static const short indices[] = {0, 1, 2, 3}; + + window = create_window(); + ok(!!window, "Failed to create a window.\n"); + + d3d = Direct3DCreate9(D3D_SDK_VERSION); + ok(!!d3d, "Failed to create a D3D object.\n"); + if (!(device = create_device(d3d, window, window, TRUE))) + { + skip("Failed to create a D3D device, skipping tests.\n"); + IDirect3D9_Release(d3d); + DestroyWindow(window); + return; + } + + hr = IDirect3DDevice9_SetRenderState(device, D3DRS_LIGHTING, FALSE); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_CreateVertexBuffer(device, sizeof(quad), 0, 0, D3DPOOL_SYSTEMMEM, &vb, NULL); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DVertexBuffer9_Lock(vb, 0, sizeof(quad), (void **)&data, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, quad, sizeof(quad)); + hr = IDirect3DVertexBuffer9_Unlock(vb); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x77777777, 0.0f, 0); + ok(SUCCEEDED(hr), "Failed to clear depth/stencil, hr %#x.\n", hr); + + hr = IDirect3DDevice9_SetFVF(device, D3DFVF_XYZ | D3DFVF_DIFFUSE); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_SetStreamSource(device, 0, vb, 0, sizeof(*quad)); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_BeginScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_DrawPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 2); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_EndScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + colour = getPixelColor(device, 320, 240); + ok(color_match(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + + hr = IDirect3DDevice9_CreateIndexBuffer(device, sizeof(indices), 0, + D3DFMT_INDEX16, D3DPOOL_SYSTEMMEM, &ib, NULL); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DIndexBuffer9_Lock(ib, 0, sizeof(indices), (void **)&data, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, indices, sizeof(indices)); + hr = IDirect3DIndexBuffer9_Unlock(ib); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x77777777, 0.0f, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_SetIndices(device, ib); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_BeginScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_DrawIndexedPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 0, 4, 0, 2); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_EndScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + colour = getPixelColor(device, 320, 240); + ok(color_match(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + + hr = IDirect3DDevice9_CreateVertexDeclaration(device, decl_elements, &vertex_declaration); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_SetVertexDeclaration(device, vertex_declaration); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_CreateVertexBuffer(device, sizeof(quad_s0), 0, 0, D3DPOOL_SYSTEMMEM, &vb_s0, NULL); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DVertexBuffer9_Lock(vb_s0, 0, sizeof(quad_s0), (void **)&data, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, quad_s0, sizeof(quad_s0)); + hr = IDirect3DVertexBuffer9_Unlock(vb_s0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_CreateVertexBuffer(device, sizeof(quad_s1), 0, 0, D3DPOOL_SYSTEMMEM, &vb_s1, NULL); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DVertexBuffer9_Lock(vb_s1, 0, sizeof(quad_s1), (void **)&data, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + memcpy(data, quad_s1, sizeof(quad_s1)); + hr = IDirect3DVertexBuffer9_Unlock(vb_s1); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_SetStreamSource(device, 0, vb_s0, 0, sizeof(*quad_s0)); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_SetStreamSource(device, 1, vb_s1, 0, sizeof(*quad_s1)); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x77777777, 0.0f, 0); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + hr = IDirect3DDevice9_BeginScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_DrawIndexedPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 0, 4, 0, 2); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + hr = IDirect3DDevice9_EndScene(device); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + colour = getPixelColor(device, 320, 240); + ok(color_match(colour, 0x00007f7f, 1), "Got unexpected colour 0x%08x.\n", colour); + + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); + ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); + + IDirect3DVertexBuffer9_Release(vb_s1); + IDirect3DVertexBuffer9_Release(vb_s0); + IDirect3DVertexDeclaration9_Release(vertex_declaration); + IDirect3DIndexBuffer9_Release(ib); + IDirect3DVertexBuffer9_Release(vb); + refcount = IDirect3DDevice9_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); + IDirect3D9_Release(d3d); + DestroyWindow(window); +} + START_TEST(visual) { D3DADAPTER_IDENTIFIER9 identifier; @@ -24335,4 +24501,5 @@ START_TEST(visual) test_null_format(); test_map_synchronisation(); test_color_vertex(); + test_sysmem_draw(); } -- 2.11.0

2 1

[PATCH 1/5] d3d9: Support drawing from D3DPOOL_SYSTEMMEM vertex buffers.
by Henri Verbeet 17 Dec '18

17 Dec '18

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45486 Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- dlls/d3d9/buffer.c | 24 ++++++++++++++++--- dlls/d3d9/d3d9_private.h | 11 ++++++--- dlls/d3d9/device.c | 60 +++++++++++++++++++++++++++++++++++++++++++----- dlls/d3d9/stateblock.c | 17 ++++++++++++++ 4 files changed, 100 insertions(+), 12 deletions(-) diff --git a/dlls/d3d9/buffer.c b/dlls/d3d9/buffer.c index 02b3570402f..15b7e2bdbce 100644 --- a/dlls/d3d9/buffer.c +++ b/dlls/d3d9/buffer.c @@ -59,6 +59,8 @@ static ULONG WINAPI d3d9_vertexbuffer_AddRef(IDirect3DVertexBuffer9 *iface) IDirect3DDevice9Ex_AddRef(buffer->parent_device); wined3d_mutex_lock(); wined3d_buffer_incref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_incref(buffer->draw_buffer); wined3d_mutex_unlock(); } @@ -78,6 +80,8 @@ static ULONG WINAPI d3d9_vertexbuffer_Release(IDirect3DVertexBuffer9 *iface) wined3d_mutex_lock(); wined3d_buffer_decref(buffer->wined3d_buffer); + if (buffer->draw_buffer) + wined3d_buffer_decref(buffer->draw_buffer); wined3d_mutex_unlock(); /* Release the device last, as it may cause the device to be destroyed. */ @@ -274,6 +278,7 @@ static const struct wined3d_parent_ops d3d9_vertexbuffer_wined3d_parent_ops = HRESULT vertexbuffer_init(struct d3d9_vertexbuffer *buffer, struct d3d9_device *device, UINT size, UINT usage, DWORD fvf, D3DPOOL pool) { + const struct wined3d_parent_ops *parent_ops = &d3d9_null_wined3d_parent_ops; struct wined3d_buffer_desc desc; HRESULT hr; @@ -299,15 +304,28 @@ HRESULT vertexbuffer_init(struct d3d9_vertexbuffer *buffer, struct d3d9_device * desc.byte_width = size; desc.usage = usage & WINED3DUSAGE_MASK; - desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + desc.bind_flags = 0; desc.access = wined3daccess_from_d3dpool(pool, usage) | WINED3D_RESOURCE_ACCESS_MAP_R | WINED3D_RESOURCE_ACCESS_MAP_W; desc.misc_flags = 0; desc.structure_byte_stride = 0; + if (desc.access & WINED3D_RESOURCE_ACCESS_GPU) + { + desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + parent_ops = &d3d9_vertexbuffer_wined3d_parent_ops; + } + wined3d_mutex_lock(); - hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, - &d3d9_vertexbuffer_wined3d_parent_ops, &buffer->wined3d_buffer); + hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, parent_ops, &buffer->wined3d_buffer); + if (SUCCEEDED(hr) && !(desc.access & WINED3D_RESOURCE_ACCESS_GPU)) + { + desc.bind_flags = WINED3D_BIND_VERTEX_BUFFER; + desc.access = WINED3D_RESOURCE_ACCESS_GPU; + if (FAILED(hr = wined3d_buffer_create(device->wined3d_device, &desc, NULL, buffer, + &d3d9_vertexbuffer_wined3d_parent_ops, &buffer->draw_buffer))) + wined3d_buffer_decref(buffer->wined3d_buffer); + } wined3d_mutex_unlock(); if (FAILED(hr)) { diff --git a/dlls/d3d9/d3d9_private.h b/dlls/d3d9/d3d9_private.h index d6155eba60b..bd6409ffaf5 100644 --- a/dlls/d3d9/d3d9_private.h +++ b/dlls/d3d9/d3d9_private.h @@ -42,6 +42,7 @@ #define D3D9_MAX_VERTEX_SHADER_CONSTANTF 256 #define D3D9_MAX_TEXTURE_UNITS 20 +#define D3D9_MAX_STREAMS 16 #define D3DPRESENTFLAGS_MASK 0x00000fffu @@ -102,9 +103,12 @@ struct d3d9_device struct d3d9_surface *render_targets[D3D_MAX_SIMULTANEOUS_RENDERTARGETS]; LONG device_state; - BOOL in_destruction; - BOOL in_scene; - BOOL has_vertex_declaration; + DWORD sysmem_vb : 16; /* D3D9_MAX_STREAMS */ + DWORD in_destruction : 1; + DWORD in_scene : 1; + DWORD has_vertex_declaration : 1; + DWORD recording : 1; + DWORD padding : 12; unsigned int max_user_clip_planes; @@ -181,6 +185,7 @@ struct d3d9_vertexbuffer struct d3d9_resource resource; struct wined3d_buffer *wined3d_buffer; IDirect3DDevice9Ex *parent_device; + struct wined3d_buffer *draw_buffer; DWORD fvf; }; diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index f19e2ae6f65..ba84db9338f 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -974,6 +974,7 @@ static HRESULT d3d9_device_reset(struct d3d9_device *device, if (!extended) { + device->recording = FALSE; wined3d_device_set_render_state(device->wined3d_device, WINED3D_RS_ZENABLE, !!swapchain_desc.enable_auto_depth_stencil); } @@ -2317,7 +2318,8 @@ static HRESULT WINAPI d3d9_device_BeginStateBlock(IDirect3DDevice9Ex *iface) TRACE("iface %p.\n", iface); wined3d_mutex_lock(); - hr = wined3d_device_begin_stateblock(device->wined3d_device); + if (SUCCEEDED(hr = wined3d_device_begin_stateblock(device->wined3d_device))) + device->recording = TRUE; wined3d_mutex_unlock(); return hr; @@ -2340,6 +2342,7 @@ static HRESULT WINAPI d3d9_device_EndStateBlock(IDirect3DDevice9Ex *iface, IDire WARN("Failed to end the state block, hr %#x.\n", hr); return hr; } + device->recording = FALSE; if (!(object = heap_alloc_zero(sizeof(*object)))) { @@ -2688,10 +2691,38 @@ static void d3d9_generate_auto_mipmaps(struct d3d9_device *device) } } +static void d3d9_device_upload_sysmem_vertex_buffers(struct d3d9_device *device, + unsigned int start_vertex, unsigned int vertex_count) +{ + struct wined3d_box box = {0, 0, 0, 1, 0, 1}; + struct d3d9_vertexbuffer *d3d9_buffer; + unsigned int i, offset, stride, map; + struct wined3d_buffer *dst_buffer; + HRESULT hr; + + map = device->sysmem_vb; + while (map) + { + i = ffs(map) - 1; + map ^= 1u << i; + + if (FAILED(hr = wined3d_device_get_stream_source(device->wined3d_device, i, &dst_buffer, &offset, &stride))) + ERR("Failed to get stream source.\n"); + d3d9_buffer = wined3d_buffer_get_parent(dst_buffer); + box.left = offset + start_vertex * stride; + box.right = box.left + vertex_count * stride; + if (FAILED(hr = wined3d_device_copy_sub_resource_region(device->wined3d_device, + wined3d_buffer_get_resource(dst_buffer), 0, box.left, 0, 0, + wined3d_buffer_get_resource(d3d9_buffer->wined3d_buffer), 0, &box, 0))) + ERR("Failed to update buffer.\n"); + } +} + static HRESULT WINAPI d3d9_device_DrawPrimitive(IDirect3DDevice9Ex *iface, D3DPRIMITIVETYPE primitive_type, UINT start_vertex, UINT primitive_count) { struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); + unsigned int vertex_count; HRESULT hr; TRACE("iface %p, primitive_type %#x, start_vertex %u, primitive_count %u.\n", @@ -2704,10 +2735,11 @@ static HRESULT WINAPI d3d9_device_DrawPrimitive(IDirect3DDevice9Ex *iface, WARN("Called without a valid vertex declaration set.\n"); return D3DERR_INVALIDCALL; } + vertex_count = vertex_count_from_primitive_count(primitive_type, primitive_count); + d3d9_device_upload_sysmem_vertex_buffers(device, start_vertex, vertex_count); d3d9_generate_auto_mipmaps(device); wined3d_device_set_primitive_type(device->wined3d_device, primitive_type, 0); - hr = wined3d_device_draw_primitive(device->wined3d_device, start_vertex, - vertex_count_from_primitive_count(primitive_type, primitive_count)); + hr = wined3d_device_draw_primitive(device->wined3d_device, start_vertex, vertex_count); if (SUCCEEDED(hr)) d3d9_rts_flag_auto_gen_mipmap(device); wined3d_mutex_unlock(); @@ -2734,6 +2766,7 @@ static HRESULT WINAPI d3d9_device_DrawIndexedPrimitive(IDirect3DDevice9Ex *iface WARN("Called without a valid vertex declaration set.\n"); return D3DERR_INVALIDCALL; } + d3d9_device_upload_sysmem_vertex_buffers(device, min_vertex_idx, vertex_count); d3d9_generate_auto_mipmaps(device); wined3d_device_set_base_vertex_index(device->wined3d_device, base_vertex_idx); wined3d_device_set_primitive_type(device->wined3d_device, primitive_type, 0); @@ -3378,6 +3411,7 @@ static HRESULT WINAPI d3d9_device_SetStreamSource(IDirect3DDevice9Ex *iface, { struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); struct d3d9_vertexbuffer *buffer_impl = unsafe_impl_from_IDirect3DVertexBuffer9(buffer); + struct wined3d_buffer *wined3d_buffer; HRESULT hr; TRACE("iface %p, stream_idx %u, buffer %p, offset %u, stride %u.\n", @@ -3386,14 +3420,28 @@ static HRESULT WINAPI d3d9_device_SetStreamSource(IDirect3DDevice9Ex *iface, wined3d_mutex_lock(); if (!stride) { - struct wined3d_buffer *wined3d_buffer; unsigned int cur_offset; hr = wined3d_device_get_stream_source(device->wined3d_device, stream_idx, &wined3d_buffer, &cur_offset, &stride); } - hr = wined3d_device_set_stream_source(device->wined3d_device, stream_idx, - buffer_impl ? buffer_impl->wined3d_buffer : NULL, offset, stride); + + if (!buffer_impl) + wined3d_buffer = NULL; + else if (buffer_impl->draw_buffer) + wined3d_buffer = buffer_impl->draw_buffer; + else + wined3d_buffer = buffer_impl->wined3d_buffer; + + hr = wined3d_device_set_stream_source(device->wined3d_device, stream_idx, wined3d_buffer, offset, stride); + if (SUCCEEDED(hr) && !device->recording) + { + if (buffer_impl && buffer_impl->draw_buffer) + device->sysmem_vb |= (1u << stream_idx); + else + device->sysmem_vb &= ~(1u << stream_idx); + } + wined3d_mutex_unlock(); return hr; diff --git a/dlls/d3d9/stateblock.c b/dlls/d3d9/stateblock.c index 62b3bacb28d..440df0c1e1a 100644 --- a/dlls/d3d9/stateblock.c +++ b/dlls/d3d9/stateblock.c @@ -108,11 +108,28 @@ static HRESULT WINAPI d3d9_stateblock_Capture(IDirect3DStateBlock9 *iface) static HRESULT WINAPI d3d9_stateblock_Apply(IDirect3DStateBlock9 *iface) { struct d3d9_stateblock *stateblock = impl_from_IDirect3DStateBlock9(iface); + struct wined3d_buffer *wined3d_buffer; + struct d3d9_vertexbuffer *buffer; + unsigned int i, offset, stride; + struct d3d9_device *device; + HRESULT hr; TRACE("iface %p.\n", iface); wined3d_mutex_lock(); wined3d_stateblock_apply(stateblock->wined3d_stateblock); + device = impl_from_IDirect3DDevice9Ex(stateblock->parent_device); + device->sysmem_vb = 0; + for (i = 0; i < D3D9_MAX_STREAMS; ++i) + { + if (FAILED(hr = wined3d_device_get_stream_source(device->wined3d_device, + i, &wined3d_buffer, &offset, &stride))) + continue; + if (!wined3d_buffer || !(buffer = wined3d_buffer_get_parent(wined3d_buffer))) + continue; + if (buffer->draw_buffer) + device->sysmem_vb |= 1u << i; + } wined3d_mutex_unlock(); return D3D_OK; -- 2.11.0

2 1

[PATCH] wined3d: Make wined3d_adapter_init_format_info() static.
by Francois Gouget 17 Dec '18

17 Dec '18

It is no longer referenced in other source files. Signed-off-by: Francois Gouget <fgouget(a)free.fr> --- dlls/wined3d/utils.c | 2 +- dlls/wined3d/wined3d_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index aa68799535e..f8da256b07e 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -3971,7 +3971,7 @@ static void init_format_depth_bias_scale(struct wined3d_adapter *adapter, } } -BOOL wined3d_adapter_init_format_info(struct wined3d_adapter *adapter, size_t format_size) +static BOOL wined3d_adapter_init_format_info(struct wined3d_adapter *adapter, size_t format_size) { unsigned int count = WINED3D_FORMAT_COUNT + ARRAY_SIZE(typeless_depth_stencil_formats); diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 5a6715a5906..6e39db4fa86 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2707,7 +2707,6 @@ struct wined3d_caps_gl_ctx GLuint test_program_id; }; -BOOL wined3d_adapter_init_format_info(struct wined3d_adapter *adapter, size_t format_size) DECLSPEC_HIDDEN; BOOL wined3d_adapter_gl_init_format_info(struct wined3d_adapter *adapter, struct wined3d_caps_gl_ctx *ctx) DECLSPEC_HIDDEN; BOOL wined3d_adapter_no3d_init_format_info(struct wined3d_adapter *adapter) DECLSPEC_HIDDEN; -- 2.19.2

2 1

Saving file not working in FMSLogo using wine
by sathish kumar 17 Dec '18

17 Dec '18

I am using Boss Linux 7.0 64Bit which is using GNOME 3.22Wine is 1.8.7.FMSLogo 7.3.0 is 32bit I am able to run FMSLogo using wine successfully.But i am not able to save the current logo file.When i try to save it, a file with the provided name is created, but with 0 bytes. Anyone has faced saving file issue ?Anyway to debug ? Thanks,B.Sathish Kumar

3 2

[PATCH] setupapi/tests: Fix returned value checking.
by Zhiyi Zhang 17 Dec '18

17 Dec '18

SetupDiCreateDeviceInfoList returns INVALID_HANDLE_VALUE(~0) on error instead of NULL. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/setupapi/tests/devinst.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/setupapi/tests/devinst.c b/dlls/setupapi/tests/devinst.c index bfffcb9c32..b4c5ce67ed 100644 --- a/dlls/setupapi/tests/devinst.c +++ b/dlls/setupapi/tests/devinst.c @@ -286,7 +286,7 @@ static void test_device_info(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device info, error %#x.\n", GetLastError()); + ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device info, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiCreateDeviceInfoA(set, "Root\\LEGACY_BOGUS\\0000", NULL, NULL, NULL, 0, NULL); @@ -366,7 +366,7 @@ static void test_device_info(void) SetupDiDestroyDeviceInfoList(set); set = SetupDiCreateDeviceInfoList(NULL, NULL); - ok(set != NULL, "Failed to create device info, error %#x.\n", GetLastError()); + ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device info, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiCreateDeviceInfoA(set, "Root\\LEGACY_BOGUS\\0000", NULL, NULL, NULL, 0, NULL); @@ -427,7 +427,7 @@ static void test_get_device_instance_id(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiGetDeviceInstanceIdA(set, NULL, NULL, 0, NULL); @@ -485,7 +485,7 @@ static void test_register_device_info(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiRegisterDeviceInfo(set, NULL, 0, NULL, NULL, NULL); @@ -528,7 +528,7 @@ static void test_register_device_info(void) SetupDiDestroyDeviceInfoList(set); set = SetupDiGetClassDevsA(&guid, NULL, NULL, 0); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); check_device_info(set, 0, &guid, "Root\\LEGACY_BOGUS\\0000"); check_device_info(set, 1, &guid, "Root\\LEGACY_BOGUS\\0002"); @@ -596,7 +596,7 @@ static void test_device_iface(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiCreateDeviceInterfaceA(set, NULL, NULL, NULL, 0, NULL); @@ -697,7 +697,7 @@ static void test_device_iface_detail(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); SetLastError(0xdeadbeef); ret = SetupDiGetDeviceInterfaceDetailA(set, NULL, NULL, 0, NULL, NULL); @@ -787,7 +787,7 @@ static void test_device_key(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "Got unexpected error %#x.\n", GetLastError()); set = SetupDiCreateDeviceInfoList(&guid, NULL); - ok(set != NULL, "Failed to create device list, error %#x.\n", GetLastError()); + ok(set && set != INVALID_HANDLE_VALUE, "Failed to create device list, error %#x.\n", GetLastError()); res = RegOpenKeyW(HKEY_LOCAL_MACHINE, bogus, &key); ok(res != ERROR_SUCCESS, "Key should not exist.\n"); -- 2.19.2

2 1

[PATCH vkd3d 4/7] vkd3d: Validate RTV format for inactive render targets in pipeline state desc.
by Józef Kucia 17 Dec '18

17 Dec '18

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- libs/vkd3d/state.c | 9 +++++++++ tests/d3d12.c | 7 +++++++ 2 files changed, 16 insertions(+) diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c index 9c2d3ac114cd..b2f177c9798d 100644 --- a/libs/vkd3d/state.c +++ b/libs/vkd3d/state.c @@ -1945,6 +1945,15 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s memset(&input_signature, 0, sizeof(input_signature)); + for (i = desc->NumRenderTargets; i < ARRAY_SIZE(desc->RTVFormats); ++i) + { + if (desc->RTVFormats[i] != DXGI_FORMAT_UNKNOWN) + { + WARN("Format must be set to DXGI_FORMAT_UNKNOWN for inactive render targets.\n"); + return E_INVALIDARG; + } + } + if (!(root_signature = unsafe_impl_from_ID3D12RootSignature(desc->pRootSignature))) { WARN("Root signature is NULL.\n"); diff --git a/tests/d3d12.c b/tests/d3d12.c index 420d7519de88..b96ca430361f 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -2491,6 +2491,13 @@ static void test_create_graphics_pipeline_state(void) ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); ID3D12PipelineState_Release(pipeline_state); + /* Inactive render targets formats must be set to DXGI_FORMAT_UNKNOWN. */ + init_pipeline_state_desc(&pso_desc, root_signature, DXGI_FORMAT_R8G8B8A8_UNORM, NULL, NULL, NULL); + pso_desc.RTVFormats[1] = DXGI_FORMAT_R8G8B8A8_UNORM; + hr = ID3D12Device_CreateGraphicsPipelineState(device, &pso_desc, + &IID_ID3D12PipelineState, (void **)&pipeline_state); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + refcount = ID3D12RootSignature_Release(root_signature); ok(!refcount, "ID3D12RootSignature has %u references left.\n", (unsigned int)refcount); refcount = ID3D12Device_Release(device); -- 2.19.2

2 1

[PATCH vkd3d 7/7] tests: Skip stencil shader resource view tests on Windows AMD drivers.
by Józef Kucia 17 Dec '18

17 Dec '18

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- We also skip similar wine/d3d11/tests on AMD. --- tests/d3d12.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/d3d12.c b/tests/d3d12.c index 7fe54c94d713..7d67de2966dd 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -14689,6 +14689,8 @@ static void test_depth_stencil_sampling(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + reset_command_list(command_list, context.allocator); init_depth_stencil(&ds, device, context.render_target_desc.Width, @@ -14753,6 +14755,13 @@ static void test_depth_stencil_sampling(void) destroy_depth_stencil(&ds); continue; } + if (is_amd_device(device)) + { + skip("Reads from depth/stencil shader resource views return stale values on some AMD drivers.\n"); + destroy_depth_stencil(&ds); + continue; + } + srv_desc.Format = tests[i].stencil_view_format; srv_desc.Texture2D.PlaneSlice = 1; ID3D12Device_CreateShaderResourceView(device, texture, &srv_desc, srv_cpu_handle); @@ -14791,6 +14800,7 @@ static void test_depth_stencil_sampling(void) destroy_depth_stencil(&ds); } + vkd3d_test_set_context(NULL); ID3D12Resource_Release(cb); ID3D12DescriptorHeap_Release(srv_heap); -- 2.19.2

2 1

[PATCH vkd3d 3/7] tests: Add test for dual source blending.
by Józef Kucia 17 Dec '18

17 Dec '18

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- tests/d3d12.c | 131 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+) diff --git a/tests/d3d12.c b/tests/d3d12.c index 463e3046af66..420d7519de88 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -21488,6 +21488,136 @@ static void test_blend_factor(void) destroy_test_context(&context); } +static void test_dual_source_blending(void) +{ + static const float white[] = {1.0f, 1.0f, 1.0f, 1.0f}; + D3D12_GRAPHICS_PIPELINE_STATE_DESC pso_desc; + ID3D12GraphicsCommandList *command_list; + struct test_context_desc desc; + struct test_context context; + ID3D12CommandQueue *queue; + unsigned int i; + HRESULT hr; + + static const DWORD ps_code[] = + { +#if 0 + float4 c0; + float4 c1; + + void main(out float4 o0 : SV_Target0, out float4 o1 : SV_Target1) + { + o0 = c0; + o1 = c1; + } +#endif + 0x43425844, 0x823a4ecf, 0xd409abf6, 0xe76697ab, 0x9b53c9a5, 0x00000001, 0x000000f8, 0x00000003, + 0x0000002c, 0x0000003c, 0x00000088, 0x4e475349, 0x00000008, 0x00000000, 0x00000008, 0x4e47534f, + 0x00000044, 0x00000002, 0x00000008, 0x00000038, 0x00000000, 0x00000000, 0x00000003, 0x00000000, + 0x0000000f, 0x00000038, 0x00000001, 0x00000000, 0x00000003, 0x00000001, 0x0000000f, 0x545f5653, + 0x65677261, 0xabab0074, 0x58454853, 0x00000068, 0x00000050, 0x0000001a, 0x0100086a, 0x04000059, + 0x00208e46, 0x00000000, 0x00000002, 0x03000065, 0x001020f2, 0x00000000, 0x03000065, 0x001020f2, + 0x00000001, 0x06000036, 0x001020f2, 0x00000000, 0x00208e46, 0x00000000, 0x00000000, 0x06000036, + 0x001020f2, 0x00000001, 0x00208e46, 0x00000000, 0x00000001, 0x0100003e, + }; + static const D3D12_SHADER_BYTECODE ps = {ps_code, sizeof(ps_code)}; + static const struct + { + struct + { + struct vec4 c0; + struct vec4 c1; + } constants; + unsigned int expected_color; + } + tests[] = + { + {{{0.0f, 0.0f, 0.0f, 0.0f}, {0.0f, 0.0f, 0.0f, 0.0f}}, 0x00000000}, + {{{0.0f, 0.0f, 0.0f, 0.0f}, {1.0f, 0.0f, 0.0f, 1.0f}}, 0xff0000ff}, + {{{1.0f, 0.0f, 0.0f, 1.0f}, {0.0f, 0.0f, 0.0f, 0.0f}}, 0xff0000ff}, + {{{1.0f, 0.0f, 0.0f, 1.0f}, {0.0f, 1.0f, 1.0f, 0.0f}}, 0xffffffff}, + }; + + memset(&desc, 0, sizeof(desc)); + desc.no_root_signature = true; + if (!init_test_context(&context, &desc)) + return; + command_list = context.list; + queue = context.queue; + + context.root_signature = create_32bit_constants_root_signature(context.device, + 0, sizeof(tests->constants) / sizeof(uint32_t), D3D12_SHADER_VISIBILITY_PIXEL); + + init_pipeline_state_desc(&pso_desc, context.root_signature, + context.render_target_desc.Format, NULL, &ps, NULL); + pso_desc.BlendState.RenderTarget[0].BlendEnable = TRUE; + pso_desc.BlendState.RenderTarget[0].SrcBlend = D3D12_BLEND_SRC_COLOR; + pso_desc.BlendState.RenderTarget[0].DestBlend = D3D12_BLEND_SRC1_COLOR; + pso_desc.BlendState.RenderTarget[0].BlendOp = D3D12_BLEND_OP_ADD; + pso_desc.BlendState.RenderTarget[0].SrcBlendAlpha = D3D12_BLEND_SRC_ALPHA; + pso_desc.BlendState.RenderTarget[0].DestBlendAlpha = D3D12_BLEND_SRC1_ALPHA; + pso_desc.BlendState.RenderTarget[0].BlendOpAlpha = D3D12_BLEND_OP_ADD; + hr = ID3D12Device_CreateGraphicsPipelineState(context.device, &pso_desc, + &IID_ID3D12PipelineState, (void **)&context.pipeline_state); + ok(hr == S_OK, "Failed to create pipeline, hr %#x.\n", hr); + + for (i = 0; i < ARRAY_SIZE(tests); ++i) + { + ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL); + ID3D12GraphicsCommandList_OMSetRenderTargets(command_list, 1, &context.rtv, FALSE, NULL); + ID3D12GraphicsCommandList_SetGraphicsRootSignature(command_list, context.root_signature); + ID3D12GraphicsCommandList_SetPipelineState(command_list, context.pipeline_state); + ID3D12GraphicsCommandList_IASetPrimitiveTopology(command_list, D3D_PRIMITIVE_TOPOLOGY_TRIANGLELIST); + ID3D12GraphicsCommandList_RSSetViewports(command_list, 1, &context.viewport); + ID3D12GraphicsCommandList_RSSetScissorRects(command_list, 1, &context.scissor_rect); + ID3D12GraphicsCommandList_SetGraphicsRoot32BitConstants(command_list, 0, 8, &tests[i].constants, 0); + ID3D12GraphicsCommandList_DrawInstanced(command_list, 3, 1, 0, 0); + transition_resource_state(command_list, context.render_target, + D3D12_RESOURCE_STATE_RENDER_TARGET, D3D12_RESOURCE_STATE_COPY_SOURCE); + check_sub_resource_uint(context.render_target, 0, queue, command_list, tests[i].expected_color, 1); + + reset_command_list(command_list, context.allocator); + transition_resource_state(command_list, context.render_target, + D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); + } + + ID3D12PipelineState_Release(context.pipeline_state); + pso_desc.BlendState.IndependentBlendEnable = TRUE; + hr = ID3D12Device_CreateGraphicsPipelineState(context.device, &pso_desc, + &IID_ID3D12PipelineState, (void **)&context.pipeline_state); + ok(hr == S_OK, "Failed to create pipeline, hr %#x.\n", hr); + ID3D12PipelineState_Release(context.pipeline_state); + context.pipeline_state = NULL; + + pso_desc.BlendState.RenderTarget[1] = pso_desc.BlendState.RenderTarget[0]; + hr = ID3D12Device_CreateGraphicsPipelineState(context.device, &pso_desc, + &IID_ID3D12PipelineState, (void **)&context.pipeline_state); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + + pso_desc.BlendState.RenderTarget[1].DestBlendAlpha = D3D12_BLEND_SRC_ALPHA; + pso_desc.BlendState.RenderTarget[1].DestBlend = D3D12_BLEND_SRC_COLOR; + hr = ID3D12Device_CreateGraphicsPipelineState(context.device, &pso_desc, + &IID_ID3D12PipelineState, (void **)&context.pipeline_state); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + context.pipeline_state = NULL; + + pso_desc.NumRenderTargets = 2; + pso_desc.RTVFormats[1] = pso_desc.RTVFormats[0]; + pso_desc.BlendState.IndependentBlendEnable = FALSE; + pso_desc.BlendState.RenderTarget[0].BlendEnable = TRUE; + pso_desc.BlendState.RenderTarget[0].SrcBlend = D3D12_BLEND_SRC_COLOR; + pso_desc.BlendState.RenderTarget[0].DestBlend = D3D12_BLEND_SRC1_COLOR; + pso_desc.BlendState.RenderTarget[0].BlendOp = D3D12_BLEND_OP_ADD; + pso_desc.BlendState.RenderTarget[0].SrcBlendAlpha = D3D12_BLEND_SRC_ALPHA; + pso_desc.BlendState.RenderTarget[0].DestBlendAlpha = D3D12_BLEND_SRC1_ALPHA; + pso_desc.BlendState.RenderTarget[0].BlendOpAlpha = D3D12_BLEND_OP_ADD; + hr = ID3D12Device_CreateGraphicsPipelineState(context.device, &pso_desc, + &IID_ID3D12PipelineState, (void **)&context.pipeline_state); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + + destroy_test_context(&context); +} + static void test_multisample_rendering(void) { static const float white[] = {1.0f, 1.0f, 1.0f, 1.0f}; @@ -21949,6 +22079,7 @@ START_TEST(d3d12) run_test(test_suballocate_small_textures); run_test(test_command_list_initial_pipeline_state); run_test(test_blend_factor); + run_test(test_dual_source_blending); run_test(test_multisample_rendering); run_test(test_primitive_restart); } -- 2.19.2

2 1

[PATCH vkd3d 1/7] vkd3d-shader: Add support for dual source blending.
by Józef Kucia 17 Dec '18

17 Dec '18

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- include/vkd3d_shader.h | 1 + libs/vkd3d-shader/spirv.c | 19 ++++++++++++++++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index 7d9bf70e3131..1153fdea0a0d 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -165,6 +165,7 @@ struct vkd3d_shader_compile_arguments const void *next; enum vkd3d_shader_target target; + bool dual_source_blending; const unsigned int *output_swizzles; unsigned int output_swizzle_count; }; diff --git a/libs/vkd3d-shader/spirv.c b/libs/vkd3d-shader/spirv.c index ec7cab693c84..a24585c542da 100644 --- a/libs/vkd3d-shader/spirv.c +++ b/libs/vkd3d-shader/spirv.c @@ -3400,6 +3400,14 @@ static unsigned int get_shader_output_swizzle(const struct vkd3d_dxbc_compiler * return compile_args->output_swizzles[register_idx]; } +static bool is_dual_source_blending(const struct vkd3d_dxbc_compiler *compiler) +{ + const struct vkd3d_shader_compile_arguments *compile_args = compiler->compile_args; + + return compiler->shader_type == VKD3D_SHADER_TYPE_PIXEL + && compile_args && compile_args->dual_source_blending; +} + static void calculate_clip_or_cull_distance_mask(const struct vkd3d_shader_signature_element *e, uint32_t *mask) { @@ -3544,7 +3552,16 @@ static void vkd3d_dxbc_compiler_emit_output(struct vkd3d_dxbc_compiler *compiler } else { - vkd3d_spirv_build_op_decorate1(builder, id, SpvDecorationLocation, reg->idx[0].offset); + if (is_dual_source_blending(compiler) && reg->idx[0].offset < 2) + { + vkd3d_spirv_build_op_decorate1(builder, id, SpvDecorationLocation, 0); + vkd3d_spirv_build_op_decorate1(builder, id, SpvDecorationIndex, reg->idx[0].offset); + } + else + { + vkd3d_spirv_build_op_decorate1(builder, id, SpvDecorationLocation, reg->idx[0].offset); + } + if (component_idx) vkd3d_spirv_build_op_decorate1(builder, id, SpvDecorationComponent, component_idx); } -- 2.19.2

2 1

[PATCH vkd3d 2/7] vkd3d: Implement dual source blending.
by Józef Kucia 17 Dec '18

17 Dec '18

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- libs/vkd3d/state.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/libs/vkd3d/state.c b/libs/vkd3d/state.c index 64c21588a825..9c2d3ac114cd 100644 --- a/libs/vkd3d/state.c +++ b/libs/vkd3d/state.c @@ -1783,6 +1783,21 @@ static void blend_attachment_from_d3d12(struct VkPipelineColorBlendAttachmentSta FIXME("Ignoring LogicOpEnable %#x.\n", d3d12_desc->LogicOpEnable); } +static bool is_dual_source_blending_blend(D3D12_BLEND b) +{ + return b == D3D12_BLEND_SRC1_COLOR || b == D3D12_BLEND_INV_SRC1_COLOR + || b == D3D12_BLEND_SRC1_ALPHA || b == D3D12_BLEND_INV_SRC1_ALPHA; +} + +static bool is_dual_source_blending(const D3D12_RENDER_TARGET_BLEND_DESC *desc) +{ + return desc->BlendEnable + && (is_dual_source_blending_blend(desc->SrcBlend) + || is_dual_source_blending_blend(desc->DestBlend) + || is_dual_source_blending_blend(desc->SrcBlendAlpha) + || is_dual_source_blending_blend(desc->DestBlendAlpha)); +} + static HRESULT compute_input_layout_offsets(const D3D12_INPUT_LAYOUT_DESC *input_layout_desc, uint32_t *offsets) { @@ -2063,9 +2078,29 @@ static HRESULT d3d12_pipeline_state_init_graphics(struct d3d12_pipeline_state *s ps_compile_args.type = VKD3D_SHADER_STRUCTURE_TYPE_COMPILE_ARGUMENTS; ps_compile_args.next = NULL; ps_compile_args.target = VKD3D_SHADER_TARGET_SPIRV_VULKAN_1_0; + ps_compile_args.dual_source_blending = is_dual_source_blending(&desc->BlendState.RenderTarget[0]); ps_compile_args.output_swizzles = ps_output_swizzle; ps_compile_args.output_swizzle_count = rt_count; + if (ps_compile_args.dual_source_blending && rt_count > 1) + { + WARN("Only one render target is allowed when dual source blending is used.\n"); + hr = E_INVALIDARG; + goto fail; + } + if (ps_compile_args.dual_source_blending && desc->BlendState.IndependentBlendEnable) + { + for (i = 1; i < ARRAY_SIZE(desc->BlendState.RenderTarget); ++i) + { + if (desc->BlendState.RenderTarget[i].BlendEnable) + { + WARN("Blend enable cannot be set for render target %u when dual source blending is used.\n", i); + hr = E_INVALIDARG; + goto fail; + } + } + } + shader_interface.type = VKD3D_SHADER_STRUCTURE_TYPE_SHADER_INTERFACE; shader_interface.next = NULL; shader_interface.bindings = root_signature->descriptor_mapping; -- 2.19.2

2 1

[PATCH vkd3d 6/7] tests: Detect device vendor only on Windows.
by Józef Kucia 17 Dec '18

17 Dec '18

From: Józef Kucia <jkucia(a)codeweavers.com> For running cross-compiled tests in Wine. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- In Wine tests we do a similar thing. --- tests/d3d12_crosstest.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/d3d12_crosstest.h b/tests/d3d12_crosstest.h index ee12c891b290..6357d48fe7ea 100644 --- a/tests/d3d12_crosstest.h +++ b/tests/d3d12_crosstest.h @@ -303,6 +303,9 @@ static inline bool is_amd_device(ID3D12Device *device) HRESULT hr; LUID luid; + if (!vkd3d_test_platform_is_windows()) + return false; + luid = ID3D12Device_GetAdapterLuid(device); hr = CreateDXGIFactory1(&IID_IDXGIFactory4, (void **)&factory); -- 2.19.2

2 1

[PATCH vkd3d 5/7] tests: Use vkd3d_test_set_context() in more tests.
by Józef Kucia 17 Dec '18

17 Dec '18

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- tests/d3d12.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/tests/d3d12.c b/tests/d3d12.c index b96ca430361f..7fe54c94d713 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -1749,6 +1749,8 @@ static void test_create_heap(void) { for (j = 0; j < ARRAY_SIZE(heap_flags); ++j) { + vkd3d_test_set_context("Test %u, %u", i, j); + desc.SizeInBytes = 10 * tests[i].alignment; desc.Alignment = tests[i].alignment; desc.Flags = heap_flags[j].flags; @@ -1765,6 +1767,7 @@ static void test_create_heap(void) ok(!refcount, "ID3D12Heap has %u references left.\n", (unsigned int)refcount); } } + vkd3d_test_set_context(NULL); hr = ID3D12Device_CheckFeatureSupport(device, D3D12_FEATURE_D3D12_OPTIONS, &options, sizeof(options)); ok(hr == S_OK, "Failed to check feature support, hr %#x.\n", hr); @@ -3682,6 +3685,8 @@ static void test_clear_unordered_access_view(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + buffer = create_default_buffer(device, BUFFER_SIZE, D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS, D3D12_RESOURCE_STATE_UNORDERED_ACCESS); @@ -3735,6 +3740,7 @@ static void test_clear_unordered_access_view(void) reset_command_list(command_list, context.allocator); ID3D12Resource_Release(buffer); } + vkd3d_test_set_context(NULL); ID3D12DescriptorHeap_Release(cpu_heap); ID3D12DescriptorHeap_Release(gpu_heap); @@ -4811,6 +4817,8 @@ static void test_draw_depth_only(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + ID3D12GraphicsCommandList_ClearDepthStencilView(command_list, ds.dsv_handle, D3D12_CLEAR_FLAG_DEPTH, tests[i].clear_depth, 0, 0, NULL); @@ -4832,6 +4840,7 @@ static void test_draw_depth_only(void) transition_resource_state(command_list, ds.texture, D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_DEPTH_WRITE); } + vkd3d_test_set_context(NULL); ID3D12GraphicsCommandList_ClearDepthStencilView(command_list, ds.dsv_handle, D3D12_CLEAR_FLAG_DEPTH, 1.0f, 0, 0, NULL); @@ -8888,6 +8897,8 @@ static void test_incompletely_initialized_shader_outputs(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL); ID3D12GraphicsCommandList_OMSetRenderTargets(command_list, 1, &context.rtv, FALSE, NULL); @@ -8907,6 +8918,7 @@ static void test_incompletely_initialized_shader_outputs(void) transition_resource_state(command_list, context.render_target, D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); } + vkd3d_test_set_context(NULL); destroy_test_context(&context); } @@ -10265,6 +10277,8 @@ static void test_texture(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + texture = create_default_texture(context.device, tests[i].width, tests[i].height, tests[i].format, 0, D3D12_RESOURCE_STATE_COPY_DEST); upload_texture_data(texture, &tests[i].data, 1, queue, command_list); @@ -10310,6 +10324,7 @@ static void test_texture(void) transition_resource_state(command_list, context.render_target, D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); } + vkd3d_test_set_context(NULL); ID3D12DescriptorHeap_Release(heap); destroy_test_context(&context); @@ -10505,6 +10520,8 @@ static void test_texture_ld(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL); ID3D12GraphicsCommandList_OMSetRenderTargets(command_list, 1, &context.rtv, FALSE, NULL); @@ -10527,6 +10544,7 @@ static void test_texture_ld(void) transition_resource_state(command_list, context.render_target, D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); } + vkd3d_test_set_context(NULL); ID3D12Resource_Release(texture); ID3D12DescriptorHeap_Release(heap); @@ -11657,6 +11675,8 @@ static void test_multisample_array_texture(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL); ID3D12GraphicsCommandList_OMSetRenderTargets(command_list, 1, &context.rtv, FALSE, NULL); ID3D12GraphicsCommandList_SetGraphicsRootSignature(command_list, context.root_signature); @@ -11679,6 +11699,7 @@ static void test_multisample_array_texture(void) transition_resource_state(command_list, context.render_target, D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); } + vkd3d_test_set_context(NULL); transition_resource_state(command_list, uav_buffer, D3D12_RESOURCE_STATE_UNORDERED_ACCESS, D3D12_RESOURCE_STATE_COPY_SOURCE); @@ -14901,6 +14922,8 @@ static void test_depth_load(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + ID3D12GraphicsCommandList_ClearDepthStencilView(command_list, ds.dsv_handle, D3D12_CLEAR_FLAG_DEPTH, tests[i], 0, 0, NULL); transition_sub_resource_state(command_list, ds.texture, 0, @@ -14943,6 +14966,7 @@ static void test_depth_load(void) transition_sub_resource_state(command_list, ds.texture, 0, D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE, D3D12_RESOURCE_STATE_DEPTH_WRITE); } + vkd3d_test_set_context(NULL); destroy_depth_stencil(&ds); ID3D12Resource_Release(texture); @@ -15258,6 +15282,8 @@ static void test_typed_uav_store(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + resource = create_default_texture(device, 32, 32, tests[i].format, D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS, D3D12_RESOURCE_STATE_UNORDERED_ACCESS); ID3D12Device_CreateUnorderedAccessView(device, resource, NULL, NULL, @@ -15292,6 +15318,7 @@ static void test_typed_uav_store(void) reset_command_list(command_list, context.allocator); } + vkd3d_test_set_context(NULL); ID3D12DescriptorHeap_Release(descriptor_heap); destroy_test_context(&context); @@ -16478,6 +16505,8 @@ static void test_cs_uav_store(void) pipeline_state = NULL; for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + if (current_shader != tests[i].shader) { if (pipeline_state) @@ -16510,6 +16539,7 @@ static void test_cs_uav_store(void) D3D12_RESOURCE_STATE_UNORDERED_ACCESS, D3D12_RESOURCE_STATE_COPY_SOURCE); check_sub_resource_float(resource, 0, queue, command_list, tests[i].value, 2); } + vkd3d_test_set_context(NULL); ID3D12PipelineState_Release(pipeline_state); pipeline_state = create_compute_pipeline_state(device, root_signature, cs_1_store); @@ -16958,6 +16988,8 @@ static void test_decrement_uav_counter(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + transition_sub_resource_state(command_list, buffer, 0, D3D12_RESOURCE_STATE_UNORDERED_ACCESS, D3D12_RESOURCE_STATE_COPY_DEST); counter = 0xffffffff; @@ -16989,6 +17021,7 @@ static void test_decrement_uav_counter(void) ok(counter == tests[i].expected_min_value, "Got %u, expected %u.\n", counter, tests[i].expected_min_value); } + vkd3d_test_set_context(NULL); ID3D12Resource_Release(buffer); ID3D12Resource_Release(counter_buffer); @@ -17496,6 +17529,8 @@ static void test_buffer_srv(void) { const struct test *test = &tests[i]; + vkd3d_test_set_context("Test %u", i); + if (current_shader != test->shader) { if (context.pipeline_state) @@ -17568,6 +17603,7 @@ static void test_buffer_srv(void) transition_sub_resource_state(command_list, context.render_target, 0, D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); } + vkd3d_test_set_context(NULL); ID3D12DescriptorHeap_Release(descriptor_heap); ID3D12Resource_Release(buffer); @@ -17887,6 +17923,8 @@ static void test_query_occlusion(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + ID3D12GraphicsCommandList_ClearDepthStencilView(command_list, ds.dsv_handle, D3D12_CLEAR_FLAG_DEPTH, tests[i].clear_depth, 0, 0, NULL); @@ -17902,6 +17940,7 @@ static void test_query_occlusion(void) ID3D12GraphicsCommandList_ResolveQueryData(command_list, query_heap, tests[i].type, i, 1, resource, i * sizeof(UINT64)); } + vkd3d_test_set_context(NULL); get_buffer_readback_with_command_list(resource, DXGI_FORMAT_UNKNOWN, &rb, queue, command_list); for (i = 0; i < ARRAY_SIZE(tests); ++i) @@ -19483,6 +19522,8 @@ static void test_face_culling(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + init_pipeline_state_desc(&pso_desc, context.root_signature, context.render_target_desc.Format, NULL, &ps_color, NULL); pso_desc.RasterizerState.CullMode = tests[i].cull_mode; @@ -19535,10 +19576,13 @@ static void test_face_culling(void) ID3D12PipelineState_Release(pso); } + vkd3d_test_set_context(NULL); /* Test SV_IsFrontFace. */ for (i = 0; i < ARRAY_SIZE(front_tests); ++i) { + vkd3d_test_set_context("Test %u", i); + init_pipeline_state_desc(&pso_desc, context.root_signature, context.render_target_desc.Format, NULL, &ps_front, NULL); pso_desc.RasterizerState.CullMode = D3D12_CULL_MODE_NONE; @@ -19589,6 +19633,7 @@ static void test_face_culling(void) ID3D12PipelineState_Release(pso); } + vkd3d_test_set_context(NULL); ID3D12PipelineState_Release(color_pso); ID3D12PipelineState_Release(ccw_color_pso); @@ -21474,6 +21519,8 @@ static void test_blend_factor(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL); ID3D12GraphicsCommandList_OMSetRenderTargets(command_list, 1, &context.rtv, FALSE, NULL); ID3D12GraphicsCommandList_SetGraphicsRootSignature(command_list, context.root_signature); @@ -21491,6 +21538,7 @@ static void test_blend_factor(void) transition_resource_state(command_list, context.render_target, D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); } + vkd3d_test_set_context(NULL); destroy_test_context(&context); } @@ -21570,6 +21618,8 @@ static void test_dual_source_blending(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL); ID3D12GraphicsCommandList_OMSetRenderTargets(command_list, 1, &context.rtv, FALSE, NULL); ID3D12GraphicsCommandList_SetGraphicsRootSignature(command_list, context.root_signature); @@ -21587,6 +21637,7 @@ static void test_dual_source_blending(void) transition_resource_state(command_list, context.render_target, D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); } + vkd3d_test_set_context(NULL); ID3D12PipelineState_Release(context.pipeline_state); pso_desc.BlendState.IndependentBlendEnable = TRUE; @@ -21905,6 +21956,8 @@ static void test_primitive_restart(void) for (i = 0; i < ARRAY_SIZE(tests); ++i) { + vkd3d_test_set_context("Test %u", i); + buffer_size = (tests[i].last_index + 1) * sizeof(*quad); vb = create_upload_buffer(context.device, buffer_size, NULL); @@ -21968,6 +22021,7 @@ static void test_primitive_restart(void) ID3D12PipelineState_Release(context.pipeline_state); context.pipeline_state = NULL; } + vkd3d_test_set_context(NULL); destroy_test_context(&context); } -- 2.19.2

2 1

[PATCH] [v2] kernel32: Use Rtl function when the time zone name is useless.
by Akihiro Sagawa 17 Dec '18

17 Dec '18

This is v2 patch of "kernel32: Introduce lightweight version of GetTimeZoneInformation." In this version, I remove the wrapper function and properly test the return value of RtlQueryTimeZoneInformation function. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/kernel32/time.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-)

1 0

[PATCH] msvcrt: Use RtlQueryTimeZoneInformation in ftime64.
by Akihiro Sagawa 17 Dec '18

17 Dec '18

This avoids performance issues caused by MUI string extraction (Bug 46266). Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/msvcrt/time.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

1 1

[PATCH] kernel32: Introduce lightweight version of GetTimeZoneInformation.
by Akihiro Sagawa 17 Dec '18

17 Dec '18

This is a workaround for Bug 46266. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/kernel32/time.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-)

3 2

[PATCH] po: Update Korean translation.
by Byeongsik Jeon 17 Dec '18

17 Dec '18

Signed-off-by: Byeongsik Jeon <bsjeon(a)hanmail.net> --- po/ko.po | 973 +++++++++++++++++++++++++++---------------------------- 1 file changed, 479 insertions(+), 494 deletions(-) diff --git a/po/ko.po b/po/ko.po index 4e9f65f8d7..0d9004770f 100644 --- a/po/ko.po +++ b/po/ko.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2018-11-05 10:52+0900\n" +"PO-Revision-Date: 2018-12-17 22:50+0900\n" "Last-Translator: Byeongsik Jeon <bsjeon(a)hanmail.net>\n" "Language-Team: Korean\n" "Language: ko\n" @@ -203,7 +203,7 @@ msgstr "" #: appwiz.rc:36 msgid "Not specified" -msgstr "지정되지 않음" +msgstr "지정하지 않음" #: appwiz.rc:38 shell32.rc:144 shell32.rc:241 regedit.rc:147 winefile.rc:107 msgid "Name" @@ -815,7 +815,7 @@ msgstr "프린터(&R)..." #: comdlg32.rc:462 comdlg32.rc:487 msgid "Look &in:" -msgstr "보기(&I):" +msgstr "위치(&I):" #: comdlg32.rc:468 comdlg32.rc:494 msgid "File &name:" @@ -899,15 +899,15 @@ msgstr "새 폴더 만들기" #: comdlg32.rc:47 msgid "List" -msgstr "목록" +msgstr "간단히" #: comdlg32.rc:48 cryptui.rc:201 msgid "Details" -msgstr "세부사항" +msgstr "자세히" #: comdlg32.rc:49 msgid "Browse to Desktop" -msgstr "바탕 화면 열기" +msgstr "바탕 화면 표시" #: comdlg32.rc:113 msgid "Regular" @@ -1067,7 +1067,7 @@ msgstr "저장(&S)" #: comdlg32.rc:143 msgid "Save &in:" -msgstr "다음 위치에 저장(&I):" +msgstr "위치(&I):" #: comdlg32.rc:144 msgid "Save" @@ -1203,7 +1203,7 @@ msgstr "여백 [인치]" #: comdlg32.rc:80 msgid "Margins [mm]" -msgstr "여백 [mm]" +msgstr "여백 [밀리미터]" #: comdlg32.rc:81 sane.rc:33 msgctxt "unit: millimeters" @@ -1749,7 +1749,7 @@ msgstr "OEM Windows 시스템 구성요소 검증" #: crypt32.rc:152 cryptui.rc:136 msgid "Embedded Windows System Component Verification" -msgstr "내장 Windows 시스템 컴포넌트 확인" +msgstr "내장 Windows 시스템 구성 요소 확인" #: crypt32.rc:153 cryptui.rc:143 msgid "Key Pack Licenses" @@ -2298,7 +2298,7 @@ msgstr "인증서" #: cryptui.rc:345 msgid "I&ntended purpose:" -msgstr "지정된 용도(&N):" +msgstr "용도(&N):" #: cryptui.rc:349 msgid "&Import..." @@ -2895,7 +2895,7 @@ msgstr "콘텐츠를 저장할 파일 이름을 지정합니다." #: cryptui.rc:155 msgid "The specified file already exists. Do you want to replace it?" -msgstr "지정된 파일이 이미 있습니다. 파일을 교체하시겠습니까?" +msgstr "지정한 파일이 이미 있습니다. 파일을 교체하시겠습니까?" #: cryptui.rc:156 msgid "DER-Encoded Binary X.509 (*.cer)" @@ -2965,7 +2965,7 @@ msgstr "참고: 이 인증서의 개인 키는 내보낼 수 없습니다." #: cryptui.rc:177 msgid "Intended Use" -msgstr "지정된 용도" +msgstr "용도" #: cryptui.rc:178 shell32.rc:152 msgid "Location" @@ -4245,7 +4245,7 @@ msgstr "이미 SUBST 타겟입니다.\n" #: winerror.mc:618 msgid "System trace not specified or disallowed.\n" -msgstr "시스템 추적이 지정되지 않았거나 허용되지 않습니다.\n" +msgstr "시스템 추적이 지정하지 않았거나 허용되지 않습니다.\n" #: winerror.mc:623 msgid "Event count for DosMuxSemWait incorrect.\n" @@ -4973,7 +4973,7 @@ msgstr "메시지는 오직 동기 호출에만 사용할 수 있습니다.\n" #: winerror.mc:1528 msgid "The source element is empty.\n" -msgstr "소스 요소가 비어 있습니다.\n" +msgstr "원본 요소가 비어 있습니다.\n" #: winerror.mc:1533 msgid "The destination element is full.\n" @@ -5949,7 +5949,7 @@ msgstr "알 수 없는 특징.\n" #: winerror.mc:2758 msgid "Unknown component.\n" -msgstr "알 수 없는 컴포넌트.\n" +msgstr "알 수 없는 구성 요소.\n" #: winerror.mc:2763 msgid "Unknown property.\n" @@ -5961,7 +5961,7 @@ msgstr "잘못된 핸들 상태.\n" #: winerror.mc:2773 msgid "Bad configuration.\n" -msgstr "나쁜 설정.\n" +msgstr "잘못된 구성.\n" #: winerror.mc:2778 msgid "Index is missing.\n" @@ -5969,7 +5969,7 @@ msgstr "인덱스가 빠짐.\n" #: winerror.mc:2783 msgid "Installation source is missing.\n" -msgstr "설치 원본이 빠짐.\n" +msgstr "설치 원본이 없음.\n" #: winerror.mc:2788 msgid "Wrong installation package version.\n" @@ -6857,26 +6857,26 @@ msgstr "HTML 문서" #: mshtml.rc:29 msgid "Downloading from %s..." -msgstr "%s로부터 다운로드중..." +msgstr "%s에서 다운로드하는 중..." #: mshtml.rc:28 msgid "Done" -msgstr "끝남" +msgstr "완료" #: msi.rc:31 msgid "" "The specified installation package could not be opened. Please check the " "file path and try again." msgstr "" -"지정한 설치 패키지를 열 수 없습니다. 파일 경로를 확인하고 다시 시도하십시오." +"지정한 설치 패키지를 열 수 없습니다. 파일 경로를 검사한 후 다시 시도하십시오." #: msi.rc:32 msgid "path %s not found" -msgstr "%s 경로를 찾을 수 없습니다" +msgstr "경로 %s을(를) 찾을 수 없습니다" #: msi.rc:33 msgid "insert disk %s" -msgstr "디스크 %s 삽입" +msgstr "디스크 %s을(를) 넣으십시오" #: msi.rc:34 msgid "" @@ -6942,19 +6942,19 @@ msgstr "" #: msi.rc:61 msgid "enter which folder contains %s" -msgstr "%s을(를) 포함하는 폴더를 입력하세여" +msgstr "%s을(를) 포함하는 폴더 입력" #: msi.rc:62 msgid "install source for feature missing" -msgstr "빠진 부분(feature)을 위한 설치 원본" +msgstr "기능 누락을 위한 설치 원본" #: msi.rc:63 msgid "network drive for feature missing" -msgstr "빠진 부분(feature)을 위한 네트워크 드라이브" +msgstr "기능 누락을 위한 네트워크 드라이브" #: msi.rc:64 msgid "feature from:" -msgstr "부분(feature)에서:" +msgstr "기능:" #: msi.rc:65 msgid "choose which folder contains %s" @@ -6966,255 +6966,255 @@ msgstr "새 폴더" #: msi.rc:91 msgid "Allocating registry space" -msgstr "레지스트리 공간 할당" +msgstr "레지스트리 공간을 할당하는 중" #: msi.rc:92 msgid "Searching for installed applications" -msgstr "설치된 프로그램 검색" +msgstr "설치한 프로그램을 검색 중" #: msi.rc:93 msgid "Binding executables" -msgstr "실행파일 빌딩" +msgstr "실행 파일을 연결하는 중" #: msi.rc:94 msi.rc:137 msgid "Searching for qualifying products" -msgstr "자격있는 제품 찾는 중" +msgstr "정품을 검색하는 중" #: msi.rc:95 msi.rc:96 msi.rc:101 msgid "Computing space requirements" -msgstr "전산 처리 공간 필요" +msgstr "필요한 공간을 계산하는 중" #: msi.rc:97 msgid "Creating folders" -msgstr "새 폴더" +msgstr "폴더를 만드는 중" #: msi.rc:98 msgid "Creating shortcuts" -msgstr "바로 가기 만들기" +msgstr "바로 가기를 만드는 중" #: msi.rc:99 msgid "Deleting services" -msgstr "서비스 제거" +msgstr "서비스를 삭제하는 중" #: msi.rc:100 msgid "Creating duplicate files" -msgstr "사본 만들기" +msgstr "중복 파일을 만드는 중" #: msi.rc:102 msgid "Searching for related applications" -msgstr "관련된 프로그램 검색 중" +msgstr "관련 프로그램을 검색 중" #: msi.rc:103 msgid "Copying network install files" -msgstr "네트워크 설치 파일 복사" +msgstr "네트워크 설치 파일을 복사하는 중" #: msi.rc:104 msgid "Copying new files" -msgstr "새 파일 복사 중" +msgstr "새 파일을 복사하는 중" #: msi.rc:105 msgid "Installing ODBC components" -msgstr "ODBC 구성 요소 설치 중" +msgstr "ODBC 구성 요소를 설치하는 중" #: msi.rc:106 msgid "Installing new services" -msgstr "새 서비스 설치" +msgstr "새 서비스를 설치하는 중" #: msi.rc:107 msgid "Installing system catalog" -msgstr "시스템 카탈로그 설치" +msgstr "시스템 카탈로그를 설치하는 중" #: msi.rc:108 msgid "Validating install" -msgstr "설치 확인 중" +msgstr "설지 유효성을 확인하는 중" #: msi.rc:109 msgid "Evaluating launch conditions" -msgstr "실행 조건 평가" +msgstr "시작 조건을 평가하는 중" #: msi.rc:110 msgid "Migrating feature states from related applications" -msgstr "관련된 프로그램의 특성 상태를 마이그레이션하는 중" +msgstr "관련 프로그램에서 기능 상태를 마이그레이션하는 중" #: msi.rc:111 msgid "Moving files" -msgstr "파일 이동" +msgstr "파일을 이동하는 중" #: msi.rc:112 msgid "Publishing assembly information" -msgstr "어셈블리 정보 게시" +msgstr "어셈블리 정보를 게시하는 중" #: msi.rc:113 msgid "Unpublishing assembly information" -msgstr "이진 정보 비게시" +msgstr "어셈블리 정보 게시를 취소하는 중" #: msi.rc:114 msgid "Patching files" -msgstr "기우기 파일" +msgstr "파일을 패치하는 중" #: msi.rc:115 msgid "Updating component registration" -msgstr "구성 요소 등록 갱신" +msgstr "구성 요소 등록을 업데이트하는 중" #: msi.rc:116 msgid "Publishing Qualified Components" -msgstr "공식 구성요소 게시" +msgstr "자격 구성 요소를 게시하는 중" #: msi.rc:117 msgid "Publishing Product Features" -msgstr "제품 기능 게시" +msgstr "제품 기능을 게시하는 중" #: msi.rc:118 msgid "Publishing product information" -msgstr "제품 정보 게시" +msgstr "제품 정보를 게시하는 중" #: msi.rc:119 msgid "Registering Class servers" -msgstr "클래스 서버 등록" +msgstr "클래스 서버를 등록하는 중" #: msi.rc:120 msgid "Registering COM+ Applications and Components" -msgstr "COM+ 프로그램 및 구성요소 등록" +msgstr "COM+ 프로그램 및 구성 요소를 등록하는 중" #: msi.rc:121 msgid "Registering extension servers" -msgstr "확장 서버 등록" +msgstr "확장 서버를 등록하는 중" #: msi.rc:122 msgid "Registering fonts" -msgstr "글꼴 등록" +msgstr "글꼴을 등록하는 중" #: msi.rc:123 msgid "Registering MIME info" -msgstr "MIME 정보 등록" +msgstr "MIME 정보를 등록하는 중" #: msi.rc:124 msgid "Registering product" -msgstr "제품 등록" +msgstr "제품을 등록하는 중" #: msi.rc:125 msgid "Registering program identifiers" -msgstr "프로그램 식별자 등록" +msgstr "프로그램 식별자를 등록하는 중" #: msi.rc:126 msgid "Registering type libraries" -msgstr "라이브러리 형식 등록" +msgstr "형식 라이브러리를 등록하는 중" #: msi.rc:127 msgid "Registering user" -msgstr "사용자 등록 중" +msgstr "사용자를 등록하는 중" #: msi.rc:128 msgid "Removing duplicated files" -msgstr "중복된 파일 제거" +msgstr "중복 파일을 제거하는 중" #: msi.rc:129 msi.rc:153 msgid "Updating environment strings" -msgstr "환경 문자열 갱신" +msgstr "환경 문자열을 업데이트하는 중" #: msi.rc:130 msgid "Removing applications" -msgstr "프로그램 제거" +msgstr "프로그램을 제거하는 중" #: msi.rc:131 msgid "Removing files" -msgstr "파일 제거" +msgstr "파일을 제거하는 중" #: msi.rc:132 msgid "Removing folders" -msgstr "폴더 제거" +msgstr "폴더를 제거하는 중" #: msi.rc:133 msgid "Removing INI files entries" -msgstr "설정 파일 목록 제거" +msgstr "INI 파일 항목을 제거하는 중" #: msi.rc:134 msgid "Removing ODBC components" -msgstr "ODBC 구성 요소 제거" +msgstr "ODBC 구성 요소를 제거하는 중" #: msi.rc:135 msgid "Removing system registry values" -msgstr "시스템 레지스트리 값 제거 중" +msgstr "시스템 레지스트리 값을 제거하는 중" #: msi.rc:136 msgid "Removing shortcuts" -msgstr "바로 가기 제거" +msgstr "바로 가기를 제거하는 중" #: msi.rc:138 msgid "Registering modules" -msgstr "구성 요소 등록" +msgstr "모듈을 등록하는 중" #: msi.rc:139 msgid "Unregistering modules" -msgstr "구성 요소 등록 취소" +msgstr "모듈 등록을 취소하는 중" #: msi.rc:140 msgid "Initializing ODBC directories" -msgstr "ODBC 디렉터리 초기화 중" +msgstr "ODBC 디렉터리를 초기화하는 중" #: msi.rc:141 msgid "Starting services" -msgstr "서비스 시작" +msgstr "서비스를 시작하는 중" #: msi.rc:142 msgid "Stopping services" -msgstr "서비스 정지" +msgstr "서비스를 중지하는 중" #: msi.rc:143 msgid "Unpublishing Qualified Components" -msgstr "공인된 구성요소에 대한 게시 취소" +msgstr "자격 구성 요소 게시를 취소하는 중" #: msi.rc:144 msgid "Unpublishing Product Features" -msgstr "제품 특성 게시 취소" +msgstr "제품 기능 게시를 취소하는 중" #: msi.rc:145 msgid "Unpublishing product information" -msgstr "제품 정보 게시 취소" +msgstr "제품 정보 게시를 취소하는 중" #: msi.rc:146 msgid "Unregister Class servers" -msgstr "클래스 서버 등록 취소" +msgstr "클래스 서버 등록을 취소하는 중" #: msi.rc:147 msgid "Unregistering COM+ Applications and Components" -msgstr "COM+ 프로그램 및 구성요소 등록 해제" +msgstr "COM+ 프로그램 및 구성 요소 등록을 취소하는 중" #: msi.rc:148 msgid "Unregistering extension servers" -msgstr "확장 서버 등록 취소" +msgstr "확장 서버 등록을 취소하는 중" #: msi.rc:149 msgid "Unregistering fonts" -msgstr "글꼴 등록 취소" +msgstr "글꼴 등록을 취소하는 중" #: msi.rc:150 msgid "Unregistering MIME info" -msgstr "MIME 정보 등록 취소" +msgstr "MIME 정보 등록을 취소하는 중" #: msi.rc:151 msgid "Unregistering program identifiers" -msgstr "프로그램 식별자 등록 취소" +msgstr "프로그램 식별자 등록을 취소하는 중" #: msi.rc:152 msgid "Unregistering type libraries" -msgstr "형식 라이브러리 등록 취소" +msgstr "형식 라이브러리 등록을 취소하는 중" #: msi.rc:154 msgid "Writing INI files values" -msgstr "INI 파일 값 쓰기" +msgstr "INI 파일 값을 쓰는 중" #: msi.rc:155 msgid "Writing system registry values" -msgstr "시스템 레지스트리 값 쓰기" +msgstr "시스템 레지스트리 값을 쓰는 중" #: msi.rc:161 msgid "Free space: [1]" -msgstr "여유 공간: [1]" +msgstr "사용 가능한 공간: [1]" #: msi.rc:162 msgid "Property: [1], Signature: [2]" -msgstr "속성 : [1], 서명 : [2]" +msgstr "속성: [1], 서명: [2]" #: msi.rc:163 msgid "File: [1]" @@ -7238,7 +7238,7 @@ msgstr "파일: [1], 디렉터리: [9], 크기: [6]" #: msi.rc:168 msgid "Found application: [1]" -msgstr "프로그램 발견: [1]" +msgstr "찾은 프로그램: [1]" #: msi.rc:169 msgid "File: [1], Directory: [9], Size: [6]" @@ -7250,7 +7250,7 @@ msgstr "서비스: [2]" #: msi.rc:172 msgid "File: [1], Dependencies: [2]" -msgstr "파일: [1], 참조 또는 의존: [2]" +msgstr "파일: [1], 종속성: [2]" #: msi.rc:173 msgid "Application: [1]" @@ -7258,7 +7258,7 @@ msgstr "프로그램: [1]" #: msi.rc:175 msi.rc:176 msgid "Application Context:[1], Assembly Name:[2]" -msgstr "프로그램 구성요소: [1], 어셈블리 이름 : [2]" +msgstr "프로그램 컨텍스트: [1], 어셈블리 이름 : [2]" #: msi.rc:177 msgid "File: [1], Directory: [2], Size: [3]" @@ -7266,7 +7266,7 @@ msgstr "파일: [1], 디렉터리: [2], 크기: [3]" #: msi.rc:178 msi.rc:199 msgid "Component ID: [1], Qualifier: [2]" -msgstr "구성 요소 ID : [1], 한정자 : [2]" +msgstr "구성 요소 ID: [1], 자격자: [2]" #: msi.rc:179 msi.rc:200 msgid "Feature: [1]" @@ -7274,11 +7274,11 @@ msgstr "기능: [1]" #: msi.rc:180 msi.rc:201 msgid "Class Id: [1]" -msgstr "클래스 ID : [1]" +msgstr "클래스 ID: [1]" #: msi.rc:181 msgid "AppId: [1]{{, AppType: [2], Users: [3], RSN: [4]}}" -msgstr "AppId: [1]{{, AppType: [2], Users: [3], RSN: [4]}}" +msgstr "AppId: [1]{{, AppType: [2], 사용자: [3], RSN: [4]}}" #: msi.rc:182 msi.rc:203 msgid "Extension: [1]" @@ -7290,7 +7290,7 @@ msgstr "글꼴: [1]" #: msi.rc:184 msi.rc:205 msgid "MIME Content Type: [1], Extension: [2]" -msgstr "MIME 콘텐츠 유형 : [1], 확장 : [2]" +msgstr "MIME 콘텐츠 형식: [1], 확장: [2]" #: msi.rc:185 msi.rc:206 msgid "ProgId: [1]" @@ -7306,7 +7306,7 @@ msgstr "파일: [1], 디렉터리: [9]" #: msi.rc:188 msi.rc:208 msgid "Name: [1], Value: [2], Action [3]" -msgstr "이름: [1], 값: [2], 작동 [3]" +msgstr "이름: [1], 값: [2], 작업 [3]" #: msi.rc:189 msgid "Application: [1], Command line: [2]" @@ -7355,8 +7355,8 @@ msgid "" "arguments are: [2], [3], [4]}}" msgstr "" "설치 프로그램에서 이 패키지를 설치하는 동안 예기치 않은 오류가 발생했습니다. " -"이 패키지에 문제가 있음을 나타낼 수 있습니다. 오류 코드는 [1]입니다. {{인" -"수 : [2], [3], [4]}}" +"이 패키지에 문제가 있음을 나타낼 수 있습니다. 오류 코드 [1]. {{인수 : [2], " +"[3], [4]}}" #: msi.rc:77 msgid "{{Disk full: }}" @@ -7364,35 +7364,35 @@ msgstr "{{디스크가 꽉 찼습니다: }}" #: msi.rc:78 msgid "Action [Time]: [1]. [2]" -msgstr "동작 [Time]: [1]. [2]" +msgstr "작업 [Time]: [1]. [2]" #: msi.rc:79 msgid "Message type: [1], Argument: [2]{, [3]}" -msgstr "메시지 유형 : [1], 인수 : [2], [3]" +msgstr "메시지 유형: [1], 인수: [2], [3]" #: msi.rc:82 msgid "=== Logging started: [Date] [Time] ===" -msgstr "=== 기록 시작: [Date] [Time] ===" +msgstr "=== 기록 시작: [Date] [Time] ===" #: msi.rc:80 msgid "Action start [Time]: [1]." -msgstr "동작 시작 [Time]: [1]." +msgstr "작업 시작 [Time]: [1]." #: msi.rc:81 msgid "Action ended [Time]: [1]. Return value [2]." -msgstr "동작 종료 [Time]: [1]. 반환 값 [2]." +msgstr "작업 끝 [Time]: [1]. 반환 값 [2]." #: msi.rc:84 msgid "Please insert the disk: [2]" -msgstr "디스크를 삽입해 주십시오. [2]" +msgstr "디스크를 넣으십시오: [2]" #: msi.rc:85 msgid "" "Source file not found{{(cabinet)}}: [2]. Verify that the file exists and " "that you can access it." msgstr "" -"소스 파일을 찾을 수 없습니다 {{(cabinet)}}: [2]. 파일이 존재 여부와 액세스 가" -"능 여부를 확인하십시오." +"원본 파일을 찾을 수 없습니다 {{(cabinet)}}: [2]. 파일 존재 및 액세스 가능 여" +"부를 확인하십시오." #: msrle32.rc:31 msgid "Wine MS-RLE video codec" @@ -8072,7 +8072,7 @@ msgstr "px" #: sane.rc:32 msgctxt "unit: bits" msgid "b" -msgstr "비트" +msgstr "bit" #: sane.rc:34 wineps.rc:49 winecfg.rc:183 msgctxt "unit: dots/inch" @@ -8087,7 +8087,7 @@ msgstr "%" #: sane.rc:36 msgctxt "unit: microseconds" msgid "us" -msgstr "us" +msgstr "µs" #: serialui.rc:28 msgid "Settings for %s" @@ -8095,7 +8095,7 @@ msgstr "%s 설정" #: serialui.rc:31 msgid "Baud Rate" -msgstr "보드속도" +msgstr "전송 속도" #: serialui.rc:33 msgid "Parity" @@ -8143,7 +8143,7 @@ msgstr "%2의 '%1' 파일이 필요합니다" #: setupapi.rc:32 ipconfig.rc:34 msgid "Unknown" -msgstr " 없음" +msgstr "없음" #: setupapi.rc:33 msgid "Copy files from:" @@ -8922,7 +8922,7 @@ msgstr "실행 파일 (*.exe)" #: shell32.rc:244 msgid "There is no Windows program configured to open this type of file." -msgstr "이 형식의 파일을 도록 구성된 Windows 프로그램이 없습니다." +msgstr "이 유형의 파일을 열도록 구성된 Windows 프로그램이 없습니다." #: shell32.rc:246 msgid "Are you sure you wish to permanently delete '%1'?" @@ -9028,815 +9028,799 @@ msgstr " 초" #: twain.rc:29 msgid "Select Source" -msgstr "소스 선택" +msgstr "원본 선택" #: tzres.rc:82 msgid "China Standard Time" -msgstr "" +msgstr "중국 표준 시간" #: tzres.rc:83 msgid "China Daylight Time" -msgstr "" +msgstr "중국 일광 절약 시간" #: tzres.rc:160 msgid "North Asia Standard Time" -msgstr "" +msgstr "북아시아 표준 시간" #: tzres.rc:161 msgid "North Asia Daylight Time" -msgstr "" +msgstr "북아시아 일광 절약 시간" #: tzres.rc:104 msgid "Georgian Standard Time" -msgstr "" +msgstr "그루지아 표준 시간" #: tzres.rc:105 msgid "Georgian Daylight Time" -msgstr "" +msgstr "그루지아 일광 절약 시간" #: tzres.rc:152 msgid "Nepal Standard Time" -msgstr "" +msgstr "네팔 표준 시간" #: tzres.rc:153 msgid "Nepal Daylight Time" -msgstr "" +msgstr "네팔 일광 절약 시간" #: tzres.rc:60 msgid "Cape Verde Standard Time" -msgstr "" +msgstr "카보베르데 표준 시간" #: tzres.rc:61 msgid "Cape Verde Daylight Time" -msgstr "" +msgstr "카보베르데 일광 절약 시간" #: tzres.rc:74 -#, fuzzy -#| msgid "Central European" msgid "Central European Standard Time" -msgstr "중부 유럽" +msgstr "중앙 유럽 표준 시간" #: tzres.rc:75 -#, fuzzy -#| msgid "Central European" msgid "Central European Daylight Time" -msgstr "중부 유럽" +msgstr "중앙 유럽 일관 절약 시간" #: tzres.rc:140 msgid "Morocco Standard Time" -msgstr "" +msgstr "모로코 표준 시간" #: tzres.rc:141 msgid "Morocco Daylight Time" -msgstr "" +msgstr "모로코 일광 절약 시간" #: tzres.rc:72 -#, fuzzy -#| msgid "Central European" msgid "Central Europe Standard Time" -msgstr "중부 유럽" +msgstr "중앙 유럽 표준 시간" #: tzres.rc:73 -#, fuzzy -#| msgid "Central European" msgid "Central Europe Daylight Time" -msgstr "중부 유럽" +msgstr "중앙 유럽 일광 절약 시간" #: tzres.rc:118 msgid "Iran Standard Time" -msgstr "" +msgstr "이란 표준 시간" #: tzres.rc:119 msgid "Iran Daylight Time" -msgstr "" +msgstr "이란 일광 절약 시간" #: tzres.rc:150 msgid "Namibia Standard Time" -msgstr "" +msgstr "나미비아 표준 시간" #: tzres.rc:151 msgid "Namibia Daylight Time" -msgstr "" +msgstr "나미비아 일광 절약 시간" #: tzres.rc:200 msgid "Tonga Standard Time" -msgstr "" +msgstr "통가 표준 시간" #: tzres.rc:201 msgid "Tonga Daylight Time" -msgstr "" +msgstr "통가 일괄 절약 시간" #: tzres.rc:144 msgid "Mountain Standard Time (Mexico)" -msgstr "" +msgstr "산지 표준 시간 (멕시코)" #: tzres.rc:145 msgid "Mountain Daylight Time (Mexico)" -msgstr "" +msgstr "산지 일광 절약 시간 (멕시코)" #: tzres.rc:106 -#, fuzzy -#| msgid "&Standard bar" msgid "GMT Standard Time" -msgstr "표준 바(&S)" +msgstr "GMT 표준 시간" #: tzres.rc:107 msgid "GMT Daylight Time" -msgstr "" +msgstr "GMT 일광 절약 시간" #: tzres.rc:68 msgid "Central Asia Standard Time" -msgstr "" +msgstr "중앙 아시아 표준 시간" #: tzres.rc:69 msgid "Central Asia Daylight Time" -msgstr "" +msgstr "중앙 아시아 일광 절약 시간" #: tzres.rc:38 msgid "Arabic Standard Time" -msgstr "" +msgstr "아랍 표준 시간" #: tzres.rc:39 msgid "Arabic Daylight Time" -msgstr "" +msgstr "아랍 일광 절약 시간" #: tzres.rc:132 msgid "Magadan Standard Time" -msgstr "" +msgstr "마가단 표준 시간" #: tzres.rc:133 msgid "Magadan Daylight Time" -msgstr "" +msgstr "마가단 일광 절약 시간" #: tzres.rc:156 msgid "Newfoundland Standard Time" -msgstr "" +msgstr "뉴펀들랜드 표준 시간" #: tzres.rc:157 msgid "Newfoundland Daylight Time" -msgstr "" +msgstr "뉴펀들랜드 일광 절약 시간" #: tzres.rc:224 msgid "West Pacific Standard Time" -msgstr "" +msgstr "서태평양 표준 시간" #: tzres.rc:225 msgid "West Pacific Daylight Time" -msgstr "" +msgstr "서태평양 일광 절약 시간" #: tzres.rc:164 msgid "Pacific Standard Time" -msgstr "" +msgstr "태평양 표준 시간" #: tzres.rc:165 msgid "Pacific Daylight Time" -msgstr "" +msgstr "태평양 일광 절약 시간" #: tzres.rc:48 msgid "Azerbaijan Standard Time" -msgstr "" +msgstr "아제르바이잔 표준 시간" #: tzres.rc:49 msgid "Azerbaijan Daylight Time" -msgstr "" +msgstr "아제르바이잔 일광 절약 시간" #: tzres.rc:182 msgid "Samoa Standard Time" -msgstr "" +msgstr "사모아 표준 시간" #: tzres.rc:183 msgid "Samoa Daylight Time" -msgstr "" +msgstr "사모아 일광 절약 시간" #: tzres.rc:124 msgid "Kaliningrad Standard Time" -msgstr "" +msgstr "칼리닌그라드 표준 시간" #: tzres.rc:125 msgid "Kaliningrad Daylight Time" -msgstr "" +msgstr "칼리닌그라드 일광 절약 시간" #: tzres.rc:166 msgid "Pacific Standard Time (Mexico)" -msgstr "" +msgstr "태평양 표준 시간 (멕시코)" #: tzres.rc:167 msgid "Pacific Daylight Time (Mexico)" -msgstr "" +msgstr "태평양 일광 절약 시간 (멕시코)" #: tzres.rc:136 msgid "Middle East Standard Time" -msgstr "" +msgstr "중동 표준 시간" #: tzres.rc:137 msgid "Middle East Daylight Time" -msgstr "" +msgstr "중동 일광 절약 시간" #: tzres.rc:198 msgid "Tokyo Standard Time" -msgstr "" +msgstr "도쿄 표준 시간" #: tzres.rc:199 msgid "Tokyo Daylight Time" -msgstr "" +msgstr "도쿄 일광 절약 시간" #: tzres.rc:130 msgid "Line Islands Standard Time" -msgstr "" +msgstr "라인 제도 표준 시간" #: tzres.rc:131 msgid "Line Islands Daylight Time" -msgstr "" +msgstr "라인 제도 일광 절약 시간" #: tzres.rc:122 msgid "Jordan Standard Time" -msgstr "" +msgstr "요르단 표준 시간" #: tzres.rc:123 msgid "Jordan Daylight Time" -msgstr "" +msgstr "요르단 일광 절약 시간" #: tzres.rc:78 msgid "Central Standard Time" -msgstr "" +msgstr "중부 표준 시간" #: tzres.rc:79 msgid "Central Daylight Time" -msgstr "" +msgstr "중부 일광 절약 시간" #: tzres.rc:50 msgid "Azores Standard Time" -msgstr "" +msgstr "아조레스 표준 시간" #: tzres.rc:51 msgid "Azores Daylight Time" -msgstr "" +msgstr "아조레스 일광 절약 시간" #: tzres.rc:158 msgid "North Asia East Standard Time" -msgstr "" +msgstr "북아시아 동부 표준 시간" #: tzres.rc:159 msgid "North Asia East Daylight Time" -msgstr "" +msgstr "북아시아 동부 일광 절약 시간" #: tzres.rc:40 msgid "Argentina Standard Time" -msgstr "" +msgstr "아르헨티나 표준 시간" #: tzres.rc:41 msgid "Argentina Daylight Time" -msgstr "" +msgstr "아르헨티나 일광 절약 시간" #: tzres.rc:146 msgid "Myanmar Standard Time" -msgstr "" +msgstr "미얀마 표준 시간" #: tzres.rc:147 msgid "Myanmar Daylight Time" -msgstr "" +msgstr "미얀마 일광 절약 시간" #: tzres.rc:210 tzres.rc:211 msgid "Coordinated Universal Time" -msgstr "" +msgstr "협정 세계시" #: tzres.rc:116 msgid "India Standard Time" -msgstr "" +msgstr "인도 표준 시간" #: tzres.rc:117 msgid "India Daylight Time" -msgstr "" +msgstr "인도 일광 절약 시간" #: tzres.rc:112 -#, fuzzy -#| msgid "&Standard bar" msgid "GTB Standard Time" -msgstr "표준 바(&S)" +msgstr "GTB 표준 시간" #: tzres.rc:113 msgid "GTB Daylight Time" -msgstr "" +msgstr "GTB 일광 절약 시간" #: tzres.rc:202 msgid "Turkey Standard Time" -msgstr "" +msgstr "터키 표준 시간" #: tzres.rc:203 msgid "Turkey Daylight Time" -msgstr "" +msgstr "터키 일광 절약 시간" #: tzres.rc:100 msgid "Fiji Standard Time" -msgstr "" +msgstr "피지 표준 시간" #: tzres.rc:101 msgid "Fiji Daylight Time" -msgstr "" +msgstr "피지 일광 절약 시간" #: tzres.rc:58 msgid "Canada Central Standard Time" -msgstr "" +msgstr "캐나다 중부 표준 시간" #: tzres.rc:59 msgid "Canada Central Daylight Time" -msgstr "" +msgstr "캐나다 중부 일광 절약 시간" #: tzres.rc:194 msgid "Taipei Standard Time" -msgstr "" +msgstr "타이베이 표준 시간" #: tzres.rc:195 msgid "Taipei Daylight Time" -msgstr "" +msgstr "타이베이 일광 절약 시간" #: tzres.rc:220 msgid "W. Europe Standard Time" -msgstr "" +msgstr "서유럽 표준 시간" #: tzres.rc:221 msgid "W. Europe Daylight Time" -msgstr "" +msgstr "서유럽 일광 절약 시간" #: tzres.rc:138 msgid "Montevideo Standard Time" -msgstr "" +msgstr "몬데비데오 표준 시간" #: tzres.rc:139 msgid "Montevideo Daylight Time" -msgstr "" +msgstr "몬데비데오 일광 절약 시간" #: tzres.rc:168 msgid "Pakistan Standard Time" -msgstr "" +msgstr "파키스탄 표준 시간" #: tzres.rc:169 msgid "Pakistan Daylight Time" -msgstr "" +msgstr "파키스탄 일광 절약 시간" #: tzres.rc:62 msgid "Caucasus Standard Time" -msgstr "" +msgstr "코코서스 표준 시간" #: tzres.rc:63 msgid "Caucasus Daylight Time" -msgstr "" +msgstr "코코서스 일광 절약 시간" #: tzres.rc:46 msgid "AUS Eastern Standard Time" -msgstr "" +msgstr "오스트레일리아 동부 표준 시간" #: tzres.rc:47 msgid "AUS Eastern Daylight Time" -msgstr "" +msgstr "오스트레일리아 동부 일광 절약 시간" #: tzres.rc:148 msgid "N. Central Asia Standard Time" -msgstr "" +msgstr "중앙 아시아 북부 표준 시간" #: tzres.rc:149 msgid "N. Central Asia Daylight Time" -msgstr "" +msgstr "중앙 아시아 북부 일광 절약 시간" #: tzres.rc:94 msgid "Eastern Standard Time" -msgstr "" +msgstr "동부 표준 시간" #: tzres.rc:95 msgid "Eastern Daylight Time" -msgstr "" +msgstr "동부 일광 절약 시간" #: tzres.rc:80 msgid "Central Standard Time (Mexico)" -msgstr "" +msgstr "중부 표준 시간 (멕시코)" #: tzres.rc:81 msgid "Central Daylight Time (Mexico)" -msgstr "" +msgstr "중부 일광 절약 시간 (멕시코)" #: tzres.rc:42 msgid "Atlantic Standard Time" -msgstr "" +msgstr "대서양 표준 시간" #: tzres.rc:43 msgid "Atlantic Daylight Time" -msgstr "" +msgstr "대서양 일광 절약 시간" #: tzres.rc:142 msgid "Mountain Standard Time" -msgstr "" +msgstr "산지 표준 시간" #: tzres.rc:143 msgid "Mountain Daylight Time" -msgstr "" +msgstr "산지 일광 절약 시간" #: tzres.rc:206 msgid "US Eastern Standard Time" -msgstr "" +msgstr "미국 동부 표준 시간" #: tzres.rc:207 msgid "US Eastern Daylight Time" -msgstr "" +msgstr "미국 동부 일광 절약 시간" #: tzres.rc:196 msgid "Tasmania Standard Time" -msgstr "" +msgstr "태즈매이니아 표준 시간" #: tzres.rc:197 msgid "Tasmania Daylight Time" -msgstr "" +msgstr "태즈매이니아 일광 절약 시간" #: tzres.rc:66 msgid "Central America Standard Time" -msgstr "" +msgstr "중앙 아메리카 표준 시간" #: tzres.rc:67 msgid "Central America Daylight Time" -msgstr "" +msgstr "중앙 아메리카 일광 절약 시간" #: tzres.rc:208 msgid "US Mountain Standard Time" -msgstr "" +msgstr "미국 산지 표준 시간" #: tzres.rc:209 msgid "US Mountain Daylight Time" -msgstr "" +msgstr "미국 산지 일광 절약 시간" #: tzres.rc:188 msgid "South Africa Standard Time" -msgstr "" +msgstr "남아프리카 표준 시간" #: tzres.rc:189 msgid "South Africa Daylight Time" -msgstr "" +msgstr "남아프리카 일광 절약 시간" #: tzres.rc:64 msgid "Cen. Australia Standard Time" -msgstr "" +msgstr "중부 오스트레일리아 표준 시간" #: tzres.rc:65 msgid "Cen. Australia Daylight Time" -msgstr "" +msgstr "중부 오스트레일리아 일광 절약 시간" #: tzres.rc:190 msgid "Sri Lanka Standard Time" -msgstr "" +msgstr "스리랑카 표준 시간" #: tzres.rc:191 msgid "Sri Lanka Daylight Time" -msgstr "" +msgstr "스리랑카 일광 절약 시간" #: tzres.rc:30 msgid "Afghanistan Standard Time" -msgstr "" +msgstr "아프가니스탄 표준 시간" #: tzres.rc:31 msgid "Afghanistan Daylight Time" -msgstr "" +msgstr "아프가니스탄 일광 절약 시간" #: tzres.rc:226 msgid "Yakutsk Standard Time" -msgstr "" +msgstr "야쿠츠크 표준 시간" #: tzres.rc:227 msgid "Yakutsk Daylight Time" -msgstr "" +msgstr "야쿠츠크 일광 절약 시간" #: tzres.rc:176 msgid "SA Eastern Standard Time" -msgstr "" +msgstr "SA 동부 표준 시간" #: tzres.rc:177 msgid "SA Eastern Daylight Time" -msgstr "" +msgstr "SA 동부 일광 절약 시간" #: tzres.rc:34 msgid "Arab Standard Time" -msgstr "" +msgstr "아랍 표준 시간" #: tzres.rc:35 msgid "Arab Daylight Time" -msgstr "" +msgstr "아랍 일광 절약 시간" #: tzres.rc:36 msgid "Arabian Standard Time" -msgstr "" +msgstr "아라비아 표준 시간" #: tzres.rc:37 msgid "Arabian Daylight Time" -msgstr "" +msgstr "아라비아 일광 절약 시간" #: tzres.rc:174 msgid "Russian Standard Time" -msgstr "" +msgstr "러시아 표준 시간" #: tzres.rc:175 msgid "Russian Daylight Time" -msgstr "" +msgstr "러시아 일광 절약 시간" #: tzres.rc:172 msgid "Romance Standard Time" -msgstr "" +msgstr "로망스 표준 시간" #: tzres.rc:173 msgid "Romance Daylight Time" -msgstr "" +msgstr "로망스 일광 절약 시간" #: tzres.rc:98 msgid "Ekaterinburg Standard Time" -msgstr "" +msgstr "예카테린부르크 표준 시간" #: tzres.rc:99 msgid "Ekaterinburg Daylight Time" -msgstr "" +msgstr "예카테린부르크 일광 절약 시간" #: tzres.rc:192 msgid "Syria Standard Time" -msgstr "" +msgstr "시리아 표준 시간" #: tzres.rc:193 msgid "Syria Daylight Time" -msgstr "" +msgstr "시리아 일광 절약 시간" #: tzres.rc:44 msgid "AUS Central Standard Time" -msgstr "" +msgstr "오스트레일리아 중부 표준 시간" #: tzres.rc:45 msgid "AUS Central Daylight Time" -msgstr "" +msgstr "오스트레일리아 중부 일광 절약 시간" #: tzres.rc:110 msgid "Greenwich Standard Time" -msgstr "" +msgstr "그리니치 표준 시간" #: tzres.rc:111 msgid "Greenwich Daylight Time" -msgstr "" +msgstr "그리니치 일광 절약 시간" #: tzres.rc:204 msgid "Ulaanbaatar Standard Time" -msgstr "" +msgstr "울란바토르 표준 시간" #: tzres.rc:205 msgid "Ulaanbaatar Daylight Time" -msgstr "" +msgstr "울란바토르 일광 절약 시간" #: tzres.rc:120 msgid "Israel Standard Time" -msgstr "" +msgstr "이스라엘 표준 시간" #: tzres.rc:121 msgid "Israel Daylight Time" -msgstr "" +msgstr "이스라엘 일광 절약 시간" #: tzres.rc:54 msgid "Bangladesh Standard Time" -msgstr "" +msgstr "발글라데시 표준 시간" #: tzres.rc:55 msgid "Bangladesh Daylight Time" -msgstr "" +msgstr "방글라데시 일광 절약 시간" #: tzres.rc:178 msgid "SA Pacific Standard Time" -msgstr "" +msgstr "SA 태평양 표준 시간" #: tzres.rc:179 msgid "SA Pacific Daylight Time" -msgstr "" +msgstr "SA 태평양 일광 절약 시간" #: tzres.rc:222 msgid "West Asia Standard Time" -msgstr "" +msgstr "서아시아 표준 시간" #: tzres.rc:223 msgid "West Asia Daylight Time" -msgstr "" +msgstr "서아시아 일광 절약 시간" #: tzres.rc:32 msgid "Alaskan Standard Time" -msgstr "" +msgstr "알래스카 표준 시간" #: tzres.rc:33 msgid "Alaskan Daylight Time" -msgstr "" +msgstr "알래스카 일광 절약 시간" #: tzres.rc:170 msgid "Paraguay Standard Time" -msgstr "" +msgstr "파라과이 표준 시간" #: tzres.rc:171 msgid "Paraguay Daylight Time" -msgstr "" +msgstr "파라과이 일광 절약 시간" #: tzres.rc:84 -#, fuzzy #| msgid "Date and time" msgid "Dateline Standard Time" -msgstr "날짜와 시간" +msgstr "날짜 변경선 표준 시간" #: tzres.rc:85 msgid "Dateline Daylight Time" -msgstr "" +msgstr "날짜 변경선 일광 절약 시간" #: tzres.rc:128 msgid "Libya Standard Time" -msgstr "" +msgstr "리비아 표준 시간" #: tzres.rc:129 msgid "Libya Daylight Time" -msgstr "" +msgstr "리비아 일광 절약 시간" #: tzres.rc:52 msgid "Bahia Standard Time" -msgstr "" +msgstr "바이아 표준 시간" #: tzres.rc:53 msgid "Bahia Daylight Time" -msgstr "" +msgstr "바이아 일광 절약 시간" #: tzres.rc:212 msgid "Venezuela Standard Time" -msgstr "" +msgstr "베네수엘라 표준 시간" #: tzres.rc:213 msgid "Venezuela Daylight Time" -msgstr "" +msgstr "베네수엘라 일광 절약 시간" #: tzres.rc:114 msgid "Hawaiian Standard Time" -msgstr "" +msgstr "하와이 표준 시간" #: tzres.rc:115 msgid "Hawaiian Daylight Time" -msgstr "" +msgstr "하와이 일광 절약 시간" #: tzres.rc:184 msgid "SE Asia Standard Time" -msgstr "" +msgstr "동남 아시아 표준 시간" #: tzres.rc:185 msgid "SE Asia Daylight Time" -msgstr "" +msgstr "동남 아시아 일광 절약 시간" #: tzres.rc:154 msgid "New Zealand Standard Time" -msgstr "" +msgstr "뉴질랜드 표준 시간" #: tzres.rc:155 msgid "New Zealand Daylight Time" -msgstr "" +msgstr "뉴질랜드 일광 절약 시간" #: tzres.rc:70 msgid "Central Brazilian Standard Time" -msgstr "" +msgstr "브라질 중부 표준 시간" #: tzres.rc:71 msgid "Central Brazilian Daylight Time" -msgstr "" +msgstr "브라질 중부 일광 절약 시간" #: tzres.rc:56 msgid "Belarus Standard Time" -msgstr "" +msgstr "벨로루시 표준 시간" #: tzres.rc:57 msgid "Belarus Daylight Time" -msgstr "" +msgstr "벨로루시 표준 시간" #: tzres.rc:180 msgid "SA Western Standard Time" -msgstr "" +msgstr "SA 서부 표준 시간" #: tzres.rc:181 msgid "SA Western Daylight Time" -msgstr "" +msgstr "SA 서부 일광 절약 시간" #: tzres.rc:108 msgid "Greenland Standard Time" -msgstr "" +msgstr "그린란드 표준 시간" #: tzres.rc:109 msgid "Greenland Daylight Time" -msgstr "" +msgstr "그린란드 일광 절약 시간" #: tzres.rc:92 -#, fuzzy #| msgid "Date and time" msgid "Easter Island Standard Time" -msgstr "날짜와 시간" +msgstr "이스터 섬 표준 시간" #: tzres.rc:93 -#, fuzzy #| msgid "Date and time" msgid "Easter Island Daylight Time" -msgstr "날짜와 시간" +msgstr "이스터 섬 일광 절약 시간" #: tzres.rc:96 msgid "Egypt Standard Time" -msgstr "" +msgstr "이집트 표준 시간" #: tzres.rc:97 msgid "Egypt Daylight Time" -msgstr "" +msgstr "이집트 일광 절약 시간" #: tzres.rc:134 msgid "Mauritius Standard Time" -msgstr "" +msgstr "모리셔스 표준 시간" #: tzres.rc:135 msgid "Mauritius Daylight Time" -msgstr "" +msgstr "모리셔스 일광 절약 시간" #: tzres.rc:214 msgid "Vladivostok Standard Time" -msgstr "" +msgstr "블라디보스토크 표준 시간" #: tzres.rc:215 msgid "Vladivostok Daylight Time" -msgstr "" +msgstr "블라디보스토크 일광 절약 시간" #: tzres.rc:186 msgid "Singapore Standard Time" -msgstr "" +msgstr "싱가포르 표준 시간" #: tzres.rc:187 msgid "Singapore Daylight Time" -msgstr "" +msgstr "싱가포르 일광 절약 시간" #: tzres.rc:126 msgid "Korea Standard Time" -msgstr "" +msgstr "대한민국 표준 시간" #: tzres.rc:127 msgid "Korea Daylight Time" -msgstr "" +msgstr "대한민국 일광 절약 시간" #: tzres.rc:86 msgid "E. Africa Standard Time" -msgstr "" +msgstr "동아프리카 표준 시간" #: tzres.rc:87 msgid "E. Africa Daylight Time" -msgstr "" +msgstr "동아프리카 일광 절약 시간" #: tzres.rc:102 -#, fuzzy #| msgid "&Standard bar" msgid "FLE Standard Time" -msgstr "표준 바(&S)" +msgstr "FLE 표준 시간" #: tzres.rc:103 msgid "FLE Daylight Time" -msgstr "" +msgstr "FLE 일광 절약 시간" #: tzres.rc:90 msgid "E. South America Standard Time" -msgstr "" +msgstr "남아메리카 동부 표준 시간" #: tzres.rc:91 msgid "E. South America Daylight Time" -msgstr "" +msgstr "남아메리카 동부 일광 절약 시간" #: tzres.rc:76 msgid "Central Pacific Standard Time" -msgstr "" +msgstr "중앙 태평양 표준 시간" #: tzres.rc:77 msgid "Central Pacific Daylight Time" -msgstr "" +msgstr "중앙 태평양 일광 절약 시간" #: tzres.rc:218 msgid "W. Central Africa Standard Time" -msgstr "" +msgstr "중앙아프리카 서부 표준 시간" #: tzres.rc:219 msgid "W. Central Africa Daylight Time" -msgstr "" +msgstr "중앙아프리카 서부 일광 절약 시간" #: tzres.rc:162 msgid "Pacific SA Standard Time" -msgstr "" +msgstr "태평양 SA 표준 시간" #: tzres.rc:163 msgid "Pacific SA Daylight Time" -msgstr "" +msgstr "태평양 SA 일광 절약 시간" #: tzres.rc:88 msgid "E. Australia Standard Time" -msgstr "" +msgstr "오스트레일리아 동부 표준 시간" #: tzres.rc:89 msgid "E. Australia Daylight Time" -msgstr "" +msgstr "오스트레일리아 동부 일광 절약 시간" #: tzres.rc:216 msgid "W. Australia Standard Time" -msgstr "" +msgstr "오스트레일리아 서부 표준 시간" #: tzres.rc:217 msgid "W. Australia Daylight Time" -msgstr "" +msgstr "오스트레일리아 서부 일광 절약 시간" #: urlmon.rc:32 wininet.rc:77 msgid "Security Warning" @@ -9856,7 +9840,7 @@ msgid "" "not click install unless you have absolute trust in the above source." msgstr "" "설치할 때, ActiveX 구성 요소는 컴퓨터에 대한 완전한 액세스 권한을 가집니다. " -"위의 소스에 대한 절대적인 신뢰가 없는 경우 [설치]를 클릭하지 마십시오." +"위 원본에 대한 절대적인 신뢰가 없는 경우 [설치]를 클릭하지 마십시오." #: urlmon.rc:51 msgid "Installation of component failed: %08x" @@ -10022,7 +10006,7 @@ msgstr "인증서 이름이 사이트와 일치하지 않습니다." #: wininet.rc:32 msgid "" "There is at least one unspecified security problem with this certificate." -msgstr "인증서에 최소한 하나의 지정되지 않은 보안 문제가 있습니다." +msgstr "인증서에 최소한 하나의 알 수 없는 보안 문제가 있습니다." #: winineterror.mc:26 msgid "The request has timed out.\n" @@ -10053,8 +10037,7 @@ msgid "" "The operation was canceled, usually because the handle on which the request " "was operating was closed before the operation completed.\n" msgstr "" -"작업이 완료되기 전에 요청이 작동하는 핸들이 닫혀 있기 때문에 작업이 취소되었" -"습니다.\n" +"요청을 수행중인 핸들이 작업 완료 전에 닫혔기 때문에 작업이 취소되었습니다.\n" #: winineterror.mc:61 msgid "The requested item could not be located.\n" @@ -10100,11 +10083,12 @@ msgid "" "The specified device is already in use. Wait until it is free, and then try " "again." msgstr "" -"지정된 장치는 이미 사용중입니다.자유롭게 될때까지 기다리고 다시 시도하십시오." +"지정한 장치가 이미 사용되고 있습니다. 사용할 수 있을 때까지 기다린 다음 다시 " +"시도하십시오." #: winmm.rc:37 msgid "The specified device handle is invalid." -msgstr "지정된 장치 핸들은 적합하지 않습니다." +msgstr "지정한 장치 핸들이 잘못되었습니다." #: winmm.rc:38 msgid "There is no driver installed on your system!" @@ -10115,110 +10099,111 @@ msgid "" "Not enough memory available for this task. Quit one or more applications to " "increase available memory, and then try again." msgstr "" -"이 작업을 위한 충분한 메모리가 없습니다.하나나더 많은 프로그램을 끝내아서 메" -"모리를 늘리고 다시 시도하십시오." +"메모리가 부족하기 때문에 이 작업을 할 수 없습니다. 응용 프로그램을 한 개 이" +"상 닫아 사용 가능한 메모리를 늘린 다음 다시 실행하십시오." #: winmm.rc:40 msgid "" "This function is not supported. Use the Capabilities function to determine " "which functions and messages the driver supports." msgstr "" -"이 함수는 지원되지 않습니다. 기능(Capability) 함수를 사용하여 드라이버가 지원" -"하는 함수와 메시지를 결정합니다." +"이 기능은 지원하지 않습니다. Capabilities 함수를 사용하여 드라이버가 지원하" +"는 기능 및 메시지를 결정하십시오." #: winmm.rc:41 msgid "An error number was specified that is not defined in the system." -msgstr "이 오류 넘버는 시스템에서 정의되지 않았습니다." +msgstr "시스템에서 정의되지 않은 오류 번호를 지정했습니다." #: winmm.rc:42 msgid "An invalid flag was passed to a system function." -msgstr "잘못된 플래그는 시스템 함수에서 무시했습니다." +msgstr "잘못된 플래그를 시스템 함수에 전달했습니다." #: winmm.rc:43 msgid "An invalid parameter was passed to a system function." -msgstr "잘못된 매개변수는 시스템 함수에서 무시했습니다." +msgstr "잘못된 매개변수가 시스템 함수에 전달되었습니다." #: winmm.rc:46 msgid "" "The specified format is not supported or cannot be translated. Use the " "Capabilities function to determine the supported formats." msgstr "" -"지정된 형식은 지원하지 않거나 전송할 수 없습니다. 지원하는 형식을 결정하는 가" -"능한 함수를 사용하십시오." +"지정한 형식이 지원되지 않거나 변환할 수 없습니다. 지원되는 형식을 결정하려면 " +"Capabilities 함수를 사용하십시오." #: winmm.rc:47 winmm.rc:53 msgid "" "Cannot perform this operation while media data is still playing. Reset the " "device, or wait until the data is finished playing." msgstr "" -"미디어 데이터가 재생되는 동안 이 작업을 실행할 수 없습니다. 장치를 리셋하거" -"나, 데이터 재생이 끝날때까지 기다리십시오." +"미디어 데이터가 계속 재생되는 동안에는 이 작업을 수행할 수 없습니다. 장치를 " +"재설정하거나 데이터 재생이 끝날 때까지 기다립니다." #: winmm.rc:48 msgid "" "The wave header was not prepared. Use the Prepare function to prepare the " "header, and then try again." msgstr "" -"웨이브 헤더가 준비되어 있지 않습니다. 준비 함수를 사용하여 헤더를 준비한 후" -"에 다시 시도하십시오." +"웨이브 헤더가 준비되지 않았습니다. Prepare 함수를 사용하여 헤더를 준비한 후 " +"다시 시도하십시오." #: winmm.rc:49 msgid "" "Cannot open the device without using the WAVE_ALLOWSYNC flag. Use the flag, " "and then try again." msgstr "" -"WAVE_ALLOWSYNC 플래그를 사용하지 않고 장치를 열 수 없습니다. 이 플래그를 사용" -"해서 다시 시도하십시오." +"WAVE_ALLOWSYNC 플래그를 사용하지 않고 장치를 열 수 없습니다. 플래그를 사용한 " +"후 다시 시도하십시오." #: winmm.rc:52 msgid "" "The MIDI header was not prepared. Use the Prepare function to prepare the " "header, and then try again." msgstr "" -"MIDI 헤더는 준비되지 않았습니다. 헤더를 준비하려면 준비 함수를 사용하십시오, " -"그리고 다시 시도하십시오n." +"MIDI 헤더가 준비되지 않았습니다. Prepare 함수를 사용하여 헤더를 준비한 후 다" +"시 시도하십시오." #: winmm.rc:54 msgid "" "A MIDI map was not found. There may be a problem with the driver, or the " "MIDIMAP.CFG file may be corrupt or missing." msgstr "" -"MIDI 맵은 찾을 수 없습니다. 드라이버의 문제이거나, MIDIMAP.CFG 파일이 망가졌" -"거나 없는 문제일 수도 있습니다." +"MIDI 맵을 찾을 수 없습니다. 드라이버에 문제가 있거나, 또는 MIDIMAP.CFG 파일" +"이 손실되었거나 없을 수 있습니다." #: winmm.rc:55 msgid "" "The port is transmitting data to the device. Wait until the data has been " "transmitted, and then try again." msgstr "" -"이 포트는 장치로 데이터를 옮기는 중입니다. 데이터가 다 옮겨질 때까지 기다리십" -"시오,그리고 다시 시도하십시오." +"포트가 데이터를 장치로 전송하고 있습니다. 데이터가 모두 전송될 때까지 기다린 " +"후 다시 시도하십시오." #: winmm.rc:56 winmm.rc:129 msgid "" "The current MIDI Mapper setup refers to a MIDI device that is not installed " "on the system." -msgstr "현재 미디 맵퍼 설정은 시스템에 설치되지 않은 미디 장치를 참조합니다." +msgstr "현재 MIDI 매퍼 설정은 시스템에 설치되지 않은 MIDI 장치를 참조합니다." #: winmm.rc:57 msgid "" "The current MIDI setup is damaged. Copy the original MIDIMAP.CFG file to the " "Windows SYSTEM directory, and then try again." msgstr "" -"현재 MIDI 설정은 손상되었습니다. 본래 MIDIMAP.CFG 파일을 Windows SYSTEM 디" -"렉터리에 복사하고, 다시 시도하십시오." +"현재 MIDI 설정이 손상되었습니다. 원래의 MIDIMAP.CFG 파일을 Windows SYSTEM 디" +"렉터리에 복사한 후 다시 시도하십시오." #: winmm.rc:60 msgid "Invalid MCI device ID. Use the ID returned when opening the MCI device." -msgstr "잘못된 MCI 장치 ID. MCI 장치를 열 때 반환한 ID를 사용하십시오." +msgstr "" +"MCI 장치 ID가 잘못되었습니다. MCI 장치를 열 때 반환된 ID를 사용하십시오." #: winmm.rc:61 msgid "The driver cannot recognize the specified command parameter." -msgstr "이 드라이버는 지정된 명령 매개변수를 인식할 수 없습니다." +msgstr "지정한 명령 매개변수를 드라이버가 인식할 수 없습니다." #: winmm.rc:62 msgid "The driver cannot recognize the specified command." -msgstr "이 드라이버는 지정된 명령을 인식할 수 없습니다." +msgstr "지정한 명령을 드라이버가 인식할 수 없습니다." #: winmm.rc:63 msgid "" @@ -10237,185 +10222,185 @@ msgid "" "The device name is already being used as an alias by this application. Use a " "unique alias." msgstr "" -"이 프로그램에서 장치 이름을 이미 별칭으로 사용하고 있습니다. 고유한 별칭을 사" -"용하십시오." +"프로그램에서 장치 이름을 이미 별칭으로 사용하고 있습니다. 고유한 별칭을 사용" +"하십시오." #: winmm.rc:67 msgid "" "There is an undetectable problem in loading the specified device driver." -msgstr "지정한 장치 드라이버를 로드하는 데 탐지할 수 없는 문제가 있습니다." +msgstr "지정한 장치 드라이버를 로드하는 중에 탐지할 수 없는 문제가 있습니다." #: winmm.rc:68 msgid "No command was specified." -msgstr "어떤 명령도 정의되지 않았습니다." +msgstr "명령을 지정하지 않았습니다." #: winmm.rc:69 msgid "" "The output string was too large to fit in the return buffer. Increase the " "size of the buffer." msgstr "" -"출력 문자열은 반환 버퍼에 채우기에는 너무 큽니다. 버퍼 크기를 증가시키십시오." +"출력 문자열이 너무 커서 리턴 버퍼에 맞지 않았습니다. 버퍼의 크기를 늘리십시" +"오." #: winmm.rc:70 msgid "" "The specified command requires a character-string parameter. Please provide " "one." -msgstr "지정된 명령은 캐릭터-문자열 매개변수를 요구합니다. 지정해 주십시오." +msgstr "지정한 명령에 문자열 매개변수가 필요합니다. 매개변수를 입력하십시오." #: winmm.rc:71 msgid "The specified integer is invalid for this command." -msgstr "지정된 정수는 이 명령에 적합하지 않습니다." +msgstr "지정한 정수는 이 명령에 적합하지 않습니다." #: winmm.rc:72 msgid "" "The device driver returned an invalid return type. Check with the device " "manufacturer about obtaining a new driver." msgstr "" -"이 장치 드라이버는 잘못된 반환 값을 반환하였습니다. 장치 제조자에게서 새 드라" -"이버를 얻을 수 있는지 체크하십시오." +"장치 드라이버가 잘못된 반환 형식을 반환했습니다. 새 드라이버를 얻을 수 있는" +"지 장치 제조업체에 확인하십시오." #: winmm.rc:73 msgid "" "There is a problem with the device driver. Check with the device " "manufacturer about obtaining a new driver." msgstr "" -"이것은 장치 드라이버 문제입니다. 장치 제조자에게서 새 드라이버를 얻을 수 있는" -"지 체크하십시오." +"장치 드라이버에 문제가 있습니다. 새 드라이버를 얻을 수 있는지 장치 제조업체" +"에 확인하십시오." #: winmm.rc:74 msgid "The specified command requires a parameter. Please supply one." -msgstr "지정된 명령은 매개변수를 요구합니다. 매개변수를 추가하십시오." +msgstr "지정한 명령은 매개변수가 필요합니다. 매개변수를 입력하십시오." #: winmm.rc:75 msgid "The MCI device you are using does not support the specified command." -msgstr "사용 중인 MCI 장치가 지정된 명령을 지원하지 않습니다." +msgstr "사용 중인 MCI 장치가 지정한 명령을 지원하지 않습니다." #: winmm.rc:76 msgid "" "Cannot find the specified file. Make sure the path and filename are correct." msgstr "" -"지정된 파일을 찾을 수 없습니다.경로와 파일 이름이 올바른지 확인하십시오." +"지정한 파일을 찾을 수 없습니다.경로와 파일 이름이 올바른지 확인하십시오." #: winmm.rc:77 msgid "The device driver is not ready." -msgstr "장치 드라이버는 준비되지 않았습니다." +msgstr "장치 드라이버가 준비되지 않았습니다." #: winmm.rc:78 msgid "A problem occurred in initializing MCI. Try restarting Windows." -msgstr "" -"MCI 초기화시 문제가 발생했습니다. Windows를 다시 시작하고 시도해보세요." +msgstr "MCI 초기화 중 문제가 발생했습니다. Windows를 다시 시작하십시오." #: winmm.rc:79 msgid "" "There is a problem with the device driver. The driver has closed. Cannot " "access error." msgstr "" -"이것은 장치 드라이버 문제입니다. 드라이버가 닫혔습니다. 오류에 접근할 수 없습" -"니다." +"장치 드라이버에 문제가 있습니다. 드라이버가 닫혔습니다. 오류에 액세스할 수 없" +"습니다." #: winmm.rc:80 msgid "Cannot use 'all' as the device name with the specified command." -msgstr "지정된 명령의 장치 이름으로 'all'은 사용할 수 없습니다." +msgstr "지정한 명령의 장치 이름으로 'all'을 사용할 수 없습니다." #: winmm.rc:81 msgid "" "Errors occurred in more than one device. Specify each command and device " "separately to determine which devices caused the error." msgstr "" -"하나나 더 많은 장치에서 오류 발생. 장치가 발생시키는 오류를 처리할 수 있도록 " -"각가의 장치에 명령을 지정하십시오." +"두 개 이상의 장치에서 오류가 발생했습니다. 각 명령 및 장치를 별도로 지정하여 " +"오류를 일으킨 장치를 결정합니다." #: winmm.rc:82 msgid "Cannot determine the device type from the given filename extension." -msgstr "주어진 파일 확장자로 장치 타입을 결정할 수 없습니다." +msgstr "주어진 파일 확장자에서 장치 유형을 결정할 수 없습니다." #: winmm.rc:83 msgid "The specified parameter is out of range for the specified command." -msgstr "지정된 매개변수는 지정된 명령 범위 밖에 있습니다." +msgstr "매개변수가 지정한 명령의 범위를 벗어났습니다." #: winmm.rc:84 msgid "The specified parameters cannot be used together." -msgstr "지정된 매개변수는 함께 사용할 수 없습니다." +msgstr "지정한 매개변수는 함께 사용할 수 없습니다." #: winmm.rc:85 msgid "" "Cannot save the specified file. Make sure you have enough disk space or are " "still connected to the network." msgstr "" -"지정된 파일을 저장할 수 없습니다. 충분한 공간이 있는지 확인하거나.내트워크가 " -"연결되어있는지 확인하세요." +"지정한 파일을 저장할 수 없습니다. 디스크 공간이 충분한지 또는 아직 네트에크" +"에 연결되어 있는지 확인하십시오." #: winmm.rc:86 msgid "" "Cannot find the specified device. Make sure it is installed and that the " "device name is spelled correctly." msgstr "" -"지정한 장치를 찾을 수 없습니다. 장치가 설치되어 있는지, 장치 이름이 올바른지 " -"확인하기 바랍니다." +"지정한 장치를 찾을 수 없습니다. 장치가 설치 여부와 장치 이름 철자가 올바른지" +"를 확인하십시오." #: winmm.rc:87 msgid "" "The specified device is now being closed. Wait a few seconds, and then try " "again." -msgstr "지정된 장치는 지금 닫혔습니다. 잠시 기다린 후에 다시 시도하십시오." +msgstr "지정한 장치는 현재 닫혀 있습니다. 잠시 기다린 후, 다시 시도하십시오." #: winmm.rc:88 msgid "" "The specified alias is already being used in this application. Use a unique " "alias." msgstr "" -"지정된 별칭은 이미 이 프로그램이 사용하고 있습니다. 다른 유일한 별칭을 사용하" -"십시오." +"지정한 별칭이 이미 응용프로그램에서 사용되고 있습니다. 다른 고유한 별칭을 사" +"용하십시오." #: winmm.rc:89 msgid "The specified parameter is invalid for this command." -msgstr "지정된 매개변수는 이 명령에 적합하지 않습니다." +msgstr "지정한 매개변수가 이 명령에 적합하지 않습니다." #: winmm.rc:90 msgid "" "The device driver is already in use. To share it, use the 'shareable' " "parameter with each 'open' command." msgstr "" -"이 장치 드라이버는 이미 사용중입니다. 이것을 공유하려면, 'shareable' 매개변수" -"를 'open'명령과 같이 사용하십시오." +"장치 드라이버가 이미 사용되고 있습니다. 공유하려면 각 'open' 명령마다 " +"'shareable' 매개변수를 사용하십시오." #: winmm.rc:91 msgid "" "The specified command requires an alias, file, driver, or device name. " "Please supply one." msgstr "" -"지정된 명령은 별명,파일,드라이버나 장치 이름을 필요로 합니다. 이것을 지정하십" -"시오." +"지정한 명령은 별칭, 파일, 드라이버 또는 장치 이름이 필요합니다. 이 중 하나를 " +"입력하십시오." #: winmm.rc:92 msgid "" "The specified value for the time format is invalid. Refer to the MCI " "documentation for valid formats." msgstr "" -"시간 형식에 지정된 값은 올바르지 않습니다. MCI 문서에서 올바를 형식을 확인하" -"십시오." +"시간 형식에 지정한 값이 잘못되었습니다. MCI 문서에서 유효한 형식에 관한 내용" +"을 참조하십시오." #: winmm.rc:93 msgid "" "A closing double-quotation mark is missing from the parameter value. Please " "supply one." -msgstr "매개변수 값에서 닫힌 쌍 따옴표 하나가 빠졌습니다. 이것을 지정하십시오." +msgstr "매개변수 값에 닫는 큰 따옴표(\")가 빠졌습니다. 입력하십시오." #: winmm.rc:94 msgid "A parameter or value was specified twice. Only specify it once." -msgstr "이 값의 매개변수는 두번 지정되었습니다. 오직 하나만 지정하십시오." +msgstr "매개변수 또는 값을 두 번 지정했습니다. 한번만 지정하십시오." #: winmm.rc:95 msgid "" "The specified file cannot be played on the specified MCI device. The file " "may be corrupt, or not in the correct format." msgstr "" -"이 지정된 파일은 지정된 MCI장치에서 재생할 수 없습니다. 이 파일이 깨졌거나 올" -"바르지 않은 형식입니다." +"지정한 파일을 MCI 장치에서 재생할 수 없습니다. 파일이 손상되었거나 올바른 형" +"식이 아닐 수 있습니다." #: winmm.rc:96 msgid "A null parameter block was passed to MCI." -msgstr "이 빈 매개변수 블럭은 MCI에서 무시되었습니다." +msgstr "비어있는 매개변수 블럭이 MCI에 전달되었습니다." #: winmm.rc:97 msgid "Cannot save an unnamed file. Supply a filename." @@ -10423,59 +10408,59 @@ msgstr "이름없는 파일을 저장할 수 없습니다. 파일 이름을 지 #: winmm.rc:98 msgid "You must specify an alias when using the 'new' parameter." -msgstr "'반드시 new'매개변수를 사용할 별명을 지정해주어야 합니다." +msgstr "'new' 매개변수를 사용할 때 별칭을 지정해야 합니다." #: winmm.rc:99 msgid "Cannot use the 'notify' flag with auto-opened devices." -msgstr "'notify' 플래그는 자동으로 열린 장치에 사용할 수 없습니다." +msgstr "'notify' 플래그는 자동 열기 장치에 사용할 수 없습니다." #: winmm.rc:100 msgid "Cannot use a filename with the specified device." -msgstr "지정된 장치하고 파일 이름은 같이 사용할 수 없습니다." +msgstr "저정한 장치에 파일 이름을 사용할 수 없습니다." #: winmm.rc:101 msgid "" "Cannot carry out the commands in the order specified. Correct the command " "sequence, and then try again." msgstr "" -"명령을 지정된 순서대로 보낼 수 없습니다. 명령 순서를 수정하여 다시 시도하십시" -"오." +"지정한 순서대로 명령을 수행할 수 없습니다. 명령 순서를 수정한 다음 다시 시도" +"하십시오." #: winmm.rc:102 msgid "" "Cannot carry out the specified command on an auto-opened device. Wait until " "the device is closed, and then try again." msgstr "" -"지정된 명령을 자동으로 열린 장치에 보낼 수 없습니다. 장치가 닫히기를 기다리" -"고 다시 시도하십시오." +"자동 열기 장치에서 지정한 명령을 수행할 수 없습니다. 장치가 닫힐 때까지 기다" +"렸다가 다시 시도하십시오." #: winmm.rc:103 msgid "" "The filename is invalid. Make sure the filename is not longer than 8 " "characters, followed by a period and an extension." msgstr "" -"이 파일 이름은 올바르지 않습니다. 파일 이름이 점과 확장자를 더해서 8자보다 길" -"지 않은지 확인하십시오." +"파일 이름이 잘못되었습니다. 파일 이름이 8 문자를 넘지 않고, 점과 확장명이 있" +"는지 확인하십시오." #: winmm.rc:104 msgid "" "Cannot specify extra characters after a string enclosed in quotation marks." -msgstr "인용부호로 둘러 싼 문자 뒤에 추가 문자를 지정할 수 없습니다." +msgstr "문자열을 따옴표로 닫은 후에는 문자를 더 지정할 수 없습니다." #: winmm.rc:105 msgid "" "The specified device is not installed on the system. Use the Drivers option " "in Control Panel to install the device." msgstr "" -"지정된 장치는 시스템에 설치되어 있지 않습니다. 제어판에서 드라이버 옵션을 사" -"용해서 장치를 설치하십시오." +"지정한 장치가 시스템에 설치되지 않았습니다. 제어판에서 드라이버 옵션을 사용하" +"여 장치를 설치하십시오." #: winmm.rc:106 msgid "" "Cannot access the specified file or MCI device. Try changing directories or " "restarting your computer." msgstr "" -"지정된 파일이나 MCI 장치에 접근할 수 없습니다. 디렉터리를 바꾸거나 컴퓨터를 " +"지정한 파일이나 MCI 장치에 접근할 수 없습니다. 디렉터리를 바꾸거나 컴퓨터를 " "다시 시작하십시오." #: winmm.rc:107 @@ -10483,104 +10468,105 @@ msgid "" "Cannot access the specified file or MCI device because the application " "cannot change directories." msgstr "" -"프로그램이 디렉터리를 바꿀 수 없기 때문에 지정된 특정한 파일이나 MCI장치에 접" -"근할 수 없습니다." +"프로그램이 디렉터리를 바꿀 수 없기 때문에 지정한 파일이나 MCI장치에 접근할 " +"수 없습니다." #: winmm.rc:108 msgid "" "Cannot access specified file or MCI device because the application cannot " "change drives." msgstr "" -"프로그램이 디렉터리를 바꿀 수 없기 때문에 지정한 파일이나 MCI장치에 접근할 " +"프로그램이 드라이브를 바꿀 수 없기 때문에 지정한 파일이나 MCI 장치에 접근할 " "수 없습니다." #: winmm.rc:109 msgid "Specify a device or driver name that is less than 79 characters." -msgstr "79자보다 적게 장치나 드라이버 이름을 지정하십시오." +msgstr "장치나 드라이버 이름을 79자 미만으로 지정하십시오." #: winmm.rc:110 msgid "Specify a device or driver name that is less than 69 characters." -msgstr "69자보다 적게 장치나 드라이버 이름을 지정하십시오." +msgstr "장치나 드라이버 이름을 69자 미만으로 지정하십시오." #: winmm.rc:111 msgid "" "The specified command requires an integer parameter. Please provide one." -msgstr "지정된 명령은 정수 매개 변수를 요구합니다. 이것을 지정하십시오." +msgstr "" +"지정한 명령에는 정수 매개변수가 필요합니다. 올바른 매개변수를 지정하십시오." #: winmm.rc:112 msgid "" "All wave devices that can play files in the current format are in use. Wait " "until a wave device is free, and then try again." msgstr "" -"현재 형식의 파일을 재생하는 모든 웨이브 장치는 사용중입니다. 웨이브 장치가 자" -"유롭게 될 때 다시 시도하십시오." +"현재 형식으로 파일을 재생할 수 있는 모든 웨이브 장치가 사용 중입니다. 웨이브 " +"장치를 사용할 수 있을 때까지 기다린 다음 다시 시도하십시오." #: winmm.rc:113 msgid "" "Cannot set the current wave device for play back because it is in use. Wait " "until the device is free, and then try again." msgstr "" -"사용중이므로 현재 웨이브 장치를 플레이 백으로 설정할 수 없습니다. 장치가 자유" -"롭게 될때까지 기다리고, 다시 시도하십시오." +"현재 웨이브 장치가 사용 중이므로 재생하도록 설정할 수 없습니다. 장치를 사용" +"할 수 있을 때까지 기다린 다음 다시 시도하십시오." #: winmm.rc:114 msgid "" "All wave devices that can record files in the current format are in use. " "Wait until a wave device is free, and then try again." msgstr "" -"현재 형식의 파일을 녹음하는 모든 웨이브 장치는 사용중입니다. 웨이브 장치가 자" -"유롭게 될 때 다시 시도하십시오." +"파일을 현재 형식으로 녹음할 수 있는 모든 웨이브 장치가 사용 중입니다. 웨이브 " +"장치를 사용할 수 있을 때까지 기다린 다음 다시 시도하십시오." #: winmm.rc:115 msgid "" "Cannot set the current wave device for recording because it is in use. Wait " "until the device is free, and then try again." msgstr "" -"사용중이므로 현재 웨이브 장치를 녹음으로 설정할 수 없습니다. 장치가 자유롭게 " -"될때까지 기다리고, 다시 시도하십시오." +"현재 웨이브 장치가 사용 중이므로 녹음하도록 설정할 수 없습니다. 장치를 사용" +"할 수 있을 때까지 기다린 다음 다시 시도하십시오." #: winmm.rc:116 msgid "Any compatible waveform playback device may be used." -msgstr "어떤 호환성이 있는 웨이브폼 플레이백 장치도 사용될수 있습니다." +msgstr "모든 호환 가능한 웨이브폼 재생 장치를 사용할 수 있습니다." #: winmm.rc:117 msgid "Any compatible waveform recording device may be used." -msgstr "어떤 호환성이 있는 웨이브폼 녹음 장치도 사용될수 있습니다." +msgstr "모든 호환 가능한 웨이브폼 녹음 장치를 사용할 수 있습니다." #: winmm.rc:118 msgid "" "No wave device that can play files in the current format is installed. Use " "the Drivers option to install the wave device." msgstr "" -"현재 형식의 파일을 재생할 수 있는 어떤 웨이브 장치도 없습니다. 드라이버 옵션" -"에서 웨이브 장치를 설치하십시오." +"현재 형식으로 파일을 재생할 수 있는 웨이브 장치가 설치되지 않았습니다. [드라" +"이버] 옵션을 사용하여 웨이브 장치를 설치하십시오." #: winmm.rc:119 msgid "" "The device you are trying to play to cannot recognize the current file " "format." -msgstr "재생하려는 장치는 현재 파일 형식을 인식할 수 없습니다." +msgstr "재생하려는 장치에서 현재 파일 형식을 인식할 수 없습니다." #: winmm.rc:120 msgid "" "No wave device that can record files in the current format is installed. Use " "the Drivers option to install the wave device." msgstr "" -"현재 형식의 파일을 녹음할 수 있는 어떤 웨이브 장치도 없습니다. 드라이버 옵션" -"에서 웨이브 장치를 설치하십시오." +"현재 형식으로 파일을 기록할 수 있는 웨이브 장치가 설치되지 않았습니다. [드라" +"이버] 옵션을 사용하여 웨이브 장치를 설치하십시오." #: winmm.rc:121 msgid "" "The device you are trying to record from cannot recognize the current file " "format." -msgstr "녹음하려는 장치는 현재 파일 형식을 인식할 수 없습니다." +msgstr "녹음하려는 장치에서 현재 파일 형식을 인식할 수 없습니다." #: winmm.rc:126 msgid "" "The time formats of the \"song pointer\" and SMPTE are mutually exclusive. " "You can't use them together." msgstr "" -"\"sont pointer\"와 SMPTE의 시간 형식은 상호 배타적입니다. 함께 쓸 수 없습니" +"\"song pointer\"와 SMPTE의 시간 형식은 상호 배타적입니다. 함께 쓸 수 없습니" "다." #: winmm.rc:128 @@ -10588,64 +10574,64 @@ msgid "" "The specified MIDI port is already in use. Wait until it is free; then try " "again." msgstr "" -"지정된 MIDI 포트는 이미 사용중입니다. 자유롭게 될 때까지 기다리고 다시 시도" -"하십시오." +"저정한 MIDI 포트는 이미 사용 중입니다. 사용할 수 있을 때까지 기다른 다음 다" +"시 시도하십시오." #: winmm.rc:131 msgid "" "The specified MIDI device is not installed on the system. Use the Drivers " "option from the Control Panel to install a MIDI device." msgstr "" -"지정된 MIDI 장치는 시스템에 설치되어 있지 않습니다. 제어판에서 장치 옵션을 사" -"용해서 MIDI 장치를 설치하십시오." +"지정한 MIDI 장치는 시스템에 설치되어 있지 않습니다. 제어판에서 [드라이버] 옵" +"션을 사용해서 MIDI 장치를 설치하십시오." #: winmm.rc:130 msgid "An error occurred with the specified port." -msgstr "지정된 포트에 오류가 발생했습니다." +msgstr "지정한 포트에 오류가 발생했습니다." #: winmm.rc:133 msgid "" "All multimedia timers are being used by other applications. Quit one of " "these applications; then, try again." msgstr "" -"모든 멀티미디어 타이머를 다른 프로그램이 사용하고 있습니다. 최소한 하나의 프" -"로그램을 끝내고 다시 시도하십시오." +"모든 멀티미디어 타이머는 다른 프로그램에서 사용되고 있습니다. 이들 프로그램 " +"중 하나를 종료한 다음 다시 시도하십시오." #: winmm.rc:132 msgid "The system doesn't have a current MIDI port specified." -msgstr "이 시스템은 현재 열거된 MIDI포트를 가지고 있지 않습니다." +msgstr "시스템에 현재 MIDI 포트가 지정되어 있지 않습니다." #: winmm.rc:127 msgid "" "The system has no installed MIDI devices. Use the Drivers option from the " "Control Panel to install a MIDI driver." msgstr "" -"시스템에 설치된 MIDI 장치가 없습니다. 제어판의 드라이버 옵션을 사용하여 MIDI " -"드라이버를 설치하십시오." +"시스템에 MIDI 장치가 설치되어 있지 않습니다. 제어판에서 [드라이버] 옵션을 사" +"용해서 MIDI 드라이버를 설치하십시오." #: winmm.rc:122 msgid "There is no display window." -msgstr "어떤 디스플레이 창도 없습니다." +msgstr "디스플레이 창이 없습니다." #: winmm.rc:123 msgid "Could not create or use window." -msgstr "창을 사용하거나 만들 수 없습니다." +msgstr "창을 만들거나 사용할 수 없습니다." #: winmm.rc:124 msgid "" "Cannot read the specified file. Make sure the file is still present, or " "check your disk or network connection." msgstr "" -"지정한 파일을 읽을 수 없습니다. 파일이 아직 있는지 확인하거나 디스크 또는 네" -"트워크 연결을 확인하십시오." +"지정한 파일을 읽을 수 없습니다. 파일이 있는지 확인하거나, 디스크나 네트워크 " +"연결을 확인하십시오." #: winmm.rc:125 msgid "" "Cannot write to the specified file. Make sure you have enough disk space or " "are still connected to the network." msgstr "" -"지정된 파일에 쓸 수 없습니다. 디스크 공간이 충분한지 확인하거나 네트워크에 연" -"결되어 있는지 확인하십시오." +"지정한 파일에 쓸 수 없습니다. 디스크 용량이 충분한 지 또는 네트워크 연결이 되" +"었는지 확인하십시오." #: winmm.rc:136 msgid "Wine Sound Mapper" @@ -10661,7 +10647,7 @@ msgstr "주 볼륨" #: winmm.rc:139 msgid "Mute" -msgstr "소거" +msgstr "음소거" #: winspool.rc:37 msgid "Print to File" @@ -10901,7 +10887,7 @@ msgstr "LDAP 프로토콜의 이 버전은 그 작업을 지원하지 않습니 #: wldap32.rc:125 msgid "Specified control was not found in message" -msgstr "지정된 제어는 메시지에서 발견할 수 없습니다" +msgstr "지정한 제어는 메시지에서 발견할 수 없습니다" #: wldap32.rc:126 msgid "No result present in message" @@ -11333,7 +11319,7 @@ msgid "" "list, so parameter 2 becomes parameter 1 and so on. It has no effect if\n" "called from the command line.\n" msgstr "" -"SHIFT는 배치 파일 안에서 매개 변수 리스트의 처음 하나를 제거 위해서\n" +"SHIFT는 배치 파일 안에서 매개변수 리스트의 처음 하나를 제거 위해서\n" "사용합니다. 매개변수 2가 매개변수 1이 되는 식입니다. 이것은 명령 라인에서\n" "사용했을 경우에는 아무 영향이 없습니다.\n" @@ -11490,7 +11476,7 @@ msgstr "" "\n" "매개변수 없는 ASSOC는 현재 파일 연결을 표시합니다\n" "만약 파일 확장자만 사용된다면, 현재 연결 상태를 표시합니다.\n" -"등호(=) 부호 다음에 파일 유형이 지정되지 않으면 현재 연결을\n" +"등호(=) 부호 다음에 파일 유형을 지정하지 않으면 현재 연결을\n" "제거합니다.\n" #: cmd.rc:300 @@ -11514,7 +11500,7 @@ msgstr "" "표시합니다.\n" "만약 파일 형식만 사용한다면, 연결된 열기 명령 문자열을 표시합니다\n" "(연결이 있다면).\n" -"등호(=) 부호 다음에 열기 명령이 지정되지 않으면 지정된 파일 형식에 연결된\n" +"등호(=) 부호 다음에 열기 명령을 지정하지 않으면 지정한 파일 형식에 연결된\n" "명령어 문자열을 제거합니다.\n" #: cmd.rc:303 @@ -11640,7 +11626,7 @@ msgstr "" "TYPE 텍스트 파일의 내용 보기\n" "VER CMD 현재 버전 보기\n" "VOL 디스크 장치의 불륨 레이블 보기\n" -"XCOPY 원본 파일이나 디렉터리 구조를 대상으로 복사함\n" +"XCOPY 원본 파일이나 디렉터리 구조를 대상에 복사함\n" "EXIT CMD 닫기\n" "\n" "HELP <명령>을 치면 그 명령의 상세한 정보를 표시합니다.\n" @@ -11887,7 +11873,7 @@ msgstr "이더넷" #: ipconfig.rc:35 msgid "Connection-specific DNS suffix" -msgstr "연결에 지정된 DNS 접미사" +msgstr "연결별 DNS 접미사" #: ipconfig.rc:36 msgid "IPv4 address" @@ -12485,7 +12471,7 @@ msgstr "전문가 모드(&E)" #: oleview.rc:65 msgid "&Hidden component categories" -msgstr "컴포넌트 분류 숨기기(&H)" +msgstr "구성 요소 분류 숨기기(&H)" #: oleview.rc:67 oleview.rc:89 winefile.rc:65 wordpad.rc:71 wordpad.rc:272 msgid "&Toolbar" @@ -12617,7 +12603,7 @@ msgstr "선택된 객체의 인스턴트 만들기" #: oleview.rc:111 msgid "Create an instance of the selected object on a specific machine" -msgstr "지정된 머신의 선택된 객체의 인스턴트 만들기" +msgstr "지정한 머신의 선택된 객체의 인스턴트 만들기" #: oleview.rc:112 msgid "Release the currently selected object instance" @@ -12638,7 +12624,7 @@ msgstr "전문가와 초보자 모드 전환e" #: oleview.rc:120 msgid "" "Toggle the display of component categories that are not meant to be visible" -msgstr "컴포넌트 목록 보기(보이지 않더라도)" +msgstr "구성 요소 목록 보기(보이지 않더라도)" #: oleview.rc:121 msgid "Show or hide the toolbar" @@ -12977,7 +12963,7 @@ msgid "" "\n" msgstr "" "문법:\n" -" REG [명령] [매개 변수]\n" +" REG [명령] [매개변수]\n" "\n" "지원하는 명령:\n" " ADD | DELETE | IMPORT | EXPORT | QUERY\n" @@ -13019,7 +13005,7 @@ msgstr "reg: 원격 컴퓨터에 액세스할 수 없습니다\n" #: reg.rc:43 msgid "" "reg: The system was unable to find the specified registry key or value\n" -msgstr "reg: 시스템에서 지정된 레지스트리 키 또는 값을 찾을 수 없습니다\n" +msgstr "reg: 시스템에서 지정한 레지스트리 키 또는 값을 찾을 수 없습니다\n" #: reg.rc:44 msgid "reg: Unsupported registry data type [%1]\n" @@ -13063,7 +13049,7 @@ msgstr "레지스트리 키 '%1'을 제거하시겠습니까?" #: reg.rc:57 msgid "reg: The option [/d] must be followed by a valid string\n" -msgstr "reg : 옵션 [/d] 다음에 유효한 문자열이 있어야 합니다.\n" +msgstr "reg : 옵션 [/d] 다음에 유효한 문자열이 있어야 합니다\n" #: reg.rc:58 msgid "" @@ -13078,7 +13064,7 @@ msgid "" "reg: Unable to complete the specified operation. An unexpected error " "occurred.\n" msgstr "" -"reg: 지정된 작업을 완료할 수 없습니다. 예기치 않은 오류가 발생했습니다.\n" +"reg: 지정한 작업을 완료할 수 없습니다. 예기치 않은 오류가 발생했습니다.\n" #: reg.rc:60 msgid "Search complete. Number of matches found: %1!d!\n" @@ -13290,30 +13276,29 @@ msgstr "다중 문자열 편집" #: regedit.rc:159 msgid "Contains commands for working with the whole registry" -msgstr "전체 레지스트리 작업 명령이 포함되어 있습니다" +msgstr "전체 레지스트리 작업 명령이 들어 있습니다" #: regedit.rc:160 msgid "Contains commands for editing values or keys" -msgstr "값 또는 키 편집에 대한 명령이 포함되어 있습니다" +msgstr "값 또는 키 편집에 대한 명령이 들어 있습니다" #: regedit.rc:161 msgid "Contains commands for customizing the registry window" -msgstr "레지스트리 창 사용자 정의 명령이 포함되어 있습니다" +msgstr "레지스트리 창 사용자 정의 명령이 들어 있습니다" #: regedit.rc:162 msgid "Contains commands for accessing frequently used keys" -msgstr "자주 사용되는 키에 액세스하는 명령이 포함되어 있습니다" +msgstr "자주 사용되는 키에 액세스하는 명령이 들어 있습니다" #: regedit.rc:163 msgid "" "Contains commands for displaying Help and information about Registry Editor" msgstr "" -"레지스트리 편집기에 대한 도움말 및 정보를 표시하기 위한 명령이 포함되어 있습" -"니다" +"레지스트리 편집기에 대한 도움말 및 정보를 표시하기 위한 명령이 들어 있습니다" #: regedit.rc:164 msgid "Contains commands for creating new keys or values" -msgstr "새 키 또는 값을 만드는 명령이 포함되어 있습니다" +msgstr "새 키 또는 값을 만드는 명령이 들어 있습니다" #: regedit.rc:149 msgid "Data" @@ -13436,9 +13421,9 @@ msgstr "" " /R:user.dat 수정할 user.dat 파일의 위치입니다.\n" " Compatible with any other switch. Ignored.\n" " /C 레지스트리 파일의 내용을 가져옵니다.\n" -" /D 지정된 레지스트리 키를 제거합니다.\n" -" /E 지정된 레지스트리 키의 내용을 파일로 내보냅니다.\n" -" 키가 지정되지 않은 경우 전체 레지스트리를 내보냅니다.\n" +" /D 지정한 레지스트리 키를 제거합니다.\n" +" /E 지정한 레지스트리 키의 내용을 파일로 내보냅니다.\n" +" 키를 지정하지 않은 경우 전체 레지스트리를 내보냅니다.\n" " /S 메시지를 출력하지 않습니다.\n" " /V GUI를 고급 모드로 실행합니다. Ignored.\n" " /? 이 정보를 출력하고 끝냅니다.\n" @@ -13462,11 +13447,11 @@ msgstr "도움말을 보려면 \"regedit /?\"를 입력하십시오.\n" #: regedit.rc:411 msgid "regedit: No filename was specified.\n" -msgstr "regedit: 파일 이름이 지정되지 않았습니다.\n" +msgstr "regedit: 파일 이름을 지정하지 않았습니다.\n" #: regedit.rc:412 msgid "regedit: No registry key was specified for removal.\n" -msgstr "regedit: 제거할 레지스트리 키가 지정되지 않았습니다.\n" +msgstr "regedit: 제거할 레지스트리 키를 지정하지 않았습니다.\n" #: regedit.rc:413 msgid "regedit: The file '%1' was not found.\n" @@ -13497,7 +13482,7 @@ msgstr "" #: regedit.rc:419 msgid "regedit: Unrecognized escape sequence [\\%1!c!]\n" -msgstr "regedit: [\\%1!c!](은)는 알수 없는 제어 문자입니다\n" +msgstr "regedit: [\\%1!c!](은)는 알 수 없는 제어 문자입니다\n" #: regedit.rc:420 msgid "regedit: Unsupported registry data type [0x%1!x!]\n" @@ -13589,7 +13574,7 @@ msgstr "키, 값, 데이터에서 텍스트 문자열을 찾습니다" #: regedit.rc:197 msgid "Finds next occurrence of text specified in previous search" -msgstr "이전 검색에서 지정한 텍스트의 다음 위치를 찾습니다" +msgstr "이전에 지정한 찾기 텍스트의 다음 위치를 검색합니다" #: regedit.rc:169 msgid "Modifies the value's data" @@ -13794,12 +13779,12 @@ msgid "" "specified file.\n" "ShellExecuteEx failed" msgstr "" -"프로그램을 실행할 수 없거나, 지정된 파일에 연결된 프로그램이 없습니다.\n" +"프로그램을 실행할 수 없거나, 지정한 파일에 연결된 프로그램이 없습니다.\n" "ShellExecuteEx 실패" #: start.rc:60 msgid "Could not translate the specified Unix filename to a DOS filename." -msgstr "지정된 Unix 파일 이름을 DOS 파일 이름으로 바꿀 수 없습니다." +msgstr "지정한 Unix 파일 이름을 DOS 파일 이름으로 바꿀 수 없습니다." #: taskkill.rc:30 msgid "Usage: taskkill [/?] [/f] [/im ProcessName | /pid ProcessID]\n" @@ -14709,7 +14694,7 @@ msgstr "" " --help 지금 보고 있는 정보를 출력합니다.\n" " --list 실행한 Wine에 설치된 모든 프로그램의 목록을 출력합니다.\n" " --remove {GUID} 지정한 프로그램을 제거합니다. 프로그램의 GUID를 알아\n" -" 내기 위해서는 '--list' 옵션을 사용하십시오.\n" +" 내려면 '--list' 옵션을 사용하십시오.\n" " [옵션 없음] 옵션없이 실행하면 uninstaller의 GUI 버전이 시작됩니다.\n" "\n" @@ -14793,8 +14778,8 @@ msgid "" "or per-application settings in those tabs as well." msgstr "" "Wine은 각각의 프로그램에 대해 다른 Windows 버전을 흉내낼 수 있습니다. 이 탭" -"은 라이브러리 및 그래픽 탭과 연결되어 해당 탭의 시스템 전체 또는 프로그램 별 " -"설정을 바꿀 수 있습니다." +"은 라이브러리 및 그래픽 탭과 연결되어 시스템 전체 또는 프로그램별 설정을 바" +"꿀 수 있습니다." #: winecfg.rc:159 msgid "Add appli&cation..." @@ -15201,8 +15186,8 @@ msgstr "" "드라이브 C 항목을 제거하시겠습니까?\n" "\n" "대부분의 Windows 프로그램은 C 드라이브가 있다고 예상합니다. C 드라이브가 없다" -"면 비정상적인 방법으로 종료합입니다. 계속 진행한다면 반드시 C 드라이브를 다" -"시 만드십시오!" +"면 비정상적인 방법으로 종료합니다. 계속 진행한다면 반드시 C 드라이브를 다시 " +"만드십시오!" #: winecfg.rc:77 msgctxt "Drive letter" @@ -15716,7 +15701,7 @@ msgstr "Wine 파일 관리자 정보(&A)" #: winefile.rc:122 msgid "Select destination" -msgstr "목적지 선택" +msgstr "대상 선택" #: winefile.rc:135 msgid "By File Type" @@ -16354,7 +16339,7 @@ msgstr "inch" #: wordpad.rc:185 msgid "inch" -msgstr "inch" +msgstr "인치" #: wordpad.rc:186 msgctxt "unit: point" @@ -16515,7 +16500,7 @@ msgid "" "\t\tthan source.\n" "\n" msgstr "" -"XCOPY - 파일이나 디렉터리 트리를 목적지로 복사합니다.\n" +"XCOPY - 파일 또는 디렉터리 트리 원본을 대상에 복사합니다.\n" "\n" "구문:\n" "XCOPY 원본 [대상] [/I] [/S] [/Q] [/F] [/L] [/W] [/T] [/N] [/U]\n" @@ -16545,6 +16530,6 @@ msgstr "" "[/K] 파일 속성을 유지하면서 복사합니다.\n" " 이 옵션이 없으면 속성을 유지하지 않습니다.\n" "[/D | /D:m-d-y]\n" -" 지정된 날짜 후에 수정되거나 새로운 파일을 복사합니다.\n" +" 새 파일이나 지정한 날짜 후에 수정된 파일을 복사합니다.\n" " 날짜를 지정하지 않으면, 원본보다 대상이 오래된 것만 복사합니다.\n" "\n" -- 2.20.0

1 0

[PATCH 1/6] user32/focus: Prevent a recursive activation loop with the activation messages
by Gabriel Ivăncescu 17 Dec '18

17 Dec '18

When activating a window and sending activation messages to the window procedure (i.e. WM_NCACTIVATE and WM_ACTIVATE), we have to avoid a recursive loop by not sending more of these messages or hooks while we are still activating the window. Some applications actually depend on this behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46274 Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- It may seem a bit strange (and I thought so as well initially), but this is exactly what's needed to match the testcase in the next patch, so this is how Windows does it (yes, including the hooks). Total Commander's Multi-Rename Tool requires this behavior, if you actually click on "Start!" in it. Closing the window then ends up in the recursion, which is only stopped by MAX_WINPROC_RECURSION after a few seconds, but then the listbox's caret is messed up. dlls/user32/focus.c | 44 +++++++++++++++++++++++++++++--------------- dlls/user32/win.h | 1 + 2 files changed, 30 insertions(+), 15 deletions(-) diff --git a/dlls/user32/focus.c b/dlls/user32/focus.c index f1c8831..edf9256 100644 --- a/dlls/user32/focus.c +++ b/dlls/user32/focus.c @@ -78,7 +78,7 @@ static BOOL set_active_window( HWND hwnd, HWND *prev, BOOL mouse, BOOL focus ) { HWND previous = GetActiveWindow(); BOOL ret; - DWORD old_thread, new_thread; + DWORD winflags, old_thread, new_thread; CBTACTIVATESTRUCT cbt; if (previous == hwnd) @@ -87,16 +87,24 @@ static BOOL set_active_window( HWND hwnd, HWND *prev, BOOL mouse, BOOL focus ) return TRUE; } - /* call CBT hook chain */ - cbt.fMouse = mouse; - cbt.hWndActive = previous; - if (HOOK_CallHooks( WH_CBT, HCBT_ACTIVATE, (WPARAM)hwnd, (LPARAM)&cbt, TRUE )) return FALSE; - - if (IsWindow(previous)) + /* Prevent a recursive activation loop with the app's activation messages */ + winflags = win_set_flags(hwnd, WIN_IS_IN_ACTIVATION, 0); + if (!(winflags & WIN_IS_IN_ACTIVATION)) { - SendMessageW( previous, WM_NCACTIVATE, FALSE, (LPARAM)hwnd ); - SendMessageW( previous, WM_ACTIVATE, - MAKEWPARAM( WA_INACTIVE, IsIconic(previous) ), (LPARAM)hwnd ); + ret = FALSE; + + /* call CBT hook chain */ + cbt.fMouse = mouse; + cbt.hWndActive = previous; + if (HOOK_CallHooks( WH_CBT, HCBT_ACTIVATE, (WPARAM)hwnd, (LPARAM)&cbt, TRUE )) + goto clear_flags; + + if (IsWindow(previous)) + { + SendMessageW( previous, WM_NCACTIVATE, FALSE, (LPARAM)hwnd ); + SendMessageW( previous, WM_ACTIVATE, + MAKEWPARAM( WA_INACTIVE, IsIconic(previous) ), (LPARAM)hwnd ); + } } SERVER_START_REQ( set_active_window ) @@ -106,9 +114,9 @@ static BOOL set_active_window( HWND hwnd, HWND *prev, BOOL mouse, BOOL focus ) previous = wine_server_ptr_handle( reply->previous ); } SERVER_END_REQ; - if (!ret) return FALSE; + if (!ret) goto clear_flags; if (prev) *prev = previous; - if (previous == hwnd) return TRUE; + if (previous == hwnd) goto clear_flags; if (hwnd) { @@ -116,7 +124,11 @@ static BOOL set_active_window( HWND hwnd, HWND *prev, BOOL mouse, BOOL focus ) if (SendMessageW( hwnd, WM_QUERYNEWPALETTE, 0, 0 )) SendMessageTimeoutW( HWND_BROADCAST, WM_PALETTEISCHANGING, (WPARAM)hwnd, 0, SMTO_ABORTIFHUNG, 2000, NULL ); - if (!IsWindow(hwnd)) return FALSE; + if (!IsWindow(hwnd)) + { + ret = FALSE; + goto clear_flags; + } } old_thread = previous ? GetWindowThreadProcessId( previous, NULL ) : 0; @@ -148,7 +160,7 @@ static BOOL set_active_window( HWND hwnd, HWND *prev, BOOL mouse, BOOL focus ) } } - if (IsWindow(hwnd)) + if (!(winflags & WIN_IS_IN_ACTIVATION) && IsWindow(hwnd)) { SendMessageW( hwnd, WM_NCACTIVATE, (hwnd == GetForegroundWindow()), (LPARAM)previous ); SendMessageW( hwnd, WM_ACTIVATE, @@ -173,7 +185,9 @@ static BOOL set_active_window( HWND hwnd, HWND *prev, BOOL mouse, BOOL focus ) } } - return TRUE; +clear_flags: + win_set_flags(hwnd, 0, WIN_IS_IN_ACTIVATION); + return ret; } diff --git a/dlls/user32/win.h b/dlls/user32/win.h index f3bdfd3..fa5d1b6 100644 --- a/dlls/user32/win.h +++ b/dlls/user32/win.h @@ -80,6 +80,7 @@ typedef struct tagWND #define WIN_NEEDS_SHOW_OWNEDPOPUP 0x0020 /* WM_SHOWWINDOW:SC_SHOW must be sent in the next ShowOwnedPopup call */ #define WIN_CHILDREN_MOVED 0x0040 /* children may have moved, ignore stored positions */ #define WIN_HAS_IME_WIN 0x0080 /* the window has been registered with imm32 */ +#define WIN_IS_IN_ACTIVATION 0x0100 /* the window is in an activation process */ /* Window functions */ extern HWND get_hwnd_message_parent(void) DECLSPEC_HIDDEN; -- 2.19.1

2 10

[PATCH] po: Update Japanese translation.
by Akihiro Sagawa 17 Dec '18

17 Dec '18

Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- po/ja.po | 444 +++++++++++++++++++++++++++++---------------------------------- 1 file changed, 207 insertions(+), 237 deletions(-)

1 0

[PATCH] winhttp: Fix handling of WINHTTP_OPTION_SECURITY_FLAGS.
by Hans Leidekker 17 Dec '18

17 Dec '18

Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> --- dlls/winhttp/session.c | 15 +++++++-------- dlls/winhttp/tests/winhttp.c | 29 ++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 9 deletions(-) diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c index 39e8d8233f..82615ad12f 100644 --- a/dlls/winhttp/session.c +++ b/dlls/winhttp/session.c @@ -695,7 +695,7 @@ static BOOL request_query_option( struct object_header *hdr, DWORD option, void { case WINHTTP_OPTION_SECURITY_FLAGS: { - DWORD flags = 0; + DWORD flags; int bits; if (!buffer || *buflen < sizeof(flags)) @@ -705,9 +705,7 @@ static BOOL request_query_option( struct object_header *hdr, DWORD option, void return FALSE; } - flags = 0; - if (hdr->flags & WINHTTP_FLAG_SECURE) flags |= SECURITY_FLAG_SECURE; - flags |= request->security_flags; + flags = request->security_flags; if (request->netconn) { bits = netconn_get_cipher_strength( request->netconn ); @@ -929,6 +927,10 @@ static BOOL request_set_option( struct object_header *hdr, DWORD option, void *b case WINHTTP_OPTION_SECURITY_FLAGS: { DWORD flags; + static const DWORD accepted = SECURITY_FLAG_IGNORE_CERT_CN_INVALID | + SECURITY_FLAG_IGNORE_CERT_DATE_INVALID | + SECURITY_FLAG_IGNORE_UNKNOWN_CA | + SECURITY_FLAG_IGNORE_CERT_WRONG_USAGE; if (buflen < sizeof(DWORD)) { @@ -937,10 +939,7 @@ static BOOL request_set_option( struct object_header *hdr, DWORD option, void *b } flags = *(DWORD *)buffer; TRACE("0x%x\n", flags); - if (!(flags & (SECURITY_FLAG_IGNORE_CERT_CN_INVALID | - SECURITY_FLAG_IGNORE_CERT_DATE_INVALID | - SECURITY_FLAG_IGNORE_UNKNOWN_CA | - SECURITY_FLAG_IGNORE_CERT_WRONG_USAGE))) + if (flags && (flags & ~accepted)) { SetLastError( ERROR_INVALID_PARAMETER ); return FALSE; diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 3f9125154f..91a9d539aa 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -1033,7 +1033,7 @@ static void test_secure_connection(void) { static const char data_start[] = "<!DOCTYPE html PUBLIC"; HINTERNET ses, con, req; - DWORD size, status, policy, bitness, read_size, err, available_size, protocols; + DWORD size, status, policy, bitness, read_size, err, available_size, protocols, flags; BOOL ret; CERT_CONTEXT *cert; WINHTTP_CERTIFICATE_INFO info; @@ -1087,6 +1087,33 @@ static void test_secure_connection(void) req = WinHttpOpenRequest(con, NULL, NULL, NULL, NULL, NULL, WINHTTP_FLAG_SECURE); ok(req != NULL, "failed to open a request %u\n", GetLastError()); + flags = 0xdeadbeef; + size = sizeof(flags); + ret = WinHttpQueryOption(req, WINHTTP_OPTION_SECURITY_FLAGS, &flags, &size); + ok(ret, "failed to query security flags %u\n", GetLastError()); + ok(!flags, "got %08x\n", flags); + + flags = SECURITY_FLAG_IGNORE_CERT_WRONG_USAGE; + ret = WinHttpSetOption(req, WINHTTP_OPTION_SECURITY_FLAGS, &flags, sizeof(flags)); + ok(ret, "failed to set security flags %u\n", GetLastError()); + + flags = SECURITY_FLAG_SECURE; + ret = WinHttpSetOption(req, WINHTTP_OPTION_SECURITY_FLAGS, &flags, sizeof(flags)); + ok(!ret, "success\n"); + + flags = SECURITY_FLAG_STRENGTH_STRONG; + ret = WinHttpSetOption(req, WINHTTP_OPTION_SECURITY_FLAGS, &flags, sizeof(flags)); + ok(!ret, "success\n"); + + flags = SECURITY_FLAG_IGNORE_UNKNOWN_CA | SECURITY_FLAG_IGNORE_CERT_DATE_INVALID | + SECURITY_FLAG_IGNORE_CERT_CN_INVALID; + ret = WinHttpSetOption(req, WINHTTP_OPTION_SECURITY_FLAGS, &flags, sizeof(flags)); + ok(ret, "failed to set security flags %u\n", GetLastError()); + + flags = 0; + ret = WinHttpSetOption(req, WINHTTP_OPTION_SECURITY_FLAGS, &flags, sizeof(flags)); + ok(ret, "failed to set security flags %u\n", GetLastError()); + ret = WinHttpSetOption(req, WINHTTP_OPTION_CLIENT_CERT_CONTEXT, WINHTTP_NO_CLIENT_CERT_CONTEXT, 0); err = GetLastError(); ok(ret || broken(!ret && err == ERROR_INVALID_PARAMETER) /* winxp */, "failed to set client cert context %u\n", err); -- 2.11.0

1 0

[PATCH] bcrypt: Clear magic bytes on destroy.
by Hans Leidekker 17 Dec '18

17 Dec '18

Based on a patch by Steven Noonan. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> --- dlls/bcrypt/bcrypt_main.c | 5 ++++- dlls/bcrypt/tests/bcrypt.c | 15 +++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/dlls/bcrypt/bcrypt_main.c b/dlls/bcrypt/bcrypt_main.c index c448f63a4d..d3f9f773f9 100644 --- a/dlls/bcrypt/bcrypt_main.c +++ b/dlls/bcrypt/bcrypt_main.c @@ -275,6 +275,7 @@ NTSTATUS WINAPI BCryptCloseAlgorithmProvider( BCRYPT_ALG_HANDLE handle, DWORD fl TRACE( "%p, %08x\n", handle, flags ); if (!alg || alg->hdr.magic != MAGIC_ALG) return STATUS_INVALID_HANDLE; + alg->hdr.magic = 0; heap_free( alg ); return STATUS_SUCCESS; } @@ -733,7 +734,8 @@ NTSTATUS WINAPI BCryptDestroyHash( BCRYPT_HASH_HANDLE handle ) TRACE( "%p\n", handle ); - if (!hash || hash->hdr.magic != MAGIC_HASH) return STATUS_INVALID_HANDLE; + if (!hash || hash->hdr.magic != MAGIC_HASH) return STATUS_INVALID_PARAMETER; + hash->hdr.magic = 0; heap_free( hash ); return STATUS_SUCCESS; } @@ -1326,6 +1328,7 @@ NTSTATUS WINAPI BCryptDestroyKey( BCRYPT_KEY_HANDLE handle ) TRACE( "%p\n", handle ); if (!key || key->hdr.magic != MAGIC_KEY) return STATUS_INVALID_HANDLE; + key->hdr.magic = 0; return key_destroy( key ); } diff --git a/dlls/bcrypt/tests/bcrypt.c b/dlls/bcrypt/tests/bcrypt.c index c3f8f3d78a..5240c3bafb 100644 --- a/dlls/bcrypt/tests/bcrypt.c +++ b/dlls/bcrypt/tests/bcrypt.c @@ -293,6 +293,12 @@ static void test_hash(const struct hash_test *test) ret = pBCryptDestroyHash(hash); ok(ret == STATUS_SUCCESS, "got %08x\n", ret); + ret = pBCryptDestroyHash(hash); + ok(ret == STATUS_INVALID_PARAMETER, "got %08x\n", ret); + + ret = pBCryptDestroyHash(NULL); + ok(ret == STATUS_INVALID_PARAMETER, "got %08x\n", ret); + ret = pBCryptCloseAlgorithmProvider(alg, 0); ok(ret == STATUS_SUCCESS, "got %08x\n", ret); } @@ -1415,8 +1421,17 @@ static void test_BCryptDecrypt(void) ok(ret == STATUS_INVALID_HANDLE, "got %08x\n", ret); HeapFree(GetProcessHeap(), 0, buf); + ret = pBCryptDestroyKey(NULL); + ok(ret == STATUS_INVALID_HANDLE, "got %08x\n", ret); + ret = pBCryptCloseAlgorithmProvider(aes, 0); ok(ret == STATUS_SUCCESS, "got %08x\n", ret); + + ret = pBCryptCloseAlgorithmProvider(aes, 0); + ok(ret == STATUS_INVALID_HANDLE, "got %08x\n", ret); + + ret = pBCryptCloseAlgorithmProvider(NULL, 0); + ok(ret == STATUS_INVALID_HANDLE, "got %08x\n", ret); } static void test_key_import_export(void) -- 2.11.0

1 0

[PATCH] include/sal.h: Add compatibility macros for Visual Studio 10.0.
by Dmitry Timoshkov 17 Dec '18

17 Dec '18

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- include/sal.h | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/include/sal.h b/include/sal.h index 29746c3a03..35f64934f6 100644 --- a/include/sal.h +++ b/include/sal.h @@ -25,12 +25,15 @@ #define _At_buffer_(a, b, c, d) #define _Check_return_ +#define _Check_return_opt_ #define _Deref_out_ +#define _Deref_out_z_ #define _Deref_out_opt_ #define _Deref_out_opt_z_ #define _Deref_post_opt_cap_(count) #define _Deref_post_opt_valid_ +#define _Deref_post_opt_z_cap_(count) #define _Deref_post_valid_ #define _Deref_post_z_ #define _Deref_prepost_opt_z_ @@ -40,10 +43,25 @@ #define _In_ #define _In_bytecount_(count) +#define _In_bytecount_c_(count) +#define _In_bytecount_x_(count) #define _In_count_(count) +#define _In_count_c_(count) +#define _In_count_x_(count) #define _In_opt_ +#define _In_opt_bytecount_(count) +#define _In_opt_bytecount_c_(count) +#define _In_opt_bytecount_x_(count) #define _In_opt_count_(count) +#define _In_opt_count_c_(count) +#define _In_opt_count_x_(count) +#define _In_opt_ptrdiff_count_(count) #define _In_opt_z_ +#define _In_opt_z_count_(count) +#define _In_opt_z_count_c_(count) +#define _In_opt_z_bytecount_(count) +#define _In_opt_z_bytecount_c_(count) +#define _In_ptrdiff_count_(count) #define _In_range_(min, max) #define _In_reads_(count) #define _In_reads_bytes_(count) @@ -53,11 +71,18 @@ #define _In_reads_or_z_opt_(count) #define _In_reads_z_(count) #define _In_z_ +#define _In_z_bytecount_(count) +#define _In_z_bytecount_c_(count) +#define _In_z_count_(count) +#define _In_z_count_c_(count) #define _Inout_ +#define _Inout_bytecap_x_(count) #define _Inout_cap_(count) #define _Inout_opt_ +#define _Inout_opt_cap_c_(count) #define _Inout_opt_z_ +#define _Inout_opt_z_bytecap_(count) #define _Inout_updates_(count) #define _Inout_updates_bytes_(count) #define _Inout_updates_opt_(count) @@ -72,13 +97,37 @@ #define _Out_ #define _Out_bytecap_(count) +#define _Out_bytecap_c_(count) +#define _Out_bytecap_x_(count) #define _Out_bytecapcount_(count) #define _Out_bytecap_post_bytecount_(count1, count2) #define _Out_cap_(count) +#define _Out_cap_c_(count) +#define _Out_cap_m_(count1, count2) +#define _Out_cap_x_(count) #define _Out_cap_post_count_(count1, count2) #define _Out_opt_ +#define _Out_opt_bytecap_(count) +#define _Out_opt_bytecap_c_(count) +#define _Out_opt_bytecap_x_(count) +#define _Out_opt_bytecap_post_bytecount_(count1, count2) +#define _Out_opt_bytecapcount_(count) +#define _Out_opt_cap_(count) +#define _Out_opt_cap_m_(count1, count2) +#define _Out_opt_cap_c_(count) +#define _Out_opt_cap_x_(count) +#define _Out_opt_cap_post_count_(count1, count2) +#define _Out_opt_ptrdiff_cap_(count) +#define _Out_opt_z_bytecap_(count) +#define _Out_opt_z_bytecap_c_(count) +#define _Out_opt_z_bytecap_x_(count) +#define _Out_opt_z_bytecap_post_bytecount_(count1, count2) #define _Out_opt_z_cap_(count) +#define _Out_opt_z_cap_c_(count) +#define _Out_opt_z_cap_m_(count1, count2) +#define _Out_opt_z_cap_x_(count) #define _Out_opt_z_cap_post_count_(count1, count2) +#define _Out_ptrdiff_cap_(count) #define _Out_writes_(count) #define _Out_writes_bytes_(count) #define _Out_writes_bytes_all_(count) @@ -91,8 +140,14 @@ #define _Out_writes_to_(count1, count2) #define _Out_writes_to_opt_(count1, count2) #define _Out_writes_z_(count) +#define _Out_z_bytecap_(count) +#define _Out_z_bytecap_c_(count) +#define _Out_z_bytecap_x_(count) +#define _Out_z_bytecap_post_bytecount_(count1, count2) #define _Out_z_cap_(count) #define _Out_z_cap_c_(count) +#define _Out_z_cap_m_(count1, count2) +#define _Out_z_cap_x_(count) #define _Out_z_cap_post_count_(count1, count2) #define _Outptr_result_buffer_(count) @@ -103,19 +158,24 @@ #define _Param_(p) +#define _Post_count_(count) +#define _Post_count_c_(count) #define _Post_equal_to_(exp) #define _Post_invalid_ #define _Post_maybez_ +#define _Post_ptr_invalid_ #define _Post_readable_size_(count) #define _Post_satisfies_(exp) #define _Post_writable_byte_size_(count) #define _Post_z_ +#define _Pre_cap_for_(count) #define _Pre_maybenull_ #define _Pre_notnull_ #define _Pre_opt_z_ #define _Pre_writable_size_(count) #define _Pre_z_ +#define _Prepost_z_ #define _Printf_format_string_ #define _Printf_format_string_params_(count) @@ -124,6 +184,8 @@ #define _Ret_maybenull_z_ #define _Ret_notnull_ #define _Ret_opt_ +#define _Ret_opt_bytecap_(count) +#define _Ret_opt_bytecap_x_(count) #define _Ret_opt_z_cap_(count) #define _Ret_writes_bytes_maybenull_(count) #define _Ret_z_ -- 2.19.2

1 0

[PATCH] include: Correct IBrowserService.IEGetDisplayName definition
by Alistair Leslie-Hughes 16 Dec '18

16 Dec '18

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- include/shdeprecated.idl | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/shdeprecated.idl b/include/shdeprecated.idl index 3e1e5e7..9f22e54 100644 --- a/include/shdeprecated.idl +++ b/include/shdeprecated.idl @@ -34,6 +34,12 @@ cpp_quote("#define TLMENUF_BACK 0x00000010") cpp_quote("#define TLMENUF_FORE 0x00000020") cpp_quote("#define TLMENUF_BACKANDFORTH (TLMENUF_BACK | TLMENUF_FORE | TLMENUF_INCLUDECURRENT)") +cpp_quote("#ifndef INTERNET_MAX_URL_LENGTH") +cpp_quote("#define INTERNET_MAX_PATH_LENGTH 2048") +cpp_quote("#define INTERNET_MAX_SCHEME_LENGTH 32") +cpp_quote("#define INTERNET_MAX_URL_LENGTH (INTERNET_MAX_SCHEME_LENGTH + sizeof(\"://\") + INTERNET_MAX_PATH_LENGTH)") +cpp_quote("#endif") + [ hidden, local, @@ -214,7 +220,7 @@ interface IBrowserService : IUnknown HRESULT IEGetDisplayName( [in] PCIDLIST_ABSOLUTE pidl, - [out] LPWSTR pwszName, + [out, size_is(INTERNET_MAX_URL_LENGTH)] LPWSTR pwszName, [in] UINT uFlags); HRESULT IEParseDisplayName( -- 1.9.1

1 0

[PATCH] include: Add GetFilePatchSignature definition
by Alistair Leslie-Hughes 16 Dec '18

16 Dec '18

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- include/patchapi.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/patchapi.h b/include/patchapi.h index 9a62a0f..5adaf0a 100644 --- a/include/patchapi.h +++ b/include/patchapi.h @@ -45,6 +45,12 @@ BOOL WINAPI ApplyPatchToFileA(LPCSTR,LPCSTR,LPCSTR,ULONG); BOOL WINAPI ApplyPatchToFileW(LPCWSTR,LPCWSTR,LPCWSTR,ULONG); #define ApplyPatchToFile WINELIB_NAME_AW(ApplyPatchToFile) +BOOL WINAPI GetFilePatchSignatureA(LPCSTR, ULONG, PVOID, ULONG, PPATCH_IGNORE_RANGE, ULONG, + PPATCH_RETAIN_RANGE, ULONG, LPSTR); +BOOL WINAPI GetFilePatchSignatureW(LPCWSTR, ULONG, PVOID, ULONG, PPATCH_IGNORE_RANGE, ULONG, + PPATCH_RETAIN_RANGE, ULONG, LPWSTR); +#define GetFilePatchSignature WINELIB_NAME_AW(GetFilePatchSignature) + #ifdef __cplusplus } #endif -- 1.9.1

1 0

[PATCH] winetest: Add GUI to display results of individual tests
by Isira Seneviratne 16 Dec '18

16 Dec '18

1 0

[PATCH] winegcc: Don't add the prefix's include dir using -isystem.
by Andre Heider 16 Dec '18

16 Dec '18

Always use -I, this fixes the include search path if the prefix is set to '/usr'. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46293 Signed-off-by: Andre Heider <a.heider(a)gmail.com> --- tools/winegcc/winegcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index 87fd661b3f..3424354a6e 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -697,7 +697,7 @@ no_compat_defines: strarray_add(comp_args, gcc_defs ? "-isystem" INCLUDEDIR "/wine/msvcrt" : "-I" INCLUDEDIR "/wine/msvcrt" ); strarray_add(comp_args, "-D__MSVCRT__"); } - strarray_add(comp_args, gcc_defs ? "-isystem" INCLUDEDIR : "-I" INCLUDEDIR ); + strarray_add(comp_args, "-I" INCLUDEDIR ); strarray_add(comp_args, gcc_defs ? "-isystem" INCLUDEDIR "/wine/windows" : "-I" INCLUDEDIR "/wine/windows" ); } else if (opts->wine_objdir) -- 2.20.0

1 0

[PATCH] winetest: Add GUI to display results of individual tests
by Isira Seneviratne 15 Dec '18

15 Dec '18

2 1

[PATCH 1/2] api-ms-win-crt-private-l1-1-0: Update to 10.0.17134.12 (WinBuild.160101.0800)
by Fabian Maurer 14 Dec '18

14 Dec '18

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> --- .../api-ms-win-crt-private-l1-1-0.spec | 31 ++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/dlls/api-ms-win-crt-private-l1-1-0/api-ms-win-crt-private-l1-1-0.spec b/dlls/api-ms-win-crt-private-l1-1-0/api-ms-win-crt-private-l1-1-0.spec index 60a9258cd1..9bddd3d98b 100644 --- a/dlls/api-ms-win-crt-private-l1-1-0/api-ms-win-crt-private-l1-1-0.spec +++ b/dlls/api-ms-win-crt-private-l1-1-0/api-ms-win-crt-private-l1-1-0.spec @@ -15,6 +15,7 @@ @ stub __BuildCatchObject @ stub __BuildCatchObjectHelper @ stdcall -arch=x86_64 __C_specific_handler(ptr long ptr ptr) ucrtbase.__C_specific_handler +@ stub __C_specific_handler_noexcept @ cdecl -arch=i386,x86_64,arm,arm64 __CxxDetectRethrow(ptr) ucrtbase.__CxxDetectRethrow @ cdecl -arch=i386,x86_64,arm,arm64 __CxxExceptionFilter(ptr ptr long ptr) ucrtbase.__CxxExceptionFilter @ cdecl -arch=i386,x86_64,arm,arm64 -norelay __CxxFrameHandler(ptr ptr ptr ptr) ucrtbase.__CxxFrameHandler @@ -44,6 +45,7 @@ @ stub __report_gsfailure @ cdecl __std_exception_copy(ptr ptr) ucrtbase.__std_exception_copy @ cdecl __std_exception_destroy(ptr) ucrtbase.__std_exception_destroy +@ stub __std_terminate @ cdecl __std_type_info_compare(ptr ptr) ucrtbase.__std_type_info_compare @ cdecl __std_type_info_destroy_list(ptr) ucrtbase.__std_type_info_destroy_list @ cdecl __std_type_info_hash(ptr) ucrtbase.__std_type_info_hash @@ -51,6 +53,7 @@ @ cdecl __unDName(ptr str long ptr ptr long) ucrtbase.__unDName @ cdecl __unDNameEx(ptr str long ptr ptr ptr long) ucrtbase.__unDNameEx @ cdecl __uncaught_exception() ucrtbase.__uncaught_exception +@ stub __uncaught_exceptions @ cdecl -arch=i386 -norelay _chkesp() ucrtbase._chkesp @ cdecl -arch=i386 _except_handler2(ptr ptr ptr ptr) ucrtbase._except_handler2 @ cdecl -arch=i386 _except_handler3(ptr ptr ptr ptr) ucrtbase._except_handler3 @@ -87,6 +90,10 @@ @ stub _o__W_Getmonths @ stub _o__W_Gettnames @ stub _o__Wcsftime +@ stub _o____lc_codepage_func +@ stub _o____lc_collate_cp_func +@ stub _o____lc_locale_name_func +@ stub _o____mb_cur_max_func @ stub _o___acrt_iob_func @ stub _o___conio_common_vcprintf @ stub _o___conio_common_vcprintf_p @@ -135,6 +142,10 @@ @ stub _o___p__wpgmptr @ stub _o___pctype_func @ stub _o___pwctype_func +@ stub _o___std_exception_copy +@ stub _o___std_exception_destroy +@ stub _o___std_type_info_destroy_list +@ stub _o___std_type_info_name @ stub _o___stdio_common_vfprintf @ stub _o___stdio_common_vfprintf_p @ stub _o___stdio_common_vfprintf_s @@ -184,6 +195,7 @@ @ stub _o__cabs @ stub _o__callnewh @ stub _o__calloc_base +@ stub _o__cexit @ stub _o__cgets @ stub _o__cgets_s @ stub _o__cgetws @@ -195,11 +207,15 @@ @ stub _o__chsize_s @ stub _o__close @ stub _o__commit +@ stub _o__configthreadlocale +@ stub _o__configure_narrow_argv @ stub _o__configure_wide_argv +@ stub _o__controlfp_s @ stub _o__cputs @ stub _o__cputws @ stub _o__creat @ stub _o__create_locale +@ stub _o__crt_atexit @ stub _o__ctime32_s @ stub _o__ctime64_s @ stub _o__cwait @@ -231,6 +247,7 @@ @ stub _o__execve @ stub _o__execvp @ stub _o__execvpe +@ stub _o__exit @ stub _o__expand @ stub _o__fclose_nolock @ stub _o__fcloseall @@ -301,6 +318,8 @@ @ stub _o__get_errno @ stub _o__get_fmode @ stub _o__get_heap_handle +@ stub _o__get_initial_narrow_environment +@ stub _o__get_initial_wide_environment @ stub _o__get_invalid_parameter_handler @ stub _o__get_narrow_winmain_command_line @ stub _o__get_osfhandle @@ -345,7 +364,9 @@ @ stub _o__i64toa_s @ stub _o__i64tow @ stub _o__i64tow_s +@ stub _o__initialize_narrow_environment @ cdecl _o__initialize_onexit_table(ptr) ucrtbase._o__initialize_onexit_table +@ stub _o__initialize_wide_environment @ stub _o__invalid_parameter_noinfo @ stub _o__invalid_parameter_noinfo_noreturn @ stub _o__isatty @@ -617,6 +638,7 @@ @ stub _o__pclose @ stub _o__pipe @ stub _o__popen +@ stub _o__purecall @ stub _o__putc_nolock @ stub _o__putch @ stub _o__putch_nolock @@ -638,9 +660,13 @@ @ stub _o__scalbf @ stub _o__searchenv @ stub _o__searchenv_s +@ stub _o__seh_filter_dll +@ stub _o__seh_filter_exe @ stub _o__set_abort_behavior +@ stub _o__set_app_type @ stub _o__set_doserrno @ stub _o__set_errno +@ stub _o__set_fmode @ stub _o__set_invalid_parameter_handler @ stub _o__set_new_handler @ stub _o__set_new_mode @@ -910,6 +936,7 @@ @ stub _o_erfcl @ stub _o_erff @ stub _o_erfl +@ stub _o_exit @ stub _o_exp @ stub _o_exp2 @ stub _o_exp2f @@ -1026,7 +1053,7 @@ @ stub _o_mbstowcs @ stub _o_mbstowcs_s @ stub _o_mbtowc -@ stub _o_memset +@ stub _o_memcpy_s @ stub _o_modf @ stub _o_modff @ stub _o_nan @@ -1061,6 +1088,7 @@ @ stub _o_remquo @ stub _o_remquof @ stub _o_remquol +@ stub _o_rename @ stub _o_rewind @ stub _o_rint @ stub _o_rintf @@ -1076,6 +1104,7 @@ @ stub _o_scalbnl @ stub _o_set_terminate @ stub _o_setbuf +@ stub _o_setlocale @ stub _o_setvbuf @ stub _o_sin @ stub _o_sinf -- 2.19.2

2 3

[PATCH] po: Update Lithuanian translation
by Aurimas Fišeras 14 Dec '18

14 Dec '18

1 0

[PATCH] advapi32: Implement RegLoadMUIString cache.
by Akihiro Sagawa 14 Dec '18

14 Dec '18

This fixes a performance regression introduced by 67574e4440ac4d9786e52a669b40197d2a4cb505. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46266 Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/advapi32/registry.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)

2 1

[PATCH 2/2] comctl32/tests: Add a test to check built-in comctl32 classes.
by Dmitry Timoshkov 14 Dec '18

14 Dec '18

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/comctl32/tests/misc.c | 58 +++++++++++++++++++++++++++++--------- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/dlls/comctl32/tests/misc.c b/dlls/comctl32/tests/misc.c index 5e91a8066a..c027852047 100644 --- a/dlls/comctl32/tests/misc.c +++ b/dlls/comctl32/tests/misc.c @@ -338,7 +338,7 @@ static void test_LoadIconWithScaleDown(void) FreeLibrary(hinst); } -static void check_class( const char *name, int must_exist, UINT style, UINT ignore ) +static void check_class( const char *name, int must_exist, UINT style, UINT ignore, BOOL v6 ) { WNDCLASSA wc; @@ -347,14 +347,14 @@ static void check_class( const char *name, int must_exist, UINT style, UINT igno char buff[64]; HWND hwnd; -todo_wine_if(strcmp(name, "Button") && - strcmp(name, "ComboBox") && - strcmp(name, "Edit") && - strcmp(name, "Static") && - strcmp(name, "ListBox") && - strcmp(name, "ComboLBox")) +todo_wine_if(!strcmp(name, "SysLink") && !must_exist && !v6) + ok( must_exist, "System class %s should %sexist\n", name, must_exist ? "" : "NOT " ); + if (!must_exist) return; + +todo_wine_if(!strcmp(name, "ScrollBar") || (!strcmp(name, "tooltips_class32") && v6)) ok( !(~wc.style & style & ~ignore), "System class %s is missing bits %x (%08x/%08x)\n", name, ~wc.style & style, wc.style, style ); +todo_wine_if((!strcmp(name, "tooltips_class32") && v6) || !strcmp(name, "SysLink")) ok( !(wc.style & ~style), "System class %s has extra bits %x (%08x/%08x)\n", name, wc.style & ~style, wc.style, style ); ok( !wc.hInstance, "System class %s has hInstance %p\n", name, wc.hInstance ); @@ -373,13 +373,40 @@ todo_wine_if(strcmp(name, "Button") && static void test_builtin_classes(void) { /* check style bits */ - check_class( "Button", 1, CS_PARENTDC | CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0 ); - check_class( "ComboBox", 1, CS_PARENTDC | CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0 ); - check_class( "Edit", 1, CS_PARENTDC | CS_DBLCLKS | CS_GLOBALCLASS, 0 ); - check_class( "ListBox", 1, CS_PARENTDC | CS_DBLCLKS | CS_GLOBALCLASS, 0 ); - check_class( "ScrollBar", 1, CS_PARENTDC | CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0 ); - check_class( "Static", 1, CS_PARENTDC | CS_DBLCLKS | CS_GLOBALCLASS, 0 ); - check_class( "ComboLBox", 1, CS_SAVEBITS | CS_DBLCLKS | CS_DROPSHADOW | CS_GLOBALCLASS, CS_DROPSHADOW ); + check_class( "Button", 1, CS_PARENTDC | CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0, FALSE ); + check_class( "ComboBox", 1, CS_PARENTDC | CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0, FALSE ); + check_class( "Edit", 1, CS_PARENTDC | CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE ); + check_class( "ListBox", 1, CS_PARENTDC | CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE ); + check_class( "ScrollBar", 1, CS_PARENTDC | CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0, FALSE ); + check_class( "Static", 1, CS_PARENTDC | CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE ); + check_class( "ComboLBox", 1, CS_SAVEBITS | CS_DBLCLKS | CS_DROPSHADOW | CS_GLOBALCLASS, CS_DROPSHADOW, FALSE ); +} + +static void test_comctl32_classes(BOOL v6) +{ + check_class(ANIMATE_CLASSA, 1, CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE); + check_class(WC_COMBOBOXEXA, 1, CS_GLOBALCLASS, 0, FALSE); + check_class(DATETIMEPICK_CLASSA, 1, CS_GLOBALCLASS, 0, FALSE); + check_class(WC_HEADERA, 1, CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE); + check_class(HOTKEY_CLASSA, 1, CS_GLOBALCLASS, 0, FALSE); + check_class(WC_IPADDRESSA, 1, CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0, FALSE); + check_class(WC_LISTVIEWA, 1, CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE); + check_class(MONTHCAL_CLASSA, 1, CS_GLOBALCLASS, 0, FALSE); + check_class(WC_NATIVEFONTCTLA, 1, CS_GLOBALCLASS, 0, FALSE); + check_class(WC_PAGESCROLLERA, 1, CS_GLOBALCLASS, 0, FALSE); + check_class(PROGRESS_CLASSA, 1, CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0, FALSE); + check_class(REBARCLASSNAMEA, 1, CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE); + check_class(STATUSCLASSNAMEA, 1, CS_DBLCLKS | CS_VREDRAW | CS_GLOBALCLASS, 0, FALSE); + check_class(WC_TABCONTROLA, 1, CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0, FALSE); + check_class(TOOLBARCLASSNAMEA, 1, CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE); + if (v6) + check_class(TOOLTIPS_CLASSA, 1, CS_DBLCLKS | CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS | CS_DROPSHADOW, CS_SAVEBITS | CS_HREDRAW | CS_VREDRAW /* XP */, TRUE); + else + check_class(TOOLTIPS_CLASSA, 1, CS_DBLCLKS | CS_GLOBALCLASS | CS_SAVEBITS, CS_HREDRAW | CS_VREDRAW /* XP */, FALSE); + check_class(TRACKBAR_CLASSA, 1, CS_GLOBALCLASS, 0, FALSE); + check_class(WC_TREEVIEWA, 1, CS_DBLCLKS | CS_GLOBALCLASS, 0, FALSE); + check_class(UPDOWN_CLASSA, 1, CS_HREDRAW | CS_VREDRAW | CS_GLOBALCLASS, 0, FALSE); + check_class("SysLink", v6, CS_GLOBALCLASS, 0, FALSE); } START_TEST(misc) @@ -393,9 +420,12 @@ START_TEST(misc) test_GetPtrAW(); test_Alloc(); + test_comctl32_classes(FALSE); + if (!load_v6_module(&ctx_cookie, &hCtx)) return; + test_comctl32_classes(TRUE); test_builtin_classes(); test_LoadIconWithScaleDown(); -- 2.19.2

1 0

[PATCH 1/2] comctl32/tests: Fix a test failure under Windows 7.
by Dmitry Timoshkov 14 Dec '18

14 Dec '18

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/comctl32/tests/misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/comctl32/tests/misc.c b/dlls/comctl32/tests/misc.c index 85f339b1ff..5e91a8066a 100644 --- a/dlls/comctl32/tests/misc.c +++ b/dlls/comctl32/tests/misc.c @@ -265,8 +265,7 @@ static void test_LoadIconWithScaleDown(void) /* non-existing filename */ hr = pLoadIconMetric(NULL, nonexisting_fileW, LIM_LARGE, &icon); - todo_wine - ok(hr == HRESULT_FROM_WIN32(ERROR_RESOURCE_TYPE_NOT_FOUND), + ok(hr == HRESULT_FROM_WIN32(ERROR_RESOURCE_TYPE_NOT_FOUND) || hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) /* Win7 */, "Expected HRESULT_FROM_WIN32(ERROR_RESOURCE_TYPE_NOT_FOUND), got %x\n", hr); hr = pLoadIconWithScaleDown(NULL, nonexisting_fileW, 32, 32, &icon); -- 2.19.2

1 0

[PATCH v4] msvcr120: Add nexttoward implementation.
by Zebediah Figura 14 Dec '18

14 Dec '18

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45631 Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- configure.ac | 2 + .../api-ms-win-crt-math-l1-1-0.spec | 6 +- dlls/msvcr120/msvcr120.spec | 6 +- dlls/msvcr120/tests/msvcr120.c | 89 +++++++++++++++++++ dlls/msvcr120_app/msvcr120_app.spec | 6 +- dlls/msvcrt/math.c | 30 +++++++ dlls/ucrtbase/ucrtbase.spec | 6 +- 7 files changed, 133 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index 1db7af9177..907fac2f71 100644 --- a/configure.ac +++ b/configure.ac @@ -2746,6 +2746,8 @@ AC_CHECK_FUNCS(\ lroundf \ nearbyint \ nearbyintf \ + nexttoward \ + nexttowardf \ powl \ remainder \ remainderf \ diff --git a/dlls/api-ms-win-crt-math-l1-1-0/api-ms-win-crt-math-l1-1-0.spec b/dlls/api-ms-win-crt-math-l1-1-0/api-ms-win-crt-math-l1-1-0.spec index 0d645e5587..f5e4fb1f8f 100644 --- a/dlls/api-ms-win-crt-math-l1-1-0/api-ms-win-crt-math-l1-1-0.spec +++ b/dlls/api-ms-win-crt-math-l1-1-0/api-ms-win-crt-math-l1-1-0.spec @@ -297,9 +297,9 @@ @ cdecl nextafter(double double) ucrtbase.nextafter @ cdecl nextafterf(float float) ucrtbase.nextafterf @ cdecl nextafterl(double double) ucrtbase.nextafterl -@ stub nexttoward -@ stub nexttowardf -@ stub nexttowardl +@ cdecl nexttoward(double double) ucrtbase.nexttoward +@ cdecl nexttowardf(float double) ucrtbase.nexttowardf +@ cdecl nexttowardl(double double) ucrtbase.nexttowardl @ stub norm @ stub normf @ stub norml diff --git a/dlls/msvcr120/msvcr120.spec b/dlls/msvcr120/msvcr120.spec index c9547bcbdf..e2764dc46e 100644 --- a/dlls/msvcr120/msvcr120.spec +++ b/dlls/msvcr120/msvcr120.spec @@ -2302,9 +2302,9 @@ @ cdecl nextafter(double double) MSVCRT__nextafter @ cdecl nextafterf(float float) MSVCRT__nextafterf @ cdecl nextafterl(double double) MSVCRT__nextafter -@ stub nexttoward -@ stub nexttowardf -@ stub nexttowardl +@ cdecl nexttoward(double double) MSVCRT_nexttoward +@ cdecl nexttowardf(float double) MSVCRT_nexttowardf +@ cdecl nexttowardl(double double) MSVCRT_nexttoward @ stub norm @ stub normf @ stub norml diff --git a/dlls/msvcr120/tests/msvcr120.c b/dlls/msvcr120/tests/msvcr120.c index 79b667e42b..4115c99503 100644 --- a/dlls/msvcr120/tests/msvcr120.c +++ b/dlls/msvcr120/tests/msvcr120.c @@ -127,6 +127,16 @@ static inline float __port_nan(void) } #define NAN __port_nan() +static inline int isnormal(double d) +{ + return _fpclass(d) & (_FPCLASS_PN | _FPCLASS_NN); +} + +static inline int isinf(double d) +{ + return _fpclass(d) & (_FPCLASS_PINF | _FPCLASS_NINF); +} + struct MSVCRT_lconv { char* decimal_point; @@ -192,6 +202,9 @@ static unsigned short (__cdecl *p_wctype)(const char*); static int (__cdecl *p_vsscanf)(const char*, const char *, __ms_va_list valist); static _Dcomplex* (__cdecl *p__Cbuild)(_Dcomplex*, double, double); static double (__cdecl *p_creal)(_Dcomplex); +static double (__cdecl *p_nexttoward)(double, double); +static float (__cdecl *p_nexttowardf)(float, double); +static double (__cdecl *p_nexttowardl)(double, double); /* make sure we use the correct errno */ #undef errno @@ -252,6 +265,9 @@ static BOOL init(void) SET(p_vsscanf, "vsscanf"); SET(p__Cbuild, "_Cbuild"); SET(p_creal, "creal"); + SET(p_nexttoward, "nexttoward"); + SET(p_nexttowardf, "nexttowardf"); + SET(p_nexttowardl, "nexttowardl"); if(sizeof(void*) == 8) { /* 64-bit initialization */ SET(p_critical_section_ctor, "??0critical_section@Concurrency@@QEAA@XZ"); @@ -964,6 +980,78 @@ static void test__Cbuild(void) ok(d == 3.0, "creal returned %lf\n", d); } +static void test_nexttoward(void) +{ + errno_t e; + double d; + float f; + int i; + + struct + { + double source; + double dir; + float f; + double d; + } + tests[] = + { + {0.0, 0.0, 0.0f, 0.0}, + {0.0, 1.0, 1.0e-45f, 5.0e-324}, + {0.0, -1.0, -1.0e-45f, -5.0e-324}, + {2.2250738585072009e-308, 0.0, 0.0f, 2.2250738585072004e-308}, + {2.2250738585072009e-308, 2.2250738585072010e-308, 1.0e-45f, 2.2250738585072009e-308}, + {2.2250738585072009e-308, 1.0, 1.0e-45f, 2.2250738585072014e-308}, + {2.2250738585072014e-308, 0.0, 0.0f, 2.2250738585072009e-308}, + {2.2250738585072014e-308, 2.2250738585072014e-308, 1.0e-45f, 2.2250738585072014e-308}, + {2.2250738585072014e-308, 1.0, 1.0e-45f, 2.2250738585072019e-308}, + {1.0, 2.0, 1.00000012f, 1.0000000000000002}, + {1.0, 0.0, 0.99999994f, 0.9999999999999999}, + {1.0, 1.0, 1.0f, 1.0}, + {0.0, INFINITY, 1.0e-45f, 5.0e-324}, + {FLT_MAX, INFINITY, INFINITY, 3.402823466385289e+038}, + {DBL_MAX, INFINITY, INFINITY, INFINITY}, + {INFINITY, INFINITY, INFINITY, INFINITY}, + {INFINITY, 0, FLT_MAX, DBL_MAX}, + }; + + for (i = 0; i < ARRAY_SIZE(tests); ++i) + { + f = p_nexttowardf(tests[i].source, tests[i].dir); + ok(f == tests[i].f, "Test %d: expected %0.8ef, got %0.8ef.\n", i, tests[i].f, f); + + errno = -1; + d = p_nexttoward(tests[i].source, tests[i].dir); + e = errno; + ok(d == tests[i].d, "Test %d: expected %0.16e, got %0.16e.\n", i, tests[i].d, d); + if (isnormal(d) || isinf(tests[i].source)) + ok(e == -1, "Test %d: expected no error, got %d.\n", i, e); + else + ok(e == ERANGE, "Test %d: expected ERANGE, got %d.\n", i, e); + + d = p_nexttowardl(tests[i].source, tests[i].dir); + ok(d == tests[i].d, "Test %d: expected %0.16e, got %0.16e.\n", i, tests[i].d, d); + } + + errno = -1; + d = p_nexttoward(NAN, 0); + e = errno; + ok(_isnan(d), "Expected NAN, got %0.16e.\n", d); + ok(e == -1, "Expected errno -1, got %d.\n", e); + + errno = -1; + d = p_nexttoward(NAN, NAN); + e = errno; + ok(_isnan(d), "Expected NAN, got %0.16e.\n", d); + ok(e == -1, "Expected errno ERANGE, got %d.\n", e); + + errno = -1; + d = p_nexttoward(0, NAN); + e = errno; + ok(_isnan(d), "Expected NAN, got %0.16e.\n", d); + ok(e == -1, "Expected errno ERANGE, got %d.\n", e); +} + START_TEST(msvcr120) { if (!init()) return; @@ -983,4 +1071,5 @@ START_TEST(msvcr120) test_wctype(); test_vsscanf(); test__Cbuild(); + test_nexttoward(); } diff --git a/dlls/msvcr120_app/msvcr120_app.spec b/dlls/msvcr120_app/msvcr120_app.spec index c1f6e0bcf0..706799ce37 100644 --- a/dlls/msvcr120_app/msvcr120_app.spec +++ b/dlls/msvcr120_app/msvcr120_app.spec @@ -1965,9 +1965,9 @@ @ cdecl nextafter(double double) msvcr120.nextafter @ cdecl nextafterf(float float) msvcr120.nextafterf @ cdecl nextafterl(double double) msvcr120.nextafterl -@ stub nexttoward -@ stub nexttowardf -@ stub nexttowardl +@ cdecl nexttoward(double double) msvcr120.nexttoward +@ cdecl nexttowardf(float double) msvcr120.nexttowardf +@ cdecl nexttowardl(double double) msvcr120.nexttowardl @ stub norm @ stub normf @ stub norml diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c index d4785d3508..f6050a1c15 100644 --- a/dlls/msvcrt/math.c +++ b/dlls/msvcrt/math.c @@ -1529,6 +1529,36 @@ float CDECL MSVCRT_nearbyintf(float num) #endif } +/********************************************************************* + * nexttoward (MSVCR120.@) + */ +double CDECL MSVCRT_nexttoward(double num, double next) +{ +#ifdef HAVE_NEXTTOWARD + double ret = nexttoward(num, next); + if (!isnormal(ret) && !isnan(ret) && !isinf(num)) *MSVCRT__errno() = MSVCRT_ERANGE; + return ret; +#else + FIXME("not implemented\n"); + return 0; +#endif +} + +/********************************************************************* + * nexttowardf (MSVCR120.@) + */ +float CDECL MSVCRT_nexttowardf(float num, double next) +{ +#ifdef HAVE_NEXTTOWARDF + float ret = nexttowardf(num, next); + if (!isnormal(ret) && !isnan(ret) && !isinf(num)) *MSVCRT__errno() = MSVCRT_ERANGE; + return ret; +#else + FIXME("not implemented\n"); + return 0; +#endif +} + #endif /* _MSVCR_VER>=120 */ /********************************************************************* diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec index 6e6cc439d8..3592a569e0 100644 --- a/dlls/ucrtbase/ucrtbase.spec +++ b/dlls/ucrtbase/ucrtbase.spec @@ -2438,9 +2438,9 @@ @ cdecl nextafter(double double) MSVCRT__nextafter @ cdecl nextafterf(float float) MSVCRT__nextafterf @ cdecl nextafterl(double double) MSVCRT__nextafter -@ stub nexttoward -@ stub nexttowardf -@ stub nexttowardl +@ cdecl nexttoward(double double) MSVCRT_nexttoward +@ cdecl nexttowardf(float double) MSVCRT_nexttowardf +@ cdecl nexttowardl(double double) MSVCRT_nexttoward @ stub norm @ stub normf @ stub norml -- 2.19.1

3 3

[PATCH 1/4] msvcrt/tests: Add tests for C locale.
by Daniel Lehman 14 Dec '18

14 Dec '18

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> --- dlls/msvcrt/tests/string.c | 80 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c index 0568bcf5df..e80a51824b 100644 --- a/dlls/msvcrt/tests/string.c +++ b/dlls/msvcrt/tests/string.c @@ -89,6 +89,12 @@ static errno_t (__cdecl *p_mbslwr_s)(unsigned char *str, size_t numberOfElements static int (__cdecl *p_wctob)(wint_t); static size_t (__cdecl *p_wcrtomb)(char*, wchar_t, mbstate_t*); static int (__cdecl *p_tolower)(int); +static int (__cdecl *p_towlower)(wint_t); +static int (__cdecl *p__towlower_l)(wint_t, _locale_t); +static int (__cdecl *p_towupper)(wint_t); +static int (__cdecl *p__towupper_l)(wint_t, _locale_t); +static _locale_t(__cdecl *p__create_locale)(int, const char*); +static void(__cdecl *p__free_locale)(_locale_t); static size_t (__cdecl *p_mbrlen)(const char*, size_t, mbstate_t*); static size_t (__cdecl *p_mbrtowc)(wchar_t*, const char*, size_t, mbstate_t*); static int (__cdecl *p__atodbl_l)(_CRT_DOUBLE*,char*,_locale_t); @@ -3603,6 +3609,73 @@ static void test___strncnt(void) } } +static void test_C_locale(void) +{ + int i, j; + wint_t ret, exp; + _locale_t locale; + static const char *locales[] = { NULL, "C" }; + + /* C locale only converts case for [a-zA-Z] */ + setlocale(LC_ALL, "C"); + for (i = 0; i <= 0xffff; i++) + { + ret = p_towlower(i); + if (i >= 'A' && i <= 'Z') + { + exp = i + 'a' - 'A'; + ok(ret == exp, "expected %x, got %x for C locale\n", exp, ret); + } + else + todo_wine_if(ret != i) + ok(ret == i, "expected self %x, got %x for C locale\n", i, ret); + + ret = p_towupper(i); + if (i >= 'a' && i <= 'z') + { + exp = i + 'A' - 'a'; + ok(ret == exp, "expected %x, got %x for C locale\n", exp, ret); + } + else + todo_wine_if(ret != i) + ok(ret == i, "expected self %x, got %x for C locale\n", i, ret); + } + + if (!p__towlower_l || !p__towupper_l || !p__create_locale) + { + win_skip("_towlower_l/_towupper_l/_create_locale not available\n"); + return; + } + + for (i = 0; i < ARRAY_SIZE(locales); i++) { + locale = locales[i] ? p__create_locale(LC_ALL, locales[i]) : NULL; + + for (j = 0; j <= 0xffff; j++) { + ret = p__towlower_l(j, locale); + if (j >= 'A' && j <= 'Z') + { + exp = j + 'a' - 'A'; + ok(ret == exp, "expected %x, got %x for C locale\n", exp, ret); + } + else + todo_wine_if(ret != j) + ok(ret == j, "expected self %x, got %x for C locale\n", j, ret); + + ret = p__towupper_l(j, locale); + if (j >= 'a' && j <= 'z') + { + exp = j + 'A' - 'a'; + ok(ret == exp, "expected %x, got %x for C locale\n", exp, ret); + } + else + todo_wine_if(ret != j) + ok(ret == j, "expected self %x, got %x for C locale\n", j, ret); + } + + p__free_locale(locale); + } +} + START_TEST(string) { char mem[100]; @@ -3648,6 +3721,12 @@ START_TEST(string) p_wctob = (void*)GetProcAddress(hMsvcrt, "wctob"); p_wcrtomb = (void*)GetProcAddress(hMsvcrt, "wcrtomb"); p_tolower = (void*)GetProcAddress(hMsvcrt, "tolower"); + p_towlower = (void*)GetProcAddress(hMsvcrt, "towlower"); + p__towlower_l = (void*)GetProcAddress(hMsvcrt, "_towlower_l"); + p_towupper = (void*)GetProcAddress(hMsvcrt, "towupper"); + p__towupper_l = (void*)GetProcAddress(hMsvcrt, "_towupper_l"); + p__create_locale = (void*)GetProcAddress(hMsvcrt, "_create_locale"); + p__free_locale = (void*)GetProcAddress(hMsvcrt, "_free_locale"); p_mbrlen = (void*)GetProcAddress(hMsvcrt, "mbrlen"); p_mbrtowc = (void*)GetProcAddress(hMsvcrt, "mbrtowc"); p_mbsrtowcs = (void*)GetProcAddress(hMsvcrt, "mbsrtowcs"); @@ -3730,4 +3809,5 @@ START_TEST(string) test__tcsncoll(); test__tcsnicoll(); test___strncnt(); + test_C_locale(); } -- 2.17.1

4 7

[PATCH] include: Add _Deref_ret_z_ stub definition.
by Dmitry Timoshkov 14 Dec '18

14 Dec '18

Yet another compatibility fix for Visual Studio 12.0. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- include/sal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/sal.h b/include/sal.h index c69f7f9840..29746c3a03 100644 --- a/include/sal.h +++ b/include/sal.h @@ -34,6 +34,7 @@ #define _Deref_post_valid_ #define _Deref_post_z_ #define _Deref_prepost_opt_z_ +#define _Deref_ret_z_ #define _Field_range_(min, max) -- 2.19.2

1 0

[PATCH v2] user32: Dont reset focus if current dialog is a child.
by Alistair Leslie-Hughes 14 Dec '18

14 Dec '18

Regression of 44f89322ba8825a8e4851aaaf7de89910701ca75 The standard File Open Dialog, creates an empty WS_EX_CONTROLPARENT child dialog which shouldn't receive focus. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46215 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/user32/dialog.c | 5 +++- dlls/user32/tests/dialog.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 76 insertions(+), 1 deletion(-) diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c index 0b33a57..72e6eee 100644 --- a/dlls/user32/dialog.c +++ b/dlls/user32/dialog.c @@ -692,7 +692,10 @@ static HWND DIALOG_CreateIndirect( HINSTANCE hInst, LPCVOID dlgTemplate, SetFocus( focus ); } else - SetFocus( hwnd ); + { + if (!(template.style & WS_CHILD)) + SetFocus( hwnd ); + } } } diff --git a/dlls/user32/tests/dialog.c b/dlls/user32/tests/dialog.c index 631f3d3..ff6052f 100644 --- a/dlls/user32/tests/dialog.c +++ b/dlls/user32/tests/dialog.c @@ -907,6 +907,55 @@ static INT_PTR CALLBACK focusDlgWinProc (HWND hDlg, UINT uiMsg, WPARAM wParam, return FALSE; } +static INT_PTR CALLBACK EmptyProcUserTemplate(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) +{ + switch(uMsg) { + case WM_INITDIALOG: + return TRUE; + } + return FALSE; +} + +HWND hChildDlg = NULL; +static INT_PTR CALLBACK focusChildDlgWinProc (HWND hwnd, UINT uiMsg, WPARAM wParam, + LPARAM lParam) +{ + switch (uiMsg) + { + case WM_INITDIALOG: + { + RECT rectHwnd; + struct { + DLGTEMPLATE tmplate; + WORD menu,class,title; + } temp; + + SetFocus( GetDlgItem(hwnd, 200) ); + + GetClientRect(hwnd,&rectHwnd); + temp.tmplate.style = WS_CHILD | WS_CLIPSIBLINGS | WS_VISIBLE | DS_CONTROL | DS_3DLOOK; + temp.tmplate.dwExtendedStyle = 0; + temp.tmplate.cdit = 0; + temp.tmplate.x = 0; + temp.tmplate.y = 0; + temp.tmplate.cx = 0; + temp.tmplate.cy = 0; + temp.menu = temp.class = temp.title = 0; + + hChildDlg = CreateDialogIndirectParamA(g_hinst, &temp.tmplate, + hwnd, (DLGPROC)EmptyProcUserTemplate, 0); + ok(hChildDlg != 0, "Failed to create test dialog.\n"); + + return FALSE; + } + case WM_CLOSE: + DestroyWindow(hChildDlg); + return TRUE; + } + + return FALSE; +} + /* Helper for InitialFocusTest */ static const char * GetHwndString(HWND hw) { @@ -1093,6 +1142,29 @@ static void test_focus(void) DestroyWindow(hDlg); } + + /* Test 6: + * Select textbox's text on creation when WM_INITDIALOG creates a child dialog. */ + { + HWND hDlg; + HRSRC hResource; + HANDLE hTemplate; + DLGTEMPLATE* pTemplate; + HWND edit; + + hResource = FindResourceA(g_hinst,"FOCUS_TEST_DIALOG_3", (LPCSTR)RT_DIALOG); + hTemplate = LoadResource(g_hinst, hResource); + pTemplate = LockResource(hTemplate); + + hDlg = CreateDialogIndirectParamA(g_hinst, pTemplate, NULL, focusChildDlgWinProc, 0); + ok(hDlg != 0, "Failed to create test dialog.\n"); + edit = GetDlgItem(hDlg, 200); + + ok(GetFocus() == edit, "Focus not set to edit, focus=%p, dialog=%p, edit=%p\n", + GetFocus(), hDlg, edit); + + DestroyWindow(hDlg); + } } static void test_GetDlgItemText(void) -- 1.9.1

2 1

[PATCH] winebus.sys: Re-add missing Xbox controller PIDs.
by Kai Krakow 14 Dec '18

14 Dec '18

These were introduced in commit 1333206 and have gone missing in one of the previous cleanup commits. Fixes: ccb06c6 ("winebus: Don't override real VID/PID for controllers.") Signed-off-by: Kai Krakow <kai(a)kaishome.de> --- dlls/winebus.sys/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/winebus.sys/main.c b/dlls/winebus.sys/main.c index cee0ae60734..299cec5034d 100644 --- a/dlls/winebus.sys/main.c +++ b/dlls/winebus.sys/main.c @@ -53,9 +53,11 @@ static const WORD PID_XBOX_CONTROLLERS[] = { 0x028f, /* Xbox360 Wireless Controller */ 0x02d1, /* Xbox One Controller */ 0x02dd, /* Xbox One Controller (Covert Forces/Firmware 2015) */ + 0x02e0, /* Xbox One X Controller */ 0x02e3, /* Xbox One Elite Controller */ 0x02e6, /* Wireless XBox Controller Dongle */ 0x02ea, /* Xbox One S Controller */ + 0x02fd, /* Xbox One S Controller (Firmware 2017) */ 0x0719, /* Xbox 360 Wireless Adapter */ }; -- 2.19.2

1 0

[PATCH] user32: Dont reset focus if current dialog is a child.
by Alistair Leslie-Hughes 14 Dec '18

14 Dec '18

Regression of 44f89322ba8825a8e4851aaaf7de89910701ca75 The standard File Open Dialog, creates an empty WS_EX_CONTROLPARENT child dialog which shouldn't receive focus. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46215 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- dlls/user32/dialog.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c index 0b33a57..72e6eee 100644 --- a/dlls/user32/dialog.c +++ b/dlls/user32/dialog.c @@ -692,7 +692,10 @@ static HWND DIALOG_CreateIndirect( HINSTANCE hInst, LPCVOID dlgTemplate, SetFocus( focus ); } else - SetFocus( hwnd ); + { + if (!(template.style & WS_CHILD)) + SetFocus( hwnd ); + } } } -- 1.9.1

3 2

[PATCH] shcore: Fix path string leak for file streams (Valgrind)
by Nikolay Sivov 14 Dec '18

14 Dec '18

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/shcore/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/shcore/main.c b/dlls/shcore/main.c index a544f27006..ac625fb746 100644 --- a/dlls/shcore/main.c +++ b/dlls/shcore/main.c @@ -839,6 +839,7 @@ static ULONG WINAPI filestream_Release(IStream *iface) if (!refcount) { CloseHandle(stream->u.file.handle); + heap_free(stream->u.file.path); heap_free(stream); } -- 2.19.2

1 0

[PATCH] kernelbase/tests: Fix some leaks (Valgrind)
by Nikolay Sivov 14 Dec '18

14 Dec '18

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/kernelbase/tests/path.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/kernelbase/tests/path.c b/dlls/kernelbase/tests/path.c index 7b24f00178..7644c312b7 100644 --- a/dlls/kernelbase/tests/path.c +++ b/dlls/kernelbase/tests/path.c @@ -323,6 +323,7 @@ static void test_PathAllocCanonicalize(void) path_maxW[PATHCCH_MAX_CCH - 1] = '\0'; hr = pPathAllocCanonicalize(path_maxW, PATHCCH_ALLOW_LONG_PATHS, &path_outW); ok(hr == S_OK, "expect hr %#x, got %#x\n", S_OK, hr); + LocalFree(path_outW); /* Check if flags added after Windows 10 1709 are supported */ MultiByteToWideChar(CP_ACP, 0, "C:\\", -1, path_inW, ARRAY_SIZE(path_inW)); @@ -449,12 +450,14 @@ static void test_PathAllocCombine(void) ok(hr == S_OK, "expect hr %#x, got %#x\n", S_OK, hr); WideCharToMultiByte(CP_ACP, 0, resultW, -1, resultA, ARRAY_SIZE(resultA), NULL, NULL); ok(!lstrcmpA(resultA, "\\a"), "expect \\a, got %s\n", resultA); + LocalFree(resultW); MultiByteToWideChar(CP_ACP, 0, "\\b", -1, path2W, ARRAY_SIZE(path2W)); hr = pPathAllocCombine(NULL, path2W, 0, &resultW); ok(hr == S_OK, "expect hr %#x, got %#x\n", S_OK, hr); WideCharToMultiByte(CP_ACP, 0, resultW, -1, resultA, ARRAY_SIZE(resultA), NULL, NULL); ok(!lstrcmpA(resultA, "\\b"), "expect \\b, got %s\n", resultA); + LocalFree(resultW); hr = pPathAllocCombine(path1W, path2W, 0, NULL); ok(hr == E_INVALIDARG, "expect hr %#x, got %#x\n", E_INVALIDARG, hr); -- 2.19.2

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel