- wine-devel - winehq.org

Re: [v2 PATCH 2/3] gdiplus/metafile: Implement EmfPlusImage deserialization ImageDataTypeBitmap image type
by Vincent Povirk 13 Oct '17

13 Oct '17

We should have a FIXME for indexed color formats.

2 2

Re: [PATCH 2/4] msvcp90: Call exception ctor in logic_error and runtime_error ctor.
by Piotr Caban 13 Oct '17

13 Oct '17

Hi Daniel, this patch doesn't look right. The runtime_error class is supposed to override "what" virtual function. I'm attaching a simple test case that shows that name field should not be set to passed string (at least in msvcp60). Thanks, Piotr

2 2

Exported functions in tests
by Zebediah Figura 13 Oct '17

13 Oct '17

Hello all, I was working on a test for MSI type 1 custom actions, i.e. functions exported from a given DLL and called by the install script. I've tested both with an independent file and in the Wine test environment, and I've found that I can successfully export functions from the executable itself with DECLSPEC_EXPORT, and MSI will successfully execute the function, as the attached patch demonstrates. The function returns ERROR_SUCCESS, and changing this to other values gets reflected in the install's error code appropriately. However, as soon as I add a function call to the custom action, the install fails with ERROR_INSTALL_FAILURE, and the function is never called—making it look, in all probability, like a page fault occurred. This is the case when compiling with mingw-w64, both inside the Wine test environment and in an independent file. Notably I have no trouble calling DLLs taken from real MSI packages in this way. I also have no trouble calling the function if I use GetModuleHandle() and GetProcAddress() directly, nor do I run into any trouble whatsoever running the custom action on Linux. It is specifically this environment—running this function as part of a custom action, on Windows. Does anyone know, or have a hunch, as to what the problem might be here? For what it's worth, it's known that native MSI uses a separate process to execute custom actions, although I don't know how this would lend any clue to what's going wrong. --Zeb

3 5

Re: [PATCH 3/4] msvcp90: Define basic_string for runtime_error when not msvcirt.
by Piotr Caban 13 Oct '17

13 Oct '17

Hi Daniel, why do you need it? The class should be not used/exported in msvcirt. Thanks, Piotr

2 4

Re: [PATCH] server_ioctl_file() - Prefix printed hex values with '0x'
by Alexandre Julliard 12 Oct '17

12 Oct '17

Chris Morgan <chmorgan(a)gmail.com> writes: > Avoids the ambiguity with non-alphanumeric hex values. > > Signed-off-by: Chris Morgan <chmorgan(a)gmail.com> > --- > dlls/ntdll/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index fd7f3dd..4d081b7 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -1567,7 +1567,7 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event, > SERVER_END_REQ; > > if (status == STATUS_NOT_SUPPORTED) > - FIXME("Unsupported ioctl %x (device=%x access=%x func=%x method=%x)\n", > + FIXME("Unsupported ioctl 0x%x (device=0x%x access=0x%x func=0x%x method=0x%x)\n", That's mostly a matter of taste, so I don't think it's necessary to change it. -- Alexandre Julliard julliard(a)winehq.org

3 2

fvwm d3d test failures
by Stefan Dösinger 12 Oct '17

12 Oct '17

Hi Alexandre, Since I currently have my head wrapped around the d3d message tests I'd like to give your fvwm2 test failures another try. Can you send me the test failures you currently see? Here I see one failure mostly reliably (~90% of all runs) with fvwm2 in focus follows mouse mode. I think the particular test is not too important, so we can disable it, but I'd like to verify first that it is the same issue you have. Cheers, Stefan

3 3

Re: [PATCH 1/4] wined3d: Show the device window when changing fullscreen resolutions.
by Marvin 12 Oct '17

12 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33502 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:3029: Test failed: Received WM_WINDOWPOSCHANGED but did not expect it, i=0.

2 1

Re: [PATCH 2/4] d3d8/tests: Test mode change messages.
by Marvin 12 Oct '17

12 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33503 Your paranoid android. === w1064 (32 bit device) === device.c:1532: Test failed: Reset failed, hr 0x80070057. device.c:1534: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1546: Test failed: D3DVIEWPORT->Width = 400. device.c:1547: Test failed: D3DVIEWPORT->Height = 300. 0c08:device: unhandled exception c0000005 at 706FA86E

2 1

Re: [PATCH 3/4] gdiplus/metafile: Implement EmfPlusImage deserialization for ImageDataTypeBitmap image type
by Vincent Povirk 12 Oct '17

12 Oct '17

We'll need a way to reuse this when deserializing texture brushes.

1 0

Re: [PATCH 2/4] gdiplus/metafile: Support solid brushes in EmfPlusRecordTypeObject record playback
by Vincent Povirk 12 Oct '17

12 Oct '17

We'll need a way to reuse this when deserializing pen objects.

1 0

Re: [PATCH 3/3] mshtml/tests: Added script event argument test.
by Marvin 12 Oct '17

12 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33498 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH 2/3] mshtml/tests: Use winetest.js in events.html.
by Marvin 12 Oct '17

12 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33497 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath === wvistau64 (64 bit events) === events.c:1006: Test failed: unexpected call img_onerror

1 0

Re: [1/2] twain_32: Add debug traces to TWAIN_UserSelect.
by Alistair Leslie-Hughes 11 Oct '17

11 Oct '17

Hi Vincent, On 10/10/17 07:57, Vincent Povirk wrote: > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> > --- > dlls/twain_32/dsm_ctrl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dlls/twain_32/dsm_ctrl.c b/dlls/twain_32/dsm_ctrl.c > index b71c112..54bd9fa 100644 > --- a/dlls/twain_32/dsm_ctrl.c > +++ b/dlls/twain_32/dsm_ctrl.c > @@ -263,12 +263,17 @@ TW_UINT16 TWAIN_UserSelect (pTW_IDENTITY pOrigin, TW_MEMREF pData) > { > pTW_IDENTITY selected = (pTW_IDENTITY)pData; > > + TRACE("DG_CONTROL/DAT_IDENTITY/MSG_USERSELECT SupportedGroups=0x%x ProductName=%s\n", > + selected->SupportedGroups, wine_dbgstr_a(selected->ProductName)); > + This patch makes the indentation of this function hard to read. Would it be better to just reformat this function to be like the reset of the file. Best Regards Alistair.

3 4

Please change WINE logo
by Farhad Mohammadi Majd 11 Oct '17

11 Oct '17

Hello, the current WINE logo is really ugly in highest level! and has no concept, please change it with better one, I have a good sample: https://commons.wikimedia.org/wiki/File:Wine_bw.png It is really beautiful and Window$ logo shows its relationship with M$ Windows, I hope this logo is legal. .

7 17

Re: [resend 2/2] comctl32: Enhance LISTVIEW_ApproximateViewRect in LV_VIEW_DETAILS mode.
by Nikolay Sivov 11 Oct '17

11 Oct '17

On 11.10.2017 14:46, Vadim Druzhin wrote: > > >> Среда, 11 октября 2017, 12:53 +03:00 от Nikolay Sivov <nsivov(a)codeweavers.com>: >> >> On 10/11/2017 10:11 AM, Vadim Druzhin wrote: >> >>> Calculate approximated window size >>> when control does not have real items. >>> >>> Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html). >>> >>> Signed-off-by: Vadim Druzhin < cdslow(a)mail.ru > >>> --- >>> dlls/comctl32/listview.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c >>> index 8114222 ..7e33f7c 100644 >>> --- a/dlls/comctl32/listview.c >>> +++ b/dlls/comctl32/listview.c >>> @@ -5362,6 +5362,13 @@ static DWORD LISTVIEW_ApproximateViewRect(const LISTVIEW_INFO *infoPtr, INT nIte >>> wWidth = rcBox.right - rcBox.left; >>> wHeight = (rcBox.bottom - rcBox.top) * nItemCount; >>> } >>> + else if (nItemCount > 0) >>> + { >>> + /* No real items, use approximation */ >>> + LISTVIEW_GetHeaderRect(infoPtr, 0, &rcBox); >>> + wHeight = rcBox.bottom - rcBox.top + infoPtr->nItemHeight * nItemCount; >>> + wWidth = infoPtr->nItemWidth; >>> + } >> Hi, Vadim. >> >> This doesn't look right. nItemCount less than -1 or 0 is acceptable too, >> only -1 has special meaning. Please add some tests to >> ./tests/listview.c:test_approximate_viewrect() first. Currently we only >> have some tests, and not that many, for LVS_ICON style. >>> else >>> { >>> /* use current height and width */ >>> -- >>> 2.5.5 >>> >> > For case with nItemCount less than -1 or 0 will be executed old code from else branch (return current window size). > Behavior changed only when nItemCount > 0 but infoPtr->nItemCount <= 0. Yes, my point is that limiting your new code to nItemCount > 0 does not look right. Anyway, like I said it need some tests first.

1 0

Re: [PATCH] mshtml: Added IDocumentEvent stub implementation.
by Marvin 11 Oct '17

11 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33484 Your paranoid android. === wxppro (32 bit events) === events.c:2541: Test failed: Could not get IDocumentEvent iface: 80004002 0a30:events: unhandled exception c0000005 at 0042E8B7 === w2003std (32 bit events) === events.c:2541: Test failed: Could not get IDocumentEvent iface: 80004002 05f0:events: unhandled exception c0000005 at 0042E8B7

1 0

Re: [resend 1/2] comctl32: Preserve title when creating ListView window.
by Nikolay Sivov 11 Oct '17

11 Oct '17

On 10/11/2017 10:10 AM, Vadim Druzhin wrote: > Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html). > > Signed-off-by: Vadim Druzhin <cdslow(a)mail.ru> > --- > dlls/comctl32/listview.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index 73eceff..8114222 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -9532,6 +9532,10 @@ static LRESULT LISTVIEW_NCCreate(HWND hwnd, const CREATESTRUCTW *lpcs) > if (!(infoPtr->hdpaPosX = DPA_Create(10))) goto fail; > if (!(infoPtr->hdpaPosY = DPA_Create(10))) goto fail; > if (!(infoPtr->hdpaColumns = DPA_Create(10))) goto fail; > + > + /* Preserve window title */ > + DefWindowProcW(hwnd, WM_SETTEXT, 0, (LPARAM)(lpcs->lpszName)); > + > return TRUE; This is fixed in git now, see https://source.winehq.org/git/wine.git/commit/ee7ddd1ed38a3b2f41bdb676f42e3…, so no need to resend. > fail: > -- > 2.5.5 >

1 0

Re: [resend 2/2] comctl32: Enhance LISTVIEW_ApproximateViewRect in LV_VIEW_DETAILS mode.
by Nikolay Sivov 11 Oct '17

11 Oct '17

On 10/11/2017 10:11 AM, Vadim Druzhin wrote: > Calculate approximated window size > when control does not have real items. > > Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html). > > Signed-off-by: Vadim Druzhin <cdslow(a)mail.ru> > --- > dlls/comctl32/listview.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index 8114222..7e33f7c 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -5362,6 +5362,13 @@ static DWORD LISTVIEW_ApproximateViewRect(const LISTVIEW_INFO *infoPtr, INT nIte > wWidth = rcBox.right - rcBox.left; > wHeight = (rcBox.bottom - rcBox.top) * nItemCount; > } > + else if (nItemCount > 0) > + { > + /* No real items, use approximation */ > + LISTVIEW_GetHeaderRect(infoPtr, 0, &rcBox); > + wHeight = rcBox.bottom - rcBox.top + infoPtr->nItemHeight * nItemCount; > + wWidth = infoPtr->nItemWidth; > + } Hi, Vadim. This doesn't look right. nItemCount less than -1 or 0 is acceptable too, only -1 has special meaning. Please add some tests to ./tests/listview.c:test_approximate_viewrect() first. Currently we only have some tests, and not that many, for LVS_ICON style. > else > { > /* use current height and width */ > -- > 2.5.5 >

1 0

Re: [v2 PATCH 1/4] gdiplus/tests: Test EMF+ records flags
by Vincent Povirk 10 Oct '17

10 Oct '17

Maybe instead of removing the check completely, we could provide a mask of bits to ignore, or an alternative accepted value?

2 1

Re: [PATCH] ws2_32/tests: Fix compilation warning
by Alexandre Julliard 10 Oct '17

10 Oct '17

Fabian Maurer <dark.shadow4(a)web.de> writes: > Without that change, gcc gives the warning > "include/winsock.h:480:37: ‘readfds.fd_array[__i]’ > may be used uninitialized in this function" It looks initialized to me. What gcc version is that? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [PATCH 1/4] gdiplus/tests: Test EMF+ records flags
by Marvin 10 Oct '17

10 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33463 Your paranoid android. === wxppro (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2003std (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === wvistau64 (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2008s64 (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === wvistau64 (64 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2008s64 (64 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1.

1 0

Wine Swag Sticker Poll
by Aric Stewart 10 Oct '17

10 Oct '17

Hello! So all the way back at wineconf I volunteered to be swag master for winehq. The idea is to have something that can be given away at trade shows, presentations, LUG visits and the like. Just something to help promote the visibility of the project. Jana here, CodeWeavers marketing director, has put together a sampling of designs to do as our first sticker and so now we are looking for some feedback on what people prefer. https://docs.google.com/forms/d/e/1FAIpQLSd5X_fXe9KSFAppRHz8kUo3XKeODyH5KeX… Rosanne? Could you direct me as to where this should be put up for the users as well? I am unfamiliar with how to communicate to our user base. The poll will run for as long as it feels like it needs to get some sort of winner. Comments and suggestions are always welcome! -aric

7 10

Re: [PATCH 1/2] msvcrt: Add vf[w]printf_s_l
by Piotr Caban 10 Oct '17

10 Oct '17

It causes compilation warnings: ../../../wine_src/dlls/msvcr110/../msvcrt/file.c: In function 'MSVCRT_vfprintf_s': ../../../wine_src/dlls/msvcr110/../msvcrt/file.c:5100:12: warning: implicit declaration of function 'MSVCRT__vfprintf_s_l' [-Wimplicit-function-declaration] Thanks, Piotr

1 0

Re: [PATCH 2/2] msvcrt: Change forward for consistency.
by Piotr Caban 10 Oct '17

10 Oct '17

On 10/09/17 12:23, Gijs Vermeulen wrote: > @@ -5320,7 +5320,7 @@ int CDECL MSVCRT_printf_s(const char *format, ...) > __ms_va_list valist; > int res; > __ms_va_start(valist, format); > - res = MSVCRT_vprintf_s(format, valist); > + res = MSVCRT_vfprintf_s(MSVCRT_stdout, format, valist); I don't think this code needs to be changed. It's just a matter of taste so I would leave it as is. Thanks, Piotr

1 0

wine-2.0.3-rc1 Available
by Michael Stefaniuc 10 Oct '17

10 Oct '17

Hello guys, I have pushed wine-2.0.3-rc1 (with tag) to https://github.com/mstefani/wine-stable http://static-winehq.193b.starter-ca-central-1.openshiftapps.com/stable/ This version has only 63 commits and only 38 bugs fixed. The summer was kinda low on bug fixes. So I have picked some small fixes too that had no bugzilla entry. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes - FreeType 2.8.1 compatibility fixes ---------------------------------------------------------------- Bugs fixed in 2.0.3 (total 38): 11433 unimplemented function ole32.dll.OleGetIconOfFile 16948 tmpfile() fails when run from Unix path 24723 Lost Horizon crash/page fault during Chapter 2 26388 Sound Recorder crashes on encoding PCM Sample 32563 Purebasic does not display icons in toolbar which is drawn distorted. 33740 Sound Recorder displays error when seeking MP3 stream to the end 35529 Uninstaller: application list doesn't fit 38328 WPS 2013 (Kingsoft) crash at install 38980 World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports) 40919 Worms Armageddon Gameplay only shows top-left corner of screen 41489 notepad++ escape key 42080 Listview does not draw correctly in some conditions. 42140 "Unrecognized stencil op 0" messages flooding system log in Söldner Secret Wars 42656 ACDSee Pro 10 needs msvcp140.dll.?_Schedule_chore@details@Concurrency@@YAHPEAU_Threadpool_chore@12@@Z 42708 Soul Reaver GOG Cinematics stopped working 42754 Seed of Andromeda Pre-Alpha 0.2 crashes 42910 Scrabble (Infogrames) multiplayer requires IDirectPlay4::EnumConnections 42940 WAtomic: White labels that show name of elements hidden by GL components 43005 secur32/tests/ntlm.ok crashes in DeleteSecurityContext 43020 Guitar Pro 7 needs msvcp140.dll._To_wide 43026 SP+ maker won't run. 43039 Rise of the Tomb Raider needs unimplemented function USER32.dll.PhysicalToLogicalPoint 43097 WarBR: game (WarS v5.5 p4) crashes on start, needs WMP IOleObject::GetExtent method implementation 43157 Adobe Premiere needs ntoskrnl.exe.KeAcquireSpinLockRaiseToDpc 43216 winhttp fails to redirect from http to https on 301 error. 43220 Adobe Premiere needs ntoskrnl.exe.KeReleaseSpinLock 43268 Wargaming.net Game Center needs msvcp140.dll._To_byte 43283 Crazyracing KartRider: Crashes on startup on unimplemented function ntoskrnl.exe.IoCreateNotificationEvent 43295 BitLord crashes on unimplemented function IPHLPAPI.DLL.if_nametoindex 43303 PHP crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.acosh 43304 PHP crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.atanh 43305 numpy crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.log1p 43334 winealsa.drv: Warning while building (GCC 7.1.1) 43369 Nora, Princess and Stray cat (demo): fails to run (division by zero) 43392 valgrind shows a couple invalid reads in programs/regedit/tests/regedit.c 43403 make error on Debian 4.9.30-2kali1 (2017-06-22) x86_64 GNU/Linux 43715 Many applications (winecfg, ...) crash on startup with freetype 2.8.1 43716 freetype 2.8.1 breaks Wine build during font conversion with sfnt2fon ---------------------------------------------------------------- Changes since 2.0.2: Akihiro Sagawa (2): oleaut32: Fix parse error when converting non-ascii string to VT_DATE. gdi32: Return non-zero VREFRESH value for display devices. Alex Henrie (5): comctl32/listview: When adding a scrollbar, update the other one. msvcr120: Add acosh. msvcr120: Add atanh. msvcr120: Add expm1. msvcr120: Add log1p. Alexandre Julliard (1): user32: Always update the visible region for cross-process DCEs. Alistair Leslie-Hughes (2): dplayx: Implement IDirectPlay4 EnumConnections. dmime: Support more interfaces in IDirectMusicAudioPath.GetObjectInPath. Andrey Gusev (1): winealsa.drv: Fix uninitialized variable warning. André Hentschel (2): wpcap: Fix build with newer pcap versions. oleview: Fix bytecount for memmoves (Coverity). Austin English (4): user32: Add LogicalToPhysicalPoint/PhysicalToLogicalPoint stubs. ntoskrnl.exe: Add KeReleaseSpinLock stub. ntoskrnl: Add KeAcquireSpinLockRaiseToDpc stub. ntoskrnl.exe: Add IoCreateNotificationEvent stub. Daniel Lehman (1): mshtml: Decrement refcount in nsWeakReference::Release (Valgrind). Dmitry Timoshkov (3): oleaut32: Add an arguments check to LoadTypeLibEx. user.exe16: Fix memory leak in case when HeapReAlloc fails. dsound: Fix a memory leak. Fabian Maurer (1): user32: Don't send WM_CHAR when a menu gets VK_ESCAPE and add tests. Hans Leidekker (4): winhttp: Reset content length when a redirect creates a new connection. wbemprox: Also free data for tables that don't have a fill function (Valgrind). advpack: Don't trace the contents of an output buffer (Valgrind). msi: Avoid zero size allocations (Valgrind). Henri Verbeet (4): ddraw/tests: Introduce a helper function to create windows. ddraw/tests: Add a test for the alpha and z-buffer blit flags. ddraw: Ignore unsupported blit flags. wined3d: Only warn about 0 stencil ops in gl_stencil_op(). Hugh McMaster (2): regedit: Prevent out-of-bounds reads when unescaping a string (Valgrind). uninstaller: Pass RegQueryValueExW() the size of the buffer (Coverity). Huw D. M. Davies (2): shell32: Remove an extraneous '@'. user32: Explicitly set last error to ERROR_SUCCESS. Jacek Caban (1): wmp: Added IOleObject::GetExtent and SetExtent implementation. Józef Kucia (1): user32: Fix memory leak in WinHelpA(). Ken Thomases (2): winemac: Track whether a view has ever had an OpenGL context attached. gdiplus: Avoid infinite recursion in flatten_bezier(). Marcus Meissner (2): msvcrt: Free the temporary filename (Coverity). gameux: Avoid freeing uninitialized interfaces (Coverity). Michael Müller (1): include: Fix an invalid UUID in dxva2api.idl. Michael Stefaniuc (2): tools/sfnt2fon: Just skip all glyphs below 0x20. fonts: Increase the Em size to fix a build failure with freetype 2.8.1. Mikhail Paulyshka (1): msvcp140: Implement _To_byte. Nikolay Sivov (6): comctl32/toolbar: Fix TB_SETDRAWTEXTFLAGS handler. comctl32/toolbar: Don't add NULL imagelist entries. comctl32/toolbar: Support undocumented IDs for standard bitmap lists. gdi32: Pick first charmap if none was selected using preferred encoding. include: Fix IShellFolderView method macros. shell32/ebrowser: Respond to IOleWindow from IExplorerBrowser. Piotr Caban (4): msvcrt: Use temp directory when creating file in tmpfile. msvcp140: Add _ContextCallback tests. msvcp140/tests: Add _TaskEventLogger tests. msvcp140: Add {_Schedule,_Reschedule,_Release}_chore implementation. Sebastian Lackner (1): ntoskrnl.exe: Add KeReleaseInStackQueuedSpinLock stub. Stefan Dösinger (3): ws2_32: Don't post completion packet if receiving fails with error immediately. iphlpapi: Implement if_nametoindex. msvcp140: Implement _To_wide. Zebediah Figura (4): secur32/tests: Zero-initialize contexts. msacm32: Don't write cbSize if the format is WAVE_FORMAT_PCM. winemp3.acm: Fix error in acmStreamSize(). msacm32: Rewrite PCM conversion functions. Zhenbo Li (1): ole32: Add stub for OleGetIconOfFile. -- Michael Stefaniuc mstefani(a)winehq.org

1 0

Re: [PATCH] shlwapi: Support UNC paths in PathGetDriveNumberW.
by Marvin 09 Oct '17

09 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33459 Your paranoid android. === wxppro (32 bit path) === path.c:1458: Test failed: got = -1 === w2003std (32 bit path) === path.c:1458: Test failed: got = -1

1 0

Re: [PATCH] d3dx9/tests: Avoid bitwise operation.
by Fabian Maurer 09 Oct '17

09 Oct '17

> if (!end1 && !end2) break; > > - status = !end1 ^ !end2; > + status = !end1 && !end2; > ok(!status, "Line %u, test %u: Mismatch in size, test declaration > is %s than expected.\n", line, test_id, end1 ? "shorter" : "longer"); > if (status) Doesn't this change the meaning of the code? You could also just make it into "status = FALSE", since when it's true the conditional break is used. Regards, Fabian Maurer

2 1

Re: [PATCH] quartz: Add missing parameter.
by Matteo Bruni 09 Oct '17

09 Oct '17

2017-10-07 15:55 GMT+02:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/quartz/pin.c | 5 ++++- > dlls/quartz/pin.h | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/dlls/quartz/pin.c b/dlls/quartz/pin.c > index a2651fd49b..355d87d9d5 100644 > --- a/dlls/quartz/pin.c > +++ b/dlls/quartz/pin.c > @@ -218,7 +218,10 @@ static HRESULT PullPin_Init(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinI > return S_OK; > } > > -HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone, LPCRITICAL_SECTION pCritSec, IPin ** ppPin) > +HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, > + SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, > + CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone, > + LPCRITICAL_SECTION pCritSec, IPin ** ppPin) > { > PullPin * pPinImpl; > > diff --git a/dlls/quartz/pin.h b/dlls/quartz/pin.h > index 428fa6fe8e..2f29c929cf 100644 > --- a/dlls/quartz/pin.h > +++ b/dlls/quartz/pin.h > @@ -102,7 +102,10 @@ typedef struct PullPin > #define Req_Pause 3 > > /*** Constructors ***/ > -HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, CLEANUPPROC pCleanUp, STOPPROCESSPROC, REQUESTPROC pCustomRequest, LPCRITICAL_SECTION pCritSec, IPin ** ppPin); > +HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, > + SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, > + CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone, > + LPCRITICAL_SECTION pCritSec, IPin ** ppPin); > > /**************************/ > /*** Pin Implementation ***/ > -- > 2.13.6 Maybe I'm blind (I read this from the cell phone, so definitely possible) but I don't see that you're adding any parameter, rather swapping two arguments in the header only. Just making sure that's what you meant to do.

1 0

Re: [PATCH 1/2] ntdll/tests: Don't abort if NtCancelFileIoEx() is missing.
by Zebediah Figura 09 Oct '17

09 Oct '17

On 10/09/2017 07:29 AM, Jacek Caban wrote: > Hi Zebediah, > > On 07.10.2017 00:18, Zebediah Figura wrote: >> - ok(U(iosb).Status == STATUS_CANCELLED, "Wrong iostatus %x\n", U(iosb).Status); >> - ok(WaitForSingleObject(hEvent, 0) == 0, "hEvent not signaled\n"); >> + ok(U(iosb).Status == STATUS_CANCELLED, "Wrong iostatus %x\n", U(iosb).Status); >> + ok(WaitForSingleObject(hEvent, 0) == 0, "hEvent not signaled\n"); >> + >> + CloseHandle(hPipe); >> + } >> + else >> + skip("NtCancelIoFileEx not available\n"); > > > Please use win_skip() instead. > > > Thanks, > > Jacek > > > Whoops, thanks. Resent.

1 0

Re: [PATCH] gdiplus: Added GdipSetImageAttributesNoOp()
by Vincent Povirk 09 Oct '17

09 Oct '17

This could use some tests. My guess is that there's an additional set of flags for "no op" that overrides the others.

1 0

Re: [PATCH V3] msvcp100: add time_get::do_get and time_get::get functions
by Piotr Caban 06 Oct '17

06 Oct '17

On 10/06/17 20:21, Vijay Kiran Kamuju wrote: > +#define call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod) CALL_VTBL_FUNC(this, 12, istreambuf_iterator_char*, \ > + (const time_get_char*, istreambuf_iterator_char*, istreambuf_iterator_char, istreambuf_iterator_char, ios_base*, int*, struct tm*, char, char), \ > + (this, ret, s, e, base, err, t, fmt, mod)) > +#else > +#define call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod) CALL_VTBL_FUNC(this, 20, istreambuf_iterator_char*, \ > + (const time_get_char*, istreambuf_iterator_char*, istreambuf_iterator_char, istreambuf_iterator_char, ios_base*, int*, struct tm*, char, char), \ > + (this, ret, s, e, base, err, t, fmt, mod)) You're calling wrong virtual functions in call_time_get_char_do_get macro. Second argument of CALL_VTBL_FUNC macro is function offset in virtual function table. Thanks, Piotr

1 0

Re: [v2] msvcrt: Introduce vf[w]printf_helper function.
by Piotr Caban 06 Oct '17

06 Oct '17

Hi, On 10/02/17 21:46, Gijs Vermeulen wrote: > -int CDECL MSVCRT_vfprintf(MSVCRT_FILE* file, const char *format, __ms_va_list valist) > +static int vfprintf_vfwprintf_helper(MSVCRT_FILE* file, const char *format, const MSVCRT_wchar_t *format_wide, > + __ms_va_list valist, MSVCRT__locale_t locale, DWORD options, BOOL wide) I would prefer to have a separate helper for vfprintf and vfwprintf functions. Also please reorder the parameters so it's more similar to _stdio_common_vfprintf. > + if(!MSVCRT_CHECK_PMT( file != NULL )) return -1; > + if(!(wide && MSVCRT_CHECK_PMT( format != NULL ))) return -1; This doesn't work as expected. It should look like this: if(!wide && !MSVCRT_CHECK_PMT(... Thanks, Piotr

1 0

Re: msvcp100: add time_get::do_get and time_get::get functions
by Piotr Caban 06 Oct '17

06 Oct '17

Hi, On 10/06/17 18:37, Vijay Kiran Kamuju wrote: > +#if _MSVCP_VER <= 100 > +#define call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod) CALL_VTBL_FUNC(this, 12, istreambuf_iterator_char*, \ > + (const time_get_char*, istreambuf_iterator_char*, istreambuf_iterator_char, istreambuf_iterator_char, ios_base*, int*, struct tm*, char, char), \ > + (this, ret, s, e, base, err, t)) > +#else > +#define call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod) CALL_VTBL_FUNC(this, 20, istreambuf_iterator_char*, \ > + (const time_get_char*, istreambuf_iterator_char*, istreambuf_iterator_char, istreambuf_iterator_char, ios_base*, int*, struct tm*, char, char), \ > + (this, ret, s, e, base, err, t)) > +#endif This will not compile (too few arguments are passed). > @@ -11613,6 +11644,9 @@ void __asm_dummy_vtables(void) { > VTABLE_ADD_FUNC(locale_facet__Decref) > #endif > VTABLE_ADD_FUNC(time_get_char_do_date_order) > +#if _MSVCP_VER >= 100 > + VTABLE_ADD_FUNC(time_get_char_do_get) > +#endif > VTABLE_ADD_FUNC(time_get_char_do_get_time) > VTABLE_ADD_FUNC(time_get_char_do_get_date) > VTABLE_ADD_FUNC(time_get_char_do_get_weekday) The order of virtual functions is incorrect. Thanks, Piotr

1 0

Re: ImmReleaseContext only return true
by Nikolay Sivov 06 Oct '17

06 Oct '17

On 06.10.2017 18:55, r00t0 wrote: > BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC) > { > - static BOOL shown = FALSE; > - > - if (!shown) { > - FIXME("(%p, %p): stub\n", hWnd, hIMC); > - shown = TRUE; > - } > - return TRUE; > + TRACE("(%p, %p): stub\n", hWnd, hIMC); > + return TRUE; > } Hi, Tomasz. What's a point of this change? (the rest of the diff seems to be whitespace changes only)

1 0

Re: ImmReleaseContext only return true
by Fabian Maurer 06 Oct '17

06 Oct '17

You seem to have a lot of unrelated white-space changes. > BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC) > { >- static BOOL shown = FALSE; >- >- if (!shown) { >- FIXME("(%p, %p): stub\n", hWnd, hIMC); >- shown = TRUE; >- } >- return TRUE; >+ TRACE("(%p, %p): stub\n", hWnd, hIMC); >+ return TRUE; > } What's the point behind this change? Regards, Fabian Maurer

1 0

Re: msxml3: Use correct string length in saxreader_get_cdata_chunk
by Nikolay Sivov 06 Oct '17

06 Oct '17

On 05.10.2017 15:59, Piotr Caban wrote: > @@ -1972,6 +1972,7 @@ static BSTR saxreader_get_cdata_chunk(const xmlChar *str, int len) > BSTR bstr = bstr_from_xmlCharN(str, len), ret; > WCHAR *ptr; > > + len = SysStringLen(bstr); Hi. Just making sure I understand this correctly, the issue is that we're using length counted in xmlChars as WCHAR length?

2 2

Re: [PATCH] rsaenh: Fix length of some algorithm names in aProvEnumAlgsEx array.
by Michael Stefaniuc 05 Oct '17

05 Oct '17

Hello Alex, On 10/05/2017 09:15 AM, Alex Henrie wrote: > From: Louis Lenders <xerox.xerox2000x(a)gmail.com> > > Patch from Wine Staging. > > Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/rsaenh/rsaenh.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/rsaenh/rsaenh.c b/dlls/rsaenh/rsaenh.c > index 3db828638b..97eb474374 100644 > --- a/dlls/rsaenh/rsaenh.c > +++ b/dlls/rsaenh/rsaenh.c > @@ -246,9 +246,9 @@ static const PROV_ENUMALGS_EX aProvEnumAlgsEx[5][RSAENH_MAX_ENUMALGS+1] = > - {CALG_SHA_256, 256,256, 256,CRYPT_FLAG_SIGNING, 6,"SHA-256", 30,"Secure Hash Algorithm (SHA-256)"}, > - {CALG_SHA_384, 384,384, 384,CRYPT_FLAG_SIGNING, 6,"SHA-384", 30,"Secure Hash Algorithm (SHA-384)"}, > - {CALG_SHA_512, 512,512, 512,CRYPT_FLAG_SIGNING, 6,"SHA-512", 30,"Secure Hash Algorithm (SHA-512)"}, > + {CALG_SHA_256, 256,256, 256,CRYPT_FLAG_SIGNING, 8,"SHA-256", 32,"Secure Hash Algorithm (SHA-256)"}, > + {CALG_SHA_384, 384,384, 384,CRYPT_FLAG_SIGNING, 8,"SHA-384", 32,"Secure Hash Algorithm (SHA-384)"}, > + {CALG_SHA_512, 512,512, 512,CRYPT_FLAG_SIGNING, 8,"SHA-512", 32,"Secure Hash Algorithm (SHA-512)"}, why don't you switch the whole big structure to automatically calculate the string sizes? Something like: #define X(str) sizeof(str), str ... {CALG_SHA_256, 256,256, 256,CRYPT_FLAG_SIGNING, X("SHA-256"), X("Secure Hash Algorithm (SHA-256)")}, ... #undef X The less the programmer can fat finger the merrier, especially in security related code. bye michael

1 0

Re: [PATCH] ntdll: Failure callback is optional in LdrResolveDelayLoadedAPI()
by Marvin 05 Oct '17

05 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33398 Your paranoid android. === w1064 (32 bit loader) === loader.c:3019: Test failed: Test 4: unexpected return value DEADBEEF. === w1064 (64 bit loader) === loader.c:3019: Test failed: Test 4: unexpected return value 00000000DEADBEEF.

1 0

Re: [3/3] gdiplus/tests: Add tests for gdi32 transform and clip caching.
by Marvin 05 Oct '17

05 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33389 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/3] gdiplus/tests: Add tests for gdi32 transform and clip caching.
by Marvin 05 Oct '17

05 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33389 Your paranoid android. === wvistau64 (32 bit graphics) === Can't locate object method "new" via package "URI" at /home/testbot/lib/WineTestBot/VMs.pm line 203, <DATA> line 751. Child process died unexpectedly === w864 (32 bit graphics) === Can't locate object method "new" via package "URI" at /home/testbot/lib/WineTestBot/VMs.pm line 203, <DATA> line 751. Child process died unexpectedly

1 0

Re: [v2 PATCH] qedit: Support IAMTimelineGroup interface in IAMTimelineObj
by Nikolay Sivov 05 Oct '17

05 Oct '17

On 05.10.2017 3:03, Alistair Leslie-Hughes wrote: > +static HRESULT WINAPI timelinegrp_QueryInterface(IAMTimelineGroup *iface, REFIID riid, void **object) > +{ > + TimelineObjImpl *This = impl_from_IAMTimelineGroup(iface); > + > + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), object); > + > + if (!object) > + return E_POINTER; There's no test for this condition. > + > + *object = NULL; > + if (IsEqualIID(riid, &IID_IUnknown) || > + IsEqualIID(riid, &IID_IAMTimelineGroup) ) > + *object = &This->IAMTimelineGroup_iface; > + else if (IsEqualIID(riid, &IID_IAMTimelineObj) ) > + *object = &This->IAMTimelineObj_iface; > + else > + WARN("(%p, %s,%p): not found\n", This, debugstr_guid(riid), object); > + > + if (!*object) > + return E_NOINTERFACE; > + > + IUnknown_AddRef((IUnknown*)*object); > + return S_OK; > +} That's not what I meant. Tests don't show that you need this. Please take a look how objects supporting multiple interfaces are implemented.

1 0

Re: [PATCH 4/4] user32: Don't invalidate ComboBox on CB_SETCURSEL message
by Marvin 04 Oct '17

04 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33383 Your paranoid android. === w7u (32 bit msg) === msg.c:12113: Test failed: WmMouseHoverSeq: 0: the msg sequence is not complete: expected 0118 - actual 0000 msg.c:12115: Test failed: wrong tme.dwFlags 00000001, expected 00000000 msg.c:12115: Test failed: wrong tme.hwndTrack 001C01BA, expected 00000000 msg.c:12115: Test failed: wrong tme.dwHoverTime 400, expected 0

1 0

Re: [PATCH] qedit: Support IAMTimelineGroup interface in IAMTimelineObj
by Nikolay Sivov 04 Oct '17

04 Oct '17

On 10/04/2017 07:40 AM, Alistair Leslie-Hughes wrote: > --- a/dlls/qedit/tests/timeline.c > +++ b/dlls/qedit/tests/timeline.c > @@ -126,7 +126,7 @@ static void test_timelineobj_interfaces(void) > IAMTimelineGroup *group; > > hr = IAMTimelineObj_QueryInterface(obj, &IID_IAMTimelineGroup, (void **)&group); > - todo_wine ok(hr == S_OK, "got %08x\n", hr); > + ok(hr == S_OK, "got %08x\n", hr); > if(hr == S_OK) > IAMTimelineGroup_Release(group); You don't need if() after this patch. > +static HRESULT WINAPI timelinegrp_QueryInterface(IAMTimelineGroup *iface, REFIID riid, void **object) > +{ > + TimelineObjImpl *This = impl_from_IAMTimelineGroup(iface); > + > + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), object); > + > + if (!object) > + return E_POINTER; > + > + *object = NULL; > + if (IsEqualIID(riid, &IID_IUnknown) || > + IsEqualIID(riid, &IID_IAMTimelineGroup) ) > + *object = &This->IAMTimelineGroup_iface; > + else > + WARN("(%p, %s,%p): not found\n", This, debugstr_guid(riid), object); > + > + if (!*object) > + return E_NOINTERFACE; > + > + IUnknown_AddRef((IUnknown*)*object); > + return S_OK; > +} This looks wrong, but not impossible. Can you query IAMTimelineObj back from IAMTimelineGroup? Looks like we don't have tests showing that you can't do that.

1 0

Re: [Rediffed PATCH] ntdll: Add stub for RtlGetUnloadEventTrace
by Alex Henrie 04 Oct '17

04 Oct '17

+#define RTL_UNLOAD_EVENT_TRACE_NUMBER 64 +RTL_UNLOAD_EVENT_TRACE RtlpUnloadEventTrace[RTL_UNLOAD_EVENT_TRACE_NUMBER]; Why did you add these? If you don't need them for the stub implementation, I recommend submitting a revised patch without them. -Alex

1 1

Wine 2.18 source code scanned with cppcheck 1.72
by Игорь Чебаненко 03 Oct '17

03 Oct '17

2 1

Re: [v2 PATCH 1/2] advapi32: Handle WinLogonIdsSid in CreateWellKnownSid
by Alexandre Julliard 02 Oct '17

02 Oct '17

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -967,7 +967,7 @@ CreateWellKnownSid( WELL_KNOWN_SID_TYPE WellKnownSidType, > unsigned int i; > TRACE("(%d, %s, %p, %p)\n", WellKnownSidType, debugstr_sid(DomainSid), pSid, cbSid); > > - if (cbSid == NULL || (DomainSid && !IsValidSid(DomainSid))) > + if (cbSid == NULL || (DomainSid && !IsValidSid(DomainSid)) || WellKnownSidType == WinLogonIdsSid) It doesn't look right to special-case it like this. It probably needs more test cases to find out what's going on with such sids. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Update Japanese translation.
by Hugh McMaster 02 Oct '17

02 Oct '17

Hi Akihiro, On Sunday, 1 October 2017 11:23 PM, Akihiro Sagawa wrote: > #: regedit.rc:213 > -#, fuzzy > -#| msgid "" > -#| "Are you sure you want to delete the registry key '%1' and all of its " > -#| "subkeys?" > msgid "" > "Are you sure you want to delete this registry key and all of its subkeys?" > -msgstr "本当にレジストリキー '%1' とそのサブキーを削除しますか?" > +msgstr "本当にこのレジストリキー '%1' とそのサブキーすべてを削除しますか?" You left the '%1' in the updated string. -- Hugh McMaster

2 1

Re: [PATCH 2/2] dwrite: Free the mappings array, but not every element.
by Huw Davies 02 Oct '17

02 Oct '17

On 2 Oct 2017, at 10:26, Huw Davies <huw(a)codeweavers.com> wrote: > > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > dlls/dwrite/analyzer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/dwrite/analyzer.c b/dlls/dwrite/analyzer.c > index 6808b468d6..183abed7f9 100644 > --- a/dlls/dwrite/analyzer.c > +++ b/dlls/dwrite/analyzer.c > @@ -2305,8 +2305,8 @@ static ULONG WINAPI fontfallbackbuilder_Release(IDWriteFontFallbackBuilder *ifac > IDWriteFontCollection_Release(mapping->collection); > heap_free(mapping->ranges); > heap_free(mapping->locale); > - heap_free(mapping); > } > + heap_free(fallbackbuilder->mappings); > > IDWriteFactory5_Release(fallbackbuilder->factory); > heap_free(fallbackbuilder); Ah, this is a dup of 137464. Huw.

1 0

Re: [PATCH 2/2] winhttp: Send basic authorization credentials with the first request if they've been set.
by Marvin 02 Oct '17

02 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33362 Your paranoid android. === w2008s64 (64 bit winhttp) === winhttp.c:1148: Test failed: request failed unexpectedly 400

2 1

Re: [PATCH] msvcrt: Don't crash if _vsnwprintf gets NULL as format string
by Marvin 01 Oct '17

01 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33350 Your paranoid android. === wxppro (32 bit printf) === 09e8:printf: unhandled exception c0000005 at 77C431F7 === w2003std (32 bit printf) === 05f0:printf: unhandled exception c0000005 at 77BD4190

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel