- wine-devel - winehq.org

Re: [PATCH] user32/tests: Added some tests for FindWindow()
by Marvin 02 Jan '17

02 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27514 Your paranoid android. === w864 (32 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100 === w864 (64 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100

1 0

Emitting aligned SSE movs in gcc with force_align_arg_pointer
by Daniel Santos 31 Dec '16

31 Dec '16

I'm working on a few improvements in GCC targeting 64-bit Wine. I've got a patch set that gives us back aligned SSE movs for 64-bit ms_abi functions that call System V functions. However, it looks like I'll have to wait until GCC 8's stage 1 comes around (https://gcc.gnu.org/ml/gcc-patches/2016-12/msg01924.html), but I thought I should post this here to prevent any duplication of effort. (Come to think of it, I should probably open a gcc bug report for this.) Following this patch set … [View More]

1 0

Re: [2/3] ntdll: Implement FileIdInformation class support in NtQueryInformationFile.
by Nikolay Sivov 31 Dec '16

31 Dec '16

On 31.12.2016 16:50, Jonathan Doron wrote: > Signed-off-by: Jonathan Doron <jond(a)wizery.com> > --- > dlls/ntdll/file.c | 19 ++++++++++++++++++- > include/winternl.h | 9 +++++++++ > 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index 6eddd19..fbadfbd 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -2379,7 +2379,7 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, … [View More]PIO_STATUS_BLOCK io, > 0, /* FileRenameInformationBypassAccessCheck */ > 0, /* FileLinkInformationBypassAccessCheck */ > 0, /* FileVolumeNameInformation */ > - 0, /* FileIdInformation */ > + sizeof(FILE_ID_INFORMATION), /* FileIdInformation */ > 0, /* FileIdExtdDirectoryInformation */ > 0, /* FileReplaceCompletionInformation */ > 0, /* FileHardLinkFullIdInformation */ > @@ -2621,6 +2621,23 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, PIO_STATUS_BLOCK io, > } > } > break; > + case FileIdInformation: > + { > + struct statfs volstats; > + FILE_ID_INFORMATION *info = ptr; > + if ((fstat(fd, &st) == -1) || (fstatfs(fd, &volstats) == -1)) > + { > + io->u.Status = FILE_GetNtStatus(); > + } > + else > + { > + memset(info, 0, sizeof(*info)); > + ((PLARGE_INTEGER)&info->VolumeSerialNumber)->LowPart = (ULONG)volstats.f_fsid.__val[0]; > + ((PLARGE_INTEGER)&info->VolumeSerialNumber)->HighPart = (ULONG)volstats.f_fsid.__val[1]; > + ((PLARGE_INTEGER)&info->FileId)->QuadPart = st.st_ino; > + } > + } > + break; > default: > FIXME("Unsupported class (%d)\n", class); > io->u.Status = STATUS_NOT_IMPLEMENTED; > diff --git a/include/winternl.h b/include/winternl.h > index 891b6a7..2f2ea86 100644 > --- a/include/winternl.h > +++ b/include/winternl.h > @@ -571,6 +571,15 @@ typedef struct _FILE_INTERNAL_INFORMATION { > LARGE_INTEGER IndexNumber; > } FILE_INTERNAL_INFORMATION, *PFILE_INTERNAL_INFORMATION; > > +typedef struct _FILE_ID_128 { > + UCHAR Identifier[16]; > +} FILE_ID_128, *PFILE_ID_128; Windows SDK has it in winnt.h, using BYTE instead of UCHAR. > + > +typedef struct _FILE_ID_INFORMATION { > + ULONGLONG VolumeSerialNumber; > + FILE_ID_128 FileId; > +} FILE_ID_INFORMATION, *PFILE_ID_INFORMATION; > + This one should go to winbase.h, as FILE_ID_INFO. > typedef struct _FILE_EA_INFORMATION { > ULONG EaSize; > } FILE_EA_INFORMATION, *PFILE_EA_INFORMATION; [View Less]

2 1

Release plans
by Alexandre Julliard 30 Dec '16

30 Dec '16

Folks, Since there was (understandably) very little activity this week, I'm going to skip today's release. I'll release rc4 next Friday; after that, there will probably be a couple more release candidates, since I'm hoping that we can make some more progress on bug fixing once people are back from the holidays. That will put the final 2.0 probably in the second half of January. Happy New Year to everyone! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32: add stub for GetAutoRotationState
by Alistair Leslie-Hughes 30 Dec '16

30 Dec '16

Hi Fabian, On 30/12/16 12:31, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42106 > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/user32/misc.c | 14 ++++++++++++++ > dlls/user32/user32.spec | 1 + > include/winuser.h | 13 +++++++++++++ > 3 files changed, 28 insertions(+) > > diff --git a/dlls/user32/misc.c b/dlls/user32/misc.c > index fa0502e25e..15f5c877fa 100644 > --- a/dlls/user32/misc.c … [View More]

2 1

Re: [PATCH 2/2] regedit: Only allow value renaming via the Edit or Popup menus
by Ken Thomases 29 Dec '16

29 Dec '16

Hi, I personally dislike this proposed change. I use click-to-rename values all the time and can't think of why that would be a problem. -Ken

3 2

Re: [PATCH 2/2] regedit: Only allow value renaming via the Edit or Popup menus
by Nikolay Sivov 29 Dec '16

29 Dec '16

On 28.12.2016 14:47, Hugh McMaster wrote: > @@ -485,7 +494,7 @@ HWND CreateListView(HWND hwndParent, UINT id) > /* Get the dimensions of the parent window's client area, and create the list view control. */ > GetClientRect(hwndParent, &rcClient); > hwndLV = CreateWindowExW(WS_EX_CLIENTEDGE, WC_LISTVIEWW, ListView, > - WS_VISIBLE | WS_CHILD | WS_TABSTOP | LVS_REPORT | LVS_EDITLABELS, > + WS_VISIBLE | … [View More]

2 2

Re: [PATCH] winmm: RegQueryValueExW wants the size in bytes, not the size in characters.
by Andrew Eikum 28 Dec '16

28 Dec '16

Thanks. These look good but we're in code freeze. I'll be happy to sign-off on them after the freeze is over. Andrew On Mon, Dec 26, 2016 at 04:25:22PM +0100, Carlo Bramini wrote: > There is a bug into dlls/winmm/playsound.c > Function RegQueryValueExW accepts the size in bytes as parameter, not the size > in characters. > > See: > https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911(v=vs.85). > aspx > > Sincerely. > > Signed-off-by: Carlo … [View More]

1 0

wined3d Add Amd rx 480 binary driver
by Jarkko Korpi 26 Dec '16

26 Dec '16

http://source.winehq.org/git/wine.git/commit/c63e3261f37e8116e59c70b9bed20a… Since that commit Rx 480 supposed to be recognized, but I am using closed source drivers, because the audio patches arent in upstream yet. I found a real problem from SC2 appdatabase and I could confirm it myself. When you start SC2 and go to options it limits your GPU graphics options and complains not enough memory. With the attached patch here the options are not limited anymore.

2 1

(no subject)
by Jarkko Korpi 26 Dec '16

26 Dec '16

http://source.winehq.org/git/wine.git/commit/c63e3261f37e8116e59c70b9bed20a… Since that commit Rx 480 supposed to be recognized, but I am using closed source drivers, because the audio patches arent in upstream yet. I found a real problem from SC2 appdatabase and I could confirm it myself. When you start SC2 and go to options it limits your GPU graphics options. With the attached patch here the options are not limited anymore.

1 0

RE: msvcirt: Avoid "array subscript above array bounds" warnings in test_ostrstream and test_strstreambuf.
by Filip Frackiewicz 24 Dec '16

24 Dec '16

Hi Gerald, In wine-1.9.22-129-g906e770 I see the array subscript warnings in the following location: ../../../../wine/dlls/msvcirt/tests/msvcirt.c: In function ‘test_strstream’: ../../../../wine/dlls/msvcirt/tests/msvcirt.c:6861:34: warning: array subscript is above array bounds [-Warray-bounds] ok(pssb->base.ebuf == buffer + 0x7fffffff || pssb->base.ebuf == (char*) -1, ~~~~~~~^~~~~~~~~~~~ ../../../../wine/dlls/msvcirt/tests/msvcirt.c:6868:35: warning: … [View More]

2 1

Re: [PATCH] mscoree: Free argument buffer on error (Coverity)
by Vincent Povirk 22 Dec '16

22 Dec '16

I'm out visiting family and don't have access to a machine that can build or run Wine. I'll be able to do reviews again next year. FWIW, by purely visual inspection this looks fine to me.

1 0

Re: [PATCH] msvcrt: Pass WCHAR strings to MessageBoxIndirectW.
by Nikolay Sivov 22 Dec '16

22 Dec '16

On Thu, 22 Dec 2016 14:38:19 -0700 Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Cc: Piotr Caban <piotr(a)codeweavers.com> > Cc: Nikolay Sivov <bunglehead(a)gmail.com> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=42057 > > I figured this would be a good time to get rid of the misleading > Hungarian notation and move the string into the single function that > uses it. > > v2: Switch to WCHAR type. > > Signed-off-by: Alex Henrie &… [View More]lt;alexhenrie24(a)gmail.com> > --- > dlls/msvcrt/exit.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dlls/msvcrt/exit.c b/dlls/msvcrt/exit.c > index 9ba0891806..ad5a78d54d 100644 > --- a/dlls/msvcrt/exit.c > +++ b/dlls/msvcrt/exit.c > @@ -41,8 +41,6 @@ typedef struct MSVCRT__onexit_table_t > MSVCRT__onexit_t *_end; > } MSVCRT__onexit_table_t; > > -static const char szMsgBoxTitle[] = "Wine C++ Runtime Library"; > - > extern int MSVCRT_app_type; > extern MSVCRT_wchar_t *MSVCRT__wpgmptr; > > @@ -112,10 +110,12 @@ void CDECL MSVCRT__exit(int exitcode) > /* Print out an error message with an option to debug */ > static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *message) > { > - static const MSVCRT_wchar_t message_format[] = {'%','s','\n','\n','P','r','o','g','r','a','m',':',' ','%','s','\n', > + static const WCHAR message_format[] = {'%','s','\n','\n','P','r','o','g','r','a','m',':',' ','%','s','\n', > '%','s','\n','\n','P','r','e','s','s',' ','O','K',' ','t','o',' ','e','x','i','t',' ','t','h','e',' ', > 'p','r','o','g','r','a','m',',',' ','o','r',' ','C','a','n','c','e','l',' ','t','o',' ','s','t','a','r','t',' ', > 't','h','e',' ','W','i','n','e',' ','d','e','b','b','u','g','e','r','.','\n',0}; > + static const WCHAR title[] = > + {'W','i','n','e',' ','C','+','+',' ','R','u','n','t','i','m','e',' ','L','i','b','r','a','r','y',0}; 'message_format' is used with MSVCRT__snwprintf, so it should be wchar_t strictly speaking. > > MSGBOXPARAMSW msgbox; > MSVCRT_wchar_t text[2048]; Another existing bug is wrong buffer length here: --- MSVCRT__snwprintf(text,sizeof(text),message_format, lead, MSVCRT__wpgmptr, message); --- Could be a separate patch I guess. > @@ -126,8 +126,8 @@ static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *mess > msgbox.cbSize = sizeof(msgbox); > msgbox.hwndOwner = GetActiveWindow(); > msgbox.hInstance = 0; > - msgbox.lpszText = (LPCWSTR)text; > - msgbox.lpszCaption = (LPCWSTR)szMsgBoxTitle; > + msgbox.lpszText = text; > + msgbox.lpszCaption = title; What I meant is that you can remove 'text' cast without changing its type. > msgbox.dwStyle = MB_OKCANCEL|MB_ICONERROR; > msgbox.lpszIcon = NULL; > msgbox.dwContextHelpId = 0; [View Less]

1 0

Re: [PATCH] msvcrt: Pass wide char caption string to MessageBoxIndirectW.
by Nikolay Sivov 22 Dec '16

22 Dec '16

On Thu, 22 Dec 2016 14:20:26 -0700 Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Cc: Piotr Caban <piotr(a)codeweavers.com> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=42057 > > I figured this would be a good time to get rid of the misleading > Hungarian notation and move the string into the single function that > uses it. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/msvcrt/exit.c | 6 +++--- > 1 file … [View More]

1 0

Re: [PATCH 2/2] user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown and add tests
by Marvin 22 Dec '16

22 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27468 Your paranoid android. === w7u (32 bit msg) === msg.c:9126: Test failed: did not get zero count as expected (1). msg.c:9129: Test failed: did not get one count as expected (2). msg.c:9133: Test failed: killing replaced … [View More]

2 1

Re: [PATCH 1/2] user32: Fix WM_NCPAINT for windows crossing screen boarders and add tests
by Marvin 22 Dec '16

22 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27467 Your paranoid android. === w7pro64 (64 bit msg) === msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 4: in msg 0x0047 expecting wParam 0x8170 got 0x1803 msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 5: … [View More]

2 1

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind) (try 2)
by Austin English 21 Dec '16

21 Dec '16

On Wed, Dec 14, 2016 at 4:45 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Assigned". > > This means that the patch has been assigned to a reviewer. If the > reviewer signs off on the patch, it will be committed, otherwise > you'll receive advice on how to improve it. If you don't hear anything > after a couple of … [View More]

3 3

Can't build crosstests
by Fabian Maurer 20 Dec '16

20 Dec '16

Hello, I'm trying to build the tests for windows, but I can't get it working anymore. I have mingw installed and it does work for cross-compiling with code-blocks, but wine says it's broken. The configure script fails with >checking for i686-w64-mingw32-gcc... i686-w64-mingw32-gcc >checking whether i686-w64-mingw32-gcc works... no An idea how to find out what's going wrong?

3 4

Re: user32/tests: Disable automatic shell restart during SetShellWindow tests.
by Marvin 20 Dec '16

20 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27438 Your paranoid android. === w864 (32 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100 === w864 (64 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100

2 1

Re: [PATCH] gdiplus/tests: Test for initial properties of adjustable arrow caps
by Vincent Povirk 19 Dec '16

19 Dec '16

On Fri, Dec 16, 2016 at 6:21 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + stat = GdipGetCustomLineCapBaseInset((GpCustomLineCap*)cap, &inset); > + ok(stat == Ok, "Unexpected return code, %d\n", stat); > + It isn't enough to reject the patch, but I'm curious why you don't test this value.

2 1

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.
by Nikolay Sivov 19 Dec '16

19 Dec '16

On 19.12.2016 13:38, Hans Leidekker wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/shell32/tests/shlfileop.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c > index 0e502fc..776da98 100644 > --- a/dlls/shell32/tests/shlfileop.c > +++ b/dlls/shell32/tests/shlfileop.c > @@ -819,7 +819,7 @@ static void test_rename(void) > … [View More]

2 1

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.
by Marvin 19 Dec '16

19 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27406 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128 === wvistau64 (64 bit shlfileop) === shlfileop.c:818: Test failed: Expected … [View More]

2 1

Re: [PATCH] webservices: free the potentially allocated pointer (Coverity)
by Hans Leidekker 19 Dec '16

19 Dec '16

On Sat, 2016-12-17 at 12:48 +0100, Marcus Meissner wrote: > 1374356 Resource leak > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/webservices/reader.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c > index d67c47a701..219683b2af 100644 > --- a/dlls/webservices/reader.c > +++ b/dlls/webservices/reader.c > @@ -4701,15 +… [View More]

2 1

Re: [PATCH 2/4] ddraw: Subtract framebuffer size from reported available video memory.
by Henri Verbeet 19 Dec '16

19 Dec '16

On 18 December 2016 at 00:22, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + INT64 total_vidmem, free_vidmem; ... > + free_vidmem = wined3d_device_get_available_texture_mem(ddraw->wined3d_device); > + *free = max(0, free_vidmem - framebuffer_size); This works, but it seems a little silly to use INT64 to avoid writing something along the lines of "*free = framebuffer_size > free_vidmem ? 0 : free_vidmem - framebuffer_size;".

1 0

Wined3d textureless rendering
by Bruno Jesus 18 Dec '16

18 Dec '16

Hello everyone. Following my email last year email asking if rendering in wireframe could speedup a game (answer was no in many different ways) I have a new idea after playing Totaly Accurate Battle Simulator with its red and blue army. What if I skip applying every texture to every object? Probably everything would be black so I would need to use different incremental solid color to distinguish stuff in the screen. Would that save memory and also make games faster? Remembering that my 3D … [View More]

2 2

[OT] Machine learning for automatical GUI testing
by Qian Hong 18 Dec '16

18 Dec '16

Hi folks, I was falling into machine learning recently and I think I'd like to share some ideas. Here is one of them: quote: ``` Universe allows an AI agent to use a computer like a human does: by looking at screen pixels and operating a virtual keyboard and mouse. We must train AI systems on the full range of tasks we expect them to solve, and Universe lets us train a single agent on any task a human can complete with a computer. ``` Reference: https://openai.com/blog/universe/ … [View More]

1 0

Re: [Tools] testbot: Skip ntdll:exception on the Windows 10 VM.
by Francois Gouget 16 Dec '16

16 Dec '16

On Fri, 16 Dec 2016, Francois Gouget wrote: [...] > - $Script .= "-q -o $RptFileName -t $Tag -m \"$EMail\" -i \"$Info\"\r\n" . > + my $Ignore = ($VM->Name eq "w1064" ? "-n ntdll:exception" : ""); > + $Script .= "-q -o $RptFileName -t $Tag -m \"$EMail\" -i \"$Info\" $Ignore\r\n" . > "$FileName -q -s $RptFileName\r\n"; This should not be needed after all. The trick is not to upgrade QEMU, Windows 10, the host kernel, change the emulated CPU or switch to … [View More]

1 0

Re: [PATCH 3/7] d3d11/tests: Add workaround for bug in AMD Windows driver.
by Henri Verbeet 16 Dec '16

16 Dec '16

On 15 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 59 +++++++++++++++++++++++++++--------------------- > 1 file changed, 33 insertions(+), 26 deletions(-) > Unfortunately this makes it fail on Wine for me, probably because the initial texture data is undefined.

2 2

Re: [PATCH 7/7] wined3d: Make total video memory limit optional.
by Henri Verbeet 16 Dec '16

16 Dec '16

On 15 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > It's enough to enable this workaround for ddraw. > So would it then also be enough to just fixup things in ddraw7_GetAvailableVidMem()? In fact, the documentation suggests that's actually the proper place, and that this shouldn't be specific to the Windows version. You could probably use wined3d_get_adapter_display_mode() together with wined3d_calculate_format_pitch() to calculate the primary surface size.

2 2

Re: [PATCH v2 14/18] d3d11/tests: Add test for depth/stencil shader resource views.
by Henri Verbeet 15 Dec '16

15 Dec '16

On 9 December 2016 at 11:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The test was slightly changed. If it still fails the failures should be more > clear now after "d3d11/tests: Print expected result in case of failures in > check_texture_sub_resource_*() functions." > Still fails: d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. … [View More]d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got 0.00000000e+000, expected 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6599: Test failed: Got 1.00000000e+002, expected 2.55000000e+002 at (0, 0), sub-resource 0. d3d11.c:6608: Test failed: Got 2.55199997e+002, expected 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6613: Test failed: Got 3.29999995e+000, expected 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6618: Test failed: Got 4.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got 0.00000000e+000, expected 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6599: Test failed: Got 1.00000000e+002, expected 2.55000000e+002 at (0, 0), sub-resource 0. d3d11.c:6608: Test failed: Got 2.55199997e+002, expected 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6613: Test failed: Got 3.29999995e+000, expected 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6618: Test failed: Got 4.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. So I investigated this a little, and the issue seems to be that as soon as D3D11_BIND_SHADER_RESOURCE is in the bind flags, reads from the depth texture return stale values. E.g., the failure at line 6563 is from the 0.6f written by the clear at line 6544. This can also be reproduced by calling check_texture_float() directly on the depth texture, and is not specific to typeless formats. I'd guess at a driver bug related to e.g. compressed depth or fast clear handling. Regardless, I'd expect that using separate resources for the clear and the shader reads would fix the failures, although it would perhaps weaken the test a little. [View Less]

3 4

Re: [PATCH] d3dx9: Fix a typo in TRACE() message.
by Matteo Bruni 15 Dec '16

15 Dec '16

2016-12-12 11:21 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > @@ -750,7 +750,7 @@ D3DXMATRIX* WINAPI D3DXMatrixTransformation(D3DXMATRIX *pout, const D3DXVECTOR3 > D3DXQUATERNION prc; > D3DXVECTOR3 psc, pt; > > - TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcentr %p, protation %p, ptranslation %p\n", > + TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcenter %p, protation %p, … [View More]

1 0

Re: [PATCH v2 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.
by Piotr Caban 15 Dec '16

15 Dec '16

Hi, On 12/14/16 18:18, Lauri Kenttä wrote: > + for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) { > + WCHAR tmp[] = {zeros[i] + 4, zeros[i], zeros[i] + 5, 0}; > + res = p_wcstoi64(tmp, NULL, 0); > + todo_wine ok(res == 405, "with zero = U+%04X: got %d, expected 405\n", zeros[i], (int)res); > + tmp[1] = zeros[i] + 10; > + res = p_wcstoi64(tmp, NULL, 0); Please change the line to: res = p_wcstoi64(tmp, NULL, 16); Currently you don'… [View More]

2 2

Re: [PATCH] appwiz.cpl: Remove list entries left over from an earlier uninstall
by Dmitry Timoshkov 15 Dec '16

15 Dec '16

Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > -IMPORTS = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 > +IMPORTS = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 shlwapi ... > +#include <shlwapi.h> ... > - info->regroot = root; > + info->regroot = SHRegDuplicateHKey(root); Adding a whole new import just because of a simple RegOpenKeyEx() wrapper is not really justified. -- Dmitry.

2 1

Re: [v3] winex11: Use XIAllDevices to select for XI_RawMotion
by Carlos Garnacho 15 Dec '16

15 Dec '16

Hi all, Got this message from Marvin about "formatting", but I'm not sure what could have triggered this. Getting picky I see the parens at the update_relative_valuators function aren't alright given surrounding code style, but I see nothing specifically against https://wiki.winehq.org/Submitting_Patches#Code_guidelines or https://source.winehq.org/patches/#legend Is there anything actually wrong? I'll be happy to send an updated patch. Cheers, Carlos On Mon, Dec 12, 2016 at 11:15 PM, … [View More]

2 2

wine-staging status
by Michael Cronenworth 14 Dec '16

14 Dec '16

Hi, Is Wine Staging on hiatus? MIA? DIA? It has been one month since the last release with no signs of any new commits. I sent an e-mail to Sebastian but no response yet. Thanks, Michael

3 2

Re: [PATCH 3/3] msvcrt: Make wcstoi64 support various Unicode digits.
by Henri Verbeet 14 Dec '16

14 Dec '16

On 13 December 2016 at 19:48, Lauri Kenttä <lauri.kentta(a)gmail.com> wrote: > @@ -2027,6 +2027,19 @@ static int wctoint(WCHAR c, int base) > v = c - 'A' + 10; > else if ('a' <= c && c <= 'z') > v = c - 'a' + 10; > + else { > + /* Unicode points that contain digits 0-9; keep this sorted! */ > + static const WCHAR zeros[] = { > + 0x660, 0x6f0, 0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, > + … [View More]

4 8

Re: [PATCH 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.
by Piotr Caban 14 Dec '16

14 Dec '16

Hi Lauri, On 12/13/16 19:48, Lauri Kenttä wrote: > + static const WCHAR zeros[] = { > + 0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0x660, 0x6f0, 0xff10, > + 0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, 0xd66 > + }; Please also add a test for Tibetan digits range: https://unicode-table.com/en/0F20/ > + /* Test various unicode digits */ > + for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) { > + WCHAR tmp[] = {zeros[i]+4, zeros[i], … [View More]

2 1

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind) (try 2)
by Henri Verbeet 14 Dec '16

14 Dec '16

On 13 December 2016 at 20:17, Austin English <austinenglish(a)gmail.com> wrote: > + /* buf was originally [24], increased to 48 to prevent a stack smashing error when running tests under Valgrind */ > + unsigned char buf[48]; /* "-1.1111111111111111E-308". */ The more interesting comment would perhaps be what actually happens and why this helps. One thing I do notice is that while 24 chars would be enough to hold "-1.1111111111111111E-308", that doesn't leave any room … [View More]

2 5

Re: [PATCH] shlwapi: Changed UrlEscapeW error paths and add tests
by Jacek Caban 14 Dec '16

14 Dec '16

Hi Fabian, On 13.12.2016 22:53, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=41956 > > Also changed wininet:HTTP_HandleRedirect to not break it. > On windows output buffer must not be NULL, > and size must not be NULL or zero, > or it won't return the number of needed characters. Please send wininet changes as separated patch. They don't depend on shlwapi, so may be applied separately, before shlwapi patch. Other than that and one small comment … [View More]bellow, the patch looks good. Thanks. > + /* Check error paths */ > + > + size = 0; > + ret = UrlEscapeW(path_test, NULL, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); You set and test size although the actual call doesn't use it. Please remove lines with size. Same in a few more cases. > + > + size = 0; > + ret = UrlEscapeW(path_test, NULL, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 0; > + ret = UrlEscapeW(path_test, empty_string, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 0; > + ret = UrlEscapeW(path_test, empty_string, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 1; > + ret = UrlEscapeW(path_test, NULL, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, NULL, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, empty_string, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, empty_string, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_POINTER, "got %x, expected %x\n", ret, E_POINTER); > + ok(size == 6, "got %d, expected %d\n", size, 6); Thanks, Jacek [View Less]

3 2

Wine Swag and Promotion
by Aric Stewart 13 Dec '16

13 Dec '16

Hello all, So at this last wineconf we had a great discussion around promotion of the wine project and how we get more interaction with the broader open source developer and user community. As part of that we really wanted people to step up and volunteer to attend conferences, Linux user groups, shows and wherever they can to talk about wine. Jeremy reminded everyone that there is money in the wine project budget to compensate people for expenses around this. The job I volunteered to take on … [View More]

2 1

Re: winhttp: Handle EINTR from connect and poll.
by Bruno Jesus 13 Dec '16

13 Dec '16

On Tue, Dec 13, 2016 at 7:33 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/winhttp/net.c | 47 +++++++++++++++++++++++++++++++++-------------- > 1 file changed, 33 insertions(+), 14 deletions(-) Hi, Isn't it better to make winhttp use ws2_32 just like wininet change [1]? Then we would have a single point for all networking code and EINTR is already covered in ws2_32. [1] http://source.winehq.… [View More]

2 3

Re: [PATCH 3/3] wined3d: Filter messages for fullscreen mode changes.
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27335 Your paranoid android. === w864 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4425: … [View More]

1 0

Re: [PATCH 2/3] d3d9/tests: Add test showing WM_SIZE is not sent during fullscreen mode change.
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27334 Your paranoid android. === w864 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4425: … [View More]

1 0

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind)
by Hans Leidekker 13 Dec '16

13 Dec '16

On Mon, 2016-12-12 at 16:20 -0600, Austin English wrote: > This avoids a stack smashing error when running > dlls/webservices/tests/writer.c under Valgrind. > > diff --git a/dlls/webservices/writer.c b/dlls/webservices/writer.c > index c1f1b0c..07b32d8 100644 > --- a/dlls/webservices/writer.c > +++ b/dlls/webservices/writer.c > @@ -1369,7 +1369,7 @@ static HRESULT text_to_utf8text( const WS_XML_TEXT *text, WS_XML_UTF8_TEXT **ret > case WS_XML_TEXT_TYPE_DOUBLE: &… [View More]

1 0

Re: [PATCH] advapi32: Add tests for StartTrace().
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27322 Your paranoid android. === wxppro (32 bit eventlog) === eventlog.c:1170: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1216: Test failed: Expected success, got 161 eventlog.c:1220: Test failed: Expected … [View More]

1 0

Re: [PATCH] mmdevapi: Fix pointer type cast
by Andrew Eikum 12 Dec '16

12 Dec '16

On Sat, Dec 10, 2016 at 08:54:51AM +0300, Nikolay Sivov wrote: > diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c > index 221fb39..b189e8e 100644 > --- a/dlls/mmdevapi/devenum.c > +++ b/dlls/mmdevapi/devenum.c > @@ -613,7 +613,7 @@ static HRESULT WINAPI MMDevice_Activate(IMMDevice *iface, REFIID riid, DWORD cls > if (SUCCEEDED(hr)) > { > IPersistPropertyBag *ppb; > - hr = IUnknown_QueryInterface((IUnknown*)*ppv, … [View More]

3 2

Re: [2/2 v2] winex11: Use XIAllDevices to select for XI_RawMotion
by Henri Verbeet 12 Dec '16

12 Dec '16

On 18 November 2016 at 12:43, Carlos Garnacho <carlosg(a)gnome.org> wrote: > Change the strategy used to get raw motion from slave devices. Instead > of selecting for XI2 events for every slave device individually, do it > for XIAllDevices, and store the current device's relative X/Y valuators > so they can be quickly looked up in the XI_RawMotion events received. > I think this makes sense, and in my (limited) testing this correctly handles the case of attaching a new … [View More]input device. I do have a few minor comments though: > +static void update_relative_valuators(XIAnyClassInfo **valuators, > + int n_valuators) This should probably just be "static void update_relative_valuators( XIAnyClassInfo **valuators, int n_valuators )" > + free( thread_data->x_rel_valuator ); > + free( thread_data->y_rel_valuator ); ... > + thread_data->x_rel_valuator = malloc( sizeof(XIValuatorClassInfo) ); > + memcpy ( thread_data->x_rel_valuator, class, sizeof(XIValuatorClassInfo) ); We generally avoid malloc()/free() in Wine code and use HeapAlloc()/HeapFree() instead. The main consideration has to do with the way address space is allocated for Win32 applications, effectively making malloc() space a bit more scarce than HeapAlloc() space. We'd probably prefer the sizeof as "sizeof(*thread_data->x_rel_valuator)", or perhaps "sizeof(*class)". I'm not sure how much we should worry about this in practice, but when multiple slaves are attached to the master, and they're not completely idle, update_relative_valuators() can end up getting called quite a bit. It doesn't seem hard to at least do the allocation only once, and only update the data in update_relative_valuators(). Perhaps it's also fine the way it is though. > - XISetMask( mask_bits, XI_ButtonPress ); This was added intentionally (see also https://bugs.winehq.org/show_bug.cgi?id=27522#c18). Perhaps it's no longer needed, but that would need to be a separate patch. > + pointer_info = pXIQueryDevice( data->display, data->xi2_core_pointer, &count ); > + update_relative_valuators( pointer_info->classes, pointer_info->num_classes ); > + pXIFreeDeviceInfo( pointer_info ); ... > + pXISelectEvents( data->display, DefaultRootWindow( data->display ), &mask, 1 ); I'm not too concerned about it, but can this race? I.e. switching slaves between when update_relative_valuators() is called above and when XISelectEvents() takes effect. Applies to querying the devices list as well. > + if (thread_data->xi2_current_slave == 0) We'd typically write that "if (!thread_data->xi2_current_slave)", although I don't think anyone would be overly concerned about it. > + for (i = 0; i <= max ( x_rel->number, y_rel->number ); i++) > + { > +»······if (!XIMaskIsSet( event->valuators.mask, i )) continue; > +»······val = *values++; > +»······if (i == x_rel->number) > +»······{ > + input.u.mi.dx = dx = val; > +»······ if (x_rel->min < x_rel->max) > + input.u.mi.dx = val * (virtual_rect.right - virtual_rect.left) > + / (x_rel->max - x_rel->min); > +»······} > +»······if (i == y_rel->number) > +»······{ > +»······ input.u.mi.dy = dy = val; > +»······ if (y_rel->min < y_rel->max) You're using tabs for indentation here. [View Less]

2 1

Re: [PATCH] shlwapi: Avoid 'else if' for IStream_fnQueryInterface.
by Nikolay Sivov 12 Dec '16

12 Dec '16

On Mon, 12 Dec 2016 13:24:38 +0200 Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/shlwapi/regstream.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/dlls/shlwapi/regstream.c b/dlls/shlwapi/regstream.c > index 1b0ca4e..d886c0c 100644 > --- a/dlls/shlwapi/regstream.c > +++ b/dlls/shlwapi/regstream.c > @@ -67,9 +67,7 @@ static HRESULT WINAPI … [View More]

1 0

Re: [PATCH resend 13/18] wined3d: Use depth/stencil formats for typeless resources only when WINED3DUSAGE_DEPTHSTENCIL is set.
by Henri Verbeet 12 Dec '16

12 Dec '16

On 9 December 2016 at 11:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > const struct wined3d_format *wined3d_get_format(const struct wined3d_gl_info *gl_info, > - enum wined3d_format_id format_id) > + enum wined3d_format_id format_id, unsigned int resource_usage) > { > + const struct wined3d_format *format; > int idx = get_format_idx(format_id); > + unsigned int i; > > if (idx == -1) > { > - FIXME("Can't … [View More]

1 0

Re: [v2] preloader: Allow a debugger to find ld.so's rendezvous-struct
by Alexandre Julliard 12 Dec '16

12 Dec '16

Keno Fischer <keno(a)juliacomputing.com> writes: > @@ -123,6 +123,18 @@ static struct wine_preload_info preload_info[] = > { 0, 0 } /* end of list */ > }; > > +/* A fake .dynamic section through which we can inform the debugger of the > + address of the chain-loaded dynamic linker's rendezvous struct */ > +__asm__( > +".section .dynamic,\"aw\"\n" > +".global _DYNAMIC\n" > +"_DYNAMIC: .quad 21\n" // DT_DEBUG > +".quad … [View More]

2 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel