- wine-devel - winehq.org

The future of the native theming support
by Ivan Akulinchev 27 Apr '16

27 Apr '16

So my GSoC proposal wasn't accepted this year. Probably it was my mistake by applying it too late, but this mail is not about this. Since a big research was already done, it would be fine to implement this feature anyway. The problem is that I still don't know what such people as Alexandre Julliard think about it. I got some positive feedback from normal users and even some Wine developers. However they don't make decisions about the Wine future and I don't want to spend my time if this feature will never get into upstream. As far as I know there already were some attempts to do something in this direction. But interesting patches I found in wine-patches were left without any response and Wine still looks like a monster from 90s. At the same time I see a lot of patches affecting the DirectX API. Is it the official position of the Wine maintainers to keep Wine as an OpenGL wrapper? Of course there are a lot of users who just want to play their Windows games on the Unix-like systems, but the need of working with normal desktop applications is still very high. There also were some questions about integrating new themes to the existing system. If it matters, I found a way to make it transparently for the end users. A new "GTK+" or even "Mac" theme can live together with old MSSTYLES themes without need of switching any "theme drivers" as it was said in my GSoC proposal. Regards, Ivan

4 8

Re: [PATCH 4/7] winex11.drv: elimininate the unnecessary XDND critical section
by Alexandre Julliard 27 Apr '16

27 Apr '16

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Everything happens on the UI thread, so there's no point in > doing any synchronization. What UI thread? Aren't the messages handled by the standard per-thread message loop? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] wininet/tests: Add more tests for INTERNET_INVALID_PORT_NUMBER. (resend)
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22619 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [4/5] wininet/tests: Add tests for asynchronous InternetReadFile. (v3)
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22618 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [2/5] wininet/tests: Add tests for asynchronous InternetReadFileEx. (v3)
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22617 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [2/6] wininet/tests: Add tests for asynchronous InternetReadFileEx.
by Jacek Caban 26 Apr '16

26 Apr '16

Hi Sebastian, On 04/25/16 21:41, Sebastian Lackner wrote: > + memset( &ib, 0, sizeof(ib) ); > + memset( buffer, 0, sizeof(buffer) ); > + ib.dwStructSize = sizeof(ib); > + for (count = 0; count < sizeof(buffer); count += ib.dwBufferLength) > + { > + ib.lpvBuffer = buffer + count; > + ib.dwBufferLength = sizeof(buffer) - count; > + > + SET_OPTIONAL( INTERNET_STATUS_RECEIVING_RESPONSE ); > + SET_OPTIONAL( INTERNET_STATUS_RESPONSE_RECEIVED ); > + > + ret = InternetReadFileExA( req, &ib, 0, 0xdeadbeef ); > + if (!ret) > + { > + ok( GetLastError() == ERROR_IO_PENDING, "expected ERROR_IO_PENDING, got %u\n", GetLastError() ); > + SET_EXPECT( INTERNET_STATUS_REQUEST_COMPLETE ); > + SetEvent( conn_wait_event ); > + WaitForSingleObject( hCompleteEvent, INFINITE ); > + ok( req_error == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %u\n", req_error ); > + CHECK_NOTIFIED( INTERNET_STATUS_REQUEST_COMPLETE ); > + } It's a nice way to force async read, but when you add tests with predictable reads it would be nice to take more advantage of that. What do you think about: - call InternetReadFileEx and check that it's done sync - call InternetReadFileEx and check that it's done async - set conn_wait_event, wait completion and make sure we read all remaining data - call InternetReadFileEx and make sure it synchronously hits the end of data Thanks, Jacek

2 5

Re: [6/6] wininet: Handle INTERNET_INVALID_PORT_NUMBER in HttpOpenRequest.
by Jacek Caban 26 Apr '16

26 Apr '16

Hi Sebastian, On 04/25/16 21:46, Sebastian Lackner wrote: > - request->server = get_server(session->hostName, session->hostPort, (dwFlags & INTERNET_FLAG_SECURE) != 0, TRUE); > + port = session->hostPort; > + if (port == INTERNET_INVALID_PORT_NUMBER) > + { > + port = (session->hdr.dwFlags & INTERNET_FLAG_SECURE) ? > + INTERNET_DEFAULT_HTTPS_PORT : INTERNET_DEFAULT_HTTP_PORT; > + } > + > + request->server = get_server(session->hostName, port, (dwFlags & INTERNET_FLAG_SECURE) != 0, TRUE); Note that get_server already has code to deal with INTERNET_INVALID_PORT_NUMBER, so it would be enough to handle https case there. However, given that all other callers have valid port numbers, I agree that it would be cleaner to do that in HTTP_HttpOpenRequestW instead. Given that your moving the logic around, please remove no longer needed code there. Thanks, Jacek

2 2

Re: [PATCH 2/5] qedit: Stub out AMTimelineObj.
by Andrew Eikum 26 Apr '16

26 Apr '16

On Mon, Apr 25, 2016 at 09:09:57PM -0600, Alex Henrie wrote: > @@ -129,8 +129,14 @@ static HRESULT WINAPI Timeline_IAMTimeline_CreateEmptyNode(IAMTimeline *iface, I > TIMELINE_MAJOR_TYPE type) > { > TimelineImpl *This = impl_from_IAMTimeline(iface); > - FIXME("(%p)->(%p,%04x): not implemented!\n", This, obj, type); > - return E_NOTIMPL; > + HRESULT hr; > + > + TRACE("(%p)->(%p,%04x)\n", This, obj, type); Any reason for the 04 width specifier here and elsewhere? AFAICT they're not shorts, but maybe I'm missing something. I'd rather print them with "0x%x". Andrew

2 2

Re: [5/5] wininet/tests: Add more tests for INTERNET_INVALID_PORT_NUMBER. (resend)
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22608 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [4/5] wininet/tests: Add tests for asynchronous InternetReadFile. (v2)
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22607 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [2/5] wininet/tests: Add tests for asynchronous InternetReadFileEx. (v2)
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22606 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [PATCH 2/5] qedit: Stub out AMTimelineObj.
by Nikolay Sivov 26 Apr '16

26 Apr '16

On 26.04.2016 6:09, Alex Henrie wrote: > Cc: Andrew Eikum <aeikum(a)codeweavers.com> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/qedit/Makefile.in | 3 +- > dlls/qedit/qedit_private.h | 2 + > dlls/qedit/tests/timeline.c | 3 - > dlls/qedit/timeline.c | 10 +- > dlls/qedit/timelineobj.c | 470 ++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 482 insertions(+), 6 deletions(-) > create mode 100644 dlls/qedit/timelineobj.c I think it's better to add this to timeline.c. > > diff --git a/dlls/qedit/timeline.c b/dlls/qedit/timeline.c > index 52123a7..0398f28 100644 > --- a/dlls/qedit/timeline.c > +++ b/dlls/qedit/timeline.c > @@ -129,8 +129,14 @@ static HRESULT WINAPI Timeline_IAMTimeline_CreateEmptyNode(IAMTimeline *iface, I > TIMELINE_MAJOR_TYPE type) > { > TimelineImpl *This = impl_from_IAMTimeline(iface); > - FIXME("(%p)->(%p,%04x): not implemented!\n", This, obj, type); > - return E_NOTIMPL; > + HRESULT hr; > + > + TRACE("(%p)->(%p,%04x)\n", This, obj, type); > + > + hr = AMTimelineObj_create(type, obj); > + if (FAILED(hr)) return hr; > + > + return S_OK; > } > You can simply 'return AMTimelineObj_create...;'. > + > +#include <assert.h> This one is not used. > +static ULONG WINAPI TimelineObj_inner_Release(IUnknown *iface) > +{ > + TimelineObjImpl *This = impl_from_IUnknown(iface); > + ULONG ref = InterlockedDecrement(&This->ref); > + > + TRACE("(%p) new ref = %u\n", This, ref); > + > + if (ref == 0) > + { > + CoTaskMemFree(This); > + return 0; > + } > + > + return ref; > +} Extra 'return 0;' does not add anything. > +HRESULT AMTimelineObj_create(TIMELINE_MAJOR_TYPE type, IAMTimelineObj **ppv) > +{ > + TimelineObjImpl* obj = NULL; No need to initialize it. > + > + TRACE("(%d,%p)\n", type, ppv); > + > + switch (type) > + { > + case TIMELINE_MAJOR_TYPE_COMPOSITE: > + case TIMELINE_MAJOR_TYPE_TRACK: > + case TIMELINE_MAJOR_TYPE_SOURCE: > + case TIMELINE_MAJOR_TYPE_TRANSITION: > + case TIMELINE_MAJOR_TYPE_EFFECT: > + case TIMELINE_MAJOR_TYPE_GROUP: > + break; > + default: > + return E_INVALIDARG; > + } What happens to returned pointer on type error? > + > + obj = CoTaskMemAlloc(sizeof(TimelineObjImpl)); > + if (NULL == obj) { > + *ppv = NULL; > + return E_OUTOFMEMORY; > + } > + ZeroMemory(obj, sizeof(TimelineObjImpl)); > + > + obj->ref = 1; > + obj->IUnknown_inner.lpVtbl = &timelineobj_vtbl; > + obj->IAMTimelineObj_iface.lpVtbl = &IAMTimelineObj_VTable; > + > + *ppv = &obj->IAMTimelineObj_iface; > + return S_OK; > +} > memset is not useful, you're setting all the fields anyway. Also, why do you need inner IUnknown for this object?

3 2

Re: kernel32/tests: Add initial tests for GetConsoleFontInfo (v3)
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22597 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 1511506268 console.c:1445: Test failed: [15] Expected output count to be 0, got 1511506268 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1511506268 console.c:1689: Test failed: [13] Expected output count to be 0, got 1511506268 console.c:1689: Test failed: [15] Expected output count to be 0, got 1511506268 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1511506268 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2670708688 console.c:1445: Test failed: [15] Expected output count to be 0, got 2670708688 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2670708688 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2670708688 console.c:1689: Test failed: [15] Expected output count to be 0, got 2670708688 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2670708688 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 795528606 console.c:1445: Test failed: [15] Expected output count to be 0, got 795528606 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 795528606 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 795528606 console.c:1689: Test failed: [15] Expected output count to be 0, got 795528606 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 795528606 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Windows 2000 VM timing out
by Hugh McMaster 26 Apr '16

26 Apr '16

The Windows 2000 VM is timing out with the following dialog message: kernel32_test.exe - Entry Point Not Found The procedure entry point InitializeSListHead could not be located in the dynamic link library kernel32.dll. For a screenshot, see https://testbot.winehq.org/JobDetails.pl?Key=22547&log_201=1&scrshot_201=1#… I'm not sure what the cause is. I sent a patch modifying a comment by one character and the same error occurs.

4 6

Re: [PATCH] winemac: Implement the WGL_WINE_query_renderer extension.
by Henri Verbeet 26 Apr '16

26 Apr '16

On 26 April 2016 at 10:29, Ken Thomases <ken(a)codeweavers.com> wrote: > + case WGL_RENDERER_UNIFIED_MEMORY_ARCHITECTURE_WINE: > + /* FIXME: not sure what this means */ Mostly whether the GPU has its own dedicated video memory that's not directly accessible by the CPU, or instead shares the memory between the CPU and GPU. > + case WGL_RENDERER_VERSION_WINE: > + /* FIXME: anything better we can return? */ If the driver doesn't have its own version number, the next best thing is probably the OS version number. This typically matches the final part of the GL_VERSION string.

4 4

Re: [PATCH v4 4/6] d3d11/tests: Add tests for 2D texture RTVs.
by Henri Verbeet 26 Apr '16

26 Apr '16

On 25 April 2016 at 12:25, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + hr = ID3D11Device_CreateBuffer(device, &buffer_desc, NULL, &context->ps_cb); > + ok_(__FILE__, line)(SUCCEEDED(hr), "Failed to create constant buffer, hr %#x.\n", hr); > + } > + > + ID3D11DeviceContext_PSSetShader(context->immediate_context, context->ps, NULL, 0); > + ID3D11DeviceContext_PSSetConstantBuffers(context->immediate_context, 0, 1, &context->ps_cb); > + > + ID3D11DeviceContext_UpdateSubresource(context->immediate_context, (ID3D11Resource *)context->ps_cb, 0, > + NULL, color, 0, 0); There isn't anything wrong with doing it like this, but note that you could also specify the initial contents when creating the buffer.

1 0

Re: [v3 PATCH 1/3] ucrtbase: Implement _initialize_onexit_table()
by Sebastian Lackner 26 Apr '16

26 Apr '16

On 26.04.2016 07:52, Nikolay Sivov wrote: > diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec > index a54a71a..96e0c3b 100644 > --- a/dlls/ucrtbase/ucrtbase.spec > +++ b/dlls/ucrtbase/ucrtbase.spec > @@ -419,7 +419,7 @@ > @ cdecl _i64tow(int64 ptr long) ntdll._i64tow > @ cdecl _i64tow_s(int64 ptr long long) MSVCRT__i64tow_s > @ cdecl _initialize_narrow_environment() > -@ stub _initialize_onexit_table > +@ cdecl _initialize_onexit_table() MSVCRT__initialize_onexit_table Did you accidentally send an old version?

1 0

Wine Smart Card handle
by Szili Péter 26 Apr '16

26 Apr '16

Hi I using Scard4Wine patch ( http://www.winehq.org/pipermail/wine-devel/2007-April/056432.html ) on Suse Leap 42.1 x64 and Ubuntu 16.04 desktop x86, and my Delphi 7 application, with wine. ( This is test sample program, which tests the smart card reader) http://www.topemail.hu/src/SCardSample.tar.gz Each of the two systems is the same problem: Delphi LoadLibrary() function can not load the winscard.dll. The patch replaces the under linux the /usr/lib/wine/winscard.dll.so With original winscard.dll.so can load the LoadLibrary(). Can someone idea of how the new winscard.dll.so could be used ? Best regards: Szili Péter szilipeter(a)topemail.hu ****************************

1 0

Re: [PATCH 2/2] inetcomm: Implement IMimeBody GetProp
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22590 Your paranoid android. === wvistau64 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 779e9075 mimeole.c:390: Test failed: Invalid encoding 3 === w2008s64 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 77009075 mimeole.c:390: Test failed: Invalid encoding 3 === w7pro64 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 2c0000 mimeole.c:388: Test failed: Invalid flags 0x2c0000 mimeole.c:390: Test failed: Invalid encoding 3 === w864 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 9 mimeole.c:388: Test failed: Invalid flags 0x9 mimeole.c:389: Test failed: Invalid row number 32757 mimeole.c:390: Test failed: Invalid encoding 3 === w1064 (64 bit mimeole) === mimeole.c:387: Test failed: Invalid mask 0x 5f8400 mimeole.c:388: Test failed: Invalid flags 0x5f8400 mimeole.c:390: Test failed: Invalid encoding 3

1 0

Re: [PATCH 1/2] inetcomm: Implement IMimeBody SetProp
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22589 Your paranoid android. === wvistau64 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 779e9075 mimeole.c:381: Test failed: Invalid encoding 3 === w2008s64 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 77009075 mimeole.c:381: Test failed: Invalid encoding 3 === w7pro64 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 510000 mimeole.c:379: Test failed: Invalid flags 0x510000 mimeole.c:381: Test failed: Invalid encoding 3 === w864 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 9 mimeole.c:379: Test failed: Invalid flags 0x9 mimeole.c:380: Test failed: Invalid row number 32757 mimeole.c:381: Test failed: Invalid encoding 3 === w1064 (64 bit mimeole) === mimeole.c:378: Test failed: Invalid mask 0x 5d7410 mimeole.c:379: Test failed: Invalid flags 0x5d7410 mimeole.c:381: Test failed: Invalid encoding 3

1 0

RFC: gdi32: add a [fonts] section to win.ini
by Austin English 26 Apr '16

26 Apr '16

This patch is for https://bugs.winehq.org/show_bug.cgi?id=33492, already tested as working. I wanted to send for review first, as I'm not sure if this is the best approach or if someone has a better idea for how to handle it. Thanks, -- -Austin

2 2

Re: [PATCH] shell32: Add SHLimitInputEdit stub.
by Nikolay Sivov 26 Apr '16

26 Apr '16

On 26.04.2016 6:13, Alex Henrie wrote: > Needed for Windows Movie Maker 2.6. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/shell32.spec | 1 + > dlls/shell32/shlfolder.c | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/dlls/shell32/shell32.spec b/dlls/shell32/shell32.spec > index 93fd449..7ebd032 100644 > --- a/dlls/shell32/shell32.spec > +++ b/dlls/shell32/shell32.spec > @@ -264,6 +264,7 @@ > 727 stdcall SHGetImageList(long ptr ptr) > 730 stdcall -noname RestartDialogEx(long wstr long long) > 743 stdcall SHCreateFileExtractIconW(wstr long ptr ptr) > + 747 stdcall SHLimitInputEdit(ptr ptr) > Does it actually need explicit ordinal?

2 2

Re: [PATCH 3/5] qedit: Implement IAMTimelineObj_GetTimelineType and add tests.
by Nikolay Sivov 26 Apr '16

26 Apr '16

On 26.04.2016 6:09, Alex Henrie wrote: > static HRESULT WINAPI TimelineObj_GetTimelineType(IAMTimelineObj *iface, TIMELINE_MAJOR_TYPE *type) > { > TimelineObjImpl *This = impl_from_IAMTimelineObj(iface); > - FIXME("(%p)->(%p): not implemented!\n", This, type); > - return E_NOTIMPL; > + TRACE("(%p)->(%p)\n", This, type); > + *type = This->timeline_type; > + return S_OK; > } Is it supposed to handle NULL input?

2 1

Re: [6/6] wininet: Handle INTERNET_INVALID_PORT_NUMBER in HttpOpenRequest.
by Marvin 25 Apr '16

25 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22569 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [5/6] wininet/tests: Add more tests for INTERNET_INVALID_PORT_NUMBER.
by Marvin 25 Apr '16

25 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22568 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [4/6] wininet/tests: Add tests for asynchronous InternetReadFile.
by Marvin 25 Apr '16

25 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22567 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [2/6] wininet/tests: Add tests for asynchronous InternetReadFileEx.
by Marvin 25 Apr '16

25 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22566 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

3 2

Re: [v2 PATCH 1/3] ucrtbase: Implement _initialize_onexit_table()
by Piotr Caban 25 Apr '16

25 Apr '16

On 04/24/16 20:51, Nikolay Sivov wrote: > dlls/ucrtbase/tests/onexit.c | 114 +++++++++++++++++++++ Probably we don't need a separate file just for these tests. Could you please put them into a file with more generic name so it can be used for other tests in future. > + memset(&table, 0, sizeof(table)); > + ret = p_initialize_onexit_table(&table); > + ok(ret == 0, "got %d\n", ret); > + ok(table._first == table._last && table._first == table._end, "got first %p, last %p, end %p\n", > + table._first, table._last, table._end); > +todo_wine > + ok(table._first != NULL, "got %p\n", table._first); We probably don't need to be binary compatible but native uses following algorithm (x - random number, 32-bit version): void* encode_ptr(void *p) { DWORD r = (DWORD)p; r = _rotl(r, x); return r^x; } void* decode_ptr(void *p) { DWORD r = (DWORD)p; r = r^x; return _rotr(r, x); } In theory this test may fail if x happens to be 0. Thanks, Piotr

2 1

Re: msvcrt: The fpclass() constants are not defines.
by Piotr Caban 25 Apr '16

25 Apr '16

Hi, I don't know how to review this patch. Alexandre, could you please take a look on it? For me the patch may go in and if it causes any problems configure check may be added. I guess we no longer care about the compiler it was added for. Thanks, Piotr

1 0

Re: shell32/tests: Tests for broken apps that check GetLastError() after SHFileOperation()
by Marvin 25 Apr '16

25 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22483 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:297: Test failed: SHGetFileInfoA(test4.txt/) should return 1, got 0x0 shlfileop.c:2455: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2464: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2468: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2471: Test failed: does not end with .lnk shlfileop.c:83: Test failed: Failure to open file shlfileop.c:2477: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2481: Test failed: Y does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2484: Test failed: Y does not end with .lnk === wvistau64 (64 bit shlfileop) === shlfileop.c:297: Test failed: SHGetFileInfoA(test4.txt/) should return 1, got 0x0 shlfileop.c:2455: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2464: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2468: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2471: Test failed: does not end with .lnk shlfileop.c:83: Test failed: Failure to open file shlfileop.c:2477: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2481: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2484: Test failed: does not end with .lnk shlfileop.c:2486: Test failed: and are the same

2 1

Re: [v2 PATCH 2/3] ucrtbase: Implement _register_onexit_function()
by Piotr Caban 25 Apr '16

25 Apr '16

On 04/24/16 20:51, Nikolay Sivov wrote: > + len = table->_end - table->_first; > + > + /* grow if full */ > + if (table->_last == table->_end) > + { > + table->_first = MSVCRT_realloc(table->_first, 2 * len * sizeof(void *)); > + table->_end = table->_first + 2 * len; > + table->_last = table->_first + len; > + } Please move len initialization/definition into the if block. Also please handle allocation failure. Thanks, Piotr

1 0

Re: [PATCH] hidclass.sys: add missing case/missing heapfree (Coverity)
by Aric Stewart 25 Apr '16

25 Apr '16

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> On 4/23/16 1:03 PM, Marcus Meissner wrote: > 1358558 Resource leak > > (actually switch on the enum, then the compiler will see missing cases) > > 2nd try, also use variable in debug directly > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/pnp.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/dlls/hidclass.sys/pnp.c b/dlls/hidclass.sys/pnp.c > index d97184f..87b19ac 100644 > --- a/dlls/hidclass.sys/pnp.c > +++ b/dlls/hidclass.sys/pnp.c > @@ -292,10 +292,9 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) > case IRP_MN_QUERY_ID: > { > BASE_DEVICE_EXTENSION *ext = device->DeviceExtension; > - ULONG type = irpsp->Parameters.QueryId.IdType; > WCHAR *id = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(WCHAR)*REGSTR_VAL_MAX_HCID_LEN); > - TRACE("IRP_MN_QUERY_ID[%i]\n", type); > - switch (type) > + TRACE("IRP_MN_QUERY_ID[%i]\n", irpsp->Parameters.QueryId.IdType); > + switch (irpsp->Parameters.QueryId.IdType) > { > case BusQueryHardwareIDs: > case BusQueryCompatibleIDs: > @@ -326,6 +325,10 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) > irp->IoStatus.Information = (ULONG_PTR)id; > rc = STATUS_SUCCESS; > break; > + case BusQueryDeviceSerialNumber: > + FIXME("BusQueryDeviceSerialNumber not implemented\n"); > + HeapFree(GetProcessHeap(), 0, id); > + break; > } > break; > } >

1 0

Re: kernel32: Print a FIXME only once in LCMapStringEx
by Andrew Eikum 25 Apr '16

25 Apr '16

On Mon, Apr 25, 2016 at 04:58:55PM +0200, Louis Lenders wrote: > diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c > index 7418da9..8901870 100644 > --- a/dlls/kernel32/locale.c > +++ b/dlls/kernel32/locale.c > @@ -2974,10 +2974,13 @@ INT WINAPI LCMapStringEx(LPCWSTR name, DWORD flags, LPCWSTR src, INT srclen, LPW > LPNLSVERSIONINFO version, LPVOID reserved, LPARAM lparam) > { > LPWSTR dst_ptr; > + static int once; > > if (version) FIXME("unsupported version structure %p\n", version); > if (reserved) FIXME("unsupported reserved pointer %p\n", reserved); > - if (lparam) FIXME("unsupported lparam %lx\n", lparam); > + > + if (!once++) > + if (lparam) FIXME("unsupported lparam %lx\n", lparam); I think you got the if statements backwards here. You should print the first time lparam is non-zero, not only if it's non-zero on the first LCMapStringEx call. Andrew

1 0

Re: Wine 1.8.1
by Michael Stefaniuc 25 Apr '16

25 Apr '16

Hello Berto, On 04/25/2016 04:13 PM, Berto Niker wrote: > How do I install Wine 1.8.1 in Ubuntu (Xenial and Trusty)? I added the current Stable version is 1.8.2 already. > repository and it only has 1.8.0. Wine Stable is not part yet of the repositories provided by winehq.org. It is planned though. > I am not interested in the development build 1.9.x. I do not want to > worry about things breaking every two weeks. Sure, that's the reason we do Wine Stable. bye michael

1 0

Re: [PATCH 6/6] ddraw/tests: Test creating flippable cubemaps.
by Bruno Jesus 25 Apr '16

25 Apr '16

On Mon, Apr 25, 2016 at 12:25 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/ddraw/surface.c | 2 ++ > dlls/ddraw/tests/ddraw7.c | 50 Hi, the subject says you are adding tests but you also change dll source, was it a leftover? Or maybe the subject should be changed to reflect the source change IMO.

2 1

Re: [PATCH 6/6] ddraw/tests: Test creating flippable cubemaps.
by Marvin 25 Apr '16

25 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22544 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: Experimental 64 bit OS X packages ready for testing
by Diego Vicioso 25 Apr '16

25 Apr '16

Any updates if it will be included into normal wine or future wine staging packages? Sent from my mac

2 1

Re: [PATCH] kernel32/tests: Add initial tests for GetConsoleFontInfo (v2)
by Sebastian Lackner 25 Apr '16

25 Apr '16

On 22.04.2016 15:21, Hugh McMaster wrote: > Changes since v1: Use CONSOLE_FONT_INFO instead of undocumented CONSOLE_FONT. > The structure is identical. > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > dlls/kernel32/tests/console.c | 57 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > You'll have to add a stub first, otherwise it breaks the tests: $ (cd dlls/kernel32/tests/; make console.ok) ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe.so console && touch console.ok fixme:console:GetConsoleProcessList ((nil),0): stub fixme:console:GetConsoleProcessList ((nil),1): stub fixme:console:GetConsoleProcessList (0x118ca0,0): stub fixme:console:GetConsoleProcessList (0x118ca0,1): stub fixme:console:GetConsoleProcessList (0x118ca0,0): stub fixme:console:SetConsoleFont (0x63, 0): stub! fixme:console:SetConsoleFont (0x63, 0): stub! wine: Call from 0x7b43b8a2 to unimplemented function KERNEL32.dll.GetConsoleFontInfo, aborting wine: Unimplemented function KERNEL32.dll.GetConsoleFontInfo called at address 0x7b43b8a2 (thread 0009), starting debugger...

2 2

Re: Fix a heap corruption when printing specific REG_MULTI_SZ values.
by Hugh McMaster 25 Apr '16

25 Apr '16

On Saturday, 23 April 2016 3:35 AM, Sebastian Lackner wrote: >The current calculation does not take the terminating \0 into account. > -buffer = HeapAlloc(GetProcessHeap(), 0, tmp_size * 2); > +buffer = HeapAlloc(GetProcessHeap(), 0, tmp_size * 2 + sizeof(WCHAR)); Which particular cases cause the heap corruption? -- Hugh McMaster

2 4

Re: [PATCH 3/4] d3drm/tests: Replace test_Texture. (v2)
by Stefan Dösinger 25 Apr '16

25 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-04-24 um 16:50 schrieb Aaryaman Vasishta: > + hr = IDirect3DRMTexture_GetClassName(texture1, &size, cname); > + ok(hr == E_INVALIDARG, "GetClassName failed with %x\n", hr); > + ok(size == sizeof("Texture") - 1, "wrong size: %u\n", size); > + ok(!strcmp(cname, "Texture"), "Expected cname to be \"Texture\", but got \"%s\"\n", cname); The strcmp check here is misleading. The content is a leftover from the previous successful call. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXHSYsAAoJEN0/YqbEcdMwVzUQAI5igH0GyGwby4/FQMWpOaDl gXwxyST6BOhwnMfSNSdY/yFT0WqgLxm23+uE1fDsApaENRTEn1JzfSC8/DzeSeEd KHv4QU2KeHlRtLl01CWJclwGgwgdCaP1b1+8mSzxXtWgfjZ2RRtGJON4STzDqLvt G8DYYKJVEAgGQXq2o4N0ZtqRJmmOyOY9iR6Etwz1SoUOe3PgKHwbHEeAJ9YmbbzV zJKkYxdEjuRcyO6Z5xXb5XLV2OBdYD/pqYPMwodQWfJIaht0Ui2GYrSI7Tw1b+DL d/B6M6gYfYm9DAivlL5DflZoyLI4OIm95BRmOgtJZ3EY+qsR0UPuHEybCZnzy0u5 0qQNTGs4+sWecIcFQMmtOqj5wcesV0XPLiRr3nAPMuuIaiBNO3Yyvxu2f/KyLIEa 3E3u6HmJtnyLJPK1btsc1mjsr21LpBA2sQ2AXYV/9wfQyIBhKUdk9gsC9lYNQEvm eVRCtTg4BDIUTxze8lXGqslyio/5IEPr1dX0suX5Rj61tpcDgp6C1MdSiHZkliM3 dTuk7Wu3dfdXCAZfGS/J+QfoQfXwP6NqYhIx6bzY48XGeL/N+m9rGC2lG1mMVROu xW5lgCuZ5/Vt2Z7+qzfEVuI0HxQ+cXO86IEq1RClvszje+1stblLpTQDrAg/hy6G X1q4jNhSjnxRP6Q0r2Ls =39F6 -----END PGP SIGNATURE-----

2 3

Re: [PATCH 2/2] ucrtbase: Implement _register_onexit_function()
by Sebastian Lackner 24 Apr '16

24 Apr '16

On 24.04.2016 20:05, Nikolay Sivov wrote: > + table->_first = MSVCRT_calloc(sizeof(void *), 32); Not really an issue, but shouldn't the first argument be the counter, and the second one the size?

2 1

Re: [PATCH 1/2] ucrtbase: Implement _initialize_onexit_table()
by Sebastian Lackner 24 Apr '16

24 Apr '16

On 24.04.2016 20:05, Nikolay Sivov wrote: > diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec > index a54a71a..96e0c3b 100644 > --- a/dlls/ucrtbase/ucrtbase.spec > +++ b/dlls/ucrtbase/ucrtbase.spec > @@ -419,7 +419,7 @@ > @ cdecl _i64tow(int64 ptr long) ntdll._i64tow > @ cdecl _i64tow_s(int64 ptr long long) MSVCRT__i64tow_s > @ cdecl _initialize_narrow_environment() > -@ stub _initialize_onexit_table > +@ cdecl _initialize_onexit_table() MSVCRT__initialize_onexit_table Shouldn't there be one "ptr" argument? Same for the other spec files. > @ cdecl _initialize_wide_environment() > @ cdecl _initterm(ptr ptr) > @ cdecl _initterm_e(ptr ptr) >

1 0

Re: [PATCH 1/4] d3drm: Use sizeof instead of strlen in d3drm_texture3_GetClassName.
by Nikolay Sivov 24 Apr '16

24 Apr '16

On 24.04.2016 18:50, Aaryaman Vasishta wrote: > This size of class name turns out to be equal to sizeof("Texture") which is strlen("Texture") + 1. This was recently discovered while testing the size returned by GetClassName. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/texture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3drm/texture.c b/dlls/d3drm/texture.c > index f81fc03..60374d3 100644 > --- a/dlls/d3drm/texture.c > +++ b/dlls/d3drm/texture.c > @@ -796,7 +796,7 @@ static HRESULT WINAPI d3drm_texture3_GetClassName(IDirect3DRMTexture3 *iface, DW > { > TRACE("iface %p, size %p, name %p.\n", iface, size, name); > > - if (!size || *size < strlen("Texture") || !name) > + if (!size || *size < sizeof("Texture") || !name) > return E_INVALIDARG; > > strcpy(name, "Texture"); > GetClassName() is duplicated for every object, it makes sense to introduce a helper function eventually.

2 1

Re: [PATCH 2/3] d3drm/tests: Replace test_Texture.
by Stefan Dösinger 24 Apr '16

24 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-04-24 um 06:40 schrieb Aaryaman Vasishta: > + size = 1; > + hr = IDirect3DRMTexture_GetClassName(texture1, &size, cname); > + ok(hr == E_INVALIDARG, "GetClassName failed with %x\n", hr); > + size = sizeof(cname); > + hr = IDirect3DRMTexture_GetClassName(texture1, &size, cname); > + ok(SUCCEEDED(hr), "Cannot get classname (hr = %x)\n", hr); > + ok(size == sizeof("Texture"), "wrong size: %u\n", size); sizeof("Texture") is confusing IMHO. I had to look up the C rules on string literals to make sure it does what you want :-) . Though I'm not sure if its better than strlen("Texture") + 1, so it's your call. However, the current implementation in d3drm_texture3_GetClassName confuses the two. I recommend adding a test for sizeof("Texture") - 1 and an exactly matching size. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXHJxZAAoJEN0/YqbEcdMwMAkP/0JEXejefj/awhnJGh5zQlg9 07gvcDjH+KvsHYbJsWOA8GE3+JcUJrqpHA8nqO2Uxmy1mg26EECNtRFTjfWJ4oQM iHcVgVurTb6rx6UZpcLkoy/BQ4fvWQFtWxfL2J9ZDO2TVt+0oeGSurkv5ywylTmq 5RZa5lFhnaeMyWw6hbtXNwsPXMhi+tDdHZTYVakJGRa72deO23ZrWuzbHzMfnlDx /SnGnSnFF9JcWLkLQMqeiQ+Q2Ztn+PHo15EjAye3hk1gvVYKx5xx7+Hef9l4/1dG Cqc2I+4GwE86FmrBkqT1noF6HDo4+6evHi+JrW6d0WFH7I/k3D+5SUtaqtBRtraC AuS4Kwsqri4wpVeqz6zsX8BsneQHQzkB87EXEC81d7W6fTPAYT1YoQp2zDPxP32G lIwd3bxtdyYA91dNTCGx8arKEpBXhuKqh0ahI8FrRBiuZ20JVIvosiVBxpWHYsiV 9X3smnaiYrL6sZTPtbcHbcs5shbuycpzm05EB5noSbc+P6ur5/q4Q9nSH86OYAIr mJBZWg6pE9N1zcko6KTmB//z7NGYms8knxVQYGVgtRgZaNk8+mVaeedgdbnrIMFj xsdTX8UGtOAs7mJ6E496xq4P7bMxK5B0BSoChtaJV3ZeS9wLD/JId/1Z7l/DvVwn 0EDb2DPmwv7EbEWz7cAH =MI19 -----END PGP SIGNATURE-----

2 2

Re: [PATCH 3/3] d3drm/tests: Add tests for IDirect3DRMTexture{2-3}_InitFromImage. (v2)
by Stefan Dösinger 24 Apr '16

24 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, I think it'd be a good idea to add some lines testing InitFromImage on a texture that was created with CreateTexture and trying to call InitFromImage twice (with the first call succeeding). Am 2016-04-24 um 06:46 schrieb Aaryaman Vasishta: > + /* InitFromImage tests */ > + d3drm_img = NULL; > + hr = IDirect3DRM2_CreateObject(d3drm2, &CLSID_CDirect3DRMTexture, NULL, &IID_IDirect3DRMTexture2, (void **)&texture2); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture2 interface (hr = %x).\n", hr); > + ref2 = get_refcount((IUnknown *)texture2); Did you forget IDirect3DRM::CreateObject(Texture1), or is there a reason why it is omitted? > + hr = IDirect3DRMTexture2_InitFromImage(texture2, NULL); > + todo_wine ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %x.\n", hr); > + ref3 = get_refcount((IUnknown *)texture2); > + ok(ref3 == ref2, "expected ref3 == ref2, got ref2 = %u , ref3 = %u.\n", ref2, ref3); You're not testing the reference count of d3drm1/2/3. My guess is that you plan to add this later since the InitFrom() increments it, and not the create. Is my understanding of your plans correct? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXHJtCAAoJEN0/YqbEcdMwAhgQAJXR10NMu88OEslWcX2iUSSg rUXk7WcCaQVHHlGFwQwddtFLrX245idLScYxm8N9CvG3kyHxx91tQ3UH6wT+QHAv No6IuMc0menrh1g2mP08/Ci44sd7Hy01HS7K8A9+/rdwUnIhb3pYiAxB8673/7he ruXnPpYY/Mhi+8I1BAQA17qy5rArUFQWHGoth+18PnPdI9VELKlkZg0Y8R/ITqdu jgLkw1zKsKZS17qvwTyz+lyxmhC2mAjIMQu/WD/lVZOwXPTFUmSqPfUke6nyTFfA ffJL16e9C5CpyD+dCT+Rc3AUoboBo+JrQz4Qif4xOW+LhNY7fZeqt4f1Pd7+Zxqe X3sr7jVDTJY3d//bWy7eW1Ow7zixawhsWXa0cj6Z6TuIV4ruMvOK6QpZ2qb1IvmS BCTGoRI6DYF6bRDZLCirbz4nOB8CNTtO+erLhh5uHCP8wtN1eYC3/5rSjGjJACrT IBQ7g/l45/oiCkmVLug5kxUqgXXX0GoVbrod0MiBd0snDMwmev1T+xNHFdsfR9La 8AKBVF6eH3FqRo0Co6PGIvgKkk0ItuAUBPFkrvaREnzTwQO5XrSbCA54FeM8YFn3 FZH9ePNGENyWJD98SI1Laluw/9GiAusQynkJALSen9Aqm1pfhfH2OSuxaFqg0IfW vl8vPREqFJGtCGx9fQU/ =FjQh -----END PGP SIGNATURE-----

2 1

Wine inside Xephyr on OSX
by Bruno Jesus 23 Apr '16

23 Apr '16

Hi, all. In Debian I have been using Xephyr to test some applications when virtual desktop is not enough, so far so good. Now I was trying to do the same in an OSX, so I have opened Xephyr and DISPLAY=:2 xeyes work but Wine windows are not created inside the Xephyr window as if the DISPLAY is completely ignored. Is there any way to make this work? Best wishes, Bruno

3 5

Re: [PATCH] d3dx10: Implement D3DX10UnsetAllDeviceObjects()
by Marvin 23 Apr '16

23 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22481 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 6/8] ddraw: Return early in d3d_device7_DrawIndexedPrimitiveVB() with a 0 vertex or index count.
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22465 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 5/8] ddraw: Return early in d3d_device7_DrawPrimitive() with a 0 vertex count.
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22464 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 4/8] ddraw: Return early in d3d_device7_DrawPrimitiveStrided() with a 0 vertex count.
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22463 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel