- wine-devel - winehq.org

Re: [PATCH 1/2] oledb32: Support VARIANT(VT_NULL)->DBTYPE_WSTR in GetConversionSize
by Michael Stefaniuc 08 Oct '15

08 Oct '15

Alistair, On 10/08/2015 11:06 AM, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/oledb32/convert.c | 2 ++ > dlls/oledb32/tests/convert.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/dlls/oledb32/convert.c b/dlls/oledb32/convert.c > index a92369f..21938aa 100644 > --- a/dlls/oledb32/convert.c > +++ b/dlls/oledb32/convert.c > @@ -1416,6 +1416,8 @@ static HRESULT WINAPI convert_GetConversionSize(IDataConvert* iface, > case DBTYPE_VARIANT: > if(V_VT((VARIANT*)src) == VT_BSTR) > *dst_len = (SysStringLen(V_BSTR((VARIANT*)src))+1) * sizeof(WCHAR); > + else if(V_VT((VARIANT*)src) == VT_NULL) > + *dst_len = 110; what is the magic number 110? I looked at the surrounding code but I don't see any other magic numbers assigned to dst_len. bye michael

2 1

Re: [v3 09/10] wined3d: don't pass a wined3d_volume to device_volume_created callback anymore
by Henri Verbeet 07 Oct '15

07 Oct '15

On 6 October 2015 at 10:36, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h > index a354308..f1ead48 100644 > --- a/include/wine/wined3d.h > +++ b/include/wine/wined3d.h > @@ -2034,7 +2034,7 @@ struct wined3d_device_parent_ops > struct wined3d_surface *surface, void **parent, const struct wined3d_parent_ops **parent_ops); > HRESULT (__cdecl *volume_created)(struct wined3d_device_parent *device_parent, > struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx, > - struct wined3d_volume *volume, void **parent, const struct wined3d_parent_ops **parent_ops); > + void **parent, const struct wined3d_parent_ops **parent_ops); I think you should be able to remove the forward declaration of struct wined3d_volume as well now.

2 1

Re: [v3 06/10] d3d9: make use of wined3d_texture_map in d3d9_volume_LockBox
by Henri Verbeet 07 Oct '15

07 Oct '15

On 6 October 2015 at 10:36, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index eb4a0fc..e5111ab 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -2335,6 +2335,8 @@ void wined3d_volume_get_pitch(const struct wined3d_volume *volume, UINT *row_pit > void wined3d_volume_load(struct wined3d_volume *volume, struct wined3d_context *context, > BOOL srgb_mode) DECLSPEC_HIDDEN; > void wined3d_volume_invalidate_location(struct wined3d_volume *volume, DWORD location) DECLSPEC_HIDDEN; > +HRESULT wined3d_volume_map(struct wined3d_volume *volume, > + struct wined3d_map_desc *map_desc, const struct wined3d_box *box, DWORD flags); This needs DECLSPEC_HIDDEN. Applies to patch 7/10 as well.

1 0

RE: [PATCH 1/2] reg: simplify root key search
by Michel Zou 07 Oct '15

07 Oct '15

Hi, These two patches correspond to the 1/4 commit by jnvsor in a preliminary work to add reg query functionality: https://github.com/jnvsor/wine/commits/reg.exe I split this commit in two after the review from Stefan Dösinger. I did not want to submit all at once because it seems pretty hard to get patches accepted. M. > Subject: Re: [PATCH 1/2] reg: simplify root key search > To: wine-patches(a)winehq.org > From: stefandoesinger(a)gmail.com > Date: Mon, 5 Oct 2015 11:42:15 +0200 > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am 2015-10-04 um 21:14 schrieb Michel Zou: > > From: Jonathan Vollebregt <jnvsor(a)gmail.com> > > > > Signed-off-by: Michel Zou <xantares09(a)hotmail.com> > Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBCAAGBQJWEkX3AAoJEN0/YqbEcdMwOx8P/RgHK3cBvTiTegMwxWil8zin > BkTP/Lq7hQjXBP5fOKhpysT6KgtXCqvif9h9gEIJkePszPQurcQrAR6DDwzS+dqT > pHWqwIBwktePQP3bo7Xb0zwWRAePe/KAf80EUF4Vj1sFmQpOExS2SzCPbLylSyle > UlIZfV4LzOMf2rqn70h0p7i+eFymUcRs8Ocejwf6llM9B/M6ETT3+PJ600rOcpYJ > a+/+oJasmBQZTyhOr2xtJe9ZctmmldCIufjH9OYpkkTiSf+fNekbBh6T7Sd1VM0q > 7KxuanloX1RJ33IZUbnaeMi4XPjYGkXwN07Y0Qoz/KbIAqsLqjs6ZX4a7zRttH/R > TiBvk8G5KgOLSA3CGk764krIAT4BhLae1sIV2BdjGnz8LXarRLY442+srLPOW5ko > F5y34SGaSjV90+K27yiAfg/HLMYa6DvT+dqU7K/+jokkir3hl87Hz2mRpWRA2Gge > 5oH4UHnrOXqOzxnmZMvhmMtteEZ7XyCtF97r+Hv1l9XDFY4eVKQMEZN0pMDIwvSx > lIvKRmQyce9RV4XAo1zsYwUFmWBjbiEDouhylgjYMp1yean7+wP6pZDxnmJ6SIxF > w6WXd2+V16rts61joPqXoXndpmPXH1SJINu69v+3YKaTFCeQF1gbGlpf/G9nM85P > 3JmJVKAKRId0MJAKIJZq > =Lqx3 > -----END PGP SIGNATURE----- > >

1 0

Re: [PATCH 3/5] ws2_32: Implement a basic synchronous TransmitFile.
by Alexandre Julliard 07 Oct '15

07 Oct '15

"Erich E. Hoover" <erich.e.hoover(a)wine-staging.com> writes: > This patch adds support for the basic file-transfer operation of > TransmitFile. It uses NtReadFile to obtain "bytes_per_send" chunks of > the file, which it then sends to the destination using WS2_send. NtReadFile potentially allocates memory, you can't use it in an async I/O callback. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v3 03/10] wined3d: pass wined3d_texture and sub_resource idx to device_volume_created callback
by Henri Verbeet 07 Oct '15

07 Oct '15

On 6 October 2015 at 10:36, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > Store wined3d_texture and sub_resource in d3d8_volume. > Updated the d3d8_volume_LockBox to make use of wined3d_texture_map. > Also updated d3d9, d3d11, ddraw callbacks accordingly > --- This is mostly fine, although "d3d8: Use wined3d_texture_map() in d3d8_volume_LockBox()." would perhaps have been more appropriate as a subject, since the callback change is just a side-effect. The d3d9 volume_init() change could have been deferred until patch 6/10 and would perhaps been more appropriate there, but it doesn't matter too much.

2 3

Signed-off-by support
by Alexandre Julliard 07 Oct '15

07 Oct '15

Folks, As a first step of the implementation of the WineConf decisions, the patch tracker now supports Signed-off-by. You can see the list of people who have signed off on a patch by hovering over the signed-off checkmark in the tracker. In general, people who are listed in the MAINTAINERS file should sign off on other people's patches that touch their area. I'll be working next on implementing a more formal mechanism for assigning reviewing responsibility. To add your sign-off to a patch that you have approved, you need to send a reply to wine-patches with your Signed-off-by header. If you find this inconvenient, I'm open to adding other mechanisms; suggestions are welcome. Finally, starting next week I'm going to require patch authors to include a proper Signed-off-by header on all patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3 v3 resend] user32: Implement semi-stub for FlashWindowEx.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17092 Your paranoid android. === w8 (32 bit win) === win.c:3418: Test failed: hwnd 00030114 message 0118 === w864 (32 bit win) === win.c:3418: Test failed: hwnd 00030192 message 0118 === w1064 (32 bit win) === win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w864 (64 bit win) === win.c:3418: Test failed: hwnd 0000000000040144 message 0118 === w1064 (64 bit win) === win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1410000: window rect 0,0-1024,768

2 1

Re: [1/3 resend] user32/tests: Add tests for FlashWindow.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17091 Your paranoid android. === w8 (32 bit win) === win.c:3418: Test failed: hwnd 000601B0 message 0118 === w864 (32 bit win) === win.c:3418: Test failed: hwnd 00060192 message 0118 === w1064 (32 bit win) === win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w1064 (64 bit win) === win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1410000: window rect 0,0-1024,768

2 1

Re: [2/2] wbemprox: Add bios name column in Win32_BIOS.
by Hans Leidekker 07 Oct '15

07 Oct '15

On Wed, 2015-10-07 at 03:51 +0200, Sebastian Lackner wrote: > diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c > index 1c960eb..8f51453 100644 > --- a/dlls/wbemprox/builtin.c > +++ b/dlls/wbemprox/builtin.c > @@ -377,7 +377,8 @@ static const struct column col_bios[] = > { prop_releasedateW, CIM_DATETIME }, > { prop_serialnumberW, CIM_STRING }, > { prop_smbiosbiosversionW, CIM_STRING }, > - { prop_versionW, CIM_STRING|COL_FLAG_KEY } > + { prop_versionW, CIM_STRING|COL_FLAG_KEY }, > + { prop_nameW, CIM_STRING } Please keep them sorted.

1 0

Re: [2/3 v3] user32: Implement semi-stub for FlashWindowEx.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17089 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/3] user32/tests: Add tests for FlashWindow.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17088 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/3] ntdll/tests: Add tests for RtlRegisterWait.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17078 Your paranoid android. === w7u (32 bit threadpool) === threadpool.c:1364: Test failed: WaitForSingleObject returned 258 threadpool.c:1375: Test failed: WaitForSingleObject returned 0 === w864 (64 bit threadpool) === threadpool.c:613: Test failed: expected userdata >> 16 != 0, got 0

2 1

Re: [1/3] msi/tests: Add a test for MsiInstallProduct with command line containing double quotes inside of the property.
by Marvin 06 Oct '15

06 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17052 Your paranoid android. === wvistau64 (32 bit install) === The test timed out

2 1

Re: [6/6] oleaut32/tests: Add more tests for typelib data. Take 2.
by Marvin 06 Oct '15

06 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17051 Your paranoid android. === wxppro (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2003std (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7u (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w8 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c}

1 0

Re: [v2 03/10] wined3d: pass wined3d_texture and sub_resource idx to device_volume_created callback
by Stefan Dösinger 06 Oct '15

06 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 This patch causes a crash in the d3d8 tests here: Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x7ec1adda). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ec1adda ESP:0033f450 EBP:0033f488 EFLAGS:00010246( R- -- I Z- -P- ) EAX:7ec887f5 EBX:7ec72000 ECX:0033f4a0 EDX:7eca7e80 ESI:0015c920 EDI:00000000 Stack dump: 0x0033f450: 00000000 7bc3cc86 0033f480 7ec72000 0x0033f460: 0015c920 00000000 0033f498 7ec1c369 0x0033f470: 00000010 7ec1adc6 0033f4a0 7eca8000 0x0033f480: 0015c920 00000000 0033f4c8 7ec9941c 0x0033f490: 0033f4b0 7eca8000 7ec887f5 7ec9941c 0x0033f4a0: 00000000 00000000 7ec8859d 7ec99411 Backtrace: =>0 0x7ec1adda wined3d_volume_unmap+0x2a(volume=<couldn't compute location>) [/home/stefan/build/wine/dlls/wined3d/../../../../src/wine/dlls/wined3d/volume.c:683] in wined3d (0x0033f488) 1 0x7ec9941c d3d8_volume_UnlockBox+0x5b(iface=<couldn't compute location>) [/home/stefan/build/wine/dlls/d3d8/../../../../src/wine/dlls/d3d8/volume.c:170] in d3d8 (0x0033f4c8) 2 0x7ec952e6 d3d8_texture_3d_UnlockBox+0x55(iface=<couldn't compute location>, level=<couldn't compute location>) [/home/stefan/build/wine/dlls/d3d8/../../../../src/wine/dlls/d3d8/texture.c:1068] in d3d8 (0x0033f508) 3 0x7ecea1d1 test_volume_locking+0x160() [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/dlls/d3d8/tests/device.c:5761] in d3d8_test (0x0033f668) 4 0x7ecff26a func_device+0x4e39() [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/dlls/d3d8/tests/device.c:7533] in d3d8_test (0x0033fd38) 5 0x7ece2536 main+0x385(argc=<is not available>, argv=<is not available>) [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/include/wine/test.h:584] in d3d8_test (0x0033fdf8) 6 0x7ed1ff0f __wine_spec_exe_entry+0x6e(peb=<couldn't compute location>) [/home/stefan/build/wine/dlls/winecrt0/../../../../src/wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x0033fe48) 7 0x7b85d97c call_process_entry+0xb() in kernel32 (0x0033fe68) 8 0x7b85e9ba start_process+0x59(peb=<couldn't compute location>) [/home/stefan/build/wine/dlls/kernel32/../../../../src/wine/dlls/kernel32/process.c:1104] in kernel32 (0x0033fe98) 9 0x7bc7e5e0 call_thread_func_wrapper+0xb() in ntdll (0x0033feb8) 10 0x7bc8151f call_thread_func+0xce(entry=0x7b85e960, arg=0x7ffdf000, frame=0x33ffc8) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/signal_i386.c:2732] in ntdll (0x0033ffa8) 11 0x7bc7e5be call_thread_entry_point+0x11() in ntdll (0x0033ffc8) 12 0x7bc53de7 start_process+0x16(kernel_start=0x7b85e960) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3040] in ntdll (0x0033ffe8) 13 0xf759138d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 14 0xf7591500 wine_switch_to_stack+0x1f(func=0x7bc53dd0, arg=0x7b85e960, stack=0x340000) [/home/stefan/build/wine/libs/wine/../../../../src/wine/libs/wine/port.c:59] in libwine.so.1 (0xffccfbd8) 15 0x7bc59b31 LdrInitializeThunk+0x1f0(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3094] in ntdll (0xffccfc18) 16 0x7b864812 __wine_kernel_init+0x871() [/home/stefan/build/wine/dlls/kernel32/../../../../src/wine/dlls/kernel32/process.c:1276] in kernel32 (0xffcd0d88) 17 0x7bc5a973 __wine_process_init+0x162() [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3303] in ntdll (0xffcd0e08) 18 0xf758f003 wine_init+0x2d2(argc=0x3, argv=0xffcd1364, error="", error_size=0x400) [/home/stefan/build/wine/libs/wine/../../../../src/wine/libs/wine/loader.c:958] in libwine.so.1 (0xffcd0e68) 19 0x7bf00d52 main+0x81(argc=<is not available>, argv=<is not available>) [/home/stefan/build/wine/loader/../../../src/wine/loader/main.c:247] in <wine-loader> (0xffcd12b8) 20 0xf739b973 __libc_start_main+0xf2() in libc.so.6 (0x00000000) 0x7ec1adda wined3d_volume_unmap+0x2a [/home/stefan/build/wine/dlls/wined3d/../../../../src/wine/dlls/wined3d/volume.c:683] in wined3d: movl 0x8(%edi),%eax 683 if (!volume->resource.map_count) Modules: Module Address Debug info Name (60 modules) ELF 7a800000-7a92f000 Deferred opengl32<elf> \-PE 7a820000-7a92f000 \ opengl32 ELF 7b800000-7ba62000 Dwarf kernel32<elf> \-PE 7b810000-7ba62000 \ kernel32 ELF 7bc00000-7bced000 Dwarf ntdll<elf> \-PE 7bc10000-7bced000 \ ntdll ELF 7bf00000-7bf04000 Dwarf <wine-loader> ELF 7e321000-7e327000 Deferred libxfixes.so.3 ELF 7e327000-7e332000 Deferred libxcursor.so.1 ELF 7e332000-7e341000 Deferred libxi.so.6 ELF 7e341000-7e345000 Deferred libxcomposite.so.1 ELF 7e345000-7e34f000 Deferred libxrandr.so.2 ELF 7e34f000-7e359000 Deferred libxrender.so.1 ELF 7e359000-7e35f000 Deferred libxxf86vm.so.1 ELF 7e35f000-7e363000 Deferred libxinerama.so.1 ELF 7e363000-7e36a000 Deferred libxdmcp.so.6 ELF 7e36a000-7e36e000 Deferred libxau.so.6 ELF 7e36e000-7e38f000 Deferred libxcb.so.1 ELF 7e38f000-7e4a8000 Deferred libx11.so.6 ELF 7e4a8000-7e4b9000 Deferred libxext.so.6 ELF 7e50b000-7e59a000 Deferred winex11<elf> \-PE 7e520000-7e59a000 \ winex11 ELF 7e59a000-7e5be000 Deferred imm32<elf> \-PE 7e5a0000-7e5be000 \ imm32 ELF 7e683000-7e6a2000 Deferred libexpat.so.1 ELF 7e6a2000-7e6d7000 Deferred libfontconfig.so.1 ELF 7e6d7000-7e706000 Deferred libpng16.so.16 ELF 7e706000-7e71a000 Deferred libz.so.1 ELF 7e71a000-7e7a8000 Deferred libfreetype.so.6 ELF 7e7a8000-7e7e5000 Deferred libncurses.so.5 ELF 7e837000-7e851000 Deferred version<elf> \-PE 7e840000-7e851000 \ version ELF 7e851000-7e9a2000 Deferred user32<elf> \-PE 7e860000-7e9a2000 \ user32 ELF 7e9a2000-7ea19000 Deferred advapi32<elf> \-PE 7e9b0000-7ea19000 \ advapi32 ELF 7ea19000-7eb34000 Deferred gdi32<elf> \-PE 7ea30000-7eb34000 \ gdi32 ELF 7eb34000-7ec76000 Dwarf wined3d<elf> \-PE 7eb40000-7ec76000 \ wined3d ELF 7ec76000-7ecaa000 Dwarf d3d8<elf> \-PE 7ec80000-7ecaa000 \ d3d8 ELF 7ecd0000-7ed37000 Dwarf d3d8_test<elf> \-PE 7ece0000-7ed37000 \ d3d8_test ELF 7ef37000-7ef44000 Deferred libnss_files.so.2 ELF 7ef44000-7ef50000 Deferred libnss_nis.so.2 ELF 7ef50000-7ef69000 Deferred libnsl.so.1 ELF 7ef69000-7efae000 Deferred libm.so.6 ELF 7efb2000-7efbf000 Deferred libbz2.so.1 ELF f4f8f000-f4fab000 Deferred libgcc_s.so.1 ELF f5147000-f721b000 Deferred libnvidia-glcore.so.355.11 ELF f726d000-f7370000 Deferred libgl.so.1 ELF f737c000-f7381000 Deferred libdl.so.2 ELF f7382000-f751c000 Dwarf libc.so.6 ELF f751c000-f7536000 Deferred libpthread.so.0 ELF f7537000-f7540000 Deferred libnss_compat.so.2 ELF f757b000-f7580000 Deferred libnvidia-tls.so.355.11 ELF f7588000-f7740000 Dwarf libwine.so.1 ELF f7741000-f7763000 Deferred ld-linux.so.2 ELF f7765000-f7766000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 0000000e services.exe 0000002f 0 0000002e 0 00000028 0 00000022 0 0000001c 0 00000014 0 00000010 0 0000000f 0 00000012 winedevice.exe 00000019 0 00000018 0 00000013 0 0000001a winedevice.exe 0000001f 0 0000001e 0 0000001b 0 00000020 winedevice.exe 00000025 0 00000024 0 00000021 0 00000026 plugplay.exe 0000002b 0 0000002a 0 00000027 0 0000002c winedevice.exe 00000031 0 00000030 0 0000002d 0 00000032 explorer.exe 00000037 0 00000036 0 00000035 0 00000034 0 00000033 0 0000003b (D) Z:\home\stefan\build\wine\dlls\d3d8\tests\d3d8_test.exe 00000040 0 <== System information: Wine build: wine-1.7.52-49-gc171ca1 Platform: i386 (WOW64) Host system: Linux Host version: 4.0.5-aufs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWE38aAAoJEN0/YqbEcdMw/XQP/jP/uppjezHsceuRmebdi44J F/RPugTszK6FVR3/c7+x/q4zVq5tdJXYD2W5Sa07k7F63P/t8lneWk0ADaASSdI6 XETTWQ9dEdP3mndOdlw2oftGwmDomgZXc7jAeGE6N7yvwRfUKUat8IRslIGmpmu2 VdeV3aYk6VL/KDxWIBVdid26hiEWVkgqQWEK2m4rZHiu5ZehE7HEf5sA+NQ3d+GX VThFQcaNRUZ1988W0iDfIEB5r621V9eedVWdPktwGh+trdJMlObTtDoihEiF9IUi Q0r5LYa47HcI6KpHhJYF+dSXFUy8c8dm+CX7xA+EhO7X4W0HL/EBE4C2sF3mZ8mO 0tAg/lrCb0o9PJJ21I/fckQ3qhAJWyA1I/BQxrBfE16W9Ywh65SA5CLDKg5hXX45 jervpWtfi6jjkgCy9A/lmmJ0pUKL7RsES8Ot8eI/aUMpmwaGf4rYuk+ZjrQiEJ9v 2xT439SXYuQw6RK3EJUeaLiMr8PiYDEluWSPbD5uYtxjUwI4L/PXRGMuqxUz+TSz 7O2jC8FHHRYuGLAskgZetd3RYi8Ip3ApPySntkZJ0B4HwNSg4AzSUaiL6UYVnNZH 8PB+dJKSx94Zb+gRA/IgonsXM0AuD9roOeVXYMCiE92ubzHHboO8YQ6dsaYM9Ial vlyz2JJWEYqBCTBD5P/c =PHTE -----END PGP SIGNATURE-----

2 1

Re: [6/6] oleaut32/tests: Add more tests for typelib data.
by Andrew Eikum 06 Oct '15

06 Oct '15

On Mon, Oct 05, 2015 at 08:36:31PM +0800, Dmitry Timoshkov wrote: > +{ > + "a", > + "{00000000-0000-0000-0000-000000000000}", > + /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4, > + /*#vtbl*/ 0, /*#func*/ 0 > +}, ... > +{ > + "c", > + "{016fe2ec-b2c8-45f8-b23b-39e53a75396b}", > + /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4, > + /*#vtbl*/ 0, /*#func*/ 0 > +}, These two tests fail on my Win7 VM: typelib.c:4378: Interface a typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4378: Interface _a typelib.c:4378: Interface aa typelib.c:4378: Interface _b typelib.c:4378: Interface bb typelib.c:4378: Interface c typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4378: Interface _c I get the same failures when running the tests on Wine. Unlike the testbot, everything else passes on my VM. Andrew

2 3

Re: [1/2] user32/tests: Add a test for sending WM_SIZE message to edit control.
by Nikolay Sivov 05 Oct '15

05 Oct '15

On 06.10.2015 0:42, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > The test failure "edit.c:1521: Test failed: got 1, 1" on Win7 is unrelated to this patch. > > dlls/user32/tests/edit.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c > index e8b41c2..88bb364 100644 > --- a/dlls/user32/tests/edit.c > +++ b/dlls/user32/tests/edit.c > @@ -1481,6 +1481,15 @@ static void test_margins(void) > ok(new_rect.top == old_rect.top, "The top border of the rectangle has changed\n"); > ok(new_rect.bottom == old_rect.bottom, "The bottom border of the rectangle has changed\n"); > > + /* The lParam argument of the WM_SIZE message should be ignored. */ > + SendMessageA(hwEdit, EM_GETRECT, 0, (LPARAM)&old_rect); > + SendMessageA(hwEdit, WM_SIZE, 0, 0); > + SendMessageA(hwEdit, EM_GETRECT, 0, (LPARAM)&new_rect); > + ok(new_rect.left == old_rect.left, "The left border of the rectangle has changed\n"); > + todo_wine ok(new_rect.right == old_rect.right, "The right border of the rectangle has changed\n"); > + todo_wine ok(new_rect.top == old_rect.top, "The top border of the rectangle has changed\n"); > + todo_wine ok(new_rect.bottom == old_rect.bottom, "The bottom border of the rectangle has changed\n"); > + Maybe use EqualRect()? Could you add more tests for that? For example non-zero lParam, different combinations of wParam modes (with SIZE_RESTORED instead of 0). > DestroyWindow (hwEdit); > > memset(&lf, 0, sizeof(lf)); >

1 0

Re: [PATCH 2/5] ddraw/tests: Add Direct3D3 test section
by Stefan Dösinger 05 Oct '15

05 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, Your mails ended up in my spam folder for some reason. Google says it has large similarities to other known spam mail, which seems unlikely to me. Am 2015-10-04 um 19:52 schrieb Andrew D'Addesio: > To avoid confusion, CreateDirect3D/ReleaseDirect3D is also renamed to > CreateDirect3D7/ReleaseDirect3D7. > --- > dlls/ddraw/tests/d3d.c | 167 +++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 154 insertions(+), 13 deletions(-) New tests should be added to ddraw*.c, ideally in all ddraw versions that offer the tested feature. The long term goal for d3d.c, dsurface.c, etc is to be migrated to those files. If you want to modify an existing test in d3d.c please move the existing code to ddraw*.c, then add your new test features to it. These files have some exising helper functions like create_device, so you don't have to take stuff like d3d3_create_objects along. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWEh67AAoJEN0/YqbEcdMwGUEQAIskKamXUC/+Kik99/eqbcpp 3SohARAHPivs+bf2GM68dBBeON9SbzlllfH/cIog9Z9oAUr2fGWDUMLQnyb96ANH +g39WlGO/HFEvqBI9B+mLrZO1VQaePwNH6Sv6p4d09OLWlyRa0PfGrImdqxBNwS2 /Z9j9PmHMQ2oV2KAM3vyqAGAX7VrLH+kr/fQqQofLhHGidHhXUZgkpOT67Drwp4/ 98B3QzFgFyo58Z1AWJ2hAJt4PZQ/uLIn3zQdnYzgsC2H3a9maLC2iB0l3CvXeMgi N8Sb+Nazvjtlu7ut6sNc7cOaharjnYLzKjTpqC0IV0TjFysa0BcwXAm1dj660KzK 2RAy6HeTbE4OpgbT+jU482GNTzhKtRX0EmyCIWD1YZV6li5SO4/mkqPp54D14pHK jgnMV689ZCayn+TpdbO2Q30USJD1tI3HwvXFWyweTFeB59ERmtruLJNDUQ3TtWct Wvcg9AMY8PaSFha/fhGis8/HUFmwWnRWt/E4rhVGmA5wLUD9NO7k0sGOxdRja6mE mNs/dE9ibLn3WB9K9NNLylI2W/4ATbUZoypdEb5H4hyejzfvsbj4LK+772qvLEkS +CEqcT5JwXVF2/XaGrXEkIWt1hz8CnGPHDFrylDoXdXBO5LYKkgKuXmBfFV7DU7Y HM8/Zo1J7TZ9r3yZjmm+ =cNFg -----END PGP SIGNATURE-----

2 2

Re: [6/6] oleaut32/tests: Add more tests for typelib data.
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17010 Your paranoid android. === wxppro (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2003std (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7u (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w8 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c}

2 1

Re: [PATCH 4/7] wined3d: Initialize unwritten texcoord varyings in the VS.
by Henri Verbeet 05 Oct '15

05 Oct '15

On 2 October 2015 at 14:54, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -4998,7 +4996,22 @@ static GLuint generate_param_reorder_function(struct shader_glsl_priv *priv, > output->register_idx, reg_mask[1]); > } > } > - shader_addline(buffer, "}\n"); > + > + for (i = 0; i < MAX_TEXTURES; ++i) > + { > + if (ps && !(ps->reg_maps.texcoord & (1u << i))) > + continue; > + > + if (texcoords_written_mask[i] != WINED3DSP_WRITEMASK_ALL) > + { > + if (gl_info->limits.glsl_varyings < wined3d_max_compat_varyings(gl_info) > + && !texcoords_written_mask[i]) > + continue; > + > + shader_glsl_write_mask_to_str(~texcoords_written_mask[i] & WINED3DSP_WRITEMASK_ALL, reg_mask); > + shader_addline(buffer, "gl_TexCoord[%u]%s = vec4(0.0)%s;\n", i, reg_mask, reg_mask); > + } > + } > } > else > { Doesn't this end up writing 0.0 to .w instead of 1.0? IIRC unwritten texture coordinates are assumed to be (0, 0, 0, 1) in D3D. May apply to the previous patch in the series as well.

3 4

Re: [3/6] oleaut32/tests: Update the typelib test generator to match existing data.
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17007 Your paranoid android. === wvistau64 (32 bit typelib) === The test timed out

1 0

Re: [PATCH] hidclass.sys: fixed copy/paste error (Coverity)
by Ken Thomases 05 Oct '15

05 Oct '15

On Oct 3, 2015, at 2:52 AM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > > 1325460 Identical code for different branches > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/descriptor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/hidclass.sys/descriptor.c b/dlls/hidclass.sys/descriptor.c > index 6f8e45e..35057f1 100644 > --- a/dlls/hidclass.sys/descriptor.c > +++ b/dlls/hidclass.sys/descriptor.c > @@ -414,7 +414,7 @@ void parse_io_feature(unsigned int bSize, int itemVal, int bTag, unsigned int *f > if ((itemVal & INPUT_ARRAY) == 0) > feature->isArray= TRUE; > else > - feature->isArray= TRUE; /* Var */ > + feature->isArray= FALSE; /* Var */ Hmm. First, doesn't that logic seem backward? You're now setting isArray to true only if itemVal does NOT contain INPUT_ARRAY. And wouldn't it be better to just replace that whole if statement by: feature->isArray = (itemVal & INPUT_ARRAY) != 0; ? (For what it's worth, I started to suggest the style refactoring first and that's what made it so obvious that the logic was wrong. The power of good style to improve comprehension!) > if ((itemVal & INPUT_ABS) == 0) > feature->IsAbsolute = TRUE; > else The rest of this function looks like it's riddled with similar backward logic. :( -Ken

2 3

Ignored WineTest report
by Francois Gouget 05 Oct '15

05 Oct '15

My FreeBSD 7.0 VM sent the following report: http://fgouget.free.fr/tmp/winebot-fg-freebsd70-vm.report However that report was ignored and I have no idea why. The report is under 1.5MB and has only 44 failures. So why is it being ignored? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The nice thing about meditation is that it makes doing nothing quite respectable -- Paul Dean

2 5

Re: [PATCH 6/7] wined3d: Avoid reading uninitialized texcoord varyings in FFP replacement fragment shaders.
by Henri Verbeet 05 Oct '15

05 Oct '15

On 2 October 2015 at 14:54, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - unsigned char padding; > + unsigned char pointsprite : 1; > + unsigned char padding : 7; > + unsigned int inited_texcoords; > }; Did you perhaps mean something like "initialized_texcoords" or "texcoords_initialized"?

2 2

Re: [PATCH 1/7] wined3d: Avoid the deprecated syntax for SM3 varyings on core profile.
by Henri Verbeet 05 Oct '15

05 Oct '15

On 2 October 2015 at 14:54, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +static void PRINTF_ATTR(4, 5) declare_in_varying(const struct wined3d_gl_info *gl_info, > + struct wined3d_string_buffer *buffer, BOOL flat, const char *format, ...) It's not a huge issue, but generally speaking things are more readable on the caller side when you use a flag or enum instead of a BOOL. I.e., "declare_in_varying(..., TRUE, ...);" vs. e.g. "declare_in_varying(..., WINED3D_GLSL_INTERPOLATE_FLAT, ...);".

1 0

Re: [PATCH 5/9] d3d11: Implement {d3d10, d3d11}_geometry_shader_GetDevice().
by Henri Verbeet 05 Oct '15

05 Oct '15

For what it's worth, the original reason geometry shaders and input layouts don't have a GetDevice() implementation was that it was a bit harder to add test coverage for them than for the rest of the interfaces. It's probably easy enough now, so please add some geometry shader coverage to test_create_shader(). You can probably use the shader from test_clear_state().

1 0

Re: crypt32/tests: Delete WineTest registry key when tests are complete
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17004 Your paranoid android. === w864 (64 bit store) === store.c:2603: Test failed: CertAddCertificateContextToStore failed store.c:2604: Test failed: Unexpected cert3 store: unhandled exception c0000005 at 000000000044DAD6

2 1

Re: [PATCH 1/5] ddraw/tests: Don't skip d3d1-2 tests if DirectDrawCreateEx isn't present
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17003 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2334: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2518: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2665: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [2/2] widl: Fix generation of a typelib for winhttp.
by Huw Davies 05 Oct '15

05 Oct '15

On 2 Oct 2015, at 03:25, Dmitry Timoshkov wrote: > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index 26600e4..7973113 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -974,8 +974,7 @@ static int encode_type( > { > int typeinfo_offset; > > - /* typedef'd types without public attribute aren't included in the typelib */ > - while (type->typelib_idx < 0 && type_is_alias(type) && !is_attr(type->attrs, ATTR_PUBLIC)) > + while (type->typelib_idx < 0 && type_is_alias(type)) > type = type_alias_get_aliasee(type); > > chat("encode_type: VT_USERDEFINED - type %p name = %s real type %d idx %d\n", type, > @@ -1836,7 +1835,7 @@ static msft_typeinfo_t *create_msft_typeinfo(msft_typelib_t *typelib, enum type_ > MSFT_TypeInfoBase *typeinfo; > MSFT_GuidEntry guidentry; > > - chat("create_msft_typeinfo: name %s kind %d\n", name, kind); > + chat("create_msft_typeinfo: name %s kind %d, index %d\n", name, kind, typelib->typelib_header.nrtypeinfos); > > msft_typeinfo = xmalloc(sizeof(*msft_typeinfo)); > memset( msft_typeinfo, 0, sizeof(*msft_typeinfo) ); > @@ -2307,9 +2306,7 @@ static void add_entry(msft_typelib_t *typelib, const statement_t *stmt) > { > const type_list_t *type_entry = stmt->u.type_list; > for (; type_entry; type_entry = type_entry->next) { > - /* if the type is public then add the typedef, otherwise attempt > - * to add the aliased type */ > - if (is_attr(type_entry->type->attrs, ATTR_PUBLIC)) > + if (type_get_type(type_entry->type) == TYPE_BASIC) > add_typedef_typeinfo(typelib, type_entry->type); > else > add_type_typeinfo(typelib, type_alias_get_aliasee(type_entry->type)); Doesn't this essentially make [public] a nop? That seems wrong. The WinHttpRequestOption enum has a [uuid] attribute, so that probably has something to do with it. Huw.

3 8

Re: [PATCH 5/5] ddraw: Enumerate the correct Direct3D devices in the correct order
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16988 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2428: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2428: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2428: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2428: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2612: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2759: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2759: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2759: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2759: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 4/5] ddraw: Accept all 3 versions of D3DFINDDEVICERESULT
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16987 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2367: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2367: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2367: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2367: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2551: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2698: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2698: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2698: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2698: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 3/5] ddraw/tests: Restore strings modified by D3D7EnumLifetimeTest
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16986 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2360: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2544: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2691: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 3/5] ddraw/tests: Restore strings modified by D3D7EnumLifetimeTest
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16985 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2360: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2544: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2691: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 2/5] ddraw/tests: Add Direct3D3 test section
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16984 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2353: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2537: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2684: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: ntdll: Work around a conflict between Wine and Solaris list.h.
by André Hentschel 04 Oct '15

04 Oct '15

Am 04.10.2015 um 16:32 schrieb Francois Gouget: > + * This need to be workaround it here. Hi Francois, I'm not a native speaker, but this sounds strange. Same for the original commit from 2008

2 1

Re: [PATCH 3/5] ddraw/tests: Restore strings modified by D3D7EnumLifetimeTest
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16983 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2360: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2544: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2691: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 2/5] ddraw/tests: Add Direct3D3 test section
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16982 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2353: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2537: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2684: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 1/5] ddraw/tests: Don't skip d3d1-2 tests if DirectDrawCreateEx isn't present
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16981 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2334: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2518: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2665: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [2/2 v4 resend] winex11.drv: Implement FlashWindowEx.
by André Hentschel 04 Oct '15

04 Oct '15

Am 03.10.2015 um 05:39 schrieb Jactry Zeng: > Superseded patch 114739. > > ChangeLog: > v4: > - Rename driver entry to FlashWindowEx; > - Put FlashWindowEx/pFlashWindowEx in right place; > - Add CDECL for X11DRV_FlashWindowEx. > v3: > - Use x11drv_atom instead of XInternAtom; > - Only do XSendEvent() when data->mapped is true. > v2: > - Use _NET_WM_STATE_DEMANDS_ATTENTION instead of Urgency. > Hi, I haven't looked closer, but normally the implementation should be in the Ex-function and the non-Ex-function should call the Ex-function. In this patch you do Ex->non-Ex->Ex which looks strange.

2 1

Re: [PATCH 4/5] ws2_32: Add support for TransmitFile headers and footers.
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16975 Your paranoid android. === w7pro64 (32 bit sock) === sock.c:7324: Test failed: bytesReturned isn't supposed to be 1 sock.c:7370: Test failed: Waiting for timeout failed with 0 + errno 997

2 1

Re: [3/4] psapi/tests: Adjust margin for win10
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16971 Your paranoid android. === w1064 (32 bit psapi_main) === psapi_main.c:627: Test failed: wrong length 3 psapi_main.c:643: Test failed: wrong length 3 === w1064 (64 bit psapi_main) === psapi_main.c:627: Test failed: wrong length 3 psapi_main.c:643: Test failed: wrong length 3

1 0

Re: [2/4] psapi/tests: Remove bad test
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16970 Your paranoid android. === w1064 (32 bit psapi_main) === psapi_main.c:627: Test failed: wrong length 3 psapi_main.c:643: Test failed: wrong length 3 === w1064 (64 bit psapi_main) === psapi_main.c:627: Test failed: wrong length 3 psapi_main.c:643: Test failed: wrong length 3

1 0

Re: [1/4] psapi/tests: Disable tests which crash on win10
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16969 Your paranoid android. === w1064 (32 bit psapi_main) === psapi_main.c:157: Test failed: cbNeeded=136 psapi_main.c:644: Test failed: wrong length 3 psapi_main.c:660: Test failed: wrong length 3 === w1064 (64 bit psapi_main) === psapi_main.c:644: Test failed: wrong length 3 psapi_main.c:660: Test failed: wrong length 3

1 0

Re: [PATCH 1/2] reg: simplify root key search
by Stefan Dösinger 03 Oct '15

03 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Thanks, this time the patches apply OK for me. I've told Alexandre that the patches look OK to me, let's see what he says. Cheers, Stefan Am 2015-09-03 um 21:51 schrieb Michel Zou: > Split patch from Jonathan Vollebregt: > https://github.com/jnvsor/wine/commit/ea0e2fc70db6ce4904655ea4a27ee34531d96… > --- > programs/reg/reg.c | 85 +++++++++++++++++++++++++++--------------------------- > 1 file changed, 43 insertions(+), 42 deletions(-) > > diff --git a/programs/reg/reg.c b/programs/reg/reg.c > index 4ec25bc..0f28b63 100644 > --- a/programs/reg/reg.c > +++ b/programs/reg/reg.c > @@ -22,6 +22,32 @@ > > #define ARRAY_SIZE(A) (sizeof(A)/sizeof(*A)) > > +static const WCHAR short_hklm[] = {'H','K','L','M',0}; > +static const WCHAR short_hkcu[] = {'H','K','C','U',0}; > +static const WCHAR short_hkcr[] = {'H','K','C','R',0}; > +static const WCHAR short_hku[] = {'H','K','U',0}; > +static const WCHAR short_hkcc[] = {'H','K','C','C',0}; > +static const WCHAR long_hklm[] = {'H','K','E','Y','_','L','O','C','A','L','_','M','A','C','H','I','N','E',0}; > +static const WCHAR long_hkcu[] = {'H','K','E','Y','_','C','U','R','R','E','N','T','_','U','S','E','R',0}; > +static const WCHAR long_hkcr[] = {'H','K','E','Y','_','C','L','A','S','S','E','S','_','R','O','O','T',0}; > +static const WCHAR long_hku[] = {'H','K','E','Y','_','U','S','E','R','S',0}; > +static const WCHAR long_hkcc[] = {'H','K','E','Y','_','C','U','R','R','E','N','T','_','C','O','N','F','I','G',0}; > + > +static const struct > +{ > + HKEY key; > + const WCHAR *short_name; > + const WCHAR *long_name; > +} > +root_rels[] = > +{ > + {HKEY_LOCAL_MACHINE, short_hklm, long_hklm}, > + {HKEY_CURRENT_USER, short_hkcu, long_hkcu}, > + {HKEY_CLASSES_ROOT, short_hkcr, long_hkcr}, > + {HKEY_USERS, short_hku, long_hku}, > + {HKEY_CURRENT_CONFIG, short_hkcc, long_hkcc}, > +}; > + > static const WCHAR type_none[] = {'R','E','G','_','N','O','N','E',0}; > static const WCHAR type_sz[] = {'R','E','G','_','S','Z',0}; > static const WCHAR type_expand_sz[] = {'R','E','G','_','E','X','P','A','N','D','_','S','Z',0}; > @@ -95,51 +121,26 @@ static int reg_message(int msg) > return reg_printfW(formatW, msg_buffer); > } > > -static int reg_StrCmpNIW(LPCWSTR str, LPCWSTR comp, int len) > +static inline BOOL path_rootname_cmp(const WCHAR *input_path, const WCHAR *rootkey_name) > { > - int i; > + DWORD length = strlenW(rootkey_name); > > - for (i = 0; i < len; i++) > - { > - if (!str[i]) > - { > - len = i + 1; > - break; > - } > - } > - > - return CompareStringW(CP_ACP, NORM_IGNORECASE, str, len, comp, len) - CSTR_EQUAL; > + return (!strncmpiW(input_path, rootkey_name, length) && > + (input_path[length] == 0 || input_path[length] == '\\')); > } > > -static HKEY get_rootkey(LPWSTR key) > +static HKEY path_get_rootkey(const WCHAR *path) > { > - static const WCHAR szHKLM[] = {'H','K','L','M',0}; > - static const WCHAR szHKEY_LOCAL_MACHINE[] = {'H','K','E','Y','_','L','O','C','A','L','_','M','A','C','H','I','N','E',0}; > - static const WCHAR szHKCU[] = {'H','K','C','U',0}; > - static const WCHAR szHKEY_CURRENT_USER[] = {'H','K','E','Y','_','C','U','R','R','E','N','T','_','U','S','E','R',0}; > - static const WCHAR szHKCR[] = {'H','K','C','R',0}; > - static const WCHAR szHKEY_CLASSES_ROOT[] = {'H','K','E','Y','_','C','L','A','S','S','E','S','_','R','O','O','T',0}; > - static const WCHAR szHKU[] = {'H','K','U',0}; > - static const WCHAR szHKEY_USERS[] = {'H','K','E','Y','_','U','S','E','R','S',0}; > - static const WCHAR szHKCC[] = {'H','K','C','C',0}; > - static const WCHAR szHKEY_CURRENT_CONFIG[] = {'H','K','E','Y','_','C','U','R','R','E','N','T','_','C','O','N','F','I','G',0}; > - > - if (!reg_StrCmpNIW(key, szHKLM, 4) || > - !reg_StrCmpNIW(key, szHKEY_LOCAL_MACHINE, 18)) > - return HKEY_LOCAL_MACHINE; > - else if (!reg_StrCmpNIW(key, szHKCU, 4) || > - !reg_StrCmpNIW(key, szHKEY_CURRENT_USER, 17)) > - return HKEY_CURRENT_USER; > - else if (!reg_StrCmpNIW(key, szHKCR, 4) || > - !reg_StrCmpNIW(key, szHKEY_CLASSES_ROOT, 17)) > - return HKEY_CLASSES_ROOT; > - else if (!reg_StrCmpNIW(key, szHKU, 3) || > - !reg_StrCmpNIW(key, szHKEY_USERS, 10)) > - return HKEY_USERS; > - else if (!reg_StrCmpNIW(key, szHKCC, 4) || > - !reg_StrCmpNIW(key, szHKEY_CURRENT_CONFIG, 19)) > - return HKEY_CURRENT_CONFIG; > - else return NULL; > + DWORD i; > + > + for (i = 0; i < ARRAY_SIZE(root_rels); i++) > + { > + if (path_rootname_cmp(path, root_rels[i].short_name) || > + path_rootname_cmp(path, root_rels[i].long_name)) > + return root_rels[i].key; > + } > + > + return NULL; > } > > static DWORD wchar_get_type(const WCHAR *type_name) > @@ -237,7 +238,7 @@ static int reg_add(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, > } > p++; > > - root = get_rootkey(key_name); > + root = path_get_rootkey(key_name); > if (!root) > { > reg_message(STRING_INVALID_KEY); > @@ -307,7 +308,7 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, > } > p++; > > - root = get_rootkey(key_name); > + root = path_get_rootkey(key_name); > if (!root) > { > reg_message(STRING_INVALID_KEY); > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJV6XG1AAoJEN0/YqbEcdMwWysP/0BvR0rXG67sd/NC5pPItrVv R2bGZceGH8yJpBuYOxpp2W5p9sCRMfoc2giTXrhmvUwVrutXrUbI9c/SqOlLZL6I YLOObNIo/DI6MxBwGaZ2jKGJKWEW3kzg5qKkJWzPIMg92zfbgtQxiTxhvAvd1xaR MxXLzKt+mhMWjPwyFR3omSFCTkvTguWxnXIVEf2S6TRshJnI0A10vJQUj1AC4dsX ZnHZkuXOAgwzgzmvkEnxbNsgkRzqmXCZaUbapcgJ5TXwwuiLMr4AuPbEcYmdf2g+ CqIYeIUYVtbg3pga/9WFdSki0YaAcJJ7kYTt5lEYRN3/V93W6QsPp/SaUXyx1J1B UOCbuj1UNx8OvRRvmABLrTvgbUQMrjlDXPP9QeNBHe8xQCQ1iV/AJ02DdbLrRleJ a/+CgisljGNzuH6Mu+5bKoKAEyEV3KAF3CIz6dJyBB5KQRY6Rk5AZMhWSQAhkJke ICBh+ITIBWYCsm+NDF+RuYutXhtstxvbewRHmwg4KnF2ouOTtQ2ypV+N2Z9JLNQ8 I25+6YB+1WDuDKYa87MPzbac6DX5IyzIPKiGsvLBngMiUcpfSDj6mgJTS4DkTwSM O+JYL5v8x7TIOmxKLGUfXXnvA+aiZ29/nrlLrZY8QoKLvHvpAxOz/SjUhDZa02IC twXso6DreRFxb4DyflTj =BizJ -----END PGP SIGNATURE-----

2 4

Re: [1/2 v2 resend] user32: Implement semi-stub for FlashWindowEx.
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16960 Your paranoid android. === w8 (32 bit win) === win.c:3417: Test failed: hwnd 0003014E message 0118 === w1064 (32 bit win) === win.c:6658: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6680: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6658: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6658: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6658: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6658: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6658: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6680: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6658: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6680: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w864 (64 bit win) === win.c:3417: Test failed: hwnd 000000000003012C message 0118 === w1064 (64 bit win) === win.c:6658: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6680: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6658: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6658: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6658: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6658: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6658: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6680: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6658: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6680: Test failed: 0x80/0x1410000: window rect 0,0-1024,768

1 0

Re: [1/2 v2] user32: Implement semi-stub for FlashWindowEx.
by Ken Thomases 03 Oct '15

03 Oct '15

On Oct 2, 2015, at 2:59 AM, Jactry Zeng <jzeng(a)codeweavers.com> wrote: > + return FlashWindow( pfwi->hwnd, pwfi->dwFlags ); This has a typo. "pwfi" should be "pfwi". You've fixed it in the next patch, which is why it compiles for you, but you have to not introduce it in the first place. :) -Ken

3 2

What is the monetary value of Wine ?
by Tom Wickline 02 Oct '15

02 Oct '15

I just wrote a little article on the monetary value of WineHQ, if any of you guys and gals are interested to read it it's located here : http://www.wine-reviews.net/2015/10/the-glass-of-wine-thats-worth-350.html Cheers, Tom

1 0

Re: [7/9] msvcirt: Implement stdiobuf::setrwbuf
by Piotr Caban 02 Oct '15

02 Oct '15

On 10/02/15 15:03, Iván Matellanes wrote: > + if (buffer_size < 0) > + return 0; > + if (read_size == 0 && write_size == 0) { > + this->base.unbuffered = 1; > + return 0; > + } Something like this makes more sense (and matches Windows 7 behavior): if (read_size < 0 || write_size < 0) return 0; if (!buffer_size) { this->base.unbuffered = 1; return 0; } Thanks, Piotr

1 0

Re: wininet: Set Content-Length header to zero if the verb is CONNECT.
by Marvin 02 Oct '15

02 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16948 Your paranoid android. === w7u (32 bit http) === http.c:5841: Test failed: HttpAddRequestHeadersA failed 12019 http.c:5847: Test failed: HttpQueryInfoA failed 12019 http.c:5848: Test failed: header missing === w1064 (32 bit http) === http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1773: Test failed: Expected 2, got 4 http.c:1774: Test failed: Expected CRLF, got ' http.c:2408: Test failed: count was wrong http.c:2409: Test failed: http data wrong, got: Garbage: Header http.c:3072: Test failed: HttpAddRequestHeaders succeeded http.c:3073: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1773: Test failed: Expected 2, got 4 http.c:1774: Test failed: Expected CRLF, got ' http.c:2408: Test failed: count was wrong http.c:2409: Test failed: http data wrong, got: Garbage: Header http.c:3072: Test failed: HttpAddRequestHeaders succeeded http.c:3073: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: code = 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:3078: Test failed: unexpected status code 200, expected 400 http.c:534: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel