- wine-devel - winehq.org

Re: [PATCH 1/9] msvcp110: Add tr2_sys__Last_write_time implementation and test.
by Marvin 15 Aug '15

15 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16023 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] shell32: Fix SHFileOperation(FO_MOVE) for creating subdirectories.
by Marvin 14 Aug '15

14 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16012 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR === wvistau64 (64 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR

1 0

Prelink usage
by Michael Cronenworth 14 Aug '15

14 Aug '15

Does prelink still provide any benefits in wine? The package is being retired in Fedora so starting with 1.7.48 the wine package will no longer be compiled with it. A few applications I have run under 1.7.48 still function, but I am curious to know the possible failure cases. Thanks, Michael

4 6

Re: [PATCH] mshtml: Handle nsIDOMWindow_GetFrames returning NULL
by Jacek Caban 14 Aug '15

14 Aug '15

Hi Indrek, On 08/09/15 09:09, Indrek Altpere wrote: > + if(!nsframes) { > + WARN("nsIDOMWindow_GetFrames returned NULL nsframes: %p\n", This->nswindow); > + return E_FAIL; The patch looks mostly good, but I think we should return DISP_E_MEMBERNOTFOUND in this case. Thanks, Jacek

1 0

Re: [PATCH] msvcr120: Implement strtof and _strtof_l (try 2)
by Henri Verbeet 13 Aug '15

13 Aug '15

On 13 August 2015 at 02:23, Bernhard Übelacker <bernhardu(a)vr-web.de> wrote: > +static inline BOOL almost_equal(float d1, float d2) { > + if(d1-d2>-1e-30 && d1-d2<1e-30) > + return TRUE; > + return FALSE; > +} > + You almost never want to compare floating point values like that. See e.g. compare_float() in dlls/ddraw/tests/ddraw7.c for a better (if perhaps not quite perfect) way. E.g. for the FLT_MAX case this only works because you happen to get an exact match. "1e-30" is a double instead of a float. Of course this is probably copied from the existing tests, so I suppose I can't complain too much.

2 1

Re: [PATCH] msvcr120: implement strtof and _strtof_l
by Piotr Caban 12 Aug '15

12 Aug '15

On 08/12/15 00:42, Bernhard Übelacker wrote: > + ok(*(unsigned*)&f == __inf_bytes && sizeof(unsigned) == sizeof(float), "f = %x\n", *(unsigned*)&f); It would be nicer to use _finitef from msvcr120 here. Thanks to it you can avoid __inf_bytes and __ninf_bytes declaration. Thanks, Piotr

1 0

Re: [PATCH 1/2] reg: simplify root key search
by Sebastian Lackner 11 Aug '15

11 Aug '15

On 06.08.2015 23:14, xantares 09 wrote: > From: Jonathan Vollebregt <jnvsor(a)gmail.com> > > --- > programs/reg/reg.c | 85 +++++++++++++++++++++++++++--------------------------- > 1 file changed, 43 insertions(+), 42 deletions(-) It is a bit pointless to send patches anonymously to the wine-patches mailing list. No matter if you are the author or not, when you are sending the patches you are the person responsible for it. To establish trust, all developers should use their real names here on the mailing lists. (see the rules for submitting patches: http://wiki.winehq.org/SubmittingPatches ) Besides that I see much bigger chances when Jonathan would send these patches himself. He is experienced with his own code, can respond to feedback, can fix regressions if it causes problems, and so on. For people new to Wine development its always easier to start with some self-written patches. @Jonathan: I would like to encourage you again to give it another try. If you need any help, feel free to ask me. I assume Stefan Dösinger would also be willing to help again. Regards, Sebastian

3 2

Re: [1/3] usp10/tests: Add tests for control character glyphs.
by Marvin 11 Aug '15

11 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15955 Your paranoid android. === wvistau64 (32 bit usp10) === Failure running script in VM: timed out waiting for the child process

1 0

Re: quartz: waveparser support wav file generated by ffmpeg (try3)
by Dmitry Timoshkov 11 Aug '15

11 Aug '15

"Changhui LIU" <liuchanghui(a)linuxdeepin.com> wrote: > Superseded patch 113457. > > > Change log: > remove todo_wine win_skip The patch looks good, and it actually more closely resembles mmioDescend behaviour (except of alignment to even boundary, but that's a separate issue). -- Dmitry.

2 1

Re: comctl32: ILC_COLORDDB imagelists can be created with 0 sizes
by Huw Davies 11 Aug '15

11 Aug '15

On Mon, Aug 10, 2015 at 08:21:52PM -0500, Aric Stewart wrote: > diff --git a/dlls/comctl32/tests/imagelist.c b/dlls/comctl32/tests/imagelist.c > index 6f13846..fcf5162 100644 > --- a/dlls/comctl32/tests/imagelist.c > +++ b/dlls/comctl32/tests/imagelist.c > @@ -1994,6 +1994,47 @@ static void test_create_destroy(void) > ok(rc == FALSE, "ImageList_Destroy(0xdeadbeef) should fail and not crash\n"); > } > > +static void test_0size_DIB(void) > +{ > + INT cx, cy; > + HIMAGELIST himl; > + IImageList *imgl; > + HRESULT hr; > + INT ret; > + > + himl = ImageList_Create(0, 14, ILC_COLORDDB, 4, 4); This seems an odd choice of function name when you're actually testing DDBs. Also, I think zero_size is much nicer than 0size. Better yet, move all of these into test_create_destroy() where it'll make the difference in behaviour between these and the DIBs more apparent. Huw.

1 0

Re: comctl32: ILC_COLORDDB imagelists can be created with 0 sizes
by Marvin 11 Aug '15

11 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15944 Your paranoid android. === w2000pro (32 bit imagelist) === imagelist: unhandled exception c0000005 at 0041CED0

1 0

Re: [PATCH 2/5] dwrite: Use OS/2 table data to set font style, make it preferable
by Dmitry Timoshkov 10 Aug '15

10 Aug '15

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > if (tt_os2) { > + USHORT version = GET_BE_WORD(tt_os2->version); > + USHORT fsSelection = GET_BE_WORD(tt_os2->fsSelection); > + > if (GET_BE_WORD(tt_os2->usWidthClass) <= DWRITE_FONT_STRETCH_ULTRA_EXPANDED) > props->stretch = GET_BE_WORD(tt_os2->usWidthClass); > > props->weight = GET_BE_WORD(tt_os2->usWeightClass); > + if (version >= 4 && (fsSelection & OS2_FSSELECTION_OBLIQUE)) > + props->style = DWRITE_FONT_STYLE_OBLIQUE; > + else if (fsSelection & OS2_FSSELECTION_ITALIC) > + props->style = DWRITE_FONT_STYLE_ITALIC; It's much better to use freetype flags for bold and italic, that way styles will match between gdi32 and dwrite. Besides I'd prefer to trust freetype instead of some handmade code which was not tested by thousands of fonts out there. -- Dmitry.

2 4

Re: d3dcompiler_43: Define BWRITER_SM1_VS and BWRITER_SM1_PS as unsigned constants.
by Józef Kucia 10 Aug '15

10 Aug '15

Hi Gerald, On Sun, Aug 9, 2015 at 1:47 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > -#define BWRITER_SM1_VS 0xfffe > -#define BWRITER_SM1_PS 0xffff > +#define BWRITER_SM1_VS 0xFFFEu > +#define BWRITER_SM1_PS 0xFFFFu > > Lowercase hex literals are preferred in D3D code.

2 1

Re: [PATCH 2/7] d3d11/tests: Port test_create_texture2d() from d3d10core.
by Henri Verbeet 10 Aug '15

10 Aug '15

On 10 August 2015 at 01:11, Józef Kucia <jkucia(a)codeweavers.com> wrote: > --- > configure | 3 +- > configure.ac | 3 +- It's not a problem to include these, but it's not necessary either. Alexandre will generate these with tools/make_makefiles before committing the patch. > + if (!(device = create_device())) > + { > + skip("Failed to create device, skipping tests.\n"); > + return; > + } > + There's nothing necessarily wrong with these tests, but you may want to consider waiting with submitting them until after they pass. Right now you're depending on create_device() to fail so the tests are skipped, but that means that once D3D11CreateDevice() is implemented you'd need to add todo_wine's and error handling to every test.

2 2

Re: [PATCH 9/9] msvcp110: Add tr2_sys__Statvfs_wchar implementation and test.
by Marvin 10 Aug '15

10 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15925 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: m[PATCH 8/9] svcp110: Add tr2_sys__Rename_wchar implementation and test.
by Marvin 10 Aug '15

10 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15924 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 7/9] msvcp110: Add tr2_sys__Copy_file_wchar implementation and test.
by Marvin 10 Aug '15

10 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15923 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 7/7] d3d11/tests: Add test for device feature level.
by Józef Kucia 10 Aug '15

10 Aug '15

Please ignore this patchset. I've sent it before subscribing to wine-patches and hoped that it won't reach the mailing list. It should be superseded by the version which reached the mailing list earlier. I'm sorry for the inconvenience. -- Józef Kucia

1 0

Re: msxml3: Handle NULL parameter in IXMLDOMElement::get_ownerDocument(). (try 4)
by Nikolay Sivov 09 Aug '15

09 Aug '15

This looks okay to me (assuming it passes testbot of course).

1 0

Re: comctl32/tests: Add ARM and ARM64 arch strings
by Marvin 09 Aug '15

09 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15887 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] mshtml: Add IHTMLSelectElement::name property implementation.
by Jacek Caban 07 Aug '15

07 Aug '15

On 08/07/15 12:12, Zhenbo Li wrote: > - if(NS_SUCCEEDED(nsres)) { > - static const WCHAR wszGarbage[] = {'g','a','r','b','a','g','e',0}; > > - nsAString_GetData(&name_str, &name); > + nsAString_GetData(&name_str, &name); > + if(*name) > + *p = SysAllocString(name); > + else > + *p = NULL; > + nsAString_Finish(&name_str); > > - /* > - * Native never returns empty string here. If an element has no name, > - * name of previous element or ramdom data is returned. > - */ > - *p = SysAllocString(*name ? name : wszGarbage); > - }else { > + if(NS_FAILED(nsres)) { > ERR("GetName failed: %08x\n", nsres); > + return E_FAIL; > } > - > - nsAString_Finish(&name_str); > - > - TRACE("name=%s\n", debugstr_w(*p)); > return S_OK; Why don't you use return_nsstr? Jacek

1 0

Assorted spelling fixes.
by Hugh McMaster 07 Aug '15

07 Aug '15

Hi Francois, Just some suggestions to improve your patch. Feel free to use the suggestions (or not). On Friday, 7 August 2015 11:56:27 +0200 (CEST), Francois Gouget wrote: >- /* for keyframes allow to consume all unused bytes */ >+ /* for keyframes allow consuming all the unused bytes */ What about "allow keyframes to consume all unused bytes"? >- /* must we check for framesize to gain requested >- * datarate or could we trust codec? */ >+ /* must we check for frame size to gain requested >+ * data rate or could we trust the codec? */ "must we check for frame size to gain the requested data rate or can we trust the codec?" >+ * This would allow framing items (iterator_frameditems), >+ * and finding the nearest item (LVFI_NEARESTXY) a lot more efficiently. "This would allow us to frame items (iterator_frameditems) and find the nearest item (LVFI_NEARESTXY) far more efficiently." >- /* to make tests pass we follow Windows behaviour and allow to read these fields only >+ /* to make tests pass we follow Windows behaviour and allow reading these fields only "...we follow Windows' behaviour..." (apostrophe) >- * Since, we're also allow to load ELF (pure) libraries and Wine ELF libraries >+ * Since, we also allow loading ELF (pure) libraries and Wine ELF libraries "Since we also allow..." (no comma) >- /* XP doesn't allow to create bitmaps larger than 128 Mb */ >+ /* XP doesn't allow creating bitmaps larger than 128 MB */ "XP doesn't allow the creation of bitmaps larger than 128 MB" >- FIXME("Mode doesn't allow to wrap. However, we should allow to overwrite current string\n"); >+ FIXME("Mode doesn't allow wrapping. However, we should allow overwriting the current string\n"); "... However, we should allow the current string to be overwritten\n" >- /* win7 doesn't allow to create a thread during process shutdown, >+ /* win7 doesn't allow creating a thread during process shutdown but "win7 doesn't allow threads to be created during process shutdown, but..." >- /* win7 doesn't allow to create a thread during process shutdown, >- * earlier Windows versions allow it, and DLL_THREAD_DETACH is >+ /* win7 doesn't allow creating a thread during process shutdown but >+ * earlier Windows versions allow it. In that case DLL_THREAD_DETACH is Same here. >- * Native localui does not allow to delete a COM / LPT - Port (ERROR_NOT_SUPPORTED) >+ * Native localui does not allow deleting a COM / LPT - Port (ERROR_NOT_SUPPORTED) "...does not allow COM/LPT-Ports to be deleted..."

1 0

Re: dmobject: Remove unused unimpl_IPersistStream_GetClassID() functions.
by Nikolay Sivov 07 Aug '15

07 Aug '15

It's better to keep this, so dmobject* copies don't differ.

2 1

Re: d2d1: Make d2d_geometry_sink_vtbl static.
by Henri Verbeet 07 Aug '15

07 Aug '15

On 7 August 2015 at 12:42, Francois Gouget <fgouget(a)free.fr> wrote: > --- > dlls/d2d1/geometry.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d2d1/geometry.c b/dlls/d2d1/geometry.c > index 056923e..beebf73 100644 > --- a/dlls/d2d1/geometry.c > +++ b/dlls/d2d1/geometry.c > @@ -1299,7 +1299,7 @@ static void STDMETHODCALLTYPE d2d_geometry_sink_AddArc(ID2D1GeometrySink *iface, > ++geometry->u.path.segment_count; > } > > -struct ID2D1GeometrySinkVtbl d2d_geometry_sink_vtbl = > +static struct ID2D1GeometrySinkVtbl d2d_geometry_sink_vtbl = It should actually be const too.

1 0

Re: [PATCH 1/2] include: Add ntifs.h with Reparse point related definitions and typedefs.(try 3)
by Piotr Caban 07 Aug '15

07 Aug '15

Hi, On 08/05/15 07:45, YongHao Hu wrote: > +typedef struct _REPARSE_MOUNTPOINT_DATA_BUFFER > +{ > + DWORD ReparseTag; > + DWORD ReparseDataLength; > + WORD Reserved; > + WORD ReparseTargetLength; > + WORD ReparseTargetMaximumLength; > + WORD Reserved1; > + WCHAR ReparseTarget[1]; > +} REPARSE_MOUNTPOINT_DATA_BUFFER, *PREPARSE_MOUNTPOINT_DATA_BUFFER; This structure is not defined in native ntifs.h. I don't know if it's acceptable to add it in wine. I think that it may be easier to get sys::tr2::_Stat implementation to wine without tests on reparse points. You can add this tests later but I'm not sure if they belong to msvcp tests. Thanks, Piotr

3 5

Re: [6/7] vcomp: Implement _vcomp_enter_critsect and _vcomp_leave_critsect.
by Nikolay Sivov 07 Aug '15

07 Aug '15

On 07.08.2015 9:22, Sebastian Lackner wrote: >However, this does not fully prevent a > leak when frequently unloading / reloading a library using OpenMP... sounds a bit > like a design flaw to me. You could keep a list of allocations to fix that if it's really a problem.

2 3

Re: Re: d3drm: Implement IDirect3DRMDevice{2-3}::GetDirect3DDevice2 (try 2).
by Marvin 06 Aug '15

06 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15844 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Implement IDirect3DRMDevice{2-3}::GetDirect3DDevice2 (try 2).
by Aaryaman Vasishta 06 Aug '15

06 Aug '15

This patch supersedes patch 113488. On Fri, Aug 7, 2015 at 3:50 AM, Aaryaman Vasishta <jem456.vasishta(a)gmail.com > wrote: > --- > dlls/d3drm/device.c | 7 ++++- > dlls/d3drm/tests/d3drm.c | 68 > ++++++++++++++---------------------------------- > 2 files changed, 26 insertions(+), 49 deletions(-) > > diff --git a/dlls/d3drm/device.c b/dlls/d3drm/device.c > index 1de6f91..26240c1 100644 > --- a/dlls/d3drm/device.c > +++ b/dlls/d3drm/device.c > @@ -1325,7 +1325,12 @@ static DWORD WINAPI > d3drm_device3_GetRenderMode(IDirect3DRMDevice3 *iface) > > static HRESULT WINAPI d3drm_device3_GetDirect3DDevice2(IDirect3DRMDevice3 > *iface, IDirect3DDevice2 **d3d_device) > { > - FIXME("iface %p, d3d_device %p stub!\n", iface, d3d_device); > + struct d3drm_device *device = impl_from_IDirect3DRMDevice3(iface); > + > + TRACE("iface %p, d3d_device %p.\n", iface, d3d_device); > + > + if (device->device) > + return IDirect3DDevice_QueryInterface(device->device, > &IID_IDirect3DDevice2, (void**)d3d_device); > > return E_NOTIMPL; > } > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 2d25bf3..52b0d9a 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -2185,9 +2185,7 @@ static void test_create_device_from_clipper2(void) > > /* Fetch immediate mode device in order to access render target */ > hr = IDirect3DRMDevice2_GetDirect3DDevice2(device2, &d3ddevice2); > - todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface > (hr = %x).\n", hr); > - if (FAILED(hr)) > - goto cleanup; > + ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface (hr = > %x).\n", hr); > > hr = IDirect3DDevice2_GetRenderTarget(d3ddevice2, &surface); > ok(hr == DD_OK, "Cannot get surface to the render target (hr = > %x).\n", hr); > @@ -2263,7 +2261,7 @@ static void test_create_device_from_clipper2(void) > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref2, "expected ref3 == ref2, got ref2 = %u , ref3 = > %u.\n", ref2, ref3); > cref2 = get_refcount((IUnknown *)clipper); > - todo_wine ok(cref1 == cref2, "expected cref1 == cref2, got cref1 = > %u, cref2 = %u.\n", cref1, cref2); > + ok(cref1 == cref2, "expected cref1 == cref2, got cref1 = %u, cref2 = > %u.\n", cref1, cref2); > > /* Test if render target format follows the screen format */ > hr = IDirectDraw_GetDisplayMode(ddraw, &desc); > @@ -2279,9 +2277,7 @@ static void test_create_device_from_clipper2(void) > ok(hr == D3DRM_OK, "Cannot create IDirect3DRMDevice2 interface (hr = > %x).\n", hr); > > hr = IDirect3DRMDevice2_GetDirect3DDevice2(device2, &d3ddevice2); > - todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface > (hr = %x).\n", hr); > - if (FAILED(hr)) > - goto cleanup; > + ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface (hr = > %x).\n", hr); > > hr = IDirect3DDevice2_GetRenderTarget(d3ddevice2, &surface); > ok(hr == DD_OK, "Cannot get surface to the render target (hr = > %x).\n", hr); > @@ -2295,23 +2291,13 @@ static void test_create_device_from_clipper2(void) > hr = IDirectDraw2_RestoreDisplayMode(ddraw); > ok(SUCCEEDED(hr), "RestoreDisplayMode failed, hr %#x.\n", hr); > > -cleanup: > - if (ds) > - IDirectDrawSurface_Release(ds); > - if (surface) > - IDirectDrawSurface_Release(surface); > - if (d3ddevice2) > - IDirect3DDevice2_Release(d3ddevice2); > - if (device2) > - IDirect3DRMDevice2_Release(device2); > - if (d3drm2) > - IDirect3DRM2_Release(d3drm2); > - if (d3drm1) > - IDirect3DRM_Release(d3drm1); > - if (clipper) > - IDirectDrawClipper_Release(clipper); > - if (ddraw) > - IDirectDraw_Release(ddraw); > + IDirectDrawSurface_Release(surface); > + IDirect3DDevice2_Release(d3ddevice2); > + IDirect3DRMDevice2_Release(device2); > + IDirect3DRM2_Release(d3drm2); > + IDirect3DRM_Release(d3drm1); > + IDirectDrawClipper_Release(clipper); > + IDirectDraw_Release(ddraw); > DestroyWindow(window); > } > > @@ -2373,9 +2359,7 @@ static void test_create_device_from_clipper3(void) > > /* Fetch immediate mode device in order to access render target */ > hr = IDirect3DRMDevice3_GetDirect3DDevice2(device3, &d3ddevice2); > - todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface > (hr = %x).\n", hr); > - if (FAILED(hr)) > - goto cleanup; > + ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface (hr = > %x).\n", hr); > > hr = IDirect3DDevice2_GetRenderTarget(d3ddevice2, &surface); > ok(hr == DD_OK, "Cannot get surface to the render target (hr = > %x).\n", hr); > @@ -2451,7 +2435,7 @@ static void test_create_device_from_clipper3(void) > ref3 = get_refcount((IUnknown *)d3drm3); > ok(ref3 == ref2, "expected ref3 == ref2, got ref2 = %u , ref3 = > %u.\n", ref2, ref3); > cref2 = get_refcount((IUnknown *)clipper); > - todo_wine ok(cref1 == cref2, "expected cref1 == cref2, got cref1 = > %u, cref2 = %u.\n", cref1, cref2); > + ok(cref1 == cref2, "expected cref1 == cref2, got cref1 = %u, cref2 = > %u.\n", cref1, cref2); > > /* Test if render target format follows the screen format */ > hr = IDirectDraw_GetDisplayMode(ddraw, &desc); > @@ -2467,9 +2451,7 @@ static void test_create_device_from_clipper3(void) > ok(hr == D3DRM_OK, "Cannot create IDirect3DRMDevice3 interface (hr = > %x).\n", hr); > > hr = IDirect3DRMDevice3_GetDirect3DDevice2(device3, &d3ddevice2); > - todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface > (hr = %x).\n", hr); > - if (FAILED(hr)) > - goto cleanup; > + ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface (hr = > %x).\n", hr); > > hr = IDirect3DDevice2_GetRenderTarget(d3ddevice2, &surface); > ok(hr == DD_OK, "Cannot get surface to the render target (hr = > %x).\n", hr); > @@ -2483,23 +2465,13 @@ static void test_create_device_from_clipper3(void) > hr = IDirectDraw2_RestoreDisplayMode(ddraw); > ok(SUCCEEDED(hr), "RestoreDisplayMode failed, hr %#x.\n", hr); > > -cleanup: > - if (ds) > - IDirectDrawSurface_Release(ds); > - if (surface) > - IDirectDrawSurface_Release(surface); > - if (d3ddevice2) > - IDirect3DDevice2_Release(d3ddevice2); > - if (device3) > - IDirect3DRMDevice3_Release(device3); > - if (d3drm3) > - IDirect3DRM3_Release(d3drm3); > - if (d3drm1) > - IDirect3DRM_Release(d3drm1); > - if (clipper) > - IDirectDrawClipper_Release(clipper); > - if (ddraw) > - IDirectDraw_Release(ddraw); > + IDirectDrawSurface_Release(surface); > + IDirect3DDevice2_Release(d3ddevice2); > + IDirect3DRMDevice3_Release(device3); > + IDirect3DRM3_Release(d3drm3); > + IDirect3DRM_Release(d3drm1); > + IDirectDrawClipper_Release(clipper); > + IDirectDraw_Release(ddraw); > DestroyWindow(window); > } > > -- > 2.3.2 (Apple Git-55) > >

1 0

Re: [PATCH 7/8] d3drm: Implement IDirect3DRMDevice::CreateDeviceFromSurface.
by Stefan Dösinger 06 Aug '15

06 Aug '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-08-06 um 00:49 schrieb Aaryaman Vasishta: > device->d3drm = d3drm; > + device->render_target = surface; > IDirect3DRM_AddRef(d3drm); > device->render_target = surface; This is redundant. > + hr = IDirectDrawSurface_AddAttachedSurface(surface, ds); > + IDirectDrawSurface_Release(ds); > + if (FAILED(hr)) > + return hr; > + } You've overshot my suggestion for pre-attached depth stencils a bit. Now you no longer detach application-created depth stencils any more in case CreateDevice() fails, but you also don't detach a depth stencil that you attached. This may even be the correct behavior. If you want you can write a test (e.g. try to pass a color surface without DDSCAPS_3DDEVICE, but *with* a depth stencil attached. See if it is detached. Try to pass a color surface without DDSCAPS_3DDEVICE and see if a depth stencil is attached after the failing CreateDevice call), but I don't think it's worth spending much time on this. My suggestion is to detach if creating the IM device fails, but only if create_z_surface is TRUE. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVw1yLAAoJEN0/YqbEcdMwyJMP/jsXffvDJlssOGTqhDZvVpl0 WBoSf9mClvG7T5Gqz9Kq8tXXZaETSLPdovHryDn3Ux7kJcJllDfE1C/TqP0jc3X8 weQFMEK49TiNsYBItqgVr7v8YU15GMTqyrhwjIH6zTq9XIx27yhAecKNExb10nfD u32ebnJ//Eh90qkfIe6uvSytFUGmjs0OWZjPlneBbEPOj0jyGMFOyNX3IxN1bB6f czAxJBr6z8EQ0KHRQK9sq98WmIA2najmfakXPzg2fbE+RYRDPnYgcfQ1KmQdtvb1 b9KhIt7FMmL+O1VqgyNsWTUwUin57I0RpyjdBcZ8F48yblUf07a0qiY9udKawKYB xwAmriEMOd37n9Ip6PguawySmdv7a4Jrd8O0Xcu+FRidUMjzq9ZkgvqNht2OaWgv 2dYOCCR6TuA5dYxD3YaqHgJpUB46KS/vE7Nh8EG/Dh2e6paTQoamBUi15WNG/TQB o5Lr2DlJKuXaJnZYoNLDlYgy88P4/JoDvRBLYekbO/fDB1sqMgdBJbRlKGoy72g5 iIrEUbtMpNNLLpxw+ChwH7Gb5U8LZJWMSeyVv8oO/xliir6vF9Dm/sCt4b+bK4uM Y5Q2hC10oEd6jHkbdSKdU6/C8oyKMcfBQJ9adiiQWF+wXQoOPcsaDxwDILVmInGy /3lu18CaUtUdBEhoX/PR =JeVt -----END PGP SIGNATURE-----

2 1

Re: [PATCH 0/3] mshtml: Image map support
by Alex Henrie 06 Aug '15

06 Aug '15

2015-08-04 8:36 GMT-06:00 Alex Henrie <alexhenrie24(a)gmail.com>: > Hi, > > Could I get some feedback on the following changes before I submit them > to wine-patches? Shoot, I just sent these to wine-patches by accident instead of wine-devel. Feedback would still be appreciated. -Alex

2 4

Re: [4/4] msvcirt: Implement filebuf::setbuf
by Piotr Caban 06 Aug '15

06 Aug '15

On 08/05/15 20:32, Iván Matellanes wrote: > @@ -1000,8 +1000,14 @@ streampos __thiscall filebuf_seekoff(filebuf *this, streamoff offset, ios_seek_d > DEFINE_THISCALL_WRAPPER(filebuf_setbuf, 12) > streambuf* __thiscall filebuf_setbuf(filebuf *this, char *buffer, int length) > { > - FIXME("(%p %p %d) stub\n", this, buffer, length); > - return NULL; > + streambuf *ret; > + > + TRACE("(%p %p %d)\n", this, buffer, length); > + > + streambuf_lock(&this->base); > + ret = streambuf_setbuf(&this->base, buffer, length); > + streambuf_unlock(&this->base); > + return ret; > } It doesn't look correct if buffer was already set. Probably the function needs to sync previous buffer or return error in this case. Thanks, Piotr

2 1

Re: [PATCH 1/3] dwrite: Properly initialize LOGFONT returned from ConvertFontToLOGFONT()
by Alexandre Julliard 06 Aug '15

06 Aug '15

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Tue, 4 Aug 2015 21:40:52 +0300 > Subject: [PATCH 1/4] dwrite: Properly initialize LOGFONT returned from > ConvertFontToLOGFONT() > > --- > dlls/dwrite/gdiinterop.c | 2 ++ > dlls/dwrite/tests/font.c | 34 +++++++++++++++++++++++++++++++++- > 2 files changed, 35 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M dwrite.dll -p dwrite_test.exe.so font && touch font.ok font.c:2767: Test failed: got 300 font.c:3028: Tests skipped: Courier New font not found. font.c:4030: Tests skipped: Skipping tests with Arial Makefile:202: recipe for target 'font.ok' failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/8] d3drm: Implement IDirect3DRMDevice::CreateDeviceFromClipper.
by Stefan Dösinger 06 Aug '15

06 Aug '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-08-06 um 00:49 schrieb Aaryaman Vasishta:> + IDirect3DRMDevice *device1; ... hr = > + IDirect3DRMDevice *device1; > ... > hr = IDirect3DRM_CreateDeviceFromClipper(d3drm1, clipper, &driver, 0, 0, &device1); > - todo_wine ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %x.\n", hr); > - if (SUCCEEDED(hr)) > - IDirect3DRMDevice_Release(device1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %x.\n", hr); > + ok(device1 == NULL, "Expected device returned == NULL, got %p.\n", device1); Set device1 = (IDirect3DRMDevice *)0xdeadbeef before calling CreateDeviceFromClipper, otherwise the device == NULL check isn't worth much at the end. (You don't know if its NULL because IDirect3DRM::CreateDeviceFromClipper set it to NULL or because it happened to randomly contain NULL at the start of the function. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVw1NZAAoJEN0/YqbEcdMwSkcP/1NMXYG2m/OkDgVhrAg3kLB3 RRu4egHLkAPpxx9Ms0iAqfl9NtbhtlQpFBjOdwmdElOQbjRZFVpU5pUhFQO4jgbo ywlrvkXYJvmsYWjMTzNFKM0vZaNO6uRQK/pg/QWwqCW+xlunCyHa8vWLzu4u34sB FqGfjOeS/FoQkH2IYnFjpSV12Org9wJC+GVwqw8h1yfgiW3lKaCgRUcA0pRNgC5o l4OlkLhnAC9EqvdSHDgW+A9UkslVDMZq7iq5XFNCasRKqPixCoEsXXu8LH3JakCI 3WOn0z8bgelcLl8Z6xr4dXO5iKvw2Ff1DxKPnmQrykzY2E4OQkZdjqMznXKNqq3g SVXqHq23KuU+CMkimeyDLd8z7brIQfud5W2Ru9/PIWrftuU3y+TgKjZR9awC7pT/ dXF8cCwPOa33MEOUAL2syunC/nAf7RDhBeCnWtj0G9wKGXWdnqFlzIaKVr4sO0wQ RO457ySvXReGkhxe7Df178VQfst9jppCA0FR7m+MlNe8BP31gNEfUvHi0HxYnD4r lyOXA3ltnhgirKhR070wHOPVbR2ZqWuwe4Qv+QAmwYJup95IU6UsXDBcU5VVHNqa 9U+Mb9+FTfcPkgKX60AHJiWdgMsPvuYIKrNoYPBLexv+x1uYdCTr6iB1YQnHCQee jyRW8O7NLo/lxDIAJsh0 =5ZQO -----END PGP SIGNATURE-----

2 2

Re: [PATCH 2/2] msvcp110: Add tr2_sys__Stat and tr2_sys__Lstat implementation and test.（try2 resend)
by Piotr Caban 06 Aug '15

06 Aug '15

On 08/05/15 07:46, YongHao Hu wrote: > +enum file_type tr2_sys__Stat(char const* path, int* err_code) > +enum file_type tr2_sys__Lstat(char const* path, int* err_code) Calling conventions are missing here. Thanks, Piotr

1 0

Re: [3/4] msvcirt: Implement filebuf::setmode
by Piotr Caban 06 Aug '15

06 Aug '15

On 08/05/15 20:32, Iván Matellanes wrote: > diff --git a/dlls/msvcirt/msvcirt.c b/dlls/msvcirt/msvcirt.c > index bf89650..0f82f30 100644 > --- a/dlls/msvcirt/msvcirt.c > +++ b/dlls/msvcirt/msvcirt.c > @@ -1009,8 +1009,16 @@ streambuf* __thiscall filebuf_setbuf(filebuf *this, char *buffer, int length) > DEFINE_THISCALL_WRAPPER(filebuf_setmode, 8) > int __thiscall filebuf_setmode(filebuf *this, int mode) > { > - FIXME("(%p %d) stub\n", this, mode); > - return 0; > + int previous; > + > + TRACE("(%p %d)\n", this, mode); > + if (mode != filebuf_text && mode != filebuf_binary) > + return -1; > + > + streambuf_lock(&this->base); > + previous = _setmode(this->fd, mode); > + streambuf_unlock(&this->base); > + return previous; > } The function should empty the buffers before it changes the mode. Also it will be cleaner if filebuf_text and filebuf_binary definition is changed so _O_TEXT and _O_BINARY is used instead of its value. Thanks, Piotr

1 0

D3DRM Implementation patches upto CreateDeviceFromSurface
by Aaryaman Vasishta 05 Aug '15

05 Aug '15

CreateDeviceFromD3D will be pushed as soon as patch 9 is finalised. The main concern right now is the thunking of the Release methods of the device. This concern comes up from the fact that the CreateDeviceFromSurface methods from all 3 versions behave the same way except for one difference in version 3, which I mention below. When you create a device from IDirect3DRM3::CreateDeviceFromSurface and release it, native will also destroy the depth surface attached to it (if it created it internally), otherwise it'll let the application keep the reference to the depth surface it created. Other than the above peculiarity, the behaviour is identical. I've attached all the commits which lead to the point of implementing CreateDeviceFromSurface. Please, review the patches as much as you'd like and if possible, provide feedback and suggestions on any improvements that can be made, possible comments required, any stupid mistakes I made etc. :) Thank you! Aaryaman

2 20

Re: [PATCH 1/2] d3dx9: Correctly handle whitespace character in D3DXCreateText. (try 2 resend)
by Marvin 05 Aug '15

05 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15799 Your paranoid android. === w8 (32 bit mesh) === mesh.c:8258: Test failed: Mesh 26: new_num_vertices == 4, expected 6. mesh.c:8272: Test failed: Mesh 26: indices[3] == 1, expected 3 mesh.c:8272: Test failed: Mesh 26: indices[4] == 3, expected 4 mesh.c:8272: Test failed: Mesh 26: indices[5] == 2, expected 5 mesh.c:8313: Test failed: Mesh 26: vertex_remap_ptr[3] == 4, expected 3 mesh.c:8313: Test failed: Mesh 26: vertex_remap_ptr[4] == -1, expected 4 mesh.c:8313: Test failed: Mesh 26: vertex_remap_ptr[5] == -1, expected 5 mesh.c:8328: Test failed: Mesh 26: Got (3.000000, 0.000000, 0.000000) for vertex 3 position, expected (2.000000, 3.000000, 0.000000). mesh.c:8328: Test failed: Mesh 26: Got (255, 255, 255, 255) for vertex 3 undefined color, expected (0, 0, 0, 0). mesh.c:8328: Test failed: Mesh 26: Got (2.000000, 3.000000, 0.000000) for vertex 4 position, expected (3.000000, 0.000000, 0.000000). mesh.c:8328: Test failed: Mesh 26: Got (255, 255, 255, 255) for vertex 5 undefined color, expected (1, 1, 1, 1).

1 0

Re: reg: implement reg query operation
by Stefan Dösinger 05 Aug '15

05 Aug '15

Hi, > +#define MAX_NAME_BUFFER 255 > +#define MAX_VALUE_BUFFER 16383 I don't like this. Ideally the code should query the lengths from the Registry APIs and allocate appropriate buffers. If the Reg* functions guarantee a maximum size use defines from the public headers. > +static const WCHAR fmt_value[] = {' ',' ',' ','%','s',' ','%','s',' ','%','s','\n',0}; This is used in print_value() only, you can move it into this function. > +static const WCHAR no_name[] = { 'n','o','_','n','a','m','e',0 }; Is this used for the default value? Is "no_name" the right choice? Does this need localization? > + hkey = get_rootkey(key_name); > + subkey_name = strchrW(key_name, '\\'); > + if (NULL == hkey || NULL == subkey_name) > + { > + reg_printfW(fmt_err, key_name); > + return 1; > + } Are you sure that this is the right behavior? I haven't checked, but I can imagine that I can e.g. have a string value directly in HKEY_CURRENT_USER, in which case subkey_name would be NULL. > + value_buffer = HeapAlloc(GetProcessHeap(), 0, MAX_VALUE_BUFFER); Please check for allocation errors. If you do stay with the fixed size buffer, do you need HeapAlloc at all? Can't you just put this on the stack? On a related note, passing value_buffer to the two helper functions but not its length, and setting value_len in those functions is ugly. This way the helper functions depend on an implementation detail of their caller. Yeah, the #define makes it a bit better, but it's still not pretty. > + run_reg_exe("reg Query HKCU\\" KEY_BASE " /ve", &r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + > + run_reg_exe("reg Query HKCU\\" KEY_BASE " /v test0", &r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + > + run_reg_exe("reg Query HKCU\\" KEY_BASE " /s", &r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); > + > + run_reg_exe("reg delete HKCU\\" KEY_BASE " /f", &r); > + ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); Some tests for error cases would be helpful as well, including all the error checks you have in your code. I expect scripts to parse the output of this command. Please add some tests that check the output. There's infrastructure for reading command output in other program tests that you can use. The following are style issues. I'm pointing them out while I'm at it, please fix them as well. > +static void query_sub(HKEY hkey, WCHAR* key_name, WCHAR* value_buffer) (Style) WCHAR *key_name please. "WCHAR*" is more common in C++. > + HKEY hsubkey = NULL; > + HKEY hkey = NULL; (Style) Please drop the h from these names. > + ret = RegOpenKeyExW( hkey, subkey_name+1, 0, KEY_READ, &hsubkey ); (Style) inconsistent space after parenthesis. > + if (ret == ERROR_SUCCESS ) Same > + static const WCHAR* reg_type[] = { > + type_none, > + type_sz, (Style) { placement

2 1

Re: widl: Added support for -ns_prefix option.
by Sebastian Lackner 05 Aug '15

05 Aug '15

On 04.08.2015 14:26, Jacek Caban wrote: > --- > tools/widl/header.c | 10 ++++++++-- > tools/widl/parser.l | 3 +++ > tools/widl/typetree.c | 12 ++++++++++-- > tools/widl/widl.c | 6 ++++++ > tools/widl/widl.h | 1 + > tools/widl/widl.man.in | 2 ++ > 6 files changed, 30 insertions(+), 4 deletions(-) > [...] > winrt_mode = 1; > break; > + case RT_NS_PREFIX: > + use_abi_namespace = 1; > case WIN32_OPTION: > do_win32 = 1; > do_win64 = 0; Is there maybe a break missing?

2 1

Re: msxml3: Handle NULL parameter in IXMLDOMElement::get_ownerDocument(). (try 2)
by Nikolay Sivov 05 Aug '15

05 Aug '15

On 31.07.2015 12:12, Zhenbo Li wrote: > try 2: > Test get_ownerDocument for more xml nodes. > > --- > dlls/msxml3/node.c | 2 ++ > dlls/msxml3/tests/domdoc.c | 51 > ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 53 insertions(+) > Hi. This looks fine to me. It would be nice to test attribute node too (I don't think it appears in children list, but it's been a while since I looked into it), but it's not a blocking issue.

1 0

Re:TestBot job 15747 results: quartz: waveparser support wav file generated by ffmpeg
by Changhui LIU 05 Aug '15

05 Aug '15

Hi Alexandre: The error code 80040256 is VFW_E_NO_AUDIO_HARDWARE, According to MSDN, the detail info is: Cannot play back the audio stream: no audio hardware is available, or the hardware is not supported. So these test failed on 64 bit windows is not caused by my patch: http://source.winehq.org/patches/data/113403 ------------------ Regards, Changhui Liu ------------------ Original ------------------ From: "Marvin"<testbot(a)winehq.org>; Date: Tue, Aug 4, 2015 07:04 PM To: "liuchanghui"<liuchanghui(a)linuxdeepin.com>; Subject: TestBot job 15747 results: quartz: waveparser support wav file generated by ffmpeg VM Status Number of test failures build completed w2000pro completed 0 wxppro completed 0 w2003std completed 0 wvistau64 completed 2 w2008s64 completed 2 w7u completed 0 w8 completed 0 wvistau64 completed 2 w2008s64 completed 2 === build (build) === No build failures found === w2000pro (32 bit filtergraph) === No test failures found === wxppro (32 bit filtergraph) === No test failures found === w2003std (32 bit filtergraph) === No test failures found === wvistau64 (32 bit filtergraph) === quartz: filtergraph.c:165: Test failed: RenderFile returned: 80040256 filtergraph.c:83: Test failed: Cannot run the graph returned: 0 === w2008s64 (32 bit filtergraph) === quartz: filtergraph.c:165: Test failed: RenderFile returned: 80040256 filtergraph.c:83: Test failed: Cannot run the graph returned: 0 === w7u (32 bit filtergraph) === No test failures found === w8 (32 bit filtergraph) === No test failures found === wvistau64 (64 bit filtergraph) === quartz: filtergraph.c:165: Test failed: RenderFile returned: 80040256 filtergraph.c:83: Test failed: Cannot run the graph returned: 0 === w2008s64 (64 bit filtergraph) === quartz: filtergraph.c:165: Test failed: RenderFile returned: 80040256 filtergraph.c:83: Test failed: Cannot run the graph returned: 0

1 0

Re: [PATCH] d3dx9: Correctly handle whitespace character in D3DXCreateText. (try 2)
by Matteo Bruni 04 Aug '15

04 Aug '15

2015-08-02 22:29 GMT+02:00 Józef Kucia <joseph.kucia(a)gmail.com>: > Fixes bug 38976. > > Try 2: Remove useless hr assignments. > --- > dlls/d3dx9_36/mesh.c | 4 ++ > dlls/d3dx9_36/tests/mesh.c | 168 ++++++++++++++++++++++++--------------------- > 2 files changed, 94 insertions(+), 78 deletions(-) > > diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c > index d0459da..39d279d 100644 > --- a/dlls/d3dx9_36/mesh.c > +++ b/dlls/d3dx9_36/mesh.c > @@ -5847,6 +5847,10 @@ static HRESULT triangulate(struct triangulation_array *triangulations) > int i; > struct point2d_index *idx_ptr; > > + /* Glyphs without outlines do not generate any vertices. */ > + if (!glyph->outlines.count) > + return D3D_OK; > + > for (i = 0; i < glyph->outlines.count; i++) > nb_vertices += glyph->outlines.items[i].count; > > diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c > index 0243a61..16c79ea 100644 > --- a/dlls/d3dx9_36/tests/mesh.c > +++ b/dlls/d3dx9_36/tests/mesh.c > @@ -3617,57 +3617,17 @@ static HRESULT create_outline(struct glyphinfo *glyph, void *raw_outline, int da > return S_OK; > } > > -static BOOL compute_text_mesh(struct mesh *mesh, HDC hdc, const char *text, > - float deviation, float extrusion, float otmEMSquare) > +static BOOL compute_text_mesh(struct mesh *mesh, const char *text, > + float deviation, float extrusion, float otmEMSquare, const struct glyphinfo *glyphs) > { > - HRESULT hr = E_FAIL; > DWORD nb_vertices, nb_faces; > DWORD nb_corners, nb_outline_points; > int textlen = 0; > - float offset_x; > - char *raw_outline = NULL; > - struct glyphinfo *glyphs = NULL; > - GLYPHMETRICS gm; > int i; > struct vertex *vertex_ptr; > face *face_ptr; > > - if (deviation == 0.0f) > - deviation = 1.0f / otmEMSquare; > - > textlen = strlen(text); > - glyphs = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, textlen * sizeof(*glyphs)); > - if (!glyphs) { > - hr = E_OUTOFMEMORY; > - goto error; > - } > - > - offset_x = 0.0f; > - for (i = 0; i < textlen; i++) > - { > - /* get outline points from data returned from GetGlyphOutline */ > - const MAT2 identity = {{0, 1}, {0, 0}, {0, 0}, {0, 1}}; > - int datasize; > - > - glyphs[i].offset_x = offset_x; > - > - datasize = GetGlyphOutlineA(hdc, text[i], GGO_NATIVE, &gm, 0, NULL, &identity); > - if (datasize < 0) { > - hr = E_FAIL; > - goto error; > - } > - HeapFree(GetProcessHeap(), 0, raw_outline); > - raw_outline = HeapAlloc(GetProcessHeap(), 0, datasize); > - if (!raw_outline) { > - hr = E_OUTOFMEMORY; > - goto error; > - } > - datasize = GetGlyphOutlineA(hdc, text[i], GGO_NATIVE, &gm, datasize, raw_outline, &identity); > - > - create_outline(&glyphs[i], raw_outline, datasize, deviation, otmEMSquare); > - > - offset_x += gm.gmCellIncX / (float)otmEMSquare; > - } > > /* corner points need an extra vertex for the different side faces normals */ > nb_corners = 0; > @@ -3691,7 +3651,7 @@ static BOOL compute_text_mesh(struct mesh *mesh, HDC hdc, const char *text, > nb_faces = nb_outline_points * 2; > > if (!new_mesh(mesh, nb_vertices, nb_faces)) > - goto error; > + return FALSE; > > /* convert 2D vertices and faces into 3D mesh */ > vertex_ptr = mesh->vertices; > @@ -3801,24 +3761,11 @@ static BOOL compute_text_mesh(struct mesh *mesh, HDC hdc, const char *text, > vertex_ptr++; > } > > - hr = D3D_OK; > -error: > - if (glyphs) { > - for (i = 0; i < textlen; i++) > - { > - int j; > - for (j = 0; j < glyphs[i].outlines.count; j++) > - HeapFree(GetProcessHeap(), 0, glyphs[i].outlines.items[j].items); > - HeapFree(GetProcessHeap(), 0, glyphs[i].outlines.items); > - } > - HeapFree(GetProcessHeap(), 0, glyphs); > - } > - HeapFree(GetProcessHeap(), 0, raw_outline); > - > - return hr == D3D_OK; > + return TRUE; > } > > -static void compare_text_outline_mesh(const char *name, ID3DXMesh *d3dxmesh, struct mesh *mesh, int textlen, float extrusion) > +static void compare_text_outline_mesh(const char *name, ID3DXMesh *d3dxmesh, struct mesh *mesh, > + size_t textlen, float extrusion, const struct glyphinfo *glyphs) > { > HRESULT hr; > DWORD number_of_vertices, number_of_faces; > @@ -3936,13 +3883,20 @@ static void compare_text_outline_mesh(const char *name, ID3DXMesh *d3dxmesh, str > > first_vtx1 = vtx_idx1; > first_vtx2 = vtx_idx2; > - for (; vtx_idx1 < number_of_vertices; vtx_idx1++) { > - if (vertices[vtx_idx1].normal.z != 0) > - break; > - } > - for (; vtx_idx2 < mesh->number_of_vertices; vtx_idx2++) { > - if (mesh->vertices[vtx_idx2].normal.z != 0) > - break; > + /* Glyphs without outlines do not generate any vertices. */ > + if (glyphs[i].outlines.count > 0) > + { > + for (; vtx_idx1 < number_of_vertices; vtx_idx1++) > + { > + if (vertices[vtx_idx1].normal.z != 0) > + break; > + } > + > + for (; vtx_idx2 < mesh->number_of_vertices; vtx_idx2++) > + { > + if (mesh->vertices[vtx_idx2].normal.z != 0) > + break; > + } > } > nb_outline_vertices1 = vtx_idx1 - first_vtx1; > nb_outline_vertices2 = vtx_idx2 - first_vtx2; > @@ -4124,15 +4078,19 @@ error: > static void test_createtext(IDirect3DDevice9 *device, HDC hdc, const char *text, float deviation, float extrusion) > { > HRESULT hr; > - ID3DXMesh *d3dxmesh; > - struct mesh mesh; > + ID3DXMesh *d3dxmesh = NULL; > + struct mesh mesh = {0}; > char name[256]; > OUTLINETEXTMETRICA otm; > GLYPHMETRICS gm; > + struct glyphinfo *glyphs = NULL; > GLYPHMETRICSFLOAT *glyphmetrics_float = HeapAlloc(GetProcessHeap(), 0, sizeof(GLYPHMETRICSFLOAT) * strlen(text)); > int i; > LOGFONTA lf; > + float offset_x; > + size_t textlen; > HFONT font = NULL, oldfont = NULL; > + char *raw_outline = NULL; > > sprintf(name, "text ('%s', %f, %f)", text, deviation, extrusion); > > @@ -4141,7 +4099,7 @@ static void test_createtext(IDirect3DDevice9 *device, HDC hdc, const char *text, > if (hr != D3D_OK) > { > skip("Couldn't create text with D3DXCreateText\n"); > - return; > + goto error; > } > > /* must select a modified font having lfHeight = otm.otmEMSquare before > @@ -4149,21 +4107,25 @@ static void test_createtext(IDirect3DDevice9 *device, HDC hdc, const char *text, > if (!GetObjectA(GetCurrentObject(hdc, OBJ_FONT), sizeof(lf), &lf) > || !GetOutlineTextMetricsA(hdc, sizeof(otm), &otm)) > { > - d3dxmesh->lpVtbl->Release(d3dxmesh); > skip("Couldn't get text outline\n"); > - return; > + goto error; > } > lf.lfHeight = otm.otmEMSquare; > lf.lfWidth = 0; > if (!(font = CreateFontIndirectA(&lf))) > { > - d3dxmesh->lpVtbl->Release(d3dxmesh); > skip("Couldn't create the modified font\n"); > - return; > + goto error; > } > + > + textlen = strlen(text); > + glyphs = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, textlen * sizeof(*glyphs)); > + if (!glyphs) > + goto error; > + > oldfont = SelectObject(hdc, font); > > - for (i = 0; i < strlen(text); i++) > + for (i = 0; i < textlen; i++) > { > const MAT2 identity = {{0, 1}, {0, 0}, {0, 0}, {0, 1}}; > GetGlyphOutlineA(hdc, text[i], GGO_NATIVE, &gm, 0, NULL, &identity); > @@ -4175,8 +4137,42 @@ static void test_createtext(IDirect3DDevice9 *device, HDC hdc, const char *text, > compare_float(glyphmetrics_float[i].gmfCellIncY, gm.gmCellIncY / (float)otm.otmEMSquare); > } > > + if (deviation == 0.0f) > + deviation = 1.0f / otm.otmEMSquare; > + > + offset_x = 0.0f; > + for (i = 0; i < textlen; i++) > + { > + /* get outline points from data returned from GetGlyphOutline */ > + const MAT2 identity = {{0, 1}, {0, 0}, {0, 0}, {0, 1}}; > + int datasize; > + > + glyphs[i].offset_x = offset_x; > + > + datasize = GetGlyphOutlineA(hdc, text[i], GGO_NATIVE, &gm, 0, NULL, &identity); > + if (datasize < 0) > + { > + SelectObject(hdc, oldfont); > + goto error; > + } > + HeapFree(GetProcessHeap(), 0, raw_outline); > + raw_outline = HeapAlloc(GetProcessHeap(), 0, datasize); > + if (!raw_outline) > + { > + SelectObject(hdc, oldfont); > + goto error; > + } > + datasize = GetGlyphOutlineA(hdc, text[i], GGO_NATIVE, &gm, datasize, raw_outline, &identity); > + > + create_outline(&glyphs[i], raw_outline, datasize, deviation, otm.otmEMSquare); > + > + offset_x += gm.gmCellIncX / (float)otm.otmEMSquare; > + } > + > + SelectObject(hdc, oldfont); > + > ZeroMemory(&mesh, sizeof(mesh)); > - if (!compute_text_mesh(&mesh, hdc, text, deviation, extrusion, otm.otmEMSquare)) > + if (!compute_text_mesh(&mesh, text, deviation, extrusion, otm.otmEMSquare, glyphs)) > { > skip("Couldn't create mesh\n"); > d3dxmesh->lpVtbl->Release(d3dxmesh); > @@ -4184,13 +4180,26 @@ static void test_createtext(IDirect3DDevice9 *device, HDC hdc, const char *text, > } > mesh.fvf = D3DFVF_XYZ | D3DFVF_NORMAL; > > - compare_text_outline_mesh(name, d3dxmesh, &mesh, strlen(text), extrusion); > + compare_text_outline_mesh(name, d3dxmesh, &mesh, textlen, extrusion, glyphs); > > +error: > free_mesh(&mesh); > > - d3dxmesh->lpVtbl->Release(d3dxmesh); > - SelectObject(hdc, oldfont); > + if (d3dxmesh) d3dxmesh->lpVtbl->Release(d3dxmesh); > HeapFree(GetProcessHeap(), 0, glyphmetrics_float); > + > + if (glyphs) > + { > + for (i = 0; i < textlen; i++) > + { > + int j; > + for (j = 0; j < glyphs[i].outlines.count; j++) > + HeapFree(GetProcessHeap(), 0, glyphs[i].outlines.items[j].items); > + HeapFree(GetProcessHeap(), 0, glyphs[i].outlines.items); > + } > + HeapFree(GetProcessHeap(), 0, glyphs); > + } > + HeapFree(GetProcessHeap(), 0, raw_outline); > } It looks like there is a minor (preexisting) issue here, the font is not deleted. Maybe fix that in a followup patch, while you're at it? The patch itself is fine to me though.

1 0

Re: [include] - add new file tcpestats.h
by Sebastian Lackner 04 Aug '15

04 Aug '15

On 04.08.2015 01:19, Vijay Kiran Kamuju wrote: > Changelog > include - add new file tcpestats.h > Your patch contains the same whitespace errors as the mingw header files. As far as I know, copying header files is not allowed, you have to type them yourself (even when the mingw header files are under a public domain license). (If someone else knows better, please correct me.) Regards, Sebastian

1 0

Re: [PATCH 1/2] include: Add ntifs.h with Reparse point related definitions and typedefs.(try 2)
by Sebastian Lackner 04 Aug '15

04 Aug '15

On 04.08.2015 19:58, YongHao Hu wrote: > try 2: > Fix nameless union.(thanks Piotr) > --- > include/Makefile.in | 1 + > include/ntifs.h | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 84 insertions(+) > create mode 100644 include/ntifs.h > > > + ULONG ReparseTag; > + USHORT ReparseDataLength; > + USHORT Reserved; > + union foo > + { > + struct > + { Please use DUMMYUNIONNAME instead, like in the other include files. It should look like this: union { ... } DUMMYUNIONNAME; Regards, Sebastian

1 0

Re: [5/5] msvcirt: Implement filebuf::open/close
by Piotr Caban 04 Aug '15

04 Aug '15

On 08/03/15 16:49, Iván Matellanes wrote: > @@ -884,8 +893,16 @@ filebuf* __thiscall filebuf_attach(filebuf *this, filedesc fd) > DEFINE_THISCALL_WRAPPER(filebuf_close, 4) > filebuf* __thiscall filebuf_close(filebuf *this) > { > - FIXME("(%p) stub\n", this); > - return NULL; > + TRACE("(%p)\n", this); > + if (this->fd == -1) > + return NULL; > + > + streambuf_lock(&this->base); > + call_streambuf_sync(&this->base); Please handle call_streambuf_sync failure here. > /* ?fd@filebuf@@QBEHXZ */ > @@ -911,8 +928,46 @@ int __thiscall filebuf_is_open(const filebuf *this) > DEFINE_THISCALL_WRAPPER(filebuf_open, 16) > filebuf* __thiscall filebuf_open(filebuf *this, const char *name, ios_open_mode mode, int protection) > { > - FIXME("(%p %s %d %d) stub\n", this, name, mode, protection); > - return NULL; > + const int inout_mode[4] = {-1, _O_RDONLY, _O_WRONLY, _O_RDWR}; > + const int share_mode[4] = {_SH_DENYRW, _SH_DENYWR, _SH_DENYRD, _SH_DENYNO}; > + int op_flags, sh_flags, fd; > + > + TRACE("(%p %s %d %d)\n", this, name, mode, protection); It will be easier to read the logs if mode and protection is printed as hexadecimal value. The same way op_flags and sh_flags should be printed. > + if (this->fd != -1) > + return NULL; > + > + /* mode */ > + if (mode & (OPENMODE_app|OPENMODE_trunc)) > + mode |= OPENMODE_out; > + op_flags = inout_mode[mode & (OPENMODE_in|OPENMODE_out)]; > + if (op_flags < 0) > + return NULL; > + if (mode & OPENMODE_app) > + op_flags |= _O_APPEND; > + if ((mode & OPENMODE_trunc) || > + ((mode & OPENMODE_out) && !(mode & (OPENMODE_in|OPENMODE_app|OPENMODE_ate)))) > + op_flags |= _O_TRUNC; > + if (!(mode & OPENMODE_nocreate)) > + op_flags |= _O_CREAT; > + if (mode & OPENMODE_noreplace) > + op_flags |= _O_EXCL; > + op_flags |= (mode & OPENMODE_binary) ? _O_BINARY : _O_TEXT; > + > + /* share protection */ > + sh_flags = (protection & filebuf_sh_none) ? share_mode[(protection >> 9) & 3] : _SH_DENYNO; > + > + TRACE("op_flags %d, sh_flags %d\n", op_flags, sh_flags); > + fd = _sopen(name, op_flags, sh_flags, _S_IREAD|_S_IWRITE); > + if (fd < 0) > + return NULL; > + > + streambuf_lock(&this->base); > + this->fd = fd; > + this->close = 1; > + if (mode & OPENMODE_ate) > + call_streambuf_seekoff(&this->base, 0, SEEKDIR_end, OPENMODE_in|OPENMODE_out); Please handle seek failure here. Thanks, Piotr

1 0

Re: wine.inf: Add UTC Time Zone (try 4)
by Sebastian Lackner 04 Aug '15

04 Aug '15

On 04.08.2015 03:05, Philippe Groarke wrote: > Fixes 39008 > --- > loader/wine.inf.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/loader/wine.inf.in b/loader/wine.inf.in > index 315ef29..30cf5ab 100644 > --- a/loader/wine.inf.in > +++ b/loader/wine.inf.in > @@ -3070,6 +3070,10 @@ HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Display",,"America > HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Dlt",,"US Mountain Daylight Time" > HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Std",,"US Mountain Standard Time" > HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"TZI",1,a4,01,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00 > +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Display",,"Etc/UTC" > +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Dlt",,"Coordinated Universal Time" > +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Std",,"Coordinated Universal Time" > +HKLM,%CurrentVersionNT%\Time Zones\UTC,"TZI",1,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00 > HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Display",,"America/Caracas" > HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Dlt",,"Venezuela Daylight Time" > HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Std",,"Venezuela Standard Time" > Looks good, thanks! :)

1 0

Re: quartz: waveparser support wav file generated by ffmpeg
by Marvin 04 Aug '15

04 Aug '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15747 Your paranoid android. === wvistau64 (32 bit filtergraph) === filtergraph.c:165: Test failed: RenderFile returned: 80040256 filtergraph.c:83: Test failed: Cannot run the graph returned: 0 === w2008s64 (32 bit filtergraph) === filtergraph.c:165: Test failed: RenderFile returned: 80040256 filtergraph.c:83: Test failed: Cannot run the graph returned: 0 === wvistau64 (64 bit filtergraph) === filtergraph.c:165: Test failed: RenderFile returned: 80040256 filtergraph.c:83: Test failed: Cannot run the graph returned: 0 === w2008s64 (64 bit filtergraph) === filtergraph.c:165: Test failed: RenderFile returned: 80040256 filtergraph.c:83: Test failed: Cannot run the graph returned: 0

1 0

Re: [PATCH 4/5] d3d9: Don't assert on invalid IDirect3DBaseTexture9 interfaces.
by Stefan Dösinger 04 Aug '15

04 Aug '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-08-04 um 08:53 schrieb Henri Verbeet: > + texture->lpVtbl = (IDirect3DBaseTexture9Vtbl *)0xdeadbeef; > + hr = IDirect3DDevice9_SetTexture(device, 0, texture); > + ok(SUCCEEDED(hr), "Failed to set texture, hr %#x.\n", hr); I guess you're not testing GetTexture because it crashes when trying to AddRef the texture? > + if (iface->lpVtbl != (const IDirect3DBaseTexture9Vtbl *)&d3d9_texture_2d_vtbl > + && iface->lpVtbl != (const IDirect3DBaseTexture9Vtbl *)&d3d9_texture_cube_vtbl > + && iface->lpVtbl != (const IDirect3DBaseTexture9Vtbl *)&d3d9_texture_3d_vtbl) > + { > + WARN("%p is not a valid IDirect3DBaseTexture8 interface.\n", iface); > + return NULL; > + } Minor copypaste bug ("IDirect3DBaseTexture8"). -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVwHkaAAoJEN0/YqbEcdMwAykP/3XM3HslUzcvJ+d5Jz59febN pBoVG5dJO0uboxYAjuv1Fj6Ft9+CWvcSOva6Oo1cnwV06ojY82oFC5XIQp+UB9xQ nU+T8In0b5IPX82uTSEM6k/uVE3Yycc41DmvD1/VxF29el64Oifn1afOcAg7TRAV f93+yR464vBzx7esXRpXkF5X1xvmsW1LtnJe3Z1uHqNMiZwixn9M33kuceMz0ZqD H9o8Hxn1sESurxR/2cEZFFzHne36l067NY2/HsJ9yeBk90zay+99iojMcWCLhhF2 CHj6xynbxWZCGFSRQM29HtCt/P5nl6lrg/jXeFY8AwmAf0n9NMBOyxqb8c7BVFx/ bSO75oPiyHS8xzBxdgqCuJka18QlTuy40UwNwQTU6TckcHl+MyezthLKAFSRV42i zGjcV0S725bQWy2/S4ep+fuxWaJNT5JKULvcqQxHDo3h/NBLyvHI+fNXMhZGJWdH Z1Xl2lGhoihIieu+2Xo5Jt+ghuecs8RQYIfamsYGQJDIuyovE8PAKGoPy/S+CzyN ypOPjXwhDTEIJpMm0/Gaxc49FkjbHiLjcevJS6wRP5JQJzIrKy94SwPCIhRiQoj7 dLgsiPAppEGLgkhFTQ1DcYvkS4UcPMlN8K0dmcXFiMWgzmfeKm2gnZ9+2p2WfhZf 5FGMz4ENg5TuWxay3YRj =4SY2 -----END PGP SIGNATURE-----

2 1

Re: loader: Add UTC Time Zone
by Sebastian Lackner 04 Aug '15

04 Aug '15

On 03.08.2015 16:32, Philippe Groarke wrote: > Fixes 39008 > --- > loader/wine.inf.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/loader/wine.inf.in b/loader/wine.inf.in > index 315ef29..1627ad6 100644 > --- a/loader/wine.inf.in > +++ b/loader/wine.inf.in > @@ -3070,6 +3070,10 @@ HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Display",,"America > HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Dlt",,"US Mountain Daylight Time" > HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Std",,"US Mountain Standard Time" > HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"TZI",1,a4,01,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00 > +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Display",,"Etc/GMT" I just saw that we have also a unix timezone Etc/UTC, this might be more appropriate (especially to avoid confusion with "GMT Standard Time", which is a separate entry in the file). > +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Dlt",,"Etc/GMT" > +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Std",,"Etc/GMT" For all other entries it contains a human readable name. Something like "Coordinated Universal Time" for both Dlt and Std might be a bit better. > +HKLM,%CurrentVersionNT%\Time Zones\UTC,"TZI",1,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00 > HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Display",,"America/Caracas" > HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Dlt",,"Venezuela Daylight Time" > HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Std",,"Venezuela Standard Time" > Two other remarks: * When you send an updated version, please append "(try N)" to your subject, to make clear which version is newer. * A subject starting with "wine.inf:" might be better, since your patch only touches this single file, not the loader itself. Sorry for not pointing out all those things earlier. Best regards, Sebastian

2 3

Re: [PATCH 1/2] include: Add ntifs.h with Reparse point related definitions and typedefs.
by Piotr Caban 03 Aug '15

03 Aug '15

On 07/29/15 20:01, YongHao Hu wrote: > + union > + { > + struct > + { > + USHORT SubstituteNameOffset; > + USHORT SubstituteNameLength; > + USHORT PrintNameOffset; > + USHORT PrintNameLength; > + ULONG Flags; > + WCHAR PathBuffer[1]; > + } SymbolicLinkReparseBuffer; > + struct > + { > + USHORT SubstituteNameOffset; > + USHORT SubstituteNameLength; > + USHORT PrintNameOffset; > + USHORT PrintNameLength; > + WCHAR PathBuffer[1]; > + } MountPointReparseBuffer; > + struct > + { > + UCHAR DataBuffer[1]; > + } GenericReparseBuffer; > + }; This will not work on some compilers (nameless unions). Thanks, Piotr

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel