- wine-devel - winehq.org

Re: [PATCH 3/5] wined3d: Get rid of wined3d_device_color_fill().
by Stefan Dösinger 22 Aug '14

22 Aug '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-22 12:32, schrieb Henri Verbeet: > + if (desc.pool != WINED3D_POOL_DEFAULT && desc.pool != WINED3D_POOL_SYSTEM_MEM) > + { > + WARN("Color-fill not allowed on surfaces in pool %#x.\n", desc.pool); > + return D3DERR_INVALIDCALL; > + } I realize that this just keeps existing code in place, but as far as I can see this check is redundant. There's already a somewhat strange check right above this one that tests if the surface is a render target or in WINED3D_POOL_DEFAULT. Unless I missed a way to create a non-default pool render target testing only for WINED3D_POOL_DEFAULT should be enough. The patch also works only as long as we keep the D3DUSAGE_RENDERTARGET check in wined3d_device_set_rendertarget_view and not move it to wined3d_rendertarget_view_create. Is that your intention? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9yX4AAoJEN0/YqbEcdMw5i4P/Ao5NQVk+CMZtE6wAenF/YIx V/NuOHczkC1qnXt74CkZe96o/HukbpoyyQ3uKlDnEzgwN8OrJUfwL3kVq6N9llqu MaYGH0a4P/Ib+ZROouuolNcOFSsgjyHvTnZmHQUONhpzURnmLNdUzoKyfrZTKrwe XtIk4prgEMny5W9Oae0eniYHeVv3Gyvg1jtSoviO/KT/fys5Bb+3xW1Voi7ARPWj Ylm+D61JIQotblAcJVon4JElegbS4ENnziRSJM2774VaCaEpFOkCJ+0e3ZDzgqBQ SjGbuLURL48HHYHKzCBEy9zpTiWr40cLjwm/h6f35koHl3IjHofFuxQPxOLqVDFt L/BsdTUNKFL6EkvalC5ObdFUvgkX+1tx60h4vllue1sFbBIZRkISARoc1Q+HAwJE 4B2Ktwlwy0w2fuy8Ml7j3X8g+wqyPkCpaoFcKtauELFBkY/eqn+HFmoRAJTa2oMb ps3d79EbeRPEVhh9NOOqAAkMuA+ztr52uEbKgq7PS0PzcFIvyECTBWxSnAEjw+d8 CKRk6HGC/v8Jo4Vqw/SzDTYRM/bO5sdvgMulux0zSAJuBZe+YGIcl2d0akT6MYQf 615tmoVbSfR3FY2e7SaMXqfXMLMEZzkQWjRy0A+Zs1+sPycobS3/Q7YjOmhW6goC KQGqfd79P2SuiuAbvlue =h6dU -----END PGP SIGNATURE-----

2 1

Tesing list, ignore
by Jeremy Newman 21 Aug '14

21 Aug '14

I'm a test post. Move along....

1 1

Re: [PATCH 5/5] wined3d: Use rendertarget views for color output instead of surfaces.
by Stefan Dösinger 21 Aug '14

21 Aug '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-21 09:55, schrieb Henri Verbeet: > + if (swapchain_desc->backbuffer_count && FAILED(hr = wined3d_rendertarget_view_create_from_surface( > + surface_from_resource(wined3d_texture_get_sub_resource(swapchain->back_buffers[0], 0)), > + NULL, &wined3d_null_parent_ops, &device->back_buffer_view))) > + { > + ERR("Failed to create rendertarget view, hr %#x.\n", hr); > + goto err_out; > + } Having an implicit back buffer render target view managed by wined3d seems a bit odd. Why not let the client libraries create and set the render target view after device creation? That would be similar to what a d3d10 app does after D3D10CreateDeviceAndSwapChain. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9huWAAoJEN0/YqbEcdMwvxMQAIcE7cZnRLTTgECUoxQMWkA5 hobDWConkMr0LGeCMt0Aw98UPsq5n7V/qivYdayudgWbt2YkrRnKq6+d7SIuaWBd QnA0q3CRpWa/v4BKfsXN7t2OKnDwwYCeQoW+qqBpentNEblxVAdh4Rh+/AQZ1Oim PjWdi0Nl31VPnRTQq/GpiHFNY87T9l46hsd5W1GfxY8gPuNxBn0P1xDDsYqG8IxQ 3GH5gw3YIk/JTlvX0nSHQbo05WCgxlGUJ+i7LMotlNth0itEBPOI8EqefEwTdfVO a/6O9xdt7FCNuZSb9yA9nCvn65D8k9hJxYjltF2aouLlbbtuV9CeuNrsxQhqWRA4 vKH5agUKa7dH8aGEaEKk1nrcO9r1U//wGVT1jaZRyWaPx2+o/J/RPIGwEx/HZtyv jInN2QpVSQo4YqSRLHB6geJ3K5OvTAVI4X4QtFXiFQ6IABTmsjlIdxF30fFSmOos +45ohC/GguOJKgvApgWix7xRAX7N1U3QaDsNyaQofJ6hDY7EdMW5Ptz58qBqUv6x 4P6PJ+m4BS5yj+hIsOC1HlwQnMRn4JexTfsg4E/mB5Laa3RONQ8x5aX00G3gs6Sv FozirZyoP4n3d7X0nRkRf4qljlW8SsssWhy7paTLgtLJwdFwy97wWLubdZuljeeg GxCvkXAnRBScDk9IE4z4 =UuRt -----END PGP SIGNATURE-----

2 1

Re: [PATCH 2/2] mshtml: Added IHTMLLinkElement::rev property implementation.
by Marvin 21 Aug '14

21 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8616 Your paranoid android. === w2000pro (32 bit dom) === dom.c:5751: Test failed: hasFeature failed: 80070057 === wxppro (32 bit dom) === dom.c:5751: Test failed: hasFeature failed: 80070057

1 0

Re: [PATCH 1/2] mshtml: Added IHTMLDocument5::get_implementation implementation.
by Marvin 21 Aug '14

21 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8615 Your paranoid android. === w2000pro (32 bit dom) === dom.c:5720: Test failed: hasFeature failed: 80070057 === wxppro (32 bit dom) === dom.c:5720: Test failed: hasFeature failed: 80070057

1 0

Re: [1/5] ntdll/tests: Add tests for FILE_PIPE_INFORMATION. (try 2)
by Marvin 21 Aug '14

21 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8610 Your paranoid android. === w8 (32 bit pipe) === pipe.c:546: Test failed: can't open pipe, GetLastError: e7 pipe.c:622: Test failed: can't open pipe, GetLastError: e7

1 0

Re: [4/4] ntdll/tests: Add tests for FILE_PIPE_INFORMATION.
by Alexandre Julliard 20 Aug '14

20 Aug '14

Sebastian Lackner <sebastian(a)fds-team.de> writes: > +#define check_pipe_handle_state(handle, r, c) \ > + do \ > + { \ > + memset(&fpi, 0x55, sizeof(fpi)); \ > + if (handle == INVALID_HANDLE_VALUE) break; \ > + res = pNtQueryInformationFile(handle, &iosb, &fpi, sizeof(fpi), (FILE_INFORMATION_CLASS)23); \ > + ok(!res, "NtQueryInformationFile returned %x\n", res); \ > + ok(fpi.ReadMode == r, "ReadMode == %x\n", fpi.ReadMode); \ > + ok(fpi.CompletionMode == c, "CompletionMode == %x\n", fpi.CompletionMode); \ > + } \ > + while (0) Please use a function instead of a macro for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Piotr Caban 20 Aug '14

20 Aug '14

On 08/19/14 17:56, Shuai Meng wrote: > Change log: > checked the type of returned variant instead of printing it. > --- > dlls/vbscript/global.c | 10 ++++++++-- > dlls/vbscript/tests/api.vbs | 2 ++ > 2 files changed, 10 insertions(+), 2 deletions(-) > The patch will not apply cleanly in current git. I've sent a patch that adds support for VAR_TIMEVALUEONLY and VAR_DATEVALUEONLY flags to VarDateFromUdateEx function. I think it will be nicer to use this function here. Thanks, Piotr

1 0

Wine test analysis August 6
by Jeremy White 19 Aug '14

19 Aug '14

Henri asked me to share my daily link; this page: www.winehq.org/~jwhite/latest.html should redirect you to the latest results of my cron job that analyzes test results. My cron job is hopefully only a temporary tool used to shame people into fixing the tests. It's main features: 1. Limits results only to believed 'good' test bot VMs (which is basically all the production ones, minus the win 8 vm) 2. Looks for patterns (e.g. apparently fixed, sporadically failing, consistently failing) 3. Holds an annotation line The goal is to have 0 failures. My first step in that is to have each failure annotated, so we know who to blame <grin>. The 'good' news is that we are back down under 30 - looks like just 27 failures right now. There are five failures not annotated in any way, and my link for them was blue, so they might be new and easy: http://test.winehq.org/data/tests/shlwapi:ordinal.html http://test.winehq.org/data/tests/comctl32:button.html http://test.winehq.org/data/tests/kernel32:change.html http://test.winehq.org/data/tests/user32:listbox.html http://test.winehq.org/data/tests/user32:win.html Any takers? Cheers, Jeremy

3 2

Re: [PATCH 2/2] vbscript: Implemented Time(try 2)
by Marvin 19 Aug '14

19 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8592 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Marvin 19 Aug '14

19 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8591 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: d3d10_1.idl: Added some missing constants.
by Henri Verbeet 19 Aug '14

19 Aug '14

In my copy of the PSDK these are guarded by _D3D10_1_CONSTANTS, although it's not entirely clear to me if that actually does anything, since it's only used there, inside d3d10_1.idl.

2 1

Re: [1/2] wbemprox: Implement __SystemSecurity::GetSD.
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8576 Your paranoid android. === wvistau64 (64 bit query) === query: unhandled exception c0000005 at 0000000077336B27 === w2008s64 (64 bit query) === query: unhandled exception c0000005 at 0000000077C76B27

1 0

Re: [PATCH 7/7] vbscript: Implemented Log(try 4)
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8570 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/7] vbscript: Implemented Exp(try 4)
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8569 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/7] vbscript: Implemented Atn(try 4)
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8568 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/7] vbscript: Implemented Tan(try 4)
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8567 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] vbscript: Implemented Sin(try 4)
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8566 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] vbscript: Implemented Cos(try 4)
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8565 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] vbscript: Implemented Sqr(try 4)
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8564 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: ddraw/tests: Correct test condition (PVS-Studio)
by Marvin 18 Aug '14

18 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8529 Your paranoid android. === w2000pro (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00A10028) === wxppro (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00B50028) === wvistau64 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02C70028) === w2008s64 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02B90028) === w7u (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(01B70028) === w8 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(019F0000) === wvistau64 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(00000000029F0040) === w2008s64 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(00000000031A0040)

5 5

Re: [PATCH 7/7] vbscript: Implemented Log(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8550 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/7] vbscript: Implemented Exp(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8549 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/7] vbscript: Implemented Atn(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8548 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/7] vbscript: Implemented Tan(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8547 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/7] vbscript: Implemented Sin(try 3 )
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8546 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] vbscript: Implemented Cos(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8545 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] vbscript: Implemented Sqr(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8544 Your paranoid android. === build (build) === Patch failed to apply

1 0

imagehlp: Implement (parts of) BindImageEx
by Bernhard Reiter 16 Aug '14

16 Aug '14

Now that the test has been committed, I'd be grateful for any reviews of the implementation! Bernhard

4 9

Missing Bug links in AppDB - a try
by André Hentschel 15 Aug '14

15 Aug '14

Hi, I once wrote a script to search the Bugzilla backup file for application names from the AppDB backup file. There are still lots of false positives and it's not respected when the bug url is already linked to the AppDB entry... The script also ignores application names < 4 chars and closed bugs. So if you want to have a bug url adding run through the AppDB, be carefull and have a look at the output: http://dawncrow.de/wine/appdbbugzilla.html

1 1

Re: mshtml: Added IHTMLTableCell::align property implementation.
by Marvin 15 Aug '14

15 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8502 Your paranoid android. === w2000pro (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === wxppro (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === wvistau64 (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === w7u (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === w8 (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === wvistau64 (64 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000

1 0

Re: msvcp90: Added complex_float_pow impletation(Fix precision) and tests(Try 3)
by Piotr Caban 15 Aug '14

15 Aug '14

On 08/10/14 10:32, YongHao Hu wrote: > +complex_float* __cdecl complex_float_pow_ci(complex_float *ret, const complex_float *l, int r) > +{ > + complex_float c = *l; > + complex_float temp = { 1.0, 0 }; > + complex_float_assign(ret, &temp); > + > + if(r < 0){ > + r = -r; > + complex_float_div(&c, &temp, l); > + } > + > + for(; r>0; r>>=1) > + { > + if( (r%2)&1 ) Please fix the if condition. You're also using tabs in the patch, please use spaces instead. Thanks, Piotr

3 3

Re: msvcp90: Add complex_float << implementation
by Piotr Caban 15 Aug '14

15 Aug '14

On 08/10/14 10:32, YongHao Hu wrote: > --- > dlls/msvcp90/ios.c | 28 ++++++++++++++++++++++++++++ > dlls/msvcp90/msvcp90.spec | 4 ++-- > 2 files changed, 30 insertions(+), 2 deletions(-) > > This implementation is not behaving well in following case: complex<float> c = complex<float>(3.1, -0.5); cout.width(20); cout << c << endl; The width should affect whole complex value instead of first float. Cheers, Piotr

2 2

Re: [3/3] mshtml/tests: Add tests for modifying IHTMLTable.
by Jacek Caban 15 Aug '14

15 Aug '14

Hi Zhenbo, On 07/29/14 11:08, Zhenbo Li wrote: > To avoid affecting other tests, I squashed the tests for > insertRow / deleteRow. It would be interesting that the table not only contains given row, but also it is in the right place. For that I'd suggest to have test_table_rows_length, to test that the size changed, and another helper that would check if given row has expected id (or that a row with given id is in the right place). Cheers, Jacek

2 1

Re: [PATCH 7/7] vbscript: Implemented Atn(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8490 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/7] vbscript: Implemented Sqr(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8489 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/7] vbscript: Implemented Log(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8488 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/7] vbscript: Implemented Exp(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8487 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] vbscript: Implemented Tan(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8486 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] vbscript: Implemented Sin(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8485 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] vbscript: Implemented Cos(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8484 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] vbscript: Implemented Cos(try 2)
by Jacek Caban 14 Aug '14

14 Aug '14

On 08/14/14 17:23, Shuai Meng wrote: > Change log: > Applied cleanly. > --- > dlls/vbscript/global.c | 10 ++++++++-- > dlls/vbscript/tests/api.vbs | 19 +++++++++++++++++++ > 2 files changed, 27 insertions(+), 2 deletions(-) > Please add some tests for values other than trivial cases. You may want to add PI constant and a helper (like almostEqual) to deal with precision problems. Same applies to other patches from this series. Also, for functions (like atan) that have invalid arguments, I'd like to see tests of them. Jacek

1 0

Re: [PATCH 2/2] vbscript: Implemented Int(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8483 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Fix(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8482 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 7/7] vbscript: Implemented Atn
by Thomas Faber 14 Aug '14

14 Aug '14

> static HRESULT Global_Ant(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) Perhaps you want to use this opportunity to fix the typo in the function name too? ;)

2 1

Re: mshtml: Added IHTMLInputElement::readOnly property.
by Jacek Caban 14 Aug '14

14 Aug '14

Hi Zhenbo, On 08/14/14 16:08, Zhenbo Li wrote: > --- a/dlls/mshtml/htmlinput.c > +++ b/dlls/mshtml/htmlinput.c > @@ -389,15 +389,33 @@ static HRESULT WINAPI HTMLInputElement_get_defaultValue(IHTMLInputElement *iface > static HRESULT WINAPI HTMLInputElement_put_readOnly(IHTMLInputElement *iface, VARIANT_BOOL v) > { > HTMLInputElement *This = impl_from_IHTMLInputElement(iface); > - FIXME("(%p)->(%x)\n", This, v); > - return E_NOTIMPL; > + nsresult nsres; > + > + TRACE("(%p)->(%x)\n", This, v); > + > + nsres = nsIDOMHTMLInputElement_SetReadOnly(This->nsinput, v != VARIANT_FALSE ? TRUE : FALSE); Remove "? TRUE : FALSE" part. Jacek

1 0

Re: mshtml: Added IHTMLInputElement_get_form method implementation. (try 3)
by Jacek Caban 14 Aug '14

14 Aug '14

On 07/29/14 15:34, Zhenbo Li wrote: > +#define test_input_get_form(o, t) _test_input_get_form(__LINE__, o, t) > +static void _test_input_get_form(unsigned line, IUnknown *unk, const char *id) > +{ > + IHTMLInputElement *input; > + IHTMLFormElement *form; > + IHTMLElement *elem; > + BSTR bstr; > + HRESULT hres; > + > + ok_(__FILE__,line) (unk != NULL, "unk is NULL!\n"); > + hres = IUnknown_QueryInterface(unk, &IID_IHTMLInputElement, (void**)&input); > + ok_(__FILE__,line) (hres == S_OK, "Could not get IHTMLInputElement: %08x\n", hres); > + ok_(__FILE__,line) (input != NULL, "input == NULL\n"); > + if(FAILED(hres) || input == NULL) > + return; > + > + hres = IHTMLInputElement_get_form(input, &form); > + ok_(__FILE__, line) (hres == S_OK, "get_form failed: %08x\n", hres); > + ok_(__FILE__, line) (form != NULL, "form == NULL\n"); > + if(FAILED(hres) || form == NULL){ > + IHTMLInputElement_Release(input); > + return; > + } > + > + hres = IHTMLFormElement_QueryInterface(form, &IID_IHTMLElement, (void **)&elem); > + ok_(__FILE__, line) (hres == S_OK, "QueryInterface(IID_IHTMLElement) failed: %08x\n", hres); > + ok_(__FILE__, line) (elem != NULL, "elem == NULL\n"); > + if(FAILED(hres) || elem == NULL){ > + IHTMLInputElement_Release(input); > + IHTMLFormElement_Release(form); > + return; > + } > + hres = IHTMLElement_get_id(elem, &bstr); > + ok_(__FILE__, line) (hres == S_OK, "get_id failed: %08x\n", hres); > + ok_(__FILE__, line) (!strcmp_wa(bstr, id), "Expect %s, got %s\n", id, wine_dbgstr_w(bstr)); Please use _test_elem_id instead. Cheers, Jacek

1 0

Re: mshtml: Added IHTMLImgElement::isMap property implementation. (try 2)
by Jacek Caban 14 Aug '14

14 Aug '14

Hi Zhenbo, On 08/11/14 08:46, Zhenbo Li wrote: > --- a/dlls/mshtml/htmlimg.c > +++ b/dlls/mshtml/htmlimg.c > @@ -102,15 +102,37 @@ static HRESULT WINAPI HTMLImgElement_Invoke(IHTMLImgElement *iface, DISPID dispI > static HRESULT WINAPI HTMLImgElement_put_isMap(IHTMLImgElement *iface, VARIANT_BOOL v) > { > HTMLImgElement *This = impl_from_IHTMLImgElement(iface); > - FIXME("(%p)->(%x)\n", This, v); > - return E_NOTIMPL; > + nsresult nsres; > + > + TRACE("(%p)->(%x)\n", This, v); > + > + nsres = nsIDOMHTMLImageElement_SetIsMap(This->nsimg, v ? TRUE : FALSE); Please avoid v?TRUE:FALSE style expressions. Cheers, Jacek

1 0

Re: [3/5] wined3d: replace vendor specific callbacks with generic code that uses vendor specific arrays (resend)
by Henri Verbeet 13 Aug '14

13 Aug '14

On 12 August 2014 02:17, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > @@ -2172,45 +2173,43 @@ intel_gl_vendor_table[] = > {GL_VENDOR_MESA, "Mesa Intel driver", cards_intel, > ARRAY_SIZE(cards_intel)}, Your mailer wrapped the patch, so it won't apply. I recommend using git send-email for sending patches. > +C_ASSERT(NUMELMS(card_fallback_nvidia) == WINED3D_D3D_LEVEL_COUNT); > +C_ASSERT(NUMELMS(card_fallback_amd) == WINED3D_D3D_LEVEL_COUNT); > +C_ASSERT(NUMELMS(card_fallback_intel) == WINED3D_D3D_LEVEL_COUNT); ... > + enum wined3d_pci_device *card_fallback; /* An array with D3D_LEVEL_COUNT > elements */ I also strongly suspect that even if the patch did apply, it would either generate warnings or just fail to compile.

1 0

Re: [4/4] ntdll/tests: Add tests for FILE_PIPE_INFORMATION.
by Marvin 12 Aug '14

12 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8473 Your paranoid android. === w8 (32 bit pipe) === pipe.c:540: Test failed: can't open pipe, GetLastError: e7 pipe.c:616: Test failed: can't open pipe, GetLastError: e7

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel