- wine-devel - winehq.org

Re: [PATCH] vbscript: Fixed CBool(try 3)
by Piotr Caban 03 May '14

03 May '14

On 05/02/14 06:22, Shuai Meng wrote: > testbot:https://newtestbot.winehq.org/JobDetails.pl?Key=6731 > > Changelog: > added more tests on object; > changed the implemention of some tests that caused "Err.number = 0" > rearranged the order of tests > --- > dlls/vbscript/global.c | 41 ++++++++++------------------------- > dlls/vbscript/tests/api.vbs | 53 > +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 65 insertions(+), 29 deletions(-) > The tests are failing on wine on polish locale: LC_ALL=pl_PL make test ../../../tools/runtest -q -P wine -T ../../.. -M vbscript.dll -p vbscript_test.exe.so run && touch run.ok fixme:thread:GetThreadUILanguage : stub, returning default language. run.c:2102: Tests skipped: Skipping some tests in non-English locale fixme:vbscript:parse_script parser failed around L"<!--" fixme:vbscript:do_icall L"y" not found fixme:vbscript:DispatchEx_InvokeEx no letter/setter run.c:1917: Test failed: expected global_success_d run.c:1918: Test failed: expected global_success_i run.c:1920: Test failed: parse_script failed: 800a000d fixme:vbscript:ClassFactory_QueryInterface (0x7e2462ec)->({342d1ea0-ae25-11d1-89c5-006008c3fbfc} 0x33f7b0) fixme:vbscript:RegExp2_QueryInterface (0x130a88)->({fc4801a3-2ba9-11cf-a229-00aa003d7352} 0x33f74c) fixme:vbscript:interp_enumnext uninitialized fixme:vbscript:interp_newenum Unsupported for {VT_EMPTY} fixme:vbscript:interp_enumnext uninitialized fixme:vbscript:show_msgbox failed: 80004005 fixme:vbscript:show_msgbox blocked make: *** [run.ok] B³±d 3

2 6

Re: [PATCH] vbscript: Fixed CBool(try 4)
by Marvin 03 May '14

03 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6774 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: dpnet/tests: Add a trailing '\n' to an ok() call.
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6756 Your paranoid android. === build (build) === Patch failed to apply

1 0

Building Wine conformance tests on Windows
by Albert Szilvasy 02 May '14

02 May '14

Hello there, It appears that it is not possible to build the Wine conformance tests on Windows as described here: http://www.winehq.org/site/docs/winedev-guide/testing-windows In particular, when I try to build against the latest Windows SDK I get all sorts of errors. Take for example, kernel32/tests/loader.c. It refers to IMAGE_FILE_MACHINE_ARM64. This symbol does not exist in winnt.h from Microsoft but does exist in the wine version. How do people build the conformance tests? Cross compile on Linux? Thanks, albert

6 7

Re: ole32/tests: Add a trailing '\n' to an ok() call.
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6755 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] ddraw/tests: Add a test for getdc palette handling (try 3).
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6752 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5645: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4569: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6369: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6546: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 6: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH 3/3] wined3d: Remove broken gdi palette code.
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6747 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5645: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4569: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6369: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6546: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 6: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH 1/3] ddraw/tests: Add a test for getdc palette handling (try 2).
by Henri Verbeet 02 May '14

02 May '14

On 2 May 2014 13:43, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + * contains uninitialized garbage. See comments beflow for the P8 case. */ This is minor of course, but "below". > + /* See Win8 refcounting remarks in test_primary_palette. */ I think this is superfluous here as well. With those fixed, I think this set is ok.

1 0

Re: [PATCH 2/3] ddraw/tests: Test mipmap GetDC behavior.
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6746 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5645: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4569: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6369: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6546: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 6: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH 1/3] ddraw/tests: Add a test for getdc palette handling (try 2).
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6745 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5645: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4569: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6369: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6546: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 6: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH] user32: Don't destroy in-use menus
by Ken Thomases 02 May '14

02 May '14

On May 1, 2014, at 2:19 PM, Andrew Eikum wrote: > + /* two different kinds of "reference" counting. in_use is for internal > + * refcounting for e.g. submenus. user_destroyed indicates whether > + * DestroyMenu has been invoked on a handle returned by CreateMenu. */ > + BOOL in_use, user_destroyed; First, since in_use is a count, it probably shouldn't be a BOOL. Second, I haven't reviewed the menu code thoroughly, but I think that it would be better to conceptually separate the handle from the internal structure. Internal references to submenus and the like should be by pointers to the structure. The handle should only be used at the interface with external clients. Then, there should be only one reference count. It's the count of users of the structure. The handle represents one reference. Each place where a pointer to the structure is stored is another reference. DestroyMenu() should really destroy the handle (and thus decrement the reference count), not just mark it as "destroyed". -Ken

2 1

Re: dpnet: Implement IDirectPlay8LobbiedApplication Initialize (try 2)
by Stefan Dösinger 02 May '14

02 May '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-02 07:26, schrieb Alistair Leslie-Hughes: > Hi, Remove the Initial value from Create function. The changes of > spaces was done on purpose, future patches will change the other > places. > > Changelog: dpnet: Implement IDirectPlay8LobbiedApplication > Initialize Looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTY2cZAAoJEN0/YqbEcdMwKTgP/1rHmFZTq7GVcDfVyvjgrJvv BQmCMFJZs0/DYgy0+D+ZR5UccLaaoJD75+GyWjSuw2AITOHJ2q8kyREAms4nNQiR /DUa4ZDMeCFfVuC7aStSal2LOiMEqfZycrHa5ryu189mhoyObOT+xQtRa19rzxuJ OLN4IDe0eOSx1KyShiFzYueLY+oNnIf5IJ/omCTfvug5xPP45ZUby74VTXzmahD3 FU+oEBisuv2vXC7mHCjIsWUCadOh1G3UHtZ39/w/70Yj9HaxGipq6bxN4CD/5gho 99qy5JqqE+88gLTjgvsAFGoUpXCdc6k2hQXW9FviV/PbIYFy62tzmpmicmHVknKO XKrRP74l4bI4QutTxBOwN4d2SmGhFD/y8n0oi1c6SgwgfzdMO9nEv3Bx4F7d+pzi JZJnN7A++j5OInGow4xHd1b6oui55MLIMtbW3QJ7auBM+Ue0tB68UKYcrZkPYb29 JpmxFoNSJbqGAhw+0YH5KiemYKb7y/KD7uctrKodsbzQJFqA5gGEUTrTj7h2mo4+ kws3INzZlWJLMIoreaxtfNCco+SFtYIhD72io9KGSdIXc92GJOLTcG0JHXNC709s Rr3Ttl7hnYN6Y6YZsCpZQKE29ZsivUVUs4idL2AuYzHlUWbdJm3RUTRQVF7ncM2f OScvgQEx3PjLqCg861pY =pRHL -----END PGP SIGNATURE-----

1 0

Re: dpnet: Store DPN_SP_CAPS as part of the object
by Stefan Dösinger 02 May '14

02 May '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-02 07:58, schrieb Alistair Leslie-Hughes: > +void init_dpn_sp_caps(DPN_SP_CAPS * pdpspCaps) DECLSPEC_HIDDEN; Why do you need the declaration in the header file? As far as I can see you're calling it from one file only. If you'll need it in a later patch just add it in the patch that needs it and keep the function static for now. Please avoid the Hungarian notation ("pdpspCaps") in new code. While you're at it: The placement of the * is inconsistent with the rest of the code. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTY2axAAoJEN0/YqbEcdMwOGYP/12lXZrx8HnEa1y1N3VHd/7W DMA9os0kqxyEuvBO0+4QCaTi8s8yjhlA0034xK4Tjl+ZYCy3sK8cx+1q1sM4PV2L XYxaRxddqWtNkuEVXbm9Kcq/P+xIzv+d8zcZ0j8WcPOX2fn0Y6YTyBGDHKQZGq/y QFLN1rLDoUksJ78L6Ik7s6zalGLmPw3SeZ7vsTvjiEaXBbbj/wBXy1LY/I4lVxXO uleeQpApV/h/3ul5mne9hnU5SkpskW6ECaNTW1ggmxA+GCSzy0UGK7Cd+LOb/gL+ wLaFXzdBop25LyGygNuzd6w+SwZ2VULPJY+IwVvZvprGMMQYYxrrdtc6B5kgJm51 tpitxyX/s2IqJUFDLPOp5yDUowmfrNWlrptS6iOjJ/j8g29PvTz4MAmoABm8UHm+ eDYUsn1jQhWp9zA7cuZL5G9JpxA7hY5xwlttBZLHqyYWzsNqC0c0XELwp6sCMAqx rH9RmFNH/Oo75puFav0YdfIQ1Zwmt8wgnaobFS1COIZ8u3gXAc36HsrPfQiaPIPQ TYiO7EwPAFx3+Tz1FHNln/PjUnbbND7s5KJtRs9CxVMiGnN3oyw7wNRyB7HbKP0u YcMXCTv6MlpMnFVSXM7zf0E1ahxTmMY3Z6qr+Y/N3EQVY+vHKxNBlXNZsaLfiJqj 8aXBZ1QdgGJ//Jn0dn3d =VadZ -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Client Initialize
by Stefan Dösinger 02 May '14

02 May '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-01 07:41, schrieb Alistair Leslie-Hughes: > +START_TEST(client) > +{ > + test_init_dp(); > + test_enum_service_providers(); > + test_enum_hosts(); > + test_get_sp_caps(); > + test_cleanup_dp(); > +} I think that needs splitting. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIbBAEBAgAGBQJTYn8SAAoJEN0/YqbEcdMwonoP9A8x5zWuCAlVxAVYi9Hsz7yL jkSay3KVxAmyU1mkboG3LBVEQP/ZSkD99oXlu2t/++GL2+FZuX9ms9vJNSxmETQn WBdu9LRqqh8QrGKuKjdyjr8aPzphqAkwNkfbHFpfvTZ9WDGqSXV2atv7pFB7ytfH 4Qrs//RYXE6n6feQB2LGSp6faupX+SGWA5hAKyWD3oKUthMNTo4C9lCjeBKg7az1 kvY45VbTthruv+YHuPnMBZk/hH5yZpxhyrM7yvBwMz/raia05Rf4Ok9xrp8FVX9k IyYX+vgYWi5OtK5XRtpwih3qpnk1v975owTcHmK/ngU2g/wkCmYszXhs+1t5hVti e4rMDByQXXgdFKV0w9uT1YnUwqgRIFMizKGLmBEougFzjtUVndXwK4U7tE0ar2Pd wwDnkQ5m0mcpZ2X690aGqnXhXg8hxsvMCFEDNQvwStH/2d1+2qpjrkaZ5WSW5W7E kEn1tTcqipoK2AVZ49ZXBa6xdtPn/ZafK3YWzwv5nvv52BhL7XE3HIByZvcuD5IM LdEr3O0xVojJLRoJ7f9dzUJWK+Fgi5TvVRMabzYEMemLWfQLEuNIZvse7JvXXu+5 bomwR2QR8+2+xv1L60CbMVepidN8bduQXNyzQdE974ZeK8ahLxWvUBS8mAlmb9aF /xU3BmBfPBwIVQIxw+s= =MrVx -----END PGP SIGNATURE-----

2 1

Re: [PATCH] vbscript: Fixed CBool(try 3)
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6732 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: dpnet: Implement IDirectPlay8LobbiedApplication Initialize
by Stefan Dösinger 01 May '14

01 May '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-05-01 07:42, schrieb Alistair Leslie-Hughes: > static HRESULT WINAPI IDirectPlay8LobbiedApplicationImpl_RegisterProgram(IDirectPlay8LobbiedApplication *iface, > @@ -191,6 +201,11 @@ HRESULT DPNET_CreateDirectPlay8LobbiedApp(LPCLASSFACTORY iface, LPUNKNOWN punkOu > } > app->IDirectPlay8LobbiedApplication_iface.lpVtbl = &DirectPlay8LobbiedApplication_Vtbl; > app->ref = 0; > + app->msghandler = NULL; > + app->flags = 0; > + app->usercontext = NULL; > + app->connection = NULL; This is redundant, HEAP_ZERO_MEMORY clears that for you. Also, in the other patches you changed the indentation to 4 spaces, but not here. If this was intentional I'm fine with that - just pointing it out. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTYn7KAAoJEN0/YqbEcdMwV2UP/jkWB0vY5CLO+A0z9JISmIJT V+dlgPTTWHYgxTVBpDVoBlfYl3vmVTqoHPMExWef8lts0Dx1+Gv0pDQZpwUFXJ9P 9jOBZsuyNwcwU1uSm8BvFXQFWs6XCUoQn9nHC5Y9GNezLQy4KRpPX3xkHf1QuHZw CI/Z8oLwcHT9zy4uWUcYe1ciATCRHx9noLFR7cHIIkOuI1kakptX1DYMp39uo7Hg qah9QP+yA88MDnXQlUSLOSui0dd7lmbqPTHwsHAm8VCgUWUdqFIT0Yt5kITxZjyW tKz1XM7aRZ+V4kbdg8R7PbmFdent/xa79ceOnOIg5MQEWc3LBY+ynh5vgAqEUgAA ynIFlJMyB09D9JRVKj6ETxoIrx+m+FN/z6xD66GvD9ehqQZXH8v+fUc+xyGg0d5o Yj+2R0HJLUEtN7h3n1o9+8EJ6YhmceyOnu7OtrSN7Mapw7qXT4aESSCiRy8j7c1T fy3qvPrmEPRjCN8e1Tu0IJn4EyQl6Eke9BB4CXtuxhOgNC+Z2GekgU1k4Dj78iiQ VXpD9jw/CblEYv+iu4Lvo+E76nHMvF4R0M/UooS+urSnIfKGiNSorMCJOQ+xM1hs b634KfA1gpfq/foDRY0pVcxQVEbN5nKS8vAiv7wul/bhIoWMAZr2DktBdYP08Ye2 pbmU+Nd4X5lclBbj2Rnq =jFdr -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/6] wined3d: Validate and handle query size parameter.
by Marvin 01 May '14

01 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6720 Your paranoid android. === w864 (32 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000). === w864 (64 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000).

1 0

Re: [PATCH 1/6] d3d9/tests: Test GetData behavior with various size values.
by Marvin 01 May '14

01 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6719 Your paranoid android. === w864 (32 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000). === w864 (64 bit device) === device.c:3856: Test failed: Occlusion query returned an unexpected result (0xffff0000). device.c:3861: Test failed: Occlusion query returned an unexpected result (0x00000000). device.c:3866: Test failed: Occlusion query returned an unexpected result (0x00000000).

1 0

Re: [PATCH] vbscript: Fixed CBool(try 2)
by Piotr Caban 01 May '14

01 May '14

On 05/01/14 10:16, Shuai Meng wrote: > Changelog: > added tests on object subtype. > improved CBool. > > https://newtestbot.winehq.org/JobDetails.pl?Key=6689 > > --- > dlls/vbscript/global.c | 41 > ++++++++++++----------------------------- > dlls/vbscript/tests/api.vbs | 42 > ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+), 29 deletions(-) The tests are not passing on wine: run.c:1013: Test failed: api.vbs: L"Err.number = 0" run.c:1013: Test failed: api.vbs: L"Err.number = 0" run.c:1013: Test failed: api.vbs: L"Err.number = 0" These are the failing tests: Call testCBoolError("#TRUE#", 458) Call testCBoolError("#FALSE#", 458) Call testCBoolError(MyObject, 458) Could you please also add following tests: MyObject.myval = 1 Call ok(CBool(MyObject) = True, "CBool(MyObject) = " & CBool(MyObject)) MyObject.myval = 0 Call ok(CBool(MyObject) = False, "CBool(MyObject) = " & CBool(MyObject))

3 3

Re: [PATCH 11/11] oleacc: Add tests for default client accessible object (try2)
by Marvin 01 May '14

01 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6716 Your paranoid android. === w2000pro (32 bit main) === main.c:347: Test failed: V_I4(&v) = 8000 === w2008s64 (64 bit main) === main.c:223: Test failed: wparam = 0 main.c:229: Test failed: unexpected (-12) === w864 (64 bit main) === main.c:223: Test failed: wparam = 0 main.c:229: Test failed: unexpected (-12)

1 0

Re: [PATCH 11/11] oleacc: Add tests for default client accessible object
by Marvin 01 May '14

01 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6714 Your paranoid android. === build (build) === Unable to regenerate dlls/oleacc/Makefile Unable to regenerate dlls/oleacc/Makefile

1 0

regsvr32 patches (argument handler, unicode)
by Hugh McMaster 01 May '14

01 May '14

Is there a reason that patches 104221 to 104224 were not committed? Perhaps a test case is needed? [1/4] regsvr32: Implement new method of handling arguments/flags ( http://source.winehq.org/patches/data/104221 ) This patch replaces the existing argument/flag handler in regsvr32.c (mostly repeated calls to strcasecmp) with a new handler based on a switch statement. [2/4] regsvr32: Convert to Unicod ( http://source.winehq.org/patches/data/104222 ) This patch modifies the source in regsvr32.c so that regsvr32.exe runs entirely in Unicode. Note that the Windows version has Unicode support. Wine does not (yet). [3/4] regsvr32: Add WriteFile support ( http://source.winehq.org/patches/data/104223 ) This patch adds WriteFile() support to regsvr32's output_write() function. It is used in the event that WriteConsoleW() fails. [4/4] regsvr32: Fix a number of errors in the comments of regsvr32.c ( http://source.winehq.org/patches/data/104224 ) This patch fixes a number of spelling, grammar and logic errors in the comments of regsvr32.c. Thank you. -- Hugh McMaster

1 0

Re: user32: Reduce the minimum Set[System]Timer from 15 ms to 10 ms.
by Marvin 01 May '14

01 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6713 Your paranoid android. === wxppro (32 bit msg) === msg.c:13332: Test failed: 9: WaitForSingleObject failed === w7u (32 bit msg) === msg.c:12098: Test failed: unexpected hwnd 00150136 msg.c:12120: Test failed: bad time 31ef4/31f14

1 0

AW: imagehlp: Implement (parts of) BindImageEx (try 5)
by Bernhard Reiter 01 May '14

01 May '14

*ping* No comments or reviews? -------- Ursprüngliche Nachricht -------- Von: Bernhard Reiter <ockham(a)raz.or.at> Datum: An: wine-patches(a)winehq.org Betreff: imagehlp: Implement (parts of) BindImageEx (try 5) Some more fixes to make tests pass on Windows, and to adjust implementation accordingly.

1 0

Re: msi: Expand REG_EXPAND_SZ keys when resolving AppSearch entries
by Hans Leidekker 01 May '14

01 May '14

On Wed, 2014-04-30 at 16:08 +0200, Jérôme Gardou wrote: > Resent for lack of comments on wine-devel. > > --- > dlls/msi/appsearch.c | 22 ++++++++++++++++++++++ > dlls/msi/tests/package.c | 22 ++++++++++++++++++++++ > 2 files changed, 44 insertions(+) Looks good, thanks.

1 0

Re: [PATCH] vbscript: Fixed CBool(try 2)
by Marvin 01 May '14

01 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6706 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: msi: Expand REG_EXPAND_SZ keys when resolving AppSearch entries
by Marvin 01 May '14

01 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6702 Your paranoid android. === w2000pro (32 bit package) === package.c:3978: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3984: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3990: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:4002: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:4008: Test failed: Expected "C:\\", got "C:\" package.c:4014: Test failed: Expected "C:\\", got "C:\" package.c:4030: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4041: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4500: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4592: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4603: Test failed: Expected "C:\\", got "C:\" package.c:4614: Test failed: Expected "C:\\", got "C:\" package.c:4664: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4675: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4690: Test failed: Expected "C:\\", got "C:\" package.c:4695: Test failed: Expected "", got "C:\" package.c:4711: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4720: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4970: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4981: Test failed: Expected "C:\\", got "C:\" package.c:4987: Test failed: Expected "C:\\", got "C:\" package.c:5008: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:5019: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5259: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5265: Test failed: Expected "C:\\", got "C:\" package.c:5282: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5293: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5301: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5645: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6277: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6301: Test failed: Expected C:\\ or empty string, got C:\ package.c:6345: Test failed: Expected C:\\ or empty string, got C:\ package.c:6354: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6584: Test failed: Expected "C:\\", got "C:\" package.c:6585: Test failed: Expected 4, got 3 package.c:6592: Test failed: Expected "C:\\", got "C:\" package.c:6593: Test failed: Expected 4, got 3 package.c:6609: Test failed: Expected "C:\\", got "C:\" package.c:6610: Test failed: Expected 4, got 3 package.c:6616: Test failed: Expected "C:\\", got "C:\" package.c:6617: Test failed: Expected 4, got 3 package.c:6624: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6625: Test failed: Expected 14, got 13 package.c:6632: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6633: Test failed: Expected 19, got 18 package.c:6643: Test failed: Expected "C:\\", got "C:\" package.c:6644: Test failed: Expected 4, got 3 package.c:6651: Test failed: Expected "C:\\", got "C:\" package.c:6652: Test failed: Expected 4, got 3 package.c:6668: Test failed: Expected "C:\\", got "C:\" package.c:6669: Test failed: Expected 4, got 3 package.c:6675: Test failed: Expected "C:\\", got "C:\" package.c:6676: Test failed: Expected 4, got 3 package.c:6683: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6684: Test failed: Expected 14, got 13 package.c:6691: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6692: Test failed: Expected 19, got 18 package.c:6702: Test failed: Expected "C:\\", got "C:\" package.c:6703: Test failed: Expected 4, got 3 package.c:6710: Test failed: Expected "C:\\", got "C:\" package.c:6711: Test failed: Expected 4, got 3 package.c:6727: Test failed: Expected "C:\\", got "C:\" package.c:6728: Test failed: Expected 4, got 3 package.c:6734: Test failed: Expected "C:\\", got "C:\" package.c:6735: Test failed: Expected 4, got 3 package.c:6742: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6743: Test failed: Expected 14, got 13 package.c:6750: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6751: Test failed: Expected 19, got 18 package.c:6761: Test failed: Expected "C:\\", got "C:\" package.c:6762: Test failed: Expected 4, got 3 package.c:6769: Test failed: Expected "C:\\", got "C:\" package.c:6770: Test failed: Expected 4, got 3 package.c:6786: Test failed: Expected "C:\\", got "C:\" package.c:6787: Test failed: Expected 4, got 3 package.c:6793: Test failed: Expected "C:\\", got "C:\" package.c:6794: Test failed: Expected 4, got 3 package.c:6801: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6802: Test failed: Expected 14, got 13 package.c:6809: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6810: Test failed: Expected 19, got 18 package.c:6825: Test failed: Expected 4, got 3 package.c:6842: Test failed: Expected 4, got 3 package.c:6848: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6851: Test failed: Expected 4, got 3 package.c:6858: Test failed: Expected "C:\\", got "C:\" package.c:6859: Test failed: Expected 4, got 3 package.c:6870: Test failed: Expected "C:\\", got "C:\" package.c:6871: Test failed: Expected 4, got 3 package.c:6966: Test failed: Expected "C:\\", got "C:\" package.c:6967: Test failed: Expected 4, got 3 package.c:6974: Test failed: Expected "C:\\", got "C:\" package.c:6975: Test failed: Expected 4, got 3 package.c:6984: Test failed: Expected "C:\\", got "C:\" package.c:6985: Test failed: Expected 4, got 3 package.c:6993: Test failed: Expected "C:\\", got "C:\" package.c:6994: Test failed: Expected 4, got 3 package.c:7000: Test failed: Expected "C:\\", got "C:\" package.c:7001: Test failed: Expected 4, got 3 package.c:7008: Test failed: Expected "C:\\", got "C:\" package.c:7009: Test failed: Expected 4, got 3 package.c:7016: Test failed: Expected "C:\\", got "C:\" package.c:7017: Test failed: Expected 4, got 3 package.c:7027: Test failed: Expected "C:\\", got "C:\" package.c:7028: Test failed: Expected 4, got 3 package.c:7035: Test failed: Expected "C:\\", got "C:\" package.c:7036: Test failed: Expected 4, got 3 package.c:7045: Test failed: Expected "C:\\", got "C:\" package.c:7046: Test failed: Expected 4, got 3 package.c:7054: Test failed: Expected "C:\\", got "C:\" package.c:7055: Test failed: Expected 4, got 3 package.c:7061: Test failed: Expected "C:\\", got "C:\" package.c:7062: Test failed: Expected 4, got 3 package.c:7069: Test failed: Expected "C:\\", got "C:\" package.c:7070: Test failed: Expected 4, got 3 package.c:7077: Test failed: Expected "C:\\", got "C:\" package.c:7078: Test failed: Expected 4, got 3 package.c:7088: Test failed: Expected "C:\\", got "C:\" package.c:7089: Test failed: Expected 4, got 3 package.c:7096: Test failed: Expected "C:\\", got "C:\" package.c:7097: Test failed: Expected 4, got 3 package.c:7106: Test failed: Expected "C:\\", got "C:\" package.c:7107: Test failed: Expected 4, got 3 package.c:7115: Test failed: Expected "C:\\", got "C:\" package.c:7116: Test failed: Expected 4, got 3 package.c:7122: Test failed: Expected "C:\\", got "C:\" package.c:7123: Test failed: Expected 4, got 3 package.c:7130: Test failed: Expected "C:\\", got "C:\" package.c:7131: Test failed: Expected 4, got 3 package.c:7138: Test failed: Expected "C:\\", got "C:\" package.c:7139: Test failed: Expected 4, got 3 package.c:7149: Test failed: Expected "C:\\", got "C:\" package.c:7150: Test failed: Expected 4, got 3 package.c:7157: Test failed: Expected "C:\\", got "C:\" package.c:7158: Test failed: Expected 4, got 3 package.c:7167: Test failed: Expected "C:\\", got "C:\" package.c:7168: Test failed: Expected 4, got 3 package.c:7176: Test failed: Expected "C:\\", got "C:\" package.c:7177: Test failed: Expected 4, got 3 package.c:7183: Test failed: Expected "C:\\", got "C:\" package.c:7184: Test failed: Expected 4, got 3 package.c:7191: Test failed: Expected "C:\\", got "C:\" package.c:7192: Test failed: Expected 4, got 3 package.c:7199: Test failed: Expected "C:\\", got "C:\" package.c:7200: Test failed: Expected 4, got 3 package.c:7297: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7298: Test failed: Expected 9, got 8 package.c:7307: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7308: Test failed: Expected 9, got 8 package.c:7317: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7318: Test failed: Expected 9, got 8 package.c:7329: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7330: Test failed: Expected 8, got 7 package.c:7341: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7342: Test failed: Expected 9, got 8 package.c:7353: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7354: Test failed: Expected 8, got 7 package.c:7365: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7366: Test failed: Expected 10, got 9 package.c:7377: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7378: Test failed: Expected 8, got 7 package.c:7389: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7390: Test failed: Expected 11, got 10 package.c:7441: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7442: Test failed: Expected 10, got 9 package.c:7451: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7452: Test failed: Expected 10, got 9 package.c:7461: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7462: Test failed: Expected 10, got 9 package.c:7473: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7474: Test failed: Expected 8, got 7 package.c:7485: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7486: Test failed: Expected 10, got 9 package.c:7497: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7498: Test failed: Expected 9, got 8 package.c:7509: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7510: Test failed: Expected 10, got 9 package.c:7521: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7522: Test failed: Expected 9, got 8 package.c:7533: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7534: Test failed: Expected 11, got 10 package.c:7670: Test failed: Expected "C:\\", got "C:\" package.c:7671: Test failed: Expected 4, got 3 package.c:7682: Test failed: Expected "C:\\", got "C:\" package.c:7683: Test failed: Expected 4, got 3 package.c:7690: Test failed: Expected "C:\\", got "C:\" package.c:7691: Test failed: Expected 4, got 3 package.c:7788: Test failed: Expected "C:\\", got "C:\" package.c:7789: Test failed: Expected 4, got 3 package.c:7796: Test failed: Expected "C:\\", got "C:\" package.c:7797: Test failed: Expected 4, got 3 package.c:7804: Test failed: Expected "C:\\", got "C:\" package.c:7805: Test failed: Expected 4, got 3 package.c:7824: Test failed: Expected "C:\\", got "C:\" package.c:7825: Test failed: Expected 4, got 3 package.c:7832: Test failed: Expected "C:\\", got "C:\" package.c:7833: Test failed: Expected 4, got 3 package.c:7852: Test failed: Expected "C:\\", got "C:\" package.c:7853: Test failed: Expected 4, got 3 package.c:7860: Test failed: Expected "C:\\", got "C:\" package.c:7861: Test failed: Expected 4, got 3 package.c:7880: Test failed: Expected "C:\\", got "C:\" package.c:7881: Test failed: Expected 4, got 3 package.c:7888: Test failed: Expected "C:\\", got "C:\" package.c:7889: Test failed: Expected 4, got 3 === w7u (32 bit package) === The test timed out

1 0

Re: [PATCH] vbscript: Fixed CBool
by Piotr Caban 30 Apr '14

30 Apr '14

On 04/29/14 15:06, Shuai Meng wrote: > + if(!res) > + return S_OK; You can't return early if res is NULL. You still need to do the conversion and return error if it fails. > +Call ok(CBool(Empty) = False, "CBool(Empty) = " & CBool(Empty)) > +Call ok(getVT(CBool(Empty)) = "VT_BOOL", "getVT(CBool(Empty)) = " & getVT(CBool(Empty))) > +Call ok(CBool(1) = True, "CBool(1) = " & CBool(1)) > +Call ok(getVT(CBool(1)) = "VT_BOOL", "getVT(CBool(1)) = " & getVT(CBool(1))) > +Call ok(CBool(0) = False, "CBool(0) = " & CBool(0)) > +Call ok(getVT(CBool(0)) = "VT_BOOL", "getVT(CBool(0)) = " & getVT(CBool(0))) > +Call ok(CBool(-0.56) = True, "CBool(-0.56) = " & CBool(-0.56)) > +Call ok(getVT(CBool(-0.56)) = "VT_BOOL", "getVT(CBool(-0.56)) = " & getVT(CBool(-0.56))) > +Call ok(CBool("-1") = True, "CBool(""-1"") = " & CBool("-1")) > +Call ok(getVT(CBool("-1")) = "VT_BOOL", "getVT(CBool(""-1"")) = " & getVT(CBool("-1"))) It would be nice to add following tests (these are the tests Jacek was asking for): Call ok(CBool("True") = true, "CBool(""True"") = " & CBool("True")) Call ok(CBool("fAlSe") = false, "CBool(""fAlSe"") = " & CBool("fAlSe")) sub testCBoolError on error resume next call Err.clear() call CBool("#FALSE#") call ok(Err.number = 458, "Err.number = " & Err.number) end sub Call testCBoolError

3 7

Re: [PATCH 01/10] vbscript: Fixed CBool(try 3)
by Jacek Caban 30 Apr '14

30 Apr '14

Hi Shuai, On 04/21/14 03:45, Shuai Meng wrote: > - > - return return_bool(res, val); > + V_VT(res) = VT_EMPTY; > + return VariantChangeType(res, arg, VARIANT_LOCALBOOL, VT_BOOL); You can't assume that res is not NULL. If result of the function is not used, it will be NULL. A simple test case is like this: call CBool(0) Also, are you sure we want VARIANT_LOCALBOOL here? Did you test it (probably by running tests on localized Windows with translated string "False")? Looking at CBool tests: +Call ok(CBool(Empty) = False, "CBool(Empty) = " & CBool(Empty)) +Call ok(getVT(CBool(Empty)) = "VT_BOOL", "getVT(CBool(Empty)) = " & getVT(CBool(Empty))) +Call ok(CBool(1) = True, "CBool(1) = " & CBool(1)) +Call ok(getVT(CBool(1)) = "VT_BOOL", "getVT(CBool(1)) = " & getVT(CBool(1))) +Call ok(CBool(CLng(0)) = False, "CBool(CLng(0)) = " & CBool(CLng(0))) +Call ok(getVT(CBool(CLng(0))) = "VT_BOOL", "getVT(CBool(CLng(0))) = " & getVT(CBool(CLng(0)))) +Call ok(CBool(CSng(0.5)) = True, "CBool(CSng(0.5)) = " & CBool(CSng(0.5))) +Call ok(getVT(CBool(CSng(0.5))) = "VT_BOOL", "getVT(CBool(CSng(0.5))) = " & getVT(CBool(CSng(0.5)))) +Call ok(CBool(-0.56) = True, "CBool(-0.56) = " & CBool(-0.56)) +Call ok(getVT(CBool(-0.56)) = "VT_BOOL", "getVT(CBool(-0.56)) = " & getVT(CBool(-0.56))) +Call ok(CBool(CCur(8.55)) = True, "CBool(CCur(8.55)) = " & CBool(CCur(8.55))) +Call ok(getVT(CBool(CCur(8.55))) = "VT_BOOL", "getVT(CBool(CCur(8.55))) = " & getVT(CBool(CCur(8.55)))) +Call ok(CBool(CDate(0)) = False, "CBool(CDate(0)) = " & CBool(CDate(0))) +Call ok(getVT(CBool(CDate(0))) = "VT_BOOL", "getVT(CBool(CDate(0))) = " & getVT(CBool(CDate(0)))) +Call ok(CBool(CDate(3.33)) = True, "CBool(CDate(3.33)) = " & CBool(CDate(3.33))) +Call ok(getVT(CBool(CDate(3.33))) = "VT_BOOL", "getVT(CBool(CDate(3.33))) = " & getVT(CBool(CDate(3.33)))) +Call ok(CBool("6666.78") = True, "CBool(""6666.78"") = " & CBool("6666.78")) +Call ok(getVT(CBool("6666.78")) = "VT_BOOL", "getVT(CBool(""6666.78"")) = " & getVT(CBool("6666.78"))) +Call ok(CBool(CByte(-0.1)) = False, "CBool(CByte(-0.1)) = " & CBool(CByte(-0.1))) +Call ok(getVT(CBool(CByte(-0.1))) = "VT_BOOL", "getVT(CBool(CByte(-0.1))) = " & getVT(CBool(CByte(-0.1)))) Those look mostly good. However I'd like to see some more tests. Interesting case is for example empty string and a "false", "False" and "#FALSE#" string. Also I'd really like to see tests on object default values. See the attached patch for an example. Those comments apply also to other patches in the series. It may be easier to proceed if you resent just the first patch fixed and include tests that don't depending on other patches in the series in the patch itself. Cheers, Jacek

3 6

Re: dpnet: Forward declare IDirectPlay8Address when you include dpaddr.h (try 2)
by Alexandre Julliard 30 Apr '14

30 Apr '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Change struct to interface, hopefully it will compile on the MAC this > time. Obviously this won't make any difference. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/1] ddraw/tests: Add some basic material tests.
by Marvin 30 Apr '14

30 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6681 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5103: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected refcount 3. ddraw2.c:5129: Test failed: Got unexpected hr 0. ddraw2.c:5132: Test failed: Got unexpected refcount 3. ddraw2.c:5134: Test failed: Got unexpected refcount 2. ddraw2.c:5140: Test failed: Got unexpected hr 0. ddraw2.c:5143: Test failed: Got unexpected refcount 2. ddraw2.c:5145: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:4027: Test failed: Got unexpected refcount 3. ddraw1.c:4046: Test failed: Got unexpected refcount 3. ddraw1.c:4053: Test failed: Got unexpected hr 0. ddraw1.c:4056: Test failed: Got unexpected refcount 3. ddraw1.c:4058: Test failed: Got unexpected refcount 2. ddraw1.c:4064: Test failed: Got unexpected hr 0. ddraw1.c:4067: Test failed: Got unexpected refcount 2. ddraw1.c:4069: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw7) === ddraw7.c:5635: Test failed: Got unexpected refcount 3. ddraw7.c:5654: Test failed: Got unexpected refcount 3. ddraw7.c:5661: Test failed: Got unexpected hr 0. ddraw7.c:5664: Test failed: Got unexpected refcount 3. ddraw7.c:5666: Test failed: Got unexpected refcount 2. ddraw7.c:5672: Test failed: Got unexpected hr 0. ddraw7.c:5675: Test failed: Got unexpected refcount 2. ddraw7.c:5677: Test failed: Got unexpected refcount 1. ddraw7.c:5679: Test failed: Got unexpected refcount 6. ddraw7.c:5796: Test failed: Failed to set cooperative level, hr 0x8876023b. === w864 (32 bit ddraw4) === ddraw4.c:5794: Test failed: Got unexpected refcount 3. ddraw4.c:5813: Test failed: Got unexpected refcount 3. ddraw4.c:5820: Test failed: Got unexpected hr 0. ddraw4.c:5823: Test failed: Got unexpected refcount 3. ddraw4.c:5825: Test failed: Got unexpected refcount 2. ddraw4.c:5831: Test failed: Got unexpected hr 0. ddraw4.c:5834: Test failed: Got unexpected refcount 2. ddraw4.c:5836: Test failed: Got unexpected refcount 1. ddraw4.c:5838: Test failed: Got unexpected refcount 6. ddraw4.c:5958: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5997: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:6000: Test failed: Got unexpected hr 0. ddraw4.c:6002: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6005: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6008: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:6010: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6013: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6015: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6018: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:6020: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [PATCH 1/2] vbscript: Allow property getters to take arguments.
by Marvin 30 Apr '14

30 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6678 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: msi/tests: Fix a couple of memory leaks (valgrind).
by Marvin 30 Apr '14

30 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6675 Your paranoid android. === w2000pro (32 bit package) === package.c:3956: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3962: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3968: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:3980: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:3986: Test failed: Expected "C:\\", got "C:\" package.c:3992: Test failed: Expected "C:\\", got "C:\" package.c:4008: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4019: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4478: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4570: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4581: Test failed: Expected "C:\\", got "C:\" package.c:4592: Test failed: Expected "C:\\", got "C:\" package.c:4642: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4653: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4668: Test failed: Expected "C:\\", got "C:\" package.c:4673: Test failed: Expected "", got "C:\" package.c:4689: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4698: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4948: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4959: Test failed: Expected "C:\\", got "C:\" package.c:4965: Test failed: Expected "C:\\", got "C:\" package.c:4986: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:4997: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5237: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5243: Test failed: Expected "C:\\", got "C:\" package.c:5260: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5271: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5279: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5623: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6255: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6279: Test failed: Expected C:\\ or empty string, got C:\ package.c:6323: Test failed: Expected C:\\ or empty string, got C:\ package.c:6332: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6562: Test failed: Expected "C:\\", got "C:\" package.c:6563: Test failed: Expected 4, got 3 package.c:6570: Test failed: Expected "C:\\", got "C:\" package.c:6571: Test failed: Expected 4, got 3 package.c:6587: Test failed: Expected "C:\\", got "C:\" package.c:6588: Test failed: Expected 4, got 3 package.c:6594: Test failed: Expected "C:\\", got "C:\" package.c:6595: Test failed: Expected 4, got 3 package.c:6602: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6603: Test failed: Expected 14, got 13 package.c:6610: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6611: Test failed: Expected 19, got 18 package.c:6621: Test failed: Expected "C:\\", got "C:\" package.c:6622: Test failed: Expected 4, got 3 package.c:6629: Test failed: Expected "C:\\", got "C:\" package.c:6630: Test failed: Expected 4, got 3 package.c:6646: Test failed: Expected "C:\\", got "C:\" package.c:6647: Test failed: Expected 4, got 3 package.c:6653: Test failed: Expected "C:\\", got "C:\" package.c:6654: Test failed: Expected 4, got 3 package.c:6661: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6662: Test failed: Expected 14, got 13 package.c:6669: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6670: Test failed: Expected 19, got 18 package.c:6680: Test failed: Expected "C:\\", got "C:\" package.c:6681: Test failed: Expected 4, got 3 package.c:6688: Test failed: Expected "C:\\", got "C:\" package.c:6689: Test failed: Expected 4, got 3 package.c:6705: Test failed: Expected "C:\\", got "C:\" package.c:6706: Test failed: Expected 4, got 3 package.c:6712: Test failed: Expected "C:\\", got "C:\" package.c:6713: Test failed: Expected 4, got 3 package.c:6720: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6721: Test failed: Expected 14, got 13 package.c:6728: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6729: Test failed: Expected 19, got 18 package.c:6739: Test failed: Expected "C:\\", got "C:\" package.c:6740: Test failed: Expected 4, got 3 package.c:6747: Test failed: Expected "C:\\", got "C:\" package.c:6748: Test failed: Expected 4, got 3 package.c:6764: Test failed: Expected "C:\\", got "C:\" package.c:6765: Test failed: Expected 4, got 3 package.c:6771: Test failed: Expected "C:\\", got "C:\" package.c:6772: Test failed: Expected 4, got 3 package.c:6779: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6780: Test failed: Expected 14, got 13 package.c:6787: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6788: Test failed: Expected 19, got 18 package.c:6803: Test failed: Expected 4, got 3 package.c:6820: Test failed: Expected 4, got 3 package.c:6826: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6829: Test failed: Expected 4, got 3 package.c:6836: Test failed: Expected "C:\\", got "C:\" package.c:6837: Test failed: Expected 4, got 3 package.c:6848: Test failed: Expected "C:\\", got "C:\" package.c:6849: Test failed: Expected 4, got 3 package.c:6944: Test failed: Expected "C:\\", got "C:\" package.c:6945: Test failed: Expected 4, got 3 package.c:6952: Test failed: Expected "C:\\", got "C:\" package.c:6953: Test failed: Expected 4, got 3 package.c:6962: Test failed: Expected "C:\\", got "C:\" package.c:6963: Test failed: Expected 4, got 3 package.c:6971: Test failed: Expected "C:\\", got "C:\" package.c:6972: Test failed: Expected 4, got 3 package.c:6978: Test failed: Expected "C:\\", got "C:\" package.c:6979: Test failed: Expected 4, got 3 package.c:6986: Test failed: Expected "C:\\", got "C:\" package.c:6987: Test failed: Expected 4, got 3 package.c:6994: Test failed: Expected "C:\\", got "C:\" package.c:6995: Test failed: Expected 4, got 3 package.c:7005: Test failed: Expected "C:\\", got "C:\" package.c:7006: Test failed: Expected 4, got 3 package.c:7013: Test failed: Expected "C:\\", got "C:\" package.c:7014: Test failed: Expected 4, got 3 package.c:7023: Test failed: Expected "C:\\", got "C:\" package.c:7024: Test failed: Expected 4, got 3 package.c:7032: Test failed: Expected "C:\\", got "C:\" package.c:7033: Test failed: Expected 4, got 3 package.c:7039: Test failed: Expected "C:\\", got "C:\" package.c:7040: Test failed: Expected 4, got 3 package.c:7047: Test failed: Expected "C:\\", got "C:\" package.c:7048: Test failed: Expected 4, got 3 package.c:7055: Test failed: Expected "C:\\", got "C:\" package.c:7056: Test failed: Expected 4, got 3 package.c:7066: Test failed: Expected "C:\\", got "C:\" package.c:7067: Test failed: Expected 4, got 3 package.c:7074: Test failed: Expected "C:\\", got "C:\" package.c:7075: Test failed: Expected 4, got 3 package.c:7084: Test failed: Expected "C:\\", got "C:\" package.c:7085: Test failed: Expected 4, got 3 package.c:7093: Test failed: Expected "C:\\", got "C:\" package.c:7094: Test failed: Expected 4, got 3 package.c:7100: Test failed: Expected "C:\\", got "C:\" package.c:7101: Test failed: Expected 4, got 3 package.c:7108: Test failed: Expected "C:\\", got "C:\" package.c:7109: Test failed: Expected 4, got 3 package.c:7116: Test failed: Expected "C:\\", got "C:\" package.c:7117: Test failed: Expected 4, got 3 package.c:7127: Test failed: Expected "C:\\", got "C:\" package.c:7128: Test failed: Expected 4, got 3 package.c:7135: Test failed: Expected "C:\\", got "C:\" package.c:7136: Test failed: Expected 4, got 3 package.c:7145: Test failed: Expected "C:\\", got "C:\" package.c:7146: Test failed: Expected 4, got 3 package.c:7154: Test failed: Expected "C:\\", got "C:\" package.c:7155: Test failed: Expected 4, got 3 package.c:7161: Test failed: Expected "C:\\", got "C:\" package.c:7162: Test failed: Expected 4, got 3 package.c:7169: Test failed: Expected "C:\\", got "C:\" package.c:7170: Test failed: Expected 4, got 3 package.c:7177: Test failed: Expected "C:\\", got "C:\" package.c:7178: Test failed: Expected 4, got 3 package.c:7275: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7276: Test failed: Expected 9, got 8 package.c:7285: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7286: Test failed: Expected 9, got 8 package.c:7295: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7296: Test failed: Expected 9, got 8 package.c:7307: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7308: Test failed: Expected 8, got 7 package.c:7319: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7320: Test failed: Expected 9, got 8 package.c:7331: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7332: Test failed: Expected 8, got 7 package.c:7343: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7344: Test failed: Expected 10, got 9 package.c:7355: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7356: Test failed: Expected 8, got 7 package.c:7367: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7368: Test failed: Expected 11, got 10 package.c:7419: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7420: Test failed: Expected 10, got 9 package.c:7429: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7430: Test failed: Expected 10, got 9 package.c:7439: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7440: Test failed: Expected 10, got 9 package.c:7451: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7452: Test failed: Expected 8, got 7 package.c:7463: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7464: Test failed: Expected 10, got 9 package.c:7475: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7476: Test failed: Expected 9, got 8 package.c:7487: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7488: Test failed: Expected 10, got 9 package.c:7499: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7500: Test failed: Expected 9, got 8 package.c:7511: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7512: Test failed: Expected 11, got 10 package.c:7648: Test failed: Expected "C:\\", got "C:\" package.c:7649: Test failed: Expected 4, got 3 package.c:7660: Test failed: Expected "C:\\", got "C:\" package.c:7661: Test failed: Expected 4, got 3 package.c:7668: Test failed: Expected "C:\\", got "C:\" package.c:7669: Test failed: Expected 4, got 3 package.c:7766: Test failed: Expected "C:\\", got "C:\" package.c:7767: Test failed: Expected 4, got 3 package.c:7774: Test failed: Expected "C:\\", got "C:\" package.c:7775: Test failed: Expected 4, got 3 package.c:7782: Test failed: Expected "C:\\", got "C:\" package.c:7783: Test failed: Expected 4, got 3 package.c:7802: Test failed: Expected "C:\\", got "C:\" package.c:7803: Test failed: Expected 4, got 3 package.c:7810: Test failed: Expected "C:\\", got "C:\" package.c:7811: Test failed: Expected 4, got 3 package.c:7830: Test failed: Expected "C:\\", got "C:\" package.c:7831: Test failed: Expected 4, got 3 package.c:7838: Test failed: Expected "C:\\", got "C:\" package.c:7839: Test failed: Expected 4, got 3 package.c:7858: Test failed: Expected "C:\\", got "C:\" package.c:7859: Test failed: Expected 4, got 3 package.c:7866: Test failed: Expected "C:\\", got "C:\" package.c:7867: Test failed: Expected 4, got 3 === w7u (32 bit msi) === The test timed out === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === Failure running script in VM: timed out waiting for the child process === wxppro (32 bit action) === The test timed out === w2008s64 (32 bit action) === Failure running script in VM: timed out waiting for the child process === w7u (32 bit action) === Failure running script in VM: timed out waiting for the child process === w864 (32 bit action) === The test timed out

1 0

Re: wbemproxy: Fix invalid HRESULT assignment in class_object_Next.
by Hans Leidekker 30 Apr '14

30 Apr '14

On Tue, 2014-04-29 at 19:41 +0200, Victor Martinez wrote: > From 9cfa2abd78c6cd23c3bd5a48c6fb5f5259edd9e4 Mon Sep 17 00:00:00 2001 > From: Victor Martinez Calvo <vmartinez(a)reactos.org> > Date: Tue, 29 Apr 2014 17:36:27 +0200 > Subject: wbemproxy: Fix invalid HRESULT assignment in class_object_Next. Thanks. As it happens I have just rewritten this function and included the same fix: http://source.winehq.org/patches/data/104254

1 0

D3D11CreateDevice
by Dyweni - Wine-Devel 30 Apr '14

30 Apr '14

Hi All, I'm curious to know if anyone has an idea of when D3D11CreateDevice will be implemented to at least D3D_FEATURE_LEVEL_10_0? http://bugs.winehq.org/show_bug.cgi?id=34008 Thanks, Dyweni!

1 0

Re: [PATCH] bcrypt: Add stub for BCryptOpenAlgorithmProvider.
by Dmitry Timoshkov 30 Apr '14

30 Apr '14

Alex Henrie <alexhenrie24(a)gmail.com> wrote: > +@ stdcall BCryptOpenAlgorithmProvider(ptr ptr ptr long) It should be (ptr wstr wstr long) > +NTSTATUS WINAPI BCryptOpenAlgorithmProvider(BCRYPT_ALG_HANDLE *phAlgorithm, LPCWSTR pszAlgId, > + LPCWSTR pszImplementation, DWORD dwFlags) > +{ > + FIXME("%p, %s, %s, %08x - stub\n", phAlgorithm, wine_dbgstr_w(pszAlgId), wine_dbgstr_w(pszImplementation), dwFlags); > + > + *phAlgorithm = NULL; > + > + return STATUS_NOT_IMPLEMENTED; > +} Probably there should be a test for NULL before writing to *phAlgorithm. Also please avoid using hungarian notation for variable naming in Wine. -- Dmitry.

1 0

Re: [PATCH 5/5] ddraw/tests: Add some basic material tests.
by Marvin 29 Apr '14

29 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6673 Your paranoid android. === w864 (32 bit ddraw1) === ddraw1.c:4938: Test failed: Got unexpected color 0x000000ff, test 0.

1 0

WINE mutex functions speed.
by John Found 29 Apr '14

29 Apr '14

Hi. Recently, I am working on an multi-thread application that widely uses mutex functions, namely: WaitForSingleObject and ReleaseMutex. After some benchmarks I found that these functions are 50..100 times(sic!) slower than in Windows. And this is when only one thread tries to use the mutex - i.e. there is nothing to be waiting for. The test program compiled natively for Linux (using pthreads library) demonstrates only 1.5 times slower functions (compared to the same program not using mutexes at all) which is pretty acceptable. So, what can I do in order to speed up these functions? Is it a bug (that need to be reported and fixed) or some fundamental architecture problem? Should I think about different way of mutex implementation? -- asm32.info <johnfound(a)asm32.info>

3 4

Re: msctf: Added ITfInputProcessorProfileMgr interface stub implementation.
by Marvin 29 Apr '14

29 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6663 Your paranoid android. === w864 (32 bit inputprocessor) === inputprocessor.c:791: Test failed: Deactivation came unexpectedly

1 0

Re: [PATCH] vbscript: Fixed CBool
by Marvin 29 Apr '14

29 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6662 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/5] ddraw/tests: Handle a backbuffer palette misbehavior on Windows 8.
by Henri Verbeet 29 Apr '14

29 Apr '14

On 28 April 2014 15:21, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + * reference crashes. The primary has an extra reference after creation call, making > + * it tricky to destroy. Creating the primary adds 5 references to the ddraw interface, This is because of the 8 bpp display mode, I have a patch.

1 0

Re: [PATCH 2/5] ddraw: Implement D3DOP_STATERENDER on top of IDirect3DDevice3_SetRenderState().
by Stefan Dösinger 29 Apr '14

29 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-04-29 10:41, schrieb Henri Verbeet: > + if (FAILED(IDirect3DDevice3_SetRenderState(&device->IDirect3DDevice2_iface, Is the use of IDirect3DDevice2_iface intentional? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTX3qrAAoJEN0/YqbEcdMwtacP/jW2hvsXFttAPKuQPjK1nLqI /EOKHK2V7p8kf9WrjvJfcy3WosiNVR3Z6WW0yF/EuF5rrqLw1zSGG0Go4WBTw5h3 DA7xDfnCZhIR9eNOnaxF9OWYaUzDI18/iEMlAVdxrVdpIJJBcrG5x/tWkklFzP9n gIS/LO3msAlTq3xeV96rXty+BYVt+iET2h49Iauw8NKJp9XGfn1a1DtSnY/LCBLV xzgTaKy1nym0Y8zI7xswzmqBsB2F0Mo8Rm7KlzHQz83lltFXS6Q1n/OyX/aVUg6R y8iM3H3gDpaeuykob+HuoEGU96JlYskPZFs94SYpdI0g5O2khM2znQ+qakJiI3ar KSa1DnudgN3eK8a735MUylas4P1IrwMRyMa8BXj5U7qN99WPkHyL0WeF+8JGD5JA A0d1Z/Ox+nA0V+4jFW6aSPeyIFI5BXSROltsDAztF4tjO16QPzMl9/tWOS8NeK23 9VEn/xqbg06oyHrTc5KKhi3u5NhUcoB5wXiTWUfmUftWEd91sUmwnvA/OHYPnAz3 xU1Fy/5E73LR1x5BJNRqZMmtKQxbRnmdMB7mf8wBJNqzt4oxzsqtVkVj1k5QOG/L WFUUmN6bL2iecLunNLo4jH8oPRujjUDW5kZHm4UCBPwtB+GecUMtP8rsSLVj++bu znfeqwAijofsnfpAL9Fa =Egcb -----END PGP SIGNATURE-----

2 1

Re: wtsapi32: Partial implementation of WTSEnumerateProcessesW (try 4)
by Stefan Leichter 28 Apr '14

28 Apr '14

Hello, after this patch has left http://source.winehq.org/patches/ without any comment, i like to know what needs to be change to get this patch commited. Regards Stefan --- dlls/wtsapi32/tests/wtsapi.c | 1 - dlls/wtsapi32/wtsapi32.c | 65 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 63 insertions(+), 3 deletions(-)

1 0

Re: [PATCH 5/5] ddraw/tests: Test mipmap GetDC behavior.
by Marvin 28 Apr '14

28 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6629 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. === w864 (64 bit ddraw7) === ddraw7.c:6115: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. ddraw7.c:6428: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6493: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6558: Test failed: Failed to create surface, hr 0x80004002.

1 0

Fixing conflicts between WineD3D and WGL
by Ken Thomases 28 Apr '14

28 Apr '14

Hi, This email brings together several threads of conversation that have been spread across different bug reports. Sorry for the length. The problem: WineD3D is based on WGL (a.k.a. opengl32). As a consequence, it conflicts with application use of WGL in a number of ways. It's also limited by WGL, which doesn't allow for all of the behaviors of DirectDraw and Direct3D. https://bugs.winehq.org/show_bug.cgi?id=28869 WineD3D needs to make its own GL context current temporarily and then restore the previous GL context, but WGL requires a DC to restore it and the DC may no longer be valid. https://bugs.winehq.org/show_bug.cgi?id=29301 WineD3D changes the window style of the device window when it should not. It needs to do that in order to render to the full screen where WGL only allows full-featured rendering to a window. https://bugs.winehq.org/show_bug.cgi?id=2082 Again, WineD3D is rendering to a window when it wants to render full-screen. In this case, the affected apps create an owned window that sits in front of the device window, obscuring it. http://bugs.winehq.org/show_bug.cgi?id=29934 WineD3D sets a pixel format on the application window. This conflicts with a later attempt by the app to set a different pixel format on the window via WGL. I think the solution to these problems is for WineD3D to have an alternative path to set up its GL context. Henri and I have been discussing using Wine-specific extensions to WGL to do this. There's already the extension WGL_WINE_pixel_format_passthrough which provides the wglSetPixelFormatWINE() function which is just like GDI's SetPixelFormat() and WGL's wglSetPixelFormat() except it allows for changing the pixel format after it's been set once. WineD3D needs to change it even though WGL doesn't allow that. In some of the bug reports listed above, I've suggested adding new extensions or modifying WGL_WINE_pixel_format_passthrough. We probably need a more comprehensive approach. WGL exposes various pieces of state to the application. Ideally, WineD3D would not alter any of that state since such alterations are visible to the app and Direct3D doesn't do that on Windows. I'm not sure that's achievable but we should at least minimize such visible state changes to the extent we can. WGL state: * The DC pixel format. For window DCs (which I believe are the only ones of real interest), this is actually a property of the window, not the DC. Changed by SetPixelFormat(), wglSetPixelFormat(); exposed by GetPixelFormat(), wglGetPixelFormat(). * The current GL context for the thread. Changed by wglMakeCurrent(), wglMakeContextCurrentARB(); exposed by wglGetCurrentContext(). * The DC for the current GL context. Changed by wglMakeCurrent(), wglMakeContextCurrentARB(); exposed by wglGetCurrentDC(), wglGetCurrentReadDCARB(). The most important things to achieve are a) to not "consume" the only opportunity the app has to set the window's pixel format, and b) to restore the app's current GL context (and implicitly its DC) when returning control to it. I don't think it's necessary to avoid WineD3D ever changing WGL's notion of the current context. Certainly, while a WineD3D GL context is current, GL functions like glClear() will operate on WineD3D's context. If the app thinks its context is current and calls GL functions, its context better really be current. So, WineD3D really needs to restore the app's context before returning control (and it generally does, I think). If it's going to do that, then wglGetCurrentContext() will take care of itself. Same for wglGetCurrentDC(). Here's my proposal: Extension WGL_WINE_surface: HANDLE wglCreateSurfaceWINE(HDC hdc, int pixel_format); // if hdc is GetDC(<some normal window>), a window surface is created // if hdc is GetDC(0), GetDC(GetDesktopWindow()), or CreateDC("display", …), a full-screen surface is created. // once the surface is created, it no longer refers to hdc void wglDestroySurfaceWINE(HANDLE surface); HDC wglGetSurfaceDCWINE(HANDLE surface); // Returns a DC created for the surface. This is not the DC passed in to wglCreateSurfaceWINE(). void wglReleaseSurfaceDCWINE(HANDLE surface, HDC hdc); This is somewhat modeled on WGL_ARB_pbuffer. <http://www.opengl.org/registry/specs/ARB/wgl_pbuffer.txt> A surface represents a "place" where GL can render, a potential target for a context. It can correspond to a Win32 window or it can be a full-screen surface. A full-screen surface will likely be a platform window (X11 or Mac) managed by the graphics driver but won't be a Win32 window. It should not interfere with mouse events or focus. A surface has a pixel format, similar to a window. Even if the surface was created from a window DC, its pixel format is independent of the window's. Since a surface is created with a pixel format, it shouldn't be necessary to set one with SetPixelFormat() on a surface DC. If it helps keep WineD3D's code simpler, we could allow it. I'm not sure if it will be necessary to support changing the pixel format after it's been set, using wglSetPixelFormatWINE(), or if the surface should just be destroyed and recreated as necessary. Doing the latter may eventually allow the removal of wglSetPixelFormatWINE(). The lifetime of a surface controls whatever resources the graphics driver has to manage for it. For a normal window, this may include a drawable. For a full-screen surface, this would include any full-screen platform window it might have created. WineD3D would obtain a DC from a surface using wglGetSurfaceDCWINE() just as it now obtains one for a window using GetDC(). There can be multiple DCs for a given surface. In particular, a DC can only be used on a single thread, so multiple threads would each have to get their own DC. The different lifetimes of surfaces vs. surface DCs is why this proposal differs from my approach in bug 2082, where I proposed an extension which just added full-screen DCs without a corresponding full-screen surface object. Destroying a surface while it still has extant surface DCs results in undefined behavior. Once WineD3D has a surface DC, it should be able to work with it as it currently does with window DCs. wglMakeCurrent() with a surface DC will associate the context with the surface drawable. For a surface created from a window, this would work as it does now in the graphics drivers with the exception of how the drawable is looked up from the DC. For a full-screen surface, this would target whatever full-screen drawable the graphics driver provides (possibly a platform window). There's a wrinkle having to do with the pixel format. User32 and the wineserver use the fact that a window has a pixel format to compute the "surface region" for the top-level window. This is a different "surface" than the concept central to this proposal. This "surface" is used for client-side GDI rendering using the DIB engine. Maintaining a surface region is necessary to prevent the contents of the window surface buffer from being blitted on top of any 3D rendering done to the window. To keep that functioning, the graphics drivers will still have to inform user32 that 3D rendering is being done to the window. It can do that using the existing mechanism, but that's not currently reversible because it's tied to the pixel format and that's a permanent property of a window. We'd like it to be reversible, since WineD3D can stop targeting a window. I'm thinking of using a count in user32. Extension WGL_WINE_make_current: BOOL wglMakeContextCurrentWINE(HGLRC hglrc); The standard WGL function wglMakeCurrent() combines two operations. It sets the a GL context's drawable to the provided DC and it makes the GL context current for the thread. This new function, wglMakeContextCurrentWINE(), would only do the latter. It would make a GL context current for the thread without changing which DC it's associated with. Both the X11 and Mac drivers already maintain the necessary state to do that. They don't need to have the DC passed in again. (If a GL context is associated with separate draw and read DCs using wglMakeContextCurrentARB(), then this function will leave it associated with both DCs.) This allows WineD3D to faithfully restore the app's previously-current WGL context. This addresses bug 28869. I considered some other designs but I don't think they work well. I looked for a way to do without special DCs. We could directly specify a pixel format when creating a context rather than getting it from the window or surface via the DC. We could make a context current directly on a surface rather than a surface DC. Unfortunately, too much of WGL depends on having a DC. For example, ChoosePixelFormat() and wglSwapBuffers(). What do folks think? Any feedback would be appreciated. -Ken

7 21

Re: [PATCH 4/5] ddraw/tests: Add a test for getdc palette handling.
by Marvin 28 Apr '14

28 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6628 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. === w864 (64 bit ddraw7) === ddraw7.c:6115: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. ddraw7.c:6428: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6493: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6553: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [PATCH 3/5] ddraw/tests: Handle a backbuffer palette misbehavior on Windows 8.
by Marvin 28 Apr '14

28 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6626 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. === w864 (64 bit ddraw7) === ddraw7.c:6115: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6376: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6376: Test failed: Test 6: Got unexpected pitch 252, expected 256. ddraw7.c:6428: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6493: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6553: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [PATCH 2/5] ddraw/tests: Skip the ddraw7 primary palette test if 8 bpp mode doesn't work.
by Marvin 28 Apr '14

28 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6625 Your paranoid android. === w864 (32 bit ddraw7) === ddraw7.c:5635: Test failed: Got unexpected refcount 3. ddraw7.c:5654: Test failed: Got unexpected refcount 3. ddraw7.c:5661: Test failed: Got unexpected hr 0. ddraw7.c:5664: Test failed: Got unexpected refcount 3. ddraw7.c:5666: Test failed: Got unexpected refcount 2. ddraw7.c:5672: Test failed: Got unexpected hr 0. ddraw7.c:5675: Test failed: Got unexpected refcount 2. ddraw7.c:5679: Test failed: Got unexpected refcount 6. ddraw7.c:5796: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:6352: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6352: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6352: Test failed: Test 6: Got unexpected pitch 252, expected 256. === w864 (64 bit ddraw7) === ddraw7.c:6091: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6352: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6352: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6352: Test failed: Test 6: Got unexpected pitch 252, expected 256. ddraw7.c:6404: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6469: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:6529: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [PATCH 1/5] ddraw/tests: Test P8 to RGB blits (try 3).
by Marvin 28 Apr '14

28 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6624 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045EB6B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00264A78. ddraw7: unhandled exception c0000005 at 0045EB6B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 005CFE60. ddraw7: unhandled exception c0000005 at 0045EB6B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 007ABEB8. ddraw7: unhandled exception c0000005 at 0045EB6B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000732980. ddraw7: unhandled exception c0000005 at 0000000000454891 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000006C77A0. ddraw7: unhandled exception c0000005 at 0000000000454891 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: mshtml: Renamed nsIDOMHTMLSelectElement::Remove to select_Remove to avoid conflict with nsIDOMElement.
by Zhenbo Li 28 Apr '14

28 Apr '14

Thanks, Jacek This patch should fix that problem, but would it hide the problem in widl? I tried midl.exe with VS, and got #define nsIDOMHTMLSelectElement_Remove(This,index) \ ( (This)->lpVtbl -> Remove(This,index) ) Then why widl can't handle this situation? 2014-04-28 18:17 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>: > Spotted by Zhenbo Li. > > --- > dlls/mshtml/nsiface.idl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > -- Have a nice day! Zhenbo Li

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel