- wine-devel - winehq.org

Fwd: [draft patch] atl100/tests: Added more tests for AtlAxWin{, Lic} procedure.
by Qian Hong 28 Apr '14

28 Apr '14

Hi, A lot of thanks to Nikolay and Jacek for many comments and suggestions :) While working on tests, I found some differences between atl80 and atl100: --- snip --- + ok(wndproc[0] == wndproc[1], "expected same proc!\n"); --- snip --- - On atl80, wndprocs are different for class AtlAxWin80 and class AtlAxWinLic80, however, wndprocs are the same for class AtlAxWin100 and class AtlAxWinLic100. --- snip --- + hwnd = CreateWindowW(cls_names[i], NULL, 0, 100, 100, 100, 100, NULL, N ULL, NULL, NULL); + ok(hwnd != NULL, "CreateWindow failed!\n"); + control = (IUnknown *)0xdeadbeef; + res = AtlAxGetControl(hwnd, &control); + todo_wine ok(res == E_FAIL, "AtlAxGetControl failed with res %08x\n", res); --- snip --- - On atl80, CreateWindow with NULL window name or empty name, then call AtlAxGetControl, result is S_OK. On atl100, the same test show that result is E_FAIL. control is NULL in both situation. We've already shared source between different atl version, so it would be annoying to change the code to match different edge case on different version of atl. As far as now, I can't find any real world app depends on any of the above different edge result, so I guess we'd better follow what atl100 does even in atl80 code, would we? Thanks for any comments. --- dlls/atl100/tests/atl.c | 159 ++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 147 insertions(+), 12 deletions(-)

1 1

Re: mshtml: Added IHTMLTable::width property implementation. (try 5)
by Jacek Caban 28 Apr '14

28 Apr '14

Hi Zhenbo, This looks better, but there are two more things I didn't catch earlier. On 04/27/14 15:08, Zhenbo Li wrote: > + nsres = nsIDOMHTMLTableElement_GetWidth(This->nstable, &val); > + if (NS_FAILED(nsres)){ > + ERR("Get Width(%s) failed!\n", debugstr_variant(p)); You can't access output argument (p) here. This will be undefined. > + nsAString_Finish(&val); > + return E_FAIL; > + } > + > + hres = nsstr_to_truncated_bstr(&val, &bstr); > + > + V_VT(p) = VT_BSTR; > + V_BSTR(p) = bstr; > + return hres; You leak val here. Jacek

1 0

[RFC 1/11] Linux FF: Joystick control panel program
by Elias Vanderstuyft 27 Apr '14

27 Apr '14

a) When unloading conditional effects in joy.cpl, the program crashes: When unloading the conditional effect array entries, Wine tries to access an invalid (high) address because dieffect.lpvTypeSpecificParams was not set at the time the effect was created. So declare a valid 'standard' (maxed out) conditional effect. For other unknown effects: - The same can happen when CustomForce effects are available, but because Wine's FF dinput->linux translation does not support this yet, we simply print a FIXME to indicate a possible cause if a crash would happen. - The same for other (unsupported) effects (this is probably not safe?), but then we print a WARN. => This is probably not safe, but these effects won't be unloaded, because they will never be allowed to be created: I tested this by using a dummy FF device that advertised to support CustomForce, but because JoystickAImpl_EnumEffects() does not handle CustomForce, no CustomForce entry was generated in the joy.cpl application, and there was no crash at exit. Solution: After the code of joy.cpl/main.c:766 : else if (IsEqualGUID(&pdei->guid, &GUID_Sine) || IsEqualGUID(&pdei->guid, &GUID_Square) || IsEqualGUID(&pdei->guid, &GUID_Triangle) || IsEqualGUID(&pdei->guid, &GUID_SawtoothUp) || IsEqualGUID(&pdei->guid, &GUID_SawtoothDown)) { DIPERIODIC pforce; pforce.dwMagnitude = DI_FFNOMINALMAX; pforce.lOffset = 0; pforce.dwPhase = 0; pforce.dwPeriod = FF_PERIOD_TIME; dieffect.cbTypeSpecificParams = sizeof(pforce); dieffect.lpvTypeSpecificParams = &pforce; dieffect.dwFlags |= DIEP_TYPESPECIFICPARAMS; } add the following code : else if (IsEqualGUID(&pdei->guid, &GUID_Spring) || IsEqualGUID(&pdei->guid, &GUID_Damper) || IsEqualGUID(&pdei->guid, &GUID_Inertia) || IsEqualGUID(&pdei->guid, &GUID_Friction)) { DICONDITION cxyforce[2]; int i; for (i = 0; i < 2; ++i) { cxyforce[i].lOffset = 0; cxyforce[i].lPositiveCoefficient = DI_FFNOMINALMAX; cxyforce[i].lNegativeCoefficient = DI_FFNOMINALMAX; cxyforce[i].dwPositiveSaturation = DI_FFNOMINALMAX; cxyforce[i].dwNegativeSaturation = DI_FFNOMINALMAX; cxyforce[i].lDeadBand = 0; } dieffect.cbTypeSpecificParams = sizeof(cxyforce); dieffect.lpvTypeSpecificParams = cxyforce; dieffect.dwFlags |= DIEP_TYPESPECIFICPARAMS; } else if (IsEqualGUID(&pdei->guid, &GUID_CustomForce)) { FIXME("Unhandled type specific parameters of CustomForce effect, this may lead to memory errors later on.\n"); } else WARN("Possibly unhandled type specific parameters of effect with guid %x.\n", pdei->guid); b) Weirdly, I had to add these commands that evaluates the DIEFFECT pointers at the end of each if-case, otherwise the pointers seemed to point to other address or data on that address was getting overwritten: TRACE("&rforce=0x%x\n", &rforce); TRACE("&cforce=0x%x\n", &cforce); TRACE("&pforce=0x%x\n", &pforce); TRACE("&cxyforce[0]=0x%x; &cxyforce[1]=0x%x\n", &(cxyforce[0]), &(cxyforce[1])); Elias

2 5

Re: winex11.drv: merge the clipboard and drag-and-drop import functions
by André Hentschel 27 Apr '14

27 Apr '14

Am 27.04.2014 11:20, schrieb Damjan Jovanovic: > * Merges the X selection import functions used by the clipboard and > drag-and-drop, now allowing files to be copied-and-pasted from X11 > apps into Wine apps, and new types (eg. images) to be > dragged-and-dropped from X11 apps into Wine apps (instead of just > files and text like before). Also has the benefit of now allowing > drag-and-drop to use INCR for large data transfers. > * Fixes several memory leaks in xdnd.c > * Uses GlobalAlloc() instead of HeapAlloc() for STGMEDIUM's hGlobal. > * De-duplicates considerable shared code. Cool work, but this sounds like "needs splitting"...

1 0

Advice fixing #13683 (DirectX mouse overlay?)
by Christopher Thielen 27 Apr '14

27 Apr '14

Hi wine-devel, I'm attempting to fix http://bugs.winehq.org/show_bug.cgi?id=13683 but need some advice as to where to start. I'm not too familiar with hacking on Wine. I'd like to test Stefan Dösinger's theory outlined in the comments for #13683 that the missing second mouse cursor is perhaps being implemented using DirectX overlays and that Wine's lack of overlay compatibility flags is to blame. Would the proper action to test this theory be to fake a certain set of flags in dlls/d3d8/device.c's static HRESULT WINAPI d3d8_device_GetDeviceCaps(IDirect3DDevice8 *iface, D3DCAPS8 *caps) ? If that proves to be the issue, I'd then need to write proper code to report the correct set of flags presumably. Is there any easy way to see which DLLs Wine loads when running an application? I appreciate any advice, I'm new but want to help, Christopher Thielen

4 25

Re: mshtml: Added IHTMLTable::width property implementation. (try 4)
by Jacek Caban 26 Apr '14

26 Apr '14

Hi Zhenbo, This is better, but: On 04/26/14 05:12, Zhenbo Li wrote: > + hres = var2str(&v, &val); > + > + if (hres != S_OK){ > + ERR("Set Width(%s) failed when initializing a nsAString!\n", > + debugstr_variant(&v)); > + nsAString_Finish(&val); Again, this is not initialized in the error case. > + return hres; > + } > + > + nsres = nsIDOMHTMLTableElement_SetWidth(This->nstable, &val); > + nsAString_Finish(&val); > + > + if (NS_FAILED(nsres)){ > + ERR("Set Width(%s) failed!\n", debugstr_variant(&v)); > + return E_FAIL; > + } > + > + return S_OK; > } > > static HRESULT WINAPI HTMLTable_get_width(IHTMLTable *iface, VARIANT *p) > { > HTMLTable *This = impl_from_IHTMLTable(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + nsAString val; > + BSTR bstr; > + nsresult nsres; > + HRESULT hres; > + > + TRACE("(%p)->(%p)\n", This, p); > + nsAString_Init(&val, NULL); > + nsres = nsIDOMHTMLTableElement_GetWidth(This->nstable, &val); > + if (NS_FAILED(nsres)){ > + ERR("Get Width(%s) failed!\n", debugstr_variant(p)); > + nsAString_Finish(&val); > + return E_FAIL; > + } > + > + hres = nsstr_to_truncated_bstr(&val, &bstr); > + if (FAILED(hres)) { > + SysFreeString(bstr); And bstr is not initialized in error case. Also, as Dmitry pointed, you don't check for some errors in var2str. Jacek

2 4

Microsoft make MS-DOS codes avalable to public
by Akira Nakagawa 26 Apr '14

26 Apr '14

http://www.computerhistory.org/atchm/microsoft-ms-dos-early-source-code/ I think it does not something for wine☺

2 1

Re: mshtml: Added IHTMLTable::width property implementation. (try 4)
by Dmitry Timoshkov 26 Apr '14

26 Apr '14

Zhenbo Li <litimetal(a)gmail.com> wrote: > + case VT_R8: > + VarBstrFromR8(V_R8(p), 0, 0, &str); > + break; > + case VT_R4: > + VarBstrFromR4(V_R4(p), 0, 0, &str); > + break; > + case VT_I4: > + VarBstrFromI4(V_I4(p), 0, 0, &str); > + break; All these APIs can fail and return appropriate error code. -- Dmitry.

1 0

Re: [PATCH 3/3] ddraw/tests: Test P8 to RGB blits (try 2).
by Henri Verbeet 25 Apr '14

25 Apr '14

On 24 April 2014 14:36, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + hr = IDirectDraw2_CreateSurface(ddraw, &surface_desc, &dst, NULL); > + You should probably check the results of this call, like in the other versions.

1 0

Re: [PATCH] gdiplus: Simplify GdipResetImageAttributes(), fix remap table leak (Valgrind)
by Vincent Povirk 25 Apr '14

25 Apr '14

Looks good to me, thanks.

1 0

Some visual testing of my latest ForceFeedback patched Wine in combination with the new Linux ff-memless-next kernel driver
by Elias Vanderstuyft 25 Apr '14

25 Apr '14

Hi guys, Here is a video of some real-time Force-Feedback testing of the game NeedForSpeed Carbon using my latest patched Wine on Linux: http://www.youtube.com/watch?v=mV-yh72GO30 All periodic force magnitudes are displayed in real-time by gnuplot. Enjoy watching, Elias

2 1

Re: mshtml: Added IHTMLTable::width property implementation. (try 3)
by Jacek Caban 25 Apr '14

25 Apr '14

On 04/22/14 17:30, Zhenbo Li wrote: > diff --git a/dlls/mshtml/htmltable.c b/dlls/mshtml/htmltable.c > index d711ed7..e16aee2 100644 > --- a/dlls/mshtml/htmltable.c > +++ b/dlls/mshtml/htmltable.c > @@ -57,6 +57,33 @@ static inline HTMLTable *impl_from_IHTMLTable3(IHTMLTable3 *iface) > return CONTAINING_RECORD(iface, HTMLTable, IHTMLTable3_iface); > } > > +static HRESULT var2str(nsAString *nsstr, const VARIANT *p) > +{ Nit: please swap arguments order. > + BSTR str; > + BOOL ret; > + > + switch(V_VT(p)) { > + case VT_BSTR: > + return nsAString_Init(nsstr, V_BSTR(p))? > + S_OK : E_FAIL; E_OUTOFMEMORY would be more appropriate here. > + case VT_R8: > + VarBstrFromR8(V_R8(p), 0, 0, &str); > + break; > + case VT_R4: > + VarBstrFromR4(V_R4(p), 0, 0, &str); > + break; > + case VT_I4: > + VarBstrFromI4(V_I4(p), 0, 0, &str); > + break; > + default: > + FIXME("unsupported arg %s\n", debugstr_variant(p)); > + return E_NOTIMPL; > + } > + ret = nsAString_Init(nsstr, str); > + SysFreeString(str); > + return ret ? S_OK : E_FAIL; > +} Same here. > + > static HRESULT WINAPI HTMLTable_QueryInterface(IHTMLTable *iface, > REFIID riid, void **ppv) > { > @@ -395,15 +422,79 @@ static HRESULT WINAPI HTMLTable_get_rows(IHTMLTable *iface, IHTMLElementCollecti > static HRESULT WINAPI HTMLTable_put_width(IHTMLTable *iface, VARIANT v) > { > HTMLTable *This = impl_from_IHTMLTable(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); > - return E_NOTIMPL; > + nsAString val; > + HRESULT hres; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); > + hres = var2str(&val, &v); > + > + if (hres != S_OK){ > + ERR("Set Width(%s) failed when initializing a nsAString!\n", > + debugstr_variant(&v)); > + nsAString_Finish(&val); val is not initialized here, you can't call nsAString_Finish on it. > + return hres; > + } > + > + nsres = nsIDOMHTMLTableElement_SetWidth(This->nstable, &val); > + nsAString_Finish(&val); > + > + if (NS_FAILED(nsres)){ > + ERR("Set Width(%s) failed!\n", debugstr_variant(&v)); > + return E_FAIL; > + } > + > + return S_OK; > } > > static HRESULT WINAPI HTMLTable_get_width(IHTMLTable *iface, VARIANT *p) > { > HTMLTable *This = impl_from_IHTMLTable(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + nsAString val; > + const PRUnichar *str; > + BSTR bstr; > + DOUBLE width; > + nsresult nsres; > + HRESULT hres; > + > + TRACE("(%p)->(%p)\n", This, p); > + nsAString_Init(&val, NULL); > + nsres = nsIDOMHTMLTableElement_GetWidth(This->nstable, &val); > + if (NS_FAILED(nsres)){ > + ERR("Get Width(%s) failed!\n", debugstr_variant(p)); > + nsAString_Finish(&val); > + return E_FAIL; > + } > + > + nsAString_GetData(&val, &str); > + hres = VarR8FromStr(str, 0, 0, &width); > + > + /* WinAPI would return VT_BSTR, not VT_I4 */ > + switch(hres) { > + case S_OK: /* Truncate that number */ > + hres = VarBstrFromI4((LONG)width, 0, 0, &bstr); There may be overflow here. > + if (hres != S_OK) { > + ERR("VarBstrFromI4 failed, err = %d\n", hres); > + return E_FAIL; > + } > + V_VT(p) = VT_BSTR; > + V_BSTR(p) = bstr; > + break; > + case DISP_E_TYPEMISMATCH: /* Has symbols */ > + V_VT(p) = VT_BSTR; > + V_BSTR(p) = SysAllocString(str); > + if (!V_BSTR(p)) { > + ERR("SysAllocString(%s) failed!\n", debugstr_w(str)); > + return E_FAIL; > + } > + break; > + default: > + ERR("VarR8FromStr(%s) failed, err = %d\n", debugstr_w(str), hres); > + return E_FAIL; I find it more complicated than it needs to be. You don't really need full conversion here, just a simple string parsing. How about using such helper: static HRESULT nsstr_to_rounded_bstr(const nsAString *nsstr, BSTR *ret_ptr) { const PRUnichar *str, *ptr, *end = NULL; BSTR ret; nsAString_GetData(nsstr, &str); for(ptr = str; isdigitW(*ptr); ptr++); if(*ptr == '.') { for(end = ptr++; isdigitW(*ptr); ptr++); if(*ptr) end = NULL; } ret = end ? SysAllocStringLen(str, end-str) : SysAllocString(str); if(!ret) return E_OUTOFMEMORY; *ret_ptr = ret; return S_OK; } Cheers, Jacek

2 2

Re: [PATCH 3/4] oleacc: Add ObjectFromLresult implementation
by Qian Hong 25 Apr '14

25 Apr '14

Hi Piotr, thanks for your work, I'm really exciting with the oleacc works because Selenium IE Driver depends on oleacc and with oleacc implemented we can run Selenium IE test case on Wine builtin / native IE to make a more compatible IE! + atom = result; + if(atom != result) + return E_FAIL; I can't understand these few lines, are they typo or did I miss anything? Also I cc'ed you on http://bugs.winehq.org/show_bug.cgi?id=30353 which is related to Selenium IE Driver and oleacc, hopefully you don't mind have a look :) Thank you again!

4 7

Re: msvcp90: Added complex_float_pow impletation and tests
by YongHao Hu 25 Apr '14

25 Apr '14

1 reply to应该没有问题吧？我也是设置成wine-devel，你是说发到wine-zh要相应换成wine-zh？ 2补丁我昨晚是不是用thunderbird发的，所以是gmail的名称。现在看看如何？ On Saturday, April 12, 2014 03:59 PM, YongHaoWu wrote: > --- > dlls/msvcp70/msvcp70.spec | 12 ++++----- > dlls/msvcp71/msvcp71.spec | 12 ++++----- > dlls/msvcp80/msvcp80.spec | 12 ++++----- > dlls/msvcp90/math.c | 18 ++++++++++++++ > dlls/msvcp90/msvcp90.spec | 12 ++++----- > dlls/msvcp90/tests/misc.c | 60 +++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 102 insertions(+), 24 deletions(-) >

2 1

Re: [PATCH] advapi32/tests: Fix some leaks in tests (Valgrind)
by Marvin 25 Apr '14

25 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6551 Your paranoid android. === w7u (32 bit service) === service.c:1412: Test failed: Active services mismatch 1 service.c:1413: Test failed: Inactive services mismatch 4294967295 The test timed out

1 0

Re: msvcp90: Added complex_float_pow impletation and tests
by YongHao Hu 25 Apr '14

25 Apr '14

On Saturday, April 12, 2014 03:59 PM, YongHaoWu wrote: > --- > dlls/msvcp70/msvcp70.spec | 12 ++++----- > dlls/msvcp71/msvcp71.spec | 12 ++++----- > dlls/msvcp80/msvcp80.spec | 12 ++++----- > dlls/msvcp90/math.c | 18 ++++++++++++++ > dlls/msvcp90/msvcp90.spec | 12 ++++----- > dlls/msvcp90/tests/misc.c | 60 +++++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 102 insertions(+), 24 deletions(-) >

1 0

Re: [4/6] shell32/tests: Use SEE_MASK_NO_CONSOLE with ShellExecuteExA.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6549 Your paranoid android. === w2000pro (32 bit shlexec) === shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 === wxppro (32 bit shlexec) === shlexec.c:1220: Test failed: expected 1 args, got 4 === w864 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\wtF77.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\wtF77.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2111: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtF56.tmp\wtF77.tmp" Exec") succeeded: rc=42 === w864 (64 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1565: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1565: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\wtFECD.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\wtFECD.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2111: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtFE3F.tmp\wtFECD.tmp" Exec") succeeded: rc=42

1 0

Re: [3/5] user32: Our popup test window loses capture to itself.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6544 Your paranoid android. === w864 (64 bit win) === win.c:6436: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6458: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6436: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6436: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6436: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6436: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6436: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6458: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6436: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6458: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:6219: Test failed: wrong error 31

1 0

Re: [2/5] user32: Add a message test for popup menus on windows that have capture.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6543 Your paranoid android. === w7u (32 bit msg) === msg.c:12092: Test failed: unexpected hwnd 00080140 msg.c:12114: Test failed: bad time 3298f/329ae === w864 (64 bit msg) === msg.c:6048: Test failed: Update region shouldn't be empty msg.c:6282: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6284: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6054: Test failed: Regions are different msg.c:6054: Test failed: Regions are different msg.c:6054: Test failed: Regions are different

1 0

Re: [1/5] user32: Add test calling EndMenu from WM_ENTERMENULOOP.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6542 Your paranoid android. === w7u (32 bit msg) === msg.c:12074: Test failed: unexpected hwnd 0009013C msg.c:12096: Test failed: bad time 312b5/312c4 === w864 (64 bit msg) === msg.c:6030: Test failed: Update region shouldn't be empty msg.c:6264: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6266: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6036: Test failed: Regions are different msg.c:6036: Test failed: Regions are different msg.c:6036: Test failed: Regions are different

1 0

Re: msxml3: complain louder if libxslt was missing at compile time
by Nikolay Sivov 24 Apr '14

24 Apr '14

> + ERR_(winediag)("libxslt headers were not found at compile time. This is not supported, expect problems!\n"); I'm not sure if it's supported or not. It's allowed to build msxml3 without libxslt and some parts will work fine, but I can't imagine a real world situation when somebody really doesn't want to build with libxslt. In my opinion 'Expect problems.' (without exclamation mark) would be enough.

1 0

Re: [PATCH 3/3] ddraw/tests: Test P8 to RGB blits (try 2).
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6538 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045EB3B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00784A78. ddraw7: unhandled exception c0000005 at 0045EB3B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 005DFE60. ddraw7: unhandled exception c0000005 at 0045EB3B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0077BEB8. ddraw7: unhandled exception c0000005 at 0045EB3B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000802980. ddraw7: unhandled exception c0000005 at 0000000000454871 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000006BFD90. ddraw7: unhandled exception c0000005 at 0000000000454871 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

2 1

Re: [4/4] ole32: Initial storage file locking implementation.
by Nikolay Sivov 24 Apr '14

24 Apr '14

On 4/24/2014 00:10, Vincent Povirk wrote: > +static HRESULT StorageImpl_GrabLocks(StorageImpl *This, DWORD openFlags) > +{ > + HRESULT hr; > + ULARGE_INTEGER offset; > + ULARGE_INTEGER cb; > + DWORD share_mode = STGM_SHARE_MODE(openFlags); > + > + /* Wrap all other locking inside a single lock so we can check ranges safely */ > + offset.QuadPart = 0x7fffff92; > + cb.QuadPart = 1; > + hr = StorageImpl_LockRegionSync(This, offset, cb, LOCK_ONLYONCE); > + > + /* If the ILockBytes doesn't support locking that's ok. */ > + if (FAILED(hr)) return S_OK; > + > + hr = S_OK; > + > + /* First check for any conflicting locks. */ > + if (SUCCEEDED(hr) && (openFlags & STGM_PRIORITY) == STGM_PRIORITY) > + hr = StorageImpl_CheckLockRange(This, 0x80, 0x80, STG_E_LOCKVIOLATION); > + > + if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_WRITE)) > + hr = StorageImpl_CheckLockRange(This, 0xbb, 0xce, STG_E_SHAREVIOLATION); > + > + if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_READ)) > + hr = StorageImpl_CheckLockRange(This, 0xcf, 0xe2, STG_E_SHAREVIOLATION); > + > + if (SUCCEEDED(hr) && (share_mode == STGM_SHARE_DENY_READ || share_mode == STGM_SHARE_EXCLUSIVE)) > + hr = StorageImpl_CheckLockRange(This, 0x93, 0xa6, STG_E_LOCKVIOLATION); > + > + if (SUCCEEDED(hr) && (share_mode == STGM_SHARE_DENY_WRITE || share_mode == STGM_SHARE_EXCLUSIVE)) > + hr = StorageImpl_CheckLockRange(This, 0xa7, 0xba, STG_E_LOCKVIOLATION); > + > + /* Then grab our locks. */ > + if (SUCCEEDED(hr) && (openFlags & STGM_PRIORITY) == STGM_PRIORITY) > + { > + hr = StorageImpl_LockOne(This, 0x58, 0x7f); > + if (SUCCEEDED(hr)) > + hr = StorageImpl_LockOne(This, 0x81, 0x91); > + } > + > + if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_WRITE)) > + hr = StorageImpl_LockOne(This, 0x93, 0xa6); > + > + if (SUCCEEDED(hr) && (STGM_ACCESS_MODE(openFlags) != STGM_READ)) > + hr = StorageImpl_LockOne(This, 0xa7, 0xba); > + > + if (SUCCEEDED(hr) && (share_mode == STGM_SHARE_DENY_READ || share_mode == STGM_SHARE_EXCLUSIVE)) > + hr = StorageImpl_LockOne(This, 0xbb, 0xce); > + > + if (SUCCEEDED(hr) && (share_mode == STGM_SHARE_DENY_WRITE || share_mode == STGM_SHARE_EXCLUSIVE)) > + hr = StorageImpl_LockOne(This, 0xcf, 0xe2); > + > + offset.QuadPart = 0x7fffff92; > + cb.QuadPart = 1; > + ILockBytes_UnlockRegion(This->lockBytes, offset, cb, LOCK_ONLYONCE); > + > + return hr; Maybe it'd be better to add some symbols for all these magic numbers? They are at least used twice in this functions, didn't look at others. Also it looks like it's possible to collapse it a bit, for example STGM_SHARE_EXCLUSIVE could check whole 0x93-0xba range with a single code, if I'm reading this right.

2 1

Re: [PATCH 4/5] wined3d: Store palettes in textures instead of in surfaces.
by Henri Verbeet 24 Apr '14

24 Apr '14

On 24 April 2014 12:10, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Since palettes only really matter on frontbuffers we could also consider > removing them from wined3d entirely and performing the ddraw frontbuffer > present with a d3d draw and d3d shaders. This would mean that the shadow > frontbuffer remains in ddraw, and that Shader Model 2 cards are required > for hardware P8 conversion. (Unless we implement full d3d shader support > for older HW, which I consider unlikely.) Or we could just attach them to the swapchain.

2 3

Re: [PATCH 2/3] ddraw/tests: Add a test for mipmap palettes (try 2).
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6537 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045D69B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00774A78. ddraw7: unhandled exception c0000005 at 0045D69B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 008EFE60. ddraw7: unhandled exception c0000005 at 0045D69B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 002BBEB8. ddraw7: unhandled exception c0000005 at 0045D69B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000312980. ddraw7: unhandled exception c0000005 at 00000000004535A1 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000322A20. ddraw7: unhandled exception c0000005 at 00000000004535A1 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: mshtml: Added IConnectionPoint::EnumConnections implementation.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6536 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2861: Test failed: unexpected command 74 === w864 (32 bit htmldoc) === htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2861: Test failed: unexpected command 74 === w864 (64 bit htmldoc) === htmldoc.c:2861: Test failed: unexpected command 74

2 1

Re: [PATCH 3/5] ddraw/tests: Test P8 to RGB blits.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6535 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045EADB === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00314A78. ddraw7: unhandled exception c0000005 at 0045EADB === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 005EFE60. ddraw7: unhandled exception c0000005 at 0045EADB === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 006DBEB8. ddraw7: unhandled exception c0000005 at 0045EADB === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000006E2980. ddraw7: unhandled exception c0000005 at 0000000000454811 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000007E0720. ddraw7: unhandled exception c0000005 at 0000000000454811 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [PATCH 1/5] ddraw: Only ddraw7 disallows SetPalette on sublevels.
by Henri Verbeet 24 Apr '14

24 Apr '14

On 24 April 2014 12:10, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (!(surface->surface_desc.u4.ddpfPixelFormat.dwFlags & (DDPF_PALETTEINDEXED1 | DDPF_PALETTEINDEXED2 > - | DDPF_PALETTEINDEXED4 | DDPF_PALETTEINDEXED8 | DDPF_PALETTEINDEXEDTO8))) > - return DDERR_INVALIDPIXELFORMAT; > - > if (surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_MIPMAPSUBLEVEL) > return DDERR_NOTONMIPMAPSUBLEVEL; > Note that this inverts the ordering of the pixel format and sub-level validation. That might even be correct, but the associated test doesn't cover that case at all.

2 1

Re: [PATCH 2/5] ddraw/tests: Add a test for mipmap palettes.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6534 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045D69B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 002E4A78. ddraw7: unhandled exception c0000005 at 0045D69B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0092FE60. ddraw7: unhandled exception c0000005 at 0045D69B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0072BEB8. ddraw7: unhandled exception c0000005 at 0045D69B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000007C2980. ddraw7: unhandled exception c0000005 at 00000000004535A1 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000325470. ddraw7: unhandled exception c0000005 at 00000000004535A1 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [2/2] dpnet: Improve Error checking in Get/Set SP (try 6 Resend)
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6531 Your paranoid android. === w864 (32 bit address) === The test timed out

1 0

Re: [1/2] dpnet: Use dxguid for tests (resend)
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6530 Your paranoid android. === w864 (64 bit peer) === The test timed out

1 0

Re: [4/4] ole32: Initial storage file locking implementation.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6527 Your paranoid android. === w2000pro (32 bit storage32) === storage32.c:3213: Test failed: file with mode 1012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11022 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11021 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 12 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 10012 should not be openable with WRITE permission

1 0

Re: [2/4] ole32: Add tests for sharing storages in transacted mode.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6526 Your paranoid android. === w2000pro (32 bit storage32) === storage32.c:3213: Test failed: file with mode 1012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11022 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11021 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 12 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 10012 should not be openable with WRITE permission

1 0

Re: [1/4] ole32: Add tests for storage locking.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6524 Your paranoid android. === w2000pro (32 bit storage32) === storage32.c:3213: Test failed: file with mode 1012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11012 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11022 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 11021 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 12 should not be openable with WRITE permission storage32.c:3213: Test failed: file with mode 10012 should not be openable with WRITE permission

1 0

Re: vbscript: Return proper error on invalid argument in Chr.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6517 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/5] ddraw: Validate the pitch for user memory surfaces against the unaligned minimum pitch.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6514 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045C03B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00314A78. ddraw7: unhandled exception c0000005 at 0045C03B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 005BFE60. ddraw7: unhandled exception c0000005 at 0045C03B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0076BEB8. ddraw7: unhandled exception c0000005 at 0045C03B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000762980. ddraw7: unhandled exception c0000005 at 00000000004520D1 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000007150E0. ddraw7: unhandled exception c0000005 at 00000000004520D1 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

GSoC 2014 - accepted proposals announcement
by Austin English 23 Apr '14

23 Apr '14

The accepted proposals for Google's Summer of Code 2014 have been announced. We have accepted 4 proposals this year. * Implement missing and improve existing D3DX9 APIs - by Gediminas Jakutis, mentored by: Matteo Bruni and Stefan Dösinger * Implement ITextDocument::Range and ITextRange - by Jactry Zeng, mentored by Huw Davies and André Hentschel * Implement VBScript built-in functions - by Shuai Meng, mentored by Piotr Caban and Detlef Riekenberg * Implemention for mshtml.dll - by Zhenbo Li, mentored by Jacek Caban and Ulrich Czekalla Congratulations! Students, this is the community bonding period ( http://googlesummerofcode.blogspot.com/2007/04/so-what-is-this-community-bo…), which you should use to get up to speed on your project. In other words, discuss your goals/milestones with your mentors, reviewing bugs in those areas, reading the code, etc. Coding begins May 19th, and mid term reviews are June 23-27th. If you have any GSoC questions, please contact your mentors or the administrators (myself and André Hentschel). Technical questions should be discussed with your mentor or on wine-devel/#winehackers on Freenode IRC. Once again, congratulations! Welcome to Wine, and good luck on your project. -- -Austin

1 0

Re: wined3d: Add NVIDIA Geforce GTX 780 Ti to supported device list
by Henri Verbeet 23 Apr '14

23 Apr '14

On 23 April 2014 00:17, André Hentschel <nerv(a)dawncrow.de> wrote: > Information gathered at: > http://pci-ids.ucw.cz/read/PC/10de > https://freedesktop.org/nouveau/CodeNames/ > http://www.nvidia.de/object/geforce-gtx-780-ti-de.html#pdpContent=2 > > Should i rather add a whole bunch of cards using these sources of information? > I'd prefer this kind of patch to be verified against the actual Windows and Linux drivers.

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Jacek Caban 23 Apr '14

23 Apr '14

On 04/23/14 02:20, Shuai Meng wrote: > --- a/dlls/vbscript/global.c > +++ b/dlls/vbscript/global.c > @@ -557,8 +557,41 @@ static HRESULT Global_IsNull(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VA > > static HRESULT Global_IsNumeric(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + if(res) { > + V_VT(res) = VT_BOOL; You can't assume that res is non-NULL. > + switch(V_VT(arg)) { > + case VT_UI1: > + case VT_I2: > + case VT_I4: > + case VT_I8: > + case VT_R4: > + case VT_R8: > + case VT_BOOL: > + case VT_EMPTY: > + case VT_CY: > + V_BOOL(res) = VARIANT_TRUE; > + break; > + case VT_BSTR: { > + HRESULT hRet; > + double d; > + > + hRet = VarR8FromStr(V_BSTR(arg), LOCALE_USER_DEFAULT, 0, &d); > + if(SUCCEEDED(hRet)) > + V_BOOL(res) = VARIANT_TRUE; > + else > + V_BOOL(res) = VARIANT_FALSE; > + break; > + } > + default: > + V_BOOL(res) = VARIANT_FALSE; > + break; That's a risky assumption. There are tons of other VT_* types possible and at least VT_UI2, VT_UI4 and alike should most likely return true. It's much safer to add explicit list of *tested* cases to return false and FIXME(); return E_NOTIMPL for other cases. > + } > + } > + return S_OK; > } > > static HRESULT Global_IsArray(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > diff --git a/dlls/vbscript/tests/api.vbs b/dlls/vbscript/tests/api.vbs > index beee4d4..cf63fb9 100644 > --- a/dlls/vbscript/tests/api.vbs > +++ b/dlls/vbscript/tests/api.vbs > @@ -170,6 +170,25 @@ Call ok(not isNull(4), "isNull(4) is true?") > Call ok(not isNull("x"), "isNull(""x"") is true?") > Call ok(isNull(Null), "isNull(Null) is not true?") > > +Call ok(isNumeric(empty), "isNumeric(empty) is not true?") > +Call ok(not isNumeric(Null), "isNumeric(Null) is not true?") > +Call ok(isNumeric(32767), "isNumeric(32767) is true?") > +Call ok(isNumeric(32768), "isNumeric(32768) is true?") > +Call ok(isNumeric(CSng(3242.4)), "isNumeric(CSng(3242.4)) is true?") > +Call ok(isNumeric(32768.4), "isNumeric(32768.4) is true?") > +Call ok(isNumeric(CCur(32768.4)), "isNumeric(CCur(32768.4)) is true?") > +Call ok(not isNumeric(CDate(32)), "isNumeric(CDate(32)) is true?") > +Call ok(isNumeric("44"), "isNumeric(""44"") is true?") > +Call ok(not isNumeric("rwrf"), "isNumeric(""rwrf"") is not true?") > +Call ok(not isNumeric(Nothing), "isNumeric(Nothing) is not true?") > +Call ok(not isNumeric(New EmptyClass), "isNumeric(New EmptyClass) is not true?") > +Call ok(isNumeric(true), "isNumeric(true) is true?") > +Call ok(isNumeric(CByte(32)), "isNumeric(CByte(32)) is true?") > +Dim arr(2) > +arr(0) = 2 > +arr(1) = 3 > +Call ok(not isNumeric(arr), "isNumeric(arr) is not true?") > + > Call ok(getVT(err) = "VT_DISPATCH", "getVT(err) = " & getVT(err)) > Your tests depend on your previous patches that were not committed and I already commented them. Please concentrate on getting them committed first. Jacek

1 1

Re: imagehlp: Implement (parts of) BindImageEx (try 4)
by Marvin 23 Apr '14

23 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6512 Your paranoid android. === w2000pro (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINNT\system32\KERNEL32.DLL === wxppro (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\system32\KERNEL32.DLL === wvista (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w2008s64 (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w7u (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w864 (32 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\SYSTEM32\KERNEL32.DLL === w2008s64 (64 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 === w864 (64 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\SYSTEM32\KERNEL32.DLL

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Marvin 23 Apr '14

23 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6508 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Wine Talks at LinuxTag 2014
by Michael Stefaniuc 22 Apr '14

22 Apr '14

Hello guys, here are the two Wine related talks that got accepted for LinuxTag 2014: Pipelight: Windows Plugins in Linux Browsers by Michael Müller (Pipelight-Team), Sebastian Lackner (Pipelight-Team), Erich Hoover (Pipelight-Team) Thursday, 8th May, Stage E, 18:30-19:15 CEST (UTC+2) http://www.linuxtag.org/2014/de/programm/vortragsdetails/?eventid=1342 Is Wine Still Relevant? - A Status Update on Wine by Michael Stefaniuc (Wine Project) Friday, 9th May, Stage C, 16:00-16:45 CEST (UTC+2) http://www.linuxtag.org/2014/de/programm/vortragsdetails/?eventid=2532 bye michael

1 0

Re: [patch]Japanese Translation for Wine 1.7.17(try 2)
by Akihiro Sagawa 22 Apr '14

22 Apr '14

On Mon, 21 Apr 2014 05:56:33 -0400 (EDT), Toshiaki Hirose wrote: > From ce340a6aff2f17d41b35c217692ece6abb17d88e Mon Sep 17 00:00:00 2001 > From: Toshiaki Hirose <t_hirose(a)aol.com> > Date: Sun, 20 Apr 2014 13:34:34 +0900 > Subject: [PATCH] Japanese Translation for Wine 1.7.17 > > --- > po/ja.po | 59 ++++++++++++++++++++++++++++++++++++----------------------- > 1 file changed, 36 insertions(+), 23 deletions(-) Hello Hirose-san, Welcome to Wine development! I'm one of Japanese translation contributors of Wine. About your patch, it looks good at first glance. But, I found some (nit-picking) issues on that. Could you read the comments and give us your feedback? > @@ -1,18 +1,20 @@ > # Japanese translations for Wine > +# Toshiaki Hirose <t_hirose(a)aol.com>, 2014. I'm not sure this change is needed. Please keep it simple. > -"PO-Revision-Date: 2013-12-05 20:08+0900\n" > -"Last-Translator: Akira Nakagawa <matyapiro31(a)yahoo.co.jp>\n" > -"Language-Team: 日本語 <>\n" > +"PO-Revision-Date: 2014-04-20 11:53+0900\n" > +"Last-Translator: Toshiaki Hirose <t_hirose(a)aol.com>\n" > +"Language-Team: 日本語 < kobayashi-ubuntu(a)junkobayashi.jp >\n" The Language Team's e-mail address seems not valid, i.e. Jun Kobayashi is a male Japanese name. Did you get his approval? > "Language: Japanese\n" > "MIME-Version: 1.0\n" > "Content-Type: text/plain; charset=UTF-8\n" > "Content-Transfer-Encoding: 8bit\n" > "Plural-Forms: nplurals=1; plural=0;\n" > +"X-Generator: Gtranslator 2.91.6\n" I'm not sure about this, too. > @@ -11682,54 +11684,65 @@ msgid "" > " [/n] Do not call DllRegisterServer. This option must be used with [/i].\n" > "\n" > msgstr "" > +"用法:\n" > +" regsvr32 [/u] [/s] [/n] [/i[:cmdline]] Dll名\n" > +"\n" > +"オプション:\n" > +" [/u] サーバを登録消去\n" Please use a sentence form here, e.g. 「～消去します。」. Because original text is sentence. > @@ -11682,54 +11684,65 @@ msgid "" > " [/n] Do not call DllRegisterServer. This option must be used with [/i].\n" > "\n" > msgstr "" > +"用法:\n" Please translate `Usage' into 「使い方」 to keep consistency with other translations. For instance, see hostname.rc:30. > +" regsvr32 [/u] [/s] [/n] [/i[:cmdline]] Dll名\n" > +"\n" > +"オプション:\n" > +" [/s] サイレントモード (一切のメッセージが表示されません)。\n" Please insert a space character between adopted compound word, i.e. サイレントモード. This point based on MS's Japanese style guide [1] at the last line in p.19. [1] http://download.microsoft.com/download/B/3/4/B34F7185-AFCA-4846-8FBF-672A1B… > +" [/i] DllInstallを呼び出し、追加の[cmdline]をパスします。\n" I think 「パス」 is not commonly used in this case. > +"\t[/u]を付けて使った場合、DllInstallはアンインストールモードで呼び出されま" > +"す。 \n" Same as 「サイレントモード」 case. (compound word) > #: regsvr32.rc:41 > msgid "" > "regsvr32: Invalid or unrecognized switch [%1]\n" > "\n" > msgstr "" > +"regsvr32: 無効な選択または認識できない選択です[%1]\n" > +"\n" In my opinion, 「選択」 is not widely used in this situation. How about to use 「スイッチ」 instead? > #: regsvr32.rc:43 > msgid "regsvr32: %1 not implemented in DLL '%2'\n" > -msgstr "" > +msgstr "regsvr32: %1はDLL '%2'内で実装されていません。\n" Can you remove the last 「。」? As original text doesn't have full-stop character. > #: regsvr32.rc:44 > #: regsvr32.rc:45 > #: regsvr32.rc:46 > #: regsvr32.rc:47 > #: regsvr32.rc:48 > #: regsvr32.rc:49 > #: regsvr32.rc:50 > #: regsvr32.rc:51 Same as above. If you would like to contact me, please e-mail to me. Of course, I can understand Japanese. However, in wine development, I prefer open discussion on wine-devel mailing list. Regards, Akihiro Sagawa

1 0

Re: mshtml: Added IHTMLTable::width property implementation.
by Jacek Caban 21 Apr '14

21 Apr '14

Hi Zhenbo, It looks better now. On 04/19/14 03:38, Zhenbo Li wrote: > @@ -395,15 +422,60 @@ static HRESULT WINAPI HTMLTable_get_rows(IHTMLTable *iface, IHTMLElementCollecti > static HRESULT WINAPI HTMLTable_put_width(IHTMLTable *iface, VARIANT v) > { > HTMLTable *This = impl_from_IHTMLTable(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); > - return E_NOTIMPL; > + nsAString val; > + HRESULT hres; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); > + hres = var2str(&val, &v); > + > + if (hres != S_OK){ > + ERR("Set Width(%s) failed when initializing a nsAString!\n", > + debugstr_variant(&v)); > + nsAString_Finish(&val); val is not initialized here, so you shouldn't call nsAString_Finish on it. > + return hres; > + } > + > + nsres = nsIDOMHTMLTableElement_SetWidth(This->nstable, &val); > + nsAString_Finish(&val); > + > + if (NS_FAILED(nsres)){ > + ERR("Set Width(%s) failed!\n", debugstr_variant(&v)); > + return E_FAIL; > + } > + > + return S_OK; > } > > static HRESULT WINAPI HTMLTable_get_width(IHTMLTable *iface, VARIANT *p) > { > HTMLTable *This = impl_from_IHTMLTable(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + nsAString val; > + nsresult nsres; > + DOUBLE width; > + const PRUnichar *str; > + > + TRACE("(%p)->(%p)\n", This, p); > + nsAString_Init(&val, NULL); > + nsres = nsIDOMHTMLTableElement_GetWidth(This->nstable, &val); > + if (NS_FAILED(nsres)){ > + ERR("Get Width(%s) failed!\n", debugstr_variant(p)); > + nsAString_Finish(&val); > + return E_FAIL; > + } > + > + nsAString_GetData(&val, &str); > + nsres = VarR8FromStr(str, 0, 0, &width); > + if (nsres == S_OK){ > + V_VT(p) = VT_I4; > + V_I4(p) = (LONG)width; > + } else { /* Symbols are in this string */ > + V_VT(p) = VT_BSTR; > + V_BSTR(p) = SysAllocString(str); > + if (!V_BSTR(p)) > + return E_OUTOFMEMORY; > + } > + return S_OK; > } > > static HRESULT WINAPI HTMLTable_put_height(IHTMLTable *iface, VARIANT v) > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 23677f4..10aca6c 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -5721,6 +5721,25 @@ static void _test_table_cell_spacing(unsigned line, IHTMLTable *table, const cha > VariantClear(&v); > } > > +#define cmp_length(a,b) _cmp_length(__LINE__,a,b) > +static void _cmp_length(unsigned line, VARIANT got, const char * exstr) > +{ > + static char buf[64]; > + ok_(__FILE__,line) (V_VT(&got)==VT_BSTR || V_VT(&got)==VT_I4, > + "V_VT is %hu, expected VT_BSTR(%hu) or VT_I4(%hu)\n", > + V_VT(&got), VT_BSTR, VT_I4); Please make it stricter and allow only one, exactly expected in given case, type. According to my quick tests (as I mentioned earlier), it's always VT_BSTR. Did you ever see it being VT_I4 in real Windows? If my testing is tight, this test hides a problem with your getter implementation. Cheers, Jacek

2 1

Re: [PATCH 1/4] msvcrt: Don't raise exception in _invalid_parameter (try2)
by Marvin 21 Apr '14

21 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6473 Your paranoid android. === wxppro (32 bit misc) === misc.c:335: Test failed: buf = C:\Documents and Settings\winetest\My Documents\msvcrt_test.exe misc popen misc.c:338: Test failed: _pclose returned 1, expected 0x37

2 1

The (broken) state of the WineTestBot
by Francois Gouget 21 Apr '14

21 Apr '14

My apologies for this last bout of WineTestBot brokenness. It all started when the VM host froze late last Friday and could not be remotely rebooted. So Newman power-cycled it Monday morning. He also suggested upgrading the kernel in the hope that this would avoid further crashes which I agreed to. Then I decided to upgrade to QEMU 1.7 in the hope of fixing the Dr6 ntdll:exception failures, or at least be in a better position to do so. Of course that entails redoing all the live VM snapshots (1) but I was prepared to do so. Then things went south. The issues ---------- I initially ran into some SELinux incompatibilities and then into QEMU/Libvirt incompatibilities (2). Then the VMs were suspending after a few seconds which turned out to be because the disk was full. My fault: I keep too many VM backups so the new VM backups I created finished filling it. That corrupted some VMs which, ironically, I was able to restore from backup after deleting older backups. Now the host now has a sane amount of free disk space and monitor it closely. But the real problem is that now the VMs get corrupted after a bit of use. This manifests through a couple of symptoms: * Sometimes the build VM will detect EXT4 filesystem corruption, remount '/' as read-only and obviously stop working properly. * Sometimes no filesystem corruption is detected but the content of files gets corrupted. For instance this is what caused all the 'Missing build status line' errors when half of the WineTestBot Build.pl sscript got lost. I suspect this also caused a round of build failures related to memcmp() being missing. * Sometimes the wtbbuild ends up at the grub prompt and complains that it cannot find the filesystem. Since these are live snapshots this is presumably preceded by a crash+reboot of the guest. * Sometimes, after qemu has been properly stopped, a 'qemu-img check' finds a lot of errors. Sometimes not despite the VM being broken. * The Windows 2000 VM also sometimes goes south: it resets and fails to reboot complaining some checksum is corrupted (probably that of the Windows boot loader). Of course QEMU behaves while I'm updating a VM's live snapshot. It's only after I've spent time doing so and creating a backup that it break the VM (thus also casting doubt into the trustworthiness of the new backup). Further compounding the problems, once the WineTestBot is on a tear compiling a bunch of patches on the lone build VM it's unstoppable (3). It also tends to get stuck whenever I restart libvirt or the VM host (a known issue I was working on before this episode). The strange thing is that QEMU 1.7 seems to work fine on my test environment. However it now appears that QEMU has at least three very different codepaths: * User-mode emulation which is slow and should not be used. * kvm_intel, uses the Intel VMX instructions, is used on my (Intel) test environment, has the icebp bug, but seems to otherwise be reliable. * kvm_amd, uses the AMD SVM instructions, is used by the WineTestBot's (AMD) VM host, has the Dr6 bug, and has been unreliable since last weekend. As kvm_adm and kvm_intel are kernel modules, the kernel version might actually be more important than the QEMU one. Indeed my latest tests seem to indicate that reverting the kernel from the 3.13 to 3.2.0 fixes the VM corruption issues (I also tested 3.14rc7 which did not help). A corrollary is that any QEMU tests I can do in my home environment are likely to be poor predictors for what will happen on the production VM host. Indeed it's because QEMU 1.7.0 seems to work fine here that I decided to upgrade the VM host. Short term goal --------------- Restore the WineTestBot to a working state! The current hope is that just reverting to a pre-3.13 kernel, maybe 3.2.0 will do the trick. That would make it possible to stick with QEMU 1.7.0 (Debian 7.0 (Stable/Wheezy) has 1.1.2 which is really too old but Wheezy-Backports has moved on to 1.7.0 so there's no easily accessible 1.6.0 packages to go back to). Longer term goals ----------------- * Solve the VM host crashes. The memory has been tested quite extensively already, and I did a badblocks pass on the hard-drive. Neither found anything. I could then test the process using PrimeNet. but the MRTG graphs did not indicate a tendency to overheat or other such problems. It now seems the crashes may be caused by the 3.2.0 kernel, and probably specifically by the kvm/kvm_amd modules. So finding a more recent kernel that actually works might help. * While I hope the VM host will never crash again, it would be nice to be able to remotely power-cycle it. * It will also be necessary to fix the stability issues in the 3.13 and 3.14 kvm_amd module. However given that I don't have an AMD box at hand and already way too many other things to do I don't see how that's going to happen. Maybe through a bug report once I get a better handle on this. Still the VM host cannot remain stuck on 3.2.0 indefinitely. * Given that on AMD the Dr6 bug still seems to be present in QEMU 2.0/Linux 3.13, it still needs to be fixed. (And the icebp one on Intel would be nice too). * Fix the mysterious 'network timeout' errors we get while waiting for a WineTest task to complete. Unfortunately the first set of patches to tackle them were not really conclusive. So maybe switch to plan B, i.e. blindly reconnect to work around them. That would be quite unsatisfying though. * Then resume work on making the WineTestBot Engine (more) resilient to network outages and VM host crashes. I started patches for that but working on them it became clear that this was entangled with proper handling and diagnostics after 'network timeout' errors. * Then resume work on all the other features and bugs of the WineTestBot. (1) QEmu 1.7.0 cannot restore a 1.6.0 live snapshot made in qemu-system-x86_64 https://bugs.launchpad.net/qemu/+bug/1259499 (2) A known issue caused by QEMU changing the 'qemu-system-x86_64 -cpu help' output format which is parsed by Libvirt to figure out which kinds of CPUs can be emulated. (3) Bug 35946 - Cannot mark a VM for maintenance if it is running a task http://bugs.winehq.org/show_bug.cgi?id=35946 -- Francois Gouget <fgouget(a)codeweavers.com>

3 5

Re: msvcrt: Remove wine-specific exports
by Alexandre Julliard 21 Apr '14

21 Apr '14

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcr100/msvcr100.spec | 4 ++-- > dlls/msvcr110/msvcr110.spec | 4 ++-- > dlls/msvcr70/msvcr70.spec | 4 ++-- > dlls/msvcr71/msvcr71.spec | 4 ++-- > dlls/msvcr80/msvcr80.spec | 4 ++-- > dlls/msvcr90/msvcr90.spec | 4 ++-- > dlls/msvcrt/mbcs.c | 7 ++---- > dlls/msvcrt/msvcrt.spec | 53 > --------------------------------------------- > dlls/msvcrt/string.c | 6 +++-- > 9 files changed, 18 insertions(+), 72 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M msvcrt.dll -p msvcrt_test.exe.so string && touch string.ok wine: Unhandled exception 0xc0000417 in thread 62 at address 0x7b83aa0e (thread 0062), starting debugger... Unhandled exception: 0xc0000417 in 32-bit code (0x7b83aa0e). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7b83aa0e ESP:0032f9a4 EBP:0032fa18 EFLAGS:00000246( - -- I Z- -P- ) EAX:7b826b79 EBX:7b8b5dac ECX:00000000 EDX:00000000 ESI:c0000417 EDI:00000000 Stack dump: 0x0032f9a4: 0032f9c4 009d0152 7bcc4514 c0000417 0x0032f9b4: 00000001 00000000 7b83aa0e 00000000 0x0032f9c4: 0032fa40 687415e1 68718cdf 00b100b0 0x0032f9d4: 00b300b2 039c00b4 681c8cc0 00000001 0x0032f9e4: 687415e0 0032fa28 6802d1bc 00000001 0x0032f9f4: 687415e0 68718cdf 68718c75 0032fa40 Backtrace: =>0 0x7b83aa0e RaiseException+0x5e(code=<couldn't compute location>, flags=<couldn't compute location>, nbargs=<couldn't compute location>, args=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/except.c:84] in kernel32 (0x0032fa18) 1 0x686c9b5d MSVCRT__invalid_parameter+0x8c() in msvcrt (0x0032fa78) 2 0x686da0c8 MSVCRT_memcpy_s+0x87(dest=0x6869112c, numberOfElements=0x8, src=0x68688415, count=0xf) [/home/julliard/wine/wine/dlls/msvcrt/heap.c:645] in msvcrt (0x0032fac8) 3 0x6865d547 test_memcpy_s+0x1f6() [/home/julliard/wine/wine/dlls/msvcrt/tests/string.c:581] in msvcrt_test (0x0032fb48) 4 0x686686c6 func_string+0xe55() [/home/julliard/wine/wine/dlls/msvcrt/tests/string.c:2737] in msvcrt_test (0x0032fd48) 5 0x6862b021 main+0x2f0(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/msvcrt/tests/../../../include/wine/test.h:584] in msvcrt_test (0x0032fe18) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: typo fixes - rebased - fixed
by Marvin 20 Apr '14

20 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6455 Your paranoid android. === w7u (32 bit msg) === msg.c:12058: Test failed: unexpected hwnd 0017014A msg.c:12080: Test failed: bad time 310a2/310b2

1 0

Re: typo fixes - rebased - fixed
by Marvin 20 Apr '14

20 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6454 Your paranoid android. === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w864 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w864 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A

1 0

Re: [PATCH 2/6] wined3d: Pass the volume texture level to the client libraries.
by Henri Verbeet 20 Apr '14

20 Apr '14

On 17 April 2014 15:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The goal is to remove volumes and surfaces from the wined3d public API. > This extra information is needed for the transition. We got rid of this not too long ago, adding it back doesn't sound very attractive. If you really need a way to find out a volume's level, I'd prefer wined3d_volume_get_level() instead, mostly because it doesn't need changes in every D3D library. I'm not convinced this is really necessary though, or that starting in d3d9 as opposed to wined3d with this is necessarily the right approach.

2 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel