- wine-devel - winehq.org

Re: [PATCH 1/2] ntdll: Add a replacement getmntent for Android.
by Huw Davies 09 Apr '14

09 Apr '14

On Tue, Apr 08, 2014 at 12:18:23PM +0400, Vitaly Lipatov wrote: > I think the more appropriate place for a missed libc function is > libs/port. If it is ever needed by another dll, then it can get moved there. Huw.

2 1

Problem Wine 1.4/ wintricks Mint Petra with installing mfc42.dll
by Thomas Paleschke 08 Apr '14

08 Apr '14

installing mfc42.dll with winetricks under wine version 1.4 and Linux Mint 16 (Petra) is aborted with the following error: ~/.cache/winetricks/vcrun6 $ winetricks mfc42 Executing w_do_call mfc42 Executing load_mfc42 Executing wine /home/thomas/.cache/winetricks/vcrun6/vc6redistsetup_deu.exe /T:C:\windows\Temp\_mfc42 /c wine: Unhandled page fault on read access to 0x00000001 at address 0x7bc493a0 (thread 0032), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc493a0 ------------------------------------------------------ Note: command 'wine /home/thomas/.cache/winetricks/vcrun6/vc6redistsetup_deu.exe /T:C:\windows\Temp\_mfc42 /c' returned status 5. Aborting. ------------------------------------------------------

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 3 Resend )
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6231 Your paranoid android. === build (build) === Make failed

1 0

Re: services: Skip tests if OpenSCManager failed.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6230 Your paranoid android. === build (build) === Make failed

1 0

Re: mshtml: Ignore QueryHitPoint calls in activex.c tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6229 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 5/5] d3d9/tests: Use a separate device for release_buffer_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6228 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 4/5] d3d9/tests: Use a separate device for float_texture_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6227 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for g16r16_texture_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6226 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for pixelshader_blending_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6225 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 1/5] d3d9/tests: Use a separate device for texture_transform_flags_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6224 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 6/6] ole32: Add more SetConvertStg amd WriteFmtUserTypeStg tests (try2)
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6207 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/6] ole32: Add OleDoAutoConvert implementation (try2)
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6206 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] dwrite: Added GetTrimming()/SetTrimming() for text format
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6217 Your paranoid android. === build (build) === Missing build status line

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 3 Resend )
by Stefan Dösinger 08 Apr '14

08 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-04-08 12:12, schrieb Alistair Leslie-Hughes: > Hi, > Any feedback would be good. A few mostly minor things come to my mind. > + if(!pguidSP) > + return DPNERR_INVALIDPOINTER; > ... > + ok(hr == DPNERR_DOESNOTEXIST, "got 0x%08x\n", hr); > ... > + ok( hr == S_OK, "failed to init com\n"); > + if (hr != S_OK) Style inconsistencies. > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&localaddr); Please avoid LPVOID and similar pointer types. Just use void **. > + hr = IDirectPlay8Address_SetSP(localaddr, NULL); > + ok(hr == DPNERR_INVALIDPOINTER, "got 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); Since you're using GUID_NULL as a way to signal that no guid is set it would be a good idea to try to pass it to SetSP and see if you still get DPNERR_DOESNOTEXIST when you call GetSP. Otherwise this looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTQ9jeAAoJEN0/YqbEcdMwDisP/iFE7fHlWn2B0LYwVNgu6lD9 6OQdMWuLYAiWRWQKx9WaBAiwdq6ZmG3WnfHfuLPAI5VkHh0lUZwOTil/J7KQYVoj rVeCA6wKDHMPXUHcRC0uB7gZlzh5JKCq60iQ4xeJ9CUAk/fhVMOGd8+xXew2HYfo K4WVyEw8FYg88F+YzQh1dWj4e84dn+yn0+yGYrqSxXOTeJFcal1EOo0myGcZgBto uLUvFb/NBQFMzwN/mOL84YzY4nRCpIbenQbI+03BT7YR/lX1Q3IOdvTyB+dsN8pQ iO+ekMEFR0PYOkG6skmLlkAkRHCeq9uxyLHaxvtUPv9NuA+GgvQY6xhXielnVn8f GGzlvHd01bNjccZQTjSbvE45rsp3/PGuV3592DNbhZGmiZ10D8bY/yu2QW3F6sHP d9yhyJc4ubi3vlJ0UTUF8joZzL2rSydWvTa5VLNkWhqnZUzJqE2lwG6QI5IqUjra Khl3W5P5SyFfoBZcWQwHVOURa3IzZOsYQWm6jbjJqrBXphUGg6wZZ1YgfTqlfoqq vq9Xnr90UulxQHB4txTcviDOQi8EXAOmAIbhSImsam6hCht0A75zuxIP84LhS/mv UkjblDHxCGneNrkq7tuJiARjwj6D5RJY26iYaw70sHOhJBFKXSzARmtP5At+BwRd wplsw498wUMBAVjAl/ZB =TIUo -----END PGP SIGNATURE-----

1 0

Re: wmp: add HKLM\\Software\\Microsoft\\Multimedia\\WMPlayer\\Extensions key (try 2)
by Jacek Caban 08 Apr '14

08 Apr '14

Hi Austin, On 04/08/14 12:16, Austin English wrote: > +HKLM > +{ > + 'SOFTWARE' > + { > + 'Microsoft' > + { > + 'Multimedia' > + { Those should probably use NoRemove attribute. Jacek

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 3 Resend )
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6231 Your paranoid android. === build (build) === Missing build status line

1 0

Re: services: Skip tests if OpenSCManager failed.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6230 Your paranoid android. === build (build) === Missing build status line

1 0

Re: mshtml: Ignore QueryHitPoint calls in activex.c tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6229 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 5/5] d3d9/tests: Use a separate device for release_buffer_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6228 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 4/5] d3d9/tests: Use a separate device for float_texture_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6227 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for g16r16_texture_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6226 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for pixelshader_blending_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6225 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 1/5] d3d9/tests: Use a separate device for texture_transform_flags_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6224 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [4/4] taskschd: Implement IRegisteredTask::get_Path.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6223 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [3/4] taskschd: Implement IRegisteredTask::get_Name.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6222 Your paranoid android. === build (build) === Could not copy the patch to the VM: the "nc -q0 '10.42.42.130' '4242'" command returned 1

1 0

Re: [2/4] taskschd: Implement task management using RPC APIs.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6221 Your paranoid android. === build (build) === Could not copy the patch to the VM: the "nc -q0 '10.42.42.130' '4242'" command returned 1

1 0

Re: [2/2] schedsvc/tests: Avoid test failures on file systems with enabled directory randomization.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6220 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [1/2] schedsvc/tests: Fix a couple of typos.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6219 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 2/2] dwrite: Added partial implementation for CreateEllipsisTrimmingSign()
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6218 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 1/2] dwrite: Added GetTrimming()/SetTrimming() for text format
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6217 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 5/5] ddraw: SetPrivateData(..., data = NULL, ...) is not valid.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6216 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 4/5] dxgi/tests: Add private data tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6215 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 3/5] ddraw/tests: Nvidia has an off-by-one rectangle handling bug.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6214 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 2/5] d3d8/tests: Test locking of mipmap textures.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6213 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 1/5] d3d9/tests: Test locking of mipmap textures.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6212 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 6/6] ole32: Add more SetConvertStg amd WriteFmtUserTypeStg tests (try2)
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6207 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 5/6] ole32: Add OleDoAutoConvert implementation (try2)
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6206 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [4/4] user32: Emit EM_SETSEL message when choosing "Select All" from context menu.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6205 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [3/4] user32: Don't emit WM_COMMAND on choosing an item in a context menu (Edit control).
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6204 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [2/4] user32/tests: Add some tests for edit control context menu messages.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6203 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [1/4] user32/tests: Don't forget to destroy the parent window after the tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6202 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [1/4] user32/tests: Don't forget to destroy the parent window after the tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6202 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 1/2] ntdll: Add a replacement getmntent for Android.
by Vitaly Lipatov 08 Apr '14

08 Apr '14

Huw Davies писал 2014-04-07 16:22: > Bionic has a stub function named getmntent which outputs an > unimplemented message. > --- > dlls/ntdll/directory.c | 101 I think the more appropriate place for a missed libc function is libs/port. -- Vitaly Lipatov, Etersoft

1 0

Re: [4/4] taskschd: Implement IRegisteredTask::get_Path.
by Alexandre Julliard 08 Apr '14

08 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/taskschd/regtask.c | 12 ++++++++++-- > dlls/taskschd/tests/scheduler.c | 34 ++++++++++++++++++++++++++-------- > 2 files changed, 36 insertions(+), 10 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M taskschd.dll -p taskschd_test.exe.so scheduler && touch scheduler.ok scheduler.c:827: Test succeeded inside todo block: expected VARIANT_FALSE, got 0 scheduler.c:887: Test succeeded inside todo block: expected VARIANT_FALSE, got 0 make: *** [scheduler.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: regsvr32: Improve a few resource strings
by Nikolay Sivov 07 Apr '14

07 Apr '14

I don't want another oversized thread on this, but: -\ [/u] Unregister a server.\n\ +\ [/u] Unregister a module.\n\ You don't really register a module, it registers COM server that's implemented in some module. So server is important part, module hosting it is details.

2 1

Re: [PATCH 3/6] ole32: Try to open 1Ole stream before trying to create it in SetConvertStg function (try2)
by Vincent Povirk 07 Apr '14

07 Apr '14

Looks good to me.

1 0

Re: [PATCH 3/5] ole32: Try to open 1Ole stream before trying to create it in SetConvertStg function
by Vincent Povirk 07 Apr '14

07 Apr '14

This looks like a no-op to me. It means we read/update the flags even if we created the stream, but in that case it should already be correct. Why do we need this?

2 1

Re: [3/5] netprofm: Add a class factory implementation.
by Dmitry Timoshkov 07 Apr '14

07 Apr '14

Hi Hans, Hans Leidekker <hans(a)codeweavers.com> wrote: > +struct netprofm_cf > +{ > + const struct IClassFactoryVtbl *vtbl; > + HRESULT (*create_instance)(void **); > +}; > + > +static inline struct netprofm_cf *impl_from_IClassFactory( IClassFactory *iface ) > +{ > + return (struct netprofm_cf *)((char *)iface - FIELD_OFFSET( struct netprofm_cf, vtbl )); > +} Objects in this new dll don't follow http://wiki.winehq.org/COMGuideline, but that's not a big problem, and could be fixed later. > +static HRESULT WINAPI netprofm_cf_CreateInstance( IClassFactory *iface, LPUNKNOWN outer, > + REFIID riid, LPVOID *obj ) > +{ > + struct netprofm_cf *factory = impl_from_IClassFactory( iface ); > + IUnknown *unk; > + HRESULT r; > + > + TRACE( "%p %s %p\n", outer, debugstr_guid(riid), obj ); > + > + *obj = NULL; > + if (outer) return CLASS_E_NOAGGREGATION; > + > + r = factory->create_instance( (void **)&unk ); > + if (FAILED( r )) > + return r; > + > + r = IUnknown_QueryInterface( unk, riid, obj ); > + if (FAILED( r )) > + return r; > + > + IUnknown_Release( unk ); > + return r; > +} It seems that 'unk' is leaked if IUnknown_QueryInterface fails. -- Dmitry.

1 0

Re: loader: add HKLM\\Software\\Microsoft\\Multimedia\\WMPlayer\\Extensions key
by Jacek Caban 07 Apr '14

07 Apr '14

Hi Austin, On 04/07/14 09:32, Austin English wrote: > diff --git a/loader/wine.inf.in b/loader/wine.inf.in > index 1f08d2e..8200d41 100644 > --- a/loader/wine.inf.in > +++ b/loader/wine.inf.in > @@ -662,6 +662,8 @@ HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-99 > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Locale",2,"*" > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Version",2,"4,74,9273,0" > > +; Windows Media Player > +HKLM,SOFTWARE\Microsoft\Multimedia\WMPlayer\Extensions,,16 This could probably go to dlls/wmp/wmp.rgs. Jacek

1 0

Re: [2/2] include/vfw.h: Replace handmade COM method macros by widl generated ones (including inline wrappers).
by Nikolay Sivov 07 Apr '14

07 Apr '14

I think the idea was to have a proper idl file eventually.

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel