- wine-devel - winehq.org

Re: [PATCH 2/2] dwrite: Store text format properties
by Dmitry Timoshkov 07 Apr '14

07 Apr '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static HRESULT WINAPI dwritetextformat_SetLineSpacing(IDWriteTextFormat *iface, DWRITE_LINE_SPACING_METHOD method, > + FLOAT spacing, FLOAT baseline) > { > struct dwrite_textformat *This = impl_from_IDWriteTextFormat(iface); > - FIXME("(%p)->(%d %f %f): stub\n", This, spacing, line_spacing, baseline); > - return E_NOTIMPL; > + TRACE("(%p)->(%d %f %f)\n", This, method, spacing, baseline); > + This->format.spacingmethod = method; > + This->format.spacing = spacing; > + This->format.baseline = baseline; > + return S_OK; > } Probably all the format properties setters should handle invalid enum or negative floating point arguments some way. -- Dmitry.

2 3

Re: [3/5] ntdll: Implement RtlInstallFunctionTableCallback on x86_64.
by Dmitry Timoshkov 07 Apr '14

07 Apr '14

Sebastian Lackner <sebastian(a)fds-team.de> wrote: > +BOOLEAN CDECL RtlInstallFunctionTableCallback( DWORD64 table, DWORD64 base, DWORD length, > + PGET_RUNTIME_FUNCTION_CALLBACK callback, PVOID context, PCWSTR dll ) > +{ http://msdn.microsoft.com/en-us/library/windows/desktop/ms680595%28v=vs.85%… claims that RtlInstallFunctionTableCallback is WINAPI, not CDECL, which one is correct? -- Dmitry.

2 1

Re: [3/5] ntdll: Implement RtlInstallFunctionTableCallback on x86_64.
by Dmitry Timoshkov 07 Apr '14

07 Apr '14

Sebastian Lackner <sebastian(a)fds-team.de> wrote: > +@ cdecl -arch=x86_64 RtlInstallFunctionTableCallback(long long long ptr ptr ptr) ... > +BOOLEAN CDECL RtlInstallFunctionTableCallback( DWORD64 table, DWORD64 base, DWORD length, > + PGET_RUNTIME_FUNCTION_CALLBACK callback, PVOID context, PCWSTR dll ) spec entry doesn't match the implementation. Probably it should be (int64 int64 long ptr ptr wstr) -- Dmitry.

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 8
by Stefan Dösinger 06 Apr '14

06 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-04-04 13:57, schrieb Patrick Rudolph: > + static struct > + { > + const char *name; > + DDPIXELFORMAT fmt; > + } > + formats[] = You can make this const. > + /* 6: Test maximum surface height */ > + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN, 1, 0x10000, DDERR_INVALIDPARAMS}, > + /* 7: Test maximum surface width */ > + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN, 0x10000, 1, DDERR_INVALIDPARAMS}, These tests fail on Wine. Please include your patch that introduces the size check in this patch or in a separate patch to apply before this one, or mark them todo_wine. > + /* 8: Test OUTOFVIDEOMEMORY */ > + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN | DDSCAPS_VIDEOMEMORY, > + 0xffff, 0xffff, DDERR_OUTOFVIDEOMEMORY}, This also fails on Wine. You'll have to move the adapter_adjust_memory() call in dlls/wined3d/resource.c, resource_init() ahead of the memory allocation call. > + /* 9: Test OUTOFMEMORY */ > + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN | DDSCAPS_SYSTEMMEMORY, > + 0xffff, 0xffff, DDERR_OUTOFMEMORY}, This test still fails in 64 bit on my Windows 7 test machine with D3DFMT_P8. The failure happens because CreateSurface succeeds although the test expects it to fail. I'd suggest to remove this test for the same reason as test 10. > + /* does the hardware support videomemory ? */ > + if (!(ddcaps.ddsCaps.dwCaps & DDSCAPS_VIDEOMEMORY)) > + { > + tests[8].hr = DDERR_NODIRECTDRAWHW; > + } You can remove the curly brackets here. > + for (i = 0; i < sizeof(tests) / sizeof(*tests); i ++) > + { > + if (surface) > + { > + IDirectDrawSurface_Release(surface); > + surface = NULL; > + } > + > + memset(&surfacedesc, 0, sizeof(surfacedesc)); > + surfacedesc.dwSize = sizeof(surfacedesc); > + surfacedesc.dwFlags = tests[i].dwFlags | DDSD_PIXELFORMAT; > + surfacedesc.ddsCaps.dwCaps = tests[i].dwCaps; > + surfacedesc.dwWidth = tests[i].dwWidth; > + surfacedesc.dwHeight = tests[i].dwHeight; > + surfacedesc.ddpfPixelFormat = formats[j].fmt; > + > + hr = IDirectDraw_CreateSurface(ddraw, &surfacedesc, &surface, NULL); > + ok(hr == tests[i].hr, "Pixelformat %s, test %d returned %08x\n", formats[j].name, i, hr); > + } Why is the surface release before the create call? You're potentially leaking surfaces here. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTQdGlAAoJEN0/YqbEcdMwvikP/RT9mO2pARAAfY7DIRuOns3R 8rYw7skxAOwKU12NK42gaSqTjZKoRglpXyYJwD1keq9uRZnk8oAy4yQN7axg3/wq OI8gF6VN9Dlqofq6l4FD8rNC0yBFxxehZkOJXpzGXGisDau3C+pK007+fnwb0zQI IOJ+M/ok+cOvmymbktmrRryVtrttG5Z0EYqpBQw53+ZTKUyu6AhcuoXV5Sf04Jkx SnCHhRn3RLKEMTwc/XT6O5+in89CgIcrMmNWnCk0JrgywNhqOxX4A9HzkHTL3h/n OHR1fJW4SmRDwT4r+nQmOBjIY7tCipv0xK5LTOqbaNCDxTIyZL2AOji5PeR4mZWH iHPOb6826iouxE8P12cLfgueBebhY/lVCmiWwV67K7koFSmYs4MhtR/jdeiuZ8rI jYgta2gNvP8Nk+R+HGxhGg6rrykNBb+lWTI5Ua+QAa7DBdW9uldLH4U+bf6mti90 171NAQA0VTrxV/dnkAxOmZ4jXogWhShrIyElD3PG6ZCxZ6W85/tdLReAyy/+feoQ OS+QdlYDrnYJlW0Bko254YAWJHk5hViy7feDFCHl+FuI/7hN3+UmKvpVloWkD7sh EpRqmAm8GtxAyaPsJtJVkWQ6s3YTkoYIZOSVUbItRWJbQvEfB/DDIYG6lTkGAxS5 cEUsoGMsqQbBK9QZf/s2 =TT3X -----END PGP SIGNATURE-----

1 0

Re: po: Revise Russian translation
by Nikolay Sivov 06 Apr '14

06 Apr '14

Looks good. I especially like changes like these: --- -msgstr "Пожалуйста, выберите файл." +msgstr "Выберите файл." ---

4 10

Re: [PATCH] ntdll: Don't enter uninterrupted section when get_cached_fd hits
by Ken Thomases 06 Apr '14

06 Apr '14

On Apr 5, 2014, at 5:25 PM, Daniel Horn wrote: > The call to server_enter_uninterrupted_section in server_get_unix_fd > was causing 2 million syscalls over the span of several seconds when > launching many popular application suites and it was causing > significant performance overhead. > > Switching those two lines resolves the problem entirely because the > cache is sized such that it nearly never misses. You can't call get_cached_fd() without entering the critical section because the critical section is protecting the fd cache. Your patch opens the code up to race conditions and data inconsistency. -Ken

2 5

Re: [PATCH 5/5] ddraw/tests: Add mipmap locking tests.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6163 Your paranoid android. === w8 (32 bit ddraw2) === Failure running script in VM: timed out waiting for the child process === w8 (32 bit ddraw1) === ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw7) === ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. ddraw7.c:5765: Test failed: Failed to set cooperative level, hr 0x8876023b. === wvistau64 (64 bit ddraw7) === Unable to set the VM system time: the "nc -q0 '10.42.42.238' '4242'" command returned 1 === w2000pro (32 bit ddraw4) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

1 0

Re: [PATCH 2/2] d3d8/tests: Test locking of mipmap textures.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6166 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9/tests: Test locking of mipmap textures.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6165 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d8/tests: Test locking of mipmap textures.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6162 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 0006019E, got 00010048. device.c:3038: Test failed: Expected wndproc 0x412120, got 0x412120.

1 0

Re: [PATCH 2/5] d3d8/tests: Add a test for (sub-) resource types.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6160 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 000501D8, got 00010048. device.c:3038: Test failed: Expected wndproc 0x412120, got 0x412120.

1 0

Re: [PATCH 3/5] d3d9/tests: Test locking of mipmap textures.
by Henri Verbeet 04 Apr '14

04 Apr '14

On 4 April 2014 11:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + hr = IDirect3DDevice9_CreateTexture(device, 4, 4, 2, 0, D3DFMT_X8R8G8B8, > + D3DPOOL_DEFAULT, &texture_dst, NULL); > + ok(SUCCEEDED(hr), "Failed to create texture, hr %#x.\n", hr); > + hr = IDirect3DTexture9_GetSurfaceLevel(texture_dst, 0, &surface_dst); > + ok(SUCCEEDED(hr), "Failed to get surface level, hr %#x.\n", hr); > + hr = IDirect3DTexture9_GetSurfaceLevel(texture_dst, 0, &surface_dst2); > + ok(SUCCEEDED(hr), "Failed to get surface level, hr %#x.\n", hr); > + This gets two references to the same surface level, is that intentional? > + hr = IDirect3DDevice9_UpdateSurface(device, surface, NULL, surface_dst, NULL); > + ok(SUCCEEDED(hr), "Failed to update surface, hr %#x.\n", hr); > + hr = IDirect3DDevice9_UpdateSurface(device, surface2, NULL, surface_dst2, NULL); > + todo_wine ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); > + Doesn't this just fail because the surface sizes are different? (Although I would have expected this to work.)

2 1

Re: [PATCH] ddraw: add dsurface dimension tests, try 7
by Stefan Dösinger 04 Apr '14

04 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Thanks for the patch. I'll test it on my Windows boxes as soon as they're done with Linux updates (Gentoo...) and report any failures I find. Am 2014-04-03 17:54, schrieb Patrick Rudolph: + window = CreateWindowA("static", "ddraw_test", WS_OVERLAPPEDWINDOW, + 100, 100, 160, 160, NULL, NULL, NULL, NULL); + + if (!(ddraw = create_ddraw())) + { + skip("Failed to create a ddraw object, skipping test.\n"); + return; + } You no longer need the skip check here. The main functions in ddraw1-ddraw7 check if ddraw creation succeeds and skip all tests if it doesn't + + ret = IDirectDraw_SetCooperativeLevel(ddraw, window, DDSCL_NORMAL); + + ddcaps.dwSize = sizeof(DDCAPS); You're not checking the return value here. I also recommend to rename "ret" to "hr" for consistency with other tests. + ret = IDirectDraw_GetCaps(ddraw, &ddcaps, NULL); + if (ret != DD_OK) + { + skip("IDirectDraw_GetCaps failed with %08x\n", ret); + return; + } Do you have hardware where GetCaps fails? If not, a simple ok(SUCCEEDED(hr), ...) should be enough. +#if _WIN64 || __x86_64__ || __ppc64__ + { + MEMORYSTATUSEX statex; + statex.dwLength = sizeof (statex); + GlobalMemoryStatusEx (&statex); + /* on 64bit surfaces with 2GByte+ are possible */ + if(statex.ullAvailVirtual > 0x80000000LL) + tests[10].ret = DD_OK; + } +#endif Is the #if necessary? Afaics GlobalMemoryStatusEx should work on 32 bit as well. In light of the testbot failures I recommend to check for available physical memory as well. I'm also fine with just dropping the SYSMEM out of memory test until we find an application that depends on this behavior. The parenthesis placement after the function call and if are inconsistent. This applies to a few other ifs as well. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTPmKGAAoJEN0/YqbEcdMwUwEP/A5NCz4xe855Z9jX6iUBWkhw NDhpM/9Wbk5tdekaR3QcrNyCYGCAHnOl/kUsGXeBDwZxCDzRzpfsdpFp0Nux46m+ L/xtf71bhAMYGikeV9r/C+UVBbCslO4KXFcUmx5K43AXcVQGMq+K1yvzhGtKCGZb 6zNCUmhxI2MlNrU9KDp7W7kNhVWMu2ungAjojT5BmaWDgtvS6TWu10jX1rIwQlYF wMOHSIomIBNvPi2vSr8aXLzPhgFCrMg3g8fERUqS3Vk8LJfmJYWJ87hcfPiMGd5A ntDYedg+mhV0ShTk26XCeKMNBfvjcdwWCnHEi1GYmYQ6H/nRDGxkEO/TskiNLuNn IO/rV2TAO9SfzHzHO/VPCGdb6nISGICAP/oA2ryrhINdXtn6eq1kjqQsGUURlqlk Y46P55qgRleYCtqxHjrjhQXDL4anaKj3ApZjGRa9MVC2/SPvIe3UpjlHjN4oeAix ohiOiq7GL/PXXs0zLOKFeVdUoOYpCIuP7MsR/dX9KcJwYQ2U9GT6OEoQPhZT+/B7 Tpv1maEOnn+UCkvcW6BY2eAt3nsznvlKVb73D5t1tLp/LCbKiSqY+8Dk0f75YTyG hEXkawRFLjhXeA6db8ieb2GdftaAnfq1Vxa7wjF4igAccZIhySInrvdnOFhZ4rp+ djHZm23O6ml1uV8Qt0mW =yrSd -----END PGP SIGNATURE-----

1 1

libwine-print missing when compiling from source
by Alois Schlögl 04 Apr '14

04 Apr '14

When compiling wine from source according to instructions on http://wiki.winehq.org/Wine64 "Building a shared WoW64 setup (most likely what you want)" starting Igor Pro fails in the same way, as if libwine-print is not installed. I'm using debian7:x86_64, and IgorPro is working fine when the debian version of wine (v1.4.1) with libwine-print is installed. What do I need to do in order the have libwine-print when compiling wine from source ? -- Alois

3 4

Re: [1/5] include: Add dxva2api.idl
by Nikolay Sivov 04 Apr '14

04 Apr '14

On 4/4/2014 08:44, Michael Müller wrote: > This first set of patches adds the required interface definitions and > headers which are required for the dxva2 implementation. Please note > that the ugly names of the header files were not my idea, thats exactly > the same name how they're called by MS. Yes, looks like 8.3 rule no longer applies :) > > The last patch of the series implements stub functions for every member > of dxva2.dll, such that applications do not abort anymore when they hit > one of the stub exports. > > --- > include/Makefile.in | 1 + > include/dxva2api.idl | 534 > ++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 535 insertions(+) > create mode 100644 include/dxva2api.idl > +cpp_quote("#if 0") > +typedef DWORD IDirect3DDevice9; > +typedef DWORD IDirect3DSurface9; > + > +typedef DWORD D3DFORMAT; > +typedef DWORD D3DPOOL; > +cpp_quote("#endif") First I thought it's a bit ugly, but apparently that's how it's done in SDK. > +enum > +{ > + DXVA2_PictureParametersBufferType = 0, > + DXVA2_MacroBlockControlBufferType = 1, > + DXVA2_ResidualDifferenceBufferType = 2, > + DXVA2_DeblockingControlBufferType = 3, > + DXVA2_InverseQuantizationMatrixBufferType = 4, > + DXVA2_SliceControlBufferType = 5, > + DXVA2_BitStreamDateBufferType = 6, > + DXVA2_MotionVectorBuffer = 7, > + DXVA2_FilmGrainBuffer = 8 > +}; > + > +enum > +{ > + DXVA2_VideoDecoderRenderTarget = 0, > + DXVA2_VideoProcessorRenderTarget = 1, > + DXVA2_VideoSoftwareRenderTarget = 2 > +}; > + You don't need explicit initializers in this case. > +[ > + object, > + uuid(a0cade0f-06d5-4cf4-a1c7-f3cdd725aa75), > + helpstring("IDirect3DDeviceManager9 Interface"), > + local > +] No need for helpstring(), it's only used definitions participating in typelibs.

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 7
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6141 Your paranoid android. === w8 (32 bit ddraw4) === The test timed out === wvistau64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w2008s64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w7pro64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w8 (32 bit ddraw2) === ddraw2.c:5071: Test failed: Got unexpected refcount 3. ddraw2.c:5090: Test failed: Got unexpected refcount 3. ddraw2.c:5097: Test failed: Got unexpected hr 0. ddraw2.c:5100: Test failed: Got unexpected refcount 3. ddraw2.c:5102: Test failed: Got unexpected refcount 2. ddraw2.c:5108: Test failed: Got unexpected hr 0. ddraw2.c:5111: Test failed: Got unexpected refcount 2. ddraw2.c:5113: Test failed: Got unexpected refcount 1. === wvistau64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w2008s64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w7pro64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w8 (32 bit ddraw1) === ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === wvistau64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w2008s64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w7pro64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 8007000e === w2000pro (32 bit ddraw7) === The test timed out === w8 (32 bit ddraw7) === ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. ddraw7.c:5765: Test failed: Failed to set cooperative level, hr 0x8876023b. === wvistau64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w2008s64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w7pro64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e

1 0

Re: [PATCH 5/5] ws2_32: Add an interactive test for interface change notifications.
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6142 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 71AB4047 === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 6
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6140 Your paranoid android. === w8 (32 bit ddraw4) === No test summary line found Failure running script in VM: network read timed out (wait2:ListSize:0/4) === wvistau64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w8 (32 bit ddraw2) === ddraw2.c:740: Test failed: Got unexpected color 0x00000000. ddraw2.c:3120: Test failed: Got unexpected color 0x000000ff. === wvistau64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w8 (32 bit dsurface) === dsurface.c:310: Test failed: Destination data after blitting is not correct dsurface.c:344: Test failed: Destination data after blitting is not correct dsurface.c:523: Test failed: Surface data after srckey blit does not match dsurface.c:548: Test failed: Surface data after src override key blit does not match dsurface.c:602: Test failed: Surface data after dest key blit does not match dsurface.c:628: Test failed: Surface data after dest key override blit does not match dsurface.c:690: Test failed: Surface data with src key and dest key blit does not match === w8 (32 bit ddraw1) === ddraw1.c:2828: Test failed: Got unexpected color 0x000000ff. ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === wvistau64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2000pro (32 bit ddraw7) === Failure running script in VM: timed out waiting for the child process === w8 (32 bit ddraw7) === ddraw7.c:3112: Test failed: Clear with count = 0, rect != NULL has color 0xff0000. ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. The test timed out === wvistau64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000

1 0

Re: [PATCH 3/3] scrrun: Implement FreeSpace() for a drive
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6136 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:1358: Test failed: got 0x00000000 filesystem.c:1482: Test failed: got DEADBEEF filesystem.c:1495: Test failed: got 0x00000000 filesystem.c:1510: Test failed: got 0x00000000 filesystem.c:1518: Test failed: got DEADBEEF filesystem.c:1524: Test failed: got DEADBEEF filesystem.c:1543: Test failed: got 0x00000000 filesystem.c:1564: Test failed: got DEADBEEF filesystem.c:1658: Test failed: got 0x00000000 filesystem.c:1672: Test failed: got DEADBEEF filesystem.c:1691: Test failed: got 0x00000000

1 0

Re: [PATCH 2/3] scrrun: Implement Read()
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6135 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:1349: Test failed: got 0x00000000 filesystem.c:1473: Test failed: got DEADBEEF filesystem.c:1486: Test failed: got 0x00000000 filesystem.c:1501: Test failed: got 0x00000000 filesystem.c:1509: Test failed: got DEADBEEF filesystem.c:1515: Test failed: got DEADBEEF filesystem.c:1534: Test failed: got 0x00000000 filesystem.c:1555: Test failed: got DEADBEEF filesystem.c:1649: Test failed: got 0x00000000 filesystem.c:1663: Test failed: got DEADBEEF filesystem.c:1682: Test failed: got 0x00000000

1 0

Re: [PATCH 1/3] scrrun: Implement ReadAll()
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6134 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:1349: Test failed: got 0x00000000 filesystem.c:1473: Test failed: got DEADBEEF filesystem.c:1486: Test failed: got 0x00000000 filesystem.c:1501: Test failed: got 0x00000000 filesystem.c:1509: Test failed: got DEADBEEF filesystem.c:1515: Test failed: got DEADBEEF filesystem.c:1534: Test failed: got 0x00000000 filesystem.c:1555: Test failed: got DEADBEEF

1 0

Re: apphelp: add a stub for SdbInitDatabase (try 2)
by Dmitry Timoshkov 03 Apr '14

03 Apr '14

Austin English <austinenglish(a)gmail.com> wrote: > + if (path) > + FIXME("stub: flags: %08x, path: \"%s\". Unexpected, please report!\n", flags, debugstr_w(path)); > + else > + FIXME("stub: %08x %s\n", flags, debugstr_w(path)); What's the reason for this if/else? What exactly is not expected and why this matters for a stub? -- Dmitry.

2 2

Re: [3/6] widl: Avoid generating negative offsets for conformant arrays of strings. Take 2.
by Alexandre Julliard 02 Apr '14

02 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the patch limits the changes to conformant arrays of > strings in order to avoid unwanted changes to other pointer types. Didn't you say that midl is doing this for all arrays? Why doesn't this work in our case? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [6/6] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 02 Apr '14

02 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6118 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH] mshtml: Implemented numeral parsing in get_frame_by_name (try 2).
by Jacek Caban 02 Apr '14

02 Apr '14

Hi Qian, On 04/01/14 22:08, Qian Hong wrote: > diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c > index a57dfba..3d6323c 100644 > --- a/dlls/mshtml/htmlwindow.c > +++ b/dlls/mshtml/htmlwindow.c > @@ -379,6 +379,20 @@ HRESULT get_frame_by_name(HTMLOuterWindow *This, const WCHAR *name, BOOL deep, H This is not the right place to do it. See callers of the function. I don't think we want that behaviour in, for example, get_target_window. > UINT32 length, i; > nsresult nsres; > HRESULT hres = S_OK; > + VARIANT v, idx; > + > + V_VT(&v) = VT_BSTR; > + V_BSTR(&v) = SysAllocString(name); > + VariantInit(&idx); > + hres = VariantChangeType(&idx, &v, VARIANT_LOCALBOOL, VT_I4); There are better ways to do that conversion, like strtolW. > + VariantClear(&v); > + if (SUCCEEDED(hres)) > + { > + hres = get_frame_by_index(This, V_I4(&idx), ret); > + VariantClear(&idx); > + return hres; > + } > + VariantClear(&idx); Clearing VARIANT of VT_I4 type is not really useful. Also, as Austin said, this definitely needs a test case. You may write that in JavaScript, if you prefer. See existing tests in *.html files. Cheers, Jacek

2 1

Re: mshtml: Added IHTMLTable::width property implementation.
by Jacek Caban 02 Apr '14

02 Apr '14

Hi Zhenbo, On 03/31/14 16:26, Zhenbo Li wrote: > As my test case shows, windows would truncate float numbers. > I considered VarInt() in oleaut32.dll, but I think to declare > var2str_length() is more clear. +static HRESULT var2str_length(nsAString *nsstr, const VARIANT *p) +{ + static WCHAR buf[64]; + static const WCHAR formatW[] = {'%','d',0}; + LONG width; + + switch(V_VT(p)) { + case VT_BSTR: + return nsAString_Init(nsstr, V_BSTR(p)); + case VT_R8: + width = (LONG)(V_R8(p)); + break; + case VT_R4: + width = (LONG)(V_R4(p)); + break; + case VT_I4: + width = V_I4(p); + break; + default: + FIXME("unsupported arg %s\n", debugstr_variant(p)); + return E_NOTIMPL; + } + sprintfW(buf, formatW, width); + return nsAString_Init(nsstr, buf); +} I would like to see this more generic. How about having var_to_nsstr? It seems to me that we don't really have to convert floats here. Gecko and/or getter may do that instead. If we really have to it here, then some sort of flags controlling helper behaviour on floats may be cleaner. + nsAString val; + HRESULT nsres; nsresult and HRESULT, although are very similar, are two different things and should not be mixed. + DOUBLE width; + + TRACE("(%p)->(%p)\n", This, p); + nsAString_Init(&val, NULL); + nsres = nsIDOMHTMLTableElement_GetWidth(This->nstable, &val); + + V_VT(p) = VT_BSTR; + nsres = return_nsstr(nsres, &val, &V_BSTR(p)); Please don't use return_nsstr this way. It's a strange helper with unusual behaviour in terms of freeing input parameters to make common Gecko wrapping functions cleaner. Using this for string conversion looks bad. Esp in this case, where it adds unneeded BSTR allocation in cases where the string is converted to int later. However, see bellow first. + if (nsres != S_OK) + return nsres; + + nsres = VarR8FromStr(V_BSTR(p), 0, 0, &width); + if (nsres == S_OK){ + VariantClear(p); + V_VT(p) = VT_I4; + V_I4(p) = (LONG)width; + } + return S_OK; +#define cmp_length(a,b) _cmp_length(__LINE__,a,b) +static void _cmp_length(unsigned line, VARIANT got, const char * exstr) +{ + static char buf[64]; + ok_(__FILE__,line) (V_VT(&got)==VT_BSTR || V_VT(&got)==VT_I4, + "V_VT is %hu, expected VT_BSTR(%hu) or VT_I4(%hu)\n", + V_VT(&got), VT_BSTR, VT_I4); + + if (V_VT(&got) == VT_BSTR){ + ok_(__FILE__,line) (!strcmp_wa(V_BSTR(&got), exstr), + "Expected %s, got %s\n", exstr, wine_dbgstr_w(V_BSTR(&got))); + } + else { + sprintf(buf, "%d", V_I4(&got)); + ok_(__FILE__,line) (!strcmp(buf, exstr), + "Expected %s, got %d\n", exstr, V_I4(&got)); + } +} This test should be stricter. You decide on the way to compare based on the value you received. This means that if the implementation always returns VT_BSTR, this will success as well. In fact, my quick testing suggests that native IE always returns string in this case. Also, please consider using more targeted helper so that test would look like: test_table_width(table, "11"); Thanks, Jacek

2 2

Re: [PATCH 3/3] winex11: Remove unused X11DRV_GET_DRAWABLE and struct x11drv_escape_get_drawable.
by Ken Thomases 02 Apr '14

02 Apr '14

On Mar 31, 2014, at 9:47 PM, Ken Thomases wrote: > --- > dlls/winex11.drv/init.c | 8 -------- > dlls/winex11.drv/x11drv.h | 9 --------- > 2 files changed, 17 deletions(-) > > <0003-winex11-Remove-unused-X11DRV_GET_DRAWABLE-and-struct.patch> Was there something wrong with this? Is it anticipated that the GET_DRAWABLE escape will be needed in the future? -Ken

2 2

Re: [PATCH] po: Update Russian translation
by Dmitry Timoshkov 02 Apr '14

02 Apr '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +" [/u] Разрегистрировать сервер.\n" This sounds very unusual, original Windows translation provides a much better wording: "/u - Отменяет регистрацию DLL". > +" [/s] Тихий режим (сообщения не выводятся).\n" Windows translation adds the quotes around "Тихий" in order to emphasize that this has nothing to do with sound. -- Dmitry.

2 4

how to use ced1401 linux driver from wine application ?
by Alois Schlögl 01 Apr '14

01 Apr '14

Hi, I'm trying to connect through wine the CED1401 device which is connected through USB. There is a driver in the linux staging tree, (linux-source-3.10/drivers/staging/ced1401/), which I've already compiled into my kernel. The module loads fine and becomes available when connecting to the device. The are several application software for Windows (e.g. ced1401 [1], Spike [2], Signal5, and we have also one running in Igor Pro). The software runs also on Wine, but fails to identify the connected hardware device. I've tried to find relevant information in the wiki; and especially, http://wiki.winehq.org/USB as well as wine developer guide, Chapter 8 Kernel modules. I've a rough idea what is missing, but would like asking what you think is missing, and how much effort it would take to get this working ? --Alois [1] http://appdb.winehq.org/objectManager.php?sClass=application&iId=15958 [2] http://appdb.winehq.org/objectManager.php?sClass=application&iId=9146

2 4

Re: [PATCH] mshtml: Implemented numeral parsing in get_frame_by_name.
by Austin English 01 Apr '14

01 Apr '14

On Tue, Apr 1, 2014 at 12:45 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hi all, > > When passing a numeral like string as array index to the window object, > native IE correctly parses the string into an integer value while Wine > doesn't. This patch fix the problem. Here is one simply test case: > > Testcase: > 1 <html> > 2 <body> > 3 </body> > 4 <script type="text/javascript"> > 5 var iframeEl = document.createElement('iframe'); > 6 document.body.appendChild(iframeEl); > 7 document.write(window["0"]); //buggy in Wine builtin iexplore > 8 </script> > 9 </html> > > In theory this patch need some more tests, because the above test case is > far from perfect, fortunately we have the open source ECMAScript 3 > Conformance Test Suite ver. 0.2: > http://kangax.github.io/sputniktests-webrunner/ > > Before this patch, Wine builtin iexplore hangs on the first test case of > the ECMAScript 3 Conformance Test Suite, after the patch, the Conformance > Test Suite begin to run. Guess how far does it gone? To everyone's > surprise, now Wine builtin iexplore passes all 5228 tests in the test case: > > Current test: > 15_Native_ECMA_Script_Objects/15.11_Error_Objects/15.11.4_Properties_of_the_Error_Prototype_Object/S15.11.4_A4 > Tests completed: 5228 > Total errors: 0 > Total failures: 0 > Elapsed time: 7:40 > Status: Completed. Final score (errors + failures; less is better): 0 > > > This is definitely a great step of our Wine buitin iexplore, now our > version beats Microsoft IE7 a lot. > > Since now all ECMAScript 3 conformance tests passed, it is safe to assume > that this patch is absolutely correct and no extra test cases needed, so > I'm not going to contribute any C test case for it into our test framework > because it is just duplicate work and waste of time - What can you worry if > even the whole test suite passed? > Hi Qian, The tests are partially there to prove the implementation is correct, yes, but they are also there to prevent regressions. Someone in the future changing dlls/mshtml may not run those same tests and things will break, if there is a unit test in dlls/mshtml/tests, that is not the case. Cheers, Austin

1 0

Re: [2/2] shell32/tests: Mark some test results as broken.
by Marvin 01 Apr '14

01 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6106 Your paranoid android. === w2000pro (32 bit shlexec) === shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 === wxppro (32 bit shlexec) === shlexec.c:1220: Test failed: expected 1 args, got 4 === w8 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\wtE99A.tmp" Exec") WaitForSingleObject returned 258

1 0

Re: [1/2] shell32/tests: Remove todo handling from DDE tests.
by Marvin 01 Apr '14

01 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6105 Your paranoid android. === w2000pro (32 bit shlexec) === shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 === wxppro (32 bit shlexec) === shlexec.c:1211: Test failed: expected 1 args, got 4 shlexec.c:2272: Test failed: argcA expected 5, but got 4 === w8 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1532: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1564: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1532: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1564: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.shlexec.noassoc', but key not found or empty

1 0

Wine GPU decoding
by Michael Müller 01 Apr '14

01 Apr '14

Hi, it is probably still a bit early, but nevertheless I would like to announce a feature I am currently working on and present you the first results. As some of you have already noticed (http://bugs.winehq.org/show_bug.cgi?id=35868) I've recently submitted some simple stub patches to add the dxva2 dll. The original purposes was to get a browser plugin working, which expects that this library is available, and otherwise refuses to run. The library exports some functions which are used by several applications (like VLC, Flash, Silverlight, ...) for GPU decoding. I started to work to on these functions and I want to present you a first result which you can see here: https://dl.dropboxusercontent.com/u/61413222/dxva2.png This is actually the windows version of VLC playing a MPEG2 movie with GPU acceleration using DXVA2. My implementation of dxva2 uses the VAAPI on Linux to do the actual gpu decoding and should support AMD, Intel and NVIDIA cards. Currently only MPEG2 decoding is supported as it is one of the easier codecs and other ones like H264 needs a lot more of buffers, which need be translated from the DXVA format to VAAPI. The second easiest codec to implement would be mpeg4 but as none of my graphic cards support mpeg4, I will most probably continue with VC-1. Anyway, I need to clean up the patches a bit as they add about 3000 new lines of code and test it with some other graphic cards before I can provide them, but there are also some problems, mostly d3d9 related, for which I would like to get your opinion. The most difficult part is that DXVA2 is completely based on Direct3D9Device and Direct3DSurface9. The DXVA2 places the output images into a Surface and the applications locks the surface to get the output data or simply presents it to the screen. Although it would be much more efficient to directly blit the data in the graphic card at least VLC reads it back into system memory as the decoding and output pipeline are separated. The problem is that I actually need to allocate twice the amount of memory for decoding. since I need to provide the Direct3D Surfaces to the application and I also need to provide buffers to VAAPI. This is not a big problem for mpeg2 since it only uses 3 output images as a B Frame can only reference the last and the next frame. Anyway, for H264 this is getting insane as it requires to store up to 16 output images so that i would need to allocate 16 VAAPI buffers and 16 Direct3D surfaces. Currently i lock both kind of buffers after rendering a frame and do the synchronization in system memory, which is kind of inefficient depending on the surface type. My original idea was to do the copy in the graphic card as I can copy the image to a texture after decoding, but after Sebastian implemented this part we found out that the VAAPI implies a format conversion to RGB when copying data to a texture. This is actually a no go since VLC will refuse to use hardware acceleration when the output format is RGB. I also think it is kind of stupid to convert the RGB data back to YUV so that we end up with 3 color coder conversion (YUV->RGB->YUV->RGB). Some Intel developer wrote (see vaCopySurfaceGLX() at http://markmail.org/message/a3sav6q3dm5qvmat) that it would be possible to implement a copy in NV12 format for NVIDIA and Intel but not AMD. We could try to ask them to implement it, so that we can at least do it efficient for these two vendors. Anyway, if other applications continue to copy the data back to system memory it might be better to instead wrap the VAAPI buffers as Direct3D9 surfaces so that we can directly map the VAAPI buffers when LockRect() is called instead of copying the data. Though this would imply problems when the applications tries to pass this interface to Present(). So what do the wined3d guys think? Is it better to convince the Intel developers to allow a copy in YUV format and copy the data directly into the texture of an Direct3D9 surface or wrap the VAAPI buffers as Direct3D9Surface and add some glue code when an applications tries to render it? Or do you have any better ideas? Regards, Michael

4 8

RE: [PATCH] regsvr32: Fix some usage message issues
by Hugh McMaster 01 Apr '14

01 Apr '14

On Tuesday, 1 April 2014 4:34 PM, Nikolay Sivov wrote: > - regsvr32 itself is not a server or service > - it doesn't unregister a module from a server, module IS a server in this context The actual executable in XP and W7 describes itself a "registration server". But I'm happy to go with this change if you believe it is appropriate. There is also the RC define to consider: #define WINE_FILEDESCRIPTION_STR "Wine Register Server" >When used with [/u], regsvr32 also calls DllInstall in uninstall mode.\n > - there's no such thing as 'DLL Uninstall', same DllInstall call is used in both cases This is true; Lauri Kenttä raised that point in this post: http://www.winehq.org/pipermail/wine-devel/2014-March/103671.html In the following discussion, Lauri and Austin English chose to remove the additional reference to 'regsvr32' and 'also'. The preferred option was this text: [/i] Call DllInstall, passing an optional [cmdline]. When used with [/u], calls DllInstall to uninstall the DLL. Of course, your change reflects the original dialog: When used with [/u], regsvr32 also calls DllInstall in uninstall mode. Perhaps you could change it to: When used with [/u], calls DllInstall in uninstall mode. I'm not sure which option would be preferred. Free free to patch using the dialog from the linked thread.

2 2

Re: [1/6] widl: Pass type attributes from write_array_tfs to write_pointer_description. Resend.
by Alexandre Julliard 01 Apr '14

01 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This allows to differentiate strings and write appropriate rpc type > (FC_C_C[W]STRING instead of FC_[W]CHAR). > > This version of the patch limits write_array_tfs() to pass attributes > to write_pointer_description() only for strings and avoids unwanted > changes to other pointer types. > > In order to test changes in the widl generated code under Windows > and make sure that widl generates the correctly working code I had > to compile widl with PSDK tools. This way I was able to test both > 32-bit and 64-bit generated code. All the patches in this sequence > have been tested under Windows as well as under Wine in both 32-bit > and 64-bit builds of the rpcrt4 Wine tests. It's also failing in 32-bit now (with the whole series applied): ../../../tools/runtest -q -P wine -T ../../.. -M ieframe.dll -p ieframe_test.exe.so ie && touch ie.ok ie.c:154: Test failed: FindConnectionPoint failed: 800706ba ie.c:177: Test failed: get_Visible failed: 800706ba ie.c:181: Test failed: put_Visible failed: 800706ba ie.c:185: Test failed: get_Visible failed: 800706ba ie.c:186: Test failed: Visible = 800706ba ie.c:189: Test failed: put_Visible failed: 800706ba ie.c:199: Test failed: Could not get IServiceProvider iface: 80004002 wine: Unhandled page fault on read access to 0x00000000 at address 0x6862ae92 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 01 Apr '14

01 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6100 Your paranoid android. === build (build) === Make failed

1 0

Re: msi: Fix infinite loop.
by Hans Leidekker 01 Apr '14

01 Apr '14

On Mon, 2014-03-31 at 16:48 -0500, Vincent Povirk wrote: > This loop never exits if progid->Parent == progid and there is no > class. There are other checks for that in the file, so I assume that > condition is supposed to be possible. Right, nothing keeps you from defining circular dependencies.

1 0

Re: [PATCH 1/2] ole32: Fix equality check in CommonPrefixWith() for pointer moniker (try2)
by Marvin 01 Apr '14

01 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6093 Your paranoid android. === wvista (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A

1 0

Re: regsvr32: Replace printf calls with WriteConsole function (try 2)
by Lauri Kenttä 01 Apr '14

01 Apr '14

Sorry for being a bit late... Hugh McMaster wrote: > - printf("\t[/i] Call DllInstall passing it an optional > [cmdline];\n"); > - printf("\t when used with /u calls dll uninstall\n"); > +\ [/i] Call DllInstall, passing an optional [cmdline].\n\ > +\tWhen used with [/u], regsvr32 also calls DLL Uninstall.\n\ This whole "calls DLL Uninstall" thing is a bit weird, as there isn't a function named DLL Uninstall or DllUninstall. Maybe you should change it to something more exact like: "When used with [/u], " + 1) "passes [also] the uninstall flag [to DllInstall]" 2) "uses DllInstall to uninstall the DLL" 3) "the bInstall parameter is set to FALSE" 4) "calls DllInstall with bInstall set to FALSE" or something similar. Opinions? If this is too radical, I'd suggest that you at least remove the "also". With my English, it now says that regsvr32 /i /u calls DllInstall and also calls DLL Uninstall, which is clearly neither true nor logical. (It really calls UnregisterDll and DllInstall(FALSE,cmdline).) In addition, repeating "regsvr32" looks strange to me in this kind of context. -- Lauri Kenttä

3 4

Re: [PATCH 6/6] user32: Implement EnumDisplayDevicesW() based on EnumDisplayMonitors() and GetMonitorInfoW().
by Alexandre Julliard 31 Mar '14

31 Mar '14

Ken Thomases <ken(a)codeweavers.com> writes: > For <http://bugs.winehq.org/show_bug.cgi?id=34978>. > --- > dlls/user32/misc.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 84 insertions(+), 12 deletions(-) I think it should be the other way around, with EnumDisplayDevices being the main function, with some sort of centralized management of display devices. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/2] docobj.idl: Added some new OLDCMDID values.
by Dmitry Timoshkov 31 Mar '14

31 Mar '14

Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > include/docobj.idl | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) A typo in the commit message: OLD -> OLE. -- Dmitry.

1 0

Re: apphelp: add a stub for SdbInitDatabase
by Hans Leidekker 31 Mar '14

31 Mar '14

On Sun, 2014-03-30 at 14:36 -0700, Austin English wrote: > +PDB WINAPI SdbInitDatabase(DWORD flags, LPCSTR path) > +{ > + FIXME("stub: %u %s\n", flags, debugstr_a(path)); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return NULL; > +} Return type should be HSDB. Please trace flags in hex.

1 0

Re: mshtml: Added IHTMLTable::bgColor property implementation.
by Nikolay Sivov 30 Mar '14

30 Mar '14

On 3/30/2014 19:18, Zhenbo Li wrote: > + nsAString_Init(&strColor, NULL); > + nsres = nsIDOMHTMLTableElement_GetBgColor(This->nstable, &strColor); > + nsAString_Finish(&strColor); > + > + if(NS_SUCCEEDED(nsres)) { > + nsAString_GetData(&strColor, &color); > + V_VT(p) = VT_BSTR; > + hres = nscolor_to_str(color, &V_BSTR(p)); > + }else { > + ERR("SetBgColor failed: %08x\n", nsres); > + hres = E_FAIL; > + } I think you can't do GetData() after Finish().

1 0

Re: [PATCH] comctl32/tests: Fix a couple of uninitialized variables (Coverity)
by Marvin 30 Mar '14

30 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6070 Your paranoid android. === wvistau64 (32 bit button) === button.c:654: Test failed: BM_SETCHECK on a button: the msg sequence is not complete: expected 0000 - actual 000f

2 1

Re: [PATCH 1/2] ole32: Fix equality check in CommonPrefixWith() for pointer moniker
by Marvin 30 Mar '14

30 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6068 Your paranoid android. === wvista (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A

1 0

Re: [1/2] ntdll/tests: Add tests for RtlUnicodeToUTF8N.
by Nikolay Sivov 29 Mar '14

29 Mar '14

On 3/29/2014 20:16, Thomas Faber wrote: > + /* output truncation */ > +#define truncate_expect(len, out_len, expect_status) do { \ > + bytes_out = 0x55555555; \ > + memset(buffer, 0x55, sizeof(buffer)); \ > + status = pRtlUnicodeToUTF8N( \ > + buffer, len, &bytes_out, \ > + special_string, sizeof(special_string)); \ > + ok(status == (expect_status), "status = 0x%x\n", status); \ > + ok(bytes_out == (out_len), "bytes_out = %u\n", bytes_out); \ > + for (i = 0; i < bytes_out; i++) \ > + ok(buf[i] == special_expected[i], \ > + "buffer[%d] = 0x%x\n", i, buf[i]); \ > + for (; i < sizeof(buffer); i++) \ > + ok(buf[i] == 0x55, "buffer[%d] = 0x%x\n", i, buf[i]); \ > + } while (0) It's better to avoid large macros like this one. A common way to do that is to move code to another function and call it with a single line macro, for line information ok_() should be used.

2 1

How to cross-compile wine?
by Akira Nakagawa 29 Mar '14

29 Mar '14

./configure --host=arm-linux-androideabi then it said --with-wine-tools was needed. What do I set to the option? -- Akira Nakagawa <matyapiro31(a)gmail.com>

1 0

MS releases vintage DOS source code
by Michael Stefaniuc 28 Mar '14

28 Mar '14

Not directly relevant to us as DOS got outsourced to dosbox but here it is nevertheless: http://www.computerhistory.org/atchm/microsoft-ms-dos-2-0-source-code/ If they keep releasing the source roughly 30 years after the OS hit the market, then Windows 3.11 is still 10 years out. bye michael

3 2

Re: [3/3] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Alexandre Julliard 28 Mar '14

28 Mar '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/rpcrt4/tests/server.c | 55 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/rpcrt4/tests/server.idl | 5 ++++ > 2 files changed, 60 insertions(+) It doesn't work on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M rpcrt4.dll -p rpcrt4_test.exe.so server && touch server.ok server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process make[1]: *** [server.ok] Error 12 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/6] winemac: Make ChangeDisplaySettingsEx() operate on the display named by the devname parameter.
by Ken Thomases 28 Mar '14

28 Mar '14

Hi, The first two patches in this series aren't quite right. Please don't commit them. They don't do the right thing with the registry settings. Patches 3 through 6 can be applied independently and are useful, so they can still be committed. (Bug 34978 won't quite be solved because DisplayFusion will be confused by enumerating the wrong modes for the second display.) -Ken

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel