- wine-devel - winehq.org

Re: [2/4] widl: Pass type attributes from write_array_tfs to write_pointer_description.
by Alexandre Julliard 20 Mar '14

20 Mar '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This allows to differentiate strings and write appropriate rpc type > (FC_C_C[W]STRING instead of FC_[W]CHAR). It also changes some pointers from UP to RP, that doesn't look right. -- Alexandre Julliard julliard(a)winehq.org

2 7

wintab32: fixing a typo which prevented sending correct pkSerialNumber
by Eriks Dobelis 20 Mar '14

20 Mar '14

This submission Obsoletes patch id#103302. I split it into parts for easier review and will later submit the rest of patches, but each of them will resolve a single issue and they are not interdependent. Common goal is to resolve http://bugs.winehq.org/show_bug.cgi?id=18517. This patch fixes a typo in a code, which was a cause for wrong pkSerialNumber values to be sent in messages. TRACE entries showed correct values, because TRACE statement was executed before actual sending of the packet. Due to this it took quite a time to spot the problem :) dlls/wintab32/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

2 1

wintab: Incorrectly classifying cursor as stylus instead of eraser
by Eriks Dobelis 20 Mar '14

20 Mar '14

Did not attach the patch in my last email :( For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly detected as stylus. The tablet returns its eraser cursor name as: Wacom Intuos PT S Pen eraser and type as: ERASER Current code classifies this as STYLUS, because name of the cursor contains the word 'Pen'. It is very unlikely that a cursor with type ERASER is STYLUS. With the patch eraser is correctly detected. Without the patch eraser works as stylus. dlls/winex11.drv/wintab.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

wintab: Incorrectly classifying cursor as stylus instead of eraser
by Eriks Dobelis 20 Mar '14

20 Mar '14

For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly detected as stylus. The tablet returns its eraser cursor name as: Wacom Intuos PT S Pen eraser and type as: ERASER Current code classifies this as STYLUS, because name of the cursor contains the word 'Pen'. It is very unlikely that a cursor with type ERASER is STYLUS. With the patch eraser is correctly detected. Without the patch eraser works as stylus. dlls/winex11.drv/wintab.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

Re: [4/4] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 20 Mar '14

20 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5800 Your paranoid android. === build (build) === Make failed

2 1

Re: [PATCH]msvcr110: added missing functions in msvcr110.spec
by Piotr Caban 20 Mar '14

20 Mar '14

On 03/19/14 23:39, Natalino Cordeiro wrote: > +@ stub -arch=arm ?_NewTokenState@_CancellationTokenState@details@Concurrency@@SAPAV123@XZ > @ stub -arch=win32 ?_NewTokenState@_CancellationTokenState@details@Concurrency@@SAPAV123@XZ The ?_NewTokenState@_CancellationTokenState@details@Concurrency@@SAPAV123@XZ function is already exported on arm (there's other entry with the same name and -arch=win32 specifier). > -@ stub -arch=i386,win64 __crtCompareStringEx > +@ stub -arch=arm,i386,win64 __crtCompareStringEx It's not really important but in this case -arch option may be removed. Cheers, Piotr

1 0

Re: gdi32/tests: GetGlyphOutlineA is broken for johab charset on windows.
by Marvin 19 Mar '14

19 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5782 Your paranoid android. === w8 (32 bit font) === font.c:3609: Test failed: W: tmLastChar for Nirmala UI Semilight got a839 expected 262c font.c:3609: Test failed: W: tmLastChar for Nirmala UI got a839 expected 262c

1 0

Re: riched20/tests: Add tests for ITextDocument::Open about dealing with rtf.
by Alexandre Julliard 19 Mar '14

19 Mar '14

Jactry Zeng <jactry92(a)gmail.com> writes: > From 4b124d86198a9ed553a5f6cfd924584769495a1f Mon Sep 17 00:00:00 2001 > From: Jactry Zeng <jactry92(a)gmail.com> > Date: Sat, 15 Mar 2014 00:39:57 +0800 > Subject: riched20/tests: Add tests for ITextDocument::Open about dealing with > rtf. > > --- > dlls/riched20/tests/richole.c | 70 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so richole && touch richole.ok richole.c:445: Test failed: ITextDocument_Open: Should return an ERROR_HANDLE_EOF error. make[1]: *** [richole.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] user32: Improve SetFocus implementation
by Alexandre Julliard 19 Mar '14

19 Mar '14

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/user32/focus.c | 1 + > dlls/user32/tests/win.c | 4 ++++ > 2 files changed, 5 insertions(+) > > > > diff --git a/dlls/user32/focus.c b/dlls/user32/focus.c > index bd2e572..c47a82d 100644 > --- a/dlls/user32/focus.c > +++ b/dlls/user32/focus.c > @@ -277,6 +277,7 @@ HWND WINAPI SetFocus( HWND hwnd ) > HWND parent; > LONG style = GetWindowLongW( hwndTop, GWL_STYLE ); > if (style & (WS_MINIMIZE | WS_DISABLED)) return 0; > + if (!(style & WS_CHILD)) break; It doesn't look right to allow setting focus if a parent is disabled. This would need more tests. Also please write a better description of the change, "improve implementation" is not very helpful. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] user32: Improve SetFocus implementation
by Marvin 19 Mar '14

19 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5775 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0006019E fg 00010048 in hook HCBT_ACTIVATE win.c:6410: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6410: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6410: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6193: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

2 1

Re: [PATCH 2/2] user32: Improve SetForegroundWindow implementation
by Marvin 19 Mar '14

19 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5776 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0156 fg 00010048 in hook HCBT_ACTIVATE win.c:6405: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6405: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6405: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6188: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Ideas about mshtml for GSoC 2014
by Zhenbo Li 19 Mar '14

19 Mar '14

Hello, I'm Zhenbo Li, a student in Shanghai JiaoTong University, China. I have been a Wine user for almost 4 years, and I've been preparing for GSoC for several month. Since 2013, I've translated some wiki pages into Chinese[1], reported nearly 40 bugs[2], involved in Appdb[3], and sent few patches[4]. I'm glad to do more contribution to Wine in 2014. While using Wine, it is common to face a bug in mshtml[5]. Native iexplore may be a workaround, but it can cause other problems, too. So my idea is to implement some functions in mshtml.dll. I have a rough plan now, and I wish to get your advice. As I have about 3 months, I want to implement some functions in IHTMLTable, IHTMLTableCol, etc., and write testcaes for them. I've written some draft patches for IHTMLTableRow, and I'll send them to wine-patches after improving them with your advice. I hope I can establish a proper schedule after communicating with my mentor. I'm also open to any suggestion, and any comment or advice is great appreciated. Thank you. FYI, my first name is Zhenbo, and my last(family) name is Li. So Zhenbo Li and Li Zhenbo means the same person lol. [1]: I contributed to FAQ, RegressionTesting, Bugs, etc. [2]: http://bugs.winehq.org/buglist.cgi?email1=litimetal%40gmail.com&emailreport… [3]: http://appdb.winehq.org/objectManager.php?sClass=maintainerView&iId=281642 [4]: http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Zhenbo+Li [5]: http://bugs.winehq.org/buglist.cgi?cmdtype=runnamed&list_id=141898&namedcmd… -- Have a nice day! Zhenbo Li

3 6

Re: include: Added netcfgx.idl
by Nikolay Sivov 19 Mar '14

19 Mar '14

On 3/19/2014 08:48, Alistair Leslie-Hughes wrote: > + uuid(C0E8AE93-306E-11D1-AACF-00805FC1270E) Please use lower case for uuids.

1 0

GSOC 2014
by Udayan Tandon 19 Mar '14

19 Mar '14

Hi, I’m Udayan Tandon. Im studying computer science in India at the Indraprastha Institute of Information Technology-Delhi. I’ve been studying and coding in C for the past year. Im enthusiastic to take part in GSoC 2014 and the wine project is really interesting. Im interested in the project "CMD:implement more robust parser" and would like if you could the course action as to what to do in this project. Regards Udayan Tandon

2 1

Re: ntoskrnl.exe: Add Stub MmUnlockPagableImageSection
by Dmitry Timoshkov 19 Mar '14

19 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +VOID MmUnlockPagableImageSection(PVOID ImageSectionHandle) > +{ > + FIXME("stub %p\n", ImageSectionHandle); > +} Calling convention specifier is missing. -- Dmitry.

1 0

Re: ntoskrnl.exe: Add Stub KeInsertQueue
by Dmitry Timoshkov 19 Mar '14

19 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +LONG KeInsertQueue(PRKQUEUE Queue, PLIST_ENTRY Entry) > +{ > + FIXME( "stub: %p %p\n", Queue, Entry ); > + return 0; > +} Calling convention specifier is missing. -- Dmitry.

1 0

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications (resend).
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5762 Your paranoid android. === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

GSoC - Winetest Graphical User Interface
by chanchengcc＠gmail.com 18 Mar '14

18 Mar '14

Hi Developers! I am Chan, a Computer Science undergraduate from Zhejiang University, China. I am interested in the project Winetest Graphical User Interface. I've learnt about C/C++/Java programming in school, I've developed an android app (automatically login to the EAS and fetch the info we need) by my own and I've also learnt about OpenGL in class. I believe that I am capable for this project. I heard about the GSoC program yesterday and I realize that it may be a little bit late for application. So I am wondering if there's any chance I can get the opportunity to join the program and work on this project? Thank you a lot for your attention. If there's any question, please feel free to contact me. I'm looking forward to hear from the mentors. Sincerely, Chan 发自 Windows 邮件

2 1

New Idea for GSOC 2014
by Naveen Sangtani 18 Mar '14

18 Mar '14

Hi sir , As you Have mentioned that we can come up with our own idea ; So , i have one such Hope to hear from you Soon. Please find attachment Thanks

1 0

Re: how to build wine with USB support ?
by Hin-Tak Leung 18 Mar '14

18 Mar '14

------------------------------ On Tue, Mar 18, 2014 1:56 PM GMT Alois Schlögl wrote: >On 2014-03-17 17:22, Uwe Bonnes wrote: >>>> "Alois" == Alois Schlögl <alois.schloegl(a)gmail.com> writes: >> >> Alois> In one case, HKLM\System\CurrentControlSet\Services\<driver name> >> Alois> points to system32\Driver\hidusb.sys; >> >> Can you show the exports of hidusb.sys? Maybe it is also a good candidate for >> a replacement dll. >> >> Bye >> > > >I'm not sure how to export that information. nm does not work because >its a sys file. >pefile gives quite some information but no export section. grep Hint >pefile_output lists this: > Does winedump -j export... Not work? >ntoskrnl.exe.ExFreePool Hint[77] >ntoskrnl.exe.ExAllocatePoolWithTag Hint[65] >ntoskrnl.exe.KeSetEvent Hint[598] >ntoskrnl.exe.IofCallDriver Hint[482] >ntoskrnl.exe.KeWaitForSingleObject Hint[621] >ntoskrnl.exe.MmMapLockedPages Hint[687] >ntoskrnl.exe.InterlockedDecrement Hint[278] >ntoskrnl.exe.IoBuildDeviceIoControlRequest Hint[302] >ntoskrnl.exe.InterlockedIncrement Hint[281] >ntoskrnl.exe.KeResetEvent Hint[588] >ntoskrnl.exe.InterlockedExchange Hint[279] >ntoskrnl.exe.IoInvalidateDeviceState Hint[385] >ntoskrnl.exe.IoQueueWorkItem Hint[401] >ntoskrnl.exe.InterlockedCompareExchange Hint[277] >ntoskrnl.exe.IoAllocateWorkItem Hint[294] >ntoskrnl.exe.IoCancelIrp Hint[307] >ntoskrnl.exe.KeTickCount Hint[614] >ntoskrnl.exe.KeBugCheckEx Hint[502] >ntoskrnl.exe.PoCallDriver Hint[822] >ntoskrnl.exe.KeInitializeSpinLock Hint[542] >ntoskrnl.exe.KeInitializeEvent Hint[536] >ntoskrnl.exe.IoFreeWorkItem Hint[355] >ntoskrnl.exe.IofCompleteRequest Hint[483] >HIDCLASS.SYS.HidRegisterMinidriver Hint[3] >USBD.SYS.USBD_ParseConfigurationDescriptorEx Hint[22] >USBD.SYS.USBD_CreateConfigurationRequestEx Hint[6] > > >-- Alois > >

2 1

how to build wine with USB support ?
by Alois Schlögl 18 Mar '14

18 Mar '14

Hi I'm trying to use USB devices for Data acquisition on wine. The recording software is proprietary, but runs on wine. (It IgorPro with some binary called FPulse, and MultiClamp Commander 700B). The problem occurs only when trying to connect to the recording device through USB. I've already found the page [1] and trying to build wine with the recommended patch. Unfortunately, the current patches [2] do not apply cleanly to the most recent version of wine-git. Therefore, I'm asking what the recommended approach is ? Is there a more recent set up patches ? The once from [2] have been updated last in Jun 2012 ? Or would you recommend using the sources of wine from that date ? Kind regards, Alois [1] http://wiki.winehq.org/USB [2] ftp://ftp.etersoft.ru/pub/people/amorozov/usb/current/

3 7

Re: how to build wine with USB support ?
by Hin-Tak Leung 18 Mar '14

18 Mar '14

------------------------------ On Tue, Mar 18, 2014 1:56 PM GMT Alois Schlögl wrote: >On 2014-03-17 17:22, Uwe Bonnes wrote: >> "Alois" == Alois Schlögl <alois.schloegl(a)gmail.com> writes: > > Alois> In one case, HKLM\System\CurrentControlSet\Services\<driver name> > Alois> points to system32\Driver\hidusb.sys; > > Can you show the exports of hidusb.sys? Maybe it is also a good candidate for > a replacement dll. > > Bye > > > >I'm not sure how to export that information. nm does not work because >its a sys file. >pefile gives quite some information but no export section. grep Hint >pefile_output lists this: > >ntoskrnl.exe.ExFreePool Hint[77] >ntoskrnl.exe.ExAllocatePoolWithTag Hint[65] >ntoskrnl.exe.KeSetEvent Hint[598] >ntoskrnl.exe.IofCallDriver Hint[482] >ntoskrnl.exe.KeWaitForSingleObject Hint[621] >ntoskrnl.exe.MmMapLockedPages Hint[687] >ntoskrnl.exe.InterlockedDecrement Hint[278] >ntoskrnl.exe.IoBuildDeviceIoControlRequest Hint[302] >ntoskrnl.exe.InterlockedIncrement Hint[281] >ntoskrnl.exe.KeResetEvent Hint[588] >ntoskrnl.exe.InterlockedExchange Hint[279] >ntoskrnl.exe.IoInvalidateDeviceState Hint[385] >ntoskrnl.exe.IoQueueWorkItem Hint[401] >ntoskrnl.exe.InterlockedCompareExchange Hint[277] >ntoskrnl.exe.IoAllocateWorkItem Hint[294] >ntoskrnl.exe.IoCancelIrp Hint[307] >ntoskrnl.exe.KeTickCount Hint[614] >ntoskrnl.exe.KeBugCheckEx Hint[502] >ntoskrnl.exe.PoCallDriver Hint[822] >ntoskrnl.exe.KeInitializeSpinLock Hint[542] >ntoskrnl.exe.KeInitializeEvent Hint[536] >ntoskrnl.exe.IoFreeWorkItem Hint[355] >ntoskrnl.exe.IofCompleteRequest Hint[483] >HIDCLASS.SYS.HidRegisterMinidriver Hint[3] >USBD.SYS.USBD_ParseConfigurationDescriptorEx Hint[22] >USBD.SYS.USBD_CreateConfigurationRequestEx Hint[6] > > >-- Alois > >

1 0

Re: gdi32/tests: Mark Win8.1 behaviour for johab charset as broken
by Akihiro Sagawa 18 Mar '14

18 Mar '14

On Sat, 15 Mar 2014 00:15:54 +0100, André Hentschel wrote: > - {JOHAB_CHARSET, 0x8446, 0x3135, > + {JOHAB_CHARSET, 0x8446, 0x3135, TRUE /* Win8.1 */, > {TRUE, TRUE, FALSE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, TRUE}}, (snip) > + ok((pGetCharABCWidthsA(hdc, c[i].a, c[i].a + 1, a) && > + pGetCharABCWidthsW(hdc, c[i].w, c[i].w + 1, w) && > + memcmp(a, w, sizeof a) == 0) || broken(c[i].broken), > "GetCharABCWidthsA and GetCharABCWidthsW should return same widths. charset = %u\n", c[i].cs); Regarding this test about Johab charset, you are missing the point. Which version of Windows does succeed in? I suspect that the test is broken. Don't you think? As far as I know, other wine testbots just skip the test due to missing Johab (=130) charset font. Moreover, my Windows 7 with Arial Unicode MS or YOzFont[1] doesn't pass because GetCharABCWidthsA returns 0. But I've not tested on Korean version Windows. If you have further information, please let me know. [1] YOzFont apparently supports Johab charset. It's available from http://yozvox.web.fc2.com/446F776E6C6F6164.html Regards, Akihiro Sagawa

2 2

Re: vbscript: Allow creating RegExp object by new expression.
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5757 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: mshtml: Fixed tests on old IEs and improved results on IE11.
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5749 Your paranoid android. === w8 (32 bit htmldoc) === htmldoc.c:2964: Test failed: unexpected call Exec_ShellDocView_138 htmldoc.c:2964: Test failed: unexpected call Exec_ShellDocView_138 htmldoc.c:5289: Test failed: elem != NULL htmldoc.c:2964: Test failed: unexpected call Exec_ShellDocView_138 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:6012: Test failed: expected Exec_ShellDocView_67 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:6012: Test failed: expected Exec_ShellDocView_67 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:6012: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2989: Test failed: unexpected command 137 htmldoc.c:2989: Test failed: unexpected command 137 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2868: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2868: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2964: Test failed: unexpected call Exec_ShellDocView_138 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2989: Test failed: unexpected command 133 htmldoc.c:3433: Test failed: dwFlags = 140 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:6084: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:985: Test failed: unexpected id 3000032 htmldoc.c:3300: Test failed: unexpected call {f6d02767-9c80-428d-b974-3f1729453fdb} htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2989: Test failed: unexpected command 137 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2989: Test failed: unexpected command 133 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:7807: Test failed: expected Exec_ShellDocView_67 htmldoc.c:7811: Test failed: expected Exec_ShellDocView_84

1 0

Re: [PATCH] scrrun: Implement WriteLine/Write for ITextStream (try2)
by Dmitry Timoshkov 18 Mar '14

18 Mar '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static HRESULT textstream_writestr(struct textstream *stream, BSTR text) > +{ > + DWORD written = 0; > + BOOL ret; > + > + if (stream->unicode) { > + if (stream->first_write) { > + static const short utf16bom = 0xfeff; 'WCHAR' instead of 'short' would look more natural IMO, especially since remaining data is WCHAR based.. -- Dmitry.

2 1

Re: user32/tests: Use BOOL type where appropriate
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5739 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0006019E fg 00010048 in hook HCBT_ACTIVATE win.c:6406: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6428: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6406: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6406: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6406: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6406: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6406: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6428: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6406: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6428: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Take 2.
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5736 Your paranoid android. === w8 (32 bit server) === server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3 server.c:984: Test failed: get_ranged_enum() returned -65533 instead of RE3 server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3

2 1

Re: [PATCH] scrrun: Implement WriteLine/Write for ITextStream
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5734 Your paranoid android. === wvista (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\nT\f8a8\"\186e\7630", expected L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n" === wvistau64 (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n\008d\f8a8'\186e\7550", expected L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n" === w2008s64 (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\scrrun\\test.txt\r\nu\f8a8'\186e\75af", expected L"\feffC:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n" === w7pro64 (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n\008c\f8a8(\625c\761f", expected L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n" === w8 (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n\0129\019c", expected L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n"

1 0

Re: gdi32/tests: GetCharABCWidthsA is broken for johab charset on windows
by Marvin 17 Mar '14

17 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5730 Your paranoid android. === w8 (32 bit font) === font.c:3609: Test failed: W: tmLastChar for Nirmala UI Semilight got a839 expected 262c font.c:3609: Test failed: W: tmLastChar for Nirmala UI got a839 expected 262c font.c:4297: Test failed: 104 100

1 0

FYI Re: wined3d_mutex
by Max TenEyck Woodbury 17 Mar '14

17 Mar '14

I have told you about the long delays I have encountered with Guild Wars 2 under wine. I mentioned that I suspected the wined3d_mutex was the source of the problem. I have just finished a test that shows that it is NOT the source of this problem. Specifically, I dummied the wined3d_mutex_lock and wined3d_mutex_unloc procedures so that they did nothing, That version showed the same pattern of delays that the unaltered system showed. If anybody has an idea about what might be causing these delays, please tell me. Note that my review of the use of this mutex indicates that it is of very questionable value. In my opinion it should be replaced by a set of read/write locks built into the individual data structures. Comments? max

3 6

GSoC 2014: Mentor signups are open
by Austin English 17 Mar '14

17 Mar '14

Howdy, Signups for mentors is open. Please register at: https://www.google-melange.com/gsoc/org2/google/gsoc2014/wine Our ideas page is at http://wiki.winehq.org/SummerOfCode, if you have any ideas for projects. -- -Austin

3 4

Wine test week 1
by Jeremy White 17 Mar '14

17 Mar '14

My current view: http://www.winehq.org/~jwhite/2bb1059ad249.html We have about 32 tests that fail on the new test bots. Some of the failures are timing related; most of them look hard. We've made some solid progress (There is new yellow on our main page. Yay!) I'm going to stop being so chatty; I'll try to work each day to annotate one more test, and then circle back in a few weeks with a summary. Cheers, Jeremy

1 0

Re: dpnet: Forward declare IDirectPlay8Address when you include dpaddr.h (resend)
by Alexandre Julliard 17 Mar '14

17 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > Changelog: > dpnet: Forward declare IDirectPlay8Address when you include dpaddr.h You can't do that: In file included from dxerr9.c:38: ../../include/dplay8.h:30: error: redefinition of typedef 'IDirectPlay8Address' ../../include/dpaddr.h:222: error: previous declaration of 'IDirectPlay8Address' was here make[1]: *** [dxerr9.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: improve GetNumaHighestNodeNumber
by Matteo Bruni 17 Mar '14

17 Mar '14

2014-03-17 11:56 GMT+01:00 Austin English <austinenglish(a)gmail.com>: > Fixes https://bugs.winehq.org/show_bug.cgi?id=35596 > > -- > -Austin > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 60156aa..86055d3 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -3911,9 +3911,9 @@ HRESULT WINAPI RegisterApplicationRecoveryCallback(APPLICATION_RECOVERY_CALLBACK */ > BOOL WINAPI GetNumaHighestNodeNumber(PULONG highestnode) > { > - FIXME("(%p): stub\n", highestnode); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + *highestnode = 0; > + WARN("(%p): semi-stub\n", highestnode); > + return TRUE; Not a big deal I guess but I don't think WARN is appropriate here, it should still be a FIXME IMO.

1 0

Cross-regressions between wine and mesa: how to handle them?
by Ruslan Kabatsayev 17 Mar '14

17 Mar '14

Hi all, I've come across a problem, which may be simplest to see in the following workability diagram, tested on GTAVC on a i915 machine: _____________________________________________ Mesa_\_Wine_|__1.3.21__|__1.5.17__|__1.5.24+_| ____9.0_____|____OK____|____OK____|___slow___| ___~9.1-____|____OK____|___slow___|___slow___| ___~9.1+____|____OK____|_GL_error_|_GL_error_| Here ~9.1- and ~9.1+ are bisected commits between 9.0 and 9.1, with "-" earlier commit and "+" later one. "slow" means slide show instead of normal animation. "GL error" is a set of errors like "err:d3d:device_clear_render_targets >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glClear @ device.c / 677". Wine version 1.5.24+ means any wine newer than 1.5.24 up to 1.7.11. All these things are related to wine trying to use GLSL as much as possible, and Mesa trying to make it seem that it supports OpenGL 2+, even on chips like i915, which don't support it. For end user this looks like failing software, and moreover, it's not easy to understand which software does have bug. Wine perspective: On the one hand, wine seems to use what Mesa exposes. On the other, why use shaders for games which don't need them? Mesa perspective: On the one hand, it wants to advertise more support for latest OpenGL standards. On the other, why do it for very old HW which doesn't support it? So, I'm not sure where I should report these regressions - to bugs.winehq.org or to bugs.freedesktop.org? I remember some similar bugs reported to wine being closed as UPSTREAM (e.g. bug 33964), and fixed (or worked around?) in Mesa. But on the other hand, wine 1.3 worked perfectly for all Mesa versions - is it really Mesa fault that newer versions of wine don't work? Could someone please explain how to handle such situations? Regards, Ruslan

4 13

Re: [PATCH 5/5] wined3d: Remove the version parameter.
by Henri Verbeet 17 Mar '14

17 Mar '14

On 16 March 2014 20:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h > index 7bb37d6..df725e2 100644 > --- a/include/wine/wined3d.h > +++ b/include/wine/wined3d.h > @@ -1221,6 +1221,7 @@ enum wined3d_display_rotation > #define WINED3D_NO3D 0x00000002 > #define WINED3D_VIDMEM_ACCOUNTING 0x00000004 > #define WINED3D_PRESENT_CONVERSION 0x00000008 > +#define WINED3D_ALLOW_3D_DISABLE 0x00000010 > Do we really need this? It's perhaps unfortunate that setting "DirectDrawRenderer" to "gdi" would also prevent 3D in d3d8+, but I'm not sure if avoiding that is really worth an extra flag.

2 2

Re: [PATCH] widl: Fix default value types
by Alexandre Julliard 17 Mar '14

17 Mar '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > http://bugs.winehq.org/show_bug.cgi?id=35778 > > --- > tools/widl/write_msft.c | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) This is causing warning: can't write value of type 29 yet during the build, that's probably not good. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: rpcrt4/tests: Add a couple of tests for marshalling an array of strings.
by Marvin 17 Mar '14

17 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5719 Your paranoid android. === w2000pro (32 bit server) === server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0178#\4d4c\4d45\86b8#\8640#" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0178#\4d4c\4d45\6868#\67c0#" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0198#\4d4c\4d45\7280#\6288#\7280#\0003\0004\0100\000c" server.c:1255: Test failed: expected World!, got L"W" === wxppro (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\01b8$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H$ server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\0178$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H$ server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\0408$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" === wvista (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === wvistau64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hdow\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"Wem3\4d4c\4d45\0008" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hem3\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W;C:\4d4c\4d45\0008" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hdow\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"Wem3\4d4c\4d45\0008" === w2008s64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w7pro64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w8 (32 bit server) === server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:984: Test failed: get_ranged_enum() returned -65533 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === wvistau64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w2008s64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w7pro64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W"

3 2

Re: [PATCH 1/2] ddraw/tests: Add mipmap private data tests (try 2).
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5717 Your paranoid android. === w8 (32 bit ddraw4) === Failure running script in VM: timed out waiting for the child process

1 0

Re: [PATCH 2/2] ddraw/tests: Use a custom GUID for the private data tests.
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5718 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] ddraw/tests: Use a custom GUID for the private data tests.
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5715 Your paranoid android. === wvistau64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w2008s64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w8 (32 bit ddraw4) === No test summary line found Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: [PATCH 3/5] ddraw/tests: Add mipmap private data tests.
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5714 Your paranoid android. === w8 (32 bit ddraw7) === Failure running script in VM: timed out waiting for the child process === wvistau64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w2008s64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w8 (32 bit ddraw4) === ddraw4.c:5731: Test failed: Got unexpected refcount 3. ddraw4.c:5750: Test failed: Got unexpected refcount 3. ddraw4.c:5757: Test failed: Got unexpected hr 0. ddraw4.c:5760: Test failed: Got unexpected refcount 3. ddraw4.c:5762: Test failed: Got unexpected refcount 2. ddraw4.c:5768: Test failed: Got unexpected hr 0. ddraw4.c:5771: Test failed: Got unexpected refcount 2. ddraw4.c:5773: Test failed: Got unexpected refcount 1. ddraw4.c:5775: Test failed: Got unexpected refcount 6.

1 0

Re: [PATCH 2/5] ddraw/tests: Test GetPrivateData size behavior.
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5713 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. ddraw7.c:5765: Test failed: Failed to set cooperative level, hr 0x8876023b. === w8 (32 bit ddraw4) === The test timed out

1 0

Re: cmd: Dont assume cmd.exe is the first argument
by Qian Hong 16 Mar '14

16 Mar '14

Hi Alistair, + args = 0; /* start at first arg, skipping cmd.exe itself */ Could you also consider fixing the comment here? Have a nice weekend :) -- Regards, Qian Hong - http://www.winehq.org

1 0

About GSoC - The Wine Project
by SpedsT . 15 Mar '14

15 Mar '14

Hello. I want to apply to this project and I have a question about this note: * Note: Beginning with Summer of Code 2014, applicants *MUST* have submitted a patch or testcase to wine-patches (see http://wiki.winehq.org/SubmittingPatches) to be considered for acceptance. What kind of patch or testcase should I submit, what would you like to be about?

2 1

Re: gdiplus: Use BOOL type where appropriate
by Vincent Povirk 15 Mar '14

15 Mar '14

On Sat, Mar 15, 2014 at 9:44 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - rotate_90 = type&1; > + rotate_90 = (type & 1) != 0; > flip_x = (type&6) == 2 || (type&6) == 4; > flip_y = (type&3) == 1 || (type&3) == 2; If you must change the style, I prefer (type&1) == 1 here, as it has fewer negatives and matches the lines after it.

1 0

Re: mshtml: Added IHTMLTableRow::rowIndex property implementation.
by Zhenbo Li 15 Mar '14

15 Mar '14

Sorry, I sent the same patch twice due to network problem. Please ignore the second one. Thank you. 2014-03-15 11:23 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > --- > dlls/mshtml/htmltablerow.c | 11 +++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) > > -- Have a nice day! Zhenbo Li

1 0

Re: [PATCH 2/2] wined3d: Re-use old wined3d_private_data structures if the size matches.
by Henri Verbeet 14 Mar '14

14 Mar '14

On 14 March 2014 14:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if ((old = wined3d_private_store_get_private_data(store, guid)) && old->size == data_size) > + { > + IUnknown *release = NULL; > + if (old->flags & WINED3DSPD_IUNKNOWN) > + release = old->content.object; > + memcpy(old->content.data, ptr, data_size); > + old->flags = flags; > + if (flags & WINED3DSPD_IUNKNOWN) > + IUnknown_AddRef(old->content.object); > + if (release) > + IUnknown_Release(release); > + return WINED3D_OK; > + } What is the motivation for this? It certainly doesn't make the code any prettier.

2 1

Re: [3/3] gdiplus: Limit image output to the bounds of the Graphics object.
by Vincent Povirk 14 Mar '14

14 Mar '14

Don't commit this one. I messed up the case where output is fully outside the Graphics object bounds. On Thu, Mar 13, 2014 at 4:49 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: >

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel