- wine-devel - winehq.org

Re: [2/2] ws2_32: Add WSAEnumNameSpaceProviders[A|W] implementation
by Marvin 27 Feb '14

27 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5214 Your paranoid android. === build (build) === Make failed

1 0

Re: [1/2] ws2_32/tests: Add WSAEnumNameSpaceProviders[A|W] tests (try 2)
by Marvin 27 Feb '14

27 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5213 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.
by Ken Thomases 27 Feb '14

27 Feb '14

On Feb 21, 2014, at 6:35 PM, mtewoodbury(a)gmail.com wrote: > Note that this greatly improves network reliability. How did you determine that? How could we confirm that? > - if ( (n = recvmsg(fd, &hdr, wsa->flags)) == -1 ) > + n = recvmsg(fd, &hdr, wsa->flags); > + if (n == -1 && (errno == EINTR || errno == EAGAIN)) > + n = recvmsg(fd, &hdr, wsa->flags); > + if (n == -1) > + > return -1; What's with that blank line between the last "if" and its corresponding statement? > - if (ret >= 0) > - { > + if (ret == -1 && (errno == EINTR || errno == EAGAIN)) > + ret = sendmsg(fd, &hdr, wsa->flags); /* Try it again quickly */ > + if (ret >= 0) { Why did you change the existing lines? You could have just added your two lines. In general: Is this actually the second patch of a two-patch series as indicated by the "[PATCH 2/2]" in the subject? I didn't receive the first patch. Have you tested to see if just retrying on EINTR is sufficient to improve the reliability? EAGAIN is not typically a situation where an immediate retry helps. The callers of WS2_recv() and WS2_send() already have tests for EINTR and EAGAIN. The strategy for dealing with those should probably exist in just one place. For my part, I think that all interruptible syscalls should be in a loop that immediately retries for EINTR, but EAGAIN should usually go back to some select(), poll(), kevent() or similar wait function. -Ken

4 12

Re: ddraw/tests: Probe the supported display modes and skip tests based on the result.
by Marvin 27 Feb '14

27 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5210 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00426DB5 === w8 (32 bit ddraw2) === ddraw2.c:5278: Test failed: Got unexpected refcount 3. ddraw2.c:5297: Test failed: Got unexpected refcount 3. ddraw2.c:5304: Test failed: Got unexpected hr 0. ddraw2.c:5307: Test failed: Got unexpected refcount 3. ddraw2.c:5309: Test failed: Got unexpected refcount 2. ddraw2.c:5315: Test failed: Got unexpected hr 0. ddraw2.c:5318: Test failed: Got unexpected refcount 2. ddraw2.c:5320: Test failed: Got unexpected refcount 1. No test summary line found Failure running script in VM: network read timed out === w8 (32 bit ddraw1) === ddraw1.c:4182: Test failed: Got unexpected refcount 3. ddraw1.c:4201: Test failed: Got unexpected refcount 3. ddraw1.c:4208: Test failed: Got unexpected hr 0. ddraw1.c:4211: Test failed: Got unexpected refcount 3. ddraw1.c:4213: Test failed: Got unexpected refcount 2. ddraw1.c:4219: Test failed: Got unexpected hr 0. ddraw1.c:4222: Test failed: Got unexpected refcount 2. ddraw1.c:4224: Test failed: Got unexpected refcount 1. === w2000pro (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0045C558 === w8 (32 bit ddraw7) === Failure running script in VM: network read timed out === w2000pro (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 00441995 === w8 (32 bit ddraw4) === ddraw4.c:5874: Test failed: Got unexpected refcount 3. ddraw4.c:5893: Test failed: Got unexpected refcount 3. ddraw4.c:5900: Test failed: Got unexpected hr 0. ddraw4.c:5903: Test failed: Got unexpected refcount 3. ddraw4.c:5905: Test failed: Got unexpected refcount 2. ddraw4.c:5911: Test failed: Got unexpected hr 0. ddraw4.c:5914: Test failed: Got unexpected refcount 2. ddraw4.c:5916: Test failed: Got unexpected refcount 1. ddraw4.c:5918: Test failed: Got unexpected refcount 6. Timeout Failure running script in VM: network read timed out

1 0

Re: ddraw/tests: Simplify the 'NT4 testbot' special case a bit.
by Marvin 27 Feb '14

27 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5209 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 004267A5 === w8 (32 bit ddraw2) === Timeout === w8 (32 bit ddraw1) === ddraw1.c:4113: Test failed: Got unexpected refcount 3. ddraw1.c:4132: Test failed: Got unexpected refcount 3. ddraw1.c:4139: Test failed: Got unexpected hr 0. ddraw1.c:4142: Test failed: Got unexpected refcount 3. ddraw1.c:4144: Test failed: Got unexpected refcount 2. ddraw1.c:4150: Test failed: Got unexpected hr 0. ddraw1.c:4153: Test failed: Got unexpected refcount 2. ddraw1.c:4155: Test failed: Got unexpected refcount 1.

1 0

Re: ddraw: Add some more D3DDEVCAPS constants.
by Henri Verbeet 27 Feb '14

27 Feb '14

> --- a/include/d3dcaps.h > +++ b/include/d3dcaps.h > @@ -302,6 +302,11 @@ typedef struct _D3DDeviceDesc7 { > #define D3DDEVCAPS_HWTRANSFORMANDLIGHT 0x00010000 > #define D3DDEVCAPS_CANBLTSYSTONONLOCAL 0x00020000 > #define D3DDEVCAPS_HWRASTERIZATION 0x00080000 > +#define D3DDEVCAPS_PUREDEVICE 0x00100000 > +#define D3DDEVCAPS_QUINTICRTPATCHES 0x00200000 > +#define D3DDEVCAPS_RTPATCHES 0x00400000 > +#define D3DDEVCAPS_RTPATCHHANDLEZERO 0x00800000 > +#define D3DDEVCAPS_NPATCHES 0x01000000 Where did you find these? They're not in any SDK I have.

2 1

Fwd: Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.
by Max TenEyck Woodbury 26 Feb '14

26 Feb '14

-------- Original Message -------- Subject: Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR. Date: Wed, 26 Feb 2014 13:33:22 -0500 From: Max Woodbury <mtewoodbury(a)gmail.com> To: Ken Thomases <ken(a)codeweavers.com> On 02/23/2014 05:23 AM, Ken Thomases wrote: > On Feb 21, 2014, at 6:35 PM, mtewoodbury(a)gmail.com wrote: > >> Note that this greatly improves network reliability. > > How did you determine that? How could we confirm that? Feature of Guild Wars 2 (trading post) that failed to work on wine now works. Lower Game latency. Fewer login failures. > > >> - if ( (n = recvmsg(fd, &hdr, wsa->flags)) == -1 ) >> + n = recvmsg(fd, &hdr, wsa->flags); >> + if (n == -1 && (errno == EINTR || errno == EAGAIN)) >> + n = recvmsg(fd, &hdr, wsa->flags); >> + if (n == -1) >> + >> return -1; > > What's with that blank line between the last "if" and its corresponding statement? To emphasize the exit from the function. I find that I often want to know where such exits are and this makes them easier to fined. Personal preference... > >> - if (ret >= 0) >> - { >> + if (ret == -1 && (errno == EINTR || errno == EAGAIN)) >> + ret = sendmsg(fd, &hdr, wsa->flags); /* Try it again quickly */ >> + if (ret >= 0) { > > Why did you change the existing lines? You could have just added your two lines. Mostly just personal preference... > > In general: > > Is this actually the second patch of a two-patch series as indicated by the "[PATCH 2/2]" > in the subject? I didn't receive the first patch. No, my dyslexia strikes again. > > Have you tested to see if just retrying on EINTR is sufficient to improve the > reliability? EAGAIN is not typically a situation where an immediate retry helps. EAGAIN says specifically resources _temporarily_ unavailable. How temporary is not specified, so one quick retry could fix the problem. > > The callers of WS2_recv() and WS2_send() already have tests for EINTR and EAGAIN. > The strategy for dealing with those should probably exist in just one place. > For my part, I think that all interruptible syscalls should be in a loop that > immediately retries for EINTR, but EAGAIN should usually go back to some select(), > poll(), kevent() or similar wait function. I'd more or less agree except that there is, if I recall correctly, some other stuff that has to happen before the retry at the higher levels and I was getting game feature failures and latency waiting for those fixes. By all means, something like this could and should be done for most system calls. This one just annoyed me enough to try fiddling with it. Since it seemed to make a difference, I posted it... > > -Ken

1 0

Re: ddraw/tests: Fix some comma versus semi-colon mixups.
by Marvin 26 Feb '14

26 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5200 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00426825 === w8 (32 bit ddraw2) === ddraw2.c:5212: Test failed: Got unexpected refcount 3. ddraw2.c:5231: Test failed: Got unexpected refcount 3. ddraw2.c:5238: Test failed: Got unexpected hr 0. ddraw2.c:5241: Test failed: Got unexpected refcount 3. ddraw2.c:5243: Test failed: Got unexpected refcount 2. ddraw2.c:5249: Test failed: Got unexpected hr 0. ddraw2.c:5252: Test failed: Got unexpected refcount 2. ddraw2.c:5254: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:4115: Test failed: Got unexpected refcount 3. ddraw1.c:4134: Test failed: Got unexpected refcount 3. ddraw1.c:4141: Test failed: Got unexpected hr 0. ddraw1.c:4144: Test failed: Got unexpected refcount 3. ddraw1.c:4146: Test failed: Got unexpected refcount 2. ddraw1.c:4152: Test failed: Got unexpected hr 0. ddraw1.c:4155: Test failed: Got unexpected refcount 2. ddraw1.c:4157: Test failed: Got unexpected refcount 1. === w2000pro (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0045BF78 === w2000pro (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 00440B85 === w8 (32 bit ddraw4) === ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4244: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. No test summary line found Failure running script in VM: network read timed out

1 0

Re: [PATCH] winegcc: Don't set stdcall and fastcall attributes on ARM.
by Alexandre Julliard 26 Feb '14

26 Feb '14

Grazvydas Ignotas <notasas(a)gmail.com> writes: > Otherwise we get lots of "attribute directive ignored" warnings. > Wine headers can take care defining __stdcall to nothing on ARM. If we wanted to rely on the headers we wouldn't need any of this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d9/tests: Fix some test failures on Windows 2000.
by Bruno Jesus 26 Feb '14

26 Feb '14

On Mon, Feb 24, 2014 at 7:54 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > This fixes some tests on the WineTestBot VM. > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) I was not aware that we are adding broken for Windows 2000. Otherwise I would not have sent http://source.winehq.org/git/wine.git/commitdiff/de0c46fd52b9f9f4ebfff256c7… I thought broken was for <= NT only. Bruno

2 1

Re: user32: Check WS_CHILD style in IsChild function (try3)
by Marvin 26 Feb '14

26 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5184 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0003007A fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030150 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040024 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000501BA fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000300F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040140 fg 00010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040190 fg 00010048 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000501BA fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000300F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040140 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: Check WS_CHILD style in IsChild function (try2)
by Marvin 26 Feb '14

26 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5182 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0003007A fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030150 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040024 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000501BA fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000300F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040190 fg 00010048 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000501BA fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000300F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040140 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Patch to fix bug 34324
by Zhenbo Li 26 Feb '14

26 Feb '14

Hello, I've been working on http://bugs.winehq.org/show_bug.cgi?id=34324. Till now, I have found two solutions, one is simple and one is complex. Both of them would fix #34324, and I don't know which one is better. As Alexandre Julliard mentioned[1], I would use the value of GetLastError() as the return (error) value in delete_files(). The simple patch would fix part of the 'todo_wine' marks. Meanwhile, the complex patch would fix *all* todo marks about return value in test_delete(). I really appreciate your help (especially for Dmitry Timoshkov, thank you very much). And I'm looking for your feedbacks. Thank you. [1]: http://markmail.org/message/fblet7gadeusyauv#query:+page:1+mid:6eu2a72uuchh… -- Have a nice day! Zhenbo Li

2 5

Re: usp10: Use BOOL type where appropriate
by Nikolay Sivov 26 Feb '14

26 Feb '14

On 2/26/2014 11:12, Frédéric Delanoy wrote: > cf. http://msdn.microsoft.com/en-us/library/windows/desktop/dd374096%28v=vs.85%… > --- > dlls/usp10/opentype.c | 32 ++++++++++++++++---------------- > dlls/usp10/shape.c | 36 ++++++++++++++++++------------------ > dlls/usp10/usp10.c | 26 +++++++++++++------------- > 3 files changed, 47 insertions(+), 47 deletions(-) > > diff --git a/dlls/usp10/opentype.c b/dlls/usp10/opentype.c > index 166d823..5b3bdc7 100644 > --- a/dlls/usp10/opentype.c > +++ b/dlls/usp10/opentype.c > @@ -645,34 +645,34 @@ void OpenType_GDEF_UpdateGlyphProps(ScriptCache *psc, const WORD *pwGlyphs, cons > { > case 0: > case BaseGlyph: > - pGlyphProp[i].sva.fClusterStart = 1; > - pGlyphProp[i].sva.fDiacritic = 0; > - pGlyphProp[i].sva.fZeroWidth = 0; > + pGlyphProp[i].sva.fClusterStart = TRUE; > + pGlyphProp[i].sva.fDiacritic = FALSE; > + pGlyphProp[i].sva.fZeroWidth = FALSE; > break; I think it's a wrong change.Even if msdn says you can use TRUE/FALSE here, field is not defined as of 'BOOL' type.

3 5

Re: [PATCH] oleaut32: Implement DISPID_PICT_RENDER dispid
by Alistair Leslie-Hughes 26 Feb '14

26 Feb '14

On 26/02/2014 8:05 PM, Nikolay Sivov wrote: > --- > dlls/oleaut32/olepicture.c | 51 ++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 47 insertions(+), 4 deletions(-) > I submitted a similar patch http://www.winehq.org/pipermail/wine-patches/2011-December/109566.html It was rejected because it lacked tests. Best Regards Alistair Leslie-Hughes

2 1

Re: usp10/tests: Use BOOL type where appropriate
by Marvin 26 Feb '14

26 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5166 Your paranoid android. === w8 (32 bit usp10) === usp10.c:497: Test failed: 0:Wrong fRTL(0) usp10.c:497: Test failed: 0:Wrong fLayoutRTL(0) usp10.c:497: Test failed: 0:Wrong BidiLevel(0) usp10.c:498: Test failed: 1:Wrong fRTL(0) usp10.c:498: Test failed: 1:Wrong fLayoutRTL(0) usp10.c:498: Test failed: 1:Wrong BidiLevel(0)

1 0

Getting Introduced with the Community and Looking forward to Contribute to the Project as part of Gsoc 2014
by Gaurav Bansal 26 Feb '14

26 Feb '14

Hi, Firstly I, Gaurav would like to introduce myself to the developers of this commmunity. I am a sophomore from Birla Institute of Science and Technology Pilani, India currently pursuing Bachelors in Computer Science and Engineering. My skills include Programming languages: GNU C/C++, Python, Java,PHP/MySQL Version control systems and Git/Github. I am also aware with many of the web development application tools and content management systems. I am an ambitous person willing to learn other technologies when need in future. I choose this organisation for the contribution as the work the community does looks very appealing and interesting to me and useful for the whole community. The skills used by the organisation for the development of open source software matches with my skills to much extent. I had installed the required necessary tools and setup the environment in my system needed for the contribution to open source software. I had got myself aware of the source to some extent. I had also read the contribution, development tutorial on the community webpage. I would like to seek the mentors help in the selection of the project for which the idea has been proposed for the Gsoc and someone is willing to mentor the project idea. I will highly appreciate with any kind of help, guidance from the mentors to help me move forward to contribute to the software starting off with some easy tasks and then moving levels higher so as to make a strong proposal for the upcoming Google Summer of Code 2014. [1] Github : https://github.com/gauravb7090 [2] IRC : gauravb7090 *--Gaurav*

1 0

Re: user32: Check WS_CHILD style in IsChild function
by Marvin 25 Feb '14

25 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5155 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00050094 fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005013E fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0132 fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005018C fg 00010048 in hook HCBT_ACTIVATE win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6180: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000C0132 fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

2 1

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure.
by Henri Verbeet 25 Feb '14

25 Feb '14

On 24 February 2014 15:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1976,6 +1976,19 @@ static inline void context_invalidate_active_texture(struct wined3d_context *con > context_invalidate_state(context, STATE_SAMPLER(sampler)); > } > > +struct wined3d_privstore > +{ > + struct list content; > +}; > + > +struct wined3d_privstore *wined3d_privstore_create(void) DECLSPEC_HIDDEN; > +void wined3d_privstore_destroy(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_free_private_data(struct wined3d_privstore *store, const GUID *guid); > +HRESULT wined3d_privstore_get_private_data(const struct wined3d_privstore *store, > + const GUID *guid, void *data, DWORD *data_size, BOOL addref) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_set_private_data(struct wined3d_privstore *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) DECLSPEC_HIDDEN; > + > #define WINED3D_RESOURCE_ACCESS_GPU 0x1 > #define WINED3D_RESOURCE_ACCESS_CPU 0x2 > I'm not entirely convinced this is how we want this to work. Calling HeapAlloc() for a struct list seems less than ideal, and I'd like the WINED3DSPD_IUNKNOWN handling to be done by the callers.

2 1

Re: [2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode (try 3)
by Bruno Jesus 25 Feb '14

25 Feb '14

Please rebase and resend your patches. On Fri, Jan 24, 2014 at 5:46 PM, Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > Load registry functions dynamically, test caused an error message box to pop > up on Windows XP instead of skipping the test, causing a timout error. > > Test now queries registry values to compare them with the function's result. > > --- > configure | 1 + > configure.ac | 1 + > dlls/bcrypt/tests/Makefile.in | 4 ++ > dlls/bcrypt/tests/bcrypt.c | 107 > ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 113 insertions(+) > > >

1 0

Re: Raise the minimum version of FreeBSD to 8.0. (PING)
by Lauri Kenttä 25 Feb '14

25 Feb '14

On 2014-02-24 00:15, Gerald Pfeifer wrote: > Any problem why this patch was not included yet? At least you have not changed all 7.0's to 8.0's, for example README.sv: "FreeBSD-versioner äldre än 7.0." -- Lauri Kenttä

1 0

Re: winmm/tests: Change the current directory to a place that will be writable.
by Marvin 25 Feb '14

25 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5140 Your paranoid android. === w8 (32 bit mci) === mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

2 1

Re: Assorted typos fixes (try 2)
by Nikolay Sivov 25 Feb '14

25 Feb '14

On 2/25/2014 13:53, Andrey Gusev wrote: > --- a/dlls/dssenh/tests/dssenh.c > +++ b/dlls/dssenh/tests/dssenh.c > @@ -405,7 +405,7 @@ struct hash_test { > }; > > static const char testHashVal1[] = "I love working with Wine"; > -static const char testHashVal2[] = "Wine is not an emulater."; > +static const char testHashVal2[] = "Wine is not an emulator."; > static const char testHashVal3[] = ""; > This breaks now. Don't forget to do a 'make test' after making changes to test data.

1 0

Suggested RFP: LinuxFest Northwest
by Jeremy White 25 Feb '14

25 Feb '14

As part of our new initiative, we're trying to encourage people to submit RFPs to give Wine talks. The Wine project can potentially help defray travel costs, although the ideal is to encourage folks that don't have to travel far. So here's one: http://linuxfestnorthwest.org/present LinuxFest Northwest. About 1500 Linux geeks. I'm told by an organizer that a Wine talk would be welcome. Anyone on the US West coast up for giving a talk? Cheers, Jeremy

3 2

Re: Assorted typos fixes (try 2)
by Marvin 25 Feb '14

25 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5149 Your paranoid android. === w2000pro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wxppro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvista (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w8 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output.

1 0

Re: msi: Add tests for [un]registering progids.
by Marvin 24 Feb '14

24 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5134 Your paranoid android. === w2000pro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605 === wxppro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605

1 0

Re: [PATCH 2/5] wined3d: Make use of WGL_WINE_make_current extension to restore the previous GL context without reference to its DC.
by Henri Verbeet 24 Feb '14

24 Feb '14

On 23 February 2014 23:58, Ken Thomases <ken(a)codeweavers.com> wrote: > + if (gl_info->supported[WGL_WINE_MAKE_CURRENT] && > + !(gl_info->p_wglMakeContextCurrentWINE = (void *)wglGetProcAddress("wglMakeContextCurrentWINE"))) > + gl_info->supported[WGL_WINE_MAKE_CURRENT] = FALSE; Why can't load_gl_funcs() take care of this? > {"WGL_WINE_pixel_format_passthrough", WGL_WINE_PIXEL_FORMAT_PASSTHROUGH}, > + {"WGL_WINE_make_current", WGL_WINE_MAKE_CURRENT}, ... > WGL_WINE_PIXEL_FORMAT_PASSTHROUGH, > + WGL_WINE_MAKE_CURRENT, With the (obvious) exceptions of WINED3D_GL_EXT_NONE and WINED3D_GL_EXT_COUNT, the wined3d_gl_extension enum is supposed to be in lexicographical order.

2 2

Re: urlmon: Fixed some tests on IE11.
by Marvin 24 Feb '14

24 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5116 Your paranoid android. === w8 (32 bit protocol) === protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20

1 0

Re: [PATCH 3/4] wmp: Added SetObjectRects implementation.
by Marvin 24 Feb '14

24 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5115 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: [PATCH 2/4] wmp: Added DoVerb(OLEIVERB_HIDE) implementation.
by Marvin 24 Feb '14

24 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5114 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: [PATCH 1/4] wmp: Return success in IPersistStreamInit::InitNew.
by Marvin 24 Feb '14

24 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5113 Your paranoid android. === w2000pro (32 bit oleobj) === oleobj.c:881: Test failed: InitNew failed: 00000000

1 0

Re: ntdll: use case-insensitive matching for typelib flags
by Nikolay Sivov 24 Feb '14

24 Feb '14

On 2/22/2014 03:06, Austin English wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=35636 > > -- > -Austin Add a test please.

2 2

Re: Assorted typos fixes
by Dmitry Timoshkov 23 Feb '14

23 Feb '14

Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c > index c4e61cc..1f94516 100644 > --- a/dlls/gdiplus/tests/image.c > +++ b/dlls/gdiplus/tests/image.c > @@ -3251,7 +3251,7 @@ static void test_GdipGetAllPropertyItems(void) > { PropertyTagTypeShort, 0x102, 6, { 8,0,8,0,8,0 } }, > { PropertyTagTypeShort, 0x103, 2, { 1 } }, > { PropertyTagTypeShort, 0x106, 2, { 2,0 } }, > - { PropertyTagTypeASCII, 0x10d, 27, "/home/meh/Desktop/test.tif" }, > + { PropertyTagTypeASCII, 0x10d, 27, "/home/meh/Desktop/test.tiff" }, > { PropertyTagTypeLong, 0x111, 4, { 8,0,0,0 } }, This change is obviously wrong. > diff --git a/dlls/ieframe/dochost.c b/dlls/ieframe/dochost.c > index 8c5d4b5..78b3f9e 100644 > --- a/dlls/ieframe/dochost.c > +++ b/dlls/ieframe/dochost.c > @@ -846,7 +846,7 @@ static HRESULT WINAPI DocHostUIHandler_ResizeBorder(IDocHostUIHandler2 *iface, > LPCRECT prcBorder, IOleInPlaceUIWindow *pUIWindow, BOOL fRameWindow) > { > DocHost *This = impl_from_IDocHostUIHandler2(iface); > - FIXME("(%p)->(%p %p %X)\n", This, prcBorder, pUIWindow, fRameWindow); > + FIXME("(%p)->(%p %p %x)\n", This, prcBorder, pUIWindow, fRameWindow); > return E_NOTIMPL; > } What's the reason for this one? -- Dmitry.

1 0

Re: Assorted typos fixes
by Marvin 23 Feb '14

23 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5100 Your paranoid android. === wxppro (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === wvista (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === wvistau64 (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w2008s64 (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w7pro64 (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w8 (32 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === wvistau64 (64 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w2008s64 (64 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch === w7pro64 (64 bit image) === image.c:3327: Test failed: 6: data mismatch image.c:3389: Test failed: 6: data mismatch

1 0

Re: Assorted typos fixes
by Marvin 23 Feb '14

23 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5099 Your paranoid android. === w2000pro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wxppro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvista (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w8 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output.

1 0

Re: resend: Windows sets CCS_VERT when TBSTYLE_EX_VERTICAL is set
by Marvin 23 Feb '14

23 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5097 Your paranoid android. === build (build) === Make failed

1 0

ff-core effect id handling in case of a failed effect upload
by Elias Vanderstuyft 23 Feb '14

23 Feb '14

Hi, In the process of reviewing the Wine DInput translation layer, I noticed an inconvenience (in the ff-core implementation?) that can possibly lead to confusing problems to application developers (not only for Wine), in short: If a new (id==-1) effect was uploaded (look at ff-core.c::input_ff_upload(...)) that failed (e.g. returning EINVAL), ff-core will have assigned a positive number to the effect id. This can be confusing because the dev->ff->effects[] array will not contain an element at the index of that new effect id. Here is a more elaborated description/discussion: - This is a bug that is either the responsibility of the Linux kernel, or of Wine (and possibly other applications that do the same thing as described below): It is caused by the following situation: When uploading an effect, the specific kernel device driver may return an error, e.g. EINVAL for example when a periodic's effect period is set to zero. This error will then be returned by "ioctl(*(This->fd), EVIOCSFF, &This->effect)". With or without error, one can find out that /drivers/input/ff-core.c:input_ff_upload(...) is called, which will set effect->id >= 0, if it was set to -1 (=> new effect created) by the user. But in case of an error: - Assume effect->id was set to -1 by the user: The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will also be set >= 0 (*). The offending effect will not be saved in the ff->effects[] array (***). - Assume effect->id was set >= 0 by the user (and ff->effects[effect->id] is a valid existing effect): The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will remain unchanged (**). The offending effect will not overwrite the ff->effects[effect->id] element (****). Is this (see *, **, *** and ****) desired behaviour? - If yes: Change the following in Wine's dinput/effect_linuxinput.c:90 : if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { to : int effectId_old = This->effect.id; if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { This->effect.id = effectId_old; - If no for *: Kernel code /drivers/input/ff-core.c:input_ff_upload(...) has to be patched to revert "effect->id" back to its original value set by the user, which is only needed when the initial (by user) value of "effect->id" was equal to -1. - If no for **** (or maybe also ***): ff->effects[effect->id] could be replaced by an 'empty' effect (however this can get complex because the effect's type has to remain unchanged) This would be a change in the kernel code /drivers/input/ff-core.c:input_ff_upload(...). - If no for **: I don't really know. Discussion is needed. - In my opinion, **, *** and **** are desired behaviour, while * should leave the effect->id at -1. In that case, Wine's dinput implementation does not have to be patched, and the kernel code only should apply a minor patch. Best regards, Elias

4 8

Re: oleaut32: Use BOOL type where appropriate
by Nikolay Sivov 22 Feb '14

22 Feb '14

On 2/22/2014 15:22, Frédéric Delanoy wrote: > --- > dlls/oleaut32/varformat.c | 8 ++++---- > dlls/oleaut32/vartype.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dlls/oleaut32/varformat.c b/dlls/oleaut32/varformat.c > index e72a170..a6a10cf 100644 > --- a/dlls/oleaut32/varformat.c > +++ b/dlls/oleaut32/varformat.c > @@ -2303,9 +2303,9 @@ HRESULT WINAPI VarFormatNumber(LPVARIANT pVarIn, INT nDigits, INT nLeading, INT > if (nLeading == -2) > GETLOCALENUMBER(LOCALE_ILZERO, LeadingZero); > else if (nLeading == -1) > - numfmt.LeadingZero = 1; > + numfmt.LeadingZero = TRUE; > else > - numfmt.LeadingZero = 0; > + numfmt.LeadingZero = FALSE; > > if (nGrouping == -2) > { > @@ -2484,9 +2484,9 @@ HRESULT WINAPI VarFormatCurrency(LPVARIANT pVarIn, INT nDigits, INT nLeading, > if (nLeading == -2) > GETLOCALENUMBER(LOCALE_ILZERO, LeadingZero); > else if (nLeading == -1) > - numfmt.LeadingZero = 1; > + numfmt.LeadingZero = TRUE; > else > - numfmt.LeadingZero = 0; > + numfmt.LeadingZero = FALSE; > That's not a case when it's appropriate - 'LeadingZero' is UINT, not BOOL. Somewhat improved variant of above conditions could look like that: --- else numfmt.LeadingZero = nLeading == -1; ---

3 3

Fixing up the code style
by Stefan Dösinger 22 Feb '14

22 Feb '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, After recently helping two contributors (the Pipelight guys and Martin Storsjö) through the maze of the Wine code style I think it's best to lift the ban against style-only patches and unify the code style once and for all. The basic reasoning is that from my point of view the lack of clarity wrt the code style and lack of automatic enforceability is causing more issues than the problems style-only patches cause with git blame. Finding a style-only change with git blame can be handled by running git blame again. Frustrating contributors on the other hand has no workaround. So I propose to agree on a code style for the entire project, fixing it up preferably with an automated tool and in the future enforcing the style with checks in the Testbot. Opinions? Wrt the code style I propose the style that is used in wineserver. It is the same one as the new style in the d3d code except for single-line if conditions. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIbBAEBAgAGBQJS/MQGAAoJEN0/YqbEcdMw7rMP+LAP5pnxyy9onITtJVe8swuy pKrS+U1NgLIru9yGuuxUsejUr8gY9hD27nSQQ2OddzSV3pEkY6vmqftSIFVT8Oli d0kEXbxZhlzRe9rCgEJGLGx73ap/LBOm0k3jtslOVONlIyH8AXdEG37a2P7s8SKV D9p0Sw7ggNRF8D0eIszSPKjfUfBYph+9XU1SDA9aEfokv6rs6AFt9xehCOUsdayZ gwqiigg70tkez81GhDRfuXWVn6pdsVpeLDjxF4P2XFMT00OInJIYBIy2w91sxgOs 3vos4X60+qg+sIGxAhxgfLilVQSbBOqvBz9QEUycOduzJK87sVfGtpsipCX4qW1Z QNE+SOINHjazNPB0mydO7s6rThOuZS2BU5nG+ZaXmbe5RBUXLMqqjUmIGL2ZYodJ zQ+3eOHC0H8fxaNhqwpRh5Gq8fVE+xcXauovLv0Ro+FskOitfazIBJEfktjJuXZ8 YZcmLqQAGCwd0Y9pTOTXldoR9ah1+gO7ya5n2ljR0+viAol6KQoUaD4dFNhEur4j cpmW2EDks/wPVrvjX2u8cphHGeOLSjDEErnE/PoX5w7jNarekRWSSalanYB+04SX rjxUXSVq30upNdJ07W2L8gLaHTgHq0rglR1ZrSYEDw5FtaG/Xs4W0YqyX5APl/+O Bj4qRaV70TNOicRNgaA= =DQdS -----END PGP SIGNATURE-----

9 12

Re: Windows sets CCS_VERT when TB_GETEXTENDEDSTYLE is set
by Marvin 22 Feb '14

22 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5092 Your paranoid android. === build (build) === Make failed

1 0

Re: ws2_32/tests: Add W2K error values as valid
by Marvin 22 Feb '14

22 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5087 Your paranoid android. === w2000pro (32 bit sock) === sock.c:613: Test failed: oob_server (444): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at C0000241 === wxppro (32 bit sock) === sock.c:613: Test failed: oob_server (b28): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 7C9010E6 === wvistau64 (32 bit sock) === sock.c:613: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:613: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit sock) === sock.c:613: Test failed: oob_server (63c): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:613: Test failed: oob_server (750): unexpectedly at the OOB mark: 0

1 0

Re: Help about implementing WSACleanup (ws2_32)
by Bruno Jesus 22 Feb '14

22 Feb '14

The attached patch implements a socket queue in the DLL side and implements WSACleanup. For now the socket list does not have any parameter but my target is to add more stuff to it and reduce the server calls. Any comments are appreciated. Best wishes, Bruno On Sun, Dec 29, 2013 at 4:21 PM, David Quintana (gigaherz) <gigaherz(a)gmail.com> wrote: > I have no knowledge about windows sockets, but DLLs are not shared across > processes. If a DLL wants shared memory it has to map it explicitly, like > everything else. On the other hand threads do share all memory, and windows > provides thread-local storage to allow thread-specific variables. > > On 29 Dec 2013 19:15, "Bruno Jesus" <00cpxxx(a)gmail.com> wrote: >> >> Hi, in an attempt to fix bugs 18670 and 26031 I would like to try >> implementing WSACleanup more properly. My limited knowledge in the >> interactions between the ws2_32 dll and wine server makes me think >> this is easy. >> >> The idea is to add the created socket in WSASocketW in a list and >> remove it from the list when closesocket is called. When the last >> WSACleanup is called it would iterate through the socket list and >> destroy the remaining sockets. >> >> When WSASocketW is called it calls the server to create the socket, >> when closesocket is called the server is also called and the function >> sock_destroy takes care of shutting down the socket. >> >> Currently I'm thinking about doing this in the dll side because the >> server is not aware of WSACleanup, but maybe it should because it >> needs to avoid calling any async operation completion. >> >> My questions are: >> 1) When I open 2 programs that use ws2_32 dll the global variables >> memory is not shared, right? Otherwise the WSAStartup/Cleanup count >> could be messed up if one application didn't call the Cleanup >> function. I hope this true so the socket list would not have to take >> care of different processes id. >> >> I understand that one application can have multiple threads and that's >> what the struct per_thread_data is about, but I hope the dll is not >> shared among different processes. >> >> 2) Is this a reasonable approach? If yes, is there any example of a >> critical protected list (add, iterate, remove items) that I could use? >> >> Best wishes, >> Bruno >> >> > -- universe* god::bigbang (void); //and then it all began...

2 4

Why using WINE not ReactOS-programs?
by theUser BL 21 Feb '14

21 Feb '14

What stands on the WINE main-side for one of the new features of WINE 1.7.13? »More Windows Media Player stubs.« So you do not only reimplementing the platform. You also reimplement the MediaPlayer, the InternetExplorer, Wordpad, etc. A month ago, I already asked in the forum, why you don't take ReactOS programs for WINE: http://forum.winehq.org/viewtopic.php?f=8&t=20836 There are programs under the GPL. But some are under the LGPL. For example mspaint: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mspaint/ It can be possible, that there are programs for Windows, which makes use of mspaint and wants to start it, because it exists since Windows 95. So any Windows-developer can assume, that mspaint exists on the system. Same with some other programs. Greatings theuserbl

2 1

[idea]wine support for Chrome OS
by 中川祥 21 Feb '14

21 Feb '14

Now,we don't run wine in Chrome OS. Google also think they can run windows executable files. My idea is about how to use wine in the OS. Google Chrome has two types of extensions:one is the extension,that support only web technology.the other is PPAPI,Google Native Client. Here's the overview↓ https://developers.google.com/native-client/dev/overview For example,Flash Player uses PPAPI. C/C++ programs can be transformed and run in its sandbox. then we can run wine in Chrome OS. I think if wine supports Chrome OS,Google helps us.

3 5

Re: user32/tests: Add some SetDlgItemTextA tests
by Alexandre Julliard 21 Feb '14

21 Feb '14

Bruno Jesus <00cpxxx(a)gmail.com> writes: > This patch was an attempt to reproduce the issue in bug 35621, I could > not get what I wanted but at least here I got the following error > covered in a todo: > > dialog.c:1022: Test failed: GetDlgItemText error, expected 102400, got > 80968. > dialog.c:1023: Test failed: Different text read. Works fine here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so dialog && touch dialog.ok dialog.c:1022: Test succeeded inside todo block: GetDlgItemText error, expected 102400, got 102400. dialog.c:1023: Test succeeded inside todo block: Different text read. make: *** [dialog.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: secur32: return success on graceful close of SSL connection
by Ken Thomases 20 Feb '14

20 Feb '14

On Feb 20, 2014, at 3:41 PM, Aric Stewart wrote: > --- > dlls/secur32/schannel_macosx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/secur32/schannel_macosx.c b/dlls/secur32/schannel_macosx.c > index 5d88223..1d1df26 100644 > --- a/dlls/secur32/schannel_macosx.c > +++ b/dlls/secur32/schannel_macosx.c > @@ -989,6 +989,8 @@ SECURITY_STATUS schan_imp_recv(schan_imp_session session, void *buffer, > else > TRACE("Read %lu bytes before would block\n", *length); > } > + else if (status == errSSLClosedGraceful) > + return SEC_E_OK; > else > { > WARN("SSLRead failed: %ld\n", (long)status); Every other path has a log line. You could add one to this case, but it's probably just sufficient to put an "or" clause in the noErr condition: if (status == noErr || status == errSSLClosedGraceful) TRACE("Read %lu bytes\n", *length); -Ken

1 0

FFE (force feedback) file format reverse engineered
by Elias Vanderstuyft 20 Feb '14

20 Feb '14

Hi, Two weeks ago, I started working on reverse engineering the FFE file format, because the functionality to load and write is currently not available in Wine: http://wiki.winehq.org/ForceFeedbackSummerOfCode2005Summary " Missing functionality: - Reading and writing FF effects to files (IDirectInputDevice8::WriteEffectToFile and IDirectInputDevice8::EnumEffectsInFile) have not been implemented. They are stored in a RIFF file, the details of which are undocumented. Given the nature of RIFF, it should be relatively simple (albeit time-consuming) to determine the exact format of the effect files. " So I wrote a Python program that can read and validate FFE files, based on my assumption of the file format structure. In the Python file: - I tried to maximally expose the relation of the FFE file contents and the RIFF structure. - Every single bit in the FFE file will be tested/validated, and the program will throw a 'Warning' when something odd/against my assumptions, occurred with the file of interest. I did not yet implement write functionality in the Python file, but it should not be difficult (~inverse operation of read). For the CustomForce effect, my assumptions are hypothetical: there was no way to test it, because: - I did not find any file containing such effect - I couldn't create such file, because FEdit.exe does not support CustomForce effects to be created. This should be a starting point to implement these read and write stubs in Wine. I don't have time to do that now, so, maybe someone else is interested to do so? Any feedback is welcome, Best regards, Elias

2 3

Re: [3/3] gdi32/tests: Avoid using GetGlyphIndices directly.
by 中川祥 20 Feb '14

20 Feb '14

What a phrase it is! By the way,please replay to my patches 102290 and 102289. Please comment if they are safe,if true,they will be comitted. 2014-02-19 21:02 GMT+09:00 Akihiro Sagawa <sagawa.aki(a)gmail.com>: > > This makes NT4 happy. > --- > dlls/gdi32/tests/font.c | 45 ++++++++++++++++++++++++++++----------------- > 1 file changed, 28 insertions(+), 17 deletions(-) > > > > >

2 1

Re: [PATCH 2/2] oleaut32: Fix VariantCopy() for VT_RECORD variants (resent)
by Alexandre Julliard 20 Feb '14

20 Feb '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/oleaut32/tests/vartest.c | 46 ++++++++++++++++++++++--- > dlls/oleaut32/variant.c | 79 ++++++++++++++++++++----------------------- > 2 files changed, 79 insertions(+), 46 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M jscript.dll -p jscript_test.exe.so run && touch run.ok wine: Unhandled page fault on read access to 0x00000001 at address 0x686c7866 (thread 007f), starting debugger... Unhandled exception: page fault on read access to 0x00000001 in 32-bit code (0x686c7866). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:686c7866 ESP:0032f6a0 EBP:0032f6d8 EFLAGS:00010202( R- -- I - - - ) EAX:0032f720 EBX:687a01ec ECX:0032f6f0 EDX:00000001 ESI:00000000 EDI:0032f720 Stack dump: 0x0032f6a0: 001d0ca8 000012e0 0032f6e8 686c6914 0x0032f6b0: 00000020 00000000 001d0da8 0032f758 0x0032f6c0: 4d430003 00000000 0032f6f0 687a01ec 0x0032f6d0: 558b6bc0 00000000 0032f748 686c8eed 0x0032f6e0: 00000018 00000000 00000000 686c8eed 0x0032f6f0: 003315c0 0032f720 00000080 0032f70c Backtrace: =>0 0x686c7866 SafeArrayGetRecordInfo+0x46(psa=<couldn't compute location>, pRinfo=<couldn't compute location>) [/home/julliard/wine/wine/dlls/oleaut32/../../include/oaidl.h:4140] in oleaut32 (0x0032f6d8) 1 0x686c8eed SAFEARRAY_CopyData+0x28c(psa=0x3315c0, dest=0x331e78) [/home/julliard/wine/wine/dlls/oleaut32/safearray.c:409] in oleaut32 (0x0032f748) 2 0x686c91e6 SafeArrayCopy+0x145(psa=<couldn't compute location>, ppsaOut=<couldn't compute location>) [/home/julliard/wine/wine/dlls/oleaut32/safearray.c:1409] in oleaut32 (0x0032f7a8) 3 0x5589c671 VBArrayConstr_value+0x140(ctx=0x1ba150, vthis=0x32f838, flags=0x4000, argc=0x1, argv=0x1e5b50, r=0x32fa38) [/home/julliard/wine/wine/dlls/jscript/vbarray.c:308] in jscript (0x0032f808) 4 0x5587810b invoke_value_proc.isra+0x6a() in jscript (0x0032f858) 5 0x55878a57 Function_invoke+0x66(func_this=0x1d0d60, jsthis=(nil), flags=0x4000, argc=0x1, argv=0x1e5b50, r=0x32fa38) [/home/julliard/wine/wine/dlls/jscript/function.c:351] in jscript (0x0032f8a8) 6 0x5586b089 jsdisp_call_value+0xd8(jsfunc=0x1d0d60, jsthis=(nil), flags=0x4000, argc=0x1, argv=0x1e5b50, r=0x32fa38) [/home/julliard/wine/wine/dlls/jscript/dispex.c:1061] in jscript (0x0032f8f8) 7 0x5586b1a1 disp_call_value+0xb0(ctx=0x1ba150, disp=0x1d0d60, jsthis=(nil), flags=0x4000, argc=0x1, argv=0x1e5b50, r=0x32fa38) [/home/julliard/wine/wine/dlls/jscript/dispex.c:1200] in jscript (0x0032f9f8) 8 0x5586ef84 interp_new+0xc3(ctx=<is not available>) [/home/julliard/wine/wine/dlls/jscript/engine.c:985] in jscript (0x0032fa58) 9 0x55874a94 exec_source+0x1e3(ctx=<is not available>, code=<is not available>, func=<is not available>, from_eval=<is not available>, ret=<is not available>) [/home/julliard/wine/wine/dlls/jscript/engine.c:2462] in jscript (0x0032fad8) 10 0x5587eb46 exec_global_code.isra+0x85() in jscript (0x0032fb18) 11 0x5587ee19 JScriptParse_ParseScriptText+0x2a8(iface=<couldn't compute location>, pstrCode=<couldn't compute location>, pstrItemName=<couldn't compute location>, punkContext=<couldn't compute location>, pstrDelimiter=<couldn't compute location>, dwSourceContextCookie=<couldn't compute location>, ulStartingLine=<couldn't compute location>, dwFlags=<couldn't compute location>, pvarResult=<couldn't compute location>, pexcepinfo=<couldn't compute location>) [/home/julliard/wine/wine/dlls/jscript/jscript.c:805] in jscript (0x0032fba8) -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user32: If the listbox loses focus while holding capture, release it by essentially simulating a button up event.
by Nikolay Sivov 20 Feb '14

20 Feb '14

On 2/20/2014 15:35, Huw Davies wrote: > --- > dlls/user32/listbox.c | 1 + > dlls/user32/tests/listbox.c | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+) > > case WM_KILLFOCUS: > + LISTBOX_HandleLButtonUp( descr ); /* Release capture if we have it */ > descr->in_focus = FALSE; > descr->wheel_remain = 0; This isn't totally correct. It's fine for when you press and hold left button and then change focus with Tab for example, LBN_SELCHANGE does indeed happen in this case. But when you just Tab away from a list with no mouse commands you shouldn't send LBN_SELCHANGE.

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel