- wine-devel - winehq.org

Re: [2/2] dpnet: Use registry for lookup in IDirectPlay8Peer, EnumServiceProviders
by Alexandre Julliard 12 Feb '14

12 Feb '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -141,30 +175,56 @@ static HRESULT WINAPI IDirectPlay8PeerImpl_EnumServiceProviders(IDirectPlay8Peer > else > { > FIXME("Application requested a provider we don't handle (yet)\n"); > - *pcReturned = 0; > return DPNERR_DOESNOTEXIST; > } > > if(*pcbEnumData < req_size) > { > + RegCloseKey(key); > + > *pcbEnumData = req_size; > return DPNERR_BUFFERTOOSMALL; > } > > - pSPInfoBuffer->pwszName = (LPWSTR)(pSPInfoBuffer + 1); > - > if(!pguidServiceProvider) > { > - lstrcpyW(pSPInfoBuffer->pwszName, dp_providerW); > - pSPInfoBuffer->guid = CLSID_DP8SP_TCPIP; > + int offset = 1; > + int count = 0; > + LPWSTR infoend = ((LPWSTR)pSPInfoBuffer + (sizeof(DPN_SERVICE_PROVIDER_INFO) * (*pcReturned))); > + > + index = 0; > + nextKeyNameResult = RegEnumKeyW( key, index, provider, MAX_PATH); > + while(nextKeyNameResult == ERROR_SUCCESS) > + { > + DWORD dwBufLen = 350; > + WCHAR name[350]; > + > + res = RegGetValueW( key, provider, friendly, RRF_RT_REG_SZ, NULL, name, &dwBufLen); > + if(res == ERROR_SUCCESS) > + { > + pSPInfoBuffer[count].guid = CLSID_DP8SP_TCPIP; > + pSPInfoBuffer[count].pwszName = (LPWSTR)(infoend + offset); > + lstrcpyW(pSPInfoBuffer[count].pwszName, name); > + > + offset += dwBufLen/sizeof(WCHAR); > + > + count++; > + } > + > + index++; > + nextKeyNameResult = RegEnumKeyW( key, index, provider, MAX_PATH ); > + } The buffer sizes and pointers are pretty much all handled incorrectly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw/tests: Skip the primary palette tests if the 640x480x8 mode is not supported.
by Marvin 12 Feb '14

12 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4809 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:3231: Test failed: SetDisplayMode failed, hr 0x80004001.

1 0

Re: [PATCH 2/4] qedit/tests: Expand the SampleGrabber COM tests.
by Marvin 12 Feb '14

12 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4795 Your paranoid android. === w2008s64 (32 bit mediadet) === mediadet.c:150: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401857 === w2008s64 (64 bit mediadet) === mediadet.c:150: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00000000004017B5

2 1

How can I get a bugzilla database dump?
by Scott Ritchie 12 Feb '14

12 Feb '14

A volunteer and I have been working on a secret prototype project for Wine, but before showing it to the world I'd like to demo how it would tie in to bugzilla. To do this, it would be easiest to just have a copy of our current database. Is this an easy thing to get for me? Thanks, Scott Ritchie

2 1

Re: ws2_32/tests: Add WSAEnumNameSpaceProviders[A|W] tests (try 2)
by Marvin 12 Feb '14

12 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4799 Your paranoid android. === wxppro (32 bit sock) === sock.c:559: Test failed: oob_server (b30): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:559: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:559: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

Re: ws2_32/tests: Add WSAEnumNameSpaceProviders[A|W] tests
by Marvin 12 Feb '14

12 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4798 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 4/4] qedit/tests: COM tests for IEnumPins from SampleGrabber.
by Marvin 12 Feb '14

12 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4796 Your paranoid android. === w2008s64 (32 bit mediadet) === mediadet.c:150: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401857 === w2008s64 (64 bit mediadet) === mediadet.c:150: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00000000004017BD

1 0

Rename "Version" field to "Earliest Affected Version" in Bugzilla?
by Ken Thomases 11 Feb '14

11 Feb '14

Hi, I haven't been subscribed to the bug emails for long, but it seems there's an ongoing problem with users updating the Version field to the _newest_ affected version when we want it to indicate the _earliest_ affected version. Sorry if this is the sort of thing which has been discussed and dismissed before, but it seems the problem could be reduced by renaming the field. I'm attaching a Bugzilla patch which I think does this. I'm not submitting to wine-patches yet because I'm not able to test this. Also, I don't know if people think it's a good idea, so I thought I'd ask first. -Ken

10 35

Re: [PATCH 3/6] wined3d: Use an rbtree for storing shaders for texture format conversion/blitting
by Stefan Dösinger 11 Feb '14

11 Feb '14

Am 11.02.2014 um 12:14 schrieb Martin Storsjo <martin(a)martin.st>: > --- > dlls/wined3d/arb_program_shader.c | 187 +++++++++++++++++++++++++------------- > 1 file changed, 122 insertions(+), 65 deletions(-) > > diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c > index 6d17ea3..8390c9e 100644 > --- a/dlls/wined3d/arb_program_shader.c > +++ b/dlls/wined3d/arb_program_shader.c > @@ -6768,22 +6768,68 @@ const struct fragment_pipeline arbfp_fragment_pipeline = { > arbfp_fragmentstate_template, > }; > > +struct arbfp_blit_type > +{ > + enum complex_fixup fixup; > + GLenum textype; > +}; > ... > +static int arbfp_blit_type_compare(const void *key, const struct wine_rb_entry *entry) > +{ > + const struct arbfp_blit_type *ka = key; > + const struct arbfp_blit_type *kb = &WINE_RB_ENTRY_VALUE(entry, const struct arbfp_blit_desc, entry)->type; > + > + return memcmp(ka, kb, sizeof(*ka)); > +} You have to watch out for padding space added by the compiler if you memcmp the structure. I think there’s no guarantee that enum complex_fixup is 4 bytes. Either use memset to initialize it to zero, or (preferred) make the fixup member a bitfield and add an explicit padding field for the remaining bits (see some structures in wined3d_private.h for examples) and set the padding to zero manually. > + desc = HeapAlloc(GetProcessHeap(), 0, sizeof(*desc)); > + if (!desc) > + { > + ERR("Out of memory\n"); > + GL_EXTCALL(glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, 0)); > + checkGLcall("glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, 0)"); > + GL_EXTCALL(glDeleteProgramsARB(1, &shader)); > + checkGLcall("GL_EXTCALL(glDeleteProgramsARB(1, &shader))"); > + return 0; > + } > ... > + ERR("Out of memory\n"); > + GL_EXTCALL(glDeleteProgramsARB(1, &shader)); > + checkGLcall("GL_EXTCALL(glDeleteProgramsARB(1, &shader))"); > + GL_EXTCALL(glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, 0)); > + checkGLcall("glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, 0)"); > + HeapFree(GetProcessHeap(), 0, desc); > + return 0; > + } You can use goto (yes, goto) to avoid code duplication in error handling. See e.g. wined3d_device_init_3d in device.c > - upload_palette(surface, context); I think you lost that call. The unfortunate thing about the P8 conversion is that the shader conversion codepath is essentially dead code for various reasons. So it’s tricky to test and likely already broken.

2 1

Re: [PATCH 1/3] msvcrt/tests: Don't pass path containing spaces to _spawnvp (try3)
by Piotr Caban 11 Feb '14

11 Feb '14

Hi, s I've seen that this patch was marked as pending. I'm not sure what should I change in it. The argv[0] argument is not used in child process so maybe it will be clearer if I put some dummy value there. I can also change the tests to not use _spawnvp. There's following comment near _spawnvp implementation: Like on Windows, this function does not handle arguments with spaces or double-quotes. Here are some results that shows what happens on windows when the tests are executed without this patch. The behavior on wine is similar. E:\>msvcrt_crosstest.exe file file: 3 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 791 tests executed (0 marked as todo, 0 failures), 0 skipped. E:\>"a a\msvcrt_crosstest.exe" file Fatal: test 'a\msvcrt_crosstest.exe' does not exist. file.c:1417: Test failed: bad position 0 expecting 8 file.c:1419: Test failed: Couldn't read back the data Fatal: test 'a\msvcrt_crosstest.exe' does not exist. Fatal: test 'a\msvcrt_crosstest.exe' does not exist. file.c:1987: Test failed: i 0, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '⌂' file.c:1987: Test failed: i 1, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '⌂' file.c:1987: Test failed: i 2, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '⌂' Fatal: test 'a\msvcrt_crosstest.exe' does not exist. file.c:2024: Test failed: fread() returned 0: ferror=0 file.c:2027: Test failed: got '⌂' expected 'Hello worldHello worldHello world' file: 791 tests executed (0 marked as todo, 10 failures), 0 skipped. In the failing case argv[0] = "a" argv[1] = "a\msvcrt_crosstest.exe" argv[2] = "file" Thanks, Piotr

2 1

Re: [PATCH 1/2] wined3d: Add support for NV12 textures
by Stefan Dösinger 11 Feb '14

11 Feb '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, The shader looks ok to me. Please add a test - see yuv_color_test in dlls/d3d9/tests/visual.c as an example, although it might not be feasible to integrate a NV12 test into the UYVY / YUY2 test loop. Since the UYVY / YUY2 test already covers the color space conversion parts I think a NV12 test should make sure that the coordinate selection works properly. Test that e.g. a 4x4 or 8x8 texture produces the correct color pattern. Am 2014-02-10 12:08, schrieb Martin Storsjo: > This fixes video playback with the sample app from OpenH264. > --- > I haven't been able to test the GL_TEXTURE_RECTANGLE_ARB codepath > here - if I explicitly disable > gl_info->supported[ARB_TEXTURE_NON_POWER_OF_TWO] the same app > crashes. Similarly for YV12 (which already exists and works), > if I disable ARB_TEXTURE_NON_POWER_OF_TWO there, the app crashes > and the video output is also garbled (the luma channel seems to > be right but chroma is handled incorrectly). I don't know what could be wrong with the texture rectangle codepath. I tested it when I wrote it for other formats, but it's quite possible that it has suffered from bitrot in the years since then. Also keep in mind that wined3d assumes limited ARB_TEXTURE_NON_POWER_OF_TWO support if OpenGL 2.0 is supported. > @@ -6772,6 +6772,7 @@ struct arbfp_blit_priv { > GLenum yuy2_rect_shader, yuy2_2d_shader; > GLenum uyvy_rect_shader, uyvy_2d_shader; > GLenum yv12_rect_shader, yv12_2d_shader; > + GLenum nv12_rect_shader, nv12_2d_shader; > GLenum p8_rect_shader, p8_2d_shader; > GLuint palette_texture; > }; It might be a good idea to replace those 10 shaders and the poorly scaling search for them with a rbtree. Yeah, I know, I started this mess, but back then it was just 4 shaders and we've been too lazy to clean this up since then :-\ . > + switch(textype) { > + case GL_TEXTURE_2D: tex = "2D"; break; > + case GL_TEXTURE_RECTANGLE_ARB: tex = "RECT"; break; > + default: > + FIXME("Implement nv12 correction for non-2d, non-rect textures\n"); > + return FALSE; > + } Regarding the code style please use the style found in dlls/wined3d/cs.c. We're migrating the code style of wined3d to this style, but since style-only changes are frowned upon we're doing this as we go. I'm sorry for the mess :-( -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS+MA3AAoJEN0/YqbEcdMw434P/36l/R7vl7k3mx24+cYw1mll DOqx4yov+V+I3ERFbQjWmzwvAKoxFbo2+Qn7AaEAegGk1x5G3cuw4jZmo+C4bUb0 uvePY9WbvZptGFdavLAEgYWaBtY6M9pNJkp1PuIehqeq9D3XP98AUH4awzWFbfcD /dQQGVow1D8hkp57iATzUpEwDZBGttAePxyYR/gj7r1FnqPpVD0NW/zWoLJBWMrq 4YQSZBmJQK3xq5mcVlajNUg0Ylh82fp0bzxCie8Zw1jNuahmbGEAaht87fzxWCMc DgdcCS19aZEa39kNT/0ft/vybIPNyHVA+Mon+JgYmEVQRxhJMCl6gYbEKYCWcs0f OZc6d5B8Z4PX9FiPTnofs49SRq2+Gh6YggJdjToY2YZ2iOGgD4A87EIj2iZQc+6w 9jz2SLIZPl4zrjBY5Ji31qyKy8c+emOO9KC1OdnkFPo6eUeIussjrCfX7r2mNyRs 2qNHLz2yrd8aG0+swYvHocZ/wnUeOtgaTYJef8BTEut0+iBsDJ/eQom1/84orhxJ oHmdTbfepXMEoQvhkMSu79gZBMnwvFERZngzOPjKuw0KS3XM+KIFOy1nFeVAMGvb AoVa39jkByIcF0tN6vuf12LdWtdMqkwKeNuF36iEwVAgzkr8pAU6xHL5QqY1QhuB zsCB0PSX3QSmNC/4s7k8 =r3du -----END PGP SIGNATURE-----

2 1

Re: [PATCH 2/2] draw: Return the D3D identifier when GetDeviceIdentifier is called with no flags.
by Henri Verbeet 11 Feb '14

11 Feb '14

On 11 February 2014 06:54, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > + memset(&adapter_id, 0x0, sizeof(adapter_id)); > + adapter_id.driver = DriverName; > + adapter_id.driver_size = sizeof(DriverName); > + adapter_id.description = DriverDescription; > + adapter_id.description_size = sizeof(DriverDescription); I think you can just write that as: + adapter_id.driver = DDDI->szDriver; + adapter_id.driver_size = sizeof(DDDI->szDriver); + adapter_id.description = DDDI->szDescription; + adapter_id.description_size = sizeof(DDDI->szDescription); + adapter_id.device_name_size = 0; > + /* check how strings are copied into the structure */ > + ok(pdddi2->szDriver[MAX_DDDEVICEID_STRING - 1]==0, "szDriver not cleared\n"); > + ok(pdddi2->szDescription[MAX_DDDEVICEID_STRING - 1]==0, "szDescription not cleared\n"); I don't think there anything in the code that guarantees this.

1 0

Re: [2/2] shell32: Supply a module name to CreateProcess
by Dmitry Timoshkov 11 Feb '14

11 Feb '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > --- a/dlls/shell32/shlexec.c > +++ b/dlls/shell32/shlexec.c > @@ -315,6 +315,8 @@ static UINT_PTR SHELL_ExecuteW(const WCHAR *lpCmd, WCHAR *env, BOOL shWait, > WCHAR curdir[MAX_PATH]; > DWORD dwCreationFlags; > const WCHAR *lpDirectory = NULL; > + WCHAR module_path[MAX_PATH] {0}; Does this really compile? -- Dmitry.

1 0

Re: [PATCH 1/5] wined3d: Introduce a sub resource structure.
by Henri Verbeet 10 Feb '14

10 Feb '14

On 10 February 2014 13:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This structure will be a base structure for buffers, surfaces and > volumes. It will take care of location management, opengl buffers, > mapping and (at least for now) memory allocation. Sub resources will > also store the pointer to the container resource. > I'm not convinced this is really the correct approach to this.

2 1

Re: bcrypt: Add semi-stub implementation of BCryptGenRandom (try 2)
by Alexandre Julliard 10 Feb '14

10 Feb '14

Bruno Jesus <00cpxxx(a)gmail.com> writes: > + > + /* Zero sized buffer should work too */ > + ret = pBCryptGenRandom(NULL, buffer, 0, BCRYPT_USE_SYSTEM_PREFERRED_RNG); > + ok(ret == STATUS_SUCCESS, "Expected success, got 0x%x\n", ret); > + > + /* Test random number generation - It's impossible for a sane RNG to return 8 zeros */ > + rnd[0] = 0; > + rnd[1] = 0; > + ret = pBCryptGenRandom(NULL, buffer, sizeof(DWORD) * 2, BCRYPT_USE_SYSTEM_PREFERRED_RNG); > + ok(ret == STATUS_SUCCESS, "Expected success, got 0x%x\n", ret); > + ok(rnd[0] || rnd[1], "Expected a random number, got 0\n"); > + trace("BCryptGenRandom : %08X%08X\n", rnd[0], rnd[1]); There's no reason to work with DWORDs, the function returns bytes, just use that directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: configure: Avoid nesting cat calls.
by Alexandre Julliard 10 Feb '14

10 Feb '14

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > @@ -3453,9 +3453,7 @@ fi > AC_CONFIG_COMMANDS([Makefile], [wine_fn_output_makefile Makefile], > [wine_fn_output_makefile () > { > - cat Make.tmp - <<\_WINE_EOF >\$tmp/makefile && mv -f \$tmp/makefile \$[]1 && rm -f Make.tmp && return > -`cat $wine_rules_file` > -_WINE_EOF > + cat Make.tmp $wine_rules_file >\$tmp/makefile && mv -f \$tmp/makefile \$[]1 && rm -f Make.tmp && return This doesn't do the same thing at all, it can't possibly work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Alexandre Julliard : Wine release 1.7.12
by Joseph Facciponti 09 Feb '14

09 Feb '14

remove me from your list please On Fri, Feb 7, 2014 at 2:04 PM, Alexandre Julliard <julliard(a)winehq.org>wrote: > Module: website > Branch: master > Commit: 14ca1bc06c384e1a3c2d51b3205a7e1e54045519 > URL: > http://source.winehq.org/git/website.git/?a=commit;h=14ca1bc06c384e1a3c2d51… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Feb 7 20:04:34 2014 +0100 > > Wine release 1.7.12 > > --- > > news/en/2014020701.xml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/news/en/2014020701.xml b/news/en/2014020701.xml > new file mode 100644 > index 0000000..ce004de > --- /dev/null > +++ b/news/en/2014020701.xml > @@ -0,0 +1,16 @@ > +<news> > +<date>February 7, 2014</date> > +<title>Wine 1.7.12 Released</title> > +<body> > + The Wine development release 1.7.12 is now available. > + <a href="{$root}/announce/1.7.12">What's new</a> in this release: > +<ul> > + <li>Initial support for Window Media Player interfaces.</li> > + <li>Some more Task Scheduler support.</li> > + <li>Various C++ runtime fixes.</li> > + <li>More dlls with ugly names for Windows 8 API set support.</li> > + <li>Various bug fixes.</li> > +</ul> > +The source is <a href=" > http://prdownloads.sourceforge.net/wine/wine-1.7.12.tar.bz2">available > now</a>. > +Binary packages are in the process of being built, and will appear soon > at their respective <a href="{$root}/download">download locations</a>. > +</body></news> > > > >

2 1

FOSDEM Presentations
by Stefan Dösinger 09 Feb '14

09 Feb '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Do we collect FOSDEM presentations in a central place? Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS9nIIAAoJEN0/YqbEcdMwXWIP/iB5Hb647oT5UcSiUy7Zru7a YaFb5/uTkBpOJZhD9KAa/u6XT8l7jh9pB633RgZSPl4xBY9/T3aIo+5amMF7IOvA 3NP3I0bRehnlbzAaeqhoN97BIHJQ4Y2ulub+FPx/GDY/kxwXayd0jurEcf+ZL4K2 csOtkgSplI05YXxBw1ZmYjiOGfXgqRH1DCEyaFaFgEWenYrfER7XzaiT2xAK64JN 85Cmp2vh5zlTh3C5jChpoeaWIHcweHC5EYONYOCAk9W2wxZdin0QWjYVnja5+DzR HnrcIsiFAXdD9IRxBStc+y4yqUq5YIDfZczpj0fI5cuPrqOxvnomyNI/y2Zs4epz sq1lL5eEyo5hTQS99PbqbENrT7IRF0IpSIebcrPCTbCpuKHctwWe3oFFS2BuqIPl 4Q/6bsNXxvQW4B3es4vcGDov05Aiy/MT1NQZoEsIXvYNa/ufqiEDmmXVCRz7rI6f 9D4hiMzS6Dxh3VRSigBcg1R3H+rYc+v1gUxGutcXWplGrVLFuE3iBY7UYfdp9rkC 6zcidSNrUDMsQMKLbmCXQV361RcL03bi+rtTVzl4d/u5RhpgVZG8BSoq49+Nt3ea MHNplal9pHWXcBHXos3L0o4PeF2tf7rdNRuLOdVYya6bBYP/UpVtHeJ2/SD7WoOV HvlQe9zHcOxAKYSX0M0P =bd+Z -----END PGP SIGNATURE-----

3 3

Re: oleaut32: Resolve embedded unnamed TypeLib dependencies using their GUID.
by Nikolay Sivov 08 Feb '14

08 Feb '14

On 2/8/2014 03:27, guillaume.charifi(a)sfr.fr wrote: > This patch is designed to fix the bug: > http://bugs.winehq.org/show_bug.cgi?id=34184 > It appears that while the dependency checking of a TypeLib is being > processed, some programs have the requested TypeLib in their Resource > section/TYPELIB. Before this patch, the behavior was to look for the > TLB on the disk, using the name provided. Obviously, when it is > embedded into the program, the function fails everytime. Now, > considering the GUID in place of the TLB name, and searching into the > Resource section, the TLB is correctly loaded. > This is what happens with Skype's "uc.tlb", whose name is only > referenced in the TLB skControl, and nowhere else. Using instead the > GUID, we are able to find and load the unnamed "uc.tlb" from the > program resources. > > --- > dlls/oleaut32/typelib.c 193 > +++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 192 insertions(+), 1 deletion(-) > We already have a code to load from resource section, it should be reused instead of duplicating it like this. Also a test would be nice.

1 0

Re: Assorted spelling fixes
by Marvin 07 Feb '14

07 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4688 Your paranoid android. === w2008s64 (64 bit url) === url.c:1662: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1674: Test failed: unexpected call OnProgress_CONNECTING === w7pro64 (64 bit url) === url.c:1662: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1674: Test failed: unexpected call OnProgress_CONNECTING url.c:1871: Test failed: binding failed: 800c0005, expected 00000000 url.c:1882: Test failed: res = 00002efd, expected 00000000 url.c:3141: Test failed: expected OnProgress_SENDINGREQUEST url.c:3147: Test failed: expected OnResponse url.c:3151: Test failed: expected OnProgress_MIMETYPEAVAILABLE url.c:3152: Test failed: expected OnProgress_BEGINDOWNLOADDATA url.c:3153: Test failed: expected OnProgress_ENDDOWNLOADDATA url.c:3165: Test failed: expected OnDataAvailable url.c:1660: Test failed: unexpected call OnProgress_FINDINGRESOURCE

1 0

Re: Assorted spelling fixes
by Marvin 07 Feb '14

07 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4686 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar')

1 0

Re: [Tools] winetest: Make the WineTest executable links more visible.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Francois Gouget <fgouget(a)free.fr> writes: > --- > > As per WineConf. > Note that the choice of a 'legend' class rather than nothing or some > other class is mostly a matter of taste. I don't think that users not finding the test binary is a major problem. A better approach would be to add some help page on the wiki and link to that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: kernel32: In FindFirstFileExW(), call NtQueryDirectoryFile() again to determine if it read all files.
by Alexandre Julliard 07 Feb '14

07 Feb '14

Ken Thomases <ken(a)codeweavers.com> writes: > Previously, it only checked if the first call failed to fill the buffer. This > is unreliable since the underlying implementation may be forced to return > a short buffer by the semantics of the system calls used. In particular, > getdirentries() on Mac OS X can only read at the resolution of whole blocks > rather than individual directory entries for AFP-mounted volumes. It would be better to fix the ntdll side. -- Alexandre Julliard julliard(a)winehq.org

2 5

Preferred License for Presentations?
by Michael Stefaniuc 07 Feb '14

07 Feb '14

Hello guys, what license do we prefer to use for Wine presentations and the related material? For the LinuxTag presentation I have the option to pick one of: - Creative Commons License - UVM Lizenz für die freie Nutzung unveränderter Inhalte - GNU General Public License - UVM Lizenz für Freie Inhalte - GNU Free Documentation License thanks bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Supervisor, APAC/EMEA IT Network/Telephony Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Werner-von-Siemens-Ring 14, 85630 Grasbrunn Handelsregister: Amtsgericht Muenchen HRB 153243 Geschäftsführer: Mark Hegarty, Charlie Peters, Michael Cunningham, Charles Cachera

2 2

Call for updating recent news queue
by André Hentschel 07 Feb '14

07 Feb '14

Hi, After getting some very positive feedback at FOSDEM2014 i decided (even with lack of time) to get WWN started again. I'm still a developer, so my time is limited, therefor it would be nice if we could crowdsource this as far as possible. So it would be nice if everyone could have a look at: http://wiki.winehq.org/RecentNewsQueue and update it again. I know this worked last time, but we had no WWN for it. Even if this will be my first try to push out a WWN, i'll make sure this won't happen this time. Thanks in advance

3 2

Re: [PATCH 2/2] d3d9/tests: Test that Direct3D restores the pixel format on the window it targets. (try 2)
by Henri Verbeet 07 Feb '14

07 Feb '14

On 7 February 2014 02:13, Ken Thomases <ken(a)codeweavers.com> wrote: > > + ZeroMemory(&present_parameters, sizeof(present_parameters)); > + present_parameters.Windowed = TRUE; > + present_parameters.hDeviceWindow = hwnd; > + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; > + > + hr = IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, > + hwnd, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device); > + if (FAILED(hr) || !device) > + { > + skip("Failed to create device\n"); > + goto cleanup; > + } Please use create_device() for creating the device, unless there's some reason it can't work here. > + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); > + ok(SUCCEEDED(hr), "Present failed %#x\n", hr); I think an interesting test would be Present() with a non-NULL destination window. I'd also like the equivalent test for d3d8, and ddraw with a clip window.

1 0

questionarie
by Akira Nakagawa 07 Feb '14

07 Feb '14

Why my patch,101880 and 102083 are not commited? They have no problem,certified by Akihiro. -- Akira Nakagawa <matyapiro31(a)gmail.com>

2 1

Re: [PATCH 1/2] msvcrt: Return error on invalid handle in _open_osfhandle
by Marvin 07 Feb '14

07 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4655 Your paranoid android. === wxppro (32 bit file) === file.c:1417: Test failed: bad position 0 expecting 8 file.c:1419: Test failed: Couldn't read back the data file.c:1987: Test failed: i 0, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:1987: Test failed: i 1, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:1987: Test failed: i 2, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:2024: Test failed: fread() returned 0: ferror=0 file.c:2027: Test failed: got '' expected 'Hello worldHello worldHello world'

1 0

Re: [PATCH 2/2] d3d9/tests: Test that Direct3D restores the pixel format on the window it targets.
by Marvin 07 Feb '14

07 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4644 Your paranoid android. === wxppro (32 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === wvista (32 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === w2008s64 (32 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === w7pro64 (32 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === w2008s64 (64 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2 === w7pro64 (64 bit device) === device.c:7445: Test failed: window has pixel format 0, expected 2 device.c:7455: Test failed: window has pixel format 0, expected 2

1 0

Re: msvcrt: Don't prevent msvcrt from getting unloaded
by Piotr Caban 06 Feb '14

06 Feb '14

On 02/06/14 15:54, Piotr Caban wrote: > --- > dlls/msvcrt/main.c | 3 --- > 1 file changed, 3 deletions(-) Please ignore this patch for now. It breaks the app it was originally added for (bug 21930).

1 0

Wine at LinuxTag in Berlin
by Michael Stefaniuc 06 Feb '14

06 Feb '14

Hello guys, to follow up to Jeremy's email on doing more Wine "evangelism" the idea quickly came up to do something for LinuxTag which happens from 8th to 10th May in Berlin / Germany http://www.linuxtag.org/2014/en/ . Talks: ------ The deadline for proposals is the 7th February. - I will submit a talk proposal: "Is Wine Still Relevant?" with a a subtitle along the lines of "A Wine status update focusing on current use cases and new exciting developments". Needs more buzzwords, I know ;) - Marcus had other ideas for talks, of course somebody would need to hold them. <_Marcus_> and a Playing Windows games with Wine could be seperate if necessary /& wanted... would surely also be interesting <_Marcus_> and Wine on Android , which I was surprised to have it fill the room ;) <_Marcus_> and a pipelight talk ... that would surely pull folks. - We're open to other talk proposals. Please don't hesitate to reply if you're interested. Booth: ------ - I'm still trying to figure out the deadline for the registration of a booth. - With 3 days this is a significant time investment. - Needs around 3-4 people to man the booth. - We could share a booth with an other project but we will still need at least 2 persons for that, 3 or more is better. - Let me know if somebody is interested in this. bye michael

9 13

Profiling CS:GO
by Brock York 06 Feb '14

06 Feb '14

Hey list I'm trying to find out why CS:GO is slower under wine then windows. When running a benchmark in CS:GO Win8 gets ~134fps and wine ~51fps. I've been following Stefan Dösingers guide ( http://wiki.winehq.org/Performance) and have compiled wined3d for windows and tryed running CS:GO using wined3d under win8 but it just crashes while loading the map. At a guess I'd say once it trys to do 3D rendering. Which brings me to my first question. How do you debug and profile wined3d when using windows? Because when every I tried to run a debugger or attach one under windows or using winedbg the game just crashes when booting. Anti-debug techniques maybe? The second being that when using perf under linux it doens't seem to really be a wined3d problem after all the effort of testing it. Attached is the perf output where is shows most of it's time is spent in the actual csgo.exe code. CS:GO under linux seems to have a lot less cpu utilisation under wine. Win8 65-78% utilisation wine 48-51% utilisation of the cpu. Where should I look next for what's causing the problem? Also I'm really new to wine development. I'm still a uni student. Apologies for anything stupidly obvious I've missed. Regards Brock York.

2 6

Re: kernel32/tests: Add test for FindFirstFileA()
by Dmitry Timoshkov 06 Feb '14

06 Feb '14

Zhenbo Li <litimetal(a)gmail.com> wrote: > + strcpy(buffer2, nonexistent); > + handle = CreateFileA(buffer2, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0 ); There is no need for a strcpy(). > + ok(handle != INVALID_HANDLE_VALUE, "failed to create a file\n"); > + handle = FindFirstFileA(buffer2, &data); > + ok(handle != FindFirstFileA, "failed to find an existent file\n"); It would be useful to actually test what FindFirstFileA() returns. Also not leaking the handle *twice* would be a bonus point. -- Dmitry.

2 2

HTTPS-Everywhere (development) now supports winehq.org
by Austin English 06 Feb '14

06 Feb '14

If you're using HTTPS-Everwhere on Firefox, you might want to upgrade to their latest development release: https://www.eff.org/files/https-everywhere-4.0development.15.xpi which now supports winehq.org. Cheers, Austin

1 0

Re: ws2_32: Fix some parameters checking in AcceptEx
by Marvin 06 Feb '14

06 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4626 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (b34): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: Nikolay Sivov : crypt32/tests: Accept another error code on Win8.
by Joseph Facciponti 05 Feb '14

05 Feb '14

Please remove me from mailng list. On Wed, Feb 5, 2014 at 2:18 PM, Alexandre Julliard <julliard(a)winehq.org>wrote: > Module: wine > Branch: master > Commit: c7a11f9ed619dfd586e96917faa1ee83d64c7352 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=c7a11f9ed619dfd586e96917f… > > Author: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Wed Feb 5 21:50:32 2014 +0400 > > crypt32/tests: Accept another error code on Win8. > > --- > > dlls/crypt32/tests/cert.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/crypt32/tests/cert.c b/dlls/crypt32/tests/cert.c > index bd67c18..9c95629 100644 > --- a/dlls/crypt32/tests/cert.c > +++ b/dlls/crypt32/tests/cert.c > @@ -3724,7 +3724,7 @@ static void testAcquireCertPrivateKey(void) > &keyProvInfo); > ret = pCryptAcquireCertificatePrivateKey(cert, 0, NULL, &csp, > &keySpec, > &callerFree); > - ok(!ret && GetLastError() == CRYPT_E_NO_KEY_PROPERTY, > + ok(!ret && (GetLastError() == CRYPT_E_NO_KEY_PROPERTY || > GetLastError() == NTE_BAD_KEYSET /* win8 */), > "Expected CRYPT_E_NO_KEY_PROPERTY, got %08x\n", GetLastError()); > > pCryptAcquireContextA(&csp, cspNameA, MS_DEF_PROV_A, PROV_RSA_FULL, > > > >

1 0

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications (resend).
by Marvin 05 Feb '14

05 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4612 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (af4): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH] shell32/tests: Remove some assertions in test code
by Marvin 05 Feb '14

05 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4602 Your paranoid android. === wxppro (32 bit shlexec) === shlexec.c:1204: Test failed: expected 1 args, got 4 shlexec.c:2247: Test failed: argcA expected 5, but got 4 === w2008s64 (32 bit shlexec) === shlexec.c:1545: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt28F.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt28F.tmp\test file.shlexec' shlexec.c:2623: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt28F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt28F.tmp\test2.exe' shlexec.c:2636: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt28F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt28F.tmp\test2.exe' shlexec.c:2648: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt28F.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt28F.tmp\test2.exe' === w2008s64 (64 bit shlexec) === shlexec.c:1545: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt176.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt176.tmp\test file.shlexec' shlexec.c:2623: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt176.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt176.tmp\test2.exe' shlexec.c:2636: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt176.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt176.tmp\test2.exe' shlexec.c:2648: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt176.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt176.tmp\test2.exe'

2 1

Temporary Directories
by C.W. Betts 05 Feb '14

05 Feb '14

I’m wondering if Wine has some way of marking temporary directories and/or files as such. I’m mainly asking because OS X has APIs to mark directories (and maybe files) excluded from backup from their Time Machine software. And temporary directories are often modified a lot, making backups of them taking awhile to complete.

3 2

Re: server: Fix generic access mapping for a thread.
by Marvin 05 Feb '14

05 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4597 Your paranoid android. === wvista (32 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff === w2008s64 (32 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff === w7pro64 (32 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff === w2008s64 (64 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff === w7pro64 (64 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff

1 0

Re: ws2_32/tests: Fix AcceptEx tests related to address length
by Marvin 05 Feb '14

05 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4593 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (af4): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0

1 0

Wine fiscal governance, Conservancy role, new initiatives
by Jeremy White 04 Feb '14

04 Feb '14

Hey Folks, At FOSDEM, Alexandre, Michael and I sat down and talked with Bradley Kuhn from the Software Freedom Conservancy about the Wine Project. For those who are not aware, the SFC is the umbrella organization that holds Wine's money and it's trademarks. They also help us if we have legal questions, or just odd this and thats that are helpful to a project like ours. They (and Bradley in particular) have been quite helpful through the years. Again for the record, spending decisions are controlled by a committee of 5, and we require a majority vote of a quorum for any spending. The quorum for any given decision cannot itself have a majority from any one company. The current committee is myself, Alexandre, Michael Stefaniuc, Marcus, and Austin English. The committee is self replacing, so if one steps down, the remaining members nominate a replacement. The SFC will recognize a 'revolution'; if the committee is clearly out of step with a majority of Wine contributors, it will force a change. In practice, the committee mostly decides who to fund for travel to the annual Wine conference. We have in the past agreed to provide SFC with 10% of our income to help them provide the support and staffing. We are still working on revising the formal paperwork to back this, and will likely be presenting that formal paperwork sometime this year (hopefully :-/). Bradley proposed one new idea that I think is worth while: sponsoring Wine evangelism. That is, sponsoring travel to various shows to present talks on Wine, or to man a table to talk up Wine. That seems like a good idea, and we will likely pursue it. If anyone is excited about the idea of being a Wine 'evangelism coordinator', drop me a line. Now get back to work; I expect test.winehq.org to be showing green before the next release... <grin> Cheers, Jeremy

1 0

Re: Assorted typos fixes (resend 2)
by Nikolay Sivov 04 Feb '14

04 Feb '14

On 2/4/2014 17:21, Andrey Gusev wrote: > - FIXME("(%p)->(%s,%p,%p,%08x): stub !\n", iface, lpszFileName, pec, pvRef, dwFlags); > + FIXME("(%p)->(%s,%p,%p,%08x): stub!\n", iface, lpszFileName, pec, pvRef, dwFlags); It's nice to have a proper spacing of course, but I don't think it justifies such changes. > -#define WINE_FILENAME_STR "dpnadr.dll" > +#define WINE_FILENAME_STR "dpnaddr.dll" > - ok(dip_gain_get.dwData==dip_gain_set.dwData, "Gain not udated: %i\n", dip_gain_get.dwData); > + ok(dip_gain_get.dwData==dip_gain_set.dwData, "Gain not updated: %i\n", dip_gain_get.dwData); These ones are valid, and some others too. But the rest is a noise.

1 0

Re: winmm/tests: Avoid spurious test failures on Windows.
by Marvin 04 Feb '14

04 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4578 Your paranoid android. === wxppro (32 bit mci) === mci.c:1212: Test failed: mci status "C:\Documents and Settings\winetest\My Documents\tempfile.wav" mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1277: Test failed: mci re-auto-open status mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1293: Test failed: mci auto-open pause returned MCIERR_INVALID_DEVICE_NAME

2 1

Official retirement of 'old' wine test bot, celebration of the work of Gé van Geldorp
by Jeremy White 04 Feb '14

04 Feb '14

Folks, Arno van Geldorp has let us know that this will be the last month that the original test bot continues to run. We will be redirecting the 'testbot' urls to the new wine test bot as a result. These intervening years have made clear just how great Gé's gift to us was. It has taken us multiple people many years to begin to replicate his work. But I think we'll be okay; Francois has done a lot of hard work, and once Huw is a qemu expert, I think we will come out of the woods. We also owe a great deal to the van Geldorp family for so graciously paying to host the old wine testbot, long after the time that Gé had asked for. That, too, was a very generous gift. So please join me in thanking the entire family of Gé van Geldorp for their incredible gifts to Wine over the years. Cheers, Jeremy

1 0

[PATCH v7 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 04 Feb '14

04 Feb '14

This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations The patchset avoids data races problem on newely created files: open with O_CREAT can return the -ESHAREDENIED error for a successfully created file if this files was locked with a sharelock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This lets not mix one share reservation approach with another. Patches #1, #2 and #3 add O_DENY* flags to fcntl and implement VFS part. A patch #4 is related to CIFS client changes, #5 -- NFSD, #6 and #7 describe NFSv4 client parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. NFS returns -EINVAL for opens with this flag. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND ----- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts CIFS: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS NFSv4: Add deny state handling for nfs4_state struct NFSv4: Add O_DENY* open flags support arch/alpha/include/uapi/asm/errno.h | 2 + arch/alpha/include/uapi/asm/fcntl.h | 3 + arch/mips/include/uapi/asm/errno.h | 2 + arch/parisc/include/uapi/asm/errno.h | 2 + arch/parisc/include/uapi/asm/fcntl.h | 3 + arch/sparc/include/uapi/asm/errno.h | 2 + arch/sparc/include/uapi/asm/fcntl.h | 3 + fs/cifs/cifsacl.c | 2 + fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 17 +- fs/cifs/cifssmb.c | 2 +- fs/cifs/dir.c | 6 + fs/cifs/file.c | 20 ++- fs/cifs/inode.c | 12 +- fs/cifs/link.c | 2 + fs/cifs/netmisc.c | 2 +- fs/cifs/smb1ops.c | 3 + fs/cifs/smb2inode.c | 1 + fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 6 + fs/cifs/smb2pdu.c | 2 +- fs/fcntl.c | 5 +- fs/locks.c | 161 ++++++++++++++++-- fs/namei.c | 56 +++++- fs/nfs/dir.c | 39 ++++- fs/nfs/inode.c | 8 +- fs/nfs/internal.h | 3 +- fs/nfs/nfs4_fs.h | 83 ++++++++- fs/nfs/nfs4file.c | 8 +- fs/nfs/nfs4proc.c | 310 +++++++++++++++++++++++----------- fs/nfs/nfs4state.c | 65 ++++--- fs/nfs/nfs4super.c | 9 +- fs/nfs/nfs4xdr.c | 21 ++- fs/nfs/super.c | 7 +- fs/nfsd/nfs4state.c | 46 ++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 15 ++ include/linux/nfs_fs.h | 5 +- include/linux/nfs_xdr.h | 1 + include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 ++ include/uapi/linux/fs.h | 1 + 43 files changed, 789 insertions(+), 166 deletions(-) -- 1.7.10.4

4 18

Re: Assorted typos fixes (resend)
by Michael Stefaniuc 04 Feb '14

04 Feb '14

Hello Andrey, On 02/04/2014 12:19 PM, Andrey Gusev wrote: > diff --git a/dlls/dpnet/client.c b/dlls/dpnet/client.c > index 637dcb8..e94eea6 100644 > --- a/dlls/dpnet/client.c > +++ b/dlls/dpnet/client.c > @@ -54,7 +54,7 @@ static HRESULT WINAPI IDirectPlay8ClientImpl_QueryInterface(IDirectPlay8Client * > return DPN_OK; > } > > - WARN("(%p)->(%s,%p),not found\n",This,debugstr_guid(riid),ppobj); > + WARN("(%p)->(%s,%p), not found\n",This,debugstr_guid(riid),ppobj); when you do those can you please fix the obvious whitespace issues and add a space after the "," in the argument list? thanks bye michael

1 0

Re: Assorted typos fixes
by Alexandre Julliard 04 Feb '14

04 Feb '14

Andrey Gusev <andrey.goosev(a)gmail.com> writes: > @@ -81,6 +81,6 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) > */ > HRESULT WINAPI DllUnregisterServer(void) > { > - FIXME(":stub\n"); > + FIXME(": stub\n"); I'm not against fixing real typos, but please don't overdo it, that kind of whitespace change is not necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] taskschd: Add IRegisteredTaskCollection stub implementation.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/taskschd/Makefile.in | 1 + > dlls/taskschd/folder.c | 9 ++- > dlls/taskschd/regtask_collection.c | 161 +++++++++++++++++++++++++++++++++++++ > dlls/taskschd/taskschd_private.h | 1 + > 4 files changed, 170 insertions(+), 2 deletions(-) > create mode 100644 dlls/taskschd/regtask_collection.c > > diff --git a/dlls/taskschd/Makefile.in b/dlls/taskschd/Makefile.in > index a1835fc..c85da9b 100644 > --- a/dlls/taskschd/Makefile.in > +++ b/dlls/taskschd/Makefile.in > @@ -5,6 +5,7 @@ C_SRCS = \ > folder.c \ > folder_collection.c \ > regtask.c \ > + regtask_collection.c \ Please try to group related interfaces into the same source file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: add CM_Get_Device_Interface_List_Size(A/W) stubs (1/2)
by Dmitry Timoshkov 04 Feb '14

04 Feb '14

Austin English <austinenglish(a)gmail.com> wrote: > +@ stdcall CM_Get_Device_Interface_List_SizeA(ptr str ptr long) > +@ stdcall CM_Get_Device_Interface_List_SizeW(ptr wstr ptr long) These entries are completely wrong. Same goes for 2/2. -- Dmitry.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel