- wine-devel - winehq.org

Re: [2/2] dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo
by Nikolay Sivov 10 Jan '14

10 Jan '14

On 1/10/2014 11:18, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo > > > Best Regards > Alistair Leslie-Hughes > > + if(This->peername) > + HeapFree(GetProcessHeap(), 0, This->peername); > + if(This->data) > + HeapFree(GetProcessHeap(), 0, This->data); > + You don't need to check for NULL.

1 0

Re: [PATCH 1/2] ddraw: Make DirectDrawEnumerateEx only enumerate secondary display devices when requested.
by Henri Verbeet 09 Jan '14

09 Jan '14

I think this looks ok in principle, but a test wouldn't hurt.

2 3

Re: Assorted spelling fixes
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4101 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

Re: Command Stream Update
by Yuri Shishenko 09 Jan '14

09 Jan '14

Civilization V has performance regression with this wine version. It shows less FPS than unpatched wine-1.7.10: 20 FPS on maximum camera distance while with unpatched wine it shows 40-50 FPS. My PC specs: openSUSE 13.1, linux 3.12.6 x86_64, nVidia GTX660 with 331.20 driver, Intel Core I5-3570k.

1 0

Re: [PATCH 4/5] d3dx9_36/tests: Use a window with a non-zero size.
by Henri Verbeet 09 Jan '14

09 Jan '14

On 9 January 2014 13:43, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > WS_SYSMENU | WS_POPUP follows the existing code in D3DXCreateBoxTest, > which is the only test that created a useable device on my system. I think you might as well just use WS_OVERLAPPEDWINDOW like e.g. the d3d9 tests do, but I don't care that much.

1 0

Re: [PATCH 6/6] ddraw/tests: Add some color key tests for complex surfaces.
by Stefan Dösinger 09 Jan '14

09 Jan '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-09 12:17, schrieb Henri Verbeet: > + hr = IDirectDrawSurface7_GetAttachedSurface(surface, &caps, > &tmp); + ok(SUCCEEDED(hr), "Failed to get attached surface, hr > %#x.\n", hr); + hr = IDirectDrawSurface7_GetColorKey(tmp, > DDCKEY_SRCBLT, &color_key); + ok(hr == DDERR_NOCOLORKEY, "Got > unexpected hr %#x, i %u.\n", hr, i); + + > color_key.dwColorSpaceLowValue = 0x0000ff00; + > color_key.dwColorSpaceHighValue = 0x0000ff00; + hr = > IDirectDrawSurface7_SetColorKey(surface, DDCKEY_SRCBLT, > &color_key); + ok(SUCCEEDED(hr), "Failed to set color key, hr > %#x.\n", hr); + memset(&color_key, 0, sizeof(color_key)); + > hr = IDirectDrawSurface7_GetColorKey(surface, DDCKEY_SRCBLT, > &color_key); + ok(SUCCEEDED(hr), "Failed to get color key, hr > %#x.\n", hr); + ok(color_key.dwColorSpaceLowValue == 0x0000ff00, > "Got unexpected value 0x%08x.\n", + > color_key.dwColorSpaceLowValue); + > ok(color_key.dwColorSpaceHighValue == 0x0000ff00, "Got unexpected > value 0x%08x.\n", + color_key.dwColorSpaceHighValue); + > + IDirectDrawSurface_Release(tmp); Did you mean to call SetColorKey and GetColorKey on tmp instead of surface here? For the sake of completion it might be interesting to test SetColorKey on cube textures. 5 of the faces are attached to a root surface but aren't mipmap sublevels. (I guess it'll still return DDERR_NOTONMIPMAPSUBLEVEL.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSzpDjAAoJEN0/YqbEcdMwyl0P/3OHO0kK93dh6XdY1RU9IvNv BASe8YHhv1a6rRxYNGDzGoX5bsnefWLcqUnsWsGGjlxdA13BxAB4NCenaMecu49v d3egCH547Bd94K/9wqqlDxl+aEe0Hh86Ig9t0LNBuruNh1hNKTG9OdohzJBuX1VD TcVYRv6S8wEwM2Gb24RL8wN359497vn58G3fAVxK7PiK/edqxlDTg+6oi6P0/L+x HLGFlSVL9bgtxpwAUVh3i9SRsnA6iS07qPmSHOXdoCz/OhoY29Lx7HLFRCOgUbJS XAo00HKWP+qB4myqt3Iir9QgtiFLFZiyBBn0HQQEWGeRsDpZTazH/EMZrbUPhP03 f9AiW/r7XX5fOoRG5HBv7i/eXdOw6XexVLEyXb57sEilNJfBF3ux2wDw/E34AiGT wUTkgY2VwjgaxNl022qsFYz6fboORwbQm0VyvWzxbKw7326pdt6Y3Q2WTvPEQ5Rk JvlVJ8McRzkrYU5hXjRW1D7/2rVmV8z+xGGi6IU1JoS3PBWIYMKjUDRlFg0n+JQG UzLnJcnxm/js8Ah4R8MWje1v4cq3TlKnc7WrMIwNtu3Wmvwjo34s4A84xdVPneY/ jIqgUGFBOeH/XnK+FAdU+ZFuUn4k/ttVNOuSrPe5HsZxc1uxGnec5OtuZB8FTjFH EH0rn+AxEiyaGPON+4w6 =GtY2 -----END PGP SIGNATURE-----

2 2

Re: [PATCH 5/6] ddraw: Return DDERR_NOTONMIPMAPSUBLEVEL for ddraw_surface7_SetColorKey() on mipmap sub levels.
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4096 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [PATCH 4/5] devenum: Make CLSID_VideoCompressorCategory a special category.
by Alexandre Julliard 09 Jan '14

09 Jan '14

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/devenum/createdevenum.c | 1 + > 1 file changed, 1 insertion(+) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M dxdiagn.dll -p dxdiagn_test.exe.so provider && touch provider.ok provider.c:84: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:88: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:125: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:128: Tests skipped: IDxDiagProvider::Initialize failed make: *** [provider.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32/tests: Add broken for a WSALookupServiceBegin test in NT
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4089 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (174): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit sock) === sock.c:566: Test failed: oob_server (964): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 5/5] devenum: Added more strict CLSID_VideoCompressorCategory test.
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4077 Your paranoid android. === w2008s64 (64 bit devenum) === devenum.c:124: Test failed: mrle codec not found devenum.c:124: Test failed: mrle codec not found === w7pro64 (64 bit devenum) === devenum.c:124: Test failed: mrle codec not found devenum.c:124: Test failed: mrle codec not found

1 0

Re: [PATCH 2/5] ddraw/tests: Add some color key tests for complex surfaces.
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4071 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:1621: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:1621: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [PATCH] oleaut32: Mask out certain features on array copy
by Dmitry Timoshkov 08 Jan '14

08 Jan '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +/* features listed here are not propagated to newly created array or data copy > + created with SafeArrayCopy()/SafeArrayCopyData() */ > +static const USHORT ignored_copy_features = > + FADF_AUTO | > + FADF_STATIC | > + FADF_EMBEDDED | > + FADF_FIXEDSIZE | > + FADF_CREATEVECTOR | > + FADF_DATADELETED; ... > - (*ppsaOut)->fFeatures = psa->fFeatures & ~FADF_CREATEVECTOR; > + (*ppsaOut)->fFeatures = psa->fFeatures & ~(FADF_CREATEVECTOR|ignored_copy_features); ignored_copy_features already includes FADF_CREATEVECTOR. > --- a/dlls/oleaut32/tests/safearray.c > +++ b/dlls/oleaut32/tests/safearray.c > @@ -57,6 +57,14 @@ static BOOL has_i8; > /* Has INT_PTR/UINT_PTR type? */ > static BOOL has_int_ptr; > > +static const USHORT ignored_copy_features[] = > + { > + FADF_AUTO, > + FADF_STATIC, > + FADF_EMBEDDED, > + FADF_FIXEDSIZE > + }; Tested and actually ignored flags do not match. Either the test is not complete or the ignored list includes too much. -- Dmitry.

2 1

Re: [PATCH 2/5] ddraw/tests: Add some color key tests for complex surfaces.
by Stefan Dösinger 08 Jan '14

08 Jan '14

Am 08.01.2014 um 10:56 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > + for (i = 0; i < 7; ++i) > + { > + hr = IDirectDrawSurface_GetAttachedSurface(mipmap, &caps, &tmp); > + ok(SUCCEEDED(hr), "Failed to get attached surface, i %u, hr %#x.\n", i, hr); > + hr = IDirectDrawSurface_GetColorKey(tmp, DDCKEY_SRCBLT, &color_key); > + ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr %#x, i %u.\n", hr, i); > + IDirectDrawSurface_Release(mipmap); > + mipmap = tmp; > + } What is the 3D rendering and blitting behavior of the mipmap sublevels? Does an application have to set the color key on all surfaces to get proper color keying on a mipmapped texture, or do the sublevels use the color key from the root surface?

2 6

Re: dpnet: Add stubbed interface IDirectPlay8Server
by Michael Stefaniuc 08 Jan '14

08 Jan '14

Hello Alistair, On 01/08/2014 06:26 AM, Alistair Leslie-Hughes wrote: > Changelog: > dpnet: Add stubbed interface IDirectPlay8Server > diff --git a/dlls/dpnet/dpnet_private.h b/dlls/dpnet/dpnet_private.h > index 72012cd..5195d51 100644 > --- a/dlls/dpnet/dpnet_private.h > +++ b/dlls/dpnet/dpnet_private.h > @@ -37,6 +37,7 @@ typedef struct IDirectPlay8AddressImpl IDirectPlay8AddressImpl; > typedef struct IDirectPlay8LobbiedApplicationImpl IDirectPlay8LobbiedApplicationImpl; > typedef struct IDirectPlay8PeerImpl IDirectPlay8PeerImpl; > typedef struct IDirectPlay8ThreadPoolImpl IDirectPlay8ThreadPoolImpl; > +typedef struct IDirectPlay8ServerImpl IDirectPlay8ServerImpl; please add the struct directly to server.c as it is used only there. > +static ULONG WINAPI IDirectPlay8ServerImpl_AddRef(IDirectPlay8Server *iface) > +{ > + IDirectPlay8ServerImpl *This = impl_from_IDirectPlay8Server(iface); > + ULONG refCount = InterlockedIncrement(&This->ref); > + > + TRACE("(%p)->(ref before=%u)\n", This, refCount - 1); The standard to which Wine moves is to print the current refcount. See http://wiki.winehq.org/COMGuideline under "COM aggregation" for sample AddRef / Release functions. > +HRESULT DPNET_CreateDirectPlay8Server(LPCLASSFACTORY iface, LPUNKNOWN punkOuter, REFIID riid, LPVOID *ppobj) IClassFactory* and IUnknown* are much nicer. > +{ > + IDirectPlay8ServerImpl *server; > + > + TRACE("(%p, %s, %p)\n", punkOuter, debugstr_guid(riid), ppobj); > + > + server = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectPlay8ServerImpl)); > + if (!server) > + { > + *ppobj = NULL; > + return E_OUTOFMEMORY; > + } > + server->IDirectPlay8Server_iface.lpVtbl = &DirectPlay8ServerVtbl; > + server->ref = 1; > + > + *ppobj = (LPVOID*)&server->IDirectPlay8Server_iface; This will fail to fail for an unsupported riid. I have added the correct way to the COMGuideline wiki page. thanks bye michael

1 0

Re: dssenh/tests: Added Cylink Mek algorithm definition and crypto provider algorithm tests for dssenh.
by Alexandre Julliard 08 Jan '14

08 Jan '14

Marek Chmiel <kcmark(a)gmail.com> writes: > + while(GetLastError() != ERROR_NO_MORE_ITEMS) > + { > + SetLastError(0xdeadbeef); > + dataLen = sizeof(dataBuffer); > + > + result = CryptGetProvParam(hProv, PP_ENUMALGS_EX, dataBuffer, &dataLen, flag); > + ok(result || (!result && GetLastError() == ERROR_NO_MORE_ITEMS), > + "Failed to get parameter, got %x\n", GetLastError()); > + > + pointer = dataBuffer; > + algid = *(ALG_ID *)pointer; pointer += sizeof(ALG_ID); > + defaultLen = *(DWORD *)pointer; pointer += dwIncrement; It doesn't make sense to test last error before the first call, or to test the buffer contents on failure. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA (try 3)
by Nikolay Sivov 08 Jan '14

08 Jan '14

On 1/8/2014 12:47, Zhenbo Li wrote: > try 3: > Add 'static' in my code > I forgot to call test_SHGetPathFromIDListA() in try2 > Check GetLastError() as well > try 2: > Move code to string.c to avoid creating a new file. > Avoid malloc() and free(). > > I'm working on Bug 33750, so I'll add test cases for > SHGetPathFromIDListA gradually. > --- > dlls/shell32/tests/string.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > +static void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + char pszPath[MAX_PATH]; > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > + ok(GetLastError() == ERROR_PROC_NOT_FOUND, > + "Bad GetLastError = %d\n", GetLastError()); > +} > + You need to set last error to something like 0xdeadbeef, your test suggest that this call doesn't set it. I guess you're trying to test return value only, but it could be interesting to test what happens to path buffer too. P.S. please avoid psz* style prefixes in names.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA (try 3)
by Marvin 08 Jan '14

08 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4066 Your paranoid android. === wxppro (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === wvista (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w2008s64 (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w7pro64 (32 bit string) === string.c:107: Test failed: Bad GetLastError = 1114 === w2008s64 (64 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w7pro64 (64 bit string) === string.c:107: Test failed: Bad GetLastError = 1114

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Dmitry Timoshkov 08 Jan '14

08 Jan '14

Zhenbo Li <litimetal(a)gmail.com> wrote: > +void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + char pszPath[MAX_PATH]; > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > +} 1. the test should be 'static'. 2. who is supposed to call this test? 3. it would be ineteresting to see whether the tested API should set an error code or somehow indicate a reason of the failure. -- Dmitry.

2 1

WineHQ Downtime
by Jeremy Newman 07 Jan '14

07 Jan '14

Starting tomorrow at 10:00 CST we will be performing updates and maintenance to the WineHQ server. The service window should be around 2 hours at most. Various services will experience outages during this time frame. This will affect www.winehq.org, appdb.winehq.org, bugs.winehq.org, forum.winehq.org, source.winehq.org, mailing lists, and GIT. wiki.winehq.org will not be affected.

3 4

Re: [PATCH 1/5] wined3d: Check parameters directly in wined3d_surface_update_desc.
by Henri Verbeet 07 Jan '14

07 Jan '14

On 7 January 2014 13:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/wined3d/surface.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 2fca299..9155c6b 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -2810,15 +2810,17 @@ HRESULT CDECL wined3d_surface_update_desc(struct wined3d_surface *surface, > struct wined3d_device *device = surface->resource.device; > const struct wined3d_gl_info *gl_info = &device->adapter->gl_info; > const struct wined3d_format *format = wined3d_get_format(gl_info, format_id); > - UINT resource_size = wined3d_format_calculate_size(format, device->surface_alignment, width, height, 1); > BOOL create_dib = FALSE; > HRESULT hr; > > TRACE("surface %p, width %u, height %u, format %s, multisample_type %#x, multisample_quality %u.\n", > surface, width, height, debug_d3dformat(format_id), multisample_type, multisample_type); > > - if (!resource_size) > + if (!width || !height || !format) That's not quite equivalent. For example, a format like WINED3DFMT_NVDB has a zero format->byte_count.

2 1

Re: [2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Huw Davies 07 Jan '14

07 Jan '14

On Tue, Jan 07, 2014 at 02:33:32PM +0100, Ralf Habacker wrote: > @@ -1327,6 +1327,20 @@ BOOL WINAPI GetTextExtentExPointW( HDC hdc, LPCWSTR str, INT count, INT max_ext, > } > } > > + XFORM old; > + BOOL exclude_rotation = FALSE; > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) > + { > + GetWorldTransform( hdc, &old ); > + XFORM xf = old; > + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) > + { > + exclude_rotation = TRUE; > + removeRotationFromMatrix( &xf, NULL ); > + SetWorldTransform( hdc, &xf ); > + } > + } Does Windows really do this only in the same-scaled, non-sheared case? Huw.

1 0

Re: [2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Nikolay Sivov 07 Jan '14

07 Jan '14

On 1/7/2014 17:33, Ralf Habacker wrote: > This patch detects operational condition first and then removes > temporary rotation from the world transform. > Bug: http://bugs.winehq.org/show_bug.cgi?id=33190 > --- > dlls/gdi32/font.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > + XFORM old; > + BOOL exclude_rotation = FALSE; > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) > + { > + GetWorldTransform( hdc, &old ); > + XFORM xf = old; > + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) > + { > + exclude_rotation = TRUE; > + removeRotationFromMatrix( &xf, NULL ); > + SetWorldTransform( hdc, &xf ); > + } > + } > + Flag really means do we need to restore transform or not. > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED && exclude_rotation == TRUE ) > + { > + SetWorldTransform( hdc, &old ); > + } > + Doesn't look like you need to check a mode again.

1 0

Re: [1/4] gid32: Add matrix helper functions.
by Nikolay Sivov 07 Jan '14

07 Jan '14

On 1/7/2014 17:31, Ralf Habacker wrote: > Contains basic functions required by further patches > --- > dlls/gdi32/dibdrv/graphics.c | 49 > ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > That should be merged with a first patch that uses it. > +/* > + check matrix for condition > +*/ > +BOOL hasRotatedAndSameScaledMatrixOnly(XFORM *xform) > +{ > + return xform->eM11 == xform->eM22 && > + -xform->eM21 == xform->eM12; > +} > + Comment is telling nothing, 'xform' should be const probably. > + double determinant = 0; > + > + /* xform = xfrom-transposed * xform */ > + xform->eM11 = sqrt( xform->eM11 * xform->eM11 + xform->eM21 * xform->eM21 ); > + xform->eM22 = sqrt( xform->eM12 * xform->eM12 + xform->eM22 * xform->eM22 ); > + xform->eM12 = 0; > + xform->eM21 = 0; > + xform->eDx = 0; > + xform->eDy = 0; > + > + if ( rotation_and_translation == NULL ) > + return TRUE; > + > + determinant = xform->eM11 * xform->eM22; > + > + inverse_matrix_scale.eM11 = xform->eM22 / determinant; Is it possible to get 0 determinant here? Function never returns FALSE, so return value is useless. Also please follow function and variable naming conventions used in this file.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Nikolay Sivov 07 Jan '14

07 Jan '14

On 1/7/2014 16:08, Zhenbo Li wrote: > I'm working on Bug 33750, so I'll add test cases for > SHGetPathFromIDListA gradually. > --- > dlls/shell32/tests/pidl.c | 48 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 dlls/shell32/tests/pidl.c > Please use some existing file. > +void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + LPCSTR pszPath; > + > + pszPath = malloc(MAX_PATH); > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > + > + free((void *)pszPath); > +} > + You don't need to allocate it here, even if had to Heap* functions should be used.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Marvin 07 Jan '14

07 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4048 Your paranoid android. === wxppro (32 bit pidl) === No test summary line found === wvista (32 bit pidl) === No test summary line found === w2008s64 (32 bit pidl) === No test summary line found === w7pro64 (32 bit pidl) === No test summary line found === w2008s64 (64 bit pidl) === No test summary line found === w7pro64 (64 bit pidl) === No test summary line found

1 0

Re: user32/tests: Use BOOL type where appropriate
by Marvin 07 Jan '14

07 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4032 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000

1 0

Re: [2/2] ws2_32/tests: Show that the last WSACleanup must destroy sockets
by Marvin 06 Jan '14

06 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4029 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4220C0

1 0

Re: [1/2] ws2_32/tests: Add some FIONREAD tests
by Marvin 06 Jan '14

06 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4028 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (4bc): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

[PATCH] Add support for GNU/Hurd
by Svante Signell 06 Jan '14

06 Jan '14

Hi, Currently wine-1.6.1 FTBFS on Debian GNU/Hurd, see https://buildd.debian.org/status/fetch.php?pkg=wine&arch=hurd-i386&ver=1.6.… Attached is a patch enabling the build: - dlls/ntdll/directory.c: Define a character array on the heap of size 4096 instead of using PATH_MAX, which is not defined for GNU/Hurd. This approach was used in dlls/ntdll/file.c:server_get_unix_name() where an array of size 1024 was defined. In case this solution is not OK, a fixed size array on the stack could be used, or as a last resort adding #ifndef PATH_MAX; #define PATH_MAX 4096 to that file (not recommended, at least from a GNU/Hurd aspect). - libs/wine/ldt.c: Add LDT support for GNU/Hurd - dlls/ntdll/signal_i386.c: Add i386 signal handling support for GNU/Hurd Applications tested so far (slow to start) include cmd, hostname, clock, winemine, wineconsole, notepad, wordpad and explorer. This patch is sent upstream on recommendation by the Debian Wine maintainers, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733605 Thanks!

3 7

Re: strmbase: Store BasePinFuncTable inside Base*PinFuncTable structs.
by Aric Stewart 06 Jan '14

06 Jan '14

On 1/3/14, 10:08 AM, Jacek Caban wrote: > --- > dlls/amstream/mediastreamfilter.c | 15 +++++++-------- > dlls/qcap/avico.c | 32 ++++++++++++++------------------ > dlls/qcap/avimux.c | 32 ++++++++++++++------------------ > dlls/qcap/vfwcapture.c | 15 +++++++-------- > dlls/quartz/filesource.c | 15 +++++++-------- > dlls/quartz/parser.c | 15 +++++++-------- > dlls/strmbase/pin.c | 24 ++++++++++++------------ > dlls/strmbase/renderer.c | 17 ++++++++--------- > dlls/strmbase/transform.c | 30 ++++++++++++++---------------- > include/wine/strmbase.h | 7 +++++-- > 10 files changed, 95 insertions(+), 107 deletions(-) > Also just so you are aware, all the strmbase stuff is based off actual microsoft strmbase stuff for directshow http://msdn.microsoft.com/en-us/library/windows/desktop/dd318897%28v=vs.85%… Not that this patch specifically breaks that, I have not dug that much, but just so that you are aware of the base for the implementation. -aric

2 1

Re: [1/7] gdi32: Relax vertical face requirements.
by Dmitry Timoshkov 06 Jan '14

06 Jan '14

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -2148,6 +2148,9 @@ static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_ > #endif /* HAVE_CARBON_CARBON_H */ > > do { > + const DWORD DBCS_MASK = 0x3e0000; dlls/gdi32/font.c,GetFontLanguageInfo() defines DBCS_MASK as 0x3f0000, I'd guess that one of these places needs to be fixed. -- Dmitry.

2 1

Re: msvcp: Return if module is not loaded (Coverity)
by Piotr Caban 06 Jan '14

06 Jan '14

On 01/04/14 19:24, André Hentschel wrote: > 1147949 > --- > dlls/msvcp90/msvcp_main.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/dlls/msvcp90/msvcp_main.c b/dlls/msvcp90/msvcp_main.c > index 489aacb..d946f3b 100644 > --- a/dlls/msvcp90/msvcp_main.c > +++ b/dlls/msvcp90/msvcp_main.c > @@ -67,7 +67,14 @@ static void init_cxx_funcs(void) > { > HMODULE hmod = GetModuleHandleA( MSVCRT_NAME(_MSVCP_VER) ); > > - if (!hmod) FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > + if (!hmod) > + { > + FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > + MSVCRT_operator_new = NULL; > + MSVCRT_operator_delete = NULL; > + MSVCRT_set_new_handler = NULL; > + return; > + } If we want to handle GetModuleHandle failure we should probably fail to load msvcpXX.dll (I'm not sure if it may ever happen unless we forget to import proper msvcrXX dll in makefile).

1 0

Re: ws2_32: Fix FreeBSD compiling issue on ipx address structure
by Francois Gouget 06 Jan '14

06 Jan '14

On Sun, 5 Jan 2014, Bruno Jesus wrote: > Manually tested on PC-BSD which also shows the issue. I think it would even work to compare sipx_network and sipx_node in one go. There is already code that copies them that way in ws_sockaddr_ws2u(): memcpy(&uipx->sipx_network,wsipx->sa_netnum,sizeof(uipx->sipx_network)+sizeof(uipx->sipx_node)); So we could do (compiles but not tested): diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 0391554..a92c5c3 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1473,7 +1473,10 @@ static BOOL is_sockaddr_bound(const struct sockaddr *uaddr, int uaddrlen) { static const struct sockaddr_ipx emptyAddr; struct sockaddr_ipx *ipx = (struct sockaddr_ipx*) uaddr; - return ipx->sipx_port || ipx->sipx_network || memcmp(&ipx->sipx_node, &emptyAddr.sipx_node, sizeof(emptyAddr.sipx_node)); + + /* compare sipx_network and sipx_node in one go to ease portability */ + return ipx->sipx_port || + memcmp(&ipx->sipx_network, &emptyAddr.sipx_network, sizeof(emptyAddr.sipx_network) + sizeof(emptyAddr.sipx_node)); } #endif case AF_INET6: But your patch works too. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

1 0

Re: [PATCH] msvcp90: mark _invalid_parameter as noreturn (Coverity)
by Piotr Caban 06 Jan '14

06 Jan '14

On 01/04/14 18:25, Marcus Meissner wrote: > 1147947 Dereference after null check > > after not seeing that _invalid_parameter will not return, > so just mark the function as such, perhaps coverity then notices it. The function may return if application sets custom invalid parameter handler. I guess it shouldn't be marked as DECLSPEC_NORETURN. Probably all the places where it's used should be changed to return an error after calling _invalid_parameter.

1 0

Build fixes for wine-1.6.1 (FreeType2)
by David Naylor 06 Jan '14

06 Jan '14

Dear Wine-developers, On behalf of Gerald Pfeifer and the FreeBSD/Wine team I would like to report that wine-1.6.1 does not build against recent versions of FreeType2. This has been fixed in master in commit 67f9b6e3c5d2397446d39ab454f691c1ee46d2c0 by Alexandre Julliard. We would like to request this commit be back-ported to the stable branch. Regards, David P.S. I'm not on the mailing list, please CC me in related correspondence, thanks.

3 2

Re: Assorted spelling fixes
by Marvin 06 Jan '14

06 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4014 Your paranoid android. === wvista (32 bit render) === render.c:1276: Test failed: GetPosition failed: 00000001 === w7pro64 (64 bit render) === render.c:664: Test failed: Wait(event) after Stop gave 102

1 0

Re: DxDiag Demo Patch
by khuaja_lucky＠yahoo.com 05 Jan '14

05 Jan '14

Sent from my iPhone

1 0

Re: bcrypt: Added BCryptGenRandom stub
by Dmitry Timoshkov 05 Jan '14

05 Jan '14

Jascha Knack <jascha.knack(a)smail.inf.h-brs.de> wrote: > +NTSTATUS WINAPI BCryptGenRandom(BCRYPT_ALG_HANDLE hAlgorithm, PUCHAR > pbBuffer, > + ULONG cbBuffer, ULONG dwFlags) > +{ > + FIXME("%08x, %08x, %08x, %08x - stub\n", hAlgorithm, pbBuffer, > cbBuffer, dwFlags); > + > + return ERROR_CALL_NOT_IMPLEMENTED; > +} If the API is supposed to return NTSTATUS it can't return a win32 error code. Also some of the printf format specifiers should be %p. P.S. Your mailer has mangled the patch. -- Dmitry.

1 0

Re: d3d10core: Fix a typo
by Frédéric Delanoy 04 Jan '14

04 Jan '14

On Sat, Jan 4, 2014 at 4:33 PM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > What do you mean saying 'to group together' ? I mean typo fixes in dll_A and dll_B should be in the same patch. -- Frédéric Delanoy

1 0

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests
by Bruno Jesus 04 Jan '14

04 Jan '14

On Sat, Jan 4, 2014 at 3:25 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Please ignore this patch, I didn't see Erich was trying to get in his interface change notifications patches. They are specially useful for a complete implementation of WSASLookupService*, when they get commited I'll be able to create a more complete test. Best wishes, Bruno

1 0

Re: d3d10core: Fix a typo
by Frédéric Delanoy 04 Jan '14

04 Jan '14

You'd probably want to group together all those typo/spelling patches. They aren't generally susceptible to breaking things. -- Frédéric Delanoy

1 0

Re: comctl32: Add opening and closing brackets and remove spaces
by Dmitry Timoshkov 04 Jan '14

04 Jan '14

Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > --- a/dlls/comctl32/animate.c > +++ b/dlls/comctl32/animate.c > @@ -499,7 +499,7 @@ static BOOL ANIMATE_GetAviInfo(ANIMATE_INFO *infoPtr) > > if ((ckMainRIFF.ckid != FOURCC_RIFF) || > (ckMainRIFF.fccType != mmioFOURCC('A', 'V', 'I', ' '))) { > - WARN("Can't find 'AVI ' chunk\n"); > + WARN("Can't find 'AVI' chunk\n"); This change is wrong. -- Dmitry.

1 0

Re: [7/7] gdi32: Improve vertical writing metrics.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3982 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [6/7] gdi32/tests: Add tests for vertical writing metrics.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3981 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [5/7] gdi32: Fix ABC metrics for rotated font.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3980 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [4/7] gdi32/tests: Add more GetCharABCWidths tests for rotated font.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3979 Your paranoid android. === wxppro (32 bit font) === font.c:1330: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0

1 0

Re: [4/4] ws2_32/tests: Add some FIONREAD tests
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3976 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead

1 0

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3975 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 3)
by Dmitry Timoshkov 04 Jan '14

04 Jan '14

Zhenbo Li <litimetal(a)gmail.com> wrote: > + > + err = GetLastError(); > + ok ( handle != INVALID_HANDLE_VALUE, "FindFirstFile on %s failed\n", buffer2 ); > + ok ( !err , "FindFirstFile failed, Error number %d\n", err ); > + This block looks like an orphaned part of some removed test. -- Dmitry.

2 2

Question about test_RemoveDirectory()
by Zhenbo Li 04 Jan '14

04 Jan '14

Hello, I found that test_RemoveDirectory() is in dlls/kernel32/tests/file.c, while RemoveDirectoryA() and RemoveDirectoryW() are in dlls/kernel32/path.c I checked git log, and found that they came from commit ad9b79932410f7c, Reimplemented CreateDirectoryW and RemoveDirectoryW using ntdll functions. Should I move test_RemoveDirectory() to dlls/kernel32/tests/path.c? Thanks. -- Have a nice day! Zhenbo Li

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel