- wine-devel - winehq.org

Re: [PATCH 4/5] ddraw: Only set DDSCAPS_FRONTBUFFER on flippable surfaces.
by Marvin 04 Dec '13

04 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3619 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] wined3d: Temporarily remove surface PBO support.
by Henri Verbeet 04 Dec '13

04 Dec '13

On 24 November 2013 00:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The implementation is strange and fairly ineffective in doing what PBOs > are supposed to do - avoiding pipeline stalls and redundant copying. > Removing it will make restructuring surfaces easier and avoid temporary > regressions. It will be re-added later. Is there a good reason this can't just be fixed first?

2 7

Re: [PATCH 2/4] d3d9: Volume and cube textures do not support user memory.
by Henri Verbeet 04 Dec '13

04 Dec '13

On 4 December 2013 14:01, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (pool == D3DPOOL_SYSTEMMEM) > + { > + WARN("User memory is not allowed on volume textures.\n"); > + return D3DERR_INVALIDCALL; > + } > + else > + FIXME("Resource sharing not implemented, *shared_handle %p.\n", *shared_handle); > + } > The docs suggest the check should be "pool != D3DPOOL_DEFAULT". You can also drop the else-branch because you return.

1 0

Re: [PATCH 2/3] server: Implement an interface change notification object (rebased).
by Alexandre Julliard 04 Dec '13

04 Dec '13

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > +static void ifchange_poll_event( struct fd *fd, int event ) > +{ > + struct object *ifchange = get_fd_user( fd ); > + int r, unix_fd, wakeup = FALSE; > + char buffer[0x1000]; > + > + unix_fd = get_unix_fd( fd ); > + r = recv( unix_fd, buffer, sizeof(buffer), 0 ); > + if (r < 0) > + { > + fprintf(stderr,"ifchange_poll_event(): ifchange read failed!\n"); > + return; > + } > + else if (r != 0) > + { > +#if defined(NETLINK_ROUTE) > + struct nlmsghdr *nlh; > + > + nlh = (struct nlmsghdr*) buffer; > + if (NLMSG_OK(nlh, r) && (nlh->nlmsg_type == RTM_NEWADDR || nlh->nlmsg_type == RTM_DELADDR)) > + wakeup = TRUE; > +#endif > + } > + if (wakeup) > + ifchange_wake_up( ifchange, STATUS_SUCCESS ); > +} This needs more work. Also please try to better follow wineserver conventions everywhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: programs/xcopy: fix a typo in a comment
by Hugh McMaster 03 Dec '13

03 Dec '13

On Saturday, 30 November 2013 4:28 pm, Austin English wrote: > /* Microsoft's xcopy's usage implies that the date >- * format depends on the locale but that false. >+ * format depends on the locale but that is false. > * It is hardcoded to month-day-year > */ Hi Austin, It would be a good idea to fix the first line of the comment as well. Something like: "Usage of Microsoft's xcopy implies that the date" Hugh

3 2

FOSDEM '14 Call for Papers
by Jeremy White 02 Dec '13

02 Dec '13

Folks, There will a Wine devroom at FOSDEM '14 on Sunday, February 2, 2014. Last year we had a great time, and I think it was valuable for us to connect with the broader Free software community. I'd like to now invite you to submit proposals for talks. I'd really like to encourage everyone to think of something fun to share with the 5,000 geeks that will be swarming Brussels. If you have an topic you'd like to discuss, or an idea you want to present, please submit it to: https://penta.fosdem.org/submission You will create an account (if you don't have one from a previous year), and select the "Wine devroom" as the track. Please either submit for lengths of 30 or 60 minutes. The deadline for submissions is December 1st. I think it would be great if we branched out a bit, and submitting a crazy off the wall proposal will just burn churn a few electrons. So submit it! For further discussion, please follow up to wineconf(a)winehq.org. Cheers, Jeremy

1 1

Re: [PATCH 5/5] ddraw/tests: Unify the skip messages a bit.
by Marvin 02 Dec '13

02 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3603 Your paranoid android. === w864 (32 bit ddraw4) === ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4105: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057.

1 0

Re: [PATCH 4/5] ddraw/tests: Add some missing DestroyWindow() calls.
by Marvin 02 Dec '13

02 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3602 Your paranoid android. === w864 (32 bit ddraw4) === ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4106: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057.

1 0

Re: winex11.drv: Remove spaces in WARN and TRACE messages.
by Henri Verbeet 02 Dec '13

02 Dec '13

On 1 December 2013 19:18, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > - WARN( "X Input 2 not available\n" ); > + WARN( "XInput2 not available\n" ); The extension is actually called the "X Input Extension", so I think the existing messages are more correct.

1 0

Re: comctl32/tests: Better deal with the unsupported CreateWindowExW() case.
by Nikolay Sivov 02 Dec '13

02 Dec '13

On 12/1/2013 19:24, Francois Gouget wrote: > No matter why CreateWindowExW() fails, if we don't have an hwnd we have > to skip the tests. > --- > It doesn't look like we have to use *Ex version at all.

2 1

Re: mshtml: Avoid memory leaks (coverity)
by Jacek Caban 30 Nov '13

30 Nov '13

Hi Frédéric, On 11/30/13 15:16, Frédéric Delanoy wrote: > CID 1131417 > --- > dlls/mshtml/htmlbody.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c > index fcd8766..163f0ba 100644 > --- a/dlls/mshtml/htmlbody.c > +++ b/dlls/mshtml/htmlbody.c > @@ -648,7 +648,8 @@ static HRESULT WINAPI HTMLBodyElement_get_scroll(IHTMLBodyElement *iface, BSTR * > > if(!overflow || !*overflow) { > *p = NULL; > - return S_OK; > + hres = S_OK; > + goto cleanup; > }else if(!strcmpW(overflow, visibleW) || !strcmpW(overflow, autoW)) { > ret = autoW; > }else if(!strcmpW(overflow, scrollW)) { > @@ -658,11 +659,16 @@ static HRESULT WINAPI HTMLBodyElement_get_scroll(IHTMLBodyElement *iface, BSTR * > }else { > TRACE("Defaulting %s to NULL\n", debugstr_w(overflow)); > *p = NULL; > - return S_OK; > + hres = S_OK; > + goto cleanup; > } > > *p = SysAllocString(ret); > - return *p ? S_OK : E_OUTOFMEMORY; > + hres = *p ? S_OK : E_OUTOFMEMORY; > + > +cleanup: > + SysFreeString(overflow); > + return hres; > } > Good catch, but those gotos make the code more complicated that it needs to be. You may just remove early returns and free overflow before allocating the result. Jacek

1 0

Re: qmgr/tests: Skip tests on Windows instead of failing
by Nikolay Sivov 29 Nov '13

29 Nov '13

On 11/29/2013 23:12, André Hentschel wrote: > Some w2k and win7 machines... > --- > dlls/qmgr/tests/enum_files.c | 2 +- > dlls/qmgr/tests/file.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/qmgr/tests/enum_files.c b/dlls/qmgr/tests/enum_files.c > index 7e2ab1e..a77f1e7 100644 > --- a/dlls/qmgr/tests/enum_files.c > +++ b/dlls/qmgr/tests/enum_files.c > @@ -256,7 +256,7 @@ START_TEST(enum_files) > /* Keep state separate between tests. */ > if (!setup()) > { > - ok(0, "tests:%d: Unable to setup test\n", i); > + win_skip("tests:%d: Unable to setup test, skipping tests\n", i); > break; > } I guess it's just fails to create an manager instance, please add a copy of test_create_manager() for that. > +++ b/dlls/qmgr/tests/file.c > @@ -197,7 +197,7 @@ START_TEST(file) > /* Keep state separate between tests. */ > if (!setup()) > { > - ok(0, "tests:%d: Unable to setup test\n", i); > + win_skip("tests:%d: Unable to setup test, skipping tests\n", i); > break; > } > (*test)(); This one is different as file.c already skips everything if initial object creation fails. We need to know where setup() fails exactly.

1 0

Re: [PATCH 2/3] wined3d: Pass a struct wined3d_bo_address to read_from_framebuffer.
by Henri Verbeet 28 Nov '13

28 Nov '13

On 28 November 2013 10:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* Read the framebuffer back into the surface */ > -static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, UINT pitch) > +static void read_from_framebuffer(struct wined3d_surface *surface, > + const struct wined3d_bo_address *data, UINT pitch) It seems a bit silly to pass these as parameters when the only caller gets them from the surface.

2 2

Re: AUTHORS: Revert commit 5da31c8817293ff98b4defceb962f7d0fbc25829
by Austin English 28 Nov '13

28 Nov '13

On Nov 22, 2013 4:21 PM, "Tae Wong" <seotaewong40(a)gmail.com> wrote: > > You'll need to stop updating the AUTHORS list automatically. Why? > It's the command that GIT uses: > git revert 5da31c8817293ff98b4defceb962f7d0fbc25829 > > If you revert the commit, you'll be able to update it manually. There's no good reason to do this manually when git can do it automatically. If you see a problem with sorting, file a bug upstream with git. The lack of replies to this topic (that you've repeatedly sent, on different threads) should indicate that the patch was intentional and won't reverted. Cheers, Austin

3 3

Re: [PATCH 2/3] wined3d: Pass a struct wined3d_bo_address to read_from_framebuffer.
by Henri Verbeet 28 Nov '13

28 Nov '13

On 28 November 2013 10:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/wined3d/surface.c | 54 +++++++++++++++++++++----------------------------- > 1 file changed, 23 insertions(+), 31 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 744d6b9..e574956 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -3438,7 +3438,8 @@ HRESULT CDECL wined3d_surface_flip(struct wined3d_surface *surface, struct wined > } > > /* Read the framebuffer back into the surface */ > -static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, UINT pitch) > +static void read_from_framebuffer(struct wined3d_surface *surface, > + const struct wined3d_bo_address *data, UINT pitch) > { > struct wined3d_device *device = surface->resource.device; > const struct wined3d_gl_info *gl_info; > @@ -3489,7 +3490,7 @@ static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, U > /* In case of P8 render targets the index is stored in the alpha component */ > fmt = GL_ALPHA; > type = GL_UNSIGNED_BYTE; > - mem = dest; > + mem = data->addr; > bpp = surface->resource.format->byte_count; > } > else > @@ -3518,21 +3519,18 @@ static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, U > break; > > default: > - mem = dest; > + mem = data->addr; > fmt = surface->resource.format->glFormat; > type = surface->resource.format->glType; > bpp = surface->resource.format->byte_count; > } > > - if (surface->flags & SFLAG_PBO) > + if (data->buffer_object) > { > - GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, surface->pbo)); > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, data->buffer_object)); > checkGLcall("glBindBufferARB"); > if (mem) > - { > ERR("mem not null for pbo -- unexpected\n"); > - mem = NULL; > - } > } > > /* Save old pixel store pack state */ > @@ -3564,23 +3562,14 @@ static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, U > gl_info->gl_ops.gl.p_glPixelStorei(GL_PACK_SKIP_ROWS, skipRow); > checkGLcall("glPixelStorei"); > > - if (surface->flags & SFLAG_PBO) > + if (data->buffer_object && !srcIsUpsideDown) > { > - GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)); > - checkGLcall("glBindBufferARB"); > - > /* Check if we need to flip the image. If we need to flip use glMapBufferARB > * to get a pointer to it and perform the flipping in software. This is a lot > * faster than calling glReadPixels for each line. In case we want more speed > * we should rerender it flipped in a FBO and read the data back from the FBO. */ > - if (!srcIsUpsideDown) > - { > - GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, surface->pbo)); > - checkGLcall("glBindBufferARB"); > - > - mem = GL_EXTCALL(glMapBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, GL_READ_WRITE_ARB)); > - checkGLcall("glMapBufferARB"); > - } > + mem = GL_EXTCALL(glMapBufferARB(GL_PIXEL_PACK_BUFFER_ARB, GL_READ_WRITE_ARB)); > + checkGLcall("glMapBufferARB(GL_PIXEL_PACK_BUFFER_ARB, GL_READ_WRITE_ARB)"); > } > > /* TODO: Merge this with the palettization loop below for P8 targets */ > @@ -3611,15 +3600,19 @@ static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, U > bottom -= pitch; > } > HeapFree(GetProcessHeap(), 0, row); > + } > > - /* Unmap the temp PBO buffer */ > - if (surface->flags & SFLAG_PBO) > - { > - GL_EXTCALL(glUnmapBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB)); > - GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, 0)); > - } > + if (data->buffer_object) > + { > + if (!srcIsUpsideDown) > + GL_EXTCALL(glUnmapBufferARB(GL_PIXEL_PACK_BUFFER_ARB)); > + > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)); > + checkGLcall("glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)"); > } > > + context_release(context); > + > /* For P8 textures we need to perform an inverse palette lookup. This is > * done by searching for a palette index which matches the RGB value. > * Note this isn't guaranteed to work when there are multiple entries for > @@ -3657,7 +3650,7 @@ static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, U > && *green == pal[c].peGreen > && *blue == pal[c].peBlue) > { > - *((BYTE *) dest + y * width + x) = c; > + *((BYTE *)data->addr + y * width + x) = c; > break; > } > } > @@ -3665,8 +3658,6 @@ static void read_from_framebuffer(struct wined3d_surface *surface, void *dest, U > } > HeapFree(GetProcessHeap(), 0, mem); > } > - > - context_release(context); > } > > /* Read the framebuffer contents into a texture. Note that this function > @@ -5046,8 +5037,9 @@ static void surface_load_sysmem(struct wined3d_surface *surface, > > if (surface->flags & SFLAG_INDRAWABLE) > { > - read_from_framebuffer(surface, surface->resource.allocatedMemory, > - wined3d_surface_get_pitch(surface)); > + struct wined3d_bo_address data; > + surface_get_memory(surface, &data); > + read_from_framebuffer(surface, &data, wined3d_surface_get_pitch(surface)); > return; > } > > -- > 1.8.3.2 > > >

1 0

Re: [PATCH 3/6] wined3d: Move format conversion to surface_upload_data.
by Henri Verbeet 28 Nov '13

28 Nov '13

I'm not sure about this, why do we want this?

2 7

Wine Mono 4.5.2 Release
by Vincent Povirk 27 Nov '13

27 Nov '13

This is a small bugfix update because Andrew Eikum found a regression in upstream mono that I thought warranted it. As always, the msi can be installed in current Wine without any modification. Any testing before this gets into Wine would be appreciated. The source tarball is at https://sourceforge.net/projects/wine/files/Wine%20Mono/4.5.2/wine-mono-4.5… The binary is at https://sourceforge.net/projects/wine/files/Wine%20Mono/4.5.2/wine-mono-4.5… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 4.5.0: * Fixed CultureInfo.CurrentCultureInfo always returning InvariantCulture. (Andrew Eikum) * Fixed build on recent mingw versions that define __readfsdword. (Andrew Eikum) * Added the policy/v4.0 registry key to reflect support for .NET 4.

1 0

Re: winhttp/tests: Use BOOL type where appropriate
by Dmitry Timoshkov 27 Nov '13

27 Nov '13

Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- a/dlls/winhttp/tests/notification.c > +++ b/dlls/winhttp/tests/notification.c > @@ -44,9 +44,9 @@ struct notification > { > enum api function; /* api responsible for notification */ > unsigned int status; /* status received */ > - int todo; > - int ignore; > - int skipped_for_proxy; > + BOOL todo; > + BOOL ignore; > + BOOL skipped_for_proxy; Do you realize that BOOL is typedef'ed to int and therefore your patches do basically nothing? Is there any real reason behind these patches? -- Dmitry.

3 5

Re: Daemonizing wine (fix for issue #15462)
by Alexandre Julliard 27 Nov '13

27 Nov '13

Micha Nelissen <micha(a)neli.hopto.org> writes: > The patch creates a daemon.err logfile in the wine server dir > (/tmp/.wine-XXX/YYY/), where the output of wineserver.exe, > services.exe, and all other background processes go. I don't think that's a good idea. In the debugging case, you want all the traces to go to the same place, and when displaying errors, no user is ever going to see them in that file. Not to mention that the log file is going to grow endlessly. > I've removed the inheritance of stdin/stdout/stderr in > server/process.c (that took some time to find!) because in windows, > either you set bInheritHandles to true with CreateProcess and you > inherit stdin etc too, or you set it false, and you get nothing. So > this patch should also increase winapi compatibility. This should be a separate patch, with test cases. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: kernel32/tests: Add tests for job objects
by Marvin 27 Nov '13

27 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3566 Your paranoid android. === w7pro64 (32 bit process) === process.c:2193: Test failed: Unexpected completion event: 7, 000001FC, 00000AB0 process.c:2210: Test failed: Unexpected completion event: 4, 000001FC, 00000000 process.c:2211: Test failed: Unexpected completion event: 6, 000001FC, 00000934 process.c:2212: Test failed: Unexpected completion event: 6, 000001FC, 00000AB8 process.c:2281: Test failed: Unexpected completion event: 7, 000001FC, 00000AB8 process.c:2309: Test failed: Unexpected completion event: 4, 0000023C, 00000000 process.c:2310: Test failed: Unexpected completion event: 6, 000001FC, 00000AE8 process.c:2311: Test failed: Unexpected completion event: 6, 000001FC, 00000AF0

1 0

Re: libport: Add a finite() portability macro and use it.
by Alexandre Julliard 26 Nov '13

26 Nov '13

Francois Gouget <fgouget(a)free.fr> writes: > --- > > This fixes compilation on Solaris machines. It should probably be a function along the lines of isinf and isnan. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: change return value of SHFileOperation when deleting files
by Nikolay Sivov 26 Nov '13

26 Nov '13

On 11/26/2013 19:37, Zhenbo Li wrote: > This patch should fix bug 34324. Does it actually fix it? Cause a hack attached to this bug differs from what you're doing. Another thing to test is to try this application on Vista or later to see if it works. > When deleting files, I can't find a situation to return > ERROR_PATH_NOT_FOUND > --- > dlls/shell32/shlfileop.c | 2 +- > dlls/shell32/tests/shlfileop.c | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) >

3 3

Re: shell32: change return value of SHFileOperation when deleting files
by Qian Hong 26 Nov '13

26 Nov '13

Hi Zhenbo, thanks for the work. On Tue, Nov 26, 2013 at 11:37 PM, Zhenbo Li <litimetal(a)gmail.com> wrote: > When deleting files, I can't find a situation to return ERROR_PATH_NOT_FOUND Hmm, testing deleting an nonexistent path would be interesting too :) Try shfo.pFrom = "nonexistent\\nonexistent.txt\0"; and shfo.pFrom = "testdir2\0testdir2\0"; In these case, Windows may return ERROR_PATH_NOT_FOUND or ERROR_INVALID_LEVEL. -- Regards, Qian Hong - http://www.winehq.org

1 0

Re: [PATCH 4/4] wined3d: Don't store PBO pointers in allocatedMemory.
by Henri Verbeet 26 Nov '13

26 Nov '13

On 25 November 2013 23:41, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -817,6 +813,12 @@ static void surface_map(struct wined3d_surface *surface, const RECT *rect, DWORD > > context_release(context); > } > + else > + { > + ret = surface->resource.allocatedMemory; > + } > + > + return ret; > } > You don't really need an else-branch here, you can just return early in the PBO case.

1 0

Re: [PATCH 6/6] qcap: Fix Avi Mux output pin Connect implementation
by Marvin 26 Nov '13

26 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3550 Your paranoid android. === w8 (32 bit qcap) === qcap.c:1293: Test failed: ReceiveConnection returned 80040200 qcap.c:1296: Test failed: ConnectedTo returned 80040209 qcap.c:1297: Test failed: incorrect pin: 00000000, expected 0023FC68 qcap.c:1315: Test failed: expected Reconnect === w864 (32 bit qcap) === qcap.c:1293: Test failed: ReceiveConnection returned 80040200 qcap.c:1296: Test failed: ConnectedTo returned 80040209 qcap.c:1297: Test failed: incorrect pin: 00000000, expected 0028FC58 qcap.c:1315: Test failed: expected Reconnect === w864 (64 bit qcap) === qcap.c:1293: Test failed: ReceiveConnection returned 80040200 qcap.c:1296: Test failed: ConnectedTo returned 80040209 qcap.c:1297: Test failed: incorrect pin: 0000000000000000, expected 000000000023FB30 qcap.c:1315: Test failed: expected Reconnect

1 0

Re: [PATCH 5/6] qcap: Add helper to initalize test_filter structure
by Marvin 26 Nov '13

26 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3549 Your paranoid android. === w8 (32 bit qcap) === qcap.c:1162: Test failed: ReceiveConnection returned 80040200 qcap.c:1165: Test failed: ConnectedTo returned 80040209 qcap.c:1166: Test failed: incorrect pin: 00000000, expected 0023FD64 === w864 (32 bit qcap) === qcap.c:1162: Test failed: ReceiveConnection returned 80040200 qcap.c:1165: Test failed: ConnectedTo returned 80040209 qcap.c:1166: Test failed: incorrect pin: 00000000, expected 0028FD54 === w864 (64 bit qcap) === qcap.c:1162: Test failed: ReceiveConnection returned 80040200 qcap.c:1165: Test failed: ConnectedTo returned 80040209 qcap.c:1166: Test failed: incorrect pin: 0000000000000000, expected 000000000023FB70

1 0

Re: [PATCH 4/6] qcap: Constify vtables in Avi Mux tests
by Marvin 26 Nov '13

26 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3548 Your paranoid android. === w8 (32 bit qcap) === qcap.c:1149: Test failed: ReceiveConnection returned 80040200 qcap.c:1152: Test failed: ConnectedTo returned 80040209 qcap.c:1153: Test failed: incorrect pin: 00000000, expected 0023FD64 === w864 (32 bit qcap) === qcap.c:1149: Test failed: ReceiveConnection returned 80040200 qcap.c:1152: Test failed: ConnectedTo returned 80040209 qcap.c:1153: Test failed: incorrect pin: 00000000, expected 0028FD54 === w864 (64 bit qcap) === qcap.c:1149: Test failed: ReceiveConnection returned 80040200 qcap.c:1152: Test failed: ConnectedTo returned 80040209 qcap.c:1153: Test failed: incorrect pin: 0000000000000000, expected 000000000023FB60

1 0

Re: [PATCH 3/6] qcap: Add Avi Mux input pin ReceiveConnection test
by Marvin 26 Nov '13

26 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3547 Your paranoid android. === w8 (32 bit qcap) === qcap.c:1149: Test failed: ReceiveConnection returned 80040200 qcap.c:1152: Test failed: ConnectedTo returned 80040209 qcap.c:1153: Test failed: incorrect pin: 00000000, expected 0023FD64 === w864 (32 bit qcap) === qcap.c:1149: Test failed: ReceiveConnection returned 80040200 qcap.c:1152: Test failed: ConnectedTo returned 80040209 qcap.c:1153: Test failed: incorrect pin: 00000000, expected 0028FD54 === w864 (64 bit qcap) === qcap.c:1149: Test failed: ReceiveConnection returned 80040200 qcap.c:1152: Test failed: ConnectedTo returned 80040209 qcap.c:1153: Test failed: incorrect pin: 0000000000000000, expected 000000000023FB60

1 0

Re: [2/4] wininet: Reset data stream for existing request connections. (try 4)
by Marvin 25 Nov '13

25 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3543 Your paranoid android. === w2008s64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0

1 0

Re: [1/4] wininet/tests: Test successive HttpSendRequest calls. (try 4)
by Marvin 25 Nov '13

25 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3542 Your paranoid android. === w2008s64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0

1 0

Re: First try to sync translations with Transifex.com
by Francois Gouget 25 Nov '13

25 Nov '13

The attachment seems to have been mangled: when I looked at it here I only got question marks in the translations. So unless the mangling only happened here, that would be one reason why the patch has not been applied. Also, although the translation comes from Transifex.com, it looks like you're the only author behind the changes in that patch, i.e. there's presumably no copyright attribution issue. That may be worth noting in the patch submission. Could you resubmit your patch? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

2 1

Re: [PATCH 3/5] wined3d: Get rid of surface_set_dirty().
by Stefan Dösinger 25 Nov '13

25 Nov '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-11-25 12:31, schrieb Henri Verbeet: > static void texture2d_sub_resource_add_dirty_region(struct > wined3d_resource *sub_resource, const struct wined3d_box > *dirty_region) { - > surface_set_dirty(surface_from_resource(sub_resource)); + struct > wined3d_surface *surface = surface_from_resource(sub_resource); + + > surface_load_location(surface, SFLAG_INSYSMEM); + > surface_invalidate_location(surface, ~SFLAG_INSYSMEM); } Why not something like if (surface->flags & SFLAG_INSYSMEM) surface_invalidate_location(surface, ~SFLAG_INSYSMEM); If the surface doesn't have SFLAG_INSYSMEM set already downloading texture / framebuffer data to sysmem and re-uploading it won't do anything. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSk0bMAAoJEN0/YqbEcdMw1rkP/R4WwqON6LvqMeZo1p37QJnA FmSC16ChtjbraQEJU9BkAbFZJCn1U8jiEybeUl3aayf3T5/OL+tk1eAbuUovuHtf LnOgCL8gHxUitao9kwPgM5gO4gwzo4IfT/kHKZ9/gu1FxqvHZGk/5khgXU67mAJ0 pp3SOhWPTbWu23k/ld6CQvp47DcFbEWoSn3n+20npv2OYGvmcUgVumW8EZIHhN8g EFou2wEKVoeEVyaPZzo85Cauv/nwyvwzJgZAgnRj5cokOu0AEpitf8jTqp2mXq6E V0ozMW5X40l6GkmrsVbHYoEhD6l+cX3Mf30b3WttHUrSd2XHDFqUHs8yONK/KxsV 7VT4zsh8vhWSqQFLp3e7ygNiryojHTBy9gC0eC5ahK9bbjkPpvHIrbj9+sHh58rP GXwAsLcxBLS0FofB2tk6zOYMILhRKWX6PhlldvsZVqvIN0mdAR/NTMoOyre7kxGf pCt/o8yXQZY/ujq3ZoKUXSjzFcV2ilhJq1EoiixCXR+X23Ge3s5WDfnPPe8QWeIZ Bl1wfVHtl9PQPL8Q5kb2g9xr572+J+HPLthT1kz73jHZ6VKSE3xN/c0vW3zzdfaJ OZRWfzmPOcAk+RqQUD3Ko2T7j/voLUH9sU3MD4FtPLfKKsOne4OMstt4VIQ/Qe5k tpOd6QkmBeS0Wq4mHywu =MNOz -----END PGP SIGNATURE-----

2 4

Re: [website] Portuguese translation for release 1.7.7
by Bruno Jesus 25 Nov '13

25 Nov '13

2013/11/25 Lucas Zawacki <lfzawacki(a)gmail.com>: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > --- > news/pt/2013112201.xml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 news/pt/2013112201.xml > > diff --git a/news/pt/2013112201.xml b/news/pt/2013112201.xml > new file mode 100644 > index 0000000..3fbff21 > --- /dev/null > +++ b/news/pt/2013112201.xml > @@ -0,0 +1,15 @@ > +<news> > +<date>22 de Novembro de 2013</date> > +<title>Wine 1.7.7 lançado</title> > +<body> > + A versão de desenvolvimento 1.7.7 já está disponível agora. > + <a href="{$root}/announce/1.7.7">Novidades</a> desta versão: > +<ul> > + <li>Suporte a configuração de comportilhamente remote usando a biblioteca NetAPI do Samba.</li> The word "remote" was not translated. > + <li>Suporte a múltiplos layouts de teclado no driver de Mac.</li> > + <li>Melhor suporte a uso embutido com XEMBED.</li> > + <li>Suporte a arrays em VBScript.</li> > + <li>Várias correções de bugs.</li> > +O código fonte está <a href="http://prdownloads.sourceforge.net/wine/wine-1.7.7.tar.bz2">disponível agora</a>. > +Pacotes binários estão em processo de construção e irão aparecer em breve em suas respectivas <a href="{$root}/download">sessões da área de downloads</a>. > +</body></news> > -- > 1.7.10.4 Best wishes, Bruno

1 0

Re: mshtml: Ignore QI(&IID_IWebBrowserPriv2IE8XP) calls.
by Marvin 25 Nov '13

25 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3537 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found === w8 (32 bit htmldoc) === htmldoc.c:2872: Test failed: unexpected command 74

1 0

Re: [PATCH 2/5] qmgr: Implement IBackgroundCopyJob::GetDescription()
by Dmitry Timoshkov 25 Nov '13

25 Nov '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static HRESULT return_strval(const WCHAR *str, WCHAR **ret) > +{ > + int len; > + > + if (!ret) return E_INVALIDARG; > + > + len = strlenW(str); > + *ret = CoTaskMemAlloc((len+1)*sizeof(WCHAR)); > + if (!*ret) return E_OUTOFMEMORY; > + > + if (len) > + strcpyW(*ret, str); > + else > + **ret = 0; > + return S_OK; > +} > + > static inline BackgroundCopyJobImpl *impl_from_IBackgroundCopyJob2(IBackgroundCopyJob2 *iface) > { > return CONTAINING_RECORD(iface, BackgroundCopyJobImpl, IBackgroundCopyJob2_iface); > @@ -313,17 +330,10 @@ static HRESULT WINAPI BITS_IBackgroundCopyJob_GetDisplayName( > LPWSTR *pVal) > { > BackgroundCopyJobImpl *This = impl_from_IBackgroundCopyJob2(iface); > - int n; > > - if (!pVal) > - return E_INVALIDARG; > + TRACE("(%p)->(%p)\n", This, pVal); > > - n = (strlenW(This->displayName) + 1) * sizeof **pVal; > - *pVal = CoTaskMemAlloc(n); > - if (*pVal == NULL) > - return E_OUTOFMEMORY; > - memcpy(*pVal, This->displayName, n); > - return S_OK; > + return return_strval(This->displayName, pVal); > } What is the reason of changing pVal type from LPWSTR* to WCHAR** in the helper? Leaving would LPWSTR* make it more clear IMO what the helper is supposed to do and would simplify dereferencing logic a bit. Also moving the parameter checks from the callers to helper doesn't look justified IMO. -- Dmitry.

2 1

Re: quartz/tests: Add tests for IVMRMonitorConfig and IVMRMonitorConfig9 interface (try 2)
by Nikolay Sivov 25 Nov '13

25 Nov '13

On 11/25/2013 10:23, Sebastian Lackner wrote: > + hr = CoCreateInstance(&CLSID_VideoRenderer, NULL, CLSCTX_INPROC_SERVER, > + &IID_IUnknown, (LPVOID*)&pVideoRenderer); > + ok(hr != S_OK || pVideoRenderer != NULL, "CoCreateInstance returned S_OK, but pVideoRenderer is NULL.\n"); > + if (hr != S_OK || !pVideoRenderer) > + { > + skip("VideoRenderer is not available, skipping QI test.\n"); > + return; > + } > + > QI_SUCCEED(pVideoRenderer, IID_IBaseFilter, pBaseFilter); > RELEASE_EXPECT(pBaseFilter, 1); It's enough to test for return value, also if wine supports this class this should be win_skip(). What's a point of separate QI here? You could CoCreateInstance with IID_IBaseFilter. > + hr = IUnknown_QueryInterface(pVMR7, &IID_IVMRMonitorConfig, (LPVOID*)&pMonitorConfig); > + ok(hr == S_OK, "IUnknown_QueryInterface returned %x.\n", hr); > + ok(pMonitorConfig != NULL, "pMonitorConfig is NULL.\n"); > + if (!pMonitorConfig) goto out; Is it really possible to fail here? > + ok(info[numdev].guid.pGUID != &info[numdev].guid.GUID || memcmp(&info[numdev].guid.GUID, &max_guid, sizeof(max_guid)) != 0, > + "GetAvailableMonitors returned info[%d].GUID = {FFFFFFFF-FFFF-FFFF-FFFF-FFFFFFFFFFFF}, expected any other value.\n", numdev); It's shorter to just print resulting guid. > + /* check that result is filled out, we do not check if the values actually make any sense */ > + while (numdev--) > + { > + ok(info[numdev].uDevID != (UINT)-1, > + "GetAvailableMonitors returned info[%d].uDevID = -1, expected != -1.\n", numdev); > + ok(memcmp(&info[numdev].rcMonitor, &max_rect, sizeof(max_rect)) != 0, > + "GetAvailableMonitors returned info[%d].rcMonitor = {-1, -1, -1, -1}, expected any other value.\n", numdev); > + ok(info[numdev].hMon != (HMONITOR)0 && info[numdev].hMon != (HMONITOR)-1, > + "GetAvailableMonitors returned info[%d].hMon = %p, expected != 0 and != -1.\n", numdev, info[numdev].hMon); > + ok(info[numdev].dwFlags != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwFlags = -1, expected != -1.\n", numdev); > + ok(info[numdev].szDevice[0] != 0 && info[numdev].szDevice[0] != (WCHAR)-1, > + "GetAvailableMonitors returned info[%d].szDevice[0] = %d, expected != 0 and != -1.\n", numdev, info[numdev].szDevice[0]); > + todo_wine ok(info[numdev].szDescription[0] != 0 && info[numdev].szDescription[0] != (WCHAR)-1, > + "GetAvailableMonitors returned info[%d].szDescription[0] = %d, expected != 0 and != -1.\n", numdev, info[numdev].szDescription[0]); > + ok(info[numdev].dwVendorId != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwVendorId = -1, expected != -1.\n", numdev); > + ok(info[numdev].dwDeviceId != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwDeviceId = -1, expected != -1.\n", numdev); > + ok(info[numdev].dwSubSysId != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwSubSysId = -1, expected != -1.\n", numdev); > + ok(info[numdev].dwRevision != (DWORD)-1, > + "GetAvailableMonitors returned info[%d].dwRevision = -1, expected != -1.\n", numdev); > + } Personally I don't like this, I think this should be more explicit - set fields separately to some invalid value that shouldn't happen and check it back. For example for string field it makes no sense setting it to -1 if it's always filled.

1 0

Re: vbscript: Added support for VT_BYREF|VT_VARIANT to to_int.
by Marvin 22 Nov '13

22 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3510 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [2/3] wininet: Reset data stream for existing request connections.
by Marvin 22 Nov '13

22 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3506 Your paranoid android. === w2008s64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0

1 0

Re: [1/3] wininet/tests: Test successive HttpSendRequest calls.
by Marvin 22 Nov '13

22 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3505 Your paranoid android. === w7pro64 (32 bit http) === http.c:4450: Test failed: HttpSendRequest failed: 12057 http.c:4455: Test failed: expected secure flag to be set === w2008s64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3615: Test failed: HttpQueryInfo failed 0

1 0

Re: msvcrt: return wall-clock time from clock()
by Alexandre Julliard 22 Nov '13

22 Nov '13

Daniel Lehman <dlehman(a)esri.com> writes: > @@ -709,19 +711,26 @@ int CDECL _wstrtime_s(MSVCRT_wchar_t* time, MSVCRT_size_t size) > */ > MSVCRT_clock_t CDECL MSVCRT_clock(void) > { > - FILETIME ftc, fte, ftk, ftu; > - ULONGLONG utime, ktime; > - > - MSVCRT_clock_t clock; > + static LONGLONG start_time; > + LONGLONG current_time; > + struct timeval now; > > - GetProcessTimes(GetCurrentProcess(), &ftc, &fte, &ftk, &ftu); > + if(!start_time) { > + KERNEL_USER_TIMES pti; > > - ktime = ((ULONGLONG)ftk.dwHighDateTime << 32) | ftk.dwLowDateTime; > - utime = ((ULONGLONG)ftu.dwHighDateTime << 32) | ftu.dwLowDateTime; > + /* while Linux's clock returns user time, Windows' clock > + * returns wall-clock time from process start. cache the > + * process start time since it won't change and to avoid > + * wineserver round-trip overhead */ > + if(NtQueryInformationProcess(GetCurrentProcess(), ProcessTimes, &pti, sizeof(pti), NULL)) > + return -1; > + start_time = pti.CreateTime.QuadPart; > + } > > - clock = (utime + ktime) / (TICKSPERSEC / MSVCRT_CLOCKS_PER_SEC); > + gettimeofday(&now, NULL); > + current_time = (LONGLONG)now.tv_sec * TICKSPERSEC + now.tv_usec * 10 + TICKS_1601_TO_1970; You should be using Windows APIs for this, not gettimeofday. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 3
by Henri Verbeet 22 Nov '13

22 Nov '13

Stefan already mentioned this, although perhaps not quite as explicit, but new ddraw tests need to go to ddraw1-7.c. In this specific case, the best option is probably to first move SizeTest() over to ddraw1-7.c (and rename it to test_surface_size(), fix minor style issues etc.), and then add the new tests after that.

1 0

Re: gdiplus: Implement GdipCreateRegionRgnData. Take 2.
by Alexandre Julliard 22 Nov '13

22 Nov '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the patch follows Windows behaviour by refusing to create > an empty path in a region, and marks the test as broken when some Windows > versions fail to properly clear an aligned DWORD. > --- > dlls/gdiplus/region.c | 219 ++++++++++++++++++++++++++++++++++++++++---- > dlls/gdiplus/tests/region.c | 65 +++++++++++++ > 2 files changed, 266 insertions(+), 18 deletions(-) > > diff --git a/dlls/gdiplus/region.c b/dlls/gdiplus/region.c > index 832ce69..bc625f5 100644 > --- a/dlls/gdiplus/region.c > +++ b/dlls/gdiplus/region.c > @@ -76,6 +76,28 @@ WINE_DEFAULT_DEBUG_CHANNEL(gdiplus); > #define FLAGS_NOFLAGS 0x0 > #define FLAGS_INTPATH 0x4000 > > +struct _memory_buffer > +{ > + const BYTE *buffer; > + INT size, pos; > +}; > + > +struct _region_header > +{ > + DWORD size; > + DWORD checksum; > + DWORD magic; > + DWORD num_children; > +}; > + > +struct _path_header > +{ > + DWORD size; > + DWORD magic; > + DWORD count; > + DWORD flags; > +}; There's no need to add leading underscores, it's obvious that these are not Windows types. -- Alexandre Julliard julliard(a)winehq.org

4 10

__wine_spec_nt_header: relocation truncated to fit: R_386_PC16 against undefined symbol
by Gerald Pfeifer 22 Nov '13

22 Nov '13

My last two nightly boostraps on FreeBSD have started to fail as follows: ../../tools/winegcc/winegcc -B../../tools/winebuild --sysroot=../.. -fasynchronous-unwind-tables -shared ./sound.drv16.spec -m16 -Wb,--main-module,winmm.dll sound.o -o sound.drv16.so -lwine ../../libs/port/libwine_port.a -L/home/gerald/10-i386/lib sound.drv16-5l5JpE.spec.o: In function `__wine_spec_nt_header': (.data+0x48c): relocation truncated to fit: R_386_PC16 against undefined symbol `.L__wine_spec_callfrom16_p_long_' collect2: error: ld returned 1 exit status winegcc: /home/gerald/gcc-ref10-i386/bin/gcc failed gmake: *** [sound.drv16.so] Error 2 Originally I thought this was the top of tree nightly GCC builds I am using, but today I also go it with GCC 4.8.3 20131121 (prerelease). Any ideas what might be going on here? Any tips how to best debug this? Gerald

1 0

Re: mscoree: Implement IMetahostPolicy GetRequestedRuntime
by Vincent Povirk 21 Nov '13

21 Nov '13

+ else if(pwzBinary && lstrlenW(pwzBinary) > 0) Did you really need the check for an empty string? This is making me wonder if my comment on bugzilla was wrong, and get_runtime_info should treat an empty string the same as NULL.

1 0

Re: wininet: Reading past end-of-file in chunked mode returns success.
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3497 Your paranoid android. === w2008s64 (64 bit http) === http.c:3525: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3525: Test failed: HttpQueryInfo failed 0

1 0

Re: xcopy: Add tests to show that the /D option only accepts dates in the m-d-y format.
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3495 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: [2/3] wininet: Reset data stream for existing request connections.
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3494 Your paranoid android. === w2008s64 (64 bit http) === http.c:3610: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3610: Test failed: HttpQueryInfo failed 0

1 0

Re: [1/3] wininet/tests: Test successive HttpSendRequest calls. (try 2)
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3493 Your paranoid android. === w2008s64 (64 bit http) === http.c:3610: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3610: Test failed: HttpQueryInfo failed 0

1 0

Re: po: xcopy expects a date in the French locale format for the /D option.
by Francois Gouget 21 Nov '13

21 Nov '13

On Thu, 21 Nov 2013, Francois Gouget wrote: > --- > > Of course Wine does not yet implement the /D option but when it does it > will have to match the Windows implementation so the documentation > might as well be correct from the start. Please ignore this patch. On Windows XP and 7 alike Microsoft's xcopy does say: | /D:j-m-a Copie les fichiers modifiés à partir de la date spécifiée But on both systems it refuses a date of 21-11-2013 but accepts 11-21-2013. So once more the Microsoft documentation is wrong. c:\Users\win7admin\Documents> xcopy /D:21-11-2013 *.* tmp Paramètre non valide - /D:21-11-2013 c:\Users\win7admin\Documents> xcopy /D:21-11-2013 *.* tmp c:foo 1 fichier(s) copié(s) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If it stinks, it's chemistry. If it moves, it's biology. If it does not work, it's computer science.

1 0

Re: [PATCH 2/2] winemac: Add support for a DisableWindowDecorations registry setting.
by Alexandre Julliard 21 Nov '13

21 Nov '13

Ken Thomases <ken(a)codeweavers.com> writes: > @@ -166,6 +167,9 @@ static void setup_options(void) > if (!get_config_key(hkey, appkey, "AllowSoftwareRendering", buffer, sizeof(buffer))) > allow_software_rendering = IS_OPTION_TRUE(buffer[0]); > > + if (!get_config_key(hkey, appkey, "DisableWindowDecorations", buffer, sizeof(buffer))) > + disable_window_decorations = IS_OPTION_TRUE(buffer[0]); > + Disable-style options should be avoided, the double negatives are confusing for users. Also using the same option name as the X11 driver for the same feature may be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel