- wine-devel - winehq.org

Re: [2/3] wininet: Reset data stream for existing request connections.
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3486 Your paranoid android. === wxppro (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === wvista (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w2008s64 (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w7pro64 (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w8 (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w864 (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w2008s64 (64 bit http) === http.c:3606: Test failed: HttpQueryInfo failed 0 http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w7pro64 (64 bit http) === http.c:3606: Test failed: HttpQueryInfo failed 0 http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w864 (64 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT)

1 0

Re: [1/3] wininet/tests: Test successive HttpSendRequest calls.
by Marvin 21 Nov '13

21 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3485 Your paranoid android. === wxppro (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === wvista (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w2008s64 (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w7pro64 (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w8 (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w864 (32 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w2008s64 (64 bit http) === http.c:3606: Test failed: HttpQueryInfo failed 0 http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w7pro64 (64 bit http) === http.c:3606: Test failed: HttpQueryInfo failed 0 http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT) === w864 (64 bit http) === http.c:318: Test failed: unexpected status 320 (INTERNET_STATUS_COOKIE_SENT)

1 0

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications (resend).
by Marvin 20 Nov '13

20 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3480 Your paranoid android. === wxppro (32 bit sock) === sock.c:520: Test failed: oob_server (174): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB91B2 === w2008s64 (32 bit sock) === sock.c:520: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 757C9799 === w7pro64 (32 bit sock) === sock.c:529: Test failed: oob_server (96c): not at the OOB mark: 1 === w864 (32 bit sock) === sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1748: Test failed: getservbyname: winsock resized servent buffer when not necessary sock.c:1748: Test failed: getservbyname: winsock resized servent buffer when not necessary === w2008s64 (64 bit sock) === sock.c:510: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:520: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 5/5] qcap: Add AVI Mux QueryInterface tests
by Marvin 20 Nov '13

20 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3479 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 6/6] winemac: Actually set the system's keyboard layout.
by Ken Thomases 20 Nov '13

20 Nov '13

On Nov 20, 2013, at 9:30 AM, Huw Davies wrote: > --- > dlls/winemac.drv/cocoa_app.m | 11 ++++++ > dlls/winemac.drv/keyboard.c | 80 +++++++++-------------------------------- > dlls/winemac.drv/macdrv_cocoa.h | 1 + > 3 files changed, 29 insertions(+), 63 deletions(-) > > <0006-winemac-Actually-set-the-system-s-keyboard-layout.patch> Series looks good to me. -Ken

1 0

Re: mscoree: Attempt to load the assembly from the application directory (try 3)
by Vincent Povirk 20 Nov '13

20 Nov '13

Looks good to me.

1 0

Re: [PATCH 5/5] d3d8/tests: Add a test for AddDirtyRect.
by Marvin 20 Nov '13

20 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3472 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Add a test for AddDirtyRect.
by Marvin 20 Nov '13

20 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3471 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ws2_32/tests: Mark the out of bound results we don't want to support as broken
by Marvin 19 Nov '13

19 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3467 Your paranoid android. === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 757C9799 === w864 (64 bit sock) === sock.c:1741: Test failed: sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1748: Test failed: getservbyname: winsock resized servent buffer when not necessary

1 0

Re: shell32/tests: delete a nonexistent file in an existent dir or a nonexistent dir (try 2)
by Lauri Kenttä 19 Nov '13

19 Nov '13

On 2013-11-19 03:17, Zhenbo Li wrote: > + broken(ret == 0x402), /* XP */ > + "Expected 1027 or DE_INVALIDFILES, got %d\n", ret); Looks like you accidentally changed this one to 1027 instead of 0x402. -- Lauri Kenttä Reply-To: wine-devel(a)winehq.org

2 1

AUTHORS: Revert commit 5da31c8817293ff98b4defceb962f7d0fbc25829 (Was: How to undo authors list generated automatically.)
by Tae Wong 19 Nov '13

19 Nov '13

You want to revert the commit 5da31c8817293ff98b4defceb962f7d0fbc25829. Quintana said that it's a suggestion for it. Some Portuguese last names sorted under first instead of second element! See blob e69040d889c1748d538f1198f6c85b97f55418b5. Araujo Chaves, Pedro, Jr Arcoverde da Rocha, Augusto Castro Lopo, Erik de Example of Portuguese last names sorted by the second element: Chaves, Pedro Araujo, Jr Lopo, Erik de Castro Rocha, Augusto Arcoverde da

1 1

Re: shell32/tests: Change Dec to Hex
by Lauri Kenttä 19 Nov '13

19 Nov '13

On 2013-11-19 18:03, Zhenbo Li wrote: > + "Expected 0x402 or ERROR_FILE_NOT_FOUND, got %d\n", retval); You should probably change the %d to %x, too. On the other hand, I don't see any need for your patch whatsoever. Maybe you should explain yourself. -- Lauri Kenttä

4 3

Re: [2/2] quartz/tests: Add tests for IVMRMonitorConfig and IVMRMonitorConfig9 interface
by Alexandre Julliard 19 Nov '13

19 Nov '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > diff --git a/dlls/quartz/tests/Makefile.in b/dlls/quartz/tests/Makefile.in > index ae5fbac..94b2f44 100644 > --- a/dlls/quartz/tests/Makefile.in > +++ b/dlls/quartz/tests/Makefile.in > @@ -8,6 +8,7 @@ C_SRCS = \ > filtermapper.c \ > memallocator.c \ > misc.c \ > + monitorconfig.c \ > referenceclock.c \ > videorenderer.c Please merge it into one of the existing files. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: shell32/tests: Change Dec to Hex
by Zhenbo Li 19 Nov '13

19 Nov '13

Sorry, something was wrong with my network, so I had send my patch twice. 2013/11/20 Zhenbo Li <litimetal(a)gmail.com>: > --- > dlls/shell32/tests/shlfileop.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > -- Have a nice day! Zhenbo Li

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 2
by Patrick Rudolph 19 Nov '13

19 Nov '13

Am 2013-11-18 16:44, schrieb Stefan Dösinger: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > Overall, did you check if there is a capability reporting problem? The > game may have the bad size from our DDSCAPS structure. > I'm not sure. It successfully creates a primary surface with dimension 320x240 and it creates offscreen surfaces with dimension 320x240 and DDSCAPS_SYSTEMMEMORY flag set. Only offscreen surfaces with DDSCAPS_VIDEOMEMORY flag set are out of range. I was wondering: 15728640 = 320 << 16 and 20971520 = 240 << 16. Where does the two byte offset come from ? > Even if this is a capability problem I think this test is relevant. > > Am 2013-11-17 20:19, schrieb Patrick Rudolph: >> dlls/ddraw/tests/dsurface.c | 88 > +++++++++++++++++++++++++++++++++++++++++++++ > > Please add new tests to ddraw{1, 2, 4, 7}.c, and if possible implement > them for all ddraw versions. I can do that as well. > >> + ZeroMemory(&desc, sizeof(desc)); > memset(desc, 0, sizeof(desc)); is preferred. > >> + if(!(ddcaps.ddsCaps.dwCaps & DDSCAPS_VIDEOMEMORY)) + { + >> todo_wine ok(ret == DDERR_INVALIDPARAMS, "Creating an > offscreen plain surface with width 0xffff and height 1 returned > %08x\n", ret); >> + } > Is there any situation in which wine enters this codepath? I think the > todo_wine is not needed here. You are right, wine always presents a direct draw device with DDSCAPS_VIDEOMEMORY. I removed ligGL, ddraw still "works", but doesn't render anything. > >> + /* Test out of memory surface size */ + ZeroMemory(&desc, >> sizeof(desc)); + desc.dwSize = sizeof(desc); + desc.dwFlags = >> DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH; + desc.ddsCaps.dwCaps |= >> DDSCAPS_OFFSCREENPLAIN | > DDSCAPS_VIDEOMEMORY; >> + desc.dwHeight = 0xffff; + desc.dwWidth = 0xffff; + /* >> this should allocate 4.29 Gbyte of video memory */ > Testing DDSCAPS_SYSTEMMEMORY might show some interesting results as > well, especially in a Win64 executable. > I can add tests for this. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJSijXyAAoJEN0/YqbEcdMwolYP+wWH7o7Dn9LjmjJq0dca5ZD9 > EKfyGNxrtg/Th1o2qKdP4rmsl1G8UC96Xo2BP9Fi5tH9BZTzAXTiq2pfSiKGf0Z7 > l48UbVGVuVd/nxBG8ULZDS7e8b9h+NwcprM3flWW6frbqsDMxf1LPhtNsEQU8gnE > 0/hFXW/T33FkPP3XiBK6vCgWjP1umK9clcQHvit7DitFpFBmwOj5SxktoIsoPVpL > TcOiaaXKcABTbKCz4xclOaAMM7k94cH0ByJBVu+8OXNTOHzd0xbtrnFl6UZi74jH > dQyqLIyQ4uDs1760He7WtwgMEeF4NhV+u3A6qRP3eLceSf59OhEhSUNGKu5yduVb > F16yGgQiTIKHpqtD1sT1RPEDAZgUYL9Uq8BnUrPbNZ+FJI5ZwIbY7KghozAhUweA > /TC9VMLwUnJKk8v/8xHPY1WI3474Pht4joahUNWkTQ8QuN7ms44IyyyALBsWM3gF > eOSTBNEcWZz+3uRaS68/ZDeqzo+R+dwmwU8XTeWEMTxuy30x1OdCTp3BgR8YNXMa > 2uLWa5mL4pkOAVJ6gI6HHPpX8T582lB3PcZgRMd5QirwIg76dwvnk6zpiv4RqFS5 > 3HCCey4c3FO4aFhDcelkNsdcpCMbaGyv4lqtLDzBe7bR5xOrtWvmdl5r3vvlCbO2 > uERNPhePZ8ogI6buwboM > =v8j0 > -----END PGP SIGNATURE-----

2 1

Re: gdiplus: Implement GdipCreateRegionRgnData. Take 2.
by Vincent Povirk 19 Nov '13

19 Nov '13

Please note that most of this format (everything except the first 8 bytes of region_header) is documented in MS-EMFPLUS section 2.2.1.8: http://msdn.microsoft.com/en-us/library/cc230724.aspx + switch (path_header->flags & FLAGS_INTPATH) You should check for other flags here, namely 0x1000 which indicates RLE compression of point types and 0x0400 which indicates that points are relative to the previous point. (Not saying we need to support them initially, but please check so we know if they appear. Also, the lower 16 bits other than those flags are supposed to always be 0, so maybe we should check them for unknown values as well.) + if (!region_header || region_header->magic != VERSION_MAGIC) + return InvalidParameter; This should also accept 0xdbc01002, for GDI+ version 1.1. + if (i == 1) continue; /* data[1] never matches */ If that's the case, shouldn't you have a test that it doesn't match?

2 5

Re: Assorted spelling fixes.
by Jonas Maebe 19 Nov '13

19 Nov '13

On 18 Nov 2013, at 20:34, Frédéric Delanoy wrote: > --- a/dlls/ole32/itemmoniker.c > +++ b/dlls/ole32/itemmoniker.c > @@ -123,7 +123,7 @@ static ULONG WINAPI ItemMonikerImpl_Release(IMoniker* iface) > > ref = InterlockedDecrement(&This->ref); > > - /* destroy the object if there's no more reference on it */ > + /* destroy the object if there are no moee references on it */ "no more" instead of "moee". I would also say "no more references to it" instead of "on it". Jonas

2 1

Re: shell32/tests: delete a nonexistent file in an existent dir or a nonexistent dir
by Nikolay Sivov 18 Nov '13

18 Nov '13

On 11/18/2013 20:12, Zhenbo Li wrote: > I found that shell32 test hasn't covered DE_INVALIDFILES > --- > dlls/shell32/tests/shlfileop.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > + ret = SHFileOperationA(&shfo); > + todo_wine > + ok(ret == 1026 || > + ret == ERROR_FILE_NOT_FOUND || /* Vista */ > + broken(ret == ERROR_SUCCESS), /* NT4 */ > + "Expected 1026 or ERROR_FILE_NOT_FOUND, got %d\n", ret); I think it's safe to mark XP result broken() as well. Also please use 0x402 value here for it, it's easier to find this way.

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 2
by Stefan Dösinger 18 Nov '13

18 Nov '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Overall, did you check if there is a capability reporting problem? The game may have the bad size from our DDSCAPS structure. Even if this is a capability problem I think this test is relevant. Am 2013-11-17 20:19, schrieb Patrick Rudolph: > dlls/ddraw/tests/dsurface.c | 88 +++++++++++++++++++++++++++++++++++++++++++++ Please add new tests to ddraw{1, 2, 4, 7}.c, and if possible implement them for all ddraw versions. > + ZeroMemory(&desc, sizeof(desc)); memset(desc, 0, sizeof(desc)); is preferred. > + if(!(ddcaps.ddsCaps.dwCaps & DDSCAPS_VIDEOMEMORY)) + { + > todo_wine ok(ret == DDERR_INVALIDPARAMS, "Creating an offscreen plain surface with width 0xffff and height 1 returned %08x\n", ret); > + } Is there any situation in which wine enters this codepath? I think the todo_wine is not needed here. > + /* Test out of memory surface size */ + ZeroMemory(&desc, > sizeof(desc)); + desc.dwSize = sizeof(desc); + desc.dwFlags = > DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH; + desc.ddsCaps.dwCaps |= > DDSCAPS_OFFSCREENPLAIN | DDSCAPS_VIDEOMEMORY; > + desc.dwHeight = 0xffff; + desc.dwWidth = 0xffff; + /* > this should allocate 4.29 Gbyte of video memory */ Testing DDSCAPS_SYSTEMMEMORY might show some interesting results as well, especially in a Win64 executable. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSijXyAAoJEN0/YqbEcdMwolYP+wWH7o7Dn9LjmjJq0dca5ZD9 EKfyGNxrtg/Th1o2qKdP4rmsl1G8UC96Xo2BP9Fi5tH9BZTzAXTiq2pfSiKGf0Z7 l48UbVGVuVd/nxBG8ULZDS7e8b9h+NwcprM3flWW6frbqsDMxf1LPhtNsEQU8gnE 0/hFXW/T33FkPP3XiBK6vCgWjP1umK9clcQHvit7DitFpFBmwOj5SxktoIsoPVpL TcOiaaXKcABTbKCz4xclOaAMM7k94cH0ByJBVu+8OXNTOHzd0xbtrnFl6UZi74jH dQyqLIyQ4uDs1760He7WtwgMEeF4NhV+u3A6qRP3eLceSf59OhEhSUNGKu5yduVb F16yGgQiTIKHpqtD1sT1RPEDAZgUYL9Uq8BnUrPbNZ+FJI5ZwIbY7KghozAhUweA /TC9VMLwUnJKk8v/8xHPY1WI3474Pht4joahUNWkTQ8QuN7ms44IyyyALBsWM3gF eOSTBNEcWZz+3uRaS68/ZDeqzo+R+dwmwU8XTeWEMTxuy30x1OdCTp3BgR8YNXMa 2uLWa5mL4pkOAVJ6gI6HHPpX8T582lB3PcZgRMd5QirwIg76dwvnk6zpiv4RqFS5 3HCCey4c3FO4aFhDcelkNsdcpCMbaGyv4lqtLDzBe7bR5xOrtWvmdl5r3vvlCbO2 uERNPhePZ8ogI6buwboM =v8j0 -----END PGP SIGNATURE-----

2 1

Re: [PATCH 1/5] wined3d: Create a proper texture for the software cursor.
by Stefan Dösinger 18 Nov '13

18 Nov '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-11-18 10:46, schrieb Henri Verbeet: > + desc.pool = WINED3D_POOL_SYSTEM_MEM; Why did you use this pool instead of managed or dynamic default to allow a GL blit? I haven't tested this, but I suspect the WINEDDBLT_KEYSRC hack won't work in a software blit. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSihI1AAoJEN0/YqbEcdMwAN4P/iRR8C1ctmY2Eu/FUORAIcmr IFDOyZnxecPmM+0pEOX+W2RVrJmwPlnI8PDBwmKnqJNx80FxEWHIq4gTzS/InhGJ BykTeNTyb7YdHr76V6lZKr8TJTl0CaP8QWEtnl342lGBFaLjXbGbjN5Uf8v3Nv6O 3mBI0hHKvPB2gNtNfnQA2y+xhE/an0s1P0hAP6SE/BcdB9xZORCyBA5Iq1ajTBqz f9lpiIW8+9vApEEGF9wncikgvJR/snGY+JhzcxCPKg5sslDyhVBY3AgfGOR9y9IU xHgF+nN8G99MJKl/+xuvbAmcAKrltH9iR2VYBH0RtJRF0GvT9mVdbASybR6gak55 j39B+X4VpZor+6bZtaV/0+oGShxEqz4mIu6RwPQHCLL7c5IpRM3SnVmu2BQlTEhB j2SJ61P+uQdAEHAjfcl5blVuhbkPwsGA5m0oNRCRopxylbnYNbM00V8P37kkEg7D bMrs/LkP8QWN4lZoj9kZ4eR9TyvjSkSFL+5eKuULtZNlhUKfKrntBzwKfpuNJYxs 9icHe30boy4aHe0xfrVTcN9K6ALIzV4xmUgItWckjpmRTwOwEnen13tTXcKLmJWG 2CXZEz59sa7eEwc1A7NeIjKpf8EUGG34TIUJtcCT326dWRC32khXPzGKVvgqq94a 7G+ZaRaImayepVr0AKdn =ZJqZ -----END PGP SIGNATURE-----

2 3

Re: riched20: Implement ITextDocument_fnOpen. (try 2)
by Nikolay Sivov 18 Nov '13

18 Nov '13

On 11/18/2013 16:02, Jactry Zeng wrote: > update: > 1. Use 0 in HeapAlloc instead of HEAP_ZERO_MEMORY; > 2. Return an E_OUTOFMEMORY instead of HRESULT_FROM_WIN32(GetLastError()) > when HeapAlloc fail. > + FIXME("Don't support UTF-16.\n"); How is supposed to be handled? > + FIXME("Partial stub! Don't support flag: 0x%x\n", Flags); At least some flags are easy to support mapping them to sharing and creation disposition modes. > + chBuffer = HeapAlloc(GetProcessHeap(), 0, size+1); > + if(!chBuffer) > + { > + CloseHandle(hFile); > + return E_OUTOFMEMORY; > + } > + > + if(!ReadFile(hFile, chBuffer, size, &dwReadSize, NULL)) > + { > + CloseHandle(hFile); > + HeapFree(GetProcessHeap(), 0, chBuffer); > + return HRESULT_FROM_WIN32(GetLastError()); > + } > + chBuffer[size] = 0; How will it work for UTF-16 input? > + SendMessageW(This->editor->hWnd, EM_SETTEXTEX, (int)&settextex, (LPARAM)chBuffer); > + CloseHandle(hFile); > + > + return S_OK; Looks like you leak a buffer.

2 1

Re: gdiplus: Implement GdipCreateRegionRgnData.
by Marvin 18 Nov '13

18 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3433 Your paranoid android. === wxppro (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 === wvista (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 === w2008s64 (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 === w7pro64 (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:623: Test failed: data mismatch region.c:774: Test failed: data mismatch === w8 (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:623: Test failed: data mismatch region.c:774: Test failed: data mismatch === w864 (32 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:623: Test failed: data mismatch region.c:774: Test failed: data mismatch === w2008s64 (64 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 === w7pro64 (64 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:774: Test failed: data mismatch === w864 (64 bit region) === region.c:438: Test failed: GdipCreateRegionRgnData error 1 region.c:774: Test failed: data mismatch

1 0

Re: [PATCH] ddraw: add dsurface dimension tests
by Marvin 17 Nov '13

17 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3418 Your paranoid android. === wxppro (32 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === wvista (32 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w2008s64 (32 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w7pro64 (32 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w8 (32 bit dsurface) === dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 8876017c === w864 (32 bit dsurface) === dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 8876017c === w2008s64 (64 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w7pro64 (64 bit dsurface) === dsurface.c:2604: Test failed: Creating an offscreen plain surface with width 0xffff and height 1 returned 80070057 dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 88760233 === w864 (64 bit dsurface) === dsurface.c:2663: Test failed: Creating an offscreen plain surface with width 0xffff and height 0xffff returned 8876017c

1 0

Re: Use BOOL type where appropriate (Patches 100478 and 100479) are wrong for localspl
by Detlef Riekenberg 17 Nov '13

17 Nov '13

Hi Frederic. BOOL is not correct for localspl.dll. Next to 0 and 1 you can get a 2 on some machines (This depends on additional installed print-monitors) Quote from includes/ddk/winsplp.h: #define ROUTER_UNKNOWN 0 #define ROUTER_SUCCESS 1 #define ROUTER_STOP_ROUTING 2 /* * WARNING: Many Functions are declared as "BOOL", but return ROUTER_* */ -- By by ... Detlef

1 0

Re: [PATCH] wintrust/tests: Accept the CryptCATAdminAcquireContext win8 results
by Marvin 17 Nov '13

17 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3414 Your paranoid android. === w8 (32 bit crypt) === crypt.c:554: Test failed: got 11 expected ERROR_INVALID_PARAMETER

1 0

Re: [PATCH 2/2] msxml3: Compile tests with __WINESRC__ defined.
by Marvin 16 Nov '13

16 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3408 Your paranoid android. === w8 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00462D8C === wxppro (32 bit domdoc) === domdoc.c:9843: Test failed: got 00244F94 === w8 (32 bit domdoc) === domdoc.c:9843: Test failed: got 002F7394

1 0

Re: [PATCH 1/2] msxml3: Return NULL instead of empty string in IXMLElement::get_tagName.
by Marvin 16 Nov '13

16 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3407 Your paranoid android. === w8 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00462DCC

1 0

Re: msxml3: Compile tests with __WINESRC__ defined.
by Marvin 16 Nov '13

16 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3405 Your paranoid android. === wxppro (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === wvista (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w2008s64 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w7pro64 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w8 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w864 (32 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00463F3D === w2008s64 (64 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00000000004584D4 === w7pro64 (64 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00000000004584D4 === w864 (64 bit xmldoc) === xmldoc: unhandled exception c0000005 at 00000000004584D4 === wxppro (32 bit domdoc) === domdoc.c:9843: Test failed: got 00244F94 === w8 (32 bit domdoc) === domdoc.c:9843: Test failed: got 00301F24

1 0

Re: [PATCH] winex11: add virtual desktop mode 320x240
by Henri Verbeet 15 Nov '13

15 Nov '13

On 14 November 2013 10:25, Patrick Rudolph <siro(a)das-labor.org> wrote: > This patch adds support for display mode 320x240. Without this patch > DDraw:SetDisplayMode fails to set the virtual desktop window to 320x240. > Can you actually set 320x240 on Windows through e.g. ChangeDisplaySettingsEx()? I have the impression that this mode may be internal to ddraw.

1 0

win9x mode gone
by Damian Ivanov 15 Nov '13

15 Nov '13

Hi, In my recent installation on openSUSE 13.1 with wine 1.7.6 I can't find wine to set winver=win95 only nt based systems are available but with them my app crashes that it needs win95 Is win9x version gone in recent versions? Is it gone because of 64bit OS?

4 7

Call to action: Windows 8 tests cleanup
by Francois Gouget 15 Nov '13

15 Nov '13

There are still a lot of failing Windows 8 tests. If I only look at tests that fail on every single system we have test results for and further ignore most Direct X tests, I already get 29 tests for a total of 533 individual test failures! cmd.exe:batch (1) crypt32:sip (1) kernel32:console (56) kernel32:heap (20) kernel32:locale (62) mshtml:activex (6) ntdll:pipe (8) ole32:marshal (36) quartz:filtergraph (crash) rpcrt4:cstub (crash) shell32:ebrowser (3) shell32:shellpath (3) shell32:shlexec (13) shell32:shlfolder (1) shlwapi:assoc (1) shlwapi:ordinal (25) urlmon:misc (2) urlmon:protocol (46) urlmon:sec_mgr (20) urlmon:uri (3) urlmon:url (94) user32:cursoricon (55) user32:edit (4) user32:msg (10) user32:win (11) wininet:urlcache (17) winmm:midi (32) wintrust:crypt (2) wintrust:softpub (crash) Overall we have 47 tests that have failures on Windows versions ranging from XP to 8.1. We need a lot more tests to succeed in order for the WineTestBot to be at its best. List collected from: http://test.winehq.org/data/1f8636c5afc9aab85abed759627c1fa25e3b2131/index_… http://test.winehq.org/data/eebc40f2b3935819584a20187af2e6f782270838/index_… -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ I haven't lost my mind, it's backed up on tape around here somewhere...

1 0

WineTestBot status update
by Francois Gouget 15 Nov '13

15 Nov '13

We switched to the new WineTestBot near the start of September. Early on it ran into a problem when it was flooded with tests due to the __WINESRC__ tests work and it failed to keep up. The reason is that as time went on the time it takes to get the VMs back to a clean state ready to run the tests (the revert time) kept increasing as can be seen on this graph: http://fgouget.free.fr/wtb/vm1-revtimes.png There one can see the increased activity in september that what was caused by the surge in test patches. But the most remarkable feature is the Windows XP revert times which increase linearly, reaching over 30 minutes. The revert times for the other VMs are much more random but still seem to increase somewhat (1). The reason for the increase is still unknown. The revert time fell down a few times and now I suspect this corresponds to times when the VM was restored from backup. So at the start of October I upgraded to QEMU 1.6.0 and restored all the VMs from backup, hoping this would solve the problem. The revert times did get much better and the WineTestBot now manages to keep up: http://fgouget.free.fr/wtb/vm1-revtimes-new.png The upgrade happened around the 2nd of october and the revert times fell at that point. But looking at more recent data it's clear that the Windows XP revert times are increasing again, while those of the other VMs remain stable (see vm1-revtimes.xls for the raw data). That XP VM is one of the first ones I created, so it probably was created with a pretty old QEMU version. Futhermore it was only an out of the box SP2 and did not have any of the later updates. So I decided to recreate it from scratch, using QEMU 1.6.0, and to add all the other updates as I was at it. And I'm hoping that this time things will be better. That's why this VM is currently in 'maintenance' mode. I also took down the 32-bit Windows 8 VM for maintenance. It too is missing proper updates and the plan is to upgrade it to Windows 8.1. Another issue has been that the tests are running a bit slow, a particular point of pain was msi:action and msi:install which were regularly timing out. See: http://fgouget.free.fr/wtb/runtimes.htm So while rebuilding the Windows XP VM I did some performance tests. That paid off. I found that switching the emulated disk cache mode from writeback to default roughly halves the msi run times: http://fgouget.free.fr/wtb/runtimes2.htm msi:action and msi:install went from an average of 99 and 90 seconds down to 48 and 39 seconds and they are not timing out anymore. The remaining troublesome tests are now ddraw:ddraw{2,4,7}, shell32:shlexec, and winspool.drv:info. I also uncovered two other potential performance issues: * Some VMs have Windows Defender and apparently it was starting a full disk scan as soon as the VM was ready to run the tests. That's clearly not good so I disabled Windows Defender in all VMs. * Most VMs were still using 20% of the CPU when idle. That's fine if only one VM is running but could impact performance (through increased interrupt rates) if many are running at once (like on the WineTestBot). Apparently the culprit is the USB Tablet device that's added by default. So I removed it from all VMs too (and now the mouse is even more laggy than before when I work on the VMs :-( But that does not impact the tests). So there is still a lot of work to do on the WineTestBot, and that's not even counting fixing all the failing tests. (1) It's almost as if the increasing Windows XP revert times were pulling up the other VM revert times. Yet there's only one revert at a given time, so I don't see how this would be possible. (2) Setting the cache mode to writeback was improving the performance quite a bit with the pre-upgrade QEMU version. But obviously it's not true anymore. Another interesting point is that the Virtio mode improves performance by a factor of 10 (down from 450 seconds to 45 in msi:action). Yet Windows 8 posts the fastest times yet in the basic IDE mode (~23 seconds). I couldn't get Windows 8 working with the Virtio disk yet and I have not verified that it's really doing the same set of tests. So that remains to be confirmed. Here is some performance data taken from the Windows XP VM while the TestBot was idle. From it cache=default looks like it's a completely separate mode! msi:action | msi:install | msi:msi 448 460 520| 487 439 | 238 229 VGA, qcow2 ide disk, cache:default 44 45 42 | 47 49 46 | 24 23 21 VGA, qcow2 virtio disk, cache:default 48 45 50 | 47 48 48 | 23 23 24 VMVGA/VGA, qcow2 virtio disk, cache:default 47 46 | 48 46 | 23 22 22 VMVGA, qcow2 virtio disk, cache:default 47 47 | 49 48 | 24 23 VMVGA, raw virtio disk, cache:default 62 67 67 | 64 60 63 | 29 27 27 VMVGA, raw virtio disk, cache:none 111 92 72 113 | 101 101 | 37 37 40 VMVGA, raw virtio disk, cache:writethrough 61 64 53 | 70 59 58 | 36 28 29 VMVGA, raw virtio disk, cache:writeback 46 44 | | VMVGA, raw virtio disk, cache:default 71 55 68 | | VMVGA, raw virtio disk, cache:writeback 65 71 72 69| | VMVGA, raw virtio disk, cache:none 76 118 111 | | VMVGA, raw virtio disk, cache:writethrough 50 48 47 | | VMVGA, raw virtio disk, cache:default And the preliminary Windows 8 performance. I hope it holds up. msi:action | msi:install | msi:msi 23 22 22 | 16 15 16 | 13 13 15 VGA, qcow2 ide disk, cache:default -- Francois Gouget <fgouget(a)codeweavers.com>

6 12

Re: [PATCH] ddraw: fill dwNumFourCCCodes in ddraw7_GetCaps
by Henri Verbeet 14 Nov '13

14 Nov '13

On 14 November 2013 17:17, Patrick Rudolph <siro(a)das-labor.org> wrote: > hr = IDirectDraw7_GetAvailableVidMem(iface, &ddscaps, &caps.dwVidMemTotal, &caps.dwVidMemFree); > - wined3d_mutex_unlock(); > if(FAILED(hr)) { > WARN("IDirectDraw7::GetAvailableVidMem failed\n"); > return hr; > } You now fail to release the mutex on the error path. Wrt. style, I realize ddraw isn't entirely consistent about this, but you'll want to put a space between the "if" and the '(', and but the '{' on a new line.

1 0

Re: shell32/tests: add a missed init_shfo_tests() call
by Marvin 13 Nov '13

13 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3354 Your paranoid android. === build (build) === Patch failed to apply

1 0

Potential miss usage of strchr VS strrchr in Wine (was: [PATCH] wscript: Get extension name by strrchrW instead of strchrW.)
by Qian Hong 13 Nov '13

13 Nov '13

Hello, While working on a vbscript bug affects a real world app, I found a potential miss usage of strchr/strrch in Wine. Here is a unfiltered list: $ git grep "= strchr" | grep ext | grep -E "'\.'" dlls/gdi32/freetype.c: ext = strchr( last_part, '.' ); dlls/msi/action.c: extension = strchrW( filename, '.' ); dlls/wineps.drv/type1afm.c: CHAR *file_extension = strchr(dent->d_name, '.'); tools/winebuild/utils.c: if (!(ext = strchr( basename, '.' ))) ext = prefix + strlen(prefix); After basic reviewing, I think all the above codes are potential miss usage, but there is a risk to touch these codes. I don't know any real word app affected by these codes yet, so I have no strong motivation to touch them. Anyone worked on related fields has interesting to review deeper? Thanks! On Tue, Nov 12, 2013 at 4:19 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > --- > programs/wscript/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

2 1

Re: user32/tests: Allow win8 error code
by Marvin 13 Nov '13

13 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3343 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2488: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2501: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:2488: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2501: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

WINE CE - getting a program to execute
by Mark Bellmore 12 Nov '13

12 Nov '13

Hello, I have some winCE apps they would like to run on Android. Since WINE for Android will not be out for several months I thought I would investigate how to get applications running under the winece that is currently available. I successfully installed it on a pandaboard and the demo applications that come with the install work (e.g. clock.exe). I downloaded what I thought was a typical application that did not have any additional dlls (putty.exe) but it immediately returns with: wine: Invalid address I am a fairly competent c programmer but I was hoping I could get some pointers on where to get started since there is a lot of codebase to wade through. If you think it cannot be done by a newbie please don't hesitate to say so :) Thanks! = Mark ----------------------- Here is the results from windump putty.exe File Header Machine: 01C0 (ARM) Number of Sections: 5 TimeDateStamp: 45E5F329 (Wed Feb 28 15:24:57 2007) offset 216 PointerToSymbolTable: 00000000 NumberOfSymbols: 00000000 SizeOfOptionalHeader: 00E0 Characteristics: 010F RELOCS_STRIPPED EXECUTABLE_IMAGE LINE_NUMS_STRIPPED LOCAL_SYMS_STRIPPED 32BIT_MACHINE Optional Header (32bit) Magic 0x10B 267 linker version 6.24 size of code 0x53c00 343040 size of initialized data 0x1f200 127488 size of uninitialized data 0x0 0 entrypoint RVA 0x5499c 346524 base of code 0x1000 4096 base of data 0x55000 348160 image base 0x10000 65536 section align 0x1000 4096 file align 0x200 512 required OS version 4.00 image version 0.00 subsystem version 4.20 Win32 Version 0x0 0 size of image 0x75000 479232 size of headers 0x400 1024 checksum 0x0 0 Subsystem 0x9 (Windows CE GUI) DLL characteristics: 0x0 stack reserve size 0x10000 65536 stack commit size 0x1000 4096 heap reserve size 0x100000 1048576 heap commit size 0x1000 4096 loader flags 0x0 0 RVAs & sizes 0x10 16 Data Directory EXPORT rva: 0x0 size: 0x0 IMPORT rva: 0x62258 size: 0x28 RESOURCE rva: 0x73000 size: 0x1f4c EXCEPTION rva: 0x71000 size: 0x1e90 SECURITY rva: 0x0 size: 0x0 BASERELOC rva: 0x0 size: 0x0 DEBUG rva: 0x0 size: 0x0 ARCHITECTURE rva: 0x0 size: 0x0 GLOBALPTR rva: 0x0 size: 0x0 TLS rva: 0x0 size: 0x0 LOAD_CONFIG rva: 0x0 size: 0x0 Bound IAT rva: 0x0 size: 0x0 IAT rva: 0x63000 size: 0x368 Delay IAT rva: 0x0 size: 0x0 CLR Header rva: 0x0 size: 0x0 rva: 0x0 size: 0x0 ----------------- Here is the last several lines from setting WINDEDEBUG=+all 0030: open_key( parent=0010, access=000f003f, attributes=00000000, name=L"Software\\Wine\\DllOverrides" ) 0030: open_key() = OBJECT_NAME_NOT_FOUND { hkey=0000 } 0030: close_handle( handle=0010 ) 0030: close_handle() = 0 0030: get_handle_fd( handle=000c ) 0030: *fd* 000c -> 21 0030: get_handle_fd() = 0 { type=1, cacheable=1, access=00120089, options=00000000 } 0030: create_mapping( access=000f0005, attributes=00000000, protect=00000145, size=00000000, file_handle=000c, objattr={rootdir=0000,sd={},name=L""} ) 0030: create_mapping() = 0 { handle=0010 } 0030: get_mapping_info( handle=0010, access=00000004 ) 0030: get_mapping_info() = 0 { size=00075000, protect=325, header_size=1024, base=00010000, mapping=0014, shared_file=0000 } 0030: get_handle_fd( handle=0010 ) 0030: *fd* 0010 -> 22 0030: get_handle_fd() = 0 { type=1, cacheable=1, access=000f0005, options=00000020 } 0030: close_handle( handle=0014 ) 0030: close_handle() = 0 0030: close_handle( handle=0010 ) 0030: close_handle() = 0 0030: close_handle( handle=000c ) 0030: close_handle() = 0 0030: terminate_process( handle=0000, exit_code=487 ) 0030: terminate_process() = 0 { self=1 } 0030: terminate_process( handle=ffffffff, exit_code=487 ) 0030: terminate_process() = 0 { self=1 } 0030: *killed* exit_code=487 002f: *process killed*

2 1

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications (rebased).
by Marvin 12 Nov '13

12 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3330 Your paranoid android. === wxppro (32 bit sock) === sock.c:520: Test failed: oob_server (470): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:510: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock.c:520: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 757C9799 === w2008s64 (64 bit sock) === sock.c:520: Test failed: oob_server (704): unexpectedly at the OOB mark: 0 === w864 (64 bit sock) === sock.c:1748: Test failed: getservbyname: winsock resized servent buffer when not necessary

1 0

Re: [PATCH 1/5] d3d8: Clear pBits and Pitch when d3d8_surface_LockRect() fails.
by Marvin 12 Nov '13

12 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3328 Your paranoid android. === w8 (32 bit device) === device.c:2494: Test failed: Expected foreground window 00030196, got 0002004E. device.c:3190: Test failed: Expected wndproc 0x40fff0, got 0x40fff0. === w864 (32 bit device) === device.c:2494: Test failed: Expected foreground window 0004017A, got 0001007A. device.c:3190: Test failed: Expected wndproc 0x40fff0, got 0x40fff0.

1 0

Re: user32/tests: Fix GetSystemMetrics on Win8
by Marvin 12 Nov '13

12 Nov '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3326 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2488: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2501: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:2488: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2501: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [2/3] quartz: Partial implementation of VMR7MonitorConfig
by Alexandre Julliard 11 Nov '13

11 Nov '13

Michael Müller <michael(a)fds-team.de> writes: > + mode.dmSize = sizeof(DEVMODEW); > + mode.dmDriverExtra = 0; > + > + if (!EnumDisplaySettingsExW(device.DeviceName, ENUM_CURRENT_SETTINGS, &mode, EDS_RAWMODE)) > + continue; > + > + memset(info, 0, sizeof(VMRMONITORINFO)); > + > + info->guid.pGUID = NULL; /* default DirectDraw device */ > + > + info->rcMonitor.left = mode.u1.s2.dmPosition.x; > + info->rcMonitor.top = mode.u1.s2.dmPosition.y; > + info->rcMonitor.right = mode.u1.s2.dmPosition.x + mode.dmPelsWidth; > + info->rcMonitor.bottom = mode.u1.s2.dmPosition.y + mode.dmPelsHeight; > + > + info->hMon = 0; /* FIXME: return monitor handle */ > + info->dwFlags = (device.StateFlags & DISPLAY_DEVICE_PRIMARY_DEVICE) ? MONITORINFOF_PRIMARY : 0; > + > + lstrcpynW(info->szDevice, device.DeviceName, sizeof(info->szDevice)/sizeof(WCHAR)); > + lstrcpynW(info->szDescription, device.DeviceString, sizeof(info->szDescription)/sizeof(WCHAR)); > + > + count++; > + info++; EnumDisplayMonitors would probably be more appropriate. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/4] winex11: Send XEMBED_REQUEST_FOCUS request for embedded windows
by Alexandre Julliard 11 Nov '13

11 Nov '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -1140,6 +1140,22 @@ void make_window_embedded( struct x11drv_win_data *data ) > set_xembed_flags( data, (data->mapped || data->embedder) ? XEMBED_MAPPED : 0 ); > } > > +/*********************************************************************** > + * get_ancestor_root_embedded > + */ > +HWND get_ancestor_root_embedded( HWND hwnd ) > +{ > + HWND parent; > + if (!hwnd) return NULL; > + for (;;) > + { > + parent = GetAncestor(hwnd, GA_PARENT); > + if (!parent || parent == GetDesktopWindow() || (Window)GetPropA( parent, foreign_window_prop )) > + break; > + hwnd = parent; > + } > + return hwnd; > +} It would be better to check for the embedded flag instead of retrieving a bunch of window properties. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] kernel32: Add tests for creating directories with specific security attributes.
by Dmitry Timoshkov 11 Nov '13

11 Nov '13

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> wrote: > Currently CreateDirectory mostly ignores the security attributes on > directories. This patch adds some tests for what happens when these > attributes are present and part 2 adds support for setting these > attributes. This patch duplicates already existing tests in dlls/advapi32/tests/security.c. -- Dmitry.

2 2

Re: urlmon: Compile tests with -D__WINESRC__.
by Dmitry Timoshkov 11 Nov '13

11 Nov '13

Jacek Caban <jacek(a)codeweavers.com> wrote: > - expectedLen = lstrlen(prop.value); > - brokenLen = lstrlen(prop.broken_value); > + expectedLen = lstrlenA(prop.value); > > /* This won't be necessary once GetPropertyLength is implemented. */ > receivedLen = -1; > @@ -8145,14 +8144,14 @@ static void test_IUri_GetPropertyLength(void) { > hr, prop.expected, i, j); > } > todo_wine { > - ok(receivedLen == expectedLen || broken(receivedLen == brokenLen), > + ok(receivedLen == expectedLen || broken(prop.broken_value && receivedLen == lstrlenA(prop.broken_value)), Please don't use lstrlenA in the tests. -- Dmitry.

3 8

Re: comctl32: Fix handling of NULL text for TTM_ADDTOOLW.
by Alexandre Julliard 11 Nov '13

11 Nov '13

Francois Gouget <fgouget(a)free.fr> writes: > --- > > The __WINESRC__ patch introduced a new failure on all Windows platforms: > http://test.winehq.org/data/tests/comctl32:tooltips.html > > Apparently passing a NULL string is ok with the ANSI version, but not > with the Unicode one. > > dlls/comctl32/tests/tooltips.c | 2 +- > dlls/comctl32/tooltips.c | 47 +++++++++++++++++++++++------------------- > 2 files changed, 27 insertions(+), 22 deletions(-) It breaks other tests: ../../../tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p comctl32_test.exe.so status.c && touch status.ok status.c:421: Test failed: Expected Tooltip Text, got make[1]: *** [status.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] quartz: Partial implementation of VMR7MonitorConfig
by Michael Stefaniuc 11 Nov '13

11 Nov '13

Hello Michael, On 11/11/2013 01:26 AM, Michael Müller wrote: > --- > dlls/quartz/vmr9.c | 70 > +++++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 64 insertions(+), 6 deletions(-) > > > > 0015-quartz-Partial-implementation-of-VMR7MonitorConfig.txt > > > From beed64a33606fd3de77f41708f8a2b590521ea51 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Michael=20M=C3=BCller?= <michael(a)fds-team.de> > Date: Sun, 10 Nov 2013 21:40:10 +0100 > Subject: quartz: Partial implementation of VMR7MonitorConfig > > --- > dlls/quartz/vmr9.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 64 insertions(+), 6 deletions(-) > > diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c > index 0acdd26..6b2970b 100644 > --- a/dlls/quartz/vmr9.c > +++ b/dlls/quartz/vmr9.c > static HRESULT WINAPI VMR7MonitorConfig_GetAvailableMonitors(IVMRMonitorConfig *iface, > @@ -1342,9 +1350,59 @@ static HRESULT WINAPI VMR7MonitorConfig_GetAvailableMonitors(IVMRMonitorConfig * > DWORD *numdev) > { a better approach is to put the implementation into VMR9MonitorConfig_GetAvailableMonitors and just forward VMR7MonitorConfig_GetAvailableMonitors to it. Of course only if there is an easy way to translate between a VMRGUID from VMR7 ro a uDevID from VMR9. > struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); > + DISPLAY_DEVICEW device; > + DWORD devnum, count; > + DEVMODEW mode; > > - FIXME("(%p/%p)->(%p, %u, %p) stub\n", iface, This, info, arraysize, numdev); > - return E_NOTIMPL; > + FIXME("(%p/%p)->(%p, %u, %p) semi-stub\n", iface, This, info, arraysize, numdev); > + > + if (!numdev) > + return E_POINTER; > + > + device.cb = sizeof(DISPLAY_DEVICEW); > + > + /* return the number of available monitors if info == NULL */ > + if (info == NULL) > + { > + for (devnum = 0; EnumDisplayDevicesW(NULL, devnum, &device, 0); ++devnum); > + *numdev = devnum; > + return S_OK; > + } > + > + /* at least one entry */ > + if (arraysize == 0) > + return E_INVALIDARG; > + > + for (count = 0, devnum = 0; count < arraysize && EnumDisplayDevicesW(NULL, devnum, &device, 0); ++devnum) > + { > + > + mode.dmSize = sizeof(DEVMODEW); > + mode.dmDriverExtra = 0; > + > + if (!EnumDisplaySettingsExW(device.DeviceName, ENUM_CURRENT_SETTINGS, &mode, EDS_RAWMODE)) > + continue; > + > + memset(info, 0, sizeof(VMRMONITORINFO)); > + > + info->guid.pGUID = NULL; /* default DirectDraw device */ > + > + info->rcMonitor.left = mode.u1.s2.dmPosition.x; > + info->rcMonitor.top = mode.u1.s2.dmPosition.y; > + info->rcMonitor.right = mode.u1.s2.dmPosition.x + mode.dmPelsWidth; > + info->rcMonitor.bottom = mode.u1.s2.dmPosition.y + mode.dmPelsHeight; > + > + info->hMon = 0; /* FIXME: return monitor handle */ > + info->dwFlags = (device.StateFlags & DISPLAY_DEVICE_PRIMARY_DEVICE) ? MONITORINFOF_PRIMARY : 0; > + > + lstrcpynW(info->szDevice, device.DeviceName, sizeof(info->szDevice)/sizeof(WCHAR)); > + lstrcpynW(info->szDescription, device.DeviceString, sizeof(info->szDescription)/sizeof(WCHAR)); > + > + count++; > + info++; > + } > + > + *numdev = count; > + return S_OK; > } > > static const IVMRMonitorConfigVtbl VMR7_MonitorConfig_Vtbl = > -- 1.7.9.5 bye michael

1 0

Re: comctl32: improve GUI error messages
by Nikolay Sivov 10 Nov '13

10 Nov '13

On Wed, Nov 6, 2013 at 11:55 PM, Austin English <austinenglish(a)gmail.com>wrote: > Requested by Focht. Fixes http://bugs.winehq.org/show_bug.cgi?id=34850 > > -- > -Austin > > > > I think it's better to start with real implementation. We'll need it sooner or later.

1 0

using mono dll components on wine(C#)
by Akira Nakagawa 09 Nov '13

09 Nov '13

I do not know how to use COM classes on wine lib,for example , System.dll wine dlls should be written by C,but I found many .Net methods equivalent to Win32 APIs.You can implement methods easily. (for example, ClearEventLog () in advapi32.dll by Eventlog.Clear() in System.Diagnostics) Isn't this good idea?

2 1

Implemention of HANDLE type in OpenEventLog func
by Akira Nakagawa 09 Nov '13

09 Nov '13

I cannot find any reference of implementation of HANDLE type that returned by OpenEventLog(). Is there any records?If so,it's OK to define it by us own.

2 1

Re: [PATCH 2/2] advapi32: HKCR merge: added path management
by George Stephanos 08 Nov '13

08 Nov '13

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel