- wine-devel - winehq.org

Re: [PATCH 2/2] ole32: Pass last_unlock_releases to IExternalConnection_ReleaseConnection().
by Marvin 18 Oct '13

18 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2864 Your paranoid android. === wxppro (32 bit marshal) === marshal.c:2803: Test failed: wait timed out marshal.c:2807: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00419C4C === w864 (32 bit marshal) === marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 === w864 (64 bit marshal) === marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0

1 0

Re: wined3d: Initialize map_desc in wined3d_surface_map
by Marvin 18 Oct '13

18 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2785 Your paranoid android. === w864 (32 bit device) === device.c:5409: Test failed: pBits not cleared on double lock. device.c:5410: Test failed: Pitch not cleared on double lock. device: unhandled exception c0000005 at 742814C8 === w864 (64 bit device) === device.c:5409: Test failed: pBits not cleared on double lock. device.c:5410: Test failed: Pitch not cleared on double lock. device: unhandled exception c0000005 at 000007F84EDD90EB

3 3

Re: [PATCH 7/9] secur32: Cache certificate context instead of store in schannel handle.
by Marvin 18 Oct '13

18 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2860 Your paranoid android. === w864 (32 bit schannel) === schannel.c:803: Test failed: cert != cert2

1 0

Re: wintrust/tests: Compile with -D__WINESRC__
by Marvin 17 Oct '13

17 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2850 Your paranoid android. === w864 (32 bit crypt) === crypt.c:289: Test failed: Expected success, got FALSE with 87 crypt.c:293: Test failed: Expected success, got FALSE with 87

1 0

re: visual studio 2012 pdb support
by Dan Kegel 17 Oct '13

17 Oct '13

Hi Roman, it might help if you were to show tiny example programs that wine's pdb support doesn't handle, like I did at http://kegel.com/wine/valgrind/pdbdemo/ Ideally you'd file a new bug report at bugs.winehq.org for this. - Dan

1 0

Re: winemac: Restore the window title when the window style is changed.
by Ken Thomases 17 Oct '13

17 Oct '13

On Oct 17, 2013, at 3:54 AM, Kevin Eaves wrote: > <cocoa_window.patch> Looks good to me. Thanks. Note that this fixes <http://bugs.winehq.org/show_bug.cgi?id=34472>. -Ken

1 0

Re: [2/3] gdi32: Adjust fake bold outline font metrics.
by Marvin 17 Oct '13

17 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2842 Your paranoid android. === wvista (32 bit font) === The test timed out

1 0

Re: [1/3] gdi32/tests: Add tests for fake bold outline fonts.
by Marvin 17 Oct '13

17 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2841 Your paranoid android. === wvista (32 bit font) === No test summary line found Failure running script in VM: network read timed out === w2008s64 (32 bit font) === Failure running script in VM: network read timed out

1 0

Re: [2/2] msxml3: Set referrer header to container url
by Marvin 17 Oct '13

17 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2837 Your paranoid android. === wxppro (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === wvista (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w2008s64 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w7pro64 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w864 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {af0ff408-129d-4b20-91f0-02bd23d88352}, riid {af0ff408-129d-4b20-91f0-02bd23d88352} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9c1-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9c1-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9d5-bafa-11ce-8c82-00aa004ba90b}, riid {79eac9d5-bafa-11ce-8c82-00aa004ba90b} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w2008s64 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w7pro64 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w864 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {af0ff408-129d-4b20-91f0-02bd23d88352}, riid {af0ff408-129d-4b20-91f0-02bd23d88352} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9c1-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9c1-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9d5-bafa-11ce-8c82-00aa004ba90b}, riid {79eac9d5-bafa-11ce-8c82-00aa004ba90b} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/"

1 0

Re: [4/6] kernel32/tests: Fix communication port tests compilation with __WINESRC__ defined.
by Marvin 17 Oct '13

17 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2833 Your paranoid android. === w2008s64 (32 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:883: Test failed: WaitCommEvent error 0 comm.c:885: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:889: WaitCommEvent for EV_TXEMPTY took 1014 ms (timeout 1000) comm.c:891: Test failed: WaitCommEvent used 1014 ms for waiting comm.c:1558: test_AbortWaitCts timeout 500 handle 000000C4 comm.c:1525: Changing CommMask on the fly for handle 000000C4 after timeout 500

1 0

Re: [2/2] gdi32/tests: Enable gdi32 tests compilation with __WINESRC__ defined. Resend.
by Marvin 17 Oct '13

17 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2828 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: msctf/tests: Compile with -D__WINESRC__
by Marvin 16 Oct '13

16 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2822 Your paranoid android. === w864 (64 bit inputprocessor) === inputprocessor.c:791: Test failed: Deactivation came unexpectedly

1 0

Re: [PATCH] user32/tests: Skip desktop tests on NT4.
by Alexandre Julliard 16 Oct '13

16 Oct '13

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so winstation.c && touch winstation.ok winstation.c:546: Test succeeded inside todo block: unexpected last error deadbeef winstation.c:549: Test failed: Skip tests on NT4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 02/11] crypt32: Don't use links to certs in memory store.
by Alexandre Julliard 16 Oct '13

16 Oct '13

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/crypt32/cert.c | 159 > ++++++++++++++++++++++++----------------- > dlls/crypt32/collectionstore.c | 12 ++-- > dlls/crypt32/context.c | 4 +- > dlls/crypt32/crl.c | 7 +- > dlls/crypt32/crypt32_private.h | 22 +++--- > dlls/crypt32/ctl.c | 9 ++- > dlls/crypt32/provstore.c | 18 ++--- > dlls/crypt32/store.c | 17 +++-- > 8 files changed, 140 insertions(+), 108 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M cryptui.dll -p cryptui_test.exe.so cryptui.c && touch cryptui.ok wine: Unhandled page fault on read access to 0xfffffff0 at address 0x6865c543 (thread 005d), starting debugger... Unhandled exception: page fault on read access to 0xfffffff0 in 32-bit code (0x6865c543). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6865c543 ESP:0032fab0 EBP:0032fac8 EFLAGS:00010297( R- -- I S -A-P-C) EAX:ffffffe8 EBX:686bb2fc ECX:00000000 EDX:0013ed38 ESI:0013ed70 EDI:00000001 Stack dump: 0x0032fab0: 00000005 0013eea0 0032fb68 686bb2fc 0x0032fac0: 686bb2fc 00000001 0032fb68 6864f122 0x0032fad0: 0013d6a8 00000000 00000000 0032fb2c 0x0032fae0: 00000000 00000000 0032fb38 6869a1af 0x0032faf0: 00000000 00020000 00000000 6865b7e0 0x0032fb00: 0032fb3c 0013ed50 0032fb38 6869a618 Backtrace: =>0 0x6865c543 Context_CopyProperties+0x43(to=0x13d6a8, from=0x0(nil)) [/home/julliard/wine/wine/dlls/crypt32/context.c:99] in crypt32 (0x0032fac8) 1 0x6864f122 add_cert_to_store+0x3e1(store=<couldn't compute location>, cert=<couldn't compute location>, add_disposition=<couldn't compute location>, use_link=<couldn't compute location>, ret_context=<couldn't compute location>) [/home/julliard/wine/wine/dlls/crypt32/cert.c:270] in crypt32 (0x0032fb68) 2 0x6864f37d CertAddCertificateContextToStore+0x9c(hCertStore=<couldn't compute location>, pCertContext=<couldn't compute location>, dwAddDisposition=<couldn't compute location>, ppStoreContext=<couldn't compute location>) [/home/julliard/wine/wine/dlls/crypt32/cert.c:288] in crypt32 (0x0032fbc8) 3 0x5557563b import_cert+0x14a() in cryptui (0x0032fc38) 4 0x555793ad CryptUIWizImport+0x10c() in cryptui (0x0032fc78) 5 0x6862a5e7 func_cryptui+0x4f6() [/home/julliard/wine/wine/dlls/cryptui/tests/cryptui.c:397] in cryptui_test (0x0032fcf8) 6 0x6862b675 run_test+0x144(name=<is not available>) [/home/julliard/wine/wine/dlls/cryptui/tests/../../../include/wine/test.h:570] in cryptui_test (0x0032fd48) 7 0x68629c23 main+0x152(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/cryptui/tests/../../../include/wine/test.h:640] in cryptui_test (0x0032fe08) 8 0x6862c0c0 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in cryptui_test (0x0032fe58) 9 0x7b85f38c call_process_entry+0xb() in kernel32 (0x0032fe78) 10 0x7b86056b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1085] in kernel32 (0x0032feb8) 11 0x7bc7fea0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 12 0x7bc82dad call_thread_func+0x7c(entry=0x7b860500, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 13 0x7bc7fe7e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 14 0x7bc54a2e start_process+0x1d(kernel_start=0x7b860500) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2697] in ntdll (0x0032ffe8) 15 0x6803128d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 16 0x6803134b wine_switch_to_stack+0x2a(func=0x7bc54a10, arg=0x7b860500, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xffb103b8) 17 0x7bc5a587 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2753] in ntdll (0xffb10428) 18 0x7b866ae0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1257] in kernel32 (0xffb11338) 19 0x7bc5ac53 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2962] in ntdll (0xffb113c8) 20 0x6802eeda wine_init+0x2b9(argc=0x3, argv=0xffb11904, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xffb11428) 21 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xffb11868) 22 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x6865c543 Context_CopyProperties+0x43 [/home/julliard/wine/wine/dlls/crypt32/context.c:99] in crypt32: movl 0xfffffff0(%ecx),%edx 99 while (ptr && ptr->linked) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] atl: Avoid duplicate debugging trace for same exported function names from different dlls.
by Alexandre Julliard 16 Oct '13

16 Oct '13

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/atl/atl.spec | 6 +++--- > dlls/atl/atl_main.c | 9 +++++---- > 2 files changed, 8 insertions(+), 7 deletions(-) I'd suggest to simply print the version in the trace, instead of renaming all the functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH try3] atl110: Added new DLL.
by Qian Hong 16 Oct '13

16 Oct '13

> +WINE_DEFAULT_DEBUG_CHANNEL(atl); Hi Jacek, we already have a debug channel atl100 for atl100.dll, but we currently use atl for both atl.dll and atl80.dll, do you think it is better to use atl for all, or one debug channel per each dll?

2 5

visual studio 2012 pdb support
by Роман Остриков 16 Oct '13

16 Oct '13

Hello, dear developes Some times ago I have started porting some system to wine and was disappointed that application hangs. So I have began use dbghelp. I have faced with problem in supporting dpb files in wine which was generated by Visual Studio 2012. I have found an article: http://bugs.winehq.org/show_bug.cgi?id=835 where Dan Kegel public a series of fixes. But support was for VS2008 and post was dated by 2009-11-01. So may be this fix already included in Wine1.6 and debug symbols cant recognized by dbghelp due of another problem? Can anybody explain this? Best Reagrds

1 0

Video Mixing Renderer 7
by Michael Müller 16 Oct '13

16 Oct '13

Hi, I am wondering what would be the best way to handle programs which rely on the Video Mixing Renderer 7 (quartz.dll) as it's supposed to be available on XP and later, but Wine contains only an implementation of version 9. The program I am speaking of is Silverlight which uses the VMR 7 Interface to create a filter graph and then queries for the IAMCertifiedOutputProtection interface. I am currently using a hack fix to get around this by returning a VMR9 instance when a VMR7 is requested and implementing the missing subinterfaces (which are only part of VMR7). This solution is clearly not perfect and I am searching for a better way to get around this issue. The most similar way to Windows would be to completely rewrite the current implementation of the VMR9 as VMR7 using DirectDraw, which would take a lot of time and most probably end up in having a lot of duplicate code. I am wondering whether using d3d9 for VMR7 would also be an acceptable solution. We could move all the d3d9 related stuff to a separate file so that VMR7.c and VMR9.c only offer the version specific interfaces and use the same code internally. This shouldn't be a big problem since the differences between the VMR7 and VMR9 interfaces are often only very small. Though it would not completely fit the behavior of windows. I am open for other ideas on how to solve the problem, but as Silverlight does not even use the VMR7 object for playing the video but only to check for the graphic driver certificate I don't think it would justify to rewrite everything using Direct Draw if there are no other programs needing this interface. Best Regards, Michael Müller

5 4

Re: notepad: Use BOOL type where appropriate (try 2)
by Alexandre Julliard 16 Oct '13

16 Oct '13

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > try 2: Avoid changing SendMessage calls Dialog procedures return booleans too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: notepad: Use BOOL type where appropriate
by Alexandre Julliard 16 Oct '13

16 Oct '13

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -298,7 +298,7 @@ static SAVE_STATUS DoSaveFile(LPCWSTR szFileName, ENCODING enc) > CloseHandle(hFile); > HeapFree(GetProcessHeap(), 0, pBytes); > > - SendMessageW(Globals.hEdit, EM_SETMODIFY, FALSE, 0); > + SendMessageW(Globals.hEdit, EM_SETMODIFY, 0, 0); Many messages use booleans, even if the actual type is a WPARAM. Please don't change them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dispex/tests: Compile with -D__WINESRC__
by Dmitry Timoshkov 16 Oct '13

16 Oct '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + PeekMessageA(&msg, NULL, WM_USER, WM_USER, PM_NOREMOVE); IMHO it would be much better to use W version of APIs while doing this cleanup. Same applies to all other your patches that prepare switching compilation to using -D__WINESRC__. -- Dmitry.

2 1

Re: [10/10] gdi32/tests: Enable gdi32 tests compilation with __WINESRC__ defined.
by Marvin 16 Oct '13

16 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2808 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [06/10] gdi32/tests: Fix font tests compilation with __WINESRC__ defined.
by Marvin 16 Oct '13

16 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2804 Your paranoid android. === wxppro (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === wvista (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 No test summary line found Failure running script in VM: network read timed out === w2008s64 (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 Timeout Failure running script in VM: network read timed out === w7pro64 (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === w864 (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === w2008s64 (64 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === w7pro64 (64 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === w864 (64 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080

1 0

Re: mmdevapi/tests: Compile with -D__WINESRC__.
by Marvin 16 Oct '13

16 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2797 Your paranoid android. === w7pro64 (32 bit render) === render.c:662: Test failed: Wait(event) after Stop gave 102

1 0

Re: winmm/tests: Use the explicit mciSendStringA() form.
by Marvin 16 Oct '13

16 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2796 Your paranoid android. === w864 (32 bit midi) === midi.c:518: Test failed: midiOutPrepare old size rc=MMSYSERR_INVALPARAM midi.c:519: Test failed: MHDR.dwFlags when prepared 0 midi.c:523: Test failed: midiStreamOut old size rc=MIDIERR_UNPREPARED midi.c:547: Test failed: MHDR.dwFlags 0 no ISSTRM when out of queue midi.c:553: Test failed: MHDR.dwFlags 0 not DONE when out of queue midi.c:554: Test failed: Wait failed: 0102 -559038737 midi.c:554: Test failed: Expect message 3ca from midiStream callback midi.c:555: Test failed: Wait failed: 0102 -559038737 midi.c:555: Test failed: Expect message 3c9 from midiStreamOut midi.c:558: Test failed: play left MIDIHDR.dwOffset at 1234567890 midi.c:561: Test failed: midiOutUnprepare rc=MMSYSERR_INVALPARAM midi.c:563: Test failed: midiOutUnprepare #2 rc=MMSYSERR_INVALPARAM midi.c:566: Test failed: MHDR.dwFlags when done 0 midi.c:580: Test failed: stream set tempo 500000 midi.c:588: Test failed: midiOutPrepare used flags 8 rc=MMSYSERR_INVALPARAM midi.c:590: Test failed: midiOutUnprepare used flags 8 rc=MMSYSERR_INVALPARAM midi.c:518: Test failed: midiOutPrepare old size rc=MMSYSERR_INVALPARAM midi.c:519: Test failed: MHDR.dwFlags when prepared 0 midi.c:523: Test failed: midiStreamOut old size rc=MIDIERR_UNPREPARED midi.c:547: Test failed: MHDR.dwFlags 0 no ISSTRM when out of queue midi.c:553: Test failed: MHDR.dwFlags 0 not DONE when out of queue midi.c:554: Test failed: Wait failed: 0102 -559038737 midi.c:554: Test failed: Expect message 3ca from midiStream callback midi.c:555: Test failed: Wait failed: 0102 -559038737 midi.c:555: Test failed: Expect message 3c9 from midiStreamOut midi.c:558: Test failed: play left MIDIHDR.dwOffset at 1234567890 midi.c:561: Test failed: midiOutUnprepare rc=MMSYSERR_INVALPARAM midi.c:563: Test failed: midiOutUnprepare #2 rc=MMSYSERR_INVALPARAM midi.c:566: Test failed: MHDR.dwFlags when done 0 midi.c:580: Test failed: stream set tempo 500000 midi.c:588: Test failed: midiOutPrepare used flags 8 rc=MMSYSERR_INVALPARAM midi.c:590: Test failed: midiOutUnprepare used flags 8 rc=MMSYSERR_INVALPARAM === wxppro (32 bit mci) === mci.c:1209: Test failed: mci status "C:\Documents and Settings\winetest\My Documents\tempfile.wav" mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1274: Test failed: mci re-auto-open status mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1290: Test failed: mci auto-open pause returned MCIERR_INVALID_DEVICE_NAME === wvista (32 bit mci) === mci.c:986: Test failed: 397ms is not in the expected 400-600ms range mci.c:993: Test failed: 397ms is not even in the expected 400-1000ms range === w7pro64 (64 bit mci) === mci.c:1120: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

1 0

Re: cmd/tests: Compile with -D__WINESRC__
by Marvin 16 Oct '13

16 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2794 Your paranoid android. === wxppro (32 bit batch) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar')

1 0

Re: ole32/tests: Compile with -D__WINESRC__
by Marvin 16 Oct '13

16 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2791 Your paranoid android. === wxppro (32 bit marshal) === marshal.c:2746: Test failed: wait timed out marshal.c:2750: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00419A9C === w864 (32 bit marshal) === marshal.c:3007: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3008: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3024: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3025: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3062: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3063: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3080: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3081: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3044: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3045: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3007: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3008: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3024: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3025: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3062: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3063: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3080: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3081: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3044: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3045: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3007: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3008: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3024: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3025: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3062: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3063: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3080: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3081: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3044: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3045: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 === w864 (64 bit marshal) === marshal.c:3007: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3008: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3024: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3025: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3062: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3063: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3080: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3081: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3044: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3045: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3007: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3008: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3024: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3025: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3062: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3063: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3080: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3081: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3044: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3045: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3007: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3008: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3024: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3025: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3062: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3063: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3080: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3081: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3044: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3045: Test failed: info->dwServerPid was 0x8ac instead of 0xb44

1 0

Request for a possible inclusion of the Wineasio driver?
by Joakim Hernberg 15 Oct '13

15 Oct '13

I am the maintainer of a driver for Wine on Linux called Wineasio. I'd like to find a home for the code and am hoping to convince you of adding it to the Wine codebase. ASIO is an API developed by Steinberg for supporting low latency audio hardware under Windows. Each hardware manufacturer uses Steinberg's SDK to create a driver supporting their own hardware. Software using the API is normally audio related such as Digital Audio Workstations, virtual instruments and other music production software. On Linux, Wineasio interfaces directly with the Jack audio API, and runs on all hardware supported by Jack, which nowdays is the vast majority on audio hardware supported in linux. On OS/X a derrived driver called Coreasio has been created, and is in use by Image-line's FLS port. Jack runs on Linux, Solaris, FreeBSD, OS/X, iOS and Windows, so in theory it ought to be possible to support Wineasio on all platforms supported by Wine. I don't know the details on how Coreasio works, but in the case of Wineasio, the driver links directly to the Jack server's client libs, so there is no need to alter any existing parts of Wine's audiostack nor to reimplement and maintain a Jack driver for Wine itself. The only change needed is to include the driver in the source tree. The driver implements all the core functionality of the API, only some optional and obscure parts of the API are missing. It has been in use for years on 32 bit Wine and does not appear to have any showstopping bugs, if any at all. I've personally used it for over a year on 64 bit Wine, and I know of some other people who use it without problems on 64 bit too. The API is stable and hasn't been changed nor expanded by Steinberg for many years. It has been tested with audio production software like Reaper and FLS, with virtual instruments, amp simulations and other FX software from companies like Native Instruments, Ik Multimedia, Toontracks, Celemony and many others. The biggest problem is that the ASIO API is defined in the asio.h header file distributed by Steinberg in their ASIO SDK, and that the license explicitly forbids the distribution of any component by a third party. I imagine that this situation is not new to the Wine project and similar to other SDKs needed. I have a header file which I have created by compiling the driver without including asio.h, and then typing in the needed defines and structures while consulting asio.h. The header makes the driver work in both 32 and 64 bit wine. I propose to undertake the following: 1. Fix up the Wineasio code to confirm to Wine conventions and coding practices. 2. Merge it into Wine for conditional compilation on linux with Jack as a dependency. 3. Work together with the Wine project to merge in coreasio support for use on OS X. The latest sourcecode of the project is available at: git://git.code.sf.net/p/wineasio/code wineasio-git or as a tarball from: http://sourceforge.net/projects/wineasio/ Is this something that has any chance of getting accepted into Wine? -- Joakim

2 1

We're in at FOSDEM!
by Jeremy White 15 Oct '13

15 Oct '13

Hey folks, I thought I'd let everyone know that I applied for and we have been granted a room at FOSDEM again this year. I'm going to send a 'Call for Papers' separately. Cheers, Jeremy

1 0

Video Mixing Renderer 7
by Michael Müller 15 Oct '13

15 Oct '13

Hi, I am wondering what would be the best way to handle programs which rely on the Video Mixing Renderer 7 (quartz.dll) as it's supposed to be available on XP and later, but Wine contains only an implementation of version 9. The program I am speaking of is Silverlight which uses the VMR 7 Interface to create a filter graph and then queries for the IAMCertifiedOutputProtection interface. I am currently using a hack fix to get around this by returning a VMR9 instance when a VMR7 is requested and implementing the missing subinterfaces (which are only part of VMR7). This solution is clearly not perfect and I am searching for a better way to get around this issue. The most similar way to Windows would be to completely rewrite the current implementation of the VMR9 as VMR7 using DirectDraw, which would take a lot of time and most probably end up in having a lot of duplicate code. I am wondering whether using d3d9 for VMR7 would also be an acceptable solution. We could move all the d3d9 related stuff to a separate file so that VMR7.c and VMR9.c only offer the version specific interfaces and use the same code internally. This shouldn't be a big problem since the differences between the VMR7 and VMR9 interfaces are often only very small. Though it would not completely fit the behavior of windows. I am open for other ideas on how to solve the problem, but as Silverlight does not even use the VMR7 object for playing the video but only to check for the graphic driver certificate I don't think it would justify to rewrite everything using Direct Draw if there are no other programs needing this interface. Best Regards, Michael Müller

1 0

Re: wined3d: Initialize map_desc in wined3d_surface_map
by Marvin 15 Oct '13

15 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2784 Your paranoid android. === w864 (32 bit device) === device.c:2481: Test failed: Expected foreground window 000401A6, got 00010084. device.c:3174: Test failed: Expected wndproc 0x4107a0, got 0x4107a0. device: unhandled exception c0000005 at 742F14C8

1 0

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded (try 3)
by Nikolay Sivov 15 Oct '13

15 Oct '13

On 10/15/2013 18:57, Lasse Rasinen wrote: > According to debugging output, Artemis Spaceship Bridge Simulator 2.0 > calls LockRect twice on the same texture (for whatever reason) and crashes. > > http://bugs.winehq.org/show_bug.cgi?id=34271 > > The return values are cleared explicitly --- game is playable. > > Now with appropriate assignments and test output. > --- > dlls/d3d9/surface.c | 9 +++++++-- > dlls/d3d9/tests/device.c | 4 ++++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3d9/surface.c b/dlls/d3d9/surface.c > index 99f0b0f..20ccc68 100644 > --- a/dlls/d3d9/surface.c > +++ b/dlls/d3d9/surface.c > @@ -293,8 +293,13 @@ static HRESULT WINAPI d3d9_surface_LockRect(IDirect3DSurface9 *iface, > hr = wined3d_surface_map(surface->wined3d_surface, &map_desc, rect, flags); > wined3d_mutex_unlock(); > > - locked_rect->Pitch = map_desc.row_pitch; > - locked_rect->pBits = map_desc.data; > + if (SUCCEEDED(hr)) { > + locked_rect->Pitch = map_desc.row_pitch; > + locked_rect->pBits = map_desc.data; > + } else { > + locked_rect->Pitch = 0; > + locked_rect->pBits = NULL; > + } > > return hr; > } > diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c > index 02b4174..90d5c38 100644 > --- a/dlls/d3d9/tests/device.c > +++ b/dlls/d3d9/tests/device.c > @@ -5404,6 +5404,10 @@ static void test_lockrect_invalid(void) > ok(SUCCEEDED(hr), "Failed to lock surface with rect NULL, hr %#x.\n", hr); > hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); > ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); > + locked_rect.pBits = (BYTE *)0xdeadbeef; > + hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); > + ok(!SUCCEEDED(hr) && locked_rect.pBits == NULL, "Failed to clear pBits (%p)\n", > + locked_rect.pBits); > hr = IDirect3DSurface9_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr %#x.\n", hr); > It looks like you could use existing LockRect() call that's already tested as failing. Also I think FAILED() is a preferred way to test HRESULT value for failure, but as existing code does - you could also test for exact failure code.

2 1

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded (try 3)
by Marvin 15 Oct '13

15 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2783 Your paranoid android. === w864 (32 bit device) === device.c:5409: Test failed: Failed to clear pBits (DEADBEEF) device: unhandled exception c0000005 at 742814C8 === w864 (64 bit device) === device.c:5409: Test failed: Failed to clear pBits (00000000DEADBEEF) device: unhandled exception c0000005 at 000007F84EDD90EB

2 1

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded (try 3)
by Stefan Dösinger 15 Oct '13

15 Oct '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-10-15 16:57, schrieb Lasse Rasinen: > - locked_rect->Pitch = map_desc.row_pitch; - > locked_rect->pBits = map_desc.data; + if (SUCCEEDED(hr)) { + > locked_rect->Pitch = map_desc.row_pitch; + > locked_rect->pBits = map_desc.data; + } else { + > locked_rect->Pitch = 0; + locked_rect->pBits = NULL; + } You can handle this in wined3d/surface.c, wined3d_surface_map. Also, please follow the code style of the existing code. Curly brackets go in their own line. > + locked_rect.pBits = (BYTE *)0xdeadbeef; + hr = > IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); + > ok(!SUCCEEDED(hr) && locked_rect.pBits == NULL, "Failed to clear > pBits (%p)\n", + locked_rect.pBits); For the sake of completeness, please also test locked_rect.Pitch and port the test to d3d8. Ddraw already has a test in dsurface.c. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSXVwzAAoJEN0/YqbEcdMw1CQP/2Lk2v78Ws8BGh1x4MvaXj/x YhJQ1d44bqP9B8+H7E3NKWuwZ6ywNmxvH+Mq59nbNKdfBrxvTezIA2PDLEsNwWJa hl/Q4St61K1XkExmu+48tyxtT3BS8P2g60Z50V8VIfrUh/3qqquXq79tki9XqYSr vtuFLuJyHECzYq7hQ+BZqbudwSSf42ZQfX0wNpa4wuZ2uX/PzA4ku0R/zvHzaMTh HoOrlIxX9hvCF/y5y7v0SAeYT83nMCkUBOZ8EMoDqv81btLDCqdFedtlFz2gTO0P O2vaGzSH0NPU+umIU9rEXUwq3H2gJdFcTG4FujQNsoVSaliXz24OzVTCEc1PvuWz eo+zMhxfG05xNSsb6Yh+fATnOPP6YDWYukS42kmalZ+V5WGlwxxKd4jgfONjCqzH JsIcqbmlxkWN9bPB9k3mIMMDHZ1PClI3GFm1XVMnc4Vas2/FF/IAAK/yPpIV2O/R fJkz4PKcha8P9V/yNlGJrmHYq/Dy7mW9xANmQ4gKv9wm0iqHoUGrDorX7OptskHL ua0pOFmWIXHRtzFysctZ/w6QkKX/e9Vwh/hRWIBhN2JOliu5AZuqQESbqe/rCwZR Flje6p9RaxlqgIzxxK1GQawpQ05NP3y8oS1MIe+mGr4c6sk8KO5d6aUgNVo4jcdY 4OAnKqN3lNbqDZgNEg91 =32E8 -----END PGP SIGNATURE-----

1 0

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded (try 2)
by Marvin 15 Oct '13

15 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2776 Your paranoid android. === w864 (32 bit device) === device.c:5409: Test failed: Failed to clear pBits (DEADBEEF)device.c:5588: Tests skipped: Failed to create surface for format D3DFMT_R8G8B8 (hr 0x8876086c), skipping tests. device: unhandled exception c0000005 at 740D14C8 === w864 (64 bit device) === device.c:5409: Test failed: Failed to clear pBits (00000000DEADBEEF)device.c:5588: Tests skipped: Failed to create surface for format D3DFMT_R8G8B8 (hr 0x8876086c), skipping tests. device: unhandled exception c0000005 at 000007F84EDD90EB

1 0

Re: [00/11] msi/tests: Prepare action.c for the switch to -D__WINESRC__.
by Marvin 15 Oct '13

15 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2775 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [10/11] msi/tests: Prepare msi.c for the switch to -D__WINESRC__.
by Marvin 15 Oct '13

15 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2769 Your paranoid android. === wvista (32 bit msi) === The test timed out === w2008s64 (32 bit msi) === The test timed out === w7pro64 (32 bit msi) === Timeout === w2008s64 (64 bit msi) === Timeout === w7pro64 (64 bit msi) === Timeout

1 0

Re: [11/11] msi/tests: Compile with -D__WINESRC__.
by Marvin 15 Oct '13

15 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2770 Your paranoid android. === build (build) === Make failed

1 0

Re: [04/11] msi/tests: Prepare install.c for the switch to -D__WINESRC__.
by Marvin 15 Oct '13

15 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2763 Your paranoid android. === wxppro (32 bit install) === No test summary line found Failure running script in VM: network read timed out === wvista (32 bit install) === Timeout === w2008s64 (32 bit install) === Failure running script in VM: network read timed out === w7pro64 (32 bit install) === Timeout Failure running script in VM: timed out waiting for the child process === w864 (32 bit install) === install.c:2439: Test failed: Directory not created === w2008s64 (64 bit install) === Timeout

1 0

Re: dlls/explorerframe: build tests with -D__WINESRC__
by Marvin 14 Oct '13

14 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2750 Your paranoid android. === wvista (32 bit nstc) === nstc.c:1934: Test failed: Got event 7, count 0 nstc.c:1936: Test failed: Got event 4, count 0 nstc.c:1949: Test failed: Got event 4, count 0

1 0

Re: wsock32: Add a fallback for inet_network.
by Alexandre Julliard 14 Oct '13

14 Oct '13

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/wsock32/protocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This doesn't build on MingW: protocol.o: In function `WSOCK32_inet_network@4': /home/julliard/wine/build/obj-pe32/dlls/wsock32/../../../wine/dlls/wsock32/protocol.c:55: undefined reference to `_inet_addr' /home/julliard/wine/build/obj-pe32/dlls/wsock32/../../../wine/dlls/wsock32/protocol.c:55: undefined reference to `_ntohl' collect2: ld returned 1 exit status winegcc: i686-w64-mingw32-gcc failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Help / Mentoring
by Hugh McMaster 14 Oct '13

14 Oct '13

Hi everyone, I just wanted to know if anyone would mind helping/mentoring me with a few small patches. I am working primarily on wineconsole's screen buffer problems (to which I believe I have the solution), but am also looking at implementing some stub Win32 console functions found in dlls/kernel32. Obviously, my aim is to have these patches committed, as the changes will benefit the entire Wine community. I had initially thought of Eric Poeuch, a significant wineconsole developer, however he appears to be extremely busy. So I'm not sure who else to contact. If time is a consideration, please note that I won't be constantly contacting you to review patches or answer questions. Thank you, Hugh

2 3

Re: [PATCH] d3drm: added some freeing of memory in error paths (Coverity)
by Henri Verbeet 14 Oct '13

14 Oct '13

On 13 October 2013 11:13, Marcus Meissner <marcus(a)jet.franken.de> wrote: > 1104553 Resource leak > Fixing the memory leak is fine of course, but I think it would be better to handle the array initialization in d3drm_visual_array_create() etc. instead, so that those functions actually return an object that's properly initialized.

1 0

Re: [2/4] dnsapi/tests: Compile with -D__WINESRC__.
by Marvin 14 Oct '13

14 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2733 Your paranoid android. === wxppro (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === wvista (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w2008s64 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w7pro64 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w864 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w2008s64 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w7pro64 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w864 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly

1 0

Re: ntdll: Support pinning module refcount with LdrAddRefDll()
by Dmitry Timoshkov 14 Oct '13

14 Oct '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + FreeLibrary(mod); Please add the tests for FreeLibrary return value. -- Dmitry.

2 1

d3d11 patch
by Max . 13 Oct '13

13 Oct '13

Hi, I would like to know when the first patchs for d3d11 will be introduce into wine ? Beginning of 2014 ? middle 2014 ? End 2014 ? Thanks,

2 2

MSYS touch.exe timestamp resolution issue on Wine-1.6
by Alan W. Irwin 13 Oct '13

13 Oct '13

Under MSYS bash.exe if I use the touch command I only get 1-second resolution when reading the results. bash.exe-3.1$ touch touch1.test touch2.test bash.exe-3.1$ ls --full-time touch*.test -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.000000000 -0700 touch1.test -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.000000000 -0700 touch2.test Would somebody be willing to make the above test for MSYS on the Microsoft version of Windows (which I don't have access to) to see if time stamps are being read with 1-second resolution as above. That test should help distinguish whether this is a Wine issue or else an MSYS issue. I have also done some tests with the MSYS find.exe and make.exe commands, and in all cases touch2.test is not newer than touch1.text. This can be an important issue for the make command where one-second time resolution can potentially screw up file dependencies. If I use the equivalent Linux ls (and find and make) commands to read the time stamps on the above files, then touch2.test is newer than touch1.text, e.g., wine@raven> ls --full-time touch*.test -rw-r--r-- 1 wine wine 0 2013-10-12 13:57:58.391000000 -0700 touch1.test -rw-r--r-- 1 wine wine 0 2013-10-12 13:57:58.408000000 -0700 touch2.test So I think this implies the MSYS touch.exe command is writing high-resolution (i.e., millisecond) time stamps, and it is only reading that high-resolution time stamp that seems to be an issue for MSYS on Wine. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

3 2

Re: mscoree: Add support for ICLRMetaHostPolicy interface
by Dmitry Timoshkov 13 Oct '13

13 Oct '13

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +static HRESULT WINAPI metahostpolicy_QueryInterface(ICLRMetaHostPolicy *iface, REFIID riid, void **ppvObject) > +{ > + TRACE("%s %p\n", debugstr_guid(riid), ppvObject); > + > + if ( IsEqualGUID( riid, &IID_ICLRMetaHostPolicy ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > + { > + *ppvObject = iface; > + } > + else > + { > + FIXME("Unsupported interface %s\n", debugstr_guid(riid)); > + return E_NOINTERFACE; > + } > + > + ICLRMetaHostPolicy_AddRef( iface ); > + > + return S_OK; > +} I think that a common COM convention is to set the object pointer to NULL in case of an unsupported interface. Also you're doing pretty good job in avoiding hungarian notation except for ppvObject. Another nitpick is the choice for if/else construct (although I understand that other places also use this sub-optimal one). A more elegant way of implementing QueryInterface would be IMHO: static HRESULT WINAPI xxx_QueryInterface(IFace *iface, REFIID riid, void **object) { if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IAnotherSupported) { xxx_AddRef(iface); *object = iface; return S_OK; } *object = NULL; return E_NOINTERFACE; } -- Dmitry.

1 0

Re: winmm/tests: Use BOOL type where appropriate
by Marvin 11 Oct '13

11 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2721 Your paranoid android. === wxppro (32 bit wave) === wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13211 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13229 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13075 bytes, should be 13230 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13091 samples (13091 bytes), should be 13230 (13230 bytes) wave.c:522: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 594 ms, (13108 bytes), should be 600 (13230 bytes) wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13220 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 17621 bytes, should be 17640 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 17634 samples (17634 bytes), should be 17640 (17640 bytes) wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 22016 bytes, should be 22050 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 22027 samples (22027 bytes), should be 22050 (22050 bytes) wave.c:522: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 999 ms, (22044 bytes), should be 1000 (22050 bytes)

1 0

Re: wined3d: Use BOOL type where appropriate
by Henri Verbeet 11 Oct '13

11 Oct '13

On 11 October 2013 22:51, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - DWORD onesided_enable = FALSE; > - DWORD twosided_enable = FALSE; > + DWORD onesided_enable = 0; > + DWORD twosided_enable = 0; Actually, all of those initializations are redundant.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel