- wine-devel - winehq.org

Re: (try 6)[5/5] imm32: limit cross thread access to ImmSet* functions
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2377 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 6)[4/5] imm32: Restrict crossthread Association and destruction
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2376 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 6)[3/5] imm32: use thread data from target HWND
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2375 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] mshtml: Added IHTMLFormElement::sumit tests.
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2374 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] appwiz.cpl: Use the same dialog template for Mono and Gecko downloader.
by Vincent Povirk 27 Sep '13

27 Sep '13

Isn't this going to make the caption "Wine Gecko Installer" in both cases?

1 0

Re: add ualapi directory (try 10)
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2370 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.
by Stefan Dösinger 27 Sep '13

27 Sep '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-09-27 00:15, schrieb Henri Verbeet: > - swapchain->swapchain_ops->swapchain_present(swapchain, > src_rect, dst_rect, dirty_region, flags); + > wined3d_cs_emit_present(swapchain->device->cs, swapchain, > src_rect, + dst_rect, dst_window_override, dirty_region, > flags); I think we should place comments like "This function is called through the command stream" for all functions that are called through the CS, similar to what we do for context activation. Also note that swapchain_gl_present contains calls to wined3d_surface_blt and wined3d_device_clear that are going to cause problems with the multithreaded CS. I have patches to remove them, so feel free to ignore this problem for now. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSRWaKAAoJEN0/YqbEcdMw9VgP/i2n/G2CHOA8XShC8CZnRzSq TNzbfIXwAQljQYtf66U98JmbMIoeS3SMPaJ4O1+mMiT062Udi3YddiTk2AVF9bi+ f6X4y9W8Q3jPolcuTxKpZ26/WFkViHtPEUtFaa5oBtksCNGZ0b3A4oK9zbrPBram EXwovsq649RqCoBf76aidtbypdkFKLfmC6P6KxtjB3C9cdKJ58kMD0YbVsua6zNc g8gUgExEQ0no9WEyWPtlN7PRf3tQlLtuUeqrRockqnK48cKbwk3VaEgfq8o6+INs EvgjoZvc2C/+YoEWUT+n7nCtIKo9IiMSG20Ey0sbmak/K/LrvZvsyHl78nQD4ss+ t5jRCS9QZs/VzJc0VakGsZARP9jGBvzapsrAcy6Ittu1d53fpji6ySwKeUrPKim+ wMtWGtu+q0FXtIRtgDYUOofd9b1o1sB3xPqUIpRm7+yBRpXiBvuGqbmbsa/14wBe vkI5b5S/djskw9M5bV1lAOCgGmo+zFIYyebxwvx8H+sqz4HmYql9uPLTOHqWvHtn J7iXcETOlcOrC+zOOT8nieR8YYuFcda51auvK5lnXtCTQvoQse5egV16x2hJkkjx Pujit58jX2/O0WS0hqR5oAfhYtPydqUf2BayXgkLUODiZa0z1UWD2eerlOvGSvcq AUs+vi2QpDjeWmQH37BZ =QcW+ -----END PGP SIGNATURE-----

2 3

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)
by Alexandre Julliard 27 Sep '13

27 Sep '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Fixes bug 18440, 20847. > > Try 3: > - Rebase to recent source. > - Separate ABC metrics change. > - Use conditional operator. It breaks the tests: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so dib.c && touch dib.ok dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 make[1]: *** [dib.ok] Error 19 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 5)
by Nikolay Sivov 27 Sep '13

27 Sep '13

On 9/13/2013 13:27, Jactry Zeng wrote: > Re-based to latest git. > > Does it actually accept any other value besides CP_ACP or 1200? Documentation is unclear here, and makes impression that only two these values are valid.

2 2

Re: ntdll: Make asynchronous WaitCommEvent report correct number of bytes returned.
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2356 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2351 Your paranoid android. === w7u (32 bit font) === The test timed out

1 0

Re: [3/3] gdi32: Don't modify output glyph metrics unless the function succeeds. (try 2)
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2352 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/3] gdi32: Return GDI_ERROR when requested empty glyph bitmaps. (try 2)
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2350 Your paranoid android. === w7u (32 bit font) === No test summary line found Failure running script in VM: network read timed out

1 0

Re: [PATCH 1/2] gdi32: fix for rotated Arc, ArcTo, Chord and Pie drawing problem (try 2)
by Alexandre Julliard 26 Sep '13

26 Sep '13

Daniel Wendt <daniel.wendt(a)linux.com> writes: > @@ -308,6 +308,11 @@ static int get_arc_points( PHYSDEV dev, const RECT *rect, POINT start, POINT end > } > > memmove( points, points + count, (pos - count) * sizeof(POINT) ); > + > + if (GetGraphicsMode( dev->hdc ) == GM_ADVANCED) > + { > + LPtoDP( dev->hdc, points, pos - count ); > + } > return pos - count; > } > > @@ -322,7 +327,17 @@ static BOOL draw_arc( PHYSDEV dev, INT left, INT top, INT right, INT bottom, > BOOL ret = TRUE; > HRGN outline = 0, interior = 0; > > - if (!get_pen_device_rect( pdev, &rect, left, top, right, bottom )) return TRUE; > + if (GetGraphicsMode(dev->hdc ) != GM_ADVANCED) > + { > + if (!get_pen_device_rect( pdev, &rect, left, top, right, bottom )) return TRUE; > + } > + else > + { > + rect.left = left; > + rect.top = top; > + rect.right = right; > + rect.bottom = bottom; > + } I don't think that you want to draw arcs in logical space, that can be very inefficient. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation (try2)
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2349 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: imm32: ImmGetDescriptionA return does not include NULL byte
by Alexandre Julliard 26 Sep '13

26 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1684,7 +1684,7 @@ UINT WINAPI ImmGetDescriptionA( > > HeapFree( GetProcessHeap(), 0, buf ); > > - return len; > + return min( len - 1, uBufLen ); > } This may do the right thing on failure, but in an ugly way. A few overflow tests would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] riched20: Implement ITextDocument_fnOpen.
by Alexandre Julliard 26 Sep '13

26 Sep '13

Jactry <jactry92(a)gmail.com> writes: > + chBuffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size+2); > + if(!chBuffer) > + { > + CloseHandle(hFile); > + return HRESULT_FROM_WIN32(GetLastError()); > + } It's not useful to zero the buffer since you are reading into it. Also GetLastError won't do anything useful here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)
by Alexandre Julliard 26 Sep '13

26 Sep '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -6519,11 +6519,17 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, > } > > lpgm->gmBlackBoxX = (right - left) >> 6; > + if (lpgm->gmBlackBoxX == 0) > + lpgm->gmBlackBoxX = 1; > lpgm->gmBlackBoxY = (top - bottom) >> 6; > + if (lpgm->gmBlackBoxY == 0) > + lpgm->gmBlackBoxY = 1; > lpgm->gmptGlyphOrigin.x = origin_x >> 6; > lpgm->gmptGlyphOrigin.y = origin_y >> 6; > abc->abcA = left >> 6; > abc->abcB = (right - left) >> 6; > + if (abc->abcB == 0) > + abc->abcB = 1; > abc->abcC = adv - abc->abcA - abc->abcB; It would be a good idea to add tests for the ABC metrics too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard 26 Sep '13

26 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -530,12 +591,18 @@ static BOOL CALLBACK _ImmAssociateContextExEnumProc(HWND hwnd, LPARAM lParam) > */ > BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > { > + IMMThreadData* thread_data = NULL; > + > TRACE("(%p, %p, 0x%x):\n", hWnd, hIMC, dwFlags); > > - if (!IMM_GetThreadData()->defaultContext) > - IMM_GetThreadData()->defaultContext = ImmCreateContext(); > + thread_data = IMM_GetInitializedThreadData(); > + if (!thread_data) > + return FALSE; > > - if (!hWnd) return FALSE; > + LeaveCriticalSection(&threaddata_cs); > + > + if (!hWnd) > + return FALSE; > > switch (dwFlags) > { > @@ -543,7 +610,7 @@ BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > ImmAssociateContext(hWnd,hIMC); > return TRUE; > case IACE_DEFAULT: > - ImmAssociateContext(hWnd,IMM_GetThreadData()->defaultContext); > + ImmAssociateContext(hWnd,thread_data->defaultContext); > return TRUE; > case IACE_IGNORENOCONTEXT: > if (GetPropW(hWnd,szwWineIMCProperty)) You shouldn't be accessing thread data outside of the critical section. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2346 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: kernel32/tests: Add DuplicateHandle test to the file access tests.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2345 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2344 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2343 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2342 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2341 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2340 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Perform the offset checks in NtWriteFile also for a serial device.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2339 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Perform the offset checks also for a serial device.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2267 Your paranoid android. === w7pro64 (32 bit comm) === comm.c:863: Test failed: WaitCommEvent failed with a timeout comm.c:875: recovering after WAIT_TIMEOUT... comm.c:886: Test failed: WaitCommEvent error 0 comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:892: WaitCommEvent for EV_TXEMPTY took 1014 ms (timeout 1000) comm.c:894: Test failed: WaitCommEvent used 1014 ms for waiting comm.c:1561: test_AbortWaitCts timeout 500 handle 000000F8 comm.c:1528: Changing CommMask on the fly for handle 000000F8 after timeout 500

3 7

Re: [2/2] oledb32: Implement IDataSourceLocator get/put hWnd (try 2)
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2338 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: user32: Avoid using CONST.
by Marvin 25 Sep '13

25 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2332 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/5] winex11: Splitted functions X11DRV_FocusOut and X11DRV_ReparentNotify
by Alexandre Julliard 25 Sep '13

25 Sep '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > --- > dlls/winex11.drv/event.c | 99 > +++++++++++++++++++++++++++------------------- > 1 file changed, 58 insertions(+), 41 deletions(-) These should go in the patches that need them. Also you should start your series with reparent support, the rest doesn't make sense without it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.
by Matteo Bruni 25 Sep '13

25 Sep '13

2013/9/24 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/effect.c | 248 > +++++++++++++++++++------------------------------ > 1 Datei geändert, 95 Zeilen hinzugefügt(+), 153 Zeilen entfernt(-) > I definitely like the direction this patch takes. @@ -5068,6 +5009,9 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * param = state->parameter; + /* + * TODO: Do we need to create the shader/string here or later when we access them? + */ Here it's fine AFAICS. What are the other options you are thinking about? Something like creating the shaders at the first Begin / BeginPass call?

3 2

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)
by Jacek Caban 25 Sep '13

25 Sep '13

Hi Hans, On 09/18/13 13:40, Hans Leidekker wrote: > diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c > index bf57223..2526681 100644 > --- a/dlls/wininet/tests/http.c > +++ b/dlls/wininet/tests/http.c > @@ -4777,8 +4777,37 @@ static const struct notification async_send_request_ex_resolve_failure_test[] = > { internet_close_handle, INTERNET_STATUS_HANDLE_CLOSING, 0, } > }; > > +static const struct notification async_send_request_ex_chunked_test[] = > +{ > + { internet_connect, INTERNET_STATUS_HANDLE_CREATED }, > + { http_open_request, INTERNET_STATUS_HANDLE_CREATED }, > + { http_send_request_ex, INTERNET_STATUS_DETECTING_PROXY, 1, 0, 1 }, > + { http_send_request_ex, INTERNET_STATUS_COOKIE_SENT, 1, 0, 1 }, > + { http_send_request_ex, INTERNET_STATUS_RESOLVING_NAME, 1, 0, 1 }, > + { http_send_request_ex, INTERNET_STATUS_NAME_RESOLVED, 1, 0, 1 }, > + { http_send_request_ex, INTERNET_STATUS_CONNECTING_TO_SERVER, 1 }, > + { http_send_request_ex, INTERNET_STATUS_CONNECTED_TO_SERVER, 1 }, > + { http_send_request_ex, INTERNET_STATUS_SENDING_REQUEST, 1 }, > + { http_send_request_ex, INTERNET_STATUS_REQUEST_SENT, 1 }, > + { http_send_request_ex, INTERNET_STATUS_REQUEST_COMPLETE, 1 }, > + { http_end_request, INTERNET_STATUS_RECEIVING_RESPONSE, 1 }, > + { http_end_request, INTERNET_STATUS_RESPONSE_RECEIVED, 1 }, > + { http_end_request, INTERNET_STATUS_REQUEST_COMPLETE, 1 }, > + { internet_close_handle, INTERNET_STATUS_CLOSING_CONNECTION }, > + { internet_close_handle, INTERNET_STATUS_CONNECTION_CLOSED }, > + { internet_close_handle, INTERNET_STATUS_HANDLE_CLOSING }, > + { internet_close_handle, INTERNET_STATUS_HANDLE_CLOSING } > +}; > + > static const struct notification_data notification_data[] = { > { > + async_send_request_ex_chunked_test, > + sizeof(async_send_request_ex_chunked_test)/sizeof(async_send_request_ex_chunked_test[0]), > + "GET", > + "test.winehq.org", > + "tests/data.php" > + }, > + { > async_send_request_ex_test, > sizeof(async_send_request_ex_test)/sizeof(async_send_request_ex_test[0]), > "POST", > @@ -5100,6 +5129,7 @@ START_TEST(http) > test_async_HttpSendRequestEx(&notification_data[0]); > test_async_HttpSendRequestEx(&notification_data[1]); > test_async_HttpSendRequestEx(&notification_data[2]); > + test_async_HttpSendRequestEx(&notification_data[3]); > InternetOpenRequest_test(); > test_http_cache(); > InternetOpenUrlA_test(); I was hoping for a test like the attached one, which shows that there is still more work to do. But it's a step in the right direction, so I'm fine with your patch. Thanks, Jacek

2 2

Re: (try 5) [2/4] imm32: do not let ImmDestroyContext destroy any default contexts
by Nikolay Sivov 25 Sep '13

25 Sep '13

On 9/25/2013 16:03, Aric Stewart wrote: > defaultContext = ImmCreateContext(); > + if (defaultContext) > + ((InputContextData*)defaultContext)->threadDefault = TRUE; I think a nicer way is to let ImmCreateContext() set this attribute.

2 1

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list
by Nikolay Sivov 25 Sep '13

25 Sep '13

On 9/25/2013 16:03, Aric Stewart wrote: > + if (!thread_data->defaultContext) > + { > + HIMC defaultContext; > + LeaveCriticalSection(&threaddata_cs); > + defaultContext = ImmCreateContext(); > + thread_data = IMM_GetThreadData(0); Why do you need to unlock/lock around ImmCreateContext()? Is it related to SendMessage() it calls?

2 1

Re: (try 4)[1/4] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard 25 Sep '13

25 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/imm32/imm.c | 153 +++++++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 116 insertions(+), 37 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok err:ntdll:RtlpWaitForCriticalSection section 0x55ec38e8 "imm.c: threaddata_cs" wait timed out in thread 005c, blocked by 0031, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7bccc200 "loader.c: loader_section" wait timed out in thread 0060, blocked by 005c, retrying (60 sec) -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine Gecko 2.24-beta1
by Jacek Caban 25 Sep '13

25 Sep '13

Hi all, It's time to do another update of Wine Gecko, so I prepared a new beta build. It's already on Sourceforge [1]. Until server-side support for auto install of the package is committed [2], its manual installation is required [3]. I attached a patch to Wine that is required for the new Gecko. Anything that uses MSHTML is worth testing. All help with testing is appreciated! Cheers, Jacek [1] https://sourceforge.net/projects/wine/files/Wine%20Gecko/2.24-beta1/ [2] http://source.winehq.org/patches/data/97881 [3] http://wiki.winehq.org/Gecko

2 2

Re: crypt32: Support HCCE_LOCAL_MACHINE.
by Juan Lang 25 Sep '13

25 Sep '13

Hi Ben, thanks for having a whack at this. Some tests would be nice. -static HCERTCHAINENGINE CRYPT_defaultChainEngine; +/* There are two default chain engines which correspond to HCCE_CURRENT_USER and + * HCCE_LOCAL_MACHINE. +*/ +static HCERTCHAINENGINE CRYPT_defaultChainEngine[2] = { NULL, NULL }; C automatically initializes statics to 0, so the initialization here is unnecessary. I'm also a little uncertain about the use of an array of two objects, I'm not sure that two distinct objects wouldn't be easier to follow, but I'm not religious on this point. + if (hChainEngine > HCCE_LOCAL_MACHINE + && InterlockedDecrement(&engine->ref) == 0) I think a function that returns whether an HCERTCHAINENGINE is one of the special ones would make this easier to read, e.g.: static int is_special_chain_engine(HCERTCHAINENGINE h) { return h == HCCE_CURRENT_USER || h == HCCE_LOCAL_MACHINE; } then: + if (is_special_chain_engine(hChainEngine) + && InterlockedDecrement(&engine->ref) == 0) +static HCERTCHAINENGINE CRYPT_GetDefaultChainEngine(HCERTCHAINENGINE h) { - if (!CRYPT_defaultChainEngine) + if (!CRYPT_defaultChainEngine[(int)h]) The constant casting is a little awkward. At least introduce a local pointer to the one you intend to modify, so we're not constantly having to re-read that cast. + if (hChainEngine <= HCCE_LOCAL_MACHINE) + engine = (CertificateChainEngine*)CRYPT_GetDefaultChainEngine( + hChainEngine); if (TRACE_ON(chain)) dump_chain_para(pChainPara); /* FIXME: what about HCCE_LOCAL_MACHINE? */ See my earlier suggestion on is_special_chain_engine. Also, what about that comment three lines down? Can't it be removed? -void default_chain_engine_free(void) +void default_chain_engine_free(HCERTCHAINENGINE h) { - CertFreeCertificateChainEngine(CRYPT_defaultChainEngine); + CertFreeCertificateChainEngine(CRYPT_defaultChainEngine[(int)h]); The function default_chain_engine_free is a thin wrapper around CryptFreeCertificateChainEngine; its intended use is to clear memory at shutdown. Rather than shift the responsibility of knowing which engines to free to the caller, just have it free the two engines itself. Thanks, --Juan

1 0

Re: [2/2] oleaut32: LoadRegTypeLib() should check actual typelib version
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2330 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 3) [1/4] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard 24 Sep '13

24 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -443,6 +473,28 @@ static InputContextData* get_imc_data(HIMC hIMC) > return data; > } > > +static BOOL ensure_default_imc(IMMThreadData** thread_data) > +{ > + if (!(*thread_data)->defaultContext) > + { > + HIMC defaultContext; > + LeaveCriticalSection(&threaddata_cs); > + defaultContext = ImmCreateContext(); > + *thread_data = IMM_GetThreadData(0); > + if (!(*thread_data)) > + { > + IMM_DestroyContext(defaultContext); > + return FALSE; > + } > + > + if ((*thread_data)->defaultContext) /* someone beat us */ > + IMM_DestroyContext(defaultContext); > + else > + (*thread_data)->defaultContext = defaultContext; > + } > + return TRUE; > +} That's fairly inelegant, try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: Android has struct user in asm/user.h
by André Hentschel 24 Sep '13

24 Sep '13

Am 24.09.2013 17:13, schrieb Huw Davies: > --- > configure.ac | 1 + > server/ptrace.c | 8 +++++++- > 2 files changed, 8 insertions(+), 1 deletion(-) is that for the warning about the missing casts?

2 1

Virus spread via wine
by Dan Kegel 24 Sep '13

24 Sep '13

Fun times: http://bugs.winehq.org/show_bug.cgi?id=34556

2 3

Re: [PATCH 4/5] d3d8/tests: Add a volume V16U16 test.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2318 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2317 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: server/protocol.def and array types
by Hugh McMaster 24 Sep '13

24 Sep '13

Any help for this? -------------------------------------------------------------- I'm testing support for GetConsoleScreenBufferInfoEx. At the moment, I've extended the screen_buffer struct in server/console.c to look like this: struct screen_buffer { struct object obj; /* object header */ struct list entry; /* entry in list of all screen buffers */ struct console_input *input; /* associated console input */ int mode; /* output mode */ int cursor_size; /* size of cursor (percentage filled) */ int cursor_visible;/* cursor visibility flag */ int cursor_x; /* position of cursor */ int cursor_y; /* position of cursor */ int width; /* size (w-h) of the screen buffer */ int height; int max_width; /* size (w-h) of the window given font size */ int max_height; char_info_t *data; /* the data for each cell - a width x height matrix */ unsigned short attr; /* default attribute for screen buffer */ rectangle_t win; /* current visible window on the screen buffer * * as seen in wineconsole */ struct fd *fd; /* for bare console, attached output fd */ unsigned short popup_attr; /* the console popup fill attribute */ BOOL fullscreen; /* indicates whether fullscreen mode is supported */ COLORREF colortable[16];/* an array of DWORD values */ }; In server/protocol.def I have: @REQ(get_console_output_info) obj_handle_t handle; /* handle to the console */ @REPLY short int cursor_size; /* size of cursor (percentage filled) */ short int cursor_visible;/* cursor visibility flag */ short int cursor_x; /* position of cursor (x, y) */ short int cursor_y; short int width; /* width of the screen buffer */ short int height; /* height of the screen buffer */ short int attr; /* default attribute */ short int win_left; /* window actually displayed by renderer */ short int win_top; /* the rect area is expressed within the */ short int win_right; /* boundaries of the screen buffer */ short int win_bottom; short int max_width; /* maximum size (width x height) for the window */ short int max_height; short int popup_attr; /* the console popup fill attribute */ short int fullscreen; /* indicates whether fullscreen mode is supported */ --> type??? colortable; /* a COLORREF array of DWORD values */ @END While colortable is a COLORREF array, protocol.def does not allow types such as DWORD, COLORREF, etc. What type should colortable be given to pass tools/make_requests?

1 0

Re: [PATCH 5/5] ddraw: Avoid VOID.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2316 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: add ualapi directory (try 9
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2313 Your paranoid android. === build (build) === Missing build status line The build timed out

2 1

Re: advapi32/tests: Mark a test result as broken.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2315 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/2] winhttp/tests: Remove explicit zero-intialization of static data.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2314 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] wined3d: Introduce a function to initialize swapchain specific device state.
by Alexandre Julliard 24 Sep '13

24 Sep '13

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/wined3d/device.c | 51 +++++++++++++++++---------------------------- > dlls/wined3d/stateblock.c | 5 +---- > 2 files changed, 20 insertions(+), 36 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dxgi.dll -T ../../.. -p dxgi_test.exe.so device.c && touch device.ok wine: Unhandled page fault on read access to 0x0000002c at address 0x686aa077 (thread 004f), starting debugger... Unhandled exception: page fault on read access to 0x0000002c in 32-bit code (0x686aa077). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:686aa077 ESP:0032f890 EBP:0032f978 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:6879e6d0 ECX:0032f9e0 EDX:00000000 ESI:0014e23c EDI:00000000 Stack dump: 0x0032f890: 00000001 00000001 00000000 567a5784 0x0032f8a0: 0000851a 00000000 00008058 00000001 0x0032f8b0: 00000001 00000001 00000000 00000000 0x0032f8c0: 0000001e 00000012 0032f9ec 00000000 0x0032f8d0: 00000001 00000000 00000000 00000000 0x0032f8e0: 00000000 7e0bd298 0032f9ec 00008035 Backtrace: =>0 0x686aa077 device_clear_render_targets+0x77(device=0x142208, rt_count=0x8, fb=0x14e23c, rect_count=0, rects=(nil), draw_rect=0x32f9e0, flags=0x1, color=0x6875e2bc, depth=1.000000, stencil=0) [/home/julliard/wine/wine/dlls/wined3d/device.c:219] in wined3d (0x0032f978) 1 0x686b0b67 wined3d_device_clear+0x136(device=0x142208, rect_count=0, rects=(nil), flags=0x1, color=0x6875e2bc, depth=1.000000, stencil=0) [/home/julliard/wine/wine/dlls/wined3d/device.c:3501] in wined3d (0x0032fa08) 2 0x686b613c wined3d_device_init_3d+0x3fb(device=<couldn't compute location>, swapchain_desc=<couldn't compute location>) [/home/julliard/wine/wine/dlls/wined3d/device.c:940] in wined3d (0x0032fa98) 3 0x6864d008 dxgi_factory_CreateSwapChain+0x127(iface=<couldn't compute location>, device=<couldn't compute location>, desc=<couldn't compute location>, swapchain=<couldn't compute location>) [/home/julliard/wine/wine/dlls/dxgi/factory.c:232] in dxgi (0x0032fb38) 4 0x6862b5aa func_device+0x13f9() [/home/julliard/wine/wine/dlls/dxgi/tests/../../../include/dxgi.h:2037] in dxgi_test (0x0032fcf8) 5 0x6862c165 run_test+0x144(name=<is not available>) [/home/julliard/wine/wine/dlls/d3d10core/tests/../../../include/wine/test.h:570] in dxgi_test (0x0032fd48) 6 0x68629c23 main+0x152(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/d3d10core/tests/../../../include/wine/test.h:640] in dxgi_test (0x0032fe08) 7 0x6862cbb0 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in dxgi_test (0x0032fe58) 8 0x7b85f36c call_process_entry+0xb() in kernel32 (0x0032fe78) 9 0x7b86054b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1084] in kernel32 (0x0032feb8) 10 0x7bc7fd50 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 11 0x7bc82c5d call_thread_func+0x7c(entry=0x7b8604e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 12 0x7bc7fd2e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 13 0x7bc5492e start_process+0x1d(kernel_start=0x7b8604e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2694] in ntdll (0x0032ffe8) 14 0x6803125d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 15 0x6803131b wine_switch_to_stack+0x2a(func=0x7bc54910, arg=0x7b8604e0, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff8613b8) 16 0x7bc5a467 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2750] in ntdll (0xff861428) 17 0x7b866ac0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1256] in kernel32 (0xff862338) 18 0x7bc5ab33 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2959] in ntdll (0xff8623c8) 19 0x6802eea2 wine_init+0x2a1(argc=0x3, argv=0xff862904, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:847] in libwine.so.1 (0xff862428) 20 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff862868) 21 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x686aa077 device_clear_render_targets+0x77 [/home/julliard/wine/wine/dlls/wined3d/device.c:219] in wined3d: movl 0x2c(%edx),%eax 219 || draw_rect->right < target->resource.width -- Alexandre Julliard julliard(a)winehq.org

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel