- wine-devel - winehq.org

Re: [PATCH 3/5] wined3d: Introduce a function to initialize swapchain specific device state.
by Alexandre Julliard 24 Sep '13

24 Sep '13

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/wined3d/device.c | 51 +++++++++++++++++---------------------------- > dlls/wined3d/stateblock.c | 5 +---- > 2 files changed, 20 insertions(+), 36 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dxgi.dll -T ../../.. -p dxgi_test.exe.so device.c && touch device.ok wine: Unhandled page fault on read access to 0x0000002c at address 0x686aa077 (thread 004f), starting debugger... Unhandled exception: page fault on read access to 0x0000002c in 32-bit code (0x686aa077). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:686aa077 ESP:0032f890 EBP:0032f978 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:6879e6d0 ECX:0032f9e0 EDX:00000000 ESI:0014e23c EDI:00000000 Stack dump: 0x0032f890: 00000001 00000001 00000000 567a5784 0x0032f8a0: 0000851a 00000000 00008058 00000001 0x0032f8b0: 00000001 00000001 00000000 00000000 0x0032f8c0: 0000001e 00000012 0032f9ec 00000000 0x0032f8d0: 00000001 00000000 00000000 00000000 0x0032f8e0: 00000000 7e0bd298 0032f9ec 00008035 Backtrace: =>0 0x686aa077 device_clear_render_targets+0x77(device=0x142208, rt_count=0x8, fb=0x14e23c, rect_count=0, rects=(nil), draw_rect=0x32f9e0, flags=0x1, color=0x6875e2bc, depth=1.000000, stencil=0) [/home/julliard/wine/wine/dlls/wined3d/device.c:219] in wined3d (0x0032f978) 1 0x686b0b67 wined3d_device_clear+0x136(device=0x142208, rect_count=0, rects=(nil), flags=0x1, color=0x6875e2bc, depth=1.000000, stencil=0) [/home/julliard/wine/wine/dlls/wined3d/device.c:3501] in wined3d (0x0032fa08) 2 0x686b613c wined3d_device_init_3d+0x3fb(device=<couldn't compute location>, swapchain_desc=<couldn't compute location>) [/home/julliard/wine/wine/dlls/wined3d/device.c:940] in wined3d (0x0032fa98) 3 0x6864d008 dxgi_factory_CreateSwapChain+0x127(iface=<couldn't compute location>, device=<couldn't compute location>, desc=<couldn't compute location>, swapchain=<couldn't compute location>) [/home/julliard/wine/wine/dlls/dxgi/factory.c:232] in dxgi (0x0032fb38) 4 0x6862b5aa func_device+0x13f9() [/home/julliard/wine/wine/dlls/dxgi/tests/../../../include/dxgi.h:2037] in dxgi_test (0x0032fcf8) 5 0x6862c165 run_test+0x144(name=<is not available>) [/home/julliard/wine/wine/dlls/d3d10core/tests/../../../include/wine/test.h:570] in dxgi_test (0x0032fd48) 6 0x68629c23 main+0x152(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/d3d10core/tests/../../../include/wine/test.h:640] in dxgi_test (0x0032fe08) 7 0x6862cbb0 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in dxgi_test (0x0032fe58) 8 0x7b85f36c call_process_entry+0xb() in kernel32 (0x0032fe78) 9 0x7b86054b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1084] in kernel32 (0x0032feb8) 10 0x7bc7fd50 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 11 0x7bc82c5d call_thread_func+0x7c(entry=0x7b8604e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 12 0x7bc7fd2e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 13 0x7bc5492e start_process+0x1d(kernel_start=0x7b8604e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2694] in ntdll (0x0032ffe8) 14 0x6803125d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 15 0x6803131b wine_switch_to_stack+0x2a(func=0x7bc54910, arg=0x7b8604e0, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff8613b8) 16 0x7bc5a467 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2750] in ntdll (0xff861428) 17 0x7b866ac0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1256] in kernel32 (0xff862338) 18 0x7bc5ab33 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2959] in ntdll (0xff8623c8) 19 0x6802eea2 wine_init+0x2a1(argc=0x3, argv=0xff862904, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:847] in libwine.so.1 (0xff862428) 20 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff862868) 21 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x686aa077 device_clear_render_targets+0x77 [/home/julliard/wine/wine/dlls/wined3d/device.c:219] in wined3d: movl 0x2c(%edx),%eax 219 || draw_rect->right < target->resource.width -- Alexandre Julliard julliard(a)winehq.org

2 1

Fwd: [GSoC Mentors Announce] Re: GSoC 2013 Mentors/Org Admins: "Pencils Down" and Final Evaluation Dates Approaching
by Austin English 23 Sep '13

23 Sep '13

---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Sep 23, 2013 at 12:04 PM Subject: [GSoC Mentors Announce] Re: GSoC 2013 Mentors/Org Admins: "Pencils Down" and Final Evaluation Dates Approaching To: GSoC Mentors Announce <gsoc-mentors-announce(a)googlegroups.com> Hi GSoC 2013 mentors and org admins, This is just a friendly reminder that final evaluations are now open and must be submitted by this Friday, 27 September at 19:00 UTC. Don't delay, submit today! Thanks, Carol -- -Austin

1 0

Re: [1/3] winex11: Splitted functions X11DRV_FocusOut (try 2)
by Alexandre Julliard 23 Sep '13

23 Sep '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > - when "virtually" reparenting the plugin window as a child of a > "foreign" window (similar to the systray code) its not possible to get > the focus anymore - the focus code always tries to request the focus for > the WS_POPUP parent, which is a foreign window in this case, and thus > fails. I don't see an easy way to detect/handle if a window is embedded > from user32-code without changing a lot of stuff there - thats why > Pipelight creates the plugin window as a WS_POPUP and makes wine think > it doesn't have any parent (which only has the disadvantage that wine > cannot track the correct window position). I think you really should make it work like the systray and keep track of the hierarchy. You'll run into a lot of hard to fix bugs otherwise. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: add ualapi directory (try 9
by Jacek Caban 23 Sep '13

23 Sep '13

Hi Akira, On 09/23/13 10:00, Akira Nakagawa wrote: > From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 > Message-Id: <2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapiro31(a)gmail.com> > From: Akira Nakagawa <matyapiro31(a)gmail.com> > Date: Mon, 23 Sep 2013 17:00:04 +0900 > Subject: [PATCH] add ual directory (try9) > > --- > configure | 2 + > configure.ac | 2 + > dlls/ualapi/Makefile.in | 6 +++ > dlls/ualapi/main.c | 86 +++++++++++++++++++++++++++++++++++++++++ > dlls/ualapi/tests/Makefile.in | 8 ++++ > dlls/ualapi/tests/ualapi_test.c | 38 ++++++++++++++++++ > dlls/ualapi/ualapi.spec | 4 ++ > include/Makefile.in | 1 + > include/ual.h | 48 +++++++++++++++++++++++ > 9 files changed, 195 insertions(+) Please don't include tests in this patch. Tests won't be committed until they are useful, so send them once you have something useful in them and as separated patch. For now, just strip them from the patch. Also, you may consider sending public header (include/ual.h) as a separated patch. And you don't need to include changes to generated files (configure, configure.ac and include/Makefile.in). Cheers, Jacek

1 0

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.
by Henri Verbeet 23 Sep '13

23 Sep '13

On 23 September 2013 13:29, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Note that Windows drivers disagree on which format they support. Nvidia > has V16U16, AMD supports Q8W8V8U8, at least on r200. I am working on a > more comprehensive converted format test that tests all supported signed > formats with surfaces. Just out of curiosity, do you happen to know if any hardware/driver supports these for render targets?

2 2

Re: [3/4] kernel32/tests: Add 0-length read tests for a pipe.
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2250 Your paranoid android. === wvista (32 bit pipe) === Failure running script in VM: network read error: Resource temporarily unavailable

1 0

Re: add ualapi directory (try 8)
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2311 Your paranoid android. === build (build) === Make failed

1 0

Re: add ualapi directory (try 7)
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2310 Your paranoid android. === build (build) === Make failed

1 0

Re: add ualapi directory (try 5)
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2309 Your paranoid android. === build (build) === Missing build status line The build timed out

1 0

Re: add ualapi directory (try 4)
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2308 Your paranoid android. === build (build) === Make failed

1 0

Re: Re: add ualapi directory (try 3)
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2304 Your paranoid android. === build (build) === Make failed

1 0

winebuild examples
by paul.clarke85＠btinternet.com 22 Sep '13

22 Sep '13

Hi, I am new to WINE and indeed winebuild. What I need to do is write a wrapper C part and Spec file and build a wrapper around an existing Linux shared library so that my wrapper DLL can be dynamically loaded into my program running in WINE. This, I believe, is supposed to be a simple thing to do and one of the main purposes of winebuild. I have failed miserably to understand the winebuild manual. It just lists a whole bunch of options. Whatever I try I just get an assembler file spat at me. I have searched the web and although I see a few people with the same problem as me I don’t see anyone posting any answers. Does ANYONE have any simple examples or example scripts which will show how to use winebuild to build a DLL I can load. Cheers, Paul Paul Clarke www.mqgem.com

2 1

Re: [PATCH 5/6] d3d8/tests: Add a volume V16U16 test.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2292 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] d3d9/tests: Add a volume V16U16 test.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2291 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9: Avoid CONST.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2290 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] ddraw/tests: Add a test for render target surface capabilities.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2289 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ws2_32: ConnectEx should not work on unbound socket
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2286 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/3] d3d9/tests: Implemented tests for IDirect3DSwapChain9Ex_GetDisplayModeEx
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2282 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] d3d9/tests: Test if IDirect3DSwapChain9Ex is available with IDirect3D9(Ex)
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2281 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] oleaut32: Implement ICreateTypeInfo::SetFuncDocString
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2280 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: rsaenh: Add support for retrieving the security descriptor on key containers.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2276 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] mshtml: Added external MIME handling tests.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2275 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: add ualapi directory (try 2)
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2273 Your paranoid android. === build (build) === Missing build status line The build timed out

1 0

Re: ws2_32/tests: Mark WinNT result as broken
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2271 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d8/tests: Test invalid volume lock boxes.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2270 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d8/tests: Add tests for block-based volume formats.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2269 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d9/tests: Read the caps from the device.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2268 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: shlwapi/tests: Fix stream test failures under some win2000 versions.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2266 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (resend)[3/4] imm32: use thread data from target HWND
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2263 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (resend)[3/4] imm32: use thread data from target HWND
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2262 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] d3dx9/tests: Add matrix column register count clamp test.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2259 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] imm32: Prevent assocating cross thread default contexts
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2257 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/4] imm32: use thread data from target HWND
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2256 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2255 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Test invalid volume lock boxes.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2254 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Add tests for block-based volume formats (try 2).
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2253 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] kernel32: Remove a 0-length read optimization from ReadFile. Resend.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2252 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] kernel32: Remove a 0-length read optimization from ReadFile. Resend.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2251 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().
by Roderick Colenbrander 20 Sep '13

20 Sep '13

That change looks suspicious. If switching to i+1 fixes a problem, the real problem is that the if-statement in question gets entered in the first place. Some bounds checking on the outer for-loop (the one which loops through nCfgs and nMaxFormats), is probably wrong then. I had issues with this part in the past, so there maybe a small typo (it may just be off by 1). Roderick On Thu, Sep 19, 2013 at 6:37 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winex11.drv/opengl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > >

2 1

Re: D3D command stream patches for testing
by Forest 20 Sep '13

20 Sep '13

>In the past months I have been working on a command stream / worker >thread for wined3d. It moves most OpenGL calls into a separate thread >to improve performance (bug 11674) and fix some bugs that are >otherwise hard to fix (24684). Thank you, Stefan! I applied your patches to the Ubuntu PPA that I maintain for Guild Wars 2 players: https://launchpad.net/~foresto/+archive/winepatched/ I'm not seeing a spectacular difference with the CSMT patches, but I am seeing a difference. I ran some quick tests in Guild Wars 2 while standing still outside the Lion's Arch bank, looking down at the forge with a moderate number of players milling about and fireworks being launched. Pierre Franco said (earlier in this discussion) that he gets better results when running with the -dx9single command line switch, so I tested with and without it. Note that I play with the WINEDEBUG=-all environment variable. Here are my results: CSMT="disabled", running with -dx9single: 15-16 fps CSMT="enabled" running without -dx9single: 19-21 fps CSMT="enabled", running with -dx9single: 22-23 fps So, almost 50% improvement for me, which is not what I remember when running natively under Windows, but is still a very welcome improvement. I wonder if the 80%+ gains reported in other games are not to be seen in Guild Wars 2, or if they're heavily dependent on CPU, GPU, graphics driver, and screen resolution. For the record, I'm using an Intel i5-3570K (stock speeds), GeForce GTX 660Ti (factory overclocked), nVidia driver 313.30, and a 1920x1200 display. I'm running Xubuntu 64-bit. My in-game options are: Resolution: Full Screen - 1920x1200 Refresh Rate: Default Frame Limiter: Unlimited Interface Size: Normal Animation: High Anti-Aliasing: FXAA Environment: High LOD Distance: High Reflections: Terrain & Sky Textures: Medium Render Sampling: Native Shadows: Medium Shaders: Medium Post-Processing: High Character Model Limit: High Character Model Quality: High + Best Texture Filtering + Depth Blur + Effect LOD + High-Res Character Textures - Vertical Sync

3 4

Re: [PATCH 2/6] wined3d: Add support for converted volumes.
by Henri Verbeet 20 Sep '13

20 Sep '13

On 20 September 2013 13:04, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static BOOL wined3d_volume_can_evict(const struct wined3d_volume *volume) > +{ > + if (volume->resource.pool != WINED3D_POOL_MANAGED) > + return FALSE; > + if (volume->download_count < 10) > + return FALSE; That doesn't look quite right.

1 0

Re: [PATCH 6/6] wined3d: Use GL_APPLE_client_storage for volumes if available.
by Henri Verbeet 20 Sep '13

20 Sep '13

On 20 September 2013 13:04, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - volume->flags &= ~(WINED3D_VFLAG_ALLOCATED | WINED3D_VFLAG_SRGB_ALLOCATED); > + volume->flags &= ~(WINED3D_VFLAG_ALLOCATED | WINED3D_VFLAG_SRGB_ALLOCATED > + | WINED3D_VFLAG_CLIENT_STORAGE); > Indentation looks a bit off here.

1 0

Re: (resend)[3/4] imm32: use thread data from target HWND
by Alexandre Julliard 20 Sep '13

20 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -507,7 +524,7 @@ HIMC WINAPI ImmAssociateContext(HWND hWnd, HIMC hIMC) > LeaveCriticalSection(&threaddata_cs); > defaultContext = ImmCreateContext(); > ((InputContextData*)defaultContext)->threadDefault = TRUE; > - thread_data = IMM_GetThreadData(0); > + thread_data = IMM_GetThreadDataForWindow(hWnd); > thread_data->defaultContext = defaultContext; > } You have multiple race conditions here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] oledb32: Correct DataLinks interface for win64
by Alexandre Julliard 20 Sep '13

20 Sep '13

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -26,6 +26,20 @@ import "oledb.idl"; > #define vi_progid(str) > #endif > > +#ifdef _WIN64 > +cpp_quote("#ifdef _WIN64") > + typedef LONGLONG COMPATIBLE_LONG; > +cpp_quote("#else") > +cpp_quote(" typedef LONG COMPATIBLE_LONG;") > +cpp_quote("#endif") > +#else > +cpp_quote("#ifdef _WIN64") > +cpp_quote(" typedef LONGLONG COMPATIBLE_LONG;") > +cpp_quote("#else") > + typedef LONG COMPATIBLE_LONG; > +cpp_quote("#endif") > +#endif You can't do that, _WIN64 is not meaningful in idl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] winemac: Implement support for global hot keys.
by Vincent Povirk 20 Sep '13

20 Sep '13

I don't think this is going to work correctly when replacing hotkeys (by passing an already-registered hwnd and id to RegisterHotKey with a different key combination). Since the user driver's RegisterHotKey function will be called with the new id/vkey/flags before UnregisterHotKey is called for the existing hotkey's id/vkey/flags, the user driver has to distinguish them based on vkey/flags. I think you can still get away with a mapping with hwnd/id as keys, as long as you check for matching vkey/flags when you unregister a hotkey. (Of course, I'm not convinced the user driver should ever post WM_HOTKEY, since the input should go through low-level keyboard hooks first, which is why I did not include the id as an argument to these entry points. If we decided to pass the id through, there would technically be no need for RegisterHotKey to call the user driver's UnregisterHotKey in this case.)

1 0

Re: [PATCH 2/3] iphlpapi: Add interface enumeration for Android.
by Bruno Jesus 19 Sep '13

19 Sep '13

On Thu, Sep 19, 2013 at 10:06 AM, Huw Davies <huw(a)codeweavers.com> wrote: > --- > configure.ac | 3 +- > dlls/iphlpapi/ifenum.c | 199 ++++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 200 insertions(+), 2 deletions(-) Hi, Huw. I'm not sure this is an issue but in the android implementation of get_interface_indexes you are not setting + if (table) *table = NULL; in the begining like in the other 2 implementations. Or I didn't understand the code correctly. Best wishes, Bruno

2 1

Re: [PATCH 3/5] mshtml: Keep moniker reference after start_binding call.
by Alexandre Julliard 18 Sep '13

18 Sep '13

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/navigate.c | 3 --- > 1 file changed, 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test failed: mon should be destroyed here make: *** [url.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] user32: Add a SetMinMaxInfo driver entry point.
by Alexandre Julliard 18 Sep '13

18 Sep '13

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/user32/driver.c | 12 ++++++++++++ > dlls/user32/user_private.h | 1 + > dlls/user32/winpos.c | 2 ++ > 3 files changed, 15 insertions(+), 0 deletions(-) It's better to avoid adding entry points that don't correspond to Windows APIs. Instead you should request the info when you need it. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [4/4] ws2_32: Do not allow socket creation if WSAStartup was not called
by Marvin 18 Sep '13

18 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2238 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/4] ws2_32: Filter invalid socket parameters and return the appropriate error
by Marvin 18 Sep '13

18 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2237 Your paranoid android. === build (build) === Patch failed to apply

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel