- wine-devel - winehq.org

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack().
by Bruno Jesus 31 Aug '13

31 Aug '13

On Sat, Aug 31, 2013 at 9:16 AM, Ralf Habacker <ralf.habacker(a)freenet.de> wrote: > new > - add doc for family parameter > - add doc for additional return code > - sorting in c file fixed > > Signed-off-by: Ralf Habacker <ralf.habacker(a)freenet.de> I guess the patch was marked as pending because you didn't add any tests. You are also missing the (try X) at the end of the subject. Regards, Bruno

1 0

Re: [PATCH 3/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO
by Marvin 31 Aug '13

31 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1945 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

Re: [PATCH] widl: Limit recursion deepth within structs to 1 for checking for full-pointers.
by Paul Chitescu 30 Aug '13

30 Aug '13

Hi! It would help to attach the patch, not your editor's swap file. Paul On Friday 30 August 2013 10:57:26 pm Kai Tietz wrote: > Hello, > > attached patch limits recursion in type_has_full_pointer-function to a > deeth of 1. By this all necessary checks should be possible, but > endless-recursion due diamond/cycle type-declarations are avoided. > I was finding this issue by working on propidl.idl rework, and hit > such an endless recursion. > > Regards, > Kai

2 1

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions
by Henri Verbeet 30 Aug '13

30 Aug '13

On 30 August 2013 00:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (format->flags & WINED3DFMT_FLAG_BLOCKS) > + { > + UINT width_mask = format->block_width - 1; > + UINT height_mask = format->block_height - 1; > + if (desc->width & width_mask || desc->height & height_mask) > + { > + WARN("(%p) : Texture cannot be created - width or height not block size aligned.\n", texture); > + return WINED3DERR_INVALIDCALL; > + } > + } > + Is this different from surfaces? IIRC surfaces are padded up to the next multiple of the block size, although I may have that wrong. Not a fan of the "(%p) : " trace formatting.

2 3

Re: [PATCH 3/5] d3d9/tests: Add a DXT5 volume test
by Henri Verbeet 30 Aug '13

30 Aug '13

On 30 August 2013 00:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* A 8x4x2 texture consisting of 4 4x4 blocks. The colors of the blocks are red, green, blue and white. */ > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x00, 0xF8, 0x00, 0x00, 0x00, 0x00, > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xE0, 0x07, 0xE0, 0x07, 0x00, 0x00, 0x00, 0x00, > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x1F, 0x00, 0x1F, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x00 In general we're using lower-case hex in wined3d, but I think it should at least be consistent within the same test.

2 1

Sequences in a loop
by matyapiro31 30 Aug '13

30 Aug '13

I found many wine sources use not a pointer,but a sequence . for example: krnl386.exe16/dma.c: for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];i<ret*size;i++) msdaps/usrmarshal.c: for(prop = 0; prop < rgPropertySets[prop_set].cProperties; prop++) I know in some cases to use sequences are wiser way than pointers, but so many of them are used in loops. Should I change them?

3 2

Help to create a server request
by Bruno Jesus 30 Aug '13

30 Aug '13

Hi all, I need some help to continue my current wine work. In order to implement SO_PROTOCOL_INFO for getsockopt I need to retrieve some information from the socket like its family and protocol. I have searched for a few days and ended up with a solution I dislike so I had a better idea (at least I hope I did). Instead of using non-portable SO_DOMAIN and SO_PROTOCOL/SO_PROTOTYPE to retrieve the socket family and protocol or using non-reliable guessing using only the socket type I thought it would be better to ask the server for this information. Using a request just like is used for several other information in ws2_32 (operation which will work on every OS). So, all I need is a server request that based on the socket fd will return the socket family, type and protocol. I tried to understand how requests work but I failed completely. Maybe this request can be later improved to return the connection time so we can finally fix SO_CONNECT_TIME option. The current solution is attached, since I sent the tests separated and they were commited the patch will not apply, it's only for reference. The idea is to remove the functions get_sock_[family|protocol|type] to a single server request. So, is this a good idea? If yes, how can I create and use the request? If not I'm all ears. Best wishes and thanks in advance, Bruno

2 2

Re: oleaut32: Add ICreateTypeInfo2::SetVarName implementation
by Nikolay Sivov 30 Aug '13

30 Aug '13

On 8/30/2013 16:28, Piotr Caban wrote: > --- > dlls/oleaut32/tests/typelib.c | 13 +++++++++++-- > dlls/oleaut32/typelib.c | 13 +++++++++++-- > 2 files changed, 22 insertions(+), 4 deletions(-) > > > > ITypeInfoImpl *This = info_impl_from_ICreateTypeInfo2(iface); > - FIXME("%p %u %s - stub\n", This, index, wine_dbgstr_w(name)); > - return E_NOTIMPL; > + > + FIXME("%p %u %s\n", This, index, wine_dbgstr_w(name)); > + It probably should be TRACE.

1 0

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.
by Alexandre Julliard 30 Aug '13

30 Aug '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Printing complete lsr value in the log may help with diagnosing > test failures on Alexandre's machine. I don't see how, since TIOCSER_TEMT is the only defined bit. Do you actually have a driver that returns other status? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: kernel32/tests: Add a FlushFileBuffers test for a COM port. Resend.
by Marvin 30 Aug '13

30 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1932 Your paranoid android. === wxppro (32 bit comm) === comm.c:849: Test failed: WaitCommEvent failed with a timeout comm.c:861: Test failed: WaitCommEvent error 997 comm.c:863: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:867: WaitCommEvent for EV_TXEMPTY took 1000 ms (timeout 1000) comm.c:869: Test failed: WaitCommEvent used 1000 ms for waiting

1 0

Re: d3d9: Partial implementation of IDirect3DSwapChain9Ex
by Stefan Dösinger 30 Aug '13

30 Aug '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2013-08-30 10:19, schrieb Michael Müller: > This patch implements the IDirect3DSwapChain9Ex interface as an > extension of IDirect3DSwapChain9 and thus fixes bug 34252 - > "Silverlight accelerated graphics cause a D3D critical section > lockup" since Silverlight does no longer try to create a Direct3D > context in an endless loop. The functions > d3d9_swapchain_GetLastPresentCount and > d3d9_swapchain_GetPresentStatistics are just stubs so far. Good work on finding out what causes that bug! > - if (IsEqualGUID(riid, &IID_IDirect3DSwapChain9) + if > (IsEqualGUID(riid, &IID_IDirect3DSwapChain9) || IsEqualGUID(riid, > &IID_IDirect3DSwapChain9Ex) || IsEqualGUID(riid, &IID_IUnknown)) For IDirect3D9Ex and IDirect3DDevice9Ex, the Ex versions are only available if IDirect3D9 was created with the extended method. I suspect swapchains are the same. Please write some tests for this. > + TRACE("iface %p, pLastPresentCount %p.\n", iface, pLastPresentCount); > + WARN("not implemented.\n"); If a function is not implemented we write a FIXME, e.g. FIXME("iface %p, pLastPresentCount %p, stub!\n", iface, pLastPresentCount); If this causes too much spam on the console, you can use a static variable to print it just once. > + if (SUCCEEDED(hr)) + { + if(pMode){ Please use a code style that is consistent with the rest of the file. Tbh the existing files aren't as consistent as we'd like. The general rule is a space between if and (, and { in newlines. 4 spaces intendation. If there's a one-line statement in an if, put that statement in a new line and don't write curly brackets. My personal opinion, and the style I use, is to use brackets for both branches of an if-else if one of those branches has more than one line. > - * IDirect3DSwapChain9 interface + * IDirect3DSwapChain9(Ex) > interface */ #define INTERFACE IDirect3DSwapChain9 > DECLARE_INTERFACE_(IDirect3DSwapChain9,IUnknown) You have to create a new interface declaration named IDirect3DSwapChain9Ex with all the methods and the invocation macros. The header change should go in a separate patch. The d3d9 code should be changed to always use IDirect3D9Swapchain9Ex, like it does for device and direct3d. Thanks for your work! Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSIFimAAoJEN0/YqbEcdMwbW0P/jC/gsziWzCtxBH1gDETnX6+ j0csX5cORWKCaq/wsPbT9ZDVV/OYFYlWRB0QZiJIUWAp4PzdGXCxQN8srdybT1hp PG3HTDzv4Kmq57fYSXEoLnZNO/pgfr4JiGmhcwQSyheJ1+lcb5Z/GE09goHwcLce CJVrIQu9f05TQb+r0BJCxIyGAIuq8to7xdIJ1tPR2MmKwYzS0XWkB1yN8QIGy/Qm z4aH7JGsOJ37t/90D4eHVBX6EtiI6pRHHiaO3hFrgYiu7wf/CeiE3E9QWnwycG1h DdPWjreQx+6/JQfg71eXDW81WYgdRl7TfMfBOc8UFh7Byj9b4llR0E+NFSkQ81NL XAQkB/PthmEpJIH1tSo91aNrZkfN/jw7D1gA4kUHFEtr5n1yuUXQQvKLYEOMWrV0 lV1plnzzLEZa50c0Y3/zCgQFCbzgo47ohO/4msMHOU33n255oJg/Bd6CLoA1oPFq hxQkkv0bW5VL6Jn0WVAC1FPjfmRF6zD6h9n8KKPWU2rz/tmkoEhoJ0Nd2a483N86 6EvOTpecczmNBlICFvyUOVAisHnVdwk+cPI+6hoqHBq0C7fGXi7R41pDOvf4o1yH wZyMH4e+kiG+7qaeGRwsTEDW1V77VAbPXJkNZPU2Wvb/gVzLU1TVQ87Bz5T83tpv tFvZjJrjOYO4qL4Afm14 =zjgo -----END PGP SIGNATURE-----

1 0

Re: d3d9: Partial implementation of IDirect3DSwapChain9Ex
by Nikolay Sivov 30 Aug '13

30 Aug '13

On 8/30/2013 12:19, Michael Müller wrote: > This patch implements the IDirect3DSwapChain9Ex interface as an > extension of IDirect3DSwapChain9 and thus fixes bug 34252 - "Silverlight > accelerated graphics cause a D3D critical section lockup" since > Silverlight does no longer try to create a Direct3D context in an > endless loop. The functions d3d9_swapchain_GetLastPresentCount and > d3d9_swapchain_GetPresentStatistics are just stubs so far. > > > --- > dlls/d3d9/swapchain.c | 71 > ++++++++++++++++++++++++++++++++++++++++++++++++- > include/d3d9.h | 14 +++++++++- > include/d3d9types.h | 8 ++++++ > 3 files changed, 91 insertions(+), 2 deletions(-) > > @@ -34,7 +34,7 @@ static HRESULT WINAPI d3d9_swapchain_QueryInterface(IDirect3DSwapChain9 *iface, > { > TRACE("iface %p, riid %s, out %p.\n", iface, debugstr_guid(riid), out); > > - if (IsEqualGUID(riid, &IID_IDirect3DSwapChain9) > + if (IsEqualGUID(riid, &IID_IDirect3DSwapChain9) || IsEqualGUID(riid, &IID_IDirect3DSwapChain9Ex) > || IsEqualGUID(riid, &IID_IUnknown)) > { > IDirect3DSwapChain9_AddRef(iface); > @@ -221,12 +221,76 @@ static HRESULT WINAPI d3d9_swapchain_GetPresentParameters(IDirect3DSwapChain9 *i > return D3D_OK; > } I don't know if d3d9 is special in this regard, but this is a wrong way to implement derived interface. You need you make everything IDirect3DSwapChain9Ex, for example this one: > /***************************************************************************** > - * IDirect3DSwapChain9 interface > + * IDirect3DSwapChain9(Ex) interface > */ > #define INTERFACE IDirect3DSwapChain9 > DECLARE_INTERFACE_(IDirect3DSwapChain9,IUnknown) > @@ -405,6 +405,10 @@ DECLARE_INTERFACE_(IDirect3DSwapChain9,IUnknown) > STDMETHOD(GetDisplayMode)(THIS_ D3DDISPLAYMODE* pMode) PURE; > STDMETHOD(GetDevice)(THIS_ struct IDirect3DDevice9** ppDevice) PURE; > STDMETHOD(GetPresentParameters)(THIS_ D3DPRESENT_PARAMETERS* pPresentationParameters) PURE; > + /*** IDirect3DSwapChain9Ex methods ***/ > + STDMETHOD(GetLastPresentCount)(THIS_ UINT* pLastPresentCount) PURE; > + STDMETHOD(GetPresentStats)(THIS_ D3DPRESENTSTATS* pPresentationStatistics) PURE; > + STDMETHOD(GetDisplayModeEx)(THIS_ D3DDISPLAYMODEEX* pMode,D3DDISPLAYROTATION* pRotation) PURE; > }; > #undef INTERFACE is no longer just IDirect3DSwapChain9. This will fix vtbl type too.

1 0

Re: [2/2] ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit.
by Dmitry Timoshkov 30 Aug '13

30 Aug '13

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Printing complete lsr value in the log may help with diagnosing > test failures on Alexandre's machine. This patch is marked as 'Build failure' in the tracker, but I've checked it once again and compiles just fine here. What kind of build failure is that? -- Dmitry.

2 1

RFC: Mark dylib/mach-o on Mac OS X
by André Hentschel 29 Aug '13

29 Aug '13

Hi, at [1] i noticed that dylibs are printed as PEs. This intents to fix that, but i have no Mac, could someone please review/test? [1] http://test.winehq.org/data/8ef3a142263e6db11f1514f77b3de84c8b08d7a0/mac_fg… diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 6bea436..41fa7e6 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -33,6 +33,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(dbghelp); const WCHAR S_ElfW[] = {'<','e','l','f','>','\0'}; +const WCHAR S_MachoW[] = {'<','m','a','c','h','o','>','\0'}; const WCHAR S_WineLoaderW[] = {'<','w','i','n','e','-','l','o','a','d','e','r','>','\0'}; static const WCHAR S_DotSoW[] = {'.','s','o','\0'}; static const WCHAR S_DotDylibW[] = {'.','d','y','l','i','b','\0'}; @@ -94,6 +95,9 @@ static void module_fill_module(const WCHAR* in, WCHAR* out, size_t size) if (len > 3 && !strcmpiW(&out[len - 3], S_DotSoW) && (l = match_ext(out, len - 3))) strcpyW(&out[len - l - 3], S_ElfW); + else if (len > 6 && !strcmpiW(&out[len - 6], S_DotDylibW) && + (l = match_ext(out, len - 6))) + strcpyW(&out[len - l - 6], S_MachoW); } while ((*out = tolowerW(*out))) out++; } diff --git a/programs/winedbg/info.c b/programs/winedbg/info.c index c0b86ba..c2c7c08 100644 --- a/programs/winedbg/info.c +++ b/programs/winedbg/info.c @@ -244,6 +244,11 @@ void info_win32_module(DWORD64 base) } } } + else if (strstr(im.mi[i].ModuleName, "<macho>")) + { + dbg_printf("MACH-O\t"); + module_print_info(&im.mi[i], FALSE); + } else { /* check module is not embedded in another module */ @@ -253,8 +258,11 @@ void info_win32_module(DWORD64 base) break; } if (j < im.num_used) continue; - if (strstr(im.mi[i].ModuleName, ".so") || strchr(im.mi[i].ModuleName, '<')) + if (strstr(im.mi[i].ModuleName, ".so") || strstr(im.mi[i].ModuleName, "<elf>") || + strstr(im.mi[i].ModuleName, "<wine-loader>")) dbg_printf("ELF\t"); + else if (strstr(im.mi[i].ModuleName, ".dylib") || strstr(im.mi[i].ModuleName, "<macho>")) + dbg_printf("MACH-O\t"); else dbg_printf("PE\t"); module_print_info(&im.mi[i], FALSE);

4 9

Re: patch:kernel32
by Charles Davis 29 Aug '13

29 Aug '13

On Aug 29, 2013, at 8:15 AM, matyapiro31 wrote: > > <0001-kernel32-change-for-loop-to-optimize.patch><0002-kernel32-change-for-loop-to-optimize.patch> One patch per email, please. Also, the subject should be more descriptive. The first one doesn't look much better than the second one (which was already rejected). sizeof(array)/sizeof(array[0]) is a constant expression; any optimizing compiler worth its salt will optimize that for you. (And I would know, because I work on LLVM and Clang.) The first part of that patch (against dlls/kernel32/console.c) might be a bit more promising, though, since it hoists a computation that isn't constant at compile time but is constant for the duration of the loop; but again, any good optimizing compiler would be smart enough to do that, too. Oh, and you forgot to actually declare the variables that hold the hoisted values. Those assignments don't count, because: a) You never gave them a type. That's an error in any C compiler (C89, C99, etc.) I'm not even sure a K&R compiler would take that. b) Wine is written in C89 (with some GNU extensions scattered throughout, but generally we try to write portable code around here); that means (among other things) all variable declarations must come before other statements. Did you even try to compile Wine with these patches? Chip

1 0

Re: [PATCH 2/2] ddraw/tests: Test WM_ACTIVATEAPP messages generated by SetCooperativeLevel
by Henri Verbeet 29 Aug '13

29 Aug '13

On 29 August 2013 11:14, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +BOOL activateapp_received; > +IDirectDraw *activateapp_ddraw; > +HWND activateapp_window; > +DWORD activateapp_coop_level; > + I think those should be static, and you'll probably want to put them in a structure.

1 0

my patch was wrong at dlls/kernel32/computernames.c
by matyapiro31 29 Aug '13

29 Aug '13

From if ( isalnumW ( wc ) ) return wc; for ( i = 0; i < 17; i++ ) To if ( isalnumW ( wc ) ) return wc; for ( i = 0; i < 16; i++ ) and the original version was wrong,too. It counts the NULL of the end.

2 1

Re: patch:kernel32
by Bruno Jesus 29 Aug '13

29 Aug '13

On Thu, Aug 29, 2013 at 11:15 AM, matyapiro31 <matyapiro31(a)gmail.com> wrote: The patch could have a better subject =) > + unix_len=sizeof(unix_vars)/sizeof(unix_vars[0]; Missing the closing ) ? Will this compile? > - for ( i = 0; i < sizeof (special) / sizeof (WCHAR); i++ ) > + for ( i = 0; i < 17; i++ ) I guess the compiler does this for you. And for the other cases too. Also you should send only one patch per email. Regards, Bruno

1 0

Re: patch:try 2 of adding wine ja mannual
by Akihiro Sagawa 29 Aug '13

29 Aug '13

On Wed, 28 Aug 2013 20:29:43 +0900, �� wrote: > diff --git a/loader/Makefile.in b/loader/Makefile.in > index a7ab893..bc11378 100644 > --- a/loader/Makefile.in > +++ b/loader/Makefile.in > @@ -20,14 +20,16 @@ MANPAGE = wine.man > EXTRA_MANPAGES = \ > wine.de.man \ > wine.fr.man \ > - wine.pl.man > + wine.pl.man \ > + wine.ja.man The line was indented spaces, use tabs instead here, please. The list should be in alphabetical order, i.e. de, fr, ja, pl. > INSTALLDIRS = \ > $(DESTDIR)$(bindir) \ > $(DESTDIR)$(mandir)/man$(prog_manext) \ > $(DESTDIR)$(mandir)/de.UTF-8/man$(prog_manext) \ > $(DESTDIR)$(mandir)/fr.UTF-8/man$(prog_manext) \ > - $(DESTDIR)$(mandir)/pl.UTF-8/man$(prog_manext) > + $(DESTDIR)$(mandir)/pl.UTF-8/man$(prog_manext) \ > + $(DESTDIR)$(mandir)/ja/man$(prog_manext) Use tabs and insert the line between fr and pl, please. Why don't you use ja.UTF-8? > diff --git a/loader/wine.ja.man.in b/loader/wine.ja.man.in > new file mode 100644 > index 0000000..e2e1cba > --- /dev/null > +++ b/loader/wine.ja.man.in The document still looks like wine 1.4 age text. Some sentences deleted before 1.6 release, e.g. git url, still remain. Updated texts, e.g. DESCRIPTION section, aren't reflected in the translated one. Please refer the diff page [1] to figure out what was changed between wine-1.4 and wine-1.6. [1] http://source.winehq.org/git/wine.git/blobdiff/wine-1.4..wine-1.6:/loader/w… I noticed that you added Japanese specific section -- 文字化けについて -- to the man page. I'm not sure about this because other translators didn't do like this and it is difficult to keep up-to-date language specific information. Regards, Akihiro Sagawa

1 0

Re: wininet: Replacing a header with an empty value deletes it.
by testbot＠winehq.org 29 Aug '13

29 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://newtestbot.winehq.org/JobDetails.pl?Key=1918 Your paranoid android. === w7pro64 (32 bit http) === http.c:4279: Test failed: HttpSendRequest failed: 12057 http.c:4284: Test failed: expected secure flag to be set === w7pro64 (64 bit http) === http.c:3445: Test failed: HttpQueryInfo failed 0

1 0

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.
by Alexandre Julliard 29 Aug '13

29 Aug '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/tests/comm.c | 5 +---- > dlls/ntdll/serial.c | 13 +++++-------- > 2 files changed, 6 insertions(+), 12 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so comm.c && touch comm.ok comm.c:835: Test failed: WriteFile took 1 ms to write 17 Bytes at 150 Baud comm.c:848: Test failed: WaitCommEvent failed with a timeout comm.c:859: Test failed: WaitCommEvent error 997 comm.c:860: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:865: Test failed: WaitCommEvent used 1000 ms for waiting comm.c:1895: Tests skipped: interactive tests (set WINETEST_INTERACTIVE=1) make: *** [comm.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

3 10

Re: [1/2] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port. Take 2.
by Dmitry Timoshkov 29 Aug '13

29 Aug '13

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Based on a patch of Wolfgang Walter. Is there anything wrong with this patch? -- Dmitry.

1 0

Re: ntdll: Store all 'comClass' attributes (try3)
by Michael Stefaniuc 28 Aug '13

28 Aug '13

Hello Nikolay, On 08/27/2013 12:16 PM, Nikolay Sivov wrote: > +static OLEMISC get_olemisc_value(const WCHAR *str, int len) > +{ > + int min, max; > + > + min = 0; > + max = sizeof(olemisc_values)/sizeof(struct olemisc_entry) - 1; > + > + while (min <= max) > + { > + int n, c; > + > + n = (min+max)/2; > + > + c = strncmpW(olemisc_values[n].name, str, len); why don't you just compare the length first? If the length matches you can do a simple strcmpW between the strings to verify the match. Something like the below code: if (olemisc_values[n].len == len) { if (!strcmpW(olemisc_values[n].name, str) return olemisc_values[n].value; else ... } else if (olemisc_values[n].len > len) max = n-1; else min = n+1; > + if (!c) > + { > + if (olemisc_values[n].len < len) > + c = -1; > + else if (olemisc_values[n].len > len) > + c = 1; > + } > + > + if (!c) > + return olemisc_values[n].value; > + > + if (c > 0) > + max = n-1; > + else > + min = n+1; > + } > + > + WARN("unknown flag %s\n", debugstr_wn(str, len)); > + return 0; > +} bye michael

1 0

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().
by Hans Leidekker 28 Aug '13

28 Aug '13

On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote: > diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec > index 36ba13f..1eed5ae 100644 > --- a/dlls/iphlpapi/iphlpapi.spec > +++ b/dlls/iphlpapi/iphlpapi.spec > @@ -6,6 +6,7 @@ > @ stdcall AllocateAndGetIpForwardTableFromStack( ptr long long long ) > @ stdcall AllocateAndGetIpNetTableFromStack( ptr long long long ) > @ stdcall AllocateAndGetTcpTableFromStack( ptr long long long ) > +@ stdcall AllocateAndGetTcpExTableFromStack( ptr long long long long ) AllocateAndGetTcpExTableFromStack sorts before AllocateAndGetTcpTableFromStack. > diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h > index bf5bb92..efdb1cc 100644 > --- a/dlls/iphlpapi/ipstats.h > +++ b/dlls/iphlpapi/ipstats.h > @@ -33,6 +33,7 @@ > DWORD getInterfaceStatsByName(const char *name, PMIB_IFROW entry) DECLSPEC_HIDDEN; > > DWORD WINAPI AllocateAndGetUdpTableFromStack(PMIB_UDPTABLE *ppUdpTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN; > +DWORD WINAPI AllocateAndGetTcpExTableFromStack(PVOID *ppTcpTable, BOOL bOrder, HANDLE heap, DWORD flags, DWORD family) DECLSPEC_HIDDEN; Again, you don't need this part.

2 2

[AppDB] How to deal with hardware/driver dependent test result?
by Felix Yan 28 Aug '13

28 Aug '13

Hi, I'm maintaining Spore 1.0, and it works correctly in wine for over a year on Nvidia video card with closed-source nvidia driver - but I do noticed with Intel cards with open source drivers, the game is nearly not playable - missing texture and more problems. Today comes in a new test result that mark the game as "Garbage", while the description is exactly what happened on my laptop with Intel chip. What should I do about this? To proceed with the test result and change the game to "Garbage" stage, or reject with "Nvidia cards works fine"? I don't think either is fine, so I come to the list for help. Thanks! Regards, Felix Yan

3 2

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().
by Hans Leidekker 28 Aug '13

28 Aug '13

On Wed, 2013-08-28 at 11:41 +0200, Ralf Habacker wrote: > diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec > index 36ba13f..cad2ca9 100644 > --- a/dlls/iphlpapi/iphlpapi.spec > +++ b/dlls/iphlpapi/iphlpapi.spec > @@ -6,6 +6,7 @@ > @ stdcall AllocateAndGetIpForwardTableFromStack( ptr long long long ) > @ stdcall AllocateAndGetIpNetTableFromStack( ptr long long long ) > @ stdcall AllocateAndGetTcpTableFromStack( ptr long long long ) > +@ stdcall AllocateAndGetTcpExTableFromStack( ptr long long long ) These should be sorted. > diff --git a/dlls/iphlpapi/ipstats.c b/dlls/iphlpapi/ipstats.c > index 809dbc6..bcb3021 100644 > --- a/dlls/iphlpapi/ipstats.c > +++ b/dlls/iphlpapi/ipstats.c > @@ -2327,6 +2327,32 @@ DWORD WINAPI AllocateAndGetTcpTableFromStack( PMIB_TCPTABLE *ppTcpTable, BOOL bO > return build_tcp_table( TCP_TABLE_BASIC_ALL, (void **)ppTcpTable, bOrder, heap, flags, NULL ); > } > > +/****************************************************************** > + * AllocateAndGetTcpExTableFromStack (IPHLPAPI.@) > + * > + * Get the TCP connection table. > + * Like GetTcpTable(), but allocate the returned table from heap. > + * > + * PARAMS > + * ppTcpTable [Out] pointer into which the MIB_TCPTABLE_EX is > + * allocated and returned. > + * bOrder [In] whether to sort the table > + * heap [In] heap from which the table is allocated > + * flags [In] flags to HeapAlloc > + * > + * RETURNS > + * ERROR_INVALID_PARAMETER if ppTcpTable is NULL, whatever GetTcpTable() > + * returns otherwise. > + */ > +DWORD WINAPI AllocateAndGetTcpExTableFromStack( PMIB_TCPTABLE_EX *ppTcpTable, BOOL bOrder, > + HANDLE heap, DWORD flags ) > +{ > + TRACE("table %p, bOrder %d, heap %p, flags 0x%08x\n", ppTcpTable, bOrder, heap, flags); > + > + if (!ppTcpTable) return ERROR_INVALID_PARAMETER; > + return build_tcp_table( TCP_TABLE_OWNER_PID_ALL, (void **)ppTcpTable, bOrder, heap, flags, NULL ); > +} > + > static DWORD get_udp_table_sizes( UDP_TABLE_CLASS class, DWORD row_count, DWORD *row_size ) > { > DWORD table_size; > diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h > index bf5bb92..823fadb 100644 > --- a/dlls/iphlpapi/ipstats.h > +++ b/dlls/iphlpapi/ipstats.h > @@ -34,6 +34,7 @@ DWORD getInterfaceStatsByName(const char *name, PMIB_IFROW entry) DECLSPEC_HIDDE > > DWORD WINAPI AllocateAndGetUdpTableFromStack(PMIB_UDPTABLE *ppUdpTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN; > DWORD WINAPI AllocateAndGetTcpTableFromStack(PMIB_TCPTABLE *ppTcpTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN; > +DWORD WINAPI AllocateAndGetTcpExTableFromStack(PMIB_TCPTABLE_EX *ppTcpTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN; > DWORD WINAPI AllocateAndGetIpNetTableFromStack(PMIB_IPNETTABLE *ppIpNetTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN; > DWORD WINAPI AllocateAndGetIpForwardTableFromStack(PMIB_IPFORWARDTABLE *ppIpForwardTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN; You don't need this, AllocateAndGetTcpExTableFromStack can be made static. The first parameter should be a void ** like in recent versions of iphlpapi.h. > diff --git a/include/tcpmib.h b/include/tcpmib.h > index 477500c..bc63c3f 100644 > --- a/include/tcpmib.h > +++ b/include/tcpmib.h > @@ -150,6 +150,9 @@ typedef struct _MIB_TCPTABLE2 > MIB_TCPROW2 table[1]; > } MIB_TCPTABLE2, *PMIB_TCPTABLE2; > > +typedef MIB_TCPROW_OWNER_PID _MIB_TCPROW_EX; > +typedef MIB_TCPTABLE_OWNER_PID MIB_TCPTABLE_EX; > +typedef PMIB_TCPTABLE_OWNER_PID PMIB_TCPTABLE_EX; Recent headers don't define these so we shouldn't either.

1 0

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().
by Nikolay Sivov 28 Aug '13

28 Aug '13

On 8/28/2013 13:41, Ralf Habacker wrote: > > Signed-off-by: Ralf Habacker <ralf.habacker(a)freenet.de> > --- > dlls/iphlpapi/iphlpapi.spec | 1 + > dlls/iphlpapi/ipstats.c | 26 ++++++++++++++++++++++++++ > dlls/iphlpapi/ipstats.h | 1 + > include/tcpmib.h | 3 +++ > 4 Dateien geändert, 31 Zeilen hinzugefügt(+) > > > > +DWORD WINAPI AllocateAndGetTcpExTableFromStack( PMIB_TCPTABLE_EX *ppTcpTable, BOOL bOrder, > + HANDLE heap, DWORD flags ) Are you sure about this? It doesn't match a prototype from MSDN.

1 0

Re: kernel32/tests: Remove a useless trace.
by Marvin 28 Aug '13

28 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26897 Your paranoid android. === WVISTAX64 (64 bit comm) === comm.c:835: Test failed: WriteFile took 16 ms to write 0 Bytes at 150 Baud comm.c:1445: test_AbortWaitCts timeout 500 handle 000000000000003C comm.c:1412: Changing CommMask on the fly for handle 000000000000003C after timeout 500

1 0

Re: msvcr90/tests: Add more ARM forwards and use them in tests
by Marvin 27 Aug '13

27 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26894 Your paranoid android. === WXPX64 (32 bit msvcr90) === No test summary line found

1 0

Re: [1/4] ntdll: Ignore ioctl(TIOCGICOUNT) failures.
by Wolfgang Walter 27 Aug '13

27 Aug '13

Am Dienstag, 27. August 2013, 22:00:59 schrieben Sie: > Wolfgang Walter <wine(a)stwm.de> wrote: > > > Wolfgang Walter <wine(a)stwm.de> wrote: > > > > I made similar changes so that several applications we use work. I > > > > tested > > > > your patches, all but one do work. I don't know why one does not, > > > > though. > > > > > > What patch doesn't work for you? > > > > I tested all your patches together (indivually they will not really work > > here). > > Yeah, the patches need to be tested after applying all of them. They were > broken into smaller parts in order to make regression test easier in case of > a regression. If I don't know what doesn't work I can't make any > improvement. Yes, that's clear. I'll have a closer look what's the main difference. The problematic application uses asynchronous IO. I wrote my patch 2009 (and earlier version 2008) so I have to rethink about it. I remember that TX_TXEMPTY detection was a problem, then. It could get lost. The reason I moved the output buffer empty detection from get_irq_info() into check_events() was simply because I thought handling input queue in check_events() but ouput queue in get_irq_info() seems odd. I also think that it's better to detect that get_irq_info() basicly does not work with drivers not supporting TIOCGICOUNT and it is good to have that information in the callers of get_irq_info(). So I return STATUS_NOT_IMPLEMENTED and handle the situation in the caller. And then it is better to move empty sending queue handling out of get_irq_info(). I handle the TIOCSERGETLSR wrong, as I see now (I should & with TIOCSER_TEMT). Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts Abteilungsleiter IT Leopoldstraße 15 80802 München

1 0

Retiring winetestbot
by Jeremy White 27 Aug '13

27 Aug '13

Folks, I am writing to announce that we will be retiring the original Wine Test Bot, written by the late Ge van Geldorp, as of August 31, 2013. We will switch over to the new test bot that Francois has been working on at that time. On September 1, we'll panic and fix everything that is broken <grin>). I want to thank Ge's family, notably his brother Arno, for keeping the servers running these years since Ge passed away. It's also important to note how incredible a contribution the Wine Test Bot has proven to be for the Wine project; Wine owes an incredible debt to Ge, and I hope we can all collectively work to remember the great gift he gave us and the world. Cheers, Jeremy

1 0

Re: Does auto-apt work to get wine dependencies in source code?
by Susan Cragin 27 Aug '13

27 Aug '13

--Sorry about the HTML in the earlier message. >> Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work. >Is that with the ubuntu-wine ppa enabled? There are two answers to that question, surprisingly. (1) bitbox In the instructions it looks like the wine ppa repository can be installed the Debian way. But I did that and here's the result. ---------------- E: You must put some 'source' URIs in your sources.list ---------------- So, I had to add the wine-ppa by manually adding to the sources.list. (2) non bitbox This morning a new version of the i386 photo function was added, and now the depencencies install. Conclusion: This afternoon I was able to update all dependencies and compile without a problem using (with modifications above) the bitbox instructions. Compiled only. Did not install because I needed symlinks, but at least I know where I am and what I have to do. Susan

1 0

Re: ntdll: Implement job objects
by Dmitry Timoshkov 27 Aug '13

27 Aug '13

Andrew Cook <ariscop(a)gmail.com> wrote: > +typedef struct _JOBOBJECT_ASSOCIATE_COMPLETION_PORT { > + PVOID CompletionKey; > + HANDLE CompletionPort; > +} JOBOBJECT_ASSOCIATE_COMPLETION_PORT, *PJOBOBJECT_ASSOCIATE_COMPLETION_PORT; This needs to go into its owm header. > +static DWORD getProcess(PHANDLE handle) { > + STARTUPINFO startup = {}; > + PROCESS_INFORMATION info = {}; > + > + if(!CreateProcessA(NULL, GetCommandLine(), NULL, NULL, FALSE, 0, NULL, NULL, &startup, &info)) { > + ok(FALSE, "CreateProcess: %x\n", GetLastError()); > + return 0; > + } > + > + CloseHandle(info.hThread); > + *handle = info.hProcess; > + > + return info.dwProcessId; > +}; Indentation is completely messed up in the tests, please set tab size to 8 and even better avoid tabs at all. ';' at the end of function looks funny. > +typedef struct _JOBOBJECT_ASSOCIATE_COMPLETION_PORT { > + PVOID CompletionKey; > + HANDLE CompletionPort; > +} JOBOBJECT_ASSOCIATE_COMPLETION_PORT, *PJOBOBJECT_ASSOCIATE_COMPLETION_PORT; Same as above. > +static NTSTATUS (WINAPI *pNtCreateJobObject)( PHANDLE handle, ACCESS_MASK access, const OBJECT_ATTRIBUTES *attr ); > +static NTSTATUS (WINAPI *pNtSetInformationJobObject)( HANDLE handle, JOBOBJECTINFOCLASS klass, PVOID info, ULONG len ); > +static NTSTATUS (WINAPI *pNtAssignProcessToJobObject)( HANDLE job, HANDLE process ); > +static NTSTATUS (WINAPI *pNtIsProcessInJob)( HANDLE process, HANDLE job ); > +static NTSTATUS (WINAPI *pNtTerminateJobObject)( HANDLE job, NTSTATUS status ); Please move it to the beginning of the file. > --- a/include/wine/server_protocol.h > +++ b/include/wine/server_protocol.h And don't include autogenerated stuff in the patch. -- Dmitry.

2 2

Re: ntdll: Implement job objects
by Marvin 27 Aug '13

27 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26885 Your paranoid android. === W2KPROSP4 (32 bit job) === job: unhandled exception c0000005 at 00000000

1 0

Re: [1/4] ntdll: Ignore ioctl(TIOCGICOUNT) failures.
by Wolfgang Walter 27 Aug '13

27 Aug '13

Hello, I made similar changes so that several applications we use work. I tested your patches, all but one do work. I don't know why one does not, though. I attached my patch, maybe it is usefull to you. Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts Abteilungsleiter IT Leopoldstraße 15 80802 München

2 1

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.
by Marvin 27 Aug '13

27 Aug '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26878 Your paranoid android. === WVISTAX64 (32 bit comm) === comm.c:835: Test failed: WriteFile took 16 ms to write 0 Bytes at 150 Baud comm.c:1443: test_AbortWaitCts timeout 500 handle 000000B4 comm.c:1410: Changing CommMask on the fly for handle 000000B4 after timeout 500

2 1

Re: ntdll: Store all 'comClass' attributes (try2)
by Alexandre Julliard 27 Aug '13

27 Aug '13

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > +static OLEMISC get_olemisc_value(const WCHAR *str, int len) > +{ > + int min, max; > + > + min = 0; > + max = ARRAY_SIZE(olemisc_values) - 1; > + > + while (min <= max) > + { > + int n, c; > + > + n = (min+max)/2; > + > + c = memcmp(olemisc_values[n].name, str, min(len, olemisc_values[n].len)*sizeof(WCHAR)); > + if (!c) > + { > + if (olemisc_values[n].len < len) > + c = -1; > + else if (olemisc_values[n].len > len) > + c = 1; > + } Actually, memcmp is not a good choice for comparing Unicode strings. It doesn't make a difference for ASCII-only strings, but it would still be cleaner to do it right. strncmpW is preferable (as long as you use it correctly...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: Store all 'comClass' attributes
by Alexandre Julliard 27 Aug '13

27 Aug '13

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > + while (min <= max) > + { > + int n, c; > + > + n = (min+max)/2; > + > + c = strncmpW(olemisc_values[n].name, str, len); strncmp isn't enough. -- Alexandre Julliard julliard(a)winehq.org

2 1

Does auto-apt work to get wine dependencies in source code?
by Susan Cragin 27 Aug '13

27 Aug '13

Hello, Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work.

4 3

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (try 2).
by Bruno Jesus 27 Aug '13

27 Aug '13

On Mon, Aug 5, 2013 at 1:24 AM, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > The attached patch is the next step in the series of fixes for > Silverlight/PlayReady under Wine. This particular patch does not > impact Netflix, but it does impact a number of other PlayReady > streaming services (and a variety of non-streaming sites as well). > Sorry it's taken so long to get back to this, life has been busy > lately. > > With this patch the SIO_ADDRESS_LIST_CHANGE call gets passed on to > NotifyAddrChange, which effectively fixes a problem where Silverlight > apps can loop forever calling SIO_ADDRESS_LIST_CHANGE (Bug #32328). > Part 2 actually implements the NotifyAddrChange call on Linux, though > this patch is sufficient on its own to resolve the bug since the > overlapped IO event no longer gets triggered. > > This version of the patch has bee updated to include tests that show > that the notification is not tied to the socket. For example, > changing an interface that the socket is not bound to still results in > an overlapped notification. It's worth noting that these tests > require interactive mode and a PC with two network cards, so for my > testing I used an actual (non-VM) Windows 7 box with a wired and a > wireless card. Was this patch already reviewed? Is there anything else take can be done to get it commited? I tested it in 2 different environments (win7 eth+wifi and winxp eth+eht) and the tests work as expected. Regards, Bruno

1 0

Re: Does auto-apt work to get wine dependencies in source code?
by Susan Cragin 26 Aug '13

26 Aug '13

1 0

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.
by Alexandre Julliard 26 Aug '13

26 Aug '13

Wolfgang Walter <wine(a)stwm.de> writes: > @@ -2749,19 +2752,46 @@ NTSTATUS WINAPI NtFlushBuffersFile( HANDLE hFile, IO_STATUS_BLOCK* IoStatusBlock > { > NTSTATUS ret; > HANDLE hEvent = NULL; > - > - SERVER_START_REQ( flush_file ) > - { > - req->handle = wine_server_obj_handle( hFile ); > - ret = wine_server_call( req ); > - hEvent = wine_server_ptr_handle( reply->event ); > + enum server_fd_type type; > + unsigned int options; > + int needs_close; > + int unix_handle; > + > + ret = server_get_unix_fd( hFile, FILE_WRITE_DATA, &unix_handle, > + &needs_close, &type, &options ); > + if (ret) return ret; You probably don't want to fail just because there's no unix fd. > + if (ret == STATUS_SUCCESS && IoStatusBlock) { > + IoStatusBlock->u.Status = ret; > } This is an unrelated change and should be a separate patch, with tests (also for failures cases), -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 2/7] wined3d: Use PBOs for dynamic volumes (try 2)
by Matteo Bruni 26 Aug '13

26 Aug '13

2013/8/26 Stefan Dösinger <stefan(a)codeweavers.com>: > Try 2: > *) Require only GPU access for buffers > *) Reduce number of checkGLcall invocations > *) Remove a return from an ERR case > --- > dlls/wined3d/utils.c | 1 + > dlls/wined3d/volume.c | 168 ++++++++++++++++++++++++++++++++++++----- > dlls/wined3d/wined3d_private.h | 7 +- > 3 files changed, 157 insertions(+), 19 deletions(-) > > + case WINED3D_LOCATION_BUFFER: > + if (!volume->pbo || !(volume->flags & WINED3D_VFLAG_PBO)) > + ERR("Trying to load WINED3D_LOCATION_BUFFER without setting it up first.\n"); > + > + if (volume->locations & WINED3D_LOCATION_DISCARDED) > + { > + TRACE("Volume previously discarded, nothing to do.\n"); > + wined3d_volume_invalidate_location(volume, WINED3D_LOCATION_DISCARDED); > + } > + else if (volume->locations & WINED3D_LOCATION_TEXTURE_RGB) > + { > + struct wined3d_bo_address data = {volume->pbo, NULL}; > + volume_bind_and_dirtify(volume, context); > + wined3d_volume_download_data(volume, context, &data); > + } > + else > + { > + FIXME("Implement WINED3D_LOCATION_SYSMEM loading from %s.\n", > + wined3d_debug_location(volume->locations)); > + return; > + } > + wined3d_volume_validate_location(volume, WINED3D_LOCATION_BUFFER); > + break; > + Not really an actual review, but that FIXME looks wrong (copy-paste remnant probably).

2 1

questions to your commit "wineps.drv: Allow for vertical text printing!"
by Wolfgang Walter 26 Aug '13

26 Aug '13

Hello Aric, I read commit 745e7c93c9042f62460f181daaa1f05645560b41 (wineps.drv: Allow for vertical text printing.) and I have some questions: 1) You added the parameter vertical to PSDRV_WriteSetFont() in ps.c but it remains unused. I think it isn't needed. 2) In PSDRV_WriteSetDownloadFont() in download.c you call PSDRV_WriteSetFont() with (lf.lfFaceName[0] == '@') for this new parameter vertical. I can't see why. 3) You added the parameter vertical to get_download_name() in download.c You use it to add "_vertical" to its name if vertical is true. I can't see why the font needs a different name. This will cause PSDRV_WriteSetDownloadFont() to download a font which is used vertically and horizontally twice. I can't see any reason why this could be necessary. I think that * PSDRV_WriteSetFont() should be changed back and of course the callers, too (in builtin.c and download.c) * get_download_name() should also be changed back (and its call in PSDRV_WriteSetDownloadFont()) Regards, -- Wolfgang Walter Studentenwerk München

2 1

Re: [patch fix]for 98152 and 98151,the encoding type was wrong.
by Akihiro Sagawa 26 Aug '13

26 Aug '13

On Sun, 25 Aug 2013 23:13:53 +0900, matyapiro31 wrote: > The first one is > 0001-add-japanese-man-page-of-wine.patch > the second one is > 0001-last-change-of-my-translation-of-man-page.patch > Please cancel 98152 and 98151and try those two. These translations are outdated. The file seems to be based on wine 1.4 release. Makefile.in has a lot of formatting errors. You'd also refine it before resubmitting. Regards, Akihiro Sagawa

1 0

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.
by Alexandre Julliard 26 Aug '13

26 Aug '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > MSDN for FlushFileBuffers says: > Flushes the buffers of a specified file and causes all buffered data to be > written to a file. > > Linux man page says: > tcdrain() waits until all output written to the object referred to by fd has > been transmitted. It's a blocking call, you can't do that on the server side. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [PATCH 1/2] advapi32/tests: Add tests for hkcr handle mask
by Nikolay Sivov 24 Aug '13

24 Aug '13

On 8/24/2013 07:11, George Stephanos wrote: > +#define IS_HKCR(hk) ((UINT_PTR)hk > 0 && ((UINT_PTR)hk & 3) == 2) > + Why is that important to check? In other words what depends on particular value pattern?

1 0

Re: [PATCH 4/6] wined3d: Enforce volume mapping restrictions
by Alexandre Julliard 23 Aug '13

23 Aug '13

Stefan Dösinger <stefan(a)codeweavers.com> writes: > --- > dlls/wined3d/volume.c | 7 +++++++ > 1 file changed, 7 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so volume.c && touch volume.ok volume.c:187: Test succeeded inside todo block: D3DXLoadVolumeFromMemory returned 0x8876086c, expected 0x8876086c make: *** [volume.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Wiki is down
by Rosanne DiMesio 23 Aug '13

23 Aug '13

I'm getting an "Unable to connect" message from Firefox and "Connection closed by remote server" from Opera. -- Rosanne DiMesio <dimesio(a)earthlink.net>

3 3

winmm: Increase mmdevapi buffer sizes.
by Joerg-Cyril.Hoehle＠t-systems.com 23 Aug '13

23 Aug '13

Hi, Andrew Eikum argued: -/* buffer size = 10 * 100000 (100 ns) = 0.1 seconds */ +/* buffer size = 100 * 100000 (100 ns) = 1 second */ >The tiny buffer size caused audio capture glitches on OSX, where the OS >often returns audio in half-second chunks. That may be good enough for winmm, but that does not solve the problem in general. Since Vista, apps can access mmdevapi directly, thus they won't benefit from this increase in winmm buffer size. I believe that instead and in general, Wine should decouple WinAPI usage from idiosyncrasies of the underlying OS. IOW, apps requesting a mmdevapi capture buffer of a size that typically works on native should work in Wine too. If 100-200ms is that typical size, then it must be made to work with Wine's back-ends, perhaps by using a hidden buffer of at least 1s *internally* in winecoreaudio (and presumably winealsa for when Jack is in use). Somehow, Wine must bridge the impedance mismatch between native's 100-200ms buffers and the observed >0.5s buffer requirements on OSX. BTW, does that imply that input signal processing will see data with 0.5s latency on OSX? Would there be a 0.5s delay in chat applications? Regards, Jörg Höhle

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel