wine-devel October 2003

wine-devel@winehq.org

166 participants
384 discussions

Start a nNew thread

Re: French keyboard layout with Euro symbol
by RemiAssailly＠aol.com 29 Oct '03

29 Oct '03

I sent a patch that looks like yours and it was simply refused ! I wasn't the fisrt...

4 10

Re: DINPUT device unacquire (mouse) fix
by Andreas Mohr 29 Oct '03

29 Oct '03

Hi, On Tue, Oct 28, 2003 at 02:53:44AM +0200, Hannu Valtonen wrote: > License: LGPL > > I stumbled upon this when looking at fixing mouse support for Crimson > lands. According to MSDN DirectInputDevice Unacquire is allowed even for > devices which haven't been acquired yet. > > Changelog: > - SysMouseAImpl_Unacquire should return DI_NOEFFECT if the device is not > in an acquired state. Ah, thanks!! Maybe this is why some game (I believe it was UT) broke... Darn, why didn't I discover that when I stumbled on that place years ago? But don't you think keyboard and joystick might need the same code?? (keyboard has it as well, but with completely different code --> mess) This could probably be cleaned up. Andreas Mohr

2 2

WinE-Bug? InternetCrackUrl incorrectly sets dwUrlPathLength
by Jan Sporbeck 29 Oct '03

29 Oct '03

Hi, During some application testing, we discovered that WinE does not correctly mimic the WinINet function InternetCrackUrl. The real WinAPI sets the dwUrlPathLength member of the URL_COMPONENTS structure to additionally hold the extra info of the given URL if the extra info is not requested as a separate component. Although this behaviour is not well documented by the Win SDK, it is for instance implemented on WinXP, Win2000 and WinME and therefore might be considered to be intended by Microsoft. The following lines of code demonstrate the problem: LPCTSTR lpszURL = _T("http://www.myserver.com/myscript.php?arg=1"); URL_COMPONENTS url; // call 1: crack out url path and extra info ::ZeroMemory(&url, sizeof(url)); url.dwStructSize = sizeof(url); url.dwHostNameLength = 1; url.dwUrlPathLength = 1; url.dwExtraInfoLength = 1; ::InternetCrackUrl(lpszURL, 0, 0, &url); // dwUrlPathLength is 13, holding "/myscript.php" // call 2: only crack out url path ::ZeroMemory(&url, sizeof(url)); url.dwStructSize = sizeof(url); url.dwHostNameLength = 1; url.dwUrlPathLength = 1; ::InternetCrackUrl(lpszURL, 0, 0, &url); // now, dwUrlPathLength should be 19, holding "/myscript.php?arg=1", // while WinE still sets it to 13 OK, it is of course no great deal to write code that correctly runs on real Win systems and on WinE (2-3 lines did it). But programers who rely on this behaviour will for example wonder why their applications don't transmit any HTTP GET parameters when they call HttpOpenRequest with lpszObjectName set to the URL path component returned by InternetCrackUrl... This applies to Wine 20031016, haven't found any recent report on this though. /jan.

1 0

spec files - syntax and generation
by "Martin Tröster" 29 Oct '03

29 Oct '03

Hi, once again I would like to get your advice on spec files. I now compiled a Windows application successful against winelib and can link it without problems. However, the application segfaults immediately when starting wine. I am tracking this back to .spec files (although I will need to debug in the next free time to be sure), since they are the weakest link I am seeing, since I wrote most of them by hand. So it would be great if you can answer the following questions: - Automatic generation: I composed the spec files by hand, based on Windows def files. Is there an automatic way to do that? I noticed a (somewhat hidden) tool called winedump, with nearly not existing documentation, but could not make much use of it. Any hints here? - Stack size and parameters in spec file: The def files are, as far as I know, very similar to the spec files: they contain the function name (either mangled or not mangled), as well as (most of the time) the stack space - format: functionname@stackspace. Is there anything wrong to translate an entry for "char* testfunc(char* str, int var1, long var2, long* ptr)" called "testfunc@16" into "@stdcall testfunc(ptr ptr ptr ptr)", without caring for the type of parameters? More explicitely asked, what use do I have from using str or long instead of ptr in the spec file? - Stdcall vs. cdecl How do I find out whether a function uses CDECL instead of STDCALL? I found the information (link lost unfortunately) that entries in the def file like testfunc1@0 are called via STDCALL, whereas in case of testfunc2 without any @ specifying the space is CDECL. Is this guess right? If not, how else do I find this out? Thanks again for any help! Cheers, Martin ______________________________________________________________________________ Bestes Testergebnis: Stiftung Warentest Doppelsieg fur WEB.DE FreeMail und WEB.DE Club. Nur fuer unsere Nutzer! http://f.web.de/?mc=021182

4 5

Re: PATCH: server/named_pipe.c (RESENT)
by Alexandre Julliard 28 Oct '03

28 Oct '03

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > was there any problem with the following patch, or did it just fall > through the cracks? ;-) > > Gerald > > ChangeLog: > Remove unused variable pipe_client_fd_ops. Well, either the client side should really use pipe_client_fd_ops, or pipe_server_fd_ops should be renamed to show that it is used by both client and server. I'm not sure which one was intended, could the named pipe experts please check that? -- Alexandre Julliard julliard(a)winehq.com

1 0

Support for TLS in CrossOver
by Mike Hearn 28 Oct '03

28 Oct '03

Hi Alexandre, I noticed the ChangeLog for the new CXOffice release (congrats on that btw!) said it now works with all glibc 2.3 variants. Does that mean the TLS related named pipe breakage we saw earlier is now fixed? If so, do you know when the fix will be in WineHQ CVS? thanks -mike

3 3

WineHQ: PATCH to fix IPersistFile::Load() and associated functions
by Subhobroto Sinha 28 Oct '03

28 Oct '03

Hello all I finally produced the "official patch" after verifying that everything is OK. This patch has been inlined as well as attached as a ZIP file, so suit yourself. All reports regaring this patch is to be sent to <subhobrotosinha at yahoo.com> with a proper subject prefixed by "IPersistFile patch" in the subject header. Just don't simply hit the 'Reply' button ! This patch fixes: (1) Stream_LoadString: Conflict of unicode strings being taken as LPSTR and AGAIN being converted to Unicode due to wrong value of SCF_UNICODE .(I have really NOT changed the original code, but redirected this call to a fixed function which I named wineStream_LoadString. This should remain so until SCF_UNICODE value is corrected) (2) Stream_LoadLocation: Previously the GetPath() failed. It works great now. For the uninitiated, here's what has to be done: Please make sure that you have the 20031016 source (latest tarball) (1)Copy this .diff to the root folder of the Wine source (2)Run 'patch' on this diff file (3)It should patch "dlls/shell32/shelllink.c". Change to that directory (4)Type 'make' to rebuild 'shell32.dll.so' (5)'su' out and overwrite/symlink the current 'shell32.dll.so' over the installed one Now IPersistFile::Load() should work as intended. Try out McCormack's 'winemenubuilder' or my WineLib 'linkresolve' (NOT my C++ version) If the diff is not proper, etc, please alert me at the mentioned address PS: As I am not a member of 'wine-patches',can the moderator be kind enough... :=) I really want these functions to get fixed. That's all. Regards Subhobroto Sinha __________________________________ Do you Yahoo!? Exclusive Video Premiere - Britney Spears http://launch.yahoo.com/promos/britneyspears/ --- dlls/shell32/shelllink.c.original 2003-10-22 17:56:31.000000000 +0530 +++ dlls/shell32/shelllink.c 2003-10-26 16:30:57.000000000 +0530 @@ -401,9 +401,49 @@ return S_OK; } +static HRESULT wineStream_LoadString( IStream* stm, LPWSTR *pstr ) +{ + DWORD count=0; + USHORT len; + LPWSTR str=NULL; + HRESULT r; + /* + From Win98 upwards unicode==TRUE.(Atleast for shortcuts..) + However, the value of SCF_UNICODE does NOT seem to be 0x1000. + Until then, we assume it true. + Anybody differing mail to <subhobrotosinha at yahoo.com>. + */ + TRACE("%p\n", stm); + + r = IStream_Read(stm, &len, sizeof(len), &count); + if(FAILED(r)||(count != sizeof(len))) return E_FAIL; + + len *= sizeof(WCHAR); + + TRACE("reading %d\n", len); + str = HeapAlloc(GetProcessHeap(), 0, len+sizeof(WCHAR)); + if(!str) return E_OUTOFMEMORY; + + count = 0; + r = IStream_Read(stm, str, len, &count); + if( FAILED(r)||( count!=len) ) + { + HeapFree( GetProcessHeap(), 0, str ); + return E_FAIL; + } + + str[count/2]=0; + *pstr = str; + TRACE("read %s\n", debugstr_w(str)); + return S_OK; +} static HRESULT Stream_LoadString( IStream* stm, BOOL unicode, LPWSTR *pstr ) { +/*This is the original function short circuited to the above till we find out correct 'SCF_UNICODE'. +Now it's assumed that the data's unicode. (This assumption failes iff the OS was <=Win95*/ +return (wineStream_LoadString(stm,pstr)); +#if 0 DWORD count; USHORT len; LPVOID temp; @@ -453,6 +493,7 @@ *pstr = str; return S_OK; +#endif } static HRESULT Stream_LoadLocation( IStream* stm ) @@ -533,6 +574,14 @@ if( FAILED( r ) ) return r; } + ////////////////////////////////////////////////////////////////////////////////////// + char szTemp[MAX_PATH]={0}; + SHGetPathFromIDListA(This->pPidl,szTemp); + This->sPath=HeapAlloc( GetProcessHeap(), 0,(strlen(szTemp)+1)*sizeof(WCHAR)); + MultiByteToWideChar(CP_ACP,0,szTemp,(strlen(szTemp)+1),This->sPath,(strlen(szTemp)+1)); + //TRACE("%s\n",szTemp); + ////////////////////////////////////////////////////////////////////////////////////// + This->wHotKey = hdr.wHotKey; This->iIcoNdx = hdr.nIcon; FileTimeToSystemTime (&hdr.Time1, &This->time1);

3 3

Winesetuptk 0.7 released
by Ivan Leo Murray-Smith 28 Oct '03

28 Oct '03

Hi lists, Winesetuptk 0.7 is at the wine sourceforge page http://sourceforge.net/project/showfiles.php?group_id=6241 This new version contains an updated winedefault.reg, you don't need to run regedit winedefault.reg any more, and it's updated to configurate all the latest and greatest features of wine. This release was possible thanks to the help and contributions of Vincent Béron and Alex Pasadyn. Without them, winesetuptk 0.7 wouldn't exist. Download and enjoy!

1 0

Status of HeapAlloc Cleanup in shell32
by Steven Edwards 28 Oct '03

28 Oct '03

Is the HeapAlloc/ReAlloc stuff being tracked anywhere? I think it is the cause of a lot of problems I have with shell32 under Windows and ReactOS. Applications linked to wine shell32.dll under Windows2000 run fine but when you exit they get illigal op's where the memory could not be "read" kind of like the bug I had in uninstaller.exe that started the HeapAlloc cleanup. Thanks Steven __________________________________ Do you Yahoo!? Exclusive Video Premiere - Britney Spears http://launch.yahoo.com/promos/britneyspears/

2 1

Re: wine/ tools/winebuild/relay.c dlls/ntdll/signa ...
by Robert Shearman 28 Oct '03

28 Oct '03

This has fixed the problem slightly (see message titled "Bug in cxx_frame_handler") - the program now displays: err:seh:setup_exception stack overflow 592 bytes in thread 000e eip 401c425a esp 40640db0 stack 0x40540000-0x40750000 And then exits. I still believe there is a problem in dlls/msvcrt/cppexcept.c with the following lines (359-364): if (!exc_type) /* nested exception, fetch info from original exception */ { rec = msvcrt_get_thread_data()->exc_record; exc_type = (cxx_exception_type *)rec->ExceptionInformation[2]; } The problem is that msvcrt_get_thead_data()->exc_record returns NULL (probably because there is no nested exception?). Should there just be a check there for a NULL pointer or is it part of a bigger problem? Rob On Tuesday 28 October 2003 12:30 am, you wrote: > ChangeSet ID: 9891 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2003/10/27 18:30:55 > > Modified files: > tools/winebuild: relay.c > dlls/ntdll : signal_i386.c > > Log message: > Switch back to the main process stack before calling exception > handlers. > > Patch: http://cvs.winehq.com/patch.py?id=9891 > > Old revision New revision Changes Path > 1.31 1.32 +27 -28 wine/tools/winebuild/relay.c > 1.73 1.74 +297 -165 wine/dlls/ntdll/signal_i386.c

1 0

← Newer
1
2
3
4
5
6
7
8
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel October 2003