wine-devel December 2003

wine-devel@winehq.org

109 participants
267 discussions

RE: Fix after recent urlcache changes
by Robert Shearman 28 Dec '03

28 Dec '03

> -----Original Message----- > From: Gerald Pfeifer [mailto:gerald@pfeifer.com] > Sent: 28 December 2003 14:00 > To: Robert Shearman > Cc: wine-patches(a)winehq.com > Subject: Fix after recent urlcache changes > > After the following change to dlls/wininet/urlcache.c > > revision 1.14 > date: 2003/12/12 06:01:20; author: julliard; state: Exp; > lines: +976 -418 > Robert Shearman <R.J.Shearman(a)warwick.ac.uk> > - Url Cache improvements. > - In Internet{Set,Query}Option functions, hInternet can be NULL. > - Add traces to Internet* functions. > > I started getting the following compiler warning > urlcache.c:556: warning: `URLCache_FindEntry' defined but not used > as URLCache_FindEntry() is a static (file local) function, but not used > anywhere any longer. > > The patch below fixes this. > > Gerald That code should probably adapted into the FindFirstUrlCacheEntry and related functions. If you are adamant about removing the warning, please enclose it in "#if 0... endif" instead so that someone does not try to duplicate the work. Rob

1 0

instance problem in CreateWindowEx{A,W,16}
by Peter Oberndorfer 28 Dec '03

28 Dec '03

Hello Trying to run PEview.exe i found a problem. First i create a window with CreateWindowEx and pass 0 as instance. When trying to read the instance with GetWindowLong(hWnd,GWL_HINSTANCE) # Wine returns 0 as passed to the function. # Win 98 returns 0x400000 which is what GetModuleHandle( NULL ) gives me. For the CreateWindowEx{A,W} it can easily be fixed by adding this two lines at the beginning of the function: if (instance == 0) instance = GetModuleHandleW( NULL ); But For CreateWindowEx16 i'm not sure how to check. But i had a look at some code in class.c, where similar checks are performed and constructed following: if (!HINSTANCE_32(instance)) instance = HINSTANCE_32(GetModuleHandle16(NULL)); So does the code for CreateWindowEx16 look right? Greetings Peter

3 2

reverse engineering
by Stefan Leichter 28 Dec '03

28 Dec '03

Hello, if i use a debugger to find the number of parameters of an undocumented function, will a patch based on this knowledge be accepted in wine ? Is this the normal way to deal with undocumented stuff? Or is it better to make a test program that prints the stack pointer before and after the call to the undocumented function? Bye Stefan

3 2

Re: Status ToDo's #2
by Ivan Leo Murray-Smith 28 Dec '03

28 Dec '03

>Was anybody already working on a control panel like applet for Wine? >That would be a panel in which you could configure Wine without having >to edit the text files... There already is such a tool, winesetuptk, but it's never been included in the wine source. A new and more advanced one, called winecfg is in preparation. Look in the wine source tree in programs/winecfg. AFAIK it needs a lot of work done, so I'm sure your help will be welcome. It works within wine, and doesn't change settings yet. Ivan.

1 0

DEVELOPERS-HINTS.diff
by Tom 28 Dec '03

28 Dec '03

Hi, Changelog add newdev section, update DMusic section, small fix to dpnhpast Tom

1 0

HTML Doc generation...
by Joshua Walker 28 Dec '03

28 Dec '03

Hi all, Well, I've pulled down a CVS copy of wine and I'm currently at work overhauling the API documentataion. I do have some nitpicks. 1) I'm using the HTML documentation (make doc-html) to check my work. An issue I kind of have with this is an index.html isn't generated. This would be most trivial as all it has to be is an alphabetical link to a.html, b.html, c.html etc...unless there is an index and I'm not seeing it. Also, in the lettered indexes, a delemiter, like a <hr> tag between the API function calls and the dll names would be nice. My perl-foo is quite weak. I'll see what I can hack togeather myself... -Joshua

1 1

Initial feedback
by tom alderweireldt 27 Dec '03

27 Dec '03

Hello, I've just started to work my way through your Wine User Guide. I'm not a complete newbie (I've been playing with Linux for a while on a dual boot PC), but I'm certainly not a specialist. It looks like my RedHat 8.0 default installation came with Wine-20020605. I searched for the check & configuration tools you recommend on pages 16 and 17, but they were missing. I found the winecheck script, but that returned an appallingly low score of only 1.78% after I copied the default config file on a freshly created /.wine directory. So I'm now trying to figure out wether I try to get the configuration right for the existing default Wine installation or just throw it away and restart from scratch with the latest source code. So far your user guide is quite helpful, but it looks like I have a loooong way to go to a working Wine setup. Thanks for the starting text anyway, I'll let you know suggestions for improvement, Best Regards, Tom Alderweireldt

2 1

Mouse cursor doesn't switch correctly...
by Robert van Herk 27 Dec '03

27 Dec '03

Hi folks, I may be asking for a needle in the haystack, but: While playing Warcraft III under Wine, I noticed something odd. Warcraft uses both a hand as a mouse cursor as a target (circle with cross in the middle) icon. In ordinary Win32, these two seem to switch. Under wine, however, only the target cursor is visible. That means that I as a user have to click to right below to the spot i would click intuivily, since I see a target, but the program thinks I'm using the hand as a pointer. I would like to solve this issue by creating some kinda patch, but I have no idea what might be going wrong... Do you have any clues? Grtz, Robert

1 0

Re: FindWindow should not match against partial names
by Eric Pouech 27 Dec '03

27 Dec '03

Mike Hearn wrote: > - if (GetWindowTextW( list[i], buffer, len ) && !strcmpiW( buffer, title )) break; a simpler fix would be to use len + 1 instead of len here. A+ -- Eric Pouech

1 0

Status ToDo's
by Tom 27 Dec '03

27 Dec '03

Anyone have any comments, or something they believe I should add before I send the patch? Tom

6 7

← Newer
1
...
4
5
6
7
8
9
10
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel December 2003