wine-devel March 2003

wine-devel@winehq.org

109 participants
285 discussions

GetWindowTextA unicode issues
by Florian Schirmer 07 Mar '03

07 Mar '03

Hi, I've a rather strange problem. Some windows (iirc all of them are dialog windows) have crippled window titles. Only the first character is dispayed. I've tried to tackle this bug down, but it was a major PITA and i was somehow unsuccessfull. What i've found out so far is: 1. GetWindowTextA( ... WM_GETTEXT ... ) is called to resolve the window title. 2. SendMessageA( ... WM_GETTEXT ... ) is called 3. SendMessageTimeoutA( ... WM_GETTEXT ... ) is called 4. call_window_proc( ... WM_GETTEXT ... unicode==FALSE ...) is called 5. CallWindowProcA( ... WM_GETTEXT ... ) is called 6. if (!proc) return WINPROC_CallWndProc( ... WM_GETTEXT ... ) is called << here i was unable to resolve the codepath futher down >> But i was able to find the codepath a bit later again: ?. DefWindowProcW( ... WM_GETTEXT ... ) is called Somehow wine (or the application) managed to route the GetWindowTextA( ... WM_GETTEXT ... ) ansi call to the DefWindowProcW( ... WM_GETTEXT ... ) unicode handler. Maybe someone has a clue how to tackle this bug down? I've attached a patch which will work around this issue. It's an ugly hack so i don't propose it for cvs inclusion. Regards, Florian Schirmer --- windows/win.c-old Wed Jan 8 22:09:25 2003 +++ windows/win.c Fri Mar 7 14:23:47 2003 @@ -2264,15 +2264,33 @@ INT WINAPI GetWindowTextA( HWND hwnd, LP { WCHAR *buffer; - if (WIN_IsCurrentProcess( hwnd )) - return (INT)SendMessageA( hwnd, WM_GETTEXT, nMaxCount, (LPARAM)lpString ); - - /* when window belongs to other process, don't send a message */ if (nMaxCount <= 0) return 0; if (!(buffer = HeapAlloc( GetProcessHeap(), 0, nMaxCount * sizeof(WCHAR) ))) return 0; - get_server_window_text( hwnd, buffer, nMaxCount ); - if (!WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpString, nMaxCount, NULL, NULL )) - lpString[nMaxCount-1] = 0; + + if (WIN_IsCurrentProcess( hwnd )) { + + SendMessageA( hwnd, WM_GETTEXT, nMaxCount, (LPARAM)buffer ); + + if (strlen((char *)buffer) == 1) { + + if (!WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpString, nMaxCount, NULL, NULL )) + lpString[nMaxCount-1] = 0; + + } else { + + strncpy(lpString, (char *)buffer, nMaxCount); + + } + + } else { + + /* when window belongs to other process, don't send a message */ + get_server_window_text( hwnd, buffer, nMaxCount ); + if (!WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpString, nMaxCount, NULL, NULL )) + lpString[nMaxCount-1] = 0; + + } + HeapFree( GetProcessHeap(), 0, buffer ); return strlen(lpString); }

1 0

Windows Longhorn 3683 complaince status
by Mathew McBride 07 Mar '03

07 Mar '03

Yes, I mean it!. I've managed to get hold of Windows Longhorn Build 3683. All tests should be simular to WinXP at the moment with notable changes in: * Internet Explorer. Internet Explorer cannot download files. It appears to have been fixed in 4008. Use Mozilla instead. It's way better. * DirectX. DirectX appears to be the 899 build, not the 900 build being distributed at the moment on Microsoft's website. Sources tell me that the version in 4008 still has the same build identifier and same size. DirectX diag is unable to run Display tests, claiming a button was pressed. * IPv6. Doesn't affect Wine, but Longhorn doesn't seem to include IPv6 at all * FileSystem. Changes introduced by WinFS Storage services (which needs to be turned off because it sucks a lot of CPU power) are unclear at the moment * Compliance mode. There is a WinXP compliance mode. But it only seems to affect the build identifier used. * GUI. I had to force Explorer.exe into Safe Mode in the .NET Framework manager to stop it from delaying the playing of the welcome sound. Also included is a new theme called Plex and a XML based sidebar. A new XML based display panel is also included, but has been mothballed in 4008. The sidebar includes a desktop switching panel. You only have 4 of them, however. * Others. TabletPC apps (Journal etc.) are included and also drag the system down a bit. But journal.exe seems to be missing. Anyone have any idea about these services and weather they have any place in Longhorn/NT 6.0: Fusion Isolation Service Castle Service Logon Hours (This appears to be more domain oriented, I didn't see this in XP SP1) - Windows still has the nasty activation feature, and as usual, includes a timebomb of 360 days. Both of these have been disabled in the registry. It turns out, that the leaked build also contains Beta's of: Longhorn XP Home Longhorn .NET Server Web Edition " " " Standard " " " Enterprise " " " Datacenter (mothballing of this edition is likley, Unisys is only vendor of 2000 Datacenter and there is no 2003 Datacenter edition) Which means that a Syncronised Server and Client release will probably happen in 2004/5. I was not able to test out the Web servers, because I am using a FAT32 Filesystem. (I did switch to Enterprise though, but soon went back) - Pinball seems to be easier and louder (note: I am using hacked C-Media drivers from http://www.xenomorph.net/) - NT 4.0 drivers don't seem to be working anymore (I tried using the ACARD NT 4.0 driver) Now to the tests: (*PLEASE* include a batch file. It's getting me irratated) (You might want to print this out) (Perhaps we can implement an /all switch to each test) advapi32_test.exe /registry registry.c:97: Test failed: value set to 'xxxxxxxxxx' instead of 'Te' registry.c:98: Test failed: data set to 'xxxxxxx' instead of 'foobar' registry.c:112: Test failed: data set to 'xxxxxxx' instead of 'foobar' /registry: 56 tests executed, 0 marked as todo, 3 failures. dsound_test.exe /dsound dsound.c:372:Testing Primary Sound Driver - dsound.c:386: DirectSound Caps: flags=0x00000f5f secondary min=100 max=100000 dsound.c:397: Testing the primary buffer dsound.c:239: Caps: flags=0x00000009 size=32768 dsound.c:253: tag=0x0001 22050x8x2 avg.B/s=44100 align=2 dsound.c:269: status=0x0000 dsound.c:290: tag=0x0001 11025x16x2 avg.B/s=44100 align=4 dsound.c:412: Testing a secondary buffer at 11025x8x1 dsound.c:239: Caps: flags=0x000100e4 size=4410 dsound.c:253: tag=0x0001 11025x8x1 avg.B/s=11025 align=1 dsound.c:269: status=0x0000 dsound.c:427: Testing a secondary buffer at 48000x16x2 dsound.c:239: Caps: flags=0x000100e4 size=76800 dsound.c:253: tag=0x0001 48000x16x2 avg.B/s=192000 align=4 dsound.c:269: status=0x0000 dsound.c:372:Testing C-Media Wave Device - cmaudio.sys dsound.c:386: DirectSound Caps: flags=0x00000f5f secondary min=100 max=100000 dsound.c:397: Testing the primary buffer dsound.c:239: Caps: flags=0x00000009 size=32768 dsound.c:253: tag=0x0001 22050x8x2 avg.B/s=44100 align=2 dsound.c:269: status=0x0000 dsound.c:290: tag=0x0001 11025x16x2 avg.B/s=44100 align=4 dsound.c:412: Testing a secondary buffer at 11025x8x1 dsound.c:239: Caps: flags=0x000100e4 size=4410 dsound.c:253: tag=0x0001 11025x8x1 avg.B/s=11025 align=1 dsound.c:269: status=0x0000 dsound.c:427: Testing a secondary buffer at 48000x16x2 dsound.c:239: Caps: flags=0x000100e4 size=76800 dsound.c:253: tag=0x0001 48000x16x2 avg.B/s=192000 align=4 dsound.c:269: status=0x0000 /dsound: 61 tests executed, 0 marked as todo, 0 failures. gdi32_test.exe /generated /generated: 2786 tests executed, 0 marked as todo, 0 failures. kernel32_test.exe /alloc. 58 executed, 0, 0 /atom 229398 executed, 0 ,0 /codepage 2 executed, 0 ,0 /drive 158 executed, 0, 0 /environ 39 executed, 0, 0 file.c:633:Current offset = 0015 file.c:658:Current offset = 0015 /file: 487239 executed, 0, 0 /format_msg 58 executed, 0, 0 /generated 609 executed, 0, 0 locale.c:154: Test failed: GetTimeFormat got '' instead of '4' locale.c:155: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:181: Test failed: GetTimeFormat got '8.@:56AM' instead of '8.@:56.@:AM' locale.c:182: Test failed: GetTimeFormat: got 9 instead of 12 locale.c:190: Test failed: GetTimeFormat got '' instead of '3' locale.c:191: Test failed: GetTimeFormat: got 1 instead of 2 locale.c:466: Test failed: GetDateFormat got '5/4/2002' instead of '5/4/02' locale.c:467: Test failed: GetDateFormat: got 9 instead of 7 locale.c:489: Test failed: GetDateFormat check DATE_YEARMONTH with null format expected ERROR_INVALID_FLAGS got return of '10' and error of '0' locale.c:520: Test failed: GetDateFormatW allowed flags and format locale.c:529: Test failed: GetDateFormatW did not permit null buffer pointer when counting. /locale: 112 executed, 0 , 11 failures. path.c:881:TMP=D:\DOCUME~1\Matt\LOCALS~1\Temp path.c:892:TMP=D:\WINDOWS path.c:902:TMP=D:\ path.c:912:TMP=D: /path: 1730 executed, 0, 2 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. tests/process.c: 1 tests executed, 0 marked as todo, 0 failures. process.c:385: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process , got D:\wine\kernel32_test.exe process.c:537: Test failed: StartupInfoA:lpTitle expected kernel32_test.exe process , got D:\wine\kernel32_test.exe process.c:870: Test failed: StartupInfoA:lpDesktop expected (null), got WinSta0\Default process.c:871: Test failed: StartupInfoA:lpTitle expected (null), got D:\wine\kernel32_test.exe process.c:918: Test failed: StartupInfoA:lpDesktop expected (null), got WinSta0\Default process.c:919: Test failed: StartupInfoA:lpTitle expected (null), got D:\wine\kernel32_test.exe process: 285 tests executed, 0 marked as todo, 6 failures. thread: 112 tests executed, 0 marked as todo, 0 failures. msvcrt_test.exe /file: 2 tests executed, 0 marked as todo, 0 failures. /scanf: 9 tests executed, 0 marked as todo, 0 failures. netapi32_test.exe access.c:110: Test failed: Bad Network Path: rc=0 /access: 23 tests executed, 0 marked as todo, 1 failure. /apibuf: 15 tests executed, 0 marked as todo, 0 failures. /wksta: 14 tests executed, 0 marked as todo, 0 failures. ntdll_test.exe error.c:81: Test failed: STATUS_SMARTCARD_CERT_REVOKED (c0000389): got -2146892975, expected 1266 (or MID_NOT_FOUND) error.c:81: Test failed: STATUS_ISSUING_CA_UNTRUSTED (c000038a): got -2146892974, expected 1267 (or MID_NOT_FOUND) error.c:81: Test failed: STATUS_REVOCATION_OFFLINE_C (c000038b): got -2146892973, expected 1268 (or MID_NOT_FOUND) error.c:81: Test failed: STATUS_PKINIT_CLIENT_FAILURE (c000038c): got -2146892972, expected 1269 (or MID_NOT_FOUND) error.c:81: Test failed: STATUS_SMARTCARD_CERT_EXPIRED (c000038d): got -2146892971, expected 1270 (or MID_NOT_FOUND) (NOTE: Longhorn seems to include invalid certs. Microsoft probably doesn't care) /error: 813 tests executed, 0 marked as todo, 5 failures. /generated: 1279 tests executed, 0 marked as todo, 0 failures. /rtlbitmap: 224 tests executed, 0 marked as todo, 0 failures. /rtlstr: 38 tests executed, 0 marked as todo, 0 failures. oleaut32_test.exe safearray.c:149: Test failed: SAC(20,1,[1,0]), result 8, expected 0 safearray.c:158: Test failed: SAGE for vt 20 returned elemsize 8 instead of expected 0 safearray.c:179: Test failed: copy of SAC(20,1,[1,0]), result 8, expected 0 safearray.c:182: Test failed: SAGE for vt 20 returned elemsize 8 instead of expected 0 safearray.c:149: Test failed: SAC(21,1,[1,0]), result 8, expected 0 safearray.c:158: Test failed: SAGE for vt 21 returned elemsize 8 instead of expected 0 safearray.c:179: Test failed: copy of SAC(21,1,[1,0]), result 8, expected 0 safearray.c:182: Test failed: SAGE for vt 21 returned elemsize 8 instead of expected 0 /safearray: 936 tests executed, 0 marked as todo, 8 failures. vartest.c:1761:======== Testing VarUI1FromXXX ======== vartest.c:1849:======== Testing VarUI2FromXXX ======== vartest.c:1936:======== Testing VarUI4FromXXX ======== vartest.c:2022:======== Testing VarI1FromXXX ======== vartest.c:2088:======== Testing VarI2FromXXX ======== vartest.c:2133:======== Testing VarI4FromXXX ======== vartest.c:2177:======== Testing VarR4FromXXX ======== vartest.c:2224:======== Testing VarR8FromXXX ======== vartest.c:2244:======== Testing VarDateFromXXX ========` vartest.c:2371:======== Testing VarBSTRFromXXX ======== vartest.c:2604:======== Testing Hi-Level Variant API ======== vartest.c:2691:======== Testing different VARTYPES ======== /vartest: 1875 tests executed, 0 marked as todo, 0 failures. rpcrt4_test.exe rpc.c:124: ** Uuid Conversion and Comparison Tests ** /rpc: 901 tests executed, 0 marked as todo, 0 failures. shell32_test.exe /generated: 272 tests executed, 0 marked as todo, 0 failures. shlfileop.c:122: Test failed: File should be removed shlfileop.c:130: Test failed: Directory should be removed shlfileop.c:177: Test failed: Can't rename many files shlfileop.c:185: Test failed: Can't rename many files shlfileop.c:225: Test failed: Can't copy many files shlfileop.c:244: Test failed: Can't copy many files shlfileop.c:286: Test failed: Files are copied to other directory shlfileop.c:287: Test failed: The file is copied shlfileop.c:317: Test failed: The file is moved shlfileop.c:318: Test failed: The directory is moved shlfileop.c:319: Test failed: The file in subdirectory is moved shlfileop.c:341: Test failed: Can't move many files shlfileop.c:354: Test failed: Can not move many files /shlfileop: 121 tests executed, 0 marked as todo, 13 failures. (It looks like I'm loosing memory) urlmon_test.exe did not execute at all user32_test.exe /class: 80 tests executed, 0 marked as todo, 0 failures. /generated: 1524 tests executed, 0 marked as todo, 0 failures. sysparams.c:176:testing SPI_{GET,SET}BEEP sysparams.c:311:testing SPI_{GET,SET}MOUSE sysparams.c:414:testing SPI_{GET,SET}KEYBOARDSPEED sysparams.c:446:testing SPI_ICONHORIZONTALSPACING sysparams.c:489:testing SPI_{GET,SET}SCREENSAVETIMEOUT sysparams.c:523:testing SPI_{GET,SET}SCREENSAVEACTIVE sysparams.c:560:testing SPI_{GET,SET}KEYBOARDDELAY sysparams.c:593:testing SPI_ICONVERTICALSPACING sysparams.c:644:testing SPI_{GET,SET}ICONTITLEWRAP sysparams.c:676:testing SPI_{GET,SET}MENUDROPALIGNMENT sysparams.c:711:testing SPI_{GET,SET}DOUBLECLKWIDTH sysparams.c:741:testing SPI_{GET,SET}DOUBLECLKHEIGHT sysparams.c:772:testing SPI_{GET,SET}DOUBLECLICKTIME sysparams.c:824:testing SPI_{GET,SET}MOUSEBUTTONSWAP sysparams.c:850:testing SPI_GETFASTTASKSWITCH sysparams.c:865:testing SPI_{GET,SET}DRAGFULLWINDOWS sysparams.c:903:testing SPI_{GET,SET}WORKAREA sysparams.c:947:testing SPI_{GET,SET}SHOWSOUNDS sysparams.c:997:testing SPI_{GET,SET}DESKWALLPAPER /sysparams: 358 tests executed, 0 marked as todo, 0 failures. win.c:91:main window 004D00EE main2 00470270 desktop 00010010 child 01040216 win.c:107:created child 004501D6 win.c:120:created child of desktop 004601D6 win.c:130:created child of child 004701D6 win.c:140:created top-level 004801D6 win.c:150:created owned top-level 004901D6 win.c:160:created popup 004A01D6 win.c:170:created owned popup 004B01D6 win.c:180:created top-level owned by child 004C01D6 win.c:186:created popup owned by desktop 004D01D6 win.c:192:created popup owned by child 004E01D6 win.c:198:created WS_CHILD popup 004F01D6 win.c:204:created owned WS_CHILD popup 005001D6 win.c:209:testing parent changes win.c:221:created child 005101D6 win.c:247:created top-level 005201D6 win.c:264:created popup 005301D6 win.c:281:created child 005401D6 win.c:298:created top-level 005501D6 win.c:307:created owned popup 005601D6 win.c:323:created owner 005701D6 and popup 00390206 win.c:337:created owner 003A0206 and popup 005801D6 win.c:345:created owner 003B0206 and popup 005901D6 /win: 373 tests executed, 0 marked as todo, 0 failures. /wsprintf: 4 tests executed, 0 marked as todo, 0 failures. wininet_test.exe /generated: 252 tests executed, 0 marked as todo, 0 failures. http.c:90:Starting with flags 0x10000000 http.c:92:InternetOpenA <-- http.c:95:InternetOpenA --> http.c:101:InternetConnectA <-- http.c:78:Callback 00CC0004 0xdeadbeef INTERNET_STATUS_HANDLE_CREATED(60) 0012E9A8 4 http.c:104:InternetConnectA --> http.c:108:HttpOpenRequestA <-- http.c:78:Callback 00CC0008 0xdeadbead INTERNET_STATUS_HANDLE_CREATED(60) 0012EC20 4 http.c:122:HttpOpenRequestA --> http.c:126:HttpSendRequestA --> http.c:133:HttpSendRequestA <-- http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESOLVING_NAME(10) 00F2FB04 21 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_NAME_RESOLVED(11) 00F2FAF4 14 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTING_TO_SERVER(20) 00F2FB9C 14 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTED_TO_SERVER(21) 00F2FD44 14 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_SENDING_REQUEST(30) 00000000 0 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_SENT(31) 00F2FCE0 4 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RECEIVING_RESPONSE(40) 00000000 0 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESPONSE_RECEIVED(41) 00F2FD64 4 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_COMPLETE(100) 00F2FDAC 8 http.c:140:Option 0x17 -> 1 12 http.c:144:Option 0x22 -> 1 http://www.winehq.com/about/ http.c:149:Option 0x16 -> 1 HTTP/1.0 200 OK Connection: close Date: Fri, 07 Mar 2003 09:03:55 GMT Server: Apache/1.3.27 (Unix) (Red-Hat/Linux) mod_ssl/2.8.12 OpenSSL/0.9.6 PHP/4.1.2 X-Powered-By: PHP/4.1.2 Content-Type: text/html http.c:154:Option 0x22 -> 1 http://www.winehq.com/about/ http.c:158:Option 0x5 -> 0 http://www.winehq.com/about/ (12150) http.c:163:Option 0x1 -> 1 text/html http.c:166:Entery Query loop http.c:183:ReadFile -> 1 813 http.c:183:ReadFile -> 1 424 http.c:172: Test failed: InternetQueryDataAvailable failed http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_COMPLETE(100) 00F2FDAC 8 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CLOSING_CONNECTION(50) 00000000 0 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTION_CLOSED(51) 00000000 0 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_HANDLE_CLOSING(70) 00F2FD6C 4 http.c:78:Callback 00CC0008 0xdeadbeef INTERNET_STATUS_HANDLE_CLOSING(70) 00F2FD28 4 http.c:90:Starting with flags 0x0 http.c:92:InternetOpenA <-- http.c:95:InternetOpenA --> http.c:101:InternetConnectA <-- http.c:78:Callback 00CC0004 0xdeadbeef INTERNET_STATUS_HANDLE_CREATED(60) 0012E9A8 4 http.c:104:InternetConnectA --> http.c:108:HttpOpenRequestA <-- http.c:78:Callback 00CC0008 0xdeadbead INTERNET_STATUS_HANDLE_CREATED(60) 0012EC20 4 http.c:122:HttpOpenRequestA --> http.c:126:HttpSendRequestA --> http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTING_TO_SERVER(20) 0012EA5C 14 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTED_TO_SERVER(21) 0012EA38 14 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_SENDING_REQUEST(30) 00000000 0 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_REQUEST_SENT(31) 0012EB48 4 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RECEIVING_RESPONSE(40) 00000000 0 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_RESPONSE_RECEIVED(41) 0012EB34 4 http.c:133:HttpSendRequestA <-- http.c:140:Option 0x17 -> 1 12 http.c:144:Option 0x22 -> 1 http://www.winehq.com/about/ http.c:149:Option 0x16 -> 1 HTTP/1.0 200 OK Connection: close Date: Fri, 07 Mar 2003 09:03:55 GMT Server: Apache/1.3.27 (Unix) (Red-Hat/Linux) mod_ssl/2.8.12 OpenSSL/0.9.6 PHP/4.1.2 X-Powered-By: PHP/4.1.2 Content-Type: text/html http.c:154:Option 0x22 -> 1 http://www.winehq.com/about/ http.c:158:Option 0x5 -> 0 http://www.winehq.com/about/ (12150) http.c:163:Option 0x1 -> 1 text/html http.c:166:Entery Query loop http.c:183:ReadFile -> 1 813 http.c:183:ReadFile -> 1 436 http.c:183:ReadFile -> 1 8192 http.c:183:ReadFile -> 1 568 http.c:183:ReadFile -> 1 2120 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CLOSING_CONNECTION(50) 00000000 0 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_CONNECTION_CLOSED(51) 00000000 0 http.c:78:Callback 00CC000C 0xdeadbead INTERNET_STATUS_HANDLE_CLOSING(70) 0012EC54 4 http.c:78:Callback 00CC0008 0xdeadbeef INTERNET_STATUS_HANDLE_CLOSING(70) 0012EC54 4 /http: 23 tests executed, 0 marked as todo, 1 failure. winmm_test.exe wave.c:193:found 1 WaveOut devices wave.c:217: 0: "C-Media Wave Device" 5.10 (1:100): channels=65535 formats=bffff support=002c wave.c:231:Testing invalid 2MHz format /wave: 233 tests executed, 0 marked as todo, 0 failures. ws2_32_test.exe sock.c:694: **** STARTING TEST 0 **** sock.c:332:simple_server (758) starting sock.c:391:simple_client (68c): starting sock.c:341:simple_server (758) ready sock.c:346:simple_server (758): waiting for client sock.c:394:simple_client (68c): server ready sock.c:391:simple_client (4b0): starting sock.c:394:simple_client (4b0): server ready sock.c:406:simple_client (68c) connected sock.c:406:simple_client (4b0) connected sock.c:346:simple_server (758): waiting for client sock.c:427:simple_client (4b0) exiting sock.c:374:simple_server (758) exiting sock.c:427:simple_client (68c) exiting sock.c:696: **** TEST 0 COMPLETE **** sock.c:694: **** STARTING TEST 1 **** sock.c:332:simple_server (380) starting sock.c:341:simple_server (380) ready sock.c:346:simple_server (380): waiting for client sock.c:445:event_client (224): starting sock.c:445:event_client (434): starting sock.c:447:event_client (224): server ready sock.c:467:event_client (224) connected sock.c:505:event_client (224): all data sent - shutdown sock.c:346:simple_server (380): waiting for client sock.c:526:event_client (224): all data received sock.c:538:event_client (224): close event sock.c:556:event_client (224) exiting sock.c:447:event_client (434): server ready sock.c:467:event_client (434) connected sock.c:505:event_client (434): all data sent - shutdown sock.c:374:simple_server (380) exiting sock.c:526:event_client (434): all data received sock.c:538:event_client (434): close event sock.c:556:event_client (434) exiting sock.c:696: **** TEST 1 COMPLETE **** /sock: 1096 tests executed, 0 marked as todo, 0 failures. -- Mathew McBride matt(a)mcbridematt.dhs.org http://mcbridematt.dhs.org

1 0

Windows Longhorn 3683 Complaince status
by Mathew McBride 07 Mar '03

07 Mar '03

1 0

Re: Janitorial dlls/advapi32/registry.c W->A cleanup
by Dmitry Timoshkov 07 Mar '03

07 Mar '03

"Tony Lambregts" <tony_lambregts(a)telusplanet.net> wrote: > -LONG WINAPI RegSaveKeyW( HKEY hkey, LPCWSTR file, LPSECURITY_ATTRIBUTES sa ) > +LONG WINAPI RegSaveKeyA( HKEY hkey, LPCSTR file, LPSECURITY_ATTRIBUTES sa ) > { > - LPSTR fileA = HEAP_strdupWtoA( GetProcessHeap(), 0, file ); > - DWORD ret = RegSaveKeyA( hkey, fileA, sa ); > - if (fileA) HeapFree( GetProcessHeap(), 0, fileA ); > + UNICODE_STRING fileW; > + LONG ret; > + > + RtlCreateUnicodeStringFromAsciiz( &fileW, file ); > + ret = RegSaveKeyW( hkey, fileW.Buffer, sa ); > + RtlFreeUnicodeString( &fileW ); > return ret; In the vast majority of cases where an API takes file name, ANSI version of the API is supposed to have a limitation of MAX_PATH characters for the name. Thus, there is no need to waste CPU cycles by allocating/deallocating memory, but instead having an automatic buffer on the stack will be quite enough. See files/drive.c,GetCurrentDirectoryA for a sample. All other APIs which get a file name as a parameter should be rewritten that way too. Probably that's the task for yet another janitorial project... All the said above doesn't mean that your patch can't applied as is, that just means that there is a better way of doing this task. -- Dmitry.

5 8

compile fails?
by Gregory M. Turner 06 Mar '03

06 Mar '03

Am I the only one with this? gcc -c -I. -I. -I../include -I../include -g -O2 -Wall -mpreferred-stack-boundary=2 -gstabs+ -Wpointer-arith -march=athlon-xp \ -pipe -mmmx -m3dnow -msse -fPIC -D__WINESRC__ -DDLLDIR="\"/usr/local/lib/wine\"" -D_REENTRANT -o ldt.o ldt.c ldt.c: In function `set_thread_area': ldt.c:97: `__NR_set_thread_area' undeclared (first use in this function) ldt.c:97: (Each undeclared identifier is reported only once ldt.c:97: for each function it appears in.) make[1]: *** [ldt.o] Error 1 make[1]: Leaving directory `/var/src/wine/library' make: *** [library] Error 2 The code there looks a bit obscure.... :( -- gmt

1 0

Re: PATCH: Inserting an item in a listview sometimes generates incorrect messages
by Dimitrie O. Paun 06 Mar '03

06 Mar '03

On March 6, 2003 06:04 am, Adam Gundy wrote: [wine-devel Cc:ed to keep people in the loop] > Is a listview guaranteed to be single threaded? I assume it is because it > is all message driven - so some flag in the LISTVIEW_INFO structure could > be set. I'd say that is even more opaque. I think this would be better. It's localized in two points (where we set it, and where we use it), and it's easier to follow. The rest of the code should be unaware of this problem, so hiding it is the right thing to do IMO. The reason it's easier to follow is that if I don't see it, I don't care about it, which is what we want, and 99% of people looking at the code will fall in this category. If you do happen to stumble upon it, you can search for the infoPtr->blah thing that we're setting to see where and how this thing is used. You can't easily search with the current flag solution. > Actually, there is the rather unhelpful comment "But we are not supposed to > modify nHotItem!* in LISTVIEW_ShiftIndices() - does 'real' Windows maintain > the focus after an insertion? Perhaps that's why they don't send the > messages - you know how they work: write the code then document its broken > behaviour after the fact ;-) Yes, I know. This is why I think it should just result from some other behavior naturally, I don't think MS went through the trouble of passing a boolean around all over the place just to not send this notification. One more reason to not uglify our interfaces, as it will just get fixed automatically when we properly support the HotItem. -- Dimi.

3 2

Re: Janitorial dlls/advapi32/registry.c W->A cleanup
by Rolf Kalbermatter 06 Mar '03

06 Mar '03

> Dmitry Timoshkov wrote: > >> "Tony Lambregts" <tony_lambregts(a)telusplanet.net> wrote: >> Yeah I actually had it that way at one point due to my familairity >> with drive.c and well... I ran into some compiler errors (in >> RegSaveKeyW) that ended up making the problem worse. Perhaps it was >> something I simple I missed. I can take another look at it if it will >> save some CPU cycles. > >when I change the code to the following > LONG WINAPI RegSaveKeyA( HKEY hkey, LPCSTR file, LPSECURITY_ATTRIBUTES sa ) { WCHAR fileW[MAX_PATH]; - LONG ret, len; + LONG ret; - len = WideCharToMultiByte(CP_ACP, 0, fileW, -1, file, 0, NULL, NULL); - WideCharToMultiByte(CP_ACP, 0, fileW, -1, file, len, NULL, NULL); + MultiByteToWideChar(CP_ACP, 0, file, -1, fileW, MAX_PATH); - ret = RegSaveKeyW( hkey, fileW.Buffer, sa ); + ret = RegSaveKeyW( hkey, fileW, sa ); return ret; } >I get the following warning > >warning: passing arg 5 of `WideCharToMultiByte' discards qualifiers from >pointer target type Well you should get a lot more warnings and even errors IMO. Look above as to what I think the code should really look like. Rolf Kalbermatter

1 0

Re: New conformance test for user32.dll
by Ferenc Wagner 06 Mar '03

06 Mar '03

Tony Lambregts <tony_lambregts(a)telusplanet.net> writes: > The patch is still in the wrong format. New files need to > be diff'ed against /dev/null. Thanks for the clarification! Winehq says new files can be included as separate attachments. Well, this is exactly one kind of problems/comments I expected for first contribution. Also, I found no mention of license info on the web page. I Cc-ed the devel list so that someone can fix the docs. Thanks for all: Feri.

6 6

Re: (2nd) Janitorial dlls/advapi32/registry.c W->A cleanup
by Vincent Béron 06 Mar '03

06 Mar '03

Tony Lambregts a écrit: > With Dmitry's suggested change and Vincent's advice (doh!) Second advice: don't forget the patch :)

1 0

Winelib article in this month's C/C++ User's Journal
by Matthew Bloch 06 Mar '03

06 Mar '03

http://www.cuj.com/current/feature.html?topic=current An immodest plug for my introductory Winelib article that the CUJ editor Joe Casad was soliciting through thist list back in December. It's now in the print journal and on their web site at the (temporary, by the looks of things) link above. Thanks to the people who offered criticism before publication; hopefully in the three months since I wrote it the information isn't too out of date! cheers, -- Matthew Bloch Bytemark Hosting tel. +44 (0) 8707 455026 http://www.bytemark-hosting.co.uk/ Dedicated Linux hosts from 15ukp ($26) per month

4 3

← Newer
1
...
20
21
22
23
24
25
26
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel March 2003