wine-devel December 2004

wine-devel@winehq.org

127 participants
276 discussions

<<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive
by Robert van Herk 16 Dec '04

16 Dec '04

Hi, I had some problems with my mail server, so I send in this patch again. If the previous one did arrive, please ignore this e-mail. ------------------------------------------------------------------------ Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed just for picking a Windows folder, was split up. It was to be found in brsfolder.c, but I split this in: brsfolder.c brsfolder.h brsfolder_windows.c brsfolder_windows.h brsfolder_unix.c brsfolder_unix.h unixTools.c unixTools.h, Otherwise I found the code to be incomprehendible. Furthermore, winecfg now uses the wine_shell_browse_for_UNIX_directoryA to let the user pick a UNIX directory as root for his virtual drive mappings. Regards, Robert van Herk

8 15

Re: Stubs in PE build
by Jon Griffiths 16 Dec '04

16 Dec '04

Hi, I had a patch which enabled stub generation for building native dlls last year (http://www.winehq.org/hypermail/wine-patches/2003/07/0176.html), that part was not accepted for the same reasons that are being mentioned in this thread. I would like to point out again that the VC linker will not generate a correct dll unless the ordinal stubs are present. Other native linkers may have the same problem. It seems very silly to me that we can't use M$'s own compiler/linker to build valid dlls (especially since these tools can be downloaded for free these days). M$ defined the dll format we are using, after all. If this is intentional, perhaps we should document it somewhere? Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

3 6

Re: Definition of IMessageFilter in objidl.h
by Dmitry Timoshkov 16 Dec '04

16 Dec '04

"Serge S. Spiridonoff" <sss(a)corbina.net> wrote: > Well, I've just noticed the following record in the ChangeLog... > > * include/objidl.h, include/objidl.idl: > Jake Hamby <jhamby(a)anobject.com> > IMessageFilter::HandleInComingCall() should be HandleIncomingCall(). > > Also, http://cvs.winehq.org/patch.py?id=12310 > > So I'm a bit confused now!? Since I'm new to Wine I'd like someone more > experienced to judge this collision. Apparently the patch above is wrong since microsoft headers have it in different case. The patch should be reverted. If you could send a patch which just reverts the above change that would be great. -- Dmitry.

1 0

dlls/gdi/tests/metafile.c warning about test_mf_PatternBrush
by Gerald Pfeifer 16 Dec '04

16 Dec '04

The following patch to dlls/gdi/tests/metafile.c revision 1.3 date: 2004/12/09 11:37:59; author: julliard; state: Exp; lines: +236 -0 Walt Ogburn <reuben(a)ugcs.caltech.edu> Added some tests for win-format metafiles. introduces the following warning: metafile.c:381: warning: `test_mf_PatternBrush' defined but not used Should we put #ifdefs around the definition, or enable the following code in the main test function? /* Crashes under wine: */ /* test_mf_PatternBrush(); */ Another option would be not to make this function static. Gerald

5 5

Re: Definition of IMessageFilter in objidl.h
by Dmitry Timoshkov 16 Dec '04

16 Dec '04

"Serge S. Spiridonoff" <sss(a)corbina.net> wrote: > IMessageFilter::HandleInComingCall is defined as HandleIncomingCall in > include/wine/windows/objidl.h (.idl) > Note the capital 'C' in 'InComing' in MS headers. > Is it a misprint? Yes. Please send a patch. -- Dmitry.

2 1

Definition of IMessageFilter in objidl.h
by Serge S. Spiridonoff 15 Dec '04

15 Dec '04

Hi, IMessageFilter::HandleInComingCall is defined as HandleIncomingCall in include/wine/windows/objidl.h (.idl) Note the capital 'C' in 'InComing' in MS headers. Is it a misprint? Thanks

1 0

Re: Should we get rid of the wine-license list?
by Ivan Leo Puoti 15 Dec '04

15 Dec '04

> OK, I'll take it down. Shall I remove the archives as well? Or simply > leave them for historical type purposes? IMHO we should keep the archives. Ivan. ____________________________________________________________ Regala e regalati Libero ADSL: 3 mesi gratis, navighi veloce e scarichi a 1.2 Mega. Abbonati subito senza costi di attivazione su http://www.libero.it

1 0

State of the Msi
by Aric Stewart 15 Dec '04

15 Dec '04

Hi all, Long time no post :) I just wanted to give an update that Mike M. and I have done alot of msi work over the first few weeks of December which caused a few significant changes to particularly action.c where we eliminated many of the static buffers for file paths and replaced them with dynamic buffers. Vitaly Lipatov's patchs reminded me that i should probably give you all a heads up about that. We where going to break them down and start submitting them but then Mike went off and got married and is on his Honeymoon. So when he gets back we are going to either break the changes down into smaller patches or try to get Alexandre to approve a big one. I will start trying to get some of the smaller ones broken down and submitted in the meantime. Vitaly Lipatov's patchs do not directly conflict with anything so we are just fine there. I will work them into our tree so that i can be sure they are not lost. But if anyone else is also doing msi work you may want to check in here so that we can make sure it all fits together ok. Thanks, -aric

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by William Lahti 15 Dec '04

15 Dec '04

Upon further review, the patch works. Stupid me. William

1 0

Re: Include file cleanup : dce.h
by Alexandre Julliard 15 Dec '04

15 Dec '04

Rémi Assailly <remi.assailly(a)free.fr> writes: > Changelog: > * get rid of dce.h > --- dlls/x11drv/winpos.c 2004-12-09 19:10:35.000000000 +0100 > +++ dlls/x11drv/winpos.c 2004-12-11 19:46:03.000000000 +0100 > @@ -40,7 +40,6 @@ > #include "x11drv.h" > #include "win.h" > #include "winpos.h" > -#include "dce.h" > #include "cursoricon.h" > #include "nonclient.h" > > @@ -49,6 +48,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(x11drv); > > +extern BOOL DCE_InvalidateDCE( HWND, const RECT* ); The goal of the header files cleanup is not to mechanically remove the #includes by duplicating the definitions, if we wanted to do that it would have been done long ago. The real goal is to get rid of the inter-dll dependencies, the global headers are really just a symptom of the problem. -- Alexandre Julliard julliard(a)winehq.org

2 6

← Newer
1
...
10
11
12
13
14
15
16
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel December 2004