April 2004 - wine-devel

Re: Remove debugmsg from guides
by Ivan Leo Murray-Smith 26 Apr '04

26 Apr '04

> Please don't do that, we've been over this a thousand times, > let's not rehash it. Do either or, otherwise you end up > confusing Alexandre's script, etc. Inlining is prefered > for a lot of reasons, so if you're using a decent mail client > (and you seem to be), just inline it and don't look back :) I'm not using an email client, my ESP only allows that if I connect via their dial-up service. That's why I can't have text/plain attachments. Ivan.

1 0

Re: Remove debugmsg from guides
by Dimitrie O. Paun 26 Apr '04

26 Apr '04

On Mon, 26 Apr 2004, Ivan Leo Murray-Smith wrote: > attaching as text/plain can't be done for various reasons, so I'll both attach > and inline. Please don't do that, we've been over this a thousand times, let's not rehash it. Do either or, otherwise you end up confusing Alexandre's script, etc. Inlining is prefered for a lot of reasons, so if you're using a decent mail client (and you seem to be), just inline it and don't look back :) -- Dimi.

1 0

Re: RFH: RPC patch
by Ivan Leo Murray-Smith 26 Apr '04

26 Apr '04

Running server and client with wine CVS current returns Hello Implicit RPC World! but I can't test with your patch because it doesn't cleanly apply against the current CVS code. Ivan.

1 0

service.cgi: script generation
by Dimitrie O. Paun 26 Apr '04

26 Apr '04

Currenly we send a script to run and execute all published versions that we have. This is currently problematic, because an error in one causes the abort the entire script. Moreover, releases may no arrive at the server at the same time, and if we're going to receive the poll event in between them, we'll miss some of them. What we need to do is to ask the client to execute one thing at a time. Problem is that we need to keep track of what the client did execute already. Here's a way to do it without storing state on the server side, which is problematic. We need to introduce three new cookies: build_id: the current build ID that we execute. It's going to be something like '200405031000' current: the name of the test that was just executed history: a comma separated list of filenames that where already executed by the client for this current build. It's going to look like so: 'wine-200405031000-paul-mingw.zip,wine-200405031000-kevin-mingw.zip' The algorithm is simple: if $build_id != $current_build_id $build_id = $current_build_id $history = "" else $history = $history . "," . $current $current = pick_next_test($history) # send script to run $current, and to set the values of the # three cookies to the values in our variables where: pick_next_test picks the next test to run from the pool of tests avaiable for our current build, so that it doesn't appear in $history Comments? -- Dimi.

1 0

Re: Font selection - please review
by Shachar Shemesh 26 Apr '04

26 Apr '04

Hi Dirk, First of all, thank you for the reference. Regarding the missing flag to TranslateCharsetInfo - My VisualStudio 6 MSDN DVD (Latest that came up for that version - dated October 2001) does not have this flag mentioned. This means either that the flag was not present at that time, or that it was present but they forgot to mention it (has happened to me before). The latest MSDN (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/intl/unico…) does mention it, and claims it's available on Windows 2000 (like you said). I guess this is anyone's guess what this means as far as when you can use it. Fortunetly for Wine, we don't care when it was introduced. If Wine has it, we can use it. At least for code written by us, that rule is fine. So, thank you very much for the good advice. Are you a wine user that needs this flag, or did you just happen to see my email when you were investigating a Win32 problem? Shachar Dirk Luetjens wrote: > Hello Shachar Shemesh, > > sorry for the lost context. Your mail I replyed to, is available at > > http://www.winehq.com/hypermail/wine-patches/2002/11/0221.html > > I know, that the wine project is totally unrelated to any windows dll. > I thought it would be better to mention, that this additonal flag for > TranslateCharsetInfo is not available in a specific windows version, > since the wine project tries to implement the WIN32 interface, and it > should behave as close as possible to the original one. Judging from > the code in > > http://source.winehq.org/source/objects/font.c#L1849 > > this additional flag is not yet implemented in wine. I can not tell > you when it was introduced into WIN32 itself. The MSDN says something > about WIN2000, but it isn't available on my WIN2k installation. > > Dirk > > > Shachar Shemesh wrote: > >> Hi Dirk, >> >> Judging from the email address you used to send me this email, we are >> talking about a fairly old post. Can you please direct me to the some >> context regarding what was my post exactly? A link with the post in >> question would be very helpful. >> >> Also, I hope you do realize that my post was on a Wine mailing list, >> which means that the functions there are totally disjointed from any >> particular Microsoft version or DLL. >> >> Many thanks, >> Shachar >> >> Dirk Luetjens wrote: >> >>> Hi Shachar Shemesh, >>> >>> I came across your post while researching a problem I had during >>> application development under windows. >>> >>> While digging in the MSDN I found another function that deals with >>> this problem: TranslateCharsetInfo >>> >>> --- >>> TranslateCharsetInfo function translates based on the specified >>> character set, code page, or font signature value, setting all >>> members of the destination structure to appropriate values. >>> --- >>> >>> and for the flag parameter: >>> >>> --- >>> TCI_SRCLOCALE Windows 2000: Source (that is, lpSrc) is the LCID or >>> LANGID of the keyboard layout. If it is a LANGID, the value is in >>> the low word. >>> --- >>> >>> The destination of the translation is a CHARSETINFO structure, where >>> one entry is the charset. >>> >>> I had problems using this parameter, since it isn't implemented in >>> the gdi version I use (VS6, gdi32.dll 5.00.2195.6898). I can only >>> find the definition in the newer .NET studio headers. But perhaps >>> this is a possible inclusion point for your function. >>> >>> Best regards >>> Dirk Luetjens >>> >> >> > > -- Shachar Shemesh Lingnu Open Source Consulting http://www.lingnu.com/

1 0

Re: winmm wave test
by Robert Reif 26 Apr '04

26 Apr '04

Francois Gouget wrote: > Some Windows sound drivers allow wild frequencies such as the 2MHz > one. > Is this a windows driver bug? Is the test really valid and it's just finding a real bug in the windows driver for that specific sound card? I know it makes the test fail on bad windows drivers but is that bad?

2 4

email add
by kosta 26 Apr '04

26 Apr '04

1 0

Re: Add some functions to msvcrt.dll
by Dmitry Timoshkov 26 Apr '04

26 Apr '04

"kata 198" <kata198(a)hotmail.com> wrote: > Changelog: > Add some functions to msvcrt.dll If you could make your patch behave according to current locale that would be really nice. Otherwise it's not acceptable. Also, please make sure that your formatting style is at least consistent, and even better conforms to the formatting style of the file you are editing. -- Dmitry.

1 0

RFH: MDI Window menu fix
by Krzysztof Foltman 25 Apr '04

25 Apr '04

I've just finished fixing the behaviour of Window menu in MDI applications. However, I'm not sure if it won't cause some other MDI applications to work incorrectly. So, if you have some time and MDI apps to play with (regardless if they worked correctly before or not), check this out and tell me if I've fixed or broken the Window menu. http://www.winehq.org/hypermail/wine-patches/2004/04/0414.html Krzysztof

1 0

Re: abnt2 keyboard patch
by Mauro Carvalho Chehab 25 Apr '04

25 Apr '04

Rafael, With your patch, the '\' key on the main keyboard will stop to work on the ABNT2 Keyboard, at least on the ABNT2 keyboards I've tested (some low valued keyboards and also Compaq keyboard). On ABNT2 keyboards, before the 'z' key there is the '\' key and the layout has to reflect that. That was the situation before 200303xx version. That changes was required in order to support that key. Had you tested it? If it works on your keyboard, may be you has some ABNT2 variant. I think it would be better to find another solution for the numeric keyboard that doesn't break the main keyboard. Mauro Chehab > Date: Fri, 16 Apr 2004 10:52:01 -0300 > From: Rafael Ávila de Espíndola <rafael.espindola(a)ic.unicamp.br> > To: wine-devel(a)winehq.org > Subject: Re: abnt2 keyboard patch > > > That's why I said that it's an X11 bug and we can do nothing about it. > > > > Please resubmit the patch without that part. > Attached. I will contact xfree and try to fix the rest of the problem. > > Thanks. > > > Dmitry. > Rafael >

2 1

RFH: RPC patch
by Filip Navara 25 Apr '04

25 Apr '04

Hi, for about week and half I was working on a patch that makes Wine RPC runtime communicating with the Windows one. Now I'm almost done with the work and I need help from someone who can test the patch under Wine. (I was doing all my testing under regular Windows.) If someone will be willing to help me testing it, the patch is at www.volny.cz/xnavara/rpc/ along with a test programs. Regards, Filip

1 0

Wine bug with MFC/C++?
by greensh＠knology.net 25 Apr '04

25 Apr '04

It appears that Wine cannot use tmpfs... so far my testing only works using swap :o( which I do have enabled at home and it crashes. At work I have a 500MB swap space and the same exact program does not crash there. It's not convenient for me to run swap at home, so does anyone know a fix for this? The code seems to require approx 500MB free memory. Since I only have 500MB RAM, I setup tmpfs on /tmp. But wine doesn't seem to use any of it. Shaun

1 0

winetest.exe output from Windows 95
by Jakob Eriksson 25 Apr '04

25 Apr '04

By killing processes left and right, I managed to get a 50 - megabyte log. Maybe in the future we should link in bzip2 in winetest.exe to compress logs before submitting? regards, Jakob

2 2

Re: Remove debugmsg from guides
by Dimitrie O. Paun 25 Apr '04

25 Apr '04

On Sun, 25 Apr 2004, Ivan Leo Murray-Smith wrote: > Please let me know if something isn't OK. A few points: -- I find the change confusing. There's no WINEDEBUG channel. I think most should just change from debugmsg -> debug -- Please provide only one .diff file. Multiple diffs are not necessary, and makes reviewing and applying so much more difficult. -- It would be nice if the diff would be either inlined or attached as text/plain. Inlining is prefered, this way people can quote easily when replying. -- Dimi.

1 0

Re: Remove debugmsg from guides
by Eric Pouech 25 Apr '04

25 Apr '04

Ivan Leo Murray-Smith a écrit : > With this all unneeded references to debugmsg should be gone. Just one note, in > debugger.sgml I found this > [MACHINE\\Software\\Microsoft\\Windows NT\\CurrentVersion\\AeDebug] 957636538 > "Auto"=dword:00000001 > "Debugger"="winedbg --debugmsg -all %ld %ld" > As I don't know what it's meant to be now, I've left it, if it should change, > let me know. > Please let me know if something isn't OK. > > Ivan. this should be changed into "Debugger"="winedbg %ld %ld" (the issue is that the debugger will be inheriting the parent's debug channel, while this setting was turning off all debugging channels from debugger itself). A+

1 0

Re: PATCH: silence strict aliasing in dlls/opengl32
by Lionel Ulmer 25 Apr '04

25 Apr '04

> Not sure how to regenerate the opemngl_ext.c file. You need the extension registry CVS (you can find it here http://oss.sgi.com/projects/ogl-sample/ - no idea where the exact CVS informations are). After, do 'make_opengl PATH_TO_EXTENSION_DIR 1.2' where PATH_TO_EXTENSION_DIR points to the '<OGL-SAMPLE-ROOT>/main/doc/registry/specs/' directory). Anyway, if it can wait, it will be updated the next time I generate the file. Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

dlls/d3d8/shader.c
by Marcus Meissner 25 Apr '04

25 Apr '04

Hi, I was just fixing this code, but I wonder why floorf(s0->w) is overwritten right next with tmp_f = powf(2.0f, s0->w); What is the right version? Ciao, Marcus void vshader_expp(D3DSHADERVECTOR* d, D3DSHADERVECTOR* s0) { float tmp_f = floorf(s0->w); DWORD tmp_d = 0; tmp_f = powf(2.0f, s0->w); tmp_d = *((DWORD*) &tmp_f) & 0xFFFFFF00;

2 1

Bad string handling in PRINTDLG_UpdatePrintDlg?
by Francois Gouget 24 Apr '04

24 Apr '04

In PRINTDLG_UpdatePrintDlgA() in dlls/commdlg/printdlg.c we do: ... LPPRINTER_INFO_2A pi = PrintStructures->lpPrinterInfo; ... pi->pPortName = "FILE:"; And in PRINTDLG_UpdatePrintDlgW() we do: ... LPPRINTER_INFO_2W pi = PrintStructures->lpPrinterInfo; ... static WCHAR file[] = {'F','I','L','E',':',0}; pi->pPortName = file; ... Now in gcc all string literals are read-only, even if you declare them as char* foo="bar", *foo='\0' will cause a segfault. So in the Ansi version we point pPortName to a read-only string. But if the application gets hold of that pointer we have no garantee that it won't expect to be able to modify that string: pPortName is an LPSTR. (this is a case where -Wwrite-strings will complain) And in the Unicode case we point pPortName to a static writable buffer. But in this case if the application writes in our buffer its contents is going to be messed up forever. However I don't know this code at all. So I'm asking, shoudln't we make a copy of these strings? Which also raises the ugly issue of later freeing the corresponding memory buffer... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux

1 0

Idea to fight spam
by Ivan Leo Murray-Smith 24 Apr '04

24 Apr '04

What about having a link to this page somewhere on winehq? Maybe on the mailing lists page? http://www.hostedscripts.com/scripts/antispam.html Ivan.

2 1

Re: Docu: mention piping for debugmsgs
by Ferenc Wagner 24 Apr '04

24 Apr '04

Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> writes: > Make people know how to reduce log size, using pipes. Hi Andi! Two notes: 1. The --debugmsg option is deprecated, people should use the WINEDEBUG environmental variable instead. 2. Won't the pipe block until you read from it, then give you all the data ever written? -- Feri.

1 0

winetest: build & publishing
by Dimitrie O. Paun 24 Apr '04

24 Apr '04

Hi folks, I've checked the build this morning on SF, and it looks beautiful! So let's review the possible problems still outstanding: 1. Build Info Feri want to move that in the resources, with good reason. This will probably affect you very little, but needs to be done. We can still keep it in the .zip file (it is tiny) as it's a lot easier accessible for others. However, if we do that, the file will need to use DOS line ends, as this file will probably be viewed by folks on Windows boxes. Anyway, from your point of view it will probably mean a 'unix2dos' and a 'cp' before the build. 2. Uploading to SF This works nice now, but I'm afraid it may not when we have more than one person doing it. Namely, a release needs to be created, will that not fail if it already exists? Can we check that? If that's a problem, how are we going to deal with it? Kevin, can you please try to see if what happens if you upload two files (with differents sfutils invocations) into the same release? 3. Downloading from SF I just realized there is a time delay for the uploads to be propagated to the mirrors. What URL are we going to use for downloading? How long are we going to allow for the propagation to happen? Anyone has experience with this? 4. Release lifetime It would be nice to have the "WineTest Files" package visible on SF. I have made it so for testing purposes now. However, it will become ugly soon, because we don't hide the old releases. We can hide the entire package, and that would solve the ugliness problem, but it would be much nicer to have an automatic way of hiding old releases, and having just the latest releases visible. Can we maybe modify the sfutils to do this for us? We are very close on this front. I'm very happy with the state of things right now, I hope we can resolve these in a few days. -- Dimi.

5 6

Re: FILEDLG_MapOfnStructA bug?
by Dmitry Timoshkov 24 Apr '04

24 Apr '04

"Francois Gouget" <fgouget(a)free.fr> wrote: > -static char defaultopen[]="Open File"; > -static char defaultsave[]="Save as"; > > /*********************************************************************** > * FileDlg_Init [internal] > @@ -970,9 +968,13 @@ > if (ofnA->lpstrTitle) > str = ofnA->lpstrTitle; > else > + { > /* Allocates default title (FIXME : get it from resource) */ > + static const char* defaultopen="Open File"; > + static const char* defaultsave="Save as"; Don't you really want to leave it as a static const array of characters as before and not a static const pointer? Same for your next patch. -- Dmitry.

1 0

Re: Fix for test of CreateFileMapping in dlls/kernel/tests/file.c
by Stefan Leichter 24 Apr '04

24 Apr '04

Am Samstag, 24. April 2004 00:54 schrieb Jakob Eriksson: > From a run of winetest 20040423 on Windows XP: > > file.c:1075: Test failed: mapping should succeed > file.c:1077: Test failed: can't close mapping handle > file: 487696 tests executed, 0 marked as todo, 2 failures. > > > > Seems CreateFileMapping has some seriously strange behaviour. > I tested some more how XP behaves and produced a patch based on that. > > > regards, > Jakob Hello Jakob, + *handle = CreateFile(filename, GENERIC_READ|GENERIC_WRITE, 0, 0, + CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); + if (handle != INVALID_HANDLE_VALUE) { do you have to test the pointer not the value ? Bye Stefan

2 1

Window management protocol extensions
by Mike Hearn 24 Apr '04

24 Apr '04

The latest WM problems caused by Metacity preventing windows from being moved offscreen prompted to raise the issue of having a Wine specific extension to the NETWM (EWMH) protocol into which we can easily add whatever semantics we need to map win32 windowing to X windowing more easily. The idea would be that we have a new property/set of properties we can mark windows with, _NET_WM_WINDOWS_EMULATION for instance, and standards compliant window managers will take note and not do things that break us. Short of actually doing all our own window management, this is probably the best way to fix the obscure bugs caused by different interpretations WMs have of what various hints mean. The current NETWM border hints are semantic not presentational, so we cannot rely on particular intepretations. The MWM hints are even worse - they are apparently undocumented, and most modern WM authors consider them deprecated. Thanks to their undocumentedness, WMs vary in their interpretation of these too: http://bugs.kde.org/show_bug.cgi?id=73294 So, I'd like to start gathering ideas on what sort of things we'd like to have in the NETWM spec, seeing as how many WMs conform to it these days. First up is a way to ensure the WM doesn't attempt to keep the window onscreen of course :) Other things we probably want are related to border styles, an absolutely crystal-clear no-wriggling-possible equivalent to PPosition as apparently the wording of the ICCCM allows WM authors to ignore this if they want. We might also want to look at where we use unmanaged windows and see if we can replace them with the use of managed windows+hints. We can probably hack around the lack of these things for now, but being able to use these hints where possible will probably keep a lot of us from going grey-haired early :) thanks -mike

2 2

Re: Fix for test of CreateFileMapping in dlls/kernel/tests/file.c
by Jakob Eriksson 24 Apr '04

24 Apr '04

Jakob Eriksson wrote: > > From a run of winetest 20040423 on Windows XP: > > file.c:1075: Test failed: mapping should succeed > file.c:1077: Test failed: can't close mapping handle > file: 487696 tests executed, 0 marked as todo, 2 failures. > > > > Seems CreateFileMapping has some seriously strange behaviour. > I tested some more how XP behaves and produced a patch based on that. But I just installed Windows 95 and it fails very much under that platform: will have to think more about that... file.c:58: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:105: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:180: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:204: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:319: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:354: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:394: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:441: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:683: Test failed: DeleteFileA("nul") returned ret=0 error=5 file.c:893: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:982: Test failed: couldn't create file "testfile.xxx" (err=32) file.c:1077: Test failed: Map is already created, for some reason we should be able to remap now... file.c:1081: Test failed: can't close mapping handle file.c:1086: Test failed: We should still be able to map! file.c:1087: Test failed: can't close mapping handle file.c:1088: Test failed: can't close file handle file.c:1097: Test failed: not ERROR_FILE_INVALID file.c:1108: Test failed: mapping should fail file.c:1110: Test failed: can't close file handle file.c:1111: Test failed: DeleteFile failed after map file.c:1118: Test failed: open testfile.xxx failed file.c:1120: Test failed: expected type disk got 0 file: 76 tests executed, 0 marked as todo, 22 failures.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2004