wine-devel January 2005

wine-devel@winehq.org

149 participants
343 discussions

ownerdraw paint recursion in listbox
by Alexander Yaworsky 04 Aug '05

04 Aug '05

Hello, recently i tried to install some application and it hung when i tried to select options. It uses listbox with ownerdraw items with checkboxes. When listbox is initially painted everything is ok. But when i try to select other item, an extra WM_PAINT is sent to listbox when application draws item. This causes infinite recursion. I've been implemented a simple workaround adding boolean to listbox structure but i have doubts. I briefly looked at some other controls and had not noticed similar countermeasures. Have somebody ever seen such behaviour? It would be interesting to test other controls sending WM_PAINT from ownerdraw handler but i'm short of time to do it soon. Should this workaround implemented in this way or something is wrong deeper with WM_PAINT handling? Thanks.

2 7

rpcrt4.dll NdrGetUserMarshalInfo() problem
by J. Grant 02 Jul '05

02 Jul '05

Hello, I am getting the attached error when running an install of Overnet v0.52. Basically it cannot find NdrGetUserMarshalInfo(), despite it being in the dll at entry point: 77d43452h, order 199. Any ideas what this problem could be? I'm expecting this to be the symptom of some wider problem. Any help appreciated. Kind regards JG p.s. Is there any way to get these mangled function names to be displayed un-mangled please? c:\opt\overnet_0_52>overnet c:\opt\overnet_0_52>err:module:import_dll No implementation for MSVCRT.dll.??_U@YAPAXI@Z imported from L"C:\\opt\\overnet_0_52\\MSVCIRT.dll", setting to 0xdeadbeef err:module:import_dll No implementation for MSVCRT.dll.??_V@YAXPAX@Z imported from L"C:\\opt\\overnet_0_52\\MSVCIRT.dll", setting to 0xdeadbeef -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

3 3

lotus notes regression
by Paul R Streitman 25 Jun '05

25 Jun '05

Patch 14725, applied 2004/12/07 11:31:53, breaks lotus notes. The symptom is a hang with the CPU at 100%, and it happens immediately if you try to click on a notes 'bookmark', or shortly after you try to do much of anything else if you try to avoid the 'bookmarks'. Sorry that it took me so long to report this, when I decided that it wasn't just a temporary instability I eventually had to iteratively compile (many) CVS snapshots to narrow down when the problem was introduced because I found it impossible to untangle the various patches that went in around that time frame. I also ran afoul of the jack problems near the end. I do not know how to narrow the problem down further. I tried running winedbg (at CVS level a couple of days ago), and that seems to be broken too -- it wanted to run things from the wine build tree? There are no unusual console messages or anything when the problem happens. Thanks, Paul z/OS core components development Internet: prs(a)us.ibm.com

7 8

Regression in comctl32 Treeview (breaks Filezilla)
by Hannu Valtonen 30 Mar '05

30 Mar '05

Hi, The following patch: ChangeSet ID: 15259 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2005/01/07 09:34:25 Modified files: dlls/comctl32 : treeview.c Log message: Crestez Leonard <cleonard(a)go.ro> Fix bug with Treeview_SelectItem reselecting the same item. Patch: http://cvs.winehq.org/patch.py?id=15259 Old revision New revision Changes Path 1.160 1.161 +0 -3 wine/dlls/comctl32/treeview.c Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The way to reproduce it is to go to the Site manager and click the "New site" button. (Doesn't work even with latest CVS) Without the check which the patch removes, if (prevSelect == newSelect) return FALSE; The dialog goes to an infinite loop. (you can exit it if you just hold the ESC-key down for long enough) I have no idea whether the rationale Leonard provided with his patch is correct, but it does break Filezilla. The binary file for Filezilla can be gotten from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?dow… and the source file from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?downl… I would appreciate it if some comctl32 messaging guru could step up and take look at this problem -- - Hannu Valtonen Hannu.Valtonen(a)hut.fi +358408030179

1 1

Support for IDvdInfo2::GetDiscID
by James Courtier-Dutton 25 Mar '05

25 Mar '05

The Windows api method uses the function call IDvdInfo2::GetDiscID http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… This returns a unique 64bit ID for a DVD. Has anyone found out what exactly it does to create this 64bit ID. It would be nice to get linux DVD players to be able to use the same method. Cheers James

2 2

Re: edit control
by Robert Shearman 09 Mar '05

09 Mar '05

Ulrich Czekalla wrote: >Running some tests under WinXP I noticed that if the edit control doesn't >have WS_EX_CLIENTEDGE it looses the WS_BORDER style and it handles painting >the border. This also has the side effect that it's non-client area goes to >zero. > >ChangeLog: > Ulrich Czekalla <ulrich(a)codeweavers.com> > Handle painting the border if WS_EX_CLIENTEDGE is not set > > This changelog doesn't really seem to match the patch. Are you sure it's right? >------------------------------------------------------------------------ > >Index: dlls/user/edit.c >=================================================================== >RCS file: /home/wine/wine/dlls/user/edit.c,v >retrieving revision 1.2 >diff -u -r1.2 edit.c >--- dlls/user/edit.c 9 Sep 2004 19:18:40 -0000 1.2 >+++ dlls/user/edit.c 15 Sep 2004 16:30:50 -0000 >@@ -4423,13 +4423,18 @@ > /* > * In Win95 look and feel, the WS_BORDER style is replaced by the > * WS_EX_CLIENTEDGE style for the edit control. This gives the edit >- * control a non client area. Not always. This coordinates in some >- * way with the window creation code in dialog.c When making >- * modifications please ensure that the code still works for edit >- * controls created directly with style 0x50800000, exStyle 0 ( >- * which should have a single pixel border) >+ * control a nonclient area so we don't need to draw the border. >+ * If WS_BORDER without WS_EX_CLIENTEDGE is specified we shouldn't have >+ * a nonclient area and we should handle painting the border ourselves. >+ * >+ * When making modifications please ensure that the code still works >+ * for edit controls created directly with style 0x50800000, exStyle 0 >+ * (which should have a single pixel border) > */ >- es->style &= ~WS_BORDER; >+ if (lpcs->dwExStyle & WS_EX_CLIENTEDGE) >+ es->style &= ~WS_BORDER; >+ else if (es->style & WS_BORDER) >+ SetWindowLongW(hwnd, GWL_STYLE, es->style & ~WS_BORDER); > > This doesn't seem right at all. The new code should be exactly the same as the old, barring any side effects from SetWindowLong (which shouldn't affect the control anyway since this the function changed is the handler for WM_NCCREATE). Rob

3 3

text edit box not painting text ( on form startup )
by Doug Herbert 09 Mar '05

09 Mar '05

( I have posted a similiar question in wine-users, don't flame me for doing so, just thinking about this some more, perhaps it may be more a developer question ) Ok, I have a windows app, that runs under wine fine - not quite. This app has a form, with many text field edit boxes on. Quite often these edit boxes already have text values, ie. they are not empty - there is a database behind the form. Anyway, the form shows on the screen, but the text within the edit fields is invisible, until you activate each edit box component. When you leave one edit box to the next, the text remains visible. It seems like the repainting is not working, on initial startup of the form. As a way to debug this database app ( I don't have the source code for it ) I wrote a real basic form app in Visual Studio, with two edit boxes, with data in each. Now this basic app shows the text values immediately on startup. So there must be something different that the database app is not doing. I then ran wine using 'wine --debugmsg +edit programname' for both app's. I see both logging 'Creating ANSI edit control, style = xxxxx' but the style reference is different between apps - I am not sure if this the cause or not. The problem app reports style = 54011104 and the basic app shows style = 50010080. Can somebody explain what this style reference means and how do I force an app to use a certain style of edit box ? What other wine class debugmsg types should I use to narrow down the source of this problem ? Is there anyway I can check to see how the database app is repainting text within the text edit components ? Regards Doug Herbert. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

3 4

Compiling the MFC using Winelib
by Dan Dennison 14 Feb '05

14 Feb '05

Building MFC for winelib has been addressed many times earlier on this list, from what I can see, since at least 2001 if not earlier. However, all together I cannot seem to find a well-written documentation of the process involved to build libmfc.so. So as a service to the Wine community I plan to document the process of building libmfc as part of my master's project. Although the MFC is not the focus of this project, porting of it is a requirement for the package to work using Winelib. Are there resources available beyond simple compilation tips to assist in the building of the MFC library under Winelib? Thanks! Dan Dennison dand(a)csun.edu

6 7

Re: wine/ windows/defwnd.c dlls/x11drv/x11drv_main ...
by Michael Stefaniuc 07 Feb '05

07 Feb '05

Hi Alexandre, this patch introduced a regression with FreeSolitaire (free download at www.freesolitaire.com). After switching virtual desktops the program windows gets blanked (see attached image). The program dosn't lockThis seems to be the only program with which i could reproduce this, all the others (winemine, notepad, winefile, Flash MX) seem to work just fine. bye michael Alexandre Julliard wrote: > ChangeSet ID: 15496 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2005/01/17 13:17:47 > > Modified files: > windows : defwnd.c > dlls/x11drv : x11drv_main.c x11drv.h winpos.c window.c > scroll.c mouse.c event.c clipboard.c > > Log message: > Avoid most references to the internals of the WND structure by passing > around an x11drv_win_data pointer instead. > > Patch: http://cvs.winehq.org/patch.py?id=15496 > > Old revision New revision Changes Path > 1.99 1.100 +0 -3 wine/windows/defwnd.c > 1.97 1.98 +0 -1 wine/dlls/x11drv/x11drv_main.c > 1.42 1.43 +17 -24 wine/dlls/x11drv/x11drv.h > 1.109 1.110 +76 -86 wine/dlls/x11drv/winpos.c > 1.87 1.88 +213 -199 wine/dlls/x11drv/window.c > 1.21 1.22 +0 -1 wine/dlls/x11drv/scroll.c > 1.16 1.17 +3 -6 wine/dlls/x11drv/mouse.c > 1.40 1.41 +5 -4 wine/dlls/x11drv/event.c > 1.30 1.31 +0 -1 wine/dlls/x11drv/clipboard.c > > -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 2

Re: [d3d9/device.c] IDirect3DDevice9Impl_GetDepthStencilSurface problem
by Ann and Jason Edmeades 04 Feb '05

04 Feb '05

Well yes and no. The 'problem' is most of this code isn't implemented yet... Try Olivers large patch and see if things are any better, or wait a while while a whole load of code gets into cvs. Basically d3d9 shouldn't have any of the code relating to the stencil buffers - that will be in wine3d. I am pretty certain Olivers patch did that, and he is working on splitting it up to get cvs in sync with his local tree. Jason

6 13

PRESS: run windows viruses with wine ...
by Marcus Meissner 04 Feb '05

04 Feb '05

Hi, Fun article ... author tests various viruses with WINE. http://os.newsforge.com/article.pl?sid=05/01/25/1430222&from=rss Ciao, Marcus

8 12

Re: [user32/tests/sysparams.c] Check for availability of SPI_GETICONTITLEWRAP
by jchevrier＠nexicom.net 03 Feb '05

03 Feb '05

> Hi, > > SPI_{GET,SET}ICONTITLEWRAP is not implemented on a standard Win98 SE. > > Changelog > Check for availability of SPI_GETICONTITLEWRAP > > Cheers, > > Paul. Hi Paul, I agree we definately should not be leaving keys/values in user's registries that weren't there originally after the test has been run. Ideally all should be returned to exactly the way it was before the test was run. Unfortunately this patch won't correct the issue. This patch implies that SPI_{GET,SET}ICONTITLEWRAP is not a supported call on Win98 which it is. As a result it will always pass and the registry will still get a new value added. Try the following patch. It was just put together quickly and only covers this one test, but testing here shows it does stop a new value from being added if it did not exist to begin with. I would like to create something that covers the entire sysparams suite of tests to stop this across the board. Thanks for the heads up on this! Justin

3 6

olepicture.c compile failure : "structure has no member named `UserData', implicit declaration of function `DGifOpen'"
by Rizwan Kassim 01 Feb '05

01 Feb '05

This has been reported as Bugzilla 1730. " olepicture.c: In function `_gif_inputfunc': olepicture.c:834: structure has no member named `UserData' olepicture.c: In function `OLEPictureImpl_Load': olepicture.c:923: warning: implicit declaration of function `DGifOpen' olepicture.c:923: warning: assignment makes pointer from integer without a cast make[2]: *** [olepicture.o] Error 1 " configure, apparently, doesn't check that both libgif.so and libungif.so are the correct versions. This was with latest CVS 2005-01-15, in /wine/dlls/oleaut32 Some slackware and debian installs that I've found have : /usr/lib/libgif.so -> libungif.so.3.0.0 /usr/lib/libungif.so -> libungif.so.3.0.0 libungif.so.4.1.0 was available, however. Running: ln -s /usr/lib/libungif.so.4.1.0 libungif.so ln -s /usr/lib/libungif.so.4.1.0 libgif.so in the wine/dlls/oleaut32 directory fixes the compile. I've added this fix to the (Unconfirmed) bug. Any input -- whats my next step? -- Thank you, Rizwan Kassim

3 3

[AppDB] bug on links
by Raphael 01 Feb '05

01 Feb '05

Hi, try http://appdb.winehq.org/appview.php?appId=443&versionId=627 select the www.darkageofcamelot.com link .... bug :) Regards, Raphael

2 1

Re: Slick build output
by Jason But 01 Feb '05

01 Feb '05

First, I apologise for the patch not being here... It appears that my attachment failed, I include it inline in the mail this time.. To Make.rules.in --------------------------------------------------------------------------- 20a21,32 > # Default running of (gnu)make causes a silent make with the NICE_ECHO > # macro expanding to the echo command. > # Running (make VERBOSE=yes) causes the NICE_ECHO to expand to the NULL > # shell command and cause no output. The output will be as per the > # original incarnation of the Makefile > ifneq ($(VERBOSE), yes) > .SILENT: > NICE_ECHO = @echo -e > else > NICE_ECHO = @: > endif > 118a131 > $(NICE_ECHO) " Compiling\t\t$<" --------------------------------------------------------------------------- There has been a range of comments to my original proposal. I make the following points. - I understand that there are those who desire to see the full output, for those running "make VERBOSE=yes" will produce exactly the same output as before. - To the suggestion of "make -s", this gives no output and is pretty useless. - I have been a developer for 20 years and nothing frustrates me more than make output that is over complicated. I see the point of printing the full command line when developing and debugging the Makefile and the make process. Once this is fixed however, I prefer a simple output from make telling me what is currently being compiled, I don't need to see all output every time. Finally, I have progressed a little further, but no patches for you yet. I have modified the *.in files for Make.rules.in, and in the libs and tools subdirectories. My current output (of make) is attached below for comment. I have similar output for "make install" and "make uninstall" (output is nicely lined up on fixed-width fonts :-) Jason. --------------------------------------------------------------------------- jbut-laptop# make Making in libs/ Making in libs/port/ Compiling ffs.c Compiling fstatvfs.c Compiling futimes.c Compiling getopt.c Compiling getopt1.c Compiling getpagesize.c Compiling gettid.c Compiling interlocked.c Compiling lstat.c Compiling memcpy_unaligned.c Compiling memmove.c Compiling mkstemps.c Compiling pread.c Compiling pwrite.c Compiling readlink.c Compiling sigsetjmp.c Compiling spawn.c Compiling statvfs.c Compiling strcasecmp.c Compiling strerror.c Compiling strncasecmp.c Compiling usleep.c Creating Library libwine_port.a Making in libs/unicode/ Compiling casemap.c Compiling collation.c Compiling compose.c Compiling cptable.c Compiling fold.c Compiling mbtowc.c Compiling sortkey.c Compiling string.c Compiling utf8.c Compiling wctomb.c Compiling wctype.c Compiling c_037.c Compiling c_424.c Compiling c_437.c Compiling c_500.c Compiling c_737.c Compiling c_775.c Compiling c_850.c Compiling c_852.c Compiling c_855.c Compiling c_856.c Compiling c_857.c Compiling c_860.c Compiling c_861.c Compiling c_862.c Compiling c_863.c Compiling c_864.c Compiling c_865.c Compiling c_866.c Compiling c_869.c Compiling c_874.c Compiling c_875.c Compiling c_878.c Compiling c_932.c Compiling c_936.c Compiling c_949.c Compiling c_950.c Compiling c_1006.c Compiling c_1026.c Compiling c_1250.c Compiling c_1251.c Compiling c_1252.c Compiling c_1253.c Compiling c_1254.c Compiling c_1255.c Compiling c_1256.c Compiling c_1257.c Compiling c_1258.c Compiling c_10000.c Compiling c_10006.c Compiling c_10007.c Compiling c_10029.c Compiling c_10079.c Compiling c_10081.c Compiling c_20866.c Compiling c_20932.c Compiling c_28591.c Compiling c_28592.c Compiling c_28593.c Compiling c_28594.c Compiling c_28595.c Compiling c_28596.c Compiling c_28597.c Compiling c_28598.c Compiling c_28599.c Compiling c_28600.c Compiling c_28603.c Compiling c_28604.c Compiling c_28605.c Compiling c_28606.c Creating Library libwine_unicode.so.1 Creating Library libwine_unicode.so Making in libs/wine/ Compiling config.c config.c: In function `init_server_dir': config.c:120: warning: right shift count >= width of type config.c:125: warning: right shift count >= width of type Compiling debug.c Compiling ldt.c Compiling loader.c Compiling mmap.c Compiling port.c Creating Library libwine.so.1 Creating Library libwine.so Making in libs/wpp/ Compiling preproc.c Compiling wpp.c YACCing ppy.y Compiling y.tab.c LEXing ppl.l Compiling lex.yy.c Creating Library libwpp.a Making in tools/ Compiling bin2res.c Linking bin2res Compiling fnt2bdf.c Linking fnt2bdf Compiling fnt2fon.c Linking fnt2fon Compiling makedep.c Linking makedep Compiling sfnt2fnt.c Linking sfnt2fnt Creating wineprefixcreate Making in tools/widl/ Compiling hash.c Compiling header.c Compiling proxy.c Compiling typelib.c Compiling utils.c Compiling widl.c Compiling write_msft.c write_msft.c:584: warning: 'ctl2_alloc_importinfo' defined but not used write_msft.c:622: warning: 'ctl2_alloc_importfile' defined but not used write_msft.c:920: warning: 'ctl2_find_nth_reference' defined but not used YACCing parser.y conflicts: 25 shift/reduce Compiling y.tab.c LEXing parser.l Compiling lex.yy.c Linking widl Making in tools/winebuild/ Compiling import.c Compiling main.c Compiling parser.c Compiling relay.c Compiling res16.c Compiling res32.c Compiling spec16.c Compiling spec32.c Compiling utils.c Linking winebuild Creating winebuild.man Making in tools/winedump/ Compiling debug.c Compiling emf.c Compiling le.c Compiling main.c Compiling misc.c Compiling msmangle.c Compiling ne.c Compiling output.c Compiling pe.c Compiling search.c Compiling symbol.c Linking winedump Making in tools/winegcc/ Compiling winegcc.c Compiling utils.c Linking winegcc Making in tools/wmc/ Compiling lang.c YACCing mcy.y YACCing mcy.y Compiling mcl.c Compiling utils.c Compiling wmc.c Compiling write.c Compiling y.tab.c Linking wmc Making in tools/wrc/ Compiling dumpres.c Compiling genres.c Compiling newstruc.c Compiling readres.c Compiling translation.c Compiling utils.c Compiling wrc.c Compiling writeres.c YACCing parser.y conflicts: 5 shift/reduce Compiling y.tab.c LEXing parser.l Compiling lex.yy.c Linking wrc

4 6

Re: wine/dlls x11drv/x11drv.h x11drv/winpos.c x11d ...
by Dimitrie O. Paun 01 Feb '05

01 Feb '05

On Mon, Jan 31, 2005 at 10:34:07AM -0600, Alexandre Julliard wrote: > Log message: > Only create an X window for top-level windows, not for child windows. > Get rid of the X client window too, it's no longer needed. Cool. Does this mean that the window management rewrite is done? -- Dimi.

3 5

emsabp.idl - virtually identical data structures to mapidefs.h
by Luke Kenneth Casson Leighton 31 Jan '05

31 Jan '05

hi, here's an IDL file i'm working on for exchange 5.5 server. as you can see it's virtually identical, structure-for-structure, to those listed in mapidefs.h. at about struct MAPIERROR, the similarity stops. thoughts, anyone? l. -- -- <a href="http://lkcl.net">http://lkcl.net</a> --

1 1

[game] Running; Dark Reign - The future of war with Wine
by Joachim Schiele 31 Jan '05

31 Jan '05

Dear Wine Developers, I've tried to get this game running with wine but after starting i get a nice main menu (sound is ok, too) but there is no mouse. You can't use the mouse altough there is a nice animated cursor. There must be something wrong with wine because in cedega it's working nice. More about this in [2] check the comment from me to dig further into this problem. My question is where should I start to search for the mouse problem? Was there a similar problem with other games in the past? Also note i've already tested the DX grab and the DGA settings with no effect. Maybe this problem is solved very fast! That would be goot because then i could start working on the network/IPX/IP things to get network play working. Dark Reign - The future of War and The Rise Of the Shadowhand is running quite nice with cedega, and I believe if only the mouse would be working it would do the same with wine! Thanks for wine, thanks for your help & and valuable time, Greets, Joachim Schiele ============================= The error message ============================= joachim@knabber:~/darkreign$ wine dkreign.exe Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file Xlib: extension "XFree86-DRI" missing on display ":0.0". fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x77c4c018)->(00010022,00000008) fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x77c4c018)->(00010022,00000013) fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 8 fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 8 fixme:x11drv:X11DRV_DDHAL_CreatePalette stub fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:dsound:IDirectSoundImpl_SetCooperativeLevel level=DSSCL_PRIORITY not fully supported fixme:mci:MCI_LoadMciDriver Couldn't load driver for type CDAUDIO. If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini fixme:mci:MCI_LoadMciDriver Couldn't load driver for type CDAUDIO. If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini fixme:wave:DSD_CreateSecondaryBuffer (0x77c4c5e0,0x77acff20,e0,0,0x77c8b58c,0x77c8b67c,0x77c8b568): stub ============== Links ============== [1] http://appdb.winehq.org/appview.php?appId=154 [2] http://appdb.winehq.org/appview.php?appId=154&versionId=2740

3 2

Recruit regression testers?
by Ivan Leo Puoti 31 Jan '05

31 Jan '05

I think quite a few regressions get into releases, and while a few a tracked down some stay in the code for months if not years (I've heard of at least one game that worked some 2 years ago but doesn't now), while regression testing may seem trivial to a developer, it can be a challenging task for most users, especially if they are new to wine/Linux. So maybe we should recruit some people to get regression reports from users, find the patch that caused the regression, and report back to developers. Am I just to tired at time of writing or could this be a good idea? Ivan.

8 12

Re: SHLWAPI: implement PathIsValidChar{A,W}
by Juan Lang 31 Jan '05

31 Jan '05

Hi Hans, > Yes I contemplated that but then you reintroduce a conditional in > the ascii case ( if (c > 0x7e) ), which somewhat defeats the > purpose of using a lookup table. Defeats? I don't think so. A single comparison that covers a large number of cases is different than a cascade of comparisons. Unless the compiler inlines PathIsValidCharAW, adding a comparison to PathIsValidCharA is faster than a function call anyway. > > Also, that means the data type can be unsigned char, not DWORD. > > I don't understand you, char class values are DWORD. You're right, that's my mistake. > > But for values of c greater than 0xff, you do not mask. This may > > be deliberate, I don't know, but it doesn't look correct. > > It's deliberate and correct. PATH_CHAR_CLASS_OTHER_VALID *is* a mask > so I do return the same value in both cases. Also remember that the > return type is a BOOL so we could return TRUE everywhere but I chose > to mimic Windows here and return a masked value. The tests show this > is the case. I'm still not sure it's correct. What if the call is PathIsValidCharW(0x1ff, PATH_CHAR_CLASS_LETTER) ? In this case, you return PATH_CHAR_CLASS_OTHER_VALID, which is 0x00000100. On the other hand, the call PathIsValidCharW('0', PATH_CHAR_CLASS_LETTER) returns 0. Your test cases don't capture the entire behavior, because the caller's mask and the character class are the same. But what if they are different? Test cases will show which is correct, of course. I've never used the function. I was just pointing out that the behavior for characters above 0xff is different than that for characters less than or equal to 0xff. Inconsistency usually means incorrectness. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

[d3d9/device.c] IDirect3DDevice9Impl_GetDepthStencilSurface problem
by Paul Vriens 31 Jan '05

31 Jan '05

Hi, while trying to run a demo-app, I had a 'crash' I have the following (part of a) trace: trace:d3d:IDirect3DDevice9Impl_GetDepthStencilSurface (0x77e3d028)->returning ((nil)) default is stencilbuffer=((nil)) trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x499db0cd trace:seh:EXC_RtlRaiseException info[0]=00000001 trace:seh:EXC_RtlRaiseException info[1]=00000004 trace:seh:EXC_RtlRaiseException eax=00000004 ebx=499e232c ecx=00000000 edx=00000001 esi=77e3d028 edi=77ec8318 trace:seh:EXC_RtlRaiseException ebp=70ecf5ac esp=70ecf5a0 cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00210202 This is because IDirect3DSurface9Impl_AddRef is called with a NULL parameter. In d3d8/device.c this is checked in d3d9/device.c it isn't. The demo-app get's a bit further with this patch/hack, but I don't know if it's correct (or if it is correct in d3d8). Comments ? Cheers, Paul.

1 0

Help on Wine
by Katia Maculan 31 Jan '05

31 Jan '05

Hello, In the last few days I executed some tests to understand a segmentation fault problem in my pcsdll library working with WineLib in RedHat 9. I created: - A little library pcsdll exporting a function that calls the TlsAlloc function - A little executable pcsmon that calls the exported library pcsdll function and creates a window Linking the library with the command g++ -m32 -march=pentium-mmx -mcpu=i686 -g -shared -Wl,-soname=pcsdll.so ...... when the pcsmon calls the library function the library obtains a segmentation fault in calling TlsAlloc function. Do you have any idea about what I miss? Regards Katia PS: I'm using wine 20050111 version -- Katia Maculan Developer ISIS Papyrus Italy Srl Tel: (+39) 0125 6455400 Fax: (+39) 0125 6455150 E-mail: katia.maculan(a)isis-papyrus.com Info: info(a)isis-papyrus.com Hotline: +43-2236-27551-111 Visit our Website: http://www.isis-papyrus.com

2 1

Re: [wined3d] GUIDS for everything.
by Alexandre Julliard 31 Jan '05

31 Jan '05

Oliver Stieber <oliver_stieber(a)yahoo.co.uk> writes: > Hi, this patch provides guids for all the wined3d > interfaces. There not needed right now, but some > patches I'll be sending in depend on them. I don't think you want to add wined3d GUIDs to dxguid, they don't exist in the Windows one. IMO they should remain purely internal to wined3d and d3d8/d3d9. -- Alexandre Julliard julliard(a)winehq.org

1 0

Xnews regression from update region handling
by Rein Klazes 31 Jan '05

31 Jan '05

Alexandre, After the update region handling moved to the server, Xnews gets in an endless loop when the windows with news groups is scrolled. The endless loop is in user/painting.c. Calling sequence is ScrollWindowEx(... SW_ERASE|SW_INVALIDATE)-> RedrawWindow(..., RDW_INVALIDATE|RDW_ERASE|RDW_ERASENOW)-> erase_now() In erase_now() the aptly coded endless loop is never broken out, and loops on the same window over and over. Before the change this was coded quite differently (traversing the window's child tree) and could not loop indefinitely. I am quite stuck what should be the reason why the loop is expected to end in the first place. Perhaps you want to have a look. Xnews can be downloaded from all over the net, for example: http://xnews.newsguy.com/release/xnews.zip Unzip it in a directory of your choice; run xnews.exe; enter the host name of a news server; confirm that you want to download the list of newsgroups; you get a window with newsgroups, try to scroll down the list. Rein.

2 1

Re: winmm: another round for unicode migration
by Alexandre Julliard 31 Jan '05

31 Jan '05

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > this patch moves (almost) the rest of winmm to handle correctly the MM > drivers as unicode drivers (for the 32 bit part) It doesn't build, you probably forgot to include the header changes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2005