wine-devel July 2005

wine-devel@winehq.org

152 participants
298 discussions

How to pass / convert file names?
by Christian Britz 27 Jul '05

27 Jul '05

Hi, I discovered only recently a problem which is probably quite prevalent, but I could not find the answer on the web. Example: I want to configure Mozilla for opening .DOC files with the free Word Viewer that can be downloaded at http://www.microsoft.com. To do so I go to Edit -> Preferences -> Navigator -> "Helper Applications" and create a new MIME-Type "application/msword", extensions "doc dot" and tell the beast to open such files with /home/cbritz/.wine/drive_c/Programme/Microsoft Office/WORDVIEW.EXE (I have configured binfmt support, so I can call the EXE directly) Expected behaviour: The viewer program starts, opens the doc file and displays it. What happens: The viewer program starts and does not open any file. I must manually select Z:\tmp\Example.doc from the application. Next try from command line: .wine/drive_c/Programme/Microsoft\ Office/WORDVIEW.EXE /tmp/Example.doc - Again the doc file doesn't open. It DOES WORK when I manually translate the path name to: .wine/drive_c/Programme/Microsoft\ Office/WORDVIEW.EXE Z:\tmp\Example.doc first. I expected naively that wine automatically translates the Unix scheme to it's own convention but this doesn's seem to be true. Is it possible to instruct wine to translate the path string before it passes it to the windows binary? If not, is there a workaround to do that trick? One solution would probably be to write a wrapper script that translates the path name before it is passed to wine. One discussion board entry I found indicates the CrossOver plugin does it that way. I might even volunteer for trying to write a patch to wine if someone could tell me where to start to look at in the code ;) But probably the solution is already out there and I just don't see it. Any help would be much appreciated! Regards Christian

2 4

bugs #3148 - Still in wine-20050725
by Hiji 27 Jul '05

27 Jul '05

Can anyone help out with this bug? It's still in existence in the July Wine release. Basically, I select 3 files, and I click on the highlighted files to try to drag all 3. However, as soon as I click on them, they deselect, and one file is now selected. If I attempt to click+drag the one file, it gets stuck on the click+drag -- that is, I let get go of the mouse button and the highlighted file is still attached to the mouse arrow. Help! I want to use the latest Wine, but it's useless to me if I can't get proper mouse behavior. :S (I'm still stuck on wine-20041201 otherwise.) Hiji __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 2

Re: hhctrl: Add the WebBrowser implementation
by James Hawkins 27 Jul '05

27 Jul '05

On 7/27/05, James Hawkins <truiken(a)gmail.com> wrote: > Hey, > > This patch includes these changes: > * no more HH_* macros, no more hhctrl.h > * uses proper ref counting > * stores pointers instead of using ptr arithmetic > * IOleClientSiteImpl frees itself so there is no mem leak > * uses the ICOM_THIS_MULTI macro > * misc cleanups > > Changelog > * Add the WebBrowser implementation. > Can you tell me what needs to be fixed to get this accepted? This is a bare-bones implementation of a embedded web browser, so the S_OKs and the E_NOTIMPL are necessary to make shdocvw happy, but we really don't need those particular api in HTML Help. -- James Hawkins

1 0

Re: hhctrl: Add the WebBrowser implementation
by Dmitry Timoshkov 27 Jul '05

27 Jul '05

"James Hawkins" <truiken(a)gmail.com> wrote: > +#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field)) IMO using 'const' before the type looks more natural. Also adding 'const' to all type conversions wouldn't hurt: const impl* This = (const impl*)((const char*)(iface) - offsetof(impl,field)) > +static HRESULT STDMETHODCALLTYPE Site_SaveObject(IOleClientSite *iface) > +{ > + return E_NOTIMPL; > +} Any chance to add a FIXME to all not implemented interfaces even if you return S_OK in them? > +static IOleClientSiteVtbl MyIOleClientSiteTable = Please make all OLE vtables const and use const keyword for pointers to them in the structures of interface implementations. > + switch (dwAction) > + { > + case WB_GOBACK: > + IWebBrowser2_GoBack(pWebBrowser2); > + break; > + case WB_GOFORWARD: > + IWebBrowser2_GoForward(pWebBrowser2); > + break; > + case WB_GOHOME: > + IWebBrowser2_GoHome(pWebBrowser2); > + break; > + case WB_SEARCH: > + IWebBrowser2_GoSearch(pWebBrowser2); > + break; > + case WB_REFRESH: > + IWebBrowser2_Refresh(pWebBrowser2); If it's intented to not use 'break;' here a comment telling that wouldn't hurt. > + case WB_STOP: > + IWebBrowser2_Stop(pWebBrowser2); > + } default: here wouldn't hurt as well and would show some not expected/implemented cases with a FIXME message. -- Dmitry.

2 3

Re: dlls/winmm/winealsa/midi.c: Bug in MIDI_CMD_BENDER fixed
by Marcus Meissner 27 Jul '05

27 Jul '05

On Tue, Jul 26, 2005 at 11:52:55PM +0200, Johannes Koch wrote: > The pitch value was wrongly converted and has to be centered around zero. > > Changelog > Fixed pitch bending in the alsa midi driver. > > ? patch.diff > Index: dlls/winmm/winealsa/midi.c > =================================================================== > RCS file: /home/wine/wine/dlls/winmm/winealsa/midi.c,v > retrieving revision 1.16 > diff -u -p -r1.16 midi.c > --- dlls/winmm/winealsa/midi.c 27 Apr 2005 09:39:56 -0000 1.16 > +++ dlls/winmm/winealsa/midi.c 26 Jul 2005 21:31:05 -0000 > @@ -833,7 +833,7 @@ static DWORD modData(WORD wDevID, DWORD > snd_seq_ev_set_controller(&event, evt&0x0F, d1, d2); > break; > case MIDI_CMD_BENDER: > - snd_seq_ev_set_pitchbend(&event, evt&0x0F, ((WORD)d1 << 7) | (WORD)d2); > + snd_seq_ev_set_pitchbend(&event, evt&0x0F, ((WORD)d2 << 7 | (WORD)d1) - 0x2000); This is not correct, you need extra ( ) around the << 7, like this perhaps: > + snd_seq_ev_set_pitchbend(&event, evt&0x0F, (((WORD)d2 << 7) | (WORD)d1) - 0x2000); Ciao, Marcus

3 2

Re: RICHED20: TODO list additions
by Dmitry Timoshkov 27 Jul '05

27 Jul '05

"Phil Krylov" <phil(a)newstar.rinet.ru> wrote: > Added some missing but useful items to the RichEdit TODO list. > + * - full justification > + * - hyphenation > + * - tables What kind of hyphenation richedit needs? Would an automatic, not dictionary based algorithm suffice? In 1996-97 I've developed and implemented that kind of algorithm for russian language and MS Word/Pagemaker. It produces much better results than Ventura Publisher for DOS and similar results to (released later) builtin automatic hyphenation in Pagemaker 6.0 (russian edition). The code has been written for TurboC/DOS but should be easy enough to port), and I would be happy if it could be handy for Wine's richedit. Just let me know and I'll send the sources. -- Dmitry.

3 2

Re: Reimplement EnumDateFormats, make it work for all available locales
by Paul Vriens 27 Jul '05

27 Jul '05

> Hello, > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > - Reimplement EnumDateFormats, make it work for all available locales. > - Add a test for EnumDateFormats > ... > -BOOL WINAPI EnumDateFormatsA( DATEFMT_ENUMPROCA lpDateFmtEnumProc, LCID > Locale, DWORD dwFlags) > +BOOL WINAPI EnumDateFormatsA(DATEFMT_ENUMPROCA proc, LCID lcid, DWORD > flags) Why did you change the names ? I thought we sticked to the MSDN ones ? Paul.

2 1

crypt32: Re: exception handling, part 2
by Saulius Krasuckas 27 Jul '05

27 Jul '05

* Log message from [1]: > > Juan Lang <juan_lang(a)yahoo.com> > - fix decoding of long-form data lengths > - use exception handling in decoding > - tests for these changes One of added tests in the patch fails on winME: | encode.c:313: Test failed: Expected CRYPT_E_ASN1_LARGE, got c0000005 But the bad thing is that after running small code chunk another calls to CryptEncodeObjectEx() starts generating exceptions here. Mentioned code: + /* Try to decode some bogus large items */ + /* The buffer size is smaller than the encoded length, so this should fail + * with CRYPT_E_ASN1_EOD if it's being decoded. It's failing with + * CRYPT_E_ASN1_LARGE, meaning there's a limit on the size decoded. + * The magic limit under XP seems to be 0x061a8000 bytes--more than this + * fails with CRYPT_E_ASN1_LARGE. + */ + ret = CryptDecodeObjectEx(dwEncoding, X509_MULTI_BYTE_INTEGER, tooBig, + 0x7fffffff, CRYPT_DECODE_ALLOC_FLAG, NULL, (BYTE *)&buf, &bufSize); + ok(!ret && GetLastError() == CRYPT_E_ASN1_LARGE, + "Expected CRYPT_E_ASN1_LARGE, got %08lx\n", GetLastError()); And example of parameters for the mentioned call (which after throws an exception of "Access violation" in another tests): CryptEncodeObjectEx( X509_ASN_ENCODING, X509_ENUMERATED, 1, CRYPT_ENCODE_ALLOC_FLAG, NULL, (BYTE *)&buf, &bufSize ); HTH to fix exceptions. If that informations is not enough, I will be glad to debug this via e-mail, Juan. :-) [1] http://www.winehq.org/hypermail/wine-cvs/2005/06/0683.html

3 6

Re: Add ShellExecute() conformance tests
by Saulius Krasuckas 27 Jul '05

27 Jul '05

* On Fri, 22 Jul 2005, Francois Gouget wrote: > > So the goal of this conformance test is to at least get things started > and to test a few sticking points like putting quotes around the One test fails on my box: | $ make -C dlls/shell32/tests/ test | make: Entering directory `/mnt/antras/usr/src/wine-cvs/wine/dlls/shell32/tests' | ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so shlexec.c && touch shlexec.ok | shlexec.c:275: Test failed: ShellExecute(null, "C:\windows\temp\\test_shortcut_shlexec.lnk", null, null) failed: rc=31 err=0 | make: *** [shlexec.ok] Error 1 Any ideas?

3 2

Version
by jstrupeni 27 Jul '05

27 Jul '05

Hello, I have a Novell Linux Desktop Version 9 and I don't know what version of Wine I should install. Thank you very much in advance. Juan

1 0

Report request. Wine20050725 Configuration error
by Ivan Lezhnev, Jr. 27 Jul '05

27 Jul '05

> configure: WARNING: GL/glx.h: present but cannot be compiled > configure: WARNING: GL/glx.h: check for missing prerequisite headers? > configure: WARNING: GL/glx.h: see the Autoconf documentation > configure: WARNING: GL/glx.h: section "Present But Cannot Be Compiled" > configure: WARNING: GL/glx.h: proceeding with the preprocessor's result > configure: WARNING: GL/glx.h: in the future, the compiler will take > precedence > configure: WARNING: ## ------------------------------------ ## > configure: WARNING: ## Report this to wine-devel(a)winehq.org ## > configure: WARNING: ## ------------------------------------ ## Slackware GNU\Linux 10.0.0, kernel 2.6.10 #2 -- Ivan Lezhnev, Jr. Ukraine. Simferopol. Local Time: Wed Jul 27 13:16:15 EEST 2005 Using: Slackware GNU\Linux | Kernel 2.6.10 #2 Disassemble to assemble something pure

1 0

Re: [wined3d] pbuffer support
by Ivan Gyurdiev 27 Jul '05

27 Jul '05

On Mon, 2005-07-18 at 19:02 +0100, Oliver Stieber wrote: > Hi, > > This patch implements the use of PBuffers for offscreen textures. > The fads in Pirates should now appear fullscreen, the dx9_offscreen_rendering > tutorial has an odd problem with ATI's drivers, clicking the window and moving > the mouse will cause the tutorial to render properly, I haven't found anything > else with this problem yet and I don't currently have a workaround. > > Registry entries and options in winecfg to change to enable and disable > pbuffers will be added in a later patch. Regression in HL2: http://ivan.ivg2.net/scr.png Screen is almost completely white - no textures. New messages (maybe?): ... fixme:d3d9:IDirect3DDevice9Impl_CreateSurface (0x7ff6b940) call to IWineD3DDevice_CreateSurface failed fixme:d3d9:D3D9CB_CreateSurface (0x7ff6b940) IDirect3DDevice9_CreateSurface failed fixme:d3d:IWineD3DDeviceImpl_CreateTexture Failed to create surface 0x7d161620 fixme:d3d9:IDirect3DDevice9Impl_CreateTexture (0x7ff6b940) call to IWineD3DDevice_CreateTexture failed .... fixme:d3d_shader:IDirect3DDevice9Impl_SetVertexShader Disabled 0x7ff6b940

3 4

cross-compiling for ARM
by John Connor 26 Jul '05

26 Jul '05

Has anyone tried to cross-compile Wine for the ARM platform or is there any documentation on how to do this? -------------------------------------------------------- This is an e-mail from General Dynamics Robotic Systems. It is for the intended recipient only and may contain confidential and privileged information. No one else may read, print, store, copy, forward or act in reliance on it or its attachments. If you are not the intended recipient, please return this message to the sender and delete the message and any attachments from your computer. Your cooperation is appreciated.

2 1

How to test a win16 application in our test-suite
by Paul Vriens 26 Jul '05

26 Jul '05

Hi, I'm busy fixing up version.dll, and I want to create some tests to read resources from win16 applications. I currently have a fixed .exe in my tests directory, but I'd like to create a 16bit .exe (or .dll) during the creation of the tests. Any idea's ? Paul Vriens.

4 3

Re: commctrl: modularize progress drawing
by Dimi Paun 26 Jul '05

26 Jul '05

From: "Frank Richter" <frank.richter(a)gmail.com> > Frank Richter <frank.richter(a)gmail.com> > Split up the drawing code into a set of smaller functions and also moved > some common computations into helper functions. All that to facilitate > the implementation of the forthcoming theming support. > +static inline int PROGRESS_GetLedSize( PROGRESS_INFO *infoPtr, LONG style, It has become the norm lately to not have the ALLCAPS_ prefix for internal static functions, but rather have names_with_underscores to easily tell them apart from Win32 APIs. So for the above, I guess get_led_size() would be preferable. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 2

Adding a new include file (softpub.h)
by Paul Vriens 26 Jul '05

26 Jul '05

Hi, for a patch to wintrust_main.c I need to define a GUID (WINTRUST_ACTION_GENERIC_VERIFY_V2). This GUID is present in softpub.h. The include file is not included in Wine right now. What are the 'rules' to add a new include file? Is it ok that have only this GUID in there ? Cheers, Paul. P.S. If somebody already has this one lying around, be my guest :-)

1 0

Re: [wintrust] Return TRUST_E_PROVIDER_UNKNOWN for WinVerifyTrust
by Rein Klazes 26 Jul '05

26 Jul '05

On Thu, 14 Jul 2005 13:37:53 +0200 (CEST), you wrote: > Hi, > > currently we return ERROR_SUCCESS for WinVerifyTrust. Process Explorer > expects some data because of this. > > As no trust provider is implemented yet, return TRUST_E_PROVIDER_UNKNOWN > instead. Paul, Girotel was perfectly happy with the ERROR_SUCCESS without anymore "data" (none is actually returned), now it fails. I think that in this case ERROR_SUCCESS should be the default. If you cannot figure out what data your program expects, perhaps you can single out the specific ActionID to return a failure. Rein.

2 3

Re: [wined3d] per app settings regression
by Raphael 26 Jul '05

26 Jul '05

On Monday 25 July 2005 20:41, Oliver Stieber wrote: > Hi, > This patch corrects a regression issue in > http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html > Hi You just sent the sme patch :) Maybe you forgot to attach the good one Regards, Raphael

2 1

[wined3d] regression
by Oliver Stieber 26 Jul '05

26 Jul '05

Following this patch http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html wined3d SegV's every time the dll is loaded. ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

3 4

Re: objsel: Add stubs for objsel.dll and objsel.h
by Thomas Weidenmueller 26 Jul '05

26 Jul '05

Thomas Weidenmueller wrote: > The attached archive contains a stubbed objsel.dll and it's public > header file objsel.h Any comments why it got rejected? Best Regards, Thomas

2 1

Windows API
by Bennie Kahler-Venter 26 Jul '05

26 Jul '05

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Anyone saw the article in June's Dr. Dobb's Journal, July 95 titled "Finding Binary Clones with Opstrings & Function Digests: Part I" by Andrew Schulman http://www.undoc.com Although just the first article, It already shows promise from wine's perspective. Generating hashes on the functions in the DLL's & EXE's while taking into consideration not to be fooled by the pointer diffs because of different positions in the binaries, Huge potential to find similar functions in all dll's instead of recoding them all. According to the article something Windows suffers from quite a bit... Just my 2c Tnx & Bi Bennie Kahler-Venter -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFC5fc7jrc/ZmvwnjARAgsyAJ9EGFZjvY+bvS4MuUJuS9IZ9WZ59ACgkAr1 ynML4cy/z/JKviK17RrwiOE= =TlTz -----END PGP SIGNATURE-----

1 0

Re: hhctrl: Add the WebBrowser implementation
by Dmitry Timoshkov 26 Jul '05

26 Jul '05

"James Hawkins" <truiken(a)gmail.com> wrote: > +#define HH_Alloc(size) ((LPVOID)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size)) > + > +#define HH_Free(buffer) \ > + if (buffer) \ > + HeapFree(GetProcessHeap(), 0, (HLOCAL)buffer); Alot of work has been done to avoid tests for NULL before HeapFree call, please do not introduce them again. Personally I don't see the point of HH_Alloc and HH_Free macros at all. > +#define HH_SafeRelease(x) \ > + if (x) \ > + { \ > + x->lpVtbl->Release(x); \ > + x = NULL; \ > + } Again, a direct access to a vtable. There is no much point in that macro either, do that check directly instead and get rid of hhctrl.h completely. -- Dmitry.

1 0

Bug in native user32
by Jacek Caban 26 Jul '05

26 Jul '05

Hello. Fixing MSHTML tests I found a bug in Windows. In tests I passed const WNDCLASSEX, to RegisterClassEx what should work as its declaration is: ATOM WINAPI RegisterClassExW(const WNDCLASSEXW *); Changing passed WNDCLASS to nonconst makes it works. I wrote small tests (attached) showing that if hInstance of WNDCLASSEX is NULL, RegisterClassEx sets it to GetModuleHandle(NULL). It, of course, couses segmentation fault in case CMASSWNDEX is const. This problem seams to happen on XP, NT 4, 2k and 2k3. So the question is if we should clone this bug? Some applications may expect it, but other may crash. They will crash on Windows anyway... Or we should mark test as todo_wine and change it if we found application that depend on it? Thanks, Jacek Index: dlls/user/tests/class.c =================================================================== RCS file: /home/wine/wine/dlls/user/tests/class.c,v retrieving revision 1.19 diff -u -p -r1.19 class.c --- dlls/user/tests/class.c 15 Jun 2005 10:21:19 -0000 1.19 +++ dlls/user/tests/class.c 25 Jul 2005 16:14:10 -0000 @@ -301,6 +301,15 @@ static void test_instances(void) HINSTANCE user32 = GetModuleHandleA("user32"); HINSTANCE main_module = GetModuleHandleA(NULL); + WNDCLASSEXA clsex = { + sizeof(WNDCLASSEXW), + 0, + ClassTest_WndProc, + 0, 0, NULL, NULL, NULL, NULL, NULL, + "const_test", + NULL + }; + memset( &cls, 0, sizeof(cls) ); cls.style = CS_HREDRAW | CS_VREDRAW; cls.lpfnWndProc = ClassTest_WndProc; @@ -436,6 +445,10 @@ static void test_instances(void) ok( !GetClassInfo( 0, name, &wc ), "Class found with null instance\n" ); ok( GetLastError() == ERROR_CLASS_DOES_NOT_EXIST, "Wrong error code %ld\n", GetLastError() ); ok( UnregisterClassA( name, 0 ), "Unregister failed for null instance\n" ); + + ok( RegisterClassExA( &clsex), "RegisterClassExA failed\n"); + ok( clsex.hInstance == GetModuleHandle(NULL), "hInstance=%08lx\n, expected %08lx\n", + clsex.hInstance, GetModuleHandle(NULL)); /* registering for user32 always fails */ cls.lpszMenuName = "user32";

3 3

Re: [AppDB] fix situation when AppDB is not at DocumentRoot (patch 1 of 3) (gah! resend)
by Chris Morgan 26 Jul '05

26 Jul '05

I ran into the same issue and was in the process of trying to fix it up. Maybe this is a better approach because it doesn't require any user intervention? The idea was to pass the relative path through that function to get the full local path. I can attach the rest of the patch if you'd like but it isn't in a finished state. Chris On 7/23/05, Tony Lambregts <tony.lambregts(a)gmail.com> wrote: > These patch are to meant address situations like mine when the AppDB is located > a http://localhost/appdb instead of http://localhost/. These patches can be > applied independatly from my other patches. > > Change Log: fix situation when AppDB is not at DocumentRoot. > > Files Changed: include/config.php.sample > > > > > > > > Index: include/config.php.sample > =================================================================== > RCS file: /home/wine/appdb/include/config.php.sample,v > retrieving revision 1.11 > diff -u -r1.11 config.php.sample > --- include/config.php.sample 23 Apr 2005 02:24:35 -0000 1.11 > +++ include/config.php.sample 23 Jul 2005 22:28:16 -0000 > @@ -17,6 +17,11 @@ > define("APPDB_OWNER_URL","http://www.winehq.org/"); // website of this product/company > define("APPDB_OWNER_EMAIL","appdb(a)winehq.org"); // e-mail of this product/company > define("BUGZILLA_ROOT","http://bugs.winehq.org/"); // path to bugzilla > +// the following is usefull if the location of your appdb is offset from the > +// DocumentRoot defined in httpd.config > +// For example: If you access the appdb from http://localhost/appdb > +// uncomment the following line . > +//define("APPDB_OFFSET","/appdb"); > > > /* > > >

1 0

Installer hangs with no output :S
by Hiji 25 Jul '05

25 Jul '05

I'm trying out this month's release. I'm trying to install AbsoluteFTP which previous installed fine, but now I try to install, the install shield begins, but just sits there. There's not even any output... How can I get something together to report to you guys? Hijinio ____________________________________________________ Start your day with Yahoo! - make it your home page http://www.yahoo.com/r/hs

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2005