January 2006 - wine-devel

setupapi: unimplemented function setupapi.dll.SetupPromptReboot
by Saulius Krasuckas 28 Jan '06

28 Jan '06

I stuck upon this function right now. And I see ReactOS folks already have some implementation [*], but for some reason it is disabled. Is anyone working on this for Wine? Any ideas about the ReactOS code? [*] http://www.reactos.org/generated/doxygen/d4/d55/lib_2setupapi_2stubs_8c-sou…

3 8

Re: USER: creating 16bit windows convert null instances to current process (try #3, should work now)
by Joseph Garvin 28 Jan '06

28 Jan '06

It's been a about a month since I sent this in and it still hasn't been applied. Is there something wrong with the patch? Joseph Garvin wrote: > Fixed up the patch according to Dmitry's suggestions :) > > Changelog > Fixed instance = 0 not converted to the current process when making a > window. Broke menus in some apps. (Thanks to Mike) > > >------------------------------------------------------------------------ > >--- dlls/user/win.c.1 2005-12-31 03:03:19.000000000 -0700 >+++ dlls/user/win.c 2006-01-01 01:02:43.000000000 -0700 >@@ -1145,6 +1145,18 @@ HWND16 WINAPI CreateWindowEx16( DWORD ex > cs.cx = (width == CW_USEDEFAULT16) ? CW_USEDEFAULT : (INT)width; > cs.cy = (height == CW_USEDEFAULT16) ? CW_USEDEFAULT : (INT)height; > >+ /* Correct if instance is null now, because later we won't >+ be able to tell the difference between a 16-bit NULL and >+ a 32-bit NULL */ >+ >+ if (!instance) >+ { >+ HTASK16 hTask = GetCurrentTask(); >+ TDB *tdb = GlobalLock16(hTask); >+ instance = tdb->hInstance; >+ GlobalUnlock16(hTask); >+ } >+ > /* Create the window */ > > cs.lpCreateParams = data; > > >------------------------------------------------------------------------ > > > >

1 0

Re: tape.c: remove bogus breaks
by Hans Leidekker 27 Jan '06

27 Jan '06

On Friday 27 January 2006 22:13, Michael Stefaniuc wrote: > are those breaks realy supposed to be there? Smatch was complaining > about unreachable code. No, those breaks don't belong there, your patch is correct. -Hans

1 0

Re: opengl: Sync a dibsection to its pixmap before drawing to it via opengl
by Alexandre Julliard 27 Jan '06

27 Jan '06

Huw D M Davies <h.davies1(a)physics.ox.ac.uk> writes: > +void enter_gl(void) > +{ > + GLXContext gl_ctx; > + Wine_GLContext *ctx; > + enum x11drv_escape_codes escape = X11DRV_SYNC_PIXMAP; > + > + wine_tsx11_lock_ptr(); /* unlock in LEAVE_GL */ > + gl_ctx = glXGetCurrentContext(); > + if(!gl_ctx) return; > + ctx = get_context_from_GLXContext(gl_ctx); > + if(!ctx || GetObjectType(ctx->hdc) == OBJ_DC) > + return; > + > + ExtEscape(ctx->hdc, X11DRV_ESCAPE, sizeof(escape), (LPCSTR)&escape, 0, NULL); You cannot make GDI calls while holding the X11 lock, this will deadlock. -- Alexandre Julliard julliard(a)winehq.org

1 0

Global hooks problems (WH_MOUSE_LL)
by Vitaliy Margolen 27 Jan '06

27 Jan '06

Trying to track down the problem with our DInput implementation I found some interesting stuff - our global hooks don't work correctly because hook callbacks are never called if event is generated in the different thread. I don't think this is a revelation to number of people who knew that before. But how do we fix it? Her is what I dug up so far: 1. Installing global hook we setting it as WINEVENT_INCONTEXT while msdn and tests indicate that it qualifies as WINEVENT_OUTOFCONTEXT instead. Unless of course we don't want to call post_win_event in step 5 and go to step 6 instead. 2. All HW mouse messages start here: http://source.winehq.org/source/dlls/x11drv/mouse.c#L191 From looking at it I assume that all the HW mouse hooks should be handled by HOOK_CallHooks function. This is because there are no code related to hooks in send_message server call. 3. First thing that HOOK_CallHooks does is calling HOOK_IsHooked with checks only current thread for installed hooks. So this is first place that is wrong. Let's comment that check out for now. I think we need to move that check farther down, after the call to server. 4. We call start_hook_chain http://source.winehq.org/source/server/hook.c#L468 to start hook callback chain. There we call get_first_valid_hook on local and then global if no local hooks exist. But there again we check for http://source.winehq.org/source/server/hook.c#L211 the hook callback thread being local (which is again not the case for global hooks). This is problem #2. 5. Now we have post_win_event of but right before it we hitting an assert so this is not the right way? 6. Say we returned with success and back to HOOK_CallHooks that now tries to call MSG_SendInternalMessageTimeout. Which for some reason fails to deliver message to our global hook. So my question is to anyone who knows. What is the proper way to deliver these messages to global hooks that are in a different thread/process? Attached is the small program to test part of this. Fixing problems (1) & (2) made it work. But it still not enough for the game (for some reason). Vitaliy

4 7

Progress on TiVo... but no cigar yet.
by Dan Kegel 27 Jan '06

27 Jan '06

Last year, I tried installing Tivo Desktop 2.0, and it failed miserably: http://www.winehq.com/hypermail/wine-devel/2005/03/0406.html Prompted by a request in wine-users, I just tried installing both Tivo Desktop 1.3 (their win98-compatible version) and Tivo Desktop 2.2 (for winxp). 2.2 wouldn't install (it really wanted to install a service, and that didn't work) but 1.3 did install (with a bunch of warnings). Starting TivoPublisher.exe even puts up a GUI after warnings like this: fixme:win:EnumDisplayDevicesW ((null),0,0x7fb1f198,0x00000000), stub! fixme:win:LockWindowUpdate (0x10020), partial stub! fixme:win:LockWindowUpdate ((nil)), partial stub! fixme:secur32:GetUserNameExA 3 0x7fb1f51c 0x7fb1f580 fixme:sync:CreateIoCompletionPort (0xf0, (nil), 7ec2b0dc, 00000000): stub. Unfortunately, the GUI is nonfunctional. (And kind of funny.) Starting TivoServer.exe doesn't work at all (it seems to want a service to be started). At least the installer doesn't crash like it did last year! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

LostWages: Status pages update #4
by Tom Wickline 26 Jan '06

26 Jan '06

Hello, Tom Change log: fix security.dll documentation link

1 0

LoadImage (4bpp) / CopyImage() crashing
by Cyril Margorin 26 Jan '06

26 Jan '06

Hello, During research the crashing application I've found a problem that can be easily reproduced by test. (http://www.winehq.org/pipermail/wine-patches/2005-November/022384.html) By investigation of problem I've found that original DIB bit depth is 4bpp, Physical pixmap bit depth is (equal to screen) 24bpp. In x11drv/bitmap.c X11_GetBitmapBits takes in account just only bit depth of physical pixmap, and copies it to provided buffer as-is. I.e. it tries to fill buffer with size (e.g.) 48x48x4bpp with 48x48x24bpp that causes buffer overrun and late falling in SetBitmapBits function. The current work-around to stop falling is Index: dlls/x11drv/bitmap.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/bitmap.c,v retrieving revision 1.18 diff -u -r1.18 bitmap.c --- dlls/x11drv/bitmap.c 26 Sep 2005 11:04:12 -0000 1.18 +++ dlls/x11drv/bitmap.c 25 Nov 2005 09:29:12 -0000 @@ -186,7 +186,19 @@ /* copy XImage to 16 bit padded image buffer with real bitsperpixel */ startline = buffer; - switch (physBitmap->pixmap_depth) + + /********************************************************************** + * CoMargo: the switching for physBitmap->pixmap_depth is not correct. + * It should take both physBitmap->pixmap_depth and bitmap.bmBitsPixel + * and convert from one bitdepth to another. + * Otherwise we meet buffer overrun. + */ + if(physBitmap->pixmap_depth != bitmap.bmBitsPixel) + { + FIXME("Pixel conversion from %d bitdepth to %d bitdepth MUST be done!\n",physBitmap->pixmap_depth,bitmap.bmBitsPixel); + } +/* switch (physBitmap->pixmap_depth) */ + switch(bitmap.bmBitsPixel) { case 1: for (h=0;h<height;h++) =================================================================== -- Cyril Margorin

6 15

Re: OLEAUT32: add additional condition for creation of interface
by Robert Shearman 26 Jan '06

26 Jan '06

Alex Villacís Lasso wrote: >diff -ur wine-0.9.6-cvs/dlls/oleaut32/typelib.c wine-0.9.6-cvs-patch/dlls/oleaut32/typelib.c >--- wine-0.9.6-cvs/dlls/oleaut32/typelib.c 2006-01-16 16:08:20.000000000 -0500 >+++ wine-0.9.6-cvs-patch/dlls/oleaut32/typelib.c 2006-01-24 21:53:48.000000000 -0500 >@@ -5567,10 +5567,31 @@ > ITypeInfo_AddRef(*ppTInfo); > result = S_OK; > } >- else if (hRefType == -1 && >- (((ITypeInfoImpl*) This)->TypeAttr.typekind == TKIND_DISPATCH) && >- (((ITypeInfoImpl*) This)->TypeAttr.wTypeFlags & TYPEFLAG_FDUAL)) >+ else if ( >+ ( >+ hRefType == -1 && >+ (This->TypeAttr.typekind == TKIND_DISPATCH) && >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDUAL) >+ ) >+ || >+ ( >+ (This->TypeAttr.typekind == TKIND_DISPATCH) && >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDISPATCHABLE) >+ ) >+ ) > { >+ /* Report whether we are here because of the DBGRID32.OCX fix */ >+ if (!( >+ hRefType == -1 && >+ (This->TypeAttr.typekind == TKIND_DISPATCH) && >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDUAL) >+ )) >+ { >+ FIXME("ignoring hRefType = %d, TYPEFLAG_FDISPATCHABLE is %s\n", >+ hRefType, >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDISPATCHABLE) ? "set" : "not set"); >+ } >+ > /* when we meet a DUAL dispinterface, we must create the interface > * version of it. > */ > > This doesn't look right to me. We need tests for this situation that will tell us whether we are adding a dirty hack or whether this behaviour is correct. I can send you a test suite I have already built for typelibs if you want to add to it. >@@ -5598,8 +5619,47 @@ > if(pRefType->reference == hRefType) > break; > } >- if(!pRefType) >- FIXME("Can't find pRefType for ref %lx\n", hRefType); >+ if(!pRefType) { >+ static const char * descTKIND[TKIND_MAX] = { >+ "TKIND_ENUM", >+ "TKIND_RECORD", >+ "TKIND_MODULE", >+ "TKIND_INTERFACE", >+ "TKIND_DISPATCH", >+ "TKIND_COCLASS", >+ "TKIND_ALIAS", >+ "TKIND_UNION", >+ }; >+ static const char * descTypeFlags[15] = { >+ "TYPEFLAG_FAPPOBJECT", >+ "TYPEFLAG_FCANCREATE", >+ "TYPEFLAG_FLICENSED", >+ "TYPEFLAG_FPREDECLID", >+ "TYPEFLAG_FHIDDEN", >+ "TYPEFLAG_FCONTROL", >+ "TYPEFLAG_FDUAL", >+ "TYPEFLAG_FNONEXTENSIBLE", >+ "TYPEFLAG_FOLEAUTOMATION", >+ "TYPEFLAG_FRESTRICTED", >+ "TYPEFLAG_FAGGREGATABLE", >+ "TYPEFLAG_FREPLACEABLE", >+ "TYPEFLAG_FDISPATCHABLE", >+ "TYPEFLAG_FREVERSEBIND", >+ "TYPEFLAG_FPROXY", >+ }; >+ int i; >+ >+ FIXME("Can't find pRefType for ref %lx\n", hRefType); >+ FIXME("\ttypekind is %s\n", descTKIND[This->TypeAttr.typekind]); >+ FIXME("\twTypeFlags are:"); >+ for (i = 0; i < 15; i++) { >+ if (This->TypeAttr.wTypeFlags & (1 << i)) >+ FIXME(" %s", descTypeFlags[i]); >+ } >+ if (This->TypeAttr.wTypeFlags & 0xFFFF8000) >+ FIXME(" %08x", This->TypeAttr.wTypeFlags & 0xFFFF8000); >+ FIXME("\n"); >+ } > if(pRefType && hRefType != -1) { > ITypeLib *pTLib = NULL; > > This clutters the code too much. There are already functions for dumping the typelib that would work here instead, although I think they don't use the FIXME channel. -- Rob Shearman

2 1

Re: Problems with references to drive Z: in registry's User Shell Folders
by Juan Lang 26 Jan '06

26 Jan '06

> when shell32.dll is registered during wineprefixcreate, it puts a > lot of paths based on Z:\ in HKLM/HKCU > Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User > Shell Folders. This is due to resolving CIDL_PERSONAL to the DOS > path corresponding to $HOME. > > If people remove the Z: drive afterwards, this leads to a lot > problems (One being that the Desktop shellfolder won't initialize > any more, which breaks the complete shell namespace and thus the file > dialogs). Yeah, that is painful. > I'm proposing to add two more environment variables: %PERSONAL%, > which would be expanded to the DOS path corresponding to $HOME if > this exists, or to %USERPROFILE%\\My Documents if not (with "My > Documents" resource based, of course). And %DESKTOP%, which would > be expanded to DOS_PATH_OF($HOME)\\Desktop if existent and to > %USERPROFILE%\\Desktop, if not. So the environment variable expansion would be based on shell32? Ouch. I don't think that'll fly. I'm of the opinion that all this fancy CSIDL_PERSONAL mapping doesn't belong in shell32, even though I put it there. shell32 should default to creating paths that are part of the profiles directory if nothing else exists, since the shell won't work without them. But creating Linux-environment-friendly defaults should perhaps go in wineprefixcreate. I actually rather liked the idea of putting it in winecfg, and launching winecfg in a GUI-less mode from wineprefixcreate. The advantage is that the drive mappings and shell folder creation would be in the same app, and so would have some hope of staying consistent. If a user breaks it through direct registry manipulation, his fault. If she breaks it through normal use of our tools, our fault. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 8

Re: TAPE 5/5: add implementation of kernel tape functions #2
by Robert Shearman 26 Jan '06

26 Jan '06

Hans Leidekker wrote: >+static DWORD set_error_from_status( NTSTATUS status ) >+{ >+ DWORD error; >+ >+ switch (status) >+ { >+ case STATUS_SUCCESS: error = ERROR_SUCCESS; break; >+ case STATUS_DISK_FULL: error = ERROR_END_OF_MEDIA; break; >+ case STATUS_DEVICE_NOT_READY: error = ERROR_NO_MEDIA_IN_DRIVE; break; >+ case STATUS_ACCESS_DENIED: error = ERROR_WRITE_PROTECT; break; >+ case STATUS_DEVICE_BUSY: error = ERROR_BUSY; break; >+ case STATUS_INVALID_PARAMETER: error = ERROR_INVALID_PARAMETER; break; >+ case STATUS_NOT_SUPPORTED: >+ case STATUS_UNSUCCESSFUL: >+ default: error = ERROR_NOT_SUPPORTED; break; >+ } >+ >+ SetLastError( error ); >+ return error; >+} > > You're duplicating RtlNtStatusToDosError. -- Rob Shearman

3 2

Problems with graphics
by Curro Amores 26 Jan '06

26 Jan '06

Hi: i have an access application and i haved tried to emulate it with wine and crossoffice as well. I have a problem when i want to display reports which have graphics. They are well displayed but when i close it, application fonts (menu) make bigger and take a white background. Has anybody seen any problem similar to it. Thanks all!

2 1

wine and jack => segfault? / wine and OSS not working
by Joachim Förster 26 Jan '06

26 Jan '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, some days ago I sent some mails to the wine-users list. My problem: the JACK output driver of wine does not work => wine segfaults; and the OSS output driver does not work, too. Windows Media Player (used for testing) says, it cannot find the audio hardware. Since then, nobody on the wine-users list had any idea what could be wrong, so now I am posting this here (3 mails): - --------------------------------- Hi, I am new to this list and just wanted to ask a question regarding Wine and JACK: I'm running JACK as my sound daemon and today I installed Wine (from the APT-Repository). I setup my .wine directory with the help of winetools. So far everything works fine, except sound output (tested with wmplayer and a simple wav file). So I selected "jack" as Audio driver. But wine segfaults with wmplayer as soon as opening the wav file: $ wine .wine/c/Programme/Windows\ Media\ Player/mplayer2.exe fixme:process:SetProcessPriorityBoost (0xffffffff,1): stub fixme:powermgnt:SetThreadExecutionState (0x2): stub, harmless. fixme:powermgnt:SetThreadExecutionState (0x80000000): stub, harmless. This sound card's driver does not support direct access The (slower) DirectSound HEL mode will be used instead. Segmentation fault I started qjackctl to see what the JACK says: 20:01:39.052 Audio connection graph change. 20:01:39.136 Audio connection change. 20:01:39.314 XRUN callback (1). 20:01:39.317 Audio connection graph change. So, I assume there was an "connection" established between Wine and JACK? Does anybody know something about this problem? Tell me if I have to provide more (log/debug) output etc. ... I am running Ubuntu Breezy (breezy kernel 2.6.12-10-686). Thanks, Joachim PS: Direct output to ALSA works (with jackd not running). - --------------------------------- Hi all, Does really nobody now something about the issue I described? Meanwhile I have done some further tests: Using the alsa-output driver works, but then I would have to kill the jack daemon, since jackd blocks the sound device, although I am running alsa with dmix. Then a ran Wine with the OSS-output driver while using a tool called oss2jack (makes a kernel device and re-routes all OSS connections to the jack daemon). Surprisingly that does NOT work, too. Although other OSS apps (skype, et, vlc, cedega (oss) ...) run really *very good* over oss2jack. There is one difference then: Using OSS-output driver, Wine does not segfault! The M$ Media Player just tells me, that it cannot access audio hardware. - --------------------------------- Hi all, obviously there is no one on this list who has similar problems? Would it be a good idea to post the problem into the dev mailing list? Anyway, yesterday again I made some tests and I think, that the OSS-output driver of Wine has a bug. Yesterday I used plain OSS (no alsa, no sound server, nothing) and again Windows Media Player (I use it to test sound) said it couldn't use the audio hardware. So there definitely has to be something wrong here. Any ideas? Short summary: Wine@alsa: works Wine@jack: segfault !! I think this is cleary a bug, or not? Wine@oss: WMPlayer couldn't use the audio hardware. Displays an error. System: Ubuntu Breezy (breezy kernel 2.6.12-10-686). - --------------------------------- Thanks, Joachim -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFD1JfBZY86bR8HqNwRAn6FAJ4jZNodTT5STF1Tg3i4kwnJLllRkQCdGwkw hepaKlpjNzFdU1NS6mkUWg8= =cJdT -----END PGP SIGNATURE-----

4 6

Re: Third party downloads
by Tony Lambregts 26 Jan '06

26 Jan '06

On 1/26/06, Joachim von Thadden <thadden(a)web.de> wrote: > Am Thu, Jan 26, 2006 at 07:27:00AM -0700 schrieb Tony Lambregts: > > Tom Wickline wrote: > > >Hello, > > > > > >I see the "note" in the third party downloads section as problematic.. > > >We should say something to the effect of "please report problems back > > >to the authors of WineTools" > > > > > >The way its currently worded WineTools users will feel left out in the > > >dark if they > > >should have any complications. > > > > > > > > It would be helpfull to have a link then, somewhere to direct them to and > > #winehq, bugs.winehq.org wine-devel and wine-users(a)winehq.org are not the > > place. Is it OK to direct them to Joachim directly <thadden(a)web.de>? > > For me it's OK. What about the following: > > Note: WineTools is only recommended if installation or operability of > Windows software failed on pure Wine. Since WineTools radically alters > your Wine configuration please do not report bugs in programs with > WineTools installed to the wine developers. Instead contact the author > of WineTools. > I will try to remember to submit a patch tonight. -- Tony Lambregts

1 0

Third party downloads
by Tom Wickline 26 Jan '06

26 Jan '06

Hello, I see the "note" in the third party downloads section as problematic.. We should say something to the effect of "please report problems back to the authors of WineTools" The way its currently worded WineTools users will feel left out in the dark if they should have any complications. Tom

2 2

Re: TAPE 5/5: add implementation of kernel tape functions
by Alexandre Julliard 26 Jan '06

26 Jan '06

Hans Leidekker <hans(a)it.vu.nl> writes: > + status = NtDeviceIoControlFile( device, NULL, NULL, NULL, &io, > + IOCTL_TAPE_CREATE_PARTITION, &part, sizeof(TAPE_CREATE_PARTITION), NULL, 0 ); > > - return FALSE; > + return (DWORD)status; > } All these functions should return Win32 error codes, not NT status codes. You probably want to set last error too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: make menu tests pass on Win 9x/ME -- RESENT
by Alexandre Julliard 26 Jan '06

26 Jan '06

Rein Klazes <wijn(a)wanadoo.nl> writes: > Changelog: > dlls/user : menu.c > dlls/user/tests : menu.c > > - make menu tests pass on Win9x/ME; > - rename the macro IS_STRING_ITEM to IS_STRING_ITEM_ONLY, which better > reflects what it is doing: absence of other item type flags. You should not check the Windows version, you should only check the actual behavior. Also I think IS_STRING_ITEM is fine, there's no reason to add _ONLY since there's no other macro that would do a less specific test. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Patch to limit testing results in AppDB
by Chris Morgan 26 Jan '06

26 Jan '06

Oooh a new appdb hacker. Welcome :-) > // Show the Test results for a application version > function ShowVersionsTestingTable($iVersionId, $iCurrentTest, $link) > { The maximum number of versions to show should be a parameter to this function. > - $hResult = query_appdb("SELECT * > + global $showAll; We don't want to use globals. Looking at $_REQUEST['showAll'] should work. > + > + $hResult = query_appdb("SELECT * > + FROM testResults > + WHERE versionId = '".$iVersionId."' > + ORDER BY testedDate DESC;"); > + if(mysql_num_rows($hResult) <= 5 || is_string($showAll)) { > + $hResult = query_appdb("SELECT * > FROM testResults > WHERE versionId = '".$iVersionId."' > ORDER BY testedDate DESC;"); > + } > + else{ > + $hResult = query_appdb("SELECT * > + FROM testResults > + WHERE versionId = '".$iVersionId."' > + ORDER BY testedDate DESC LIMIT 0,5;"); > + } This is simplier if you do: $sQuery = "select * from testResults WHERE versionId = '".$iVersionId."' ORDER BY testedDate DESC"; if(!$showAll) $sQuery.=" LIMIT 0,"$maxEntries; It saves a db query and reduces duplicate code. > if(!$hResult || mysql_num_rows($hResult) == 0) > return; > echo '<p><span class="title">Testing Results</span><br />',"\n"; > @@ -379,7 +394,9 @@ > if ($oTest->iTestingId == $iCurrentTest) > echo ' <td align="center" > class="color2"><b>Current</b></td>',"\n"; > else > - echo ' <td align="center" class="color2">[<a > href="'.$link.$oTest->iTestingId.'">Show</a>]</td>',"\n"; > + echo ' <td align="center" class="color2">[<a > href="'.$link.$oTest->iTestingId; > + if(is_string($showAll)) echo > '&showAll='.$showAll.'">Show</a>]</td>',"\n"; > + else echo '">Show</a>]</td>',"\n"; > echo ' <td>',"\n"; > echo '<a href="'.BASE.'distributionView.php > ?iDistributionId='.$oTest->iDistributionId.'">',"\n"; > echo $oDistribution->sName.'</a>',"\n"; > @@ -393,6 +410,20 @@ > } > > echo '</table>',"\n"; > + > + if(mysql_num_rows($hResult) >= 5 AND !is_string($showAll)) { > + echo '<form method=get action="'.$PHP_SELF.'">'; > + echo '<input name="versionId" type=hidden value="',$iVersionId,'" > />'; > + echo '<input class="button" name="showAll" type=submit value="Show > All Tests" />'; > + echo '</form>'; > + } > + if(is_string($showAll)) { > + echo '<form method=get action="'.$PHP_SELF.'">'; > + echo '<input name="versionId" type=hidden value="',$iVersionId,'" > />'; > + echo '<input class="button" name="hideAll" type=submit > value="Limit to 5 Tests" />'; > + echo '</form>'; > + unset($showAll); > + } > The common code should be factored out of these conditionals. The only line that differs appears to be the one that generates the form button. Oh, and can you attach the patch to the email? It came through as inlined here which makes it difficult to save to a file, although maybe I just don't know what I'm doing with kmail. Chris

1 0

Re: DINPUT: Enforce single mouse acquire
by Dmitry Timoshkov 26 Jan '06

26 Jan '06

On Wed, 2006-01-25 at 17:32 -0500, Alex Villacís Lasso wrote: > + if (This == NULL) { > + ERR("mouse hook called with no current lock!\n"); > + return 0; > + } > + > if (code != HC_ACTION) return CallNextHookEx( This->hook, code, wparam, lparam ); You need to call CallNextHookEx in any case, otherwise it might break other hooks in the chain. Probably just add a check for This being NULL in the same place as the code checks for HC_ACTION. -- Dmitry.

2 6

Re: HW address w/o connection in iphlpapi
by Michael Ost 25 Jan '06

25 Jan '06

> Hi Michael, > >> When you boot a linux box without an ethernet connection, and eth0 >> configuration fails, GetAdaptersInfo does not return MAC address info >> for eth0. >> The problem seems to be that enumerateInterfaces (in >> dlls/iphlpapi/ifenum.c) doesn't create a record for eth0, because >> SIOCGIFCONF doesn't return one. > > Mmm. Yeah, I think an alternative to SIOCGIFCONF might be the thing. Wait. This works better than getifaddrs. It successfully returns info for "down" devices on my RH8 based linux box, with my creaky old wine-20050419. get_ifaddrs makes the same calls that you were, in its implementation. So it has the same problem. But it's alot easier to program with than the ioctl you used. You made comments in the source about if_indextoname having issues. So perhaps this patch won't be useful to you. But it works for us, so I'll apply it to our wine sources unless/until something better comes along. Have at it! Cheers... mo

3 10

commdlg patch
by Turkin, Andrey 25 Jan '06

25 Jan '06

Hi! Here is quick&dirty (TM :) patch (against wine-0.9.6) that changes explorer-like Open/Save file dialogs to be more 3.11-like dialog/Windows compatible: 1) set view window control id to 1121 2) set inner list window control id to 1 instead of 2000 (anyone know why 2000 was chosen?) This patch is really not very good because of my 1) implementation, but it fixes Macromedia Director cast import! I've done 1) by placing SetWindowLong(hwndView,GWLP_ID, lst2) after each IShellBrowser_BrowseObject call. Better approach is to set view vindow's control id inside of IShellBrowser_BrowseObject but I don't sure if it safe. Regards, Andrey Turkin. diff -cr wine-0.9.6/dlls/commdlg/filedlg.c wine-0.9.6p/dlls/commdlg/filedlg.c *** wine-0.9.6/dlls/commdlg/filedlg.c 2006-01-19 17:13:54.000000000 +0300 --- wine-0.9.6p/dlls/commdlg/filedlg.c 2006-01-25 19:37:26.000000000 +0300 *************** *** 1486,1491 **** --- 1486,1492 ---- /* Browse to the initial directory */ IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser,pidlItemId, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); /* Free pidlItem memory */ COMDLG32_SHFree(pidlItemId); *************** *** 1997,2002 **** --- 1998,2004 ---- if( ! COMDLG32_PIDL_ILIsEqual(pidlCurrent, fodInfos->ShellInfos.pidlAbsCurrent)) { IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, pidlCurrent, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); } else if( nOpenAction == ONOPEN_SEARCH ) { *************** *** 2260,2265 **** --- 2262,2268 ---- NULL, SBSP_PARENT))) { + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); return TRUE; } *************** *** 2282,2287 **** --- 2285,2291 ---- SHGetSpecialFolderLocation(0,CSIDL_DESKTOP,&pidl); hres = IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, pidl, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); COMDLG32_SHFree(pidl); return SUCCEEDED(hres); *************** *** 2758,2763 **** --- 2762,2768 ---- tmpFolder->pidlItem, SBSP_ABSOLUTE))) { + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); return TRUE; } *************** *** 3435,3440 **** --- 3440,3446 ---- ' ','n','o','t',' ','e','x','i','s','t',0}; MessageBoxW( hwnd, notexist, fodInfos->title, MB_OK | MB_ICONEXCLAMATION ); } + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); bBrowseSelFolder = TRUE; SendCustomDlgNotificationMessage(hwnd,CDN_FOLDERCHANGE); } diff -cr wine-0.9.6/dlls/shell32/shlview.c wine-0.9.6p/dlls/shell32/shlview.c *** wine-0.9.6/dlls/shell32/shlview.c 2006-01-19 17:14:17.000000000 +0300 --- wine-0.9.6p/dlls/shell32/shlview.c 2006-01-25 19:37:45.000000000 +0300 *************** *** 146,152 **** #define IDM_VIEW_IDW (FCIDM_SHVIEWFIRST + 0x501) #define IDM_MYFILEITEM (FCIDM_SHVIEWFIRST + 0x502) ! #define ID_LISTVIEW 2000 #define SHV_CHANGE_NOTIFY WM_USER + 0x1111 --- 146,152 ---- #define IDM_VIEW_IDW (FCIDM_SHVIEWFIRST + 0x501) #define IDM_MYFILEITEM (FCIDM_SHVIEWFIRST + 0x502) ! #define ID_LISTVIEW 1 #define SHV_CHANGE_NOTIFY WM_USER + 0x1111

1 0

Fwd: Re: Fwd: MBR was destroyed
by Oliver Stieber 25 Jan '06

25 Jan '06

> On Sun, Nov 20, 2005 at 05:30:39PM +0100, seorge wrote: > > Hi, > > > > Since I'm not a developerr and therefore can't take part in any discussion > > here may I ask you to discuss the bug I reported, because Dustin Navea asked > > me to join this list. Or if nobody really need my presence here, please let > > me know and I will unsubscribe. > > If you run WINE only as user (not as root) this just cannot happen. > > Did you run WINE as root? I've just tried at it appears to have wiped my MBR logged in as a normal User in wheel group. If this is the problem then I purchsed a new drive because of it last month. Oliver. > > Ciao, Marcus > > > > > > > ___________________________________________________________ > Yahoo! Model Search 2005 - Find the next catwalk superstars - > http://uk.news.yahoo.com/hot/model-search/ > ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

11 21

Can't compile with vc7: oleauto.h(229) : error C2719: 'function-parameter': formal parameter with __declspec(align('8')) won't be aligned
by Dan Kegel 25 Jan '06

25 Jan '06

A UCLA student trying to compile wine conformance tests on Windows ran into this: > [Compiling wine tests with VC7 or > the server 2003 sdk gets] this error when compiling. > > ..\..\..\include\oleauto.h(229) : error C2719: 'function-parameter': > formal parameter with __declspec(align('8')) won't be aligned (See http://msdn2.microsoft.com/en-us/library/373ak2y1.aspx ) Examining oleauto.h line 229, I saw the bad parameter was of type DOUBLE. I then went looking for the typedef for DOUBLE: ~/wine/include$ grep 'typedef.*DOUBLE' *.h The interesting hit was: wtypes.h:typedef double DECLSPEC_ALIGN(8) DOUBLE; The patch that introduced the change was http://www.winehq.com/hypermail/wine-cvs/2004/05/0027.html I told him to try replacing DOUBLE and DATE with double and date in the formal parameters in oleauto.h for now. Is that generally the right thing to do? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

CVS build error
by Peter Åstrand 25 Jan '06

25 Jan '06

I can't build the CVS version anymore, I get: gcc -g -O2 -o widl client.o hash.o header.o proxy.o server.o typegen.o typelib.o utils.o widl.o write_msft.o parser.tab.o lex.yy.o -L../../libs -lwpp -lwine_port -lfl ../../libs/libwpp.a(lex.yy.o)(.text+0x624): In function `_yy_dummy_uses_of_static_functions_b2f4_517d_02ff_b30c_3e5a_47d7_aaa3_3b5d_': /home/peter/wine/libs/wpp/lex.yy.c:3357: multiple definition of `_yy_dummy_uses_of_static_functions_b2f4_517d_02ff_b30c_3e5a_47d7_aaa3_3b5d_' lex.yy.o(.text+0x58c):/home/peter/wine/tools/widl/lex.yy.c:1796: first defined here collect2: ld returned 1 exit status make[2]: *** [widl] Error 1 make[2]: Leaving directory `/home/peter/wine/tools/widl' Any ideas? -- Peter Åstrand ThinLinc Chief Developer Cendio www.cendio.se Teknikringen 3 583 30 Linköping Phone: +46-13-21 46 00

2 1

Re: d3d8: CreateDevice should try the parent if the current window fails
by H. Verbeet 25 Jan '06

25 Jan '06

On 24/01/06, Jan Zerebecki <jan.wine(a)zerebecki.de> wrote: > Changelog: > d3d8: CreateDevice should try the parent if the current window fails > because it doesn't have the property __wine_x11_whole_window . > Fixes bug #4341 . Does that happen in wined3d as well? If so, it's probably usefull to fix wined3d as well, considering the idea is to make d3d8 use wined3d eventually.

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2006