wine-devel March 2006

wine-devel@winehq.org

172 participants
291 discussions

Re: WineD3D Opengl 2.x compile fix
by H. Verbeet 02 Mar '06

02 Mar '06

On 02/03/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: >+ if(WINE_GL_VERSION_MAJOR(gl_info->gl_version) == 2) { Shouldn't that be >= 2? It seems unlikely functionality would get removed in later OpenGL versions.

1 0

Re: [PATCH 3/3] [Dnsapi.dll] Tests
by Steven Edwards 02 Mar '06

02 Mar '06

Hi, Just a matter of style to save moving the code around later if we add more tests. +START_TEST(names) +{ + HMODULE hdnsapi = LoadLibrary("dnsapi.dll"); + char *testname1 = ".bob"; + char *testname2 = ".bOb"; + + trace("Dnsapi.dll is only on Win2k and above.\nChecking...\n"); + if(hdnsapi != NULL) + { + trace("Dnsapi.dll loaded.\nNow unloading...\n"); + FreeLibrary(hdnsapi); + } + else + { + trace("Dnsapi.dll was not loaded or failed to be unloaded.\n"); + return; + } Why don't you break this out in to a function like load_dnsapi() that way if there are missing symbols from one version to another you can use GetProcAddress and delay load them and it will all be contained in one function. + trace("Now testing function: DnsNameCompare_A(LPSTR, LPSTR)\n"); + ok(DnsNameCompare_A(testname1,testname2)==TRUE, + "Comparison failed!\n %s and %s should be equal!\n",testname1,testname2); + trace("%s and %s are equal.\n",testname1,testname2); Also it would be a good idea to break this out in to another function. I tend to do one function per API I am checking so I would stick all of this in to a function called test_DnsNameCompare(); +} Nice work btw. Thanks for being patent with submitting patches and tests. I am not really that great of a programmer and these type of style changes help me follow along and write better tests. Take a look at this test I wrote to get the idea http://cvs.winehq.org/cvsweb/wine/dlls/setupapi/tests/stringtable.c?rev=1.2… It tends to be more lines but I think its much clearer to read. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 1

New d3d8 code and FFXIBench3 - pretty good!
by Al Tobey 02 Mar '06

02 Mar '06

I just tried the new d3d8 code with FFXiBench3 again tonight and it's pretty good! The textures are mostly there and there are only a handful of recurring glitches. This demo is downloadable from http://www.playonline.com. Some textures had their colors munged up. I assume this is related to earlier discussions about RGB_ v.s. BGR_ formats. Screenshots: http://img238.imageshack.us/img238/9879/screenshot28hh.jpg http://img48.imageshack.us/img48/4135/screenshot35wa.jpg http://img48.imageshack.us/img48/28/screenshot48xx.jpg I got a lot of these two messages: fixme:d3d_surface:IWineD3DSurfaceImpl_UnlockRect unsupported unlocking to Rendering surface surf@0x7d388550 usage(1) fixme:d3d:IWineD3DDeviceImpl_CopyRects Wanted to copy partial surfaces not implemented, returning D3DERR_INVALIDCALL I'll play around with my CopyRects patch a bit and see if I can get it to work properly then submit it. I'm not convinced MSDN is telling the whole truth about how partial copies should work. Keep up the good work! -Al Tobey

5 12

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll
by Rolf Kalbermatter 02 Mar '06

02 Mar '06

Mike McCormack [mike(a)codeweavers.com] wrote: >> + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); >> + return ERROR_CALL_NOT_IMPLEMENTED; >> +} > >You SetLastError or return an error code, not both. This is not always correct. Win32 API has several functions returning an int where the only SDK documentation is that the function returns 0 on success and anything else on failure. What those usually seem to do is retuning the (internal) error code. Relying on such a return value being anything than 0 or !0 of course would be bad programming, since there will be potential differences between different platforms but it does happen. Rolf Kalbermatter

1 0

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll
by Mike McCormack 02 Mar '06

02 Mar '06

Also, please disable your challenge/response spam "filter". Solving your spam problem by spamming everybody else is not cool. You wrote to us with a patch, you solicited our response, so why are you spamming us back? I'd advise others to not respond to spam from bluebottle.com. Mike

1 0

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll
by Dmitry Timoshkov 02 Mar '06

02 Mar '06

"MattK" <mekjedi(a)bluebottle.com> wrote: > + if(fdwReason == DLL_THREAD_ATTACH) > + { > + DisableThreadLibraryCalls(hinstDLL); > + return TRUE; > + } This is not an appropriate place to call DisableThreadLibraryCalls, how did you come with it when there are a lot of examples in the Wine tree? -- Dmitry.

1 0

Re: x11drv fix for bug#4506: page fault on read access
by Alexandre Julliard 02 Mar '06

02 Mar '06

Rein Klazes <wijn(a)wanadoo.nl> writes: > Fixing bug #4506: unaligned 32bit access, can access one byte beyond the > pixel buffer. > > Changelog: > dlls/x11drv : dib_convert.c > Avoid unaligned 32 bit reads, and reads beyond the input pixel buffer in > the convert_888_to_0888_* functions. This will badly hurt performance, you don't want to check alignment on every pixel. You should only check on the first one and copy 1 to 3 pixels as needed to align things properly, then do the 4 pixels at a time thing. -- Alexandre Julliard julliard(a)winehq.org

3 2

[wined3d] glStencilOpSeparate & glStencilFuncSeparate symbol errors
by Aric Cyr 02 Mar '06

02 Mar '06

The recent patch: http://winehq.org/pipermail/wine-patches/2006-February/024656.html can cause linker errors for the two symbols glStencilOpSeparate and glStencilFuncSeparate. The reason being that these are only exported in OpenGL 2.0 compatible libraries, and in particular, are not present in ATI's binary driver. This causes wined3d to fail to build (compiles fine but linking fails). I suspect that Vitaly is already working on fixing this, but thought I'd mention it anyways since other might run into the same problem. Cheers, Aric

1 0

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll
by Mike McCormack 02 Mar '06

02 Mar '06

MattK wrote: > +BOOL WINAPI DnsNameCompare_A(LPSTR pName1, LPSTR pName2) > +{ > + TRACE("(%s %s)\n",pName1, pName2); > + > + LPSTR name1 = pName1; > + LPSTR name2 = pName2; > + > + RemovePeriods(name1); > + RemovePeriods(name2); > + > + int equal; > + > + equal = lstrcmpiA(name1,name2); > + > + return !equal; > +} This is still not correct. You can't modify name1, and name2 in place. You shouldn't use inline declarations (ie. the "int equal" should be after the bracket.) There's also no in assigning pName1 to name1, it doesn't make a copy of the string as you suspect, it makes a copy of the pointer to the string. > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} You SetLastError or return an error code, not both. > diff -Nu dlls/dnsapi/utils.c dlls/dnsapi/utils.c There's no need to make a seperate file for this. > +LPSTR RemovePeriods(LPSTR string) > +{ > + if(string == NULL) > + return NULL; > + DWORD d = 0; > + > + while(string[d] == '.') > + { > + string--; > + } > + > + return string; > +} This won't work at all... If you wrote some better test cases you would discover these problems. How about testing: DnsNameCompare_A(NULL, NULL) DnsNameCompare_A("", ".") DnsNameCompare_A("..........", "..........") DnsNameCompare_A(".a.b.c.d.e.", "abcde") DnsNameCompare_A("a.com.","a.com") DnsNameCompare_A("A.com", "a.com") DnsNameCompare_A(".A.com", "a.com") DnsNameCompare_A("Acom", "acom") etc. Mike

1 0

Re: wined3d: Fix compile for older OpenGL headers.
by H. Verbeet 01 Mar '06

01 Mar '06

Although #ifdef GL_VERSION_2_0 will make compilation work with older OpenGl headers, it's not the way to fix this. Basically, wined3d should check for functionallity during runtime with GL_SUPPORT and call extensions with GL_EXTCALL. The issue has come up a few times before with patches from the same author, and I think he should be aware of the issue by now.

3 3

Re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to
by Vitaly Lipatov 01 Mar '06

01 Mar '06

We need a --disable-rpath option in configure for rpath disable. Rpaths is not useful when WINE building for distribution. Will I add --disable-rpath of there is a better suggestion? В сообщении от 20 февраля 2006 14:40 Alexandre Julliard написал(a): ... > configure: Use --rpath if supported when building binaries to point to > the relative location of the wine libraries. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

4 11

Re: [PATCH 1/4] [WineDbg]: main_loop
by Alexandre Julliard 01 Mar '06

01 Mar '06

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > - split dbg_main_loop in two parts (one for finishing the debuggee > attachment, the second one really for handling the main loop) > - removed now longer needed dbg_main_loop Auto mode is still broken with this patch... did you really test it? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wined3d: Implemented WINED3DRS_DEPTHBIAS
by H. Verbeet 01 Mar '06

01 Mar '06

On 01/03/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > + glPolygonOffset(*((float*)&This->stateBlock->renderState[WINED3DRS_SLOPESCALEDEPTHBIAS]), tmpvalue.f); Does this compile?

1 0

Re: wined3d: Add function pointers to glSupportOpSeparate and glSupportFuncSeparate
by H. Verbeet 01 Mar '06

01 Mar '06

On 01/03/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > wined3d: Add function pointers to glSupportOpSeparate and > glSupportFuncSeparate > That's not going to help much if you don't actually use them. Also, you probably want to be able to detect if the functions are actually available, instead of just dereferencing a NULL pointer if they aren't.

1 0

Re: riched20: EM_AUTOURLDETECT/EM_GETAUTOURLDETECT implementation
by Alexandre Julliard 01 Mar '06

01 Mar '06

Brandon Woodmansee <bwood(a)ucla.edu> writes: > + case EM_AUTOURLDETECT: > + { > + if (wParam==1) > + { > + editor->AutoURLDetect_bEnable=1; > + return 0; > + } > + > + if (wParam==0) > + { > + editor->AutoURLDetect_bEnable=0; > + return 0; > + } > + return E_INVALIDARG; E_INVALIDARG is a pretty strange return value for a window procedure. Do you have a test case for that? -- Alexandre Julliard julliard(a)winehq.org

1 0

libxml2 use in Wine?
by Gerald Pfeifer 01 Mar '06

01 Mar '06

A user reported that when he has libxml2 installed when building Wine, "some apps" work fine whereas without libxml2 he get's warning and errors and reduce functionality. And indeed the configure code and some other part of Wine do refer to libxml2. However, there is now documentation (as verified via `grep -ri libxml2`) that mentions libxml2 in any way. Is there any specific reason, or is this just an omission, and a patch to wine/README would be welcome? Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel March 2006