wine-devel April 2006

wine-devel@winehq.org

176 participants
334 discussions

Re: regedit, wordpad hungarian translation (try 2)
by James Hawkins 17 Apr '06

17 Apr '06

On 4/17/06, Kovács András <andras(a)csevego.net> wrote: > Hi, I splitted the last patch. This is a hungarian translation patch of > regedit, and wordpad. Best regards, Andras > Check out http://winehq.org/site/sending_patches. Only send one patch per email. -- James Hawkins

1 0

WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.
by Tomas Carnecky 17 Apr '06

17 Apr '06

These circumstances being if it tries to load an invalid lua file, more specifically a lua file which contains the invalid lua string (not character!) "\342\200\260". I don't know what this function does and there isn't a TRACE() in that function, so could someone please review if the function is implemented correctly (wrt the above char sequence) or give me more informations about the arguments so I could add a TRACE() to see what WoW passes to it? thanks tom

3 8

Re: [update] Add test for long float numbers in msvcrt printf test suite
by Jesse Allen 17 Apr '06

17 Apr '06

On 4/17/06, Tomas Carnecky <tom(a)dbservice.com> wrote: > Changelog: > - Add test for long float numbers in msvcrt snprintf test suite > > update: snprintf() doesn't print the exact same number because it's a > double. > > together with my patch that is available in wine-devel wine passes the > msvcrt tests. > > tom > > > > > > > This test fails on Windows 2003.

1 0

Re: winebrowser: Use user's preferred browser
by Jeremy White 17 Apr '06

17 Apr '06

> + "kfmclient exec,gnome-open,kmail,mozilla-thunderbird,thunderbird,evolution"; A Gnome user will be offended if you spool up the entire KDE environment just to launch a URL; a KDE user will be similarly offended by gnome-open. Further, if I'm a Gnome user, I may have KDE on my system, and kfmclient exec may work, but it's likely to not be the browser I *really* want used. The standard that's developing is that you don't invoke a KDE program unless KDE_FULL_DESKTOP is set and you … [View More]

5 5

Re: winspool/tests: fix broken test for GetPrinterDriver
by Dmitry Timoshkov 17 Apr '06

17 Apr '06

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > @@ -939,36 +939,36 @@ static void test_GetPrinterDriver(void) > > for (level = -1; level <= 7; level++) > { > - SetLastError(0xdeadbeef); > + SetLastError(MAGIC_DEAD); Please don't change this, stick to the style used everywhere else, i.e. use 0xdeadbeef directly. > needed = (DWORD)-1; > ret = GetPrinterDriver(hprn, NULL, level, NULL, 0, &needed); > - ok(… [View More]!ret, "level %d: GetPrinterDriver should fail\n", level); > - if (level >= 1 && level <= 6) > - { > - ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "wrong error %ld\n", GetLastError()); > - ok(needed > 0,"not expected needed buffer size %ld\n", needed); > - } > - else > - { > - ok(GetLastError() == ERROR_INVALID_LEVEL, "wrong error %ld\n", GetLastError()); > - ok(needed == (DWORD)-1,"not expected needed buffer size %ld\n", needed); > - continue; > - } > + ok(!ret && ((GetLastError() == ERROR_INVALID_LEVEL) || > + (GetLastError() == ERROR_INSUFFICIENT_BUFFER) || > + (GetLastError() == ERROR_OUTOFMEMORY)), "%d: returned %d with %ld " \ > + "(expected '0' with: ERROR_INVALID_LEVEL, ERROR_INSUFFICIENT_BUFFER" \ > + "or ERROR_OUTOFMEMORY)\n", level, ret, GetLastError()); > + > + if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) continue; > + > + ok(needed > 0,"%d: returned size %ld\n", level, needed); > + if (needed == 0) continue; I object to this change. The test needs a clear indication whether it's an invalid or a not supported parameter. Do not remove if {} else {}, that's an essential part of the test. A comment explaining the change would be also nice. > ret = GetPrinterDriver(hprn, NULL, level, buf, needed, &filled); > - ok(ret, "level %d: GetPrinterDriver error %ld\n", level, GetLastError()); > - ok(needed == filled, "needed %ld != filled %ld\n", needed, filled); > + ok( ret, "%d: returned %d with %ld (expected '!= 0')\n", > + level, ret, GetLastError()); "expected '!= 0'" is wrong, ret is BOOL, so "expected TRUE" or better leave it as it is now, error message already implies that the API has failed. > - ok(di_2->cVersion >= 0 && di_2->cVersion <= 3, "di_2->cVersion = %ld\n", di_2->cVersion); > + ok((di_2->cVersion >= 0 && di_2->cVersion <= 3) || > + (di_2->cVersion == 0x0400), "di_2->cVersion = %ld\n", di_2->cVersion); A comment explaining which windows version returns 0x400 (which contradicts MSDN) would be helpful. > ok(di_2->pName != NULL, "not expected NULL ptr\n"); > ok(di_2->pEnvironment != NULL, "not expected NULL ptr\n"); > ok(di_2->pDriverPath != NULL, "not expected NULL ptr\n"); > @@ -977,15 +977,15 @@ static void test_GetPrinterDriver(void) > > trace("cVersion %ld\n", di_2->cVersion); > trace("pName %s\n", di_2->pName); > - calculated += strlen(di_2->pName) + 1; > + calculated += lstrlenA(di_2->pName) + 1; If you want to replace strlen by lstrlenA (why?) that should be a separate patch. Same for below changes. -- Dmitry. [View Less]

1 0

Solaris: Rundll322 exercising
by Robert Lunnon 16 Apr '06

16 Apr '06

I would like to exercise rundll32 or similar (IE accessing a unix lib via the link in in .wine). This didn't work before because LD.SO refused to load a lib via a link with a colon in it's name. I wrote some code to fix it, but now process.c has been rearranged and the patch doesn't apply. It may well be that the new code works now but I need to test.

1 0

Re: abort if WINEDEBUG requests functionality that was disabled at configure time
by Mike Hearn 16 Apr '06

16 Apr '06

On Sat, 15 Apr 2006 23:37:17 -0400, Mike Frysinger wrote: > if wine is built with --disable-trace or --disable-debug, then using WINEDEBUG > will accept the respective options without complaining and without actually > showing any useful information Why would anybody build without tracing anyway? I would be *very* surprised if it led to any noticable/real world performance improvement. Rather than do this why not just restore your packages configure switches to the upstream defaults?

5 7

Wine missing from repositories?
by Dee Ayy 16 Apr '06

16 Apr '06

1) I installed wine at work from kubunu breezy repositories (standard and maybe universe and multiverse repositories are added) on wednesday 4/12/2006, yet on thursday 4/13/2006 I installed ubuntu breezy at home and definitely had standard, universe, multiverse, and even the *deb http://wine.sourceforge.net/apt/ binary/* repository added, yet could not see wine available for installation. Is Wine missing from repositories? 2) I thought I might be able to build wine from source for my AMD64 … [View More]using the info on this page http://www.winehq.com/site/download-deb , but I seem to be getting a ubuntu compiler problem. But I am posting the error in case it is a winehq problem and this helps you (and attaching config.log): root@ubuntu:/home/user1/apt_sources# apt-get --build source wine Reading package lists... Done Building dependency tree... Done Need to get 13.6MB of source archives. Get:1 http://wine.sourceforge.net source/ wine 0.9.11~winehq1-1 (dsc) [1209B] Get:2 http://wine.sourceforge.net source/ wine 0.9.11~winehq1-1 (tar) [ 13.5MB] Get:3 http://wine.sourceforge.net source/ wine 0.9.11~winehq1-1 (diff) [ 47.1kB] Fetched 3B in 0s (4B/s) Skipping unpack of already unpacked source in wine-0.9.11~winehq1 dpkg-buildpackage: source package is wine dpkg-buildpackage: source version is 0.9.11~winehq1-1 dpkg-buildpackage: source changed by Scott Ritchie <scott(a)open-vote.org> dpkg-buildpackage: host architecture amd64 debian/rules clean dh_testdir dh_testroot rm -f build-stamp # Add here commands to clean up after the build process. /usr/bin/make distclean make[1]: Entering directory `/home/user1/apt_sources/wine-0.9.11~winehq1' make[1]: *** No rule to make target `distclean'. Stop. make[1]: Leaving directory `/home/user1/apt_sources/wine-0.9.11~winehq1' make: [clean] Error 2 (ignored) #-/usr/bin/make -C documentation clean dh_clean debian/rules build dh_testdir # Add here commands to configure the package. CFLAGS="-Wall -g -O2" ./configure --host=x86_64-linux-gnu --build=x86_64-linux-gnu --prefix=/usr --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info checking build system type... x86_64-pc-linux-gnu checking host system type... x86_64-pc-linux-gnu checking whether make sets $(MAKE)... yes checking for x86_64-linux-gnu-gcc... gcc -m32 checking for C compiler default output file name... configure: error: C compiler cannot create executables See `config.log' for more details. make: *** [config.status] Error 77 Build command 'cd wine-0.9.11~winehq1 && dpkg-buildpackage -b -uc' failed. E: Child process failed Please advise. ** [View Less]

2 1

GPG test - ignore
by Stefan Dösinger 15 Apr '06

15 Apr '06

I wonder why the gpg signatures of the mails I send to wine-patches are wrong when I receive them back, but not wine-devel. Trying to send a mail with a small attachment to here to test. I appologise for the spam. Stefan

1 0

Re: advpack: Perform install initialization in install_init
by James Hawkins 15 Apr '06

15 Apr '06

On 4/13/06, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > Changelog: > * Add a structure to track the data for an install instance. > * Add install_init/release to perform install initialization. > Go ahead and trash all these advpack patches. There are a couple bugs, and some things I'm changing. I'll send the new patches next week. -- James Hawkins

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
34
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2006