wine-devel November 2007

wine-devel@winehq.org

117 participants
275 discussions

re: dlls/msi/streams.c -- simplify and constify
by Dan Kegel 03 Nov '07

03 Nov '07

James wrote: > This change is wrong. If you'd actually read what the code intended > to do instead of just fixing warnings, you'd see that > add_streams_to_table returns -1 on error. Yeah, Gerald, I was getting the feeling reading your patches that you were being too glib about rewriting code based simply on looking at signedness issues. Please be more careful. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: [PATCH 1/7] advapi32: Implement CredWriteW.
by Detlef Riekenberg 03 Nov '07

03 Nov '07

On Di, 2007-10-30 at 12:36 +0000, Robert Shearman wrote: > +static DWORD open_cred_mgr_key(HKEY *hkey, BOOL open_for_write) > +{ > + return RegCreateKeyExW(HKEY_CURRENT_USER, > wszCredentialManagerKey, 0, > + NULL, REG_OPTION_NON_VOLATILE, > + KEY_READ | KEY_WRITE, NULL, hkey, NULL); > +} > + What's the reason of the Parameter "BOOL open_for_write" ? open_cred_mgr_key is called with (..., TRUE) and (..., FALSE), but you always use "KEY_READ | KEY_WRITE". On the other hand, gcc does not warn about that unused Parameter. My first Idea was the optimizer in gcc, but removing "-O2" does not give us a warning. With "-pedantic", we lost (but still no warning for "open_for_write"). -- By by ... Detlef

2 2

Re: msxml - Fix Memory Leak
by Vitaliy Margolen 03 Nov '07

03 Nov '07

Not really. Now it's an attachment of "application/octet-stream" type. Not plain/text. Try renaming the file to *.patch.txt. Vitaliy. Alistair Leslie-Hughes wrote: > Hi Vitaliy, > > Thanks for the information, I though I had fixed my News client. > > Does this work better? Ill forward to the patch list if this works. > > Best Regards > Alistair > > > > > 00 > > From: wine-devel(a)kievinfo.com > > To: wine-devel(a)winehq.org > > CC: leslie_alistair(a)hotmail.com > > Subject: Re: msxml - Fix Memory Leak > > > > Alistair Leslie-Hughes wrote: > > > Hi, > > > > > > Changelog: > > > Fixed memory leak > > > > > > > > > Regards > > > Alistair Leslie-Hughes > > > > > > > > > begin 666 xmlelem.diff > > > > Please attach patches as a plain text. This patch is not an > attachment and > > is unreadable. > > > > Vitaliy. > >

1 0

re: USER32: win16 applications should not see long filenames returned from dialog control
by Dan Kegel 02 Nov '07

02 Nov '07

Alex wrote: > Legacy Win16 applications display file/directory selection listboxes and > expect to receive a short name from the control.... >The attached patch attempts to fix this >by converting the about-to-be-returned name to a short name if the expected >windows version is not at least Win95 How about converting to a short name in the win16 wrapper code instead?

1 0

Re: mshtml: Set IE version when installing wine gecko
by Jacek Caban 02 Nov '07

02 Nov '07

Hi Chris, This patch is already committed, but, I'm afraid, it's wrong. Setting these registries has nothing to do with installing Gecko. Setting them in Gecko installer will only make supporting it harder. We don't want to tell user to "run iexplore about:blank" to get an app working. I will send a better patch that always sets them. Last time Alexandre didn't accept such a patch, because of apps that need native IE and install it only when this key is not found. It looks like it's time for such change. Thanks, Jacek

4 8

Generic text printer driver
by Juan Luis Ramos 02 Nov '07

02 Nov '07

Hi all, is there anybody working in the generic text printer driver o raw printer driver? I've a problem with a compatible Epson POS printer so, I've modified the text.c code inside wineps.drv to send the text to the printer without postscript processing. The function that send the data is PSDRV_ExtTextOut, but the LPCWSTR parameter passed (str) doesn't contain the ESCAPE codes sent to the printer. I don't find when does the program call the PSDRV_ExtTextOut function. Can anybody help me? Thanks.

2 1

Re: [PATCH 07/18] inetcomm: Add an implementation of an SMTP transport.
by Juan Lang 02 Nov '07

02 Nov '07

Hi Rob, + const char szHostName[] = "roblaptop"; /* FIXME */ Did you mean to leave that in? --Juan

3 2

Re: Fix type of loop variable in alloc_device().
by Vitaliy Margolen 02 Nov '07

02 Nov '07

Gerald Pfeifer wrote: > We iterate between 0 and and the value of an usigned variable, so we > should adjust the loop variable accordingly (not the list to silence > GCC). > - int i; > + unsigned i; If there is nothing wrong about it, then why do you change it? If even gcc does not complain about it. Vitaliy.

2 1

Re: [Bug 10266] Numpad keyboard handling is strange, Del key produces two events
by Peter Åstrand 02 Nov '07

02 Nov '07

Perhaps we need to gather more input from other developers: > http://bugs.winehq.org/show_bug.cgi?id=10266 > > --- Comment #4 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2007-11-01 08:32:46 --- > > But in that case, you will find all of your X11 applications on your desktop, > > including Firefox etc, confusing as well? > > Yes, and this behaviour is very annoying and not consistent IMO. Let's break down this statement into two: 1) "Not consistent" It might be interesting to compare with CapsLock. Shift can cancel CapsLock, but also substitute it. This is true on both Windows and Linux. Additionally, on Linux, NumLock works the same, ie Shift works in both directions. On Windows, however, Shift can only cancel NumLock, not substitute it. Regardless of whether users actually finds this useful or not, I think it's hard to argue for that this is "logical" or "consistent". 2) "Annoying" Can it be that you have a Windows background and are therefore used to the Windows behaviour? I haven't actually asked any users yet, but my general opinion is that all applications on the same desktop should behave the same, if possible. We are decorating the Windows windows with the normal window manager decorations etc so I think it's reasonable that the keyboard should behave according to the native system model. Another thing to keep in mind is that most users actually never use the numpad keys in conjunction with Shift. I know this from several years of experience of keyboard hacking - there have been plenty of bugs in many softwares in this area but very few actual bug reports. > Besides, I just tested with Wine's notepad and don't see the problem you > are reporting. Which keyboard layout are you using? On my system, Wine selects the Swedish keyboard layout. Regards, --- Peter Åstrand ThinLinc Chief Developer Cendio AB http://www.cendio.se Wallenbergs gata 4 583 30 Linköping Phone: +46-13-21 46 00 ThinLinc User Group 2007 Höstkonferens --- 15-16 november, Linköping. Program och anmälan: http://www.thinlincusergroup.se/aktiviteter

2 5

Re: [PATCH 04/18] inetcomm: Add self-registration code.
by Paul Vriens 02 Nov '07

02 Nov '07

Robert Shearman wrote: > --- +static LONG recursive_delete_key(HKEY key); +static LONG recursive_delete_keyA(HKEY base, char const *name); +static LONG recursive_delete_keyW(HKEY base, WCHAR const *name); We just got rid of all the self build recursive delete ones. Can you use RegDeleteTree[AW] (or is there a specific reason not to)? -- Cheers, Paul.

3 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel November 2007