wine-devel December 2007

wine-devel@winehq.org

139 participants
264 discussions

Re: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 (RESEND)
by Steven Edwards 05 Dec '07

05 Dec '07

Hello, On Dec 4, 2007 7:34 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > Since Alexandre has asked me to take care of overflow in some other > context, I figured I could ping this underflow patch in return. ;-) > > Gerald > > ---------- Forwarded message ---------- > From: Gerald Pfeifer <gerald(a)pfeifer.com> > To: <wine-patches(a)winehq.org>, Damjan Jovanovic <damjan.jov(a)gmail.com> > Date: Thu, 22 Nov 2007 22:32:08 +0100 (CET) > Subject: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 > > I believe revision 1.30 of dlls/icmp/icmp_main.c > > date: 2006-11-06 11:51:07 +0000; author: julliard; state: Exp; lines: +10 -15; > Damjan Jovanovic <damjan.jov(a)gmail.com> > icmp: Changed select to poll. Could we just revert this patch? I think poll is not a valid api on win32 so this breaks the windows port. I don't really see the need in this change here in the first place. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

dib engine
by Piotr Maceluch 04 Dec '07

04 Dec '07

Hi, what's the status of DIB engine (or where can one read about it)? Are the up-to-date sources still available? What kind of help would be needed? Thanks Peter Maceluch -- -----------=== F O R P S I ===----------- Profesjonalne uslugi, rewelacyjne ceny Sprawdz nas - nowa oferta !! Twoja strona w sieci - od 2 zl http://www.forpsi.pl -----------------------------------------

2 1

Re: dlls/wined3d/state.c -- fix error handling
by Stefan Dösinger 04 Dec '07

04 Dec '07

Am Dienstag, 4. Dezember 2007 01:34:55 schrieb Gerald Pfeifer: > This looks like a mistaken consistency check. The code where mapped_stage > is set looks as follows: > > DWORD mapped_stage = stateblock->wineD3DDevice->texUnitMap[texUnit]; > > and at other places we do check for -1, so this looks like another bug > in error handling. In fact the texUnitMap entries are never set to any value < 0 other than -1, so it doesn't make much difference, but for the sake of consistency we should check for -1 here as well

1 0

Re: ntdll: detach modules based on inter-module dependencies (try 2)
by Alexandre Julliard 04 Dec '07

04 Dec '07

"Lei Zhang" <thestig(a)google.com> writes: > This patch changes how process_detach() works when called with > bForceDetach set to TRUE. A module would get detached when that module > has no dependencies. After a module gets detached, process_detach() > scans through all the modules and update their dependencies. I'm > assuming there's no circular dependencies between modules. You can't assume that, some modules do have circular dependencies. My suspicion is that this bug should be fixed in winmm, but either way you'll need to show some test cases. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [AppDB] Change licence to AGPL
by Trent Waddington 03 Dec '07

03 Dec '07

interesting. Do you have a list of contributors and their signoff on this license change? Or is it just you two? On Nov 24, 2007 12:36 PM, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > Change licence to AGPL > > > > Alexander N. Sørnes > > > >

6 7

re: kernel32:add ReadFileScatter
by Dan Kegel 03 Dec '07

03 Dec '07

Hey Louis, Focht is using a pseudonym, and I believe it's Wine policy to not accept patches without real names. His patches should be used as guides only, and should not be reposted to wine-patches, until such time as he decloaks. If he doesn't want to decloak, I think we can't use his patches. I rather wish he would avoid attach patches to bugs, as it tempts people into submitting them as you have done, which is a waste of effort given Wine's policy. But I greatly value his ability to describe where and how Wine is wrong. - Dan

4 4

handle unimplemented function stubs
by nessi＠nessi-online.de 03 Dec '07

03 Dec '07

Hello all, I'm a Windows software developer and I'm trying to execute an application under the wine environment. Now I have a problem introduced with wine 0.9.49. I use the function RegOverridePredefKey from the advapi32.dll. To be compatible with older windows versions, I use the following code: LONG WINAPI (*RegOverridePredefKey)(HKEY hKey, HKEY hNewHKey); HMODULE hMod=GetModuleHandle("Advapi32"); if (hMod) (FARPROC)RegOverridePredefKey=GetProcAddress(hMod,"RegOverridePredefKey"); if (RegOverridePredefKey) RegOverridePredefKey(HKEY_CLASSES_ROOT, hKey); In wine 0.9.49 a stub entry for this function was created, but the implementation is missing. The result is, that the GetProcAddress function is successful, but the RegOverridePredefKey call fails. I can catch the EXCEPTION_WINE_STUB exception (see code below), but the application will nevertheless closed. if (RegOverridePredefKey) { long err = ERROR_CALL_NOT_IMPLEMENTED; try { // test for C-based structured exceptions err=RegOverridePredefKey(HKEY_CLASSES_ROOT, hKey); } #define EXCEPTION_WINE_STUB 0x80000100 __except(GetExceptionCode()==EXCEPTION_WINE_STUB ? EXCEPTION_EXECUTE_HANDLER : EXCEPTION_CONTINUE_SEARCH) { RegOverridePredefKey=NULL; } } What can I do ? I know, that I can find a workaround for this case, but this in not my problem. How can I handle, in principle, such exceptions? What is the reason for creating a function stub without an implementation ??? Thanks Nessi

2 1

Re: rpcrt4: Handle all non-continuable exceptions in CStdStubBuffer_Invoke.
by Alexandre Julliard 03 Dec '07

03 Dec '07

Robert Shearman <rob(a)codeweavers.com> writes: > --- > dlls/rpcrt4/cstub.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > I have a test for this in my tree, which passes on Windows, but > doesn't pass in Wine yet until we have some more proxy/stub code that > I can use to call an object's methods (ideally IClassFactory). This doesn't work: ../../../tools/runtest -q -P wine -M rpcrt4.dll -T ../../.. -p rpcrt4_test.exe.so cstub.c && touch cstub.ok cstub.c:874: Test failed: ret c0000005 make[2]: *** [cstub.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)
by Alexandre Julliard 03 Dec '07

03 Dec '07

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > One of the really uncontested ones, I think. ;-) > > ---------- Forwarded message ---------- > From: Gerald Pfeifer <gerald(a)pfeifer.com> > To: <wine-patches(a)winehq.org> > Date: Thu, 1 Nov 2007 16:10:03 +0100 (CET) > Subject: Remove four useless checks in dlls/gdi32/enhmetafile.c > > The members of EMRCREATEDIBPATTERNBRUSHPT are of type DWORD, so > comparing them for >= 0 is a noop which always evaluates to true. > > Gerald > > ChangeLog: > Remove four unnecessary comparisions of DWORD variables for >= 0. Validating the record is not unnecessary, it just needs to be done correctly by checking for wraparounds etc. -- Alexandre Julliard julliard(a)winehq.org

2 6

kernel32:add ReadFileScatter
by luis.busquets＠ilidium.com 03 Dec '07

03 Dec '07

Just to add more clarity to the IPR of computer programs and if it is legal to decompile and implement a program again. In Europe, software is protected by Council Directive 91/250/EEC of 14 May 1991 on the legal protection of computer programs (http://eur-lex.europa.eu/LexUriServ/LexUriServ.do?uri=CELEX:31991L0250:EN:H…). There are a number of things that a software vendor cannot forbid. In particular article 6 speaks about decompilation. It can be done only if the information necessary to achieve interoperability has not previously been readily available (a.1.b) to achieve programs interoperable with the first one (a.1) but not to be used for the development, production or marketing of a computer program substantially similar in its expression (a. 6.2.c). It could be argued that wine is not replicating Windows as it is just the top API. Nevertherless, to avoid any legal problems, it is better to refrain from adding any patches obtained by decompilation.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel December 2007