March 2007 - wine-devel

Re: comctl32: register all the controls in DllMain (fixes bug #7641)
by Felix Nawothnig 15 Mar '07

15 Mar '07

Mikołaj Zalewski wrote: > comctl32 version 5.82 (at least the one that comes with a fully patched > Windows XP) and 6.0 register all the controls in DllMain. > InitCommonControlsEx is just a dummy function. Could it be that 6.0 only registers those controls listed using window class dependencies in the manifest file? If what you say about 5.82 is true your patch is correct though ofcourse. Felix

2 1

Help with debug
by Phil Lodwick 15 Mar '07

15 Mar '07

Hi, I have been debugging a problem today and am running low on batteries. I am hoping somebody can look at the attached snippet of log and point me in the right direction. >From what I can tell, there is a DLL called snoopy.dll that does a whole bunch of allocs and reallocs and then tries to reference a NULL pointer which causes an unhandled exception. The code goes through a loop and does not always crash on the same iteration, but it always seems to crash at the same address. This code does not crash on Windows. Just getting lucky? Unfortunately I do not have the sources to this code, so it makes life a little more difficult. Any good ideas for my next step in debugging? Thanks, Phil

2 1

Re: Submitting winetricks to winehq tree?
by Dan Kegel 15 Mar '07

15 Mar '07

Carl-Daniel wrote: > Sorry if this has been answered before, but is winetricks a newer > version of winetools? No. Winetricks (http://www.kegel.com/wine/winetricks ) is a single 11KB shell script. It's a tiny command line tool that only knows how to install Microsoft redistributable libraries (and fonts), and set a registry key or two. For instance, if you're trying to install or run an application, but it fails with "import_dll Library MSVBVM60.DLL not found", you can fix it with $ winetricks vbrun60 Or if you're trying to install an app, but it fails with "Sorry, this application requires IE6", you can fix it without really installing IE6 by setting the right registry key. Winetricks makes this easy; just do $ winetricks fakeie6 etc. etc. Essentially, Winetricks just automates things one would normally have to look up in the Wine wiki, and it does it in the simplest possible way. Winetools ( http://www.von-thadden.de/Joachim/WineTools/ ) can do some of that, but it's really a different beast. It's a set of 150 or so files with a fancy GUI. Each of the files is a recipe for installing a particular Windows application. It is aimed at people who just want to run apps and not understand things. It is bad because, instead of working to improve Wine to make apps easy to install, it papers over the problems. And then there's Wine-Doors ( http://www.wine-doors.org ), which is like Winetools with delusions of grandeur. They seem to want to reinvent apt-get for no particular reason, and as far as I can tell, they intend to have a central server from which you can download copies of e.g. Photoshop with it. This doesn't seem legal, offhand, but I can't find their mailing list archive to see if anyone has asked them about this fine point. IMHO both Winetools and Wine Doors are mostly harmful, but they do have a real benefit for users. Winetricks is a bit like the non-harmful 1% of Winetools. If we don't provide something like Winetricks, more people might be driven to Winetools, and it'd be nice to prevent that. - Dan

2 1

Re: [2/3] kernel32: GlobalMemoryStatusEx: return the size of physicalmemory + swapsize in ullTotalPageFile/ullAvailPageFile
by Dmitry Timoshkov 15 Mar '07

15 Mar '07

"Fabian Bieler" <der.fabe(a)gmx.net> wrote: > - /* Project2k refuses to start if it sees less than 1Mb of free swap */ > - if (lpmemex->ullTotalPageFile < lpmemex->ullTotalPhys) > - lpmemex->ullTotalPageFile = lpmemex->ullTotalPhys; > - if (lpmemex->ullAvailPageFile < lpmemex->ullAvailPhys) > - lpmemex->ullAvailPageFile = lpmemex->ullAvailPhys; > + /* Win98 returns only the swapsize in ullTotalPageFile/ullAvailPageFile, > + WinXP returns the size of physical memory + swapsize; > + mimic the behavior of XP: > + */ > + lpmemex->ullTotalPageFile += lpmemex->ullTotalPhys; > + lpmemex->ullAvailPageFile += lpmemex->ullAvailPhys; Why did you remove a comment about Project2k? It helps to understand what are the constrains of the API, and helps to avoid chasing the same bug once again. -- Dmitry.

1 0

Submitting winetricks to winehq tree?
by Dan Kegel 14 Mar '07

14 Mar '07

I haven't been villified yet, so let me try harder. Should winetricks be committed to the winehq tree? It would be handy for people triaging Wine bugs to see if e.g. native dcom, odbc, or corefonts hide a bug. I've uploaded a new version to http://kegel.com/wine/winetricks Mainly it adds a -q option to make all the installers quiet, but it also includes lots of little improvements sent in by Detlef and Saulius. Here's the new usage message: Usage: winetricks [options] package [package] ... This script can help you prepare your system for Windows applications that mistakenly assume all users' systems have all the needed redistributable runtime libraries or fonts. Options: -q quiet. You must have already agreed to the EULAs. -v Verbose Packages: art2kmin Access 2000 runtime. License required! corefonts Install MS Times, Arial fonts dcom98 Install native DCOM, override the Wine implementation fakeie6 Set registry to claim IE6sp1 is installed mdac27 Microsoft ODBC drivers, etc. mfc40 mono1.1 mono 1.1.13-gtksharp-2.8.2 mono1.2 mono 1.2.3.1-gtksharp-2.8.3 vbvm50 Visual Basic 5 runtime vbrun60 Visual Basic 6 runtime vcrun6 vc6redist from VS6sp4, including mfc42 wsh51 Windows Scripting Host 5.1

5 4

Re: Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.
by Eric Pouech 14 Mar '07

14 Mar '07

Robert Shearman a écrit : > > The old behaviour can be turned back on by setting the V environment > variable to "1" (e.g. make V=1). a couple of more comments (mostly not yet converted rules): - the MAKEDEP rule in Make.rules.in isn't handled yet (suggestion [DEPEND] $SRC(DIR)) - most of exec rule in tools/*/Makefile.in miss the MAKERULE stuff - ditto in loader (and the version-stamp could be handled too) - in dlls/Makedlls.rules.in, all lib/def/.a stuff isn't handled is there any reason why the Linking... rule has a different format than the others ? now I wish we could also get rid of the message for recursive calls to make A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [advapi32/tests 1/2] Use GetModuleHandle and skip
by Francois Gouget 14 Mar '07

14 Mar '07

On Tue, 13 Mar 2007, Paul Vriens wrote: [...] > as advapi32 is already linked to, we can use GetModuleHandle. - if (!(module = LoadLibrary( "advapi32.dll" ))) return; + if (!(module = GetModuleHandleA( "advapi32.dll" ))) return; Well, since we're already linked to advapi32.dll, there's no need to check that GetModuleHandleA() does not return NULL. Plus if we were to check we should use skip(). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

2 1

A SoC proposal for discussion: PE Packers
by Julien 14 Mar '07

14 Mar '07

Hello all, I didn't find a webpage on the wiki about SoC'07. However, I would like to suggest a SoC proposal for your comments. It seems to me that there are many bugs floating in bugzilla that are related to PE packers. Because applications just crash due to being packed, this seems a requirement for Wine 1.0. For a SoC, it would be very interesting if one student takes the mission of fixing bugs related to PE packers such as: - Shrinker (#2608, #2619) - Neolite (seems ok see #4709) - Aspack (#6129) - Armadillo (#219) This would require to define the list of PE packers to support and which versions (as anti debugging tricks may differ depending of the version). Best, Julien

2 1

Re: Add very basic initial tests for d3drm
by Dmitry Timoshkov 14 Mar '07

14 Mar '07

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > +START_TEST(vector) > +{ > + init_function_pointers(); > + > + VectorTest(); > + QuaternionTest(); What happens if init_function_pointers() failed? -- Dmitry.

2 1

Re: Alexandre Julliard : ntdll: Add a wrapper to call the thread entry point for broken apps.
by Ken Thomases 14 Mar '07

14 Mar '07

On Mar 14, 2007, at 7:25 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 7744443febb04213cf014b007a83744a66544d6c > URL: http://source.winehq.org/git/wine.git/? > a=commit;h=7744443febb04213cf014b007a83744a66544d6c > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Wed Mar 14 12:28:38 2007 +0100 > > ntdll: Add a wrapper to call the thread entry point for broken apps. > > --- > > dlls/ntdll/thread.c | 25 ++++++++++++++++++++++--- > 1 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 9656331..d0871a1 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -349,6 +349,26 @@ static PUNHANDLED_EXCEPTION_FILTER > get_unhandled_exception_filter(void) > return unhandled_exception_filter; > } > > +#ifdef __i386__ > +/* wrapper for apps that don't declare the thread function > correctly */ > +extern DWORD call_thread_entry_point( PRTL_THREAD_START_ROUTINE > entry, void *arg ); > +__ASM_GLOBAL_FUNC(call_thread_entry_point, > + "pushl %ebp\n\t" > + "movl %esp,%ebp\n\t" > + "subl $4,%esp\n\t" > + "pushl 12(%ebp)\n\t" > + "movl 8(%ebp),%eax\n\t" > + "call *%eax\n\t" > + "leave\n\t" > + "ret" ); > +#else > +static inline DWORD call_thread_entry_point > ( PRTL_THREAD_START_ROUTINE entry, void *arg ) > +{ > + LPTHREAD_START_ROUTINE func = (LPTHREAD_START_ROUTINE)rtl_func; Should the above have "entry" instead of "rtl_func"? > + return func( arg ); > +} > +#endif > + > / > ********************************************************************** > * > * call_thread_func > * > @@ -356,16 +376,15 @@ static PUNHANDLED_EXCEPTION_FILTER > get_unhandled_exception_filter(void) > */ > static void DECLSPEC_NORETURN call_thread_func > ( PRTL_THREAD_START_ROUTINE rtl_func, void *arg ) > { > - LPTHREAD_START_ROUTINE func = (LPTHREAD_START_ROUTINE)rtl_func; > DWORD exit_code; > BOOL last; > > MODULE_DllThreadAttach( NULL ); > > if (TRACE_ON(relay)) > - DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", > GetCurrentThreadId(), func, arg ); > + DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", > GetCurrentThreadId(), rtl_func, arg ); > > - exit_code = func( arg ); > + exit_code = call_thread_entry_point( rtl_func, arg ); > > /* send the exit code to the server */ > SERVER_START_REQ( terminate_thread ) > > >

2 1

DirectX 10 start as a SoC project?
by Kovács András 14 Mar '07

14 Mar '07

Hi, I think, that start working on Dx10 is a great opportunity to learn about wined3d, and Microsoft's new platform. I would like to apply, because i want to contribute to open source projects, and i'm really interested in wine, especially in wined3d. I have some patches in the tree, and I really would like to work on together. Best Regards, Andras kovacs -- ------------------ andras NetClub Lamarr csevego.net andras(a)csevego.net ------------------

4 3

HtmlHelp status, winecfg and SoC proposal
by Jacek Caban 14 Mar '07

14 Mar '07

Hello. As you may have noticed, I've been working on HtmlHelp lately. Currently it should generally work, but still there is a lot to do. HTML should be correctly displayed and content tab should work. I was thinking about making more use of it in Wine. I think winecfg could benefit from it. We could easily add context help to winecfg using HtmlHelp API. Even just integrating a part of Wine User's Guide would be a good start. The main problem is building chm file (that is the file format of HtmlHelp). Microsoft has a HtmlHelp compiler (hhc) for it. We'd need something similar in Wine. AFAIK there is no good open source replacement. HtmlHelp maker (hhc, see [1]) doesn't create internal files (parts of chm that describes stuff like index or default topic) and it's GPLed so it's useless for Wine (unless author would relicense it for us). I think it would be a good project for Google Summer of Code. The task would be to write a hhc replacement and add a help option to winecfg. hhc replacement (say whhc) would have to be a plain UNIX tool (it means a bit of code duplication with itss.dll, just like we do in widl) so we could use it during compilation. I think its difficulty is good for SoC. Compressing code may be integrated from some other project. The remaining parts are code of parser of files describing chm and a little winecfg hacking. What do you think? Jacek [1] http://savannah.nongnu.org/projects/hhm

4 5

Re: wined3d: Allow SetCursorProperties on existing cursor
by Stefan Dösinger 13 Mar '07

13 Mar '07

Am Dienstag 13 März 2007 03:44 schrieb Erich Hoover: > Real Name: > Erich Hoover > Changelog: > wined3d: Allow SetCursorProperties on existing cursor Looks good to me, except one cosmetic issue: if(pCursorBitmap) { + WINED3DLOCKED_RECT rect; +......... /* MSDN: Cursor must be A8R8G8B8 */ You are adding trailing whitespaces here. I think git or AJs filters filter them out, but they tend causing merging problems for me if my patches contain some of them.

1 0

My plans for SOC
by Maarten Lankhorst 13 Mar '07

13 Mar '07

For the summer of code I'm planning to improve the dsound code and alsa code, to make alsa finally better then OSS, in a way that has a will get accepted into the wine tree, for that I'm thinking of improving on the following fronts: Winealsa: - Add mixer device and aux controls - Implement dsound capture - Seperate the initialisation of the directsound code from the waveout code, to allow creation of multiple dmix devices. - Try to configure alsa to allow arbitrarily big buffers, working around the alsa problem that only up to a certain amount can be allocated for buffers, certain programs (for example winamp) may require more. - Remove the queuing thread and use Lock() and Unlock() instead. - Make it run so well, people wouldn't want to use OSS any more. Both dsound/winealsa: - Allow proper usage of Lock() and Unlock() for sound drivers, it's not used properly or even tested in current dsound code. - Rework some of the dsound code, to allow mixing to be done in winealsa, and fix possible errors that can be caused by it. - Improve the dsound software mixer code to allow mixing and (if possible) be less prone to buffer underruns. The challenge is to get this working right, without too much of an impact hit. I also will have to work around alsa limitations: I cannot make buffers arbitrarily big, while in windows they can be. It seems no 2 programs use dsound in the same way, so I will have to test with various different programs to get everything working. I'll try to get in contact with alsa-devel first, if there is a way to change buffer size to something arbitrary, it is worth it in the long run to use that method. A manual fix seems to be close everything using alsa, then echo 256 > /proc/asound/card0/pcm0p/sub0/prealloc, but I am hoping there is an easier way to fix it, in either case I am afraid I will have to put some memory buffer code in winealsa as fallback. If there's still some time left, I'll also try to get some 3d sound code in, using some openal code, the license seems to be lgpl compatible, or I will try to get support for multiple (4, 5.1 ?) speakers working, it depends a little on how fast I can get this to work in a nice shape. Looking for feedback. Cheers, Maarten

4 3

re: Want to be a Wine mentor for Google Summer of Code 2007?
by Dan Kegel 13 Mar '07

13 Mar '07

Jeremy wrote: > Say, we (the Wine project) seem to be increasingly leaning on you > to run Wine's SoC program. In the early days, we had a committee, > and people helping, and stuff. These days, I know that I am guilty > of thinking that you're on it, so I can safely ignore it; I fear > that a bunch of others of us may be doing the same. > > Are we letting you down? Do you need help? I'm fine this year, but considering how I missed the deadline (we were saved by LH's kindness), it would probably be a good idea to pick somebody else to be admin next year. The committee should probably just be the mentors plus you and Alexandre (if you/he are interested). - Dan

2 1

RE: some emails not arriving to wine-patches (was CMD.EXE resubmits)
by Ann & Jason Edmeades 13 Mar '07

13 Mar '07

As an FYI I sent the same patchset to another email account (not on my ISP, just one of the free ones) and they all got through 4 times. It would start to point to the wine-patches side of things, but I have never seen anyone else have problems Note I am not seeing any rejection emails either Jason

3 2

Re: [0/9] CMD.EXE resubmits
by Alexander Nicolaysen Sørnes 13 Mar '07

13 Mar '07

Tirsdag 13 mars 2007 22:03, skrev Ann & Jason Edmeades: > Resubmitting the patchset from yesterday having fixed up the > mallocs/reallocs/frees to HeapAllocs/HeapReAllocs/HeapFrees, and resolved > conflicts with those already committed. > > Note: I have been experimenting from sending the emails directly from "git > send-email", and this will be the first ones sent that way, so if there are > any problems please let me know > > Jason There does not seem to be a patch attached. Alexander N. Sørnes

2 2

Issue with GetTokenInformation?
by Paul Vriens 13 Mar '07

13 Mar '07

Hi, As I'm still trying to get Process Explorer running perfectly, I've noticed that the usernames for the processes are not correct. The attached patch shows the issue. I'm not sure if this test-patch should go to wine-patches as I'm not sure my test is correct (or in the correct place). It succeeds on W2K3. Maybe someone more knowledgeable about the Token stuff could have a look? Cheers, Paul

1 0

Re: Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.
by Eric Pouech 13 Mar '07

13 Mar '07

Robert Shearman a écrit : > > The old behaviour can be turned back on by setting the VERBOSE > environment variable to "yes". > .s.o: > $(AS) -o $@ $< > > $(MODULE): $(OBJS) Makefile.in > - $(RM) $@ > - $(AR) $@ $(OBJS) > - $(RANLIB) $@ > + @$(RM) $@ > + @$(MAKERULE) '[AR] $@' $(AR) $@ $(OBJS) > + @$(MAKERULE) '[RANLIB] $@' $(RANLIB) $@ > we'll miss the echo for the $(RM) command in verbose mode IMO, we should use here something like @$(MAKERULE) '' $(RM)... and handle the empty $1 in makerule A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: localspl: add Polish translation
by Jacek Caban 13 Mar '07

13 Mar '07

Hi Mikołaj, Mikołaj Zalewski wrote: > + IDS_NOTHINGTOCONFIG "Ten port nie ma opcji, kt�re mo�na by skonfigurowa�" > +} > It doesn't sound good to me. How about "Ten port nie ma opcji do skonfigurowania" or just remove "by" from your version? Jacek

1 0

Re: shell32: update Polish translation
by Jacek Caban 13 Mar '07

13 Mar '07

Hi Mikołaj, Mikołaj Zalewski wrote: > - IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > - "If the files in the destination folder have the same names as files in the\n"\ > - "selected folder they will be replaced. Do you still want to move or copy\n"\ > - "the folder?" > + IDS_OVERWRITEFOLDER_TEXT "Ten folder ju� zawiera folder o nazwie '%1'.\n\n"\ > + "Je�eli w docelowym folderze wyst�pi� pliki o takich zamych nazwach jak\n"\ > This is a typo, it should be "samych nazwach". Jacek

1 0

Re: wordpad: update Polish translation
by Jacek Caban 13 Mar '07

13 Mar '07

Hi Mikołaj, Mikołaj Zalewski wrote: > + > +STRINGTABLE DISCARDABLE > +BEGIN > + STRING_RICHTEXT_FILES_RTF, "Tekst sformatowany - RTF (*.rtf)" > + STRING_TEXT_FILES_TXT, "Document tekstowy (*.txt)" This is a typo, it should be "Dokument". Jacek

1 0

Re: const cleanup round 1
by Eric Pouech 13 Mar '07

13 Mar '07

Mike Schaadt a écrit : > string.c: > strtolW and strtoulW - constify the endptr value. This is just an > output value to indicate where in the array we stoped processing. > Change causes this to be the same type as the first value. Reduces > number of cast-qual warnings by 6. > > lnk.c: > dump_pidl > [line 176] - switched to const. Value is never modified in > the function. Removes a cast-qual warning. > > symbol.c: > symbol_clean_string - this function is modifying the string. This > should most definitly *not* be a const parameter. It's not even > logically const as the the intent of the function is to make the type > string Wine-friendly. That requires modifications to that string. > > ------------------------------------------------------------------------ > > diff --git a/include/wine/unicode.h b/include/wine/unicode.h > index 83a7d52..4e2caa5 100644 > --- a/include/wine/unicode.h > +++ b/include/wine/unicode.h > @@ -96,8 +96,8 @@ extern int strcmpiW( const WCHAR *str1, > extern int strncmpiW( const WCHAR *str1, const WCHAR *str2, int n ); > extern int memicmpW( const WCHAR *str1, const WCHAR *str2, int n ); > extern WCHAR *strstrW( const WCHAR *str, const WCHAR *sub ); > -extern long int strtolW( const WCHAR *nptr, WCHAR **endptr, int base ); > -extern unsigned long int strtoulW( const WCHAR *nptr, WCHAR **endptr, int base ); > +extern long int strtolW( const WCHAR *nptr, const WCHAR **endptr, int base ); > +extern unsigned long int strtoulW( const WCHAR *nptr, const WCHAR **endptr, int base ); > this is wrong as you want to be able to write code as: WCHAR* str; WCHAR* p; int val = strtolW(str, &p, 10); *p = '\0'; which your modification forbids (ANSI strtol doesn't have the const modifier for endptr) the rest of the patch looks ok -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

Re: Add casts to tools/makedep.c
by Dmitry Timoshkov 13 Mar '07

13 Mar '07

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > I accidently ended up building Wine using a C++ compiler the other day, > and came across the following. > - char *p = xmalloc (size); > + char *p = (char*) xmalloc (size); That's a problem of C++ not Wine if it can't cope with casting void * to another pointer type. Polluting the whole source with useless casts buys us nothing. -- Dmitry.

2 1

Re: winedbg: Support longer thread names
by Eric Pouech 13 Mar '07

13 Mar '07

Erich Hoover a écrit : > Real Name: > Erich Hoover > Description: > The thread name length in winedbg is currently restricted to 9 > characters, this is not nearly long enough for debugging threads in > the Supreme Commander demo and results in character corruption on the > terminal. Since this particular application names one of the threads > with the map path (Map loader /maps/scmp_019/scmp_019.scmap), a > significant increase in the number of characters is necessary. This > patch ups the allowed thread name length to 100 characters and > null-terminates the string in case an application exceeds that > threshold value. > Changelog: > winedbg: Support longer thread names in that case, it would be better to dynamically allocate the string (and to create it by default at 5 bytes for the %04x value) furthermore, you need to change the comment in debugger.h in THREADNAME_INFO structure about the name's length, as it seems VC7 removed the restriction to 8 characters that existed in VC6 A+

2 2

Re: [11/19] cmd.exe: Add dir /Q support
by Alexandre Julliard 13 Mar '07

13 Mar '07

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > + secBuffer = (LPBYTE) malloc(sizeNeeded * sizeof(BYTE)); > + if(!secBuffer) return; Please don't use malloc in Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

d3drm test implementation need comments and review
by Vijay Kiran Kamuju 13 Mar '07

13 Mar '07

Hi, I have implemented some d3drm functions and made some changes. Original implementation is by David Adam. Currently I dont have a wine repository to test the patch. Before applying the patch please create the dlls/d3drm/tests directory Please send me you comments, regarding this. If there are any compilation/execution errors, please notify me. I will correct them (I dont have access to linux m/c currently) Thanks, VJ

2 1

Re: Add d3drmdef.h header - try 2
by Francois Gouget 13 Mar '07

13 Mar '07

On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote: > Changelog > --------------- > Add minimalistic d3drmdef.h > > extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, LPD3DVECTOR); Two nitpicks: Wine's headers usually don't specify extern (it's implicit). If there's a large list of functions it can also be nice to sort them in alphabetical order as other forms of grouping tend to break down after a time. But this is not a hard and fast rules and it is not always followed. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

2 1

Re: Set D3DCAPS2_DYNAMICTEXTURES flag
by Mirek 13 Mar '07

13 Mar '07

Shouldn't we use WINED3DCAPS2_DYNAMICTEXTURES rather than D3DCAPS2_DYNAMICTEXTURES ? Mirek Slugen Kovács András napsal(a): > Hi, > Set D3DCAPS2_DYNAMICTEXTURES flag. > This makes Call of Duty 2 to run. Stefan told me, this function is supported, > but we don't advertise it currently. > > > > ------------------------------------------------------------------------ > > From e9398c4ee873ef8b8257fcb3db4945c858655732 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Andr=C3=A1s_Kov=C3=A1cs?= <andras(a)debian.sth.sze.hu> > Date: Tue, 13 Mar 2007 03:07:30 +0100 > Subject: [PATCH] Set D3DCAPS2_DYNAMICTEXTURES flag > > --- > dlls/wined3d/directx.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 209e745..c5898c6 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -1879,7 +1879,8 @@ static HRESULT WINAPI IWineD3DImpl_GetDeviceCaps(IWineD3D *iface, UINT Adapter, > > *pCaps->Caps = 0; > *pCaps->Caps2 = WINED3DCAPS2_CANRENDERWINDOWED | > - WINED3DCAPS2_FULLSCREENGAMMA; > + WINED3DCAPS2_FULLSCREENGAMMA | > + D3DCAPS2_DYNAMICTEXTURES; > *pCaps->Caps3 = 0; > *pCaps->PresentationIntervals = WINED3DPRESENT_INTERVAL_IMMEDIATE; > > > > ------------------------------------------------------------------------ > >

2 1

const cleanup round 1(commentary on what I found)
by Mike Schaadt 13 Mar '07

13 Mar '07

Some of this was included in the patch submission. Some of it I had questions about. spawn.c : warnings may or may not be harmless depending on if esecvp attempts to modify the results. Specs indicate it doesn't, but the function typing doesn't indicate so(the difference is 'const char * const argv[]' and 'char *const argv[]') libs/wine/string.c: strstrW - returns the location where sub was found in str. I believe returning a non-const value is what is expected. Should this be changed to a non-const parameter, or just leave the warning as is? tools/winedump/pdb.c: pdb_exit [line 149,153,155] - freeing of const variable. Is this ok? I could imagine it *could* cause problems if what we are freeing isn't in readable/writeable memory. pdb_dump_symbols [line 293,403,409] - same as pdb_exit. pdb_dump_types [line 462] - ditto pdb_jg_dump line[514] - ditto pdb_ds_dump line[643] - ditto tools/winedump/search.c: get_type [line 305, 329] - freeing of const variable again. [line 314, 335] - both cases, set return_text to type_str. Either parsed_symbol's return_text needs to be constified, proto should be unconstified, or leave it in place as a necessary cast. Any comments on the above spots? what of these are necessary casts? what of these can/should be corrected, and what needs to be done to correct them? **patches submitted to wine-patches** the following were straight forward patches that shouldn't modify the flow of the program beyond fixing the warnings. libs/wine/string.c: strtolW and strtoulW - constify the endptr value. This is just an output value to indicate where in the array we stoped processing. Change causes this to be the same type as the first value. Reduces number of cast-qual warnings by 6. tools/winedump/lnk.c: dump_pidl [line 176] - switched to const. Value is never modified in the function. Removes a cast-qual warning. tools/winedump/symbol.c: symbol_clean_string - this function is modifying the string. This should most definitely *not* be a const parameter. It's not even logically const(as a comment tried to claim) as the the intent of the function is to make the type string Wine-friendly. That requires modifications to that string, and to the variable. Removes a cast-qual warning. Comments? questions? Current number of cast-qual warnings fixed: 8. Number deemed necessary: 0(you guys need to help me decide what of these need to remain) Number looked at: 24. Estimated number remaining: 521.

1 0

re: Add d3drmdef.h header - try 2
by Dan Kegel 13 Mar '07

13 Mar '07

Vijay wrote: > Add minimalistic d3drmdef.h But why? None of the code in wine currently needs it. Maybe you should submit it together with the first bit of code that needs it. -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

re: Add d3drmdef.h header
by Dan Kegel 13 Mar '07

13 Mar '07

vijay wrote: > [complete d3drmdef.h] It seems premature to check that in without any code that uses it. Also, did you really write all that yourself? - Dan

3 5

Wiki changes lost? (was: Re: Known desktop migration projects and their "must have" Windows apps)
by Dan Kegel 13 Mar '07

13 Mar '07

On 3/11/07, Dan Kegel <dank(a)kegel.com> wrote: > I'm putting a list together at > http://wiki.winehq.org/DesktopMigrationProjects This, and all my other recent wiki changes, seem to have vanished in a puff of greasy black smoke. What's up? This isn't doing much for my trust in wikis... - Dan

4 10

CreateScalableFontResource - a few questions
by Chris Howe 13 Mar '07

13 Mar '07

Hi all, For my first foray into contributing to Wine (a blast, so far :) ) I am implementing CreateScalableFontResource which is currently present in stub form, but when fully implemented should create .FOT files from .TTF files for (amongst other things) temporarily installing fonts by a successive call to AddFontResource (which exists in Wine). It was trivial to code the functionality for the flow of CreateScalableFontResource as per the documentation but my research into the .FOT file format threw up a couple of questions. Even though .FOT files, as far as they're used by AddFontResource are little more than storage for a couple of pathnames, they are in fact Win3.1-style NE-binary files. With that in mind, 1) AFAICT, there is no code in Wine currently to save NE-binaries to disk, although obviously they are loadable and data structures relating to the format are defined. Rather than write a standalone, .FOT saving function, based off the kind of code you see in the fnt2fon program - .FON files are a similar, though not identical format - would it be better to write something like a NE_SaveModule that takes an in-memory NE module and saves it to disk, and call that from my .FOT saving code? This would live in ne_module.c I guess, and be limited, certainly initially, to the context in which I'd be using it. IE, just saving the resources. Indeed, I don't know in what other context that code WOULD be used, but who knows, down the line someone might want to expand it to do something more useful. 2) NE binaries, including FOT files, contain as part of the header a DOS stub-executable that typically spits out a message of some sort. I reasoned that being in itself a compiled binary we can't legally use the blob of binary that would appear in a real-world FOT file as-is, and I certainly wasn't about to go decompiling it, so I lifted the DOS stub executable from fnt2fon which I'm assuming as it's distributed with WINE is fair game. This will mean .FOT files generated by my code will be slightly different to a real, "in-the-wild" .FOT file, but I'm not sure in the circumstances that matters as the file is typically temporary, and only used as a container, never to be run - it's just different from a user perspective. Is this OK? Also, are there any open-source requirements on that small binary blob? Fnt2fon certainly includes it with no added info. 3) Related to item 2, so far, the actual spec of the .FOT file format has eluded me, though knowing that it's a NE binary has enabled me to reverse a lot of it, which I'm yet to test but I believe will be enough to fool AddFontResource into doing what it's supposed to do. Again, is it enough to go that far for now as the FOT format seems to be unsupported in WINE? Advice on these points would help me help you :) -- Chris Howe

2 1

DirectX 10 start as a SoC project?
by Stefan Dösinger 13 Mar '07

13 Mar '07

Hi, Thinking about SoC I though that starting a DirectX 10 implementation may be a good summer of code project. I do not mean implementing the full d3d10 lib, that would be way to much, more starting the infrastructure. Henri disagreed with the idea, so I thought I'll write a mail for public discussion :-) . Looking at the timeline for SoC I hope it isn't too late. My idea is to start a d3d10 implementation up to the following point: -> Add a winver Windows Vista to make version checkers happy :-) -> Create the d3d10 lib and start the .idl file for header generation -> Write stubs for the functions to allow the app to create all the interfaces -> Write test cases for reference counting. ddraw and d3d9 show that Microsoft does not stick to its own COM rules -> Make methods that have already 1:1 equivalents in wined3d call wined3d. Add other methods as required to wined3d. -> Implement them as far as you feel like :-) I think the good thing about this is that there are is not much knowledge about wined3d and d3d10 necessary at the start. The one who works on it can learn the d3d10 interface while writing the stubs and learn about wined3d when starting to call it. Opinions? Suggestions? Cheers, Stefan

11 21

Re: CreateScalableFontResource - a few questions
by Juan Lang 13 Mar '07

13 Mar '07

Hi Chris, > For my first foray into contributing to Wine Welcome! > would it be better to write something like a NE_SaveModule that takes > an in-memory NE module and saves it to disk, and call that from my > .FOT saving code? Only if it makes your code more readable. In general Wine doesn't share code between modules, unless Windows does. So this would almost certainly be kept in gdi32, unless you know of a public Windows API that does what you suggest. > 2) NE binaries, including FOT files, contain as part of the header > a DOS stub-executable that typically spits out a message of > some sort. I reasoned that being in itself a compiled binary we > can't legally use the blob of binary that would appear in a > real-world FOT file as-is, and I certainly wasn't about to go > decompiling it, so I lifted the DOS stub executable from fnt2fon > which I'm assuming as it's distributed with WINE is fair game. That seems reasonable to me. > Also, are there any open-source requirements on that small binary > blob? Fnt2fon certainly includes it with no added info. Taking it from fnt2fon seems safe enough to me too. > 3) Related to item 2, so far, the actual spec of the .FOT file > format has eluded me, though knowing that it's a NE binary has > enabled me to reverse a lot of it, which I'm yet to test but I > believe will be enough to fool AddFontResource into doing what > it's supposed to do. Again, is it enough to go that far for now > as the FOT format seems to be unsupported in WINE? Yes, that's probably enough for now. --Juan ____________________________________________________________________________________ 8:00? 8:25? 8:40? Find a flick in no time with the Yahoo! Search movie showtime shortcut. http://tools.search.yahoo.com/shortcuts/#news

1 0

Re: wined3d: Set wrapmode for cubemags to clamp regardeless of the sampler state
by Stefan Dösinger 12 Mar '07

12 Mar '07

Am Samstag 10 März 2007 15:02 schrieb Fabian Bieler: > This Patch forces GL_CLAMP_TO_EDGE on all cubemaps. > > I tested this on XP with some Radeon X1???. > > Also, this fixes some renderissues Half-Life 2. Say, does that fix the strange quad boarders like in this screenshot? http://bugs.winehq.org/attachment.cgi?id=5297&action=view (Eve Online). It sounds like it would do that, I'm very impressed :-) How did you test that? It sounds like a test case using the visual test framework is worth an investigation. I can try to write a test for that.

3 4

WineHQ maintenance
by Jeremy Newman 12 Mar '07

12 Mar '07

I will be performing some maintenance to WineHQ today at 14:30 CST. The recent outages on WineHQ were attributed to a faulty drive in the RAID. I will be taking the server offline to replace that drive. The server should only be offline for about 20 minutes. -newman

1 0

LockRect Problem
by Erich Hoover 12 Mar '07

12 Mar '07

I'm looking into a problem that causes Supreme Commander to segfault (Bug #7643 <http://bugs.winehq.org/show_bug.cgi?id=7643>) and I believe I may have run into a problem with IWineD3DSurfaceImpl_LockRect. I believe the problem is a typo in the line: > This->resource.allocatedMemory = HeapAlloc(GetProcessHeap() ,0 , This-> > resource.size + 4); I think that the allocated memory should be the size of the resource multiplied by 4 (instead of adding 4). With the current allocation, for some textures, the operation to calculate the pBits location returns a memory address that is past the end of the allocated memory. So, after this operation: > pLockedRect->pBits = This->resource.allocatedMemory + (pLockedRect->Pitch > * pRect->top) + (pRect->left * This->bytesPerPixel) > the value of pLockedRect->pBits is greater than "This-> resource.allocatedMemory + This->resource.size + 4". I've dug around a bit to see if This->resource.size was just allocated incorrectly but that does not appear the case. So, if someone could confirm or deny that this is a typo problem then I'd really appreciate it. Erich Hoover ehoover(a)mines.edu

3 4

fog with pixel shaders < 3.0
by Fabian Bieler 12 Mar '07

12 Mar '07

Hello! I'd like to get fog working in conjunction with pixel shaders 2.0 or earlier. The problem is that said shaders don't replace the fog stage in Direct3D. Adding the necessary fog calculations to a GLSL fragment shader is trivial, however, this results in a dependency of the shader on the current fog state. Now, I have thought up three solutions for this problem: 1) Compile two versions of every fragment shader (one with fog and one without) and choose the appropriate one according to the state. Pro: Probably performance wise the cheapest solution Con: Generates more shaders, however, as shader are only compiled on demand, this shouldn't be too bad. 2) Rebuild the shader whenever it is bound in conjunction with a changed fog state. Pro: ? Con: This would be a performance killer as it would potentially cause multiple calls of IWineD3DPixelShaderImpl_CompileShader per frame, as some Programs use the same fragment shader for rendering with and without fog. (ok, I only know this of source based games, but imo that's bad enough) 3) Add Fog calculation to every shader, enabling or disabling it at runtime via a constant factor of 1.0 or 0.0 depending on the fog state which is supplied as a shader constant. Pro: cpu-load wise cheap Con: Adds some more instructions to fragment shader code. Now, I don't particularly like any of these solutions, so I'd welcome other ideas, comments or suggestions. Fabian P.S: I noticed that fog-state management is not yet included in the state table. Should a patch that fixes fog with pixel shaders wait until this is done, or is this of no importance?

3 8

Re: [2/2] imm32: Fix the unwanted root_context string buffer cleanup code.
by Byeong-Sik Jeon 12 Mar '07

12 Mar '07

I'm sorry. This patch don't fix kinput2 case. kinput2 case may be wanted situation. but this patch fix the 'nabi' and 'scim' case. Hmm, I'll stop the my poor patch series. Thank you. Byeong-Sik Jeon worte: > kinput2: Japanese xim. when we press japanese/english toggle key > at the composition state before commit, we lost composition > string. > nabi : Korean xim. same 'kinput2' case. > scim : General IM platform. when we input Japanese string, if > we press the "commit key(ENTER)", then we lost the all > composition string. > > This patch fix all above. > --- > dlls/imm32/imm.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-)

1 0

mswsock.dll, Soc & legal questions
by Benoit Pradelle 12 Mar '07

12 Mar '07

Hi, I'm pretty interested in implementing mswsock.dll as a SoC this summer : this dll seems to be used by many apps and it's, I think, the sort of job I can do. As I'm not a Wine dev, I was wondering about how should I work for implementing this lib : should I juste use the MSDN description of the functions and make some tests with some apps to validate the behavior ? Or can I take the original dll, execute some apps with it and try to see how the dll is interacting with other libs, what sort of network traffic is generated, etc ? Is this solution possible with the microsoft license ? Thanks, Ben

2 2

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.
by Aric Stewart 12 Mar '07

12 Mar '07

I am pretty sure that these are done via SendMessage when I checked with Spy++. Additional a number of the applications I am working with hang when the WM_IME_NOTIFY is sent out of order. -aric Byeong-Sik Jeon wrote: > We have to call PostMessage to send WM_IME_NOTIFY message. > To send WM_IME_CONTROL, we use SendMessage, but WM_IME_NOTIFY is not... > > changelog: > Use the PostMessageW for WM_IME_NOTIFY message. > --- > dlls/imm32/imm.c | 25 ++++++++----------------- > 1 files changed, 8 insertions(+), 17 deletions(-) > > > ------------------------------------------------------------------------ > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 02a362e..034d4ea 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -77,8 +77,8 @@ static UINT WM_MSIME_DOCUMENTFEED; > */ > static LRESULT WINAPI IME_WindowProc(HWND hwnd, UINT uMsg, WPARAM wParam, > LPARAM lParam); > +static LRESULT ImmInternalPostIMEMessage(UINT, WPARAM, LPARAM); > static void UpdateDataInDefaultIMEWindow(HWND hwnd); > -static void ImmInternalPostIMEMessage(UINT, WPARAM, LPARAM); > static void ImmInternalSetOpenStatus(BOOL fOpen); > > static VOID IMM_PostResult(InputContextData *data) > @@ -160,16 +160,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpReserved) > } > > /* for posting messages as the IME */ > -static void ImmInternalPostIMEMessage(UINT msg, WPARAM wParam, LPARAM lParam) > -{ > - HWND target = GetFocus(); > - if (!target) > - PostMessageW(root_context->hwnd,msg,wParam,lParam); > - else > - PostMessageW(target, msg, wParam, lParam); > -} > - > -static LRESULT ImmInternalSendIMENotify(WPARAM notify, LPARAM lParam) > +static LRESULT ImmInternalPostIMEMessage(UINT msg, WPARAM wParam, LPARAM lParam) > { > HWND target; > > @@ -177,7 +168,7 @@ static LRESULT ImmInternalSendIMENotify(WPARAM notify, LPARAM lParam) > if (!target) target = GetFocus(); > > if (target) > - return SendMessageW(target, WM_IME_NOTIFY, notify, lParam); > + return PostMessageW(target, msg, wParam, lParam); > > return 0; > } > @@ -214,7 +205,7 @@ static void ImmInternalSetOpenStatus(BOOL fOpen) > else > ShowWindow(hwndDefault, SW_SHOWNOACTIVATE); > > - ImmInternalSendIMENotify(IMN_SETOPENSTATUS, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETOPENSTATUS, 0); > } > > > @@ -1243,7 +1234,7 @@ BOOL WINAPI ImmSetCompositionFontA(HIMC hIMC, LPLOGFONTA lplf) > MultiByteToWideChar(CP_ACP, 0, lplf->lfFaceName, -1, data->font.lfFaceName, > LF_FACESIZE); > > - ImmInternalSendIMENotify(IMN_SETCOMPOSITIONFONT, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETCOMPOSITIONFONT, 0); > > if (data->textfont) > { > @@ -1267,7 +1258,7 @@ BOOL WINAPI ImmSetCompositionFontW(HIMC hIMC, LPLOGFONTW lplf) > return FALSE; > > memcpy(&data->font,lplf,sizeof(LOGFONTW)); > - ImmInternalSendIMENotify(IMN_SETCOMPOSITIONFONT, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETCOMPOSITIONFONT, 0); > > if (data->textfont) > { > @@ -1418,7 +1409,7 @@ BOOL WINAPI ImmSetCompositionWindow( > if (reshow) > ShowWindow(hwndDefault,SW_SHOWNOACTIVATE); > > - ImmInternalSendIMENotify(IMN_SETCOMPOSITIONWINDOW, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETCOMPOSITIONWINDOW, 0); > return TRUE; > } > > @@ -1447,7 +1438,7 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > if (hIMC == (HIMC)FROM_IME) > { > ImmInternalSetOpenStatus(fOpen); > - ImmInternalSendIMENotify(IMN_SETOPENSTATUS, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETOPENSTATUS, 0); > return TRUE; > } >

2 3

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.
by Dmitry Timoshkov 12 Mar '07

12 Mar '07

"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote: > We have to call PostMessage to send WM_IME_NOTIFY message. > To send WM_IME_CONTROL, we use SendMessage, but WM_IME_NOTIFY is not... > > changelog: > Use the PostMessageW for WM_IME_NOTIFY message. Aric just changed the code to use SendMessage for WM_IME_NOTIFY message. Sounds like it's time to write some message tests or look at the existing ones (which confirm that WM_IME_SETCONTEXT and WM_IME_NOTIFY are sent, not posted). -- Dmitry.

2 3

Re: Add implementation of D3DRMVector* functions
by Dmitry Timoshkov 12 Mar '07

12 Mar '07

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > This is a patch by David Adams, implementing D3DRMVector* functions in d3drm.dll > I am sending the patch to this mailing list as this was posted on > bugzilla and awaiting review. 1. it's not really nice to send something with name attachment.cgi as a patch. 2. the patch has inconsistent formatting and very hard to read due to that 3. the patch is extremely buggy in memory allocations: instead of allocating the space for an object it allocates the space only for a pointer. I'd suggest to allocate all the objects on the stack instead. -- Dmitry.

3 2

Re: Add implementation of D3DRMVector* functions
by H. Verbeet 12 Mar '07

12 Mar '07

On 12/03/07, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > Hi, > > This is a patch by David Adams, implementing D3DRMVector* functions in d3drm.dll > I am sending the patch to this mailing list as this was posted on > bugzilla and awaiting review. > A few comments: >- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA >+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 0;2110;-130;1, USA I don't think that change should be there. >+ LPD3DVECTOR result=(LPD3DVECTOR)(malloc(sizeof(LPD3DVECTOR))); That and other places in that patch should be using HeapAlloc/HeapFree >+LPD3DVECTOR D3DRMAPI D3DRMVectorRandom(LPD3DVECTOR d) >+{ >+ >+ srand(time(NULL)); >+ d->x=(float)(rand()); >+ d->y=(float)(rand()); >+ d->z=(float)(rand()); >+ TRACE("Random vector=(%f,%f,%f)\n",d->x,d->y,d->z); >+ return d; >+} I'm not sure about this, but I'm thinking it might be better to generate a normalized vector there. - The indentation in D3DRMVectorRotate is a bit of a mess - Writing test cases doesn't hurt, and in this case should be pretty easy

2 1

Re: [try 3] wined3d: Implented signed texture formats via NV_TEXTURE_SHADER
by Stefan Dösinger 12 Mar '07

12 Mar '07

Am Montag 12 März 2007 11:54 schrieb Fabian Bieler: > On Monday 12 March 2007 10:39, Stefan Dösinger wrote: > > You seem to add a 2nd table for GL_NV_texture_shader3 formats and try > > this table first. It is another solution for the static table problem I > > haven't thought of yet. For now, can you just hardcode the formats in the > > normal table? It should not cause any issues otherwise, because the > > function looking for a surface conversion will filter them out anyway. > > This patch includes the requested changes. I did not implement the > conversions for the new pixel formats, as that would not help anything > without also alterting the fragment shaders. Almost perfect :-) + {WINED3DFMT_X8L8V8U8 ,0x0 ,0x0 ,0x0 ,0x0 ,4 ,FALSE ,GL_DSDT8_MAG8_INTENSITY8_NV,GL_DSDT_MAG_INTENSITY_NV,GL_BYTE}, Can you align the } with the other lines? (I'm picky because it is very tricky to fix the formating afterwards)

1 0

Re: wined3d: Implented signed texture formats via NV_TEXTURE_SHADER
by Stefan Dösinger 12 Mar '07

12 Mar '07

Am Montag 12 März 2007 00:30 schrieb Fabian Bieler: > The same patch as before, but with GL_DSDT_NV instead of GL_HILO8_NV as > suggested by Frank Richter. You seem to add a 2nd table for GL_NV_texture_shader3 formats and try this table first. It is another solution for the static table problem I haven't thought of yet. For now, can you just hardcode the formats in the normal table? It should not cause any issues otherwise, because the function looking for a surface conversion will filter them out anyway. It is mostly my own fault; When I created that pixel format table almost a year ago, we only had static formats which were supported by the gl core, or by a max of one extension. Nowadays the table hits the limit with bump map formats, and sRGB textures. I think it is time to think about changing the design. A few ideas by me: * Stop making the table static and keep one table per adapter. Then we can insert the proper formats depending on the supported extensions at initialization time +: One table to search for a format -: No solution for sRGB * Duplicate the tables, create extra tables for sRGB formats and per-extension tables +: Tables stay static -: Multiple tables look nasty. Can get out of control * Put one format into the table, select other per-extension formats in d3dfmt_get_conv. +: One table +: Simmilar to the color keying and palette handling -: No solution for sRGB -: Complicated, final format hard to read from pixel format table * Add extra columns to the table to allow multiple table entries per format: like a flag sRGB, and a supported extension. +: One table, stays static +: Deals with sRGB formats -: Searching for a format gets more complex, will be more expensive than with the many tables approach. * Replace the table with a function with a huge switch statement. +: Can deal with all sorts of parameters dynamically +: Not really more expensive than a lookup table with a linear search +: If done right should be easy to read -: We have had that before, it didn't look nice(ok, it used 3 different functions)

1 0

Re: wined3d: Allow SetCursorProperties on existing cursor
by Erich Hoover 12 Mar '07

12 Mar '07

> > Am Samstag 10 März 2007 06:10 schrieb Erich Hoover: > >* Real Name: > *>* Erich Hoover > *>* Description: > *>* The SetCursorProperties call needs to be capable of being performed on > *>* existing cursors. The current behavior removes the cursor handle at the > *>* beginning of any SetCursorProperties call (and on Uninit3D). The removal > *>* of the cursor on SetCursorProperties is counter to the documentation and > *>* causes some applications to lose the cursor when SetCursorProperties is > *>* re-issued (See Bug #7619 <http://bugs.winehq.org/show_bug.cgi?id=7619>). > *>* This patch corrects this issue and permits SetCursorProperties to retrieve > *>* the gl texture of an old cursor. > *>* Changelog: > *>* wined3d: Allow SetCursorProperties on existing cursor > *This is not completely correct: > > The application can Release the d3d surface after setting the cursor. This > would also delete the gl texture used to draw the cursor. Also, the apps can > potentially change the surface and call PreLoad. This would change the cursor > without SetCursorProperties(The cursor texture does not have to be in > D3DPOOL_SCRATCH, so the app can preload it manually). > > But you are right, a non-dirty surface causes issues with the current code. I > think you can fix that by modifying LoadTexture not to release the surface > memory is SFLAG_FORCELOAD is passed. (Or better, fix the SFLAG_DONOTFREE > macro in wined3d_private.h). Then, when SetCursorProperties sets the surface > texture to 0 remove SFLAG_INTEXTURE from the surface flags. > > The API documentation doesn't say anything about an application releasing the d3d surface, but the documentation in the code seems to indicate that the gl texture needs to remain when the surface is deleted - I did nothing to change this. What I did see as requiring a change is the call to "glDeleteTextures(1, &This->cursorTexture);" at the beginning of SetCursorProperties. Maybe I'm not understanding you correctly, but in my mind it is necessary to remove this call so that applications that re-use the same cursor can do so. This change (in combination with the change for non-dirty surfaces) was also experimentally verified to fix the problem I was experiencing (See Bug #7619<http://bugs.winehq.org/show_bug.cgi?id=7619>). I will look into changing/implementing the flags to eliminate the "non-dirty surface" problem. Erich Hoover ehoover(a)mines.edu

4 12

Re: quartz: Check allocation failure and clear memory in DSound Renderer
by Detlef Riekenberg 12 Mar '07

12 Mar '07

On Fr, 2007-03-09 at 03:02 -0800, Chris Robinson wrote: > + ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl)); Since you clear the whole struct, ... > pDSoundRender->lpVtbl = &DSoundRender_Vtbl; > pDSoundRender->IBasicAudio_vtbl = &IBasicAudio_Vtbl; > @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, > LPVOID * ppv) > pDSoundRender->pClock = NULL; > pDSoundRender->init = FALSE; > pDSoundRender->started = FALSE; ... there is no need to clear it again. -- By by ... Detlef

5 8

A Reminder : A Study on Free/Open Source Software
by Anu Gupta DCSA 12 Mar '07

12 Mar '07

Dear Wine Contributors, I seek help from designers, developers, testers,defect fixers,project managers or playing any other key role in Free/Open Source software development or maintenence in carrying out a study on practices and problems of defect management in various Free/Open Source Software projects. The insights gained from the study can further help us to extract publicly accessible defect data and determine impact of defect management practices on software quality. Please spend a few minutes of your precious time to fill up the Questionnaire. The most of the questions follow multiple choice formats and are quite easy to answer. To have the Online Questionnaire, please visit: http://anu.puchd.ac.in/phpESP/public/survey.php?name=FOSS_Defect_Survey (You can also copy and paste this link into your browser, and hit the 'Return' key.) I hope you will find all the questions interesting and thought-provoking. Your answers will be kept anonymous.The data thus collected will only be used for research purpose.It would be nice if you may further refer this mail to others actively engaged with Free/Open Source Software development. If you have any query or suggestions then feel free to contact. Thank You With regards, Anu Gupta Senior Lecturer Department of Computer Science and Applications, Panjab University, Chandigarh. INDIA In case of any problem in accessing/using the above mentioned link please contact: E-mail: anugupta(a)pu.ac.in anugupta98(a)gmail.com

1 0

Time for an advapi category in bugzilla?
by Dan Kegel 12 Mar '07

12 Mar '07

I just filed a bug related to wine's advapi implementation ( http://bugs.winehq.org/show_bug.cgi?id=7690 ) and noticed there wasn't an advapi category in Bugzilla. Should there be? - Dan

1 0

Re: mapi32: Add DebugInfo to critical sections.
by Uwe Bonnes 12 Mar '07

12 Mar '07

>>>>> "Jan" == Jan Zerebecki <jan.wine(a)zerebecki.de> writes: Jan> --- If this patch is rejected from inclusion, please tell me why, Jan> as I would have to ask anyway. Nice disclaimer ;-) I wonder if it works? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: wined3d: Implented signed texture formats via NV_TEXTURE_SHADER
by Frank Richter 11 Mar '07

11 Mar '07

On 10.03.2007 15:02, Fabian Bieler wrote: > +static const PixelFormatDesc NV_texture_shader_formats[] = { > + {WINED3DFMT_V8U8 ,0x0 ,0x0 ,0x0 ,0x0 ,2 ,FALSE ,GL_SIGNED_HILO8_NV ,GL_HILO_NV ,GL_BYTE }, Are you sure this is right? From the NV_texture_shader spec it looks to me like HILO is for high-precision data, and that DSDT (described as offset data) would be more appropriate for V8U8. -f.r.

2 1

Re: Alexandre Julliard : ntdll: Fixed a compiler warning for size_t/ unsigned int mismatch.
by Francois Gouget 11 Mar '07

11 Mar '07

On Fri, 9 Mar 2007, Alexandre Julliard wrote: [...] > void * __cdecl _lfind( const void *key, const void *base, unsigned int *nmemb, > - unsigned int size, int(*compar)(const void *, const void *) ) > + size_t size, int(*compar)(const void *, const void *) ) > { > - return lfind( key, base, nmemb, size, compar ); > + size_t n = *nmemb; > + return lfind( key, base, &n, size, compar ); > } The problem is that Microsoft's _lfind() takes an 'unsigned int' and not a size_t. Or, more precisely, the msvcrt one declared in search.h does. There's no official prototype for the ntdll implementation that I know of, but I'd expect it to have the same prototype. So my understanding is that replacing this parameter type with a size_t could be a problem on 64bit systems. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

2 3

DIB Engine & GSoC
by Benoit Pradelle 11 Mar '07

11 Mar '07

Hi, I would like participate to the Google Summer Of Code with Wine by implementing a DIB Engine. I've searched a lot of informations about the DIB Engine but i still got one question : for you, how important is a DIB Engine in Wine ? Ben. ___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com

10 14

Tackling gdiplus?
by Dan Kegel 11 Mar '07

11 Mar '07

An increasing number of apps need gdiplus.dll. Seems like it's time for Wine to include it. Since Mono has implemented much of gdiplus already ( http://www.mono-project.com/Libgdiplus ), we ought to be able to just slurp that into Wine and get quite a ways. Any objections? I'm thinking of asking a summer intern to try this. - Dan

5 8

Memory checking?
by Giles Cameron 11 Mar '07

11 Mar '07

Ok. I am just entering the WINE development crowd, and have very very little experiance with the Windows API (The first time I saw it, I was terrifyed!) Anywho. It would appear that some programs decide there isn't enough free memory available for their tasks (EG, Train Simulator's CAB extaction process, I have yet to look further into this to see if I even have the slightest clue what I am talking about, however) so I was wondering if we could hack in an option to allow the API to tell a little fib on the free memory, since (From what I understand) Linux is so much better with memory. Sorry if I am randomly babbling, my brain is off around 02:30. ;) (Thats my current local time.)

2 1

0.9.32 hangs UltraVNC Viewer after a while
by Dieter Rogiest 11 Mar '07

11 Mar '07

Mandriva Linux 2007.0 here. With wine 0.9.30 ultravnc_viewer.exe (remote access) works perfect. I installed wine 0.9.32 (wine-0.9.32-1.SoS.2007.0.i586.rpm). Using ultravnc_viewer.exe I saw immediately that the fullscreen title bar that should appear when you move your mouse to the top of the screen was now allways visible also in windowed mode. After a while (4 minutes) ultravnc_viewer stopped working, I could still see the remote desktop but my mouse clicks didn't happen. I went back to 0.9.30. Dieter

3 2

Known desktop migration projects and their "must have" Windows apps
by Dan Kegel 11 Mar '07

11 Mar '07

I'm putting a list together at http://wiki.winehq.org/DesktopMigrationProjects listing organizations who are migrating their users from Windows to Linux. I only list projects that have come out and said which Windows applications they really want to run on Linux. Since these migration projects, if they end up using Wine, will be very good publicity for the project, it might behoove us to look carefully at whether we can get the apps they need running. I know Banco do Brasil's folks are quite happy at the effort put into Lotus Notes 5.x recently, so it is possible for us to make a difference. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

appdb needs to allow untested applications sometimes
by Dan Kegel 11 Mar '07

11 Mar '07

I tried to add an appdb entry for FINView because it's one of the applications required by the LiMux project, and I'm trying to add links into the appdb for all apps listed on http://wiki.winehq.org/LiMuxWineKeller . It's an addon for a commercial product I don't have, so I couldn't test it. That means I had to lie to the appdb to get it to accept the entry. Appdb maintainers, please remove the "only submit tested applications" restriction from the appdb, or at least allow people who know what they're doing to get around it.

4 4

Re: WineD3D: Blit the offscreen texture into the drawable if needed
by Ivan Gyurdiev 11 Mar '07

11 Mar '07

> This time cube texture support is added. Hopefully the coords are right, I had > no test app for them. If not it should be easy to spot the very > characteristic flipping of the image. > I'm confused - you replaced a patch which had no support for cube maps, with one that has untested support for cube maps?

2 1

Re: wined3d: Implented signed texture formats via NV_TEXTURE_SHADER
by Stefan Dösinger 11 Mar '07

11 Mar '07

Am Samstag 10 März 2007 15:02 schrieb Fabian Bieler: > This patch implements D3DFMT_V8U8 and D3DFMT_Q8W8V8U8 via > NV_TEXTURE_SHADER. This fixes some renderissues in Half-Life 2 with the > DirectX9 path and the DirectX8 path via GLSL. What do those formats provide that other formats do not provide? Signedness, or something else I missed? Using GL_NV_texture shader and GL_ATI_envmap bumpmap is definitly the way to go, but I am concerned about macos, where neither of those extensions exist. But working around that issue will be tricky because the shaders depend more on the stateblock then, and things get increasingly ugly. Oh, and it seems that you have proven me wrong with my suspicion that sRGB correction is the cause of that :-)

3 2

Re: kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS fix
by Felix Nawothnig 10 Mar '07

10 Mar '07

Andrew O.Shadoura wrote: > +#if 0 > static int once; > +#endif > > if (!src || (!dst && dstlen)) > { > @@ -1774,11 +1783,13 @@ INT WINAPI MultiByteToWideChar( UINT pag > > if (srclen < 0) srclen = strlen(src) + 1; > > +#if 0 > if (!once && (flags & MB_USEGLYPHCHARS)) > { > once = 1; > FIXME("MB_USEGLYPHCHARS not supported\n"); > } > +#endif If you implemented MB_USEGLYPHCHARS just remove the FIXME. Don't submit dead code - git will remember all revisions... Felix

1 0

appdb needs to allow untested applications
by Dan Kegel 10 Mar '07

10 Mar '07

I tried to add an appdb entry for FINView because it's one of the applications required by the LiMux project. It's an addon for a commercial product I don't have, so I couldn't test it. That means I had to lie to the appdb to get it to accept the entry. Please remove the "only submit tested applications" restriction from the appdb, or at least allow people who know what they're doing to get around it. -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Patches in bugzilla
by Vijay Kiran Kamuju 10 Mar '07

10 Mar '07

Hi, There are some patches that are attached in the bugzilla. They havent sent to wine-patches mailing list. Can I mail them to the mailing list on their behalf? I have asked them to submit to the mailing list. The patches are submitted about 2 months back. Thanks, VJ

2 1

Quick, how do you install native dcom? Or the visual C++ runtimes? Or...
by Dan Kegel 10 Mar '07

10 Mar '07

OK, I've been doing bug triage on and off for years, but just recently I've gotten to the point where I'm tired of going to the NativeDCOM wiki page to remember how to try an app with native dcom just to see if the bug in question is a COM bug. So I wrote a trivial script to automate installing that plus a bunch of other redistributables. A draft is at http://kegel.com/wine/winetricks Usage: winetricks [dcom98|fakeie6|mdac26|mfc40|mono|vbrun60|vcrun6|wsh51|wsh56jscript] ... It's a bit like a programmer's version of winetools: it's so commandline-crufty that normal users won't go near it, but it's simple enough to extend that it will probably end up being pretty handy for anyone working on triaging bugs that appear to be due to missing redistributable libraries. Oh, or commonly-needed registry entries. - Dan

2 2

Re: Add Xcursor support
by Adam Petaccia 10 Mar '07

10 Mar '07

4 3

Re: wined3d: Allow SetCursorProperties on existing cursor
by Stefan Dösinger 10 Mar '07

10 Mar '07

Am Samstag 10 März 2007 06:10 schrieb Erich Hoover: > Real Name: > Erich Hoover > Description: > The SetCursorProperties call needs to be capable of being performed on > existing cursors. The current behavior removes the cursor handle at the > beginning of any SetCursorProperties call (and on Uninit3D). The removal > of the cursor on SetCursorProperties is counter to the documentation and > causes some applications to lose the cursor when SetCursorProperties is > re-issued (See Bug #7619 <http://bugs.winehq.org/show_bug.cgi?id=7619>). > This patch corrects this issue and permits SetCursorProperties to retrieve > the gl texture of an old cursor. > Changelog: > wined3d: Allow SetCursorProperties on existing cursor This is not completely correct: The application can Release the d3d surface after setting the cursor. This would also delete the gl texture used to draw the cursor. Also, the apps can potentially change the surface and call PreLoad. This would change the cursor without SetCursorProperties(The cursor texture does not have to be in D3DPOOL_SCRATCH, so the app can preload it manually). But you are right, a non-dirty surface causes issues with the current code. I think you can fix that by modifying LoadTexture not to release the surface memory is SFLAG_FORCELOAD is passed. (Or better, fix the SFLAG_DONOTFREE macro in wined3d_private.h). Then, when SetCursorProperties sets the surface texture to 0 remove SFLAG_INTEXTURE from the surface flags.

1 0

Settlers II: 10th Anniversary regression?
by Markus 10 Mar '07

10 Mar '07

Hi, when trying the demo of the above game ( http://appdb.winehq.org/appview.php?iVersionId=5346 ) with 0.9.30, it loads the main menu and allows you to enter a game. In 0.9.32, it does not start anymore at all (it hangs after opening a window) with the following messages: fixme:wininet:InternetSetOptionExA Flags 04000000 ignored fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CONNECT_TIMEOUT (1000): STUB fixme:wininet:InternetSetOptionExA Flags 04000000 ignored fixme:wininet:InternetSetOptionW INTERNET_OPTION_SEND/RECEIVE_TIMEOUT not supported on protocol 1 err:ntdll:RtlpWaitForCriticalSection section 0x110020 "heap.c: main process heap section" wait timed out in thread 0009, blocked by 000d, retrying (60 sec) Could this be a regression in DirectPlay? Regards, -- Markus

6 16

Question about OpenGL/D3D
by Mike Schaadt 10 Mar '07

10 Mar '07

Has anyone tested using standard window objects in a window that also had an opengl/d3d context? I believe Terragen 2 is attempting to do this. If this hasn't been tested, than it might be the cause of all of the static that appears non opengl area, making the program nearly unusable. No messages get printed to the console from wine(Terragen 2 prints out a fair bit of debug info there, but nothing from wine that would cause the problem, just a few warnings that shouldn't be related). Any thoughts?

4 4

Re: Shader instruction table whitespace cleanup
by Ivan Gyurdiev 10 Mar '07

10 Mar '07

Kevin Wallerbos wrote: > This formatting patch cleans up the spacing in the pixel/vertexshader > instruction table, making it somewhat nicer on the eyes. The lines > have become a bit longer than practical on standard resolutions, but > that shouldn't be a problem as most lines were already too long. A better thing to do is to remove the useless GLNAME_REQUIRE_GLSL, and "undefined" instruction names. In fact, it may be nice to break out the instruction names out of this table completely, since they are only necessary for some instructions, required by the map2gl function. This table is also organized poorly, you have to search through the whole thing, and then do version comparisons to find anything. If possible, it would be great to make it O(1) accessible. ===== Also, as you point out: Before patch : "most lines were already too long" [ I'd say some lines were too long ] After patch: "all lines are too long" Not sure what is gained... please don't force others to your resolution preferences. [ looking at this on a widescreen at 1680 x 1050 and it still wraps! ]

1 0

Re: user32: avoid NULL pointer access in DefWindowProcA WM_NCCREATE
by Felix Nawothnig 10 Mar '07

10 Mar '07

Jan Zerebecki wrote: > CREATESTRUCTA *cs = (CREATESTRUCTA *)lParam; > /* check for string, as static icons, bitmaps (SS_ICON, SS_BITMAP) > * may have child window IDs instead of window name */ > - if (HIWORD(cs->lpszName)) > + if (cs && HIWORD(cs->lpszName)) cs is never NULL at that point. Felix

2 3

Don't compare file handles to NULL
by Francois Gouget 09 Mar '07

09 Mar '07

Jacek just sent a patch fixing the following bug: file = CreateFileW(fileName, GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_READONLY,NULL); - if(file) { + if(file != INVALID_HANDLE_VALUE) { This looks like something that could be turned into a nice Smatch test. Hint, hint... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In theory, theory and practice are the same, but in practice they're different.

4 13

Re: comctl32: treeview: Message sequencing tests
by Marcelo Duarte 09 Mar '07

09 Mar '07

Chris Peterson escreveu: > This is another patch for my CS130 assignment. It adds message > sequencing tests. Other changes include: I updated one of my previous > tests which was not testing the implied message; I changed a > SendMessageW to SendMessageA call in DoFocusTest to fix a problem on > Windows 98 due to a lack of default unicode support. Any > comments/suggestions are welcome. > Thanks! > -Chris > Hi! > > @@ -166,7 +315,8 @@ static void DoFocusTest(void) > assert(hChild2); > > ShowWindow(hMainWnd,SW_SHOW); > - SendMessageW(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)hChild); > + /* Using SendMessageA since Win98 doesn't have default unicode support */ > + SendMessageA(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)hChild); > Use SendMessage() instead. > static void TestGetSetInsertMarkColor(void) > { > COLORREF crColor = RGB(0,0,0); > - SendMessage( hTree, TVM_SETBKCOLOR, 0, crColor ); > - crColor = (COLORREF)SendMessage( hTree, TVM_GETBKCOLOR, 0, 0 ); > + SendMessage( hTree, TVM_SETINSERTMARKCOLOR, 0, crColor ); > + crColor = (COLORREF)SendMessage( hTree, TVM_GETINSERTMARKCOLOR, 0, 0 ); > ok(crColor == RGB(0,0,0), "Insert mark color reported as 0x%.8x, expected 0x00000000\n", crColor); >

2 1

Re: gdi32: Add a GetTextMetrics test, make it pass under Wine
by Lei Zhang 09 Mar '07

09 Mar '07

I tested it out on a couple machines and found many failure cases. (output attached) As a sanity check, I copied the deja vu family of fonts to a windows box and they passed the tests there. On 3/9/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Hello, > > this patch should partially resolve a problem reported in the bug 5783. > > In Wine GetTextMetricsW returns wrong tmFirstChar/tmLastChar, and > GetFontUnicodeRanges returns wrong ranges for fonts with SYMBOL_CHARSET. > > Changelog: > gdi32: Add a GetTextMetrics test, make it pass under Wine. > > --- > dlls/gdi32/font.c | 9 ++- > dlls/gdi32/freetype.c | 4 +- > dlls/gdi32/tests/font.c | 141 ++++++++++++++++++++++++++++++++++++++++++++++- > 3 files changed, 149 insertions(+), 5 deletions(-) > > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index 1b1d8b4..785a990 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -287,10 +287,12 @@ static void FONT_TextMetricWToA(const TEXTMETRICW *ptmW, LPTEXTMETRICA ptmA ) > ptmA->tmOverhang = ptmW->tmOverhang; > ptmA->tmDigitizedAspectX = ptmW->tmDigitizedAspectX; > ptmA->tmDigitizedAspectY = ptmW->tmDigitizedAspectY; > - ptmA->tmFirstChar = ptmW->tmFirstChar > 255 ? 255 : ptmW->tmFirstChar; > + ptmA->tmBreakChar = ptmW->tmBreakChar > 255 ? 255 : ptmW->tmBreakChar; > + /* This appears to be what Windows does */ > + ptmA->tmFirstChar = ptmW->tmBreakChar; > + if (ptmA->tmFirstChar >= 2) ptmA->tmFirstChar -= 2; > ptmA->tmLastChar = ptmW->tmLastChar > 255 ? 255 : ptmW->tmLastChar; > ptmA->tmDefaultChar = ptmW->tmDefaultChar > 255 ? 255 : ptmW->tmDefaultChar; > - ptmA->tmBreakChar = ptmW->tmBreakChar > 255 ? 255 : ptmW->tmBreakChar; > ptmA->tmItalic = ptmW->tmItalic; > ptmA->tmUnderlined = ptmW->tmUnderlined; > ptmA->tmStruckOut = ptmW->tmStruckOut; > @@ -1366,6 +1368,9 @@ BOOL WINAPI GetTextMetricsW( HDC hdc, TEXTMETRICW *metrics ) > /* device layer returns values in device units > * therefore we have to convert them to logical */ > > + metrics->tmDigitizedAspectX = GetDeviceCaps(hdc, LOGPIXELSX); > + metrics->tmDigitizedAspectY = GetDeviceCaps(hdc, LOGPIXELSY); > + > #define WDPTOLP(x) ((x<0)? \ > (-abs(INTERNAL_XDSTOWS(dc, (x)))): \ > (abs(INTERNAL_XDSTOWS(dc, (x))))) > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index db990fa..03adfe5 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -4480,7 +4480,7 @@ static DWORD get_font_unicode_ranges(FT_Face face, GLYPHSET *gs) > { > DWORD num_ranges = 0; > > - if (face->charmap->encoding == FT_ENCODING_UNICODE && pFT_Get_First_Char) > + if (pFT_Get_First_Char) > { > FT_UInt glyph_code; > FT_ULong char_code, char_code_prev; > @@ -4488,7 +4488,7 @@ static DWORD get_font_unicode_ranges(FT_Face face, GLYPHSET *gs) > glyph_code = 0; > char_code_prev = char_code = pFT_Get_First_Char(face, &glyph_code); > > - TRACE("face encoding FT_ENCODING_UNICODE, number of glyphs %ld, first glyph %u, first char %04lx\n", > + TRACE("number of glyphs %ld, first glyph %u, first char %04lx\n", > face->num_glyphs, glyph_code, char_code); > > if (!glyph_code) return 0; > diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c > index 43e9c3a..a996ff0 100644 > --- a/dlls/gdi32/tests/font.c > +++ b/dlls/gdi32/tests/font.c > @@ -408,7 +408,7 @@ static void test_GdiGetCharDimensions(void) > > if (!pGdiGetCharDimensions) > { > - skip("GetFontUnicodeRanges not available on this platform\n"); > + skip("GdiGetCharDimensions not available on this platform\n"); > return; > } > > @@ -1149,6 +1149,7 @@ static void test_GetFontUnicodeRanges(void) > > size = pGetFontUnicodeRanges(hdc, gs); > ok(size, "GetFontUnicodeRanges failed\n"); > + ok(gs->cRanges != 0, "GetFontUnicodeRanges returned empty ranges\n"); > #if 0 > for (i = 0; i < gs->cRanges; i++) > trace("%03d wcLow %04x cGlyphs %u\n", i, gs->ranges[i].wcLow, gs->ranges[i].cGlyphs); > @@ -1397,6 +1398,143 @@ else > ReleaseDC(0, hdc); > } > > +static void test_text_metrics(const LOGFONTA *lf) > +{ > + HDC hdc; > + HFONT hfont, hfont_old; > + TEXTMETRICA tmA; > + TEXTMETRICW tmW; > + UINT first_unicode_char = 0, last_unicode_char = 0; > + INT ret, test_char; > + const char *font_name = lf->lfFaceName; > + > + trace("Testing font metrics for %s, charset %d\n", font_name, lf->lfCharSet); > + > + hdc = GetDC(0); > + > + SetLastError(0xdeadbeef); > + hfont = CreateFontIndirectA(lf); > + ok(hfont != 0, "CreateFontIndirect error %u\n", GetLastError()); > + > + hfont_old = SelectObject(hdc, hfont); > + > + if (pGetFontUnicodeRanges) > + { > + DWORD size; > + GLYPHSET *gs; > + > + size = pGetFontUnicodeRanges(hdc, NULL); > + ok(size, "GetFontUnicodeRanges failed unexpectedly\n"); > + > + gs = HeapAlloc(GetProcessHeap(), 0, size); > + > + size = pGetFontUnicodeRanges(hdc, gs); > + ok(size, "GetFontUnicodeRanges failed\n"); > + ok(gs->cRanges != 0, "GetFontUnicodeRanges returned empty ranges\n"); > + > + first_unicode_char = gs->ranges[0].wcLow; > + last_unicode_char = gs->ranges[gs->cRanges - 1].wcLow + gs->ranges[gs->cRanges - 1].cGlyphs - 1; > + trace("for %s first char %x, last char %x\n", font_name, > + first_unicode_char, last_unicode_char); > + > + HeapFree(GetProcessHeap(), 0, gs); > + } > + > + SetLastError(0xdeadbeef); > + ret = GetTextMetricsA(hdc, &tmA); > + ok(ret, "GetTextMetricsA error %u\n", GetLastError()); > + > + trace("A: first %x, last %x, default %x, break %x\n", > + tmA.tmFirstChar, tmA.tmLastChar, tmA.tmDefaultChar, tmA.tmBreakChar); > + > + SetLastError(0xdeadbeef); > + ret = GetTextMetricsW(hdc, &tmW); > + ok(ret, "GetTextMetricsA error %u\n", GetLastError()); > + > + trace("W: first %x, last %x, default %x, break %x\n", > + tmW.tmFirstChar, tmW.tmLastChar, tmW.tmDefaultChar, tmW.tmBreakChar); > + > + /* This appears to be what Windows does */ > + test_char = tmW.tmBreakChar; > + if (test_char >= 2) test_char -= 2; > + if (test_char > 255) test_char = 255; > + ok(tmA.tmFirstChar == test_char, "tmFirstChar for %s %02x != %02x\n", > + font_name, tmA.tmFirstChar, test_char); > + > + /* This test failes for Marlett, Wingdings 2 and Wingdings 3, but succeeds > + * for all other 327 truetype fonts on my system. > + */ > +#if 0 > + test_char = tmW.tmLastChar > 255 ? 255 : tmW.tmLastChar; > + ok(tmA.tmLastChar == test_char, "tmLastChar for %s %02x != %02x\n", > + font_name, tmA.tmLastChar, test_char); > +#endif > + if (pGetFontUnicodeRanges) > + { > + ok(tmW.tmFirstChar == first_unicode_char, "tmFirstChar for %s %02x != %02x\n", > + font_name, tmW.tmFirstChar, first_unicode_char); > +/* FIXME: remove completely once Wine is fixed > + * GetFontUnicodeRanges in Wine returns wrong data for fonts with > + * SYMBOL_CHARSET. > + */ > +if (tmW.tmLastChar != last_unicode_char) > +todo_wine ok(tmW.tmLastChar == last_unicode_char, "tmLastChar for %s %02x != %02x\n", > + font_name, tmW.tmLastChar, last_unicode_char); > +else > + ok(tmW.tmLastChar == last_unicode_char, "tmLastChar for %s %02x != %02x\n", > + font_name, tmW.tmLastChar, last_unicode_char); > + } > + > + ret = GetDeviceCaps(hdc, LOGPIXELSX); > + ok(tmW.tmDigitizedAspectX == ret, "tmDigitizedAspectX %u != %u\n", > + tmW.tmDigitizedAspectX, ret); > + ret = GetDeviceCaps(hdc, LOGPIXELSY); > + ok(tmW.tmDigitizedAspectX == ret, "tmDigitizedAspectY %u != %u\n", > + tmW.tmDigitizedAspectX, ret); > + > + SelectObject(hdc, hfont_old); > + DeleteObject(hfont); > + > + ReleaseDC(0, hdc); > +} > + > +static INT CALLBACK enum_truetype_font_proc(const LOGFONT *lf, const TEXTMETRIC *ntm, DWORD type, LPARAM lParam) > +{ > + INT *enumed = (INT *)lParam; > + > + if (type == TRUETYPE_FONTTYPE) > + { > + (*enumed)++; > + test_text_metrics(lf); > + } > + return 1; > +} > + > +static void test_GetTextMetrics(void) > +{ > + LOGFONTA lf; > + HDC hdc; > + INT enumed; > + > + SetLastError(0xdeadbeef); > + GetTextMetricsW(0, NULL); > + if (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > + { > + skip("Skipping GetTextMetrics test on a Win9x platform\n"); > + return; > + } > + > + hdc = GetDC(0); > + > + memset(&lf, 0, sizeof(lf)); > + lf.lfCharSet = DEFAULT_CHARSET; > + enumed = 0; > + EnumFontFamiliesExA(hdc, &lf, enum_truetype_font_proc, (LPARAM)&enumed, 0); > + trace("Tested metrics of %d truetype fonts\n", enumed); > + > + ReleaseDC(0, hdc); > +} > + > START_TEST(font) > { > init(); > @@ -1427,4 +1565,5 @@ START_TEST(font) > } > else > skip("Arial Black or Symbol/Wingdings is not installed\n"); > + test_GetTextMetrics(); > } > -- > 1.5.0.2 > > > > > >

1 0

re: Writing a winelib plugin
by Dan Kegel 09 Mar '07

09 Mar '07

Shachar wrote: >It used to not be possible to write a plugin, to be loaded from a >standard Linux ELF program, that will be itself a winelib shared object. >All sorts of issues regarding running wineserver and memory layout >initializations were problematic. > >I'm wondering whether there is any news on that front. Is it still not >practically possible to do this? Last time I asked about this, I got the impression that there was some hope but nobody was working on it. And I think it would require linking something statically into the program, too, so if you're trying to foist winelib shared objects onto an unsuspecting Big App, you're probably going to be out of luck even if this gets worked on. What application did you have in mind?

3 2

Re: [Bug 7503] Eve Online pasword box on login screen doesn't work
by Lei Zhang 09 Mar '07

09 Mar '07

Can we change wineprefixcreate to copy the truetype fonts (if any) from /usr/X11R6/lib/X11/fonts/TTF or /usr/share/X11/fonts/TTF or [insert distro specific X11/fonts/TTF directory] to $WINEPREFIX/drive_c/windows/fonts/ ? On 2/20/07, Wine Bugs <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=7503 > > > > > > ------- Additional Comments From kelfe(a)gmx.de 2007-20-02 16:57 ------- > to fix the issue you need to copy the font file arial.ttf into > .wine/drive_c/windows/fonts folder (.wine is a hidden folder) > > the arial.ttf can be found in the mscorefonts packages or search engine/windows box > > I don't know if font files should be placed in the fonts folder by wine or by > the user. So close this bug or keep it open until basic fonts are installed by > wine when creating the .wine folder. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the assignee for the bug, or are watching the assignee. > > >

3 3

New opengl thread context selection patches for testing
by Stefan Dösinger 09 Mar '07

09 Mar '07

Hi, Here is a new patchset for testing which implements duplicating gl contexts for new threads in wined3d. Again, it does not implement any synchronisation measures(except ENTER_GL and glFinish), so running multithreaded games is still kinda a lottery. This patchset also contains a patch for offscreen rendering, which may fix the problems introduced with TES: Oblivion before. This is just a format-patch of my git tree, the first 3 patches are unrelated. One of them is a clone of Henri's already sent patch, and the other 2 patches were sent by me already. Happy testing, Stefan

3 7

Re: [2/2] wined3d: IWineD3DDeviceImpl_UpdateSurface: return D3DERR_INVALIDCALL if source and dest format do not match
by Fabian Bieler 09 Mar '07

09 Mar '07

Please ignore this patch.

1 0

Is there someone working on dxdiag?
by Mirek 09 Mar '07

09 Mar '07

Hi, I would like to start some applications like Carmageddon TDR 2000 in HW mode, Neverwinter Nights 2 or just GetGPUAndSystemInfo.exe from Nvidia SDK demos and maybe 3DMark with HW info, but there are problems with detecting video card, I assume the main problem is in dxdiag library. So I would like to ask if there is someone working on this library, or if was there some code which was not accepted in wine tree to fix that? I am trying to hack this library, but with only small success. Mirek Slugen

3 3

Re: quartz: Check allocation failure and clear memory in DSound Renderer
by Robert Shearman 09 Mar '07

09 Mar '07

Chris Robinson wrote: > return CLASS_E_NOAGGREGATION; > > pDSoundRender = CoTaskMemAlloc(sizeof(DSoundRenderImpl)); > + if (!pDSoundRender) > + return E_OUTOFMEMORY; > + ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl)); > > pDSoundRender->lpVtbl = &DSoundRender_Vtbl; > pDSoundRender->IBasicAudio_vtbl = &IBasicAudio_Vtbl; > @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv) > pDSoundRender->pClock = NULL; > pDSoundRender->init = FALSE; > pDSoundRender->started = FALSE; > - ZeroMemory(&pDSoundRender->filterInfo, sizeof(FILTER_INFO)); > The check for allocation failure is good, but clearing the memory that is going to be initialised anyway is inefficient and unnecessary. -- Rob Shearman

2 1

Re: [2/2] wined3d: IWineD3DDeviceImpl_UpdateSurface: return D3DERR_INVALIDCALL if source and dest format do not match
by H. Verbeet 09 Mar '07

09 Mar '07

On 09/03/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > + if (destFormat != srcFormat) { > + WARN("source %p and dest %p must match, returning WINED3DERR_INVALIDCALL\n", pSourceSurface, pDestinationSurface); > + return WINED3DERR_INVALIDCALL; > + } You should probably print the actual formats there, using debug_d3dformat(). Also, a test wouldn't hurt.

1 0

Fwd: wined3d: Update cursor position on ShowCursor
by Erich Hoover 09 Mar '07

09 Mar '07

Request for comments, as per http://www.winehq.com/site/sending_patches. For details on the need for this patch please see Bug #7542<http://bugs.winehq.org/show_bug.cgi?id=7542>. Thanks! Erich Hoover ehoover(a)mines.edu ---------- Forwarded message ---------- From: Erich Hoover <ehoover(a)mines.edu> Date: Mar 3, 2007 6:46 PM Subject: wined3d: Update cursor position on ShowCursor To: wine-patches(a)winehq.org Real Name: Erich Hoover Description: When ShowCursor is first called it should make the cursor appear at the OS's last known cursor position. Because of this, some applications just repetitively call ShowCursor in order to update the cursor's position. This behavior is undocumented. Changelog: wined3d: Update cursor position on ShowCursor

3 2

Re: Alexandre Julliard : advapi32: Fixed registry test that failed because of a buffer overflow.
by James Hawkins 09 Mar '07

09 Mar '07

On 3/8/07, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 7e2228f15aa7a6fc0d63fe36c34906035422e95a > URL: http://source.winehq.org/git/wine.git/?a=commit;h=7e2228f15aa7a6fc0d63fe36c… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Thu Mar 8 21:06:31 2007 +0100 > > advapi32: Fixed registry test that failed because of a buffer overflow. > The test passes in Windows, so isn't this hiding a bug in our implementation of RegSetValueW? -- James Hawkins

2 1

How does wine determine to draw non-client area according to managed mode setting?
by Sunil Baek 09 Mar '07

09 Mar '07

Hello, When wine runs on managed mode, it delegate drawing non-client area(caption, frame-border) to window manager. I found NC_DrawCaption function is not invoked on managed mode. On non-managed mode, that function is invoked. I tried to find routine which determine to draw non-client area according to managed mode setting, but I can't. please give me some hints about that. Thank you.

1 0

Re: comctl32: listview tests
by Lei Zhang 09 Mar '07

09 Mar '07

On 3/8/07, George Gov <ggov(a)ucla.edu> wrote: > @@ -573,10 +699,242 @@ static void test_redraw(void) > trace("invalidate & update\n"); > InvalidateRect(hwnd, NULL, TRUE); > UpdateWindow(hwnd); > - ok_sequence(sequences, LISTVIEW_SEQ_INDEX, redraw_listview_seq, "redraw listview", FALSE); > + ok_sequence(sequences, LISTVIEW_SEQ_INDEX, redraw_listview_seq, "redraw listview", TRUE); This test succeeds for me, so I'm not sure why you marked it as todo. - Lei

1 0

Re: quartz: Use proper alloc/free functions for COM objects
by Detlef Riekenberg 09 Mar '07

09 Mar '07

On Do, 2007-03-08 at 03:06 -0800, Chris Robinson wrote: > Subject: [PATCH] quartz: Use proper alloc/free functions for COM > objects > + omr->messages = CoTaskMemAlloc(omr->ring_buffer_size * > sizeof(Event)); > + ZeroMemory(omr->messages, omr->ring_buffer_size * sizeof(Event)); > > + fimpl = CoTaskMemAlloc(sizeof(*fimpl)); > fimpl->IGraphBuilder_vtbl = &IGraphBuilder_VTable; > + This->ppPins = CoTaskMemAlloc((This->cStreams + 2) * sizeof(IPin > *)); > memcpy(This->ppPins, ppOldPins, (This->cStreams + 1) * > sizeof(IPin *)); > + This->ppPins = CoTaskMemAlloc(sizeof(IPin *) * 1); > memcpy(This->ppPins, ppOldPins, sizeof(IPin *) * 1); While reading your Patch, I see the above Places, where the result from the allocation is used without a NULL-check. The other allocations are checked for NULL before used. Is this correct? -- By by ... Detlef

2 1

Command and Conquer 3 Demo
by Matthew Clark 09 Mar '07

09 Mar '07

I just wanted to write to let all of the devs know how proud of the wine project I am. This Demo seems to work for the most part except for the movies in it don't seem to want to resize and when you are under attack the game crashes. Here is the console dump: fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=49332 < primary_done=49356) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=39800 < primary_done=39824) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=35960 < primary_done=35984) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36008 < primary_done=36032) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=39968 < primary_done=39992) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36128 < primary_done=36152) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36128 < primary_done=36152) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=38072 < primary_done=38076) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=38072 < primary_done=38076) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=38072 < primary_done=38076) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=34232 < primary_done=34236) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=38072 < primary_done=38096) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=34232 < primary_done=34256) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36152 < primary_done=36176) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36152 < primary_done=36176) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36152 < primary_done=36176) err:dsound:DSOUND_MixOne underrun on sound buffer 0x210b10 fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=34568 < primary_done=34592) wine: Unhandled page fault on read access to 0x0000fff7 at address 0x7efa2553 (thread 000e), starting debugger... fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=50292 < primary_done=50316) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:alsa:ALSA_AddRingMessage two fast messages in the queue!!!! toget = 52(WINE_WM_RESTARTING), tosave=53(UNKNOWN(0x00000000)) fixme:alsa:ALSA_AddRingMessage two fast messages in the queue!!!! toget = 36(WINE_WM_RESTARTING), tosave=37(UNKNOWN(0x00000000)) hope that helps. Again, greats that that is all that's wrong^_^ The graphics look great, it sounds great, and the videos are crystal clear(though small). -Matthew Clark

3 4

modification to allow -Wcast-qual to find potential warnings without unicode.h causing them
by Andrew Talbot 08 Mar '07

08 Mar '07

Assuming it is valid and does what is required, maybe the following pragma would be more precise. #pragma GCC diagnostic warning "-Wwrite-strings" -- Andy.

1 2

Interesting Winelib report
by Jeremy White 08 Mar '07

08 Mar '07

Hi Folks, John Gilmore alerted me to an attempted use of Winelib by the Cairo folks: http://lists.freedesktop.org/archives/cairo/2007-February/009707.html I've chatted privately with Behdad, who doesn't have a ton of time, but would be willing to poke a bit further if he had some help. I know that from time to time, people like to pick up this sort of project as a fun one, and I thought I'd see if I could spark someone into doing so with Cairo. Cheers, Jeremy

1 0

-Wcast-qual result
by Mike Schaadt 08 Mar '07

08 Mar '07

I submited a patch today that modified unicode.h that disables warnings(which allows for -Wcast-qual to actually give relevant results) I don't know if it will be accepted or not(it has the potential of being problematic if modifying unicode.h that would normally result in a warning, but this patch would cause it to be suppresed), but I figured I would at least share the results I found. after configuring with cast-qual, I stored the warnings that resulted(which I've included as an attachment for those that are interested.). There were no warnings in the make depend, and make generated 545 warnings(all from .c files). The included file does not contain the sub directory for what file generates the warning. If anyone knows how to pull that data, let me know and I'll redo it and extract that information as well. I plan on start looking through these and working on fixing some here soon, but I thought I would share what I found with this group in general.

1 0

Re: wine-devel Digest, Vol 20, Issue 30
by Alessandro Pignotti 08 Mar '07

08 Mar '07

> Date: Thu, 8 Mar 2007 08:22:59 +0100 > From: Kai Blin <kai.blin(a)gmail.com> > > > /* FIXME: Should we be storing these dwFlags or the creation ones? */ > > - lpPData = DP_CreatePlayer( This, lpidPlayer, lpPlayerName, dwFlags, > > + /* I think we should pass creation flags, so we can distinguish > > sysplayers and not count them in the current + player total */ > > + lpPData = DP_CreatePlayer( This, lpidPlayer, lpPlayerName, > > dwCreateFlags, hEvent, bAnsi ); > > Every time someone uses "I think" in the code, usually this calls for a > test case. This one should be rather straightforward to test. It's not possible to write a conformance test because i'm using a flag internal to wine's implementation of directplay, It's possible to safely change "I think we should" with "we have to". I've used "i think" more as an answer to the previous FIXME comment we have inherited from the author of the code. Regards Alessandro Pignotti > > Cheers, > Kai > > -- > Kai Blin, <kai Dot blin At gmail Dot com> > WorldForge developer http://www.worldforge.org/ > Wine developer http://wiki.winehq.org/KaiBlin/ > -- > Will code for cotton. -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

2 1

Serial port problem - again
by Aleš Rom 08 Mar '07

08 Mar '07

Hello. I'm new to this list. First I must say that I apologise for posting this mail again here. I hope you wine gurus can see what is going wrong here. If I run this app <http://appdb.winehq.org/appview.php?iAppId=4165> with WINEDEBUG=+relay , I can transfer data from my device to PC, but not all of it. It stops somewhere in the middle of the transfer. Without +relay option, device is not even accesible. It just say: [romcek@core2 ~]$ WINEDEBUG=+trace,+comm wine /home/romcek/.wine/drive_c/Program\ Files/SMA/Sunny\ Data\ Control/SDC.exe err:systray:delete_icon invalid tray icon ID specified: 0d fixme:tapi:lineInitialize (0x832f88, 0x11c0000, 0x11c2dfc, "TAPICOMM", 0x832f8c): stub. fixme:tapi:lineGetDevCapsA ((nil), 00000000, 00010003, 00000000, 0xf7eaf8): stub. fixme:tapi:lineGetDevCapsA ((nil), 00000000, 00010003, 00000000, 0xf7eb2c): stub. fixme:ras:RasEnumEntriesA ((nil),(null),0xf7fc80,0x34f5d8,0xf7ec38),stub! fixme:ras:RasEnumDevicesA ((nil),0x34f60c,0x34f608),stub! fixme:ras:RasEnumDevicesA (0x777fe0,0x34f60c,0x34f608),stub! trace:comm:GetCommState handle 0x144, ptr 0x34f9b8 trace:comm:io_control 0x144 IOCTL_SERIAL_GET_BAUD_RATE (nil) 0 0x34f988 4 0x34f914 trace:comm:io_control 0x144 IOCTL_SERIAL_GET_LINE_CONTROL (nil) 0 0x34f98d 3 0x34f914 trace:comm:io_control 0x144 IOCTL_SERIAL_GET_HANDFLOW (nil) 0 0x34f970 16 0x34f914 trace:comm:io_control 0x144 IOCTL_SERIAL_GET_CHARS (nil) 0 0x34f982 6 0x34f914 trace:comm:GetCommState OK trace:comm:dump_dcb bytesize=8 baudrate=19200 fParity=0 Parity=0 stopbits=1 trace:comm:dump_dcb ~IXON ~IXOFF trace:comm:dump_dcb fOutxCtsFlow=0 fRtsControl=0 trace:comm:dump_dcb fOutxDsrFlow=0 fDtrControl=1 trace:comm:dump_dcb ~CRTSCTS trace:comm:dump_dcb bytesize=8 baudrate=19200 fParity=0 Parity=0 stopbits=1 trace:comm:dump_dcb ~IXON ~IXOFF trace:comm:dump_dcb fOutxCtsFlow=0 fRtsControl=1 trace:comm:dump_dcb fOutxDsrFlow=0 fDtrControl=1 trace:comm:dump_dcb ~CRTSCTS trace:comm:io_control 0x144 IOCTL_SERIAL_SET_BAUD_RATE 0x34f988 4 (nil) 0 0x34f914 trace:comm:io_control 0x144 IOCTL_SERIAL_SET_LINE_CONTROL 0x34f98d 3 (nil) 0 0x34f914 trace:comm:io_control 0x144 IOCTL_SERIAL_SET_HANDFLOW 0x34f970 16 (nil) 0 0x34f914 trace:comm:io_control 0x144 IOCTL_SERIAL_SET_CHARS 0x34f982 6 (nil) 0 0x34f914 trace:comm:io_control 0x144 IOCTL_SERIAL_SET_QUEUE_SIZE 0x34f98c 8 (nil) 0 0x34f930 fixme:comm:set_queue_size insize 1024 outsize 1024 unimplemented stub trace:comm:io_control 0x144 IOCTL_SERIAL_GET_COMMSTATUS (nil) 0 0x61b196c8 20 0x61b19660 trace:comm:io_control 0x144 IOCTL_SERIAL_GET_COMMSTATUS (nil) 0 0x61b196c8 20 0x61b19660 trace:comm:io_control 0x144 IOCTL_SERIAL_GET_COMMSTATUS (nil) 0 0x61b196c8 20 0x61b19660 trace:comm:io_control 0x144 IOCTL_SERIAL_GET_COMMSTATUS (nil) 0 0x61b196c8 20 0x61b19660 trace:comm:io_control 0x144 IOCTL_SERIAL_GET_COMMSTATUS (nil) 0 0x61b196c8 20 0x61b19660 last line is repeating and then nothing hapens. It looks like delay issue to me, but I'm not a programmer. Can someone help, plese. Thanks, Ales

1 0

[winealsa] Mind buffer loops when pausing
by Chris Bandy 08 Mar '07

08 Mar '07

This patch should fix the incorrect handling of WaveHdr loops when pausing. Like the non-loop case written before, this sums the buffer lengths between dwPlayedTotal and dwWrittenTotal to calculate the new dwPartialOffset. Instead of blindly moving from one buffer to the next, however, this traverses the list using BeginWaveHdr and PlayPtrNext. This has added benefit of correctly initializing all pointers and counters for playback. It looks correct on paper, but I don't seem to have any applications that even attempt to pause. Can anyone suggest an application to test this with? All feedback welcome. Note: this branch in the function is a 'software' pause. To test you may need to override the check for ALSA's hardware pause at line 418 (snd_pcm_hw_params_can_pause) -- Chris diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 6a8a435..4ac50c6 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -319,9 +319,9 @@ static DWORD wodPlayer_NotifyCompletions(WINE_WAVEDEV* wwo, BOOL force) * * wodPlayer helper. Resets current output stream. */ -static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) +static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) { - int err; + int err; TRACE("(%p)\n", wwo); /* flush all possible output */ @@ -329,7 +329,7 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) wodUpdatePlayedTotal(wwo, NULL); /* updates current notify list */ - wodPlayer_NotifyCompletions(wwo, FALSE); + wodPlayer_NotifyCompletions(wwo, reset); if ( (err = snd_pcm_drop(wwo->pcm)) < 0) { FIXME("flush: %s\n", snd_strerror(err)); @@ -345,9 +345,6 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) DWORD param; HANDLE ev; - /* remove any buffer */ - wodPlayer_NotifyCompletions(wwo, TRUE); - wwo->lpPlayPtr = wwo->lpQueuePtr = wwo->lpLoopPtr = NULL; wwo->state = WINE_WS_STOPPED; wwo->dwPlayedTotal = wwo->dwWrittenTotal = 0; @@ -368,32 +365,34 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) ((LPWAVEHDR)param)->dwFlags &= ~WHDR_INQUEUE; ((LPWAVEHDR)param)->dwFlags |= WHDR_DONE; - wodNotifyClient(wwo, WOM_DONE, param, 0); + wodNotifyClient(wwo, WOM_DONE, param, 0); } ALSA_ResetRingMessage(&wwo->msgRing); LeaveCriticalSection(&wwo->msgRing.msg_crst); } else { - if (wwo->lpLoopPtr) { - /* complicated case, not handled yet (could imply modifying the loop counter */ - FIXME("Pausing while in loop isn't correctly handled yet, except strange results\n"); - wwo->lpPlayPtr = wwo->lpLoopPtr; - wwo->dwPartialOffset = 0; - wwo->dwWrittenTotal = wwo->dwPlayedTotal; /* this is wrong !!! */ - } else { - LPWAVEHDR ptr; - DWORD sz = wwo->dwPartialOffset; + DWORD diff = wwo->dwWrittenTotal - wwo->dwPlayedTotal; + DWORD sz; + + /* no pointers or counters need to change */ + if (diff <= wwo->dwPartialOffset) + wwo->dwPartialOffset -= diff; + else { + wwo->lpLoopPtr = NULL; + wodPlayer_BeginWaveHdr(wwo, wwo->lpQueuePtr); - /* reset all the data as if we had written only up to lpPlayedTotal bytes */ - /* compute the max size playable from lpQueuePtr */ - for (ptr = wwo->lpQueuePtr; ptr != wwo->lpPlayPtr; ptr = ptr->lpNext) { - sz += ptr->dwBufferLength; + diff -= wwo->dwPartialOffset; + sz = wwo->lpPlayPtr->dwBufferLength; + + while (sz < diff) { + wodPlayer_PlayPtrNext(wwo); + sz += wwo->lpPlayPtr->dwBufferLength; } - /* because the reset lpPlayPtr will be lpQueuePtr */ - if (wwo->dwWrittenTotal > wwo->dwPlayedTotal + sz) ERR("grin\n"); - wwo->dwPartialOffset = sz - (wwo->dwWrittenTotal - wwo->dwPlayedTotal); - wwo->dwWrittenTotal = wwo->dwPlayedTotal; - wwo->lpPlayPtr = wwo->lpQueuePtr; + + wwo->dwPartialOffset = sz - diff; + wodPlayer_BeginWaveHdr(wwo, wwo->lpQueuePtr); } + + wwo->dwWrittenTotal = wwo->dwPlayedTotal; wwo->state = WINE_WS_PAUSED; } }

2 1

Writing a winelib plugin
by Shachar Shemesh 08 Mar '07

08 Mar '07

Hi all, It used to not be possible to write a plugin, to be loaded from a standard Linux ELF program, that will be itself a winelib shared object. All sorts of issues regarding running wineserver and memory layout initializations were problematic. I'm wondering whether there is any news on that front. Is it still not practically possible to do this? Many thanks, Shachar

1 0

Re: Alexandre Julliard : wine_common_ver: Set company name to Microsoft, some apps check for that.
by Paul Chitescu 08 Mar '07

08 Mar '07

Hi! Ummm, isn't this legally dangerous? Stamping a piece of code with Microsoft's name can be interpreted as counterfeiting. Maybe a better choice would be to add a configure option --with-company-name and let the users set it to... whatever... Paul Chitescu

4 3

Re: [RESEND] [PATCH] DirectPlay should keep track of the current number of players
by Kai Blin 08 Mar '07

08 Mar '07

On Wednesday 07 March 2007 10:52, Alessandro Pignotti wrote: > + /* I think we have to add a player to the total number of players only if it's not a player created for system > + purpose like the name server. This way it seems we get a correct player number */ > + if( ~dwFlags & DPLAYI_PLAYER_SYSPLAYER ) > + This->dp2->lpSessionDesc->dwCurrentPlayers++; > + [...] > /* FIXME: Should we be storing these dwFlags or the creation ones? */ > - lpPData = DP_CreatePlayer( This, lpidPlayer, lpPlayerName, dwFlags, > + /* I think we should pass creation flags, so we can distinguish sysplayers and not count them in the current > + player total */ > + lpPData = DP_CreatePlayer( This, lpidPlayer, lpPlayerName, > dwCreateFlags, hEvent, bAnsi ); Every time someone uses "I think" in the code, usually this calls for a test case. This one should be rather straightforward to test. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

RS232 latency, redirection possible?
by [IDC]Dragon 07 Mar '07

07 Mar '07

Hi, I have 2 questions about the serial port handling under Wine: 1) I see a very annoying latency in an application which talks to a controller over RS232. Under Windows, the traffic is "fluent", under Wine each command has a turnaround time of almost a second. Since there are many commands, this gets useless. I sthere anything known, some settings I can try? 2) Is it possible to map the e.g. COM1 port traffic to another device, or is it firmly assigned to matching RS232 interfaces of the Linux box? Ideally, I'd like to have the Windows app talk to an XPort device (remote RS232) connected over network. A program called "socat" (http://www.dest-unreach.org/socat) can be used to create a device and tunnel the traffic over a TCP port. I'd like to map that device to a windows-emulated COM port. Maybe this even eliminates problem 1). I hope I was able to explain especially 2) and kindly wait for answers, thanks! Jörg -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser

3 4

wininet: Don't discard the extra info part of a URL in InternetOpenUrl.
by Ron Yorston 07 Mar '07

07 Mar '07

A fix to winnet/internet.c turned up in 0.9.32 that's supposed to ensure that the "extra info" part of a URL is correctly included. I think there's a problem with the patch. On line 2865 space is allocated for the extra info: if (!(path_extra = HeapAlloc(GetProcessHeap(), 0, size))) Shouldn't this be in units of sizeof(WCHAR)? That is, if (!(path_extra = HeapAlloc(GetProcessHeap(), 0, size*sizeof(WCHAR)))) Ron

2 1

Work legalities
by Juan Lang 07 Mar '07

07 Mar '07

> I'm worried about the copyright of any external work I do, so I need a > little advice. > > What do I need from my employer to clear me to work on wine? > Is something verbal ok, or should I get it in writing? In the US, if you do the Wine work outside of your workplace, on your own time and with your own equipment, it should be okay. IANAL, but see e.g.: http://www.supnik.com/reid.htm --Juan

1 0

A Survey on Defect Management Practices in Free/Open Source Software
by anugupta＠pu.ac.in 07 Mar '07

07 Mar '07

Dear Wine Contributors, I seek help from designers, developers, testers,defect fixers,project managers or playing any other key role in Free/Open Source software development or maintenence in carrying out a study to identify practices and problems of defect management in various Free/Open Source Software projects. The insights gained from the study can further help us to extract publicly accessible defect data and determine impact of defect management practices on software quality. Please spend a few minutes of your precious time to fill up the Questionnaire. The most of the questions follow multiple choice formats and are quite easy to answer. To have the Online Questionnaire, please visit: http://anu.puchd.ac.in/phpESP/public/survey.php?name=FOSS_Defect_Survey (You can also copy and paste this link into your browser, and hit the 'Return' key.) I hope you will find all the questions interesting and thought-provoking. Your answers will be kept anonymous.The data thus collected will only be used for research purpose.It would be nice if you may further refer this mail to others actively engaged with Free/Open Source Software development. If you have any query or suggestions then feel free to contact. Thank You With regards, Anu Gupta Senior Lecturer Department of Computer Science and Applications, Panjab University, Chandigarh. INDIA In case of any problem in accessing/using the above mentioned link please contact: E-mail: anugupta(a)pu.ac.in anugupta98(a)gmail.com

1 0

[winealsa] Mind buffer loops when pausing
by Chris Bandy 07 Mar '07

07 Mar '07

This patch should fix the incorrect handling of WaveHdr loops when pausing. Like the non-loop case written before, this sums the buffer lengths between dwPlayedTotal and dwWrittenTotal to calculate the new dwPartialOffset. Instead of blindly moving from one buffer to the next, however, this traverses the list using BeginWaveHdr and PlayPtrNext. This has added benefit of correctly initializing all pointers and counters for playback. It looks correct on paper, but I don't seem to have any applications that even attempt to pause. Can anyone suggest an application to test this with? All feedback welcome. Note: this branch in the function is a 'software' pause. To test you may need to override the check for ALSA's hardware pause at line 418 (snd_pcm_hw_params_can_pause) -- Chris diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 6a8a435..4ac50c6 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -319,9 +319,9 @@ static DWORD wodPlayer_NotifyCompletions(WINE_WAVEDEV* wwo, BOOL force) * * wodPlayer helper. Resets current output stream. */ -static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) +static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) { - int err; + int err; TRACE("(%p)\n", wwo); /* flush all possible output */ @@ -329,7 +329,7 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) wodUpdatePlayedTotal(wwo, NULL); /* updates current notify list */ - wodPlayer_NotifyCompletions(wwo, FALSE); + wodPlayer_NotifyCompletions(wwo, reset); if ( (err = snd_pcm_drop(wwo->pcm)) < 0) { FIXME("flush: %s\n", snd_strerror(err)); @@ -345,9 +345,6 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) DWORD param; HANDLE ev; - /* remove any buffer */ - wodPlayer_NotifyCompletions(wwo, TRUE); - wwo->lpPlayPtr = wwo->lpQueuePtr = wwo->lpLoopPtr = NULL; wwo->state = WINE_WS_STOPPED; wwo->dwPlayedTotal = wwo->dwWrittenTotal = 0; @@ -368,32 +365,34 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) ((LPWAVEHDR)param)->dwFlags &= ~WHDR_INQUEUE; ((LPWAVEHDR)param)->dwFlags |= WHDR_DONE; - wodNotifyClient(wwo, WOM_DONE, param, 0); + wodNotifyClient(wwo, WOM_DONE, param, 0); } ALSA_ResetRingMessage(&wwo->msgRing); LeaveCriticalSection(&wwo->msgRing.msg_crst); } else { - if (wwo->lpLoopPtr) { - /* complicated case, not handled yet (could imply modifying the loop counter */ - FIXME("Pausing while in loop isn't correctly handled yet, except strange results\n"); - wwo->lpPlayPtr = wwo->lpLoopPtr; - wwo->dwPartialOffset = 0; - wwo->dwWrittenTotal = wwo->dwPlayedTotal; /* this is wrong !!! */ - } else { - LPWAVEHDR ptr; - DWORD sz = wwo->dwPartialOffset; + DWORD diff = wwo->dwWrittenTotal - wwo->dwPlayedTotal; + DWORD sz; + + /* no pointers or counters need to change */ + if (diff <= wwo->dwPartialOffset) + wwo->dwPartialOffset -= diff; + else { + wwo->lpLoopPtr = NULL; + wodPlayer_BeginWaveHdr(wwo, wwo->lpQueuePtr); - /* reset all the data as if we had written only up to lpPlayedTotal bytes */ - /* compute the max size playable from lpQueuePtr */ - for (ptr = wwo->lpQueuePtr; ptr != wwo->lpPlayPtr; ptr = ptr->lpNext) { - sz += ptr->dwBufferLength; + diff -= wwo->dwPartialOffset; + sz = wwo->lpPlayPtr->dwBufferLength; + + while (sz < diff) { + wodPlayer_PlayPtrNext(wwo); + sz += wwo->lpPlayPtr->dwBufferLength; } - /* because the reset lpPlayPtr will be lpQueuePtr */ - if (wwo->dwWrittenTotal > wwo->dwPlayedTotal + sz) ERR("grin\n"); - wwo->dwPartialOffset = sz - (wwo->dwWrittenTotal - wwo->dwPlayedTotal); - wwo->dwWrittenTotal = wwo->dwPlayedTotal; - wwo->lpPlayPtr = wwo->lpQueuePtr; + + wwo->dwPartialOffset = sz - diff; + wodPlayer_BeginWaveHdr(wwo, wwo->lpQueuePtr); } + + wwo->dwWrittenTotal = wwo->dwPlayedTotal; wwo->state = WINE_WS_PAUSED; } }

1 0

Re: [3/4] WineD3D: Blit the offscreen texture into the drawable if needed
by Stefan Dösinger 07 Mar '07

07 Mar '07

Am Mittwoch 07 März 2007 02:43 schrieb Stefan Dösinger: Do not apply this patch yet. Cube textures aren't that easy

1 0

App DB TOP-10 issue
by speedator＠gmx.de 07 Mar '07

07 Mar '07

Hi, I want to annotate that there are apps/games twice in the Platinum List(Diablo II Lord of Destruction 1.x , Outlaws All versions) even thrice(if you add Diablo II 1.x and LoD up for such a list). Btw: Why are Outlaws and IDA Pro "top"? Doesn't seem they are so popular, nvm.

2 1

Re: [PATCH] DirectPlay should keep track of the current number of players
by Kai Blin 07 Mar '07

07 Mar '07

On Tuesday 06 March 2007 23:25, Alessandro Pignotti wrote: > Hi everyone, > this patch fixes the behaviour of dplayx that was not adding new player to > its counter. I don't see a patch. Did you attach it? Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: comctl32: Implement LVS_EX_DOUBLEBUFFER
by Dimi Paun 07 Mar '07

07 Mar '07

On Tue, March 6, 2007 16:27, Felix Nawothnig wrote: > Tested with utorrent - completly removes the flickering from #7344. > In case you're wondering about the change in EraseBkgnd() - this is how > native behaves, they recreate the double buffer on each refresh so we > need to move the erase. Please tell me if I broke anything. It looks good, but you don't cleanup the new DC if the bitmap creation fails. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: [localspl/tests] Remove tempfile after running the tests
by Detlef Riekenberg 06 Mar '07

06 Mar '07

On Di, 2007-03-06 at 18:47 +0100, Paul Vriens wrote: > We had a leftover file in the temp directory. > > Changelog > Remove tempfile after running the tests Ignore my prev. mail. I looked always in "c:\temp" and found the files in "c:\tmp" :-( Sorry for the noise. -- By by ... Detlef

1 0

Re: [localspl/tests] Remove tempfile after running the tests
by Detlef Riekenberg 06 Mar '07

06 Mar '07

On Di, 2007-03-06 at 18:47 +0100, Paul Vriens wrote: > + > + /* Cleanup our temporary file */ > + DeleteFileW(tempfileW); Where / when did you see an undeleted File for this test? localspl_test.exe does not create a temporary file yet. -- By by ... Detlef

1 0

dll that just forward
by Luis Carlos Busquets Pérez 06 Mar '07

06 Mar '07

Concerning dlls dpnaddr.dll dpnlobby.dll They both are dlls with just one function and that it is forwarded to dpnet.dll. I understand that this is just for compatibility reasons. If we add to the git tree these two spec files dlls/dpnaddr/dpnaddr.spec: stdcall DirectPlay8AddressCreate( ptr ptr ptr ) dpnet.DirectPlay8AddressCreate dlls/dpnlobby/dpnlobby.spec: stdcall DirectPlay8Create(ptr ptr ptr) dpnet.DirectPlay8Create Shouldn't these do to have both dlls implemented natively in wine? Do we need to add anymore code for dll functions which are just forwarded in windows?

2 1

Regression in Lotus Notes R5 between wine-0.9.27 and wine-0.9.28
by Pedro Araujo Chaves Jr. 06 Mar '07

06 Mar '07

Hi all, There's been a regression in printing in Lotus Notes R5 somewhere between wine-0.9.27 and wine-0.9.28: it seems that the presence of an inline picture (in this case, a logo) in the mail stationery prevents all text (including header text) from being printed. Odd as it may seem, my regression testing pointed commit 21635133fb271405fefd6bce3078cf971e84c426 as the cause. I positioned my tree just before it, and the mail printed okay; I applied it, the mail came out blank again. As I still couldn't see any direct relation between the said commit and this issue, I'm posting here in the hope someone would be able to figure out what's going on. If that's the case, then, I'll file a bug report and upload a database containing a message with one of these problematic stationeries. Regards, -- - Pedro.

2 3

Re: [wordpad]updated Korean Resource
by Detlef Riekenberg 06 Mar '07

06 Mar '07

On Di, 2007-03-06 at 17:35 +0900, Hwang YunSong(황윤성) wrote: > MENUITEM "(&C)\tCtrl+C", ID_EDIT_COPY > + MENUITEM "ٿֱ(&P)\tCtrl+V", ID_EDIT_PASTE > + MENUITEM "(&C)\tDEL", ID_EDIT_CLEAR > + MENUITEM " (&S)\tCtrl+A", ID_EDIT_SELECTALL > MENUITEM SEPARATOR The idention is different. Please replace the tab with "4 Space" (Similar in the Stringtable below that Part) -- By by ... Detlef

1 0

Question some code in server/request.c
by Paul Vriens 06 Mar '07

06 Mar '07

Hi, while going through the Coverity reports I found CID-293 that mentions a possible NULL-RETURN. Marcus sent in a patch that wasn't applied. If I look at the code (starting at line 537): /* create the server directory and chdir to it */ static void create_server_dir( const char *dir ) { char *p, *server_dir; struct stat st, st2; if (!(server_dir = strdup( dir ))) fatal_error( "out of memory\n" ); /* first create the base directory if needed */ p = strrchr( server_dir, '/' ); *p = 0; create_dir( server_dir, &st ); /* now create the server directory */ *p = '/'; create_dir( server_dir, &st ); if (chdir( server_dir ) == -1) fatal_perror( "chdir %s", server_dir ); if (stat( ".", &st2 ) == -1) fatal_perror( "stat %s", server_dir ); if (st.st_dev != st2.st_dev || st.st_ino != st2.st_ino) fatal_error( "chdir did not end up in %s\n", server_dir ); free( server_dir ); } it looks to me that 'p' is not used at all (this is so since June 2002). Am I completely missing something? Cheers, Paul.

5 5

Re: ddraw: Don't include window border in default surface size (ignore the other patch)
by Stefan Dösinger 06 Mar '07

06 Mar '07

Am Sonntag 04 März 2007 20:49 schrieb Samuel Lidén Borell: > If no width or height is passed to CreateSurface, use GetClientRect > instead of GetWindowRect to calculate a default size. tbh, the whole thing is wrong. Whatever cooperative level is used, and whatever the surface size is, windows creates a front buffer surface of the full screen size. So if you have a res of 1400x1050 and a window of 64x64, the front buffer is 1400x1050 pixels in size. I wanted to change that somewhen, but the windowed d3d rendering needs some adjustments for it(Not the usual opengl problem).

1 0

Re: [1/2] gdi32: Implement AddFontMemResourceEx api.
by Dmitry Timoshkov 06 Mar '07

06 Mar '07

"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote: > These patches fix the BUG #5865 > http://bugs.winehq.org/show_bug.cgi?id=5865. > > changelog: > Implement AddFontMemResourceEx. You shouldn't need to create a temp file, FT_New_Memory_Face is able to load font data from memory just fine. FT_New_Memory_Face is already used by OpenFontFile, you need to adapt existing code to not require fonts to be passed as a file name in general. -- Dmitry.

2 2

Re: 0001-server-main.c-fixed-command-line-parsing-using-GNU-getopt
by Dmitry Timoshkov 06 Mar '07

06 Mar '07

"Srivatsa Kanchi, R" <skanchi(a)nexthop.com> wrote: > replaced the custom 'parse_args' function with GNU getopt And what's wrong with current parser, except it being custom? > applied some coding style to limit code 80 characters /line Please leave existing style alone, even if you don't like it. -- Dmitry.

2 3

Working on DIBEngine for SOC
by Ivan de Jesus Deras Tabora 06 Mar '07

06 Mar '07

Hello everyone. I'm thinking about participating in the Google SOC 2007. Given that Wine in one of my favorite Open Source projects I find interesting the idea of implementing the DIBEngine. In the past I've worked in some Open Source projects, one of them QT-Win32 and also I did little contributions to the OFC (Open Foundation Class). I've experience with C coding, mostly from working on Educational OS like GeekOS and PintOS. >From what I understood the hard part of this project is INTEGRATION. I mean integrating the new code into the Wine repository without breaking everything? Am I right? About the drawing code, I read that is possible to use the X11 code, also the ReactOS code and the old Transgaming DIBEngine (incomplete). Is that correct? Waiting for your comments and ideas. Regards, Ivan

5 4

Re: AppDB performance issue
by Tony Lambregts 05 Mar '07

05 Mar '07

Nick Law wrote: > Hi Tony, > Just lately, I've noticed that AppDB seems to be very slow, i.e it can > take15 seconds or more for a page to come up or simply to login. Is > there a bandwidth problem or is the server getting overwhelmed or is > it a problem at my end (UK). 30 seconds later it's back to being very > responsive as if the server was a bit overloaded for 30 seconds or so. > Other websites I try at the time work fine including winehq. Is winehq > on a different server ? > I have noticed this too and it is very annoying. Yes www.winehq.org qpdb.winehq.or and bugs.winehq.org are all on the same server. Winehq and bugzilla are quite snappy but the AppDB is a pig now. I have know idea what is wrong -- Tony Lambregst

9 19

Current wine and HL2 family - well done!
by Luke Bratch 05 Mar '07

05 Mar '07

> without an annoying graphics glitch causing parts of skies to be > replaced with some bogus contents like white, black, mirrors of a part of > ground etc. Are you finding no errors at all? In Counter-Strike: Source, when running in anything above DX7 mode, on the map "de_aztec", the screen is often completely black - it appears to be when looking at water. ___________________________________________________________ Inbox full of unwanted email? Get leading protection and 1GB storage with All New Yahoo! Mail. http://uk.docs.yahoo.com/nowyoucan.html

7 15

mingw linking problem
by Stefan Leichter 05 Mar '07

05 Mar '07

Hello, i'm trying to build wine/its dlls with mingw. This fail for some dlls at the linking, eg. comdlg32.dll misses the imports _IID_IContextMenu, _IID_IShellFolder, _IID_IPersistFolder2, _IID_IShellBrowser, _IID_ICommDlgBrowser, _IID_IShellView, _SID_STopLevelBrowser My investigations are showing that mingw has the missing imports in libshell32.a., but the linker links against wine's shell32.dll. The missing symbols are also in wine's libuuid.a, but this is not used because the linker does not see the file. When i extend the linker call with -L../../dlls/uuid i can link the comdlg32.dll successfully.. I have tried to find the symbols with strings on my win2k box, but the symbols are not there. So the first question is: What is the correct way to build the dll? The second question when we agreed on the first one is: Can someone please fix configure/Makefile.in to work properly . Thanks Stefan

3 3

Visualizing skip on test.winehq.org (and getting rid of visible desktop border)
by Paul Vriens 05 Mar '07

05 Mar '07

Hi, currently all tests on test.winehq.org show the blue border to indicate the test is running on a visible desktop. I think we can get rid of this one as winetest will not run if we don't have a visible desktop. My idea is to visualize the skipped tests by using the blue border at the single test level to indicate tests are skipped (see attached picture). Comments, idea's, thoughts? Cheers, Paul.

3 2

fc4 rpms
by Bill Medland 05 Mar '07

05 Mar '07

Is there any chance that someone with the ability can create the fedora core 4 wine rpms for version 0.9.30? Bill Medland

4 4

Re: Problems with Alice
by gslink 05 Mar '07

05 Mar '07

After considerable digging the problems with sound in Alice were traced to a bad software load. While digging another thing came to our attention that may be of interest to others. When we put in the latest fixes to FC6 Wine quit running. This was traced to the fact that the latest fixes contain a set of fixes for the X server and replace the open GL library. The drivers posted by Nvidia, which were installed, have their own GL library and will not work with the RH GL library. If you install an update to FC and are using the Nvidia drivers reinstall the drivers if things in the X server quit working. This is true even if the kernel version is not changed.

1 0

Re: secur32: NTLM's AcquireCredentialHandleA/W should accept domains and usernames with lengths of 0.
by Kai Blin 05 Mar '07

05 Mar '07

On Monday 05 March 2007 13:02, Robert Shearman wrote: > + if(pQuerySecurityPackageInfoA(sec_pkg_name, &pkg_info) != SEC_E_OK) > + { > + trace("NTLM package not installed, skipping test\n"); > + return; > + } I've just started using skip() for skipping tests. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

2 1

Writing IDL and other definition files
by Jeff L 05 Mar '07

05 Mar '07

I am looking at writing a piece of IDL and a header file I am wrestling with how to do it without infringing copyright. IDL looks particularly hard to write from first principles and is probably hard to write in a different way as the functions being implemented are defined and require IDL similar code. Is there any advice as to what type of code can be copied and what constitutes a rewrite to avoid copyright? Jeff

2 2

Re: [msi, 1/5, try 5] msi: Add OLE automation conformance test.
by James Hawkins 04 Mar '07

04 Mar '07

On 3/4/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > Changes: Ok, try 5. This time there are five patches, as this first > patch is a (moderately) comprehensive conformance test for MSI OLE > automation, which checks all the functions that will be implemented, and > does basic checks like set a property, then get it, is the property what > we set it to? I hope this helps get it into git. > > These patches add partial OLE automation support for MSI and then add > JScript/VBScript support for MSI (as the MSI specs specifically state > that applications that need this functionality must install Windows > Script themselves). As a proof of concept, sufficient automation support > is added to conform to the conformance test and to fix bug #7357. > Doesn't compile: ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole automation.o db.o format.o iface.o install.o msi.o package.o record.o suminfo.o testlist.o -o msi_test.exe.so ../../../libs/port/libwine_port.a -lcabinet -lmsi -lshell32 -lole32 -ladvapi32 -lkernel32 -luuid automation.o: In function `invoke': /home/truiken/wine/dlls/msi/tests/automation.c:389: undefined reference to `VariantInit' /home/truiken/wine/dlls/msi/tests/automation.c:404: undefined reference to `VariantClear' /home/truiken/wine/dlls/msi/tests/automation.c:398: undefined reference to `VariantChangeTypeEx' -- James Hawkins

2 3

Re: [PATCH 1/2] comctl32: Added getter-setter tests for the tab control (second attempt)
by Vitaliy Margolen 04 Mar '07

04 Mar '07

The_Hagop wrote: > @@ -1,5 +1,6 @@ > /* Unit test suite for tab control. > * > + * Copyright 2007 Hagop Hagopian > * Copyright 2003 Vitaliy Margolen > * > * This library is free software; you can redistribute it and/or These are sorted in historical order. > @@ -52,6 +59,8 @@ > > static HFONT hFont = 0; > > +static HWND hTab; > + > static HWND > create_tabcontrol (DWORD style, DWORD mask) > { You using exactly the same name as parameter to all of your functions. This creates lots of confusion. Please remove this global variable and pass it as a function parameter instead. > + /* Creating a tooltip window*/ > + hwndTT = CreateWindowEx(WS_EX_TOPMOST, > + TOOLTIPS_CLASS, > + NULL, > + WS_POPUP | TTS_NOPREFIX | TTS_ALWAYSTIP, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + hTab, > + NULL, > + 0, > + NULL > + ); > + > + SetWindowPos(hwndTT, > + HWND_TOPMOST, > + 0, > + 0, > + 0, > + 0, > + SWP_NOMOVE | SWP_NOSIZE | SWP_NOACTIVATE); This looks just plain bad. Please put all parameters one after another. There are absolutely no need to have each on it's own line. > + ti.rect.left = rect.left; > + ti.rect.top = rect.top; > + ti.rect.right = rect.right; > + ti.rect.bottom = rect.bottom; You can assign structures to structures in C: ti.rect = rect; > + todo_wine{ > + /* Testing CurFocus with negative value */ > + SendMessage(hTab, TCM_SETCURFOCUS, -1, 0); > + focusIndex = SendMessage(hTab, TCM_GETCURFOCUS, 0, 0); > + expect(-1, focusIndex); > + } Here and all other places - the only part of the test that's failing is "expect(,)". Add "todo_wine" at front of it only. Also it would be interesting to test larger negative numbers, like -10. This is because number of places use -1 to indicate that nothing is selected. So in a sense you might be getting a correct number. > + expect((int) extendedStyle, (int) prevExtendedStyle); > + todo_wine{ > + extendedStyle = SendMessage(hTab, TCM_GETEXTENDEDSTYLE, 0, 0); > + expect(TCS_EX_FLATSEPARATORS, (int) extendedStyle); > + } Why are you casting DWORD to int? > +static void test_getters_setters(INT nTabs) > +{ > + RECT rTab; > + INT nTabsRetrieved; > + INT rowCount; > + > + hTab = createFilledTabControl(TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE, nTabs); > + ok(hTab != NULL, "Failed to create tab control\n"); > + > + SendMessage(hTab, TCM_SETMINTABWIDTH, 0, -1); > + > + /* Testing GetItemCount */ > + nTabsRetrieved = SendMessage(hTab, TCM_GETITEMCOUNT, 0, 0); > + expect(nTabs, nTabsRetrieved); > + > + /* Testing GetRowCount */ > + rowCount = SendMessage(hTab, TCM_GETROWCOUNT, 0, 0); > + expect(1, rowCount); > + > + /* Testing GetItemRect */ > + SendMessage(hTab, TCM_GETITEMRECT, 0 , (LPARAM) &rTab ); > + CheckSize(hTab, TAB_DEFAULT_WIDTH, -1 , "Default Width"); > + > + test_getset_curFocus(hTab, nTabs); > + test_getset_curSel(hTab, nTabs); > + > + test_getset_extendedStyle(hTab); > + test_getset_unicodeFormat(hTab); > + test_getset_item(hTab); > + test_getset_tooltip(hTab); > + > + DestroyWindow(hTab); > +} All your small functions should go inside this function. There is no need to create 100 small functions that do 1-3 tests. > + > + test_getters_setters(5); > } This part part of your patch appears to be malformed. Vitlaiy

2 2

Current wine and HL2 family - well done!
by Pavel Troller 04 Mar '07

04 Mar '07

Hi! Normally I'm writing complaints here, so for a bit of compensation, I would like to inform that yesterday's wine runs HL2 family of games for the first time without an annoying graphics glitch causing parts of skies to be replaced with some bogus contents like white, black, mirrors of a part of ground etc. So, many thanks to all the DirectX developers especially from my sons, they are very pleased and wish you all the best, especially continuous progress in wine development (a bit egocentric from them, but nice :-)) ). With regards, Pavel Troller

2 1

Re: gdi32: Add a EnumFontFamilies test, make it pass under Wine. Try 2
by Dmitry Timoshkov 04 Mar '07

04 Mar '07

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> wrote: > this patch should fix the problem reported in the bug #7571. > > This version of the patch adds a test for the case of enumerating "Symbol"-like > fonts (pointed out by Huw), and makes it pass under Wine as well. > > Changelog: > gdi32: Add a EnumFontFamilies test, make it pass under Wine. Please do not commit this patch, according to the comments in the bug above it needs more work. -- Dmitry.

1 0

Re: Fix compilation on systems that don't support nameless unions.
by Dmitry Timoshkov 04 Mar '07

04 Mar '07

"Francois Gouget" <fgouget(a)free.fr> wrote: > This fixes compilation with gcc 2.95. > > programs/cmd/batch.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) As a more general solution that would also prevent this kind of breakage in future would be to move #define NONAMELESSUNION #define NONAMELESSSTRUCT from directory.c to wcmd.h. -- Dmitry.

1 0

Re: (resend) Scroll window fix
by Peter Oberndorfer 03 Mar '07

03 Mar '07

On Tuesday 13 February 2007 14:38, Aric Stewart wrote: > finds the case where the scrolling amount exceeds the window but still > falls within the clipping rect. This generates an additional update > region that needs to be invalidated. > includes a test > Hi, I think your patch has a problem. It calls CombineRgn with the deleted Region hrgnClip. I don't know if it impacts real world applications, but i just saw a warning about a invalid handle in my debug log. Maybe moving DeleteObject below the if solves the problem? I don't know... @@ -870,6 +870,26 @@ INT WINAPI ScrollWindowEx( HWND hwnd, IN CombineRgn( hrgnWinupd, hrgnWinupd, hrgnTemp, RGN_OR ); RedrawWindow( hwnd, NULL, hrgnTemp, rdw_flags); DeleteObject( hrgnClip ); //<<<<<<< deleted here + + /* Catch the case where the scolling amount exceeds the size of the + * original window. This generated a second update area that is the + * location where the original scrolled content would end up. + * This second region is not returned by the ScrollDC and sets + * ScrollWindowEx apart from just a ScrollDC. + * + * This has been verified with testing on windows. + */ + if (abs(dx) > abs(rc.right - rc.left) || + abs(dy) > abs(rc.bottom - rc.top)) + { + DeleteObject( hrgnTemp ); + hrgnTemp = CreateRectRgn(rc.left + dx, rc.top + dy, rc.right+dx, rc.bottom + dy); + CombineRgn( hrgnTemp, hrgnTemp, hrgnClip, RGN_AND ); //<<<<<<< used here + CombineRgn( hrgnUpdate, hrgnUpdate, hrgnTemp, RGN_OR ); + + if( !bOwnRgn) + CombineRgn( hrgnWinupd, hrgnWinupd, hrgnTemp, RGN_OR ); + } } DeleteObject( hrgnTemp ); Greetings Peter

1 0

msi ole automation update
by Misha Koshelev 03 Mar '07

03 Mar '07

Hi everbody, I have been working on some more stuff for the MSI OLE automation, and I now have a moderately comprehensive conformance test (1000 or so lines, tests each function implemented at least for basic functionality, tests things like return codes, if you set a property and then get it do you get what you set it to, etc.). A few small patches are needed to then make my OLE automation code (which is still hanging out in wine-patches, not in git yet) pass this test. I am going to wait to send all these new patches to wine-patches until my other patches get reviewed/committed by Alexandre. However, I thought I would post them here for any comments. I am going to be _quite_ busy starting Monday for a month though, so I may likely not be able to make any serious modifications to them if people see large problems until April. However, if anyone has any comments about these or my patches already sitting in wine-patches, please do let me know. Thanks Misha

1 1

re: GSoC project proposal: Implement the Negotiate and Kerberos SSPs based on GSSAPI
by Dan Kegel 03 Mar '07

03 Mar '07

Kai wrote: >My toy idea is to not implement the ASN.1 stuff myself but instead make >use of GSSAPI for this.... Can you explain for us non-knowledgeable folks what ASN.1 stuff you're talking about? >Should using GSSAPI not work for us for whatever reason, I think it should be >well within the GSoC timeframe to bite the bullet and cobble together an >ASN.1 parser for Negotiate, handle negotiation in Wine and use libkrb5 for >Kerberos. When I first looked at gssapi back in '98 or so, it seemed to be mostly an annoying convenience layer that just got in the way of my project (which was to add authentication to a network game library). Here's a rule of thumb: if a convenience layer does any networking for you, it will do it wrong. Let's look at Heimdal's networking, for instance. In heimdal, its networking implementation uses select(). We've spent a lot of time purging all select()'s from Wine's source tree because any application that uses select() breaks once you have fd's in your app with values above 1024. Sure, we can fix that by submitting patches to Heimdal to use poll() instead, but there are are sure to be other problems. The best thing to do is eschew all functions that do networking for you, and do it all yourself. So, can you do what you're thinking of without being forced to let gssapi do networking for you? For those just tuning in, here's some context: http://www.stacken.kth.se/lists/heimdal-discuss/2006-12/msg00030.html http://www.stacken.kth.se/lists/heimdal-discuss/2006-12/msg00033.html - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: [PATCH 2/2] comctl32: Added message sequence tests for the tab control
by Vitaliy Margolen 03 Mar '07

03 Mar '07

The_Hagop wrote: > assert(tabHandle); > > - SetWindowLong(tabHandle, GWL_STYLE, WS_CLIPSIBLINGS | WS_CLIPCHILDREN | TCS_FOCUSNEVER | style); > - SendMessage (tabHandle, WM_SETFONT, 0, (LPARAM) hFont); > + if (!tabHandle) > + { > + HeapFree(GetProcessHeap(), 0, info); > + return NULL; > + } This check is redundant. assert will terminate the test if window was not created properly. You probably should remove it and skip the test. > @@ -448,22 +717,42 @@ > INT nTabsRetrieved; > INT rowCount; > > + parent_wnd = createParentWindow(); > + ok(parent_wnd != NULL, "Failed to create parent window!\n"); > + ok_sequence(sequences, PARENT_SEQ_INDEX, create_parent_wnd_seq, "create parent window", TRUE); > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + No need to test window creation sequence here. It's tested in much more details in user32/tests/msg.c Also you are leaking parent window - you don't destroying it at the end of the test. And, same as hTab, don't make it global. You are not using it outside one function. > @@ -474,6 +763,9 @@ > test_getset_tooltip(hTab); > > DestroyWindow(hTab); > + > + ok_sequence(sequences, TAB_SEQ_INDEX, destroy_tab_control_seq, "Tab sequence, after removing tab control from parent", FALSE); > + ok_sequence(sequences, PARENT_SEQ_INDEX, empty_sequence, "Parent sequence, after removing tab control from parent", FALSE); > } > > START_TEST(tab) Same thing here - there are no common controls' related messages in them- no need to test what's already being tested in the other places. And last but not the least - your tests fail on windows 2k and xp pro in interactive mode (set WINETEST_INTERACTIVE=1): tab: 911 tests executed (0 marked as todo, 20 failures), 0 skipped. Vitaliy.

1 0

Re: DirectPlay should convert dwReserved1/2 registry keys from strings to DWORDs
by Joris Huizer 03 Mar '07

03 Mar '07

if( i == 0 ) - memcpy( &lpSpData->dwReserved1, returnBuffer, sizeof(lpSpData->dwReserved1) ); + sscanf(returnBuffer, "%x", &lpSpData->dwReserved1); Couldnt you use: strcpy(lpSpData->dwReserved1,returnBuffer); Sorry for only replying now; Your solution is equivalent, except that it is looks more complicated regards, Joris --------------------------------- The fish are biting. Get more visitors on your site using Yahoo! Search Marketing.

2 2

Re: [2/?]WineD3D: Adjust the rhw transformation for offscreen rendering
by Stefan Dösinger 03 Mar '07

03 Mar '07

Am Samstag 03 März 2007 02:53 schrieb Stefan Dösinger: > I hope I explained it correctly, these tripple upside down matrix things > are the perfect way to get insane. Actually that is not totally correct - it should be - Y, -Y - height. It works because all games I have seen use Y = 0 I'll resend a fixed patch

1 0

Re: DirectPlay should convert dwReserved1/2 registry keys from strings to DWORDs
by Kai Blin 03 Mar '07

03 Mar '07

On Friday 02 March 2007 22:54, Alessandro Pignotti wrote: > Hi, > This is the first of several patches that will make builtin dplayx > compatible with native dpwsockx, so we can kill the native override of > dplayx This patch adds two compile-time warnings about implicitly declaring sscanf. Please include the appropriate header or provide the function header if you use sscanf. Other than that, this patch stops builtin dplay from blowing up in my face with native dpwsockx.dll. Good work. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: (resend) Scroll window fix
by Dmitry Timoshkov 03 Mar '07

03 Mar '07

"Aric Stewart" <aric(a)codeweavers.com> wrote: > + SetRect( &rc, 0,40, 100,60); > + SetRect( &cliprc, 0,0, 100,100); > + ScrollWindowEx( hwnd1, 0, -25, &rc, &cliprc, hrgn, &rcu, SW_INVALIDATE); > + SetRectRgn( tmprgn, 0,15,98,35); > + CombineRgn( exprgn, exprgn, tmprgn, RGN_OR); > + SetRectRgn( tmprgn, 0, 40, 98, 60); > + CombineRgn( exprgn, exprgn, tmprgn, RGN_OR); > + ok( EqualRgn( exprgn, hrgn), "wrong update region in excessive scroll\n"); Under which version of Windows this was tested? According to test.winehq.org this test doesn't pass under any of Win98, NT4, Win2000 nor XP invalidating the (now committed) fix. I'd vote to revert this patch as obviously incorrect. -- Dmitry.

3 4

GSoC project proposal: Implement the Negotiate and Kerberos SSPs based on GSSAPI
by Kai Blin 03 Mar '07

03 Mar '07

Hi folks, after I spent my last two summers toying with the NTLM SSP, I'm considering to implement Negotiate and Kerberos this time. As we've discussed on WineConf, there's more than one way to do this. My toy idea is to not implement the ASN.1 stuff myself but instead make use of GSSAPI for this. (With the added bonus that when using Heimdal GSSAPI, we should be able to do NTLM via GSSAPI, too, so Negotiate can actually negotiate between Kerberos and NTLM). I'm not 100% sure that this approach will work, but then again, if I got and write the proof of concept now, I won't have much to do during the summer. Should using GSSAPI not work for us for whatever reason, I think it should be well within the GSoC timeframe to bite the bullet and cobble together an ASN.1 parser for Negotiate, handle negotiation in Wine and use libkrb5 for Kerberos. Dan Kegel seemed to prefer this approach, anyway. In any case I would like to keep the NTLM provider using ntlm_auth in as a fallback solution. What do you think? Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: winex11.drv: Try to work around an access violation in dib_convert
by Dmitry Timoshkov 03 Mar '07

03 Mar '07

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > @@ -849,7 +858,17 @@ static void convert_888_to_0888_asis(int > for (x=0; x < w2; x++) { > /* Do 4 pixels at a time: 3 dwords in and 4 dwords out */ > DWORD srcval1,srcval2; > - srcval1=srcpixel[0]; > + /* Some apps crash in following code-line, possibly they pass a bad pointer*/ > + __TRY > + { > + srcval1=srcpixel[0]; > + } > + __EXCEPT(exception_filter) > + { > + return; > + } > + __ENDTRY; An exception handler should be set around the whole conversion cycle, not around a single pixel read since it's a very expensive (slow) operation in Wine (unlike in Windows). -- Dmitry.

1 0

Re: [2/3] wined3d: The texldl instruction takes 3 arguments
by Ivan Gyurdiev 03 Mar '07

03 Mar '07

> Changelog: > - The texldl instruction takes 3 arguments > Can the SW shader handlers be deleted now that the rest of the SW code is gone. They just get out of sync when you do things like this.

2 1

Re: [programs/cacls] Dummy implementation of cacls.exe (try 2)
by Nigel "Nia-Chiang" Liang 02 Mar '07

02 Mar '07

Yes, sorry about that. Here is the modified patch -Nigel On 3/2/07, James Hawkins <truiken(a)gmail.com> wrote: > > On 3/2/07, Nigel Nia-Chiang Liang <ncliang(a)gmail.com> wrote: > > Hi, > > > > This patch implements a dummy version of cacls.exe to fix bug 7593. > > > > +#RC_SRCS = wcmdrc.rc > +#RC_BINSRC = wcmdrc.rc > +#RC_BINARIES = wcmd.ico > > Did you accidentally leave these in? > > -- > James Hawkins >

1 0

Re: Re: Re: Forum proposal
by "Luis C. Busquets Pérez" 02 Mar '07

02 Mar '07

I understand that for some people the mailing list is a far better thing. May be for some other, a forum is better. Why not having both? Running a forum does not exclude continuing with the mailing lists and could add users and developpers who find more easy coordinate through a forum. Configuring phpBB (www.phpbb.com) does not take more than 1 hour . I have made a try in 30 minutes starting from not knowing anything about this package: http://ns2.ilidium.com:8011/ Why not trying both systems? > I fully agree with Jonathan - the mail lists that have gone to forums I've dropped off. I can check the mail lists > quickly, easily, filter as necessary and get what I need without having to sign on and wade through a bunch of posts. > If people really want forums setup a forum and let those who want it use it. > > > > From: Jonathan Allen <jonathan(a)barumtrading.co.uk> > > Date: 2007/03/01 Thu AM 11:20:18 EST > > To: wine-devel(a)winehq.org > > Subject: Re: Forum proposal > > > > On Thu, Mar 01, 2007 at 05:15:03PM +0100, Luis Carlos Busquets Pérez wrote: > >> > > Instead of having the mailing lists, I think that a "forum" would increase >> > > and facilitate the group working. >> > > > > I could agree less. IMHO a mailing list works well by making sure that > > everyone gets everything, without them needing to go anywhere to get it. > > A forum wil immediately disenfranchise all thsoe who have no immediate > > need to go and visit the forum site every day and so will miss important > > annoucements and so on. Bad idea. > > > > Jonathan

9 13

Re: [programs/cacls] Dummy implementation of cacls.exe
by James Hawkins 02 Mar '07

02 Mar '07

On 3/2/07, Nigel Nia-Chiang Liang <ncliang(a)gmail.com> wrote: > Hi, > > This patch implements a dummy version of cacls.exe to fix bug 7593. > +#RC_SRCS = wcmdrc.rc +#RC_BINSRC = wcmdrc.rc +#RC_BINARIES = wcmd.ico Did you accidentally leave these in? -- James Hawkins

1 0

Re: kernel32: Implement ReplaceFileA/ReplaceFileW
by Felix Nawothnig 02 Mar '07

02 Mar '07

(CC-ing wine-devel again) Erich Hoover wrote: >> The "right" way would probably to do the copying yourself by >> read/write.. but I dunno. > Except that it would ignore the permissions issues that have already > been coded into the copy routines (and any updates that may eventually No, CreateFile (and friends) does the permissions checks (which you would still have to call). > be made to these routines). Also, it seems to me that MSDN is > describing the list of function calls that ReplaceFile actually makes. No it doesn't? Your other objections were right. Your last version follows for wine-devel. > ------------------------------------------------------------------------ > > /************************************************************************** > * ReplaceFileW (KERNEL32.@) > * ReplaceFile (KERNEL32.@) > */ > BOOL WINAPI ReplaceFileW(LPCWSTR lpReplacedFileName,LPCWSTR lpReplacementFileName, > LPCWSTR lpBackupFileName, DWORD dwReplaceFlags, > LPVOID lpExclude, LPVOID lpReserved) > { > HANDLE hReplaced, hReplacement; > BOOL skipBackup = FALSE; > > if(dwReplaceFlags) > FIXME("Ignoring flags %x\n", dwReplaceFlags); > /* First two arguments are mandatory */ > if(!lpReplacedFileName || !lpReplacementFileName) > { > SetLastError( ERROR_INVALID_PARAMETER ); > return FALSE; > } > /* > * Lock the "replacement" file, fail if it does not exist > */ > if((hReplacement = CreateFileW(lpReplacementFileName, GENERIC_READ, > FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, > NULL, OPEN_EXISTING, 0, 0)) == INVALID_HANDLE_VALUE) > { > return FALSE; > } > if(!LockFile( hReplacement, 0, 0, 0, 0 )) > { > CloseHandle( hReplacement ); > return FALSE; > } > /* > * Lock the "replaced" file while we're working. > */ > if((hReplaced = CreateFileW(lpReplacedFileName, GENERIC_READ, > FILE_SHARE_READ | FILE_SHARE_WRITE, > NULL, OPEN_EXISTING, 0, 0)) == INVALID_HANDLE_VALUE) > { > /* If "replaced" does not exist then create it for the lock, but skip backup */ > if((hReplaced = CreateFileW(lpReplacedFileName, GENERIC_READ, > FILE_SHARE_READ | FILE_SHARE_WRITE, > NULL, CREATE_ALWAYS, 0, 0)) == INVALID_HANDLE_VALUE) > { > UnlockFile( hReplacement, 0, 0, 0, 0 ); > CloseHandle( hReplacement ); > return FALSE; > } > skipBackup = TRUE; > } > if(!LockFile( hReplaced, 0, 0, 0, 0 )) > { > UnlockFile( hReplacement, 0, 0, 0, 0 ); > CloseHandle( hReplacement ); > CloseHandle( hReplaced ); > return FALSE; > } > /* > * If the user wants a backup then that needs to be performed first > */ > if( lpBackupFileName && !skipBackup ) > { > /* If an existing backup exists then copy over it */ > if(!CopyFileW( lpReplacedFileName, lpBackupFileName, FALSE )) > goto replace_fail; > } > /* > * Now that the backup has been performed (if requested), copy the replacement > * into place > */ > if(!CopyFileW( lpReplacementFileName, lpReplacedFileName, FALSE )) > { > /* Assume that all access denied errors are a write problem. */ > if(GetLastError() == ERROR_ACCESS_DENIED) > SetLastError( ERROR_UNABLE_TO_REMOVE_REPLACED ); > else > SetLastError( ERROR_UNABLE_TO_MOVE_REPLACEMENT ); > goto replace_fail; > } > /* Delete the replacement file */ > if(!DeleteFileW( lpReplacementFileName )) > return FALSE; > /* Unlock the handles */ > UnlockFile( hReplacement, 0, 0, 0, 0 ); > CloseHandle( hReplacement ); > UnlockFile( hReplaced, 0, 0, 0, 0 ); > CloseHandle( hReplaced ); > /* All done, file replacement successful */ > return TRUE; > > replace_fail: > UnlockFile( hReplacement, 0, 0, 0, 0 ); > CloseHandle( hReplacement ); > UnlockFile( hReplaced, 0, 0, 0, 0 ); > CloseHandle( hReplaced ); > return FALSE; > }

2 4

Re: ntdll: make exception test not hang when creating process fails
by Robert Shearman 02 Mar '07

02 Mar '07

Peter Oberndorfer wrote: > --- > Did not seem to happen in the wild, > but just make sure the test fails gracefully > if launching the child fails > > Applies on top of the patch which should fix test result reporting > If it doesn't happen in the wild, then it should stay as an "ok". -- Rob Shearman

1 0

Re: kernel32: Set object security on process object in CreateProcess.[try2]
by Vitaliy Margolen 02 Mar '07

02 Mar '07

Vitaliy Margolen wrote: > Removed todo from succeeding tests. > > Tests showed that only DACL can be set this way. Owner and group > are taken from the token. And we don't need SACL at this time if ever. > --- > dlls/advapi32/tests/security.c | 3 --- > dlls/kernel32/process.c | 12 ++++++++++++ > 2 files changed, 12 insertions(+), 3 deletions(-) Any reason this patch was not applied? Vitaliy.

2 1

[TOOLS/RFC] Use skip information on test.winehq.org
by Paul Vriens 02 Mar '07

02 Mar '07

Hi, This patch add the skip information to test.winehq.org. I'm not a 100% sure what will happen to the already existing reports when summary.js is patched. This however is only relevant for someone opening the popup window for old reports. There could be an issue when somebody is running an old(er) winetest version and sends the results to test.winehq.org. The summary.txt will be different for the later added ones compared to the ones that are already there. Should I change the fileversion (from 3 to 4)? In that case only new type winetest reports will be accepted by test.winehq.org. Any other remarks and/or suggestions? Changelog Use skip information Cheers, Paul. Index: winetest/dissect =================================================================== RCS file: /home/wine/tools/winetest/dissect,v retrieving revision 1.21 diff -u -p -r1.21 dissect --- winetest/dissect 1 Mar 2007 18:30:28 -0000 1.21 +++ winetest/dissect 2 Mar 2007 10:10:21 -0000 @@ -143,9 +143,9 @@ if ($wine) { /Test output:\r?/ or mydie "no test header: $_"; my ($unit, $test, $source, $rev, $result); -my ($lines,$total, $todo, $failed); +my ($lines,$total, $todo, $failed, $skipped); $unit = undef; # state machine starts -$total = $todo = $failed = 0; +$total = $todo = $failed = $skipped = 0; $lines = 0; while (<IN>) { if (!defined $unit) { # new test @@ -165,13 +165,14 @@ while (<IN>) { $total += $2; $todo += $3; $failed += $4; + $skipped += $5; print OUT; } elsif (s/$unit:$test done $(-?\d+)$\r?$//) { chomp; # current test ended if ($lines==0) { - $result = "failed $1 -"; + $result = "failed $1 - -"; } else { - $result = "$total $todo $failed"; + $result = "$total $todo $failed $skipped"; } FINISH: print SUM "- $unit $test $result $source $rev\n"; @@ -183,7 +184,7 @@ while (<IN>) { mydie "can't rename $tmpfile to $testfile: $!\n"; } $unit = undef; - $total = $todo = $failed = 0; + $total = $todo = $failed = $skipped = 0; $lines = 0; } else { # current test output print OUT; @@ -191,7 +192,7 @@ while (<IN>) { } if (defined $unit) { $_=""; - $result = "failed - -"; + $result = "failed - - -"; goto FINISH; } close SUM or mydie "error writing $tmpdir/summary.txt: $!"; Index: winetest/gather =================================================================== RCS file: /home/wine/tools/winetest/gather,v retrieving revision 1.17 diff -u -p -r1.17 gather --- winetest/gather 11 Jan 2007 17:03:43 -0000 1.17 +++ winetest/gather 2 Mar 2007 10:10:21 -0000 @@ -94,10 +94,10 @@ foreach my $file (glob "$datadir/$build/ next; } while (<TEST>) { - my ($digest, $unit, $test, $count, $todo, $error, + my ($digest, $unit, $test, $count, $todo, $error, $skipped, $source, $rev) = split; my $testname = "$unit:$test"; - $testref->{results}->{$testname} = [$count, $todo, $error]; + $testref->{results}->{$testname} = [$count, $todo, $error, $skipped]; $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") unless exists $alltests{$testname}; if ($count ne "failed") { @@ -215,7 +215,7 @@ sub singletest { print OUT " <td class=\"${vis}note\">.</td>\n"; } else { my $file = "$test->{dir}/$testname.txt"; - my ($count, $todo, $error) = @{$test->{results}->{$testname}}; + my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; if ($count eq "failed") { my $msg = $todo eq "-"?"crash": $todo == 258?"timeout":"failed"; @@ -226,8 +226,8 @@ sub singletest { print OUT <<"EOF"; <td class="$vis$class"><a href="$file" - title="$count tests, $todo TODO, $error errors" - onMouseOver="refresh('$testname','$groupname $test->{tag}',$count,$todo,$error);" + title="$count tests, $todo TODO, $error errors, $skipped skipped" + onMouseOver="refresh('$testname','$groupname $test->{tag}',$count,$todo,$error,$skipped);" >$error</a></td> EOF } Index: winetest/resultform.html =================================================================== RCS file: /home/wine/tools/winetest/resultform.html,v retrieving revision 1.1 diff -u -p -r1.1 resultform.html --- winetest/resultform.html 19 Feb 2004 22:00:34 -0000 1.1 +++ winetest/resultform.html 2 Mar 2007 10:10:21 -0000 @@ -34,6 +34,10 @@ <td>Errors:</td> <td><input type="text" name="errors" size="6" readonly></td> </tr> + <tr> + <td>Skipped:</td> + <td><input type="text" name="skipped" size="6" readonly></td> + </tr> </form> </body> </html> Index: winetest/summary.js =================================================================== RCS file: /home/wine/tools/winetest/summary.js,v retrieving revision 1.2 diff -u -p -r1.2 summary.js --- winetest/summary.js 11 Jan 2005 16:00:44 -0000 1.2 +++ winetest/summary.js 2 Mar 2007 10:10:22 -0000 @@ -9,7 +9,7 @@ function isopen () { return result_window && result_window.document && result_window.document.results; } -function refresh (test, version, tests, todo, errors) { +function refresh (test, version, tests, todo, errors, skipped) { if (isopen ()) { var form = result_window.document.results; form.test.value = test; @@ -17,6 +17,7 @@ function refresh (test, version, tests, form.tests.value = tests; form.todo.value = todo; form.errors.value = errors; + form.skipped.value = skipped; result_window.focus (); } } @@ -31,5 +32,6 @@ function clone () { cf.tests.value = rf.tests.value; cf.todo.value = rf.todo.value; cf.errors.value = rf.errors.value; + cf.skipped.value = rf.skipped.value; } }

1 0

Re: kernel32: Fix GetComputerNameA to not count trailing NULL
by Dmitry Timoshkov 02 Mar '07

02 Mar '07

"Alasdair Sinclair" <alasdairs(a)dsl.pipex.com> wrote: > GetComputerNameA shouldn't count the trailing NULL when returning the > buffer. > --- a/dlls/kernel32/computername.c > +++ b/dlls/kernel32/computername.c > @@ -390,8 +390,7 @@ BOOL WINAPI GetComputerNameA(LPSTR name, LPDWORD size) > else > { > WideCharToMultiByte ( CP_ACP, 0, nameW, -1, name, len, NULL, 0 ); > - name[len] = 0; > - *size = len; > + *size = len - 1; > ret = TRUE; This change requires a test case. -- Dmitry.

1 0

Re: [try3, 4/4] msi: Add full JScript/VBScript support.
by James Hawkins 02 Mar '07

02 Mar '07

On 3/1/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > No changes from previous version. > > Implements the IActiveScriptSite interface which links with the session > object implemented in patch #3 and then adds a call to the script > handler from the common script handling function implemented in patch > #1. This fixes bug #7357 and possibly others. > > Changelog: > > * msi: Add full JScript/VBScript support. > +static HRESULT ASS_create(IUnknown *pUnkOuter, LPVOID *ppObj) +{ I'm not trying to be immature, but you should probably come up with a better prefix. + * Call a script. This is our meat and potatoes. + * - Currently, since the function is relatively new, it will always end up returning S_OK. + * Think of it like a bonus feature, we can run the script - great. If we have a problem, + * we are no worse off than if this function had not been called. + */ +DWORD call_script(MSIHANDLE hPackage, INT type, LPCWSTR script, LPCWSTR function, LPCWSTR action) +{ ... +/* return ret; */ + return ERROR_SUCCESS; /* FIXME: Until thoroughly tested, always return success */ This is wrong...and a hack. Don't be afraid of bugs. By always returning ERROR_SUCCESS, you're just hiding the bugs. What testing are you referring to? If a user runs an installer and the script fails, yet we return ERROR_SUCCESS, how are we going to know that the script is the problem? +static HRESULT WINAPI MsiActiveScriptSite_GetLCID(IActiveScriptSite* iface, LCID* plcid) +{ + MsiActiveScriptSite *This = (MsiActiveScriptSite *)iface; + TRACE("(%p/%p)->(%p) stub!\n", This, iface, plcid); + return E_NOTIMPL; +} If it's a stub, it needs to be marked with a FIXME. -- James Hawkins

2 3

Re: [try3, 1/4] msi: Added handlers for JScript/VBScript actions that call one script function.
by James Hawkins 01 Mar '07

01 Mar '07

On 3/1/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > I am resending the entire patchset as James Hawkins suggested. The only > changes from my previous patchset are in patch #2 (add full IDL from > Windows Installer 3.0 vs 2.0 in the old patchset) and patch #3 (added > more proper variant handling using GetDispId as per Rob's suggestion and > removed unnecessary comments as per James' suggestion). > > Just as a reminder, these patches add JScript/VBScript support for > MSI (as the MSI specs specifically state that applications that need > this functionality must install Windows Script themselves) and partial > but easily expandable OLE automation functionality for MSI. As a proof > of concept, sufficient automation support is added to fix bug #7357. > > Patch #1 creates custom action handlers for all 8 script custom action > types using a framework similar to that used for calling DLL functions. > These custom action handlers all converge on one function that is passed > a script and a function to be called (if any), and it outputs these in a > FIXME. > > Changelog: > > * msi: Added handlers for JScript/VBScript actions that call one script > function. > +static DWORD WINAPI ACTION_CallScript( const LPGUID guid ) +{ + msi_custom_action_info *info; + MSIHANDLE hPackage; + UINT r = ERROR_FUNCTION_FAILED; + + info = find_action_by_guid( guid ); + if (!info) + { + ERR("failed to find action %s\n", debugstr_guid( guid) ); + return r; + } + + FIXME("function %s, script %s\n", debugstr_w( info->function ), debugstr_w( info->dllname ) ); + + hPackage = alloc_msihandle( &info->package->hdr ); + if (hPackage) + { + r = S_OK; + MsiCloseHandle( hPackage ); + } + else + ERR("failed to create handle for %p\n", info->package ); + + return r; +} Looks like you're leaking info. If you're going to go down this route, leaving a stub ACTION_CallScript, then just print the FIXME and be on your way. Each patch should be atomic, and assuming this patch gets applied but none of the others do, you're left with some weird code that allocates a handle then frees it for no apparent reason. + r = MSI_RecordReadStream(row, 2, buffer, &sz); + if (r != ERROR_SUCCESS) + { + msi_free(buffer); + return r; + } + + buffer[sz] = 0; + szw = MultiByteToWideChar(CP_ACP, MB_PRECOMPOSED, buffer, -1, bufferw, 0); + bufferw = msi_alloc(sizeof(WCHAR)*szw); + if (!szw) + { + msi_free(bufferw); + return ERROR_FUNCTION_FAILED; + } + + r = MultiByteToWideChar(CP_ACP, MB_PRECOMPOSED, buffer, -1, bufferw, szw); + msi_free(buffer); + if (!r) + { + msi_free(bufferw); + return ERROR_FUNCTION_FAILED; + } This would be a lot cleaner if you used a 'goto done;' at each of these error points. Also, is there a reason you're not using strdupAtoW? done: msi_free(bufferw) ... return r; -- James Hawkins

2 1

re: Forum proposal
by Dan Kegel 01 Mar '07

01 Mar '07

Wojciech wrote: >But there's one thing with forums that IMVHO mailing-lists can't do. TBMS >forums build better comunities than mailing-lists. Mailing lists are just >concentrated on the topics, disallowing any OT. Good. Let's keep it that way. I think we have a great community as it is. If you really want a web interface that makes posting to the mailing list easy, maybe we could get Google Groups to carry wine-devel. It's as close to a nice web interface as you're going to get, I think. The other gateways I've seen between 'forums' and mailing lists all sucked, IMHO. - Dan

1 0

Re: [final, sorry] msi: Expand IDL file to contain all OLE automation interfaces.
by James Hawkins 01 Mar '07

01 Mar '07

On 3/1/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > Ok, sorry about posting patches to uncomitted patches, I have > reintegrated these changes back into my patches. The change in this > patch is the IDL file now contains all OLE automation interfaces as of > native installer version 3.0 (as opposed to 2.0). > > As a reminder this is part 2 of 4 of my patchset: > > 1. > http://www.winehq.org/pipermail/wine-patches/2007-February/036359.html > 2. This patch > 3. Next patch > 4. > http://www.winehq.org/pipermail/wine-patches/2007-February/036362.html > You need to resubmit the whole series if you resubmit parts of it. -- James Hawkins

2 3

Unknown issue with test.winehq.org
by Paul Vriens 01 Mar '07

01 Mar '07

Hi, So finally we have a working winetest executable and the test.winehq.org scripts should be able to handle the new reports. Could someone have a look what the issue currently is on the webserver as I've sent several reports (a few hours ago) and they are not handled yet? Cheers, Paul.

3 5

Re: Re: Forum proposal
by brettholcomb＠bellsouth.net 01 Mar '07

01 Mar '07

I fully agree with Jonathan - the mail lists that have gone to forums I've dropped off. I can check the mail lists quickly, easily, filter as necessary and get what I need without having to sign on and wade through a bunch of posts. If people really want forums setup a forum and let those who want it use it. > > From: Jonathan Allen <jonathan(a)barumtrading.co.uk> > Date: 2007/03/01 Thu AM 11:20:18 EST > To: wine-devel(a)winehq.org > Subject: Re: Forum proposal > > On Thu, Mar 01, 2007 at 05:15:03PM +0100, Luis Carlos Busquets Pérez wrote: > > Instead of having the mailing lists, I think that a "forum" would increase > > and facilitate the group working. > > I could agree less. IMHO a mailing list works well by making sure that > everyone gets everything, without them needing to go anywhere to get it. > A forum wil immediately disenfranchise all thsoe who have no immediate > need to go and visit the forum site every day and so will miss important > annoucements and so on. Bad idea. > > Jonathan > > >

2 1

Forum proposal
by Luis Carlos Busquets Pérez 01 Mar '07

01 Mar '07

Dear all, Instead of having the mailing lists, I think that a "forum" would increase and facilitate the group working. I wonder if you share my view and who is in charge of the web serving so that trying to set up the forum. Luis C. Busquets Pérez T. +34 93 796 05 81 M. +32 473 353 128 M. +34 620501328

2 1

Error Invalid EXE Format when executing a exe.so built with winelib
by Roger Wimbert 01 Mar '07

01 Mar '07

Here is the Debug output: warn:module:load_builtin_dll failed to load .so lib for builtin L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so": /bb/home/.wine/dosdevices/z:/bb/s/bc/wine/dmsw.exe.so: cannot allocate memory in static TLS block warn:module:load_dll Failed to load module L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so"; status=c000007b warn:module:load_builtin_dll failed to load .so lib for builtin L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so": /bb/home/.wine/dosdevices/z:/bb/s/bc/wine/dmsw.exe.so: cannot allocate memory in static TLS block warn:module:load_dll Failed to load module L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so"; status=c000007b wine: could not load L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so": Fehlerhaftes EXE-Format f³r It has something to do with TLS memory or threads, but the /lib/tls/libc.so is linked in: (rw 8 amd64) /bb/s/bc/wine 105>ldd dmsw.exe.so linux-gate.so.1 => (0xffffe000) libwine.so.1 => /usr/local/lib/libwine.so.1 (0x557be000) libm.so.6 => /lib/tls/libm.so.6 (0x558e8000) libc.so.6 => /lib/tls/libc.so.6 (0x5590a000) libdl.so.2 => /lib/libdl.so.2 (0x55a1f000) /lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x56555000) Our system: (rw 8 amd64) /bb/s/bc/wine 106>uname -a Linux amd64 2.6.5-7.193-smp #1 SMP Wed Jul 20 14:39:18 UTC 2005 x86_64 x86_64 x86_64 GNU/Linux glibc has version 2.3.3 A simple program does work, but no program which uses threads. wine is created with the 32 bit libraries. If I use the original exe of my program with wine, it does work. Does anyone has an idea what is going wrong? The makefile is attached. Thanks a lot. ### Generated by Winemaker TOPSRCDIR = /bb/s TOPOBJDIR = /bb/s/bc/wine SRCDIR = . SUBDIRS = DLLS = EXES = dmsw.exe ### Common settings CEXTRA = -mno-cygwin -fno-pic -fno-PIC CXXEXTRA = -mno-cygwin CFLAGS = -D_DMSW RCEXTRA = RCFLAGS = -DBB_WINE INCLUDE_PATH = -I. -I/bb/nt/wine -I/bb/s/i -I/bb/fg/i -I/bb/ze/i -I/bb/fe/i -I/bb/pbm/i -I/bb/wb1/i DLL_PATH = LIBRARY_PATH = LIBRARIES = -lmsvcrt40 -lws2_32 -lversion -lnetapi32 -liphlpapi -lcomctl32 -lshlwapi -lwinmm ### dmsw.exe sources and settings dmsw_exe_MODULE = dmsw.exe dmsw_exe_C_SRCS = /bb/s/c/bbcrypt.c \ /bb/s/c/bbdes.c \ /bb/s/c/bbmalloc.c \ /bb/s/c/bbmd5.c \ /bb/s/c/bbo.c \ /bb/s/c/bbtwofish.c \ /bb/s/c/cmp.c \ /bb/s/c/costri.c \ /bb/s/c/cpy.c \ /bb/s/c/datec.c \ /bb/s/c/dfa.c \ /bb/fg/c/dgcode.c \ /bb/fg/c/dgvar.c \ /bb/s/c/dhinfo.c \ /bb/s/c/dholz.c \ /bb/fg/c/digcte.c \ /bb/fg/c/digecm.c \ /bb/fg/c/digranox.c \ /bb/fg/c/digvec.c \ /bb/s/c/dirview.c \ /bb/s/c/dirwalk.c \ /bb/s/c/dmsb.c \ /bb/s/c/dmsc.c \ /bb/s/c/dmsca.c \ /bb/s/c/dmse.c \ /bb/s/c/dmsf.c \ /bb/s/c/dmsfr.c \ /bb/s/c/dmsg.c \ /bb/s/c/dmsh.c \ /bb/s/c/dmshc.c \ /bb/s/c/dmsl.c \ /bb/s/c/dmsliz.c \ /bb/s/c/dmsm.c \ /bb/s/c/dmsmv.c \ /bb/s/c/dmsp.c \ /bb/s/c/dmsr.c \ /bb/s/c/dmss.c \ /bb/s/c/dmssb.c \ /bb/s/c/dmst.c \ /bb/s/c/dmstast.c \ /bb/s/c/dmsw.c \ /bb/s/c/dmswf.c \ /bb/s/c/dmswicon.c \ /bb/s/c/dmsy.c \ /bb/s/c/encode.c \ /bb/s/c/fileleng.c \ /bb/s/c/fordat.c \ /bb/s/c/gtypes.c \ /bb/fg/c/image.c \ /bb/fg/c/imgprint.c \ /bb/s/c/itoa.c \ /bb/fg/c/jpegconv.c \ /bb/s/c/lru.c \ /bb/s/c/ltoa.c \ /bb/s/c/map.c \ /bb/s/c/msleep.c \ /bb/s/c/packbits.c \ /bb/s/c/packdiff.c \ /bb/s/c/pfad.c \ /bb/fg/c/rgbtools.c \ /bb/s/c/rtt.c \ /bb/s/c/scrinfo.c \ /bb/s/c/set.c \ /bb/s/c/sockcom.c \ /bb/s/c/softdum.c \ /bb/s/c/swap.c \ /bb/s/c/syslog.c \ /bb/s/c/textino.c \ /bb/fg/c/tiffconv.c \ /bb/s/c/udpcom.c \ /bb/s/c/utoa.c \ /bb/s/c/vgl.c \ /bb/s/c/w32argv.c \ /bb/fg/c/w32bmp.c \ /bb/s/c/w32error.c \ /bb/s/c/w32font.c \ /bb/fg/c/w32ico.c \ /bb/s/c/w32macadr.c \ /bb/s/c/w32pfad.c \ /bb/s/c/w32pipe.c \ /bb/s/c/w32print.c \ /bb/s/c/w32puts.c \ /bb/s/c/w32reg.c \ /bb/fg/c/w32scalebmp.c \ /bb/s/c/w32screen.c \ /bb/s/c/w32scroll.c \ /bb/s/c/w32toolbar.c \ /bb/s/c/w32tools.c \ /bb/s/c/w32winms.c \ /bb/s/c/wsinit.c \ /bb/s/c/zeitc.c dmsw_exe_CXX_SRCS= dmsw_exe_RC_SRCS = /bb/nt/rc/dmsw/dmsw_wine.rc dmsw_exe_LDFLAGS = -mwindows \ -mno-cygwin dmsw_exe_DLL_PATH= dmsw_exe_DLLS = odbc32 \ ole32 \ oleaut32 \ winspool dmsw_exe_LIBRARY_PATH= dmsw_exe_LIBRARIES= uuid dmsw_exe_OBJS = $(dmsw_exe_C_SRCS:.c=.o) \ $(dmsw_exe_CXX_SRCS:.cpp=.o) \ $(dmsw_exe_RC_SRCS:.rc=.res) ### Global source lists C_SRCS = $(dmsw_exe_C_SRCS) CXX_SRCS = $(dmsw_exe_CXX_SRCS) RC_SRCS = $(dmsw_exe_RC_SRCS) ### Tools CC = winegcc CXX = wineg++ RC = wrc ### Generic targets all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES:%=%.so) ### Build rules .PHONY: all clean dummy $(SUBDIRS): dummy @cd $@ && $(MAKE) # Implicit rules .SUFFIXES: .cpp .rc .res DEFINCL = $(INCLUDE_PATH) $(DEFINES) $(OPTIONS) .c.o: $(CC) -c $(CFLAGS) $(CEXTRA) $(DEFINCL) -o $@ $< .cpp.o: $(CXX) -c $(CXXFLAGS) $(CXXEXTRA) $(DEFINCL) -o $@ $< .cxx.o: $(CXX) -c $(CXXFLAGS) $(CXXEXTRA) $(DEFINCL) -o $@ $< .rc.res: $(RC) $(RCFLAGS) $(RCEXTRA) $(DEFINCL) -fo$@ $< # Rules for cleaning CLEAN_FILES = y.tab.c y.tab.h lex.yy.c core *.orig *.rej \ \\\#*\\\# *~ *% .\\\#* clean:: $(SUBDIRS:%=%/__clean__) $(EXTRASUBDIRS:%=%/__clean__) $(RM) $(CLEAN_FILES) $(RC_SRCS:.rc=.res) $(C_SRCS:.c=.o) $(CXX_SRCS:.cpp=.o) $(RM) $(DLLS:%=%.so) $(EXES:%=%.so) $(EXES:%.exe=%) $(SUBDIRS:%=%/__clean__): dummy cd `dirname $@` && $(MAKE) clean $(EXTRASUBDIRS:%=%/__clean__): dummy -cd `dirname $@` && $(RM) $(CLEAN_FILES) ### Target specific build rules DEFLIB = $(LIBRARY_PATH) $(LIBRARIES) $(DLL_PATH) $(dmsw_exe_MODULE).so: $(dmsw_exe_OBJS) $(CC) $(dmsw_exe_LDFLAGS) -o $@ $(dmsw_exe_OBJS) $(dmsw_exe_LIBRARY_PATH) $(DEFLIB) $(dmsw_exe_DLLS:%=-l%) $(dmsw_exe_LIBRARIES:%=-l%)

2 2

Re: [PATCH] generate stand alone AC_CONFIG_FILES() lines.
by Saulius Krasuckas 01 Mar '07

01 Mar '07

* On Tue, 27 Feb 2007, Marcus Meissner wrote: > Another try to generate stand alone AC_CONFIG_FILES lines > to make git merges easier. Thank you Marcus (and others) very much for that :)

1 0

Re: [9/12] WineD3D: When multithreading, call glFinish after drawing
by H. Verbeet 01 Mar '07

01 Mar '07

Would GL_NV_fence be usefull here?

2 1

Re: ntdll: implement NtAllocateLocallyUniqueId with server call (resend)
by Alexandre Julliard 01 Mar '07

01 Mar '07

Juan Lang <juan_lang(a)yahoo.com> writes: > Any feedback on this one? > > ChangeLog: implement NtAllocateLocallyUniqueId with server call In general it's better to define server-specific types based on simple C types instead of using Windows data types in server requests. This gives us more control about the data layout, and avoids confusion with things like long/LONG etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] d3d9: Add a mova rounding test
by Alexandre Julliard 01 Mar '07

01 Mar '07

"H. Verbeet" <hverbeet(a)gmail.com> writes: > It should be noted that native d3d rounds to nearest even while Wine > doesn't. Applications are not supposed to depend on that though. > > Changelog: > - Add a mova rounding test The test fails here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:405: Test failed: Expected color 00ffff00, got 00000000 (for input -2.400000) visual.c:405: Test failed: Expected color 00ffff00, got 00000000 (for input -1.600000) visual.c:405: Test failed: Expected color 0000ffff, got 00000000 (for input -0.400000) visual.c:405: Test failed: Expected color 0000ffff, got 00000000 (for input 0.400000) visual.c:405: Test failed: Expected color 00ff00ff, got 00000000 (for input 1.600000) visual.c:405: Test failed: Expected color 00ff00ff, got 00000000 (for input 2.400000) make: *** [visual.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

3 4

Wine's Wiki Defaced
by Francois Gouget 01 Mar '07

01 Mar '07

Someone has defaced Wine's Wiki frontpage. Also I have either forgotten my password or the user accounts don't work anymore. Could someone look into this? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.

2 2

DIB Engine & GSoC
by Benoit Pradelle 01 Mar '07

01 Mar '07

Hi, I would like participate to the Google Summer Of Code with Wine by implementing a DIB Engine. I've searched a lot of informations about the DIB Engine but i still got one question : for you, how important is a DIB Engine in Wine ? Ben.

1 0

Re: user32: add more tests for GetUpdateRect()
by Dmitry Timoshkov 01 Mar '07

01 Mar '07

"Clinton Stimpson" <cjstimpson(a)utwire.net> wrote: > Here's another test to add to test_GetUpdateRect(). > This case doesn't uses CS_PARENTDC as suggested in bug #7360. > +static LRESULT WINAPI test_GetUpdateRect_window_procA(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + return DefWindowProc(hwnd, msg, wparam, lparam); > +} You can just specify 'cls.lpfnWndProc = DefWindowProcA;' to avoid useless test_GetUpdateRect_window_procA body. > + cls.style = 0; > + cls.lpfnWndProc = test_GetUpdateRect_window_procA; > + cls.cbClsExtra = 0; > + cls.cbWndExtra = 0; > + cls.hInstance = GetModuleHandleA(0); > + cls.hIcon = 0; > + cls.hCursor = LoadCursorA(0, (LPSTR)IDC_ARROW); > + cls.hbrBackground = GetStockObject(WHITE_BRUSH); > + cls.lpszMenuName = NULL; > + cls.lpszClassName = "CSParentDCWindowClass"; Strange class name since it doesn't use CS_PARENTDC style at all. -- Dmitry.

1 0

Re: [2/6] winex11.drv: Try to get an opengl visual with aux buffers
by Vitaliy Margolen 01 Mar '07

01 Mar '07

> I don't know if that patch wasn't applied because other patches of my patchset > weren't applied, or because something is wrong with this patch. If something > is wrong with this patch please tell me > @@ -3083,33 +3083,44 @@ BOOL X11DRV_SwapBuffers(X11DRV_PDEVICE *physDev) > XVisualInfo *X11DRV_setup_opengl_visual( Display *display ) > { > XVisualInfo *visual = NULL; > - /* In order to support OpenGL or D3D, we require a double-buffered visual and stencil buffer support, */ > - int dblBuf[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_DOUBLEBUFFER, None}; > + /* In order to support OpenGL or D3D, we require a double-buffered visual and stencil buffer support, > + * WineD3D and Some applications can make use of aux buffers > + */ > + int dblBuf[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_AUX_BUFFERS, 1, GLX_DOUBLEBUFFER, None}; [skip] > + int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_DOUBLEBUFFER, None}; [skip] > + int dblBuf3[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_STENCIL_SIZE, 8, GLX_DOUBLEBUFFER, None}; [skip] > + int dblBuf4[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_DOUBLEBUFFER, None}; 3 levels was bad enough. Can we put this in an array and iterate through it instead of adding more levels? Specific comments can go there as well. Vitaliy.

1 0

Re: ntdll: Some code cleanup
by Vitaliy Margolen 01 Mar '07

01 Mar '07

Felix Nawothnig wrote: > - if (last) > - { > - LdrShutdownProcess(); > - exit( exit_code ); > - } > - else > - { > - LdrShutdownThread(); > - server_exit_thread( exit_code ); > - } > + NtTerminateThread( GetCurrentThread(), func( arg ) ); > + exit(0); /* To avoid a compiler warning, never reached. */ server_exit_thread() and NtTerminateThread() (which calls server_abort_thread()) are not the same things! Former gracefully exits the current thread freeing it's memory. Later rips it out from the process without freeing any resources. Needless to say you can't do that. Vitaliy.

1 0

Re: kernel32: Remove server-call from ExitThread()
by Dmitry Timoshkov 01 Mar '07

01 Mar '07

"Felix Nawothnig" <flexo(a)holycrap.org> wrote: > - if (last) > - { > - LdrShutdownProcess(); > - exit( code ); > - } > - else RtlExitUserThread( code ); > + TerminateThread( GetCurrentThread(), code ); > + exit(code); /* To avoid a compiler warning, never reached. */ > } New code now calls exit() unconditionally killing the whole process. If you follow the TerminateThread way you will notice that exit() is being already called on its time. -- Dmitry.

1 0

Re: [2/6] winex11.drv: Try to get an opengl visual with aux buffers
by Ivan Gyurdiev 01 Mar '07

01 Mar '07

Something's wrong with this patch: it has more 2 nested if statements. I suggest early returns on negated condition, gotos, and subroutines to fix the problem :) > I don't know if that patch wasn't applied because other patches of my patchset > weren't applied, or because something is wrong with this patch. If something > is wrong with this patch please tell me > > ------------------------------------------------------------------------ > > From 029e9756abed6c2647950f86e9227ba47d366ebe Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Tue, 27 Feb 2007 15:53:43 +0100 > Subject: [PATCH] winex11.drv: Try to get an opengl visual with aux buffers > > Applications may profit from auxilliary buffers. Because we have to find > the visual at initialization time try to find a visual with aux buffers > first, if none is found fall back to the usual default visual without > aux buffers > --- > dlls/winex11.drv/opengl.c | 35 +++++++++++++++++++++++------------ > 1 files changed, 23 insertions(+), 12 deletions(-) > > diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c > index fdb92ae..9c1060a 100644 > --- a/dlls/winex11.drv/opengl.c > +++ b/dlls/winex11.drv/opengl.c > @@ -3083,33 +3083,44 @@ BOOL X11DRV_SwapBuffers(X11DRV_PDEVICE *physDev) > XVisualInfo *X11DRV_setup_opengl_visual( Display *display ) > { > XVisualInfo *visual = NULL; > - /* In order to support OpenGL or D3D, we require a double-buffered visual and stencil buffer support, */ > - int dblBuf[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_DOUBLEBUFFER, None}; > + /* In order to support OpenGL or D3D, we require a double-buffered visual and stencil buffer support, > + * WineD3D and Some applications can make use of aux buffers > + */ > + int dblBuf[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_AUX_BUFFERS, 1, GLX_DOUBLEBUFFER, None}; > if (!has_opengl()) return NULL; > > wine_tsx11_lock(); > visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf); > wine_tsx11_unlock(); > if (visual == NULL) { > - /* fallback to 16 bits depth, no alpha */ > - int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_STENCIL_SIZE, 8, GLX_DOUBLEBUFFER, None}; > - WARN("Failed to get a visual with at least 24 bits depth\n"); > + /* Try without aux buffers */ > + int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_DOUBLEBUFFER, None}; > + WARN("Failed to get a visual with at least one aux buffer\n"); > > wine_tsx11_lock(); > visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf2); > wine_tsx11_unlock(); > if (visual == NULL) { > - /* fallback to no stencil */ > - int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_DOUBLEBUFFER, None}; > - WARN("Failed to get a visual with at least 8 bits of stencil\n"); > + /* fallback to 16 bits depth, no alpha */ > + int dblBuf3[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_STENCIL_SIZE, 8, GLX_DOUBLEBUFFER, None}; > + WARN("Failed to get a visual with at least 24 bits depth\n"); > > wine_tsx11_lock(); > - visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf2); > + visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf3); > wine_tsx11_unlock(); > if (visual == NULL) { > - /* This should only happen if we cannot find a match with a depth size 16 */ > - FIXME("Failed to find a suitable visual\n"); > - return visual; > + /* fallback to no stencil */ > + int dblBuf4[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_DOUBLEBUFFER, None}; > + WARN("Failed to get a visual with at least 8 bits of stencil\n"); > + > + wine_tsx11_lock(); > + visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf4); > + wine_tsx11_unlock(); > + if (visual == NULL) { > + /* This should only happen if we cannot find a match with a depth size 16 */ > + FIXME("Failed to find a suitable visual\n"); > + return visual; > + } > } > } > } > > ------------------------------------------------------------------------ > > >

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel March 2007