May 2007 - wine-devel

Re: some doubts about sendind patches - is text/plain way good?
by Kirill K. Smirnov 26 May '07

26 May '07

>You might want to try the following: Select the patch from >http://thread.gmane.org/gmane.comp.emulators.wine.patches/ , >select the link after "Direct link" on the bottom, append "/raw" >without quotation marks after the URL. Now you can save the file >at that URL as is and use it with patch, it will ignore the headers. It works! Cool! (but a little complicated ;-) Thanks a lot for hint! -- Kirill

1 0

Re: [PATCH 3/6] CMD.EXE: Handle command line as Unicode
by Dmitry Timoshkov 26 May '07

26 May '07

"Jason Edmeades" <us(a)edmeades.me.uk> wrote: > int main (int argc, char *argv[]) > { > + LPWSTR *argvW = NULL; > + int args; > + WCHAR *cmdW = NULL; If you will start using wmain() instead of main() you get unicode args for free, and that will help to avoid changing the command line parsing code. -- Dmitry.

2 3

Re: some doubts about sendind patches - is text/plain way good?
by Kirill K. Smirnov 26 May '07

26 May '07

В сообщении от 26 мая 2007 21:24 вы написали: > I'll double check later, but are you sure? > > When I said I hadn't changed the patches, I meant the contents, but I had > done a git fetch, git rebase origin on the branch (and resolved the german > resource conflict) before resubmitting I got the following messages: patching file programs/cmd/Cs.rc patching file programs/cmd/De.rc Hunk #1 FAILED at 263. 1 out of 1 hunk FAILED -- saving rejects to file programs/cmd/De.rc.rej patching file programs/cmd/En.rc patching file programs/cmd/Es.rc patching file programs/cmd/Fr.rc patching file programs/cmd/Ja.rc patching file programs/cmd/Ko.rc Hunk #1 FAILED at 235. 1 out of 1 hunk FAILED -- saving rejects to file programs/cmd/Ko.rc.rej patching file programs/cmd/Nl.rc patching file programs/cmd/No.rc patching file programs/cmd/Pl.rc patching file programs/cmd/Pt.rc patching file programs/cmd/Ru.rc patching file programs/cmd/Si.rc ... I noticed that German translations patch failed, checked git log, saw that translation has been updated and panic. ;-) I rechecked patch - it is ok, not outdated, but I still cannot apply it. Why? I have only one consideration. As I noticed, patches are sent with different MIME types. In wine-patches mailing list different types are handled differently - if text/plain then attach is embedded into body, if not text/plain (usually text/x-patch) then attach is available via special URL link. I do not receive mail from wine-patches mail list. Thus, to get the patch sent with MIME text/plain I use select/copy/paste/save technique. If patch is not text/plain, I just use "save link target" option in browser. That patch was sent with MIME type text/plain, so I had to copy/paste it. When I tried to save it via kwrite it complained about problems with UTF8 characters, but I did not pay attention and went on. While patching I got messages I wrote before. I've tried VIM as an editor to save too. It does not complain but file I get is still unusable. This make me think, that idea to sent patches with text/plain MIME type (as recommended at http://winehq.org/site/docs/winedev-guide/style-notes) is not a really good way. Also there may be an encoding problem - while sending patches kmail (MUA I use) asks me what enconding to use (7bit, 8bit, base-64). I always set 8-bit. Now I am in doubts if I follow a right way. Any comments? -- Kirill P.S. sorry for rising up nonsence with Jason's patch. It is looks correct, I cannot say more. ;-)

2 1

CMD.EXE patchset 1->6
by Ann & Jason Edmeades 26 May '07

26 May '07

Apologies if this set arrives multiple times - I sent it all on Friday, and the mailing list only shows 1,2 and 4. I sent then again tonight separately, and immediately 3 went missing... FYI I had this problem before the last hardware upgrade on winehq, and it appeared fixed since then. I'll start copying a gmail account in future to confirm what I am seeing, but last time some emails got delayed about a month in transit and eventually appeared, but ONLY when winehq was involved, gmail, hotmail, my own email addr etc all got immediate copies... Regards, Jason

4 6

Re: [PATCH 4/6] CMD.EXE: Convert cmd into unicode
by Detlef Riekenberg 26 May '07

26 May '07

On Di, 2007-05-08 at 00:11 +0100, Jason Edmeades wrote: > Apologies for the size of this patch - I tried 3 or 4 ways of converting > chunks to unicode and always ended up duplicating huge bits of code and > having problems keeping track of duplicated variables that in the end I > did the lot in one go. You need TCHAR and friends to reduce the Patch-Size (char => TCHAR when you did char => WCHAR) And do not forget "* sizeof(TCHAR)" when calculating the required size for allocations (HeapAlloc) -- By by ... Detlef

2 1

Re: [AppDB] Add apidb_footer to browse downloadable page
by Alexander Nicolaysen Sørnes 26 May '07

26 May '07

Lørdag 26 mai 2007 19:02, skrev Chris Morgan: > On 5/26/07, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > > Lørdag 26 mai 2007 18:53, skrev Chris Morgan: > > > We should move that page to a class and integrate it in with the > > > objectManager stuff. Its a pretty simple page. > > > > > > Chris > > > > I agree > > I meant instead of applying this patch we should move it to use the > objectManager stuff ;-) > > Chris Oh, so it was a trick question, then? :D I'll just move it over and adapt it to the objectManager's page browsing framework later. Alexander

1 0

Re: 64-bit compilation broken today
by Clinton Stimpson 26 May '07

26 May '07

>> The confusing thing to me is that I *do* have the libxml2-dev package >> installed, and see no errors about a missing header... >> >> If it didn't recognize the xmlNodePtr type, shouldn't it have choked on >> line 52 first? >> >> -J >> >> >> Bryan DeGrendel wrote: >> >>> A couple of libxml2 externs were recently added to >>> dlls/msxml3/msxml_private.h Both functions have a xmlNodePtr as a >>> parameter, which is defined in the libxml2 header. However, both >>> externs were added outside msxml_private.h's libxml2 preprocessor >>> check, so I believe it causes a compilation error if you don't have >>> the libxml header. I have sent a patch which should fix it. >>> >>> Bryan DeGrendel >>> >>> On 5/25/07, *Evil Jay* <wine(a)eternaldusk.com >>> <mailto:wine@eternaldusk.com>> wrote: >>> >>> This might already be known, but sometime in the last eight hours >>> or so, >>> git seems to have broken: >>> >>> gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ >>> -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe >>> -fno-strict-aliasing >>> -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g >>> -O2 -o >>> attribute.o attribute.c >>> In file included from attribute.c:32: >>> msxml_private.h:67: error: expected declaration specifiers or '...' >>> before 'xmlNodePtr' >>> msxml_private.h:68: error: expected declaration specifiers or '...' >>> before 'xmlNodePtr' >>> make[2]: *** [attribute.o] Error 1 >>> make[2]: Leaving directory `/data/install/wine/dlls/msxml3' >>> make[1]: *** [msxml3] Error 2 >>> make[1]: Leaving directory `/data/install/wine/dlls' >>> make: *** [dlls] Error 2 > I also have the libxml2-dev package installed, however HAVE_LIBXML2 was not > defined. Therefore lines 28-60 were not compiled. I suspect this is the > same quirk in your case. > > Bryan DeGrendel > I had the same compile error until I installed the libxml2-devel.i386 package. I had libxml2-devel.x86_64 already installed. Clint

2 1

[PATCH 1/6] CMD.EXE: Move english constants into NLS files
by Kirill K. Smirnov 26 May '07

26 May '07

Hi Jason, Since German and Korean resource have been updated, this patch is a little outdated and cannot be applied. Please, rediff. Other patches may be outdated too. -- Kirill

2 1

No release today?
by Scott Ritchie 26 May '07

26 May '07

I heard a rumor in IRC that there wasn't going to be a release today. Seems to be true. Alexandre, in the future could you please send out an email to wine-devel when you know there won't be a release? I scheduled my day partially around building the upcoming 0.9.38 packages, but that didn't happen. Thanks, Scott Ritchie

3 4

Re: hnetcfg: [resend 3] 1/5 add spec file for hnetcfg
by Detlef Riekenberg 26 May '07

26 May '07

On Sa, 2007-05-26 at 19:37 +1000, Jeff Latimer wrote: > --- > dlls/hnetcfg/hnetcfg.spec | 44 > ++++++++++++++++++++++++++++++++++++++++++++ I suggest, that you read and follow this Hints: http://wiki.winehq.org/Developers-Hints#head-30a7f7f51ce0e42b4141749c9832ba… Thanks -- By by ... Detlef

1 0

[dmaxwell@coverity.com: Re: database full for "Wine" project?]
by Marcus Meissner 26 May '07

26 May '07

Hi, If you have a Coverity Wine account... This is for our information. Ciao, Marcus ----- Forwarded message from David Maxwell <dmaxwell(a)coverity.com> ----- Date: Sat, 26 May 2007 08:31:13 -0400 From: David Maxwell <dmaxwell(a)coverity.com> To: Marcus Meissner <marcus(a)jet.franken.de> Subject: Re: database full for "Wine" project? On Sat, May 26, 2007 at 07:50:10AM +0200, Marcus Meissner wrote: > Hi David, > > I just tried to change a CID in the Wine project > and it results in this error message: > > [ERROR:db.c:226]: database is full: The database is full. > > Ciao, Marcus Hi Marcus, Sorry about that - it's a diskspace issue again. I'm moving Wine over to the new web hosting provider now. It will take a while for the copy, and I won't have Internet again until later on today. The new URL will be: http://scan2.coverity.com:7479/ I'll send an email when the move is complete. Could you let the other Wine developers know about the move and the new URL? Thanks. -- David Maxwell Coverity Open Source Strategist http://scan.coverity.com/ ----- End forwarded message -----

1 0

Alarming number of users getting hardlocks with Wine
by Scott Ritchie 26 May '07

26 May '07

Reading the Ubuntu forums, I've noticed quite a few reports from users complaining about Wine deadlocking their system - keyboard unresponsive, with no solution but to restart the entire computer. Sometimes users report this problem after running ANY Wine process - even winecfg. I'm not sure what's causing the issue. At first I thought it was a hardware thing (perhaps ATI's infamously terribly drivers), but would that still prevent winecfg from working? Wine is a user-level process, it shouldn't be able to cause a hardlock under any circumstances, right? Anyone else seen these kinds of reports? Thanks, Scott Ritchie

9 9

Re: [PATCH 4/4] secur32: Fix NTLM's InitializeSecurityContextA/W to be flexible with the index of the token buffer in both the input and output buffer descriptions.
by Kai Blin 25 May '07

25 May '07

On Thursday 24 May 2007 21:04:47 Robert Shearman wrote: > This patch allows native rpcrt4.dll to use NTLM authentication. Nice :) And it looks like it wasn't that much work to fix my code ;) > TRACE("pInput->pBuffers[0].cbBuffer is: %ld\n", > - pInput->pBuffers[0].cbBuffer); > + pInput->pBuffers[input_token_idx].cbBuffer); > ret = SEC_E_INVALID_TOKEN; If you change the index of the token buffer, could you please fix the trace accordingly? > + WARN("no SECBUFFER_TOKEN buffer could be found\n"); > + ret = SEC_E_BUFFER_TOO_SMALL; > + goto isc_end; > } Is that intentional? According to the developer's guide, "[y]ou should report a warning when something unwanted happens, and the function cannot deal with the condition." This is something the calling application screwed up, so I think a TRACE should be sufficient. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

1 1

Compiling tests standalone on windows
by Dan Kegel 25 May '07

25 May '07

(This is more for my own notekeeping, but maybe it'll be of interest to somebody else.) Sometimes it's nice to build a test with visual C++ on Windows without any makefiles or projects. You just have to get a command prompt that has run vcvars32.bat, e.g. by doing Start / All Programs / Visual C++ 2005 Express Edition / Visual Studio Tools / VS 2005 Command Prompt and then do e.g. cd wine-git\dlls\gdi32\tests cl -DSTANDALONE -D_X86_ -I../../../include pen.c gdi32.lib But for some reason today that didn't work for me; cl couldn't find gdi32.lib unless I gave an absolute path, which made no sense (since the same path was already in LIB). To try to track this down, I wrote a tiny batch file to reproduce everything: set PSDK=C:\Program Files\Microsoft Platform SDK set VS8=C:\Program Files\Microsoft Visual Studio 8 set LIB=%VS8%\VC\LIB;%VS8%\SDK\v2.0\lib;%PSDK%\Lib set INCLUDE=%VS8%\VC\INCLUDE;%PSDK%\Include set PATH=%VS8%\VC\BIN;%VS8%\Common7\IDE;%PATH% cd \dank\wine-git\dlls\gdi32\tests cl -DSTANDALONE -D_X86_ -I../../../include pen.c gdi32.lib Oddly enough, that worked fine. I dunno why the problem went away.

1 0

Re: New winetricks: add support for Red Hat's liberation fonts
by Dan Kegel 25 May '07

25 May '07

On 5/24/07, Brian Vincent <brian.vincent(a)gmail.com> wrote: > I haven't even looked at that stuff at all, but does Wine have any > fonts worth contributing to that cause? (Marlett?) Red Hat's Liberation font is a single-source thing done by a pro, so probably not. > Is it worth > creating a link within winecfg to download and install these somehow? > Good fonts can really help the user experience with Wine. No, it would be better to have Wine install the fonts by default once they are proven useful, I think. I added them to winetricks so people could experiment with them (slightly) more easily. - Dan

4 5

Re: RegDeleteTree [10]
by James Hawkins 25 May '07

25 May '07

On 5/25/07, Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > Am Friday 25 May 2007 00:48 schrieb Juan Lang: > > Hi Stefan, > > > > + /* Find how many subkeys there are */ > > > > This comment is incorrect. > > > > You have also reintroduced tabs in this patch - please don't do that. > > --Juan > ChangeLog > ------------- > added implementation of RegDeleteTreeA/W > + if (lpszSubKey) { + ret = RegDeleteKeyW(hKey, lpszSubKey); + } else { + while (TRUE) { + dwSize = dwMaxLen; + if (RegEnumValueW(hKey, 0, lpszName, &dwSize, + NULL, NULL, NULL, NULL)) break; + + ret = RegDeleteValueW(hKey, lpszName); + if (ret) goto cleanup; + } + } Please stick with the style of the rest of the file, e.g., opening braces on the next line. There is one short function that uses the style you're using, but we don't need to be adding even more variety to the style. -- James Hawkins

2 1

Re: credui: Add stub for CredUIReadSSOCredW
by James Hawkins 25 May '07

25 May '07

On 5/25/07, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > According to wine's headers, the *A version isn't in there, so not > adding a stub for it. > You forgot to attach the patch. -- James Hawkins

1 0

bugzilla component needed
by James Hawkins 25 May '07

25 May '07

Hey Tony, Can we get a wine-advapi32 component? Thanks, James Hawkins

2 1

Re: crypt32: remove wrong test and parameter check
by Detlef Riekenberg 25 May '07

25 May '07

On Do, 2007-05-24 at 16:45 -0700, Juan Lang wrote: > --Juan No Patch was found in this Message. -- By by ... Detlef

1 0

"Submitted Bug Link rejected" notification is kinda useless
by RusH 25 May '07

25 May '07

Here is my problem : On 5/25/07, AppDB <appdb-noreply(a)winehq.org> wrote: > > Submitted Bug Link rejected > ------------------------------------------------------- > The Bug Link you submitted for eMule 0.46c has been rejected. > We appreciate your help in making the Application Database better for all users. > > Best regards. > The AppDB team > http://appdb.winehq.org/ > > > If you don't want to receive any other e-mail, please change your preferences: > http://appdb.winehq.org/preferences.php as you can see this automatically generated notification is useless, it tells me that one of Bug Links has been deleted, but doesnt tell me which one, and why :( This is bad for people that submit bug links. Now the other end of the equation - Im the maintainer of uTorrent on appdb and had to delete a bug link. Someone submitted a link to a weird bug, there was no mention about utorrent in that bug and I couldnt reproduce it. My actions should be -ask submitter about more details -delete link filling the REASON field with question to submitter about more details but there is no "submitter" field in "Known bugs" list, there is also no "reason" field when I delete bugs. In that particular case I digged up the email from AppDB with info "Link between Bug xxxx and utorrent 1.7 submitted by blabla" and googled for the blabla person, fortunately I was able to find his email and write him a message, but it would be far more user friendly and productive to be able to just do that from the appdb admin form (mail/message bug submitters/ state reason for deletion) -- Who logs in to gdm? Not I, said the duck.

3 2

About Parallel Port Driver
by Zhongli Xu 25 May '07

25 May '07

Hi all, I have a .sys driver for parallel port communication. But it seems wine didn't support loading the driver. My windows program has to be configured as XP version. And directly accessing to parallel port is not allowed on the XP host, therefore _outp() and _inp() are useless. Is there any solution to this problem? Best Regards, Milo Xu

1 0

Re: RegDeleteTree [9]
by Juan Lang 24 May '07

24 May '07

Hi Stefan, + /* Find how many subkeys there are */ This comment is incorrect. You have also reintroduced tabs in this patch - please don't do that. --Juan ____________________________________________________________________________________Pinpoint customers who are looking for what you sell. http://searchmarketing.yahoo.com/

1 0

GIT access fails
by Kirill K. Smirnov 24 May '07

24 May '07

> Did you happen to update curl/libcurl? No, I did not update anything for a few weeks. Git stopped to work a couple of days ago. Should I update curl? My version is 7.15.3.

1 0

GIT access fails
by Kirill K. Smirnov 24 May '07

24 May '07

Hi, Something strange happened to git - fetch fails if uses git:// protocol. In tcpdump I can see my machine and wine.codeweavers.com chating. Thus connection is OK. When I changed protocol to http:// in .git/remotes/origin, I managed to update local git repo. This is very strange - git:// does not work, but http:// does! I did not update git utility on my system. git version is 1.4.2.1. No firewalls too. Any ideas? Thanks, -- Kirill

2 1

problems regression testing/compiling wine
by EA Durbin 24 May '07

24 May '07

I'm having problems regression testing between 0.9.15 and 0.9.37. On 3+ bisects I keep getting the following error and wine won't compile. /home/eric/wine/dlls/winex11.drv/palette.c:866: undefined reference to `GDI_ReleaseObj' palette.o:/home/eric/wine/dlls/winex11.drv/palette.c:881: more undefined references to `GDI_ReleaseObj' follow palette.o: In function `X11DRV_RealizePalette': /home/eric/wine/dlls/winex11.drv/palette.c:1251: undefined reference to `GDI_GetObjPtr' /home/eric/wine/dlls/winex11.drv/palette.c:1253: undefined reference to `GDI_ReleaseObj' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [winex11.drv.so] Error 2 make[2]: Leaving directory `/home/eric/wine/dlls/winex11.drv' make[1]: *** [winex11.drv] Error 2 make[1]: Leaving directory `/home/eric/wine/dlls' make: *** [dlls] Error 2 _________________________________________________________________ More photos, more messages, more storageget 2GB with Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

5 7

Status regarding the recent Appdb vandalism
by Jan Zerebecki 24 May '07

24 May '07

Please do _only_ address replies to this email to wine-devel(a)winehq.org ! Remove all other recipients from To and Cc ! Work is currently underway to restore the state of the Appdb to the backup of May 22 07:00 CST. This morning ( TZ +0200 ) someone used the account "Molle Bestefich" to vandalize the Appdb. He was also seen on IRC and on the wiki. His IP was identified on all three, logs are available. See towards the end of this mail for IRC log snippet and whois on his IP. Please contact me first if you intend to contact abuse or police personal regarding this, so we don't cause headaches or duplicate work. We do not yet know how this person got access to Molle Bestefich his account. I received 4454 emails about deletes or other actions by the account "Molle Bestefich". Send between "Date: Tue, 22 May 2007 21:43:46 -0500" and "Date: Tue, 22 May 2007 22:18:55 -0500". (2 mails sent by the Appdb in that date range were legit actions.) I don't know if these are all, because admin-accounts were explicitly deleted and thus the notification to them stopped. The following applications where mentioned in these notification emails: Adobe Illustrator Battlefield 1942 Battlefield 2 Battlefield 2142 Call of Duty 2 Call of Duty Checkpoint Firewall-1 Policy editor Command & Conquer 3: Tiberium Wars Counter-Strike: Source Day of Defeat: Source Deus Ex Diablo II EVE Online F.E.A.R.: First Encounter Assault Recon Final Fantasy XI Online Guild Wars IDA Pro Photoshop S.T.A.L.K.E.R. : Shadow of Chernobyl Soldat Steam Supreme Commander The Elder Scrolls IV: Oblivion Trillian World of Warcraft PunkBuster Rune Igowin Age of Empires Age of Mythology Black & White Brothers in Arms Flash FlatOut .NET Framework Lotus Notes Some notifcations didn't contain a application of version, here the Message-Id-s of some examples (this is probably a bug in the Appdb code): screen shot Message-Id: <E1HqgpS-0008Ay-OM(a)wine.codeweavers.com> test result Message-Id: <E1Hqgs7-0001iH-S7(a)wine.codeweavers.com> monitor Message-Id: <E1HqgsD-0001mW-It(a)wine.codeweavers.com> bug Message-Id: <E1HqhDT-0003xe-GS(a)wine.codeweavers.com> One message about a rejected bug link seemed like these type of message don't contain any information: Message-Id: <E1Hqh5W-0000QE-UG(a)wine.codeweavers.com> On IRC from the #winehq channel: Mai 23 05:27:14 --> noerrorsfound_ (n=nicholas(a)h10.66.119.64.ip.alltel.net) has joined #winehq [unrelated stuff deleted] Mai 23 06:21:37 --- noerrorsfound_ is now known as molle-molle-moll Mai 23 06:21:41 <molle-molle-moll> molle molle molle Mai 23 06:21:42 <molle-molle-moll> molle Mai 23 06:21:51 <molle-molle-moll> molle Mai 23 06:22:03 <molle-molle-moll> mole string Mai 23 06:22:18 <molle-molle-moll> hello give thank Mai 23 06:22:18 <-- Amorphous has kicked molle-molle-moll from #winehq (Amorphous) /whois output: [06:22:38] --- [molle-molle-moll] (n=nicholas(a)h10.66.119.64.ip.alltel.net) : Nicholas [06:22:38] --- [whoismolle-molle-moll] irc.freenode.net :http://freenode.net/ [06:22:38] --- [molle-molle-moll] End of WHOIS list. 2007-05-23T06:50:15+0200 $ whois 64.119.66.10 OrgName: Windstream Communications Inc OrgID: WINDS-6 Address: 4001 Rodney Parham Rd City: Little Rock StateProv: AR PostalCode: 72212 Country: US NetRange: 64.119.64.0 - 64.119.79.255 CIDR: 64.119.64.0/20 NetName: WINDSTREAM-COMMUNICATIONS NetHandle: NET-64-119-64-0-1 Parent: NET-64-0-0-0-0 NetType: Direct Allocation NameServer: NS1-AUTH.WINDSTREAM.NET NameServer: NS2-AUTH.WINDSTREAM.NET NameServer: NS3-AUTH.WINDSTREAM.NET NameServer: NS4-AUTH.WINDSTREAM.NET Comment: ADDRESSES WITHIN THIS BLOCK ARE NON-PORTABLE RegDate: 2001-08-24 Updated: 2007-02-26 OrgAbuseHandle: WINDS1-ARIN OrgAbuseName: Windstream Abuse OrgAbusePhone: +1-888-292-3827 OrgAbuseEmail: abuse(a)windstream.net OrgTechHandle: WINDS-ARIN OrgTechName: Windstream Communications Inc OrgTechPhone: +1-800-990-4449 OrgTechEmail: ipadmin(a)windstream.net # ARIN WHOIS database, last updated 2007-05-22 19:10 # Enter ? for additional hints on searching ARIN's WHOIS database.

5 4

Re: wininet: Pass -1 into WideCharToMultiByte instead of calling lstrlenW on the string to slightly reduce code size.
by Alexandre Julliard 24 May '07

24 May '07

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -504,8 +504,8 @@ static BOOL HTTP_DoAuthorization( LPWININETHTTPREQW lpwhr, LPCWSTR pszAuthValue > > if (is_basic_auth_value(pszAuthValue)) > { > - int userlen = WideCharToMultiByte(CP_UTF8, 0, domain_and_username, lstrlenW(domain_and_username), NULL, 0, NULL, NULL); > - int passlen = WideCharToMultiByte(CP_UTF8, 0, password, lstrlenW(password), NULL, 0, NULL, NULL); > + int userlen = WideCharToMultiByte(CP_UTF8, 0, domain_and_username, -1, NULL, 0, NULL, NULL); > + int passlen = WideCharToMultiByte(CP_UTF8, 0, password, -1, NULL, 0, NULL, NULL); This won't work, -1 is not equivalent to lstrlenW. -- Alexandre Julliard julliard(a)winehq.org

1 0

New winetricks: add support for Red Hat's liberation fonts
by Dan Kegel 24 May '07

24 May '07

As requested by Mark Cox, I've added a verb to winetricks to install Red Hat's Liberation fonts (http://www.redhat.com/promo/fonts/). -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: winscard: add pcsc-lite helpers for upcoming implementation (try 2)
by Alexandre Julliard 24 May '07

24 May '07

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > +/* > + * pcsc-lite functions pointers > + */ > +typedef LONG (*SCardEstablishContextPtr)(DWORD dwScope,LPCVOID pvReserved1, > + LPCVOID pvReserved2, LPSCARDCONTEXT phContext); > +typedef LONG (*SCardReleaseContextPtr)(SCARDCONTEXT hContext); > +typedef LONG (*SCardIsValidContextPtr)(SCARDCONTEXT hContext); > +typedef LONG (*SCardSetTimeoutPtr)(SCARDCONTEXT hContext, DWORD dwTimeout); > +typedef LONG (*SCardConnectPtr)(SCARDCONTEXT hContext,LPCSTR szReader,DWORD dwShareMode, > + DWORD dwPreferredProtocols,LPSCARDHANDLE phCard, LPDWORD pdwActiveProtocol); > +typedef LONG (*SCardReconnectPtr)(SCARDHANDLE hCard,DWORD dwShareMode, > + DWORD dwPreferredProtocols,DWORD dwInitialization, LPDWORD pdwActiveProtocol); > +typedef LONG (*SCardDisconnectPtr)(SCARDHANDLE hCard, DWORD dwDisposition); > +typedef LONG (*SCardBeginTransactionPtr)(SCARDHANDLE hCard); > +typedef LONG (*SCardEndTransactionPtr)(SCARDHANDLE hCard, DWORD dwDisposition); > +typedef LONG (*SCardCancelTransactionPtr)(SCARDHANDLE hCard); > +typedef LONG (*SCardStatusPtr)(SCARDHANDLE hCard,LPSTR mszReaderNames, LPDWORD pcchReaderLen, > + LPDWORD pdwState,LPDWORD pdwProtocol,BYTE* pbAtr,LPDWORD pcbAtrLen); > +typedef LONG (*SCardGetStatusChangePtr)(SCARDCONTEXT hContext,DWORD dwTimeout, > + LPSCARD_READERSTATEA rgReaderStates, DWORD cReaders); > +typedef LONG (*SCardControlPtr)(SCARDHANDLE hCard, DWORD dwControlCode, LPCVOID pbSendBuffer, > + DWORD cbSendLength,LPVOID pbRecvBuffer, DWORD cbRecvLength, LPDWORD lpBytesReturned); > +typedef LONG (*SCardTransmitPtr)(SCARDHANDLE hCard,LPCSCARD_IO_REQUEST pioSendPci, > + const BYTE* pbSendBuffer, DWORD cbSendLength, > + LPSCARD_IO_REQUEST pioRecvPci, BYTE* pbRecvBuffer, LPDWORD pcbRecvLength); > +typedef LONG (*SCardListReaderGroupsPtr)(SCARDCONTEXT hContext,LPSTR mszGroups, LPDWORD pcchGroups); > +typedef LONG (*SCardListReadersPtr)(SCARDCONTEXT hContext,LPCSTR mszGroups, > + LPSTR mszReaders, LPDWORD pcchReaders); > +typedef LONG (*SCardCancelPtr)(SCARDCONTEXT hContext); > +typedef LONG (*SCardGetAttribPtr)(SCARDHANDLE hCard, DWORD dwAttrId,BYTE* pbAttr, LPDWORD pcbAttrLen); > +typedef LONG (*SCardSetAttribPtr)(SCARDHANDLE hCard, DWORD dwAttrId,const BYTE* pbAttr, DWORD cbAttrLen); I don't think the pcsc-lite library is guaranteed to be binary compatible with the Windows definitions. You'll need to include the correct headers and convert data types between Windows and Unix definitions. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: FWD: Updated/add many Chinese simplified resource
by Detlef Riekenberg 24 May '07

24 May '07

On Mi, 2007-05-23 at 02:17 +0800, Lobster DB wrote: > may i can't mailto: wine-patches(a)winehq.org It was automatic filtered for manual review, because the Mail/Attachment is to large. To get the Patches in the Tree, they must be much smaller! > change all *Zh.rc which is Chinese simplified resource to *Cn.rc > keep some *Zh.rc which is Chinese traditional > user32: user32_Zh.rc slipted for Chinese simplified (user32_Cn.rc) and > Chinese traditional (user32_Zh.rc) > comctl32: update Chinese simplified resource > comdlg32: update Chinese simplified resource > notepad: update Chinese simplified resource > progman: update Chinese simplified resource > user32: update Chinese simplified resource > winefile: update Chinese simplified resource > winhelp: update Chinese simplified resource > credui: add add Chinese simplified resource > clock: add Chinese simplified resource > regedit: add Chinese simplified resource > uninstaller: add Chinese simplified resource > winecfg: add Chinese simplified resource > winemine: add Chinese simplified resource A Changelog, that does not fit in the Subject is the main Hint, that the Patch needs to be split. I Suggest one Patch per DLL. When you need to rename a File, please do not update more than very, very few Tanslations in that Patch. The best way is to send a seperate Patch for the rename. As an Example for multiple Language-Versions in one File, you can read "Pt.rc" for winmine. After a short Talk with Alexandre, we think, that both versions (Traditional and Simplified) can go in a single File. About the encoding (from Alexandre): utf-8 is better, but that really depends on what's most convenient for you. Another Hint: Try the easy translations (Single Chinese Translation) first; wait with the difficult translations, until the easy Patches are in the tree. Thanks for your Help. -- By by ... Detlef

3 3

re: winscard: add pcsc-lite helpers for upcoming implementation
by Dan Kegel 24 May '07

24 May '07

James wrote: > This would be a lot cleaner as: > > if (!(liteSCardEstablishContext = (SCardEstablishContextPtr) > wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr))) > { > ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); > goto error; > } I think in C you can skip the cast from void *, can't you? e.g. liteSCardEstablishContext = wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr)); if (!liteSCardEstablishContext) { ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); goto error; } -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: winscard: add pcsc-lite helpers for upcoming implementation
by Juan Lang 24 May '07

24 May '07

+BOOL InitializePCSCLite(void) You don't use the return value: @@ -42,9 +43,11 @@ BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { DisableThreadLibraryCalls(hinstDLL); WINSCARD_hModule = hinstDLL; + InitializePCSCLite(); break; } I suspect it's safer not to fail loading winscard if PCSC-Lite isn't available. Instead, the functions such as SCardListCards should probably return empty lists. But knowing to do so relies on knowing that PCSC-Lite couldn't be initialized, so the return value shouldn't be thrown away. Or, remove the return value, and have every function check the function pointers it needs. --Juan ____________________________________________________________________________________Sick sense of humor? Visit Yahoo! TV's Comedy with an Edge to see what's on, when. http://tv.yahoo.com/collections/222

2 1

Re: help: test subprogram can't be console app
by Misha Koshelev 24 May '07

24 May '07

Ok, never mind. I found a way to fool the Windows shell into allowing me to actually execute the appropriate console app while at the same time picking up the DDE string in a separate server (fail connection when it tries to connect first time in the DDE server in the process calling ShellExecute, then succeed the next time after it has launched the app, thus getting both the command line params and the DDE string; yay) Misha

1 0

Re: winscard: add pcsc-lite helpers for upcoming implementation
by James Hawkins 24 May '07

24 May '07

On 5/23/07, Mounir IDRASSI <mounir.idrassi(a)idrix.fr> wrote: > Hi, > This patch adds helper variables and functions that exposes pcsc-lite > functionalities for the use of the upcoming implementation. > + /* loading entry points*/ + bSuccess = TRUE; + if (bSuccess && + !(liteSCardEstablishContext = (SCardEstablishContextPtr) wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr)))) + { + bSuccess = FALSE; + ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); + } This would be a lot cleaner as: if (!(liteSCardEstablishContext = (SCardEstablishContextPtr) wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr))) { ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); goto error; } .... return TRUE; error: wine_dlclose(g_pcscliteHandle,NULL,0); g_pcscliteHandle = NULL; return FALSE; } -- James Hawkins

1 0

help: test subprogram can't be console app
by Misha Koshelev 24 May '07

24 May '07

Hi all, So I have run into a weird problem. I was writing a conformance test for ShellExecute logic of when to use DDE and a little about how it uses it, as currently the logic is incorrect and fails for some apps, e.g., Vector NTI (the fix is pretty easy, but I'd like to make a nice conformance test to go with it). Anyhow, shlexec.c conformance tests in shell32 have a nice framework where the test program itself is associated with an extension, and I just extended that to also allow a DDE execute and save the results. It didn't seem to work (FILENOTFOUND error) except when the program was already running, and then it worked fine. Just to see what was going on, I made a very simple program (attached) and used the following simple compile script to make 2 versions, one a console program and one a regular windows program (with the -mwindows switch). The -mwindows one allows DDE-based ShellExecute (or just "start" command) opening just fine, whereas withotu -mwindows the shell complains right away that the file trying to be started is not found. So it looks like I need to somehow start a non-console test program from within a test, any ideas on this? Thanks Misha --- Script: i386-mingw32-gcc -o console.exe -lshell32 -lole32 -loleaut32 -lshlwapi -luser32 -lgdi32 -ladvapi32 -lkernel32 -luuid -I. -I../../../include console.c i386-mingw32-gcc -o gui.exe -lshell32 -lole32 -loleaut32 -lshlwapi -luser32 -lgdi32 -ladvapi32 -lkernel32 -luuid -I. -I../../../include console.c -mwindows

1 0

Hello all
by Matthew Larsen 24 May '07

24 May '07

Hello all, I just joined up to the mailing list so thought I would say hello to everyone :-) I am a student studying Computer Science at Manchester University (UK) and am interested in helping the development of Wine. I decided the first step was to hop on the mailing lists and see whats going on! I have experience in writing basic Operating Systems (In ARM Assembler, as well as making ARM's work with FPGA's if your interested) and knowledge of fundamental OS functions so I hope they will come in useful at some stage. Also got a good grasp of C/C++, UNIX and Windows / Windows Server. My motivation with joining Wine was primarily to one-day get Counterstrike:Source working properly. Secondary is the fact I am fed-up completely with Windows but unfortunately have apps that are not supported in Linux / Unix and would like to get them ported onto Wine. Hope to get talking with you all soon, Regards, -- Matthew G Larsen > mat.larsen(a)gmail.com > +44(0)7739 785 249

2 1

tests: show summary and last executed test in case of a crash
by Peter Oberndorfer 23 May '07

23 May '07

Some tests on http://test.winehq.org/data/ seem to crash silently. This patch might be useful for debugging such crashes. It prints out the last ok/trace that was executed before the crash, the exception address and the type of the crash. It also print out the summary that is normally printed at the end of the test instead of exiting silently[1]. On wine it still executes winedbg for better debugging after dumping out the info. My concern now is that it requires a change to the parser which accepts the test reports, so those crashes are not lost. And don't know much about this parser. Suggestions, ideas anyone? Greetings Peter [1] example output: file.c:1228:FileSize: 0 file.c:1229:Unknown2[0]: 0 Test crashed at B7D0DF47 with error c0000005 Last test before crash: file.c:1239 file: 19 tests executed (0 marked as todo, 3 failures), 0 skipped. wine: Unhandled page fault on write access to 0x00001234 at address 0xb7d0df47 (thread 0009), starting debugger... Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b ...

2 2

Re: Bugzilla outcome?
by Robert Shearman 23 May '07

23 May '07

Tom Spear wrote: > Just curious to see if anything was ever done with the offer to > upgrade bugzilla? > > On a side note, it would be nice if there was a crash keyword to make > finding crashes easier Searching for "Unhandled exception" is too hard? -- Rob Shearman

5 8

Re: crypt32: implement CryptSIPLoad (resend)
by Alexandre Julliard 23 May '07

23 May '07

Juan Lang <juan_lang(a)yahoo.com> writes: > Hi, any problems with this one? It's causing test failures: ../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok rsaenh.c:64: Test failed: 0, 00000057 rsaenh.c:68: Test failed: 00000057 make: *** [rsaenh.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 3

RE: Application deletion!
by EA Durbin 23 May '07

23 May '07

Someone using Molle Bestefich's account has been attacking the AppDB. I've lost my AppDB admin privileges as well as a bunch of things are being deleted. >From: James Bond <tehstealth(a)yahoo.com> >To: appdb(a)winehq.org >Subject: Application deletion! >Date: Wed, 23 May 2007 04:40:49 -0700 (PDT) > >I'm sorry, I do not know who to contact for this, but the 2 apps I've been >maintaining Soldat, and Battlefield 2 have BOTH been completely deleted! >At first it was Soldat, and I thought maybe since it was a small game made >by a lone developer, it was removed. I e-mailed the person resposnible, toa >ask why. But I just got another mass spam of e-mails this morning saying >this and that were deleted from Battlefield 2, a very popular game! I think >something is wrong. Molle Bestefich (molle.bestefich(a)gmail.com) is the one >whose deleted all of that stuff. What is going on? > >-Brian > > > >____________________________________________________________________________________Ready >for the edge of your seat? >Check out tonight's top picks on Yahoo! TV. >http://tv.yahoo.com/ _________________________________________________________________ More photos, more messages, more storageget 2GB with Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

2 1

Re: RegDeleteTree [8]
by Alexandre Julliard 23 May '07

23 May '07

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + /* Recursively delete all the subkeys */ > + for (i = 0; i < dwKeyCount; i++) { > + dwSize = dwMaxLen; > + ret = RegEnumKeyExW(hSubKey, 0, lpszName, &dwSize, NULL, > + NULL, NULL, NULL); There's no reason to use the key count, you should enum until you get an error, it's more reliable. > + for (i = 0; i < dwValCount; i++) { > + dwSize = dwMaxLen; > + ret = RegEnumValueW(hKey, 0, lpszName, &dwSize, NULL, NULL, NULL, NULL); Same here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] DDraw: Hold the dll lock in IDirectDrawSurfaceX methods
by Alexandre Julliard 23 May '07

23 May '07

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > @@ -810,8 +841,12 @@ IDirectDrawSurfaceImpl_AddAttachedSurface(IDirectDrawSurfaceImpl *This, > { > TRACE("(%p)->(%p)\n", This, Surf); > > + EnterCriticalSection(&ddraw_cs); > if(Surf == This) > + { > + LeaveCriticalSection(&ddraw_cs); > return DDERR_CANNOTATTACHSURFACE; /* unchecked */ > + } Parameter checks can be done outside the section, it simplifies the code. There are many more such cases in the patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] check return code of ICreateDevEnum_CreateClassEnumerator
by Alexandre Julliard 23 May '07

23 May '07

Marcus Meissner <marcus(a)jet.franken.de> writes: > diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c > index 6adce61..841b130 100644 > --- a/dlls/quartz/filtermapper.c > +++ b/dlls/quartz/filtermapper.c > @@ -966,6 +966,9 @@ static HRESULT WINAPI FilterMapper2_Enum > if (SUCCEEDED(hr)) > hr = ICreateDevEnum_CreateClassEnumerator(pCreateDevEnum, &CLSID_ActiveMovieCategories, &pEnumCat, 0); > > + if (!SUCCEEDED(hr)) > + return hr; You are potentially leaking an object here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] basetsd.h: Fix a typo in the parameter name
by Marcus Meissner 23 May '07

23 May '07

On Wed, May 23, 2007 at 04:35:33PM +0900, Dmitry Timoshkov wrote: > Hello, > > Changelog: > basetsd.h: Fix a typo in the parameter name. > > --- > include/basetsd.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index e0d04f6..fe3639f 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -219,7 +219,7 @@ typedef unsigned short UHALF_PTR, *PUHALF_PTR; > #define HandleToULong(h) ((ULONG)(ULONG_PTR)(h)) > #define HandleToLong(h) ((LONG)(LONG_PTR)(h)) > #define ULongToHandle(ul) ((HANDLE)(ULONG_PTR)(ul)) > -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) > +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I do not think this is right. Ciao, Marcus

2 1

[1/5] basetsd.h: Fix a typo in the parameter name
by Vijay Kiran Kamuju 23 May '07

23 May '07

Hi I think this patch is not correct. -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I dont see 'l' defined or sent to this macro any where. Thanks, VJ

3 2

APPDB ROGE USER
by Vitaliy Margolen 23 May '07

23 May '07

ANYONE WITH appdb admin rights check into IRC!!!

1 0

Re: winscard: small stub implementation of winscard dll (Try 2)
by Mounir IDRASSI 22 May '07

22 May '07

Hi Alexandre, You are completely right...these variables are definitely useless!! I don't remember when I coded that but it must have been very late at night! Anyway, I'll purge them from the patch. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Alexandre Julliard wrote: > Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: >> Thank you for your comments Alexandre. >> Concerning the SCARD_PCI_xxx , I implemented them as variables instead >> of defines because it's impossible using winelib to link against the >> exported variables g_rgSCardXXX (please see my discussion with Eric >> Pouech about that). Well, I should create variables with other names to >> achieve the same goal. >> > Linking against SCARD_PCI_xxx would be just as impossible, so I still > don't understand why you need any extra variables. Could you give an > example? >

1 0

Re: RegDeleteTree [7] [resend]
by Laurent Vromman 22 May '07

22 May '07

There is a few tabs in the file : Here (line 92), first blank character : + &dwValCount, NULL, NULL, NULL, NULL); Here (line 103) + } Laurent > Hello, > > any comment on the current version of this patch? > > ChangeLog > ------------- > added implementation of RegDeleteTreeA/W > >

2 2

Re: Bugzilla outcome?
by Tom Spear 22 May '07

22 May '07

I sent this to the wrong list before, sorry for that.. Just curious to see if anything was ever done with the offer to upgrade bugzilla? On a side note, it would be nice if there was a crash keyword to make finding crashes easier -- Thanks Tom

1 0

Re: winscard: small stub implementation of winscard dll (Try 2)
by Alexandre Julliard 22 May '07

22 May '07

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > +BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("%p,%x,%p\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) > + { > + case DLL_PROCESS_ATTACH: > + { > + DisableThreadLibraryCalls(hinstDLL); > + WINSCARD_hModule = hinstDLL; > + /* initialize protocol requests pointers */ > + SCARD_PCI_T0 = &g_rgSCardT0Pci; > + SCARD_PCI_T1 = &g_rgSCardT1Pci; > + SCARD_PCI_RAW = &g_rgSCardRawPci; AFAICT these are supposed to be macros, not variables. Also your indentation is messed up. -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel May 2007