wine-devel August 2007

wine-devel@winehq.org

121 participants
249 discussions

Re: WineD3D: fix a null pointer dereference
by Stefan Dösinger 21 Aug '07

21 Aug '07

Am Dienstag, 21. August 2007 16:55 schrieb Roderick Colenbrander: > Hi, > > This patch gets Tiberian Sun working in ddraw OpenGL mode. Before it > suffered > > >from a null pointer dereference bug. This patch is ok with me, but there's a bad flaw with opengl'ed ddraw I want to point out Ddraw apps can just create offscreen surfaces and perform blits between them without creating a render target. To do anything in opengl, a context is needed, and a context needs a drawable. So no gl context without a render target in gl. Now the current code checks if the locked surface is a render target, and crashes because the render target array doesn't exist. This patch simply fixes this NULL pointer dereference. The essential problem remains though, that ddraw operations in gl won't work unless the app creates a render target. Currently it works because only operations on render targets use opengl, but there is code to have opengl do offscreen<->offscreen blits. That code(stretch_rect_fbo) is only used for d3d9, but when activated for ddraw apps too, we have to be careful.

1 0

Re: dinput: Fix compile with old input.h that missing input_absinfo
by Dmitry Timoshkov 21 Aug '07

21 Aug '07

"Vitaliy Margolen" <wine-patches(a)kievinfo.com> wrote: > +struct wine_input_absinfo { > + LONG value; > + LONG minimum; > + LONG maximum; > + LONG fuzz; > + LONG flat; > +}; If it's a kernel structure, it's better IMO to use the types that are actually used in the native structure instead of LONG. -- Dmitry.

1 0

Re: How to Calling PE Dlls on linux??
by Damjan Jovanovic 21 Aug '07

21 Aug '07

On 8/21/07, trulyliu <trulyliu(a)gmail.com> wrote: > Can I made Arithmetic.dll.so ? And link it against my linux App? A library function runs in the context of the process that invokes it. A library doesn't have its own TEB/memory layout/exception handling that works independently of the process that calls it, no matter how it is compiled. If the wine plugin API is ever made, it will modify the process so it has what the library expects when the library functions are called. Does your Arithmetic.dll.so call any Windows functions? If so, you need wine and you will always need wine, plugin API or no plugin API, whether you compile it into a DLL or .dll.so. But if you only use ANCI C stuff you can compile it into a .so and use it without wine. If you want something that runs seamlessly on every operating system today, IMHO you should consider Java. > 2007/8/21, Damjan Jovanovic <damjan.jov(a)gmail.com >: > > On 8/21/07, trulyliu <trulyliu(a)gmail.com > wrote: > > > > > I have tried these code, It works well. Thanks a lot. > > > Could I use gcc/g++ instead of winegcc/wineg++ ??? > > > mplayer use gcc as it's complier？ What's the mystery in it? > > > > > > > gcc/g++ would give you the wrong ABI (eg. 4 bytes per wide char > > instead of 2 bytes), and the special code needed to set up the Windows > > memory layout and the thread extension block and structured exception > > handling wouldn't get executed, leading to segfaults when you call any > > code that tries to access them. That's assuming you can even compile > > and link. > > > > That's why you need winegcc/wineg++. > > > > > trulyliu(a)gmail.com > > > > Damjan > > > > > > > > > > -- > trulyliu(a)gmail.com > Damjan

2 2

Re: [2/5] WineD3D: Use 0/0/0 as normal if no normal is supplied
by H. Verbeet 21 Aug '07

21 Aug '07

I'm not sure about this one. Unless explicitly checked for, (0, 0, 0) will cause a division by zero when trying to normalize it, and I don't know for sure if GL has well defined behaviour for it.

2 1

Re: [5/5] WineD3D: Fix fogstart == fogend with table fog
by H. Verbeet 21 Aug '07

21 Aug '07

On 21/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Feel free to suggest a better way to increase the fogend. My way works, but it > is not the nicest way. > Does this really matter? To me, this looks like a rather ugly hack to get the DCT to shut up.

2 1

Re: gdi: AddFontResource needs to support a second default directory
by Alexandre Julliard 21 Aug '07

21 Aug '07

"Dan Kegel" <dank(a)kegel.com> writes: > @@ -1727,6 +1736,22 @@ INT WineEngAddFontResourceEx(LPCWSTR file, DWORD flags, PVOID pdv) > { > INT ret = AddFontFileToList(unixname, NULL, NULL, ADDFONT_FORCE_BITMAP); > HeapFree(GetProcessHeap(), 0, unixname); > + if (!ret && !strchrW(file, '\\')) { > + /* http://support.installshield.com/kb/view.asp?pcode=ALL&articleid=Q100057 > + * suggests that in older versions of Windows, AddFontResource > + * paths were relative to %WINDIR%/Fonts instead of %WINDIR%/System > + * Retry assuming that's what went wrong. > + */ This comment is misleading, fonts are in WINDIR/fonts in all Windows versions, and we never look in WINDIR/system anyway. -- Alexandre Julliard julliard(a)winehq.org

2 1

How to Calling PE Dlls on linux??
by trulyliu 21 Aug '07

21 Aug '07

hi: I am sorry to disturb you with a question about calling PE Dll on linux. This is really an old question. I found the sameness issues in mail list. http://www.winehq.org/pipermail/wine-devel/2003-December/thread.html http://www.winehq.org/pipermail/wine-devel/2005-November/thread.html#41917 http://www.winehq.org/pipermail/wine-users/2004-August/014685.html http://www.winehq.org/pipermail/wine-devel/2006-August/050619.html I have tried the ways discussed in these threads。 But it's not clear enough how to do this. So I send this mail to you for some help. I have a PE Dll named Arithmetic.dll which exports a function, it's prototype is: void sort(unsigned int*, int num) I want to call the function in my Linux App. I used winedump to generate a spec file winedump spec Arithmetic.dll This comand generated three files: Arithmetic_dll.h Arithmetic_main.c and Arithmeticspec. What's the next exactly step I should do? What's the usage of the three files? And wow could I use them? I made reference to mplayer's implementation, It's code is a little clutter， and I don't have experience on MS D-Show. Could you give me some simple sample codes ?? Best Regards. -- trulyliu(a)gmail.com

4 5

Re: [patch] Garbage code in text string display
by Guan Xin 21 Aug '07

21 Aug '07

Q: Can you give a simple example of such a program (preferably downloadable)? A: Yes. If you have Simplified Chinese environment, you can try: http://update.cz88.net/soft/qqwry.rar which is a freeware for IP address-to-geographical address translation. Before patching WINE, most (though not all) labels and all buttons show garbage code. None after. Q:Can you add a conformance test showing that your patch is correct? A: I have tried editplus, acdsee, and gvim in en_US and zh_CN.GBK locale/encodings. They all ran well. I also tried the German version of winrar in de locale, no problem either. I don't think we need to prove this patch is correct because it is certainly wrong and introduced a bug. However, `any sufficiently advanced bug becomes a feature'. In the source code of Microsoft Windows NT/2k/XP, or to be excact, in the file "private/windows/shell/accesory/spechars/charmap.c" they confessed there is a bug in GDI that `assumes the font's default charset is always the system default locale'. I know peeking into The source code is illegal, but I've only done this some 24 hrs after I submitted this patch. So this patch has nothing to do with my undesirable deed. Xin On 8/19/07, Dan Kegel <dank(a)kegel.com> wrote: > Xin Guan wrote: > > This patch solves the problem that many MBCS programs display garbage code > > for text strings. Because most windows programmers do not handle charsets > > properly, we have to force DEFAULT_CHARSET in here. > > Can you give a simple example of such a program (preferably downloadable)? > > Can you add a conformance test showing that your patch is correct? > - Dan >

2 4

[Winetest RFI] What do you want out of the test suite?
by Paul Vriens 21 Aug '07

21 Aug '07

Hi, I just want to get people's opinion(s) about the needs/requirements/whishes for both the conformance tests themselves (including winetest) as well as the webpages. I'll collect the information and will put it on the wiki. Cheers, Paul.

5 16

Re: [PATCH try2 2/5] wininet: Free handle structs in WININET_Release.
by Robert Shearman 21 Aug '07

21 Aug '07

Misha Koshelev wrote: > This is necessary so that we send the INTERNET_STATUS_HANDLE_CLOSING before, for example > INTERNET_STATUS_CLOSE_CONNECTION gets sent from HTTP_CloseConnection in HTTP_CloseHTTPRequestHandle. > This can be tested on native/with native wininet on wine because although we do not send > INTERNET_STATUS_CLOSE_CONNECTION correctly when the data is finished reading on wine as native > does, if we simply don't read all the data (or any data, changing the while TRUE's to while FALSE's > in the InternetReadFiel_test for example in wininet/tests/http.c) then these do in fact get sent > as a response to InternetCloseHandle like they do on wine, and INTERNET_STATUS_HANDLE_CLOSING > always gets sent afterwards (last). > It seems like it would be better to add a close_connection method to go along with destroy, instead of leaving the handle in a half-destroyed state. Either that, or to not use INTERNET_SendCallback to send the callback in this case so that you don't have to have a WININETHANDLEHEADER object still around. -- Rob Shearman

2 1

← Newer
1
...
7
8
9
10
11
12
13
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel August 2007