Oh okay, I resent a fixed patch.
Why isn't it possible to forward the functions of the other dlls to the d3dx8 ones?
Or is this just for keeping the code clean so that we don't have mixed d3dx8 and d3dx9_36 forwardings?
Looks like there's a linux platform issue interfering
with our preallocations again...?
See
https://bugs.launchpad.net/bugs/114025
---------- Forwarded message ----------
From: Kees Cook <kees(a)ubuntu.com>
Date: Jan 9, 2008 5:21 PM
Subject: [Bug 114025] Re: Problem with wine preloader: Warning: failed
to reserve range 00000000-60000000
To: dank06(a)kegel.com
This is likely related to the extra security changes added to
/etc/sysctl.conf (vm.mmap_min_addr = 65536). As a work-around, …
[View More]set this
to 0. Hopefully wine can be built in a way that it doesn't have to
reserve the lower 64k all the time.
--
Problem with wine preloader: Warning: failed to reserve range 00000000-60000000
https://bugs.launchpad.net/bugs/114025
You received this bug notification because you are a member of Ubuntu
Wine Team, which is a bug assignee.
--
Wine for Windows ISVs: http://kegel.com/wine/isv
[View Less]
A few issues:
1.
* DPMI_xalloc
- * special virtualalloc, allocates lineary monoton growing memory.
+ * special virtualalloc, allocates linear monoton growing memory.
Um... Probably should be 'linearly'.
But if you're opening the can of worms, might as well really
improve it. I suspect this would be better:
* DPMI_xalloc
- * special virtualalloc, allocates lineary monoton growing memory.
+ * Try to VirtualAlloc the len bytes just past the last block we allocated
+ * If …
[View More]that's not available, try 64K beyond; if still not available, fail.
2.
-/* Volume functions derived from Alsaplayer source */
+/* Volume functions derivated from Alsaplayer source */
What? What's wrong with "derived"? "Derivated" isn't even a word?!
3.
-# include <unistd.h>
+#include <unistd.h>
That's not a spelling fix, and you would have to fix a whole
lot of those. Best leave alone.
- Dan
--
Wine for Windows ISVs: http://kegel.com/wine/isv
[View Less]
#ifdef HAVE_UNISTD_H
-# include <unistd.h>
+#include <unistd.h>
#endif
#include <stdarg.h>
#include <stdio.h>
I think this chunk should not be applied because:
* as pointed out before, it's not a spelling fix
* it's perfectly valid to have a space there
* the indentation makes the scope of the #ifdef clearer. So removing it
makes the code less readable
--
Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/
You can have my guns …
[View More]when you pry them from my kids cold, dead hands.
[View Less]
Dmitry Timoshkov <dmitry(a)codeweavers.com> writes:
> Changelog:
> gdi32: Fix the regression caused by the scaling font metrics patch.
This breaks the tests:
../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so editor.c && touch editor.ok
editor.c:309: Test failed: 0 == 0
editor.c:317: Test failed: 0 == 0
editor.c:865: Test failed: EM_SCROLL page down didn't scroll by a small positive number of lines (r == 0x00010000)
editor.c:869: …
[View More]Test failed: EM_SCROLL page down not functioning (line 0 scrolled to line 0
editor.c:876: Test failed: EM_SCROLL page up didn't scroll by a small negative number of lines (r == 0x00010000)
editor.c:879: Test failed: EM_SCROLL page up not functioning (line 0 scrolled to line 0
editor.c:888: Test failed: EM_SCROLL line down didn't scroll by one line (r == 0x00010000)
editor.c:890: Test failed: EM_SCROLL line down didn't go down by 1 line (0 scrolled to 0)
editor.c:899: Test failed: EM_SCROLL line up didn't scroll by one line (r == 0x00010000)
editor.c:901: Test failed: EM_SCROLL line up didn't go up by 1 line (0 scrolled to 0)
editor.c:865: Test failed: EM_SCROLL page down didn't scroll by a small positive number of lines (r == 0x00010000)
editor.c:869: Test failed: EM_SCROLL page down not functioning (line 0 scrolled to line 0
editor.c:876: Test failed: EM_SCROLL page up didn't scroll by a small negative number of lines (r == 0x00010000)
editor.c:879: Test failed: EM_SCROLL page up not functioning (line 0 scrolled to line 0
editor.c:888: Test failed: EM_SCROLL line down didn't scroll by one line (r == 0x00010000)
editor.c:890: Test failed: EM_SCROLL line down didn't go down by 1 line (0 scrolled to 0)
editor.c:899: Test failed: EM_SCROLL line up didn't scroll by one line (r == 0x00010000)
editor.c:901: Test failed: EM_SCROLL line up didn't go up by 1 line (0 scrolled to 0)
make[2]: *** [editor.ok] Error 18
--
Alexandre Julliard
julliard(a)winehq.org
[View Less]