wine-devel January 2008

wine-devel@winehq.org

126 participants
290 discussions

What is the commit status of my test fixes?
by Reece Dunn 24 Jan '08

24 Jan '08

Hi, what is the status of my recent patches sent to the wine-patches list: ‎user32: make the class tests pass on Vista. [0001-user32-make-the-class-tests-pass-on-Vista.patch] 23 Jan user32: make the clipboard tests pass on Vista. [0001-user32-make-the-clipboard-tests-pass-on-Vista.patch] 23 Jan ‎user32: make the listbox tests pass in directories other than dlls/user32/tests. [0001-user32-make-the-listbox-tests-pass-in-directories-o.patch] 00:54 ‎gdi32: Vista returns UNICODE_NOCHAR if a character does not exist. [0001-gdi32-Vista-returns-UNICODE_NOCHAR-if-a-character-d.patch] 09:01 These have not been applied, although the others beyond them have (all the changes are independant of each other, except for the gitignore changes where the devenum.h one should be ignored). wine-dev ‎gitignore: ignore files generated by the Visual C++ compiler. [0001-gitignore-ignore-files-generated-by-the-Visual-C.patch] 09:08 I know that this is causing a bit of discussion at the moment. wine-dev ‎user32: make the edit tests pass on Vista. [0001-user32-make-the-edit-tests-pass-on-Vista.patch] 00:03 This one needs updating, so I'll repost it later today with the update. wine-dev ‎gitignore: added the missing include/devenum.h generated file. [0001-gitignore-added-the-missing-include-devenum.h-gener.patch] 23 Jan This one I have said is wrong, so this one can be ignored. - Reece

1 0

wpkg.org, taskkill, reg
by Dan Kegel 24 Jan '08

24 Jan '08

I just noticed http://wpkg.org, which has a big library of silent install scripts for many windows apps. Groovy! But the first one I looked at, http://wpkg.org/Picasa, requires the taskkill and reg utilities (part of Windows XP Professional), e.g. taskkill /F /IM "Picasa2.exe" reg delete "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run" /v "Picasa Media Detector" /f' It ought to be easy to whip those up. Any takers? - Dan

1 0

Basis to accept someone as a maintainer
by Vitaliy Margolen 24 Jan '08

24 Jan '08

Recently I've noticed number of random people being accepted as maintainers of few apps I'm being a super-maintainer for. First, can the appDB send notifications that some one became a maintainer? Second, what are the basis that appDB admins accept some one as one? I've tried to search for a single message, test results, anything from the people in question and found none. Should we just make everyone a maintainer? If not, then could anyone spellout why we have some random people there? Vitaliy.

3 2

Re: user32: make the edit tests pass on Vista.
by Paul Vriens 24 Jan '08

24 Jan '08

Reece Dunn wrote: > The EM_CHARFROMPOS calls return different results on Vista. This patch > adds the values returned by Vista as expected results. > > - Reece > > > ------------------------------------------------------------------------ > > If you change the test for multiple correct answers, the corresponding text should reflect that as well (it now only say 'expected 0'). -- Cheers, Paul.

1 0

Re: shell32: Support getting the shell folder path for users other than the current user and the default user [resend]
by Alexandre Julliard 24 Jan '08

24 Jan '08

"Ge van Geldorp" <ge(a)thinstall.com> writes: > +static PSID _GetUserFromToken(HANDLE Token) > +{ > + char InfoBuffer[64]; > + PTOKEN_USER UserInfo; > + DWORD InfoSize; > + PSID Sid; > + DWORD SidSize; > + > + UserInfo = (PTOKEN_USER) InfoBuffer; > + if (! GetTokenInformation(Token, TokenUser, InfoBuffer, sizeof(InfoBuffer), > + &InfoSize)) > + { > + if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) > + return NULL; > + UserInfo = HeapAlloc(GetProcessHeap(), 0, InfoSize); > + if (UserInfo == NULL) > + return NULL; > + if (! GetTokenInformation(Token, TokenUser, UserInfo, InfoSize, > + &InfoSize)) > + { > + HeapFree(GetProcessHeap(), 0, UserInfo); > + return NULL; > + } > + } > + > + SidSize = GetLengthSid(UserInfo->User.Sid); > + Sid = HeapAlloc(GetProcessHeap(), 0, SidSize); > + if (Sid == NULL) > + { > + if (UserInfo != (PTOKEN_USER) InfoBuffer) > + HeapFree(GetProcessHeap(), 0, UserInfo); > + return NULL; > + } > + > + if (! CopySid(SidSize, Sid, UserInfo->User.Sid)) > + { > + HeapFree(GetProcessHeap(), 0, Sid); > + Sid = NULL; > + } You should return a string directly, there's no reason to make a copy of the SID. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: PATCH - makedep, open in binary mode, move the end of file marker
by Alexandre Julliard 24 Jan '08

24 Jan '08

"Steven Edwards" <winehacker(a)gmail.com> writes: > As Julliard did not comment on this, I am assuming either it hit is > garbage filter because it was bad or because it was diffed from cvs. > Resending to hit the garbage filter for bad hacks...As discussed on > wine-devel, if its still not accepted then when I have some time I'll > look to seeing what needs to be done to teach MSYS about using windows > style line endings when doing checkouts with msys and cvs. Makefiles are text files, so they should be opened in text mode. If the mixed endings are confusing MSYS you could change makedep to rewrite the whole file instead of just appending. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: try work around a crash
by Marcus Meissner 24 Jan '08

24 Jan '08

On Thu, Jan 24, 2008 at 09:00:32AM +0000, Louis. Lenders wrote: > > Hi, basically this is a resend of a patch i sent very long time ago ( http://www.winehq.org/pipermail/wine-patches/2007-April/037733.html ) > > It's a fix for bug http://bugs.winehq.org/show_bug.cgi?id=7380#c29 > > As explained in comment http://bugs.winehq.org/show_bug.cgi?id=7380#c29 > the cause of these crashes is some buggy mfc-function > , and as windows is able to work around this, wine should do the same. > > I've put the exception handler only around X11DRV_DIB_SetImageBits_24 , as that's where all the applications crash; if we want to mimic windows behaviour it should be put around all cases i guess, but i'm not sure we want to that and maybe hide other bugs. > > If this patch is rejected could you please comment why, to help fix the bug in a better way Remembering a different bug with the same issue I think you should not wrap DIB_SetImageBits_24 but just check descr->bits in X11DRV_DIB_SetImageBits() Something along the lines of: unsigned long off; unsigned char volatile x; __TRY { for (off=0;off<descr->sizeImage;off+=PAGE_SIZE) { x += ((unsigned char*)descr->bits)[off] } } ... Ciao, Marcus

1 1

Re: user32: Test destroying the cursor of a parent process.
by Dmitry Timoshkov 24 Jan '08

24 Jan '08

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: >I made some changes from the last time I talked to AJ - mainly exit code > stuff. > > changelog: user32: Test destroying the cursor of a parent process. Also there was a complaint that ok() call ersults in the child process are not included in the final statistics. There were no changes in that area in the patch. -- Dmitry.

1 0

Re: gitignore: added the missing include/devenum.h generated file.
by Reece Dunn 24 Jan '08

24 Jan '08

On 23/01/2008, Reece Dunn <msclrhd(a)googlemail.com> wrote: > The include/devenum.idl file does not have an entry in .gitignore to > prevent the generated file include/devenum.h from being included. This > patch fixes this issue. Please ignore this patch. - Reece

1 0

Re: credui: Full russian translation
by Kirill K. Smirnov 24 Jan '08

24 Jan '08

Hi, > + IDS_INCORRECTPASSWORDTITLE "Вход успешно произведён" The translation has opposite meaning than original. >+ IDS_INCORRECTPASSWORD "Убедитесь, что имя пользоватея\nи пароль верны." Typo in word "пользоватея" -- Kirill

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2008