wine-devel November 2008

wine-devel@winehq.org

110 participants
239 discussions

Regarding ./configure file
by shanmukha sainath addepalli 22 Nov '08

22 Nov '08

Sir/Madam, I need to add few functions related to libwnck. It requires some header files to be included. I included them in wine source code. But when compiled it says header files not found. I haven't updated configure file. How can i update it? please tell me what r the changes that i need to made? Regards, Sainath.

7 6

LPD3DXMESH
by Krzysztof Drewniak 22 Nov '08

22 Nov '08

What header is LPD3DXMESH supposed to be declared in? Krzys D.

5 4

[RFC/RFH] winmm:wave hang fix question (commit 717df5b2972b3cb998ca5a43279ae2283b117eaa) [bug 15559]
by Reece Dunn 21 Nov '08

21 Nov '08

Hi, Looking at the history of that test (http://test.winehq.org/data/tests/winmm:wave.html) I see a lot of timeout errors on the Wine builds, even after this fix went in. The fix itself has caused a regression of playback in many applications and games that play audio (http://bugs.winehq.org/show_bug.cgi?id=15559). I want to submit the following patch to revert the part of the patch that caused the regression and fix some of the tracing. I have been using this patch on Cepstral SwiftTalker without issue and have tested it also with the game Azguard Defense. I am submitting this here and not to wine-patches initially, as I would like to understand what the fix was actually fixing and (based on the test history still showing timeouts) whether it actually fixes the issue it was trying to. diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 6cb2da8..b3f52aa 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -103,14 +103,19 @@ static BOOL wodUpdatePlayedTotal(WINE_WAVEDEV* wwo, snd_pcm_status_t* ps) state = snd_pcm_state(wwo->pcm); snd_pcm_delay(wwo->pcm, &delay); + if (state != SND_PCM_STATE_RUNNING && state != SND_PCM_STATE_PREPARED) + { + WARN("Unexpected state (%d) while updating Total Played, resetting\n", state); + delay=0; + } + /* A delay < 0 indicates an underrun; for our purposes that's 0. */ if (delay < 0) { - WARN("Unexpected state (%d) or delay (%ld) while updating Total Played, resetting\n", state, delay); + WARN("Unexpected delay (%ld) while updating Total Played, resetting\n", delay); delay=0; } - if (state == SND_PCM_STATE_XRUN) - snd_pcm_start(wwo->pcm); + InterlockedExchange((LONG*)&wwo->dwPlayedTotal, wwo->dwWrittenTotal - snd_pcm_frames_to_bytes(wwo->pcm, delay)); return TRUE; } - Reece

2 2

Re: urlmon #6: Added more policy tests.
by Paul Vriens 21 Nov '08

21 Nov '08

Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 78 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 77 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Jacek, I'm checking out a test failure on a fresh and clean W2K3 box with SP2 and IE6. Right after this (line 859): + policy = 0xdeadbeef; + hres = IInternetZoneManager_GetZoneActionPolicy(zonemgr, 3, action, (BYTE*)&policy, + sizeof(DWORD), URLZONEREG_DEFAULT); I get a popup asking if I want to add www.winehq.org to the "Trusted sites zone". If I don't add this site the test succeeds. If I add it the test fails (over and over again). I didn't change any of the default IE6 (W2K3 specific?) security settings. I do see that adding this site to that zone doesn't change the content of the checked registry key but instead a new one is created: HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ZoneMap\EscDomains\winehq.org and HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ZoneMap\EscDomains\winehq.org\www with a 'http' REG_DWORD (value = 2) underneath that last one. So how should we proceed fixing/changing this test? -- Cheers, Paul.

2 1

Re: [4/5] wined3d: Use IDL to generate wined3d_interface.h.
by Rob Shearman 21 Nov '08

21 Nov '08

2008/11/21 Henri Verbeet <hverbeet(a)codeweavers.com>: > +cpp_quote("#if 0") > +import "wined3d_types.idl"; > +import "wined3d_caps.idl"; ... > +cpp_quote("#endif") > + > +cpp_quote("#include \"wine/wined3d_types.h\"") > +cpp_quote("#include \"wine/wined3d_caps.h\"") You can't do this. It won't work in MIDL and it won't work in widl when it is fixed to put the includes for imported files at the start of the generated header file, rather than in between the statements generated from neighbouring IDL statements. You need to find another way of solving the issue you are facing. -- Rob Shearman

2 1

Re: [3/5] wined3d: Use IDL to generate wined3d_caps.h.
by Rob Shearman 21 Nov '08

21 Nov '08

2008/11/21 Henri Verbeet <hverbeet(a)codeweavers.com>: > +cpp_quote("#if 0") > +import "wined3d_types.idl"; > +cpp_quote("#endif") This won't work either, for the same reason as I mentioned for the 4/5 patch. -- Rob Shearman

1 0

re: Add wtmpnam to msvcrt.dll
by Dan Kegel 21 Nov '08

21 Nov '08

Hi Tim, welcome to Wine! > A diff (relative to wine-1.1.8/dlls/msvcrt/file.c) is attached. Whoops, you attached the undiffed file! > I did not even get as far as successfully building it to test it Ah. Such patches usually get attached to bug reports in bugzilla or sent to wine-devel. wine-patches is for tested and known working patches. > I'd be happy to do a test build (assuming I can successfully > install the dependencies) That should be easy, see http://wiki.winehq.org/Recommended_Packages > if MSVCRT_tmpname gets initialized, where does that occur? It gets initialized by tmpnam(). Presumably _wtmpnam() will need its own static buffer. Also, please be sure to write a conformance test (see http://www.winehq.org/site/docs/winedev-guide/testing ) for your change! Thanks, Dan p.s. The MSDN doc for this, FWIW, is at http://msdn.microsoft.com/en-us/library/hs3e7355(VS.80).aspx

1 0

dead stores in advapi32
by ricardo filipe 21 Nov '08

21 Nov '08

hi rob. i have some dead stores in advapi32 files that i would like to clarify. first, what do you want to do on lines 173 and 194 of cred.c? now, there are also 3 dead assignments in cred.c, lines 992, 199 and 1064. i didn't understand what you meant in your last email about my patch that removed dead code in ole32, so since this is dead code i think i can remove it, but i'm not sure anymore since you confused me. regards, ricardo _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

2 1

Disable regression tests option now available in git!
by Austin English 21 Nov '08

21 Nov '08

For those of you that don't monitor wine-commit, Alexandre committed a patch today to disable building the regression tests: http://source.winehq.org/git/wine.git/?a=commitdiff;h=35078f4b57523d4afe00d… So the manual PITA patching is no longer necessary. I've updated the Regression Testing wiki page as well. Thanks Alexandre! -- -Austin

1 0

Re: dlls/ole32: check some dead store results (llvm/clang)
by Michael Karcher 20 Nov '08

20 Nov '08

Am Donnerstag, den 20.11.2008, 18:36 +0000 schrieb ricardo filipe: | - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { | + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey) == ERROR_SUCCESS) { No. This inverts the logic of the tests. if(x) means if(x != 0). And ERROR_SUCCESS is just zero. To prevent just this possible mistake, a patch making the condition obvious was requested. Regards, Michael Karcher

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel November 2008