wine-devel July 2008

wine-devel@winehq.org

135 participants
411 discussions

Re: dpnet: #3 Add stubbed DirectPlay8Peer:Close
by Alexandre Julliard 28 Jul '08

28 Jul '08

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > + > static const IDirectPlay8PeerVtbl DirectPlay8Peer_Vtbl = > { > IDirectPlay8PeerImpl_QueryInterface, > IDirectPlay8PeerImpl_AddRef, > IDirectPlay8PeerImpl_Release, > IDirectPlay8PeerImpl_Initialize, > - IDirectPlay8PeerImpl_EnumServiceProviders > + IDirectPlay8PeerImpl_EnumServiceProviders, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + NULL, > + IDirectPlay8PeerImpl_Close Don't do that, partial vtables lead to hard to find crashes. The vtable should be completely initialized from the start with stub functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shdocvw: rudimentary implementation of CLSID_InternetShortcut
by Alexandre Julliard 28 Jul '08

28 Jul '08

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes: > +#define IMPL(class, member, pointer) ((class*) (((char*) pointer) - offsetof(class, member))) Please don't invent yet another macro for this. Use inline functions instead. > +typedef struct > +{ > + IUnknown unknown; > + IUniformResourceLocatorA uniformResourceLocatorA; > + IUniformResourceLocatorW uniformResourceLocatorW; > + IPersistFile persistFile; There's no need for an explicit IUnknown vtable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/winedos/vxd.c
by Francois Gouget 28 Jul '08

28 Jul '08

On Mon, 28 Jul 2008, Gerald Pfeifer wrote: > Seems like I'm losing the argument on the GCC side, so we'll really > need to address those six or so warnings in our codebase by adding > return statements I guess. Hopefully they won't add a check complaining that this is an unreachale statement next. Are all the other cases unreachable too? static DWORD CALLBACK timer_thread( void *arg ) { DWORD *system_time = arg; for (;;) { *system_time = GetTickCount(); Sleep( 55 ); } return 0; } -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

1 0

Re: d3dx8: patch1: Implement D3DXBoxBoundProbe
by H. Verbeet 28 Jul '08

28 Jul '08

2008/7/27 David Adam <david.adam.cnrs(a)gmail.com>: > + ortho = D3DXVec3Dot(praydirection, &normal[i]); > + if ( ortho ) > + { > + t = D3DXVec3Dot(praydirection, &normal[i]) / ortho; This doesn't make much sense, t will always be close to zero this way. > + rayposition.x = -3.0f; rayposition.y = 1.0f; rayposition.z = -2.0f; > + result = D3DXBoxBoundProbe(&bottom_point, &top_point, &rayposition, &raydirection); > + ok(result == TRUE, "expected TRUE, received FALSE\n"); This succeeds because rayposition lies on one of the faces of the box. I think it would be useful to also add a test where rayposition lies outside the box but where the ray still intersects the box. In general, also note that the fact that the box is always axis-aligned means the normal is always 0 in two of the three directions. This simplifies the equations a bit.

1 1

Re: [WideChar conversion improvements - 2/5] Implement new versions ofwctomb and wcstombs
by Dmitry Timoshkov 28 Jul '08

28 Jul '08

"Colin Finck" <mail(a)colinfinck.de> wrote: > -INT CDECL MSVCRT_wctomb( char *dst, MSVCRT_wchar_t ch ) > +INT CDECL MSVCRT_wctomb(char *mbchar, MSVCRT_wchar_t wchar) What's the point of the above change? > { > - return WideCharToMultiByte( CP_ACP, 0, &ch, 1, dst, 6, NULL, NULL ); > + BOOL bUsedDefaultChar; > + char chMultiByte[MSVCRT_MB_LEN_MAX]; > + int nBytes; Please don't use ugly mixed case variable names. Same for other tests. > + > + /* At least one parameter needs to be given, the length of a null character cannot be queried (verified by tests > under WinXP SP2) */ > + if(!mbchar && !wchar) > + return 0; Please keep line length close to 80 columns limit. What are you calling a "null character" here? A NULL pointer is not a NUL character. What happens in the code below if mbchar is not NULL but wchar is? > + > + /* Use WideCharToMultiByte for doing the conversion using the codepage currently set with setlocale() */ > + nBytes = WideCharToMultiByte(MSVCRT___lc_codepage, 0, &wchar, 1, chMultiByte, MSVCRT_MB_LEN_MAX, NULL, > &bUsedDefaultChar); -- Dmitry.

3 3

Re: [5/5] WineD3D: Implement an ARB_fragmen_program fixed function pipeline
by H. Verbeet 28 Jul '08

28 Jul '08

2008/7/27 Stefan Dösinger <stefan(a)codeweavers.com>: > Unfortunately, even despite the preparations in the last patches, this patch > is still kinda huge because I have to replace all the fragment processing at > once. > This enables the replacement pretty much unconditionally... do we want that? It also might make sense to give this its own file.

2 2

Re: winhttp: tests/winhttp.c: Add test for WinHttpSendRequest
by Hans Leidekker 28 Jul '08

28 Jul '08

On Friday 25 July 2008 22:13:18 Zac Brown wrote: > +#include <wchar.h> > > #include <windef.h> > #include <winbase.h> > +#include <windows.h> You shouldn't need these. -Hans

2 1

Re: crypt32: Add test showing only file header is checked for cabinet files
by Detlef Riekenberg 27 Jul '08

27 Jul '08

On Fr, 2008-07-25 at 11:28 -0700, Juan Lang wrote: > + /* Create a file with just the .cab header 'MSCF' */ > + file = CreateFileW( CreateFileW is not supported on win9x. (returned NULL with ERROR_CALL_NOT_IMPLEMENTED) I have a Patch ready for the other use of CreateFileW in dlls/crypt32/tests/sip.c -- By by ... Detlef

1 0

Re: wined3d: universal surface convertor function for unsigned integer color formats(5th attempt)
by Philip Nilsson 27 Jul '08

27 Jul '08

On Thu, Jul 24, 2008 at 08:14:40PM +0400, Victor Eremin wrote: > Supports conversion between most of "unsigned color" argb/xrgb > surface formats (D3DFMT_A8R8G8B8, D3DFMT_A8R3G3B2, etc), and > "luminosity" color formats (D3DFMT_L8, etc), > excluding D3DFMT_A16R16G16B16, D3DFMT_A8P8, D3DFMT_P8 and D3DFMT_A1. > luminosity to argb/xrgb (and vice versa) conversions are not supported > dlls/wined3d/surface_base.c | 218 ++++++++++++++++++++++++++++++++++++++- I think it would be a better idea to put most of the functions in utils.c, as they are utilities, and may have utility in other places (for example argb_to_fmt does something similar, although I'm not sure if more format conversion is neccessary.) > +inline BYTE getMaskShift(DWORD mask){ Most functions here do not use camelCase. > +void mask_erase(DWORD dstMask, BYTE pixelSize, I'd make all functions static that have no use outside their file to get nicer warnings (function unused) and smaller binaries. I wonder how static and inline interacts... > +/* > + * Warning: this won't convert all formats > + */ The FIXMEs should be enough. > struct d3dfmt_convertor_desc convertors[] = { > - {WINED3DFMT_R32F, WINED3DFMT_R16F, convert_r32f_r16f}, > + {WINED3DFMT_R32F, WINED3DFMT_R16F, convert_r32f_r16f} > }; I think my neckbeard just caught fire! A lot of tests would be nice (although I guess most of the functionality is already tested.) I hope this is somewhat helpful.

1 0

Bizarre idea: creating our own extension to msi for cross-platform installers
by Scott Ritchie 27 Jul '08

27 Jul '08

Just a crazy thought, but... What if we created a standard for passing some sort of wine-specific metadata in an MSI file? Windows would ignore it, but application developers could use it to include some helpful Linux-specific Wine instructions like what windows version to use, a custom .desktop file, or even instructions to install into a completely independent Wine prefix. This way, a single .msi file could be a true universal installer for both Windows machines and Linux machines. Moreover, there'd be less of a need to create custom Wine packages for applications like Picassa since a lot of that functionality would be abstracted into Wine itself. Thoughts? Thanks, Scott Ritchie

4 4

← Newer
1
...
5
6
7
8
9
10
11
...
42
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2008