wine-devel October 2010

wine-devel@winehq.org

94 participants
301 discussions

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 4)
by Charles Davis 27 Oct '10

27 Oct '10

Any concerns? I've gone over this patch, and I don't see anything major. If it will make you feel any better, I just ran the tests under a WoW64 environment on Linux, and they passed. Chip

2 2

Re: [1/3] mscoree: Add tests for LoadLibraryShim.
by testbot＠testbot.winehq.org 27 Oct '10

27 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6540 Your paranoid android. === W2K3R2SESP2 (32 bit mscoree) === mscoree.c:176: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === WVISTAADM (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W2K8SE (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W7PRO (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (64 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL"

1 0

Re: [PATCH] [Server]: fix access rights for console creation (#24792)
by Alexandre Julliard 27 Oct '10

27 Oct '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > + if (access & GENERIC_READ) access |= FILE_GENERIC_READ; > + /* FIXME: we add FILE_READ_PROPERTIES access even in write-only mode. > + * As tested on Windows, this is not correct (ie GetConsoleMode() on with GENERIC_WRITE only > + * access fails). > + * But, this is currently needed as part of kernel32/console.c client side code relies on the > + * fact that it can read properties: lots of 'set' functions like WriteConsole, > + * ScrollConsoleScreenBuffer, SetConsoleCursorPosition (and many others) do call 'get' > + * functions. > + */ These should be fixed then. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] gdi32: Make AddFontToList skip adding a face into global lists if the font is not supposed to be enumerated, and return a pointer to first loaded face.
by Alexandre Julliard 27 Oct '10

27 Oct '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1207,15 +1207,17 @@ static void AddFaceToFamily(Face *face, Family *family) > > #define ADDFONT_EXTERNAL_FONT 0x01 > #define ADDFONT_FORCE_BITMAP 0x02 > -static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_size, char *fake_family, const WCHAR *target_family, DWORD flags) > +#define ADDFONT_HIDDEN 0x04 > +static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_size, > + char *fake_family, const WCHAR *target_family, DWORD flags, Face **face_to_return) The face_to_return pointer doesn't seem to be used anywhere. If it's really needed for something else it should be a separate patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: First contact
by Dan Kegel 26 Oct '10

26 Oct '10

On Tue, Oct 26, 2010 at 10:58 PM, Andréas LIVET <andreas.livet at gmail.com> wrote: > For the patch, I think I understand the concept (I never use git before and > never apply a patch), I have to selection the diff text and save it into a > file (let's say debug.patch) Copy and paste sometimes screws up patches. Better to save the patch to a file some other way. In particular, I usually use wget. For the patch you mentioned, one command to fetch the patch is wget http://repo.or.cz/w/wine/hacks.git/patch/2daf55e8eeca89d5c2bb82381151277b6f… http://marc.info/?l=wine-patches is another good place to search for uncommitted patches; that site does a good job of saving the patches as hyperlinks you can use with wget. See also http://kegel.com/academy/opensource.html and http://kegel.com/wine/qa/ for a few tips. Welcome aboard. I hope you have more than 1 hour / week, it takes a while to come up the learning curve. - Dan

1 0

Re: ddraw: Add tests for the foreground window set by SetCooperativeLevel
by Alexandre Julliard 26 Oct '10

26 Oct '10

David Adam <david.adam.cnrs(a)gmail.com> writes: > @@ -33,8 +33,9 @@ static LPDIRECTDRAW lpDD = NULL; > static LPDIRECTDRAWSURFACE lpDDSPrimary = NULL; > static LPDIRECTDRAWSURFACE lpDDSBack = NULL; > static WNDCLASS wc; > -static HWND hwnd; > +static HWND hwnd, hwnd2; > static int modes_cnt; > +static BOOL success; That boolean make much sense, especially with this name. If you want to check that you have a valid window you should test the window handle. Same with your createwindow function, it should simply return the handle. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msxml3: libxml2 error/warning callback functions (try 2)
by Alexandre Julliard 26 Oct '10

26 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > + len = vsnprintf(NULL, 0, msg, ap); > + buf = heap_alloc(len+1); > + vsnprintf(buf, len+1, msg, ap); vsnprintf can also return -1, check how this is done in other places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
by Alexandre Julliard 26 Oct '10

26 Oct '10

Aric Stewart <aric(a)codeweavers.com> writes: > + ERR("++++++++++++++++ perform byte seek ------------------\n"); You still have a ton of such debug ERRs in there. > + *buf = NULL; > + TRACE("Requesting %llu %u\n", ofs, len); Don't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] kernel32: Export recent wer functions
by Alexandre Julliard 26 Oct '10

26 Oct '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -1156,7 +1156,20 @@ > @ stdcall WaitForSingleObjectEx(long long long) > @ stdcall WaitNamedPipeA (str long) > @ stdcall WaitNamedPipeW (wstr long) > +@ stub WerGetFlags > @ stdcall WerRegisterFile(wstr long long) > +@ stub WerRegisterMemoryBlock > +@ stub WerRegisterRuntimeExceptionModule > +@ stub WerSetFlags > +@ stub WerUnregisterFile > +@ stub WerUnregisterMemoryBlock > +@ stub WerUnregisterRuntimeExceptionModule > +@ stub WerpCleanupMessageMapping > +@ stub WerpInitiateRemoteRecovery > +@ stub WerpNotifyLoadStringResource > +@ stub WerpNotifyLoadStringResourceEx > +@ stub WerpNotifyUseStringResource > +@ stub WerpStringLookup Adding stubs is not a good idea. If you have an app that calls these you need to provide a proper stub function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wer/tests: Add initial tests
by testbot＠testbot.winehq.org 26 Oct '10

26 Oct '10

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel October 2010