Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička:
> + hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw, (void **) &dd);
> + ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: 0x%08x\n", hr);
This is redundant, lpDD is already an IDirectDraw interface.
> + hr = IDirectDraw_CreateSurface(dd, &ddsd, &surf, NULL);
> + ok(SUCCEEDED(hr), "IDirectDraw_CreateSurface failed: 0x%08x\n", hr);
This test will fail before your 3/4 patch is in, so you'll have …
[View More]to use todo_wine for now, and remove in the patch that implements the correct behavior. You'll have to handle the NULL pointer that is returned in case of a failure.
[View Less]
In my automated testing I've noticed that some apps create desktop links
without asking and there's no way to avoid them. It's a similar
situation for start menu entries.
It would be nice to be able to have an entire install fully contained in
a .wine folder that could be cleanly deleted after the test is done.
This isn't currently the case.
Would it be appropriate to have a registry key or environment variable
to disable this behavior silently? Or is hacking scripts to delete
individual …
[View More]entries afterwards the right approach?
Thanks,
Scott Ritchie
[View Less]
I hate to do this but I would rather look bad as a person than taint
Wine with imperfect code.
Thus, I will please ask to hold my very own patch for the moment.
I don't honestly know that there is a better way to come up with indices
but I have some ideas, mainly looking at:
http://local.wasp.uwa.edu.au/~pbourke/miscellaneous/sphere_cylinder/http://sol.gfxile.net/sphere/index.html
Basically this would involve, rather than creating vertices & indices
like we do now, creating _all_ the …
[View More]vertices (with duplications) and then
collapsing to vertices + indices.
We would have to allocate larger structures, but this may indeed solve
the problem that Henri was referring to and make the index code cleaner.
In any case, it would also help me take my mind off teapot ;)
Thank you and hopefully you will see a better patch from me on Monday.
If not, then I don't have a better one :(
Misha
[View Less]
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3763
Your paranoid android.
=== WINEBUILD (build) ===
Patch failed
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3764
Your paranoid android.
=== WINEBUILD (build) ===
Patch failed
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3760
Your paranoid android.
=== WINEBUILD (build) ===
Patch failed
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3756
Your paranoid android.
=== W98SE (32 bit dsurface) ===
No test summary line found
=== W7PRO (32 bit dsurface) ===
dsurface.c:3424: Test failed: GetSurfaceDesc returned caps 804, expected 10004004
=== W7PROX64 (32 bit …
[View More]dsurface) ===
dsurface.c:3424: Test failed: GetSurfaceDesc returned caps 804, expected 10004004
=== W7PROX64 (64 bit dsurface) ===
dsurface.c:3424: Test failed: GetSurfaceDesc returned caps 804, expected 10004004
[View Less]
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3755
Your paranoid android.
=== W7PRO (32 bit filedlg) ===
Timeout