wine-devel August 2010

wine-devel@winehq.org

110 participants
338 discussions

Re: [3/5] msi/tests: Skip SourceDir tests on win9x.
by testbot＠testbot.winehq.org 18 Aug '10

18 Aug '10

1 0

Re: [2/5] msi/tests: Use HKEY_CURRENT_USER instead of HKEY_LOCAL_MACHINE for registry tests.
by testbot＠testbot.winehq.org 18 Aug '10

18 Aug '10

1 0

Re: [1/5] msi/tests: Fix some WoW64 test failures.
by testbot＠testbot.winehq.org 18 Aug '10

18 Aug '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4525 Your paranoid android. === W7PROX64 (32 bit package) === package.c:8329: Test failed: Expected "C:\Program Files\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\", got "C:\Program Files (x86)\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\" === W7PROX64 (64 bit package) === package.c:8366: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8377: Test failed: Expected "C:\winetest\", got "" package.c:8388: Test failed: Expected "C:\winetest\", got "" package.c:8438: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8449: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8458: Test failed: Expected "C:\", got "" package.c:8464: Test failed: Expected "C:\winetest\", got "" package.c:8485: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8494: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

kernel32/tests: GetVolumeInformationA X: succeeds iff drive's default dir is root. (try 2)
by Joerg-Cyril.Hoehle＠t-systems.com 18 Aug '10

18 Aug '10

Hi, what happened to this patch? It's still marked new. Is the discovery too surprising? (Maybe it's the wrong time to ask with AJ still on vacation) Is it not robust enough (lacking testing with network drives)? It explains bugs #20887 and #23355. It may explain intermittent failures in test.winehq/kernel/volume.ok, as success depends on where the test was launched from. >Tests pass on w95,w98,w2k,xp,7. I forgot to add "without skipping the one relevant section", i.e. when started from another drive than C: Of course I invite people here to also perform the test on native. Regards, Jörg Höhle

2 2

Re: wldap32: Fix handling of zero timeout value in ldap_search_extW.
by testbot＠testbot.winehq.org 18 Aug '10

18 Aug '10

1 0

Re: [PATCH 2/3] winex11.drv: set global key state
by Alexandre Julliard 18 Aug '10

18 Aug '10

Rafał Miłecki <zajec5(a)gmail.com> writes: > @@ -1250,6 +1250,21 @@ void X11DRV_send_keyboard_input( WORD wVk, WORD wScan, DWORD event_flags, DWORD > key_state_table[wVkStripped] = key_state_table[wVkL] | key_state_table[wVkR]; > } > > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVk; > + req->state = key_state_table[wVk]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVkStripped; > + req->state = key_state_table[wVkStripped]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + You don't want to add 2 extra server calls for every key, especially since the server already receives the necessary information through the key event. -- Alexandre Julliard julliard(a)winehq.org

3 2

re: winex11.drv: Fix uninitialised values. (valgrind) (try 2)
by Dan Kegel 17 Aug '10

17 Aug '10

That's for http://bugs.winehq.org/show_bug.cgi?id=20335 , right? Alexandre's reply to that was "It sounds like it's hashing padding bytes. Probably should be reported to the X.org folks." X is old code, and I don't think anyone has cleaned it up for valgrind yet. That's why I use suppression files like http://winezeug.googlecode.com/svn/trunk/valgrind/valgrind-suppressions which contain blanket suppressions like { bogus_X11_1 Memcheck:Param write(buf) obj:* obj:/usr/lib*/libX11.so.6.2.0 } { bogus_X11_2 Memcheck:Param write(buf) obj:* obj:* obj:/usr/lib*/libX11.so.6.2.0 }

2 1

Re: Should we expect Liberation fonts to be installed?
by Scott Ritchie 17 Aug '10

17 Aug '10

On 08/08/2010 06:56 AM, James McKenzie wrote: > Scott Ritchie wrote: >> I was looking through our fairly large collection of open font bugs and >> realized that things might be a lot simpler if we took some opinionated >> positions and just declared certain fonts to be dependencies and >> expected all packagers to provide them. >> >> This is similar to bundling our own Tahoma, except much less work. >> > This might work for Linux, but these fonts are not installed on any > MacOSX version that I'm aware of. This might break Wine useage for > Macs. It might also break it for Solaris as well. > > James McKenzie > It should only break in a way that makes it as bad as it currently is. Thanks, Scott Ritchie

4 5

Re: kernel32: add stub for SetFileValidData
by Alexandre Julliard 17 Aug '10

17 Aug '10

Austin English <austinenglish(a)gmail.com> writes: > @@ -1001,6 +1001,16 @@ error: > } > > /*********************************************************************** > + * SetFileValidData (KERNEL32.@) > + */ > +BOOL WINAPI SetFileValidData( HANDLE hFile, LONGLONG ValidDataLength ) > +{ > + FIXME("stub: %p, %llu\n", hFile, ValidDataLength); You can't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32, GetUserObjectInformation implementation with index=UOI_USER_SID (try2, resend)
by Alexandre Julliard 17 Aug '10

17 Aug '10

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > New patch after rebase. > Always checks return values. > Tested with Polar Protrainer 5, updater.exe > From dcb91595b33513f8df2cf4d439221d3143c8fac1 Mon Sep 17 00:00:00 2001 > From: Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> > Date: Sat, 24 Jul 2010 17:12:05 +0200 > Subject: GetUserObjectInformation UOI_USER_SID (try 2) This should be retrieved from the server, based on the object security token or something along those lines. -- Alexandre Julliard julliard(a)winehq.org

1 0

← Newer
1
...
18
19
20
21
22
23
24
...
34
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel August 2010