June 2011 - wine-devel

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer 22 Nov '20

22 Nov '20

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong 28 Sep '18

28 Sep '18

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird 14 Jun '18

14 Jun '18

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart 16 Jun '16

16 Jun '16

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger 05 Jul '15

05 Jul '15

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa 02 Aug '14

02 Aug '14

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg 09 Oct '13

09 Oct '13

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: [patch] Support NULL puLen in VerQueryValue
by Andrew Nguyen 15 Oct '11

15 Oct '11

On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote: > I couldn't find any documentation saying that this must be supported, > but running google code search on VerQueryValue.*NULL found some uses. > > Cheers, > Rafael > > > > You should write some tests to examine the behavior of VerQueryValue with NULL puLen.

3 2

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins 24 Sep '11

24 Sep '11

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell 25 Aug '11

25 Aug '11

Dear Wine developers, I would like implement some of the missing mesh functions in Wine's D3DX9 for Google Summer of Code 2011. I would like to implement the following functions: - CloneMesh - CloneMeshFVF - ConvertPointRepsToAdjacency - ConvertAdjacencyToPointReps - GenerateAdjacency They seem to be suitable in size to implement during a summer, and I have a good idea of how to implement them. I expect to first implement tests and then implement the functions. I am a masters student at the Technical University of Denmark nearing the end of my studies, and I have specialized in 3D computer graphics, studying both real-time and physically based techniques, as well as how to use existing 3D modeling tools to create animations. The mesh functions should be fairly straight forward for me to implement as I have recently taken an advanced course on geometry processing which involved a lot of mesh manipulation. I have, furthermore, already tests (for a shell32 function) in the wine test suite so I have some knowledge of Wine development. Roderick Coldenbrander is listed as a possible mentor for "Direct3D - Implement missing D3D9_xx DLLs" on the wiki. Are you still interested, or would someone else like to be a mentor? Regards, Michael Mc Donnell

9 50

re: make "bisected" a keyword in bugzilla?
by Dan Kegel 08 Aug '11

08 Aug '11

I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday.

11 15

re: GSoC: dinput8 Action Mapping
by Dan Kegel 02 Aug '11

02 Aug '11

Lucas asked: > Should I correct the tabs and align the > parameters in the function prototype when I implement them? If you do a significant rewrite of a function, or are implementing it for the first time, I think it's ok to use more standard code style in your new code, or to update the style of adjacent old code (like a prototype) related to your change.

7 28

Need help at collecting ActionMapping data
by Lucas Zawacki 24 Jul '11

24 Jul '11

Hello everyone. As you may know I'm working on the dinput8 action mapping support and at the moment I've pretty much finished the mouse and keyboard and just need to get my patches in. For the next part, however, I'm going to need to analyze lot's of data generated by different joysticks to figure out how the mapping works. Some things are already clear for me, but I have only some simple USB joysticks here and thus would like your help to collect more useful data. If any of you has any sort of joystick (simple gamepads, driving wheels and whatnot) and would like to help, I've set up a little app that uses the DI8 action mapping API to construct a mapping for every connected joystick and outputs it to the terminal. You just need to run it, redirect the output to a file and email it back to me. Telling me which version of windows you're running would be nice. If you want to help but can't use windows, wine with native dinput8.dll is fine too. The program can be found here: https://github.com/downloads/lfzawacki/dinput-samples/devices_test.exe The code is here: https://github.com/lfzawacki/dinput-samples/blob/master/devices_test.cpp Thanks in advance Cheers

2 3

Fwd: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell 14 Jul '11

14 Jul '11

Hi Stefan sorry for the duplicate email. I forgot to also send it to wine-devel. On Fri, Jun 17, 2011 at 12:02 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Thursday 16 June 2011 10:49:19 Michael Mc Donnell wrote: >> I've added the test you outlined. It shows you're correct that >> GetDeclaration only writes up to D3DDECL_END(). I've changed the >> implementation so that it caches the number of elements and only >> writes up to D3DDECL_END(). > Looks good to me. Great! >> You're right it could potentially read undefined memory depending on >> the compiler semantics. I think the safest thing is just to read up to >> D3DDECL_END() in the passed in declaration, then it will never read >> undefined memory (except if the programmer makes a mistake). > Looks good, but please write a WARN message in every case where you return an > error to the application. We believe that we handled the error condition > correctly, so there's no need for a FIXME, but the broken app behavior may > have been triggered by some other problem in Wine, so the message is more > important than a simple TRACE. Ok I've added WARN message for every case where it returns an error to the application. I've also reworded the WARN where it uses an invalid declaration but still must return D3D_OK.

4 36

wine bug 27600
by wylda＠volny.cz 02 Jul '11

02 Jul '11

Hi Vincas, i wanted to give bug 27600 a try. So on top of wine-1.3.23-50-g2497a91 i applied patches: 1. 75818 2. 75819 3. 75831 4. 75830 5. 75829 6. 75820 7. 75821 8. 75822 9. 75823 but i end up with failure during the buildup: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-stric t-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogi cal-op -g -O0 -o input.o input.c input.c: In function ‘GetRawInputDeviceList’: input.c:495: error: ‘union generic_request’ has no member named ‘get_raw_input_device_list_request’ input.c:495: error: ‘union generic_reply’ has no member named ‘get_raw_input_device_list_reply’ Regards, W. -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz

5 24

Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX
by Jacek Caban 30 Jun '11

30 Jun '11

On 06/26/11 18:28, Detlef Riekenberg wrote: > How can we force tests to use VT_UI4? It's not JScript builtin type, you need to extend tests host object for that. > -- > By by ... Detlef > --- > dlls/jscript/tests/lang.js | 31 +++++++++++++++++++++++++++++++ > 1 files changed, 31 insertions(+), 0 deletions(-) > > diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js > index b54eef2..b96788b 100644 > --- a/dlls/jscript/tests/lang.js > +++ b/dlls/jscript/tests/lang.js > @@ -306,6 +306,37 @@ tmp = 3/2; > ok(tmp === 1.5, "3/2 !== 1.5"); > ok(getVT(tmp) === "VT_R8", "getVT(3/2) !== VT_R8"); > > +/* 0x7fffffff is 2147483647 is INT_MAX */ > +tmp = 2147483647*-1; 0x... is correct jscript syntax, why not use it? Jacek

2 2

gcc 4.6 warning report
by Jerome Leclanche 30 Jun '11

30 Jun '11

Had to check a few warnings earlier and there hasn't been a warning report in a while, thought I'd share it. It's also still impossible to configure with -Werror because of warnings in configure scripts. Wine version wine-1.3.22-203-gac90c1b ac90c1bd1878599710605fa5b4e2fe8ce224b280 Enabled packages alsa freetype gstreamer jpeg ldap openal opengl openssl png x xinerama xinput2 xml xrandr Disabled packages capi cms cups curses esd fontconfig gettextpo gnutls gphoto gsm hal jack mpg123 nas opencl oss sane tiff v4l xslt xxf86vm CFLAGS -msse4 -O3 -Wall Built on Linux azura 3.0-0-generic #1-Ubuntu SMP Thu Jun 9 16:32:10 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux J. Leclanche

5 7

Re: [PATCH 1/4] shell32: Implement erasing and restoring items from the trash
by Juan Lang 30 Jun '11

30 Jun '11

Hi Jay, +HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl){ Nit: the brace should be on its own line. +HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN; +HRESULT TRASH_EraseItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN; These two functions are never called in this patch, so you're introducing dead code. That's not allowed. Introduce the functions in the patch that uses them, please. If the resulting patch is too large, you must split it another way. --Juan

1 0

Re: dxgi.idl: Added DXGI_SWAP_CHAIN_FLAG enum declaration and DXGI_MWA_* flags
by Henri Verbeet 30 Jun '11

30 Jun '11

On 30 June 2011 17:34, Jacek Caban <jacek(a)codeweavers.com> wrote: > +cpp_quote("#define DXGI_MWA_NO_WINDOW_CHANGES 0x1") > +cpp_quote("#define DXGI_MWA_NO_ALT_ENTER 0x2") > +cpp_quote("#define DXGI_MWA_NO_PRINT_SCREEN 0x4") > +cpp_quote("#define DXGI_MWA_VALID 0x7") Aren't those usually done as constants? (I.e., "const UINT DXGI_MWA_NO_WINDOW_CHANGES = 0x1;")

2 1

Re: [PATCH 1/3] d3dx9/line: Implemented ID3DXLine's Draw method.
by Matteo Bruni 30 Jun '11

30 Jun '11

2011/6/30 Charles Welton <charleswfb(a)gmail.com>: > --- > > + memcpy(buffer_mem, vertices, size); There is no need to allocate and write into your own buffer then copy the content, you can directly write into the vertex buffer. A more important issue: MSDN says "The ID3DXLine interface implements line drawing using textured triangles", which is probably true (as far as I know there is otherwise no support in D3D9 to antialiased/stippled/wide lines, which are instead supported by ID3DXLine). So, drawing with D3DPT_LINESTRIP primitives in general is probably not the right way...

1 0

Re: [3/8] msi: Handle escaped double quotes in command line parsing.
by Marvin 30 Jun '11

30 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12111 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon) === W7PRO (32 bit install) === Timeout

1 0

RectInRegion Question
by Alistair Leslie-Hughes 30 Jun '11

30 Jun '11

Hi, When looping Region rects in function RectInRegion, we have the condition if(pCurRect->top >= rc.bottom) break; Should this break actually be a continue, like the other conditions? Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 3/3] d3dx9/tests: Implemented Draw and DrawTransform tests for ID3DXLine.
by Marvin 30 Jun '11

30 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12105 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [2/2] d3dx9_36: Implement and add tests for D3DXFloat16To32Array.
by Matteo Bruni 29 Jun '11

29 Jun '11

2011/6/29 Misha Koshelev <misha680(a)gmail.com>: > --- ... > + else return sgn * powf(2, -14.0f) * ((float)m / 1024.0f); ... > + return sgn * powf(2, (float)e - 15.0f) * (1.0f + ((float)m / 1024.0f)); I think you don't need the explicit casts here, the values should be automatically promoted to floats as the other operand is a float as well.

1 0

Bad_Pool_Header
by Keith Muir 29 Jun '11

29 Jun '11

Hi, Been trying to run wine tests from http://test.winehq.org/data/ but every time I try this for about the last half dozen versions I get a blue screen and bad pool header any suggestions? I try to support the project by doing test runs and updating the appdb. Regards, Keith

2 1

Ge (Greg) van Geldorp
by Paul Vriens 29 Jun '11

29 Jun '11

Hi, The sad news reached me two days ago that Ge (Greg) van Geldorp passed away. Please find below the mail from his brother. I've briefly talked to Jeremy and Alexandre about this loss and the idea came up to have something on the winehq frontpage for a while. Jeremey also mentioned to mark Greg's life and contributions to Wine at Wineconf this year. Alexandre mentioned potentially hosting the winetestbot at codeweavers in the future. Both the frontpage remembrance and the potential hosting somewhere else has been discussed by me and Arno and will not be an issue. Cheers, Paul. -------- Original Message -------- Subject: RE: Ge van Geldorp Date: Thu, 9 Jun 2011 23:05:46 +0200 From: Erven Gé van Geldorp <erven.van.geldorp(a)gmail.com> To: 'Paul Vriens' <paul.vriens.wine(a)gmail.com> Hi all, My name is Arno van Geldorp. I'm the brother of Gé (Greg) van Geldorp. I'm very sorry that I have to inform you that Greg has passed away almost 3 weeks ago. 2 Months earlier he was diagnosed with cancer in a very aggressive form. I know he made his contribution to the Wine project. And that one of them is the WineTestBot. His passing away went so fast that he didn't have the time to inform me all about it. What he did ask me is to make sure that the server where the WineTestBot is running on will be hosted for at least 2 more years. So we will take care of that. But I don't know if anyone took over the administration off the server. If anyone took over the administration from Greg could you please contact me at erven.van.geldorp at gmail.com Kind regards, Arno van Geldorp

9 10

Re: [1/2] include: Add declarations related to D3DXFLOAT16.
by Dylan Smith 29 Jun '11

29 Jun '11

On Wed, Jun 29, 2011 at 11:16 AM, Misha Koshelev <misha680(a)gmail.com> wrote: > Submitted by original author as requested by Alexandre. Necessary for > further patches by Dylan Smith to fix bug 25769. > Attached are the further patches he is referring to, which are based on his patch series.

1 0

Re: [1/2] oleaut32: COM Cleanup ICreateTypeLib2Imp (resend)
by Michael Stefaniuc 29 Jun '11

29 Jun '11

Hello Alistair, sorry that I missed the first time. And Alexandre should have marked it as PENDING (good idea but current implementation is rejected). Alistair Leslie-Hughes wrote: > Changelog: > oleaut32: COM Cleanup ICreateTypeLib2Imp > > > Best Regards > Alistair Leslie-Hughes > >From 4e5e70b84cc4a254e5e3bdfeb788282a20a3dd50 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Mon, 27 Jun 2011 22:24:09 +1000 > Subject: [PATCH] COM Cleanup ICreateTypeLib2Imp > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/oleaut32/typelib2.c | 75 ++++++++++++++++++++++++--------------------- > 1 files changed, 40 insertions(+), 35 deletions(-) > > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index e9c7613..5740ddd 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -1476,7 +1481,7 @@ static HRESULT ctl2_find_typeinfo_from_offset( > > for (typeinfo = This->typeinfos; typeinfo; typeinfo = typeinfo->next_typeinfo) { > if (typeinfo->typeinfo == typeinfodata) { > - *ppTinfo = (ITypeInfo *)&typeinfo->lpVtblTypeInfo2; > + *ppTinfo = (ITypeInfo *)&typeinfo->ITypeInfo2_iface.lpVtbl; Please don't cast a vtable to an iface, cast the iface instead: + *ppTinfo = (ITypeInfo *)&typeinfo->ITypeInfo2_iface > ITypeInfo2_AddRef(*ppTinfo); > return S_OK; > } > @@ -1573,7 +1578,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnQueryInterface( > *ppvObject = This; > } else if (IsEqualIID(riid, &IID_ITypeInfo) || > IsEqualIID(riid, &IID_ITypeInfo2)) { > - *ppvObject = &This->lpVtblTypeInfo2; > + *ppvObject = &This->ITypeInfo2_iface.lpVtbl; No need to go here down to the vtable: + *ppvObject = &This->ITypeInfo2_iface It's the exact same thing but shorter. > } > > if(*ppvObject) > @@ -1697,7 +1702,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetTypeFlags(ICreateTypeInfo2 *iface, U > iter->next_typeinfo = This->dual; > } > } else > - iface = (ICreateTypeInfo2*)&This->dual->lpVtbl; > + iface = (ICreateTypeInfo2*)&This->dual->ICreateTypeInfo2_iface.lpVtbl; There's no need for a cast here as you already have the right thing: + iface = &This->dual->ICreateTypeInfo2_iface; > } > > if (uTypeFlags & (TYPEFLAG_FDISPATCHABLE|TYPEFLAG_FDUAL)) { You missed a few changes: @@ -3153,7 +3158,7 @@ { ICreateTypeInfo2Impl *This = impl_from_ITypeInfo2(iface); - return ICreateTypeInfo2_QueryInterface((ICreateTypeInfo2 *)This, riid, ppv); + return ICreateTypeInfo2_QueryInterface(&This->ICreateTypeInfo2_iface, riid, ppv); } There are more of those "(ICreateTypeInfo2 *)This" ==> "&This->ICreateTypeInfo2_iface" changes. Check for all (ICreateTypeInfo2 *), there should be none left. > @@ -3388,7 +3393,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeOfImplType( > } > > if(This->typekind == TKIND_DISPATCH) > - return ITypeInfo2_GetRefTypeOfImplType((ITypeInfo2*)&This->dual->lpVtblTypeInfo2, > + return ITypeInfo2_GetRefTypeOfImplType((ITypeInfo2*)&This->dual->ITypeInfo2_iface.lpVtbl, No need for the cast: + return ITypeInfo2_GetRefTypeOfImplType(&This->dual->ITypeInfo2_iface, > index, pRefType); > } > > @@ -3599,7 +3604,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeInfo( > return E_INVALIDARG; > > if(hRefType==-2 && This->dual) { > - *ppTInfo = (ITypeInfo*)&This->dual->lpVtblTypeInfo2; > + *ppTInfo = (ITypeInfo*)&This->dual->ITypeInfo2_iface.lpVtbl; Just cast the iface: + *ppTInfo = (ITypeInfo*)&This->dual->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } > @@ -3635,7 +3640,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeInfo( > > for(iter=This->typelib->typeinfos; iter; iter=iter->next_typeinfo) { > if(This->typelib->typelib_typeinfo_offsets[i] == (hRefType&(~0x3))) { > - *ppTInfo = (ITypeInfo*)&iter->lpVtblTypeInfo2; > + *ppTInfo = (ITypeInfo*)&iter->ITypeInfo2_iface.lpVtbl; Same here: + *ppTInfo = (ITypeInfo*)&iter->ITypeInfo2_iface; > > ITypeLib_AddRef(*ppTInfo); > return S_OK; > @@ -4948,7 +4953,7 @@ static HRESULT WINAPI ITypeLib2_fnGetDocumentation( > if(!iter) > return TYPE_E_ELEMENTNOTFOUND; > > - return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->lpVtblTypeInfo2, > + return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->ITypeInfo2_iface.lpVtbl, And here: + return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->ITypeInfo2_iface, > -1, pBstrName, pBstrDocString, pdwHelpContext, pBstrHelpFile); > } > thanks bye michael

1 0

Re: [PATCH] comctl32: Fixed strncpy (Coverity)
by Michael Stefaniuc 28 Jun '11

28 Jun '11

Hello Marcus, On 06/28/2011 09:15 AM, Marcus Meissner wrote: > This is a 2 CHAR buffer, and we copy in 1 CHAR and \0. So just do that > via strcpy() and dont confuse the static checker. > > CID 1194 > > Ciao, Marcus > --- > dlls/comctl32/tests/treeview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c > index 324473d..faa9553 100644 > --- a/dlls/comctl32/tests/treeview.c > +++ b/dlls/comctl32/tests/treeview.c > @@ -1225,7 +1225,7 @@ static void test_itemedit(void) > r = TreeView_SelectItem(hTree, NULL); > expect(TRUE, r); > /* alter text */ > - strncpy(buff, "x", sizeof(buff)/sizeof(CHAR)); > + strcpy(buff, "x"); > r = SendMessage(edit, WM_SETTEXT, 0, (LPARAM)buff); What about r = SendMessage(edit, WM_SETTEXT, 0, (LPARAM)"x"); No strcpy involved. > expect(TRUE, r); > r = SendMessage(hTree, WM_COMMAND, MAKEWPARAM(0, EN_KILLFOCUS), (LPARAM)edit); bye michael

3 2

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)
by Alexandre Julliard 28 Jun '11

28 Jun '11

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > + FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, lpszUserName, dwFlags); > + > + diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions); > + _copy_diactionformatAtoW(&diafW, lpdiaf); > + > + hr = IDirectInputDevice8WImpl_SetActionMap(&This->IDirectInputDevice8W_iface, &diafW, NULL, dwFlags); > + > + _copy_diactionformatWtoA(lpdiaf, &diafW); Do you really need to copy it back? It looks like an input parameter. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3dx9/tests: Fix comparison that expects NAN, since NAN != NAN.
by Alexandre Julliard 28 Jun '11

28 Jun '11

Dylan Smith <dylan.ah.smith(a)gmail.com> writes: > @@ -4834,7 +4834,7 @@ static void test_create_skin_info(void) > for (i = 0; i < num_influences; i++) { > ok(exp_vertices[i] == vertices[i], > "influence[%d]: expected vertex %u, got %u\n", i, exp_vertices[i], vertices[i]); > - ok(exp_weights[i] == weights[i], > + ok((isnan(exp_weights[i]) && isnan(weights[i])) || exp_weights[i] == weights[i], I put this in for now to fix the tests, but isnan() isn't really portable, we should try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [2/2] gdiplus: Implement GdipMeasureDriverString.
by Alexandre Julliard 27 Jun '11

27 Jun '11

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > From 520906b62d02cb9c886404caa03d1fcb634f574b Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Mon, 27 Jun 2011 13:24:39 -0500 > Subject: [PATCH 2/3] gdiplus: Implement GdipMeasureDriverString. It doesn't work here: ../../../tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so graphics.c && touch graphics.ok graphics.c:3110: Test failed: Expected 7.00, got 8.00 make: *** [graphics.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32: return an error in SO_CONNECT_TIME stub
by Dmitry Timoshkov 27 Jun '11

27 Jun '11

Austin English <austinenglish(a)gmail.com> wrote: > @@ -2554,7 +2554,7 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > } > *(DWORD*)optval = pretendtime++; > *optlen = sizeof(DWORD); > - return ret; > + return SOCKET_ERROR; > } Filling out optval and optlen but returning SOCKET_ERROR doesn't make sense. Probably Eye-Fi doesn't change the return value. What kind of socket both of the applications do pass? -- Dmitry.

2 1

Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
by Michael Stefaniuc 27 Jun '11

27 Jun '11

Hello Alistair, Alistair Leslie-Hughes wrote: > Changelog: > oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext > > dlls/oleaut32/typelib2.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index e9c7613..459547f 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -3067,8 +3067,13 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetHelpStringContext( > ICreateTypeInfo2* iface, /* [I] The typeinfo on which to set the help string context. */ > ULONG dwHelpStringContext) /* [I] The help string context. */ > { > - FIXME("(%p,%d), stub!\n", iface, dwHelpStringContext); > - return E_OUTOFMEMORY; > + ICreateTypeInfo2Impl *This = (ICreateTypeInfo2Impl *)iface; please do not add any more of those cast but add a impl_from_ICreateTypeInfo2() helper as per the COM guidline at http://wiki.winehq.org/COMGuideline. Bonus points for doing the COM cleanup too ;) thanks bye michael

1 0

Re: [docs] winedev: A hint for patch separation
by Jerome Leclanche 27 Jun '11

27 Jun '11

That sounds like we want people to avoid testing wine. How about "Patches must not break building Wine nor its testsuite. Adding dead code should also be avoided."? </bikeshed> J. Leclanche 2011/6/26 André Hentschel <nerv(a)dawncrow.de>: > --- > en/winedev-coding.sgml | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/en/winedev-coding.sgml b/en/winedev-coding.sgml > index eacf6d8..8b0f0d9 100644 > --- a/en/winedev-coding.sgml > +++ b/en/winedev-coding.sgml > @@ -207,6 +207,10 @@ code > is your friend! > </para> > <para> > + Every patch must not break building and testing Wine and > + adding dead code should be avoided. > + </para> > + <para> > Save yourself some embarrassment and run your patched code > against more than just your current test example. Experience > will tell you how much effort to apply here. If there are > -- > > Best Regards, André Hentschel > > >

2 1

Re: [PATCH 9/9] server+user32: Added GetRawInputData implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11988 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 8/9] server+user32: Added GetRawInputBuffer implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11987 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 7/9] server+user32: Added RegisterRawInputDevices implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11986 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 6/9] server+user32: Added GetRegisteredRawInputDevices implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11985 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Vincas Miliūnas 27 Jun '11

27 Jun '11

On 06/22/2011 06:41 PM, André Hentschel wrote: > ... Done - http://source.winehq.org/patches/data/75767

1 0

Re: [PATCH 5/9] server+user32: Added GetRawInputDeviceInfoA implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11984 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 4/9] server+user32: Added GetRawInputDeviceInfoW implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11983 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 3/9] server+user32: Added GetRawInputDeviceList implementation (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11982 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/9] user32/tests: Added client-side raw input function tests (try 8)
by Marvin 27 Jun '11

27 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11981 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by André Hentschel 26 Jun '11

26 Jun '11

Am 22.06.2011 06:26, schrieb Vincas Miliūnas: > + if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData && pGetRawInputDeviceList && > + pGetRawInputDeviceInfoA && pGetRawInputDeviceInfoW && pGetRegisteredRawInputDevices && pRegisterRawInputDevices) You should avoid such a construct, move the check to test_functions that actually need these functions. e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer i didn't looked very close, but if the tests depend on each other there should be a comment. the rest of that patch looks fine to me -- Best Regards, André Hentschel

2 1

[mshtml] Crash in World of Warcrash launcher
by Vincent Pelletier 26 Jun '11

26 Jun '11

Hi. Runing the latest WoW Launcher, I get the following traceback: Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7d399990 ESP:0032e404 EBP:0032e474 EFLAGS:00010213( R- -- I -A- -C) EAX:00000001 EBX:7d3f22bc ECX:ffffffff EDX:00000000 ESI:00000000 EDI:0281f518 Stack dump: 0x0032e404: 0032e474 00000000 038f3338 0032e430 0x0032e414: 6a00410b 038f3338 00000000 0032e450 0x0032e424: 038f3368 038f3338 00000000 0032e470 0x0032e434: 0281f518 cbc0cbd8 0281f518 0032e480 0x0032e444: 6a617b40 0281f518 6ab94f64 0032e490 0x0032e454: 038f3338 0000000f 0000000e 7ef7bee5 Backtrace: =>0 0x7d399990 doc_insert_script+0x30(window=0x2738378, nsscript=(nil)) [/home/vincent/git/wine/dlls/mshtml/script.c:757] in mshtml (0x0032e474) 1 0x7d36ec96 run_insert_script+0xb5(doc=0x7d36e63e, script_iface=0x3849830, parser_iface=0x38f3368) [/home/vincent/git/wine/dlls/mshtml/mutation.c:338] in mshtml (0x03849830) 2 0x0032e550 (0x0384a9e8) 3 0x00000002 (0x7d3f0a28) 4 0x7d36e7d0 in mshtml (+0x6e7cf) (0x7d36fbc0) 5 0x00000010 (0xb94cec83) 0x7d399990 doc_insert_script+0x30 [/home/vincent/git/wine/dlls/mshtml/script.c:757] in mshtml: movl 0x0(%esi), %eax 757 nsres = nsIDOMHTMLScriptElement_GetType(nsscript, &val_str); Bisecting find this commit: dc96c688d397eb4ef1392ee6a98f3eb6b176dc56 is the first bad commit commit dc96c688d397eb4ef1392ee6a98f3eb6b176dc56 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 15 13:45:46 2011 +0100 mshtml: Notify parser about script evaluation. :040000 040000 56e26373e5d368d9c991936e12bbf6572b51a1c8 b047f9b40a63e482b477254952737e9e9cd4aded M dlls I don't know if it's a regression in wine by itself, or if WoW Launcher just happens to trigger the failure now (I haven't ran it in some months). -- Vincent Pelletier

2 1

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Vincas Miliūnas 26 Jun '11

26 Jun '11

On 06/22/2011 06:26 PM, André Hentschel wrote: > Am 22/06/2011 06:26, schrieb Vincas Miliūnas: >> + if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData && pGetRawInputDeviceList && >> + pGetRawInputDeviceInfoA && pGetRawInputDeviceInfoW && pGetRegisteredRawInputDevices && pRegisterRawInputDevices) > > You should avoid such a construct, move the check to test_functions that actually need these functions. > e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer > i didn't looked very close, but if the tests depend on each other there should be a comment. > the rest of that patch looks fine to me Done - http://source.winehq.org/patches/data/75756

2 1

Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX
by Marvin 26 Jun '11

26 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11980 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] jscript/tests: Fix copy & paste typos
by Marvin 26 Jun '11

26 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11979 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 7)
by Marvin 26 Jun '11

26 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11978 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0

Behavior of SHChangeNotify
by Jay Yang 25 Jun '11

25 Jun '11

To try to implement copy-paste for shell folders, I used SHFileOperation for the actual copy. SHFileOperation calls SHChangeNotify to notify listeners about changes to the file system. But I noticed that the shell view would not update correctly if it was at 'C:\' but it would if it was at '/home/user_name/.wine/drive_c/'. In the end I traced this to the fact that in the first case the shell view calls SHChangeNotifyRegister with a pidl of the form <Desktop|My Computer|C:> while SHFileOperation is using SHChangeNotify to send a notification to those listeners registered on pidls of the form <Desktop|/|home|user_name|.wine|drive_c>. This makes it such that the shell view doesn't always get the notifications it expects. I can think of a couple of ways to fix this. 1. Have SHChangeNotifyRegister normalize all file system pidls to ones rooted in the unixfs. 2. Have the shell view register on a unixfs pidl. I would like to know if either of these is a good solution, or if there are better solutions. I can also write a quick test to demonstrate the problem if necessary. -- Jay Yang

2 2

usability study: "30 days with Ubuntu" author had trouble with wine
by Dan Kegel 25 Jun '11

25 Jun '11

http://www.pcworld.com/businesscenter/article/231065/ubuntu_linux_day_23_wo… First problem - ubuntu's package manager is unclear: "I opened up my handy-dandy Ubuntu Software Center and typed Wine in the search field, and...WTF? There are 14 matching items that show up. Many of them are variations on 'Microsoft Windows Compatibility Layer'. One has '(meta package)' at the end, another has '(dummy package)'. They each have a little sub-title like 'wine', or 'wine-gecko', or 'wine1.3-gecko'. Why isn't there just a single app clearly called 'Wine'? I didn't really have any clue which of these various software packages is the real Wine, but the one at the top--the 'meta package'--had the most ratings and ranked highly at 4.5 stars, so I decided to give that one a shot." Second problem - he expected to run a program called Wine, found wineconfig, did something with it, and then got back on track: "Once it completed installing, I went to the Applications lens on the Unity bar and typed in Wine. It claims I have three apps installed that fit that description: Configure Wine, Uninstall Wine Software, and Winetricks. I was hoping to actually run Wine, but given these three options it seems that Configure Wine is the logical first choice. I clicked Configure Wine and the Wine Configuration console popped up (go figure). At the bottom of the Applications tab, it specific which version of Windows to emulate...I mean be compatible with. It defaults to Windows XP, but I changed it to Windows 7... OK. Now, I am ready to run some Windows software, right?" Third problem: he expected Office 2010 to install and run Fourth problem: he couldn't even run the installer: " I opened up the folder from my Windows drive where I store downloaded software, right-clicked my Microsoft Office 2010 installation executable and clicked 'Open With Wine Windows Program Loader', and...got an error message. Something to the effect that this software is not marked as executable. Windows logoRunning Windows software in Wine proved convoluted and elusive.I checked with Google, and found a helpful walk-through from Psychocats.net called Using Wine on Ubuntu. Apparently, the fact that the software is an EXE is not obvious enough, so I have to first right-click the file, go into the Properties, and click a checkbox designating the file as executable. Seems convoluted. The problem is, every time I click the checkbox my check disappears. It won't let me make my file executable. I tried looking for more help on Google to no avail. I tried a couple other executable installation files, but couldn't mark those as executable either. I assume it is a permissions thing--like I need to somehow access the file permissions with root privileges in order to be able to make those changes. That is just a theory, though. So, no Windows software running for me just yet." Ouch, ouch, ouch.

4 4

Re: urlmon: Use CoInternetParseIUri instead of IUri::GetPath in file protocol handler implementation
by Marvin 25 Jun '11

25 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11968 Your paranoid android. === WVISTAADM (32 bit protocol) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

shouldn't the 1.3 dependencies include binfmt-support and lib32nss
by Susan Cragin 24 Jun '11

24 Jun '11

Just wondering. apt-get build-dep wine1.3 does not load binfmt-support and lib32nss... Installation of natspeak requires them. The installation script tries to grab them but failed for me.

2 1

Ars Technica article
by Brian Vincent 24 Jun '11

24 Jun '11

Here's some light reading for your weekend enjoyment. I found this on Ars Technica and thought it was a pretty good summary of some stuff from Microsoft's past and a pretty good guess at how some future technology pieces fit together. http://arstechnica.com/microsoft/news/2011/06/windows-8-for-software-develo… -Brian

1 0

How to do single-step debugging while testing?
by Michael Mc Donnell 24 Jun '11

24 Jun '11

Hi I'm trying to figure out how to single step through the code. I've looked at the winedbg and gdb information on winehq, but still can't figure out what to do. I normally run tests by issuing: $ ../../../tools/runtest name_of_test Is there a way to run the test in a debugger, so that I can single step through the functions that the test calls? Thanks, Michael Mc Donnell

3 7

re: [1/3] cmd/tests: Use plain strings instead of char arrays for keywords
by Dan Kegel 24 Jun '11

24 Jun '11

Frédéric Delanoy wrote: - static const char escaped_space[] = {'@','s','p','a','c','e','@','\0'}; + static const char *escaped_space = "@space@"; I'm not sure it's worth the effort, since eventually we want cmd to use unicode internally, at which point we'll have to go back to using arrays.

2 2

Re: Dylan Smith : d3dx9/tests: Added tests for D3DXCreateSkinInfo.
by Michael Stefaniuc 24 Jun '11

24 Jun '11

Hello Dylan, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 01ff07e2e1d2e77575ddbd88a705ef12ea6f9073 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=01ff07e2e1d2e77575ddbd88a… > > Author: Dylan Smith <dylan.ah.smith(a)gmail.com> > Date: Wed Jun 22 14:24:41 2011 -0400 > > d3dx9/tests: Added tests for D3DXCreateSkinInfo. > > --- > > dlls/d3dx9_36/tests/mesh.c | 229 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 229 insertions(+), 0 deletions(-) > > Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=01ff07e2e1d2e77575ddb… this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function) bye michael

4 7

re: Dylan Smith : d3dx9/tests: Added tests for D3DXCreateSkinInfo.
by Dan Kegel 24 Jun '11

24 Jun '11

Dylan wrote: - exp_weights[1] = FP_NAN; + exp_weights[1] = 0.0f / 0.0f; It's a bit strange to see 0 being replaced with infinity. What is your intent in that line? FP_NAN probably isn't what you think it is. On Fri, Jun 24, 2011 at 9:44 AM, Stefan Dösinger <stefandoesinger at gmx.at> wrote: > I'd appreciate a portable solution for generating NaN and Inf values as well, > I have the same problem with wined3d in visual studio. libxml2 has a nifty function trio_nan() which wraps all the portable ways of doing it. See e.g. http://www.opensource.apple.com/source/libxml2/libxml2-4/libxml2/trionan.c - Dan

1 0

Re: [PATCH 04/13] winmm: Clean up waveform.c's style
by Paul Vriens 24 Jun '11

24 Jun '11

On 06/23/2011 08:12 PM, Andrew Eikum wrote: > + if(dwFlags& WAVE_FORMAT_QUERY) > + TRACE("WAVE_FORMAT_QUERY requested!\n"); How is removing the spaces for all these if/else statements an improvement? It's also not consistent with the rest of the winmm code. -- Cheers, Paul.

1 0

Disablin xinput2 for now?
by Marcus Meissner 23 Jun '11

23 Jun '11

Hi, There seem to be regressions in xinput2 support, http://bugs.winehq.org/show_bug.cgi?id=27028 As this might be a X.org issue, should we packagers turn off xinput2 support for the time being? Ciao, Marcus

4 6

Re: [PATCH 3/4] shell32: Add IKnownFolder::SetPath() implementation
by Mariusz Pluciński 23 Jun '11

23 Jun '11

Please, ignore this single patch. This function should be implemented in other way (using redirection feature, the thing I am working on but did not submit yet). W dniu 23.06.2011 18:50, Mariusz Pluciński pisze: > --- > dlls/shell32/shellpath.c | 32 ++++++++++++++++++++++++++++++-- > dlls/shell32/tests/shellpath.c | 3 +-- > 2 files changed, 31 insertions(+), 4 deletions(-) > > -- Best regards Mariusz Pluciński

1 0

Re: [2/6] Make ComboBoxEx send CBEN_ENDEDIT when selecting from the dropdown list
by Nikolay Sivov 23 Jun '11

23 Jun '11

On Thu, Jun 23, 2011 at 6:57 PM, Jay Yang <jkelleyy(a)gmail.com> wrote: > >> Could you please add a test for that? It's possible to explicitly send >> WM_COMMAND I guess. This could be done as a next patch if you're sure >> it works right. But in general it should come with a fix. > Hi Nikolay, > > Do you have a suggestion on how to simulate selecting an element from the dropdown list? Should I just send a CBN_DROPDOWN message followed by a CBN_CLOSEUP to the ComboBoxEx? > Yes, this could work I think. Sometimes it's a pain to get a reliable test for controls that are made from another ones, because interaction between them differs or creation order differs between native a wine's. If it's not worth it, it's ok to add simple separate test application to reproduce that, link it with a patch or as another message to wine-devel. Just to have more information about what this patch fixes.

1 0

Re: [4/5] user32: Test that QS_HOTKEY is properly set and cleared.
by Marvin 23 Jun '11

23 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11926 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [2/6] Make ComboBoxEx send CBEN_ENDEDIT when selecting from the dropdown list
by Nikolay Sivov 23 Jun '11

23 Jun '11

On Thu, Jun 23, 2011 at 6:31 PM, Jay Yang <jkelleyy(a)gmail.com> wrote: > Windows send a CBEN_ENDEDIT when selecting from the dropdown menu, and for wine to send that message, the WCBE_ACTEDIT flag needs to be set when the dropdown is created. > --- > dlls/comctl32/comboex.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > Hey, Jay. Could you please add a test for that? It's possible to explicitly send WM_COMMAND I guess. This could be done as a next patch if you're sure it works right. But in general it should come with a fix.

1 0

GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell 23 Jun '11

23 Jun '11

Sorry I made a mistake. On Thu, Jun 23, 2011 at 11:07 AM, Michael Mc Donnell <michael(a)mcdonnell.dk> wrote: > Yes that's the basics of it. It does some other funny things too. For > example it re-orders the indices, so if you have > > 0--1 6 3 > | / / | | \ > | / / | | \ > 2 8--7 5--4 > > That corresponds to: > > index buffer = [ 0,1, 2, 6, 7,8, 3, 4,5] > adjacency = [-1,1,-1, 2,-1,0, -1,-1,1] > point rep = [ 0,1, 2, 1, 4,7, 1, 7,2] Index 5 is not replaced by 7 because the lowest index is always used. So it should have been the other way around: point rep = [ 0,1, 2, 1, 4,5, 1, 5,2] > If the indices had not been re-ordered then the point representation > would have been > [0,1,2, 1,7,2, 1,4,7]. And similarly [0,1,2, 1,5,2, 1,4,5]. I'll put this example into the test.

1 0

Re: [PATCH 03/10] urlmon: Reimplement CreateURLMonikerEx on top of IUri APIs
by Alexandre Julliard 23 Jun '11

23 Jun '11

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/umon.c | 115 > ++++++++++++++++++++++++++++------------------------ > 1 files changed, 62 insertions(+), 53 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M qmgr.dll -T ../../.. -p qmgr_test.exe.so job.c && touch job.ok job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:386: Test failed: BITS jobs timed out job.c:388: Test failed: IBackgroundCopyJob_Complete job.c:329: Test failed: CreateFile job.c:333: Test failed: ReadFile job.c:338: Test failed: Files differ in length job.c:339: Test failed: Files differ in contents job.c:329: Test failed: CreateFile job.c:333: Test failed: ReadFile job.c:338: Test failed: Files differ in length job.c:339: Test failed: Files differ in contents make: *** [job.ok] Error 39 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] d3dx9_36/tests: Added tests for constant table samplers (Try 2)
by Marvin 22 Jun '11

22 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11904 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] msvcp90: Added locale class stub
by Alexandre Julliard 22 Jun '11

22 Jun '11

Piotr Caban <piotr(a)codeweavers.com> writes: > +/* ?name@locale@std@@QBE?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@XZ */ > +/* ?name@locale@std@@QEBA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@XZ */ > +DEFINE_THISCALL_WRAPPER(locale_name, 8) > +void __thiscall locale_name(THIS_AND_RET(const locale *this, basic_string_char *ret)) > +{ > + FIXME("(%p %p) stub\n", this, ret); > +} You should declare it correctly for the non-i386 case, the return pointer is a calling convention detail that the compiler should take care of. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation (resend)
by Marvin 22 Jun '11

22 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11886 Your paranoid android. === WVISTAADM (32 bit shellpath) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

[1/2] d3dx9/test: Add UpdateSemantics test. (try 3)
by Michael Mc Donnell 22 Jun '11

22 Jun '11

Hi Alexandre My UpdateSemantics patches haven't been applied yet. Stefan Dösinger and Dylan Smith think they look ok. Is there something that looks wrong with them to you, or have you just not have the time to look at them yet? Thanks, Michael Mc Donnell

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Marvin 22 Jun '11

22 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11882 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [2/3] wined3d: Fix context_apply_draw_buffers() with backbuffer ORM.
by Henri Verbeet 21 Jun '11

21 Jun '11

On 21 June 2011 23:49, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > Here I modified surface_get_gl_buffer() to fix backbuffer ORM, an > alternative approach would be to modify > context_apply_[blit|clear|draw]_state() in a similar fashion instead. > Yeah, I think I'd prefer the alternative. We handle onscreen and offscreen surfaces separately for the FBO cases as well, and conceptually I'd prefer ORM checks to be in the context code if anywhere.

1 0

bug policy for "app X needs msvcp90.dll" type bugs
by Dan Kegel 21 Jun '11

21 Jun '11

(From the "keeping AF happy" and "metabugs are evil" departments.) Anyone watching wine-bugs already knows this, but just in case: As AF suggested in http://bugs.winehq.org/show_bug.cgi?id=24745#c11 bugs about apps needing msvcr90 or the like should identify the particular function in the bug subject line, if possible. There are still some bugs that simply say "app X needs native msvcr90". When the particular function that bothered them is fixed, and the app is verified to get further, that bug's subject line should be updated to identify the function that was fixed, and the bug should be marked as fixed. If the game still doesn't run because of some other function, a new bug should be filed.

1 0

Re: [PATCH 2/2] jscript: Correctly throw an exception if instanceof expression is not used on function
by Marvin 21 Jun '11

21 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11874 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation
by Mariusz Pluciński 21 Jun '11

21 Jun '11

Hello Would you explain me, what is wrong with this patches series? I've submitted it last week and for some reason it's status is untouched. (the "failed" status seems to be temporal testbot's problem rather than my patch's, so this is not the reason). I have no idea how to fix them. Best regards Mariusz Pluciński W dniu 15.06.2011 18:05, Mariusz Pluciński pisze: > To not break currently working applications/tests, I decided to > implement known folders using following schema: > 1. implement infrastructure of known folders without breaking > currently working CSIDL-based way. New code is used only for folders > registered using RegisterFolder(). For all others, the older code > using CSIDL_Data array is used. > 2. move all folders from CSIDL_Data array to registry and remove old > way of accessing them. > --- > dlls/shell32/shellpath.c | 70 > ++++++++++++++++++++++++++++++++++++++- > dlls/shell32/tests/shellpath.c | 1 - > 2 files changed, 68 insertions(+), 3 deletions(-) > >

2 1

Re: Regression today?
by Susan Cragin 21 Jun '11

21 Jun '11

2 1

Regression today?
by Susan Cragin 21 Jun '11

21 Jun '11

I think a regression was introduced today. I got the following trying to run NatSpeak 11.0 with today's git. wine-1.3.22-255-g4c0c0d3 Should I do a regression test and file a bug, or is it obvious from this? Or is it me -- something to do with my new Oneiric Ocelot? Or the new 3.0 kernel? susan@ubuntu:~/.wine/drive_c/Program Files/Nuance/NaturallySpeaking11/Program$ wine natspeak err:service:service_send_start_message service L"DragonSvc" failed to start fixme:iphlpapi:NotifyAddrChange (Handle 0xc2e91c, overlapped 0xc2e900): stub wine: configuration in '/home/susan/.wine' has been updated. fixme:ole:CoInitializeSecurity ((nil),-1,(nil),(nil),0,3,(nil),0,(nil)) - stub! fixme:wbemprox:wbem_locator_ConnectServer 0x134288, L"ROOT\\CIMV2", (null), (null), (null), 0x00000000, (null), (nil), 0xfcea54) fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsupported ioctl 74080 fixme:wbemprox:wbem_locator_ConnectServer 0x135fd0, L"ROOT\\CIMv2", (null), (null), (null), 0x00000000, (null), (nil), 0x10cea5c) fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsupported ioctl 74080 fixme:wbemprox:wbem_locator_ConnectServer 0x135fd0, L"ROOT\\CIMv2", (null), (null), (null), 0x00000000, (null), (nil), 0xfcea5c) fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsupported ioctl 74080 fixme:wbemprox:wbem_locator_ConnectServer 0x136020, L"ROOT\\CIMv2", (null), (null), (null), 0x00000000, (null), (nil), 0x10cea5c) fixme:wbemprox:wbem_locator_ConnectServer 0x136020, L"ROOT\\WMI", (null), (null), (null), 0x00000000, (null), (nil), 0xfcea54) fixme:reg:RegSetKeySecurity :(0x60,4,0xd9ba9c): stub fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS fixme:mountmgr:harddisk_ioctl unsupported ioctl 74080 fixme:wbemprox:wbem_locator_ConnectServer 0x136020, L"ROOT\\CIMv2", (null), (null), (null), 0x00000000, (null), (nil), 0x10cea5c) susan@ubuntu:~/.wine/drive_c/Program Files/Nuance/NaturallySpeaking11/Program$

3 2

Re: [PATCH 1/4] dlls/ntdll: Add handle count to NtQuerySystemInformation
by Vitaliy Margolen 21 Jun '11

21 Jun '11

On 06/19/2011 08:15 PM, Austin Lund wrote: > + ret = wine_server_call( req ); > + shi->Count += reply->handles; > + len = sizeof(SYSTEM_HANDLE_ENTRY)*shi->Count + sizeof(ULONG); > + shi = RtlReAllocateHeap(GetProcessHeap(), HEAP_ZERO_MEMORY, shi, len); Please do allocations outside of server call block. And add handling of failed realloc. Also please double the allocated size, don't reallocate after each server call. > + for (i = shi->Count - reply->handles; i< shi->Count; i++) { > + shi->Handle[i].OwnerPid = reply->pid; > + } Please follow file's curly braces style - none for single line blocks, or on separate line for multi-line blocks. Vitaliy.

2 4

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer.
by Vitaliy Margolen 21 Jun '11

21 Jun '11

On 06/20/2011 04:06 PM, Lucas Fialho Zawacki wrote: > @@ -1391,9 +1391,24 @@ HRESULT WINAPI IDirectInputDevice8AImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface > LPCSTR lpszUserName, > DWORD dwFlags) > { ... > + hr = IDirectInputDevice8_SetActionMap(&This->IDirectInputDevice8W_iface, > +&diafW, NULL, dwFlags); You need to call IDirectInputDevice8WImpl_SetActionMap directly here. Also please don't wrap lines at 80 characters, you can put all that into one line. And please be consistent with spacing around parentheses - either put spaces on both sides, or don't put at all. > + memset(&dp,0,sizeof(dp)); Please don't needlessly zero structures. You setting most values of it anyway. And please don't forget spaces after comas. Otherwise looks really good! Vitaliy.

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5)
by Marvin 20 Jun '11

20 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11852 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: shdocvw: Add ITaskbarList2 Interface (try 2)
by Michael Stefaniuc 20 Jun '11

20 Jun '11

Hello André, On 06/20/2011 10:01 PM, André Hentschel wrote: > I should mention that i never added a interface before, neither one > that extends an existing one. I want to stub out ITaskbarList3, so i > thought i should first start with ITaskbarList2 and see what i'm doing > right or wrong. this is a waste of time. Go straight for ITaskbarList3 as that inherits from ITaskbarList2. You would would just duplicate most of the work as you have to change again all the functions to take a ITaskbarList3 instead of a ITaskbarList2. > This time i kept the implementation of QueryInterface > as much as possible. bye michael

1 0

Re: [PATCH 2/3] server: Added server-side raw input function implementations (try 4)
by Vitaliy Margolen 20 Jun '11

20 Jun '11

On 06/20/2011 02:55 AM, Vincas Miliūnas wrote: > (see the message in the first part of the patch) > +struct raw_input > +{ > + struct list entry; > + unsigned short usage_page; > + unsigned short usage; > + BOOL processed; > + BOOL retrieved; > + RAWINPUT raw; > + > + /* common fields */ > + unsigned int type; > + unsigned int message; > + unsigned int flags; > + unsigned int extra_info; > + > + /* mouse fields */ > + unsigned int point_x; > + unsigned int point_y; > + unsigned int mouse_data; > + unsigned int cursor_x; > + unsigned int cursor_y; > + > + /* keyboard fields */ > + unsigned int vk_code; > + unsigned int scan_code; > +}; Mouse and keyboard fields should be a union to save space. > +#define NUM_RAW_DEVICES (sizeof( raw_devices ) / sizeof( struct raw_device )) Please use "sizeof(array)/sizeof(array[0])" construct instead. > + UINT i, size_in_bytes; In server please use standard C types ("unsigned int" in this case). > + /* Currently fake handles are provided, however they are only used for the GetRawInputDeviceInfo function, > + thus it should not create any undesirable side effects */ > + result[i].hDevice = (HANDLE)raw_devices[i].handle; This doesn't sound right. What this handle can be used for? > + if (!(raw = malloc( sizeof( *raw ) ))) In server please use mem_alloc() instead. > +/* Unregister a raw input device */ > +DECL_HANDLER(unregister_raw_input_device) I don't see handing of case where device is not found. Should you return error instead? > + LIST_FOR_EACH( registration_entry, &current->process->raw_registered ) > + { > + struct raw_registration *registration = LIST_ENTRY( registration_entry, struct raw_registration, entry ); You can use this instead: LIST_FOR_EACH_ENTRY( registration, &current->process->raw_registered, struct raw_registration, entry ) > + /* Prevent unprocessed raw input entries from being queued indefinitely */ > + while (current->process->raw_inputs_len >= MAX_RAW_INPUT_QUEUE_LENGTH) > + { > + struct raw_input *head = LIST_ENTRY( list_head( &current->process->raw_inputs ), struct raw_input, entry ); > + list_remove( &head->entry ); > + current->process->raw_inputs_len -= 1; > + free( head ); > + } Looks like you need a circular buffer (an array of fixed size with head and tail pointers) instead of a list here. Vitaliy.

2 1

Re: shdocvw: Add ITaskbarList2 Interface
by Henri Verbeet 20 Jun '11

20 Jun '11

2011/6/18 André Hentschel <nerv(a)dawncrow.de>: > -static HRESULT STDMETHODCALLTYPE taskbar_list_QueryInterface(ITaskbarList *iface, REFIID riid, void **object) > +static HRESULT STDMETHODCALLTYPE taskbar_list_QueryInterface(ITaskbarList2 *iface, REFIID riid, LPVOID *ppv) > { > - TRACE("iface %p, riid %s, object %p\n", iface, debugstr_guid(riid), object); > + struct taskbar_list *This = impl_from_ITaskbarList2(iface); > + > + *ppv = NULL; > + > + if(IsEqualGUID(&IID_IUnknown, riid)) { > + TRACE("(%p)->(IID_IUnknown %p)\n", This, ppv); > + *ppv = &This->ITaskbarList2_iface; > + }else if(IsEqualGUID(&IID_ITaskbarList, riid)) { > + TRACE("(%p)->(IID_ITaskbarList %p)\n", This, ppv); > + *ppv = &This->ITaskbarList2_iface; > + }else if(IsEqualGUID(&IID_ITaskbarList2, riid)) { > + TRACE("(%p)->(IID_ITaskbarList2 %p)\n", This, ppv); > + *ppv = &This->ITaskbarList2_iface; > + } > > - if (IsEqualGUID(riid, &IID_ITaskbarList) > - || IsEqualGUID(riid, &IID_IUnknown)) > - { > - IUnknown_AddRef(iface); > - *object = iface; > + if(*ppv) { > + IUnknown_AddRef((IUnknown*)*ppv); > return S_OK; > } > > - WARN("%s not implemented, returning E_NOINTERFACE\n", debugstr_guid(riid)); > - > - *object = NULL; > + WARN("(%p)->(%s %p) interface not supported\n", This, debugstr_guid(riid), ppv); > return E_NOINTERFACE; > } > I'm not sure that's really an improvement.

2 1

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 4)
by Vitaliy Margolen 20 Jun '11

20 Jun '11

On 06/20/2011 02:55 AM, Vincas Miliūnas wrote: > Fixed function name typo, compiler warnings, code style issues in a > fragment of new code and incorrect usage of wcslen in the tests instead > of lstrlenW after previous changes. My apologies :). > > +#define DEADBEEF 0xdeadbeef Please don't do this. Just explicitly use 0xdeadbeef everywhere. > + todo_wine ok(ret == 0 && GetLastError() == DEADBEEF && count >= 1, "Given (NULL, &count, sizeof), " > + "GetRawInputDeviceList should return the number of raw input devices\n"); If call succeeded you don't need to check last error. > + device_list = malloc(count * sizeof(RAWINPUTDEVICELIST)); Don't use malloc/free in Wine. Use HeapAlloc / HeapFree. > + ret = pGetRawInputDeviceList(device_list, &count2, sizeof(RAWINPUTDEVICELIST)); > + todo_wine ok(ret == (UINT)-1 && GetLastError() == ERROR_INSUFFICIENT_BUFFER && count2 == count, > + "Given (device_list, &count2 = 0, sizeof), GetRawInputDeviceList should return an error\n"); If something fails it's nice to know the error code - you need to print it. For that you need to more GetLastError outside of ok() function call. See other tests as example. > +static BOOL get_raw_input_data_wnd_proc_was_called = FALSE; Static variables automatically set to 0 at the start. You don't need to do it explicitly. Vitaliy.

1 0

Re: [PATCH 2/2] d3dx9/line: Implemented tests for ID3DXLine's Begin and End methods.
by Matteo Bruni 20 Jun '11

20 Jun '11

2011/6/18 Charles Welton <charleswfb(a)gmail.com>: > --- > dlls/d3dx9_36/tests/line.c | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > > + srand(time(NULL)); > + random = ((FLOAT) rand())/RAND_MAX; /* Random value between 0.0 and 1.0. We're using this later. */ I didn't check why your patch failed with the testbot. Nevertheless, you should avoid to use random values: the tests should be repeatable. Just pick some arbitrary values and use them. Also, for better clarity, you may want to use a different variable for the modified identity matrix (because, at that point, it isn't identity anymore). Maybe you could check the world matrix between ID3DXLine_Begin and ID3DXLine_End too.

1 0

Re: [PATCH 2/4] server: Add function to count only valid handles in a process
by Vitaliy Margolen 20 Jun '11

20 Jun '11

On 06/19/2011 08:15 PM, Austin Lund wrote: > [PATCH 2/4] server: Add function to count only valid handles in a process This makes no sense. All handles are valid inside wineserver. Vitaliy.

2 1

Disablin xinput2 for now?
by Joerg-Cyril.Hoehle＠t-systems.com 20 Jun '11

20 Jun '11

Hi, >There seem to be regressions in xinput2 support I too have experienced various mouse trouble since approx. 1.3.18 on MacOS, using XQuartz 2.5.x or 2.6.1 -- which is much more recent than any of my Ubuntu systems (Lucid). As I've currently little time for regressions, I haven't yet turned that into bug reports (and had always hoped that Wine release N+1 would eventually make things work again). Haegemonia 2 aka. Legions of Iron seems to be fixed as of 1.3.22. Previously, the mouse flickered badly when moved and it moved like crazy along one y/x direction. As of 1.3.22, Black & White 2 doesn't react to the mouse anymore. >should we packagers turn off >xinput2 support for the time being? There's still hope that the situation will stabilize as present bug reports are analyzed and the causes understood. I also hope somebody will update the Wiki pages, e.g. UsefulRegistryKeys to reflect new possibilities. I would believe there are some. The Wiki is the place where I'd expect to find a summary of options and hints for when a program does not work in area Y. I know where to look for some forms of audio trouble, but what do I know about mouse trouble? Before starting git bisect, I'd prefer to try out whether a few registry keys may help with the mouse. Which ones should I try? Regards, Jörg Höhle

1 0

Re: [1/2] d3dx9/test: Add UpdateSemantics test. (try 3)
by Stefan Dösinger 20 Jun '11

20 Jun '11

These two patches look OK to me. On Friday 17 June 2011 14:19:56 Michael Mc Donnell wrote: > Removed a superfluous test. > Added NULL check before releasing mesh. > Changed struct declaration style. > Changed the struct declaration style again. > Added GetNumBytesPerVertex test > Added GetDeclaration tests > Added equals check > Renamed larger declaration test to overlapping declaration test. > Added smaller and larger declarations. > Added D3DECL_END() marker check > Moved pointer * to new_test_context (nitpick) > Added multiple streams test

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 4)
by Marvin 20 Jun '11

20 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11841 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [3/3] msxml3: Added IStream support to IMXWriter
by Adam Martinson 20 Jun '11

20 Jun '11

On 06/19/2011 09:32 PM, Thomas Mullaly wrote: > +static inline void reset_output_buffer(mxwriter *This, LPCSTR encoding) > +{ > + xmlOutputBufferClose(This->buffer); > + > + if (encoding) > + This->buffer = xmlAllocOutputBuffer(xmlFindCharEncodingHandler(encoding)); > + else if (!This->dest) > + This->buffer = xmlAllocOutputBuffer(xmlFindCharEncodingHandler("UTF-16")); > + else { > + LPSTR enc = heap_strdupWtoA(This->encoding); > + This->buffer = xmlAllocOutputBuffer(xmlFindCharEncodingHandler(enc)); > + heap_free(enc); > + } > + > + This->dest_written = 0; > +} > Libxml2 has the various encodings enum'd out as xmlCharEncoding; better to pass the enum around and avoid the string comparison. Then you can use xmlGetCharEncodingHandler() instead of xmlFindCharEncodingHandler().

1 0

Re: [1/3] msxml3/tests: Added IStream tests for IMXWriter
by Adam Martinson 20 Jun '11

20 Jun '11

On 06/19/2011 09:31 PM, Thomas Mullaly wrote: > +#define DEFINE_EXPECT(func) \ > + static BOOL expect_ ## func = FALSE, called_ ## func = FALSE > + > +#define SET_EXPECT(func) \ > + expect_ ## func = TRUE This seems like macro-overkill. I think a struct/table here may be a bit cleaner. > +static const CHAR szUtf16BOM[] = {'\xff','\xfe'}; Normal hex here would be more readable.

1 0

Re: ddraw: Add tests for SetCooperativeLevels
by Marvin 20 Jun '11

20 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11839 Your paranoid android. === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

CopyFileExW Support
by Arthur Dene Ice 20 Jun '11

20 Jun '11

Thank you Jerome, this is my first patch and I pretty much bunged it all up. I appreciate the help. So to recap, subscribe to list first so that I can respond to messages. check. Fix my tab/spacing issue. check. and fix my patch submission subject line so it is more in line with the standard. check.

1 0

Re: [PATCH 1/6] quartz/tests: COM cleanup for the IPin iface.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11823 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B3C

2 1

Re: [PATCH 6/6] quartz/tests: Simplify the file handling in filtergraph.c.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11828 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405AEC

1 0

Re: [PATCH 5/6] quartz/tests: Store the TestFilterImpl instead of its iface in IEnumPinsImpl.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11827 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B2C

1 0

Re: [PATCH 4/6] quatz/tests: Pass back the object instead of the iface in createtestfilter()
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11826 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B2C

1 0

Re: [PATCH 3/6] quartz/tests: Finish the COM cleanup in filtergraph.c.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11825 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B3C

1 0

Re: [PATCH 2/6] quartz/tests: COM cleanup for the IClassFactory iface.
by Marvin 19 Jun '11

19 Jun '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11824 Your paranoid android. === WNT4WSSP6 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00405B3C

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel June 2011