wine-devel July 2011

wine-devel@winehq.org

69 participants
221 discussions

re: wined3d: Introduce quirk for proper RGBA16 support.
by Dan Kegel 08 Jul '11

08 Jul '11

It seems to work... but in Mass Effect 2 Demo with the patch, the initial cinematics (where Shepard is trying to put out the fire, and you're prompted to answer "There's no time to argue", are very jerky, and CPU usage is very high. I didn't have that problem without the patch.

1 1

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard 08 Jul '11

08 Jul '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static inline HWAVE WINMM_MakeHWAVE(UINT mmdevice, BOOL is_out, UINT device) > +{ > + return (HWAVE)((1 << 15) | ((!!is_out) << 14) | (mmdevice << 8) | device); > +} > + > +static inline void WINMM_DecomposeHWAVE(HWAVE hwave, UINT *mmdevice_index, > + BOOL *is_out, UINT *device_index, UINT *junk) > +{ > + *device_index = ((UINT)hwave & 0xFF); > + *mmdevice_index = ((UINT)hwave >> 8) & 0x3F; > + *is_out = ((UINT)hwave >> 14) & 0x1; > + *junk = (UINT)hwave >> 15; > +} This (and the same thing in various other places) will cause pointer conversion warnings on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Fix SETUPDI_OpenDrvKey
by Alexandre Julliard 08 Jul '11

08 Jul '11

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > @@ -3728,8 +3728,13 @@ static HKEY SETUPDI_OpenDrvKey(struct DeviceInfo *devInfo, REGSAM samDesired) > WCHAR devId[10]; > > sprintfW(devId, fmt, devInfo->devId); > - RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > - RegCloseKey(classKey); > + l = RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > + if (!l) { > + RegCloseKey(classKey); > + } else { > + SetLastError(ERROR_KEY_DOES_NOT_EXIST); > + return INVALID_HANDLE_VALUE; > + } You are leaking the key now. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin (try 2)
by Alexandre Julliard 08 Jul '11

08 Jul '11

Jay Yang <jkelleyy(a)gmail.com> writes: > +static void test_query_recyclebin(void) > +{ > + SHQUERYRBINFO info1={sizeof(info1),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; > + SHQUERYRBINFO info2={sizeof(info2),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; You can't use LL constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Bug #2082
by Charles Welton 08 Jul '11

08 Jul '11

This is one of the longest standing bugs which don't get much love from developers. Today I took some time with traces and wrote a test case which fails against git: http://bugs.winehq.org/attachment.cgi?id=35469 What is happening? When there's a child window to the ddraw window over it(the ddraw window), wined3d doesn't draw over the child. Windows, however, doesn't care about children and draws over them. Note that the DC is the same for both(according to traces). Not only that, the child window have different positions when in fullscreen or virtual desktop. As for the fix, I have yet to find the culprit dll(s) for this. Unfortunately I don't have the experience with wine's code and would like suggestions as to where to begin. -- Charles Welton

2 1

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)
by Juan Lang 08 Jul '11

08 Jul '11

Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't enough. Thanks, --Juan

3 3

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)
by Marvin 07 Jul '11

07 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)
by Marvin 07 Jul '11

07 Jul '11

1 0

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin
by Marvin 07 Jul '11

07 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12300 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: msvcrt/tests: Remove dead assignment (Clang)
by Octavian Voicu 07 Jul '11

07 Jul '11

2011/7/7 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- a/dlls/msvcrt/tests/file.c > +++ b/dlls/msvcrt/tests/file.c > @@ -132,21 +132,21 @@ static void test_fileops( void ) > rewind(file); > for (i = 0, c = EOF; i < sizeof(outbuffer); i++) Isn't c = EOF in for initialization also a dead assignment? Octavian

2 1

← Newer
1
...
14
15
16
17
18
19
20
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2011