wine-devel September 2011

wine-devel@winehq.org

83 participants
387 discussions

RFC: Highlighting Fall-throughs
by Andrew Talbot 23 Sep '11

23 Sep '11

Hi All, I am thinking of marking any unmarked places in switch statements where fall-through occurs. However, simply to do so would be to ignore the question of whether each fall-through is intentional or an oversight. I therefore propose to mark each new point with two comments (maybe separate, maybe combined): one to state that fall-through occurs and the other to point out that the validity of this particular fall-through has not yet been checked, maybe something like: select(x) { case 1: foo(); break; case 2: bar(); /* fall through */ /* unaudited */ default: baz(); } Is this all good, or is there a better way? Thanks, -- Andy.

3 4

Re: comctl32: Fix going to today with multiple calenders
by Nikolay Sivov 22 Sep '11

22 Sep '11

On 9/23/2011 00:03, André Hentschel wrote: > --- > dlls/comctl32/monthcal.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c > index 5f8a36c..b330871 100644 > --- a/dlls/comctl32/monthcal.c > +++ b/dlls/comctl32/monthcal.c > @@ -1970,9 +1970,7 @@ MONTHCAL_RButtonUp(MONTHCAL_INFO *infoPtr, LPARAM lParam) > if( TrackPopupMenu(hMenu, TPM_RIGHTBUTTON | TPM_NONOTIFY | TPM_RETURNCMD, > menupoint.x, menupoint.y, 0, infoPtr->hwndSelf, NULL)) > { > - infoPtr->calendars[0].month = infoPtr->todaysDate; > - infoPtr->minSel = infoPtr->todaysDate; > - infoPtr->maxSel = infoPtr->todaysDate; > + MONTHCAL_SetCurSel(infoPtr,&infoPtr->todaysDate); > InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); > } > This is wrong, it lacks notification calls and you have unneeded invalidate call left. Also similar case remains to be fixed. Actually I planned to work on this tomorrow, including some other issues I just spotted.

2 2

Fwd: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation
by Dan Kegel 22 Sep '11

22 Sep '11

Didn't build here, did you forget to add dependency on ole32? ccache gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -Wno-unused-but-set-variable -Wno-unused-but-set-parameter -o vwin32.o vwin32.c global.o: In function `create_object': /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:74: undefined reference to `CLSIDFromProgID' /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:92: undefined reference to `CoGetClassObject' /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:114: undefined reference to `CoTaskMemFree' collect2: ld returned 1 exit status winegcc: ccache failed make[1]: *** [vbscript.dll.so] Error 2 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Thu, Sep 22, 2011 at 8:01 AM Subject: Re: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/26 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: make: *** [dlls/vbscript] Error 2

2 1

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)
by Jacek Caban 22 Sep '11

22 Sep '11

> === WNT4WSSP6 (32 bit createobj) === > createobj.c:734: Test failed: CoCreateInstance failed: 80040154 > createobj: unhandled exception c0000005 at 00402A21 These tests fail because testbot runs them regardless that vbscript.dll is not present on the machine. Jacek

1 0

IPv6 issue on TestBot?
by Francois Gouget 22 Sep '11

22 Sep '11

Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( This makes accessing it from my desktop very annoying. $ time wget -4 --quiet http://testbot.winehq.org/ real 0m2.150s user 0m0.000s sys 0m0.000s $ time wget -6 --quiet http://testbot.winehq.org/ ... still stuck after 6+ minutes $ telnet -6 testbot.winehq.org Trying 2001:888:2000:38:1000::2... ... same thing According to http://test-ipv6.com/ my desktop is configured just fine and I only have trouble with the TestBot. Could this be a firewall problem? (testbot exposing an IPv6 address but the firewall dropping any IPv6 packets) In the mean time I'm going to use my laptop which is still IPv4 only :-/ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A black hole is just God dividing by zero.

6 11

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)
by Marvin 22 Sep '11

22 Sep '11

1 0

Re: [PATCH 07/13] vbscript: Added exit for statement support
by Marvin 22 Sep '11

22 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14454 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/13] vbscript: Added for..in statement tests
by Marvin 22 Sep '11

22 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14453 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

crypt32(1/2): Test CertCreateCertificateContext, and fix an error code in a failure case
by Juan Lang 22 Sep '11

22 Sep '11

--Juan

1 0

Remove the legalese from start.exe?
by Francois Gouget 22 Sep '11

22 Sep '11

Start has the following lines at the end of its usage message: "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" "Start comes with ABSOLUTELY NO WARRANTY; for details run with /L option.\n" "This is free software, and you are welcome to redistribute it\n" "under certain conditions; run 'start /L' for details.\n" And also this resource: "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" "This program is free software; you can redistribute it and/or\n" "modify it under the terms of the GNU Lesser Public License\n" "as published by the Free Software Foundation; either version 2.1\n" [...] "along with this program; if not, write to the Free Software\n" "Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.\n" "\n" "See the COPYING.LIB file for license information.\n" We also have another copy of this copyright notice in shell32 for the 'About Wine' dialog but without the 'start.exe' and 'COPYING.LIB' lines, and with 'This program' replaced with 'Wine'. One more copyright notice we have is this in msrle32.rc: "Wine MS-RLE video codec\n" "Copyright 2002 by Michael Guennewig" Now this is all legalese which is a pain to translate (weird vocabulary) and pretty scary too. And because of the small differences the copyright notice needs to be translated twice (though tools like Virtaal/Launchpad may notice the similarity and prefill a fuzzy translation). Also start.exe and msrle32.dll are the only ones to have these notices which seems pretty inconsistent. So what can we do to make this simpler? The simplest would be to remove all copyright notices from start.rc and msrle32.rc. (we would keep the ones in the source of course). I guess that would require Dan's and Michael's approval. The other options involve separating the strings that change from one tool to the next, from those that stay the same. This way the latter will only appear once in the PO file and thus need to be translated only once. The various parts can then trivially be concatenated when they are displayed. (unfortunately this does not help for the msrle32.rc case) For instance we could decide to only keep the 'COPYING.LIB' string and tack it to the end of the usage message. We could also make things more consistent by doing this in every tool. So in pseudo-code we would have something like this: /* Load the tool-specific usage message */ usage_message = load_string(IDS_USAGE); /* Load the generic copying.lib reference. This one is duplicated in * every tool but always the same. */ copying_reference = load_string(IDS_COPYING); /* Print both */ printf(usage_message); printf(copying_reference); Another option would be to reuse the exact same main copyright notice as in the About Wine dialog since we need to translate that anyway (I think it would work wrapping-wise). So the start.exe pseudo-code for showing the license would be something like this: /* Load the copyright notice header, that is: * start.exe version 0.2 Copyright (C) 2003, Dan Kegel * start.exe is part of Wine. */ notice_header = load_string(IDS_NOTICE_HEADER); /* Load the generic Wine copyright notice. Note that it * says 'Wine' like in the 'About Wine' dialog, not 'This program' * and would be the same in any other Wine tool: * Wine is free software; you can redistribute it and/or modify * ... */ notice_generic = load_string(IDS_NOTICE_GENERIC); /* Load the copyright notice trailer: * * See the COPYING.LIB file for license information. */ notice_trailer = load_string(IDS_NOTICE_TRAILER); /* Print all the parts together */ printf(notice_header); printf(notice_generic); printf(notice_trailer); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

3 4

← Newer
1
...
7
8
9
10
11
12
13
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel September 2011