wine-devel January 2012

wine-devel@winehq.org

83 participants
193 discussions

Start a nNew thread

Re: jscript: Fixed continue inside for..in statement
by Marvin 10 Jan '12

10 Jan '12

1 0

Re: gdi32: GetGlyphIndices doesn't substitute glyph.
by Marvin 10 Jan '12

10 Jan '12

1 0

Re: [PATCH] programs/explorer: Fix explorer's command line parsing (try 2)
by Vitaliy Margolen 10 Jan '12

10 Jan '12

On 01/08/2012 08:45 PM, Jay Yang wrote: > Fixed some small formatting issues from last time. > Your patch strips spaces all over the place. For example: + LPWSTR *argv; + if(commandline[0]=='\0') Need an empty line after variable declarations. No space after "if". No space around equal operator. + for(i=0;i<argc;i++) No spaces after semi-colon. + copy_path_string(parameters->root,curr); No space after coma. Some other issues - you will parse over parameters given to the program. Ex: explorer /desktop=foo,800x600 program.exe /n /e Parsing inside parameters is incorrect: + LPWSTR end=strchrW(curr,','); + LPWSTR next; + if(end==NULL) + next=(end=strchrW(curr,'\0')); + else + next=end+1; ... + curr=next; You end up parsing something like this as a valid param: /n,/e,/select,c:\\ Vitaliy.

2 2

Re: [4/5] dinput: Device username being assigned at creation time (try 2)
by Vitaliy Margolen 10 Jan '12

10 Jan '12

On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki<lfzawacki(a)gmail.com> You leaking FindFile handle. Need to use FindClose() to close it. This is on top of more unchecked returns from HappAlloc. Vitaliy.

1 0

Re: [3/5] dinput: SetActionMap setting username
by Vitaliy Margolen 10 Jan '12

10 Jan '12

On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki<lfzawacki(a)gmail.com> > > + /* Set username in device */ > + HeapFree(GetProcessHeap(), 0, This->username); > + This->username = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * (lstrlenW(username) + 1)); > + lstrcpyW(This->username, username); No error checking if allocation fails. > + > + /* Free username */ > + HeapFree(GetProcessHeap(), 0, This->username); > + Comment is kind of redundant the property already called "username". Vitaliy.

1 0

UTF-7
by Alex Henrie 10 Jan '12

10 Jan '12

Hello, I have been thinking about implementing UTF-7 support in MultiByteToWideChar and WideCharToMultiByte. The guts of the code that needs to be added have already been posted to bug 27388. What more needs to be done? Should a libs/wine/utf7.c file be created for the new functions, similar to libs/wine/utf8.c? -Alex

1 0

Re: [1/5] dinput: Added DI_SETTINGSNOTSAVED flag
by Francois Gouget 09 Jan '12

09 Jan '12

On Mon, 9 Jan 2012, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > --- > include/dinput.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/dinput.h b/include/dinput.h > index 353ec55..cf99ecc 100644 > --- a/include/dinput.h > +++ b/include/dinput.h > @@ -134,6 +134,7 @@ DECL_WINELIB_TYPE_AW(LPDIRECTINPUTDEVICE8) > #define DI_DOWNLOADSKIPPED ((HRESULT)0x00000003) > #define DI_EFFECTRESTARTED ((HRESULT)0x00000004) > #define DI_TRUNCATED ((HRESULT)0x00000008) > +#define DI_SETTINGSNOTSAVED ((HRESULT)0x0000000BL) > #define DI_TRUNCATEDANDRESTARTED ((HRESULT)0x0000000C) I'm not sure the 'L' modifier is needed or makes sense (although the PSDK does have it). In anycase there's clearly an inconsistency in the above patch and we normally avoid the 'L' modifier nowadays, see for instance __MSABI_LONG() in include/ddeml.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [6/6] d3drm: Implement GetParent
by Nikolay Sivov 09 Jan '12

09 Jan '12

On 1/8/2012 20:47, André Hentschel wrote: > --- > dlls/d3drm/frame.c | 11 +++++++---- > dlls/d3drm/tests/d3drm.c | 16 ++++++++-------- > 2 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/dlls/d3drm/frame.c b/dlls/d3drm/frame.c > index 212f7dd..b72700c 100644 > --- a/dlls/d3drm/frame.c > +++ b/dlls/d3drm/frame.c > @@ -33,6 +33,7 @@ typedef struct { > IDirect3DRMFrame2 IDirect3DRMFrame2_iface; > IDirect3DRMFrame3 IDirect3DRMFrame3_iface; > LONG ref; > + LPVOID parent; > } IDirect3DRMFrameImpl; Parent is store as another frame interface pointer, right? Why void* here? > > static const struct IDirect3DRMFrame2Vtbl Direct3DRMFrame2_Vtbl; > @@ -336,9 +337,10 @@ static HRESULT WINAPI IDirect3DRMFrame2Impl_GetParent(IDirect3DRMFrame2* iface, > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > > - FIXME("(%p/%p)->(%p): stub\n", iface, This, frame); > + TRACE("(%p/%p)->(%p)\n", iface, This, frame); > > - return E_NOTIMPL; > + *frame = This->parent; > + return D3DRM_OK; > } What looks suspicious is reference counting handling, or absence of it in other words. I'm not familiar with d3d, but this needs tests for parent refcount - is it increased when it's stored? is it properly freed? is it increased after GetParent()?

3 5

Re: [PATCH 1/6] ieframe: Added support for SID_SHTMLWindow in WebBrowser::QueryService
by Marvin 09 Jan '12

09 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16341 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3170: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2754: Test failed: expected TranslateUrl webbrowser.c:2755: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2756: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2762: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3129: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2847: Test failed: expected RequestUIActivate webbrowser.c:2939: Test failed: Got 0x80004002 webbrowser.c:3137: Test failed: doc != doc2 webbrowser.c:3034: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040CB02

1 0

Re: user32: Add GetListBoxInfo
by Nikolay Sivov 09 Jan '12

09 Jan '12

On 1/9/2012 01:28, Louis Lenders wrote: > This should fix http://bugs.winehq.org/show_bug.cgi?id=27385 > > (See also Remarks on http://msdn.microsoft.com/en-us/library/windows/desktop/bb775208%28v=vs.85%… : This message is equivalent to GetListBoxInfo. > +DWORD WINAPI GetListBoxInfo(HWND hwnd) > +{ > + TRACE("(%p)\n", hwnd); > + return SendMessageW( hwnd, LB_GETLISTBOXINFO, 0, 0); > +} > + Please add a test showing that it really sends a message.

1 0

Re: user32: Add GetListBoxInfo
by Dmitry Timoshkov 09 Jan '12

09 Jan '12

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > +DWORD WINAPI GetListBoxInfo(HWND hwnd) > +{ > + TRACE("(%p)\n", hwnd); > + return SendMessageW( hwnd, LB_GETLISTBOXINFO, 0, 0); > +} The spacing is not consistent. > -# @ stub GetListBoxInfo > +@ stdcall GetListBoxInfo(ptr) Please have a look at other user32 spec file entries for correct type for a window handle. -- Dmitry.

1 0

Re: [4/4] shell32: Fix SHLoadInProc() return value
by Marvin 08 Jan '12

08 Jan '12

1 0

Re: d3drm/tests: Add IDirect3DRM3 tests
by Marvin 06 Jan '12

06 Jan '12

1 0

Re: [1/2] d3drm: Partial implementation for [Add/Delete]Child
by Henri Verbeet 06 Jan '12

06 Jan '12

2012/1/6 André Hentschel <nerv(a)dawncrow.de>: > @@ -212,10 +216,15 @@ static HRESULT WINAPI IDirect3DRMFrame2Impl_AddChild(IDirect3DRMFrame2* iface, > LPDIRECT3DRMFRAME child) > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > + IDirect3DRMFrameImpl *Frame = impl_from_IDirect3DRMFrame2((LPDIRECT3DRMFRAME2)child); That looks pretty questionable, but some tests would probably be a good thing either way.

1 0

Re: [2/4] d3drm: Forward GetTextureCoordinates from IDirect3DRMMeshBuilder3 to IDirect3DRMMeshBuilder2
by Henri Verbeet 06 Jan '12

06 Jan '12

2012/1/6 André Hentschel <nerv(a)dawncrow.de>: > - > - FIXME("(%p)->(%d,%p,%p): stub\n", This, index, u, v); > - > - return E_NOTIMPL; > + return IDirect3DRMMeshBuilder_GetTextureCoordinates(&This->IDirect3DRMMeshBuilder2_iface, > + index, u, v); > } I'm not going to say you can't do it like this, but it can often be pretty useful to know what version of an interface you were called from. Also, usually we implement older versions of interfaces on top of the new ones, instead of the other way around.

2 1

Re: [PATCH 4/5] ieframe: Added IHTMLWindow2 service tests
by Marvin 06 Jan '12

06 Jan '12

2 1

Re: msvcp90: add basic_ios<wchar_t> stubs
by Piotr Caban 06 Jan '12

06 Jan '12

On 01/05/12 22:41, Daniel Lehman wrote: +/* ?imbue@?$basic_ios@_WU?$char_traits@_W@std@@@std@@QAE?AVlocale@2@ABV32@@Z */ +/* ?imbue@?$basic_ios@_WU?$char_traits@_W@std@@@std@@QEAA?AVlocale@2@AEBV32@@Z */ +DEFINE_THISCALL_WRAPPER(basic_ios_wchar_imbue, 4) +locale __thiscall basic_ios_wchar_imbue(basic_ios_wchar *this) +{ + locale ret = { NULL }; + FIXME("(%p) stub\n", this); + return ret; +} This should look like: locale* __thiscall basic_ios_wchar_imbue(basic_ios_wchar *this, locale *ret) there's similar mistake in basic_ios_char_imbue.

1 0

Re: mshtml: Remove unused definitions
by Jacek Caban 06 Jan '12

06 Jan '12

Hi André, On 01/05/12 19:35, André Hentschel wrote: > --- > dlls/mshtml/resource.h | 17 ----------------- > 1 files changed, 0 insertions(+), 17 deletions(-) > > diff --git a/dlls/mshtml/resource.h b/dlls/mshtml/resource.h > index 50342a2..a798760 100644 > --- a/dlls/mshtml/resource.h > +++ b/dlls/mshtml/resource.h > @@ -38,23 +38,6 @@ > > #define IDR_BROWSE_CONTEXT_MENU 24641 > > -#define IDM_TRACETAGS 6004 > -#define IDM_RESOURCEFAILURES 6005 > -#define IDM_DUMPTRACKINGINFO 6006 > -#define IDM_DEBUGBREAK 6007 > -#define IDM_DEBUGVIEW 6008 > -#define IDM_DUMPTREE 6009 > -#define IDM_DUMPLINES 6010 > - > -#define IDM_SAVEHTML 6012 > -#define IDM_MEMORYMONITOR 6013 > -#define IDM_PERFORMANCEMETERS 6014 > -#define IDM_DUMPDISPLAYTREE 6015 > -#define IDM_DUMPFORMATCACHES 6016 > -#define IDM_DUMPLAYOUTRECTS 6017 > - > -#define _IDM_REFRESH 6042 > - > #define IDD_HYPERLINK 8000 > > #define IDC_URL 9001 > These defines are for stuff that is in shdoclc and mshtml uses these resources. Although we currently don't use them currently, ideally we should implement them. It doesn't make sense to remove them now and add back in the future. Jacek

1 0

Re: [PATCH 2/2] winmm/tests: Test some inconsistent WAVEFORMAT descriptions.
by Marvin 06 Jan '12

06 Jan '12

2 1

Re: [PATCH 1/5] ddraw/tests: Add some clipper tests.
by Alexandre Julliard 05 Jan '12

05 Jan '12

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/ddraw/tests/ddraw1.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw2.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw4.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw7.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 866 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddraw1.c && touch ddraw1.ok ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. ddraw1.c:231: Test succeeded inside todo block: Got unexpected clip rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. make: *** [ddraw1.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 3

Any bad side-effects from not building with HAL if udisks is enabled?
by Scott Ritchie 05 Jan '12

05 Jan '12

Assuming udisks support exists on the system, anything wrong with this? Does the new udisks do everything HAL used to do? Thanks, Scott Ritchie

2 2

Re: msvcrt: make WEOF returned from swscanf signed (try 2)
by Marvin 05 Jan '12

05 Jan '12

1 0

D3DXHANDLE for ID3DXConstantTable
by Rico Schüller 05 Jan '12

05 Jan '12

Hi, I'd like to get up the discussion for the D3DXHANLE in the ID3DXConstantTable again. There were several tries in the past, but there wasn't made a decision for one solution. My opinion about the handles is, that they have to allow at least the following options: 1. D3DXHANDLEs have to be global (not local to a ID3DXConstantTable), so the way the effect interface does it is not an ideal option for the ID3DXConstantTable 2. D3DXHANDLEs could also be strings and thus it is a requirement that this could be detected (at least for !D3DXCONSTTABLE_LARGEADDRESSAWARE) Ideally we may handle all D3DXHANDLEs the same way. Some possible solutions are listed in [3]. Any thoughts which way is preferred? Cheers Rico References: [1] http://www.winehq.org/pipermail/wine-devel/2010-April/082900.html [2] http://www.winehq.org/pipermail/wine-patches/2011-July/104325.html [3] http://www.winehq.org/pipermail/wine-devel/2011-July/091091.html

2 8

Re: [PATCH] msvcp60: Avoid a crash, when the ptr in basic_string_char is NULL
by Piotr Caban 05 Jan '12

05 Jan '12

Hi, > void __thiscall basic_string_char__Eos(basic_string_char *this, MSVCP_size_t len) > { > - this->size = len; > - this->ptr[len] = 0; > + if (this->ptr) { > + this->size = len; > + this->ptr[len] = 0; > + } > } This function should not be called if this->ptr is NULL. The bug is somewhere else. I'll take a look on it. Do you have a backtrace? Piotr

1 0

Re: msvcrt: make WEOF returned from swscanf signed
by Marvin 05 Jan '12

05 Jan '12

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2012