wine-devel February 2012

wine-devel@winehq.org

77 participants
169 discussions

Re: msvcrt/file.c: file mode T (temporary file) (try 2)
by Vitaliy Margolen 26 Feb '12

26 Feb '12

On 02/25/2012 05:30 AM, Robert van Herk wrote: > Try 2 fixes some blatant memory bug in the conformance test > --------------------------------------------------------------------------- > > Windows fopen has some fancy file modes 'T' and 'D'. > Currently, wine wrongly interprets 'T' as 't'. They should be interpreted > differently though: 't' is text file, and 'T' is temporary file. > > I've fixed this, and added a conformance test. > + case 'T': > + FIXME("Implement T flag (temporary file, i.e. delete on close, don't flush to disk if possible)"); > + break; So what actually prevents you from properly implementing this? Especially that Wine already supports temporary files. Search for MSVCRT__O_TEMPORARY Vitaliy.

2 1

Spaces in the Korean translation.
by Francois Gouget 26 Feb '12

26 Feb '12

I noticed some leading and trailing space issues in the Korean translation. I think these are probably safe to change. However I then noticed that there was a lot of sentences mixed single and double spaces. So I wonder if that's normal, maybe tied to a Korean typography rule related to half vs. full width characters; or if only single or double spaces should be present. Here are a few examples: "주의: 이 파일 형식은 아마도 하나 이상의 인증서,인증서 파기 목록,인증서 신뢰 " ^^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ "목록을 가지고 있을 수 있음:" ^ ^ ^ ^ msgstr "'여기로부터'엔트리는 여기까지'엔트리에 도달 할 수 없습니다." ^^ ^ ^ ^ ^ msgstr "대기열에는 %d의 문서가 존재합니다" ^^ ^ ^ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

1 0

Re: sk.po
by Francois Gouget 26 Feb '12

26 Feb '12

Thanks for the translation updates. I noticed some potential issues while proofreading it: "to modify its installed components, select it from the list and click Change/" "Remove." msgstr "" +"Nasledujúci program môže byť automaticky odinštalovaný. K odstráneniu programu " +"alebo k modifukácii jeho inštalovaných súčastí, zvoľte možnosť zo zoznamu a kliknite " +"Zmeniť/Odstrániť" There should probably be a trailing full stop. msgid "Publisher:" -msgstr "" +msgstr "Vydavateľ" msgid "Version:" -msgstr "" +msgstr "Verzia" These are missing the trailing colon (these are likely field labels in a dialog). msgid "&Settings..." -msgstr "" +msgstr "&Nastavenia" #, fuzzy msgid "&Modify..." -msgstr "Modifikovaný" +msgstr "&Zmeniť" #, fuzzy msgid "&Install" -msgstr "&Skomentovať..." +msgstr "&Inštalovať..." These are either missing the trailing ellipsis or have one that should not be there. Ellipses are very important because, for instance, they make all the difference between a 'Print' button that will send the page to the default printer right away, and a 'Print...' button that will first display a dialog that will let you choose the destination printer or cancel before anything happens. Note that I did not list all ellipsis issues here. Also this is one of the points that my script checks so you'll see any ellipsis issue in Wine's PO file there: http://fgouget.free.fr/wine-po/sk-errors.html #, fuzzy msgid "Unexpected network error.\n" -msgstr "Nedefinovaná externá chyba." +msgstr "Nedefinovaná sieťová chyba." This translation should have a trailing linefeed. Also I notice that you did not remove the 'fuzzy' flag, not only here but also for quite a few other translations, including two others above. The fuzzy flag indicates that the translation is potentially incomplete or incorrect and thus requires more work or a review. So as long as it is present the translation will not be used. Keep up the good work. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

1 0

Re: shlwapi: Implemented StrToInt64ExA/W
by Marvin 26 Feb '12

26 Feb '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17105 Your paranoid android. === W2KPROSP4 (32 bit string) === Timeout

1 0

Re: shlwapi: Implemented StrToInt64ExA/W
by Nikolay Sivov 25 Feb '12

25 Feb '12

On 2/25/2012 17:49, carlo.bramix(a)libero.it wrote: > I tried to implement StrToInt64ExA/W as a reply to bug #27633 > I also corrected the comment in functions FormatInt() and FormatDouble() > because, according to MSDN, GetNumberFormat() returns the number of characters > written (or required) and not the number of bytes emitted: > http://msdn.microsoft.com/en-us/library/windows/desktop/dd318110%28v=vs.85%…. > aspx > I hope my first patch to WINE is correct and it could be useful. > Sincerely, > > Carlo Bramini. > > > > BOOL WINAPI StrToIntExA(LPCSTR lpszStr, DWORD dwFlags, LPINT lpiRet) > { > + LARGE_INTEGER li; > + BOOL bRes; > + > + TRACE("(%s,%08X,%p)\n", debugstr_a(lpszStr), dwFlags, lpiRet); > + > + // Test on lpszStr is done into StrToInt64ExA No cpp comments please. Also this comment is a bit redundant for a function that small. > + if (!lpiRet) > + { > + WARN("Invalid lpiRet would crash under Win32!\n"); > + return FALSE; > + } You don't need to WARN on that, especially with such message. > + > + bRes = StrToInt64ExA(lpszStr, dwFlags,&li.QuadPart); > + if (bRes) > + *lpiRet = li.u.LowPart; > + > + return bRes; > +} This needs tests, take a look at shlwapi/tests for some examples.

1 0

Re: msvcrt/file.c: file mode T (temporary file)
by Nikolay Sivov 25 Feb '12

25 Feb '12

On 2/25/2012 00:19, Robert van Herk wrote: > Windows fopen has some fancy file modes 'T' and 'D'. > Currently, wine wrongly interprets 'T' as 't'. They should be > interpreted differently though: 't' is text file, and 'T' is temporary > file. > > I've fixed this, and added a conformance test. > > Test ran on Windows 7 Home Premium. > > Kind regards, > Robert > > dlls/msvcrt/file.c | 8 +++++- > dlls/msvcrt/tests/Makefile.in | 1 + > dlls/msvcrt/tests/filemodeT.c | 61 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 69 insertions(+), 1 deletions(-) > create mode 100644 dlls/msvcrt/tests/filemodeT.c You clearly don't need a new file for that, please place it into existing file.c.

1 0

Re: msvcrt/file.c: file mode T (temporary file)
by Marvin 25 Feb '12

25 Feb '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17097 Your paranoid android. === WNT4WSSP6 (32 bit filemodeT) === filemodeT: unhandled exception c0000005 at 780109BF === WXPPROSP3 (32 bit filemodeT) === filemodeT: unhandled exception c0000005 at 77C41165

1 0

Re: po: Update Chinese (Taiwan) translation.
by Francois Gouget 24 Feb '12

24 Feb '12

Thanks for the translation update. It's a big one. There are pretty few issues given the size: msgid "&Modify..." -msgstr "" +msgstr "�޸�(&M)" The translation is missing the ellipsis here. msgid "" "This value does not lie within the page range.\n" "Please enter a value between %1!d! and %2!d!." msgstr "" -"�@��ֵ��퓔��\n" -"Ոݔ��һ�� %d �� %d ֮�g�Ĕ��" +"ݔ��ֵ��퓔��ȡ�\n" +"Ոݔ��һ�� %d �� %d ֮�g��ֵ��" The formatting directives should match. There's been quite a few changes of that type that had the goal of making it possible to reorder them so there may be other places with the same issue. #, fuzzy msgid "Write fault.\n" -msgstr "Ĭ�J��\n" +msgstr "�A�O��\n" #, fuzzy msgid "Read fault.\n" -msgstr "Ĭ�J��\n" +msgstr "�A�O��\n" ... Is it normal that you did not remove the fuzzy on this series of messages? (Maybe they need further review?) -#, fuzzy msgid "By &Type" msgstr "��" #: shell32.rc:52 -#, fuzzy msgid "By &Size" msgstr "��С" Should preserve the keyboard shortcut? -#, fuzzy msgid "LoadTypeLib( %1 ) failed ($%2!x!)" msgstr "LoadTypeLib( %s ) ʧ�� ($%x)" The format directives also need an update on this one. msgid "&New override for library:" -msgstr "��ʽ��(&N)��" +msgstr "��ʽ�츲�d(&N):" msgid "Existing &overrides:" -msgstr "��еĺ�ʽ��(&o)��" +msgstr "��еĺ�ʽ�츲�d(&O)��" I see that you replaced some full width colons with their half-width equivalent but not everywhere. What is the common practice there? As far as I know for full stops it's the full-width character that is used. However for characters like colons, question marks and exclamation points I don't know (looking at Windows 7 dialogs did not help there). msgid "Full &Path:" -msgstr "" +msgstr "��·��(P):" This one is missing the ampersand. That's the only such case as far as I can tell. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Dieu dit: "M-x Lumi��re". Et la lumi��re fut.

2 1

Removing 'all' platform/os from bugzilla
by Austin English 23 Feb '12

23 Feb '12

Howdy, We seem to discourage use of the use of 'all' platform/os on bugzilla. While I personally am not opposed to it, in cases where it's obviously true (e.g., http://bugs.winehq.org/show_bug.cgi?id=29901), changing these fields causes unnecessary spam. It would be easier, imho to remove them. Does anyone have any opposition to this? I'm intending to leave 'other', of course. -- -Austin

2 2

Obscure texts and invalid translations
by Lauri Kenttä 23 Feb '12

23 Feb '12

Hi, Wine has many texts, especially error messages, that are almost impossible to translate without knowing what they're really about. Some are also easy to misunderstand. An example from dlls/kernel32/winerror.mc: msgid "Notify change request in progress.\n" Some interpretations: de, nb: "A request for notifications about changes is in progress." fr, sv: "A request to change a notification is in progress." it, pt: Both have their own versions, I think. There are many more such cases, although the difference is usually in only one or two languages. (Unfortunately it didn't occur to me to put them down from the beginning, so I can't give you a list. I'll just mention "Challenge Password" before I forget that, too.) 1) What should I do if I wanted to clarify a msgid? Just change the original .rc file? 2) Is there a way to add helpful comments to all language files at once without changing the msgid? 3) What should I do if I spot a suspicious translation? Spam the Bugzilla, contact the Last-Translator personally, or send patches to add #fuzzy comments and hope I'm right? And if it's wrong in many of the languages I can read, it's probably wrong in some others as well; who would check them all? 4) There has been discussions about some translation websites. Is there a chance that such a website would allow easy tagging of potential errors? -- Lauri Kenttä

3 5

← Newer
1
2
3
4
5
6
7
8
9
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel February 2012