April 2012 - wine-devel

Re: [PATCH 4/4] jscript: Added Number.toPrecision implementation
by Marvin 19 Apr '12

19 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17957 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] jscript: Added Number.toExpontential implementation
by Marvin 19 Apr '12

19 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17956 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] jscript: Added Number.toFixed implementation
by Marvin 19 Apr '12

19 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17955 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] ws2_32: Revise AcceptEx behavior to send completions for canceled sockets (resend 3, deferred).
by Alexandre Julliard 19 Apr '12

19 Apr '12

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > @@ -256,10 +256,12 @@ void async_set_result( struct object *obj, unsigned int status, unsigned int tot > else > { > if (async->timeout) remove_timeout_user( async->timeout ); > + if (async->completion && async->data.cvalue && status != STATUS_ALERTED) > + add_completion( async->completion, async->comp_key, async->data.cvalue, status, total ); > + else if (async->completion && async->data.cvalue && status == STATUS_ALERTED) > + status = STATUS_SUCCESS; This looks pretty hackish, the server shouldn't have to care about the status values or patch them up for the client. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wininet: Add a new common module information struct
by Piotr Caban 18 Apr '12

18 Apr '12

On 04/16/12 22:03, Morten Rønne wrote: > Add a new common module information struct for urlcache and functions to > do initialization of the struct. This is intended to be a new way to > more easily create Ansi and Unicode version of the functions, by doing a > Ansi/Unicode preamble code that calls a common worker function that do > the real work. Is there any reason not to call Ansi function inside Unicode function? (This is the other way then it is done in most parts of wine, the reason for this is that urlcache stores ansi strings internally. Unicode urls should probably be converted using punycode encoding (IdnToAscii?)). This patch is also introducing lots of unneeded Ansi/Unicode conversions. I'm not sure if storing all url entry related information inside a structure makes anything easier/more readable. Especially when you need to make sure that a field is initialized before accessing it.

2 1

Re: [PATCH 1/2] wininet: Update structs with more information in preparation for implementation of more functionality.
by Piotr Caban 18 Apr '12

18 Apr '12

On 04/16/12 22:00, Morten Rønne wrote: + DWORD AllocationTable[0xF6C]; There are defines describing allocation table size. It's better to define it as BYTE AllocationTable[ALLOCATION_TABLE_SIZE];

2 1

Patch 85420
by Christian Costa 18 Apr '12

18 Apr '12

Hi, Patch http://source.winehq.org/patches/data/85420 is marked as pending. I've taken a look but I still don't understand what's wrong. Is there anything I've missed ? Thanks Christian

3 3

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending. Resend.
by Dmitry Timoshkov 18 Apr '12

18 Apr '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > This patch makes printing of PNG and other images work from applications > which use gdiplus for that. > > Printer drivers can't support transparency or alpha blending in any way. > This patch was tested with wide range of images (some mixed with other > graphics and text), and output matches what native gdiplus does. Is there anything else I could provide in helping to get this patch accepted? -- Dmitry.

2 2

Re: mshtml: Copy filter value in HTMLElement_clone
by Marvin 18 Apr '12

18 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17938 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] wininet: Add a new common module information struct
by Jacek Caban 18 Apr '12

18 Apr '12

Hi Morten, On 04/16/12 22:03, Morten Rønne wrote: > typedef struct _HASH_CACHEFILE_ENTRY > { > CACHEFILE_ENTRY CacheFileEntry; > DWORD dwAddressNext; > DWORD dwHashTableNumber; > - struct _HASH_ENTRY HashTable[HASHTABLE_SIZE]; > -} HASH_CACHEFILE_ENTRY; > + HASH_ENTRY HashTable[HASHTABLE_SIZE]; > +} HASH_CACHEFILE_ENTRY, *LPHASH_CACHEFILE_ENTRY; > > typedef struct _DIRECTORY_DATA > { > @@ -187,13 +187,56 @@ typedef struct _URLCACHECONTAINER > HANDLE hMapping; /* handle of file mapping */ > DWORD file_size; /* size of file when mapping was opened */ > HANDLE hMutex; /* handle of mutex */ > -} URLCACHECONTAINER; > +} URLCACHECONTAINER, *LPURLCACHECONTAINER; Please don't use this kind of defined. LP* types make the code less readable for no good reason. Cheers, Jacek

1 0

Re: [PATCH 2/2] jscript: Correctly handle empty matches in String.replace
by Marvin 18 Apr '12

18 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17935 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [7/7] server: Propagate an error code returned by token_access_check() to the client. Resend.
by Marvin 18 Apr '12

18 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17934 Your paranoid android. === TEST64_W7SP1 (32 bit sync) === sync.c:924: Test failed: ChangeTimerQueueTimer

1 0

SymEnumSymbolsForAddr in dbghelp.dll
by Roger Cruz 18 Apr '12

18 Apr '12

I wrote a simple piece of code that uses dbghelp.dll's SymEnumSymbolsForAddr() but when I went to search for its code in Wine, it looks to be missing. The dbghelp.spec has that function listed as "stub". What does stub mean in this context? Does it mean the function is not implemented? Are there any plans to? Thanks Roger R. Cruz

2 4

Re: wsnmp32: New stub dll (resend)
by Alexandre Julliard 17 Apr '12

17 Apr '12

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -0,0 +1,49 @@ > +# imported from D-Link EMS by ordinal > +320 stub SnmpSetPort > +# > +@ stub SnmpCancelMsg > +@ stub SnmpCleanup > +@ stub SnmpClose > +@ stub SnmpContextRoStr > +@ stub _SnmpConveyAgentAddress > +@ stub SnmpCountVbl > +@ stub SnmpCreatePdu > +@ stub SnmpCreateSession > +@ stub SnmpCreateVbl > +@ stub SnmpDecodeMsg > +@ stub SnmpDeleteVb > +@ stub SnmpDuplicatePdu > +@ stub SnmpDuplicateVbl > +@ stub SnmpEncodeMsg > +@ stub SnmpEntityTpStr > +@ stub SnmpFreeContext > +@ stub SnmpFreeDescriptor > +@ stub SnmpFreeEntity > +@ stub SnmpFreePdu > +@ stub SnmpFreeVbl > +@ stub SnmpGetLastError > +@ stub SnmpGetPduData > +@ stub SnmpGetRetransmitMode > +@ stub SnmpGetRetry > +@ stub SnmpGetTimeout > +@ stub SnmpGetVb > +@ stub SnmpGetVendorInfo > +@ stub SnmpListen > +@ stub SnmpOidCompare > +@ stub SnmpOidCopy > +@ stub SnmpOidToStr > +@ stub SnmpOpen > +@ stub SnmpRecvMsg > +@ stub SnmpRegister > +@ stub SnmpSendMsg > +@ stub _SnmpSetAgentAddress > +@ stub SnmpSetPdu > +@ stub SnmpSetRetransmitMode > +@ stub SnmpSetRetry > +@ stub SnmpSetTimeout > +@ stub SnmpSetTranslateMode > +@ stub SnmpSetVb > +@ stub SnmpStartup > +@ stub SnmpStrToContext > +@ stub SnmpStrToEntity > +@ stub SnmpStrToOid They should probably all be ordinals, also some of the names are wrong. -- Alexandre Julliard julliard(a)winehq.org

1 0

New forum software
by Vitaliy Margolen 17 Apr '12

17 Apr '12

Can I ask when we'll have the new forum software installed? It's been discussed ages ago and we still using the same old crappy version. Vitaliy.

4 4

Re: gdi32/dibdrv: don't add_join if points are coincident in wide_line_segments (try 2)
by Alexandre Julliard 17 Apr '12

17 Apr '12

Daniel Lehman <dlehman(a)esri.com> writes: > Was mistakenly sent to wine-devel > > try 2 - integrate into existing tests; updated commit message > > I think the only points in the middle of the points array can cause > the crash I was seeing. wide_pen_lines trims coincident points/empty > segments from the beginning and end of the array, so the > wine_line_segment calls before and after the for loop I modified will > always return valid faces It doesn't work here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so dib.c && touch dib.ok dib.c:1324: Test failed: 8888: wide pen - empty segments: expected hash 5bac9c515315bced1ac5cb46a771690d02040278 got 56cc0584aaeb790419b343dae0ea09591c384ac4 dib.c:1324: Test failed: 8888 - bitfields: wide pen - empty segments: expected hash 5bac9c515315bced1ac5cb46a771690d02040278 got 56cc0584aaeb790419b343dae0ea09591c384ac4 dib.c:1324: Test failed: a8b8g8r8: wide pen - empty segments: expected hash 1aa5e414c797fd74fe1400757548ef79650fe994 got ee5a5dc02ec61af2462c265424943049ea7c23eb dib.c:1324: Test failed: r10g10b10: wide pen - empty segments: expected hash 65f7fc7219e7cc29d20aeab7d38a60ac6c303726 got d7ee8801ea0c3e7cf012153b77bd7ba9b388f459 dib.c:1324: Test failed: r6g6b6: wide pen - empty segments: expected hash b1e3aeac484f49b1874033509924627ef0a4c3bc got 906c2d8da24180ccbe84fd4fd5ba964d8f9a3a44 dib.c:1324: Test failed: 24: wide pen - empty segments: expected hash f11f301314f9729ab351294a4d8a72b72fc2491d got 9433b11e4190cf1d77f4b84017e8561884ccd73c dib.c:1324: Test failed: r5g5b5: wide pen - empty segments: expected hash ffa75c684138fdb296f4001e2dc36ed1ae33065b got e141eb6b73e91eb2e4b5fd31688084d4b4c70d30 dib.c:1324: Test failed: r4g4b4: wide pen - empty segments: expected hash 9aa687dc13503e3ff4e12e67c361ca140cbdb48d got 27afb67bda17491c7806f1a42650deb9d47bba71 dib.c:1324: Test failed: 8 color: wide pen - empty segments: expected hash 7897ba51f37e01c6a54a2733459e79285b52d213 got d905bc3cd08fc4a7110608ec8b80e494077e859e dib.c:1324: Test failed: 8 grayscale: wide pen - empty segments: expected hash 88eb0c6542a2c03036241cdb5e08f13401a92f31 got bef8347c9bc96d709aaf002fcf6b4da66e5267e7 dib.c:1324: Test failed: 8: wide pen - empty segments: expected hash 00b34f58bb4876b597fad1a275bccb2c9a95967b got 3f318b982da1b8d26eff59ed8c6d7ce6a84f857a dib.c:1324: Test failed: 4: wide pen - empty segments: expected hash 9b5ecb81cf32c34c43cb13310e4b479b6909f3ec got 10271cb9b746fb9b507a9322c16f1279deb69a95 dib.c:1324: Test failed: 4 grayscale: wide pen - empty segments: expected hash 048ce4615962675d66b648631dc556238a86b4df got 9cf16c3165ac241aa6fb50bb0a05c3548fbaeb43 dib.c:1324: Test failed: 1: wide pen - empty segments: expected hash 1dde794388a3ca3ac710acc0aff97f7df70687e5 got e203905ad4c0a609b5ac78e66714b66ffe792b8b make[1]: *** [dib.ok] Error 14 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/4] server: Add access mapping for a named pipe device object, adjust its default access rights. Resend.
by Alexandre Julliard 17 Apr '12

17 Apr '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -238,7 +238,7 @@ static const struct object_ops named_pipe_device_ops = > no_satisfied, /* satisfied */ > no_signal, /* signal */ > named_pipe_device_get_fd, /* get_fd */ > - no_map_access, /* map_access */ > + named_pipe_map_access, /* map_access */ > default_get_sd, /* get_sd */ > default_set_sd, /* set_sd */ > named_pipe_device_lookup_name, /* lookup_name */ > @@ -270,10 +270,10 @@ static void named_pipe_dump( struct object *obj, int verbose ) > > static unsigned int named_pipe_map_access( struct object *obj, unsigned int access ) > { > - if (access & GENERIC_READ) access |= STANDARD_RIGHTS_READ; > + if (access & GENERIC_READ) access |= STANDARD_RIGHTS_READ | FILE_READ_ATTRIBUTES; > if (access & GENERIC_WRITE) access |= STANDARD_RIGHTS_WRITE | FILE_CREATE_PIPE_INSTANCE; > if (access & GENERIC_EXECUTE) access |= STANDARD_RIGHTS_EXECUTE; > - if (access & GENERIC_ALL) access |= STANDARD_RIGHTS_ALL; > + if (access & GENERIC_ALL) access |= STANDARD_RIGHTS_ALL | FILE_READ_ATTRIBUTES | FILE_CREATE_PIPE_INSTANCE; > return access & ~(GENERIC_READ | GENERIC_WRITE | GENERIC_EXECUTE | GENERIC_ALL); Why do you need this for the device? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 2/3] Added support for shadowing of element pseudo-variables
by Marvin 17 Apr '12

17 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17915 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [4/4] server: Propagate an error code returned by token_access_check() to the client. Resend.
by Marvin 17 Apr '12

17 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17912 Your paranoid android. === W7PROX64 (64 bit sync) === sync.c:923: Test failed: DeleteTimerQueueTimer sync.c:924: Test failed: ChangeTimerQueueTimer

2 1

Re: kernel32: Add more memory access checks.
by Marvin 17 Apr '12

17 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17913 Your paranoid android. === TEST64_W7SP1 (64 bit virtual) === virtual.c:854: Test failed: got size 0x100000 virtual.c:935: Test failed: got size 0x100000

1 0

Re: [3/4] server: Perform an access check for kernel objects without a security descriptor using access rights of the owner'
by Marvin 17 Apr '12

17 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17911 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:923: Test failed: DeleteTimerQueueTimer

2 1

[shlwapi] Add NULL checks to StrCpyW and StrCatW
by carlo.bramix＠libero.it 16 Apr '12

16 Apr '12

Hello friends, according to these results, it looks like the test I added in the patch crashes win2k SP4 but it works on all others. And it does not seem to be a thing that it can be resolved with dynamic library loading. So, what should I do? Do I need to comment them like it has been done (for example) into test_StrChrA()? Do I need to remove interely the test and revive previous patch? Please excuse my inexperience... Sincerely, Carlo Bramini. >----Messaggio originale---- >Da: testbot(a)testbot.winehq.org >Data: 16/04/2012 22.48 >A: <carlo.bramix(a)libero.it> >Ogg: TestBot job 17900 results: [shlwapi] Add NULL checks to StrCpyW and StrCatW > >VM Status Number of test failures >WINEBUILD completed >WNT4WSSP6 completed 0 >W2KPROSP4 completed 1 >WXPPROSP3 completed 0 >W2K3R2SESP2 completed 0 >WVISTAADM completed 0 >W2K8SE completed 0 >W7PRO completed 0 >W7PROX64 completed 0 >TEST64_W7SP1 completed 0 >W7PROX64 completed 0 >TEST64_W7SP1 completed 0 > >=== WINEBUILD (build) === >No build failures found > >=== WNT4WSSP6 (32 bit string) === >No test failures found > >=== W2KPROSP4 (32 bit string) === > >shlwapi: >string: unhandled exception c0000005 at 77C7F8A8 > >=== WXPPROSP3 (32 bit string) === >No test failures found > >=== W2K3R2SESP2 (32 bit string) === >No test failures found > >=== WVISTAADM (32 bit string) === >No test failures found > >=== W2K8SE (32 bit string) === >No test failures found > >=== W7PRO (32 bit string) === >No test failures found > >=== W7PROX64 (32 bit string) === >No test failures found > >=== TEST64_W7SP1 (32 bit string) === >No test failures found > >=== W7PROX64 (64 bit string) === >No test failures found > >=== TEST64_W7SP1 (64 bit string) === >No test failures found

1 0

Re: [shlwapi] Add NULL checks to StrCpyW and StrCatW
by Marvin 16 Apr '12

16 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17900 Your paranoid android. === W2KPROSP4 (32 bit string) === string: unhandled exception c0000005 at 77C7F8A8

1 0

Re: [PATCH] winealsa.drv: Init *num to 0 (Coverity)
by Andrew Eikum 16 Apr '12

16 Apr '12

On Mon, Apr 16, 2012 at 09:09:58AM +0200, Marcus Meissner wrote: > Also initialize a "may be uninitialized" value the compiler sees. > Not sure what this means. *num is initialized at the beginning of alsa_enum_devices, which is always called from GetEndpointIDs. Seems like a Coverity oversight. I'd either leave it as-is, or also remove the *num=0 from alsa_enum_devices. Andrew > Ciao, Marcus > --- > dlls/winealsa.drv/mmdevdrv.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index e3c1d15..d84bbb2 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -345,7 +345,7 @@ static WCHAR *construct_device_id(EDataFlow flow, const WCHAR *chunk1, const cha > { > WCHAR *ret; > const WCHAR *prefix; > - DWORD len_wchars = 0, chunk1_len, copied = 0, prefix_len; > + DWORD len_wchars = 0, chunk1_len = 0, copied = 0, prefix_len; > > static const WCHAR dashW[] = {' ','-',' ',0}; > static const size_t dashW_len = (sizeof(dashW) / sizeof(*dashW)) - 1; > @@ -583,6 +583,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, GUID **guids, > > TRACE("%d %p %p %p %p\n", flow, ids, guids, num, def_index); > > + *num = 0; > *ids = NULL; > *guids = NULL; > > -- > 1.7.3.4 > > >

2 2

Re: msvcrt: Added more length modifiers in scanf function
by Marvin 16 Apr '12

16 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17893 Your paranoid android. === WNT4WSSP6 (32 bit scanf) === scanf.c:144: Test failed: sprintf retuned 10 scanf.c:145: Test failed: got 1942892530, expected 12345678901234 === W2KPROSP4 (32 bit scanf) === scanf.c:144: Test failed: sprintf retuned 10 scanf.c:145: Test failed: got 1942892530, expected 12345678901234 === WXPPROSP3 (32 bit scanf) === scanf.c:144: Test failed: sprintf retuned 10 scanf.c:145: Test failed: got 1942892530, expected 12345678901234 === W2K3R2SESP2 (32 bit scanf) === scanf.c:144: Test failed: sprintf retuned 10 scanf.c:145: Test failed: got 1942892530, expected 12345678901234

1 0

Re: ws2_32: Fix hostent memory allocation
by Alexandre Julliard 16 Apr '12

16 Apr '12

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -5546,24 +5546,70 @@ INT WINAPI WSAUnhookBlockingHook(void) > * pointers (via a template of some kind). > */ > > -static int list_size(char** l, int item_size) > +/*********************************************************************** > + * list_size (INTERNAL) > + * > + * Calculate the size of data and number of items from a list based on > + * a fixed item size or strings by using strlen. The source list must be > + * NULL terminated. > + * > + * PARAMS > + * l [I] Pointer to array of source items. > + * item_size [I] Fixed item size or zero if it's a string list. > + * size_sum [O] Pointer to where the sum of item bytes will be > + * stored. May be NULL if not required by the caller. > + * item_count [O] Pointer to where the number of items bytes will be > + * stored. May be NULL if not required by the caller. > + * > + * NOTES > + * When item_size is zero the byte sum will also count the NULL > + * terminator for each string. > + */ > +static void list_size(char** l, int item_size, int *size_sum, int *item_count) > { > - int i,j = 0; > - if(l) > - { for(i=0;l[i];i++) > - j += (item_size) ? item_size : strlen(l[i]) + 1; > - j += (i + 1) * sizeof(char*); } > - return j; > + int s, c, *sum = (size_sum ? size_sum : &s), *count = (item_count ? item_count : &c); > + *sum = *count = 0; > + if(l) > + { > + for(;l[*count];(*count)++) > + *sum += (item_size) ? item_size : strlen(l[*count]) + 1; > + } That's not a good helper function, with all the optional parameters and various behaviors. Also if you need a big documentation block like this for a 5-line function it's a sign that something is wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

WASAPI ISimpleAudioVolume::SetMasterVolume appears to not work
by adam smith 16 Apr '12

16 Apr '12

Hi, I've been trying to get WASAPI audio output working for our app as Directsound output was very glitchy post the new audio stack. All seems to work great with WASAPI however I need to able to set the volume level independently for individual audio sessions / streams for crossfading however I'm having problems controlling the volume levels of a shared mode audio session / stream. specifically, ISimpleAudioVolume::SetMasterVolume http://msdn.microsoft.com/en-us/library/windows/desktop/dd316537(v=vs.85).a… Doesn't seem to work under Wine i.e. HRESULT hr; hr=audioClient_->GetService(IID_ISimpleAudioVolume,(void**)&simpleAudioVolume_); if (SUCCESS(hr)) hr=simpleAudioVolume_->SetMasterVolume(0.1,NULL); returns success but does not change the volume level though interestingly HRESULT hr; hr=audioClient_->GetService(IID_ISimpleAudioVolume,(void**)&simpleAudioVolume_); if (SUCCESS(hr)) hr=simpleAudioVolume_->SetMute(TRUE,NULL); does work and mute the volume. I've also tried usingsthe IAudioStreamVolume interface to control the volume again to no avail. Does anyone have any experience of these interfaces or know equivalent interfaces to use instead working I've tested on : Ubuntu 10.04, 11.10 Wine 1.4 , 1.5 , 1.5.2 PulseAudio 0.9.21 , 1.0 , no pulse audio (and windows 7 where the code works fine) Thanks, Adam

2 1

Re: jscript: Make sure to jump out of switch before entering implicit default clausule
by Marvin 16 Apr '12

16 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17883 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Testbot certificate has expired
by Morten Rønne 16 Apr '12

16 Apr '12

Hi testbot.winehq.com certificate expired on 13-04-2012. So now the wininet tests in dlls/wininet/tests/http.c are failing with an error for me. I can't determine if the fault are in the test or the function called should handle the error case. The error message is: err:wininet:NETCON_secure_connect SSL_connect failed: 12037 http.c:2873: Test failed: HttpSendRequest failed: 12037 wine: Unhandled page fault on read access to 0x00000008 at address 0x68a876c5 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x68a876c5). Best Regards Morten Rønne

2 1

Re: gdi32: Add support for emulating bold faces of bitmap fonts.
by Huw Davies 16 Apr '12

16 Apr '12

On Mon, Apr 16, 2012 at 04:37:39PM +0900, Dmitry Timoshkov wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 0a5d3c3..eb3f9b5 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -5669,12 +5669,27 @@ static inline BYTE get_max_level( UINT format ) > return 255; > } > > -static const BYTE masks[8] = {0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01}; > +static void emulate_bold_glyph(BYTE *buf, int pitch, int height) > +{ > + int x, y; > + BYTE *p = buf; > + > + for (y = 0; y < height; y++) > + { > + for (x = pitch - 1; x >= 0; x--) > + { > + p[x] |= p[x] >> 1; > + if (x > 0) p[x] |= p[x - 1] << 7; > + } > + p += pitch; > + } > +} > Don't we need to add some bytes if glyph_width % 32 == 0 ? Huw.

2 3

Re: msvcp90: Add codecvt ctors and dtors
by Piotr Caban 16 Apr '12

16 Apr '12

Hi, On 04/16/12 02:50, William Panlener wrote: > typedef struct { > + locale_facet facet; > + /* FIXME: type definition in standard but var here */ > + enum { ok, partial, error, noconv } result; > +} codecvt_base; This structure has incorrect size. It should not contain result variable. > +typedef struct { > + codecvt_base base; > + /* FIXME: incomplete struct definition */ > +} codecvt_char_char_mbstate; It's better to define whole structure. Also other structures are named differently, it would be probably better to name it codecvt_char. > +typedef struct { > + codecvt_base base; > + /* FIXME: incomplete struct definition */ > +} codecvt_short_char_mbstate; > + > +typedef struct { > + codecvt_base base; > + /* FIXME: incomplete struct definition */ > +} codecvt_wchar_char_mbstate; There's no reason to define separate structures for unsigned short and wchar_t variants of the class. Probably the only difference between this classes is typeinfo structure. > +/* FIXME: Potentially unused */ > +/* ?id@?$codecvt@DDH@std@@2V0locale@2@A */ > +locale_id codecvt_char_char_mbstate_id = {0}; I don't understand this comment. The id fields will be used by locale class. > +/* ??1codecvt_base@std@@UAE@XZ */ > +/* ??1codecvt_base@std@@UEAA@XZ */ > +DEFINE_THISCALL_WRAPPER(codecvt_base_dtor, 4) > +void __thiscall codecvt_base_dtor(codecvt_base *this) > +{ > + FIXME("(%p)\n stub!", this); > + TRACE("(%p)\n", this); > +} There's no need to use both FIXME and TRACE. > +/* ??1?$codecvt@DDH@std@@MAE@XZ */ > +/* ??1?$codecvt@DDH@std@@MEAA@XZ */ > +DEFINE_THISCALL_WRAPPER(codecvt_char_char_mbstate_dtor, 4) > +void __thiscall codecvt_char_char_mbstate_dtor(codecvt_char_char_mbstate *this) > +{ > + /*FIXME stub*/ > + codecvt_base_dtor(&this->base); > + TRACE("(%p)\n", this); > +} It's better to print a fixme message here. > +DEFINE_RTTI_DATA(codecvt_char_char_mbstate, 0, 1,&locale_facet_rtti_base_descriptor, NULL, NULL, " ?AV?$codecvt@DDH@std@@"); > +DEFINE_RTTI_DATA(codecvt_short_char_mbstate, 0, 1,&locale_facet_rtti_base_descriptor, NULL, NULL, " ?AV?$codecvt@GDH@std@@"); > +DEFINE_RTTI_DATA(codecvt_wchar_char_mbstate, 0, 1,&locale_facet_rtti_base_descriptor, NULL, NULL, ".?AV?$codecvt@_WDH@std@@"); The RTTI data for these structures is incorrect. > + __ASM_VTABLE(codecvt_base, ""/*FIXME*/); > + __ASM_VTABLE(codecvt_char_char_mbstate, ""/*FIXME*/); > + __ASM_VTABLE(codecvt_short_char_mbstate, ""/*FIXME*/); > + __ASM_VTABLE(codecvt_wchar_char_mbstate, ""/*FIXME*/); It's better to create correct virtual functions table. This may lead to some strange crashes.

1 0

Re: [PATCH 1/3] browseui: Add IOleWindow to IProgressDialog
by Nikolay Sivov 15 Apr '12

15 Apr '12

On 4/15/2012 23:08, Detlef Riekenberg wrote: > Used by apps to adjust the dialog position > or remove the cancel button before vista > > -- > By by ... Detlef > --- > dlls/browseui/progressdlg.c | 69 ++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 68 insertions(+), 1 deletions(-) > > diff --git a/dlls/browseui/progressdlg.c b/dlls/browseui/progressdlg.c > index 9b970e2..2807622 100644 > --- a/dlls/browseui/progressdlg.c > +++ b/dlls/browseui/progressdlg.c > @@ -60,6 +60,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(browseui); > > typedef struct tagProgressDialog { > IProgressDialog IProgressDialog_iface; > + IOleWindow IOleWindow_iface; > LONG refCount; > CRITICAL_SECTION cs; > HWND hwnd; > @@ -79,6 +80,11 @@ static inline ProgressDialog *impl_from_IProgressDialog(IProgressDialog *iface) > return CONTAINING_RECORD(iface, ProgressDialog, IProgressDialog_iface); > } > > +static inline ProgressDialog *impl_from_IOleWindow(IOleWindow *iface) > +{ > + return CONTAINING_RECORD(iface, ProgressDialog, IOleWindow_iface); > +} > + > static void set_buffer(LPWSTR *buffer, LPCWSTR string) > { > static const WCHAR empty_string[] = {0}; > @@ -270,9 +276,20 @@ static HRESULT WINAPI ProgressDialog_QueryInterface(IProgressDialog *iface, REFI > ProgressDialog *This = impl_from_IProgressDialog(iface); > *ppvOut = NULL; > > - if (IsEqualIID(iid,&IID_IUnknown) || IsEqualIID(iid,&IID_IProgressDialog)) > + if (IsEqualIID(iid,&IID_IUnknown)) > { > *ppvOut = This; > + TRACE("(%p, IID_IUnknown, %p) -> %p\n", This, ppvOut, This); > + } > + else if (IsEqualIID(iid,&IID_IProgressDialog)) > + { > + *ppvOut = This; > + TRACE("(%p, IID_IProgressDialog, %p) -> %p\n", This, ppvOut, This); > + } > + else if (IsEqualIID(iid,&IID_IOleWindow)) > + { > + *ppvOut =&This->IOleWindow_iface; > + TRACE("(%p, IID_IOleWindow, %p) -> %p\n", This, ppvOut, *ppvOut); > } What's a point in different traces? A single one is enough, with printed riid of course. Also please return iface instead of This, like *ppvOut = iface;, or if you prefer instance pointer add a pointer to interface like - &This->... > > if (*ppvOut) > @@ -495,6 +512,55 @@ static const IProgressDialogVtbl ProgressDialogVtbl = > ProgressDialog_Timer > }; > > +static HRESULT WINAPI OleWindow_QueryInterface(IOleWindow *iface, REFIID iid, LPVOID *ppvOut) > +{ > + ProgressDialog *This = impl_from_IOleWindow(iface); > + > + TRACE("(%p, %s, %p)\n", iface, debugstr_guid(iid), ppvOut); > + return ProgressDialog_QueryInterface(&This->IProgressDialog_iface, iid, ppvOut); > +} > + This trace should go to ProgressDialog_QueryInterface(), no need to place it in every interface.

1 0

Re: ddraw/tests: Compare the correct surface pointers.
by Marvin 15 Apr '12

15 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17873 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00A70028) === WXPPROSP3 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00BA0028) === W2K3R2SESP2 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00E40028) === WVISTAADM (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02210028) === W2K8SE (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02800028) === W7PRO (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(01BF0028) === W7PROX64 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02740028) === TEST64_W7SP1 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02690028) === W7PROX64 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(0000000002390040) === TEST64_W7SP1 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(0000000002360040)

2 1

Re: [PATCH 1/3] browseui: Add IOleWindow to IProgressDialog
by Michael Stefaniuc 15 Apr '12

15 Apr '12

Hello Detlef, On 04/15/2012 10:08 PM, Detlef Riekenberg wrote: > Used by apps to adjust the dialog position > or remove the cancel button before vista > > -- > By by ... Detlef > --- > dlls/browseui/progressdlg.c | 69 ++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 68 insertions(+), 1 deletions(-) > > diff --git a/dlls/browseui/progressdlg.c b/dlls/browseui/progressdlg.c > index 9b970e2..2807622 100644 > --- a/dlls/browseui/progressdlg.c > +++ b/dlls/browseui/progressdlg.c > @@ -270,9 +276,20 @@ static HRESULT WINAPI ProgressDialog_QueryInterface(IProgressDialog *iface, REFI > ProgressDialog *This = impl_from_IProgressDialog(iface); > *ppvOut = NULL; > > - if (IsEqualIID(iid, &IID_IUnknown) || IsEqualIID(iid, &IID_IProgressDialog)) > + if (IsEqualIID(iid, &IID_IUnknown)) > { > *ppvOut = This; > + TRACE("(%p, IID_IUnknown, %p) -> %p\n", This, ppvOut, This); > + } > + else if (IsEqualIID(iid, &IID_IProgressDialog)) > + { > + *ppvOut = This; this is not correct as ppvOut takes an interface and not an object. While at it please fix the above one too. thanks bye michael

1 0

[GSoC] Reduce dependency on native dlls
by William Panlener 15 Apr '12

15 Apr '12

My name is William Panlener, and I am currently attending the University of Mississippi as a first semester Masters student in Computer Science. This is my first time participating in GSoC. My proposal for GSoC involves choosing an application with high dependence on native dlls and implementing enough stubs so as to eliminate this dependency. I chose the game, League of Legends, and its installer, Pando Media Booster. Most stubs that require implementation are in msvcp90 and wininet. I have two concerns with this proposal: 1) Is it unusual to work towards improving a specific application rather than focusing on a specific component of wine? 2) The scope of the project is difficult to gauge in advance since the next problematic stub cannot be identified until all the previous problematic stubs are taken care of. Is this an issue for a GSoC proposal? I would be more than willing to revise my proposal (if this is allowed) if either of the above points is a problem.

2 1

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)
by Dmitry Timoshkov 15 Apr '12

15 Apr '12

Daniel Jelinski <djelinski1(a)gmail.com> wrote: > Skipping tests on WinNT - older versions of comctl send a different > set of events. Then you need to figure out what is different, and make the tests pass there as well (there is 'optional' flag for that), otherwise you risk breaking applications written for NT. > + /* WM_RBUTTONDOWN does not return until it gets another mouse event. > + Make sure it gets one by posting WM_RBUTTONUP to message queue */ > + PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); > + /* this sequence should NOT send WM_CONTEXTMENU */ > + SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); > + > + /* ditch the first sequence as it processed more messages than we need. Redo */ > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); > + SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); This can't work. If you use PostMessage you need to flush message queue before testing the sequence. Using SendMessage after PostMessage doesn't guarantee that a posted message is handled before a sent one, you may try generating hardware messages instead. > + > + if(sequences[PARENT_SEQ_INDEX]->sequence->message == 0x133) > + { > + win_skip("Comctl32 versions prior to 5.80 send different set of events"); > + return; > + } Please use symbolic names for messages instead of magic numbers. -- Dmitry.

4 5

automate winedbg IDE integration
by Ilya Basin 15 Apr '12

15 Apr '12

Hi developers. There's a manual on this page: http://www.winehq.org/docs/winedev-guide/dbg-others > Start the Wine debugger with a command line like: > winedbg --gdb --no-start <name_of_exe_to_debug.exe> > Start ddd > In ddd, use the 'Open File' or 'Open Program' to point to the Wine executable (which is either wine-pthread or wine-kthread depending on your settings). > In the output of 1/, there's a line like > target remote localhost:32878 > copy that line and paste into ddd command pane (the one with the (gdb) prompt) So many steps. Is there an easier way? Or maybe everyone use plain winedbg without any IDE?

2 5

winedbg-eclipse - winedbg wrapper for Eclipse IDE
by Ilya Basin 14 Apr '12

14 Apr '12

- Get Eclipse 3.7.2 CDT - Import existing code as Makefile (a wine component or a standalone - winelib program) - Check "Automate discovery" in project properties/C/C++ Build/Discovery - Create a standart C/C++ Application debug configuration - Set *.exe.so as application - Set winedbg-eclipse as GDB debugger - fix bugs faster!

1 0

Re: Wine release 1.5.2
by mike＠yurick.ca 13 Apr '12

13 Apr '12

I am no longer using this e-mail. Please contact me for my new e-mail address. Thank you, Mike

1 0

Re: vbscript: Short if statement may have optional 'end if'
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17842 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

gdi32/dibdrv: don't add_join if points are coincident in wide_line_segments (try 2)
by Daniel Lehman 13 Apr '12

13 Apr '12

try 2 - integrate into existing tests; updated commit message I think the only points in the middle of the points array can cause the crash I was seeing. wide_pen_lines trims coincident points/empty segments from the beginning and end of the array, so the wine_line_segment calls before and after the for loop I modified will always return valid faces

1 0

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending. Resend.
by Vincent Povirk 13 Apr '12

13 Apr '12

I ran some of my drawing tests with GdipSetCompositingMode(graphics, CompositingModeSourceCopy), and it looks like native in that mode does roughly what your patch does, except that pixels that would be 100% transparent are not drawn. If a printer device behaves differently then that would be very strange. If it is the same, it probably makes sense to use (and maybe set at graphics creation time if it's appropriate for the HDC) the compositing mode flag. So I guess this is an acceptable approach, and could probably be committed as is and refined later, but it'd be nice if you could look into compositing modes and drawing with 100% transparent colors, since you have a test program set up for printing and I don't.

1 0

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (try 2) (resend)
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17840 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3drm: Implement IDirect3DRMFrameX_GetParent and update tests. (resend)
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17839 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (try 2) (resend)
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17835 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3drm: Implement IDirect3DRMFrameX_GetParent and update tests. (resend)
by Marvin 13 Apr '12

13 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17832 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Regression testing
by Daniel Jeliński 12 Apr '12

12 Apr '12

Hello all, I am trying to get Microsoft SQL Server Management Studio to work flawlessly under Wine. For the most part I create and triage related bug reports, but recently I also started tinkering with code, specifically with comctl library, which I am most familiar with. Back on subject. I thought I found a regression - on Wine 1.4 package downloaded from launchpad the "New query" button works fine, while on my compiled Wine it produces an error. So I did: git reset --hard wine-1.4 make and, surprisingly, I still had the problem with the compiled version. However after some combination of deleting leftover files, running make clean, make depend and make the button started working, so I started bisecting, hoping for the best. At some point I started getting bad versions, and every subsequent compile was bad - even after I ended bisecting and returned to wine-1.4, the button still did not work (and it still works under packaged Wine - I use the same install for all tests). This time make clean && make depend && make did not help. I am comparing what I did to [1], and the only difference I see is that I did not run configure before make. I'll try doing that later, but I think this shouldn't affect the outcome. Any other ideas? Also [1] suggests to set CC="ccache gcc -m32" on amd64 machines. I did that and when doing make I noticed that many lines start with: ccache gcc -m32 -m32 I guess that CC="ccache gcc" would be enough - but I didn't test that yet. Also I noticed that running parallel make (make -j) is never mentioned on [1]. Is there any reason I shouldn't use it? Daniel [1] http://wiki.winehq.org/RegressionTesting

5 6

Re: [PATCH 1/4] d3drm: Implement IDirect3DRMFrameX_AddChild. (try 2) (resend)
by Alexandre Julliard 12 Apr '12

12 Apr '12

Christian Costa <titan.costa(a)gmail.com> writes: > + children = (IDirect3DRMFrame3**)HeapAlloc(GetProcessHeap(), 0, (This->nb_children + 1) * sizeof(IDirect3DRMFrame3*)); > + if (!children) > + return E_OUTOFMEMORY; > + > + CopyMemory(children, This->children, This->nb_children * sizeof(IDirect3DRMFrame3*)); > + HeapFree(GetProcessHeap(), 0, This->children); HeapReAlloc is your friend. Also you should grow the buffer quadratically. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Add a test for creating named mapping after closing without unmapping.
by Dmitry Timoshkov 12 Apr '12

12 Apr '12

Alexander Morozov <amorozov(a)etersoft.ru> wrote: > + ptr = MapViewOfFile(mapping, FILE_MAP_WRITE, 0, 0, 0); > + ok( ptr != NULL, "MapViewOfFile failed with error %d\n", GetLastError() ); > + CloseHandle(mapping); > + > + SetLastError(0xdeadbeef); > + mapping = CreateFileMappingA(INVALID_HANDLE_VALUE, NULL, PAGE_READWRITE, 0, MAPPING_SIZE, name); > + ok( mapping != INVALID_HANDLE_VALUE, "CreateFileMappingA failed\n" ); It would be interesting to add OpenFileMapping before and after CloseHandle and test what it returns. -- Dmitry.

1 0

Re: [PATCH] d3drm: Implement IDirect3DRMFrameX_GetTransform.
by Marvin 12 Apr '12

12 Apr '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17814 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2012