wine-devel May 2012

wine-devel@winehq.org

67 participants
174 discussions

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.
by Vincent Povirk 14 May '12

14 May '12

> - GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0); > + GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0); You probably shouldn't use the same GpRect* for both parameters there.

2 3

Re: msxml3: avoid a dangling else (LLVM/Clang)
by Michael Stefaniuc 14 May '12

14 May '12

Hello Austin, On 05/14/2012 08:01 AM, Austin English wrote: > diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c > index 6805c75..14fd01b 100644 > --- a/dlls/msxml3/domdoc.c > +++ b/dlls/msxml3/domdoc.c > @@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML( > > /* skip leading spaces if needed */ > if (This->properties->version == MSXML_DEFAULT || This->properties->version == MSXML26) > + { > while (*ptr) > if (isspaceW(*ptr)) ptr++; else break; I do not mind terse code but that kinda overdoes it. I would put the "else" on a separate line. > + } > > xmldoc = doparse(This, (char*)ptr, strlenW(ptr)*sizeof(WCHAR), XML_CHAR_ENCODING_UTF16LE); > if ( !xmldoc ) bye michael

2 2

Re: wininet: Fixed typo in tests and accompanying implementation
by Marvin 14 May '12

14 May '12

1 0

Re: wininet/tests: fix a compiler warning on LLVM/Clang
by Jacek Caban 14 May '12

14 May '12

Hi Austin, On 05/14/12 08:19, Austin English wrote: > clang -c -I. -I. -I../../../include -I../../../include > -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT > -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits > -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith > -I/usr/include/freetype2 -g -O0 -std=gnu89 -o http.o http.c > http.c:212:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^ ~~~~~~~~~~~~~~~~~~~~~~ > http.c:212:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^~~~~~~~~~~~~~~~~~~~~~~~ > | > http.c:218:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > ^ > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > http.c:218:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Thanks for the patch. The problem found by those warnings was more serious as we were tested a wrong thing, causing the implementation to be wrong. That said, we need to fix tests and implementation as well. I've sent a patch. Thanks, Jacek

1 0

Re: wininet/tests: fix a compiler warning on LLVM/Clang
by Marvin 14 May '12

14 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18347 Your paranoid android. === WXPPROSP3 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W2K3R2SESP2 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === WVISTAADM (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W2K8SE (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PRO (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PROX64 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === TEST64_W7SP1 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PROX64 (64 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === TEST64_W7SP1 (64 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154)

1 0

Re: [2/2] msxml3: Support iso-8859-x encodings in writer
by Marvin 14 May '12

14 May '12

1 0

Re: jscript/tests: Fix the spelling of the testEmbeddedFunctions() function name.
by Marvin 13 May '12

13 May '12

1 0

Re: jscript/tests: Fix the spelling of the testEmbeddedFunctions() function name.
by Marvin 13 May '12

13 May '12

1 0

Using an IDE on Wine?
by Max TenEyck Woodbury 13 May '12

13 May '12

How many of you use an Integrated Development Environment (IDE) when working on Wine? If you do, which one do you use and how, how useful is it and how hard was it to set up? Max

4 3

re: Using an IDE on Wine?
by Dan Kegel 13 May '12

13 May '12

I suspect most people don't use IDEs with wine. Someone recently posted how to use eclipse during debugging, though: http://www.winehq.org/pipermail/wine-devel/2012-April/095162.html

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
18
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel May 2012